FCL/sf/app/browserui: comparison ginebra2/ContentViews/GWebContentViewWidget.cpp

equal deleted inserted replaced

-:b0dd75e285d2
+:0f2326c2a325
 /*
 * Copyright (c) 2010 Nokia Corporation and/or its subsidiary(-ies).
 * All rights reserved.
-* This component and the accompanying materials are made available
-* under the terms of "Eclipse Public License v1.0"
-* which accompanies this distribution, and is available
-* at the URL "http://www.eclipse.org/legal/epl-v10.html".
 *
-* Initial Contributors:
+* This program is free software: you can redistribute it and/or modify
-* Nokia Corporation - initial contribution.
+* it under the terms of the GNU Lesser General Public License as published by
+* the Free Software Foundation, version 2.1 of the License.
 *
-* Contributors:
+* This program is distributed in the hope that it will be useful,
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* GNU Lesser General Public License for more details.
 *
-* Description:
+* You should have received a copy of the GNU Lesser General Public License
+* along with this program.  If not,
+* see "http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html/".
+*
+* Description:
 *
 */
 #include "GWebContentViewWidget.h"
 #include "GWebContentView.h"
 #include "browserpagefactory.h"
 #include "webpagecontroller.h"
+#include "Utilities.h"
+#include "ChromeEffect.h"
 #include <QGraphicsSceneResizeEvent>
 #include <QGraphicsSceneContextMenuEvent>
 #include <QWebFrame>
 #include <QWebHitTestResult>
 #include <QStyleOptionGraphicsItem>
 #include <QDebug>
 #include <QGraphicsView>
 #ifdef ENABLE_PERF_TRACE
 #include "wrtperftracer.h"
-// Global reference to WrtPerfTracer
-extern WrtPerfTracer* g_wrtPerfTracing;
 #endif
 namespace GVA {
 const QString KViewPortWidthTag("width");
 GWebContentViewWidget::GWebContentViewWidget(QObject* parent, GWebContentView* view,QWebPage* pg) : QGraphicsWebView(0)
 , m_webContentView(view)
 , m_dirtyZoomFactor(1)
 , m_frozenPixmap(0)
-, m_freezeCount(0)
+, m_frozenCount(0)
 , m_wrtPage(0)
 , m_bitmapZoom(false)
-, m_pagePixmap(0)
 , m_isResize(false)
 , m_currentinitialScale(0)
 , m_previousViewPortwidth(size().toSize().width())
 , m_bitmapImage(NULL)
 , m_checkeredBoxPixmap(NULL)
 {
 qDebug() << "GWebContentViewWidget::GWebContentViewWidget: page=" << pg;
 setParent(parent);
-if( pg ) {
+if ( pg ) {
 setPage(pg);
 }
 #ifdef ENABLE_PERF_TRACE
-g_wrtPerfTracing->initPage(pg);
+WrtPerfTracer::tracer()->initPage(pg);
 #endif //ENABLE_PERF_TRACE
 m_currentinitialScale = zoomFactor();
 //connect(this->page()->mainFrame(), SIGNAL(initialLayoutCompleted()), this, SLOT(onInitLayout()));
 #ifndef NO_QSTM_GESTURE
 m_touchNavigation = new WebTouchNavigation(this);
 #endif
+// Fixes missing radio button problem with certain themes
+QPalette pal = palette();
+pal.setColor(QPalette::ButtonText,Qt::black);
+setPalette(pal);
 }
 GWebContentViewWidget::~GWebContentViewWidget()
 {
-if (m_bitmapImage)
+delete m_bitmapImage;
-delete m_bitmapImage;
+delete m_checkeredBoxPixmap;
-if (m_checkeredBoxPixmap)
+delete m_frozenPixmap;
-delete m_checkeredBoxPixmap;
 }
 void GWebContentViewWidget::updateViewport()
 {
 if (page() && size() != page()->viewportSize()) {
 page()->setViewportSize(size().toSize());
 }
 setViewportSize();
 }
-void GWebContentViewWidget::setBlockElement(QWebElement pt)
+void GWebContentViewWidget::setBlockElement(const QWebElement &pt)
 {
 m_BlockElement = pt;
 }
 void GWebContentViewWidget::setCheckeredPixmap()
 {
 delete m_checkeredBoxPixmap;
 m_checkeredBoxPixmap = NULL;
 int checkerPixmapSizeX = size().toSize().width();
 int checkerPixmapSizeY = size().toSize().height() + 50;
-m_checkeredBoxPixmap = new QPixmap(size().width(), size().height() + 50);
+m_checkeredBoxPixmap = new QPixmap(checkerSize, checkerSize);
 QPainter painter(m_checkeredBoxPixmap);
+painter.fillRect(0, 0, checkerSize, checkerSize, QColor(checkerColor1));
-for (int y = 0; y < checkerPixmapSizeY; y += checkerSize / 2) {
+painter.fillRect(0, checkerSize/2, checkerSize/2, checkerSize/2, QColor(checkerColor2));
-bool alternate = y % checkerSize;
+painter.fillRect(checkerSize/2, 0, checkerSize/2, checkerSize/2, QColor(checkerColor2));
-for (int x = 0; x < checkerPixmapSizeX; x += checkerSize / 2) {
-QColor color(alternate ? checkerColor1 : checkerColor2);
-painter.fillRect(x, y, checkerSize / 2, checkerSize / 2, color);
-alternate = !alternate;
-}
-}
 }
 void GWebContentViewWidget::createPageSnapShot()
 {
 bitmapZoomCleanup();
 void GWebContentViewWidget::bitmapZoomCleanup()
 {
 m_bitmapZoom = false;
 if (m_bitmapImage) {
-	    delete m_bitmapImage;
+delete m_bitmapImage;
-		m_bitmapImage = NULL;
+m_bitmapImage = NULL;
-	}
+}
+}
+void GWebContentViewWidget::updateFrozenImage() {
+// Take a snapshot for to be displayed while in frozen state.
+QStyleOptionGraphicsItem opt;
+opt.levelOfDetail = 1.0;
+opt.exposedRect = QRectF(QPointF(0,0), size());
+m_frozenPixmap = new QPixmap(opt.exposedRect.size().toSize());
+QPainter painter(m_frozenPixmap);
+paint(&painter, &opt);
+if(!isEnabled()) {
+// Disabled, apply whitewash.
+painter.setOpacity(ChromeEffect::disabledOpacity);
+painter.fillRect(opt.exposedRect, ChromeEffect::disabledColor);
+}
+painter.end();
 }
 QImage GWebContentViewWidget::getPageSnapshot()
 {
 QImage img(size().toSize(), QImage::Format_RGB32);
-if(!page()) return QImage();
+if (!page()) return QImage();
 QPainter painter(&img);
 QWebFrame *frame = page()->mainFrame();
 painter.fillRect(QRectF(0, 0, size().width(), size().height()), QColor(255, 255, 255));
 bool GWebContentViewWidget::event(QEvent * e) {
 if (e->type() == QEvent::Gesture) {
 #ifndef NO_QSTM_GESTURE
-		  QStm_Gesture* gesture = getQStmGesture(e, WebGestureHelper::getAssignedGestureType());
+QStm_Gesture* gesture = getQStmGesture(e, WebGestureHelper::getAssignedGestureType());
-		  if (gesture) {
+if (gesture) {
-			  m_touchNavigation->handleQStmGesture(gesture);
+m_touchNavigation->handleQStmGesture(gesture);
-			  return true;
+return true;
-		  }
+}
 #endif
 }
-else if(e->type() == WebPageControllerUpdateViewPortEvent::staticType()) {
+else if (e->type() == WebPageControllerUpdateViewPortEvent::staticType()) {
 updateViewport();
 }
 return QGraphicsWebView::event(e);
 }
 void GWebContentViewWidget::resizeEvent(QGraphicsSceneResizeEvent* e)
 {
 // set the fixed text layout size for text wrapping
 #if defined CWRTINTERNALWEBKIT
 if (page()) {
 p->m_webPage->settings()->setMaximumTextColumnWidth(e->newSize().width() - 6);
 }
 m_previousViewPortwidth = page()->viewportSize().width();
 const QSize &s = e->newSize().toSize();
 if (page() && s != page()->viewportSize()) {
-if(m_BlockElement.isNull()) {
+if (m_BlockElement.isNull()) {
 QPoint pos = QPoint(0,0);
 QWebFrame* frame = page()->frameAt(pos);
 frame = (frame) ? frame : page()->currentFrame();
 QWebHitTestResult htr = frame->hitTestContent(pos);
 m_BlockInFocus = htr.element();
-if(m_BlockInFocus.tagName() != "IMG")
+if (m_BlockInFocus.tagName() != "IMG")
 m_BlockInFocus = htr.enclosingBlockElement();
 QPoint position = m_BlockInFocus.geometry().topLeft() - page()->currentFrame()->scrollPosition();
 m_Ratiox = (qreal) position.x() / m_BlockInFocus.geometry().width();
 m_Ratioy = (qreal) position.y() / m_BlockInFocus.geometry().height();
 }
 page()->setViewportSize(s);
 }
 updateViewportSize(e);
+if(frozen())
+updateFrozenImage();
 }
 void GWebContentViewWidget::contextMenuEvent(::QGraphicsSceneContextMenuEvent *event) {
-qDebug() << "GWebContentViewWidget::contextMenuEvent: " << event;
+QWebHitTestResult hitTest = page()->currentFrame()->hitTestContent(event->pos().toPoint());
-QPoint p = mapFromGlobal(event->scenePos()).toPoint();
+qDebug() << "GWebContentViewWidget::contextMenuEvent:"
-QWebHitTestResult hitTest = page()->currentFrame()->hitTestContent(p);
+<< "\n\t pos=" << hitTest.pos()
+<< "\n\t linkUrl=" << hitTest.linkUrl()
+<< "\n\t imageUrl=" << hitTest.imageUrl();
 WebViewEventContext *context =
 new WebViewEventContext(view()->type(), hitTest);
-emit contextEvent(context);
+if (m_webContentView && m_webContentView->currentPageIsSuperPage()) {
+// Let the superpage handle the event.
+m_webContentView->currentSuperPage()->onContextEvent(context);
+}
+else {
+// Send the event directly.
+emit contextEvent(context);
+}
 event->accept();
 }
 void GWebContentViewWidget::setZoomFactor(qreal zoom)
 {
 setPageZoomFactor(zoom);
 }
 void GWebContentViewWidget::setPageZoomFactor(qreal zoom)
 {
-if(!page()) return;
+//not zooming if it's bookmark or historyview or not a page
+if (!page() ||
+	  	(m_webContentView->type() == "webView" &&
+m_webContentView->currentPageIsSuperPage()) )
+{
+return;
+}
 //qDebug() << __func__ << "Zoom " << zoom << "Max : " << m_maximumScale << "Min: " << m_minimumScale;
 if (zoom < m_minimumScale)
 zoom = m_minimumScale;
 else if (zoom > m_maximumScale)
 zoom = m_maximumScale;
 QPoint pos = QPoint(0,0);
-if(!m_isResize) {
+if (!m_isResize) {
 QWebFrame* frame = page()->frameAt(pos);
 frame = (frame) ? frame : page()->currentFrame();
 QWebHitTestResult htr = frame->hitTestContent(pos);
 m_BlockInFocus = htr.element();
-if(m_BlockInFocus.tagName() != "IMG")
+if (m_BlockInFocus.tagName() != "IMG")
 m_BlockInFocus = htr.enclosingBlockElement();
 QPoint position = m_BlockInFocus.geometry().topLeft() - page()->currentFrame()->scrollPosition();
 m_Ratiox = (qreal) position.x() / m_BlockInFocus.geometry().width();
 m_Ratioy = (qreal) position.y() / m_BlockInFocus.geometry().height();
 }
-if( m_dirtyZoomFactor != zoom ) {
+if ( m_dirtyZoomFactor != zoom ) {
 m_dirtyZoomFactor = zoom;
 }
 QGraphicsWebView::setZoomFactor( zoom );
-if(!m_BlockElement.isNull() && m_isResize) {
+if (!m_BlockElement.isNull() && m_isResize) {
 QPoint imageFocusPoint;
 QPoint m_focusedBlockPt = QPoint(m_BlockElement.geometry().topLeft()) - page()->mainFrame()->scrollPosition();
-if(m_BlockElement.tagName() != "IMG" && (m_BlockElement.styleProperty(QString("background-image"),QWebElement::InlineStyle) == ""))
+if (m_BlockElement.tagName() != "IMG" && (m_BlockElement.styleProperty(QString("background-image"),QWebElement::InlineStyle) == ""))
 page()->mainFrame()->scroll(m_focusedBlockPt.x() - KFocussPoint.x() , m_focusedBlockPt.y() - KFocussPoint.y());
 else {
-if((page()->viewportSize().width() - m_BlockElement.geometry().width()) > 0)
+if ((page()->viewportSize().width() - m_BlockElement.geometry().width()) > 0)
 imageFocusPoint.setX((page()->viewportSize().width() - m_BlockElement.geometry().width())/2);
 else
 imageFocusPoint.setX(0);
-if((page()->viewportSize().height() - m_BlockElement.geometry().height()) > 0)
+if ((page()->viewportSize().height() - m_BlockElement.geometry().height()) > 0)
 imageFocusPoint.setY((page()->viewportSize().height() - m_BlockElement.geometry().height())/2);
 else
 imageFocusPoint.setY(0);
 page()->mainFrame()->scroll(m_focusedBlockPt.x() - imageFocusPoint.x() ,
 }
 void GWebContentViewWidget::setDirtyZoomFactor(qreal zoom)
 {
-if( m_dirtyZoomFactor == zoom )
+if ( m_dirtyZoomFactor == zoom )
 return;
 m_dirtyZoomFactor = zoom;
 update();
 m_loadingTime.start();
 }
 void GWebContentViewWidget::onLoadFinished()
 {
+#ifdef NO_RESIZE_ON_LOAD
 m_inLoading = false;
 update();
+#endif
 }
 #ifdef NO_RESIZE_ON_LOAD
 void GWebContentViewWidget::paint(QPainter* painter, const QStyleOptionGraphicsItem* options, QWidget* widget)
 {
 QRect clipRect;
-if(options && !options->exposedRect.isEmpty())
+if (options && !options->exposedRect.isEmpty())
 clipRect = options->exposedRect.toRect();
 else
 {
 clipRect = geometry().toRect();
 clipRect.moveTo(0,0);
 }
+#ifdef ENABLE_PERF_TRACE
-painter->fillRect(clipRect, QColor(255, 255, 255));
+PERF_DEBUG() << "GWebContentViewWidget::paint: " << clipRect << "\n";
+unsigned int st = WrtPerfTracer::tracer()->startTimer();
+#endif
+//painter->fillRect(clipRect, QColor(255, 255, 255));
 if (!m_inLoading || !(m_loadingTime.elapsed() < 750)) {
 QGraphicsWebView::paint(painter, options, widget);
 }
+#ifdef ENABLE_PERF_TRACE
+PERF_DEBUG() << "GWebContentViewWidget::paint__end: " <<
+WrtPerfTracer::tracer()->elapsedTime(st) << "\n";
+#endif
 }
 #else //NO_RESIZE_ON_LOAD
 void GWebContentViewWidget::paint(QPainter* painter, const QStyleOptionGraphicsItem* option, QWidget* widget)
 {
+//    if (!m_active) return;
-//    if(!m_active) return;
+#ifdef ENABLE_PERF_TRACE
-if(m_freezeCount > 0) {
+PERF_DEBUG() << "GWebContentViewWidget::paint: " << option->exposedRect << "\n";
+unsigned int st = WrtPerfTracer::tracer()->startTimer();
+#endif
+//qDebug() << "GWebContentViewWidget::paint";
+if (frozen() && m_frozenPixmap) {
 // Frozen, paint the snapshot.
-painter->drawPixmap(0, 0, *m_frozenPixmap);
+painter->drawPixmap(option->exposedRect.topLeft(), *m_frozenPixmap, option->exposedRect);
 }
 else {
 if (m_bitmapZoom) {
+// Frozen ----
 qreal czf = 1;
 qreal zoomF = zoomFactor();
 if ( m_bitmapZoomFactor != zoomF )
 czf = m_bitmapZoomFactor/zoomF;
 painter->save();
-if (czf < 1)
+if (czf < 1) {
-painter->drawPixmap(QPoint(0,0), *m_checkeredBoxPixmap);
+if (!m_checkeredBoxPixmap) {
+setCheckeredPixmap();
+}
+QBrush brush(*m_checkeredBoxPixmap);
+painter->fillRect(0, 0, size().width(), size().height(), brush);
+}
 painter->drawImage(QRectF(0,0,size().width() * czf,size().height() * czf), *m_bitmapImage);
 painter->restore();
 }
+else if ( qAbs(zoomFactor() - m_dirtyZoomFactor) < 0.0001 )
-// Not frozen, do normal paint.
-else if( zoomFactor() == m_dirtyZoomFactor )
 {
+// Do normal paint. ----
 // Cannot use normal QGraphicsWebView paint because have to fill background with white for the phone build
 // QGraphicsWebView::paintEvent( event);
 // Commented the following line out to try to improve scrolling performance.  hab - 3/25/10
 //painter->fillRect(0, 0, size().width(), size().height(), QColor(255, 255, 255));
 //painter->fillRect(clipRect, QColor(255, 255, 255));
 QGraphicsWebView::paint(painter, option, widget);
 } else {
+// Do zooming paint. ----
 qreal czf = m_dirtyZoomFactor / zoomFactor();
 QWebFrame* frame = page()->mainFrame();
 painter->save();
 // Commented the following line out to try to improve scrolling performance.  hab - 3/25/10
-			//painter->fillRect(0, 0, size().width(), size().height(), QColor(255, 255, 255));
+//painter->fillRect(0, 0, size().width(), size().height(), QColor(255, 255, 255));
 QTransform transform;
 transform.scale(czf, czf);
 //            painter.translate(-transform.map(frame->scrollPosition()));
 QRegion clipRegion = QRect(QPoint(0,0), size().toSize());
-if(option && !option->exposedRect.isEmpty())
+if (option && !option->exposedRect.isEmpty())
 {
 clipRegion.intersect( option->exposedRect.toRect());
 }
 QTransform invert = transform.inverted();
 clipRegion = invert.map(clipRegion);
 frame->render(painter, clipRegion);
 painter->restore();
 }
 }
+#ifdef ENABLE_PERF_TRACE
+PERF_DEBUG() << "GWebContentViewWidget::paint__end: " <<
+WrtPerfTracer::tracer()->elapsedTime(st) << "\n";
+#endif
 }
 #endif //NO_RESIZE_ON_LOAD
+void GWebContentViewWidget::freeze() {
+if(m_frozenCount == 0) {
+updateFrozenImage();
+update();
+}
+m_frozenCount++;
+}
+void GWebContentViewWidget::unfreeze() {
+if(m_frozenCount > 0) {
+m_frozenCount--;
+if(m_frozenCount == 0){
+delete m_frozenPixmap;
+m_frozenPixmap = 0;
+update();
+}
+}
+}
 void GWebContentViewWidget::setPage(QWebPage* pg)
 {
-if(m_wrtPage == pg) return;
+if (m_wrtPage == pg) return;
 qDebug() << "GWebContentViewWidget::setPage: " << pg;
-if(m_wrtPage) {
+if (m_wrtPage) {
 disconnect(page()->mainFrame(), 0, this, 0);
 m_wrtPage->setView(0);
 }
 /* Reset the webview page as well - for its internal clean up */
 QGraphicsWebView::setPage(pg);
 m_wrtPage = pg;
-if(page()) {
-#ifndef NO_RESIZE_ON_LOAD
+// Call setViewportSize when the initial layout finishes unless pg is a super page.
+// Otherwise the superpage's zoom factor get set to its initialScale (0.6667).
+// This should be updated/removed when we start saving zoom factors on each page.
+if (page() && !m_webContentView->currentPageIsSuperPage()) {
+#ifndef NO_RESIZE_ON_LOAD
 connect(page()->mainFrame(), SIGNAL(initialLayoutCompleted()), this, SLOT(setViewportSize()));
 #endif
+//    setCacheMode(QGraphicsItem::DeviceCoordinateCache);
 }
 // setPage() above doesn't seem to trigger an update, do it explicitly.
 update();
 void GWebContentViewWidget::showNormalPage()
 {
 WRT::WrtBrowserContainer *wbc = WebPageController::getSingleton()->currentPage();
 setPage((QWebPage *)wbc);  // static_cast here gives compiler error
-}
-void GWebContentViewWidget::createPagePixmap()
-{
-if (m_pagePixmap)
-delete m_pagePixmap;
-m_pagePixmap = new QPixmap(size().toSize());
-QStyleOptionGraphicsItem op;
-QPainter p(m_pagePixmap);
-paint(&p,&op,0);
-p.end();
 }
 void GWebContentViewWidget::setBitmapZoom(qreal zoom)
 {
 if (!m_userScalable || zoom == zoomFactor())
 zoom = m_maximumScale;
 m_bitmapZoom = true;
 m_bitmapZoomFactor = zoom;
 update();
-}
-void GWebContentViewWidget::deletePagePixmap()
-{
-if (m_pagePixmap) {
-delete m_pagePixmap;
-m_pagePixmap = 0;
-}
-m_bitmapZoom = false;
 }
 void GWebContentViewWidget::setPageCenterZoomFactor(qreal zoom)
 {
 //calculating the center of the widget
 m_userScalable = true;
 m_inferWidthHeight = true;
 m_aspectRation = size().width() / size().height();
 #ifdef NO_RESIZE_ON_LOAD
 QSize sz = size().toSize();
 m_viewportWidth = sz.width();
 m_viewportHeight = sz.height();
 m_initialScale = 1.0;
 #else
 m_viewportWidth = KDefaultViewportWidth;
 m_viewportHeight = (int)size().height();
-if( size().width() < size().height())       //if Portrait
+if ( size().width() < size().height())       //if Portrait
 m_initialScale = size().width() / KDefaultPortraitScaleWidth;
 else
 m_initialScale = size().width() / KDefaultViewportWidth;
 #endif //NO_RESIZE_ON_LOAD
 m_minimumScale = m_initialScale;
 }
 /*!
 * Provides the default values - used when opening a new blank window
 /*!
 * Set the viewport Size
 */
 void GWebContentViewWidget::setViewportSize()
 {
-if(!page()) return;
+if (!page()) return;
 QWebFrame* frame = page()->mainFrame();
 initializeViewportParams();
 page()->setFixedContentsSize(QSize(m_viewportWidth, m_viewportHeight));
 #else
 page()->setPreferredContentsSize(QSize((int)m_viewportWidth, (int)m_viewportHeight));
 #endif
 #ifndef NO_RESIZE_ON_LOAD
 qreal zoomF = 0.0;
 QString str;
-if(m_isResize &&  (m_currentinitialScale != zoomFactor())) {
+if (m_isResize &&  (m_currentinitialScale != zoomFactor())) {
 zoomF = ((qreal)(page()->viewportSize().width()-10) * zoomFactor())/(m_previousViewPortwidth-10);
 str.setNum(zoomF,'f',2);
 zoomF = str.toDouble();
 setPageZoomFactor(zoomF);
 }
 setPageZoomFactor(m_initialScale);
 }
 m_BlockInFocus = QWebElement();
 m_currentinitialScale = m_initialScale;
 #endif //NO_RESIZE_ON_LOAD
-setCheckeredPixmap();
 // Let the page save the data. Even though it is part of the frame, it is easier to
 // save the info in the page to avoid parsing the meta data again.
-emit pageZoomMetaDataChange(frame, pageZoomMetaData());
+WrtBrowserContainer* pg = static_cast<WrtBrowserContainer*>(page());
+pg->setPageZoomMetaData(pageZoomMetaData());
 }
 qreal GWebContentViewWidget::initialScale()
 {
 return  m_initialScale;
 if (propertyName == KViewPortWidthTag) {
 if (propertyValue == KViewPortDeviceWidthTag) {
 m_viewportWidth = size().width();
 m_viewportHeight = m_viewportWidth * m_aspectRation;
 }
-else if(propertyValue == KViewPortDeviceHeightTag) {
+else if (propertyValue == KViewPortDeviceHeightTag) {
 m_viewportWidth = size().height();
 m_viewportHeight = m_viewportWidth * m_aspectRation;
 }
 else {
 m_viewportWidth = propertyValue.toInt();
 QPointF GWebContentViewWidget::mapToGlobal(const QPointF& p)
 {
 QList<QGraphicsView*> gvList = scene()->views();
 QList<QGraphicsView*>::iterator it;
-for(it = gvList.begin(); it != gvList.end(); it++)
+for (it = gvList.begin(); it != gvList.end(); it++)
 {
 if (static_cast<QGraphicsView*>(*it)->hasFocus())
 {
 QWidget* viewport = static_cast<QGraphicsView*>(*it)->viewport();
 return viewport->mapToGlobal(mapToScene(p).toPoint());
 QPointF GWebContentViewWidget::mapFromGlobal(const QPointF& p)
 {
 QList<QGraphicsView*> gvList = scene()->views();
 QList<QGraphicsView*>::iterator it;
-for(it = gvList.begin(); it != gvList.end(); it++)
+for (it = gvList.begin(); it != gvList.end(); it++)
 {
 if (static_cast<QGraphicsView*>(*it)->hasFocus())
 {
 QWidget* viewport = static_cast<QGraphicsView*>(*it)->viewport();
 return mapFromScene(viewport->mapFromGlobal(p.toPoint()));

changeset 5	0f2326c2a325
parent 0	1450b09d0cfd
child 6	1c3b8676e58c