# HG changeset patch # User Sebastian Brannstrom # Date 1288011787 -3600 # Node ID 2f62fe179bbba9e16f1a78ff33018b9fa39f2e55 # Parent 0d5e69a7cda9abc87e3ffedd8e6c67bf2d652363 For for a potential crash bug when a show URL does not contain a period diff -r 0d5e69a7cda9 -r 2f62fe179bbb engine/src/ShowEngine.cpp --- a/engine/src/ShowEngine.cpp Mon Oct 25 13:58:51 2010 +0100 +++ b/engine/src/ShowEngine.cpp Mon Oct 25 14:03:07 2010 +0100 @@ -198,13 +198,25 @@ TFileName fileName; PodcastUtils::FileNameFromUrl(info->Url(), fileName); - TFileName extension; - extension.Copy(fileName.Mid(fileName.LocateReverse('.'))); - DP1("extension=%S", &extension); - TFileName newFilename; - newFilename.Format(_L("%u%S"), info->Uid(), &extension); - DP1("newFilename=%S", &newFilename); + + TInt periodPos = fileName.LocateReverse('.'); + + if (periodPos != -1) + { + // file extension (most likely) found + TFileName extension; + extension.Copy(fileName.Mid(periodPos)); + DP1("extension=%S", &extension); + + newFilename.Format(_L("%u%S"), info->Uid(), &extension); + DP1("newFilename=%S", &newFilename); + } + else + { + // no extension found, we'll have to rely on magic numbers + newFilename.Copy(fileName); + } relPath.Append(newFilename); PodcastUtils::EnsureProperPathName(relPath);