# HG changeset patch
# User Heikki Lahtinen <heikki.a.lahtinen@nokia.com>
# Date 1265974984 0
# Node ID 62bf59ab417f4113b8526c51eb2341d7b460c1bb
# Parent  3034dfa79906999fad34a1cb6c2a4de8db827634
Fix for Bug 1815

diff -r 3034dfa79906 -r 62bf59ab417f ncdengine/provider/server/inc/ncdfavoritemanagerimpl.h
--- a/ncdengine/provider/server/inc/ncdfavoritemanagerimpl.h	Fri Feb 12 11:36:35 2010 +0000
+++ b/ncdengine/provider/server/inc/ncdfavoritemanagerimpl.h	Fri Feb 12 11:43:04 2010 +0000
@@ -107,9 +107,93 @@
     virtual void CounterPartLost(
         const MCatalogsSession& aSession );
     
+private:
+
+    /**
+     * CNcdClientFavorites object encapsulates the favorite identifiers of one
+     * client.
+     */
+    class CNcdClientFavorites : public CBase,
+                                public MNcdStorageDataItem
+        {
+    public:
+        static CNcdClientFavorites* NewLC( const TUid& aClientUid );
+        ~CNcdClientFavorites();
+        
+        TUid ClientUid() const;
+        void AddFavoriteL( CNcdNodeIdentifier* aNodeIdentifier );
+        void RemoveFavorite( const CNcdNodeIdentifier& aNodeIdentifier );
+        void RemoveFavorites();
+        void SetDisclaimerL(
+            const CNcdNodeIdentifier& aNodeIdentifier,
+            const CNcdNodeDisclaimer& aDisclaimer );
+        void RemoveDisclaimer( const CNcdNodeIdentifier& aNodeIdentifier );
+        CNcdNodeDisclaimer* Disclaimer(
+            const CNcdNodeIdentifier& aNodeIdentifier ) const;
+            
+        TBool HasFavorite( const CNcdNodeIdentifier& aNodeIdentifier ) const;
+        
+        const RPointerArray<CNcdNodeIdentifier>& Identifiers() const;
+        void ExternalizeIdentifiersL( RWriteStream& aStream ) const;
+                
+    public: // from MNcdStorageDataItem
+
+        /* 
+        * @see MNcdStorageDataItem::ExternalizeL
+        */
+        virtual void ExternalizeL( RWriteStream& aStream );
+
+        /* 
+        * @see MNcdStorageDataItem::InternalizeL
+        */
+        virtual void InternalizeL( RReadStream& aStream );
+        
+    protected:
+        CNcdClientFavorites( const TUid& aClientUid );
+        void CloseDisclaimers();
+        
+    private: 
+        
+        // Node identifiers.
+        RPointerArray<CNcdNodeIdentifier> iIdentifiers;
+        // Node disclaimers. A disclaimer at index 'i' is disclaimer of the node at
+        // the same index.
+        RPointerArray<CNcdNodeDisclaimer> iDisclaimers;
+        
+        // Client uid.
+        TUid iClientUid;
+        };
+        
+        
+    class CNcdTemporaryFavorites : public CBase 
+        {
+    public: // public functions
+        CNcdTemporaryFavorites( MCatalogsSession& aSession );
+        ~CNcdTemporaryFavorites();
+        
+        
+    public: // member variables
+        MCatalogsSession& iSession;
+        RPointerArray<CNcdNodeIdentifier> iFavoriteIdentifiers;
+        };
+        
+    CNcdGeneralManager& iGeneralManager;
+    
+    // Node manager.        
+    CNcdNodeManager& iNodeManager;
+    
+    // Favorite nodes of all the clients.
+    RPointerArray<CNcdClientFavorites> iFavorites;
+    
+    // Temp favorite mappings.
+    RPointerArray<CNcdTemporaryFavorites> iTempFavorites;
+    
+    // Storage manager.
+    MNcdStorageManager& iStorageManager;       
+    
 protected:
 
-    class CNcdClientFavorites;
+    //class CNcdClientFavorites;
     class CNcdTemporaryFavorites;
     
     CNcdFavoriteManager( CNcdGeneralManager& aGeneralManager );
@@ -234,89 +318,6 @@
     void DbSaveFavoritesL( CNcdClientFavorites& aFavorites );    
     
     
-private:
-
-    /**
-     * CNcdClientFavorites object encapsulates the favorite identifiers of one
-     * client.
-     */
-    class CNcdClientFavorites : public CBase,
-                                public MNcdStorageDataItem
-        {
-    public:
-        static CNcdClientFavorites* NewLC( const TUid& aClientUid );
-        ~CNcdClientFavorites();
-        
-        TUid ClientUid() const;
-        void AddFavoriteL( CNcdNodeIdentifier* aNodeIdentifier );
-        void RemoveFavorite( const CNcdNodeIdentifier& aNodeIdentifier );
-        void RemoveFavorites();
-        void SetDisclaimerL(
-            const CNcdNodeIdentifier& aNodeIdentifier,
-            const CNcdNodeDisclaimer& aDisclaimer );
-        void RemoveDisclaimer( const CNcdNodeIdentifier& aNodeIdentifier );
-        CNcdNodeDisclaimer* Disclaimer(
-            const CNcdNodeIdentifier& aNodeIdentifier ) const;
-            
-        TBool HasFavorite( const CNcdNodeIdentifier& aNodeIdentifier ) const;
-        
-        const RPointerArray<CNcdNodeIdentifier>& Identifiers() const;
-        void ExternalizeIdentifiersL( RWriteStream& aStream ) const;
-                
-    public: // from MNcdStorageDataItem
-
-        /* 
-        * @see MNcdStorageDataItem::ExternalizeL
-        */
-        virtual void ExternalizeL( RWriteStream& aStream );
-
-        /* 
-        * @see MNcdStorageDataItem::InternalizeL
-        */
-        virtual void InternalizeL( RReadStream& aStream );
-        
-    protected:
-        CNcdClientFavorites( const TUid& aClientUid );
-        void CloseDisclaimers();
-        
-    private: 
-        
-        // Node identifiers.
-        RPointerArray<CNcdNodeIdentifier> iIdentifiers;
-        // Node disclaimers. A disclaimer at index 'i' is disclaimer of the node at
-        // the same index.
-        RPointerArray<CNcdNodeDisclaimer> iDisclaimers;
-        
-        // Client uid.
-        TUid iClientUid;
-        };
-        
-        
-    class CNcdTemporaryFavorites : public CBase 
-        {
-    public: // public functions
-        CNcdTemporaryFavorites( MCatalogsSession& aSession );
-        ~CNcdTemporaryFavorites();
-        
-        
-    public: // member variables
-        MCatalogsSession& iSession;
-        RPointerArray<CNcdNodeIdentifier> iFavoriteIdentifiers;
-        };
-        
-    CNcdGeneralManager& iGeneralManager;
-    
-    // Node manager.        
-    CNcdNodeManager& iNodeManager;
-    
-    // Favorite nodes of all the clients.
-    RPointerArray<CNcdClientFavorites> iFavorites;
-    
-    // Temp favorite mappings.
-    RPointerArray<CNcdTemporaryFavorites> iTempFavorites;
-    
-    // Storage manager.
-    MNcdStorageManager& iStorageManager;       
 };
 
 #endif