FCL/sf/mw/qtextensions: comparison qtmobility/src/serviceframework/servicedatabase.cpp

equal deleted inserted replaced

-:2b40d63a9c3d
+:90517678cc4f
 **
 ** $QT_END_LICENSE$
 **
 ****************************************************************************/
-//#define QT_SFW_SERVICEDATABASE_DEBUG
+// #define QT_SFW_SERVICEDATABASE_DEBUG
 #include "servicedatabase_p.h"
 #include <QDir>
 #include <QSet>
 #include "qserviceinterfacedescriptor.h"
 if (!database.isOpen()) {
 if(!database.open()) {
 m_lastError.setError(DBError::SqlError, database.lastError().text());
 #ifdef QT_SFW_SERVICEDATABASE_DEBUG
 qWarning() << "ServiceDatabase::open():-"
-<< "Problem:" << "Could not open database"
+<< "Problem:" << "Could not open database. "
-<< "\nReason:" << m_lastError.text();
+<< "Reason:" << m_lastError.text();
 #endif
 close();
 return false;
 }
 }
 //bool ServiceDatabase::registerService(ServiceMetaData &service)
 bool ServiceDatabase::registerService(const ServiceMetaDataResults &service, const QString &securityToken)
 {
 #ifndef QT_SFW_SERVICEDATABASE_USE_SECURITY_TOKEN
 Q_UNUSED(securityToken);
+#else
+if (securityToken.isEmpty()) {
+QString errorText("Access denied, no security token provided (for registering service: \"%1\")");
+m_lastError.setError(DBError::NoWritePermissions, errorText.arg(service.name));
+#ifdef QT_SFW_SERVICEDATABASE_DEBUG
+qWarning() << "ServiceDatabase::registerService():-"
+<< "Problem: Unable to register service,"
+<< "reason:" << qPrintable(m_lastError.text());
+#endif
+return false;
+}
 #endif
 if(!checkConnection()) {
 #ifdef QT_SFW_SERVICEDATABASE_DEBUG
 qWarning() << "ServiceDatabase::registerService():-"
 QSqlQuery query(database);
 if (!beginTransaction(&query, Write)) {
 #ifdef QT_SFW_SERVICEDATABASE_DEBUG
 qWarning() << "ServiceDatabase::registerService():-"
-<< "Unable to begin transaction"
+<< "Unable to begin transaction,"
-<< "\nReason:" << qPrintable(m_lastError.text());
+<< "reason:" << qPrintable(m_lastError.text());
 #endif
 return false;
 }
 //See if the service's location has already been previously registered
 QString statement("SELECT Name from Service WHERE Location=? COLLATE NOCASE");
 #endif
 return false;
 }
 #ifdef QT_SFW_SERVICEDATABASE_USE_SECURITY_TOKEN
-statement = "SELECT Value FROM ServiceProperty WHERE ServiceID = ? AND Key = ?";
+// If service(s) have already been registered with same name, they must all come from
+// same application. Fetch a service with given name and if such exists, check that its
+// security ID equals to the security ID of the current registrar.
+// One application may register multiple services with same name (different location),
+// hence the keyword DISTINCT.
+statement = "SELECT DISTINCT ServiceProperty.Value FROM Service, ServiceProperty "
+"WHERE Service.ID = ServiceProperty.ServiceID "
+"AND ServiceProperty.Key = ? "
+"AND Service.Name = ?";
 bindValues.clear();
+bindValues.append(SECURITY_TOKEN_KEY);
 bindValues.append(service.name);
-bindValues.append(SECURITY_TOKEN_KEY);
+if (!executeQuery(&query, statement, bindValues)) {
-if(!executeQuery(&query, statement, bindValues)) {
 rollbackTransaction(&query);
 #ifdef QT_SFW_SERVICEDATABASE_DEBUG
 qWarning() << "ServiceDatabase::registerService():-"
 << qPrintable(m_lastError.text());
 #endif
 return false;
 }
+QString existingSecurityToken;
-QStringList securityTokens;
+if (query.next()) {
-while(query.next()) {
+existingSecurityToken = query.value(EBindIndex).toString();
-securityTokens << query.value(EBindIndex).toString();
+}
-}
+if (!existingSecurityToken.isEmpty() && (existingSecurityToken != securityToken)) {
-if (!securityTokens.isEmpty() && securityTokens.first() != securityToken) {
 QString errorText("Access denied: \"%1\"");
 m_lastError.setError(DBError::NoWritePermissions, errorText.arg(service.name));
 rollbackTransaction(&query);
 #ifdef QT_SFW_SERVICEDATABASE_DEBUG
 qWarning() << "ServiceDatabase::registerService():-"
-<< "Problem: Unable to register service"
+<< "Problem: Unable to register service,"
-<< "\nReason:" << qPrintable(m_lastError.text());
+<< "reason:" << qPrintable(m_lastError.text());
 #endif
 return false;
 }
-#endif
+#endif // QT_SFW_SERVICEDATABASE_USE_SECURITY_TOKEN
+// Checks done, create new rows into tables.
 statement = "INSERT INTO Service(ID,Name,Location) VALUES(?,?,?)";
 QString serviceID = QUuid::createUuid().toString();
 bindValues.clear();
 bindValues.append(serviceID);
 #endif
 return false;
 }
 #ifdef QT_SFW_SERVICEDATABASE_USE_SECURITY_TOKEN
-if (securityTokens.isEmpty()) {
+// Insert a security token for the particular service
 statement = "INSERT INTO ServiceProperty(ServiceID,Key,Value) VALUES(?,?,?)";
 bindValues.clear();
-bindValues.append(service.name);
+bindValues.append(serviceID);
 bindValues.append(SECURITY_TOKEN_KEY);
 bindValues.append(securityToken);
 if (!executeQuery(&query, statement, bindValues)) {
 rollbackTransaction(&query);
 #ifdef QT_SFW_SERVICEDATABASE_DEBUG
 qWarning() << "ServiceDatabase::registerService():-"
 << qPrintable(m_lastError.text());
 #endif
 return false;
 }
-}
+#endif // QT_SFW_SERVICEDATABASE_USE_SECURITY_TOKEN
-#endif
 QList <QServiceInterfaceDescriptor> interfaces = service.interfaces;
 QString interfaceID;;
 foreach (const QServiceInterfaceDescriptor &interface, interfaces) {
 interfaceID = getInterfaceID(&query, interface);
 return QString();
 }
 if (!query->next()) {
 QString errorText("No Interface Descriptor found with "
-"\nService name: %1 "
+"Service name: %1 "
-"\nInterface name: %2 "
+"Interface name: %2 "
-"\nVersion: %3.%4");
+"Version: %3.%4");
 m_lastError.setError(DBError::NotFound, errorText.arg(interface.serviceName())
 .arg(interface.interfaceName())
 .arg(interface.majorVersion())
 .arg(interface.minorVersion()));
 return QString();
 success = query->exec();
 if (!success) {
 QString errorText;
 errorText = "Problem: Could not %1 statement: %2"
-"\nReason: %3"
+"Reason: %3"
-"\nParameters: %4\n";
+"Parameters: %4\n";
 QString parameters;
 if (bindValues.count() > 0) {
 for(int i = 0; i < bindValues.count(); ++i) {
 parameters.append(QString("\n\t[") + QString::number(i) + "]: " + bindValues.at(i).toString());
 }
 //multiple read queries are performed so wrap them
 //in a read only transaction
 if (!beginTransaction(&query, Read)) {
 #ifdef QT_SFW_SERVICEDATABASE_DEBUG
 qWarning() << "ServiceDatabase::getInterfaces():-"
-<< "Unable to begin transaction:"
+<< "Unable to begin transaction. "
-<< "\nReason:" << qPrintable(m_lastError.text());
+<< "Reason:" << qPrintable(m_lastError.text());
 #endif
 return interfaces;
 }
 //Prepare search query, bind criteria values
 QSqlQuery query(database);
 if (!beginTransaction(&query, Read)) {
 #ifdef QT_SFW_SERVICEDATABASE_DEBUG
 qWarning() << "ServiceDatabase::getInterface():-"
-<< "Unable to begin transaction"
+<< "Unable to begin transaction. "
-<< "\nReason:" << qPrintable(m_lastError.text());
+<< "Reason:" << qPrintable(m_lastError.text());
 #endif
 return interface;
 }
 QString selectComponent = "SELECT Interface.Name, "
 QSqlQuery query(database);
 if (!inTransaction && !beginTransaction(&query, Read)) {
 #ifdef QT_SFW_SERVICEDATABASE_DEBUG
 qWarning() << "ServiceDatabase::interfaceDefault(QString, QString):-"
-<< "Unable to begin transaction"
+<< "Unable to begin transaction. "
-<< "\nReason:" << qPrintable(m_lastError.text());
+<< "Reason:" << qPrintable(m_lastError.text());
 #endif
 return interface;
 }
 QString statement("SELECT InterfaceID FROM Defaults WHERE InterfaceName = ? COLLATE NOCASE");
 //Begin Transaction
 if(!beginTransaction(&query, Write)) {
 #ifdef QT_SFW_SERVICEDATABASE_DEBUG
 qWarning() << "ServiceDatabase::setInterfaceDefault(QServiceInterfaceDescriptor):-"
-<< "Problem: Unable to begin transaction"
+<< "Problem: Unable to begin transaction."
-<< "\nReason:" << qPrintable(m_lastError.text());
+<< "Reason:" << qPrintable(m_lastError.text());
 #endif
 return false;
 }
 QString statement;
 .arg(interface.serviceName()));
 rollbackTransaction(&query);
 #ifdef QT_SFW_SERVICEDATABASE_DEBUG
 qWarning() << "ServiceDatbase::setInterfaceDefault(QServiceInterfaceDescriptor):-"
-<< "Problem: Unable to set default service"
+<< "Problem: Unable to set default service. "
-<< "\nReason:" << qPrintable(m_lastError.text());
+<< "Reason:" << qPrintable(m_lastError.text());
 #endif
 return false;
 }
 interfaceID = query.value(EBindIndex).toString();
 DBError::InvalidDatabaseConnection
 DBError::NoWritePermissions
 DBError::InvalidDatabaseFile
 */
 bool ServiceDatabase::unregisterService(const QString &serviceName, const QString &securityToken)
 {
 #ifndef QT_SFW_SERVICEDATABASE_USE_SECURITY_TOKEN
 Q_UNUSED(securityToken);
-#endif
+#else
+if (securityToken.isEmpty()) {
+QString errorText("Access denied, no security token provided (for unregistering service: \"%1\")");
+m_lastError.setError(DBError::NoWritePermissions, errorText.arg(serviceName));
+#ifdef QT_SFW_SERVICEDATABASE_DEBUG
+qWarning() << "ServiceDatabase::unregisterService():-"
+<< "Problem: Unable to unregister service. "
+<< "Reason:" << qPrintable(m_lastError.text());
+#endif
+return false;
+}
+#endif
 if (!checkConnection()) {
 #ifdef QT_SFW_SERVICEDATABASE_DEBUG
 qWarning() << "ServiceDatabase::unregisterService():-"
 << "Problem:" << qPrintable(m_lastError.text());
 QSqlQuery query(database);
 if(!beginTransaction(&query, Write)) {
 #ifdef QT_SFW_SERVICEDATABASE_DEBUG
 qWarning() << "ServiceDatabase::unregisterService():-"
-<< "Problem: Unable to begin transaction"
+<< "Problem: Unable to begin transaction. "
-<< "\nReason:" << qPrintable(m_lastError.text());
+<< "Reason:" << qPrintable(m_lastError.text());
 #endif
 return false;
 }
 QString statement("SELECT Service.ID from Service WHERE Service.Name = ? COLLATE NOCASE");
 QStringList serviceIDs;
 while(query.next()) {
 serviceIDs << query.value(EBindIndex).toString();
 }
 #ifdef QT_SFW_SERVICEDATABASE_USE_SECURITY_TOKEN
-statement = "SELECT Value FROM ServiceProperty WHERE ServiceID = ? AND Key = ?";
+// Only the application that registered the service is allowed to unregister that
-bindValues.clear();
+// service. Fetch a security ID of a service (with given name) and verify that it matches
-bindValues.append(serviceName);
+// with current apps security id. Only one application is allowed to register services with
-bindValues.append(SECURITY_TOKEN_KEY);
+// same name, hence a distinct (just any of the) security token will do because they are identical.
-if(!executeQuery(&query, statement, bindValues)) {
+if (!serviceIDs.isEmpty()) {
-rollbackTransaction(&query);
+statement = "SELECT DISTINCT Value FROM ServiceProperty WHERE ServiceID = ? AND Key = ?";
-#ifdef QT_SFW_SERVICEDATABASE_DEBUG
+bindValues.clear();
-qWarning() << "ServiceDatabase::unregisterService():-"
+bindValues.append(serviceIDs.first());
-<< qPrintable(m_lastError.text());
+bindValues.append(SECURITY_TOKEN_KEY);
-#endif
-return false;
+if (!executeQuery(&query, statement, bindValues)) {
-}
+rollbackTransaction(&query);
+#ifdef QT_SFW_SERVICEDATABASE_DEBUG
-QStringList securityTokens;
+qWarning() << "ServiceDatabase::unregisterService():-"
-while(query.next()) {
+<< qPrintable(m_lastError.text());
-securityTokens << query.value(EBindIndex).toString();
+#endif
-}
+return false;
+}
-if (!securityTokens.isEmpty() && (securityTokens.first() != securityToken)) {
+QString existingSecurityToken;
-QString errorText("Access denied: \"%1\"");
+if (query.next()) {
-m_lastError.setError(DBError::NoWritePermissions, errorText.arg(serviceName));
+existingSecurityToken = query.value(EBindIndex).toString();
-rollbackTransaction(&query);
+}
-#ifdef QT_SFW_SERVICEDATABASE_DEBUG
+if (existingSecurityToken != securityToken) {
-qWarning() << "ServiceDatabase::unregisterService():-"
+QString errorText("Access denied: \"%1\"");
-<< "Problem: Unable to unregister service"
+m_lastError.setError(DBError::NoWritePermissions, errorText.arg(serviceName));
-<< "\nReason:" << qPrintable(m_lastError.text());
+rollbackTransaction(&query);
-#endif
+#ifdef QT_SFW_SERVICEDATABASE_DEBUG
-}
+qWarning() << "ServiceDatabase::unregisterService():-"
+<< "Problem: Unable to unregister service"
-#endif
+<< "Reason:" << qPrintable(m_lastError.text());
+#endif
+return false;
+}
+}
+#endif // QT_SFW_SERVICEDATABASE_USE_SECURITY_TOKEN
 statement = "SELECT Interface.ID from Interface, Service "
 "WHERE Interface.ServiceID = Service.ID "
 "AND Service.Name =? COLLATE NOCASE";
 bindValues.clear();
 bindValues.append(serviceName);
 m_lastError.setError(DBError::NotFound, errorText.arg(serviceName));
 rollbackTransaction(&query);
 #ifdef QT_SFW_SERVICEDATABASE_DEBUG
 qWarning() << "ServiceDatabase::unregisterService():-"
 << "Problem: Unable to unregister service"
-<< "\nReason:" << qPrintable(m_lastError.text());
+<< "Reason:" << qPrintable(m_lastError.text());
 #endif
 return false;
 }
 statement = "SELECT Defaults.InterfaceName "
 #endif
 return false;
 }
 }
-#ifndef QT_SFW_SERVICEDATABASE_USE_SECURITY_TOKEN
 statement = "DELETE FROM ServiceProperty WHERE ServiceID = ?";
-#else
-statement = "DELETE FROM ServiceProperty WHERE ServiceID = ? AND Key <> ?";
-#endif
 foreach(const QString &serviceID, serviceIDs) {
 bindValues.clear();
 bindValues.append(serviceID);
-#ifdef QT_SFW_SERVICEDATABASE_USE_SECURITY_TOKEN
-bindValues.append(SECURITY_TOKEN_KEY);
-#endif
 if (!executeQuery(&query, statement, bindValues)) {
 rollbackTransaction(&query);
 #ifdef QT_SFW_SERVICEDATABASE_DEBUG
 qWarning() << "ServiceDatabase::unregisterService():-"
 << qPrintable(m_lastError.text());
 */
 QString ServiceDatabase::databasePath() const
 {
 QString path;
 if(m_databasePath.isEmpty()) {
+#if (defined(Q_OS_SYMBIAN) && defined(__WINS__))
+// On Symbian, database location never changes. On emulator it is fixed
+// and on hardware it is relative to the db managers private directory.
+path = QDir::toNativeSeparators("C:\\Data\\temp\\QtServiceFW");
+#elif defined(Q_OS_SYMBIAN)
+QString qtVersion(qVersion());
+qtVersion = qtVersion.left(qtVersion.size() -2); //strip off patch version
+path = QDir::toNativeSeparators(QCoreApplication::applicationDirPath() +
+"\\Nokia\\" + "QtServiceFramework_" +
+qtVersion + "_system" +
+QLatin1String(".db"));
+#else
 QSettings settings(QSettings::SystemScope, "Nokia", "Services");
 path = settings.value("ServicesDB/Path").toString();
 if (path.isEmpty()) {
 path = QDir::currentPath();
 if (path.lastIndexOf(RESOLVERDATABASE_PATH_SEPARATOR) != path.length() -1) {
 path.append(RESOLVERDATABASE_PATH_SEPARATOR);
 }
 path.append(RESOLVERDATABASE);
 }
 path = QDir::toNativeSeparators(path);
+#endif
 } else {
 path = m_databasePath;
 }
 return path;
 //Begin Transaction
 if (!beginTransaction(&query, Write)) {
 #ifdef QT_SFW_SERVICEDATABASE_DEBUG
 qWarning() << "ServiceDatabase::createTables():-"
-<< "Unable to begin transaction"
+<< "Unable to begin transaction. "
-<< "\nReason:" << qPrintable(m_lastError.text());
+<< "Reason:" << qPrintable(m_lastError.text());
 #endif
 return false;
 }
 QString statement("CREATE TABLE Service("
 //begin transaction
 if (!beginTransaction(&query, Write)) {
 #ifdef QT_SFW_SERVICEDATABASE_DEBUG
 qWarning() << "ServiceDatabase::removeExternalDefaultServiceInterface():-"
-<< "Problem: Unable to begin transaction"
+<< "Problem: Unable to begin transaction. "
-<< "\nReason:" << qPrintable(m_lastError.text());
+<< "Reason:" << qPrintable(m_lastError.text());
 #endif
 return false;
 }
 QString statement("SELECT Name FROM Interface WHERE Interface.ID = ?");
 if (database.tables().count() > 0) {
 if (!beginTransaction(&query, Write)) {
 #ifdef QT_SFW_SERVICEDATABASE_DEBUG
 qWarning() << "ServiceDatabase::dropTables():-"
-<< "Unable to begin transaction"
+<< "Unable to begin transaction. "
-<< "\nReason:" << qPrintable(m_lastError.text());
+<< "Reason:" << qPrintable(m_lastError.text());
 #endif
 return false;
 }
 QStringList actualTables = database.tables();
-foreach(QString expectedTable, expectedTables) {
+foreach(const QString expectedTable, expectedTables) {
 if ((actualTables.contains(expectedTable))
 && (!executeQuery(&query, QString("DROP TABLE ") + expectedTable))) {
 rollbackTransaction(&query);
 #ifdef QT_SFW_SERVICEDATABASE_DEBUG
 qWarning() << "ServiceDatabase::dropTables():-"

changeset 4	90517678cc4f
parent 1	2b40d63a9c3d
child 8	71781823f776