=== Safari-111 ===

2003-10-22  Maciej Stachowiak  <mjs@apple.com>

        Fix broken build.

        * kjs/simple_number.h:

2003-10-22  Maciej Stachowiak  <mjs@apple.com>

	Merged 64-bit compilation fixes, and fixes for handling negative 0

	from upstream kjs.

        * kjs/internal.cpp:

        * kjs/simple_number.h:

        (KJS::SimpleNumber): fixed constants; added negZero constant. 

        (KJS::SimpleNumber::is): adjusted to use long and not int.

        (KJS::SimpleNumber::value): ditto.

	(KJS::SimpleNumber::fits): ditto; also don't allow -0 to fit, so

	we don't lose the distinction between -0 and +0.

        (KJS::SimpleNumber::make): adjusted to use long.

2003-10-18  Darin Adler  <darin@apple.com>

        Reviewed by Dave.

        - fixed 3367015 -- interdependent variable declarations in for loop don't work (they go backwards)

        * kjs/nodes.h: (KJS::ForNode::ForNode): Add a new overload of the constructor for when the

        first parameter is a variable declaration list. Call reverseList as we do in other constructors

        that take lists that are built backwards.

        * kjs/nodes.cpp: (ForNode::reverseList): Added. New helper function.

=== Safari-110 ===

=== Safari-109 ===

2003-10-06  Darin Adler  <darin@apple.com>

        * kjs/create_hash_table: Remove stray semicolon.

        * kjs/array_object.lut.h:

        * kjs/date_object.lut.h:

        * kjs/lexer.lut.h:

        * kjs/math_object.lut.h:

        * kjs/number_object.lut.h:

        * kjs/string_object.lut.h:

        Regenerated.

=== Safari-108 ===

2003-10-02  Darin Adler  <darin@apple.com>

        Reviewed by Dave.

        - fixed 3441656 -- constructor bad for objs created w/ function as prototype (www.moock.org/asdg/codedepot)

        * kjs/nodes.cpp: (FuncDeclNode::processFuncDecl): Set up the constructor as

        as specified in the JavaScript spec. We were already doing this right in the

        other place we make functions.

2003-09-30  Darin Adler  <darin@apple.com>

        Reviewed by Dave.

        Rolled in Harri Porten's change to accept non-breaking space in JavaScript.

        * kjs/lexer.cpp: (Lexer::isWhiteSpace): Accept 00A0 as "whitespace".

2003-09-25  Maciej Stachowiak  <mjs@apple.com>

	Roll out build system change since it did not actually work. :-(

        * JavaScriptCore.pbproj/project.pbxproj:

        * Makefile.am:

2003-09-25  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin.

        * JavaScriptCore.pbproj/project.pbxproj: Don't hack install name. Instead

	of embedding into Safari, embed into WebKit as sub-umbrella.

        * Makefile.am: Don't forget to rebuild if the user removes

	JavaScript.framework from symroots manually.

=== Safari-107 ===

2003-09-24  Darin Adler  <darin@apple.com>

        Reviewed by Ken.

        - fixed 3421107 -- some dates that other browsers can parse can't be parsed by KJS's Date.parse()

        * kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Added code to be more strict about month names,

        to allow a time zone after date even if the date omits the time, and to understand AM and PM.

2003-09-22  Darin Adler  <darin@apple.com>

        * JavaScriptCore.pbproj/project.pbxproj: Rename Mixed build style to OptimizedWithSymbols.

2003-09-22  Darin Adler  <darin@apple.com>

        Reviewed by Ken.

        * kjs/config.h: Added HAVE_SYS_PARAM_H, since KJS does look for this header, and we do

        indeed have it. Just something I noticed in passing while cleaning up configure.in.

2003-09-20  Darin Adler  <darin@apple.com>

        Reviewed by Dave.

        - fixed 3419380 -- JavaScript Date.getTimezoneOffset is off by one hour (during daylight savings)

        * kjs/date_object.cpp: (DateProtoFuncImp::call): The daylight savings correction

        in here was incorrect. Perhaps I should have corrected it for the non-BSD case too,

        but I'm not sure the issue is the same.

2003-09-17  Darin Adler  <darin@apple.com>

        Reviewed by Maciej.

        * kjs/date_object.cpp: Removed our CF-based implementations of gmtime, localtime,

        mktime, timegm, and time, since they no longer have the slow "hit the filesystem

        every time" behavior.

=== Safari-100 ===

=== Safari-99 ===

=== Safari-98 ===

=== Safari-97 ===

=== Safari-96 ===

2003-08-27  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by John

	- fixed rdar://problem/3397316 - sherlock crash: KJS::Collector::allocate(unsigned long)

	* kjs/internal.cpp:

        (InterpreterImp::InterpreterImp): Hold the lock a bit longer, so

	the call to initGlobalObject is covered.

=== Safari-95 ===

2003-08-24  Darin Adler  <darin@apple.com>

        Reviewed by John.

        - fixed 3098350 -- opt. params to date methods are ignored (can't set end date in Exchange/Outlook web cal.)

        * kjs/date_object.cpp: (DateProtoFuncImp::call): Added code to handle the optional parameters.

        Strangely, the table of functions already had the right number of parameters listed, but the

        code to look at the parameter values was missing.

=== Safari-94 ===

2003-08-17  Darin Adler  <darin@apple.com>

        Reviewed by Maciej.

        - fixed 3247528 -- encodeURI missing from JavaScriptCore (needed by Crystal Reports)

        - fixed 3381297 -- escape method does not escape the null character

        - fixed 3381299 -- escape method produces incorrect escape sequences ala WinIE, rather than correct ala Gecko

        - fixed 3381303 -- unescape method treats escape sequences as Latin-1 ala WinIE rather than as UTF-8 ala Gecko

        - fixed 3381304 -- unescape method garbles strings with bad escape sequences in them

        * kjs/function.h: Added constants for decodeURI, decodeURIComponent, encodeURI, and

        encodeURIComponent.

        * kjs/function.cpp:

        (encode): Added. New helper function for escape, encodeURI, and encodeURIComponent.

        (decode): Added. New helper function for unescape, decodeURI, and decodeURIComponent.

        (GlobalFuncImp::call): Added decodeURI, decodeURIComponent, encodeURI, and encodeURIComponent 

        implementations. Changed escape and unescape to use new helper functions, which fixes

        the four problems above.

        * kjs/internal.cpp: (InterpreterImp::initGlobalObject): Add decodeURI, decodeURIComponent,

        encodeURI, and encodeURIComponent to the global object.

        * kjs/ustring.h: Added a length to the CString class so it can hold strings with null

        characters in them, not just null-terminated strings. This allows a null character from

        a UString to survive the process of UTF-16 to UTF-8 decoding. Added overloads to

        UString::append, UString::UTF8String, UTF8SequenceLength, decodeUTF8Sequence,

        convertUTF16OffsetsToUTF8Offsets, and convertUTF8OffsetsToUTF16Offsets.

        * kjs/ustring.cpp:

        (CString::CString): Set up the length properly in all the constructors. Also add a new

        constructor that takes a length.

        (CString::append): Use and set the length properly.

        (CString::operator=): Use and set the length properly.

        (operator==): Use and the length and memcmp instead of strcmp.

        (UString::append): Added new overloads for const char * and for a single string to make

        it more efficient to build up a UString from pieces. The old way, a UString was created

        and destroyed each time you appended.

        (UTF8SequenceLength): New. Helper for decoding UTF-8.

        (decodeUTF8Sequence): New. Helper for decoding UTF-8.

        (UString::UTF8String): New. Decodes from UTF-16 to UTF-8. Same as the function that

        was in regexp.cpp, except has proper handling for UTF-16 surrogates.

        (compareStringOffsets): Moved from regexp.cpp.

        (createSortedOffsetsArray): Moved from regexp.cpp.

        (convertUTF16OffsetsToUTF8Offsets): New. Converts UTF-16 offsets to UTF-8 offsets, given

        a UTF-8 string. Same as the function that was in regexp.cpp, except has proper handling

        for UTF-16 surrogates.

        (convertUTF8OffsetsToUTF16Offsets): New. Converts UTF-8 offsets to UTF-16 offsets, given

        a UTF-8 string. Same as the function that was in regexp.cpp, except has proper handling

        for UTF-16 surrogates.

        - fixed 3381296 -- regular expression matches with UTF-16 surrogates will treat sequences as two characters

        * kjs/regexp.cpp:

        (RegExp::RegExp): Use the new UString::UTF8String function instead a function in this file.

        (RegExp::match): Use the new convertUTF16OffsetsToUTF8Offsets (and the corresponding

        reverse) instead of convertCharacterOffsetsToUTF8ByteOffsets in this file.

=== Safari-93 ===

2003-08-14  Vicki Murley  <vicki@apple.com>

        Reviewed by John. 

        * JavaScriptCore.pbproj/project.pbxproj: deleted JavaScriptCore.order from the project.

2003-08-14  Vicki Murley  <vicki@apple.com>

        Reviewed by John. 

        * JavaScriptCore.order: Removed.  We now link to the order file at /AppleInternal/OrderFiles.

        * JavaScriptCore.pbproj/project.pbxproj: change sectorder flag to point to /AppleInternal/OrderFiles/JavaScriptCore.order

=== JavaScriptCore-92.1 ===

2003-08-07  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan.

        - fixed 3365527 -- subscripting JavaScript strings does not work (leads to hang at www.newmagna.com.au)

        The JavaScript specification says nothing about this, but other browsers seem to give

        read-only access to the characters in a string as if the string was an array of characters.

        * kjs/array_object.cpp:

        (ArrayInstanceImp::get): Update to use a public toArrayIndex function instead of our own getArrayIndex

        function, so we can share with string.

        (ArrayInstanceImp::put): Ditto.

        (ArrayInstanceImp::hasProperty): Ditto.

        (ArrayInstanceImp::setLength): Ditto.

        * kjs/ustring.h: Add toArrayIndex.

        * kjs/ustring.cpp: (UString::toArrayIndex): Added. Implements the rule from array.

        * kjs/identifier.h: Add a forwarding function so we can use toArrayIndex.

        * kjs/string_object.cpp:

        (StringInstanceImp::get): Return a single character string if the property name is an array index.

        (StringInstanceImp::hasProperty): Return true for property names that are suitable array indices.

        * JavaScriptCore.pbproj/project.pbxproj: Let Xcode be Xcode.

=== Safari-92 ===

2003-08-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin.

	- fixed 3366975 - repro hang in KJS::Value::Value entering text at eil.com

        * kjs/string_object.cpp:

        (StringProtoFuncImp::call): When doing a match against a regexp

	with the global flag set, make sure to return null rather than an

	empty array when there is no match. This is what other browsers do.

2003-08-05  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by John.

        * kjs/list.cpp:

	(List::copyTail): Test for loop termination with < instead of !=,

	since i starts at 1 but size could be 0. Do the same for the other

	loop for consistency's sake.

2003-08-01  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by John.

	- fixed 3222621 - Cryptic "anonymous function hack" messages in console (10.2.4)

        * kjs/lexer.cpp:

        (Lexer::lex): Remove useless debug spew.

=== Safari-91 ===

2003-07-30  Darin Adler  <darin@apple.com>

        Reviewed by Dave.

        - fixed problem where some JavaScriptCore symbols had no namespace or prefix

        * kjs/grammar.y: Added a define for yylloc to make it use the kjs prefix.

        This is the same thing done for the rest of the symbols automatically by yacc,

        but for some reason it's not done for yyloc. Also make automatic() function static.

        * kjs/grammar.cpp: Regenerated.

        * kjs/lexer.cpp: Use kjsyylloc instead of yyloc.

        * pcre/pcre.h: Add defines to prepend kjs prefixes for all the PCRE functions.

2003-07-30  Darin Adler  <darin@apple.com>

        * Makefile.am: Include the subdirectory with the PCRE code in it.

2003-07-30  John Sullivan  <sullivan@apple.com>

	- JavaScriptCore part of fix for 3284525 -- AutoFill fills in 

	only e-mail address field of New Account form on Apple Store Japan

        Reviewed by Darin

        * JavaScriptCore.pbproj/project.pbxproj:

	Mark pcre.h as a Private header

2003-07-28  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Richard.

	- fixed 3240814 - LEAK: 120 byte leak in JavaScript parser in Sherlock Movies channel

        * kjs/internal.cpp:

        (Parser::parse): ref() and deref() the program node, to make sure to clean up properly,

	before deleting it.

        (InterpreterImp::checkSyntax): Likewise.

=== Safari-90 ===

2003-07-22  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by John.

	Remove -seg_addr_table_filename to fix build.

        * JavaScriptCore.pbproj/project.pbxproj:

2003-07-17  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by John.

	- fixed 3330344 - Please change allowable client to "JavaScriptGlue" from "JSGlue"

        * JavaScriptCore.pbproj/project.pbxproj: Changed allowable client

	to "JavaScriptGlue"

2003-07-13  Darin Adler  <darin@apple.com>

        Reviewed by Maciej.

        - do some improvements Maciej suggested while reviewing the array index change

        * kjs/array_object.cpp:

        (getArrayIndex): Return a flag to say whether the index was value separately, to avoid

        in-band signalling.

        (ArrayInstanceImp::get): Update for new getArrayIndex parameters.

        (ArrayInstanceImp::put): Ditto.

        (ArrayInstanceImp::hasProperty): Ditto.

        (ArrayInstanceImp::setLength): Ditto.

        * kjs/ustring.cpp: (UString::toStrictUInt32): Check for overflow in a way that avoids doing

        a divide every time through the loop. But note that it adds an extra branch to the loop.

        I wonder which is worse.

2003-07-12  Darin Adler  <darin@apple.com>

        Fixed broken build.

        * kjs/identifier.h: Add toULong back. It's still used in WebCore (and maybe in JavaScriptGlue,

        for all I know).

2003-07-12  Darin Adler  <darin@apple.com>

        Reviewed by Dave.

        - fixed 3272777 -- array object indices treated as integers by Safari, but as strings in other web browsers

        JavaScriptCore did not implement the proper rule for what an array index is.

        * kjs/array_object.cpp:

        (getArrayIndex): Added. Implements the rule from the specification, which also provides a handy

        "not an array index" value of 2^32-1.

        (ArrayInstanceImp::get): Use getArrayIndex.

        (ArrayInstanceImp::put): Ditto.

        (ArrayInstanceImp::hasProperty): Ditto.

        (ArrayInstanceImp::setLength): Ditto.

        * kjs/identifier.h: Removed now-unused toULong, and added toStrictUInt32, in both cases forwarding

        functions that forward to UString.

        * kjs/ustring.h: Added toStringUInt32.

        * kjs/ustring.cpp: (UString::toStrictUInt32): Added. Converts a string to a 32-bit unsigned integer,

        and rejects any string that does not exactly match the way the integer would be formatted on output.

        This is the rule documented in the ECMA language standard.

=== Safari-89 ===

2003-07-10  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin.

	- fixed 3302021 - v74 and v85 hang with http://e-www.motorola.com/

	The crux of this was saving and restoring the prototype objects

	for all the standard types when saving and restoring for the page

	cache.

        * kjs/internal.cpp:

        (InterpreterImp::saveBuiltins):

        (InterpreterImp::restoreBuiltins):

        * kjs/internal.h:

        * kjs/interpreter.cpp:

        (Interpreter::saveBuiltins):

        (Interpreter::restoreBuiltins):

        (SavedBuiltins::SavedBuiltins):

        (SavedBuiltins::~SavedBuiltins):

        * kjs/interpreter.h:

        * kjs/property_map.cpp:

2003-07-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by John.

	- fixed 3295916 - b/c JavaScriptCore and WebCore are installing in wrong location, private headers are public

        * WebCore.pbproj/project.pbxproj: Install in WebKit.framework/Versions/A/Frameworks.

=== Safari-88 ===

2003-07-02  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Ken.

	- fixed 3096961 - JavaScriptCore should link only to what it uses, shouldn't drag in Cocoa.framework

        * JavaScriptCore.pbproj/project.pbxproj: Don't link Cocoa.framework;

	just pull in CoreFoundation and CoreServices.

        * kjs/date_object.cpp: Include CoreServices.h instead of Carbon.h

	(the stuff we want is in CarbonCore).

2003-06-20  Darin Adler  <darin@apple.com>

        Reviewed by Maciej.

        - improved the property map sorting technique so that the indices

          are separate for each property map, and also preserve the ordering

          when property maps are saved and restored

        * kjs/property_map.cpp:

        (PropertyMap::put): Don't bother setting the index for _singleEntry, since there's

        no need to sort a single entry. Use the per-table lastIndexUsed instead of a global.

        (PropertyMap::expand): Don't use the index (uninitialized now) out of a _singleEntry

        when putting it in a newly-created map; just use 0. Compute a value for the new map's

        lastIndexUsed as we walk through the elements we are adding to it (using the same old

        indices from the old map).

=== Safari-85.1 ===

=== Safari-85 ===

2003-06-13  Darin Adler  <darin@apple.com>

        Reviewed by Dave.

	- fixed 3178438 -- return elements in order of addition in for..in loop (other browsers seem to)

	- fixed 3292067 -- REGRESSION (64-65): albertsons.com "Shop A to Z" menus are not sorted alphabetically

        * kjs/property_map.h: Add index field to hash table entry and index parameter to insert function.

        * kjs/property_map.cpp:

        (PropertyMap::put): Set an index for new map entries to an ever-increasing number based on a global.

        (PropertyMap::insert): Take an index parameter.

        (PropertyMap::expand): Preserve the indices as we rehash the table.

        (comparePropertyMapEntryIndices): Added. Compares two property map entries by index.

        (PropertyMap::addEnumerablesToReferenceList): Sort the proprty map entries by index before adding

        them to the reference list.

=== Safari-84 ===

2003-06-10  Vicki Murley  <vicki@apple.com>

        Reviewed by john.

        * JavaScriptCore.order: new order file for 1.0

=== Safari-83 ===

2003-06-04  Darin Adler  <darin@apple.com>

        Reviewed by Dave.

	- fixed 3224031 -- can't search at rakuten.co.jp b/c of extra characters inserted by regexp replace (8-bit char)

        Use PCRE UTF-8 regular expressions instead of just chopping off high bytes.

        * kjs/regexp.h: Redo field names, remove some unused stuff.

        * kjs/regexp.cpp:

        (convertToUTF8): Added.

        (compareStringOffsets): Added.

        (createSortedOffsetsArray): Added.

        (convertCharacterOffsetsToUTF8ByteOffsets): Added.

        (convertUTF8ByteOffsetsToCharacterOffsets): Added.

        (RegExp::RegExp): Set the PCRE_UTF8 flag, and convert the UString to UTF-8 instead of

        using ascii() on it.

        (RegExp::~RegExp): Remove unneeded if statement (pcre_free is 0-tolerant as free is).

        (RegExp::match): Convert the UString to UTF-8 and convert the character offsets to and

        from UTF-8 byte offsets. Also do fixes for the "no offset vector" case so we get the

        correct position and matched string.

        * JavaScriptCore.pbproj/project.pbxproj: Add a PCRE header that was missing before.

=== Safari-82 ===

=== Safari-81 ===

2003-05-21  Vicki Murley  <vicki@apple.com>

        Reviewed by john 

	- fixed 3234553: Safari and its frameworks should link using order files

        * JavaScriptCore.order: Added.

        * JavaScriptCore.pbproj/project.pbxproj: set SECTORDER_FLAGS = -sectorder __TEXT __text JavaScriptCore.order

=== Safari-80 ===