2010-07-22  Jon Honeycutt  <jhoneycutt@apple.com>

        Build fix. Unreviewed.

        * win/WebKit2WebProcess.vcproj:

        Remove the pre- and post-build events, so that they will use the value

        inherited from the vsprops.

2010-07-21  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions

        https://bugs.webkit.org/show_bug.cgi?id=42548

        Added WKBundleFrameCopyName.

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

        (WKBundleFrameCopyName): Added.

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Ditto.

        * WebProcess/WebPage/WebFrame.cpp:

        (WebKit::WebFrame::name): Added.

        * WebProcess/WebPage/WebFrame.h: Ditto.

2010-07-21  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WebKitTestRunner needs to support dumping of scroll position

        https://bugs.webkit.org/show_bug.cgi?id=42514

        Added WKBundleFrameGetJavaScriptContext function.

        * WebKit2.xcodeproj: Added property svn:ignore.

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

        (WKBundleFrameGetJavaScriptContext): Added.

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Ditto.

        * WebProcess/InjectedBundle/API/c/WKBundlePage.h:

        * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

        (WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):

        * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

        (WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):

        Use JSGlobalContextRef instead of JSContextRef and context instead of ct.

2010-07-21  Adam Roben  <aroben@apple.com>

        Handle broken pipes in more places in CoreIPC

        Fixes <http://webkit.org/b/42784> Assertion failure in

        Connection::readEventHandler when WebKitTestRunner exits

        Reviewed by Anders Carlsson.

        * Platform/CoreIPC/win/ConnectionWin.cpp:

        (CoreIPC::Connection::readEventHandler): Check for a broken pipe

        whenever we call ::PeekNamedPipe.

2010-07-21  Adam Roben  <aroben@apple.com>

        Teach CoreIPC how to handle messages that are larger than the pipe's

        buffer

        ::GetOverlappedResult and ::ReadFile can fail with ERROR_MORE_DATA

        when there is more data available on the pipe than was requested in

        the read operation. In those cases, the appropriate response is to

        perform another read operation to read the extra data. We now do this.

        Also, MSDN says that, because we are doing asynchronous read

        operations, we should not pass a pointer to ::ReadFile to find out how

        many bytes were read. Instead we should always call

        ::GetOverlappedResult to find this out. I've changed

        Connection::readEventHandler to have a single loop that calls

        ::GetOverlappedResult and ::ReadFile in alternation, rather than

        sometimes calling ::ReadFile multiple times in a row, to satisfy this

        requirement.

        In order to simplify the logic in this function, I've made us request

        only a single byte from the pipe when there are no messages already in

        the pipe. (Previously we were requesting 4096 bytes in this case.)

        This allows us not to have to consider the case where the received

        message is smaller than our read buffer. If we decide that this has a

        negative impact on performance, we can of course change it. I've

        mitigated this somewhat by using ::PeekNamedMessage to find out the

        size of the next message in the pipe (if any), so that we can read it

        all in one read operation.

        Fixes <http://webkit.org/b/42710> <rdar://problem/8197571> Assertion

        in Connection::readEventHandler when launching WebKitTestRunner

        Reviewed by Anders Carlsson.

        * Platform/CoreIPC/win/ConnectionWin.cpp:

        (CoreIPC::Connection::readEventHandler): Put the call to

        ::GetOverlappedResult in the same loop as ::ReadFile so that we will

        call them alternately. If ::GetOverlappedResult fails with

        ERROR_MORE_DATA, use ::PeekNamedPipe to determine the size of the rest

        of the message, then read it from the pipe. After dispatching the

        message, use ::PeekNamedPipe to find out the size of the next message

        in the pipe so we can read it all in one operation. If there's no

        message in the pipe, we'll request just a single byte of the next

        message that becomes available, and Windows will tell us when the rest

        of the message is ready. If ::ReadFile fails with ERROR_MORE_DATA it

        means there is data available now even though we didn't think there

        was any. We go back to the top of the loop in this case and call

        ::GetOverlappedResult again to retrieve the available data.

2010-07-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Patch for https://bugs.webkit.org/show_bug.cgi?id=42539

        WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages

        - Convert injected bundle UIClient functions to will-style, at least until we establish

          more concrete use cases for them past the TestRunner.

        * WebProcess/InjectedBundle/API/c/WKBundlePage.h:

        * WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

        (WebKit::InjectedBundlePageUIClient::willAddMessageToConsole):

        (WebKit::InjectedBundlePageUIClient::willSetStatusbarText):

        (WebKit::InjectedBundlePageUIClient::willRunJavaScriptAlert):

        (WebKit::InjectedBundlePageUIClient::willRunJavaScriptConfirm):

        (WebKit::InjectedBundlePageUIClient::willRunJavaScriptPrompt):

        * WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:

        * WebProcess/WebCoreSupport/WebChromeClient.cpp:

        (WebKit::WebChromeClient::addMessageToConsole):

        (WebKit::WebChromeClient::runJavaScriptAlert):

        (WebKit::WebChromeClient::runJavaScriptConfirm):

        (WebKit::WebChromeClient::runJavaScriptPrompt):

        (WebKit::WebChromeClient::setStatusbarText):

2010-07-21  Simon Fraser  <simon.fraser@apple.com>

        Windows build fix.

        Need to supply implementations of PageClient::pageDidEnterAcceleratedCompositing()

        and pageDidLeaveAcceleratedCompositing() for WebView on Windows.

        * UIProcess/win/WebView.cpp:

        (WebKit::WebView::pageDidEnterAcceleratedCompositing):

        (WebKit::WebView::pageDidLeaveAcceleratedCompositing):

        * UIProcess/win/WebView.h:

2010-07-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Don't assert when clicking on a plug-in in WebKit2

        https://bugs.webkit.org/show_bug.cgi?id=42762

        Add stub for PluginView::handleEvent.

        * WebProcess/Plugins/PluginView.cpp:

        (WebKit::PluginView::handleEvent):

        * WebProcess/Plugins/PluginView.h:

2010-07-21  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson.

        Get accelerated compositing working with webkit2

        https://bugs.webkit.org/show_bug.cgi?id=41084

        Hook up dynamic DrawingArea switching, so that when the WebProcess hits a page

        that requires accelerated compositing, we switch to the LayerBackedDrawingArea.

        * Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h:

        (DrawingAreaProxyMessage::):

        * Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:

        (WebPageProxyMessage::):

        * UIProcess/API/mac/PageClientImpl.h:

        * UIProcess/API/mac/PageClientImpl.mm:

        (WebKit::PageClientImpl::pageDidEnterAcceleratedCompositing):

        (WebKit::PageClientImpl::pageDidLeaveAcceleratedCompositing):

        * UIProcess/API/mac/WKView.mm:

        (-[WKView _startAcceleratedCompositing:]):

        (-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaProxy::]):

        (-[WKView _pageDidEnterAcceleratedCompositing]):

        (-[WKView _pageDidLeaveAcceleratedCompositing]):

        * UIProcess/API/mac/WKViewInternal.h:

        * UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

        (WebKit::ChunkedUpdateDrawingAreaProxy::didReceiveSyncMessage):

        * UIProcess/ChunkedUpdateDrawingAreaProxy.h:

        * UIProcess/DrawingAreaProxy.h:

        (WebKit::DrawingAreaProxy::):

        (WebKit::DrawingAreaProxy::type):

        * UIProcess/LayerBackedDrawingAreaProxy.cpp:

        (WebKit::LayerBackedDrawingAreaProxy::didSetSize):

        (WebKit::LayerBackedDrawingAreaProxy::didReceiveMessage):

        (WebKit::LayerBackedDrawingAreaProxy::didReceiveSyncMessage):

        * UIProcess/LayerBackedDrawingAreaProxy.h:

        * UIProcess/PageClient.h:

        * UIProcess/WebPageProxy.cpp:

        (WebKit::WebPageProxy::setDrawingArea):

        (WebKit::WebPageProxy::didReceiveSyncMessage):

        (WebKit::WebPageProxy::didEnterAcceleratedCompositing):

        (WebKit::WebPageProxy::didLeaveAcceleratedCompositing):

        * UIProcess/WebPageProxy.h:

        * UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:

        (WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext):

        * WebProcess/WebCoreSupport/WebChromeClient.cpp:

        (WebKit::WebChromeClient::attachRootGraphicsLayer):

        * WebProcess/WebPage/ChunkedUpdateDrawingArea.h:

        (WebKit::ChunkedUpdateDrawingArea::attachCompositingContext):

        (WebKit::ChunkedUpdateDrawingArea::setRootCompositingLayer):

        * WebProcess/WebPage/DrawingArea.cpp:

        (WebKit::DrawingArea::create):

        * WebProcess/WebPage/DrawingArea.h:

        (WebKit::DrawingArea::):

        (WebKit::DrawingArea::type):

        * WebProcess/WebPage/LayerBackedDrawingArea.cpp:

        (WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea):

        (WebKit::LayerBackedDrawingArea::setNeedsDisplay):

        (WebKit::LayerBackedDrawingArea::setSize):

        (WebKit::LayerBackedDrawingArea::didUpdate):

        (WebKit::LayerBackedDrawingArea::setRootCompositingLayer):

        * WebProcess/WebPage/LayerBackedDrawingArea.h:

        * WebProcess/WebPage/WebPage.cpp:

        (WebKit::WebPage::changeAcceleratedCompositingMode):

        (WebKit::WebPage::enterAcceleratedCompositingMode):

        (WebKit::WebPage::exitAcceleratedCompositingMode):

        * WebProcess/WebPage/WebPage.h:

        * WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:

        (WebKit::LayerBackedDrawingArea::platformInit):

        (WebKit::LayerBackedDrawingArea::attachCompositingContext):

        (WebKit::LayerBackedDrawingArea::detachCompositingContext):

        (WebKit::LayerBackedDrawingArea::setRootCompositingLayer):

2010-07-20  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        WebKit on Windows should build optionally with an unversioned ICU DLL

        https://bugs.webkit.org/show_bug.cgi?id=42722

        <rdar://problem/8211767> WebKit needs to link against unversioned ICU

        To get the proper value for U_DISABLE_RENAMING into all source files, we force

        the include of ICUVersion.h (our generated header) via the compiler options.

        Since the versioned and unversioned ICU have different filenames (libicuuc.lib vs icuuc.lib)

        we copy the ICU lib to an intermediate location under obj with a common name. This

        allows us to link properly with either without adding a new build configuration.

        * win/WebKit2Common.vsprops:

        Copy ICU libs into a common location with a common name.

        Add additional library search path to pick up icu lib.

        Change ICU library filename specified to linker.

        Add forced include of ICUVersion.h.        

2010-07-21  Adam Roben  <aroben@apple.com>

        Windows build fix

        * Shared/win/UpdateChunk.h:

        (WebKit::UpdateChunk::isEmpty): Added to match the Mac definition.

2010-07-21  Anders Carlsson  <andersca@apple.com>

        Land file I forgot to add.

        * WebProcess/com.apple.WebProcess.sb: Added.

2010-07-21  Adam Roben  <aroben@apple.com>

        Move WebKit2WebProcess's settings to a vsprops file

        Fixes <http://webkit.org/b/42751> WebKit2WebProcess should use vsprops

        files

        Reviewed by Darin Adler.

        * win/WebKit2WebProcess.vcproj: Moved settings from here...

        * win/WebKit2WebProcessCommon.vsprops: ...to here.

2010-07-20  Ivan Krstić  <ike@apple.com>

        Reviewed and tweaked by Anders Carlsson and Sam Weinig.

        Put WebProcess in a sandbox. All of the following changes are

        Mac-only.

        <rdar://problem/7865269>

        * UIProcess/WebProcessProxy.cpp:

        (WebKit::WebProcessProxy::WebProcessProxy):

        Send Sandbox extension for injected bundle to WebProcess.

        * WebKit2.xcodeproj/project.pbxproj:

        Add Sandbox profile to Resources for WebProcess.

        * WebProcess/InjectedBundle/InjectedBundle.h:

        New function InjectedBundle::setSandboxToken.

        * WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:

        (WebKit::InjectedBundle::load):

        Consume Sandbox token for the bundle if present.

        (WebKit::InjectedBundle::setSandboxToken):

        Set Sandbox token for the bundle.

        * WebProcess/WebProcess.cpp:

        (WebKit::WebProcess::loadInjectedBundle):

        Extra function parameter for Sandbox token.

        (WebKit::WebProcess::didReceiveMessage):

        Pass Sandbox token to loadInjectedBundle().

        * WebProcess/WebProcess.h:

        Extra function parameter for Sandbox token in loadInjectedBundle().

        * WebProcess/com.apple.WebProcess.sb: Added.

        Sandbox profile for WebProcess.

        * WebProcess/mac/WebProcessMainMac.mm:

        (WebKit::WebProcessMain):

        Initialize Sandbox, exit on failure.

2010-07-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Brady Eidson.

        Patch for https://bugs.webkit.org/show_bug.cgi?id=42719

        Make Acid2 pass in WebKit2

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

        (WebKit::WebFrameLoaderClient::objectContentType): Check for supported image mimetypes

        before falling back to plugins.

2010-07-20  Adam Roben  <aroben@apple.com>

        Remove WebKit2.sln

        WebKit.sln builds all the same projects.

        Rubber-stamped in advance by Steve Falkenburg.

        * WebKit2.sln: Removed.

2010-07-20  Adam Roben  <aroben@apple.com>

        Make the web process break into the debugger when Ctrl-Alt-Shift is

        held during launch

        Fixes <http://webkit.org/b/42670> Would like a way to break into the

        debugger when the web process launches

        Reviewed by Anders Carlsson.

        * WebProcess/WebKitMain.cpp:

        (WebKitMain): If the Control, Alt, and Shift keys are held down in a

        Debug build, call DebugBreak() so that we will break into the

        debugger.

2010-07-20  Adam Roben  <aroben@apple.com>

        Teach Connection how to handle a slow receiver

        Fixes <http://webkit.org/b/42667> Assertion in

        Connection::sendOutgoingMessage when browser or web process is paused

        Reviewed by Anders Carlsson.

        * Platform/CoreIPC/win/ConnectionWin.cpp:

        (CoreIPC::Connection::sendOutgoingMessage): If WriteFile returns FALSE

        and the last error is ERROR_IO_PENDING, Windows will write the data as

        soon as the current write operation is completed. We don't need to do

        anything special in this case, so there's no need to assert about it.

2010-07-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Handle WKView visibility changes

        <rdar://problem/7891077>

        * Shared/mac/UpdateChunk.h:

        (WebKit::UpdateChunk::isEmpty):

        Add convenience getter.

        * UIProcess/API/mac/WKView.mm:

        (-[WKView viewDidMoveToWindow]):

        Reorder the calls to _updateActiveState and _updateVisibility based on whether the view is moved to

        a window or away from a window.

        * UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

        (WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):

        Initialize m_forceRepaintWhenResumingPainting to false.

        (WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible):

        Pass the m_forceRepaintWhenResumingPainting along to the DrawingAreaMessage::ResumePainting message.

        (WebKit::ChunkedUpdateDrawingAreaProxy::didSetSize):

        Don't try to paint empty update chunks.

        (WebKit::ChunkedUpdateDrawingAreaProxy::update):

        Don't paint the update chunk if we're not visible. Instead, make sure that the entire page is being redrawn

        when its shown again.

        * UIProcess/ChunkedUpdateDrawingAreaProxy.h:

        * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:

        (WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea):

        (WebKit::ChunkedUpdateDrawingArea::display):

        (WebKit::ChunkedUpdateDrawingArea::suspendPainting):

        Rename m_shouldPaint to m_isPaintingSuspended and invert its logic.

        (WebKit::ChunkedUpdateDrawingArea::scheduleDisplay):

        Don't schedule a display timer if the dirty rect is empty.

        (WebKit::ChunkedUpdateDrawingArea::setSize):

        If painting is suspended, just send back an empty update chunk in the DidSetSize message.

        (WebKit::ChunkedUpdateDrawingArea::resumePainting):

        If forceRepaint is true, repaint the entire drawing area.

2010-07-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Implement NPN_GetURL and NPN_PostURL

        https://bugs.webkit.org/show_bug.cgi?id=42650

        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

        (WebKit::parsePostBuffer):

        Add a FIXME about deleting the file.

        (WebKit::makeURLString):

        Move this static method before NPN_GetURL.

        (WebKit::NPN_GetURL):

        Call NetscapePLugin::LoadURL.

        (WebKit::NPN_PostURL):

        Ditto.

        (WebKit::NPN_PostURLNotify):

        * WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

        Remove unreached code.

        (WebKit::NetscapePluginStream::deliverDataToPlugin):

        Stop the stream if the plug-in returns -1 from NPP_Write.

2010-07-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        WebKitTestRunner and WebProcess simultaneously stall in CoreIPC::Connection::sendOutgoingMessage

        https://bugs.webkit.org/show_bug.cgi?id=42356

        Up the port queue length from 5 to 1024. While this does solve the problem, we should still try to

        make sendOutgoingMessage not block. I've filed https://bugs.webkit.org/show_bug.cgi?id=42611 to track 

        doing this on Mac and Windows.

        * Platform/CoreIPC/mac/ConnectionMac.cpp:

        (CoreIPC::Connection::open):

        Call setMachPortQueueLength.

        * Platform/mac/MachUtilities.cpp: Added.

        (setMachPortQueueLength):

        Given a mach port receive right, sets the port queue length.

        * Platform/mac/MachUtilities.h: Added.

        * WebKit2.xcodeproj/project.pbxproj:

        Add MachUtilities.cpp and MachUtilities.h

2010-07-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler, Adam Roben, Dan Bernstein and Sam Weinig.

        Handle NP_ASFILE and NP_ASFILEONLY transfer modes

        https://bugs.webkit.org/show_bug.cgi?id=42587

        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

        (WebKit::NetscapePlugin::NPP_StreamAsFile):

        * WebProcess/Plugins/Netscape/NetscapePlugin.h:

        Add NPP_ wrapper.

        * WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

        (WebKit::NetscapePluginStream::NetscapePluginStream):

        Initialize m_fileHandle.

        (WebKit::isSupportedTransferMode):

        NP_ASFILE and NP_ASFILEONLY is now supported.

        (WebKit::NetscapePluginStream::deliverData):

        Call deliverDataToFile if necessary.

        (WebKit::NetscapePluginStream::deliverDataToFile):

        Create a temporary file and write the data into it.

        (WebKit::NetscapePluginStream::stop):

        If the transfer mode is either NP_ASFILE or NP_ASFILEONLY, make sure to

        call NPP_StreamAsFile and close the file and delete it.

        * WebProcess/Plugins/PluginView.cpp:

        (WebKit::PluginView::cancelStreamLoad):

        Keep a reference to the Stream since cancelling it will remove it from the map.

2010-07-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Implement NPN_PostURLNotify

        https://bugs.webkit.org/show_bug.cgi?id=42602

        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

        (WebKit::parsePostBuffer):

        Read the buffer from a file if necessary and parse it.

        (WebKit::NPN_GetURLNotify):

        Add extra arguments.

        (WebKit::NPN_PostURLNotify):

        Parse the post buffer, then call NetscapePlugin::loadURL.

        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

        (WebKit::NetscapePlugin::loadURL):

        Pass the method, the header fields and form data along.

        (WebKit::NetscapePlugin::allowPopups):

        Just return false for now.

        (WebKit::NetscapePlugin::initialize):

        Pass extra arguments to loadURL.