2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Ariya Hidayat.

        [Qt] QtTestBrowser: proper set scene rect

        When resizesToContents is ON scene's rect is set to the boundary of

        the mainFrame. However, navigating to other web page should keep resizing

        scene's rect according to the new document loaded. Patch addresses this issue.

        Now resizesToContents and scrolling properly work on QtTestBrowser.

        * QtTestBrowser/webview.cpp:

        (WebViewGraphicsBased::setPage):

        (WebViewGraphicsBased::contentsSizeChanged):

        (WebViewGraphicsBased::setResizesToContents):

        (WebViewGraphicsBased::resizeEvent):

        * QtTestBrowser/webview.h:

2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Ariya Hidayat.

        [Qt] QtTestBrowser: Clean up LauncherWindow code.

        * QtTestBrowser/launcherwindow.cpp:

        (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().

        (LauncherWindow::init): Fixed comments.

        (LauncherWindow::applyPrefs): Move the method around.

        (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.

2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Ariya Hidayat.

        [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.

        It gets control+0 the same visual effect as control++ or control-.

        * QtTestBrowser/launcherwindow.cpp:

        (LauncherWindow::toggleZoomTextOnly):

2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Ariya Hidayat.

        [Qt] QtTestBrowser:: make m_zoomLevels a static member.

        Not all instances of LauncherWindow need its own m_zoomLevel.

        * QtTestBrowser/launcherwindow.cpp:

        * QtTestBrowser/launcherwindow.h:

2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Kenneth Christiansen.

        [Qt] [QtTestBrowser] Remove unneeded QAction class members

        https://bugs.webkit.org/show_bug.cgi?id=43518

        LauncherWindow class has two totally unneeded class members: m_flopAnimated and

        m_flipYAnimated. Also, in initializeView method there are some dead code block

        trying to connect them at the wrong time, when they have not been instanciated.

        This patch:

        - removes the two cited class members in favor of local variables in createChrome method;

        - removes the dead code block.

        * QtTestBrowser/launcherwindow.cpp:

        (LauncherWindow::LauncherWindow):

        (LauncherWindow::initializeView):

        (LauncherWindow::createChrome):

        * QtTestBrowser/launcherwindow.h:

2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Simon Hausmann and Kenneth Christiansen.

        [Qt] [QtTestBrowser] Clean up static and global menu state controls

        https://bugs.webkit.org/show_bug.cgi?id=43448

        After LauncherWindow class was refactored out of from main.cpp, all global variables that

        were hanging in main.cpp became temporarily public static class members of newly added

        LauncherWindow class. This design was not properly handling the initial purpose of the

        global variables: newly created launcher windows should inherit the settings of the originating

        one.

        In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It

        comprises all data needed to handling the goal described above.

        * QtTestBrowser/launcherwindow.cpp:

        (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object

                                          holding all user settings configured in the menus and command line.

                                          It also receices an optional QGraphicsScene points in case we are doing

                                          a "Clone Window".

        (LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its

                                value.

        (LauncherWindow::initializeView): Ditto.

        (LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX

        (LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly

                                      apply the preferences is provided by m_userData.

        (LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX

        (LauncherWindow::toggleResizesToContents): Ditto.

        (LauncherWindow::toggleWebGL): Ditto.

        (LauncherWindow::toggleFrameFlattening): Ditto.

        (LauncherWindow::toggleQGLWidgetViewport): Ditto.

        (LauncherWindow::changeViewportUpdateMode): Ditto.

        (LauncherWindow::showFPS): Ditto.

        (LauncherWindow::newWindow): Changed to pass the userData.

        (LauncherWindow::cloneWindow): Ditto.

        * QtTestBrowser/launcherwindow.h:

        (WindowOptions::WindowOptions):

        * QtTestBrowser/main.cpp:

        (requiresGraphicsView):

        (LauncherApplication::handleUserOptions):

        (main):

2010-08-02  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Kenneth Christiansen.

        [Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents

        https://bugs.webkit.org/show_bug.cgi?id=43168

        QGraphicsWebView resizesToContents property has to work together with QWebPage's

        setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser.

        * QtTestBrowser/launcherwindow.cpp:

        (LauncherWindow::applyPrefs):

        * QtTestBrowser/webview.cpp:

        (WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes

                                                      needed when toggle resizesToContents on/off.

        (WebViewGraphicsBased::resizeEvent):

        * QtTestBrowser/webview.h:

        (WebViewGraphicsBased::setCustomLayoutSize): Setter helper.

        (WebViewGraphicsBased::customLayoutSize): Getter helper.

2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Kenneth Christiansen.

        [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken

        https://bugs.webkit.org/show_bug.cgi?id=43209

        When -resizes-to-content was being passed as a command line parameter it was simply

        not being set (although the corresponding menu item was marked as ON).

        User had to toggle the menu OFF and then ON again for it to take place.

        Reason: LauncherWindow::applyPrefs method sets many user options passed in from

        the command line, but not resizesToContents. Patch addresses that.

        * QtTestBrowser/launcherwindow.cpp:

        (LauncherWindow::createChrome):

        (LauncherWindow::applyPrefs):

        (LauncherWindow::toggleResizesToContents):

        * QtTestBrowser/webview.h:

        (WebViewGraphicsBased::resizesToContents):

2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>

        Rubber-stamped by Simon Fraser.

        [Qt] QtTestBrowser: more method grouping and clean ups.

        Moving blocks of code around. Basically grouping related methods close to each.

        * QtTestBrowser/launcherwindow.cpp:

        (LauncherWindow::initializeView):

        (LauncherWindow::createChrome):

        (LauncherWindow::changeViewportUpdateMode):

        (LauncherWindow::showFPS):

        (LauncherWindow::newWindow):

        (LauncherWindow::cloneWindow):

        * QtTestBrowser/launcherwindow.h:

2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Kenneth Christiansen.

        [Qt] QtTestBrowser: Move WebPage class methods definitions from main.cpp to webpage.cpp

        https://bugs.webkit.org/show_bug.cgi?id=43199

        There is no sense in keeping WebPage method definitions in main.cpp once

        webpage.cpp already exists.

        No behavior change.

        * QtTestBrowser/main.cpp:

        * QtTestBrowser/webpage.cpp:

        (WebPage::createWindow):

        (WebPage::createPlugin):

2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Kenneth Christiansen.

        [Qt] Factor out LauncherWindow class out of main.cpp (QtTestBrowser)

        https://bugs.webkit.org/show_bug.cgi?id=43170

        Moving LauncherWindow class out of main.cpp to its own .cpp and .h files:

        launcherwindow.{cpp|h}

        No behavior change.

        Also changed all global static variables (named "gXXX") from main.cpp to

        static public variables of the LauncherWindow class.

        * QtTestBrowser/QtTestBrowser.pro:

        * QtTestBrowser/launcherwindow.cpp: Added.

        * QtTestBrowser/launcherwindow.h: Added.

        * QtTestBrowser/main.cpp:

        (LauncherApplication::handleUserOptions):

        (main):

2010-08-04  Markus Goetz  <Markus.Goetz@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Change wording in QtTestBrowser

        https://bugs.webkit.org/show_bug.cgi?id=43241

        * QtTestBrowser/launcherwindow.cpp:

        (LauncherWindow::createChrome):

2010-07-30  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [QT][Symbian] QtTestBrowser missing location capabilities

        https://bugs.webkit.org/show_bug.cgi?id=43235

        QtTestBrowser missing capabilities to use QtMobility::QLocation. 

        * QtTestBrowser/QtTestBrowser.pro:

2010-07-22  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] QtWebKit needs public API for Notifications.

        https://bugs.webkit.org/show_bug.cgi?id=41413

        Update DumpRenderTree and QtTestBrowser to use the new API.

        Add new DRT API to flag that notifications permission requests should be ignored.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:

        (WebCore::WebPage::WebPage):

        (WebCore::WebPage::requestPermission):

        (WebCore::WebPage::checkPermission):

        (WebCore::WebPage::cancelRequestsForPermission):

        * DumpRenderTree/qt/DumpRenderTreeQt.h:

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:

        (LayoutTestController::reset):

        (LayoutTestController::ignoreDesktopNotificationPermissionRequests):

        (LayoutTestController::checkDesktopNotificationPermission):

        * DumpRenderTree/qt/LayoutTestControllerQt.h:

        (LayoutTestController::ignoreReqestForPermission):

        * QtTestBrowser/main.cpp:

        (LauncherWindow::LauncherWindow):

        * QtTestBrowser/webpage.cpp:

        (WebPage::WebPage):

        (WebPage::requestPermission):

        (WebPage::checkPermission):

        (WebPage::cancelRequestsForPermission):

        * QtTestBrowser/webpage.h:

2010-07-21  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions

        https://bugs.webkit.org/show_bug.cgi?id=42548

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

        (WTR::numericWindowPropertyValue): Renamed this and moved it up higher in the file.

        (WTR::dumpFrameScrollPosition): Added argument telling whether to dump the frame name.

        Changed to a file-internal function instead of a member function.

        (WTR::dumpDescendantFrameScrollPositions): Added.

        (WTR::InjectedBundlePage::dumpAllFrameScrollPositions): Added.

        (WTR::InjectedBundlePage::dump): Changed to call dumpAllFrameScrollPositions when

        appropriate. Also streamlined all the WKStringToUTF8 call sites.

        (WTR::InjectedBundlePage::willAddMessageToConsole): Streamlined use of WKStringToUTF8.

        (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.

        (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.

        (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.

        (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for above changes.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

        (WTR::LayoutTestController::LayoutTestController): Initialize

        m_shouldDumpAllFrameScrollPositions.

        (WTR::LayoutTestController::shouldDumpMainFrameScrollPosition): Renamed from

        shouldDumpFrameScrollPositions.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Reorganized the file a

        bit, added dumpChildFrameScrollPositions and shouldDumpAllFrameScrollPositions,

        and renamed shouldDumpFrameScrollPositions to shouldDumpMainFrameScrollPosition.

2010-07-21  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WebKitTestRunner needs to support dumping of scroll position

        https://bugs.webkit.org/show_bug.cgi?id=42514

        * MiniBrowser/mac/WebBundle/WebBundleMain.m:

        (_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

        (WTR::InjectedBundlePage::_didClearWindowForFrame): Use JSGlobalContextRef

        instead of JSContextRef.

        (WTR::InjectedBundlePage::dump): Call dumpFrameScrollPosition when appropriate.

        (WTR::numericWindowProperty): Added. Helper for dumpFrameScrollPosition.

        (WTR::InjectedBundlePage::dumpFrameScrollPosition): Added.

        (WTR::InjectedBundlePage::didClearWindowForFrame): Use JSGlobalContextRef

        instead of JSContextRef.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Removed names from

        arguments that simply repeat the argument type. Added dumpFrameScrollPosition.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

        (WTR::LayoutTestController::shouldDumpDOMAsWebArchive): Added. Currently

        returns false.

        (WTR::LayoutTestController::shouldDumpSourceAsWebArchive): Added. Currently

        returns false.

        (WTR::LayoutTestController::shouldDumpFrameScrollPositions): Added. Matches

        the logic in DumpRenderTree.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for above changes.

        * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added property svn:ignore.

2010-07-21  Kevin Ollivier  <kevino@theolliviers.com>

        [wx] Build fix, adding the WebCore/bindings/generic dir to the list of build dirs.

        * wx/build/settings.py:

2010-07-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Patch for https://bugs.webkit.org/show_bug.cgi?id=42539

        WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

        (WTR::InjectedBundlePage::InjectedBundlePage):

        (WTR::InjectedBundlePage::_willAddMessageToConsole):

        (WTR::InjectedBundlePage::_willSetStatusbarText):

        (WTR::InjectedBundlePage::_willRunJavaScriptAlert):

        (WTR::InjectedBundlePage::_willRunJavaScriptConfirm):

        (WTR::InjectedBundlePage::_willRunJavaScriptPrompt):

        (WTR::InjectedBundlePage::willAddMessageToConsole):

        (WTR::InjectedBundlePage::willSetStatusbarText):

        (WTR::InjectedBundlePage::willRunJavaScriptAlert):

        (WTR::InjectedBundlePage::willRunJavaScriptConfirm):

        (WTR::InjectedBundlePage::willRunJavaScriptPrompt):

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

2010-07-21  Adam Roben  <aroben@apple.com>

        Give InjectedBundle our standard set of configurations (minus the

        *_Cairo variants)

        InjectedBundle's Debug_All configuration was the same as is Debug

        configuration, and it was missing a Debug_Internal configuration.

        Fixes <http://webkit.org/b/42749> InjectedBundle's build

        configurations are screwy

        Reviewed by Darin Adler.

        * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added

        debug_internal.vsprops and debug_all.vsprops to the Debug_All

        configuration. Added a Debug_Internal configuration.

        * WebKitTestRunner/WebKitTestRunner.sln: Build the Debug_Internal

        variant of InjectedBundle when we're using the Debug_Internal solution

        configuration.

2010-07-21  Adam Roben  <aroben@apple.com>

        Move InjectedBundle's settings to a vsprops file

        This will make it easier to change settings for all configurations,

        and to add new configurations.

        Fixes <http://webkit.org/b/42748> InjectedBundle should use vsprops

        files

        Reviewed by Darin Adler.

        * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added.

        Moved settings here...

        * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: ...from

        here.

2010-07-21  Adam Roben  <aroben@apple.com>

        Give MiniBrowser our standard set of configurations (minus the *_Cairo

        variants)

        MiniBrowser already had a configuration called "Release", but it was

        using mostly the same settings as Debug. And its Debug configuration

        was using the settings that Debug_Internal should be using.

        Fixes <http://webkit.org/b/42746> MiniBrowser's build configurations

        are screwy

        Reviewed by Darin Adler.

        * MiniBrowser/MiniBrowser.vcproj: Removed debug_internal.vsprops from

        the Debug configuration. Remove debug.vsprops and

        debug_internal.vsprops from the Release configuration and replace them

        with release.vsprops. Added Debug_Internal and Debug_All

        configurations.

2010-07-21  Adam Roben  <aroben@apple.com>

        Move MiniBrowser's settings to a vsprops file

        This will make it easier to change settings for all configurations,

        and to add new configurations.

        MiniBrowser should use vsprops files

        https://bugs.webkit.org/show_bug.cgi?id=42745

        Reviewed by Darin Adler.

        * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added. Moved

        settings here...

        * MiniBrowser/MiniBrowser.vcproj: ...from here.

2010-07-21  Adam Roben  <aroben@apple.com>

        Fix compiler warnings when building MiniBrowser

        Also cleaned up the .vcproj a bit.

        Fixes <http://webkit.org/b/42743>.

        Reviewed by Darin Adler.

        * MiniBrowser/MiniBrowser.vcproj: Removed all settings that are

        already defined in .vsprops files. This also fixes a warning about

        /EDITANDCONTINUE being incompatible with /SAFESEH.

        * MiniBrowser/win/MiniBrowser.rc: Replaced afxres.h with winresrc.h so

        that we stop getting warnings about ID_FILE_OPEN and ID_FILE_CLOSE

        being redefined. (I think this will also get us closer to building

        with VC++ Express.)

2010-07-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Jon Honeycutt.

        Fix obvious typo.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

        (WTR::InjectedBundlePage::setStatusbarText): Need to call ->data() to actually get the string value.

2010-07-20  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] by default, dumpAsText should disable pixel results

        https://bugs.webkit.org/show_bug.cgi?id=42715

        * DumpRenderTree/chromium/LayoutTestController.cpp:

        (LayoutTestController::dumpAsText): disable pixel results, but allow JS to override

2010-07-20  Adam Roben  <aroben@apple.com>

        Windows build fix

        * MiniBrowser/MiniBrowser.vcproj: Link against the new, shiny

        WebKit.lib instead of the old, dusty WebKit2.lib.

2010-07-20  Adam Roben  <aroben@apple.com>

        Stop linking WebKitTestRunner against getopt

        Use of getopt was removed in r63700.

        Fixes <http://webkit.org/b/42714> WebKitTestRunner links against

        getopt, but doesn't need to

        Reviewed by Sam Weinig.

        * WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed getopt.lib

        from all configurations.

2010-07-20  Adam Roben  <aroben@apple.com>

        Make run-webkit-tests --webkit-test-runner "work" on Windows

        WebKitTestRunner crashes on launch, but at least the scripts build and

        launch it!

        Fixes <http://webkit.org/b/42709> run-webkit-tests

        --webkit-test-runner bails with an error on Windows

        Reviewed by Anders Carlsson.

        * Scripts/build-webkittestrunner: Build WebKitTestRunner.sln on

        Windows.

        * WebKitTestRunner/WebKitTestRunner.sln: Added. Contains the following

        projects (from first-built to last-built): FindSafari, ImageDiff,

        InjectedBundleGenerated, InjectedBundle, WebKitTestRunner.

2010-07-20  Adam Roben  <aroben@apple.com>

        Change build-webkit back to building WebKit.sln on Windows

        WebKit.sln builds all the same projects as WebKit2.sln, and the latter

        is being removed.

        Rubber-stamped in advance by Steve Falkenburg.

        * Scripts/build-webkit:

2010-07-20  Adam Roben  <aroben@apple.com>

        Windows build fix