2010-07-16  Zhe Su  <suzhe@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms

        https://bugs.webkit.org/show_bug.cgi?id=42253

        Dummy implementation of EditorClient::willSetInputMethodState.

        * WebCoreSupport/EditorClientGtk.cpp:

        (WebKit::EditorClient::willSetInputMethodState):

        * WebCoreSupport/EditorClientGtk.h:

2010-07-16  Nate Chapin  <japhet@chromium.org>

        Reviewed by Darin Fisher.

        Uncomment an assert that broke due to r63100.

        https://bugs.webkit.org/show_bug.cgi?id=42298

        * tests/testwebview.c:

2010-07-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Patch for https://bugs.webkit.org/show_bug.cgi?id=42232

        Make changing Cursors work in WebKit2.

        * WebCoreSupport/ChromeClientGtk.cpp:

        (WebKit::ChromeClient::setCursor):

        * WebCoreSupport/ChromeClientGtk.h:

        Change prototype to match new one.

2010-07-12  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] r63100 broke the testwebview test

        https://bugs.webkit.org/show_bug.cgi?id=42114

        * tests/testwebview.c: Disable a failing assertion in test_webkit_web_view_adjustments

        until we can get to the bottom of the failure.

2010-07-12  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Update for 1.3.3

        * NEWS:

2010-07-12  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Fix compilation with sealed GTK+.

        * webkit/webkitwebview.cpp:

        (webkit_web_view_drag_motion):

        (webkit_web_view_drag_data_received):

        (webkit_web_view_drag_drop):

2010-07-11  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] WebKitWebView should support drops

        https://bugs.webkit.org/show_bug.cgi?id=39843

        Add support for dropping content onto GTK+ WebViews.

        * webkit/webkitprivate.h:

        Add a DroppingContext struct to keep track of drop data while the drop is

        in progress. Have WebKitWebView keep a map of GdkDragContexts to DroppingContexts.

        * webkit/webkitwebview.cpp: Add necessary includes and globalPointForClientPoint helper.

        (webkit_web_view_popup_menu_handler): Use globalPointForClientPoint helper.

        (webkit_web_view_dispose): Properly clean up droppingContexts member.

        (webkit_web_view_finalize): Delete droppingContext member.

        (globalPointForClientPoint): Added.

        (doDragLeaveLater): Added.

        (webkit_web_view_drag_leave): Added.

        (webkit_web_view_drag_motion): Added.

        (webkit_web_view_drag_data_received): Added.

        (webkit_web_view_drag_drop): Added.

        (webkit_web_view_class_init): Connect new drop signal handlers to the widget definition.

        (webkit_web_view_init): Set up the widget as a drop destination and initialize droppingContexts.

2010-07-07  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Patch for https://bugs.webkit.org/show_bug.cgi?id=41772

        Add basic piping for BackForwardControllerClient.

        * webkit/webkitwebview.cpp:

        (webkit_web_view_init):

2010-06-19  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: js function name was fixed.

        dispatchMessageToFrontend -> dispatchMessageFromBackend.

        https://bugs.webkit.org/show_bug.cgi?id=40675

        * WebCoreSupport/InspectorClientGtk.cpp:

        (WebKit::InspectorClient::sendMessageToFrontend):

2010-06-23  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Separate DerivedSources per-project

        https://bugs.webkit.org/show_bug.cgi?id=41109

        Separate WebKitGTK+ DerivedSources into per-project subdirectories to prepare

        for properly building WebKit2.

        * webkitmarshal.list: Touch this file to force a rebuild of the marshaling code.

2010-07-01  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Stop using GdkRegion in 3.x mode

        https://bugs.webkit.org/show_bug.cgi?id=41463

        Make us compile without using GdkRegion, since it's gone from GTK+

        3.x.

        * WebCoreSupport/ChromeClientGtk.cpp:

        (WebKit::ChromeClient::scroll):

        * webkit/webkitwebview.cpp:

        (webkit_web_view_expose_event):

2010-07-01  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Convert WebKitWebView's private draggingDataObjects member to a pointer

        https://bugs.webkit.org/show_bug.cgi?id=40333

        Convert draggingDataObjects to a pointer. The constructor and destructor of the

        HashMap should be called explicitly. GObject memory allocation does not do this.

        * WebCoreSupport/DragClientGtk.cpp:

        (WebKit::DragClient::startDrag):

        * webkit/webkitprivate.h:

        * webkit/webkitwebview.cpp:

        (webkit_web_view_dispose):

        (webkit_web_view_drag_end):

        (webkit_web_view_drag_data_get):

        (webkit_web_view_init):

2010-06-30  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed, rolling out r62226.

        http://trac.webkit.org/changeset/62226

        https://bugs.webkit.org/show_bug.cgi?id=40333

        This change caused 13 new crashers.

        * WebCoreSupport/DragClientGtk.cpp:

        (WebKit::DragClient::startDrag):

        * webkit/webkitprivate.h:

        * webkit/webkitwebview.cpp:

        (webkit_web_view_dispose):

        (webkit_web_view_drag_end):

        (webkit_web_view_drag_data_get):

        (webkit_web_view_init):

2010-06-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Convert WebKitWebView's private draggingDataObjects member to a pointer

        https://bugs.webkit.org/show_bug.cgi?id=40333

        Convert draggingDataObjects to a pointer. The constructor and destructor of the

        HashMap should be called explicitly. GObject memory allocation does not do this.

        * WebCoreSupport/DragClientGtk.cpp:

        (WebKit::DragClient::startDrag):

        * webkit/webkitprivate.h:

        * webkit/webkitwebview.cpp:

        (webkit_web_view_dispose):

        (webkit_web_view_drag_end):

        (webkit_web_view_drag_data_get):

        (webkit_web_view_init):

2010-06-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Unit test for DOM insertion methods

        https://bugs.webkit.org/show_bug.cgi?id=40495

        Add unit test for webkit_dom_node_remove_child.

        * tests/testdomnode.c:

        (test_dom_node_insertion):

2010-06-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Unit test for DOM insertion methods

        https://bugs.webkit.org/show_bug.cgi?id=40495

        Add unit tests for node insertion and replacement methods.

        * tests/testdomnode.c:

        (test_dom_node_insertion):

        (main):

2010-06-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Random failure on 'testdownload' unit test

        https://bugs.webkit.org/show_bug.cgi?id=38256

        Make sure the set_filename function is called after handling the

        'download-requested' signal for the asynchronous test. This change

        is needed because it could happen, with the current code, that the

        set_filename () function got called too early in the mainloop,

        therefore screwing the tests because the 'theDownload' global

        variable wouldn't be properly set yet.

        With this modification we ensure the set_filename() function gets

        called always after handling the download-requested signal,

        therefore avoiding potentialproblems.

        * tests/testdownload.c:

        (set_filename):

        (handle_download_requested_cb):

        (download_requested_cb):

        (download_requested_asynch_cb):

        (test_webkit_download_perform):

2010-06-30  José Millán Soto  <jmillan@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Text attributes not exposed

        https://bugs.webkit.org/show_bug.cgi?id=25528

        Added new tests for accessible text attributes

        * tests/testatk.c:

        (compAtkAttribute):

        (compAtkAttributeName):

        (atkAttributeSetAttributeHasValue):

        (atkAttributeSetAreEqual):

        (testWebkitAtkTextAttributes):

        (main):

2010-06-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Update for 1.3.2.

        * NEWS:

2010-06-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Does not compile with -DGSEAL_ENABLE

        https://bugs.webkit.org/show_bug.cgi?id=37851

        Fix build with GSEAL enabled.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:

        (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):

        * webkit/webkitsoupauthdialog.c:

        (show_auth_dialog):

2010-06-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Add support for GTK+3

        https://bugs.webkit.org/show_bug.cgi?id=41253

        Adapt build system to 3.x support, allow the JSCore gir and webkit

        pc files to be configurable at build time for different API

        versions.

        * JSCore-1.0.gir: Removed.

        * JSCore.gir.in: Added.

        * docs/GNUmakefile.am:

        * webkit.pc.in:

2010-06-25  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Implement atk_table_get_column_header

        https://bugs.webkit.org/show_bug.cgi?id=30896

        Replace g_timeout_add() with g_idle_add().

        * tests/testatk.c:

        (test_webkit_atk_get_text_at_offset_forms):

        (test_webkit_atk_get_text_at_offset):

        (test_webkit_atk_get_text_at_offset_newlines):

        (test_webkit_atk_get_text_at_offset_textarea):

        (test_webkit_atk_get_text_at_offset_text_input):

        (testWebkitAtkGetTextInParagraphAndBodySimple):

        (testWebkitAtkGetTextInParagraphAndBodyModerate):

        (testWebkitAtkGetTextInTable):

        (testWebkitAtkGetHeadersInTable):

2010-06-25  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Implement atk_table_get_column_header

        https://bugs.webkit.org/show_bug.cgi?id=30896

        Added new test to check whether the implementation of

        get_column_headers() and get_row_headers() works ok.

        * tests/testatk.c:

        (testWebkitAtkGetHeadersInTable):

        (main):

2010-06-25  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Pasteboard code does not take into account the nil character when getting and setting markup/netscape-url data

        https://bugs.webkit.org/show_bug.cgi?id=41221

        Add a test for this issue which simulates a paste keyboard event into an editable

        body. The pasteboard should contain a markup portion containing a null terminator.

        * tests/testcopyandpaste.c:

        (test_info_new):

        (test_info_destroy):

        (load_status_cb):

        (runPasteTestCallback):

        (window_object_cleared_callback):

        (pasting_test_get_data_callback):

        (pasting_test_clear_data_callback):

        (test_pasting_markup):

        (main):

2010-06-24  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Cannot change the selection via the keyboard

        https://bugs.webkit.org/show_bug.cgi?id=41162

        Fix issue where the selection could not be extended via the keyboard by

        adjusting the logic guarding against inserting text in non-editable nodes.

        * WebCoreSupport/EditorClientGtk.cpp:

        (WebKit::EditorClient::handleKeyboardEvent):

        Allow editor commands that do not insert text in non-editable nodes. This

        fixes keyboard selection extension in non-editable nodes. Move the existing

        check to after the execution of any editor commands.

2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>

        Reviewed by Adam Barth.

        Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.

        https://bugs.webkit.org/show_bug.cgi?id=39041

        * webkit/webkitwebview.cpp:

        (webkit_web_view_update_settings):

        (webkit_web_view_settings_notify):

        (webkit_get_cache_model):

2010-06-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT

        https://bugs.webkit.org/show_bug.cgi?id=40600

        * WebCoreSupport/DragClientGtk.cpp: 

        (WebKit::DragClient::startDrag): Reset the click count after a drag starts.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:

        (WebKit::postCommitFrameViewSetup): Reset the click count after a load is committed.

        * webkit/webkitprivate.h: Move static click counting variables to be per-view.

        * webkit/webkitwebview.cpp: 

        (getEventTime): Added.

        (webkit_web_view_button_press_event): If the event time is zero, use the current time.

        (webkit_web_view_finalize): Clean up click counting member.

        (webkit_web_view_init): Initialize click counting member.

2010-06-15  Xan Lopez  <xlopez@igalia.com>

        Fix compilation with older GTK+.

        * WebCoreSupport/ChromeClientGtk.cpp:

        (WebKit::ChromeClient::pageRect):

2010-06-15  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Does not compile with -DGSEAL_ENABLE

        https://bugs.webkit.org/show_bug.cgi?id=37851

        Fix compilation with GSEAL_ENABLE.

        * WebCoreSupport/ChromeClientGtk.cpp:

        (WebKit::ChromeClient::pageRect):

        (WebKit::ChromeClient::contentsSizeChanged):

        * tests/testdomnode.c:

        (test_dom_node_insertion):

        * webkit/webkitwebview.cpp:

        (webkit_web_view_realize):

        (webkit_web_view_script_dialog):

        (webkit_web_view_drag_end):

        (webkit_web_view_init):

2010-06-14  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed build fix.

        This is a fix for flaky inspector tests at gtk-debug bots.

        * WebCoreSupport/InspectorClientGtk.cpp:

        (WebKit::InspectorFrontendClient::destroyInspectorWindow):

2010-06-14  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc

        data from inspected page to WebInspector as JSON string via http. The native

        serialization to JSON string is supported by InspectorValue's classes. This patch

        has the implementation of sendMessageToFrontend function. WebKit version of it still

        uses ScriptFunctionCall and will be switched to another transport a little bit later.

        https://bugs.webkit.org/show_bug.cgi?id=40134

        * WebCoreSupport/InspectorClientGtk.cpp:

        (WebKit::InspectorClient::releaseFrontendPage):

        (WebKit::InspectorClient::sendMessageToFrontend):

        * WebCoreSupport/InspectorClientGtk.h:

2010-06-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Reduce FrameView.h includes to speed up build times

        https://bugs.webkit.org/show_bug.cgi?id=40408

        * webkit/webkitwebinspector.cpp:

         - Include RenderLayer.h

2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r60889.

        http://trac.webkit.org/changeset/60889

        https://bugs.webkit.org/show_bug.cgi?id=40365

        gtk bot has some kind of memory corruption (Requested by

        loislo on #webkit).

        * WebCoreSupport/InspectorClientGtk.cpp:

        (WebKit::InspectorClient::InspectorClient):

        (WebKit::InspectorClient::openInspectorFrontend):

        (WebKit::InspectorFrontendClient::InspectorFrontendClient):

        (WebKit::InspectorFrontendClient::destroyInspectorWindow):

        * WebCoreSupport/InspectorClientGtk.h:

2010-06-07  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc

        data from inspected page to WebInspector as JSON string via http. The native

        serialization to JSON string is supported by InspectorValue's classes. This patch

        has the implementation of sendMessageToFrontend function. WebKit version of it still

        uses ScriptFunctionCall and will be switched to another transport a little bit later.

        https://bugs.webkit.org/show_bug.cgi?id=40134

        * WebCoreSupport/InspectorClientGtk.cpp:

        (WebKit::InspectorClient::releaseFrontendPage):

        (WebKit::InspectorClient::sendMessageToFrontend):

        * WebCoreSupport/InspectorClientGtk.h:

2010-06-08  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Unit testing for WebKitDOMNode hierarchy walk

        https://bugs.webkit.org/show_bug.cgi?id=40171

        Add some DOM node unit testing.

        * tests/testdomnode.c: Added.

        (finish_loading):

        (dom_node_fixture_setup):

        (dom_node_fixture_teardown):

        (test_dom_node_hierarchy_navigation):

        (main):

2010-06-08  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Ojan Vafai and Darin Adler.

        Refactor platform dependent editing behavior code out of Settings

        https://bugs.webkit.org/show_bug.cgi?id=39854

        EditingBehavior enum was renamed to EditingBehaviorTypes and moved out from Settings.h to

        EditingBehaviorTypes.h . Call sites in WebKit/ adjusted accordingly.

        * webkit/webkitprivate.cpp:

        (WebKit::core):

        * webkit/webkitprivate.h:

        * webkit/webkitwebview.cpp:

        (webkit_web_view_update_settings):

        (webkit_web_view_settings_notify):

2010-06-08  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.