1 === Start merge of feature-branch 2007-10-12 ===

     2 

     3 2007-10-03  Andrew Wellington  <proton@wiretapped.net>

     4 

     5         Reviewed by Mark Rowe.

     6         

     7         Mac build fix for issue introduced in r26027

     8 

     9         * WebCoreSupport/WebSystemInterface.m:

    10         (InitWebCoreSystemInterface):

    11 

    12 2007-10-01  Eric Seidel  <eric@webkit.org>

    13 

    14         Reviewed by Oliver Hunt.

    15         

    16         SVG Subresources will not be saved when creating WebArchives

    17         http://bugs.webkit.org/show_bug.cgi?id=15280

    18         

    19         Implement _subresourceURLs methods for more SVGElement types

    20         more such methods will be needed as we add support for other

    21         external references (such as use, mpath, tref, etc.)

    22 

    23         * DOM/WebDOMOperations.mm:

    24         (-[DOMSVGScriptElement _subresourceURLs]): added.

    25         (-[DOMSVGCursorElement _subresourceURLs]): added.

    26         (-[DOMSVGFEImageElement _subresourceURLs]): added.

    27 

    28 2007-10-01  Eric Seidel  <eric@webkit.org>

    29 

    30         Reviewed by Oliver Hunt.

    31         

    32         WebArchives do not embed stylesheets referenced by xml-stylesheeet

    33         http://bugs.webkit.org/show_bug.cgi?id=15320

    34 

    35         * DOM/WebDOMOperations.mm:

    36         (-[DOMProcessingInstruction _stylesheetURL]): needed to access [[self sheet] href]

    37         (-[DOMProcessingInstruction _subresourceURLs]): call and return _stylesheetURL

    38 

    39 2007-10-01  Eric Seidel  <eric@webkit.org>

    40 

    41         Reviewed by Oliver Hunt.

    42 

    43         * DOM/WebDOMOperations.mm: added DOMSVGElementImage _subresources implementation

    44         (-[DOMNode _URLsFromSelectors:]): now handles DOMSVGAnimatedString return values

    45         (-[DOMSVGImageElement _subresourceURLs]): added.

    46         * MigrateHeaders.make: copies DOMSVG* headers into WebKit/PrivateHeaders

    47 

    48 2007-10-01  Oliver Hunt  <oliver@apple.com>

    49 

    50         Reviewed by Mark.

    51 

    52         Enable Experimental SVG features by default when building from Xcode

    53 

    54         * Configurations/WebKit.xcconfig:

    55 

    56 === End merge of feature-branch 2007-10-12 ===

    57 

    58 2007-10-11  Mark Rowe  <mrowe@apple.com>

    59 

    60         Reviewed by Tim Hatcher.

    61 

    62         Fix for <rdar://problem/5488678>.  Disable debugging symbols in production builds for 10.4

    63         PowerPC to prevent a huge STABS section from being generated.

    64 

    65         * Configurations/Base.xcconfig:

    66 

    67 2007-10-10  Alice Liu  <alice.liu@apple.com>

    68 

    69         Reviewed by Geoff Garen.

    70 

    71         Fixed <rdar://5464402> Crash when running fast/frames/onload-remove-iframe-crash.html in DRT

    72         createFrame() now returns a RefPtr instead of a raw Frame pointer. 

    73         Making this change improves the way we handle frames on Windows WebKit. 

    74 

    75         * WebCoreSupport/WebFrameLoaderClient.h:

    76         * WebCoreSupport/WebFrameLoaderClient.mm:

    77         (WebFrameLoaderClient::createFrame):

    78 

    79 2007-10-04  Beth Dakin  <bdakin@apple.com>

    80 

    81         Reviewed by John Sullivan.

    82 

    83         Fix for <rdar://problem/5441823> REGRESSION (r25142, Tiger only): 

    84         Vertical scroll bar not redrawn properly when going back in history 

    85         (15033)

    86 

    87         This fix if-defs r25142 to be Leopard-only since it causes 

    88         correctness issues on Tiger and does not seem to have any 

    89         performance impact on Tiger either.

    90 

    91         * WebView/WebDynamicScrollBarsView.m:

    92         (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]):

    93         (-[WebDynamicScrollBarsView reflectScrolledClipView:]):

    94 

    95 2007-10-04  Mark Rowe  <mrowe@apple.com>

    96 

    97         Reviewed by Oliver.

    98 

    99         Switch to default level of debugging symbols to resolve <rdar://problem/5488678>.

   100         The "full" level appears to offer no observable benefits even though the documentation

   101         suggests it be used for dead code stripping.  This should also decrease link times.

   102 

   103         * Configurations/Base.xcconfig:

   104 

   105 2007-10-04  Adele Peterson  <adele@apple.com>

   106 

   107         Reviewed by Darin.

   108 

   109         WebKit part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content

   110 

   111         * WebView/WebHTMLView.mm: (-[WebHTMLView becomeFirstResponder]): Pass in the FocusDirection.

   112 

   113 2007-10-04  Darin Adler  <darin@apple.com>

   114 

   115         * WebView/WebHTMLView.mm: (-[WebHTMLView _updateActiveState]):

   116         Removed a bogus comment.

   117 

   118 2007-10-02  Kevin Decker  <kdecker@apple.com>

   119 

   120         Reviewed by Mark Rowe.

   121 

   122         Re-added _minimumRequiredSafariBuildNumber. It turns out older version of Safari still rely

   123         on this method, so we need to keep it around at least until the next major Safari release.

   124 

   125         * StringsNotToBeLocalized.txt:

   126         * WebView/WebView.mm:

   127         (+[WebView _minimumRequiredSafariBuildNumber]):

   128         * WebView/WebViewPrivate.h:

   129 

   130 2007-10-02  Kevin Decker  <kdecker@apple.com>

   131 

   132         Reviewed by John Sullivan.

   133 

   134         <rdar://problem/5517710> 

   135 

   136         * WebView/WebView.mm: Removed -[WebView _minimumRequiredSafariBuildNumber] because newer

   137          versions of Safari no longer use this method. This won't break existing Safaris because

   138          they always use a respondsToSelector check before calling this.

   139          

   140         * WebView/WebViewPrivate.h: Ditto. 

   141 

   142 2007-09-27  John Sullivan  <sullivan@apple.com>

   143 

   144         Reviewed by Ollie

   145         

   146         - fixed <rdar://problem/5408186> REGRESSION (5522-5523.9): Safari leaks every browser window

   147         

   148         The leak started occurring when we removed the code to clear the delegates and the host window

   149         from Safari as part of the fix for 5479443. But it turns out that Safari code was masking a

   150         bug here in WebView: setHostWindow:nil needs to be called before setting _private->closed to

   151         YES, or it will do nothing at all, causing a world leak due to a circular reference between

   152         the window and the WebView.

   153         

   154         I toyed with a more complex fix, but this is the simplest one that retains the fix for 5479443

   155         while otherwise restoring the code order to be as close as possible to what it was before

   156         5479443 was fixed.

   157 

   158         * WebView/WebView.mm:

   159         (-[WebView _close]):

   160         Moved the call that sets _private->closed to YES to be after the code that clears the delegates

   161         and the host window. Added a comment about this order.

   162 

   163 2007-09-27  Kevin Decker  <kdecker@apple.com>

   164 

   165         Rubber stamped by Darin.

   166 

   167         <rdar://problem/5493093>

   168 

   169         * WebKit.order: Added.

   170         * WebKit.xcodeproj/project.pbxproj:  We're changing from using an order file built by

   171          another team to using one we actually check into our project repository. Linker settings for

   172          Symbol Ordering Flags have been updated accordingly.

   173 

   174 2007-09-26  Geoffrey Garen  <ggaren@apple.com>

   175 

   176         Reviewed by Adele Peterson.

   177         

   178         Fixed <rdar://problem/5507476> Promote cache model SPI to API

   179         

   180         Promoted cache model SPI to API. This was just a move, with some small 

   181         edits to the documentation (changing 'application' to 'WebView' in 

   182         some cases, since the interface is now per-WebView).

   183 

   184         * WebView/WebPreferences.h:

   185         * WebView/WebPreferences.m:

   186         (-[WebPreferences setCacheModel:]):

   187         (-[WebPreferences cacheModel]):

   188         * WebView/WebPreferencesPrivate.h:

   189 

   190 2007-09-24  Timothy Hatcher  <timothy@apple.com>

   191 

   192         Reviewed by Darin.

   193 

   194         <rdar://problem/5498016> Photoshop CS3: Adobe Help Viewer 1.1 crashes in 9A553

   195 

   196         WebKit started calling the mouseDidMoveOverElement delegate method with a nil dictionary in r14982.

   197         We originally intended to call this delegate method sometimes with a nil dictionary, but due to

   198         a bug dating back to WebKit 1.0 this delegate was never called with nil! Unfortunately we can't

   199         start calling this with nil since it will break Adobe Help Viewer, and possibly other clients.

   200 

   201         * WebView/WebView.mm:

   202         (-[WebView _mouseDidMoveOverElement:modifierFlags:]):

   203 

   204 2007-09-21  Kevin Decker  <kdecker@apple.com>

   205 

   206         * Plugins/WebBaseNetscapePluginView.mm: Build fix. 

   207         The first argument of aglChoosePixelFormat() has changed from const AGLDevice *gdevs on Tiger to

   208         const void *gdevs on Leopard.

   209 

   210 2007-09-20  Kevin Decker  <kdecker@apple.com>

   211 

   212         Reviewed by Darin Adler.

   213 

   214         <rdar://problem/5493093>

   215 

   216         Reduced launch time by lazily linking both the AGL and OpenGL frameworks until they are really needed.

   217 

   218         * Plugins/WebBaseNetscapePluginView.mm: Soft link all AGL and OpenGL functions used by

   219         WebBaseNetscapePluginView.

   220 

   221         * WebKit.xcodeproj/project.pbxproj: Removed AGL and OpenGL from the project.

   222 

   223 2007-09-20  John Sullivan  <sullivan@apple.com>

   224 

   225         Build fix for stoooopid old PPC gcc compiler

   226 

   227         * WebCoreSupport/WebEditorClient.mm:

   228         (WebEditorClient::checkSpellingOfString):

   229         replace perfectly valid ?: syntax with if/else

   230 

   231 2007-09-19  John Sullivan  <sullivan@apple.com>

   232 

   233         Reviewed by Darin Adler.

   234 

   235         - WebKit part of speculative fix for <rdar://problem/5490627>, about crashes constructing a

   236           String using the values filled in by checkSpellingOfString()

   237 

   238         * WebCoreSupport/WebEditorClient.mm:

   239         (WebEditorClient::checkSpellingOfString):

   240         convert NSNotFound to -1, since WebCore code expects -1 for this purpose. We already do this

   241         in checkGrammarOfString.

   242 

   243 2007-09-19  Kevin Decker  <kdecker@apple.com>

   244 

   245         Reviewed by Darin Adler.

   246 

   247         <rdar://problem/5491066> soft link Accelerate.framework

   248         

   249         * Misc/WebGraphicsExtras.c:

   250         (WebConvertBGRAToARGB): Improve launch time performance and reduce vsize

   251         footprint by soft linking the Accelerate.framework.

   252         * WebKit.xcodeproj/project.pbxproj: Remove no longer needed frameworks.

   253 

   254 2007-09-18  Geoffrey Garen  <ggaren@apple.com>

   255 

   256         Reviewed by Darin Adler.

   257         

   258         Fixed <rdar://problem/5490204> In some cases, WebKit can make the 

   259         Foundation disk cache way too big or way too small

   260         

   261         Use the actual location of the foundation disk cache, rather than 

   262         the user's home directory, when determining how big to make it.

   263 

   264         * WebView/WebView.mm:

   265         (+[WebView _setCacheModel:]):

   266 

   267 2007-09-17  Geoffrey Garen  <ggaren@apple.com>

   268 

   269         Reviewed by Darin Adler.

   270 

   271         Fixed a hang due to an infinite script running in the window's unload 

   272         event handler, which may be the cause of <rdar://problem/5479443> 

   273         REGRESSION: Hang due to infinite JS recursion on close @ engadget.com 

   274         (onunload-based ad)

   275 

   276         * WebView/WebUIDelegatePrivate.h: Added FIXME.

   277         

   278         * WebView/WebView.h: Clarified headerdoc ambiguity about when delegate 

   279         methods stop firing.

   280 

   281         * WebView/WebView.mm:

   282         (-[WebView _close]): The fix: don't nil out our delegates until after

   283         detaching the FrameLoader, because the act of detaching the FrameLoader

   284         might fire important delegate methods, like webViewShouldInterruptJavaScript:.

   285         Don't do other tear-down either, because the unload event handler needs 

   286         to run in a fully constructed page.

   287         

   288         This change is fairly low risk because niling out our delegates is a 

   289         very recent, never-shipped feature in WebKit, so it's unlikely that any 

   290         apps rely on it in a crazy way.

   291 

   292 2007-09-15  Darin Adler  <darin@apple.com>

   293 

   294         Reviewed by John Sullivan.

   295 

   296         - fix <rdar://problem/5391540> REGRESSION: Can't drag images from Safari to applications

   297           in the dock (Tiger Preview, others in Leopard)

   298 

   299         * Misc/WebNSPasteboardExtras.mm:

   300         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):

   301         Re-implement code here that has been missing for the last couple of years since we

   302         did some image refactoring. Was pretty easy now that we can freely call C++ code

   303         in WebKit.

   304 

   305 2007-09-14  Mark Rowe  <mrowe@apple.com>

   306 

   307         Build fix for Tiger.

   308 

   309         * WebView/WebArchive.m:

   310         (-[WebArchive initWithCoder:]): Use @catch(id) rather than @catch(...).

   311         * WebView/WebPreferences.m:

   312         (-[WebPreferences initWithCoder:]): Ditto.

   313         * WebView/WebResource.mm:

   314         (-[WebResource initWithCoder:]): Ditto.

   315         (-[WebResource _initWithPropertyList:]): Ditto.

   316 

   317 2007-09-14  Darin Adler  <darin@apple.com>

   318 

   319         Reviewed by Geoff Garen and Tim Hatcher.

   320 

   321         - fixed <rdar://problem/5482745> initFromCoder: and initWithPropertyList: functions

   322           should guard against incorrect types

   323 

   324         * WebView/WebArchive.m:

   325         (isArrayOfClass): Added helper function.

   326         (-[WebArchive _initWithPropertyList:]): Tweaked function to remove the need for a

   327         type cast.

   328         (-[WebArchive initWithCoder:]): Added type checking for the main resource,

   329         subresources array, and subframe archives array. Also replaced NS_DURING with @try.

   330         * WebView/WebPreferences.m: (-[WebPreferences initWithCoder:]): Added type checking

   331         for the identifier and the values dictionary, including ensuring that it's a mutable

   332         dictionary.

   333         * WebView/WebResource.mm:

   334         (-[WebResource initWithCoder:]): Added type checking for all the fields.

   335         (-[WebResource _initWithPropertyList:]): Added type checking for the NSURLResponse.

   336 

   337         * WebKit.exp: Removed accidentally exported internal symbol; I checked and it's not

   338         used anywhere.

   339 

   340 2007-09-13  Darin Adler  <darin@apple.com>

   341 

   342         Reviewed by Oliver.

   343 

   344         - fix <rdar://problem/5470457> REGRESSION: Input method inline hole is mishandled in text

   345           <input> elements with maxlength limit

   346 

   347         * WebView/WebHTMLView.mm:

   348         (-[WebHTMLView _selectionChanged]): Tweaked code a bit.

   349         (-[WebHTMLView markedRange]): Simplified logic, since markedTextNSRange works when there's

   350         no composition range.

   351         (-[WebHTMLView hasMarkedText]): Call directly to Editor instead of bridge.

   352         (-[WebHTMLView unmarkText]): Call new confirmComposition to make it clear that this is

   353         confirming text, not just unmarking it to discard it.

   354         (extractUnderlines): Added. Converts directly from an NSAttributedString to the

   355         CompositionUnderline vector that's used by WebCore.

   356         (-[WebHTMLView setMarkedText:selectedRange:]): Changed to use the new setComposition.

   357         (-[WebHTMLView insertText:]): Changed to use confirmComposition when appropriate, instead

   358         of relying on special behavior of Editor::insertText.

   359         (-[WebHTMLView _updateSelectionForInputManager]): Rewrote to use getCompositionSelection

   360         and confirmCompositionWithoutDisturbingSelection.

   361 

   362         * WebCoreSupport/WebEditorClient.h:

   363         * WebCoreSupport/WebEditorClient.mm:

   364         Removed obsolete markedTextAbandoned function.

   365  

   366 2007-09-12  David Kilzer  <ddkilzer@apple.com>

   367 

   368         Rubber-stamped by Darin and reviewed by Adam.

   369 

   370         Removed import of unused icon database headers.

   371 

   372         * WebCoreSupport/WebFrameBridge.mm:

   373 

   374 2007-09-11  Timothy Hatcher  <timothy@apple.com>

   375 

   376         Reviewed by Darin.

   377 

   378         Remove the unused class_getMethodImplementation function.

   379 

   380         * Misc/WebNSObjectExtras.h:

   381 

   382 2007-09-11  Geoffrey Garen  <ggaren@apple.com>

   383 

   384         Reviewed by Oliver Hunt.

   385         

   386         Fixed CFNetwork version check so it actually works.

   387 

   388         * Misc/WebKitVersionChecks.h:

   389         * WebView/WebView.mm:

   390         (+[WebView _setCacheModel:]): Don't use NSVersionOfLinkTimeLibrary because

   391         we don't link against CFNetwork directly, so it returns -1. Also, use

   392         the proper hex encoding instead of decimal numbers.

   393 

   394 2007-09-11  Darin Adler  <darin@apple.com>

   395 

   396         - redo fix for <rdar://problem/5472899> REGRESSION (TOT): Crash in FrameLoadDelegate loading stationery

   397 

   398         * WebView/WebView.mm:

   399         (getMethod): Added.

   400         (-[WebView _cacheResourceLoadDelegateImplementations]): Use getMethod.

   401         (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto.

   402 

   403 2007-09-11  Darin Adler  <darin@apple.com>

   404 

   405         Rubber-stamped by Dave Harrison.

   406 

   407         * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

   408         Removed wkCreateURLPasteboardFlavorTypeName and wkCreateURLNPasteboardFlavorTypeName.

   409 

   410 2007-09-11  Darin Adler  <darin@apple.com>

   411 

   412         Reviewed by Mark Rowe.

   413 

   414         - fix <rdar://problem/5472899> REGRESSION (TOT): Crash in FrameLoadDelegate loading stationery

   415 

   416         * Misc/WebNSObjectExtras.h:

   417         (class_getMethodImplementation): Added.

   418         (method_setImplementation): Added.

   419 

   420         * WebView/WebHTMLView.mm: (+[WebHTMLViewPrivate initialize]):

   421         * Carbon/HIViewAdapter.m: (+[HIViewAdapter bindHIViewToNSView:nsView:]):

   422         Remove old-ObjC code path, since WebNSObjectExtras.h now implements everything we need.

   423 

   424         * WebView/WebView.mm:

   425         (-[WebView _cacheResourceLoadDelegateImplementations]): Don't bother doing a separate

   426         respondsToSelector call, since class_getMethodImplementation will return 0 for selectors

   427         that we don't respond to. The bug fix is to actually set the cached pointer to 0.

   428         Also get rid of the unnecessary use of a macro; instead use the functions from

   429         WebNSObjectExtras.h on Tiger and the appropriate function directly on Leopard.

   430         (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto.

   431 

   432 2007-09-11  Darin Adler  <darin@apple.com>

   433 

   434         Reviewed by Sam, Ollie.

   435 

   436         * WebView/WebView.mm: (+[WebView _setCacheModel:]): A slightly cleaner 64-bit

   437         fix for the NSURLCache capacity code in this file.

   438 

   439 2007-09-11  Darin Adler  <darin@apple.com>

   440 

   441         Rubber-stamped by Mark Rowe.

   442 

   443         * Misc/WebNSPasteboardExtras.mm: Fix incorrect strings in my last check-in.

   444         The strings I checked in were wrong and were breaking layout tests too.

   445         These new ones match what WebKitSystemInterface was returning.

   446 

   447 2007-09-10  Geoffrey Garen  <ggaren@apple.com>

   448 

   449         Fixed 64-bit build (I think).

   450 

   451         * WebView/WebView.mm:

   452         (max): Added. In 64-bit land, -diskCapacity magically starts returning

   453         unsigned long instead of unsigned, so we define a custom max() that's

   454         willing to compare unsigned to unsigned long.

   455 

   456 2007-09-10  Darin Adler  <darin@apple.com>

   457 

   458         Reviewed by Tim Hatcher.

   459 

   460         - <rdar://problem/5471082> Removing WebURLPboardType from headers broke SPI-using applications

   461 

   462         Rolled out my fix for bug 4582212 and fixed it in a much simpler way.

   463 

   464         * Misc/WebNSPasteboardExtras.h:

   465         * Misc/WebNSPasteboardExtras.mm:

   466         * WebCoreSupport/WebPasteboardHelper.mm:

   467         * WebKit.exp:

   468         * WebView/WebHTMLView.mm:

   469         * WebView/WebView.mm:

   470         Rolled out the new PasteboardType functions and changed the PboardType globals to be initialized

   471         with constant values.

   472 

   473 2007-09-10  Timothy Hatcher  <timothy@apple.com>

   474 

   475         Reviewed by Darin.

   476 

   477         Always animate when calling _scrollTo.

   478 

   479         * WebView/WebFrameView.mm:

   480         (-[WebFrameView _scrollVerticallyBy:]):

   481         (-[WebFrameView _scrollHorizontallyBy:]):

   482 

   483 2007-09-08  Brady Eidson  <beidson@apple.com>

   484 

   485         Reviewed by Darin

   486 

   487         <rdar://problem/5434431> - Asynchronous Icon Database

   488 

   489         WebKit side of things

   490         Mainly, there are Notifications WebKit has to listen for now that tell it when to either call back into WebCore

   491         for some purpose or to send the webView:didReceiveIcon: delegate call

   492 

   493         Many smaller tweaks as well.

   494 

   495         * Misc/WebIconDatabase.h:

   496         * Misc/WebIconDatabase.mm:

   497         (defaultClient):

   498         (-[WebIconDatabase init]):

   499         (+[WebIconDatabase delayDatabaseCleanup]): Accessor so clients can prevent the thread from cleaning up the database

   500           before they've done all their necessary retaining of icons.

   501         (+[WebIconDatabase allowDatabaseCleanup]):

   502         (-[WebIconDatabase removeAllIcons]):

   503         (-[WebIconDatabase _isEnabled]):

   504         (-[WebIconDatabase _sendNotificationForURL:]):

   505         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]):

   506         (-[WebIconDatabase _databaseDirectory]):

   507 

   508         (-[ThreadEnabler threadEnablingSelector:]): Quick and dirty class to enabled Cocoa multithreading

   509         (+[ThreadEnabler enableThreading]):

   510         (importToWebCoreFormat):

   511         * Misc/WebIconDatabaseInternal.h: Expose the internal methods of WebIconDatabase that are required by WebIconDatabaseClient

   512 

   513         * Misc/WebNSNotificationCenterExtras.h: Added. - Great utility class whose design was borrowed from Colloquy

   514           that allows the posting of a Cocoa notification on the main thread from *any* thread

   515         * Misc/WebNSNotificationCenterExtras.m: Added.

   516         (-[NSNotificationCenter postNotificationOnMainThreadWithName:object:]):

   517         (-[NSNotificationCenter postNotificationOnMainThreadWithName:object:userInfo:]):

   518         (-[NSNotificationCenter postNotificationOnMainThreadWithName:object:userInfo:waitUntilDone:]):

   519         (+[NSNotificationCenter _postNotificationName:]):

   520 

   521         * WebCoreSupport/WebFrameLoaderClient.h:

   522         * WebCoreSupport/WebFrameLoaderClient.mm:

   523         (WebFrameLoaderClient::dispatchDidReceiveIcon): Send the webView:didReceiveIcon: delegate call

   524         (WebFrameLoaderClient::registerForIconNotification):

   525 

   526         * WebCoreSupport/WebIconDatabaseClient.h: Added.

   527         * WebCoreSupport/WebIconDatabaseClient.mm: Added.

   528         (WebIconDatabaseClient::performImport):  Perform the Safari 2 icon import

   529         (WebIconDatabaseClient::dispatchDidRemoveAllIcons): Send the NSNotification

   530         (WebIconDatabaseClient::dispatchDidAddIconForPageURL): Ditto

   531 

   532         * WebView/WebView.mm:

   533         (-[WebView _receivedIconChangedNotification:]): Check and see if this notification is for this WebView's current URL by

   534           calling back into the IconDatabase

   535         (-[WebView _registerForIconNotification:]): Support for WebIconDatabaseClient

   536         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Dispatch this delegate call as well as unregister for the notification

   537         * WebView/WebViewInternal.h:

   538 

   539         * WebKit.xcodeproj/project.pbxproj:

   540 

   541 2007-09-07  Geoffrey Garen  <ggaren@apple.com>

   542 

   543         Suggested by Maciej Stachowiak.

   544         

   545         Added wKiosk Browser to the browser list. Pretty sweet app.

   546 

   547         * WebView/WebPreferences.m:

   548         (cacheModelForMainBundle):

   549 

   550 2007-09-07  Geoffrey Garen  <ggaren@apple.com>

   551 

   552         Build fix.

   553 

   554         * WebView/WebView.mm:

   555         (+[WebView _setCacheModel:]):

   556 

   557 2007-09-05  Geoffrey Garen  <ggaren@apple.com>

   558 

   559         Reviewed by Darin Adler, Maciej Stachowiak, Mark Rowe, Tim Hatcher.

   560         

   561         Fixed <rdar://problem/5326009> Make non-browser WebKit clients have no 

   562         memory cache, or a very tiny one

   563         

   564         High level explanation:

   565             - Added SPI for specifying a cache model on a per-WebView basis. 

   566             (Hopefully, this will become API soon.) We balance competing

   567             cache models simply by using the largest one that pertains at a

   568             given time.

   569 

   570             - Added heuristic for guessing a default cache model in WebViews

   571             that don't specify one:

   572                 1) Default to DocumentViewer for apps linked on or after this

   573                 WebKit. Default to DocumentBrowser otherwise.

   574 

   575                 2) Assign specific defaults to well-known clients based on 

   576                 bundle ID.

   577 

   578                 3) Grow the default to DocumentBrowser if a navigation takes 

   579                 place.

   580 

   581             - As a part of the DocumentBrowser & PrimaryWebBrowser settings:

   582                 1) Make the Foundation disk cache much much bigger than the 

   583                 default 20MB, if space allows. (This is a hedge against a small 

   584                 WebCore cache in DocumentBrowser mode, but also an all-around 

   585                 win for page load speed.)

   586 

   587                 2) Scaled the Foundation memory cache's capacity with physical

   588                 RAM, just like we do with other caches. This is a small win on

   589                 low memory systems.

   590 

   591         * Misc/WebKitSystemBits.h:

   592         * Misc/WebKitSystemBits.m:

   593         (WebMemorySize): Renamed from "WebSystemMainMemory."

   594         (WebHomeDirectoryFreeSize): Added function to measure the free space

   595         on the user's home directory. We use this as a factor in determining 

   596         the disk cache's cacpacity.

   597 

   598         * Misc/WebKitVersionChecks.h: Support for linked on or after check.

   599         

   600         * WebCoreSupport/WebFrameLoaderClient.h:

   601         * WebCoreSupport/WebFrameLoaderClient.mm:

   602         (WebFrameLoaderClient::didPerformFirstNavigation): Implementation of

   603         heuristic rule #3.

   604 

   605         * WebView/WebPreferenceKeysPrivate.h:

   606         * WebView/WebPreferences.m:

   607         (cacheModelForMainBundle): Implementation of heuristic rule #2.

   608         (-[NSMutableDictionary _web_checkLastReferenceForIdentifier:]): Added

   609         notification for when a WebPreferences instance becomes inert. We use

   610         this to shrink the cache model back down if possible. Moved this code

   611         into a WebPreferences method, since it's not really a feature of 

   612         NSDictionary.

   613 

   614         * WebView/WebPreferencesPrivate.h: SPI declarations.

   615         

   616         * WebView/WebView.mm: Replaced manual notification posts with calls to

   617         the _postPreferencesChangesNotification convenience method.

   618 

   619         (-[WebView _preferencesChangedNotification:]): Merged dispersed code

   620         for updating preferences-related settings into this one function. This

   621         was needed for an earlier version of the patch, even though the 

   622         current version could probably do without it.

   623 

   624         (+[WebView _preferencesChangedNotification:]): Added a class-level 

   625         listener for WebPreferences changes. This listener takes care of 

   626         modifying the class-level global cache model setting if necessary.

   627 

   628         (+[WebPreferences standardPreferences]): Removed call to 

   629         _postPreferencesChangesNotification because the notification already 

   630         posts when you create the WebPreferences object. (I noticed this 

   631         inefficiency because my new _preferencesChangedNotification: method was

   632         called excessively at startup.)

   633 

   634         Also Added explicit tracking of WebPreferences clients, so we know when

   635         a WebPreferences instance becomes inert:

   636         

   637         (-[WebPreferences didRemoveFromWebView]):

   638         (-[WebPreferences willAddToWebView]):

   639 

   640         (+[WebView _setCacheModel:]): Translates a cache model into actual 

   641         settings in various APIs. Caches that have unbounded value grow 

   642         linearly relative to available space. Caches that have bounded value 

   643         grow inverse-squaredly relative to available space.

   644 

   645 2007-09-05  Timothy Hatcher  <timothy@apple.com>

   646 

   647         Reviewed by Darin.

   648 

   649         <rdar://problem/5443883> Uncaught Objective-C exceptions in WebKit clients lead to hard-to-diagnose crashes

   650 

   651         Changed all the direct delegate calls to use helper functions that have direct access to

   652         WebView's delegate objects. These helper methods will catch any ObjC exceptions and call

   653         ReportDiscardedDelegateException to log the discarded exception. WebView's that have

   654         catchesDelegateExceptions set to NO will not pay the cost of a @try/@catch. The delegate

   655         forwarders also have the same behavior.

   656 

   657         * Misc/WebKitLogging.h:

   658         * Misc/WebKitLogging.m:

   659         (ReportDiscardedDelegateException):

   660         * Plugins/WebBaseNetscapePluginView.mm:

   661         (-[WebBaseNetscapePluginView loadPluginRequest:]):

   662         * Plugins/WebNullPluginView.mm:

   663         (-[WebNullPluginView viewDidMoveToWindow]):

   664         * WebCoreSupport/WebChromeClient.mm:

   665         (WebChromeClient::createWindow):

   666         (WebChromeClient::createModalDialog):

   667         (WebChromeClient::runModal):

   668         (WebChromeClient::toolbarsVisible):

   669         (WebChromeClient::statusbarVisible):

   670         (WebChromeClient::addMessageToConsole):

   671         (WebChromeClient::canRunBeforeUnloadConfirmPanel):

   672         (WebChromeClient::runBeforeUnloadConfirmPanel):

   673         (WebChromeClient::runJavaScriptAlert):

   674         (WebChromeClient::runJavaScriptConfirm):

   675         (WebChromeClient::runJavaScriptPrompt):

   676         (WebChromeClient::shouldInterruptJavaScript):

   677         (WebChromeClient::setStatusbarText):

   678         (WebChromeClient::print):

   679         * WebCoreSupport/WebContextMenuClient.mm:

   680         (WebContextMenuClient::getCustomMenuFromDefaultItems):

   681         (WebContextMenuClient::contextMenuItemSelected):

   682         * WebCoreSupport/WebDragClient.mm:

   683         (WebDragClient::startDrag):

   684         * WebCoreSupport/WebEditorClient.mm:

   685         (WebEditorClient::textFieldDidBeginEditing):

   686         (WebEditorClient::textFieldDidEndEditing):

   687         (WebEditorClient::textDidChangeInTextField):

   688         (WebEditorClient::doTextFieldCommandFromEvent):

   689         (WebEditorClient::textWillBeDeletedInTextField):

   690         (WebEditorClient::textDidChangeInTextArea):

   691         * WebCoreSupport/WebFrameBridge.mm:

   692         (-[WebFrameBridge viewForPluginWithFrame:URL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):

   693         * WebCoreSupport/WebFrameLoaderClient.mm:

   694         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):

   695         (WebFrameLoaderClient::assignIdentifierToInitialRequest):

   696         (WebFrameLoaderClient::dispatchWillSendRequest):

   697         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):

   698         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):

   699         (WebFrameLoaderClient::dispatchDidReceiveResponse):

   700         (WebFrameLoaderClient::willCacheResponse):

   701         (WebFrameLoaderClient::dispatchDidReceiveContentLength):

   702         (WebFrameLoaderClient::dispatchDidFinishLoading):

   703         (WebFrameLoaderClient::dispatchDidFailLoading):

   704         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):

   705         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):

   706         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):

   707         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):

   708         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):

   709         (WebFrameLoaderClient::dispatchWillClose):

   710         (WebFrameLoaderClient::dispatchDidReceiveIcon):

   711         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):

   712         (WebFrameLoaderClient::dispatchDidReceiveTitle):

   713         (WebFrameLoaderClient::dispatchDidCommitLoad):

   714         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):

   715         (WebFrameLoaderClient::dispatchDidFailLoad):

   716         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):

   717         (WebFrameLoaderClient::dispatchDidFinishLoad):

   718         (WebFrameLoaderClient::dispatchDidFirstLayout):

   719         (WebFrameLoaderClient::dispatchCreatePage):

   720         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):

   721         (WebFrameLoaderClient::dispatchWillSubmitForm):

   722         (WebFrameLoaderClient::dispatchDidLoadMainResource):

   723         * WebView/WebHTMLView.mm:

   724         (-[WebHTMLView callDelegateDoCommandBySelectorIfNeeded:]):

   725         (-[WebHTMLView validateUserInterfaceItem:]):

   726         * WebView/WebPDFView.mm:

   727         (-[WebPDFView validateUserInterfaceItem:]):

   728         (-[WebPDFView PDFViewSavePDFToDownloadFolder:]):

   729         * WebView/WebView.mm:

   730         (-[WebView _openNewWindowWithRequest:]):

   731         (-[WebView _menuForElement:defaultItems:]):

   732         (-[WebView _mouseDidMoveOverElement:modifierFlags:]):

   733         (-[WebView _cacheResourceLoadDelegateImplementations]):

   734         (-[WebView _cacheFrameLoadDelegateImplementations]):

   735         (-[WebView _policyDelegateForwarder]):

   736         (-[WebView _UIDelegateForwarder]):

   737         (-[WebView _editingDelegateForwarder]):

   738         (-[WebView _scriptDebugDelegateForwarder]):

   739         (-[WebView _setCatchesDelegateExceptions:]):

   740         (-[WebView _catchesDelegateExceptions]):

   741         (-[_WebSafeForwarder initWithTarget:defaultTarget:]):

   742         (-[_WebSafeForwarder forwardInvocation:]):

   743         (-[_WebSafeForwarder methodSignatureForSelector:]):

   744         (-[WebView _commonInitializationWithFrameName:groupName:]):

   745         (-[WebView validateUserInterfaceItem:]):

   746         (-[WebView _headerHeight]):

   747         (-[WebView _footerHeight]):

   748         (-[WebView _drawHeaderInRect:]):

   749         (-[WebView _drawFooterInRect:]):

   750         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):

   751         (CallDelegate):

   752         (CallDelegateReturningFloat):

   753         (CallDelegateReturningBoolean):

   754         (CallUIDelegate):

   755         (CallUIDelegateReturningFloat):

   756         (CallUIDelegateReturningBoolean):

   757         (CallFrameLoadDelegate):

   758         (CallResourceLoadDelegate):

   759         (CallFormDelegate):

   760         (CallFormDelegateReturningBoolean):

   761         * WebView/WebViewInternal.h:

   762         * WebView/WebViewPrivate.h:

   763 

   764 2007-09-04  Timothy Hatcher  <timothy@apple.com>

   765 

   766         Reviewed by Darin.

   767 

   768         <rdar://problem/5452908> NIBs saved in the Pre-10.2 format while Safari 3 installed do not work without Safari 3

   769 

   770         This happened because we encoded a new field that the old WebKit does not know how to read.

   771         And NSCoder throws an exception if initWithCoder finishes while there is still unread data in the archive.

   772 

   773         The WebViewVersion is now 4 to distinguish that we do not encode/decode allowsUndo.

   774 

   775         * WebView/WebView.mm:

   776         (-[WebView initWithCoder:]): Only try to read allowsUndo if the version is 3.

   777         (-[WebView encodeWithCoder:]): No longer encode allowsUndo.

   778 

   779 2007-09-04  David Hyatt  <hyatt@apple.com>

   780 

   781         Fix for <rdar://problem/5271213>, resizing iChat window is slower than in

   782         Tiger.  This patch implements a fast scaling mode that can be used by

   783         WebViews, e.g., during window resizing.

   784 

   785         Reviewed by John Sullivan

   786 

   787         * WebView/WebView.mm:

   788         (-[WebView _setUseFastImageScalingMode:]):

   789         (-[WebView _inFastImageScalingMode]):

   790         * WebView/WebViewPrivate.h:

   791 

   792 2007-09-04  Darin Adler  <darin@apple.com>

   793 

   794         Reviewed by Hyatt.

   795 

   796         * WebView/WebView.mm:

   797         (-[WebView _loadBackForwardListFromOtherView:]): Added missing null check.

   798         (-[WebView _setInitiatedDrag:]): Ditto.

   799         (-[WebView _clearUndoRedoOperations]): Ditto.

   800         (-[WebView encodeWithCoder:]): Ditto.

   801         (-[WebView backForwardList]): Ditto.

   802         (-[WebView setMaintainsBackForwardList:]): Ditto.

   803 

   804 2007-09-04  Tristan O'Tierney  <tristan@apple.com>

   805 

   806         Reviewed by John Sullivan.

   807         

   808         <rdar://problem/5454935> Can't reply to this message in Mail -- -[DOMRange webArchive] is throwing an exception

   809 

   810         * WebView/WebArchiver.mm:

   811         (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):

   812         Guard the creation of WebResource by ensuring that the passed in

   813         responseURL is never nil.

   814 

   815 2007-09-03  Mark Rowe  <mrowe@apple.com>

   816 

   817         Reviewed by Tim Hatcher.

   818 

   819         <rdar://problem/5452164> Production build with in symbols directory has no debug info

   820 

   821         Enable debug symbol generation on all build configurations.  Production builds are stripped

   822         of symbols by Xcode during deployment post-processing.

   823 

   824         * Configurations/Base.xcconfig:

   825         * WebKit.xcodeproj/project.pbxproj:

   826 

   827 2007-09-02  Brady Eidson  <beidson@apple.com>

   828 

   829         Reviewed by John Sullivan and Mark Rowe

   830 

   831         Groundwork for support for monitoring IconDatabase in-memory statistics

   832  

   833         * Misc/WebCoreStatistics.h:

   834         * Misc/WebCoreStatistics.mm:

   835         (+[WebCoreStatistics iconPageURLMappingCount]):

   836         (+[WebCoreStatistics iconRetainedPageURLCount]):

   837         (+[WebCoreStatistics iconRecordCount]):

   838         (+[WebCoreStatistics iconsWithDataCount]):

   839 

   840 2007-09-01  Oliver Hunt  <oliver@apple.com>

   841 

   842         Reviewed by Sam.

   843 

   844         <rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions

   845 

   846         EditorClient::setInputMethodState stub

   847 

   848         * WebCoreSupport/WebEditorClient.h:

   849         * WebCoreSupport/WebEditorClient.mm:

   850         (WebEditorClient::setInputMethodState):

   851 

   852 2007-08-30  Maciej Stachowiak  <mjs@apple.com>

   853 

   854         Reviewed by Tim.

   855         

   856         <rdar://problem/5439953> REGRESSION: Cannot load feeds in widgets in Dashcode due to change in WebKit delegate methods

   857 

   858         * WebView/WebFrame.mm:

   859         (-[WebFrame _attachScriptDebugger]): Don't create the debugger object if the frame has not yet

   860         created its script interpreter, to avoid premature dispatch of windowScriptObjectAvailable/Cleared

   861         delegate methods. The script debugger will be created in any case when the window object does appear.

   862 

   863 2007-08-29  Darin Adler  <darin@apple.com>

   864 

   865         Reviewed by Tim Hatcher.

   866 

   867         - fix <rdar://problem/4582212> WebKit inappropriately adds +initialize to

   868           NSPasteboard via a category, prevents AppKit initialize

   869           http://bugs.webkit.org/show_bug.cgi?id=9417

   870 

   871         * Misc/WebNSPasteboardExtras.h: Got rid of the global data objects and replaced

   872         them with global functions.

   873 

   874         * Misc/WebNSPasteboardExtras.mm:

   875         (initializePasteboardTypes): Changed the initialize method to be this function.

   876         (WebURLPasteboardType): Added, calls the initialize function and then returns

   877         the value of the global.

   878         (WebURLNamePasteboardType): Ditto.

   879         (+[NSPasteboard _web_writableTypesForURL]): Changed to call the new function instead

   880         of getting at the global directly.

   881         (+[NSPasteboard _web_dragTypesForURL]): Ditto.

   882         (-[NSPasteboard _web_writeURL:andTitle:types:]): Ditto.

   883         * WebCoreSupport/WebPasteboardHelper.mm:

   884         (WebPasteboardHelper::urlFromPasteboard): Ditto.

   885         * WebView/WebHTMLView.mm:

   886         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.

   887 

   888         * WebView/WebView.mm:

   889         (+[WebView initialize]): Added a call to one of the functions to take advantage

   890         of the side effect that initializes the globals; this is to help out old versions

   891         of Safari.

   892         (+[WebView URLTitleFromPasteboard:]): Changed to call the new function instead

   893         of getting at the global directly.

   894 

   895         * WebKit.exp: Add exports of the new functions.

   896 

   897 2007-08-29  Adele Peterson  <adele@apple.com>

   898 

   899         Reviewed by Darin.

   900 

   901         Fix for http://bugs.webkit.org/show_bug.cgi?id=15098

   902         <rdar://problem/5440319> REGRESSION (9A530-9A534): Double scroll bar on pdfs

   903 

   904         * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView):

   905          Don't suppress scrollbars before the view creation if we're making the view for a non-html view

   906 

   907         * WebView/WebFrameViewInternal.h: Make _scrollView return a WebDynamicScrollBarsView since so many clients were relying on it being that type anyway.

   908         * WebView/WebFrameView.mm:

   909         (-[WebFrameView _setDocumentView:]):

   910         (-[WebFrameView _scrollView]):

   911         (-[WebFrameView setAllowsScrolling:]):

   912         (-[WebFrameView allowsScrolling]):

   913         * WebView/WebView.mm:

   914         (-[WebView setAlwaysShowVerticalScroller:]):

   915         (-[WebView alwaysShowVerticalScroller]):

   916         (-[WebView setAlwaysShowHorizontalScroller:]):

   917         (-[WebView alwaysShowHorizontalScroller]):

   918 

   919 2007-08-29  David Hyatt  <hyatt@apple.com>

   920 

   921         The method that was swizzled to fix 5441281 does not exist on Tiger.

   922         Tiger has to do a double swizzle instead (of resetCursorRects and NSCursor's

   923         set method) in order to roughly achieve the same effect.

   924 

   925         Reviewed by darin

   926 

   927         * WebView/WebHTMLView.mm:

   928         (resetCursorRects):

   929         (setCursor):

   930         (+[WebHTMLViewPrivate initialize]):

   931 

   932 2007-08-29  Anders Carlsson  <andersca@apple.com>

   933 

   934         Fix 64-bit build.

   935         

   936         * WebCoreSupport/WebFrameBridge.mm:

   937 

   938 2007-08-29  David Hyatt  <hyatt@apple.com>

   939 

   940         Fix for 5441281, remove our dependency on cursor rects and drag margins

   941         in AppKit for a large performance boost on the PLT and iBench.

   942 

   943         Reviewed by darin

   944 

   945         * Plugins/WebBaseNetscapePluginView.h:

   946         * Plugins/WebBaseNetscapePluginView.mm:

   947         (-[WebBaseNetscapePluginView sendNullEvent]):

   948         (-[WebBaseNetscapePluginView mouseEntered:]):

   949         (-[WebBaseNetscapePluginView mouseExited:]):

   950         (-[WebBaseNetscapePluginView stop]):

   951         Clean up cursor setting from Netscape plugins.  Don't unconditionally mutate

   952         the cursor when a plugin stops.

   953 

   954         * WebView/WebFrameView.mm:

   955         (-[WebFrameView _setDocumentView:]):

   956         Suppress the resetting of drag margins while the new document view is being

   957         added to the view hierarchy.

   958 

   959         * WebView/WebHTMLView.mm:

   960         (-[NSWindow _web_borderView]):

   961         Expose the border view of the NSWindow so that it can be hit tested.

   962 

   963         (setCursorForMouseLocation):

   964         Apply a method swizzle to override the private AppKit method, _setCursorForMouseLocation.

   965         We have to do this to suppress the cursor rect invalidation handling from resetting

   966         the cursor for no reason.

   967 

   968         The swizzle will do a hit test and allow the cursor set to occur if the mouse ends up

   969         being over a plugin or over a view other than a WebHTMLView.

   970 

   971         (+[WebHTMLViewPrivate initialize]):

   972         The swizzle for setCursorForMouseLocation is set up here.

   973 

   974         (-[WebHTMLView _frameOrBoundsChanged]):

   975         Add a 100ms delay to the fake mouse moved event that fires when the view moves

   976         under the mouse (without the mouse moving).  This happens on iBench when the

   977         pages get scrolled.  By adding a delay we ensure that even with the mouse inside

   978         the window, we don't experience cursor thrashing when pages are updating and

   979         scrolling rapidly.

   980 

   981 2007-08-28  Anders Carlsson  <andersca@apple.com>

   982 

   983         Reviewed by Darin.

   984 

   985         <rdar://problem/5424866> Bottom portion of any Web Clip widget appears transparent

   986         

   987         * WebCoreSupport/WebFrameBridge.mm:

   988         Use the enum from FrameLoaderTypes.h.

   989         

   990         * WebCoreSupport/WebFrameLoaderClient.mm:

   991         (WebFrameLoaderClient::objectContentType):

   992         Return ObjectContentNetscapePlugin and ObjectContentOtherPlugin depending on the plug-in type.

   993 

   994 2007-08-28  Mark Rowe  <mrowe@apple.com>

   995 

   996         Reviewed by Maciej Stachowiak.

   997 

   998         Fix fallout from the fix for <rdar://problem/5437983> (Loading history containing 100,000 entries adds 20s to Safari's startup)

   999         in r25275.  The array of entries for each day was being maintained in the reverse of the order that was expected.

  1000 

  1001         * History/WebHistory.mm:

  1002         (-[WebHistoryPrivate insertItem:forDateKey:]): Maintain the array of entries in descending order.

  1003 

  1004 2007-08-28  Mark Rowe  <mrowe@apple.com>

  1005 

  1006         Fix the buildbot build.

  1007 

  1008         * History/WebHistory.mm:

  1009         (timeIntervalForBeginningOfDay):  Explicitly cast to silence compiler warning.

  1010 

  1011 2007-08-28  Mark Rowe  <mrowe@apple.com>

  1012 

  1013         Reviewed by Darin Adler.

  1014 

  1015         <rdar://problem/5437983> Loading history containing 100,000 entries adds 20s to Safari's startup

  1016 

  1017         Move WebHistoryItemPrivate from using a sorted array of NSCalendarDate's that map to a sorted array of arrays

  1018         of WebHistoryItem's over to using a HashMap of NSTimeIntervals and arrays of WebHistoryItems.  NSTimeInterval

  1019         uses less memory and is substantially cheaper during comparisons than NSCalendarDate.  The use of the HashMap

  1020         avoids the needs to repeatedly search within an array to locate the array that corresponds to the given days

  1021         history items.

  1022 

  1023         The result of these changes is that loading 100,000 history items drops from around 25s to 1.6s.  Loading

  1024         100 items drops from 0.003s to 0.002s.

  1025 

  1026         * History/WebHistory.mm:

  1027         (-[WebHistoryPrivate init]):

  1028         (-[WebHistoryPrivate dealloc]):

  1029         (timeIntervalForBeginningOfDay): Return the NSTimeInterval representing the beginning of the specified day.

  1030         (-[WebHistoryPrivate findKey:forDay:]):

  1031         (-[WebHistoryPrivate insertItem:forDateKey:]): Perform a binary search within the day's history items rather than a linear search.

  1032         (-[WebHistoryPrivate _removeItemFromDateCaches:]):

  1033         (-[WebHistoryPrivate _addItemToDateCaches:]):

  1034         (-[WebHistoryPrivate removeAllItems]):

  1035         (-[WebHistoryPrivate orderedLastVisitedDays]): Generate and cache the sorted NSArray of NSCalendarDate's exposed in the API.

  1036         This cache is invalidated by _removeItemFromDateCaches: and _addItemToDateCaches: when needed.

  1037         (-[WebHistoryPrivate orderedItemsLastVisitedOnDay:]):

  1038         (-[WebHistoryPrivate arrayRepresentation]):

  1039         (-[WebHistoryPrivate _loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]): Use an autorelease pool to keep the

  1040         number of live autoreleased objects generated to a reasonable level.

  1041         * History/WebHistoryItem.mm:

  1042         (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):

  1043         (-[WebHistoryItem initFromDictionaryRepresentation:]): Use the new HistoryItem constructor that accepts the alternate title

  1044         rather than setting it after construction.  This prevents a modification notification from being sent for each WebHistoryItem that is loaded.

  1045         * History/WebHistoryItemInternal.h:

  1046         * History/WebHistoryPrivate.h:

  1047         * Misc/WebNSCalendarDateExtras.h: Removed as _webkit_compareDay: is no longer used.

  1048         * Misc/WebNSCalendarDateExtras.m: Removed.

  1049         * WebKit.xcodeproj/project.pbxproj:

  1050 

  1051 2007-08-28  Anders Carlsson  <andersca@apple.com>

  1052 

  1053         Reviewed by Darin.

  1054 

  1055         <rdar://problem/5298296> XMLHttpRequest readyState 3 & responseText buffer issues

  1056         

  1057         Expose WKSetNSURLRequestShouldContentSniff to WebCore.

  1058         

  1059         * WebCoreSupport/WebSystemInterface.m:

  1060         (InitWebCoreSystemInterface):

  1061 

  1062 2007-08-24  Kevin McCullough  <kmccullough@apple.com>

  1063 

  1064         Reviewed by Darin.

  1065 

  1066         <rdar://problem/5437038> 1 credential object leaked for each call to credentialWithUser:password:persistence

  1067         - Use initWithUser instead of credentialWithUser because credentialWithUser leaks.

  1068 

  1069         * Panels/WebAuthenticationPanel.m:

  1070         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):

  1071         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):

  1072 

  1073 2007-08-24  Adele Peterson  <adele@apple.com>

  1074 

  1075         Fix by Darin, reviewed by Adele.

  1076 

  1077         Fix for <rdar://problem/5433422> Upon quitting, WebKit loads the WebPlugin shared database and immediately closes it

  1078 

  1079         * Plugins/WebPluginDatabase.h: Added closeSharedDatabase, which won't create a new database if we're just trying to close it.

  1080         * Plugins/WebPluginDatabase.m: (+[WebPluginDatabase closeSharedDatabase]): Added.

  1081         * WebView/WebView.mm:

  1082         (-[WebView _close]): Call closeSharedDatabase.

  1083         (+[WebView _applicationWillTerminate]): Call closeSharedDatabase.

  1084 

  1085 2007-08-24  Timothy Hatcher  <timothy@apple.com>

  1086 

  1087         Reviewed by John Sullivan.

  1088 

  1089         <rdar://problem/5410937> HIWebView in SimpleCarbonWeb doesn't seem to be getting adequate invalidation when window is resized

  1090 

  1091         This is a more localized fix for yesterday's change. Now explicitly call _web_layoutIfNeededRecursive inside the

  1092         HIWebView Draw() function. Adds a FIXME to explain that we need to do layout before Carbon has decided what regions to draw.

  1093         Doing layout in Draw() will potentially cause drawing to happen in two passes, but this has always been a problem in Carbon.

  1094 

  1095         * Carbon/HIWebView.m:

  1096         (Draw): Call _web_layoutIfNeededRecursive on the main WebHTMLView.

  1097         (SetFocusPart): Fix to work in ObjC++ (now that HIWebView.m is treated as a ObjC++ file.)

  1098         * WebView/WebView.mm: Removes the 4 displayIfNeeded methods from yesterday's change.

  1099         * WebKit.xcodeproj/project.pbxproj: Force the file type of HIWebView.m to ObjC++ so WebHTMLViewInternal.h can be included.

  1100 

  1101 2007-08-23  Timothy Hatcher  <timothy@apple.com>

  1102 

  1103         Reviewed by Dave Hyatt.

  1104 

  1105         <rdar://problem/5410937> HIWebView in SimpleCarbonWeb doesn't seem to be getting adequate invalidation when window is resized

  1106 

  1107         The Carbon HIWebView was relying on layout happening when displayIfNeededInRect: was called on the WebView.

  1108         This would happen on Tiger because _recursiveDisplayRectIfNeededIgnoringOpacity: would always do a layout if needed.

  1109         Doing a layout in _recursiveDisplayRectIfNeededIgnoringOpacity was removed in Leopard in favor of viewWillDraw, and

  1110         the fact that adding new dirty rects inside _recursiveDisplayRectIfNeededIgnoringOpacity on Leopard will not

  1111         cause a drawRect in the same display loop.

  1112 

  1113         So any client on Leopard calling displayIfNeeded* on the WebView would get a layout and any new dirty rects. So

  1114         _web_layoutIfNeededRecursive needs to be called on the main frame's WebHTMLView to make sure we layout and

  1115         display anything that is really needed.

  1116 

  1117         * WebView/WebHTMLView.mm:

  1118         (-[WebHTMLView _layoutIfNeeded]):

  1119         (-[WebHTMLView _web_layoutIfNeededRecursive]):

  1120         * WebView/WebHTMLViewInternal.h:

  1121         * WebView/WebView.mm:

  1122         (-[WebView displayIfNeeded]): Call _web_layoutIfNeededRecursive on the main WebHTMLView.

  1123         (-[WebView displayIfNeededIgnoringOpacity]): Ditto.

  1124         (-[WebView displayIfNeededInRect:]): Ditto. 

  1125         (-[WebView displayIfNeededInRectIgnoringOpacity:]): Ditto.

  1126 

  1127 2007-08-22  Timothy Hatcher  <timothy@apple.com>

  1128 

  1129         Rolling out r25102 for <rdar://problem/5410937> until

  1130         <rdar://problem/5429920> is resolved.

  1131 

  1132         * Carbon/CarbonUtils.m:

  1133         (WebInitForCarbon):

  1134         (PoolCleaner):

  1135         * Carbon/CarbonWindowAdapter.h: