WebKitTools/ChangeLog
changeset 0 4f2f89ce4247
child 2 303757a437d3
equal deleted inserted replaced
-1:000000000000 0:4f2f89ce4247
       
     1 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
       
     2 
       
     3         Reviewed by Ariya Hidayat.
       
     4 
       
     5         [Qt] QtTestBrowser: proper set scene rect
       
     6 
       
     7         When resizesToContents is ON scene's rect is set to the boundary of
       
     8         the mainFrame. However, navigating to other web page should keep resizing
       
     9         scene's rect according to the new document loaded. Patch addresses this issue.
       
    10 
       
    11         Now resizesToContents and scrolling properly work on QtTestBrowser.
       
    12 
       
    13         * QtTestBrowser/webview.cpp:
       
    14         (WebViewGraphicsBased::setPage):
       
    15         (WebViewGraphicsBased::contentsSizeChanged):
       
    16         (WebViewGraphicsBased::setResizesToContents):
       
    17         (WebViewGraphicsBased::resizeEvent):
       
    18         * QtTestBrowser/webview.h:
       
    19 
       
    20 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
       
    21 
       
    22         Reviewed by Ariya Hidayat.
       
    23 
       
    24         [Qt] QtTestBrowser: Clean up LauncherWindow code.
       
    25 
       
    26         * QtTestBrowser/launcherwindow.cpp:
       
    27         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
       
    28         (LauncherWindow::init): Fixed comments.
       
    29         (LauncherWindow::applyPrefs): Move the method around.
       
    30         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
       
    31 
       
    32 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
       
    33 
       
    34         Reviewed by Ariya Hidayat.
       
    35 
       
    36         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
       
    37 
       
    38         It gets control+0 the same visual effect as control++ or control-.
       
    39 
       
    40         * QtTestBrowser/launcherwindow.cpp:
       
    41         (LauncherWindow::toggleZoomTextOnly):
       
    42 
       
    43 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
       
    44 
       
    45         Reviewed by Ariya Hidayat.
       
    46 
       
    47         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
       
    48 
       
    49         Not all instances of LauncherWindow need its own m_zoomLevel.
       
    50 
       
    51         * QtTestBrowser/launcherwindow.cpp:
       
    52         * QtTestBrowser/launcherwindow.h:
       
    53 
       
    54 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
       
    55 
       
    56         Reviewed by Kenneth Christiansen.
       
    57 
       
    58         [Qt] [QtTestBrowser] Remove unneeded QAction class members
       
    59         https://bugs.webkit.org/show_bug.cgi?id=43518
       
    60 
       
    61         LauncherWindow class has two totally unneeded class members: m_flopAnimated and
       
    62         m_flipYAnimated. Also, in initializeView method there are some dead code block
       
    63         trying to connect them at the wrong time, when they have not been instanciated.
       
    64 
       
    65         This patch:
       
    66 
       
    67         - removes the two cited class members in favor of local variables in createChrome method;
       
    68         - removes the dead code block.
       
    69 
       
    70         * QtTestBrowser/launcherwindow.cpp:
       
    71         (LauncherWindow::LauncherWindow):
       
    72         (LauncherWindow::initializeView):
       
    73         (LauncherWindow::createChrome):
       
    74         * QtTestBrowser/launcherwindow.h:
       
    75 
       
    76 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
       
    77 
       
    78         Reviewed by Simon Hausmann and Kenneth Christiansen.
       
    79 
       
    80         [Qt] [QtTestBrowser] Clean up static and global menu state controls
       
    81         https://bugs.webkit.org/show_bug.cgi?id=43448
       
    82 
       
    83         After LauncherWindow class was refactored out of from main.cpp, all global variables that
       
    84         were hanging in main.cpp became temporarily public static class members of newly added
       
    85         LauncherWindow class. This design was not properly handling the initial purpose of the
       
    86         global variables: newly created launcher windows should inherit the settings of the originating
       
    87         one.
       
    88 
       
    89         In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
       
    90         comprises all data needed to handling the goal described above.
       
    91 
       
    92         * QtTestBrowser/launcherwindow.cpp:
       
    93         (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object
       
    94                                           holding all user settings configured in the menus and command line.
       
    95                                           It also receices an optional QGraphicsScene points in case we are doing
       
    96                                           a "Clone Window".
       
    97         (LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its
       
    98                                 value.
       
    99         (LauncherWindow::initializeView): Ditto.
       
   100         (LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
       
   101         (LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly
       
   102                                       apply the preferences is provided by m_userData.
       
   103         (LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
       
   104         (LauncherWindow::toggleResizesToContents): Ditto.
       
   105         (LauncherWindow::toggleWebGL): Ditto.
       
   106         (LauncherWindow::toggleFrameFlattening): Ditto.
       
   107         (LauncherWindow::toggleQGLWidgetViewport): Ditto.
       
   108         (LauncherWindow::changeViewportUpdateMode): Ditto.
       
   109         (LauncherWindow::showFPS): Ditto.
       
   110         (LauncherWindow::newWindow): Changed to pass the userData.
       
   111         (LauncherWindow::cloneWindow): Ditto.
       
   112         * QtTestBrowser/launcherwindow.h:
       
   113         (WindowOptions::WindowOptions):
       
   114         * QtTestBrowser/main.cpp:
       
   115         (requiresGraphicsView):
       
   116         (LauncherApplication::handleUserOptions):
       
   117         (main):
       
   118 
       
   119 2010-08-02  Antonio Gomes  <tonikitoo@webkit.org>
       
   120 
       
   121         Reviewed by Kenneth Christiansen.
       
   122 
       
   123         [Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents
       
   124         https://bugs.webkit.org/show_bug.cgi?id=43168
       
   125 
       
   126         QGraphicsWebView resizesToContents property has to work together with QWebPage's
       
   127         setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser.
       
   128 
       
   129         * QtTestBrowser/launcherwindow.cpp:
       
   130         (LauncherWindow::applyPrefs):
       
   131         * QtTestBrowser/webview.cpp:
       
   132         (WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes
       
   133                                                       needed when toggle resizesToContents on/off.
       
   134         (WebViewGraphicsBased::resizeEvent):
       
   135         * QtTestBrowser/webview.h:
       
   136         (WebViewGraphicsBased::setCustomLayoutSize): Setter helper.
       
   137         (WebViewGraphicsBased::customLayoutSize): Getter helper.
       
   138 
       
   139 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
       
   140 
       
   141         Reviewed by Kenneth Christiansen.
       
   142 
       
   143         [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken
       
   144         https://bugs.webkit.org/show_bug.cgi?id=43209
       
   145 
       
   146         When -resizes-to-content was being passed as a command line parameter it was simply
       
   147         not being set (although the corresponding menu item was marked as ON).
       
   148         User had to toggle the menu OFF and then ON again for it to take place.
       
   149 
       
   150         Reason: LauncherWindow::applyPrefs method sets many user options passed in from
       
   151         the command line, but not resizesToContents. Patch addresses that.
       
   152 
       
   153         * QtTestBrowser/launcherwindow.cpp:
       
   154         (LauncherWindow::createChrome):
       
   155         (LauncherWindow::applyPrefs):
       
   156         (LauncherWindow::toggleResizesToContents):
       
   157         * QtTestBrowser/webview.h:
       
   158         (WebViewGraphicsBased::resizesToContents):
       
   159 
       
   160 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
       
   161 
       
   162         Rubber-stamped by Simon Fraser.
       
   163 
       
   164         [Qt] QtTestBrowser: more method grouping and clean ups.
       
   165 
       
   166         Moving blocks of code around. Basically grouping related methods close to each.
       
   167 
       
   168         * QtTestBrowser/launcherwindow.cpp:
       
   169         (LauncherWindow::initializeView):
       
   170         (LauncherWindow::createChrome):
       
   171         (LauncherWindow::changeViewportUpdateMode):
       
   172         (LauncherWindow::showFPS):
       
   173         (LauncherWindow::newWindow):
       
   174         (LauncherWindow::cloneWindow):
       
   175         * QtTestBrowser/launcherwindow.h:
       
   176 
       
   177 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
       
   178 
       
   179         Reviewed by Kenneth Christiansen.
       
   180 
       
   181         [Qt] QtTestBrowser: Move WebPage class methods definitions from main.cpp to webpage.cpp
       
   182         https://bugs.webkit.org/show_bug.cgi?id=43199
       
   183 
       
   184         There is no sense in keeping WebPage method definitions in main.cpp once
       
   185         webpage.cpp already exists.
       
   186 
       
   187         No behavior change.
       
   188 
       
   189         * QtTestBrowser/main.cpp:
       
   190         * QtTestBrowser/webpage.cpp:
       
   191         (WebPage::createWindow):
       
   192         (WebPage::createPlugin):
       
   193 
       
   194 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
       
   195 
       
   196         Reviewed by Kenneth Christiansen.
       
   197 
       
   198         [Qt] Factor out LauncherWindow class out of main.cpp (QtTestBrowser)
       
   199         https://bugs.webkit.org/show_bug.cgi?id=43170
       
   200 
       
   201         Moving LauncherWindow class out of main.cpp to its own .cpp and .h files:
       
   202         launcherwindow.{cpp|h}
       
   203 
       
   204         No behavior change.
       
   205 
       
   206         Also changed all global static variables (named "gXXX") from main.cpp to
       
   207         static public variables of the LauncherWindow class.
       
   208 
       
   209         * QtTestBrowser/QtTestBrowser.pro:
       
   210         * QtTestBrowser/launcherwindow.cpp: Added.
       
   211         * QtTestBrowser/launcherwindow.h: Added.
       
   212         * QtTestBrowser/main.cpp:
       
   213         (LauncherApplication::handleUserOptions):
       
   214         (main):
       
   215 
       
   216 2010-08-04  Markus Goetz  <Markus.Goetz@nokia.com>
       
   217 
       
   218         Reviewed by Simon Hausmann.
       
   219 
       
   220         [Qt] Change wording in QtTestBrowser
       
   221         https://bugs.webkit.org/show_bug.cgi?id=43241
       
   222 
       
   223         * QtTestBrowser/launcherwindow.cpp:
       
   224         (LauncherWindow::createChrome):
       
   225 
       
   226 2010-07-30  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
       
   227 
       
   228         Reviewed by Tor Arne Vestbø.
       
   229 
       
   230         [QT][Symbian] QtTestBrowser missing location capabilities
       
   231         https://bugs.webkit.org/show_bug.cgi?id=43235
       
   232 
       
   233         QtTestBrowser missing capabilities to use QtMobility::QLocation. 
       
   234 
       
   235         * QtTestBrowser/QtTestBrowser.pro:
       
   236 
       
   237 2010-07-22  Yael Aharon  <yael.aharon@nokia.com>
       
   238 
       
   239         Reviewed by Laszlo Gombos.
       
   240 
       
   241         [Qt] QtWebKit needs public API for Notifications.
       
   242         https://bugs.webkit.org/show_bug.cgi?id=41413
       
   243 
       
   244         Update DumpRenderTree and QtTestBrowser to use the new API.
       
   245         Add new DRT API to flag that notifications permission requests should be ignored.
       
   246 
       
   247         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
       
   248         (WebCore::WebPage::WebPage):
       
   249         (WebCore::WebPage::requestPermission):
       
   250         (WebCore::WebPage::checkPermission):
       
   251         (WebCore::WebPage::cancelRequestsForPermission):
       
   252         * DumpRenderTree/qt/DumpRenderTreeQt.h:
       
   253         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
       
   254         (LayoutTestController::reset):
       
   255         (LayoutTestController::ignoreDesktopNotificationPermissionRequests):
       
   256         (LayoutTestController::checkDesktopNotificationPermission):
       
   257         * DumpRenderTree/qt/LayoutTestControllerQt.h:
       
   258         (LayoutTestController::ignoreReqestForPermission):
       
   259         * QtTestBrowser/main.cpp:
       
   260         (LauncherWindow::LauncherWindow):
       
   261         * QtTestBrowser/webpage.cpp:
       
   262         (WebPage::WebPage):
       
   263         (WebPage::requestPermission):
       
   264         (WebPage::checkPermission):
       
   265         (WebPage::cancelRequestsForPermission):
       
   266         * QtTestBrowser/webpage.h:
       
   267 
       
   268 2010-07-21  Darin Adler  <darin@apple.com>
       
   269 
       
   270         Reviewed by Sam Weinig.
       
   271 
       
   272         WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
       
   273         https://bugs.webkit.org/show_bug.cgi?id=42548
       
   274 
       
   275         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
       
   276         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
       
   277         (WTR::numericWindowPropertyValue): Renamed this and moved it up higher in the file.
       
   278         (WTR::dumpFrameScrollPosition): Added argument telling whether to dump the frame name.
       
   279         Changed to a file-internal function instead of a member function.
       
   280         (WTR::dumpDescendantFrameScrollPositions): Added.
       
   281         (WTR::InjectedBundlePage::dumpAllFrameScrollPositions): Added.
       
   282         (WTR::InjectedBundlePage::dump): Changed to call dumpAllFrameScrollPositions when
       
   283         appropriate. Also streamlined all the WKStringToUTF8 call sites.
       
   284         (WTR::InjectedBundlePage::willAddMessageToConsole): Streamlined use of WKStringToUTF8.
       
   285         (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
       
   286         (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
       
   287         (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
       
   288         (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
       
   289 
       
   290         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for above changes.
       
   291 
       
   292         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
       
   293         (WTR::LayoutTestController::LayoutTestController): Initialize
       
   294         m_shouldDumpAllFrameScrollPositions.
       
   295         (WTR::LayoutTestController::shouldDumpMainFrameScrollPosition): Renamed from
       
   296         shouldDumpFrameScrollPositions.
       
   297 
       
   298         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Reorganized the file a
       
   299         bit, added dumpChildFrameScrollPositions and shouldDumpAllFrameScrollPositions,
       
   300         and renamed shouldDumpFrameScrollPositions to shouldDumpMainFrameScrollPosition.
       
   301 
       
   302 2010-07-21  Darin Adler  <darin@apple.com>
       
   303 
       
   304         Reviewed by Sam Weinig.
       
   305 
       
   306         WebKitTestRunner needs to support dumping of scroll position
       
   307         https://bugs.webkit.org/show_bug.cgi?id=42514
       
   308 
       
   309         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
       
   310         (_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef.
       
   311 
       
   312         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
       
   313         (WTR::InjectedBundlePage::_didClearWindowForFrame): Use JSGlobalContextRef
       
   314         instead of JSContextRef.
       
   315         (WTR::InjectedBundlePage::dump): Call dumpFrameScrollPosition when appropriate.
       
   316         (WTR::numericWindowProperty): Added. Helper for dumpFrameScrollPosition.
       
   317         (WTR::InjectedBundlePage::dumpFrameScrollPosition): Added.
       
   318         (WTR::InjectedBundlePage::didClearWindowForFrame): Use JSGlobalContextRef
       
   319         instead of JSContextRef.
       
   320 
       
   321         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Removed names from
       
   322         arguments that simply repeat the argument type. Added dumpFrameScrollPosition.
       
   323 
       
   324         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
       
   325         (WTR::LayoutTestController::shouldDumpDOMAsWebArchive): Added. Currently
       
   326         returns false.
       
   327         (WTR::LayoutTestController::shouldDumpSourceAsWebArchive): Added. Currently
       
   328         returns false.
       
   329         (WTR::LayoutTestController::shouldDumpFrameScrollPositions): Added. Matches
       
   330         the logic in DumpRenderTree.
       
   331 
       
   332         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for above changes.
       
   333 
       
   334         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added property svn:ignore.
       
   335 
       
   336 2010-07-21  Kevin Ollivier  <kevino@theolliviers.com>
       
   337 
       
   338         [wx] Build fix, adding the WebCore/bindings/generic dir to the list of build dirs.
       
   339 
       
   340         * wx/build/settings.py:
       
   341 
       
   342 2010-07-21  Sam Weinig  <sam@webkit.org>
       
   343 
       
   344         Reviewed by Anders Carlsson.
       
   345 
       
   346         Patch for https://bugs.webkit.org/show_bug.cgi?id=42539
       
   347         WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages
       
   348 
       
   349         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
       
   350         (WTR::InjectedBundlePage::InjectedBundlePage):
       
   351         (WTR::InjectedBundlePage::_willAddMessageToConsole):
       
   352         (WTR::InjectedBundlePage::_willSetStatusbarText):
       
   353         (WTR::InjectedBundlePage::_willRunJavaScriptAlert):
       
   354         (WTR::InjectedBundlePage::_willRunJavaScriptConfirm):
       
   355         (WTR::InjectedBundlePage::_willRunJavaScriptPrompt):
       
   356         (WTR::InjectedBundlePage::willAddMessageToConsole):
       
   357         (WTR::InjectedBundlePage::willSetStatusbarText):
       
   358         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
       
   359         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
       
   360         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
       
   361         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
       
   362 
       
   363 2010-07-21  Adam Roben  <aroben@apple.com>
       
   364 
       
   365         Give InjectedBundle our standard set of configurations (minus the
       
   366         *_Cairo variants)
       
   367 
       
   368         InjectedBundle's Debug_All configuration was the same as is Debug
       
   369         configuration, and it was missing a Debug_Internal configuration.
       
   370 
       
   371         Fixes <http://webkit.org/b/42749> InjectedBundle's build
       
   372         configurations are screwy
       
   373 
       
   374         Reviewed by Darin Adler.
       
   375 
       
   376         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added
       
   377         debug_internal.vsprops and debug_all.vsprops to the Debug_All
       
   378         configuration. Added a Debug_Internal configuration.
       
   379 
       
   380         * WebKitTestRunner/WebKitTestRunner.sln: Build the Debug_Internal
       
   381         variant of InjectedBundle when we're using the Debug_Internal solution
       
   382         configuration.
       
   383 
       
   384 2010-07-21  Adam Roben  <aroben@apple.com>
       
   385 
       
   386         Move InjectedBundle's settings to a vsprops file
       
   387 
       
   388         This will make it easier to change settings for all configurations,
       
   389         and to add new configurations.
       
   390 
       
   391         Fixes <http://webkit.org/b/42748> InjectedBundle should use vsprops
       
   392         files
       
   393 
       
   394         Reviewed by Darin Adler.
       
   395 
       
   396         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added.
       
   397         Moved settings here...
       
   398         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: ...from
       
   399         here.
       
   400 
       
   401 2010-07-21  Adam Roben  <aroben@apple.com>
       
   402 
       
   403         Give MiniBrowser our standard set of configurations (minus the *_Cairo
       
   404         variants)
       
   405 
       
   406         MiniBrowser already had a configuration called "Release", but it was
       
   407         using mostly the same settings as Debug. And its Debug configuration
       
   408         was using the settings that Debug_Internal should be using.
       
   409 
       
   410         Fixes <http://webkit.org/b/42746> MiniBrowser's build configurations
       
   411         are screwy
       
   412 
       
   413         Reviewed by Darin Adler.
       
   414 
       
   415         * MiniBrowser/MiniBrowser.vcproj: Removed debug_internal.vsprops from
       
   416         the Debug configuration. Remove debug.vsprops and
       
   417         debug_internal.vsprops from the Release configuration and replace them
       
   418         with release.vsprops. Added Debug_Internal and Debug_All
       
   419         configurations.
       
   420 
       
   421 2010-07-21  Adam Roben  <aroben@apple.com>
       
   422 
       
   423         Move MiniBrowser's settings to a vsprops file
       
   424 
       
   425         This will make it easier to change settings for all configurations,
       
   426         and to add new configurations.
       
   427 
       
   428         MiniBrowser should use vsprops files
       
   429         https://bugs.webkit.org/show_bug.cgi?id=42745
       
   430 
       
   431         Reviewed by Darin Adler.
       
   432 
       
   433         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added. Moved
       
   434         settings here...
       
   435         * MiniBrowser/MiniBrowser.vcproj: ...from here.
       
   436 
       
   437 2010-07-21  Adam Roben  <aroben@apple.com>
       
   438 
       
   439         Fix compiler warnings when building MiniBrowser
       
   440 
       
   441         Also cleaned up the .vcproj a bit.
       
   442 
       
   443         Fixes <http://webkit.org/b/42743>.
       
   444 
       
   445         Reviewed by Darin Adler.
       
   446 
       
   447         * MiniBrowser/MiniBrowser.vcproj: Removed all settings that are
       
   448         already defined in .vsprops files. This also fixes a warning about
       
   449         /EDITANDCONTINUE being incompatible with /SAFESEH.
       
   450 
       
   451         * MiniBrowser/win/MiniBrowser.rc: Replaced afxres.h with winresrc.h so
       
   452         that we stop getting warnings about ID_FILE_OPEN and ID_FILE_CLOSE
       
   453         being redefined. (I think this will also get us closer to building
       
   454         with VC++ Express.)
       
   455 
       
   456 2010-07-20  Sam Weinig  <sam@webkit.org>
       
   457 
       
   458         Reviewed by Jon Honeycutt.
       
   459 
       
   460         Fix obvious typo.
       
   461 
       
   462         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
       
   463         (WTR::InjectedBundlePage::setStatusbarText): Need to call ->data() to actually get the string value.
       
   464 
       
   465 2010-07-20  Tony Chang  <tony@chromium.org>
       
   466 
       
   467         Reviewed by Kent Tamura.
       
   468 
       
   469         [chromium] by default, dumpAsText should disable pixel results
       
   470         https://bugs.webkit.org/show_bug.cgi?id=42715
       
   471 
       
   472         * DumpRenderTree/chromium/LayoutTestController.cpp:
       
   473         (LayoutTestController::dumpAsText): disable pixel results, but allow JS to override
       
   474 
       
   475 2010-07-20  Adam Roben  <aroben@apple.com>
       
   476 
       
   477         Windows build fix
       
   478 
       
   479         * MiniBrowser/MiniBrowser.vcproj: Link against the new, shiny
       
   480         WebKit.lib instead of the old, dusty WebKit2.lib.
       
   481 
       
   482 2010-07-20  Adam Roben  <aroben@apple.com>
       
   483 
       
   484         Stop linking WebKitTestRunner against getopt
       
   485 
       
   486         Use of getopt was removed in r63700.
       
   487 
       
   488         Fixes <http://webkit.org/b/42714> WebKitTestRunner links against
       
   489         getopt, but doesn't need to
       
   490 
       
   491         Reviewed by Sam Weinig.
       
   492 
       
   493         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed getopt.lib
       
   494         from all configurations.
       
   495 
       
   496 2010-07-20  Adam Roben  <aroben@apple.com>
       
   497 
       
   498         Make run-webkit-tests --webkit-test-runner "work" on Windows
       
   499 
       
   500         WebKitTestRunner crashes on launch, but at least the scripts build and
       
   501         launch it!
       
   502 
       
   503         Fixes <http://webkit.org/b/42709> run-webkit-tests
       
   504         --webkit-test-runner bails with an error on Windows
       
   505 
       
   506         Reviewed by Anders Carlsson.
       
   507 
       
   508         * Scripts/build-webkittestrunner: Build WebKitTestRunner.sln on
       
   509         Windows.
       
   510         * WebKitTestRunner/WebKitTestRunner.sln: Added. Contains the following
       
   511         projects (from first-built to last-built): FindSafari, ImageDiff,
       
   512         InjectedBundleGenerated, InjectedBundle, WebKitTestRunner.
       
   513 
       
   514 2010-07-20  Adam Roben  <aroben@apple.com>
       
   515 
       
   516         Change build-webkit back to building WebKit.sln on Windows
       
   517 
       
   518         WebKit.sln builds all the same projects as WebKit2.sln, and the latter
       
   519         is being removed.
       
   520 
       
   521         Rubber-stamped in advance by Steve Falkenburg.
       
   522 
       
   523         * Scripts/build-webkit:
       
   524 
       
   525 2010-07-20  Adam Roben  <aroben@apple.com>
       
   526 
       
   527         Windows build fix
       
   528 
       
   529         * MiniBrowser/win/BrowserWindow.cpp: Added missing #include.
       
   530 
       
   531 2010-07-20  Joseph Pecoraro  <joepeck@webkit.org>
       
   532 
       
   533         Reviewed by Geoffrey Garen.
       
   534 
       
   535         WebScriptObject Should Allow Safely Checking For Key Existence
       
   536         https://bugs.webkit.org/show_bug.cgi?id=42613
       
   537 
       
   538         Normal ObjCController workflow for a WebScriptObject test.
       
   539 
       
   540         * DumpRenderTree/mac/ObjCController.m:
       
   541         (+[ObjCController isSelectorExcludedFromWebScript:]):
       
   542         (+[ObjCController webScriptNameForSelector:]):
       
   543         (-[ObjCController testHasWebScriptKey:]):
       
   544 
       
   545 2010-07-20  Chris Marrin  <cmarrin@apple.com>
       
   546 
       
   547         Reviewed by Simon Fraser.
       
   548 
       
   549         https://bugs.webkit.org/show_bug.cgi?id=42118
       
   550         Disable compositing/webgl tests if WebGL is not enabled
       
   551 
       
   552         * Scripts/old-run-webkit-tests:
       
   553 
       
   554 2010-07-20  Anton Muhin  <antonm@chromium.org>
       
   555 
       
   556         Reviewed by Darin Adler.
       
   557 
       
   558         Print additional information about exception if failed to connect to apache (in verbose mode).
       
   559         https://bugs.webkit.org/show_bug.cgi?id=42627
       
   560 
       
   561         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
       
   562 
       
   563 2010-07-20  Tony Chang  <tony@chromium.org>
       
   564 
       
   565         Reviewed by David Levin.
       
   566 
       
   567         [chromium] only pass --force to gclient sync if explicitly stated
       
   568         https://bugs.webkit.org/show_bug.cgi?id=42581
       
   569 
       
   570         * BuildSlaveSupport/build.webkit.org-config/master.cfg: bots should
       
   571               always pass --force since it's hard to do manual cleanups
       
   572         * Scripts/update-webkit-chromium: only pass --force if --force is
       
   573               passed in
       
   574 
       
   575 2010-07-19  Anders Carlsson  <andersca@apple.com>
       
   576 
       
   577         Fix build.
       
   578 
       
   579         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
       
   580         Paths of generated files should be relative to the build product.
       
   581 
       
   582 2010-07-19  Daniel Bates  <dbates@rim.com>
       
   583 
       
   584         Reviewed by Adam Roben.
       
   585 
       
   586         [Win] Implement LayoutTestController::markerTextForListItem()
       
   587         https://bugs.webkit.org/show_bug.cgi?id=37930
       
   588 
       
   589         Implements DRT support for markerTextForListItem in the Windows port.
       
   590 
       
   591         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
       
   592         (LayoutTestController::markerTextForListItem): Implemented.
       
   593 
       
   594 2010-07-19  Jessie Berlin  <jberlin@apple.com>
       
   595 
       
   596         Windows build fix. Unreviewed.
       
   597 
       
   598         * WebKitTestRunner/win/TestControllerWin.cpp:
       
   599         (WTR::TestController::initializeTestPluginPath):
       
   600 
       
   601 2010-07-19  Sam Weinig  <sam@webkit.org>
       
   602 
       
   603         Reviewed by Jon Honeycutt.
       
   604 
       
   605         Remove dependency on getopt from WebKitTestRunner.
       
   606 
       
   607         - Simplify options parsing and eliminate unused options.
       
   608 
       
   609         * WebKitTestRunner/TestController.cpp:
       
   610         (WTR::TestController::TestController):
       
   611         (WTR::TestController::initialize):
       
   612         * WebKitTestRunner/TestController.h:
       
   613         (WTR::TestController::testPluginPath):
       
   614         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
       
   615         * WebKitTestRunner/mac/TestControllerMac.mm:
       
   616         (WTR::TestController::platformInitialize):
       
   617         (WTR::TestController::initializeTestPluginPath):
       
   618         * WebKitTestRunner/win/TestControllerWin.cpp:
       
   619         (WTR::TestController::platformInitialize):
       
   620         (WTR::TestController::initializeTestPluginPath):
       
   621 
       
   622 2010-07-19  Diego Gonzalez  <diegohcg@webkit.org>
       
   623 
       
   624         Reviewed by Antonio Gomes.
       
   625 
       
   626         [Qt] MiniBrowser: Progress indication at address bar
       
   627         https://bugs.webkit.org/show_bug.cgi?id=42565
       
   628 
       
   629         Make possible to see load progress at address bar based on
       
   630         QtTestBrowser solution
       
   631 
       
   632         * MiniBrowser/qt/BrowserWindow.cpp:
       
   633         (BrowserWindow::BrowserWindow):
       
   634         (BrowserWindow::loadProgress):
       
   635         * MiniBrowser/qt/BrowserWindow.h:
       
   636 
       
   637 2010-07-19  Diego Gonzalez  <diegohcg@webkit.org>
       
   638 
       
   639         Reviewed by Antonio Gomes.
       
   640 
       
   641         [Qt] Add MiniBrowser features: urlChanged, titleChanged and from user input load
       
   642         https://bugs.webkit.org/show_bug.cgi?id=42564
       
   643 
       
   644         * MiniBrowser/qt/BrowserWindow.cpp:
       
   645         (BrowserView::load):
       
   646         (BrowserWindow::BrowserWindow):
       
   647         (BrowserWindow::titleChanged):
       
   648         (BrowserWindow::urlChanged):
       
   649         * MiniBrowser/qt/BrowserWindow.h:
       
   650 
       
   651 2010-07-19  Sam Weinig  <weinig@apple.com>
       
   652 
       
   653         Reviewed by Adam Roben.
       
   654 
       
   655         Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
       
   656         Auto-generate the JS bindings for WebKitTestRunner's script objects.
       
   657 
       
   658         * WebKitTestRunner/Configurations/Base.xcconfig:
       
   659         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
       
   660         * WebKitTestRunner/DerivedSources.make: Added.
       
   661         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
       
   662         * WebKitTestRunner/InjectedBundle/Bindings: Added.
       
   663         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
       
   664         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
       
   665         (WTR::JSWrappable::~JSWrappable):
       
   666         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
       
   667         (WTR::JSWrapper::wrap):
       
   668         (WTR::JSWrapper::unwrap):
       
   669         (WTR::unwrapObject):
       
   670         (WTR::JSWrapper::initialize):
       
   671         (WTR::JSWrapper::finalize):
       
   672         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
       
   673         (WTR::toJS):
       
   674         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
       
   675         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
       
   676         (WTR::InjectedBundlePage::dump):
       
   677         (WTR::InjectedBundlePage::setStatusbarText):
       
   678         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
       
   679         (WTR::LayoutTestController::wrapperClass):
       
   680         (WTR::LayoutTestController::waitUntilDone):
       
   681         (WTR::LayoutTestController::makeWindowObject):
       
   682         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
       
   683         (WTR::LayoutTestController::shouldDumpAsText):
       
   684         (WTR::LayoutTestController::dumpAsText):
       
   685         (WTR::LayoutTestController::shouldDumpStatusCallbacks):
       
   686         (WTR::LayoutTestController::dumpStatusCallbacks):
       
   687         (WTR::LayoutTestController::waitToDump):
       
   688         (WTR::LayoutTestController::testRepaint):
       
   689         (WTR::LayoutTestController::repaintSweepHorizontally):
       
   690         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
       
   691         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
       
   692         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added.
       
   693         * WebKitTestRunner/win/build-generated-files.sh: Added.
       
   694 
       
   695 2010-07-19  Mark Rowe  <mrowe@apple.com>
       
   696 
       
   697         Clean up the buildbot configuration a little.
       
   698 
       
   699         * BuildSlaveSupport/build.webkit.org-config/config.json:
       
   700 
       
   701 2010-07-19  Chris Marrin  <cmarrin@apple.com>
       
   702 
       
   703         Reviewed by Darin Adler.
       
   704 
       
   705         https://bugs.webkit.org/show_bug.cgi?id=42118
       
   706         Disable WebGL on Leopard for now. 
       
   707 
       
   708         LayoutTests fail on some graphics hardware on Leopard because one of the features we use,
       
   709         GL_ARB_framebuffer_object, is not universally available in Leopard like it is in
       
   710         SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a
       
   711         software OpenGL driver on machines without this support.
       
   712 
       
   713         * Scripts/build-webkit:
       
   714 
       
   715 2010-07-19  Simon Fraser  <simon.fraser@apple.com>
       
   716 
       
   717         Reviewed by Brady Eidson.
       
   718 
       
   719         Fix MiniBrowser to update URL as you browse
       
   720         https://bugs.webkit.org/show_bug.cgi?id=42591
       
   721         
       
   722         Hook up various loading notifications to update the URL bar in MiniBrowser.
       
   723 
       
   724         * MiniBrowser/mac/BrowserWindowController.m:
       
   725         (_didStartProvisionalLoadForFrame):
       
   726         (_didReceiveServerRedirectForProvisionalLoadForFrame):
       
   727         (_didFailProvisionalLoadWithErrorForFrame):
       
   728         (_didCommitLoadForFrame):
       
   729         (_didFailLoadWithErrorForFrame):
       
   730         (-[BrowserWindowController updateProvisionalURLForFrame:]):
       
   731         (-[BrowserWindowController didStartProvisionalLoadForFrame:]):
       
   732         (-[BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
       
   733         (-[BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
       
   734         (-[BrowserWindowController didFailLoadWithErrorForFrame:]):
       
   735         (-[BrowserWindowController didCommitLoadForFrame:]):
       
   736 
       
   737 2010-07-19  Alexey Proskuryakov  <ap@apple.com>
       
   738 
       
   739         Reviewed by Darin Adler.
       
   740 
       
   741         https://bugs.webkit.org/show_bug.cgi?id=42586
       
   742         Log all canceled authentication attempts in DumpRenderTree
       
   743 
       
   744         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
       
   745         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
       
   746         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
       
   747         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
       
   748         It's important to know whether an auth sheet appeared. Added logging to "no preset credentials"
       
   749         case.
       
   750 
       
   751 2010-07-19  Sheriff Bot  <webkit.review.bot@gmail.com>
       
   752 
       
   753         Unreviewed, rolling out r63671.
       
   754         http://trac.webkit.org/changeset/63671
       
   755         https://bugs.webkit.org/show_bug.cgi?id=42575
       
   756 
       
   757         broke windows (Requested by weinig on #webkit).
       
   758 
       
   759         * WebKitTestRunner/Configurations/Base.xcconfig:
       
   760         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
       
   761         * WebKitTestRunner/DerivedSources.make: Removed.
       
   762         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Removed.
       
   763         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Removed.
       
   764         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Removed.
       
   765         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Removed.
       
   766         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Removed.
       
   767         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
       
   768         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
       
   769         (WTR::InjectedBundlePage::dump):
       
   770         (WTR::InjectedBundlePage::setStatusbarText):
       
   771         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
       
   772         (WTR::LayoutTestController::setWaitToDump):
       
   773         (WTR::displayCallback):
       
   774         (WTR::dumpAsTextCallback):
       
   775         (WTR::dumpStatusCallbacksCallback):
       
   776         (WTR::waitUntilDoneCallback):
       
   777         (WTR::notifyDoneCallback):
       
   778         (WTR::numberOfActiveAnimationsCallback):
       
   779         (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
       
   780         (WTR::repaintSweepHorizontallyCallback):
       
   781         (WTR::testRepaintCallback):
       
   782         (WTR::layoutTestControllerObjectFinalize):
       
   783         (WTR::LayoutTestController::makeWindowObject):
       
   784         (WTR::LayoutTestController::getJSClass):
       
   785         (WTR::LayoutTestController::staticFunctions):
       
   786         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
       
   787         (WTR::LayoutTestController::dumpAsText):
       
   788         (WTR::LayoutTestController::setDumpAsText):
       
   789         (WTR::LayoutTestController::dumpStatusCallbacks):
       
   790         (WTR::LayoutTestController::setDumpStatusCallbacks):
       
   791         (WTR::LayoutTestController::setTestRepaint):
       
   792         (WTR::LayoutTestController::setTestRepaintSweepHorizontally):
       
   793         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
       
   794 
       
   795 2010-07-19  Sam Weinig  <sam@webkit.org>
       
   796 
       
   797         Reviewed by Adam Roben.
       
   798 
       
   799         Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
       
   800         Auto-generate the JS bindings for WebKitTestRunner's script objects.
       
   801 
       
   802         * WebKitTestRunner/Configurations/Base.xcconfig:
       
   803         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
       
   804         * WebKitTestRunner/DerivedSources.make: Added.
       
   805         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
       
   806         * WebKitTestRunner/InjectedBundle/Bindings: Added.
       
   807         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
       
   808         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
       
   809         (WTR::JSWrappable::~JSWrappable):
       
   810         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
       
   811         (WTR::JSWrapper::wrap):
       
   812         (WTR::JSWrapper::unwrap):
       
   813         (WTR::unwrapObject):
       
   814         (WTR::JSWrapper::initialize):
       
   815         (WTR::JSWrapper::finalize):
       
   816         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
       
   817         (WTR::toJS):
       
   818         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
       
   819         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
       
   820         (WTR::InjectedBundlePage::dump):
       
   821         (WTR::InjectedBundlePage::setStatusbarText):
       
   822         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
       
   823         (WTR::LayoutTestController::wrapperClass):
       
   824         (WTR::LayoutTestController::waitUntilDone):
       
   825         (WTR::LayoutTestController::makeWindowObject):
       
   826         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
       
   827         (WTR::LayoutTestController::shouldDumpAsText):
       
   828         (WTR::LayoutTestController::dumpAsText):
       
   829         (WTR::LayoutTestController::shouldDumpStatusCallbacks):
       
   830         (WTR::LayoutTestController::dumpStatusCallbacks):
       
   831         (WTR::LayoutTestController::waitToDump):
       
   832         (WTR::LayoutTestController::testRepaint):
       
   833         (WTR::LayoutTestController::repaintSweepHorizontally):
       
   834         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
       
   835 
       
   836 2010-07-19  Tony Chang  <tony@chromium.org>
       
   837 
       
   838         Reviewed by David Levin.
       
   839 
       
   840         fix chromium linux compile on ubuntu maverick
       
   841         https://bugs.webkit.org/show_bug.cgi?id=42528
       
   842 
       
   843         * Scripts/webkitdirs.pm: add a chomp to eat a newline that breaks the make command line
       
   844 
       
   845 2010-07-19  Adam Roben  <aroben@apple.com>
       
   846 
       
   847         When dumping a response's MIME type, print its URL's last path
       
   848         component rather than its suitable-for-test-result form
       
   849 
       
   850         This matches the Mac behavior.
       
   851 
       
   852         Fixes <http://webkit.org/b/42276>
       
   853         http/tests/loading/preload-slow-loading.php and
       
   854         http/tests/mime/uppercase-mime-type.html fail on Windows
       
   855 
       
   856         Reviewed by Anders Carlsson.
       
   857 
       
   858         * DumpRenderTree/win/DumpRenderTree.cpp:
       
   859         (urlSuitableForTestResult): Moved code to actually extract the last
       
   860         path component from here...
       
   861         (lastPathComponent): ...to here.
       
   862 
       
   863         * DumpRenderTree/win/DumpRenderTreeWin.h: Added lastPathComponent.
       
   864 
       
   865         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
       
   866         (ResourceLoadDelegate::didReceiveResponse): Use the URL's last path
       
   867         component, rather than its suitable-for-test-result form, to match
       
   868         Mac.
       
   869 
       
   870 2010-07-19  Anders carlsson  <andersca@apple.com>
       
   871 
       
   872         Reviewed by Adam Roben.
       
   873 
       
   874         WebKit2 does not have application cache
       
   875         https://bugs.webkit.org/show_bug.cgi?id=42552
       
   876 
       
   877         * WebKitTestRunner/TestInvocation.cpp:
       
   878         (WTR::TestInvocation::resetPreferencesToConsistentValues):
       
   879         Set up default preferences. Right now just enables the web application cache.
       
   880 
       
   881         (WTR::TestInvocation::invoke):
       
   882         Call resetPreferencesToConsistentValues.
       
   883 
       
   884         * WebKitTestRunner/TestInvocation.h:
       
   885 
       
   886 2010-07-19  Kent Tamura  <tkent@chromium.org>
       
   887 
       
   888         Reviewed by Adam Roben.
       
   889 
       
   890         Fix NewRunWebKitTests to work on Windows.
       
   891         https://bugs.webkit.org/show_bug.cgi?id=41180
       
   892 
       
   893         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
       
   894           Specifying python explicitly.
       
   895 
       
   896 2010-07-18  Anders Carlsson  <andersca@apple.com>
       
   897 
       
   898         Reviewed by Dan Bernstein.
       
   899 
       
   900         Add dumping of statusbar text to WebKitTestRunner
       
   901         https://bugs.webkit.org/show_bug.cgi?id=42516
       
   902 
       
   903         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
       
   904         (WTR::InjectedBundlePage::InjectedBundlePage):
       
   905         (WTR::InjectedBundlePage::_setStatusbarText):
       
   906         (WTR::InjectedBundlePage::setStatusbarText):
       
   907         Dump the statusbar text.
       
   908 
       
   909         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
       
   910         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
       
   911         (WTR::LayoutTestController::LayoutTestController):
       
   912         Initialize m_dumpStatusCallbacks to false.
       
   913 
       
   914         (WTR::dumpStatusCallbacksCallback):
       
   915         Implement JSC callback.
       
   916 
       
   917         (WTR::LayoutTestController::staticFunctions):
       
   918         Add dumpStatusCallbacks.
       
   919 
       
   920         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
       
   921         (WTR::LayoutTestController::dumpStatusCallbacks):
       
   922         (WTR::LayoutTestController::setDumpStatusCallbacks):
       
   923         Add setter and getter for m_dumpStatusCallbacks.
       
   924 
       
   925 2010-07-17  Anders Carlsson  <andersca@apple.com>
       
   926 
       
   927         Reviewed by Maciej Stachowiak.
       
   928 
       
   929         * WebKitTestRunner/TestController.cpp:
       
   930         (WTR::TestController::initialize):
       
   931         Get the test plug-in path and set it on the context.
       
   932 
       
   933         * WebKitTestRunner/TestController.h:
       
   934         * WebKitTestRunner/mac/TestControllerMac.mm:
       
   935         (WTR::TestController::initializeInjectedBundlePath):
       
   936         Simplify this code by using NSBundle.
       
   937 
       
   938         (WTR::TestController::testPluginPath):
       
   939         Return the test plug-in path.
       
   940 
       
   941         * WebKitTestRunner/win/TestControllerWin.cpp:
       
   942         (WTR::TestController::testPluginPath):
       
   943         Ditto.
       
   944 
       
   945 2010-07-16  Adam Barth  <abarth@webkit.org>
       
   946 
       
   947         Reviewed by Eric Seidel.
       
   948 
       
   949         Teach webkitpy about queues.webkit.org
       
   950         https://bugs.webkit.org/show_bug.cgi?id=42492
       
   951 
       
   952         * Scripts/webkitpy/common/net/statusserver.py:
       
   953 
       
   954 2010-07-16  Ada Chan  <adachan@apple.com>
       
   955 
       
   956         Reviewed by Alice Liu.
       
   957 
       
   958         Fix Windows build.
       
   959 
       
   960         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
       
   961 
       
   962 2010-07-16  Sam Weinig  <sam@webkit.org>
       
   963 
       
   964         Reviewed by Anders Carlsson.
       
   965 
       
   966         Fix for https://bugs.webkit.org/show_bug.cgi?id=42482
       
   967         <rdar://problem/8197701>
       
   968         Add notification of when the BackForwardList changes
       
   969         to aid invalidation of Back/Forward related UI elements.
       
   970 
       
   971         * MiniBrowser/mac/BrowserWindowController.m:
       
   972         (_didStartProvisionalLoadForFrame):
       
   973         (_didCommitLoadForFrame):
       
   974         (_didFailLoadWithErrorForFrame):
       
   975         (_didChangeBackForwardList):
       
   976         (-[BrowserWindowController awakeFromNib]):
       
   977         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
       
   978 
       
   979 2010-07-16  Kent Tamura  <tkent@chromium.org>
       
   980 
       
   981         Reviewed by Darin Fisher.
       
   982 
       
   983         [Chromium] <input type=number> UI implementation for Windows
       
   984         https://bugs.webkit.org/show_bug.cgi?id=42259
       
   985 
       
   986         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
       
   987         (WebThemeEngineDRT::paintSpinButton):
       
   988          Added. Check state consistency and use existing arrow painting code.
       
   989         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
       
   990 
       
   991 2010-07-16  Alice Liu  <alice.liu@apple.com>
       
   992 
       
   993         Reviewed by Sam Weinig.
       
   994 
       
   995         https://bugs.webkit.org/show_bug.cgi?id=42430
       
   996         Make WebKitTestRunner on Windows actually load and run a test
       
   997 
       
   998         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Export WKBundleInitialize.
       
   999         (WKBundleInitialize):
       
  1000         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added.  Output is a dll.
       
  1001         * WebKitTestRunner/TestInvocation.cpp: Create a Windows-style path on Windows
       
  1002         (WTR::createWKURL):
       
  1003         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Change check for Windows platform to match
       
  1004         other existing checks, and avoid including Platform.h
       
  1005         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
       
  1006         (WTR::registerWindowClass): Added.
       
  1007         (WTR::PlatformWebView::PlatformWebView): Implemented.
       
  1008         (WTR::PlatformWebView::~PlatformWebView): Implemented.
       
  1009         (WTR::PlatformWebView::page): Implemented.
       
  1010         * WebKitTestRunner/win/TestControllerWin.cpp:
       
  1011         (WTR::TestController::initializeInjectedBundlePath): Implemented. Provide build 
       
  1012         configuration specific path to InjectedBundle.dll.
       
  1013         * WebKitTestRunner/win/TestInvocationWin.cpp:
       
  1014         (WTR::TestInvocation::runUntil): Implemented.
       
  1015         * WebKitTestRunner/win/WebKitTestRunner.sln: Added InjectedBundle project.
       
  1016         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Cleaned up unnecessary dependencies.
       
  1017 
       
  1018 2010-07-16  Brady Eidson  <beidson@apple.com>
       
  1019 
       
  1020         Reviewed by Sam Weinig.
       
  1021 
       
  1022         Make revalidation of back/forward work a little better with page loads
       
  1023         https://bugs.webkit.org/show_bug.cgi?id=42470
       
  1024 
       
  1025         * MiniBrowser/mac/BrowserWindow.xib:
       
  1026         * MiniBrowser/mac/BrowserWindowController.h:
       
  1027         * MiniBrowser/mac/BrowserWindowController.m:
       
  1028         (-[BrowserWindowController validateToolbar]):
       
  1029         (_didStartProvisionalLoadForFrame):
       
  1030         (_didCommitLoadForFrame):
       
  1031         (_didFailLoadWithErrorForFrame):
       
  1032 
       
  1033 2010-07-16  Nikolas Zimmermann  <nzimmermann@rim.com>
       
  1034 
       
  1035         Reviewed by Dirk Schulze.
       
  1036 
       
  1037         Add possibility to dumpAsText and generate a pixel test result
       
  1038         https://bugs.webkit.org/show_bug.cgi?id=42374
       
  1039 
       
  1040         Add optional parameter to setDumpAsText() to allow generating a pixel test result even if dumpAsText mode.
       
  1041         setDumpAsText(true) will also generate a pixel test result now, when running run-webkit-tests --pixel-tests.
       
  1042 
       
  1043         This is needed for the svg/dynamic-updates tests, which don't want render tree dumps but text dumps + a pixel test result.
       
  1044         At some point DRT changed to not generate pixel test results when using dumpAsText - which makes sense, but breaks the svg/dynamic-updates test.
       
  1045 
       
  1046         Implemented for all DRT platforms, except Qt, as it's not clear how arguments to functions like "setDumpAsText" are handled.
       
  1047         (Qt always dumps pixel tests when using --pixel-tests mode, so it does not break anything)
       
  1048 
       
  1049         * DumpRenderTree/LayoutTestController.cpp:
       
  1050         (LayoutTestController::LayoutTestController):
       
  1051         (dumpAsTextAndPixelsCallback):
       
  1052         (LayoutTestController::staticFunctions):
       
  1053         * DumpRenderTree/LayoutTestController.h:
       
  1054         (LayoutTestController::dumpAsTextAndPixels):
       
  1055         (LayoutTestController::setDumpAsTextAndPixels):
       
  1056         * DumpRenderTree/chromium/LayoutTestController.cpp:
       
  1057         (LayoutTestController::LayoutTestController):
       
  1058         (LayoutTestController::dumpAsTextAndPixels):
       
  1059         (LayoutTestController::reset):
       
  1060         * DumpRenderTree/chromium/LayoutTestController.h:
       
  1061         (LayoutTestController::shouldDumpAsTextAndPixels):
       
  1062         * DumpRenderTree/chromium/TestShell.cpp:
       
  1063         (TestShell::dump):
       
  1064         * DumpRenderTree/gtk/DumpRenderTree.cpp:
       
  1065         (dump):
       
  1066         * DumpRenderTree/mac/DumpRenderTree.mm:
       
  1067         (dump):
       
  1068         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
       
  1069         (WebCore::DumpRenderTree::dump):
       
  1070         * DumpRenderTree/win/DumpRenderTree.cpp:
       
  1071         (dump):
       
  1072         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
       
  1073         (dump):
       
  1074 
       
  1075 2010-07-16  Kent Hansen  <kent.hansen@nokia.com>
       
  1076 
       
  1077         Unreviewed. Adding myself as committer.
       
  1078 
       
  1079         * Scripts/webkitpy/common/config/committers.py:
       
  1080 
       
  1081 2010-07-16  Shinichiro Hamaji  <hamaji@chromium.org>
       
  1082 
       
  1083         Another uneviewed attempt to fix build.
       
  1084 
       
  1085         Printing test results differ between machines, we should use ImageDiff instead
       
  1086         https://bugs.webkit.org/show_bug.cgi?id=20011
       
  1087 
       
  1088         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
       
  1089         (createPagedBitmapContext):
       
  1090 
       
  1091 2010-07-16  Shinichiro Hamaji  <hamaji@chromium.org>
       
  1092 
       
  1093         Unreviewed tiger build fix.
       
  1094 
       
  1095         Printing test results differ between machines, we should use ImageDiff instead
       
  1096         https://bugs.webkit.org/show_bug.cgi?id=20011
       
  1097 
       
  1098         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
       
  1099         (createBitmapContext):
       
  1100         (createBitmapContextFromWebView):
       
  1101 
       
  1102 2010-07-15  Shinichiro Hamaji  <hamaji@chromium.org>
       
  1103 
       
  1104         Unreviewed build fix.
       
  1105 
       
  1106         Printing test results differ between machines, we should use ImageDiff instead
       
  1107         https://bugs.webkit.org/show_bug.cgi?id=20011
       
  1108 
       
  1109         * DumpRenderTree/PixelDumpSupport.cpp:
       
  1110         (dumpWebViewAsPixelsAndCompareWithExpected):
       
  1111 
       
  1112 2010-07-15  Shinichiro Hamaji  <hamaji@chromium.org>
       
  1113 
       
  1114         Reviewed by Darin Adler.
       
  1115 
       
  1116         Printing test results differ between machines, we should use ImageDiff instead
       
  1117         https://bugs.webkit.org/show_bug.cgi?id=20011
       
  1118 
       
  1119         * DumpRenderTree/PixelDumpSupport.cpp:
       
  1120         (dumpWebViewAsPixelsAndCompareWithExpected):
       
  1121         * DumpRenderTree/PixelDumpSupport.h:
       
  1122         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
       
  1123         (createBitmapContext): This function was added to share bitmap context creation code.
       
  1124         (createBitmapContextFromWebView):
       
  1125         (createPagedBitmapContext):
       
  1126 
       
  1127 2010-07-15  Yuta Kitamura  <yutak@chromium.org>
       
  1128 
       
  1129         Reviewed by Kent Tamura.
       
  1130 
       
  1131         Pull in pywebsocket-0.5.1
       
  1132         https://bugs.webkit.org/show_bug.cgi?id=42353
       
  1133 
       
  1134         pywebsocket-0.5.1 contains a small bug fix (*) that should fix a worker test
       
  1135         in Chromium. There is no other functional change.
       
  1136 
       
  1137         (*) http://code.google.com/p/pywebsocket/source/detail?r=265
       
  1138 
       
  1139         * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version to 0.5.1.
       
  1140 
       
  1141 2010-07-15  Brady Eidson  <beidson@apple.com>
       
  1142 
       
  1143         Reviewed by Sam Weinig.
       
  1144 
       
  1145         Add toolbar and toolbar item validation for MiniBrowser
       
  1146         https://bugs.webkit.org/show_bug.cgi?id=42422
       
  1147 
       
  1148         * MiniBrowser/MBToolbarItem.h: Added.
       
  1149         * MiniBrowser/MBToolbarItem.m: Added.
       
  1150         (-[MBToolbarItem validate]):
       
  1151 
       
  1152         * MiniBrowser/mac/BrowserWindowController.m:
       
  1153         (-[BrowserWindowController validateUserInterfaceItem:]):
       
  1154 
       
  1155         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
       
  1156         * MiniBrowser/mac/BrowserWindow.xib:
       
  1157 
       
  1158 2010-07-15  Victor Wang  <victorw@chromium.org>
       
  1159 
       
  1160         Unreviewed, add victorw irc nickname to committer list.
       
  1161 
       
  1162         * Scripts/webkitpy/common/config/committers.py:
       
  1163 
       
  1164 2010-07-15  Adam Roben  <aroben@apple.com>
       
  1165 
       
  1166         Make killing Apache more reliable (on both Mac and Windows)
       
  1167 
       
  1168         We previously had two ways of determining whether we had succeeded in
       
  1169         killing Apache:
       
  1170           1) checking the return value of kill(0, $apachePID)
       
  1171           2) checking whether Apache's PID file still exists
       
  1172 
       
  1173         On Cygwin, Apache doesn't always delete its PID file when it exits,
       
  1174         making (2) unreliable. We unfortunately misdiagnosed this as an
       
  1175         impotency of Perl's kill function, which led to r63177 and r63355.
       
  1176 
       
  1177         Now that we know that the real problem is that Apache doesn't always
       
  1178         delete its PID file on Windows, we can make a much better fix: always
       
  1179         use method (1) to determine whether we've killed Apache.
       
  1180 
       
  1181         Fixes <http://webkit.org/b/42415> Killing Apache is unreliable,
       
  1182         leading to regression test failures (and general annoyance).
       
  1183 
       
  1184         Reviewed by Anders Carlsson.
       
  1185 
       
  1186         * Scripts/webkitperl/httpd.pm:
       
  1187         (openHTTPD): Moved killing code from here to killHTTPD. Added a call
       
  1188         to delete the PID file in case Apache doesn't do this itself when
       
  1189         killed. Our later logic relies on the PID file being deleted after
       
  1190         this point.
       
  1191         (closeHTTPD): Removed killing logic and changed to just call killHTTPD
       
  1192         instead. killHTTPD's logic is a bit different from the logic we had
       
  1193         here, for the reasons stated above.
       
  1194         (killHTTPD): Added. Code came from openHTTPD.
       
  1195         (handleInterrupt): Bonus fix for Mac: don't hang when pressing Ctrl-C!
       
  1196         On Mac, don't try to kill Apache when we receive a signal, as Apache
       
  1197         will already have been killed by this point (though for some reason
       
  1198         this isn't detected by our killing logic in killHTTPD). On Cygwin, we
       
  1199         still need to kill Apache manually.
       
  1200 
       
  1201 2010-07-15  Sam Weinig  <sam@webkit.org>
       
  1202 
       
  1203         Reviewed by Anders Carlsson.
       
  1204 
       
  1205         Patch for https://bugs.webkit.org/show_bug.cgi?id=42399
       
  1206         Update MiniBrowser for WKFrameNavigationType 
       
  1207 
       
  1208         * MiniBrowser/mac/BrowserWindowController.m:
       
  1209         (_decidePolicyForNavigationAction):
       
  1210         (_decidePolicyForNewWindowAction):
       
  1211 
       
  1212 2010-07-15  Stephanie Lewis  <slewis@apple.com>
       
  1213 
       
  1214         Reviewed by Geoff Garen.
       
  1215 
       
  1216         http://bugs.webkit.org/show_bug.cgi?id=42406
       
  1217         Make SunSpider work better with roots.
       
  1218 
       
  1219         * Scripts/sunspider-compare-results: fix argument bug
       
  1220         * Scripts/webkitdirs.pm: look inside JavaScriptCore if jsc isn't top-level.
       
  1221 
       
  1222 2010-07-15  Brady Eidson  <beidson@apple.com>
       
  1223 
       
  1224         Reviewed by Sam Weinig.
       
  1225 
       
  1226         Hook up back/forward in MiniBrowser
       
  1227         https://bugs.webkit.org/show_bug.cgi?id=42397
       
  1228 
       
  1229         * MiniBrowser/mac/BrowserWindow.xib:
       
  1230         * MiniBrowser/mac/BrowserWindowController.h:
       
  1231         * MiniBrowser/mac/BrowserWindowController.m:
       
  1232         (-[BrowserWindowController goBack:]):
       
  1233         (-[BrowserWindowController goForward:]):
       
  1234 
       
  1235 2010-07-15  Daniel Bates  <dbates@rim.com>
       
  1236 
       
  1237         Reviewed by Darin Adler.
       
  1238 
       
  1239         [Mac] Implement LayoutTestController::markerTextForListItem()
       
  1240         https://bugs.webkit.org/show_bug.cgi?id=37929
       
  1241 
       
  1242         Implements DRT support for markerTextForListItem in the Mac port.
       
  1243 
       
  1244         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
       
  1245         (LayoutTestController::markerTextForListItem): Implemented.
       
  1246 
       
  1247 2010-07-15  Adam Barth  <abarth@webkit.org>
       
  1248 
       
  1249         Unreviewed.
       
  1250 
       
  1251         Update the port names to be more specific.  Before this patch,
       
  1252         port-specific results for Mac would end up in the wrong place.
       
  1253 
       
  1254         * Scripts/webkitpy/tool/commands/rebaseline.py:
       
  1255         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
       
  1256 
       
  1257 2010-07-14  Eric Seidel  <eric@webkit.org>
       
  1258 
       
  1259         Reviewed by Adam Barth.
       
  1260 
       
  1261         WebKit needs a rebaselining tool (finally)
       
  1262         https://bugs.webkit.org/show_bug.cgi?id=42339
       
  1263 
       
  1264         This is a very basic rebaselining tool.  It's not
       
  1265         quite as fancy as chromium's as it will only handle
       
  1266         updating failing results.  It cannot yet handle adding new
       
  1267         results, or updating results where the results should not
       
  1268         replace existing results.
       
  1269 
       
  1270         * Scripts/webkitpy/layout_tests/port/base.py:
       
  1271         * Scripts/webkitpy/tool/commands/__init__.py:
       
  1272         * Scripts/webkitpy/tool/commands/queries.py:
       
  1273         * Scripts/webkitpy/tool/commands/rebaseline.py: Added.
       
  1274         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added.
       
  1275 
       
  1276 2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
       
  1277 
       
  1278         Unreviewed, rolling out r63352.
       
  1279         http://trac.webkit.org/changeset/63352
       
  1280         https://bugs.webkit.org/show_bug.cgi?id=42341
       
  1281 
       
  1282         Broke plugin-initiate-popup-window.html and plugin-javascript-
       
  1283         access.html on snow leopard (Requested by abarth on #webkit).
       
  1284 
       
  1285         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
       
  1286         (pluginAllocate):
       
  1287         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
       
  1288         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
       
  1289         (NPP_New):
       
  1290         (handleEventCarbon):
       
  1291         (handleEventCocoa):
       
  1292 
       
  1293 2010-07-14  Maciej Stachowiak  <mjs@apple.com>
       
  1294 
       
  1295         Reviewed by Mark Rowe.
       
  1296 
       
  1297         Lower WebKitTestRunner notifyDone timeout to 6.0 for now, to make it easier to grind through the failures.
       
  1298 
       
  1299         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
       
  1300 
       
  1301 2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
       
  1302 
       
  1303         Unreviewed, rolling out r63346.
       
  1304         http://trac.webkit.org/changeset/63346
       
  1305         https://bugs.webkit.org/show_bug.cgi?id=42295
       
  1306 
       
  1307         Broke lots of tests, some of which probably just need new
       
  1308         results (Requested by aroben on #webkit).
       
  1309 
       
  1310         * DumpRenderTree/win/DumpRenderTree.cpp:
       
  1311         (urlSuitableForTestResult):
       
  1312 
       
  1313 2010-07-14  Adam Roben  <aroben@apple.com>
       
  1314 
       
  1315         Speed up killing of Apache on Windows
       
  1316 
       
  1317         Fixes <http://webkit.org/b/42289> Killing Apache (and thus quitting
       
  1318         run-webkit-tests) takes a long time on Windows
       
  1319 
       
  1320         Reviewed by Darin Adler and Jon Honeycutt.
       
  1321 
       
  1322         * Scripts/webkitperl/httpd.pm:
       
  1323         (closeHTTPD): Use taskkill to kill Apache and its child processes.
       
  1324         Perl's kill seems ineffectual. We were already using taskkill, but
       
  1325         only after trying kill 20 times. Since kill never works, let's just
       
  1326         skip it entirely.
       
  1327 
       
  1328 2010-07-14  Johnny Ding  <jnd@chromium.org>
       
  1329 
       
  1330         Reviewed by Adam Barth.
       
  1331 
       
  1332         https://bugs.webkit.org/show_bug.cgi?id=41292
       
  1333         Add a new parameter to the test plugin to allow to specify a script and a
       
  1334         mouse/keyboard event. The specified script will be evaluated in the browser
       
  1335         when the specified event is received by the plugin.
       
  1336 
       
  1337         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
       
  1338         (pluginAllocate):
       
  1339         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
       
  1340         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
       
  1341         (NPP_New):
       
  1342         (handleEventCarbon):
       
  1343         (handleEventCocoa):
       
  1344 
       
  1345 2010-07-14  Adam Roben  <aroben@apple.com>
       
  1346 
       
  1347         Make urlSuitableForTestResult work for http: URLs, too
       
  1348 
       
  1349         Fixes <http://webkit.org/b/42276>
       
  1350         http/tests/loading/preload-slow-loading.php and
       
  1351         http/tests/mime/uppercase-mime-type.html fail on Windows.
       
  1352 
       
  1353         Reviewed by Darin Adler.
       
  1354 
       
  1355         * DumpRenderTree/win/DumpRenderTree.cpp:
       
  1356         (urlSuitableForTestResult): Don't bail if the URL starts with http://.
       
  1357         We want this function to work for those URLs, too!
       
  1358 
       
  1359 2010-07-13  Maciej Stachowiak  <mjs@apple.com>
       
  1360 
       
  1361         Reviewed by Oliver Hunt.
       
  1362 
       
  1363         Add placebo versions of some repaint test functions to WebKitTestRunner - good enough for non-pixel tests
       
  1364         https://bugs.webkit.org/show_bug.cgi?id=42227
       
  1365 
       
  1366         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
       
  1367         (WTR::LayoutTestController::LayoutTestController): Initialize new bool
       
  1368         members.
       
  1369         (WTR::LayoutTestController::display): Dummy method.
       
  1370         (WTR::displayCallback): Call the dummy.
       
  1371         (WTR::repaintSweepHorizontallyCallback): ditto
       
  1372         (WTR::testRepaintCallback): ditto
       
  1373         (WTR::LayoutTestController::staticFunctions): Expose new methods.
       
  1374         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
       
  1375         (WTR::LayoutTestController::setTestRepaint): Set the flag (which currently does
       
  1376         nothing).
       
  1377         (WTR::LayoutTestController::setTestRepaintSweepHorizontally): ditto
       
  1378 
       
  1379 2010-07-13  Andreas Kling  <andreas.kling@nokia.com>
       
  1380 
       
  1381         Unreviewed. Adding myself as committer.
       
  1382 
       
  1383         * Scripts/webkitpy/common/config/committers.py:
       
  1384 
       
  1385 2010-07-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
       
  1386 
       
  1387         Reviewed by Darin Adler.
       
  1388 
       
  1389         Prevent assertion/duplicate loads for non-deferred subtitute-data loads
       
  1390 
       
  1391         https://bugs.webkit.org/show_bug.cgi?id=30879
       
  1392 
       
  1393         MainResourceLoader uses the member m_initialRequest to store requests for future
       
  1394         deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
       
  1395         have to clear this request so that subsequent entries into the loader will not
       
  1396         start yet another load.
       
  1397 
       
  1398         This can happen as a result of a PageGroupLoadDeferrer going out of scope when
       
  1399         returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
       
  1400         but only in the case of using both substitute-data and non-deferred main resource
       
  1401         load together. That's why two new DRT functions were added:
       
  1402 
       
  1403          * queueLoadHTMLString()
       
  1404          * setDeferMainResourceLoad()
       
  1405 
       
  1406         The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
       
  1407         and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
       
  1408         added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.
       
  1409 
       
  1410         * DumpRenderTree/LayoutTestController.cpp:
       
  1411         (LayoutTestController::LayoutTestController):
       
  1412         (queueLoadHTMLStringCallback):
       
  1413         (setDeferMainResourceDataLoadCallback):
       
  1414         (LayoutTestController::staticFunctions):
       
  1415         (LayoutTestController::queueLoadHTMLString):
       
  1416         * DumpRenderTree/LayoutTestController.h:
       
  1417         (LayoutTestController::deferMainResourceDataLoad):
       
  1418         (LayoutTestController::setDeferMainResourceDataLoad):
       
  1419         * DumpRenderTree/WorkQueueItem.h:
       
  1420         (LoadHTMLStringItem::LoadHTMLStringItem):
       
  1421         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
       
  1422         (LoadHTMLStringItem::invoke):
       
  1423         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
       
  1424         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
       
  1425         * DumpRenderTree/mac/WorkQueueItemMac.mm:
       
  1426         (LoadHTMLStringItem::invoke):
       
  1427         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
       
  1428         (LayoutTestController::reset):
       
  1429         (LayoutTestController::setDeferMainResourceDataLoad):
       
  1430         (LayoutTestController::queueLoadHTMLString):
       
  1431         * DumpRenderTree/qt/LayoutTestControllerQt.h:
       
  1432         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
       
  1433         (LoadHTMLStringItem::invoke):
       
  1434         * DumpRenderTree/qt/WorkQueueItemQt.h:
       
  1435         (LoadHTMLStringItem::LoadHTMLStringItem):
       
  1436         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
       
  1437         (ResourceLoadDelegate::willSendRequest):
       
  1438         * DumpRenderTree/win/WorkQueueItemWin.cpp:
       
  1439         (LoadHTMLStringItem::invoke):
       
  1440         * DumpRenderTree/wx/WorkQueueItemWx.cpp:
       
  1441         (LoadHTMLStringItem::invoke):
       
  1442 
       
  1443 2010-07-13  Maciej Stachowiak  <mjs@apple.com>
       
  1444 
       
  1445         Reviewed by Nikolas Zimmermann.
       
  1446 
       
  1447         Activate test fonts for layout tests in WebKitTestRunner (on Mac)
       
  1448         https://bugs.webkit.org/show_bug.cgi?id=42153
       
  1449 
       
  1450         * WebKitTestRunner/InjectedBundle/ActivateFonts.h: Added.
       
  1451         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
       
  1452         (WTR::InjectedBundle::initialize): Activate fonts on startup.
       
  1453         * WebKitTestRunner/InjectedBundle/mac: Added.
       
  1454         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: Added.
       
  1455         (WTR::activateFonts): Activate our fonts.
       
  1456         * WebKitTestRunner/InjectedBundle/win: Added.
       
  1457         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Added.
       
  1458         (WTR::activateFonts): Dummy version.
       
  1459         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Copy fonts to bundle;
       
  1460         add more files.
       
  1461         * WebKitTestRunner/fonts: Added.
       
  1462         * WebKitTestRunner/fonts/AHEM____.TTF: Added.
       
  1463         * WebKitTestRunner/fonts/ColorBits-A.png: Added.
       
  1464         * WebKitTestRunner/fonts/ColorBits.ttf: Added.
       
  1465         * WebKitTestRunner/fonts/WebKit Layout Tests 2.ttf: Added.
       
  1466         * WebKitTestRunner/fonts/WebKit Layout Tests.ttf: Added.
       
  1467         * WebKitTestRunner/fonts/WebKitWeightWatcher100.ttf: Added.
       
  1468         * WebKitTestRunner/fonts/WebKitWeightWatcher200.ttf: Added.
       
  1469         * WebKitTestRunner/fonts/WebKitWeightWatcher300.ttf: Added.
       
  1470         * WebKitTestRunner/fonts/WebKitWeightWatcher400.ttf: Added.
       
  1471         * WebKitTestRunner/fonts/WebKitWeightWatcher500.ttf: Added.
       
  1472         * WebKitTestRunner/fonts/WebKitWeightWatcher600.ttf: Added.
       
  1473         * WebKitTestRunner/fonts/WebKitWeightWatcher700.ttf: Added.
       
  1474         * WebKitTestRunner/fonts/WebKitWeightWatcher800.ttf: Added.
       
  1475         * WebKitTestRunner/fonts/WebKitWeightWatcher900.ttf: Added.
       
  1476 
       
  1477 2010-07-13  Dumitru Daniliuc  <dumi@chromium.org>
       
  1478 
       
  1479         Reviewed by Eric Seidel.
       
  1480 
       
  1481         Remove check-header-includes, as it didn't turn out to be very useful.
       
  1482         https://bugs.webkit.org/show_bug.cgi?id=41970
       
  1483 
       
  1484         * Scripts/check-header-includes: Removed.
       
  1485 
       
  1486 2010-07-12  Steve Falkenburg  <sfalken@apple.com>
       
  1487 
       
  1488         Reviewed by Maciej Stachowiak.
       
  1489 
       
  1490         Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots)
       
  1491         https://bugs.webkit.org/show_bug.cgi?id=40922
       
  1492         
       
  1493         Always build WebKit2 on Windows. Necessary since our WebKit build on
       
  1494         Windows is packaged into a DLL with WebKit2.
       
  1495 
       
  1496         * Scripts/build-webkit: Always build WebKit2 on Windows.
       
  1497 
       
  1498 2010-07-12  Brian Weinstein  <bweinstein@apple.com>
       
  1499 
       
  1500         Reviewed by Steve Falkenburg.
       
  1501 
       
  1502         One http test timing out on Windows can cause all future tests to time out
       
  1503         https://bugs.webkit.org/show_bug.cgi?id=42146
       
  1504         
       
  1505         There have been multiple times on the Windows bots where one http test timing out causes all future
       
  1506         http tests to time out. This is because the httpd process becomes unresponsive. When an http test
       
  1507         times out, we should restart httpd on Cygwin to prevent this.
       
  1508 
       
  1509         * Scripts/old-run-webkit-tests: If an http test timed out on Cygwin, close httpd and restart it.
       
  1510         * Scripts/webkitperl/httpd.pm: Add additional logic to closeHTTPD to teach it about taskkill if
       
  1511             using kill fails.
       
  1512 
       
  1513 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
       
  1514 
       
  1515         Reviewed by Dan Bernstein.
       
  1516 
       
  1517         Remove use of auto_ptr in WebKitTestRunner
       
  1518         https://bugs.webkit.org/show_bug.cgi?id=42134
       
  1519         
       
  1520         Replaced auto_ptr with PassOwnPtr / OwnPtr.
       
  1521 
       
  1522         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
       
  1523         (WTR::WKStringToUTF8):
       
  1524         (WTR::InjectedBundlePage::dump):
       
  1525         (WTR::InjectedBundlePage::addMessageToConsole):
       
  1526         * WebKitTestRunner/TestInvocation.cpp:
       
  1527         (WTR::WKStringToUTF8):
       
  1528         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
       
  1529 
       
  1530 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
       
  1531 
       
  1532         Reviewed by Sam Weinig.
       
  1533 
       
  1534         Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it)
       
  1535         https://bugs.webkit.org/show_bug.cgi?id=42132
       
  1536 
       
  1537         * Scripts/old-run-webkit-tests: In --webkit-test-runner mode, add mac-wk2 to list of
       
  1538         platform directories.
       
  1539 
       
  1540 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
       
  1541 
       
  1542         Reviewed by Anders Carlsson.
       
  1543 
       
  1544         Make WebKitTestRunner resize the view specially for the W3C SVG tests.
       
  1545         https://bugs.webkit.org/show_bug.cgi?id=42126
       
  1546 
       
  1547         * WebKitTestRunner/PlatformWebView.h:
       
  1548         * WebKitTestRunner/TestInvocation.cpp:
       
  1549         (WTR::TestInvocation::TestInvocation): Store the path as a C
       
  1550         string for later use.
       
  1551         (WTR::TestInvocation::~TestInvocation):
       
  1552         (WTR::sizeWebViewForCurrentTest): Resize the WebView to the proper
       
  1553         size, depending on whether this is a W3C SVG test.
       
  1554         (WTR::TestInvocation::invoke): Call the size function.
       
  1555         * WebKitTestRunner/TestInvocation.h:
       
  1556         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
       
  1557         (WTR::PlatformWebView::resizeTo): Implement.
       
  1558         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
       
  1559         (WTR::PlatformWebView::resizeTo): Placeholder.
       
  1560 
       
  1561 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
       
  1562 
       
  1563         Reviewed by Xan Lopez.
       
  1564 
       
  1565         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
       
  1566         https://bugs.webkit.org/show_bug.cgi?id=38648
       
  1567 
       
  1568         Add the GTK_MODULES envvar (set to "gail") to the clean
       
  1569         environment when running DRT for the Gtk+ port
       
  1570 
       
  1571         * Scripts/old-run-webkit-tests:
       
  1572 
       
  1573 2010-07-12  Martin Robinson  <mrobinson@igalia.com>
       
  1574 
       
  1575         Reviewed by Dirk Schulze.
       
  1576 
       
  1577         [GTK] Support pixel tests
       
  1578         https://bugs.webkit.org/show_bug.cgi?id=31518
       
  1579 
       
  1580         Finish support for pixel tests on GTK+.
       
  1581 
       
  1582         * DumpRenderTree/PixelDumpSupport.cpp: Remove unecessary RetainPtr include (only
       
  1583         works on CoreFoundation systems) and add missing cstdio include.
       
  1584         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Switch to using the MD5 support found
       
  1585         in JSC library. MD5.cpp and MD5.h are only available for the Windows build.
       
  1586         (computeMD5HashStringForBitmapContext): The number of bytes per row should be the row stride
       
  1587         of the image, not the row stride multiplied by the width. Use JSC MD5 implementation to calculate
       
  1588         the MD5 hash here. According to glibc manpages, using snprintf to build a string in unsupported
       
  1589         by the ANSI standard and this fails on Linux, so unroll the loop here.
       
  1590         * DumpRenderTree/cairo/PixelDumpSupportCairo.h: Correct some constructor misbehavior.
       
  1591         (BitmapContext::BitmapContext): There is no reason to check the value of the
       
  1592         m_context member in the constructor and it certainly should not be freed. Instead
       
  1593         just initialize it with the incoming value.
       
  1594         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the order of includes.
       
  1595         (dump): Actually call dumpWebViewAsPixelsAndCompareWithExpected when it is time to
       
  1596         dump pixels.
       
  1597         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Added.
       
  1598         (createBitmapContextFromWebView):
       
  1599         * GNUmakefile.am: Add new files to the build.
       
  1600 
       
  1601 2010-07-12  Adam Barth  <abarth@webkit.org>
       
  1602 
       
  1603         Unreviewed.
       
  1604 
       
  1605         Remove stray "raise e" that got included in a previous patch.  This
       
  1606         caused the EWS bots to turn red instead of purple when a patch failed
       
  1607         to apply.
       
  1608 
       
  1609         * Scripts/webkitpy/tool/commands/stepsequence.py:
       
  1610 
       
  1611 2010-07-12  Sheriff Bot  <webkit.review.bot@gmail.com>
       
  1612 
       
  1613         Unreviewed, rolling out r63101.
       
  1614         http://trac.webkit.org/changeset/63101
       
  1615         https://bugs.webkit.org/show_bug.cgi?id=42103
       
  1616 
       
  1617         Broke one API test (Requested by xan_ on #webkit).
       
  1618 
       
  1619         * Scripts/old-run-webkit-tests:
       
  1620 
       
  1621 2010-07-12  Alexey Proskuryakov  <ap@apple.com>
       
  1622 
       
  1623         Reviewed by Adam Roben.
       
  1624 
       
  1625         https://bugs.webkit.org/show_bug.cgi?id=13075
       
  1626         XMLHttpRequest with failed authentication should set status to 401
       
  1627 
       
  1628         https://bugs.webkit.org/show_bug.cgi?id=6871
       
  1629         <rdar://problem/3363403> 401 error page is never shown
       
  1630 
       
  1631         Fix crashes in Windows DumpRenderTree.
       
  1632 
       
  1633         * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
       
  1634         If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge()
       
  1635         again on a destroyed sender.
       
  1636 
       
  1637 2010-07-12  Adam Roben  <aroben@apple.com>
       
  1638 
       
  1639         Windows failure-to-launch fix
       
  1640 
       
  1641         * DumpRenderTree/win/DumpRenderTree.vcproj: Copy CoreVideo.dll and
       
  1642         CoreVideo.pdb into WebKitOutputDir in the post-build event, too, like
       
  1643         we already do for CoreFoundation, CFNetwork, etc.
       
  1644 
       
  1645 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
       
  1646 
       
  1647         Reviewed by Xan Lopez.
       
  1648 
       
  1649         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
       
  1650         https://bugs.webkit.org/show_bug.cgi?id=38648
       
  1651 
       
  1652         Add the GTK_MODULES envvar (set to "gail") to the clean
       
  1653         environment when running DRT for the Gtk+ port
       
  1654 
       
  1655         * Scripts/old-run-webkit-tests:
       
  1656 
       
  1657 2010-07-09  Alexey Proskuryakov  <ap@apple.com>
       
  1658 
       
  1659         Reviewed by Darin Adler.
       
  1660 
       
  1661         https://bugs.webkit.org/show_bug.cgi?id=13075
       
  1662         XMLHttpRequest with failed authentication should set status to 401
       
  1663 
       
  1664         https://bugs.webkit.org/show_bug.cgi?id=6871
       
  1665         <rdar://problem/3363403> 401 error page is never shown
       
  1666 
       
  1667         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
       
  1668         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
       
  1669         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
       
  1670         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
       
  1671         Do respond even if handlesAuthenticationChallenges() is false. Pretend that the user pressed
       
  1672         the Cancel button.
       
  1673 
       
  1674 2010-07-12  Andreas Kling  <andreas.kling@nokia.com>
       
  1675 
       
  1676         Reviewed by Tor Arne Vestbø.
       
  1677 
       
  1678         [Qt] Add location bar (Ctrl+L) shortcut in QtTestBrowser
       
  1679         https://bugs.webkit.org/show_bug.cgi?id=42082
       
  1680 
       
  1681         * QtTestBrowser/main.cpp:
       
  1682         (LauncherWindow::createChrome):
       
  1683         * QtTestBrowser/mainwindow.cpp:
       
  1684         (MainWindow::openLocation):
       
  1685         * QtTestBrowser/mainwindow.h:
       
  1686 
       
  1687 2010-07-12  Adam Roben  <aroben@apple.com>
       
  1688 
       
  1689         Make the Python autoinstaller not use a dead SourceForge server
       
  1690 
       
  1691         Fixes <http://webkit.org/b/42080> webkit-patch is broken due to
       
  1692         offline SourceForge server
       
  1693 
       
  1694         Reviewed by Anders Carlsson.
       
  1695 
       
  1696         * Scripts/webkitpy/thirdparty/__init__.py: Use
       
  1697         surfnet.dl.sourceforge.net instead of hivelocity.dl.sourceforge.net,
       
  1698         which seems to be down.
       
  1699 
       
  1700 2010-07-12  Adam Roben  <aroben@apple.com>
       
  1701 
       
  1702         Make run-webkit-tests print how many tests timed out when exiting
       
  1703         early
       
  1704 
       
  1705         The number of timed-out tests is taken into account when deciding
       
  1706         whether to exit early. Leaving it out of the output just makes the
       
  1707         script look buggy (because it might say something like "Exiting early
       
  1708         after 0 crashes.").
       
  1709 
       
  1710         Fixes <http://webkit.org/b/42077> run-webkit-tests prints confusing
       
  1711         messages when exiting early due to crashes and time-outs
       
  1712 
       
  1713         Reviewed by Anders Carlsson.
       
  1714 
       
  1715         * Scripts/old-run-webkit-tests:
       
  1716         (stopRunningTestsEarlyIfNeeded): When stopping, print the number of
       
  1717         timed-out tests, too.
       
  1718 
       
  1719 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
       
  1720 
       
  1721         Reviewed by Dan Bernstein.
       
  1722 
       
  1723         Implement animation-related methods for WebKitTestRunner
       
  1724         https://bugs.webkit.org/show_bug.cgi?id=42053
       
  1725         
       
  1726         Implemented numberOfActiveAnimatiosn and pauseAnimationAtTimeOnElementWithId. Many
       
  1727         animation tests were hanging otherwise.
       
  1728 
       
  1729         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
       
  1730         (WTR::LayoutTestController::numberOfActiveAnimations):
       
  1731         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
       
  1732         (WTR::numberOfActiveAnimationsCallback):
       
  1733         (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
       
  1734         (WTR::LayoutTestController::staticFunctions):
       
  1735         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
       
  1736 
       
  1737 2010-07-11  Daniel Bates  <dbates@rim.com>
       
  1738 
       
  1739         Reviewed by David Kilzer.
       
  1740 
       
  1741         Enable executable support for svn-apply and svn-unapply
       
  1742         https://bugs.webkit.org/show_bug.cgi?id=39409
       
  1743 
       
  1744         Connect up the Git and SVN executable bit support in parseDiff() so that
       
  1745         executable bit changes are propagated via the returned diff hash to the
       
  1746         patch function in svn-apply and svn-unapply.
       
  1747 
       
  1748         * Scripts/VCSUtils.pm:
       
  1749           - Modified parseDiff() to call parseSvnDiffProperties when
       
  1750             it finds the start of an SVN property change diff.
       
  1751           - Removed FIXME comment above parseSvnDiffProperties() since
       
  1752             it is now being used by parseDiff().
       
  1753           - Export method scmToggleExecutableBit() now that we added the
       
  1754             executableBitDelta hash key. (This should have been exported
       
  1755             when we added this function in Bug #38423 <https://bugs.webkit.org/show_bug.cgi?id=38423>).
       
  1756         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
       
  1757           - Updated results for:
       
  1758             "rename (with executable bit change)"
       
  1759               - Test value of executableBitDelta (now that we have support).
       
  1760             "SVN: binary file (isBinary true)"
       
  1761               - Remove the property change diff from svnConvertedText. We plan
       
  1762                 to remove svnConvertedText in the future. So, we decided
       
  1763                 against adding such support to any new code, such as the
       
  1764                 property parsing routines. Therefore, we do not keep SVN
       
  1765                 converted text for property change diffs.
       
  1766           - Added unit tests:
       
  1767             "SVN: file change diff with property change diff"
       
  1768             "SVN: file change diff, followed by property change diff on different file"
       
  1769             "SVN: property diff, followed by file change diff"
       
  1770             "SVN: copied file with property change"
       
  1771             "SVN: two consecutive property diffs"
       
  1772             "SVN: binary file with executable bit change"
       
  1773             "SVN: binary file followed by property change on different file"
       
  1774             "SVN: binary file followed by file change on different file"
       
  1775             "SVN: file change diff with property change, followed by property change diff"
       
  1776             "SVN: file change diff with property change, followed by file change diff"
       
  1777 
       
  1778 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
       
  1779 
       
  1780         Reviewed by Dan Bernstein.
       
  1781 
       
  1782         Implement waitUntilDone and notifyDone for WebKitTestRunner
       
  1783         https://bugs.webkit.org/show_bug.cgi?id=42049
       
  1784 
       
  1785         With this fix, most of the DOM tests pass.
       
  1786         
       
  1787         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
       
  1788         (WTR::InjectedBundle::didCreatePage): Track the main page. Not
       
  1789         a great way to do it in the future case where we may get multiple
       
  1790         pages - we really need a way to send it over from the ui process.
       
  1791         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
       
  1792         (WTR::InjectedBundle::page): A way to get the main page.
       
  1793         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
       
  1794         (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false.
       
  1795         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we
       
  1796         are loading.
       
  1797         (WTR::InjectedBundlePage::dump): Factor into a method so this can be
       
  1798         called by the layout test controller. Also, cancel any pending watchdogs.
       
  1799         (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading.
       
  1800         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
       
  1801         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
       
  1802         (WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
       
  1803         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
       
  1804         (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump
       
  1805         to false.
       
  1806         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate 
       
  1807         the watchdog.
       
  1808         (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer.
       
  1809         (WTR::LayoutTestController::setWaitToDump): Set the flag.
       
  1810         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case
       
  1811         where waitUntilDone times out.
       
  1812         (WTR::LayoutTestController::notifyDone): Dump, if loading is done.
       
  1813         (WTR::waitUntilDoneCallback): JS glue for waitUntilDone.
       
  1814         (WTR::notifyDoneCallback): JS glue for notifyDone.
       
  1815         (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone
       
  1816         to the layoutController.
       
  1817         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
       
  1818         (WTR::LayoutTestController::waitToDump): Inline method to get the wait state.
       
  1819 
       
  1820 2010-07-09  Brian Weinstein  <bweinstein@apple.com>
       
  1821 
       
  1822         Rubber-stamped by Dan Bernstein.
       
  1823 
       
  1824         Windows testers running Windows 7 were hanging during test_kill_process. Changing the
       
  1825         number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
       
  1826         slow down the tests).
       
  1827 
       
  1828         * Scripts/webkitpy/common/system/executive.py:
       
  1829 
       
  1830 2010-07-09  Luiz Agostini  <luiz.agostini@openbossa.org>
       
  1831 
       
  1832         Reviewed by Kenneth Rohde Christiansen.
       
  1833 
       
  1834         [Qt] Mac build fix
       
  1835         https://bugs.webkit.org/show_bug.cgi?id=41967
       
  1836 
       
  1837         Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.
       
  1838 
       
  1839         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
       
  1840 
       
  1841 2010-07-09  Diego Gonzalez  <diegohcg@webkit.org>
       
  1842 
       
  1843         Reviewed by Antonio Gomes.
       
  1844 
       
  1845         [Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
       
  1846         https://bugs.webkit.org/show_bug.cgi?id=41966
       
  1847 
       
  1848         * MiniBrowser/qt/BrowserWindow.cpp:
       
  1849         (BrowserWindow::BrowserWindow):
       
  1850 
       
  1851 2010-07-09  Leon Clarke  <leonclarke@google.com>
       
  1852 
       
  1853         Reviewed by Adam Barth.
       
  1854 
       
  1855         add support for link prefetching
       
  1856         https://bugs.webkit.org/show_bug.cgi?id=3652
       
  1857 
       
  1858         * Scripts/build-webkit:
       
  1859 
       
  1860 2010-07-09  Ojan Vafai  <ojan@chromium.org>
       
  1861 
       
  1862         Reviewed by Adam Barth.
       
  1863 
       
  1864         r63004 broke some python tests
       
  1865         https://bugs.webkit.org/show_bug.cgi?id=42007
       
  1866 
       
  1867         AbstractStep now checks options.no_squash and options.squash, so
       
  1868         they needed to have real values. Mock would return an object for those,
       
  1869         which would then act as if the values were True.
       
  1870 
       
  1871         * Scripts/webkitpy/tool/commands/commandtest.py:
       
  1872         * Scripts/webkitpy/tool/commands/download_unittest.py:
       
  1873         * Scripts/webkitpy/tool/commands/stepsequence.py:
       
  1874         * Scripts/webkitpy/tool/commands/upload_unittest.py:
       
  1875         * Scripts/webkitpy/tool/mocktool.py:
       
  1876         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
       
  1877         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
       
  1878         * Scripts/webkitpy/tool/steps/steps_unittest.py:
       
  1879         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
       
  1880         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
       
  1881 
       
  1882 2010-07-09  Ojan Vafai  <ojan@chromium.org>
       
  1883 
       
  1884         Reviewed by Adam Barth.
       
  1885 
       
  1886         --squash should go away and become the default
       
  1887         https://bugs.webkit.org/show_bug.cgi?id=39624
       
  1888 
       
  1889         If there are local commits and working copy changes, then prompt the user
       
  1890         whether to continue. Setting git config webkit-patch.commit_should_always_squash
       
  1891         true bypasses the prompt.
       
  1892 
       
  1893         --git-commit=HEAD.. operates on working copy changes only.
       
  1894         --git-commit=committish operates on a range of commits as a single commit.
       
  1895             e.g. --git-commit=HEAD only operates on the HEAD commit.
       
  1896             --git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit.
       
  1897 
       
  1898         --no-squash and --squash are left in with descriptive error messages if used.
       
  1899 
       
  1900         * Scripts/check-webkit-style:
       
  1901         * Scripts/webkitpy/common/checkout/api.py:
       
  1902         * Scripts/webkitpy/common/checkout/api_unittest.py:
       
  1903         * Scripts/webkitpy/common/checkout/scm.py:
       
  1904         * Scripts/webkitpy/common/checkout/scm_unittest.py:
       
  1905         * Scripts/webkitpy/common/net/rietveld.py:
       
  1906         * Scripts/webkitpy/common/system/user.py:
       
  1907         * Scripts/webkitpy/style/optparser.py:
       
  1908         * Scripts/webkitpy/style_references.py:
       
  1909         * Scripts/webkitpy/tool/commands/download.py:
       
  1910         * Scripts/webkitpy/tool/commands/upload.py:
       
  1911         * Scripts/webkitpy/tool/mocktool.py:
       
  1912         * Scripts/webkitpy/tool/steps/abstractstep.py:
       
  1913         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
       
  1914         * Scripts/webkitpy/tool/steps/checkstyle.py:
       
  1915         * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed.
       
  1916         * Scripts/webkitpy/tool/steps/commit.py:
       
  1917         * Scripts/webkitpy/tool/steps/options.py:
       
  1918         * Scripts/webkitpy/tool/steps/preparechangelog.py:
       
  1919         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
       
  1920         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
       
  1921         * Scripts/webkitpy/tool/steps/validatereviewer.py:
       
  1922 
       
  1923 2010-07-09  Mark Rowe  <mrowe@apple.com>
       
  1924 
       
  1925         Add two new Windows test build slaves.
       
  1926 
       
  1927         * BuildSlaveSupport/build.webkit.org-config/config.json:
       
  1928 
       
  1929 2010-07-09  Albert J. Wong  <ajwong@chromium.org>
       
  1930 
       
  1931         Reviewed by David Levin.
       
  1932 
       
  1933         rebaseline_chromium_webkit_tests missing --use_drt option on linux
       
  1934         https://bugs.webkit.org/show_bug.cgi?id=41985
       
  1935 
       
  1936         This adds in the --use_drt option for rebaseline_chromium_webkit_tests
       
  1937         so that it works on linux. This is essentially a "compile-fix" for the
       
  1938         script.
       
  1939 
       
  1940         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
       
  1941 
       
  1942 2010-07-09  Nico Weber  <thakis@chromium.org>
       
  1943 
       
  1944         Unreviewed. Adding myself as committer.
       
  1945 
       
  1946         * Scripts/webkitpy/common/config/committers.py:
       
  1947 
       
  1948 2010-07-09  David Kilzer  <ddkilzer@apple.com>
       
  1949 
       
  1950         Revert "<http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git"
       
  1951 
       
  1952         This reverts commit r62692.
       
  1953 
       
  1954         * Scripts/commit-log-editor:
       
  1955 
       
  1956 2010-07-08  Kinuko Yasuda  <kinuko@chromium.org>
       
  1957 
       
  1958         Reviewed by Ojan Vafai.
       
  1959 
       
  1960         cleanup json_results_generator dependencies so that non-layout-tests can also use it safely
       
  1961         https://bugs.webkit.org/show_bug.cgi?id=38693
       
  1962 
       
  1963         Introduced a new base class JSONResultsGeneratorBase that doesn't
       
  1964         have any dependency on layout_tests packages.
       
  1965         Turned JSONResultsGenerator into a wrapper class of the base class
       
  1966         so that the old code can work with it during the cleanup.
       
  1967 
       
  1968         Added json_results_generator_unittest.py.
       
  1969 
       
  1970         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
       
  1971         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
       
  1972         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added
       
  1973 
       
  1974 2010-07-09  Abhishek Arya  <inferno@chromium.org>
       
  1975 
       
  1976         Unreviewed.
       
  1977 
       
  1978         Marking myself as a committer.
       
  1979 
       
  1980         * Scripts/webkitpy/common/config/committers.py:
       
  1981 
       
  1982 2010-07-09  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
       
  1983 
       
  1984         Reviewed by Antti Koivisto.
       
  1985 
       
  1986         Implement MiniBrowser for Qt.
       
  1987         https://bugs.webkit.org/show_bug.cgi?id=40233
       
  1988 
       
  1989         * MiniBrowser/qt/BrowserWindow.cpp: Added.
       
  1990         (createNewPage):
       
  1991         (BrowserView::BrowserView):
       
  1992         (BrowserView::resizeEvent):
       
  1993         (BrowserView::load):
       
  1994         (BrowserView::view):
       
  1995         (BrowserWindow::BrowserWindow):
       
  1996         (BrowserWindow::load):
       
  1997         (BrowserWindow::changeLocation):
       
  1998         (BrowserWindow::~BrowserWindow):
       
  1999         * MiniBrowser/qt/BrowserWindow.h: Added.
       
  2000         (BrowserView::~BrowserView):
       
  2001         * MiniBrowser/qt/MiniBrowser.pro: Added.
       
  2002         * MiniBrowser/qt/main.cpp: Added.
       
  2003         (main):
       
  2004 
       
  2005 2010-07-09  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
       
  2006 
       
  2007         Reviewed by Simon Hausmann.
       
  2008 
       
  2009         Introduce the Qt autotest launcher.
       
  2010 
       
  2011         Qt autotests should be executed more frequently, ideally by the Qt
       
  2012         build bot. This is the first step to provide the tests more accessible.
       
  2013 
       
  2014         [Qt] It should be easier to run all Qt's autotests.
       
  2015         https://bugs.webkit.org/show_bug.cgi?id=31625
       
  2016 
       
  2017         * Scripts/run-qtwebkit-tests: Added.
       
  2018 
       
  2019 2010-07-09  Adam Barth  <abarth@webkit.org>
       
  2020 
       
  2021         Reviewed by Eric Seidel.
       
  2022 
       
  2023         commit-queue should merge to TOT when checkout needs update
       
  2024         https://bugs.webkit.org/show_bug.cgi?id=41944
       
  2025 
       
  2026         There are a bunch of different designs that are possible here.  This
       
  2027         one merges to top of tree by cleaning out the working copy and
       
  2028         re-applying the patch.  Once you decide to merge that way, you need to
       
  2029         decide who's going to retry.  In this patch, we retry in the child
       
  2030         process instead of plumbing the failure reason to the master process.
       
  2031 
       
  2032         This patch is difficult to test end-to-end, but hopefully it will work.
       
  2033         :)
       
  2034 
       
  2035         * Scripts/webkitpy/tool/commands/queues.py:
       
  2036         * Scripts/webkitpy/tool/commands/stepsequence.py:
       
  2037         * Scripts/webkitpy/tool/multicommandtool.py:
       
  2038         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
       
  2039 
       
  2040 2010-07-09  Dumitru Daniliuc  <dumi@chromium.org>
       
  2041 
       
  2042         Reviewed by Darin Adler.
       
  2043 
       
  2044         Add a script to check for unnecessary includes in header files.
       
  2045         https://bugs.webkit.org/show_bug.cgi?id=41894
       
  2046 
       
  2047         * Scripts/check-header-includes: Added.
       
  2048 
       
  2049 2010-07-09  Adam Barth  <abarth@webkit.org>
       
  2050 
       
  2051         Reviewed by Eric Seidel.
       
  2052 
       
  2053         Add --html5-treebuilder option to run-webkit-tests
       
  2054         https://bugs.webkit.org/show_bug.cgi?id=41922
       
  2055 
       
  2056         We're down to one or two regressions in the HTML5lib test suite.  It's
       
  2057         getting to be time to look at fixing LayoutTests.
       
  2058 
       
  2059         * Scripts/old-run-webkit-tests:
       
  2060 
       
  2061 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
       
  2062 
       
  2063         Fix Tiger plugin test failures; the #ifdefs were incorrect, resulting
       
  2064         in the drawing model never getting set on Tiger.
       
  2065 
       
  2066         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
       
  2067         (NPP_New):
       
  2068 
       
  2069 2010-07-08  Aaron Boodman  <aa@chromium.org>
       
  2070 
       
  2071         Reviewed by Timothy Hatcher.
       
  2072 
       
  2073         Add the ability for user scripts and user styles to affect just the top frame.
       
  2074 
       
  2075         https://bugs.webkit.org/show_bug.cgi?id=41529
       
  2076 
       
  2077         * DumpRenderTree/LayoutTestController.h: Added new allFrames param.
       
  2078         * DumpRenderTree/LayoutTestController.cpp: Ditto.
       
  2079         (addUserScriptCallback):
       
  2080         (addUserStyleSheetCallback):
       
  2081         * DumpRenderTree/chromium/LayoutTestController.cpp: Ditto.
       
  2082         (LayoutTestController::addUserScript):
       
  2083         (LayoutTestController::addUserStyleSheet):
       
  2084         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
       
  2085         (LayoutTestController::addUserScript):
       
  2086         (LayoutTestController::addUserStyleSheet):
       
  2087         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
       
  2088         (LayoutTestController::addUserScript):
       
  2089         (LayoutTestController::addUserStyleSheet):
       
  2090         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Ditto.
       
  2091         (LayoutTestController::addUserScript):
       
  2092         (LayoutTestController::addUserStyleSheet):
       
  2093         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Ditto.
       
  2094         (LayoutTestController::addUserScript):
       
  2095         (LayoutTestController::addUserStyleSheet):
       
  2096 
       
  2097 2010-07-08  Adele Peterson  <adele@apple.com>
       
  2098 
       
  2099         Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
       
  2100 
       
  2101         Test infrastructure for https://bugs.webkit.org/show_bug.cgi?id=41721
       
  2102         <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
       
  2103 
       
  2104         Log when the missing plugin button is pressed.
       
  2105 
       
  2106         * DumpRenderTree/mac/UIDelegate.mm:
       
  2107         (-[UIDelegate webView:didPressMissingPluginButton:]):
       
  2108         * DumpRenderTree/win/UIDelegate.cpp:
       
  2109         (UIDelegate::QueryInterface):
       
  2110         (UIDelegate::createWebViewWithRequest):
       
  2111         (UIDelegate::drawBackground):
       
  2112         (UIDelegate::decidePolicyForGeolocationRequest):
       
  2113         (UIDelegate::didPressMissingPluginButton):
       
  2114         * DumpRenderTree/win/UIDelegate.h:
       
  2115 
       
  2116 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
       
  2117 
       
  2118         Fix the Tiger build.
       
  2119 
       
  2120         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
       
  2121         (NPP_New):
       
  2122 
       
  2123 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
       
  2124 
       
  2125         Fix windows build.
       
  2126 
       
  2127         #ifdef code for Mac.
       
  2128 
       
  2129         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
       
  2130         (NPP_New):
       
  2131 
       
  2132 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
       
  2133 
       
  2134         Reviewed by Anders Carlsson.
       
  2135 
       
  2136         Allow the TestPlugin to use Core Animation rendering for testing
       
  2137         https://bugs.webkit.org/show_bug.cgi?id=41872
       
  2138         
       
  2139         Add the ability for the TestPlugin to use the CoreAnimation rendering model
       
  2140         when available, based on the "drawingmodel" attribute of the embed tag:
       
  2141             drawingmodel="coreanimation"
       
  2142 
       
  2143         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add PluginObjectMac.mm
       
  2144         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Add some macros so we can detect
       
  2145         when building on Tiger. Add a void* coreAnimationLayer member.
       
  2146         
       
  2147         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm: Added.
       
  2148         (createCoreAnimationLayer): Obj-C method to create the CALayer.
       
  2149         
       
  2150         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
       
  2151         (NPP_New): Look for the drawingmodel attribute to decide which drawing
       
  2152         model to use.
       
  2153         (NPP_Destroy): Release the CALayer if we have one.
       
  2154         (NPP_GetValue): Return the retained CALayer.
       
  2155 
       
  2156 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
       
  2157 
       
  2158         Reviewed by Xan Lopez.
       
  2159 
       
  2160         [GTK] Support pixel tests
       
  2161         https://bugs.webkit.org/show_bug.cgi?id=31518
       
  2162 
       
  2163         Convert this file from CRLF to NL line endings. It will soon
       
  2164         be used on more than just the WinCairo platform.
       
  2165 
       
  2166         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
       
  2167         (writeFunction):
       
  2168         (printPNG):
       
  2169         (computeMD5HashStringForBitmapContext):
       
  2170         (dumpBitmap):
       
  2171 
       
  2172 2010-07-08  Steve Falkenburg  <sfalken@apple.com>
       
  2173 
       
  2174         Reviewed by Darin Adler.
       
  2175 
       
  2176         Enable Data Execution Prevention for our test harnesses on Windows
       
  2177         https://bugs.webkit.org/show_bug.cgi?id=41882
       
  2178 
       
  2179         * DumpRenderTree/win/DumpRenderTree.vcproj:
       
  2180         * DumpRenderTree/win/ImageDiff.vcproj:
       
  2181         * WebKitAPITest/WebKitAPITest.vcproj:
       
  2182         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
       
  2183 
       
  2184 2010-07-07  Robert Hogan  <robert@webkit.org>
       
  2185 
       
  2186         Reviewed by Kenneth Rohde Christiansen.
       
  2187 
       
  2188         [Qt] Add DRT support for pageProperty etc.
       
  2189 
       
  2190         https://bugs.webkit.org/show_bug.cgi?id=41584
       
  2191 
       
  2192         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
       
  2193         (LayoutTestController::isPageBoxVisible):
       
  2194         (LayoutTestController::pageSizeAndMarginsInPixels):
       
  2195         (LayoutTestController::pageProperty):
       
  2196         (LayoutTestController::addUserStyleSheet):
       
  2197         * DumpRenderTree/qt/LayoutTestControllerQt.h:
       
  2198 
       
  2199 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
       
  2200 
       
  2201         Reviewed by Xan Lopez.
       
  2202 
       
  2203         Remove a warnings from the ImageDiff build by using the proper
       
  2204         printf format string for the gsize data type.
       
  2205 
       
  2206         * DumpRenderTree/gtk/ImageDiff.cpp:
       
  2207         (printImage): Use the proper printf format string for the gsize data type.
       
  2208 
       
  2209 2010-07-08  Alice Liu  <alice.liu@apple.com>
       
  2210 
       
  2211         Reviewed by Sam Weinig.
       
  2212 
       
  2213         https://bugs.webkit.org/show_bug.cgi?id=41653
       
  2214         Add new WebKitTestRunner project for Windows
       
  2215 
       
  2216         * WebKitTestRunner/WebKitTestRunnerPrefix.h: 
       
  2217         Similar to how it's done in DumpRenderTree, define max and min early
       
  2218         on so that they don't get replaced by a macro requiring 2 arguments.
       
  2219 
       
  2220         * WebKitTestRunner/win: Added.
       
  2221         * WebKitTestRunner/win/WebKitTestRunner.sln: Added.
       
  2222         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added.
       
  2223         * WebKitTestRunner/win/main.cpp: Added.
       
  2224         (main): Implemented
       
  2225 
       
  2226         Added these files with stubbed out functions:
       
  2227         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
       
  2228         (WTR::PlatformWebView::PlatformWebView):
       
  2229         (WTR::PlatformWebView::~PlatformWebView):
       
  2230         (WTR::PlatformWebView::page):
       
  2231         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
       
  2232         (WTR::TestController::initializeInjectedBundlePath):
       
  2233         * WebKitTestRunner/win/TestInvocationWin.cpp: Added.
       
  2234         (WTR::TestInvocation::runUntil):
       
  2235 
       
  2236 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
       
  2237 
       
  2238         Reviewed by Gustavo Noronha Silva.
       
  2239 
       
  2240         [GTK] Implement ImageDiff and add it to the build system
       
  2241         https://bugs.webkit.org/show_bug.cgi?id=41779
       
  2242 
       
  2243         Add the initial implementation of the ImageDiff tool for the GTK+
       
  2244         port. This is an essential tool for doing pixel tests. The implementation
       
  2245         is based on the Mac and Chromium ports.
       
  2246 
       
  2247         * DumpRenderTree/gtk/ImageDiff.cpp: Added.
       
  2248         (readPixbufFromStdin): Added.
       
  2249         (differenceImageFromDifferenceBuffer): Ditto.
       
  2250         (calculateDifference): Ditto.
       
  2251         (printImage): Ditto.
       
  2252         (printImageDifferences): Ditto.
       
  2253         (main): Ditto.
       
  2254         * GNUmakefile.am: Add ImageDiff to the WebKitTools build scripts.
       
  2255 
       
  2256 2010-07-08  Jay Civelli  <jcivelli@chromium.org>
       
  2257 
       
  2258         Unreviewed. Adding myself as a committer.
       
  2259 
       
  2260         * Scripts/webkitpy/common/config/committers.py:
       
  2261 
       
  2262 2010-07-08  Adam Roben  <aroben@apple.com>
       
  2263 
       
  2264         Make Windows stop running tests from platform/mac
       
  2265 
       
  2266         r62742 made a change (at my suggestion!) that caused us to start
       
  2267         looking for tests in platform/mac, rather than just looking for
       
  2268         expected results in platform/mac. This patch just undoes that part of
       
  2269         r62742.
       
  2270 
       
  2271         Fixes <http://webkit.org/b/41855> REGRESSION (r62742): Windows runs
       
  2272         tests from platform/mac, but shouldn't
       
  2273 
       
  2274         Reviewed by Antti Koivisto and Anders Carlsson.
       
  2275 
       
  2276         * Scripts/old-run-webkit-tests:
       
  2277         (top level): Removed "mac-snowleopard" and "mac" from @winPlatforms,
       
  2278         so we won't look in those directories for tests to run.
       
  2279         (expectedDirectoryForTest): Added back code from pre-r62742 to look in
       
  2280         platform/mac-snowleopard and platform/mac for expected results.
       
  2281 
       
  2282 2010-07-08  Antonio Gomes  <tonikitoo@webkit.org>
       
  2283 
       
  2284         Unreviewed. Adding myself as a reviewer.
       
  2285 
       
  2286         * Scripts/webkitpy/common/config/committers.py:
       
  2287 
       
  2288 2010-07-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
       
  2289 
       
  2290         Update my e-mail in committers.py
       
  2291 
       
  2292         * Scripts/webkitpy/common/config/committers.py:
       
  2293 
       
  2294 2010-07-07  Daniel Bates  <dbates@rim.com>
       
  2295 
       
  2296         Reviewed by Dumitru Daniliuc.
       
  2297 
       
  2298         VCSUtils.pm complains about uninitialized value $newLine
       
  2299         https://bugs.webkit.org/show_bug.cgi?id=41333
       
  2300 
       
  2301         Fixes an issue where VCSUtils::fixChangeLogPatch() may read off the end of
       
  2302         an array when fixing a change log entry that overlaps with an earlier
       
  2303         entry. In particular, when a patch contains a change log entry inserted
       
  2304         earlier in the change log file, but after an entry with the same author
       
  2305         and date.
       
  2306 
       
  2307         * Scripts/VCSUtils.pm:
       
  2308             - Added for-loop constraint to fixChangeLogPatch() so that it does not
       
  2309               read off the end of the @overlappingLines array.
       
  2310         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added unit test.
       
  2311 
       
  2312 2010-07-07  Anders Carlsson  <andersca@apple.com>
       
  2313 
       
  2314         Comment out a part of TestNetscapePlugin that caused tests to fail on Tiger and Leopard.
       
  2315 
       
  2316         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
       
  2317         (NPP_New):
       
  2318 
       
  2319 2010-07-07  Kent Tamura  <tkent@chromium.org>
       
  2320 
       
  2321         Reviewed by Adam Barth.
       
  2322 
       
  2323         [DRT/Chromium] Support for indeterminate checkbox
       
  2324         https://bugs.webkit.org/show_bug.cgi?id=41747
       
  2325 
       
  2326         Import http://src.chromium.org/viewvc/chrome?view=rev&revision=51499
       
  2327 
       
  2328         * DumpRenderTree/chromium/WebThemeControlDRT.cpp:
       
  2329         (WebThemeControlDRT::draw):
       
  2330         * DumpRenderTree/chromium/WebThemeControlDRT.h:
       
  2331         (WebThemeControlDRT::):
       
  2332         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
       
  2333         (WebThemeEngineDRT::paintButton):
       
  2334 
       
  2335 2010-07-07  Sam Weinig  <sam@webkit.org>
       
  2336 
       
  2337         Reviewed by Mark Rowe.
       
  2338 
       
  2339         Clean up MiniBrowser Xcode project.
       
  2340 
       
  2341         - Use xcconfig files.
       
  2342         - Rename plists to canonical Info.plist
       
  2343         - Remove localizations.
       
  2344 
       
  2345         * MiniBrowser/Configurations: Added.
       
  2346         * MiniBrowser/Configurations/Base.xcconfig: Added.
       
  2347         * MiniBrowser/Configurations/DebugRelease.xcconfig: Added.
       
  2348         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Added.
       
  2349         * MiniBrowser/Configurations/WebBundle.xcconfig: Added.
       
  2350         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
       
  2351         * MiniBrowser/WebBundle-Info.plist: Removed.
       
  2352         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
       
  2353         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
       
  2354         * MiniBrowser/mac/BrowserWindow.xib: Added.
       
  2355         * MiniBrowser/mac/BrowserWindowController.m:
       
  2356         (-[BrowserWindowController initWithPageNamespace:]):
       
  2357         * MiniBrowser/mac/English.lproj: Removed.
       
  2358         * MiniBrowser/mac/English.lproj/BrowserWindow.xib: Removed.
       
  2359         * MiniBrowser/mac/English.lproj/InfoPlist.strings: Removed.
       
  2360         * MiniBrowser/mac/English.lproj/MainMenu.xib: Removed.
       
  2361         * MiniBrowser/mac/Info.plist: Copied from MiniBrowser/mac/MiniBrowser-Info.plist.
       
  2362         * MiniBrowser/mac/MainMenu.xib: Added.
       
  2363         * MiniBrowser/mac/MiniBrowser-Info.plist: Removed.
       
  2364         * MiniBrowser/mac/WebBundle/Info.plist: Copied from MiniBrowser/WebBundle-Info.plist.
       
  2365 
       
  2366 2010-07-07  Kent Tamura  <tkent@chromium.org>
       
  2367 
       
  2368         Reviewed by Dimitri Glazkov.
       
  2369 
       
  2370         [DRT/Chromium] Fix two regressions
       
  2371         https://bugs.webkit.org/show_bug.cgi?id=41745
       
  2372 
       
  2373         * DumpRenderTree/chromium/WebViewHost.cpp:
       
  2374         (WebViewHost::paintInvalidatedRegion):
       
  2375          Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg
       
  2376          and svg/custom/use-on-g-containing-foreignObject-and-image.svg
       
  2377          though test_shell does it twice. Probably DRT needs it because
       
  2378          DRT delays painting as possible.
       
  2379 
       
  2380 2010-07-07  Anders Carlsson  <andersca@apple.com>
       
  2381 
       
  2382         Try to fix build.
       
  2383 
       
  2384         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
       
  2385         (webkit_test_plugin_destroy_stream):
       
  2386 
       
  2387 2010-07-07  Anders Carlsson  <andersca@apple.com>
       
  2388 
       
  2389         Try to fix the GTK+ and Qt test failures by merging the newly added code from TestNetscapePlugin/main.cpp
       
  2390 
       
  2391         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
       
  2392         (webkit_test_plugin_new_stream):
       
  2393         (webkit_test_plugin_destroy_stream):
       
  2394         (webkit_test_plugin_write_ready):
       
  2395         (webkit_test_plugin_write):
       
  2396 
       
  2397 2010-07-07  Sam Weinig  <sam@webkit.org>
       
  2398 
       
  2399         Reviewed by Mark Rowe.
       
  2400 
       
  2401         Don't hard code the Mac OS X 10.6 SDK for MiniBrowser. 
       
  2402 
       
  2403         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
       
  2404 
       
  2405 2010-07-07  Anders Carlsson  <andersca@apple.com>
       
  2406 
       
  2407         Use the correct XP_MACOSX define instead of XP_MAC. This was causing test failures on some platforms.
       
  2408 
       
  2409         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
       
  2410         (NPP_New):
       
  2411         (NPP_HandleEvent):
       
  2412 
       
  2413 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
       
  2414 
       
  2415         Reviewed by Adam Roben.
       
  2416 
       
  2417         Need to have a way to specify different results for Windows XP and 7
       
  2418         https://bugs.webkit.org/show_bug.cgi?id=41776
       
  2419         
       
  2420         Add the ability to have platform/win-xp, platform/win-vista, and platform/win-7
       
  2421         subdirectories, so we can have different results for tests on Windows XP, Windows
       
  2422         Vista, and Windows 7.
       
  2423 
       
  2424         Windows XP will try the order: win-xp, win-vista, win-7, win, mac-snowleopard, mac.
       
  2425         Windows Vista will try the order: win-vista, win-7, win, mac-snowleopard, mac.
       
  2426         Windows 7 will try the order: win-7, win, mac-snowleopard, mac.
       
  2427 
       
  2428         This matches the behavior of the mac.
       
  2429 
       
  2430         * Scripts/old-run-webkit-tests: Add multiple platforms for Windows, and if we are on XP
       
  2431             or Vista, try looking in other win-* subdirectories before win.
       
  2432         * Scripts/webkitdirs.pm: Add some helper functions to determine what version of Windows
       
  2433             we are running.
       
  2434 
       
  2435 2010-07-07  Kent Tamura  <tkent@chromium.org>
       
  2436 
       
  2437         Reviewed by Dimitri Glazkov.
       
  2438 
       
  2439         [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
       
  2440         https://bugs.webkit.org/show_bug.cgi?id=41753
       
  2441 
       
  2442         The original code of the following functions in
       
  2443         test_shell_devtools_client.cc have NOTIMPLEMENTED(), not
       
  2444         ASSERT_NOT_REACHED(). The program shouldn't stop at these
       
  2445         functions.
       
  2446 
       
  2447         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
       
  2448         (DRTDevToolsClient::activateWindow):
       
  2449         (DRTDevToolsClient::closeWindow):
       
  2450         (DRTDevToolsClient::dockWindow):
       
  2451         (DRTDevToolsClient::undockWindow):
       
  2452 
       
  2453 2010-07-07  Anders Carlsson  <andersca@apple.com>
       
  2454 
       
  2455         Reviewed by Sam Weinig.
       
  2456 
       
  2457         Test that we call NPP_DestroyStream if a plug-in returns -1 from its NPP_Write function
       
  2458         https://bugs.webkit.org/show_bug.cgi?id=41821
       
  2459 
       
  2460         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
       
  2461         (pluginGetProperty):
       
  2462         (pluginSetProperty):
       
  2463         (pluginAllocate):
       
  2464         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
       
  2465         Add and initialize the returnNegativeOneFromWrite property.
       
  2466 
       
  2467         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
       
  2468         (NPP_NewStream):
       
  2469         Set the stream type to NP_NORMAL so we'll get write callbacks.
       
  2470 
       
  2471         (NPP_DestroyStream):
       
  2472         Treat the onstreamdestroy attribute as a function name and not a string.
       
  2473 
       
  2474         (NPP_WriteReady):
       
  2475         Have this return a nonzero value.
       
  2476 
       
  2477         (NPP_Write):
       
  2478         If returnNegativeOneFromWrite is true return -1.
       
  2479 
       
  2480 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
       
  2481 
       
  2482         [wx] Build fix for machines with both MSVC 2005 and 2008 installed. Ensures the
       
  2483         latest version is selected by default, and allows the version to be specified.
       
  2484 
       
  2485         * wx/build/settings.py:
       
  2486 
       
  2487 2010-07-07  Chris Fleizach  <cfleizach@apple.com>
       
  2488 
       
  2489         Reviewed by Darin Adler.
       
  2490 
       
  2491         AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area
       
  2492         https://bugs.webkit.org/show_bug.cgi?id=41810
       
  2493 
       
  2494         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
       
  2495         (AccessibilityUIElement::selectedTextRange):
       
  2496 
       
  2497 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
       
  2498 
       
  2499         Unreviewed.
       
  2500 
       
  2501         Build fix after r62700.
       
  2502 
       
  2503         * GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn
       
  2504         source file locations.
       
  2505 
       
  2506 2010-07-07  Ojan Vafai  <ojan@chromium.org>
       
  2507 
       
  2508         Reviewed by David Levin.
       
  2509 
       
  2510         change --exit-after-n-crashes to --exit-after-n-crashes-or-timeouts
       
  2511         https://bugs.webkit.org/show_bug.cgi?id=41814
       
  2512 
       
  2513         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
       
  2514         * Scripts/old-run-webkit-tests:
       
  2515 
       
  2516 2010-07-07  Ojan Vafai  <ojan@chromium.org>
       
  2517 
       
  2518         Reviewed by David Levin.
       
  2519 
       
  2520         add --exit-after-n-crashes to run-webkit-tests
       
  2521         https://bugs.webkit.org/show_bug.cgi?id=41811
       
  2522 
       
  2523         Change the bots at build.webkit.org to use --exit-after-n-crashes
       
  2524         instead of --exit-after-n-failures since we want to be able to have
       
  2525         more than 20 failures on those bots, but more than 20 crashes means
       
  2526         something should be rolled out.
       
  2527 
       
  2528         * Scripts/old-run-webkit-tests:
       
  2529         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
       
  2530 
       
  2531 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
       
  2532 
       
  2533         Fix the Windows build by removing win/TestNetscapePlugin/main.cpp from the
       
  2534         TestNetscapePlugin project, because this was removed from the tree.
       
  2535 
       
  2536         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
       
  2537 
       
  2538 2010-07-07  Anders Carlsson  <andersca@apple.com>
       
  2539 
       
  2540         Reviewed by Simon Fraser.
       
  2541 
       
  2542         Unify Mac and Windows TestNetscapePlugin main.cpp files
       
  2543         https://bugs.webkit.org/show_bug.cgi?id=41798
       
  2544         
       
  2545         * DumpRenderTree/DumpRenderTree.sln:
       
  2546         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
       
  2547         (strcasecmp):
       
  2548         (NP_Initialize):
       
  2549         (NP_GetEntryPoints):
       
  2550         (NP_Shutdown):
       
  2551         (NPP_New):
       
  2552         (NPP_Destroy):
       
  2553         (NPP_HandleEvent):
       
  2554         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
       
  2555         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Removed.
       
  2556 
       
  2557 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
       
  2558 
       
  2559         [wx] Build fix. pageProperty needs to return a value.
       
  2560 
       
  2561         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
       
  2562         (LayoutTestController::pageProperty):
       
  2563 
       
  2564 2010-07-07  David Kilzer  <ddkilzer@apple.com>
       
  2565 
       
  2566         <http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git
       
  2567 
       
  2568         Reviewed by Anders Carlsson.
       
  2569 
       
  2570         For both svn and git, commit-log-editor is invoked from the root
       
  2571         of the working directory.  Unlike svn, git returns a list of
       
  2572         changed files that are relative to the directory where the
       
  2573         command was invoked.  This caused the ChangeLog file in the root
       
  2574         directory to be read instead of the ChangeLog in the current
       
  2575         directory.
       
  2576 
       
  2577         The fix is to use $ENV{PWD} as the base directory when fixing
       
  2578         the path to the ChangeLog files.  With svn, this has no net
       
  2579         effect since $ENV{PWD} is the root of the working directory and
       
  2580         the ChangeLog paths are already relative to that directory.
       
  2581         With git, $ENV{PWD} is the directory that the commit was invoked
       
  2582         from, which fixes the ChangeLog paths so that the correct files
       
  2583         are read when creating the commit log entry.
       
  2584 
       
  2585         Note that the call to makeFilePathRelative() was supposed to
       
  2586         address this issue, but it doesn't because (a) it does nothing
       
  2587         with svn working directories by design, and (b) it does nothing
       
  2588         with git working directories because it's invoked when the
       
  2589         current directory is the root of the working directory, thus
       
  2590         giving no relative path.
       
  2591 
       
  2592         * Scripts/commit-log-editor: Removed call to
       
  2593         makeFilePathRelative() since since it does nothing.  Moved code
       
  2594         to fix up $changeLog path so that it's fixed before trying to
       
  2595         open the file, and use $ENV{PWD} as the base path.  Also use
       
  2596         canonicalizePath() to clean up paths with "../" in them.
       
  2597 
       
  2598 2010-07-07  Anders Carlsson  <andersca@apple.com>
       
  2599 
       
  2600         Another attempt at fixing the Qt build.
       
  2601 
       
  2602         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
       
  2603 
       
  2604 2010-07-07  Anders Carlsson  <andersca@apple.com>
       
  2605 
       
  2606         Try to fix Qt build.
       
  2607 
       
  2608         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
       
  2609 
       
  2610 2010-07-07  Anders Carlsson  <andersca@apple.com>
       
  2611 
       
  2612         Reviewed by Simon Fraser.
       
  2613 
       
  2614         Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
       
  2615         https://bugs.webkit.org/show_bug.cgi?id=41781
       
  2616 
       
  2617         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
       
  2618         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp.
       
  2619         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h.
       
  2620         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp.
       
  2621         * DumpRenderTree/TestNetscapePlugIn/TestObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h.
       
  2622         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist.
       
  2623         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp.
       
  2624         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def.
       
  2625         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc.
       
  2626         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added.
       
  2627         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def.
       
  2628         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/resource.h.
       
  2629         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
       
  2630 
       
  2631 2010-07-07  Andras Becsi  <abecsi@webkit.org>
       
  2632 
       
  2633         Unreviewed trivial fix.
       
  2634 
       
  2635         Remove DUMPRENDERTREE_TEMP environment variable from NRWT
       
  2636         which was checked in accidentally in r62635.
       
  2637 
       
  2638         * Scripts/webkitpy/layout_tests/port/webkit.py:
       
  2639 
       
  2640 2010-07-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
       
  2641 
       
  2642         Reviewed by Eric Seidel.
       
  2643 
       
  2644         Pass port specific environment to server process.
       
  2645         https://bugs.webkit.org/show_bug.cgi?id=41593
       
  2646 
       
  2647         * Scripts/webkitpy/layout_tests/port/qt.py:
       
  2648         * Scripts/webkitpy/layout_tests/port/webkit.py:
       
  2649 
       
  2650 2010-07-06  Kent Tamura  <tkent@chromium.org>
       
  2651 
       
  2652         Reviewed by Shinichiro Hamaji.
       
  2653 
       
  2654         Fix a wrong dup detection of rebaseline-chromium-webkit-tests
       
  2655         https://bugs.webkit.org/show_bug.cgi?id=41644
       
  2656 
       
  2657         rebaseline-chromium-webkit-tests used ImageDiff with 0.1%
       
  2658         tolerance. We don't need tolerance for rebaseline.
       
  2659 
       
  2660         * Scripts/webkitpy/layout_tests/port/base.py:
       
  2661           Add optional tolerance parameter to diff_image().
       
  2662         * Scripts/webkitpy/layout_tests/port/test.py:
       
  2663           Add optional tolerance parameter to diff_image().
       
  2664         * Scripts/webkitpy/layout_tests/port/webkit.py:
       
  2665           Add optional tolerance parameter to diff_image(), and pass it to ImageDiff command.
       
  2666         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
       
  2667           diff_files() always calls diff_image() with tolerance=0.
       
  2668           diff_files() is used only by rebaseline-chromium-webkit-tests.
       
  2669 
       
  2670 2010-07-06  Sam Weinig  <sam@webkit.org>
       
  2671 
       
  2672         Fix MiniBrowser build.
       
  2673 
       
  2674         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
       
  2675 
       
  2676 2010-07-06  Sam Weinig  <sam@webkit.org>
       
  2677 
       
  2678         Reviewed by Anders Carlsson.
       
  2679 
       
  2680         Add support for dumping the contents of messages to the console to WebKitTestRunner
       
  2681 
       
  2682         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
       
  2683         (WTR::InjectedBundlePage::InjectedBundlePage):
       
  2684         (WTR::InjectedBundlePage::_addMessageToConsole):
       
  2685         (WTR::InjectedBundlePage::addMessageToConsole):
       
  2686         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
       
  2687 
       
  2688 2010-07-06  Sam Weinig  <sam@webkit.org>
       
  2689 
       
  2690         Reviewed by Anders Carlsson.
       
  2691 
       
  2692         Patch for https://bugs.webkit.org/show_bug.cgi?id=41708
       
  2693         Add dumpAsText support for WebKitTestRunner
       
  2694 
       
  2695         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
       
  2696         (WTR::InjectedBundle::InjectedBundle):
       
  2697         (WTR::InjectedBundle::reset): Reset the LayoutTestController for each test.
       
  2698         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
       
  2699         (WTR::InjectedBundlePage::didFinishLoadForFrame): Use the new WKBundleFrameCopyInnerText
       
  2700         API to dump the main frames text.
       
  2701 
       
  2702 2010-07-06  Darin Adler  <darin@apple.com>
       
  2703 
       
  2704         Fix Chromium build.
       
  2705 
       
  2706         * DumpRenderTree/chromium/WebViewHost.cpp:
       
  2707         (WebViewHost::didCreateDataSource): Call leakPtr instead of release.
       
  2708         (WebViewHost::didNavigateWithinPage): Ditto.
       
  2709         (WebViewHost::updateURL): Ditto.
       
  2710 
       
  2711 2010-07-06  Martin Robinson  <mrobinson@igalia.com>
       
  2712 
       
  2713         Reviewed by Xan Lopez.
       
  2714 
       
  2715         [GTK] build-webkit should not run autogen.sh unconditionally
       
  2716         https://bugs.webkit.org/show_bug.cgi?id=41704
       
  2717 
       
  2718         * Scripts/webkitdirs.pm: Only run autogen.sh during a build if GNUmakefile
       
  2719         doesn't exist. Autotools should re-run autogen.sh when necessary. Also do
       
  2720         some very minor cleanup.
       
  2721 
       
  2722 2010-07-06  Darin Adler  <darin@apple.com>
       
  2723 
       
  2724         Try to fix Chromium build.
       
  2725 
       
  2726         * DumpRenderTree/chromium/WebViewHost.cpp: Added include of PassOwnPtr.h.
       
  2727 
       
  2728 2010-07-06  Darin Adler  <darin@apple.com>
       
  2729 
       
  2730         Fix build.
       
  2731 
       
  2732         * WebKitAPITest/TestsController.cpp:
       
  2733         (WebKitAPITest::TestsController::addTest): Use leakPtr instead of release.
       
  2734 
       
  2735 2010-07-06  Roland Steiner  <rolandsteiner@chromium.org>
       
  2736 
       
  2737         Reviewed by Kent Tamura.
       
  2738 
       
  2739         Bug 40558 - [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
       
  2740         https://bugs.webkit.org/show_bug.cgi?id=40558
       
  2741 
       
  2742         Upstream DevTools for Chromium DRT.
       
  2743         (original Chromium files rev. 51287)
       
  2744 
       
  2745         * DumpRenderTree/DumpRenderTree.gypi:
       
  2746         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Added.
       
  2747         (DRTDevToolsAgent::DRTDevToolsAgent):
       
  2748         (DRTDevToolsAgent::setWebView):
       
  2749         (DRTDevToolsAgent::sendMessageToFrontend):
       
  2750         (DRTDevToolsAgent::forceRepaint):
       
  2751         (DRTDevToolsAgent::runtimeFeatureStateChanged):
       
  2752         (DRTDevToolsAgent::injectedScriptSource):
       
  2753         (DRTDevToolsAgent::injectedScriptDispatcherSource):
       
  2754         (DRTDevToolsAgent::debuggerScriptSource):
       
  2755         (DRTDevToolsAgent::asyncCall):
       
  2756         (DRTDevToolsAgent::call):
       
  2757         (DRTDevToolsAgent::webDevToolsAgent):
       
  2758         (DRTDevToolsAgent::attach):
       
  2759         (DRTDevToolsAgent::detach):
       
  2760         (DRTDevToolsAgent::setTimelineProfilingEnabled):
       
  2761         (DRTDevToolsAgent::evaluateInWebInspector):
       
  2762         (DRTDevToolsAgent::dispatchMessageLoop):
       
  2763         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Added.
       
  2764         (DRTDevToolsAgent::~DRTDevToolsAgent):
       
  2765         (DRTDevToolsAgent::hostIdentifier):
       
  2766         * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp:
       
  2767         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
       
  2768         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
       
  2769         (DRTDevToolsCallArgs::~DRTDevToolsCallArgs):
       
  2770         (DRTDevToolsCallArgs::callsCount):
       
  2771         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Added.
       
  2772         (DRTDevToolsClient::DRTDevToolsClient):
       
  2773         (DRTDevToolsClient::~DRTDevToolsClient):
       
  2774         (DRTDevToolsClient::sendMessageToAgent):
       
  2775         (DRTDevToolsClient::sendDebuggerCommandToAgent):
       
  2776         (DRTDevToolsClient::activateWindow):
       
  2777         (DRTDevToolsClient::closeWindow):
       
  2778         (DRTDevToolsClient::dockWindow):
       
  2779         (DRTDevToolsClient::undockWindow):
       
  2780         (DRTDevToolsClient::asyncCall):
       
  2781         (DRTDevToolsClient::call):
       
  2782         (DRTDevToolsClient::allMessagesProcessed):
       
  2783         * DumpRenderTree/chromium/DRTDevToolsClient.h:
       
  2784         * DumpRenderTree/chromium/EventSender.cpp:
       
  2785         * DumpRenderTree/chromium/LayoutTestController.cpp:
       
  2786         (LayoutTestController::LayoutTestController):
       
  2787         (LayoutTestController::closeWebInspector):
       
  2788         (LayoutTestController::setTimelineProfilingEnabled):
       
  2789         (LayoutTestController::evaluateInWebInspector):
       
  2790         * DumpRenderTree/chromium/LayoutTestController.h:
       
  2791         * DumpRenderTree/chromium/TestShell.cpp:
       
  2792         (TestShell::TestShell):
       
  2793         (TestShell::~TestShell):
       
  2794         (TestShell::createDRTDevToolsClient):
       
  2795         (TestShell::showDevTools):
       
  2796         (TestShell::closeDevTools):
       
  2797         (TestShell::runFileTest):
       
  2798         (TestShell::createNewWindow):
       
  2799         * DumpRenderTree/chromium/TestShell.h:
       
  2800         (TestShell::drtDevToolsAgent):
       
  2801         (TestShell::drtDevToolsClient):
       
  2802         * DumpRenderTree/chromium/config.h:
       
  2803 
       
  2804 2010-07-06  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
       
  2805 
       
  2806         Reviewed by Eric Seidel.
       
  2807 
       
  2808         Don't pass image hash to DRT when pixel tests are disabled.
       
  2809         https://bugs.webkit.org/show_bug.cgi?id=41597
       
  2810 
       
  2811         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
       
  2812 
       
  2813 2010-07-05  Csaba Osztrogonác  <ossy@webkit.org>
       
  2814 
       
  2815         Reviewed by Eric Seidel.
       
  2816 
       
  2817         REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
       
  2818         https://bugs.webkit.org/show_bug.cgi?id=41612
       
  2819 
       
  2820         * Scripts/ensure-valid-python: File::Temp::tempdir call fixed.
       
  2821 
       
  2822 2010-07-05  Adam Barth  <abarth@webkit.org>
       
  2823 
       
  2824         Reviewed by Eric Seidel.
       
  2825 
       
  2826         We should be able to specify a bug to block for webkit-patch upload
       
  2827         https://bugs.webkit.org/show_bug.cgi?id=41648
       
  2828 
       
  2829         This will be useful for working on the HTML5 parser.
       
  2830 
       
  2831         * Scripts/webkitpy/tool/steps/createbug.py:
       
  2832         * Scripts/webkitpy/tool/steps/options.py:
       
  2833 
       
  2834 2010-07-05  Martin Robinson  <mrobinson@igalia.com>
       
  2835 
       
  2836         Reviewed by Oliver Hunt.
       
  2837 
       
  2838         The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
       
  2839         https://bugs.webkit.org/show_bug.cgi?id=41017
       
  2840 
       
  2841         * Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
       
  2842         * Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.
       
  2843 
       
  2844 2010-07-04  MORITA Hajime  <morrita@google.com>
       
  2845 
       
  2846         rebaseline-chromium-webkit-tests: UnicodeDecodeError
       
  2847         https://bugs.webkit.org/show_bug.cgi?id=41589
       
  2848 
       
  2849         * run() method can result non-utf-8 bytes, that causes utf-8
       
  2850           decoding fail.  Fixed to disable decoding.
       
  2851         * Fixed Git.find_checkout_root() to make a test pass.
       
  2852 
       
  2853         * Scripts/webkitpy/common/checkout/scm.py:
       
  2854         * Scripts/webkitpy/common/checkout/scm_unittest.py:
       
  2855 
       
  2856 2010-07-03  Patrick Gansterer  <paroga@paroga.com>
       
  2857 
       
  2858         Reviewed by Simon Hausmann.
       
  2859 
       
  2860         [Qt] Fix DumpRenderTree userStyleSheet handling.
       
  2861         https://bugs.webkit.org/show_bug.cgi?id=41570
       
  2862 
       
  2863         DumpRenderTree did only set the userStyleSheet at
       
  2864         layoutTestController.setUserStyleSheetEnabled().
       
  2865 
       
  2866         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
       
  2867         (LayoutTestController::reset):
       
  2868         (LayoutTestController::setUserStyleSheetLocation):
       
  2869         (LayoutTestController::setUserStyleSheetEnabled):
       
  2870         * DumpRenderTree/qt/LayoutTestControllerQt.h:
       
  2871 
       
  2872 2010-07-03  Robert Hogan  <robert@webkit.org>
       
  2873 
       
  2874         Reviewed by Kenneth Rohde Christiansen.
       
  2875 
       
  2876         [Qt] support dumpChildFrameScrollPositions
       
  2877 
       
  2878         https://bugs.webkit.org/show_bug.cgi?id=41088
       
  2879 
       
  2880         Unskip:
       
  2881 
       
  2882         http/tests/navigation/anchor-subframeload.html
       
  2883         http/tests/navigation/relativeanchor-frames.html
       
  2884 
       
  2885         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
       
  2886         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
       
  2887         (WebCore::DumpRenderTree::dump):
       
  2888         * DumpRenderTree/qt/DumpRenderTreeQt.h:
       
  2889         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
       
  2890         (LayoutTestController::reset):
       
  2891         * DumpRenderTree/qt/LayoutTestControllerQt.h:
       
  2892         (LayoutTestController::shouldDumpChildFrameScrollPositions):
       
  2893         (LayoutTestController::dumpChildFrameScrollPositions):
       
  2894 
       
  2895 2010-07-02  Sam Weinig  <sam@webkit.org>
       
  2896 
       
  2897         Reviewed by Anders Carlsson.
       
  2898 
       
  2899         Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.
       
  2900 
       
  2901         * Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
       
  2902         * Scripts/debug-webkittestrunner: Removed.
       
  2903         * Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
       
  2904         * Scripts/run-webkittestrunner: Removed.
       
  2905 
       
  2906 2010-07-02  Brian Weinstein  <bweinstein@apple.com>
       
  2907 
       
  2908         Reviewed by Steve Falkenburg.
       
  2909 
       
  2910         Some http tests fail on Windows with Cygwin 1.7
       
  2911         https://bugs.webkit.org/show_bug.cgi?id=41537
       
  2912         
       
  2913         With Cygwin 1.7, the registry key at SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/
       
  2914         doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we
       
  2915         just need root mount point, which is defined in SOFTWARE\\Cygwin\\setup.
       
  2916 
       
  2917         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
       
  2918         (resolveCygwinPath): Fall back to SOFTWARE\\Cygwin\\setup if 
       
  2919             SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ doesn't work.
       
  2920 
       
  2921 2010-06-23  Martin Robinson  <mrobinson@igalia.com>
       
  2922 
       
  2923         Reviewed by Gustavo Noronha Silva.
       
  2924 
       
  2925         [GTK] Separate DerivedSources per-project
       
  2926         https://bugs.webkit.org/show_bug.cgi?id=41109
       
  2927 
       
  2928         The JavaScriptCore cppflags used to include the top-level DerivedSources directory
       
  2929         allowing the tools to build as a side-effect. Now that the top-level directory
       
  2930         is no longer in the list of JavaScriptCore includes, include it explicitly.
       
  2931 
       
  2932         * GNUmakefile.am:
       
  2933 
       
  2934 2010-07-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
       
  2935 
       
  2936         Reviewed by Kenneth Rohde Christiansen.
       
  2937 
       
  2938         [Qt] Make context menus show up in the right place in QTestBrowser
       
  2939 
       
  2940         Context menus were shown at scene-relative coordinates for
       
  2941         QGraphicsWebView while QMenu expects them to be global. The
       
  2942         change to the QWidget case was to get rid of the mapToGlobal.
       
  2943 
       
  2944         * QtTestBrowser/webview.cpp:
       
  2945 
       
  2946 2010-07-01  Robert Hogan <robert@webkit.org>
       
  2947 
       
  2948         Reviewed by Kenneth Rohde Christiansen.
       
  2949 
       
  2950         [Qt] dump frames in ascending alphabetical order of title
       
  2951 
       
  2952         https://bugs.webkit.org/show_bug.cgi?id=41261
       
  2953 
       
  2954         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
       
  2955         (WebCore::dumpHistoryItem):
       
  2956 
       
  2957 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
       
  2958 
       
  2959         Unreviewed. 
       
  2960 
       
  2961         Fix the GTK+ build after r62278.
       
  2962 
       
  2963         * Scripts/webkitdirs.pm: If the make arguments have already been specified,
       
  2964         let them override the automatic CPU detection for autotools builds.
       
  2965 
       
  2966 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
       
  2967 
       
  2968         Unreviewed.
       
  2969 
       
  2970         Fix the Windows build after r62278.
       
  2971 
       
  2972         * Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories.
       
  2973 
       
  2974 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
       
  2975 
       
  2976         Reviewed by Gustavo Noronha Silva.
       
  2977 
       
  2978         [GTK] build-webkit does not detect the number of CPUs
       
  2979         https://bugs.webkit.org/show_bug.cgi?id=41469
       
  2980 
       
  2981         Pass the appropriate -j<#> flag to make when building autotools builds.
       
  2982         This causes make to spawn that many number of child processes for doing
       
  2983         parallel builds.
       
  2984 
       
  2985         * Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number
       
  2986         of CPUs. This makes the script work across more platforms.
       
  2987         * Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the
       
  2988         number of CPUs across several platforms. Use this new function to determine the appropriate
       
  2989         arguments to pass to make for doing parallel builds with autotools build files.
       
  2990 
       
  2991 2010-07-01  Simon Hausmann  <simon.hausmann@nokia.com>
       
  2992 
       
  2993         Rubber-stamped by Laszlo Gombos.
       
  2994 
       
  2995         [Qt][Symbian] Bumped up the maximum heap size to 96MB
       
  2996 
       
  2997         * QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration
       
  2998         and use the one from WebKit.pri instead.
       
  2999 
       
  3000 2010-07-01  Adam Barth  <abarth@webkit.org>
       
  3001 
       
  3002         Reviewed by Eric Seidel.
       
  3003 
       
  3004         Promote webkit-patch land-safely to main help
       
  3005         https://bugs.webkit.org/show_bug.cgi?id=41446
       
  3006 
       
  3007         I've been using this command a bunch and recommending it to folks.  We
       
  3008         should show it in main help as it's past the experimental phase.
       
  3009 
       
  3010         * Scripts/webkitpy/tool/commands/upload.py:
       
  3011 
       
  3012 2010-06-28  MORITA Hajime  <morrita@google.com>
       
  3013 
       
  3014         Reviewed by Shinichiro Hamaji.
       
  3015 
       
  3016         rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit
       
  3017         https://bugs.webkit.org/show_bug.cgi?id=38775
       
  3018 
       
  3019         - Introduced SCM.show_head() and SCM.diff_for_file().
       
  3020         - Replaced direct svn invocations with newly implement SCM methods.
       
  3021 
       
  3022         * Scripts/webkitpy/common/checkout/scm.py:
       
  3023         * Scripts/webkitpy/common/checkout/scm_unittest.py:
       
  3024         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
       
  3025 
       
  3026 2010-06-30  Simon Fraser  <simon.fraser@apple.com>
       
  3027 
       
  3028         Reviewed by Sam Weinig.
       
  3029 
       
  3030         Allow MiniBrowser to open local files
       
  3031         https://bugs.webkit.org/show_bug.cgi?id=41104
       
  3032 
       
  3033         Wire up the openDocument: message with an NSOpenPanel, so we can open
       
  3034         local files.
       
  3035         
       
  3036         Also change the xib so that the window remembers its size.
       
  3037         
       
  3038         * MiniBrowser/mac/AppDelegate.m:
       
  3039         (-[BrowserAppDelegate frontmostBrowserWindowController]):
       
  3040         (-[BrowserAppDelegate openDocument:]):
       
  3041         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
       
  3042         * MiniBrowser/mac/English.lproj/BrowserWindow.xib:
       
  3043 
       
  3044 2010-06-30  Sam Weinig  <sam@webkit.org>
       
  3045 
       
  3046         Rubber-stamped by Anders Carlsson.
       
  3047 
       
  3048         Add debug-webkittestrunner and cleanup related scripts.
       
  3049 
       
  3050         * Scripts/debug-webkittestrunner: Added.
       
  3051         * Scripts/run-webkittestrunner:
       
  3052         * Scripts/webkitdirs.pm:
       
  3053 
       
  3054 2010-06-30  Kevin Ollivier  <kevino@theolliviers.com>
       
  3055 
       
  3056         [wx] Build fix after recent changes to LayoutTestController.
       
  3057 
       
  3058         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
       
  3059         (LayoutTestController::pageSizeAndMarginsInPixels):
       
  3060 
       
  3061 2010-06-29  Sam Weinig  <sam@webkit.org>
       
  3062 
       
  3063         Reviewed by Anders Carlsson.
       
  3064 
       
  3065         Patch for https://bugs.webkit.org/show_bug.cgi?id=41389
       
  3066         Make WebKitTestRunner work with more than one test at a time.
       
  3067 
       
  3068         This converts WebKitTestRunner to a similar model as DumpRenderTree,
       
  3069         where there is a single WKView and each test is run it, rather than
       
  3070         the design I was using where each test got its own WKView.
       
  3071 
       
  3072         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
       
  3073         (WTR::InjectedBundle::didRecieveMessage):
       
  3074         (WTR::InjectedBundle::reset):
       
  3075         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
       
  3076         * WebKitTestRunner/TestController.cpp:
       
  3077         (WTR::TestController::initialize):
       
  3078         (WTR::TestController::runTest):
       
  3079         (WTR::TestController::_didRecieveMessageFromInjectedBundle):
       
  3080         (WTR::TestController::didRecieveMessageFromInjectedBundle):
       
  3081         * WebKitTestRunner/TestController.h:
       
  3082         (WTR::TestController::mainWebView):
       
  3083         (WTR::TestController::pageNamespace):
       
  3084         (WTR::TestController::context):
       
  3085         * WebKitTestRunner/TestInvocation.cpp:
       
  3086         (WTR::TestInvocation::TestInvocation):
       
  3087         (WTR::TestInvocation::~TestInvocation):
       
  3088         (WTR::TestInvocation::invoke):
       
  3089         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
       
  3090         * WebKitTestRunner/TestInvocation.h:
       
  3091 
       
  3092 2010-06-30  Simon Hausmann  <simon.hausmann@nokia.com>
       
  3093 
       
  3094         Reviewed by Laszlo Gombos.
       
  3095 
       
  3096         [Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0
       
  3097         https://bugs.webkit.org/show_bug.cgi?id=40446
       
  3098 
       
  3099         We quickly run out of memory on Symbian when loading web pages. This is
       
  3100         caused by the default heap size, which is not suited for a web browser.
       
  3101 
       
  3102         This change bumps the max heap size to 32MB.
       
  3103 
       
  3104         * QtTestBrowser/QtTestBrowser.pro:
       
  3105 
       
  3106 2010-06-30  Eric Seidel  <eric@webkit.org>
       
  3107 
       
  3108         Reviewed by Adam Barth.
       
  3109 
       
  3110         webkit-patch land allow the user to continue even if the builders are red
       
  3111         https://bugs.webkit.org/show_bug.cgi?id=41395
       
  3112 
       
  3113         I don't think it's good that we've been teaching people
       
  3114         to always pass --ignore-builders.  At least land is now
       
  3115         useable w/o --ignore-builders.
       
  3116 
       
  3117         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
       
  3118 
       
  3119 2010-06-29  Robert Hogan  <robert@webkit.org>
       
  3120 
       
  3121         Reviewed by Kenneth Rohde Christiansen.
       
  3122 
       
  3123         [Qt] support dumpResourceResponseMIMETypes
       
  3124         https://bugs.webkit.org/show_bug.cgi?id=41260
       
  3125 
       
  3126         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
       
  3127         (LayoutTestController::reset):
       
  3128         (LayoutTestController::dumpResourceResponseMIMETypes):
       
  3129         * DumpRenderTree/qt/LayoutTestControllerQt.h:
       
  3130 
       
  3131 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
       
  3132 
       
  3133         Reviewed by Kenneth Rohde Christiansen.
       
  3134 
       
  3135         [Qt] Resize scene when Qt DRT WebPage receives a geometry change request
       
  3136         https://bugs.webkit.org/show_bug.cgi?id=41173
       
  3137 
       
  3138         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
       
  3139         (WebCore::WebPage::setViewGeometry):
       
  3140         * DumpRenderTree/qt/DumpRenderTreeQt.h:
       
  3141 
       
  3142 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
       
  3143 
       
  3144         Reviewed by Simon Hausmann.
       
  3145 
       
  3146         [Qt] Deal with postEvent in case of graphics based DRT
       
  3147         https://bugs.webkit.org/show_bug.cgi?id=41174
       
  3148 
       
  3149         QGraphicsScene does not have a postEvent method, so make scene
       
  3150         send the event, in case of graphics based DRT, and delete it after that.
       
  3151 
       
  3152         * DumpRenderTree/qt/EventSenderQt.cpp:
       
  3153         (EventSender::scheduleAsynchronousClick):
       
  3154         (EventSender::replaySavedEvents):
       
  3155         (EventSender::postEvent):
       
  3156         * DumpRenderTree/qt/EventSenderQt.h:
       
  3157 
       
  3158 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
       
  3159 
       
  3160         Reviewed by Kenneth Rohde Christiansen.
       
  3161 
       
  3162         [Qt] Make switchFocus() method works with QGraphicsWebView in Qt DRT
       
  3163         https://bugs.webkit.org/show_bug.cgi?id=41172
       
  3164 
       
  3165         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
       
  3166         (WebCore::DumpRenderTree::switchFocus):
       
  3167 
       
  3168 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
       
  3169 
       
  3170         Reviewed by Xan Lopez.
       
  3171 
       
  3172         [Gtk] Make DRT more coherent with other ports to allow reusing more tests
       
  3173         https://bugs.webkit.org/show_bug.cgi?id=40009
       
  3174 
       
  3175         Make sure "AXRole: ", "AXTitle: " and "AXDescription: " prefixes
       
  3176         are used when returning those values, for coherency with other ports.
       
  3177 
       
  3178         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
       
  3179         (AccessibilityUIElement::role):
       
  3180         (AccessibilityUIElement::title):
       
  3181         (AccessibilityUIElement::description):
       
  3182 
       
  3183 2010-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
       
  3184 
       
  3185         Unreviewed, rolling out r62106.
       
  3186         http://trac.webkit.org/changeset/62106
       
  3187         https://bugs.webkit.org/show_bug.cgi?id=41346
       
  3188 
       
  3189         "Broke editing tests" (Requested by xan_ on #webkit).
       
  3190 
       
  3191         * Scripts/old-run-webkit-tests:
       
  3192 
       
  3193 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
       
  3194 
       
  3195         Reviewed by Xan Lopez.
       
  3196 
       
  3197         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
       
  3198         https://bugs.webkit.org/show_bug.cgi?id=38648
       
  3199 
       
  3200         Add the GTK_MODULES envvar (set to "gail") to the clean
       
  3201         environment when running DRT for the Gtk+ port
       
  3202 
       
  3203         * Scripts/old-run-webkit-tests:
       
  3204 
       
  3205 2010-06-28  Adam Barth  <abarth@webkit.org>
       
  3206 
       
  3207         Unreviewed.
       
  3208 
       
  3209         Switch test-html5-parser back to using runner.html.
       
  3210 
       
  3211         * Scripts/test-html5-parser:
       
  3212 
       
  3213 2010-06-28  Adam Barth  <abarth@webkit.org>
       
  3214 
       
  3215         Reviewed by Eric Seidel.
       
  3216 
       
  3217         Restore webkit-runner.html for use with new tree builder
       
  3218         https://bugs.webkit.org/show_bug.cgi?id=41317
       
  3219 
       
  3220         For now, we just want to run webkit-runner when we test-html5-parser.
       
  3221 
       
  3222         * Scripts/test-html5-parser:
       
  3223 
       
  3224 2010-06-23  John Gregg  <johnnyg@google.com>
       
  3225 
       
  3226         Reviewed by Kent Tamura.
       
  3227 
       
  3228         add ENABLE_DIRECTORY_UPLOAD build support
       
  3229         https://bugs.webkit.org/show_bug.cgi?id=41100
       
  3230 
       
  3231         * Scripts/build-webkit:
       
  3232 
       
  3233 2010-06-28  Gustavo Noronha Silva  <gns@gnome.org>
       
  3234 
       
  3235         Rubber-stamped by Xan Lopez.
       
  3236 
       
  3237         Update webkitdirs's knowledge of our library's name.
       
  3238 
       
  3239         * Scripts/webkitdirs.pm:
       
  3240 
       
  3241 2010-06-28  Sam Weinig  <sam@webkit.org>
       
  3242 
       
  3243         Reviewed by Anders Carlsson.
       
  3244 
       
  3245         Patch for https://bugs.webkit.org/show_bug.cgi?id=41299
       
  3246         Build up WebKitTestRunner output in the InjectedBundle
       
  3247 
       
  3248         Simplify WebKitTestRunner by building up the output in the InjectedBundle
       
  3249         and sending it over postMessage when done, instead of using the async
       
  3250         WKPageRenderTreeExternalRepresentation.
       
  3251 
       
  3252         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
       
  3253         (WTR::InjectedBundle::done):
       
  3254         (WTR::InjectedBundle::didRecieveMessage):
       
  3255         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
       
  3256         (WTR::InjectedBundle::os):
       
  3257         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
       
  3258         (WTR::WKStringToUTF8):
       
  3259         (WTR::InjectedBundlePage::didFinishLoadForFrame):
       
  3260         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
       
  3261         * WebKitTestRunner/TestInvocation.cpp:
       
  3262         (WTR::WKStringToUTF8):
       
  3263         (WTR::TestInvocation::TestInvocation):
       
  3264         (WTR::TestInvocation::invoke):
       
  3265         (WTR::TestInvocation::initializeMainWebView):
       
  3266         (WTR::TestInvocation::_didRecieveMessageFromInjectedBundle):
       
  3267         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
       
  3268         * WebKitTestRunner/TestInvocation.h:
       
  3269 
       
  3270 2010-06-28  Robert Hogan  <robert@webkit.org>
       
  3271 
       
  3272         Unreviewed, rolling out r62021.
       
  3273         http://trac.webkit.org/changeset/62021
       
  3274         https://bugs.webkit.org/show_bug.cgi?id=41261
       
  3275 
       
  3276         Broke http/navigation tests among other
       
  3277 
       
  3278         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
       
  3279         (WebCore::DumpRenderTree::dumpFramesAsText):
       
  3280 
       
  3281 2010-06-28  Sam Weinig  <sam@webkit.org>
       
  3282 
       
  3283         Reviewed by Anders Carlsson.
       
  3284 
       
  3285         Add run-webkittestrunner to run WebKitTestRunner with the appropriate
       
  3286         environment.
       
  3287 
       
  3288         * Scripts/run-webkittestrunner: Added.
       
  3289         * Scripts/webkitdirs.pm:
       
  3290 
       
  3291 2010-06-28  Robert Hogan  <robert@webkit.org>
       
  3292 
       
  3293         Reviewed by Kenneth Rohde Christiansen.
       
  3294 
       
  3295         [Qt] dump frames in ascending alphabetical order of title
       
  3296 
       
  3297         https://bugs.webkit.org/show_bug.cgi?id=41261
       
  3298 
       
  3299         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
       
  3300         (WebCore::DumpRenderTree::dumpFramesAsText):
       
  3301 
       
  3302 2010-06-28  Robert Hogan  <robert@webkit.org>
       
  3303 
       
  3304         Reviewed by Kenneth Rohde Christiansen.
       
  3305 
       
  3306         [Qt] dump bf history of child windows
       
  3307 
       
  3308         https://bugs.webkit.org/show_bug.cgi?id=41266
       
  3309 
       
  3310         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
       
  3311         (WebCore::DumpRenderTree::dumpBackForwardList):
       
  3312         (WebCore::DumpRenderTree::dump):
       
  3313         * DumpRenderTree/qt/DumpRenderTreeQt.h:
       
  3314 
       
  3315 2010-06-28  Sam Weinig  <sam@webkit.org>
       
  3316 
       
  3317         Reviewed by Anders Carlsson.
       
  3318 
       
  3319         Patch for https://bugs.webkit.org/show_bug.cgi?id=41288
       
  3320         WebKit2: Add frame API for InjectedBundle code
       
  3321 
       
  3322         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
       
  3323         (_didClearWindowForFrame):
       
  3324 
       
  3325 2010-06-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
       
  3326 
       
  3327         Reviewed by Kenneth Rohde Christiansen.
       
  3328 
       
  3329         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
       
  3330         https://bugs.webkit.org/show_bug.cgi?id=38597
       
  3331 
       
  3332         Fix behavior so reload button really acts as a load and a reload button.
       
  3333 
       
  3334         * QtTestBrowser/mainwindow.cpp:
       
  3335         (MainWindow::changeLocation):
       
  3336 
       
  3337 2010-06-28  Xan Lopez  <xlopez@igalia.com>
       
  3338 
       
  3339         Reviewed by Gustavo Noronha.
       
  3340 
       
  3341         [GTK] Does not compile with -DGSEAL_ENABLE
       
  3342         https://bugs.webkit.org/show_bug.cgi?id=37851
       
  3343 
       
  3344         Fix build with GSEAL enabled.
       
  3345 
       
  3346         * DumpRenderTree/gtk/EventSender.cpp:
       
  3347         (gtk_widget_get_window):
       
  3348         (prepareMouseButtonEvent):
       
  3349         (mouseMoveToCallback):
       
  3350         (mouseWheelToCallback):
       
  3351         (keyDownCallback):
       
  3352 
       
  3353 2010-06-28  Xan Lopez  <xlopez@igalia.com>
       
  3354 
       
  3355         Reviewed by Gustavo Noronha.
       
  3356 
       
  3357         [GTK] Add support for GTK+3
       
  3358         https://bugs.webkit.org/show_bug.cgi?id=41253
       
  3359 
       
  3360         Adapt build system for 3.x support.
       
  3361 
       
  3362         * GNUmakefile.am:
       
  3363 
       
  3364 2010-06-10  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
       
  3365 
       
  3366         Reviewed by Simon Hausmann.
       
  3367 
       
  3368         [QT][S60] build-webkit scripts picks wrong make spec for windows build
       
  3369         https://bugs.webkit.org/show_bug.cgi?id=41198
       
  3370 
       
  3371         Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds. 
       
  3372 
       
  3373         * Scripts/webkitdirs.pm:
       
  3374         (determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well
       
  3375 
       
  3376 2010-06-28  Eric Seidel  <eric@webkit.org>
       
  3377 
       
  3378         Reviewed by Adam Barth.
       
  3379 
       
  3380         Make it possible to test the new HTML5 TreeBuilder
       
  3381         https://bugs.webkit.org/show_bug.cgi?id=41276
       
  3382 
       
  3383         Adam was concerned that someone might make their port
       
  3384         depend on this setting (I guess we had some trouble with that
       
  3385         with the HTML5Parser setting), so I littered the code with warnings.
       
  3386 
       
  3387         test-html5-parser now tests this code path.
       
  3388 
       
  3389         * DumpRenderTree/mac/DumpRenderTree.mm:
       
  3390         (resetDefaultsToConsistentValues):
       
  3391         (initializeGlobalsFromCommandLineOptions):
       
  3392         * Scripts/test-html5-parser:
       
  3393 
       
  3394 2010-06-27  MORITA Hajime  <morrita@google.com>
       
  3395 
       
  3396         Unreviewed. 
       
  3397         
       
  3398         Some never-called @staticmethods touched self. 
       
  3399         Fixed it to replace these self with a class.
       
  3400 
       
  3401         * Scripts/webkitpy/common/checkout/scm.py:
       
  3402 
       
  3403 2010-06-27  MORITA Hajime  <morrita@google.com>
       
  3404 
       
  3405         Unreviewed.
       
  3406         
       
  3407         Fixed exception raising syntax that is pointed out at
       
  3408         https://bugs.webkit.org/show_bug.cgi?id=41153
       
  3409 
       
  3410         * Scripts/webkitpy/common/checkout/scm.py:
       
  3411         * Scripts/webkitpy/common/checkout/scm_unittest.py: 
       
  3412           Removed a bad line that I accidentally checked-in at last revision.
       
  3413 
       
  3414 2010-06-24  MORITA Hajime  <morrita@google.com>
       
  3415 
       
  3416         Reviewed by Eric Seidel.
       
  3417 
       
  3418         rebaseline-chromium-webkit-tests should add or remove files to local git repository
       
  3419         https://bugs.webkit.org/show_bug.cgi?id=41153
       
  3420 
       
  3421         - Added SCM.add() and SCM.remove()
       
  3422         - Replaced "svn add" and "svn remove"
       
  3423           rebaseline_chromium_webkit_tests.py: in with SCM method equivalents.
       
  3424         - add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py
       
  3425           for debugging purpose.
       
  3426 
       
  3427         * Scripts/webkitpy/common/checkout/scm.py:
       
  3428         * Scripts/webkitpy/common/checkout/scm_unittest.py:
       
  3429         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
       
  3430 
       
  3431 2010-06-25  Yuzo Fujishima  <yuzo@google.com>
       
  3432 
       
  3433         Reviewed by Shinichiro Hamaji.
       
  3434 
       
  3435         Improve default value handling for page format properties.
       
  3436         https://bugs.webkit.org/show_bug.cgi?id=41150
       
  3437 
       
  3438         * DumpRenderTree/LayoutTestController.cpp:
       
  3439         (parsePageNumber):
       
  3440         (parsePageNumberSizeMarings):
       
  3441         (pageSizeAndMarginsInPixelsCallback):
       
  3442         (LayoutTestController::staticFunctions):
       
  3443         * DumpRenderTree/LayoutTestController.h:
       
  3444         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
       
  3445         (LayoutTestController::pageSizeAndMarginsInPixels):
       
  3446         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
       
  3447         (LayoutTestController::pageSizeAndMarginsInPixels):
       
  3448         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
       
  3449         (LayoutTestController::pageSizeAndMarginsInPixels):
       
  3450 
       
  3451 2010-06-21  Robert Hogan  <robert@webkit.org>
       
  3452 
       
  3453         Reviewed by Kenneth Rohde Christiansen.
       
  3454 
       
  3455         [Qt] DRT Support for setCustomPolicyDelegate
       
  3456 
       
  3457         https://bugs.webkit.org/show_bug.cgi?id=39564
       
  3458 
       
  3459         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
       
  3460         (LayoutTestController::setCustomPolicyDelegate):
       
  3461         * DumpRenderTree/qt/LayoutTestControllerQt.h:
       
  3462 
       
  3463 2010-06-26  Robert Hogan  <robert@webkit.org>
       
  3464 
       
  3465         Unreviewed, Qt build fix following http://trac.webkit.org/changeset/61879
       
  3466         
       
  3467         Remove qwebscriptworld.h from LayoutTestControllerQt.cpp - it is no longer
       
  3468         exported.
       
  3469 
       
  3470         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
       
  3471 
       
  3472 2010-06-26  Tony Gentilcore  <tonyg@chromium.org>
       
  3473 
       
  3474         Reviewed by Dimitri Glazkov.
       
  3475 
       
  3476         Add a build-webkit option for enabling Web Timing support.
       
  3477         https://bugs.webkit.org/show_bug.cgi?id=38924
       
  3478 
       
  3479         * Scripts/build-webkit:
       
  3480 
       
  3481 2010-06-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
       
  3482 
       
  3483         Reviewed by Kenneth Rohde Christiansen.
       
  3484 
       
  3485         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
       
  3486         https://bugs.webkit.org/show_bug.cgi?id=38597
       
  3487 
       
  3488         Make the reload button act as a load button as well.
       
  3489 
       
  3490         * QtTestBrowser/mainwindow.cpp:
       
  3491         (MainWindow::buildUI):
       
  3492         (MainWindow::changeLocation):
       
  3493 
       
  3494 2010-06-25  Prasad Tammana  <prasadt@chromium.org>
       
  3495 
       
  3496         Reviewed by Dmitry Titov.
       
  3497 
       
  3498         Add empty abortModal() method to all platforms.
       
  3499         https://bugs.webkit.org/show_bug.cgi?id=40864
       
  3500 
       
  3501         Add an empty abortModal() stub to LayoutTestController on all platforms to get rid of platform specific #ifs in
       
  3502         platform independent LayoutTestController code.  Without this change, layout tests using LayoutTestController tests
       
  3503         that use abortModal will become mac specific which is not desirable.
       
  3504 
       
  3505         * DumpRenderTree/LayoutTestController.cpp:
       
  3506         (abortModalCallback):
       
  3507         (LayoutTestController::staticFunctions):
       
  3508         * DumpRenderTree/LayoutTestController.h:
       
  3509         * DumpRenderTree/chromium/LayoutTestController.cpp:
       
  3510         (LayoutTestController::LayoutTestController):
       
  3511         (LayoutTestController::abortModal):
       
  3512         * DumpRenderTree/chromium/LayoutTestController.h:
       
  3513         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
       
  3514         (LayoutTestController::abortModal):
       
  3515         * DumpRenderTree/qt/LayoutTestControllerQt.h:
       
  3516         (LayoutTestController::abortModal):
       
  3517         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
       
  3518         (LayoutTestController::abortModal):
       
  3519         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
       
  3520         (LayoutTestController::abortModal):
       
  3521 
       
  3522 2010-06-25  Sam Weinig  <sam@webkit.org>
       
  3523 
       
  3524         Reviewed by Anders Carlsson.
       
  3525 
       
  3526         Patch for https://bugs.webkit.org/show_bug.cgi?id=41226
       
  3527         Flesh out injected bundle code for WebKitTestRunner and add basic LayoutTestController.
       
  3528 
       
  3529         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Added.
       
  3530         (WTR::InjectedBundle::shared):
       
  3531         (WTR::InjectedBundle::InjectedBundle):
       
  3532         (WTR::InjectedBundle::_didCreatePage):
       
  3533         (WTR::InjectedBundle::_willDestroyPage):
       
  3534         (WTR::InjectedBundle::_didRecieveMessage):
       
  3535         (WTR::InjectedBundle::initialize):
       
  3536         (WTR::InjectedBundle::didCreatePage):
       
  3537         (WTR::InjectedBundle::willDestroyPage):
       
  3538         (WTR::InjectedBundle::didRecieveMessage):
       
  3539         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added.
       
  3540         (WTR::InjectedBundle::layoutTestController):
       
  3541         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
       
  3542         (WKBundleInitialize):
       
  3543         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Added.
       
  3544         (WTR::InjectedBundlePage::InjectedBundlePage):
       
  3545         (WTR::InjectedBundlePage::~InjectedBundlePage):
       
  3546         (WTR::InjectedBundlePage::_didStartProvisionalLoadForFrame):
       
  3547         (WTR::InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame):
       
  3548         (WTR::InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame):
       
  3549         (WTR::InjectedBundlePage::_didCommitLoadForFrame):
       
  3550         (WTR::InjectedBundlePage::_didFinishLoadForFrame):
       
  3551         (WTR::InjectedBundlePage::_didFailLoadWithErrorForFrame):
       
  3552         (WTR::InjectedBundlePage::_didReceiveTitleForFrame):
       
  3553         (WTR::InjectedBundlePage::_didClearWindowForFrame):
       
  3554         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
       
  3555         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
       
  3556         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
       
  3557         (WTR::InjectedBundlePage::didCommitLoadForFrame):
       
  3558         (WTR::InjectedBundlePage::didFinishLoadForFrame):
       
  3559         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
       
  3560         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
       
  3561         (WTR::InjectedBundlePage::didClearWindowForFrame):
       
  3562         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added.
       
  3563         (WTR::InjectedBundlePage::page):
       
  3564         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Added.
       
  3565         (WTR::LayoutTestController::create):
       
  3566         (WTR::LayoutTestController::LayoutTestController):
       
  3567         (WTR::LayoutTestController::~LayoutTestController):
       
  3568         (WTR::dumpAsTextCallback):
       
  3569         (WTR::layoutTestControllerObjectFinalize):
       
  3570         (WTR::LayoutTestController::makeWindowObject):
       
  3571         (WTR::LayoutTestController::getJSClass):
       
  3572         (WTR::LayoutTestController::staticFunctions):
       
  3573         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added.
       
  3574         (WTR::LayoutTestController::dumpAsText):
       
  3575         (WTR::LayoutTestController::setDumpAsText):
       
  3576         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
       
  3577 
       
  3578 2010-06-25  Sam Weinig  <sam@webkit.org>
       
  3579 
       
  3580         Reviewed by Anders Carlsson.
       
  3581 
       
  3582         Make WebKitTestRunner really work with run-webkit-tests. 
       
  3583 
       
  3584         - Add Forwarding headers to allow some cleanup.
       
  3585 
       
  3586         * WebKitTestRunner/ForwardingHeaders: Added.
       
  3587         * WebKitTestRunner/ForwardingHeaders/wtf: Added.
       
  3588         * WebKitTestRunner/ForwardingHeaders/wtf/ASCIICType.h: Added.
       
  3589         * WebKitTestRunner/ForwardingHeaders/wtf/Assertions.h: Added.
       
  3590         * WebKitTestRunner/ForwardingHeaders/wtf/Atomics.h: Added.
       
  3591         * WebKitTestRunner/ForwardingHeaders/wtf/FastMalloc.h: Added.
       
  3592         * WebKitTestRunner/ForwardingHeaders/wtf/HashMap.h: Added.
       
  3593         * WebKitTestRunner/ForwardingHeaders/wtf/HashSet.h: Added.
       
  3594         * WebKitTestRunner/ForwardingHeaders/wtf/HashTraits.h: Added.
       
  3595         * WebKitTestRunner/ForwardingHeaders/wtf/Locker.h: Added.
       
  3596         * WebKitTestRunner/ForwardingHeaders/wtf/MainThread.h: Added.
       
  3597         * WebKitTestRunner/ForwardingHeaders/wtf/MathExtras.h: Added.
       
  3598         * WebKitTestRunner/ForwardingHeaders/wtf/Noncopyable.h: Added.
       
  3599         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtr.h: Added.
       
  3600         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
       
  3601         * WebKitTestRunner/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
       
  3602         * WebKitTestRunner/ForwardingHeaders/wtf/PassRefPtr.h: Added.
       
  3603         * WebKitTestRunner/ForwardingHeaders/wtf/Platform.h: Added.
       
  3604         * WebKitTestRunner/ForwardingHeaders/wtf/RefCounted.h: Added.
       
  3605         * WebKitTestRunner/ForwardingHeaders/wtf/RefPtr.h: Added.
       
  3606         * WebKitTestRunner/ForwardingHeaders/wtf/RetainPtr.h: Added.
       
  3607         * WebKitTestRunner/ForwardingHeaders/wtf/StringExtras.h: Added.
       
  3608         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
       
  3609         * WebKitTestRunner/ForwardingHeaders/wtf/Threading.h: Added.
       
  3610         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
       
  3611         * WebKitTestRunner/ForwardingHeaders/wtf/Vector.h: Added.
       
  3612         * WebKitTestRunner/TestInvocation.cpp:
       
  3613         (WTR::TestInvocation::dump): Dump the right number of #EOFs.
       
  3614         * WebKitTestRunner/TestInvocation.h:
       
  3615 
       
  3616 2010-06-25  Sam Weinig  <sam@webkit.org>
       
  3617 
       
  3618         Reviewed by Mark Rowe.
       
  3619 
       
  3620         Add support for WebKitTestRunner to old-run-webkit-tests
       
  3621 
       
  3622         - Also adds a script to build WebKitTestRunner for old-run-webkit-tests to use.
       
  3623 
       
  3624         * Scripts/build-webkittestrunner: Added.
       
  3625         * Scripts/old-run-webkit-tests:
       
  3626 
       
  3627 2010-06-25  Adam Barth  <abarth@webkit.org>
       
  3628 
       
  3629         Reviewed by David Levin.
       
  3630 
       
  3631         Incremental build failed on Chromium ews
       
  3632         https://bugs.webkit.org/show_bug.cgi?id=41011
       
  3633 
       
  3634         The division of responsibility between update-webkit --chromium and
       
  3635         build-webkit --chromium is slightly unclear.  In this patch, we make
       
  3636         build-webkit --chromium also update DEPS and re-run GYP in case the
       
  3637         developer has changed either since they updated.
       
  3638 
       
  3639         This change is also helpful for the EWS, which wants to update DEPS and
       
  3640         re-run GYP after applying patches, but the EWS doesn't want to run
       
  3641         update-webkit --chromium because it has a dirty working copy.
       
  3642 
       
  3643         * Scripts/webkitdirs.pm:
       
  3644 
       
  3645 2010-06-25  Robert Hogan  <robert@webkit.org>
       
  3646 
       
  3647         Reviewed by Simon Hausmann.
       
  3648 
       
  3649         [Qt] Support evaluateScriptInIsolatedWorld()
       
  3650 
       
  3651         https://bugs.webkit.org/show_bug.cgi?id=40079
       
  3652 
       
  3653         Remove evaluateScriptInIsolatedWorld() from QtWebKit API.
       
  3654         Remove QWebScriptWorld from exported headers.
       
  3655         Confine support to DumpRenderTreeSupportQt so that the tests can pass.
       
  3656 
       
  3657         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
       
  3658         (LayoutTestController::reset):
       
  3659         (LayoutTestController::evaluateScriptInIsolatedWorld):
       
  3660         * DumpRenderTree/qt/LayoutTestControllerQt.h:
       
  3661 
       
  3662 2010-06-25  Anders Carlsson  <andersca@apple.com>
       
  3663 
       
  3664         Revert accidental part and add a newline.
       
  3665 
       
  3666         * MiniBrowser/mac/AppDelegate.m:
       
  3667         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
       
  3668 
       
  3669 2010-06-25  Anders Carlsson  <andersca@apple.com>
       
  3670 
       
  3671         Rubber-stamped by Dan Bernstein.
       
  3672 
       
  3673         Add a LOG macro that expands to a no-op by default.
       
  3674 
       
  3675         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
       
  3676         * MiniBrowser/mac/AppDelegate.m:
       
  3677         (_didRecieveMessageFromInjectedBundle):
       
  3678         * MiniBrowser/mac/BrowserWindowController.m:
       
  3679         (-[BrowserWindowController windowShouldClose:]):
       
  3680         (_didStartProvisionalLoadForFrame):
       
  3681         (_didReceiveServerRedirectForProvisionalLoadForFrame):
       
  3682         (_didFailProvisionalLoadWithErrorForFrame):
       
  3683         (_didCommitLoadForFrame):
       
  3684         (_didFinishLoadForFrame):
       
  3685         (_didFailLoadWithErrorForFrame):
       
  3686         (_didReceiveTitleForFrame):
       
  3687         (_didFirstLayoutForFrame):
       
  3688         (_didFirstVisuallyNonEmptyLayoutForFrame):
       
  3689         (_didBecomeUnresponsive):
       
  3690         (_didBecomeResponsive):
       
  3691         (_decidePolicyForNavigationAction):
       
  3692         (_decidePolicyForNewWindowAction):
       
  3693         (_createNewPage):
       
  3694         (_showPage):
       
  3695         (_closePage):
       
  3696         (_didNavigateWithNavigationData):
       
  3697         (_didPerformClientRedirect):
       
  3698         (_didPerformServerRedirect):
       
  3699         (_didUpdateHistoryTitle):
       
  3700         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
       
  3701         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
       
  3702         (_didClearWindowForFrame):
       
  3703         (_didCreatePage):
       
  3704         (_willDestroyPage):
       
  3705         (_didRecieveMessage):
       
  3706 
       
  3707 2010-06-24  Adam Barth  <abarth@webkit.org>
       
  3708 
       
  3709         Reviewed by Eric Seidel.
       
  3710 
       
  3711         commit-queue is taking too long to land patches because of red trees
       
  3712         https://bugs.webkit.org/show_bug.cgi?id=41194
       
  3713 
       
  3714         Instead of checking for the tree to be green, we'll just spin hot
       
  3715         trying to land patches.  This is probably too extreme in ignoring the
       
  3716         tree, but I think we should try it for a while to see if we have
       
  3717         trouble.  That will help us find the right balance.
       
  3718 
       
  3719         * Scripts/webkitpy/tool/commands/queues.py:
       
  3720         * Scripts/webkitpy/tool/commands/queues_unittest.py:
       
  3721 
       
  3722 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
       
  3723 
       
  3724         Reviewed by Xan Lopez.
       
  3725 
       
  3726         [GTK] Clean up the use of gdk_window_get_root_coords in EventSender
       
  3727         https://bugs.webkit.org/show_bug.cgi?id=40843
       
  3728 
       
  3729         Define the version for old GTK+s in a way that is forward-compatible
       
  3730         and clean up the logic a bit.
       
  3731 
       
  3732         * DumpRenderTree/gtk/EventSender.cpp:
       
  3733         (gdk_window_get_root_coords): Renamed and cleaned up.
       
  3734         (prepareMouseButtonEvent): Remove #ifdefs.
       
  3735         (mouseMoveToCallback): Remove #ifdefs.
       
  3736 
       
  3737 2010-06-24  Dimitri Glazkov  <dglazkov@chromium.org>
       
  3738 
       
  3739         Reviewed by Eric Seidel.
       
  3740 
       
  3741         Fix NewRunWebKitTests to work on Windows.
       
  3742         https://bugs.webkit.org/show_bug.cgi?id=41180
       
  3743 
       
  3744         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments,
       
  3745             because Windows fails to understand what we're asking of it.
       
  3746 
       
  3747 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
       
  3748 
       
  3749         Reviewed by Xan Lopez.
       
  3750 
       
  3751         [GTK] The url passed to the WebView during layout tests is invalid
       
  3752         https://bugs.webkit.org/show_bug.cgi?id=40832
       
  3753 
       
  3754         Set the test URL to the full real file URL and do a small cleanup.
       
  3755         Previously a URL like file://relative/path/to/test.html was passed
       
  3756         to the WebView. This malformed file URL would be returned by
       
  3757         webkit_web_view_get_url and webkit_web_frame_get_url.
       
  3758 
       
  3759         * DumpRenderTree/gtk/DumpRenderTree.cpp:
       
  3760         (shouldLogFrameLoadDelegates): Change to take a const string& as the argument.
       
  3761         (shouldOpenWebInspector): Change to take a const string& as the argument.
       
  3762         (shouldEnableDeveloperExtras): Change to take a const string& as the argument.
       
  3763         (runTest): Pass the full file:// URL to the view. Remove the superfluous url variable.
       
  3764 
       
  3765 2010-06-24  Sam Weinig  <sam@webkit.org>
       
  3766 
       
  3767         Reviewed by Anders Carlsson.
       
  3768 
       
  3769         Fix WebKitTestRunner Makefile typos.
       
  3770 
       
  3771         * WebKitTestRunner/Makefile:
       
  3772 
       
  3773 2010-06-24  Adele Peterson  <adele@apple.com>
       
  3774 
       
  3775         Reviewed by Eric Carlson.
       
  3776 
       
  3777         DumpRenderTree part of testing <rdar://problem/8093680> "Paste and Match Style" should fire paste events
       
  3778         https://bugs.webkit.org/show_bug.cgi?id=41085
       
  3779 
       
  3780         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
       
  3781         Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects.
       
  3782 
       
  3783 2010-06-23  Sam Weinig  <sam@webkit.org>
       
  3784 
       
  3785         Reviewed by Anders Carlsson.
       
  3786 
       
  3787         Patch for https://bugs.webkit.org/show_bug.cgi?id=41086
       
  3788         Add new WebKitTestRunner project (ie. DRT for WebKit2).
       
  3789 
       
  3790         - Mac only.
       
  3791         - run-webkit-tests has not been modified to call it yet.
       
  3792         - Only dumps the render tree at this time. 
       
  3793 
       
  3794         * WebKitTestRunner: Added.
       
  3795         * WebKitTestRunner/Configurations: Added.
       
  3796         * WebKitTestRunner/Configurations/Base.xcconfig: Added.
       
  3797         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added.
       
  3798         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added.
       
  3799         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added.
       
  3800         * WebKitTestRunner/InjectedBundle: Added.
       
  3801         * WebKitTestRunner/InjectedBundle-Info.plist: Added.
       
  3802         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added.
       
  3803         (_didStartProvisionalLoadForFrame):
       
  3804         (_didReceiveServerRedirectForProvisionalLoadForFrame):
       
  3805         (_didFailProvisionalLoadWithErrorForFrame):
       
  3806         (_didCommitLoadForFrame):
       
  3807         (_didFinishLoadForFrame):
       
  3808         (_didFailLoadWithErrorForFrame):
       
  3809         (_didReceiveTitleForFrame):
       
  3810         (_didClearWindow):
       
  3811         (_didCreatePage):
       
  3812         (_willDestroyPage):
       
  3813         (_didRecieveMessage):
       
  3814         (WKBundleInitialize):
       
  3815         * WebKitTestRunner/Makefile: Added.
       
  3816         * WebKitTestRunner/PlatformWebView.h: Added.
       
  3817         (WTR::PlatformWebView::platformView):
       
  3818         * WebKitTestRunner/TestController.cpp: Added.
       
  3819         (WTR::TestController::shared):
       
  3820         (WTR::TestController::TestController):
       
  3821         (WTR::TestController::initialize):
       
  3822         (WTR::TestController::runTest):
       
  3823         (WTR::TestController::runTestingServerLoop):
       
  3824         (WTR::TestController::run):
       
  3825         * WebKitTestRunner/TestController.h: Added.
       
  3826         (WTR::TestController::verbose):
       
  3827         (WTR::TestController::injectedBundlePath):
       
  3828         * WebKitTestRunner/TestInvocation.cpp: Added.
       
  3829         (WTR::createWKURL):
       
  3830         (WTR::TestInvocation::TestInvocation):
       
  3831         (WTR::TestInvocation::~TestInvocation):
       
  3832         (WTR::TestInvocation::invoke):
       
  3833         (WTR::TestInvocation::dump):
       
  3834         (WTR::TestInvocation::initializeMainWebView):
       
  3835         (WTR::TestInvocation::didStartProvisionalLoadForFrame):
       
  3836         (WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame):
       
  3837         (WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame):
       
  3838         (WTR::TestInvocation::didCommitLoadForFrame):
       
  3839         (WTR::TestInvocation::didFinishLoadForFrame):
       
  3840         (WTR::TestInvocation::didFailLoadForFrame):
       
  3841         (WTR::TestInvocation::renderTreeExternalRepresentationFunction):
       
  3842         (WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction):
       
  3843         * WebKitTestRunner/TestInvocation.h: Added.
       
  3844         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added.
       
  3845         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added.
       
  3846         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Added.
       
  3847         * WebKitTestRunner/mac: Added.
       
  3848         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Added.
       
  3849         (WTR::PlatformWebView::PlatformWebView):
       
  3850         (WTR::PlatformWebView::~PlatformWebView):
       
  3851         (WTR::PlatformWebView::page):
       
  3852         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
       
  3853         (WTR::TestInvocation::runUntil):
       
  3854         * WebKitTestRunner/mac/main.mm: Added.
       
  3855         (main):
       
  3856 
       
  3857 2010-06-24  Luiz Agostini  <luiz.agostini@openbossa.org>
       
  3858 
       
  3859         Unreviewed. Adding myself to the committers list.
       
  3860 
       
  3861         * Scripts/webkitpy/common/config/committers.py:
       
  3862 
       
  3863 2010-06-23  Kevin Ollivier  <kevino@theolliviers.com>
       
  3864 
       
  3865         [wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT.
       
  3866 
       
  3867         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
       
  3868         (LayoutTestController::isPageBoxVisible):
       
  3869         (LayoutTestController::pageAreaRectInPixels):
       
  3870         (LayoutTestController::preferredPageSizeInPixels):
       
  3871         * wx/build/settings.py:
       
  3872 
       
  3873 2010-06-23  James Robinson  <jamesr@chromium.org>
       
  3874 
       
  3875         Unreviewed.  Add my IRC handle to committers.py so the sheriffbot can yell at me.
       
  3876 
       
  3877         * Scripts/webkitpy/common/config/committers.py:
       
  3878 
       
  3879 2010-06-23  Kent Tamura  <tkent@chromium.org>
       
  3880 
       
  3881         Reviewed by Dimitri Glazkov.
       
  3882 
       
  3883         Correct Chromium test configuration
       
  3884         https://bugs.webkit.org/show_bug.cgi?id=41057
       
  3885 
       
  3886         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
       
  3887          - Add "--use-drt" option for NRWT. It is required for Chromium and
       
  3888            ignored for other platforms.
       
  3889          - Skip JSC test on Chromium
       
  3890         * BuildSlaveSupport/test-result-archive:
       
  3891           Add Chromium support.
       
  3892 
       
  3893 2010-06-23  Sam Weinig  <sam@webkit.org>
       
  3894 
       
  3895         Reviewed by Anders Carlsson.
       
  3896 
       
  3897         Fix for https://bugs.webkit.org/show_bug.cgi?id=41073
       
  3898         WebKit2: Flesh out more of the InjectedBundle client API
       
  3899 
       
  3900         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
       
  3901         (_didStartProvisionalLoadForFrame):
       
  3902         (_didReceiveServerRedirectForProvisionalLoadForFrame):
       
  3903         (_didFailProvisionalLoadWithErrorForFrame):
       
  3904         (_didCommitLoadForFrame):
       
  3905         (_didFinishLoadForFrame):
       
  3906         (_didFailLoadWithErrorForFrame):
       
  3907         (_didReceiveTitleForFrame):
       
  3908         (_didClearWindowForFrame):
       
  3909         (_didCreatePage):
       
  3910         (_willDestroyPage):
       
  3911         (WKBundleInitialize):
       
  3912 
       
  3913 2010-06-23  Yuzo Fujishima  <yuzo@google.com>
       
  3914 
       
  3915         Reviewed by Shinichiro Hamaji.
       
  3916 
       
  3917         Implement page format data programming interface.
       
  3918         Add methods for testing.
       
  3919         https://bugs.webkit.org/show_bug.cgi?id=37538
       
  3920 
       
  3921         * DumpRenderTree/LayoutTestController.cpp:
       
  3922         (parsePageNumber):
       
  3923         (isPageBoxVisibleCallback):
       
  3924         (pageAreaRectInPixelsCallback):
       
  3925         (preferredPageSizeInPixelsCallback):
       
  3926         (LayoutTestController::staticFunctions):
       
  3927         * DumpRenderTree/LayoutTestController.h:
       
  3928         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
       
  3929         (LayoutTestController::isPageBoxVisible):
       
  3930         (LayoutTestController::pageAreaRectInPixels):
       
  3931         (LayoutTestController::preferredPageSizeInPixels):
       
  3932         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
       
  3933         (LayoutTestController::isPageBoxVisible):
       
  3934         (LayoutTestController::pageAreaRectInPixels):
       
  3935         (LayoutTestController::preferredPageSizeInPixels):
       
  3936         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
       
  3937         (LayoutTestController::isPageBoxVisible):
       
  3938         (LayoutTestController::pageAreaRectInPixels):
       
  3939         (LayoutTestController::preferredPageSizeInPixels):
       
  3940 
       
  3941 2010-06-23  Sam Magnuson  <smagnuson@netflix.com>
       
  3942 
       
  3943         Reviewed by Shinichiro Hamaji.
       
  3944 
       
  3945         Follow proper convention for if/switch/while as I've discovered
       
  3946         them to be through my review processes.
       
  3947         https://bugs.webkit.org/show_bug.cgi?id=40723
       
  3948 
       
  3949         Modified test so that if( foo ) is not allowed as it appears not
       
  3950         to be the accepted convention.
       
  3951 
       
  3952         * Scripts/webkitpy/style/checkers/cpp.py:
       
  3953         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
       
  3954 
       
  3955 2010-06-22  Eric Seidel  <eric@webkit.org>
       
  3956 
       
  3957         Reviewed by Adam Barth.
       
  3958 
       
  3959         Run clean-header-guards to fix some header guards
       
  3960         https://bugs.webkit.org/show_bug.cgi?id=41044
       
  3961 
       
  3962         No functional changes, thus no tests.
       
  3963 
       
  3964         This entire change was generated by running
       
  3965         clean-header-guards, and then reverting changes
       
  3966         to files which shouldn't be changed.  Those which
       
  3967         are left all should be updated.
       
  3968 
       
  3969         Some of these changes are just fixing 755 permissions
       
  3970         to be 644, since it seems various files have the wrong
       
  3971         execute bit which don't need it.  clean-header-guards
       
  3972         made those (welcome) permission fixes unintentionally.
       
  3973 
       
  3974         * DumpRenderTree/chromium/WebThemeControlDRT.h:
       
  3975         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
       
  3976         * QtTestBrowser/fpstimer.h:
       
  3977 
       
  3978 2010-06-22  Adam Barth  <abarth@webkit.org>
       
  3979 
       
  3980         Reviewed by Eric Seidel.
       
  3981 
       
  3982         Rename HTMLDocumentParser to LegacyHTMLDocumentParser
       
  3983         https://bugs.webkit.org/show_bug.cgi?id=41043
       
  3984 
       
  3985         Update the hash.
       
  3986 
       
  3987         * Scripts/do-webcore-rename:
       
  3988 
       
  3989 2010-06-22  Sam Magnuson  <smagnuson@netflix.com>
       
  3990 
       
  3991         Reviewed by Shinichiro Hamaji.
       
  3992 
       
  3993         Follow proper convention for variable declaration spacing.
       
  3994         https://bugs.webkit.org/show_bug.cgi?id=40724
       
  3995 
       
  3996         Modified test so that 'int   a;' is not allowed.
       
  3997 
       
  3998         * Scripts/webkitpy/style/checkers/cpp.py:
       
  3999         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
       
  4000 
       
  4001 2010-06-22  Eric Seidel  <eric@webkit.org>
       
  4002 
       
  4003         Unreviewed.  Add Tony Gentilcore now that he's a committer.
       
  4004 
       
  4005         * Scripts/webkitpy/common/config/committers.py:
       
  4006 
       
  4007 2010-06-22  Eric Seidel  <eric@webkit.org>
       
  4008 
       
  4009         Reviewed by Adam Barth.
       
  4010 
       
  4011         Remove Gtk 64-Release bot from core since it's broken
       
  4012         https://bugs.webkit.org/show_bug.cgi?id=41022
       
  4013 
       
  4014         This bot alone has been responsible for more than 72 hours of
       
  4015         commit-queue blockage in the last week.  The bot is broken -- keeps
       
  4016         losing its display server or similar.  Until the Gtk folks can fix the
       
  4017         bot, we need to remove it from core.  The WebKit community can't keep
       
  4018         it green as is.
       
  4019 
       
  4020         * Scripts/webkitpy/common/net/buildbot.py:
       
  4021         * Scripts/webkitpy/common/net/buildbot_unittest.py:
       
  4022 
       
  4023 2010-06-21  Dumitru Daniliuc  <dumi@chromium.org>
       
  4024 
       
  4025         Reviewed by Eric Seidel.
       
  4026 
       
  4027         Fix the Windows build.
       
  4028         https://bugs.webkit.org/show_bug.cgi?id=40972
       
  4029 
       
  4030         * DumpRenderTree/win/ImageDiff.vcproj:
       
  4031 
       
  4032 2010-06-21  Prasad Tammana  <prasadt@chromium.org>
       
  4033 
       
  4034         Reviewed by Darin Adler, Dmitry Titov.
       
  4035 
       
  4036         DumpRenderTree should allow tests with modal dialogs
       
  4037         https://bugs.webkit.org/show_bug.cgi?id=35350
       
  4038 
       
  4039         * DumpRenderTree/LayoutTestController.cpp:
       
  4040         (abortModalCallback):
       
  4041         (LayoutTestController::staticFunctions):
       
  4042         * DumpRenderTree/LayoutTestController.h:
       
  4043         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
       
  4044         (LayoutTestController::abortModal):
       
  4045         Add abortModal method to LayoutTestController and make it available from script.
       
  4046 
       
  4047         * DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.
       
  4048         (-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
       
  4049         abortModal from when modal window closes.
       
  4050         (-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.
       
  4051 
       
  4052 2010-06-21  Simon Fraser  <simon.fraser@apple.com>
       
  4053 
       
  4054         Reviewed by Anders Carlsson.
       
  4055         
       
  4056         Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
       
  4057         https://bugs.webkit.org/show_bug.cgi?id=40948
       
  4058         
       
  4059         Have the script look in WebKit2.
       
  4060 
       
  4061         * Scripts/do-webcore-rename:
       
  4062 
       
  4063 2010-06-21  Robert Hogan  <robert@webkit.org>
       
  4064 
       
  4065         Reviewed by Kenneth Rohde Christiansen.
       
  4066 
       
  4067         [Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html
       
  4068 
       
  4069         It's a Mac-specific test so just add the required LayoutTestController
       
  4070         function as a no-op to avoid failing. Similar approach adopted by other
       
  4071         ports.
       
  4072 
       
  4073         https://bugs.webkit.org/show_bug.cgi?id=33344
       
  4074 
       
  4075         * DumpRenderTree/qt/LayoutTestControllerQt.h:
       
  4076         (LayoutTestController::addDisallowedURL):
       
  4077 
       
  4078 2010-06-21  Sam Weinig  <sam@webkit.org>
       
  4079 
       
  4080         Reviewed by Anders Carlsson.
       
  4081 
       
  4082         Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
       
  4083         Add message passing support to the WebKit2 API.
       
  4084 
       
  4085         - Add some test messages.
       
  4086 
       
  4087         * MiniBrowser/mac/AppDelegate.m:
       
  4088         (_didRecieveMessageFromInjectedBundle):
       
  4089         (-[BrowserAppDelegate init]):
       
  4090         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
       
  4091         (_didClearWindow):
       
  4092         (_didCreatePage):
       
  4093         (_didRecieveMessage):
       
  4094         (WKBundleInitialize):
       
  4095 
       
  4096 2010-06-21  Drew Wilson  <atwilson@chromium.org>
       
  4097 
       
  4098         Unreviewed.
       
  4099 
       
  4100         Rolling back 61551 and 61555 due to test failures.
       
  4101 
       
  4102         * DumpRenderTree/LayoutTestController.cpp:
       
  4103         (LayoutTestController::staticFunctions):
       
  4104         * DumpRenderTree/LayoutTestController.h:
       
  4105         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
       
  4106         (LayoutTestController::setEditingBehavior):
       
  4107         * DumpRenderTree/mac/UIDelegate.mm:
       
  4108 
       
  4109 2010-06-21  Anders Carlsson  <andersca@apple.com>
       
  4110 
       
  4111         Reviewed by Sam Weinig.
       
  4112 
       
  4113         Make DumpRenderTree build with clang++
       
  4114 
       
  4115         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
       
  4116         (-[LocalPasteboard setPropertyList:forType:]):
       
  4117         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
       
  4118         (-[DumpRenderTreeWindow keyDown:]):
       
  4119         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
       
  4120         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
       
  4121         (LayoutTestController::isCommandEnabled):
       
  4122 
       
  4123 2010-06-21  Satish Sampath  <satish@chromium.org>
       
  4124 
       
  4125         Reviewed by Steve Block.
       
  4126 
       
  4127         Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
       
  4128         https://bugs.webkit.org/show_bug.cgi?id=40878
       
  4129 
       
  4130         * Scripts/build-webkit:
       
  4131 
       
  4132 2010-06-21  Kent Tamura  <tkent@chromium.org>
       
  4133 
       
  4134         Reviewed by Dimitri Glazkov.
       
  4135 
       
  4136         [DRT/Chromium] Initialization for http/tests/loading/
       
  4137         https://bugs.webkit.org/show_bug.cgi?id=40902
       
  4138 
       
  4139         * DumpRenderTree/chromium/TestShell.cpp:
       
  4140         (TestShell::runFileTest):
       
  4141 
       
  4142 2010-06-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
       
  4143 
       
  4144         Unreviewed.
       
  4145 
       
  4146         Adding myself to the committers list.
       
  4147 
       
  4148         * Scripts/webkitpy/common/config/committers.py:
       
  4149 
       
  4150 2010-06-20  Kent Tamura  <tkent@chromium.org>
       
  4151 
       
  4152         Reviewed by Dimitri Glazkov.
       
  4153 
       
  4154         [DRT/Chromium] Add --allow-external-pages option
       
  4155         https://bugs.webkit.org/show_bug.cgi?id=40762
       
  4156 
       
  4157         Add --allow-external-pages introduced by Chromium r45403.
       
  4158         http://src.chromium.org/viewvc/chrome?view=rev&revision=45403
       
  4159 
       
  4160         * DumpRenderTree/chromium/DumpRenderTree.cpp:
       
  4161         (main):
       
  4162         * DumpRenderTree/chromium/TestShell.cpp:
       
  4163         (TestShell::TestShell):
       
  4164         * DumpRenderTree/chromium/TestShell.h:
       
  4165         (TestShell::allowExternalPages):
       
  4166         (TestShell::setAllowExternalPages):
       
  4167         * DumpRenderTree/chromium/WebViewHost.cpp:
       
  4168         (WebViewHost::willSendRequest):
       
  4169 
       
  4170 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
       
  4171 
       
  4172         Reviewed by Adam Barth.
       
  4173 
       
  4174         Sheriffbot: Should allow "r" in SVN_REVISION
       
  4175         https://bugs.webkit.org/show_bug.cgi?id=40889
       
  4176 
       
  4177         * Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
       
  4178         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
       
  4179 
       
  4180 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
       
  4181 
       
  4182         Reviewed by Dimitri Glazkov.
       
  4183 
       
  4184         Python Tests Fail after r61508
       
  4185         https://bugs.webkit.org/show_bug.cgi?id=40891
       
  4186 
       
  4187         Test's regex list needed to be updated to match the new
       
  4188         regex list in the source code. Added new bots to the
       
  4189         example_buildbots list.
       
  4190 
       
  4191         Regex list fixed in r61512. Updated bot list.
       
  4192 
       
  4193         * Scripts/webkitpy/common/net/buildbot_unittest.py:
       
  4194 
       
  4195 2010-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
       
  4196 
       
  4197         Unreviewed, build fix.
       
  4198 
       
  4199         Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508.
       
  4200 
       
  4201         * Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
       
  4202 
       
  4203 2010-06-19  Justin Schuh  <jschuh@chromium.org>
       
  4204 
       
  4205         Unreviewed.
       
  4206 
       
  4207         Adding myself to the committers list.
       
  4208 
       
  4209         * Scripts/webkitpy/common/config/committers.py:
       
  4210 
       
  4211 2010-06-19  Sam Weinig  <sam@webkit.org>
       
  4212 
       
  4213         Reviewed by Anders Carlsson.
       
  4214 
       
  4215         Fix for https://bugs.webkit.org/show_bug.cgi?id=40882
       
  4216         Add ability to have a WebProcess per WebContext.
       
  4217 
       
  4218         Move to use new shared contexts API.
       
  4219 
       
  4220         * MiniBrowser/mac/AppDelegate.h:
       
  4221         * MiniBrowser/mac/AppDelegate.m:
       
  4222         (-[BrowserAppDelegate init]):
       
  4223         (-[BrowserAppDelegate getCurrentPageNamespace]):
       
  4224         (-[BrowserAppDelegate validateMenuItem:]):
       
  4225         (-[BrowserAppDelegate _setProcessModel:]):
       
  4226         (-[BrowserAppDelegate setSharedProcessProcessModel:]):
       
  4227         (-[BrowserAppDelegate setSharedThreadProcessModel:]):
       
  4228         * MiniBrowser/win/BrowserView.cpp:
       
  4229         (BrowserView::create):
       
  4230 
       
  4231 2010-06-02  Robert Hogan  <robert@webkit.org>
       
  4232 
       
  4233         Reviewed by Adam Barth.
       
  4234 
       
  4235         [Qt] Support evaluateScriptInIsolatedWorld()
       
  4236 
       
  4237         https://bugs.webkit.org/show_bug.cgi?id=40079
       
  4238 
       
  4239         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
       
  4240         (LayoutTestController::evaluateScriptInIsolatedWorld):
       
  4241         * DumpRenderTree/qt/LayoutTestControllerQt.h:
       
  4242 
       
  4243 2010-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
       
  4244 
       
  4245         Reviewed by Darin Adler.
       
  4246 
       
  4247         Add three more non-core Chromium builders to start testing DumpRenderTree.
       
  4248         https://bugs.webkit.org/show_bug.cgi?id=40335
       
  4249 
       
  4250         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
       
  4251 
       
  4252 2010-06-18  Drew Wilson  <atwilson@chromium.org>
       
  4253 
       
  4254         Reviewed by Darin Fisher.
       
  4255 
       
  4256         [Chromium] Plumbing for top-level frame names
       
  4257         https://bugs.webkit.org/show_bug.cgi?id=40430
       
  4258 
       
  4259         * DumpRenderTree/chromium/WebViewHost.cpp:
       
  4260         (WebViewHost::reset):
       
  4261         Changed obsolete call to clearName() to use setName(WebString()) instead.
       
  4262 
       
  4263 2010-06-18  Sam Weinig  <weinig@apple.com>
       
  4264 
       
  4265         Rolling http://trac.webkit.org/changeset/61297 back in.
       
  4266 
       
  4267         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
       
  4268         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
       
  4269         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.
       
  4270         (_didClearWindow):
       
  4271         (_didCreatePage):
       
  4272         (WKBundleInitialize):
       
  4273 
       
  4274 2010-06-18  Alexey Proskuryakov  <ap@apple.com>
       
  4275 
       
  4276         Reviewed by Darin Adler.
       
  4277 
       
  4278         https://bugs.webkit.org/show_bug.cgi?id=40803
       
  4279         TestNetscapePlugin has an incorrect implementation of "property" property
       
  4280 
       
  4281         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't
       
  4282         pass a static string back, it's going to be released by NPAPI implementation.
       
  4283 
       
  4284 2010-06-18  Leandro Pereira  <leandro@profusion.mobi>
       
  4285 
       
  4286         Unreviewed.
       
  4287 
       
  4288         Adding myself to the committers list.
       
  4289 
       
  4290         * Scripts/webkitpy/common/config/committers.py:
       
  4291 
       
  4292 2010-06-17  Tony Chang  <tony@chromium.org>
       
  4293 
       
  4294         Reviewed by Kent Tamura.
       
  4295 
       
  4296         [chromium] cleanup redundant DEPS value and remove buildbot cleanup code
       
  4297         https://bugs.webkit.org/show_bug.cgi?id=40615
       
  4298 
       
  4299         * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
       
  4300 
       
  4301 2010-06-17  Ada Chan  <adachan@apple.com>
       
  4302 
       
  4303         Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
       
  4304 
       
  4305         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
       
  4306         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
       
  4307         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
       
  4308 
       
  4309 2010-06-17  Darin Adler  <darin@apple.com>
       
  4310 
       
  4311         One more try at fix for Chromium build.
       
  4312 
       
  4313         * DumpRenderTree/chromium/TestShell.cpp:
       
  4314         (TestShell::TestShell): Use set again instead of =.
       
  4315 
       
  4316 2010-06-17  Darin Adler  <darin@apple.com>
       
  4317 
       
  4318         Fix Chromium build.
       
  4319 
       
  4320         I didn't realize that neither Chromium nor Qt share the DumpRenderTree
       
  4321         code with all the other platforms! Wow, that should be fixed at some point.
       
  4322 
       
  4323         * DumpRenderTree/chromium/TestShell.cpp:
       
  4324         (TestShell::TestShell): Changed back to using "new".
       
  4325         * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
       
  4326 
       
  4327 2010-06-17  Simon Hausmann  <simon.hausmann@nokia.com>
       
  4328 
       
  4329         Unreviewed Qt build fix.
       
  4330 
       
  4331         LayoutTestController in the Qt DRT is not using refs :)
       
  4332 
       
  4333         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
       
  4334         (WebCore::DumpRenderTree::DumpRenderTree):
       
  4335 
       
  4336 2010-06-17  Darin Adler  <darin@apple.com>
       
  4337 
       
  4338         Reviewed by Sam Weinig.
       
  4339 
       
  4340         Use adoptRef and create functions in more code paths
       
  4341         https://bugs.webkit.org/show_bug.cgi?id=40760
       
  4342 
       
  4343         * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
       
  4344 
       
  4345         * DumpRenderTree/LayoutTestController.cpp:
       
  4346         (LayoutTestController::create): Added.
       
  4347         * DumpRenderTree/LayoutTestController.h: Declare the create function.
       
  4348 
       
  4349         * DumpRenderTree/chromium/TestShell.cpp:
       
  4350         (TestShell::TestShell): Use create instead of new.
       
  4351         * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
       
  4352 
       
  4353         * DumpRenderTree/gtk/DumpRenderTree.cpp:
       
  4354         (runTest): Use RefPtr and create instead of OwnPtr and new.
       
  4355 
       
  4356         * DumpRenderTree/mac/DumpRenderTree.mm:
       
  4357         (runTest): Use RefPtr and create instead of OwnPtr and new.
       
  4358 
       
  4359         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
       
  4360         (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
       
  4361         instead of new.
       
  4362 
       
  4363         * DumpRenderTree/win/DumpRenderTree.cpp:
       
  4364         (runTest): Use RefPtr and create instead of OwnPtr and new.
       
  4365 
       
  4366         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
       
  4367         (runTest): Use RefPtr and create instead of OwnPtr and new.
       
  4368         (MyApp::OnInit): Removed unneeded code to delete the layout
       
  4369         test controller. This is done during each test.
       
  4370 
       
  4371 2010-06-17  Kent Tamura  <tkent@chromium.org>
       
  4372 
       
  4373         Reviewed by Shinichiro Hamaji.
       
  4374 
       
  4375         [DRT/Chromium] Fix a bug of Windows pixel tests
       
  4376         https://bugs.webkit.org/show_bug.cgi?id=40763
       
  4377 
       
  4378         * DumpRenderTree/chromium/TestEventPrinter.cpp:
       
  4379         (TestShellPrinter::handleImage):
       
  4380 
       
  4381 2010-06-16  Kent Tamura  <tkent@chromium.org>
       
  4382 
       
  4383         Reviewed by Shinichiro Hamaji.
       
  4384 
       
  4385         [DRT/Chromium] Fix crash on Mac Release
       
  4386         https://bugs.webkit.org/show_bug.cgi?id=40759
       
  4387 
       
  4388         * DumpRenderTree/chromium/WebViewHost.cpp:
       
  4389         (WebViewHost::paintRect): We should not use m_canvas directly because
       
  4390           it is created lazily in canvas().
       
  4391 
       
  4392 2010-06-16  Kevin Ollivier  <kevino@theolliviers.com>
       
  4393 
       
  4394         [wx] Build fix after new method addition.
       
  4395 
       
  4396         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
       
  4397         (LayoutTestController::pageProperty):
       
  4398 
       
  4399 2010-06-16  Kent Tamura  <tkent@chromium.org>
       
  4400 
       
  4401         Reviewed by Dimitri Glazkov.
       
  4402 
       
  4403         [DRT/Chromium] Set current working directory for each of tests
       
  4404         https://bugs.webkit.org/show_bug.cgi?id=40668
       
  4405 
       
  4406         This change fixes tests with eventSender.beginDragWithFiles().
       
  4407 
       
  4408         * DumpRenderTree/chromium/DumpRenderTree.cpp:
       
  4409         (runTest):
       
  4410 
       
  4411 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
       
  4412 
       
  4413         Reviewed by Gustavo Noronha Silva.
       
  4414 
       
  4415         [GTK] r60803 broke media/controls-drag-timebar.html
       
  4416         https://bugs.webkit.org/show_bug.cgi?id=40269
       
  4417 
       
  4418         Only queue events while the mouse button is down, if drag mode is enabled. Some
       
  4419         tests may disable drag mode, to prevent the queuing of events in this situation.
       
  4420 
       
  4421         * DumpRenderTree/gtk/EventSender.cpp:
       
  4422         (sendOrQueueEvent): Only queue events here if dragMode is true.
       
  4423 
       
  4424 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
       
  4425 
       
  4426         Reviewed by Gustavo Noronha Silva.
       
  4427 
       
  4428         [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
       
  4429         https://bugs.webkit.org/show_bug.cgi?id=40600
       
  4430 
       
  4431         * DumpRenderTree/gtk/EventSender.cpp:
       
  4432         (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
       
  4433 
       
  4434 2010-06-16  Adam Barth  <abarth@webkit.org>
       
  4435 
       
  4436         Reviewed by Dimitri Glazkov.
       
  4437 
       
  4438         Add a hidden land-cowboy command to webkit-patch to help land quick
       
  4439         build fixes.
       
  4440 
       
  4441         * Scripts/webkitpy/tool/commands/download.py:
       
  4442         * Scripts/webkitpy/tool/steps/preparechangelog.py:
       
  4443 
       
  4444 2010-06-16  Adam Roben  <aroben@apple.com>
       
  4445 
       
  4446         Convert console messages to UTF-8 before printing them
       
  4447 
       
  4448         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
       
  4449         http/tests/security/xssAuditor/embed-tag-null-char.html and
       
  4450         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
       
  4451         Windows. (I can't test the fix because Apache is crashing on my
       
  4452         computer.)
       
  4453 
       
  4454         Reviewed by Alexey Proskuryakov.
       
  4455 
       
  4456         * DumpRenderTree/win/DumpRenderTree.cpp:
       
  4457         (toUTF8): Extracted the code into an overload that takes a wide string
       
  4458         and a length, then added an overload that takes a wstring.
       
  4459 
       
  4460         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
       
  4461         overload.
       
  4462 
       
  4463         * DumpRenderTree/win/UIDelegate.cpp:
       
  4464         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
       
  4465         UTF-8 instead of letting printf convert to the current code page.
       
  4466 
       
  4467 2010-06-16  Drew Wilson  <atwilson@chromium.org>
       
  4468 
       
  4469         Reviewed by Kent Tamura.
       
  4470 
       
  4471         [Chromium] Plumbing for top-level frame names
       
  4472         https://bugs.webkit.org/show_bug.cgi?id=40430
       
  4473 
       
  4474         * DumpRenderTree/chromium/WebViewHost.cpp:
       
  4475         (WebViewHost::createView):
       
  4476         Migrate to new createView() API.
       
  4477         * DumpRenderTree/chromium/WebViewHost.h:
       
  4478         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
       
  4479 
       
  4480 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
       
  4481 
       
  4482         Reviewed by Kenneth Rohde Christiansen.
       
  4483 
       
  4484         [Qt] Scroll wheel event support to graphics based DRT
       
  4485         https://bugs.webkit.org/show_bug.cgi?id=40577
       
  4486 
       
  4487         * DumpRenderTree/qt/EventSenderQt.cpp:
       
  4488         (EventSender::continuousMouseScrollBy):
       
  4489         (EventSender::createGraphicsSceneWheelEvent):
       
  4490         * DumpRenderTree/qt/EventSenderQt.h:
       
  4491 
       
  4492 2010-06-16  Adam Roben  <aroben@apple.com>
       
  4493 
       
  4494         Remove a stray newline from the Windows version of TestNetscapePlugin
       
  4495 
       
  4496         Reviewed by Alexey Proskuryakov.
       
  4497 
       
  4498         Fixes <http://webkit.org/b/40728>
       
  4499         plugins/geturlnotify-during-document-teardown.html fails on Windows
       
  4500 
       
  4501         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
       
  4502         (NPP_Destroy): Removed extra newline that the Mac version doesn't
       
  4503         have.
       
  4504 
       
  4505 2010-06-16  Adam Roben  <aroben@apple.com>
       
  4506 
       
  4507         Respect LayoutTestController::isPrinting on Windows
       
  4508 
       
  4509         This gets some printing tests closer to passing (like
       
  4510         printing/page-rule-in-media-query.html).
       
  4511 
       
  4512         Fixes <http://webkit.org/b/40727>.
       
  4513 
       
  4514         Reviewed by Dan Bernstein.
       
  4515 
       
  4516         * DumpRenderTree/win/DumpRenderTree.cpp:
       
  4517         (dump): Pass LayoutTestController::isPrinting to
       
  4518         IWebFramePrivate::renderTreeAsExternalRepresentation.
       
  4519 
       
  4520 2010-06-15  Adam Barth  <abarth@webkit.org>
       
  4521 
       
  4522         Reviewed by Eric Seidel.
       
  4523 
       
  4524         Enable HTML5 lexer
       
  4525         https://bugs.webkit.org/show_bug.cgi?id=40650
       
  4526 
       
  4527         * DumpRenderTree/mac/DumpRenderTree.mm:
       
  4528         (initializeGlobalsFromCommandLineOptions):
       
  4529 
       
  4530 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
       
  4531 
       
  4532         Reviewed by Shinichiro Hamaji.
       
  4533 
       
  4534         Implement render style selection for pages to support CSS3 Paged Media.
       
  4535         https://bugs.webkit.org/show_bug.cgi?id=35961
       
  4536 
       
  4537         * DumpRenderTree/LayoutTestController.cpp:
       
  4538         (parsePagePropertyParameters):
       
  4539         (pagePropertyCallback):
       
  4540         (LayoutTestController::staticFunctions):
       
  4541         * DumpRenderTree/LayoutTestController.h:
       
  4542         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
       
  4543         (LayoutTestController::pageProperty):
       
  4544         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
       
  4545         (LayoutTestController::pageProperty):
       
  4546         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
       
  4547         (LayoutTestController::pageProperty):
       
  4548 
       
  4549 2010-06-15  Sam Weinig  <sam@webkit.org>
       
  4550 
       
  4551         Reviewed by Anders Carlsson.
       
  4552 
       
  4553         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
       
  4554         WebKit2: Add mechanism to inject code into the WebProcess on startup
       
  4555 
       
  4556         Add initial InjectedBundle support.
       
  4557 
       
  4558         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
       
  4559         * MiniBrowser/WebBundle-Info.plist: Added.
       
  4560         Add test InjectedBundle to the project.
       
  4561 
       
  4562         * MiniBrowser/mac/AppDelegate.m:
       
  4563         (-[BrowserAppDelegate init]):
       
  4564         Get the path to the WebBundle from the the main bundle and pass it to the new
       
  4565         WKContextCreateWithInjectedBundlePath function.
       
  4566 
       
  4567         * MiniBrowser/mac/BrowserWindowController.m:
       
  4568         (_didChangeProgress):
       
  4569         Fix the build.  This has been broken for a while.
       
  4570 
       
  4571         * MiniBrowser/mac/WebBundle: Added.
       
  4572         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
       
  4573         (_didCreatePage):
       
  4574         (WKBundleInitialize):
       
  4575         Add really basic InjectedBundle.
       
  4576 
       
  4577         * MiniBrowser/win/BrowserView.cpp:
       
  4578         (BrowserView::create):
       
  4579         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
       
  4580 
       
  4581 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
       
  4582 
       
  4583         Reviewed by Darin Adler.
       
  4584 
       
  4585         Adding myself to the reviewers list.
       
  4586         https://bugs.webkit.org/show_bug.cgi?id=40693
       
  4587 
       
  4588         * Scripts/webkitpy/common/config/committers.py:
       
  4589 
       
  4590 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
       
  4591 
       
  4592         Reviewed by Xan Lopez.
       
  4593 
       
  4594         Switch to using GIO methods instead of realpath in GtkLauncher to determine
       
  4595         the file URI. This should remove warnings about realpath being undefined
       
  4596         when compiling with '-ansi'.
       
  4597 
       
  4598         * GtkLauncher/main.c:
       
  4599         (filenameToURL): Use GIO instead of realpath to determine file URI.
       
  4600 
       
  4601 2010-06-15  Adam Roben  <aroben@apple.com>
       
  4602 
       
  4603         Remove the redundant set-apple-windows-environment-variables script
       
  4604 
       
  4605         Apparently update-webkit does this for you these days.
       
  4606 
       
  4607         Rubber-stamped by Steve Falkenburg.
       
  4608 
       
  4609         * Scripts/set-apple-windows-environment-variables: Removed.
       
  4610 
       
  4611 2010-06-14  Adam Roben  <aroben@apple.com>
       
  4612 
       
  4613         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
       
  4614         environment variables
       
  4615 
       
  4616         Fixes <http://webkit.org/b/40595>.
       
  4617 
       
  4618         Reviewed by Steve Falkenburg.
       
  4619 
       
  4620         * Scripts/set-apple-windows-environment-variables: Added.
       
  4621         (to_windows_path): Passes the passed-in path through cygpath to
       
  4622         generate a Windows-style path.
       
  4623         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
       
  4624         variables to their defaults, if they aren't already set.
       
  4625 
       
  4626 2010-06-14  Adam Roben  <aroben@apple.com>
       
  4627 
       
  4628         Speed up run-safari/debug-safari on Windows
       
  4629 
       
  4630         Fixes <http://webkit.org/b/40586>.
       
  4631 
       
  4632         Reviewed by Steve Falkenburg.
       
  4633 
       
  4634         * Scripts/webkitdirs.pm:
       
  4635         (runSafari): When debugging, set up the environment to run Safari
       
  4636         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
       
  4637         actually launch the debugger. When not debugging, just run WebKit.exe
       
  4638         and it will do the rest for us.
       
  4639 
       
  4640 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
       
  4641 
       
  4642         Reviewed by Kenneth Rohde Christiansen.
       
  4643 
       
  4644         [Qt] DRT EventSender support to graphics context events
       
  4645         https://bugs.webkit.org/show_bug.cgi?id=40324
       
  4646 
       
  4647         * DumpRenderTree/qt/EventSenderQt.cpp:
       
  4648         (EventSender::contextClick):
       
  4649 
       
  4650 2010-06-14  Tony Chang  <tony@chromium.org>
       
  4651 
       
  4652         Reviewed by Darin Fisher.
       
  4653 
       
  4654         [chromium] checkout chromium third_party directly
       
  4655         https://bugs.webkit.org/show_bug.cgi?id=40556
       
  4656 
       
  4657         * Scripts/update-webkit-chromium: some migration code for the bots
       
  4658 
       
  4659 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
       
  4660 
       
  4661         Chromium build fix.
       
  4662 
       
  4663         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
       
  4664         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
       
  4665 
       
  4666 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
       
  4667 
       
  4668         Reviewed by Darin Adler.
       
  4669 
       
  4670         https://bugs.webkit.org/show_bug.cgi?id=40529
       
  4671         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
       
  4672 
       
  4673         * DumpRenderTree/mac/EventSendingController.mm:
       
  4674         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
       
  4675         event for "delete" - it had virtual key code from forward delete, and text from backspace.
       
  4676         Fixed "delete" to mean forward delete.
       
  4677 
       
  4678         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
       
  4679         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
       
  4680         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
       
  4681         Mac DRT confusion has propagated to other platforms, fixing those.
       
  4682 
       
  4683 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
       
  4684 
       
  4685         Reviewed by Xan Lopez.
       
  4686 
       
  4687         Small GtkLauncher build fix for some systems.
       
  4688 
       
  4689         * GtkLauncher/main.c: Add <limit.h> include.
       
  4690 
       
  4691 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
       
  4692 
       
  4693         Reviewed by Laszlo Gombos.
       
  4694 
       
  4695         [Qt] navigator.geolocation support for Qt port
       
  4696         https://bugs.webkit.org/show_bug.cgi?id=39724
       
  4697 
       
  4698         Implementation for geolocation cases to DumpRenderTreeQt
       
  4699 
       
  4700         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
       
  4701         (WebCore::WebPage::allowGeolocationRequest):
       
  4702         * DumpRenderTree/qt/DumpRenderTreeQt.h:
       
  4703         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
       
  4704         (LayoutTestController::setGeolocationPermission):
       
  4705         (LayoutTestController::setMockGeolocationError):
       
  4706         (LayoutTestController::setMockGeolocationPosition):
       
  4707         * DumpRenderTree/qt/LayoutTestControllerQt.h:
       
  4708         (LayoutTestController::isGeolocationPermissionSet):
       
  4709         (LayoutTestController::geolocationPermission):
       
  4710 
       
  4711 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
       
  4712 
       
  4713         Reviewed by Darin Adler.
       
  4714 
       
  4715         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
       
  4716         be a way of overwriting the Xcode system path.  Making
       
  4717         $WEBKITOUTPUTDIR take precedence over the system default would make
       
  4718         this possible.
       
  4719 
       
  4720         * Scripts/webkitdirs.pm:
       
  4721 
       
  4722 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
       
  4723 
       
  4724         Reviewed by Darin Adler.
       
  4725 
       
  4726         AX: link won't return linked element if URL contains #
       
  4727         https://bugs.webkit.org/show_bug.cgi?id=40192
       
  4728 
       
  4729         * DumpRenderTree/AccessibilityUIElement.cpp:
       
  4730         (linkedUIElementAtIndexCallback):
       
  4731         (AccessibilityUIElement::getJSClass):
       
  4732         * DumpRenderTree/AccessibilityUIElement.h:
       
  4733         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
       
  4734         (AccessibilityUIElement::linkedUIElementAtIndex):
       
  4735         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
       
  4736         (AccessibilityUIElement::linkedUIElementAtIndex):
       
  4737         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
       
  4738         (AccessibilityUIElement::linkedUIElementAtIndex):
       
  4739 
       
  4740 2010-06-13  Adam Barth  <abarth@webkit.org>
       
  4741 
       
  4742         Reviewed by Darin Adler.
       
  4743 
       
  4744         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
       
  4745         https://bugs.webkit.org/show_bug.cgi?id=39550
       
  4746 
       
  4747         This can cause an extra request to bugs.webkit.org durig upload, but it
       
  4748         shouldn't be too bad.  Also, this won't work if you remove the
       
  4749         boilerplate created by prepare-ChangeLog.
       
  4750 
       
  4751         * Scripts/webkitpy/common/checkout/changelog.py:
       
  4752         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
       
  4753         * Scripts/webkitpy/common/net/bugzilla.py:
       
  4754         * Scripts/webkitpy/tool/steps/abstractstep.py:
       
  4755         * Scripts/webkitpy/tool/steps/preparechangelog.py:
       
  4756         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
       
  4757 
       
  4758 2010-06-08  Robert Hogan  <robert@webkit.org>
       
  4759 
       
  4760         Reviewed by Eric Seidel.
       
  4761 
       
  4762         [Qt] Add support for callShouldCloseOnWebView() to DRT
       
  4763         https://bugs.webkit.org/show_bug.cgi?id=40330
       
  4764 
       
  4765         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
       
  4766         (LayoutTestController::callShouldCloseOnWebView):
       
  4767         * DumpRenderTree/qt/LayoutTestControllerQt.h:
       
  4768         (LayoutTestController::setCallCloseOnWebViews):
       
  4769 
       
  4770 2010-06-12  Eric Seidel  <eric@webkit.org>
       
  4771 
       
  4772         Reviewed by Daniel Bates.
       
  4773 
       
  4774         do-webcore-rename should have a --verbose option
       
  4775         https://bugs.webkit.org/show_bug.cgi?id=40497
       
  4776 
       
  4777         * Scripts/do-webcore-rename:
       
  4778          - Unified how we handle skipping files/directories
       
  4779            this will allow us to "black list" certain files and
       
  4780            directories when performing renames.
       
  4781          - Made do-webcore-rename log what it's skipping when passed --verbose.
       
  4782 
       
  4783 2010-06-12  Darin Adler  <darin@apple.com>
       
  4784 
       
  4785         * Scripts/run-bindings-tests: Fixed a typo in a message.
       
  4786 
       
  4787 2010-06-12  Kent Tamura  <tkent@chromium.org>
       
  4788 
       
  4789         Reviewed by Dimitri Glazkov.
       
  4790 
       
  4791         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
       
  4792         https://bugs.webkit.org/show_bug.cgi?id=40402
       
  4793 
       
  4794         _build_path() of each Chromium port check existence of build path
       
  4795         of Chromium checkout first, then check existence of build path of
       
  4796         WebKit-only checkout.
       
  4797 
       
  4798         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
       
  4799         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
       
  4800         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
       
  4801 
       
  4802 2010-06-12  Robert Hogan  <robert@webkit.org>
       
  4803 
       
  4804         Reviewed by Kenneth Rohde Christiansen.
       
  4805 
       
  4806         [Qt] Back-forward list dumping is incorrect
       
  4807 
       
  4808         https://bugs.webkit.org/show_bug.cgi?id=36392
       
  4809 
       
  4810         Support dumping child history items in DRT.
       
  4811 
       
  4812         Unskip:
       
  4813 
       
  4814         fast/loader/frame-src-change-added-to-history.html
       
  4815         fast/loader/frame-src-change-not-added-to-history.html
       
  4816         fast/loader/frame-location-change-not-added-to-history.html
       
  4817 
       
  4818         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
       
  4819         (WebCore::dumpHistoryItem):
       
  4820 
       
  4821 2010-06-10  Ojan Vafai  <ojan@chromium.org>
       
  4822 
       
  4823         Reviewed by Eric Seidel.
       
  4824 
       
  4825         upload all patches that lack in-rietveld to rietveld
       
  4826         https://bugs.webkit.org/show_bug.cgi?id=40444
       
  4827 
       
  4828         If it's a patch, then we'll try to upload it as long as it
       
  4829         doesn't have in-rietveld set. No longer set in-rietveld? since
       
  4830         it's not needed.
       
  4831 
       
  4832         * Scripts/webkitpy/common/net/bugzilla.py:
       
  4833 
       
  4834 2010-06-10  Ojan Vafai  <ojan@chromium.org>
       
  4835 
       
  4836         Reviewed by Darin Fisher.
       
  4837 
       
  4838         Fix rietveld upload when message length > 100 characters
       
  4839         https://bugs.webkit.org/show_bug.cgi?id=40457
       
  4840 
       
  4841         * Scripts/webkitpy/common/net/rietveld.py:
       
  4842 
       
  4843 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
       
  4844 
       
  4845         Reviewed by Laszlo Gombos.
       
  4846 
       
  4847         [Qt] There should be a way to enable popups in QtTestBrowser
       
  4848         https://bugs.webkit.org/show_bug.cgi?id=40427
       
  4849 
       
  4850         * QtTestBrowser/main.cpp:
       
  4851         (LauncherWindow::toggleJavascriptCanOpenWindows):
       
  4852         (LauncherWindow::createChrome):
       
  4853 
       
  4854 2010-06-10  Adam Barth  <abarth@webkit.org>
       
  4855 
       
  4856         Reviewed by Daniel Bates.
       
  4857 
       
  4858         Make SheriffBot more chatty
       
  4859         https://bugs.webkit.org/show_bug.cgi?id=40463
       
  4860 
       
  4861         People seem to like to talk to SheriffBot, so let's make him chat back.
       
  4862 
       
  4863         * Scripts/webkitpy/thirdparty/__init__.py:
       
  4864         * Scripts/webkitpy/tool/bot/irc_command.py:
       
  4865         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
       
  4866         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
       
  4867         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
       
  4868 
       
  4869 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
       
  4870 
       
  4871         Reviewed by Darin Adler.
       
  4872 
       
  4873         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
       
  4874         
       
  4875         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
       
  4876         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
       
  4877         WEXITSTATUS on $result instead of just comparing $result to 0.
       
  4878 
       
  4879         * Scripts/update-webkit-auxiliary-libs:
       
  4880 
       
  4881 2010-06-10  Ojan Vafai  <ojan@chromium.org>
       
  4882 
       
  4883         Reviewed by Alexey Proskuryakov.
       
  4884 
       
  4885         don't use Exception.message as it's deprecated in python 2.6+
       
  4886         https://bugs.webkit.org/show_bug.cgi?id=40449
       
  4887 
       
  4888         * Scripts/webkitpy/tool/commands/queues.py:
       
  4889 
       
  4890 2010-06-10  Ojan Vafai  <ojan@chromium.org>
       
  4891 
       
  4892         Reviewed by Adam Barth.
       
  4893 
       
  4894         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
       
  4895         https://bugs.webkit.org/show_bug.cgi?id=40436
       
  4896 
       
  4897         * Scripts/webkitpy/common/system/outputcapture.py:
       
  4898         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
       
  4899         * Scripts/webkitpy/tool/commands/queues.py:
       
  4900         * Scripts/webkitpy/tool/commands/queues_unittest.py:
       
  4901         * Scripts/webkitpy/tool/commands/queuestest.py:
       
  4902         * Scripts/webkitpy/tool/mocktool.py:
       
  4903 
       
  4904 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
       
  4905 
       
  4906         Reviewed by Simon Hausmann.
       
  4907 
       
  4908         [Qt] *All* WebGL layout tests fail!
       
  4909         https://bugs.webkit.org/show_bug.cgi?id=40296
       
  4910 
       
  4911         Added test for WebKitWebGLEnabled to
       
  4912         LayoutTestController::overridePreference().
       
  4913 
       
  4914         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
       
  4915         (LayoutTestController::overridePreference):
       
  4916 
       
  4917 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
       
  4918 
       
  4919         Reviewed by Kenneth Rohde Christiansen.
       
  4920 
       
  4921         [Qt] DRT EventSender support to graphics mouse events activation
       
  4922         https://bugs.webkit.org/show_bug.cgi?id=40017
       
  4923 
       
  4924         * DumpRenderTree/qt/EventSenderQt.cpp:
       
  4925         (EventSender::mouseDown):
       
  4926         (EventSender::mouseUp):
       
  4927         (EventSender::mouseMoveTo):
       
  4928         (EventSender::keyDown):
       
  4929         (EventSender::contextClick):
       
  4930         (EventSender::sendTouchEvent):
       
  4931         (EventSender::sendOrQueueEvent):
       
  4932         (EventSender::eventFilter):
       
  4933         (EventSender::createGraphicsSceneMouseEvent):
       
  4934         (EventSender::sendEvent):
       
  4935         * DumpRenderTree/qt/EventSenderQt.h:
       
  4936         (EventSender::isGraphicsBased):
       
  4937 
       
  4938 2010-06-09  Adam Barth  <abarth@webkit.org>
       
  4939 
       
  4940         Reviewed by Ojan Vafai.
       
  4941 
       
  4942         webkit-patch upload fails for security bugs because there's no rietveld flag
       
  4943         https://bugs.webkit.org/show_bug.cgi?id=40309
       
  4944 
       
  4945         There's probably a more elegant way of seeing whether the form control
       
  4946         exists, but this seems to work.
       
  4947 
       
  4948         * Scripts/webkitpy/common/net/bugzilla.py:
       
  4949 
       
  4950 2010-06-09  Ojan Vafai  <ojan@chromium.org>
       
  4951 
       
  4952         Reviewed by Adam Barth.
       
  4953 
       
  4954         make rietveld upload faster and avoid posting to bug on errors
       
  4955         https://bugs.webkit.org/show_bug.cgi?id=40389
       
  4956 
       
  4957         Only grab the first item of the upload queue instead of trying
       
  4958         to compute the whole list upfront (which is O(n) bugzilla lookups!).
       
  4959 
       
  4960         Also, don't post comments to the bug when uploading fails.
       
  4961 
       
  4962         * Scripts/webkitpy/common/net/bugzilla.py:
       
  4963         * Scripts/webkitpy/tool/commands/queues.py:
       
  4964         * Scripts/webkitpy/tool/commands/queues_unittest.py:
       
  4965         * Scripts/webkitpy/tool/commands/stepsequence.py:
       
  4966         * Scripts/webkitpy/tool/mocktool.py:
       
  4967 
       
  4968 2010-06-09  Ojan Vafai  <ojan@chromium.org>
       
  4969 
       
  4970         Reviewed by Adam Barth.
       
  4971 
       
  4972         Rietveld upload queue fails when setting in-rietveld flag
       
  4973         https://bugs.webkit.org/show_bug.cgi?id=40371
       
  4974 
       
  4975         Make the comment arguments to set_flag_on_attachment optional
       
  4976         and add it to the MockBugzilla.
       
  4977 
       
  4978         * Scripts/webkitpy/common/net/bugzilla.py:
       
  4979         * Scripts/webkitpy/tool/bot/queueengine.py:
       
  4980         * Scripts/webkitpy/tool/commands/download_unittest.py:
       
  4981         * Scripts/webkitpy/tool/commands/queues.py:
       
  4982         * Scripts/webkitpy/tool/commands/queues_unittest.py:
       
  4983         * Scripts/webkitpy/tool/mocktool.py:
       
  4984 
       
  4985 2010-06-09  Kenneth Russell  <kbr@google.com>
       
  4986 
       
  4987         Reviewed by Dimitri Glazkov.
       
  4988 
       
  4989         Rename FloatArray to Float32Array
       
  4990         https://bugs.webkit.org/show_bug.cgi?id=40323
       
  4991 
       
  4992         Used do-webcore-rename to perform renaming. Manually undid
       
  4993         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
       
  4994         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
       
  4995         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
       
  4996         all layout tests on Safari; built Chromium and ran selected WebGL
       
  4997         tests.
       
  4998 
       
  4999         * Scripts/do-webcore-rename:
       
  5000 
       
  5001 2010-06-08  Tony Chang  <tony@chromium.org>
       
  5002 
       
  5003         Reviewed by David Levin.
       
  5004 
       
  5005         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
       
  5006         https://bugs.webkit.org/show_bug.cgi?id=40285
       
  5007 
       
  5008         * Scripts/webkitdirs.pm:
       
  5009         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
       
  5010 
       
  5011 2010-06-03  Roland Steiner  <rolandsteiner@chromium.org>
       
  5012 
       
  5013         Reviewed by Tamura Kent.
       
  5014 
       
  5015         Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
       
  5016         https://bugs.webkit.org/show_bug.cgi?id=40052
       
  5017         
       
  5018         Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
       
  5019 
       
  5020         * DumpRenderTree/DumpRenderTree.gypi:
       
  5021         * DumpRenderTree/chromium/TestShellWin.cpp:
       
  5022         (platformInit):
       
  5023         * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
       
  5024         (WebKit::):
       
  5025         (WebKit::WebThemeControlDRT::WebThemeControlDRT):
       
  5026         (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
       
  5027         (WebKit::WebThemeControlDRT::box):
       
  5028         (WebKit::WebThemeControlDRT::line):
       
  5029         (WebKit::WebThemeControlDRT::triangle):
       
  5030         (WebKit::WebThemeControlDRT::roundRect):
       
  5031         (WebKit::WebThemeControlDRT::oval):
       
  5032         (WebKit::WebThemeControlDRT::circle):
       
  5033         (WebKit::WebThemeControlDRT::nestedBoxes):
       
  5034         (WebKit::WebThemeControlDRT::markState):
       
  5035         (WebKit::WebThemeControlDRT::draw):
       
  5036         (WebKit::WebThemeControlDRT::drawTextField):
       
  5037         (WebKit::WebThemeControlDRT::drawProgressBar):
       
  5038         * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
       
  5039         (WebKit::WebThemeControlDRT::):
       
  5040         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
       
  5041         (WebKit::):
       
  5042         (WebKit::WebThemeEngineDRT::paintButton):
       
  5043         (WebKit::WebThemeEngineDRT::paintMenuList):
       
  5044         (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
       
  5045         (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
       
  5046         (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
       
  5047         (WebKit::WebThemeEngineDRT::paintTextField):
       
  5048         (WebKit::WebThemeEngineDRT::paintTrackbar):
       
  5049         (WebKit::WebThemeEngineDRT::paintProgressBar):
       
  5050         * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
       
  5051         (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):
       
  5052 
       
  5053 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
       
  5054 
       
  5055         Unreviewed, rolling out r60878.
       
  5056         http://trac.webkit.org/changeset/60878
       
  5057         https://bugs.webkit.org/show_bug.cgi?id=40349
       
  5058 
       
  5059         broke linux build (Requested by tony^work on #webkit).
       
  5060 
       
  5061         * Scripts/webkitdirs.pm:
       
  5062         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
       
  5063 
       
  5064 2010-06-08  Tony Chang  <tony@chromium.org>
       
  5065 
       
  5066         Reviewed by David Levin.
       
  5067 
       
  5068         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
       
  5069         https://bugs.webkit.org/show_bug.cgi?id=40285
       
  5070 
       
  5071         * Scripts/webkitdirs.pm:
       
  5072         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
       
  5073 
       
  5074 2010-06-08  Kenneth Russell  <kbr@google.com>
       
  5075 
       
  5076         Unreviewed, build fix.
       
  5077 
       
  5078         Fix build breakage from 38145
       
  5079         https://bugs.webkit.org/show_bug.cgi?id=40346
       
  5080 
       
  5081         The fix for bug 38145 broke the Chromium Win build because
       
  5082         Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
       
  5083         change log2(x) to log(x) / log(2). Built and ran WebGL layout
       
  5084         tests in Safari on Mac OS X. Changed download mirrors for
       
  5085         python-irclib to working ones.
       
  5086 
       
  5087         * Scripts/webkitpy/thirdparty/__init__.py:
       
  5088 
       
  5089 2010-06-08  Fumitoshi Ukai  <ukai@chromium.org>
       
  5090 
       
  5091         Reviewed by Eric Seidel.
       
  5092 
       
  5093         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
       
  5094         https://bugs.webkit.org/show_bug.cgi?id=39058
       
  5095 
       
  5096         * Scripts/old-run-webkit-tests:
       
  5097          use sourceDir() to find ensure-valid-python in checkPythonVersion()
       
  5098 
       
  5099 2010-06-08  Andras Becsi  <abecsi@webkit.org>
       
  5100 
       
  5101         Unreviewed buildfix after r60479.
       
  5102 
       
  5103         [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
       
  5104         versions other than 2.17.3.
       
  5105 
       
  5106         * DumpRenderTree/gtk/EventSender.cpp:
       
  5107         (getRootCoords):
       
  5108 
       
  5109 2010-06-07  Martin Robinson  <mrobinson@igalia.com>
       
  5110 
       
  5111         Reviewed by Oliver Hunt.
       
  5112 
       
  5113         [GTK] Mouse movement should not trigger a replay of saved events in the event sender
       
  5114         https://bugs.webkit.org/show_bug.cgi?id=40267
       
  5115 
       
  5116         When a mouse button is down, automatically queue mouse motion events and
       
  5117         do not play them back until the mouse button is released. This matches the
       
  5118         behavior of other ports' EventSenders.
       
  5119 
       
  5120         * DumpRenderTree/gtk/EventSender.cpp:
       
  5121         (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
       
  5122         (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
       
  5123 
       
  5124 2010-06-07  Nikolas Zimmermann  <nzimmermann@rim.com>
       
  5125 
       
  5126         Reviewed by Sam Weinig.
       
  5127 
       
  5128         Add CPP bindings generator
       
  5129         https://bugs.webkit.org/show_bug.cgi?id=38279
       
  5130 
       
  5131         Integrate CPP bindings in run-bindings-tests.
       
  5132 
       
  5133         * Scripts/run-bindings-tests:
       
  5134 
       
  5135 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
       
  5136 
       
  5137         Reviewed by Ojan Vafai.
       
  5138 
       
  5139         Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
       
  5140         https://bugs.webkit.org/show_bug.cgi?id=40183
       
  5141 
       
  5142         * Scripts/webkitpy/tool/steps/preparechangelog.py:
       
  5143 
       
  5144 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
       
  5145 
       
  5146         Unreviewed.
       
  5147 
       
  5148         Add my new email and IRC nick to committers.py.
       
  5149 
       
  5150         * Scripts/webkitpy/common/config/committers.py:
       
  5151 
       
  5152 2010-06-04  Kinuko Yasuda  <kinuko@chromium.org>
       
  5153 
       
  5154         Unreviewed.
       
  5155 
       
  5156         Revert changes in json_results_generator.py's _get_svn_revision.
       
  5157 
       
  5158         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
       
  5159 
       
  5160 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
       
  5161 
       
  5162         Reviewed by Xan Lopez.
       
  5163 
       
  5164         [GTK] GtkLauncher should support relative file paths
       
  5165         https://bugs.webkit.org/show_bug.cgi?id=39944
       
  5166 
       
  5167         Allow GtkLauncher to handle relative file paths passed via command-line arguments.
       
  5168 
       
  5169         * GtkLauncher/main.c:
       
  5170         (filename_to_url): Added.
       
  5171         (main): Try to resolve arguments as relative file URLs first.
       
  5172 
       
  5173 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
       
  5174 
       
  5175         Reviewed by Xan Lopez.
       
  5176 
       
  5177         [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
       
  5178         https://bugs.webkit.org/show_bug.cgi?id=40182
       
  5179 
       
  5180         Instead of invoking signal handlers directly via g_signal_emit_by_name, call
       
  5181         gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
       
  5182         without breaking DRT.
       
  5183 
       
  5184         * DumpRenderTree/gtk/EventSender.cpp:
       
  5185         (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly.
       
  5186         (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
       
  5187 
       
  5188 2010-06-04  Anders Carlsson  <andersca@apple.com>
       
  5189 
       
  5190         Reviewed by David Hyatt.
       
  5191 
       
  5192         Make the editing/spelling/context-menu-suggestions.html test more robust
       
  5193         https://bugs.webkit.org/show_bug.cgi?id=40178
       
  5194 
       
  5195         Change the contextClick method to return an array of strings describing the context menu items.
       
  5196 
       
  5197         * DumpRenderTree/mac/EventSendingController.mm:
       
  5198         (+[EventSendingController isSelectorExcludedFromWebScript:]):
       
  5199         (+[EventSendingController webScriptNameForSelector:]):
       
  5200         (-[EventSendingController contextClick]):
       
  5201 
       
  5202 2010-06-03  Kinuko Yasuda  <kinuko@chromium.org>
       
  5203 
       
  5204         Reviewed by Shinichiro Hamaji.
       
  5205 
       
  5206         Clean up chromium-specific code from json_results_generator.py.
       
  5207         https://bugs.webkit.org/show_bug.cgi?id=39665
       
  5208 
       
  5209         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
       
  5210         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
       
  5211         * Scripts/webkitpy/layout_tests/port/base.py:
       
  5212         * Scripts/webkitpy/layout_tests/port/chromium.py:
       
  5213 
       
  5214 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
       
  5215 
       
  5216         Reviewed by Adam Barth.
       
  5217 
       
  5218         Utilize new takeFirst() method where appropriate.
       
  5219         https://bugs.webkit.org/show_bug.cgi?id=40089
       
  5220 
       
  5221         * DumpRenderTree/chromium/EventSender.cpp:
       
  5222         (EventSender::replaySavedEvents):
       
  5223         * DumpRenderTree/chromium/LayoutTestController.cpp:
       
  5224         (LayoutTestController::WorkQueue::processWork):
       
  5225         (LayoutTestController::WorkQueue::reset):
       
  5226 
       
  5227 2010-06-04  Yael Aharon  <yael.aharon@nokia.com>
       
  5228 
       
  5229         Reviewed by Simon Hausmann.
       
  5230 
       
  5231         [Qt] QtTestLauncher should allow notifications by default.
       
  5232         https://bugs.webkit.org/show_bug.cgi?id=40078
       
  5233 
       
  5234         * QtTestBrowser/main.cpp:
       
  5235         (NotificationsPermissionController::NotificationsPermissionController):
       
  5236         (NotificationsPermissionController::checkPermission):
       
  5237         (NotificationsPermissionController::requestPermission):
       
  5238         (LauncherWindow::LauncherWindow):
       
  5239 
       
  5240 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
       
  5241 
       
  5242         Reviewed by Adam Barth.
       
  5243 
       
  5244         Detect whether the user's environment can open a browser.
       
  5245         https://bugs.webkit.org/show_bug.cgi?id=40136
       
  5246 
       
  5247         Some environments like cygwin silently fail webbrowser.open() causing
       
  5248         webkit-patch upload not to display any diff. This detects environments
       
  5249         where webbrowser.open() would fail by testing if webbrowser.get()
       
  5250         raises an exception.
       
  5251 
       
  5252         * Scripts/webkitpy/common/system/user.py:
       
  5253         * Scripts/webkitpy/tool/mocktool.py:
       
  5254         * Scripts/webkitpy/tool/steps/confirmdiff.py:
       
  5255 
       
  5256 2010-06-03  Tony Gentilcore  <tonyg@chromium.org>
       
  5257 
       
  5258         Reviewed by David Levin.
       
  5259 
       
  5260         Add dependencies required to link with VS Express 2005.
       
  5261         https://bugs.webkit.org/show_bug.cgi?id=40038
       
  5262 
       
  5263         Visual Studio implicitly links against these libs.
       
  5264         VC++ Express does not.
       
  5265 
       
  5266         * WebKitAPITest/WebKitAPITestCommon.vsprops:
       
  5267         * WinLauncher/WinLauncher.vcproj:
       
  5268 
       
  5269 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
       
  5270 
       
  5271         Reviewed by David Levin.
       
  5272 
       
  5273         bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
       
  5274         https://bugs.webkit.org/show_bug.cgi?id=40105
       
  5275 
       
  5276         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
       
  5277         - kill pywebsocket process when url is not alive and the process is not
       
  5278           terminated, not to leave pywebsocket server running.
       
  5279         - fix codecs.open parameters.
       
  5280 
       
  5281 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
       
  5282 
       
  5283         Reviewed by Alexey Proskuryakov.
       
  5284 
       
  5285         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
       
  5286         https://bugs.webkit.org/show_bug.cgi?id=39058
       
  5287 
       
  5288         * Scripts/ensure-valid-python:
       
  5289           - Perl 5.8 doesn't have File::Temp->newdir().  Use File::Temp->tempdir() instead.
       
  5290           - Add --check-only and --help option.
       
  5291           - --check-only option only checks python version and don't try to install Python 2.5.
       
  5292           - Set executable bit.
       
  5293         * Scripts/old-run-webkit-tests:
       
  5294           - Check if it can run the websocket tests by calling ensure-valid-python --check-only.
       
  5295 
       
  5296 2010-05-14  Ojan Vafai  <ojan@chromium.org>
       
  5297 
       
  5298         Reviewed by Adam Barth.
       
  5299 
       
  5300         add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
       
  5301         https://bugs.webkit.org/show_bug.cgi?id=38918
       
  5302 
       
  5303         Patches with in-rietveld? get uploaded to rietveld and get marked
       
  5304         in-rietveld+. If the upload fails, they are marked in-rietveld-
       
  5305         and an error is logged to the bug, like the commit-queue.
       
  5306 
       
  5307         Also, get rid of --fancy-review and the ability to upload to rietveld
       
  5308         using webkit-patch upload/post.
       
  5309 
       
  5310         * Scripts/webkitpy/common/net/bugzilla.py:
       
  5311         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
       
  5312         * Scripts/webkitpy/tool/commands/download.py:
       
  5313         * Scripts/webkitpy/tool/commands/download_unittest.py:
       
  5314         * Scripts/webkitpy/tool/commands/queues.py:
       
  5315         * Scripts/webkitpy/tool/commands/queues_unittest.py:
       
  5316         * Scripts/webkitpy/tool/commands/upload.py:
       
  5317         * Scripts/webkitpy/tool/commands/upload_unittest.py:
       
  5318         * Scripts/webkitpy/tool/mocktool.py:
       
  5319         * Scripts/webkitpy/tool/steps/options.py:
       
  5320         * Scripts/webkitpy/tool/steps/postcodereview.py:
       
  5321 
       
  5322 2010-05-24  Ojan Vafai  <ojan@chromium.org>
       
  5323 
       
  5324         Reviewed by Chris Jerdonek.
       
  5325 
       
  5326         many webkit-patch commands fail in a non-svn tracking git checkout
       
  5327         https://bugs.webkit.org/show_bug.cgi?id=38156
       
  5328 
       
  5329         If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
       
  5330         If neither exists, then error out. This makes webkit-patch work
       
  5331         for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
       
  5332         to checkout webkit. The fallback to master is for people who don't
       
  5333         do the steps on that page for tracking svn.
       
  5334 
       
  5335         * Scripts/webkitpy/common/checkout/scm.py:
       
  5336         * Scripts/webkitpy/common/checkout/scm_unittest.py:
       
  5337 
       
  5338 2010-06-03  Mike Fenton  <mifenton@rim.com>
       
  5339 
       
  5340         Unreviewed.
       
  5341 
       
  5342         Reverse e-mail for myself in committers.py to correspond with bugzilla account.
       
  5343 
       
  5344         * Scripts/webkitpy/common/config/committers.py:
       
  5345 
       
  5346 2010-06-03  Pavel Feldman  <pfeldman@chromium.org>
       
  5347 
       
  5348         Reviewed by Yury Semikhatsky.
       
  5349 
       
  5350         Web Inspector: a number of fixes that make InspectorController
       
  5351         happy with null redirects.
       
  5352 
       
  5353         https://bugs.webkit.org/show_bug.cgi?id=40109
       
  5354 
       
  5355         * DumpRenderTree/gtk/DumpRenderTree.cpp:
       
  5356         (runTest):
       
  5357         * DumpRenderTree/mac/DumpRenderTree.mm:
       
  5358         (runTest):
       
  5359         * DumpRenderTree/win/DumpRenderTree.cpp:
       
  5360         (runTest):
       
  5361 
       
  5362 2010-06-02  Tasuku Suzuki  <tasuku.suzuki@nokia.com>
       
  5363 
       
  5364         Reviewed by Shinichiro Hamaji.
       
  5365 
       
  5366         [Qt] Fix compilation with QT_NO_PROPERTIES
       
  5367         https://bugs.webkit.org/show_bug.cgi?id=38324
       
  5368 
       
  5369         * QtTestBrowser/main.cpp:
       
  5370         (LauncherWindow::init):
       
  5371 
       
  5372 2010-06-02  Diego Gonzalez  <diegohcg@webkit.org>
       
  5373 
       
  5374         Reviewed by Kenneth Rohde Christiansen.
       
  5375 
       
  5376         [Qt] Make possible run DRT with QGraphicsWebView
       
  5377         https://bugs.webkit.org/show_bug.cgi?id=40016
       
  5378 
       
  5379         Make possible to use a environment variable for switching backend.
       
  5380         Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt
       
  5381 
       
  5382         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
       
  5383         (WebCore::WebViewGraphicsBased::WebViewGraphicsBased):
       
  5384         (WebCore::DumpRenderTree::DumpRenderTree):
       
  5385         * DumpRenderTree/qt/DumpRenderTreeQt.h:
       
  5386         (WebCore::DumpRenderTree::setGraphicsBased):
       
  5387         (WebCore::DumpRenderTree::isGraphicsBased):
       
  5388         (WebCore::WebViewGraphicsBased::graphicsView):
       
  5389         (WebCore::WebViewGraphicsBased::setPage):
       
  5390         * Scripts/old-run-webkit-tests:
       
  5391 
       
  5392 2010-06-02  Csaba Osztrogonác  <ossy@webkit.org>
       
  5393 
       
  5394         Reviewed by Eric Seidel.
       
  5395 
       
  5396         Slave lost shouldn't be recognized as build failed.
       
  5397         https://bugs.webkit.org/show_bug.cgi?id=39282
       
  5398 
       
  5399         * Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
       
  5400         * Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
       
  5401 
       
  5402 2010-06-01  Yael Aharon  <yael.aharon@nokia.com>
       
  5403 
       
  5404         Reviewed by Kenneth Rohde Christiansen.
       
  5405 
       
  5406         [Qt] Fix the lifecycle of notification objects
       
  5407         https://bugs.webkit.org/show_bug.cgi?id=40003
       
  5408 
       
  5409         Remove the dependency of notifications on QWebPage.
       
  5410 
       
  5411         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
       
  5412         (WebCore::requestPermissionCallback):
       
  5413         (WebCore::WebPage::WebPage):
       
  5414         (WebCore::DumpRenderTree::requestPermission):
       
  5415         * DumpRenderTree/qt/DumpRenderTreeQt.h:
       
  5416 
       
  5417 2010-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
       
  5418 
       
  5419         Unreviewed, rolling out r60559.
       
  5420         http://trac.webkit.org/changeset/60559
       
  5421         https://bugs.webkit.org/show_bug.cgi?id=40055
       
  5422 
       
  5423         It broke python unit test (Requested by Ossy on #webkit).
       
  5424 
       
  5425         * Scripts/webkitpy/common/net/buildbot.py:
       
  5426 
       
  5427 2010-06-02  Csaba Osztrogonác  <ossy@webkit.org>
       
  5428 
       
  5429         Reviewed by Eric Seidel.
       
  5430 
       
  5431         Slave lost shouldn't be recognized as build failed.
       
  5432         https://bugs.webkit.org/show_bug.cgi?id=39282
       
  5433 
       
  5434         * Scripts/webkitpy/common/net/buildbot.py:
       
  5435 
       
  5436 2010-06-02  Tony Gentilcore  <tonyg@chromium.org>
       
  5437 
       
  5438         Reviewed by Eric Seidel.
       
  5439 
       
  5440         Fix crash caused when assigned_to is disabled
       
  5441         https://bugs.webkit.org/show_bug.cgi?id=40039
       
  5442 
       
  5443         * Scripts/webkitpy/common/net/bugzilla.py:
       
  5444 
       
  5445 2010-06-02  Sterling Swigart  <sswigart@google.com>
       
  5446 
       
  5447         Reviewed by David Levin.
       
  5448 
       
  5449         Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
       
  5450         https://bugs.webkit.org/show_bug.cgi?id=39906
       
  5451 
       
  5452         * Scripts/build-webkit:
       
  5453 
       
  5454 2010-06-01  Raine Makelainen  <raine.makelainen@nokia.com>
       
  5455 
       
  5456         Reviewed by Simon Hausmann.
       
  5457 
       
  5458         Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard.
       
  5459 
       
  5460         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
       
  5461         (WebCore::WebPage::WebPage):
       
  5462         (WebCore::WebPage::resetSettings):
       
  5463         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
       
  5464         (LayoutTestController::setJavaScriptCanAccessClipboard):
       
  5465 
       
  5466 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
       
  5467 
       
  5468         Reviewed by Mark Rowe.
       
  5469 
       
  5470         A nicer Tiger build fix.
       
  5471 
       
  5472         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
       
  5473         * DumpRenderTree/mac/Configurations/Base.xcconfig:
       
  5474         Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig.
       
  5475 
       
  5476 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
       
  5477 
       
  5478         A real Tiger build fix.
       
  5479 
       
  5480         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS
       
  5481         for all configurations, not just debug.
       
  5482 
       
  5483 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
       
  5484 
       
  5485         Tiger build fix.
       
  5486 
       
  5487         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS.
       
  5488 
       
  5489 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
       
  5490 
       
  5491         Reviewed by Xan Lopez.
       
  5492 
       
  5493         [GTK] Get more mouse tests passing
       
  5494         https://bugs.webkit.org/show_bug.cgi?id=39040
       
  5495 
       
  5496         Reproduce the logic from the Windows EventSender for mapping
       
  5497         button numbers to GDK button numbers. Move this logic to the
       
  5498         prepareMouseButtonEvent helper.
       
  5499 
       
  5500         * DumpRenderTree/gtk/EventSender.cpp:
       
  5501         (prepareMouseButtonEvent): Reproduce Windows logic.
       
  5502         (contextClickCallback): Move mapping logic to prepareMouseButtonEvent.
       
  5503         (mouseDownCallback): Ditto.
       
  5504         (mouseUpCallback): Ditto.
       
  5505 
       
  5506 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
       
  5507 
       
  5508         Reviewed by Sam Weinig.
       
  5509 
       
  5510         https://bugs.webkit.org/show_bug.cgi?id=39434
       
  5511         REGRESSION (r59811): Geolocation callbacks cannot be created
       
  5512 
       
  5513         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added MockGeolocationProvider.
       
  5514 
       
  5515         * DumpRenderTree/mac/DumpRenderTree.mm:
       
  5516         (createWebViewAndOffscreenWindow): Tell the view to use MockGeolocationProvider. 
       
  5517         (resetWebViewToConsistentStateBeforeTesting): Make sure that mock notifications don't leak
       
  5518         into subsequent tests.
       
  5519 
       
  5520         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
       
  5521         (LayoutTestController::setMockGeolocationPosition): Changed to use MockGeolocationProvider.
       
  5522         (LayoutTestController::setMockGeolocationError): Ditto.
       
  5523 
       
  5524         * DumpRenderTree/mac/MockGeolocationProvider.h: Added.
       
  5525         * DumpRenderTree/mac/MockGeolocationProvider.mm: Added.
       
  5526         (+[MockGeolocationProvider shared]):
       
  5527         (-[MockGeolocationProvider dealloc]):
       
  5528         (-[MockGeolocationProvider setPosition:]):
       
  5529         (-[MockGeolocationProvider setError:]):
       
  5530         (-[MockGeolocationProvider registerWebView:]):
       
  5531         (-[MockGeolocationProvider unregisterWebView:]):
       
  5532         (-[MockGeolocationProvider lastPosition]):
       
  5533         (-[MockGeolocationProvider stopTimer]):
       
  5534         (-[MockGeolocationProvider timerFired]):
       
  5535 
       
  5536         * DumpRenderTree/mac/UIDelegate.mm:
       
  5537         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
       
  5538         This delegate method must send a response. I'm not sure what the two-stage check is supposed
       
  5539         to achieve, it seems unnecessary.
       
  5540 
       
  5541 2010-05-12  Martin Robinson  <mrobinson@igalia.com>
       
  5542 
       
  5543         Reviewed by Xan Lopez.
       
  5544 
       
  5545         [GTK] Double clicks cause three button press events
       
  5546         https://bugs.webkit.org/show_bug.cgi?id=38853
       
  5547 
       
  5548         WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS
       
  5549         and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses
       
  5550         the GDK event queue entirely, we simply do not send the extra event.
       
  5551 
       
  5552         * DumpRenderTree/gtk/EventSender.cpp:
       
  5553         (mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately.
       
  5554         (dispatchEvent): Properly handle GDK_3BUTTON_PRESS.
       
  5555 
       
  5556 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
       
  5557 
       
  5558         Not reviewed. Build fix.
       
  5559 
       
  5560         Fix GTK+ build caused by a bad merge.
       
  5561 
       
  5562         * DumpRenderTree/gtk/EventSender.cpp: 
       
  5563         (prepareMouseButtonEvent): Use the GdkEvent union as a pointer here.
       
  5564 
       
  5565 2010-06-01  Martin Robinson  <mrobinson@webkit.org>
       
  5566 
       
  5567         Reviewed by Xan Lopez.
       
  5568 
       
  5569         [GTK] Double clicks cause three button press events
       
  5570         https://bugs.webkit.org/show_bug.cgi?id=38853
       
  5571 
       
  5572         Small EventSender cleanups. Consolidate some common code. Style fixes.
       
  5573 
       
  5574         * DumpRenderTree/gtk/EventSender.cpp:
       
  5575         (prepareMouseButtonEvent): Added.
       
  5576         (contextClickCallback): Use prepareMouseButtonEvent.
       
  5577         (mouseDownCallback): Use prepareMouseButtonEvent.
       
  5578         (mouseUpCallback): Use prepareMouseButtonEvent.
       
  5579         (mouseMoveToCallback): Small style fix.
       
  5580 
       
  5581 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
       
  5582 
       
  5583         Reviewed by Xan Lopez.
       
  5584 
       
  5585         [GTK] Double clicks cause three button press events
       
  5586         https://bugs.webkit.org/show_bug.cgi?id=38853
       
  5587 
       
  5588         Add rudimentary leapForward support to the GTK+ DRT. leapForward allows a test
       
  5589         to pause for a specified amount of time. It is used in the processing of drag-
       
  5590         -and-drop data as well as to separate distinct mouse double-clicks in some tests.
       
  5591         This patch enables tests that rely on the latter behavior to pass.
       
  5592 
       
  5593         * DumpRenderTree/gtk/DumpRenderTree.cpp:
       
  5594         (webViewWindowObjectCleared): Only initialize the EventSender when loading the top frame.
       
  5595         * DumpRenderTree/gtk/EventSender.cpp:
       
  5596         (leapForwardCallback): Add support for adjusting the time offset on leapForward().
       
  5597         (contextClickCallback): Use sendOrQueueEvent.
       
  5598         (updateClickCount): Take the time offset into account when counting clicks.
       
  5599         (mouseDownCallback): Use sendOrQueueEvent.
       
  5600         (getStateFlags): Change down/currentEventButton into buttonCurrentlyDown/lastClickButton.
       
  5601         (mouseUpCallback): Use sendOrQueueEvent.
       
  5602         (mouseMoveToCallback): Ditto.
       
  5603         (mouseWheelToCallback): Ditto.
       
  5604         (sendOrQueueEvent): Added.
       
  5605         (dispatchEvent): Added.
       
  5606         (replaySavedEvents): Pause when an event has a delay and defer to dispatchEvent.
       
  5607         (makeEventSender): Only initialize the EventSender when loading the top frame.
       
  5608         * DumpRenderTree/gtk/EventSender.h: Ditto.
       
  5609 
       
  5610 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
       
  5611 
       
  5612         Reviewed by Xan Lopez.
       
  5613 
       
  5614         [GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
       
  5615         https://bugs.webkit.org/show_bug.cgi?id=39101
       
  5616 
       
  5617         Work around timing issues for render tree dumps by pumping the
       
  5618         main loop before doing the dump. Resize events are asynchronous
       
  5619         in GTK+, so sometimes resize requests are still pending when DRT
       
  5620         dumps the tree.
       
  5621 
       
  5622         * DumpRenderTree/gtk/DumpRenderTree.cpp:
       
  5623         (dump): Pump the main loop before dumping the render tree.
       
  5624 
       
  5625 2010-05-31  Kent Tamura  <tkent@chromium.org>
       
  5626 
       
  5627         Reviewed by Dimitri Glazkov.
       
  5628 
       
  5629         [DRT/Chromium] Fix crash of a test after another test with multiple windows
       
  5630         https://bugs.webkit.org/show_bug.cgi?id=39942
       
  5631 
       
  5632         If a test opens multiple windows, focuses on non-main window, and
       
  5633         the focused window is closed, TestShell::m_focusedWidget points a
       
  5634         deleted object.
       
  5635 
       
  5636         * DumpRenderTree/chromium/TestShell.cpp:
       
  5637         (TestShell::closeWindow): Clear m_focusedWidget.
       
  5638 
       
  5639 2010-05-30  Kent Tamura  <tkent@chromium.org>
       
  5640 
       
  5641         Reviewed by Dimitri Glazkov.
       
  5642 
       
  5643         new-run-webkit-tests: Support DRT on Chromium-win
       
  5644         https://bugs.webkit.org/show_bug.cgi?id=39810
       
  5645 
       
  5646         Add --test-shell flag to DRT/Chromium, and it changes DRT so that
       
  5647         it behaves like test_shell about command analysis, printing
       
  5648         format, pixel dumping, and timeout handling.
       
  5649 
       
  5650         chromium.py and chromium_win.py supports the --test-shell flag and
       
  5651         DRT/Chromium-win binary names.
       
  5652         
       
  5653         * DumpRenderTree/DumpRenderTree.gypi: Add new files.
       
  5654         * DumpRenderTree/chromium/DumpRenderTree.cpp:
       
  5655         (runTest): Support for test_shell-style command.
       
  5656         (main): Introduce --test-shell.
       
  5657         * DumpRenderTree/chromium/TestEventPrinter.cpp: Added.
       
  5658         * DumpRenderTree/chromium/TestEventPrinter.h: Added.
       
  5659           TestEventPrinter class manages stdio output and image output.
       
  5660           TestEventPrinter.cpp has two implementations; DRTPrinter and
       
  5661           TestShellPrinter.
       
  5662         * DumpRenderTree/chromium/TestShell.cpp:
       
  5663           Some changes for TestEventPrinter.
       
  5664         (TestShell::TestShell):
       
  5665         (TestShell::runFileTest):
       
  5666         (TestShell::testTimedOut):
       
  5667         (TestShell::dump):
       
  5668         (TestShell::dumpImage):
       
  5669         * DumpRenderTree/chromium/TestShell.h:
       
  5670         (TestShell::printer):
       
  5671         (TestShell::layoutTestTimeout):
       
  5672         (TestShell::layoutTestTimeoutForWatchDog):
       
  5673         (TestShell::setLayoutTestTimeout):
       
  5674         * DumpRenderTree/chromium/TestShellWin.cpp:
       
  5675         (watchDogThread): Use TestShell::layoutTestTimeoutForWatchDog().
       
  5676         * Scripts/webkitpy/layout_tests/port/chromium.py:
       
  5677         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
       
  5678 
       
  5679 2010-05-30  Robert Hogan  <robert@webkit.org>
       
  5680 
       
  5681         Reviewed by Kenneth Rohde Christiansen.
       
  5682 
       
  5683         [Qt] Enhance Qt DRT implementation to support platform scroll wheel events.
       
  5684 
       
  5685         https://bugs.webkit.org/show_bug.cgi?id=36004
       
  5686 
       
  5687         * DumpRenderTree/qt/EventSenderQt.cpp:
       
  5688         (EventSender::EventSender): QApplication::setWheelScrollLines(2) in order to match
       
  5689                                     Scrollbar::pixelsPerLineStep() for DRT testing.
       
  5690         (EventSender::mouseScrollBy): Added
       
  5691         (EventSender::continuousMouseScrollBy): Added
       
  5692         * DumpRenderTree/qt/EventSenderQt.h:
       
  5693 
       
  5694 2010-05-28  Adam Barth  <abarth@webkit.org>
       
  5695 
       
  5696         Reviewed by David Levin.
       
  5697 
       
  5698         webkit-patch should support CHANGE_LOG_EDIT_APPLICATION
       
  5699         https://bugs.webkit.org/show_bug.cgi?id=39546
       
  5700 
       
  5701         One sublty is that we want to wait for the user to finish editing the
       
  5702         ChangeLog before moving on to the next step.  That means we want to pass
       
  5703         -W to open.  However, if the user is using Xcode to edit the ChangeLog,
       
  5704         we don't want them to have to exit the Xcode application.  For this reason,
       
  5705         we create a new instance of the application with -n.
       
  5706         
       
  5707         Overall, xed seems like a better solution, so we recommend that too.
       
  5708 
       
  5709         * Scripts/webkitpy/common/system/user.py:
       
  5710         * Scripts/webkitpy/tool/mocktool.py:
       
  5711         * Scripts/webkitpy/tool/steps/editchangelog.py:
       
  5712 
       
  5713 2010-05-21  Dirk Pranke  <dpranke@chromium.org>
       
  5714 
       
  5715         Reviewed by Ojan Vafai.
       
  5716 
       
  5717         new-run-webkit-tests: fix handling of Ctrl-C to exit even if some
       
  5718         threads are wedged. Also, the script will print the results of the
       
  5719         tests completed when the interrupt occurs.
       
  5720 
       
  5721         https://bugs.webkit.org/show_bug.cgi?id=33238
       
  5722 
       
  5723         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
       
  5724         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
       
  5725         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
       
  5726         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
       
  5727 
       
  5728 2010-05-28  Darin Adler  <darin@apple.com>
       
  5729 
       
  5730         Ignore more Python messiness.
       
  5731 
       
  5732         * Scripts/webkitpy/layout_tests/data/platform/test: Added property svn:ignore.
       
  5733         * Scripts/webkitpy/layout_tests/layout_package: Added property svn:ignore.
       
  5734         * Scripts/webkitpy/layout_tests/test_types: Added property svn:ignore.
       
  5735         * Scripts/webkitpy/test: Added property svn:ignore.
       
  5736         * Scripts/webkitpy/thirdparty/simplejson: Added property svn:ignore.
       
  5737 
       
  5738 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
       
  5739 
       
  5740         Reviewed by Beth Dakin.
       
  5741 
       
  5742         Adding myself as a reviewer.
       
  5743 
       
  5744         * Scripts/webkitpy/common/config/committers.py:
       
  5745 
       
  5746 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
       
  5747 
       
  5748         Build fix. No review.
       
  5749 
       
  5750         AX: need to catch NSAccessibilityExceptions in DRT
       
  5751         https://bugs.webkit.org/show_bug.cgi?id=39881
       
  5752 
       
  5753         It looks like Tiger doesn't like seeing a NSMakeRange inside a @try.
       
  5754 
       
  5755         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
       
  5756         (AccessibilityUIElement::rowIndexRange):
       
  5757         (AccessibilityUIElement::columnIndexRange):
       
  5758         (AccessibilityUIElement::selectedTextRange):
       
  5759 
       
  5760 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
       
  5761 
       
  5762         Reviewed by Darin Adler.
       
  5763 
       
  5764         AX: need to catch NSAccessibilityExceptions in DRT
       
  5765         https://bugs.webkit.org/show_bug.cgi?id=39881
       
  5766 
       
  5767         Normally, accessibility exceptions are caught in the AX Runtime on the Mac, but 
       
  5768         because DRT is its own AX client, no one is there to catch these otherwise innocuous exceptions.
       
  5769   
       
  5770         So DRT should wrap exception handlers around its AX related calls.
       
  5771 
       
  5772         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
       
  5773         (attributesOfElement):
       
  5774         (AccessibilityUIElement::getLinkedUIElements):
       
  5775         (AccessibilityUIElement::getDocumentLinks):
       
  5776         (AccessibilityUIElement::getChildren):
       
  5777         (AccessibilityUIElement::getChildrenWithRange):
       
  5778         (AccessibilityUIElement::ariaOwnsElementAtIndex):
       
  5779         (AccessibilityUIElement::ariaFlowToElementAtIndex):
       
  5780         (AccessibilityUIElement::disclosedRowAtIndex):
       
  5781         (AccessibilityUIElement::selectedRowAtIndex):
       
  5782         (AccessibilityUIElement::titleUIElement):
       
  5783         (AccessibilityUIElement::parentElement):
       
  5784         (AccessibilityUIElement::disclosedByRow):
       
  5785         (AccessibilityUIElement::stringAttributeValue):
       
  5786         (AccessibilityUIElement::boolAttributeValue):
       
  5787         (AccessibilityUIElement::isAttributeSettable):
       
  5788         (AccessibilityUIElement::isAttributeSupported):
       
  5789         (AccessibilityUIElement::role):
       
  5790         (AccessibilityUIElement::subrole):
       
  5791         (AccessibilityUIElement::roleDescription):
       
  5792         (AccessibilityUIElement::title):
       
  5793         (AccessibilityUIElement::description):
       
  5794         (AccessibilityUIElement::orientation):
       
  5795         (AccessibilityUIElement::stringValue):
       
  5796         (AccessibilityUIElement::language):
       
  5797         (AccessibilityUIElement::helpText):
       
  5798         (AccessibilityUIElement::x):
       
  5799         (AccessibilityUIElement::y):
       
  5800         (AccessibilityUIElement::width):
       
  5801         (AccessibilityUIElement::height):
       
  5802         (AccessibilityUIElement::clickPointX):
       
  5803         (AccessibilityUIElement::clickPointY):
       
  5804         (AccessibilityUIElement::intValue):
       
  5805         (AccessibilityUIElement::minValue):
       
  5806         (AccessibilityUIElement::maxValue):
       
  5807         (AccessibilityUIElement::valueDescription):
       
  5808         (AccessibilityUIElement::insertionPointLineNumber):
       
  5809         (AccessibilityUIElement::isActionSupported):
       
  5810         (AccessibilityUIElement::isEnabled):
       
  5811         (AccessibilityUIElement::isRequired):
       
  5812         (AccessibilityUIElement::isSelected):
       
  5813         (AccessibilityUIElement::isExpanded):
       
  5814         (AccessibilityUIElement::hierarchicalLevel):
       
  5815         (AccessibilityUIElement::ariaIsGrabbed):
       
  5816         (AccessibilityUIElement::ariaDropEffects):
       
  5817         (AccessibilityUIElement::lineForIndex):
       
  5818         (AccessibilityUIElement::boundsForRange):
       
  5819         (AccessibilityUIElement::stringForRange):
       
  5820         (AccessibilityUIElement::attributesOfColumnHeaders):
       
  5821         (AccessibilityUIElement::attributesOfRowHeaders):
       
  5822         (AccessibilityUIElement::attributesOfColumns):
       
  5823         (AccessibilityUIElement::attributesOfRows):
       
  5824         (AccessibilityUIElement::attributesOfVisibleCells):
       
  5825         (AccessibilityUIElement::attributesOfHeader):
       
  5826         (AccessibilityUIElement::rowCount):
       
  5827         (AccessibilityUIElement::columnCount):
       
  5828         (AccessibilityUIElement::indexInTable):
       
  5829         (AccessibilityUIElement::rowIndexRange):
       
  5830         (AccessibilityUIElement::columnIndexRange):
       
  5831         (AccessibilityUIElement::cellForColumnAndRow):
       
  5832         (AccessibilityUIElement::selectedTextRange):
       
  5833         (AccessibilityUIElement::setSelectedTextRange):
       
  5834         (AccessibilityUIElement::increment):
       
  5835         (AccessibilityUIElement::decrement):
       
  5836         (AccessibilityUIElement::showMenu):
       
  5837         (AccessibilityUIElement::press):
       
  5838         (AccessibilityUIElement::url):
       
  5839         (AccessibilityUIElement::hasPopup):
       
  5840 
       
  5841 2010-05-28  Yael Aharon  <yael.aharon@nokia.com>
       
  5842 
       
  5843         Reviewed by Laszlo Gombos.
       
  5844 
       
  5845         [Qt] Pass all web notification layout tests
       
  5846         https://bugs.webkit.org/show_bug.cgi?id=39146
       
  5847 
       
  5848         Mimic Chromium's test_shell security model in Qt's DRT.
       
  5849         It makes a list of origins which were granted permission to display
       
  5850         notifications, and only those origins can display notifications.
       
  5851 
       
  5852         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
       
  5853         (WebCore::checkPermissionCallback):
       
  5854         (WebCore::requestPermissionCallback):
       
  5855         (WebCore::WebPage::WebPage):
       
  5856         (WebCore::DumpRenderTree::checkPermission):
       
  5857         (WebCore::DumpRenderTree::requestPermission):
       
  5858         * DumpRenderTree/qt/DumpRenderTreeQt.h:
       
  5859         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
       
  5860         (LayoutTestController::reset):
       
  5861         (LayoutTestController::grantDesktopNotificationPermission):
       
  5862         (LayoutTestController::checkDesktopNotificationPermission):
       
  5863         * DumpRenderTree/qt/LayoutTestControllerQt.h:
       
  5864 
       
  5865 2010-05-27  Philippe Normand  <pnormand@igalia.com>
       
  5866 
       
  5867         Reviewed by Shinichiro Hamaji.
       
  5868 
       
  5869         check-webkit-style complains about use of NULL in GTK function calls that require sentinels
       
  5870         https://bugs.webkit.org/show_bug.cgi?id=39372
       
  5871 
       
  5872         Don't warn about NULL in g_*() calls. Zero can't be used instead
       
  5873         for calls like g_build_filename and g_object_get/set.
       
  5874 
       
  5875         * Scripts/webkitpy/style/checkers/cpp.py:
       
  5876         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
       
  5877 
       
  5878 2010-05-27  Luiz Agostini  <luiz.agostini@openbossa.org>
       
  5879 
       
  5880         Reviewed by Kenneth Rohde Christiansen.
       
  5881 
       
  5882         [Qt] Platform plugin example
       
  5883         https://bugs.webkit.org/show_bug.cgi?id=39489
       
  5884 
       
  5885         Exempting directory WebKit/qt/examples/ from style guide.
       
  5886 
       
  5887         * Scripts/webkitpy/style/checker.py:
       
  5888 
       
  5889 2010-05-26  Philippe Normand  <pnormand@igalia.com>
       
  5890 
       
  5891         Reviewed by David Levin.
       
  5892 
       
  5893         [style] Allow usage of NULL in gst_*_many()
       
  5894         https://bugs.webkit.org/show_bug.cgi?id=39740
       
  5895 
       
  5896         Don't warn if NULL is used by gst_*_many() functions. Zero can't
       
  5897         be used for the reason explained in Bug 32858.
       
  5898 
       
  5899         * Scripts/webkitpy/style/checkers/cpp.py:
       
  5900         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
       
  5901 
       
  5902 2010-05-27  Adam Barth  <abarth@webkit.org>
       
  5903 
       
  5904         Reviewed by Eric Seidel.
       
  5905 
       
  5906         Update script to run the normal version of the parser tests.
       
  5907 
       
  5908         * Scripts/test-html5-parser:
       
  5909 
       
  5910 2010-05-27  Adam Barth  <abarth@webkit.org>
       
  5911 
       
  5912         Reviewed by Eric Seidel.
       
  5913 
       
  5914         Add HTML5 parser support to run-webkit-tests
       
  5915         https://bugs.webkit.org/show_bug.cgi?id=39815
       
  5916 
       
  5917         * Scripts/old-run-webkit-tests:
       
  5918 
       
  5919 2010-05-26  Adam Barth  <abarth@webkit.org>
       
  5920 
       
  5921         Reviewed by Eric Seidel.
       
  5922 
       
  5923         Make HTML5 lexer not ASSERT when resuming partial parses
       
  5924         https://bugs.webkit.org/show_bug.cgi?id=39755
       
  5925 
       
  5926         Add webkit-resumer.html to the HTML5 parser test suite.
       
  5927 
       
  5928         * Scripts/test-html5-parser:
       
  5929 
       
  5930 2010-05-24  Tony Chang  <tony@chromium.org>
       
  5931 
       
  5932         Reviewed by Kent Tamura.
       
  5933 
       
  5934         [chromium] setup fonts on chromium linux DRT
       
  5935         https://bugs.webkit.org/show_bug.cgi?id=39644
       
  5936 
       
  5937         * DumpRenderTree/chromium/TestShellGtk.cpp:
       
  5938         (setupFontconfig):
       
  5939         (platformInit):
       
  5940         * DumpRenderTree/chromium/WebViewHost.cpp:
       
  5941         (WebViewHost::paintRect):  Fix a bug where in release builds, we didn't initialize m_canvas.
       
  5942         * DumpRenderTree/chromium/fonts.conf: Added.
       
  5943 
       
  5944 2010-05-24  Dirk Pranke  <dpranke@chromium.org>
       
  5945 
       
  5946         Reviewed by Dimitri Glazkov.
       
  5947 
       
  5948         Re-commit r58765 - it had been rolled out to see if it was causing
       
  5949         a perf regression (in r59787 and r59789), but that does not seem to
       
  5950         have been the case.
       
  5951 
       
  5952         https://bugs.webkit.org/show_bug.cgi?id=39605
       
  5953 
       
  5954         * DumpRenderTree/chromium/NotificationPresenter.cpp:
       
  5955         (NotificationPresenter::show):
       
  5956 
       
  5957 2010-05-25  Ojan Vafai  <ojan@chromium.org>
       
  5958 
       
  5959         Reviewed by Chris Jerdonek.
       
  5960 
       
  5961         remove suppression of rietveld logging
       
  5962         https://bugs.webkit.org/show_bug.cgi?id=39693
       
  5963 
       
  5964         Now that we only upload to rietveld explicitly, e.g. on the bot
       
  5965         or via webkit-patch post-attachment-to-rietveld, we should print
       
  5966         all the rietveld logging. It was suppressed before to avoid making
       
  5967         webkit-patch upload too noisy.
       
  5968 
       
  5969         * Scripts/webkitpy/common/net/rietveld.py:
       
  5970 
       
  5971 2010-05-25  Antonio Gomes  <tonikitoo@webkit.org>
       
  5972 
       
  5973         Reviewed by Ojan Vafai.
       
  5974 
       
  5975         [Qt] Expose the editing behavior setting in DRT to test all editing code paths
       
  5976         https://bugs.webkit.org/show_bug.cgi?id=39680
       
  5977 
       
  5978         Implement LayoutTestController::setEditingBehavior in Qt's DRT.
       
  5979 
       
  5980         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
       
  5981         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
       
  5982         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
       
  5983         (LayoutTestController::setEditingBehavior):
       
  5984 
       
  5985 2010-05-25  Kevin Ollivier  <kevino@theolliviers.com>
       
  5986 
       
  5987         [wx] Build fix after API change and addition of WebCore/platform/text/transcoder dir. 
       
  5988 
       
  5989         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
       
  5990         (LayoutTestController::setEditingBehavior):
       
  5991         * wx/build/settings.py:
       
  5992 
       
  5993 2010-05-24  Antonio Gomes  <tonikitoo@webkit.org>
       
  5994 
       
  5995         Reviewed by Eric Seidel and Kent Tamura (for the Chromium part).
       
  5996 
       
  5997         editingBehavior settings needs to be set back to a reasonable default between tests
       
  5998         https://bugs.webkit.org/show_bug.cgi?id=39433
       
  5999 
       
  6000         Similarly to r59861, hard code the default setting during reset for Gtk and Chromium,
       
  6001         so that the serialized version of the setting stays in sync with expectations.
       
  6002 
       
  6003         * DumpRenderTree/chromium/TestShell.cpp:
       
  6004         (TestShell::resetWebSettings):
       
  6005         * DumpRenderTree/gtk/DumpRenderTree.cpp:
       
  6006         (resetDefaultsToConsistentValues):
       
  6007 
       
  6008 2010-05-24  Eric Seidel  <eric@webkit.org>
       
  6009 
       
  6010         Reviewed by Adam Barth.
       
  6011 
       
  6012         webkit-patch land calls scm.changed_files 4 times!
       
  6013         https://bugs.webkit.org/show_bug.cgi?id=39584
       
  6014 
       
  6015         * Scripts/webkitpy/tool/commands/download_unittest.py:
       
  6016          - Assert that we don't call modified_changelogs too often.
       
  6017         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
       
  6018          - Use cached changelogs list instead of calling modified_changelogs directly.
       
  6019         * Scripts/webkitpy/tool/steps/validatereviewer.py:
       
  6020          - ditto.
       
  6021 
       
  6022 2010-05-24  Kent Tamura  <tkent@chromium.org>
       
  6023 
       
  6024         Reviewed by Dimitri Glazkov.
       
  6025 
       
  6026         [DRT/Chromium] Import layout_test_helper for Windows
       
  6027         https://bugs.webkit.org/show_bug.cgi?id=39581
       
  6028 
       
  6029         Import Chromium win/layout_test_helper.cc as LayoutTestHelperWin.cpp.
       
  6030         http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/win/layout_test_helper.cc
       
  6031 
       
  6032         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Added.
       
  6033 
       
  6034 2010-05-24  Kent Tamura  <tkent@chromium.org>
       
  6035 
       
  6036         Reviewed by Dimitri Glazkov.
       
  6037 
       
  6038         [DRT/Chromium] Reset frame name
       
  6039         https://bugs.webkit.org/show_bug.cgi?id=39586
       
  6040 
       
  6041         This change fixes about 70 unexpected results.
       
  6042 
       
  6043         * DumpRenderTree/chromium/WebViewHost.cpp:
       
  6044         (WebViewHost::reset):
       
  6045 
       
  6046 2010-05-24  Marcus Bulach  <bulach@chromium.org>
       
  6047 
       
  6048         Reviewed by Kent Tamura.
       
  6049 
       
  6050         [chromium] Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
       
  6051         https://bugs.webkit.org/show_bug.cgi?id=39587
       
  6052 
       
  6053         * DumpRenderTree/chromium/WebViewHost.cpp:
       
  6054         (WebViewHost::geolocationService):
       
  6055 
       
  6056 2010-05-24  Robert Hogan  <robert@webkit.org>
       
  6057 
       
  6058         Reviewed by Laszlo Gombos.
       
  6059 
       
  6060         [Qt] DRT Support for removeOriginAccessWhitelistEntry
       
  6061 
       
  6062         Unskips http/tests/xmlhttprequest/origin-whitelisting-removal.html
       
  6063 
       
  6064         [Qt] DRT Support for removeOriginAccessWhitelistEntry
       
  6065         https://bugs.webkit.org/show_bug.cgi?id=39565
       
  6066 
       
  6067         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
       
  6068         (LayoutTestController::removeOriginAccessWhitelistEntry):
       
  6069 
       
  6070 2010-05-24  Marcus Bulach  <bulach@google.com>
       
  6071 
       
  6072         Reviewed by Ojan Vafai.
       
  6073 
       
  6074         _svn_branch_has_extra_commits needs to check for ^HEAD instead of ^head.
       
  6075         https://bugs.webkit.org/show_bug.cgi?id=39603
       
  6076 
       
  6077         * Scripts/webkitpy/common/checkout/scm.py:
       
  6078 
       
  6079 == Rolled over to ChangeLog-2010-05-24 ==