1 # Copyright (C) 2010 Google Inc. All rights reserved.

     2 #

     3 # Redistribution and use in source and binary forms, with or without

     4 # modification, are permitted provided that the following conditions are

     5 # met:

     6 #

     7 #    * Redistributions of source code must retain the above copyright

     8 # notice, this list of conditions and the following disclaimer.

     9 #    * Redistributions in binary form must reproduce the above

    10 # copyright notice, this list of conditions and the following disclaimer

    11 # in the documentation and/or other materials provided with the

    12 # distribution.

    13 #    * Neither the name of Google Inc. nor the names of its

    14 # contributors may be used to endorse or promote products derived from

    15 # this software without specific prior written permission.

    16 #

    17 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS

    18 # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT

    19 # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR

    20 # A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT

    21 # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,

    22 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT

    23 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,

    24 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY

    25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT

    26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

    27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

    28 

    29 import unittest

    30 

    31 from webkitpy.common.checkout.changelog import ChangeLogEntry

    32 from webkitpy.common.system.outputcapture import OutputCapture

    33 from webkitpy.tool.mocktool import MockOptions, MockTool

    34 from webkitpy.tool.steps.validatereviewer import ValidateReviewer

    35 

    36 class ValidateReviewerTest(unittest.TestCase):

    37     _boilerplate_entry = '''2009-08-19  Eric Seidel  <eric@webkit.org>

    38 

    39         REVIEW_LINE

    40 

    41         * Scripts/bugzilla-tool:

    42 '''

    43 

    44     def _test_review_text(self, step, text, expected):

    45         contents = self._boilerplate_entry.replace("REVIEW_LINE", text)

    46         entry = ChangeLogEntry(contents)

    47         self.assertEqual(step._has_valid_reviewer(entry), expected)

    48 

    49     def test_has_valid_reviewer(self):

    50         step = ValidateReviewer(MockTool(), MockOptions())

    51         self._test_review_text(step, "Reviewed by Eric Seidel.", True)

    52         self._test_review_text(step, "Reviewed by Eric Seidel", True) # Not picky about the '.'

    53         self._test_review_text(step, "Reviewed by Eric.", False)

    54         self._test_review_text(step, "Reviewed by Eric C Seidel.", False)

    55         self._test_review_text(step, "Rubber-stamped by Eric.", True)

    56         self._test_review_text(step, "Rubber stamped by Eric.", True)

    57         self._test_review_text(step, "Unreviewed build fix.", True)