--- a/uiacceltk/hitchcock/goommonitor/src/goomactionlist.cpp Tue Jul 06 15:18:10 2010 +0300
+++ b/uiacceltk/hitchcock/goommonitor/src/goomactionlist.cpp Wed Aug 18 10:42:48 2010 +0300
@@ -163,20 +163,6 @@
{
// Get the config for this plugin
CGOomRunPluginConfig& pluginConfig = aConfig.GetPluginConfig(iPluginList->Uid(pluginIndex));
- TInt priority = pluginConfig.CalculatePluginPriority(aWindowGroupList);
-
- TGOomSyncMode syncMode = pluginConfig.iSyncMode;
- TInt ramEstimate = pluginConfig.iRamEstimate;
-
- TActionRef::TActionType actionType;
-
- if (pluginConfig.PluginType() == EGOomAppPlugin)
- {
- actionType = TActionRef::EAppPlugin;
- }
- else
- actionType = TActionRef::ESystemPlugin;
-
//get skip plugin config for foreground app
TUint foregroundUid = iMonitor.ForegroundAppUid();
@@ -197,12 +183,27 @@
continue ; //skip this and continue with next plugin
}
}
-
- TActionRef ref = TActionRef(actionType, priority, syncMode, ramEstimate, *(iRunPluginActions[actionsIndex]), aWindowGroupList.GetIndexFromAppId(pluginConfig.TargetApp()));
- iAppsProtectedByPlugins.Append(pluginConfig.TargetApp());
- TRACES2("Creating Plugin Action Item %x , TargetAppId %x", iPluginList->Uid(pluginIndex), pluginConfig.TargetApp());
- //It is valid to have plugins with equal priority
- User::LeaveIfError(iActionRefs.InsertInOrderAllowRepeats(ref, ComparePriorities));
+
+ actionsIndex--;
+ CGOomRunPluginConfig * nextConfigForSamePlugin = &pluginConfig;
+ while(nextConfigForSamePlugin)
+ {
+ TInt priority = nextConfigForSamePlugin->CalculatePluginPriority(aWindowGroupList);
+ TGOomSyncMode syncMode = nextConfigForSamePlugin->iSyncMode;
+ TInt ramEstimate = nextConfigForSamePlugin->iRamEstimate;
+ TActionRef::TActionType actionType;
+ if (nextConfigForSamePlugin->PluginType() == EGOomAppPlugin)
+ actionType = TActionRef::EAppPlugin;
+ else
+ actionType = TActionRef::ESystemPlugin;
+
+ TActionRef ref = TActionRef(actionType, priority, syncMode, ramEstimate, *(iRunPluginActions[++actionsIndex]), aWindowGroupList.GetIndexFromAppId(nextConfigForSamePlugin->TargetApp()));
+ iAppsProtectedByPlugins.Append(nextConfigForSamePlugin->TargetApp());
+ TRACES2("Creating Plugin Action Item %x , TargetAppId %x", iPluginList->Uid(pluginIndex), nextConfigForSamePlugin->TargetApp());
+ //It is valid to have plugins with equal priority
+ User::LeaveIfError(iActionRefs.InsertInOrderAllowRepeats(ref, ComparePriorities));
+ nextConfigForSamePlugin = nextConfigForSamePlugin->iNextConfig;
+ }
actionsIndex++;
}
@@ -230,6 +231,8 @@
*/
iRunningKillAppActions = ETrue;
+ TInt oldcount = iActionRefs.Count();
+
if (aWindowGroupList.Count())
{
// Go through each item in the wglist, create an app close action for this application
@@ -252,6 +255,12 @@
// This sets the window group name
TInt32 appId = aWindowGroupList.AppId(wgIndex, ETrue);
+ if(AppCloseActionAlreadyExists(aWindowGroupList, appId))
+ {
+ wgIndex--;
+ continue;
+ }
+
CApaWindowGroupName* wgName = aWindowGroupList.WgName();
__ASSERT_DEBUG(wgName, GOomMonitorPanic(KInvalidWgName));
@@ -314,10 +323,24 @@
}
}
- TRACES1("BuildActionListL: Action list built with %d items",iActionRefs.Count());
+ TRACES1("BuildActionListL: Action list built with %d new items",iActionRefs.Count()- oldcount);
}
+TBool CGOomActionList::AppCloseActionAlreadyExists(CGOomWindowGroupList& aWindowGroupList, TInt32 appId)
+ {
+ for(TInt i = 0 ; i < iActionRefs.Count() ; i++)
+ {
+ TActionRef ref = iActionRefs[i];
+ if(ref.Type() == TActionRef::EAppClose )
+ {
+ if(aWindowGroupList.AppIdfromWgId(ref.WgId(), ETrue) == appId)
+ return ETrue;
+ }
+ }
+ return EFalse;
+ }
+
// Execute the OOM actions according to their priority
// Run batches of OOM actions according to their sync mode
void CGOomActionList::FreeMemory(TInt aMaxPriority)
@@ -364,48 +387,9 @@
ref.iAppPlugin = action;
- //Double checking again if this app is now in foreground, if yes then we dont kill
- CApaWindowGroupName* wgName = CApaWindowGroupName::NewLC(iWs, iWs.GetFocusWindowGroup());
-
- TInt32 fgApp = wgName->AppUid().iUid;
TInt32 appId = iMonitor.GetWindowGroupList()->AppIdfromWgId(ref.WgId(), ETrue);
-
- if(appId == fgApp)
- {
- TRACES1("Foreground App wgid %x, spared by GOOM", appId);
-
- iCurrentActionIndex++;
- CleanupStack::PopAndDestroy();
- continue;
- }
- //check if this is not parent of foreground app
- TBool spared = EFalse;
- TRACES1("CGOomActionList::FreeMemory - Going to kill Appid %x ",appId);
- TInt prevWgId = 0;
- while(prevWgId != KErrNotFound)
- {
- wgName->FindByAppUid(wgName->AppUid(), iWs, prevWgId);
-
- if(prevWgId == KErrNotFound)
- break;
-
- TInt parentId = 0;
- TRAPD(err, parentId = iMonitor.GetWindowGroupList()->FindParentIdL(prevWgId));
- TRACES2("CGOomActionList::FreeMemory - Foreground App wgid %d, parent wgid %d",prevWgId, parentId);
- if( err == KErrNone && parentId != 0)
- {
- TInt32 parentAppId = iMonitor.GetWindowGroupList()->AppIdfromWgId(parentId, ETrue);
- if(parentAppId == appId)
- {
- TRACES3("Parent App %x (wgId %d), of Foreground App %x, spared by GOOM", parentAppId, parentId, fgApp);
- spared = ETrue;
- break;
- }
- }
- }
- CleanupStack::PopAndDestroy();
- if(spared)
+ if(!IsOkToKillApp(appId))
{
iCurrentActionIndex++;
if (iCurrentActionIndex >= iActionRefs.Count())
@@ -427,6 +411,7 @@
iFreeingMemory = ETrue;
TRACES2("CGOomActionList::FreeMemory: Running action %d which has priority %d", iCurrentActionIndex,ref.Priority());
+ iCurrentActionIndex++;
action->FreeMemory(iCurrentTarget - memoryEstimate, iUseSwRendering);
iCurrentPluginRun = 0;
memoryFreeingActionRun = ETrue;
@@ -449,18 +434,16 @@
if ((ref.SyncMode() == ECheckRam)
|| (numberOfRunningActions >= maxBatchSize)
|| estimatedEnoughMemoryFreed
- || globalConfig.ForceCheckAtPriority(iActionRefs[iCurrentActionIndex].Priority()))
+ || globalConfig.ForceCheckAtPriority(iActionRefs[iCurrentActionIndex-1].Priority()))
// If this actions requires a RAM check then wait for it to complete
// Also force a check if we've reached the maximum number of concurrent operations
// Also check if we estimate that we have already freed enough memory (assuming that the sync mode is "estimate"
{
// Return from the loop - we will be called back (in CGOomActionList::StateChanged()) when the running actions complete
- iCurrentActionIndex++;
TRACES("CGOomActionList::FreeMemory: Exiting run action loop");
return;
}
// ... otherwise continue running actions, don't wait for any existing ones to complete
- iCurrentActionIndex++;
if (iCurrentActionIndex >= iActionRefs.Count())
{
@@ -493,6 +476,55 @@
}
}
+TBool CGOomActionList::IsOkToKillApp(TInt aAppId)
+ {
+
+ //Double checking again if this app is now in foreground, if yes then we dont kill
+ TUid fgAppuid = TUid::Uid(iMonitor.ForegroundAppUid());
+ TInt32 fgApp = fgAppuid.iUid;
+ TRACES1("Foreground Appuid %x", fgApp);
+
+ if (aAppId == fgApp)
+ {
+ TRACES1("Foreground App wgid %x, spared by GOOM", aAppId);
+ return EFalse;
+ }
+
+ //check if this is not parent of foreground app
+ TBool spared = EFalse;
+ TRACES2("CGOomActionList::FreeMemory - Going to kill Appid %x, Foreground app %x ", aAppId, fgApp);
+ TInt prevWgId = 0;
+
+ CApaWindowGroupName::FindByAppUid(fgAppuid, iWs, prevWgId);
+ TInt i = 0;
+ while ((prevWgId == KErrNotFound) && (i++ < 3)) //try 3 times before quiting. It takes time to get the wgid info when app is starting
+ {
+ TRACES1("Cannot find any more parent, trying again %d",i);
+ User::After(200000);
+ prevWgId = 0;
+ CApaWindowGroupName::FindByAppUid(fgAppuid, iWs, prevWgId);
+ }
+
+ while (prevWgId != KErrNotFound)
+ {
+ TInt parentId = 0;
+ TRAPD(err, parentId = iMonitor.GetWindowGroupList()->FindParentIdL(prevWgId));
+ TRACES3("CGOomActionList::FreeMemory - Foreground App AppId %x, wgid %d, parent wgid %d", fgApp, prevWgId, parentId);
+ if (err == KErrNone && parentId > 0)
+ {
+ TInt32 parentAppId = iMonitor.GetWindowGroupList()->AppIdfromWgId(parentId, ETrue);
+ if (parentAppId == aAppId)
+ {
+ TRACES3("Parent App %x (wgId %d), of Foreground App %x, spared by GOOM", parentAppId, parentId, fgApp);
+ spared = ETrue;
+ break;
+ }
+ }
+ CApaWindowGroupName::FindByAppUid(fgAppuid, iWs, prevWgId);
+ }
+ return !spared;
+ }
+
// Should be called when the memory situation is good
// It results in notifications of the good memory state to all plugins with an outstanding FreeMemory request
void CGOomActionList::MemoryGood()
@@ -706,6 +738,7 @@
}
else
{
+ iMonitor.SwitchMemMode(CMemoryMonitor::EGOomLowMemMode);
TRACES1("CGOomActionList::StateChanged: All current Plugin actions complete, below good threshold, Time to kill bad guys. freeMemory=%d", freeMemory);
iRunningKillAppActions = ETrue;
iMonitor.RunCloseAppActions(iMaxPriority);
@@ -751,6 +784,14 @@
CGOomRunPlugin* action = CGOomRunPlugin::NewL(iPluginList->Uid(pluginIndex), pluginConfig, *this, iPluginList->Implementation(pluginIndex));
iRunPluginActions.AppendL(action);
+
+ CGOomRunPluginConfig * nextConfigForSamePlugin = pluginConfig.iNextConfig;
+ while(nextConfigForSamePlugin)
+ {
+ CGOomRunPlugin* action = CGOomRunPlugin::NewL(iPluginList->Uid(pluginIndex), *(nextConfigForSamePlugin), *this, iPluginList->Implementation(pluginIndex));
+ iRunPluginActions.AppendL(action);
+ nextConfigForSamePlugin = nextConfigForSamePlugin->iNextConfig;
+ }
}
//references to v2 plugin types removed as these are not yet used by GOOM