=== Safari-111 ===

2003-10-24  Richard Williamson   <rjw@apple.com>

	Fixed 3425358.  Don't try to create page cache for pages that

	have a nil view().

        Reviewed by Hyatt.

        * kwq/WebCoreBridge.mm:

        (-[WebCoreBridge saveDocumentToPageCache]):

2003-10-24  David Hyatt  <hyatt@apple.com>

	Fix for 3133375, the minwidth computation for pres is wrong.  There were a couple of bugs here.

	One is that pres only should have a breakable character if they contain a newline.  Otherwise they're

	treated essentially like nowrap.  The other was that m_beginMinWidth and m_endMinWidth needed to be

	set to the maxwidth of the first line and the maxwidth of the last line respectively for pres instead of

	being only the first and last words.

        Reviewed by mjs

        * khtml/rendering/render_text.cpp:

        (RenderText::calcMinMaxWidth):

2003-10-24  David Hyatt  <hyatt@apple.com>

	Two fixes to the computation of min/max width for text runs.

	(1) Make sure that pre runs don't add in word-spacing to the last word on a line (e.g., when a newline explicitly

	breaks a pre).

	(2) Fix a bug where breakable characters weren't getting factored into minwidth properly.  When a word got broken

	because of a breakable character, we were treating the breakable character like a space, and not including its

	width as part of the minimum width of the text run.

        Reviewed by john

        * khtml/rendering/render_text.cpp:

        (RenderText::calcMinMaxWidth):

2003-10-23  David Hyatt  <hyatt@apple.com>

	This patch fixes the pseudo-elements ::first-line and ::first-letter to inherit styles properly.  More

	specifically it does the following:

	(1) Implements caching of pseudo-styles once computed off the style() which originated the pseudo-style.

	The old code did this, and this was a regression from my previous patch.

	(2) Fixes first-letter checking so that it happens at layout time rather than during render object

	construction time, since that makes first-letter more dynamic and causes it to be discovered in cases

	where it was being missed before.  This fixes the front page of meyerweb.com.

	(3) Make first-letter inherit from first-line like it's supposed to, and also make first-line styles

	cross blocks and inherit properly from enclosing containers.

	(4) Make first-letter changes cause a detach/attach to fire just as when the display changes.  I generalized

	the notion of needing to detach on a style change by making it a new kind of hint in dom_nodeimpl's style

	diff function.

	(5) Fixed isBlockFlow to return true for inline-blocks.

        Reviewed by john

        * khtml/rendering/render_block.cpp:

        (khtml::RenderBlock::addChildToFlow):

        (khtml::RenderBlock::layoutBlock):

        (khtml::RenderBlock::getFirstLineBox):

        (khtml::RenderBlock::firstLineBlock):

        (khtml::RenderBlock::updateFirstLetter):

        * khtml/rendering/render_block.h:

        (khtml::RenderBlock::isBlockFlow):

        * khtml/rendering/render_line.cpp:

        (InlineFlowBox::paintBackgroundAndBorder):

        * khtml/rendering/render_list.cpp:

        (RenderListItem::setStyle):

        * khtml/rendering/render_object.cpp:

        (RenderObject::RenderObject):

        (RenderObject::firstLineBlock):

        (RenderObject::updateFirstLetter):

        (RenderObject::dump):

        (RenderObject::setStyle):

        (RenderObject::recalcMinMaxWidths):

        (RenderObject::style):

        (RenderObject::getPseudoStyle):

        * khtml/rendering/render_object.h:

        (khtml::RenderObject::overhangingContents):

        * khtml/rendering/render_style.cpp:

        (pseudoBit):

        * khtml/rendering/render_style.h:

        (khtml::RenderStyle::):

        * khtml/rendering/render_table.cpp:

        (RenderTable::firstLineBlock):

        (RenderTable::updateFirstLetter):

        * khtml/rendering/render_table.h:

        * khtml/rendering/render_text.cpp:

        (RenderText::paintObject):

        (RenderText::htmlFont):

        * khtml/xml/dom_elementimpl.cpp:

        (ElementImpl::recalcStyle):

        * khtml/xml/dom_nodeimpl.cpp:

        (NodeImpl::diff):

        * khtml/xml/dom_nodeimpl.h:

        (DOM::NodeImpl::):

2003-10-23  Ken Kocienda  <kocienda@apple.com>

        Reviewed by David

	Fix for these bugs:

	<rdar://problem/3171929>: Safari picks a different button in a 

	form when you hit return if the first button has no name

	<rdar://problem/3200386>: investigate which button is activated 

	when hitting return in form text input fields

	HTML spec says that buttons must have names to be considered

	successful. However, other browsers do not impose this constraint.

	Therefore, we behave differently, and can use different buttons than

	the author intended.

        * khtml/html/html_formimpl.cpp:

        (HTMLButtonElementImpl::isSuccessfulSubmitButton)

        (HTMLInputElementImpl::isSuccessfulSubmitButton)

2003-10-22  David Hyatt  <hyatt@apple.com>

	Fix for 3460726, the user agent string was returning nil.  

	Fix for 3386544, empty documents did not get a layout, and so they looked white.  Also fixed the positioning

	of widgets to account for border/padding in updateWidgetPositions.

	Fix for espn.com crasher, 3458143, caused by layout object not being properly cleared when layouts were

	unscheduled.

        Reviewed by darin

        * khtml/khtmlview.cpp:

        * khtml/rendering/render_canvas.cpp:

        (RenderCanvas::RenderCanvas):

        * khtml/rendering/render_replaced.cpp:

        (RenderWidget::updateWidgetPositions):

        * kwq/KWQKHTMLPart.mm:

        (KWQKHTMLPart::userAgent):

2003-10-22  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by 

	- fixed 3460664 - Exception handlers not properly removed

        * kwq/KWQKHTMLPart.mm:

        (KWQKHTMLPart::mouseMoved): Don't return from exception block

        (KWQKHTMLPart::khtmlMouseReleaseEvent): Add exception blocking (whoops)

2003-10-22  John Sullivan  <sullivan@apple.com>

	- fixed 3460652 -- REGRESSION (100-110+): Can't tab out of a 

	frameset page

        Reviewed by Darin (actually he made the change on my machine)

        * khtml/html/html_baseimpl.cpp:

        (HTMLFrameSetElementImpl::defaultEventHandler):

	only set defaultHandled for the one event that we actually

	handle (mouse event to resize frame borders); this was always

	being set, hence preventing key events from being used elsewhere.

2003-10-22  Richard Williamson   <rjw@apple.com>

	Fixed 3454067.  RenderText's repaint wasn't called because of recent changes to de-virtualize repaint.  Modified getAbsoluteRepaintRect() to return containing block's getAbsoluteRepaintRect().

	Also removed the long standing +1 from QFontMetrics::height().

        Reviewed by Hyatt.

        * khtml/rendering/render_text.cpp:

        (RenderText::getAbsoluteRepaintRect):

        * khtml/rendering/render_text.h:

        * kwq/KWQFontMetrics.mm:

        (QFontMetrics::height):

2003-10-22  David Hyatt  <hyatt@apple.com>

	Fix visibility to be done when widgets are added or when styles are set rather than at paint time.  Fixes

	the ads painting on top of content at tvguide.com.

        Reviewed by cblu

        * khtml/rendering/render_replaced.cpp:

        (RenderWidget::setQWidget):

        (RenderWidget::setStyle):

        (RenderWidget::paintObject):

        * kwq/KWQWidget.h:

        * kwq/KWQWidget.mm:

        (QWidget::QWidget):

        (QWidget::show):

        (QWidget::hide):

2003-10-21  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dave.

	Finished exception blocking changes, so now I can finally say:

	- fixed 3137084 - Many non-reproducible crashers in ContextImp::mark / ScopeChain::mark

	- fixed 3308848 - nil-deref in KHTMLView::topLevelWidget

	- fixed 3311511 - nil deref inside KJS::Screen

	- fixed 3397422 - 7B51: Safari crashed in KJS::ObjectImp::mark()

	- fixed 3408373 - Panther7B58 : Safari Crashed in KJS::ObjectImp::mark

	- fixed 3409307 - 7B55: safari crashed in KJS::Interpreter::globalExec() (idle, nothing particular going on)

	- fixed 3410160 - 7B60 Safari crashed in KHTMLPart::parentPart called from JS while in the background

	- fixed 3413224 - unrepro crash in KJS::Window::mark

	- fixed 3419940 - unrepro crash in KJS::Collector::allocate trying to access http://www.lindyinthepalms.com

	- fixed 3420123 - Panther7B66: Safari crashed while going to http://www.tangents.co.uk/index2.html

	- fixed 3423225 - Safari crash in vtable for KWQMapImpl (vtable for KWQMapImpl + 8).

	- fixed 3437190 - nil-deref on quit in calling marked() from ScopeChain::mark()

        * WebCore.pbproj/project.pbxproj:

        * kwq/KWQFontMetrics.mm:

        * kwq/KWQPainter.mm:

        (QPainter::drawPixmap):

        (QPainter::drawTiledPixmap):

        (QPainter::_updateRenderer):

        * kwq/WebCoreTextRenderer.h:

2003-10-21  David Hyatt  <hyatt@apple.com>

	http://placenamehere.com/safari/fixedbgtest.html is now fixed with a patch from the KHTML trunk.

	Fixed backgrounds repeated when they weren't supposed to.

        * khtml/rendering/render_box.cpp:

        (RenderBox::paintBackgroundExtended):

2003-10-21  David Hyatt  <hyatt@apple.com>

	Change pseudo-element style resolution to be lazy and to not occur until the style is actually asked

	for by the front end render objects.  Also fix first-letter to inherit properly from first-line styles.

        Reviewed by mjs

        * khtml/css/cssstyleselector.cpp:

        (khtml::CSSStyleSelector::initForStyleResolve):

        (khtml::CSSStyleSelector::styleForElement):

        (khtml::CSSStyleSelector::pseudoStyleForElement):

        (khtml::CSSStyleSelector::checkSelector):

        (khtml::CSSStyleSelector::checkOneSelector):

        * khtml/css/cssstyleselector.h:

        * khtml/rendering/render_block.cpp:

        (khtml::RenderBlock::addChildToFlow):

        * khtml/rendering/render_container.cpp:

        (RenderContainer::updatePseudoChild):

        * khtml/rendering/render_object.cpp:

        (RenderObject::setStyle):

        (RenderObject::createInlineBox):

        (RenderObject::style):

        (RenderObject::getPseudoStyle):

        * khtml/rendering/render_object.h:

        * khtml/rendering/render_style.cpp:

        (pseudoBit):

        (RenderStyle::hasPseudoStyle):

        (RenderStyle::setHasPseudoStyle):

        (RenderStyle::getPseudoStyle):

        (RenderStyle::addPseudoStyle):

        * khtml/rendering/render_style.h:

        (khtml::RenderStyle::NonInheritedFlags::operator==):

        (khtml::RenderStyle::setBitDefaults):

        * khtml/rendering/render_text.cpp:

        (InlineTextBox::paintSelection):

        (RenderText::paintObject):

        (RenderText::htmlFont):

2003-10-21  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dave.

	More exception blocking.

        * kwq/KWQKHTMLPart.mm:

        (KWQKHTMLPart::~KWQKHTMLPart):

        (KWQKHTMLPart::generateFrameName):

        (KWQKHTMLPart::openURL):

        (KWQKHTMLPart::openURLRequest):

        (regExpForLabels):

        (KWQKHTMLPart::clearRecordedFormValues):

        (KWQKHTMLPart::recordFormValue):

        (KWQKHTMLPart::submitForm):

        (KHTMLPart::frameDetached):

        (KWQKHTMLPart::urlSelected):

        (KWQKHTMLPart::createPart):

        (KWQKHTMLPart::setTitle):

        (KWQKHTMLPart::setStatusBarText):

        (KWQKHTMLPart::scheduleClose):

        (KWQKHTMLPart::unfocusWindow):

        (KWQKHTMLPart::jumpToSelection):

        (KWQKHTMLPart::redirectionTimerStartedOrStopped):

        (KWQKHTMLPart::userAgent):

        (KWQKHTMLPart::mimeTypeForFileName):

        (KWQKHTMLPart::nextKeyView):

        (KWQKHTMLPart::currentEventIsMouseDownInWidget):

        (KWQKHTMLPart::openURLFromPageCache):

        (KWQKHTMLPart::saveDocumentState):

        (KWQKHTMLPart::restoreDocumentState):

        (KWQKHTMLPart::requestedURLString):

        (KWQKHTMLPart::incomingReferrer):

        (KWQKHTMLPart::runJavaScriptAlert):

        (KWQKHTMLPart::runJavaScriptConfirm):

        (KWQKHTMLPart::runJavaScriptPrompt):

        (KWQKHTMLPart::createEmptyDocument):

        (KWQKHTMLPart::keyEvent):

        (KWQKHTMLPart::khtmlMousePressEvent):

        (KWQKHTMLPart::passWidgetMouseDownEventToWidget):

        (KWQKHTMLPart::lastEventIsMouseUp):

        (findViewInSubviews):

        (KWQKHTMLPart::khtmlMouseMoveEvent):

        (KWQKHTMLPart::passSubframeEventToSubframe):

        (KWQKHTMLPart::buttonForCurrentEvent):

        (KWQKHTMLPart::stateForCurrentEvent):

        (KWQKHTMLPart::mouseDown):

        (KWQKHTMLPart::mouseDragged):

        (KWQKHTMLPart::mouseUp):

        (KWQKHTMLPart::sendFakeEventsAfterWidgetTracking):

        (KWQKHTMLPart::mouseMoved):

        (KWQKHTMLPart::sendContextMenuEvent):

        (fileWrapperForElement):

        (KWQKHTMLPart::attributedString):

        (KWQKHTMLPart::keyboardUIMode):

2003-10-21  Chris Blumenberg  <cblu@apple.com>

	Fixed: <rdar://problem/3176170>: OBJECT tag with no or empty TYPE is mishandled

        Reviewed by rjw.

        * kwq/KWQKHTMLPart.mm:

        (KWQKHTMLPart::createPart): call renamed frameRequiredForMIMEType:URL:

        * kwq/WebCoreBridge.h: renamed frameRequiredForMIMEType: to frameRequiredForMIMEType:URL:

2003-10-20  David Hyatt  <hyatt@apple.com>

	Fix generated content (before/after) so that it no longer has any restrictions on it.   CSS2.1 lifted 

	restrictions preventing the floating/positioning of generated content.

        Reviewed by rjw

        * khtml/css/cssstyleselector.cpp:

        (khtml::CSSStyleSelector::adjustRenderStyle):

        * khtml/rendering/render_container.cpp:

        (RenderContainer::updatePseudoChild):

2003-10-20  Ken Kocienda  <kocienda@apple.com>

        Reviewed by David

        * khtml/dom/dom2_events.cpp:

        (UIEvent::keyCode): Change over to use ascii value for key code.

        (UIEvent::which): Ditto.

        (KeyboardEvent::KeyboardEvent): New key event class which

	tracks the DOM Level 3 spec more closely.

        (KeyboardEvent::operator = ): New function.

        (KeyboardEvent::~KeyboardEvent): New function.

        (KeyboardEvent::ctrlKey): New function.

        (KeyboardEvent::shiftKey): New function.

        (KeyboardEvent::altKey): New function.

        (KeyboardEvent::metaKey): New function.

        (KeyboardEvent::altGraphKey): New function.

        (KeyboardEvent::initKeyboardEvent): New function.

        * khtml/dom/dom2_events.h: Ditto.

        * khtml/html/html_formimpl.cpp:

        (HTMLGenericFormElementImpl::defaultEventHandler): Use key 

	identifiers to test which key was pressed, instead of removed keyVal().

        (HTMLInputElementImpl::defaultEventHandler): Ditto.

        (HTMLSelectElementImpl::defaultEventHandler): Ditto.

        * khtml/html/html_inlineimpl.cpp:

        (HTMLAnchorElementImpl::defaultEventHandler): Change casts to match new

	class name. Use key identifiers to test which key was pressed, 

	instead of removed keyVal(). Use new modifier accessors.

        * khtml/xml/dom2_eventsimpl.cpp:

        (EventImpl::typeToId): Some reorganization of the constants in the

	switch statements. Name change for these to remove the KHTML_ prefix

	from the key up and key down events will happen soon.

        (EventImpl::idToType): Ditto.

        (KeyboardEventImpl::KeyboardEventImpl): New key event class which

        tracks the DOM Level 3 spec more closely.

        (KeyboardEventImpl::~KeyboardEventImpl): Ditto.

        (KeyboardEventImpl::initKeyboardEvent): Ditto.

        * khtml/xml/dom2_eventsimpl.h:

        (DOM::EventImpl::): Some reorganization of the constants in the

        switch statements. Name change for these to remove the KHTML_ prefix

        from the key up and key down events will happen soon.

        (DOM::KeyboardEventImpl::keyIdentifier): New function.

        (DOM::KeyboardEventImpl::keyLocation): New function.

        (DOM::KeyboardEventImpl::ctrlKey): New function.

        (DOM::KeyboardEventImpl::shiftKey): New function.

        (DOM::KeyboardEventImpl::altKey): New function.

        (DOM::KeyboardEventImpl::metaKey): New function.

        (DOM::KeyboardEventImpl::altGraphKey): New function.

        (DOM::KeyboardEventImpl::qKeyEvent): New function.

        * khtml/xml/dom_docimpl.cpp:

        (DocumentImpl::createEvent): Now can create keyboard events.

        * khtml/xml/dom_nodeimpl.cpp:

        (NodeImpl::dispatchKeyEvent): Class name changes.

        * kwq/KWQEvent.h: Added QString identifier member.

        * kwq/KWQEvent.mm:

        (hexDigit): Added helper.

        (identifierForKeyText): Added new function to map keys to DOM

	key identifiers as listed in the DOM spec.

        (QKeyEvent::identifier): Added accessor.

        * kwq/KWQKHTMLPart.mm:

        (KWQKHTMLPart::stateForCurrentEvent): Added check to see if

	a key press is on one of the numeric keypad keys.

        * kwq/KWQLogging.h: Added log constant for DOM events.

        * kwq/KWQLogging.m: Ditto

2003-10-20  David Hyatt  <hyatt@apple.com>

	Make first-letter and before/after work with text transforms.

        Reviewed by mjs

        * khtml/rendering/render_block.cpp:

        (khtml::RenderBlock::addChildToFlow):

        * khtml/rendering/render_container.cpp:

        (RenderContainer::updatePseudoChild):

        * khtml/rendering/render_text.cpp:

        (RenderText::setStyle):

        (RenderText::isTextFragment):

        (RenderText::originalString):

        (RenderText::setText):

        (m_generatedContentStr):

        (m_start):

        (RenderTextFragment::~RenderTextFragment):

        (RenderTextFragment::isTextFragment):

        (RenderTextFragment::originalString):

        * khtml/rendering/render_text.h:

        (khtml::RenderTextFragment::start):

        (khtml::RenderTextFragment::end):

        (khtml::RenderTextFragment::contentString):

        * khtml/xml/dom_nodeimpl.h:

        (DOM::NodeImpl::setRenderer):

2003-10-19  David Hyatt  <hyatt@apple.com>

	Remove the "flow-around-floats" hack for lists.  Other browsers don't do this.

        Reviewed by darin

        * khtml/css/quirks.css:

2003-10-19  David Hyatt  <hyatt@apple.com>

	Fix for a regression/crash on tivocommunity.com caused by faulty border-collapse code in the collapsedRightBorder

	case.  I forgot to deal with colspans.

        Reviewed by darin

        * khtml/rendering/render_table.cpp:

        (RenderTable::cellRight):

        (RenderTableCell::collapsedRightBorder):

2003-10-19  David Hyatt  <hyatt@apple.com>

	Patch from KHTML trunk that makes textareas work properly even when they have no render objects.

        * khtml/html/html_formimpl.cpp:

        (HTMLTextAreaElementImpl::encoding):

        (HTMLTextAreaElementImpl::value):

2003-10-18  Darin Adler  <darin@apple.com>

        Reviewed by Maciej.

        - fixed 3454444 -- contents of mailto form shows up in Mail title instead of body (IE sends mail directly)

        * kwq/KWQKURL.mm: (KURL::parse): Changed non-hierarchical code to consider everything

        after a question mark as a query, just the way the hierarchical code does. This makes

        the code that constructs the mailto URL work properly.

2003-10-18  David Hyatt  <hyatt@apple.com>

	Fix the intrinsic minmax width computation for blocks and XUL boxes to actually check fixed min/max CSS widths.

        Reviewed by darin

        * khtml/rendering/render_block.cpp:

        (khtml::RenderBlock::calcMinMaxWidth):

        * khtml/rendering/render_flexbox.cpp:

        (khtml::RenderFlexibleBox::calcMinMaxWidth):

2003-10-18  David Hyatt  <hyatt@apple.com>

	Change the names of the border-spacing properties to border-horizontal-spacing and border-vertical-spacing.

        * khtml/css/cssparser.cpp:

        (CSSParser::parseValue):

        * khtml/css/cssproperties.c:

        (findProp):

        * khtml/css/cssproperties.h:

        * khtml/css/cssproperties.in:

        * khtml/css/cssstyleselector.cpp:

        (khtml::CSSStyleSelector::applyRule):

2003-10-18  David Hyatt  <hyatt@apple.com>

	Fix for diveintomark className parsing bug.  class="bigblue blue" would fail to match a rule with .blue.

	The bug was in the selector matching code for class attributes.

	Also fixing a minmax width bug for blocks on the mozilla.org Web site.  XUL boxes had the same bug as

	well.

        Reviewed by darin

        * khtml/css/cssstyleselector.cpp:

        (khtml::CSSStyleSelector::checkOneSelector):

        * khtml/rendering/render_block.cpp:

        (khtml::RenderBlock::calcMinMaxWidth):

        * khtml/rendering/render_flexbox.cpp:

        (khtml::RenderFlexibleBox::calcMinMaxWidth):

2003-10-18  David Hyatt  <hyatt@apple.com>

	Fix for 3443502, generated content sometimes doesn't generate.  The bug is caused by an

	uninitialized variable.  m_isContinuation needed to be set to false in the RenderInline

	constructor.

        * khtml/rendering/render_inline.cpp:

        (m_isContinuation):

2003-10-17  Darin Adler  <darin@apple.com>