2007-10-11  Mark Rowe  <mrowe@apple.com>

        Reviewed by Tim Hatcher.

        Fix for <rdar://problem/5488678>.  Disable debugging symbols in production builds for 10.4

        PowerPC to prevent a huge STABS section from being generated.

        * Configurations/Base.xcconfig:

2007-10-10  Alice Liu  <alice.liu@apple.com>

        Reviewed by Geoff Garen.

        Fixed <rdar://5464402> Crash when running fast/frames/onload-remove-iframe-crash.html in DRT

        createFrame() now returns a RefPtr instead of a raw Frame pointer. 

        Making this change improves the way we handle frames on Windows WebKit. 

        * WebCoreSupport/WebFrameLoaderClient.h:

        * WebCoreSupport/WebFrameLoaderClient.mm:

        (WebFrameLoaderClient::createFrame):

2007-10-04  Beth Dakin  <bdakin@apple.com>

        Reviewed by John Sullivan.

        Fix for <rdar://problem/5441823> REGRESSION (r25142, Tiger only): 

        Vertical scroll bar not redrawn properly when going back in history 

        (15033)

        This fix if-defs r25142 to be Leopard-only since it causes 

        correctness issues on Tiger and does not seem to have any 

        performance impact on Tiger either.

        * WebView/WebDynamicScrollBarsView.m:

        (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]):

        (-[WebDynamicScrollBarsView reflectScrolledClipView:]):

2007-10-04  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver.

        Switch to default level of debugging symbols to resolve <rdar://problem/5488678>.

        The "full" level appears to offer no observable benefits even though the documentation

        suggests it be used for dead code stripping.  This should also decrease link times.

        * Configurations/Base.xcconfig:

2007-10-04  Adele Peterson  <adele@apple.com>

        Reviewed by Darin.

        WebKit part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content

        * WebView/WebHTMLView.mm: (-[WebHTMLView becomeFirstResponder]): Pass in the FocusDirection.

2007-10-04  Darin Adler  <darin@apple.com>

        * WebView/WebHTMLView.mm: (-[WebHTMLView _updateActiveState]):

        Removed a bogus comment.

2007-10-02  Kevin Decker  <kdecker@apple.com>

        Reviewed by Mark Rowe.

        Re-added _minimumRequiredSafariBuildNumber. It turns out older version of Safari still rely

        on this method, so we need to keep it around at least until the next major Safari release.

        * StringsNotToBeLocalized.txt:

        * WebView/WebView.mm:

        (+[WebView _minimumRequiredSafariBuildNumber]):

        * WebView/WebViewPrivate.h:

2007-10-02  Kevin Decker  <kdecker@apple.com>

        Reviewed by John Sullivan.

        <rdar://problem/5517710> 

        * WebView/WebView.mm: Removed -[WebView _minimumRequiredSafariBuildNumber] because newer

         versions of Safari no longer use this method. This won't break existing Safaris because

         they always use a respondsToSelector check before calling this.

        * WebView/WebViewPrivate.h: Ditto. 

2007-09-27  John Sullivan  <sullivan@apple.com>

        Reviewed by Ollie

        - fixed <rdar://problem/5408186> REGRESSION (5522-5523.9): Safari leaks every browser window

        The leak started occurring when we removed the code to clear the delegates and the host window

        from Safari as part of the fix for 5479443. But it turns out that Safari code was masking a

        bug here in WebView: setHostWindow:nil needs to be called before setting _private->closed to

        YES, or it will do nothing at all, causing a world leak due to a circular reference between

        the window and the WebView.

        I toyed with a more complex fix, but this is the simplest one that retains the fix for 5479443

        while otherwise restoring the code order to be as close as possible to what it was before

        5479443 was fixed.

        * WebView/WebView.mm:

        (-[WebView _close]):

        Moved the call that sets _private->closed to YES to be after the code that clears the delegates

        and the host window. Added a comment about this order.

2007-09-27  Kevin Decker  <kdecker@apple.com>

        Rubber stamped by Darin.

        <rdar://problem/5493093>

        * WebKit.order: Added.

        * WebKit.xcodeproj/project.pbxproj:  We're changing from using an order file built by

         another team to using one we actually check into our project repository. Linker settings for

         Symbol Ordering Flags have been updated accordingly.

2007-09-26  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Adele Peterson.

        Fixed <rdar://problem/5507476> Promote cache model SPI to API

        Promoted cache model SPI to API. This was just a move, with some small 

        edits to the documentation (changing 'application' to 'WebView' in 

        some cases, since the interface is now per-WebView).

        * WebView/WebPreferences.h:

        * WebView/WebPreferences.m:

        (-[WebPreferences setCacheModel:]):

        (-[WebPreferences cacheModel]):

        * WebView/WebPreferencesPrivate.h:

2007-09-24  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Darin.

        <rdar://problem/5498016> Photoshop CS3: Adobe Help Viewer 1.1 crashes in 9A553

        WebKit started calling the mouseDidMoveOverElement delegate method with a nil dictionary in r14982.

        We originally intended to call this delegate method sometimes with a nil dictionary, but due to

        a bug dating back to WebKit 1.0 this delegate was never called with nil! Unfortunately we can't

        start calling this with nil since it will break Adobe Help Viewer, and possibly other clients.

        * WebView/WebView.mm:

        (-[WebView _mouseDidMoveOverElement:modifierFlags:]):

2007-09-21  Kevin Decker  <kdecker@apple.com>

        * Plugins/WebBaseNetscapePluginView.mm: Build fix. 

        The first argument of aglChoosePixelFormat() has changed from const AGLDevice *gdevs on Tiger to

        const void *gdevs on Leopard.

2007-09-20  Kevin Decker  <kdecker@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/5493093>

        Reduced launch time by lazily linking both the AGL and OpenGL frameworks until they are really needed.

        * Plugins/WebBaseNetscapePluginView.mm: Soft link all AGL and OpenGL functions used by

        WebBaseNetscapePluginView.

        * WebKit.xcodeproj/project.pbxproj: Removed AGL and OpenGL from the project.

2007-09-20  John Sullivan  <sullivan@apple.com>

        Build fix for stoooopid old PPC gcc compiler

        * WebCoreSupport/WebEditorClient.mm:

        (WebEditorClient::checkSpellingOfString):

        replace perfectly valid ?: syntax with if/else

2007-09-19  John Sullivan  <sullivan@apple.com>

        Reviewed by Darin Adler.

        - WebKit part of speculative fix for <rdar://problem/5490627>, about crashes constructing a

          String using the values filled in by checkSpellingOfString()

        * WebCoreSupport/WebEditorClient.mm:

        (WebEditorClient::checkSpellingOfString):

        convert NSNotFound to -1, since WebCore code expects -1 for this purpose. We already do this

        in checkGrammarOfString.

2007-09-19  Kevin Decker  <kdecker@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/5491066> soft link Accelerate.framework

        * Misc/WebGraphicsExtras.c:

        (WebConvertBGRAToARGB): Improve launch time performance and reduce vsize

        footprint by soft linking the Accelerate.framework.

        * WebKit.xcodeproj/project.pbxproj: Remove no longer needed frameworks.

2007-09-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Fixed <rdar://problem/5490204> In some cases, WebKit can make the 

        Foundation disk cache way too big or way too small

        Use the actual location of the foundation disk cache, rather than 

        the user's home directory, when determining how big to make it.

        * WebView/WebView.mm:

        (+[WebView _setCacheModel:]):

2007-09-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Fixed a hang due to an infinite script running in the window's unload 

        event handler, which may be the cause of <rdar://problem/5479443> 

        REGRESSION: Hang due to infinite JS recursion on close @ engadget.com 

        (onunload-based ad)

        * WebView/WebUIDelegatePrivate.h: Added FIXME.

        * WebView/WebView.h: Clarified headerdoc ambiguity about when delegate 

        methods stop firing.

        * WebView/WebView.mm:

        (-[WebView _close]): The fix: don't nil out our delegates until after

        detaching the FrameLoader, because the act of detaching the FrameLoader

        might fire important delegate methods, like webViewShouldInterruptJavaScript:.

        Don't do other tear-down either, because the unload event handler needs 

        to run in a fully constructed page.

        This change is fairly low risk because niling out our delegates is a 

        very recent, never-shipped feature in WebKit, so it's unlikely that any 

        apps rely on it in a crazy way.

2007-09-15  Darin Adler  <darin@apple.com>

        Reviewed by John Sullivan.

        - fix <rdar://problem/5391540> REGRESSION: Can't drag images from Safari to applications

          in the dock (Tiger Preview, others in Leopard)

        * Misc/WebNSPasteboardExtras.mm:

        (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):

        Re-implement code here that has been missing for the last couple of years since we

        did some image refactoring. Was pretty easy now that we can freely call C++ code

        in WebKit.

2007-09-14  Mark Rowe  <mrowe@apple.com>

        Build fix for Tiger.

        * WebView/WebArchive.m:

        (-[WebArchive initWithCoder:]): Use @catch(id) rather than @catch(...).

        * WebView/WebPreferences.m:

        (-[WebPreferences initWithCoder:]): Ditto.

        * WebView/WebResource.mm:

        (-[WebResource initWithCoder:]): Ditto.

        (-[WebResource _initWithPropertyList:]): Ditto.

2007-09-14  Darin Adler  <darin@apple.com>

        Reviewed by Geoff Garen and Tim Hatcher.

        - fixed <rdar://problem/5482745> initFromCoder: and initWithPropertyList: functions

          should guard against incorrect types

        * WebView/WebArchive.m:

        (isArrayOfClass): Added helper function.

        (-[WebArchive _initWithPropertyList:]): Tweaked function to remove the need for a

        type cast.

        (-[WebArchive initWithCoder:]): Added type checking for the main resource,

        subresources array, and subframe archives array. Also replaced NS_DURING with @try.

        * WebView/WebPreferences.m: (-[WebPreferences initWithCoder:]): Added type checking

        for the identifier and the values dictionary, including ensuring that it's a mutable

        dictionary.

        * WebView/WebResource.mm:

        (-[WebResource initWithCoder:]): Added type checking for all the fields.

        (-[WebResource _initWithPropertyList:]): Added type checking for the NSURLResponse.

        * WebKit.exp: Removed accidentally exported internal symbol; I checked and it's not

        used anywhere.

2007-09-13  Darin Adler  <darin@apple.com>

        Reviewed by Oliver.

        - fix <rdar://problem/5470457> REGRESSION: Input method inline hole is mishandled in text

          <input> elements with maxlength limit

        * WebView/WebHTMLView.mm:

        (-[WebHTMLView _selectionChanged]): Tweaked code a bit.

        (-[WebHTMLView markedRange]): Simplified logic, since markedTextNSRange works when there's

        no composition range.

        (-[WebHTMLView hasMarkedText]): Call directly to Editor instead of bridge.

        (-[WebHTMLView unmarkText]): Call new confirmComposition to make it clear that this is

        confirming text, not just unmarking it to discard it.

        (extractUnderlines): Added. Converts directly from an NSAttributedString to the

        CompositionUnderline vector that's used by WebCore.

        (-[WebHTMLView setMarkedText:selectedRange:]): Changed to use the new setComposition.

        (-[WebHTMLView insertText:]): Changed to use confirmComposition when appropriate, instead

        of relying on special behavior of Editor::insertText.

        (-[WebHTMLView _updateSelectionForInputManager]): Rewrote to use getCompositionSelection

        and confirmCompositionWithoutDisturbingSelection.

        * WebCoreSupport/WebEditorClient.h:

        * WebCoreSupport/WebEditorClient.mm:

        Removed obsolete markedTextAbandoned function.

2007-09-12  David Kilzer  <ddkilzer@apple.com>

        Rubber-stamped by Darin and reviewed by Adam.

        Removed import of unused icon database headers.

        * WebCoreSupport/WebFrameBridge.mm:

2007-09-11  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Darin.

        Remove the unused class_getMethodImplementation function.

        * Misc/WebNSObjectExtras.h:

2007-09-11  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Fixed CFNetwork version check so it actually works.

        * Misc/WebKitVersionChecks.h:

        * WebView/WebView.mm:

        (+[WebView _setCacheModel:]): Don't use NSVersionOfLinkTimeLibrary because

        we don't link against CFNetwork directly, so it returns -1. Also, use

        the proper hex encoding instead of decimal numbers.

2007-09-11  Darin Adler  <darin@apple.com>

        - redo fix for <rdar://problem/5472899> REGRESSION (TOT): Crash in FrameLoadDelegate loading stationery

        * WebView/WebView.mm:

        (getMethod): Added.

        (-[WebView _cacheResourceLoadDelegateImplementations]): Use getMethod.

        (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto.

2007-09-11  Darin Adler  <darin@apple.com>

        Rubber-stamped by Dave Harrison.

        * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

        Removed wkCreateURLPasteboardFlavorTypeName and wkCreateURLNPasteboardFlavorTypeName.

2007-09-11  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        - fix <rdar://problem/5472899> REGRESSION (TOT): Crash in FrameLoadDelegate loading stationery

        * Misc/WebNSObjectExtras.h:

        (class_getMethodImplementation): Added.

        (method_setImplementation): Added.

        * WebView/WebHTMLView.mm: (+[WebHTMLViewPrivate initialize]):

        * Carbon/HIViewAdapter.m: (+[HIViewAdapter bindHIViewToNSView:nsView:]):

        Remove old-ObjC code path, since WebNSObjectExtras.h now implements everything we need.

        * WebView/WebView.mm:

        (-[WebView _cacheResourceLoadDelegateImplementations]): Don't bother doing a separate

        respondsToSelector call, since class_getMethodImplementation will return 0 for selectors

        that we don't respond to. The bug fix is to actually set the cached pointer to 0.

        Also get rid of the unnecessary use of a macro; instead use the functions from

        WebNSObjectExtras.h on Tiger and the appropriate function directly on Leopard.

        (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto.

2007-09-11  Darin Adler  <darin@apple.com>

        Reviewed by Sam, Ollie.

        * WebView/WebView.mm: (+[WebView _setCacheModel:]): A slightly cleaner 64-bit

        fix for the NSURLCache capacity code in this file.

2007-09-11  Darin Adler  <darin@apple.com>

        Rubber-stamped by Mark Rowe.

        * Misc/WebNSPasteboardExtras.mm: Fix incorrect strings in my last check-in.

        The strings I checked in were wrong and were breaking layout tests too.

        These new ones match what WebKitSystemInterface was returning.

2007-09-10  Geoffrey Garen  <ggaren@apple.com>

        Fixed 64-bit build (I think).

        * WebView/WebView.mm:

        (max): Added. In 64-bit land, -diskCapacity magically starts returning

        unsigned long instead of unsigned, so we define a custom max() that's

        willing to compare unsigned to unsigned long.

2007-09-10  Darin Adler  <darin@apple.com>

        Reviewed by Tim Hatcher.

        - <rdar://problem/5471082> Removing WebURLPboardType from headers broke SPI-using applications

        Rolled out my fix for bug 4582212 and fixed it in a much simpler way.

        * Misc/WebNSPasteboardExtras.h:

        * Misc/WebNSPasteboardExtras.mm:

        * WebCoreSupport/WebPasteboardHelper.mm:

        * WebKit.exp:

        * WebView/WebHTMLView.mm:

        * WebView/WebView.mm:

        Rolled out the new PasteboardType functions and changed the PboardType globals to be initialized

        with constant values.

2007-09-10  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Darin.

        Always animate when calling _scrollTo.

        * WebView/WebFrameView.mm:

        (-[WebFrameView _scrollVerticallyBy:]):

        (-[WebFrameView _scrollHorizontallyBy:]):

2007-09-08  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        <rdar://problem/5434431> - Asynchronous Icon Database

        WebKit side of things

        Mainly, there are Notifications WebKit has to listen for now that tell it when to either call back into WebCore

        for some purpose or to send the webView:didReceiveIcon: delegate call

        Many smaller tweaks as well.

        * Misc/WebIconDatabase.h:

        * Misc/WebIconDatabase.mm:

        (defaultClient):

        (-[WebIconDatabase init]):

        (+[WebIconDatabase delayDatabaseCleanup]): Accessor so clients can prevent the thread from cleaning up the database

          before they've done all their necessary retaining of icons.

        (+[WebIconDatabase allowDatabaseCleanup]):

        (-[WebIconDatabase removeAllIcons]):

        (-[WebIconDatabase _isEnabled]):

        (-[WebIconDatabase _sendNotificationForURL:]):

        (-[WebIconDatabase _sendDidRemoveAllIconsNotification]):

        (-[WebIconDatabase _databaseDirectory]):

        (-[ThreadEnabler threadEnablingSelector:]): Quick and dirty class to enabled Cocoa multithreading

        (+[ThreadEnabler enableThreading]):

        (importToWebCoreFormat):

        * Misc/WebIconDatabaseInternal.h: Expose the internal methods of WebIconDatabase that are required by WebIconDatabaseClient

        * Misc/WebNSNotificationCenterExtras.h: Added. - Great utility class whose design was borrowed from Colloquy

          that allows the posting of a Cocoa notification on the main thread from *any* thread

        * Misc/WebNSNotificationCenterExtras.m: Added.

        (-[NSNotificationCenter postNotificationOnMainThreadWithName:object:]):

        (-[NSNotificationCenter postNotificationOnMainThreadWithName:object:userInfo:]):

        (-[NSNotificationCenter postNotificationOnMainThreadWithName:object:userInfo:waitUntilDone:]):

        (+[NSNotificationCenter _postNotificationName:]):

        * WebCoreSupport/WebFrameLoaderClient.h:

        * WebCoreSupport/WebFrameLoaderClient.mm:

        (WebFrameLoaderClient::dispatchDidReceiveIcon): Send the webView:didReceiveIcon: delegate call

        (WebFrameLoaderClient::registerForIconNotification):

        * WebCoreSupport/WebIconDatabaseClient.h: Added.

        * WebCoreSupport/WebIconDatabaseClient.mm: Added.

        (WebIconDatabaseClient::performImport):  Perform the Safari 2 icon import

        (WebIconDatabaseClient::dispatchDidRemoveAllIcons): Send the NSNotification

        (WebIconDatabaseClient::dispatchDidAddIconForPageURL): Ditto

        * WebView/WebView.mm:

        (-[WebView _receivedIconChangedNotification:]): Check and see if this notification is for this WebView's current URL by

          calling back into the IconDatabase

        (-[WebView _registerForIconNotification:]): Support for WebIconDatabaseClient

        (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Dispatch this delegate call as well as unregister for the notification

        * WebView/WebViewInternal.h:

        * WebKit.xcodeproj/project.pbxproj:

2007-09-07  Geoffrey Garen  <ggaren@apple.com>

        Suggested by Maciej Stachowiak.

        Added wKiosk Browser to the browser list. Pretty sweet app.

        * WebView/WebPreferences.m:

        (cacheModelForMainBundle):

2007-09-07  Geoffrey Garen  <ggaren@apple.com>

        Build fix.

        * WebView/WebView.mm:

        (+[WebView _setCacheModel:]):

2007-09-05  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler, Maciej Stachowiak, Mark Rowe, Tim Hatcher.

        Fixed <rdar://problem/5326009> Make non-browser WebKit clients have no 

        memory cache, or a very tiny one

        High level explanation:

            - Added SPI for specifying a cache model on a per-WebView basis. 

            (Hopefully, this will become API soon.) We balance competing

            cache models simply by using the largest one that pertains at a

            given time.

            - Added heuristic for guessing a default cache model in WebViews

            that don't specify one:

                1) Default to DocumentViewer for apps linked on or after this

                WebKit. Default to DocumentBrowser otherwise.

                2) Assign specific defaults to well-known clients based on 

                bundle ID.

                3) Grow the default to DocumentBrowser if a navigation takes 

                place.

            - As a part of the DocumentBrowser & PrimaryWebBrowser settings:

                1) Make the Foundation disk cache much much bigger than the 

                default 20MB, if space allows. (This is a hedge against a small 

                WebCore cache in DocumentBrowser mode, but also an all-around 

                win for page load speed.)