1 2002-12-03  Trey Matteson  <trey@apple.com>

     2 

     3 	Re-fix of 3113393 - Clients side redirects shouldn't always add item to back/forward list

     4 	Fix 3116980 - REGRESSION: Back button goes back twice

     5 	Fix 3099631 - assertion failure at http://www.calendarlive.com/ when pop-up blocking is off

     6 

     7 	The earlier fix for the first bug was to consider any redirect happening within one

     8 	second as a continuation of the previous load.  To fix the regressions I re-cast that

     9 	fix using a similar, pre-existing mechanism.

    10 

    11         Reviewed by: Richwill

    12 

    13         * WebView.subproj/WebFramePrivate.h:  Nuke shortRedirectComing, rename

    14 	instantRedirectComing to quickRedirectComing.

    15         * WebView.subproj/WebFramePrivate.m:

    16         (-[WebFrame _createOrUpdateItem]):  Remove code related to shortRedirectComing,

    17 	the fix that brought the regressions.

    18         (-[WebFrame _setState:]):  Don't cache the page we're leaving if we're doing

    19 	a redirect (since we don't want the redirecting page in the cache).

    20         (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]):  Above rename.

    21         (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]):  Above rename.

    22         (-[WebFrame _loadURL:intoChild:]):  Comment fix.

    23         (-[WebFrame _clientRedirectedTo:delay:fireDate:]):  Use 1 second instead of 0

    24 	seconds as the metric of a client redirect.  Do not consider whether the frame

    25 	state is completed as part of the decision.

    26         (-[WebFrame _clientRedirectCancelled]):  Above rename.

    27 

    28 2002-12-03  John Sullivan  <sullivan@apple.com>

    29 

    30         Reviewed by: Darin

    31 

    32 	- REALLY changed the default state for block pop-ups to be off.

    33 

    34         * WebView.subproj/WebPreferences.m:

    35         (+[WebPreferences load]):

    36 	change default for letting JavaScript open windows automatically

    37 	to YES

    38 

    39 2002-12-03  Darin Adler  <darin@apple.com>

    40 

    41 	- fixed 3117135 -- world leak: drag any image, get a leak of 1 WebFrame

    42 

    43         Reviewed by John.

    44 

    45         * WebView.subproj/WebHTMLView.m:

    46         (-[WebHTMLView mouseDragged:]): Retain the URL of the dragged image, not the entire

    47 	element dictionary. The element dictionary creates a reference cycle since it includes

    48 	a reference to the WebFrame.

    49         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use the URL rather than

    50 	extracting it from the dictionary with a WebElementImageURLKey.

    51 

    52         * WebView.subproj/WebHTMLViewPrivate.h: URL, not element dictionary.

    53         * WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): Release the

    54 	URL, not the element dictionary.

    55 

    56 2002-12-03  Richard Williamson   <rjw@apple.com>

    57 

    58         Added a preference to change the page cache size, i.e.:

    59         Alexander.app/Contents/MacOS/Alexander -WebKitPageCacheSizePreferenceKey 4

    60         

    61         Reviewed by: hyatt

    62 

    63         * History.subproj/WebBackForwardList.m:

    64         (+[WebBackForwardList setPageCacheSize:]):

    65         (+[WebBackForwardList pageCacheSize]):

    66         * WebView.subproj/WebPreferences.m:

    67         (+[WebPreferences load]):

    68         (-[WebPreferences _initialTimedLayoutSize]):

    69         (-[WebPreferences _pageCacheSize]):

    70         * WebView.subproj/WebPreferencesPrivate.h:

    71 

    72 2002-12-03  Richard Williamson   <rjw@apple.com>

    73 

    74         Fixed 3019986.  Use an array of font families instead of a single

    75         font family to support CSS family lists.

    76         r=hyatt

    77         

    78         * Misc.subproj/WebKitNSStringExtras.m:

    79         (-[NSString _web_widthForString:font:]):

    80         * Misc.subproj/WebStringTruncator.m:

    81         (+[WebStringTruncator rightTruncateString:toWidth:withFont:]):

    82         (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):

    83         * WebCoreSupport.subproj/WebTextRenderer.h:

    84         * WebCoreSupport.subproj/WebTextRenderer.m:

    85         (-[WebTextRenderer substituteFontForString:families:]):

    86         (-[WebTextRenderer substituteFontForCharacters:length:families:]):

    87         (-[WebTextRenderer widthForCharacters:length:]):

    88         (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:letterSpacing:wordSpacing:fontFamilies:]):

    89         (-[WebTextRenderer floatWidthForCharacters:stringLength:characterPosition:]):

    90         (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]):

    91         (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:letterSpacing:wordSpacing:fontFamilies:]):

    92         (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:fontFamilies:]):

    93         * WebCoreSupport.subproj/WebTextRendererFactory.h:

    94         * WebCoreSupport.subproj/WebTextRendererFactory.m:

    95         (-[WebTextRendererFactory fontWithFamilies:traits:size:]):

    96         (-[WebTextRendererFactory fontWithFamily:traits:size:]):

    97         (+[WebTextRendererFactory fallbackFontWithTraits:size:]):

    98         (-[WebTextRendererFactory cachedFontFromFamily:traits:size:]):

    99         (-[WebTextRendererFactory cachedFontFromFamilies:traits:size:]):

   100         (-[WebTextRendererFactory rendererWithFamilies:traits:size:]):

   101 

   102 2002-12-03  Chris Blumenberg  <cblu@apple.com>

   103 

   104 	Fixed: 3115073 - REGRESSION: plants.com is crashing in WebIconDB with bad retain count

   105 

   106 	The plants.com favicon was marked to be removed from disk and thus it had no retain count. The problem was that it was still on disk and _hasIconForIconURL would return YES. If hasIconForIconURL returns YES, its is ok to call  _setIconURL:forSiteURL:. Since there was no retain count, the assert in _setIconURL:forSiteURL: would be hit.

   107 

   108 	We now consider icons without retain counts to not exist even if they're on disk.

   109 

   110         * Misc.subproj/WebIconDatabase.m:

   111         (-[WebIconDatabase _updateFileDatabase]):

   112         (-[WebIconDatabase _setIconURL:forSiteURL:]):

   113 

   114 2002-12-03  Chris Blumenberg  <cblu@apple.com>

   115 

   116 	Fixed:

   117 	3112477 - REGRESSION: dropping image within window loads image in current window

   118 	Fix: Unregister the parent webview for dragging when the drag starts, reregister after the drag ends.

   119 

   120 	3116423 - Dragged images sometimes have the wrong promised-file file type

   121 	Fix: Make the - [NSView_web_dragPromisedImage...] method take a file type rather than deriving the file type from the URL

   122 

   123 	3115768 - REGRESSION: contextual menu item "copy url to clipboard" doesn't work

   124 	Fix: In [NSPastboard _web_writeURL:andTitle:withOwner:] adding pboard types  doesn't work for the general pasteboard, have to redeclare.

   125 

   126 	3116594 - Image on the drag pasteboard shouldn't have applied transparency and scaling

   127 	Fix: In - [NSView_web_dragPromisedImage...] put the original image on the pboard

   128 

   129 	Reviewed by John.

   130 

   131         * Misc.subproj/WebNSPasteboardExtras.m:

   132         (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): don't use addTypes as it doesn't work as I expected

   133         * Misc.subproj/WebNSViewExtras.h:

   134         * Misc.subproj/WebNSViewExtras.m:

   135         (-[NSView _web_dragPromisedImage:origin:URL:fileType:title:event:]): put the original image on the pboard, not the drag image

   136         * WebView.subproj/WebHTMLView.m:

   137         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):

   138         (-[WebHTMLView mouseDragged:]): call _web_dragPromisedImage

   139         (-[WebHTMLView draggedImage:endedAt:operation:]): call -[WebView _reregisterDraggedTypes]

   140         * WebView.subproj/WebImageView.m:

   141         (-[WebImageView mouseDragged:]): call _web_dragPromisedImage

   142         (-[WebImageView draggedImage:endedAt:operation:]): call -[WebView _reregisterDraggedTypes]

   143         * WebView.subproj/WebView.m:

   144         (-[WebView initWithFrame:]): call _reregisterDraggedTypes

   145         (-[WebView draggingEntered:]): simplified, don't need to check drag source

   146         * WebView.subproj/WebViewPrivate.h:

   147         * WebView.subproj/WebViewPrivate.m:

   148         (-[WebView _reregisterDraggedTypes]):

   149 

   150 2002-12-03  Darin Adler  <darin@apple.com>

   151 

   152 	- fixed 3114796 -- WORLD LEAKS: 1 WebFrame leaked on trivial source file with <html> tag only

   153 	(probably fixed a ton of other bugs too, since this always leaks)

   154 

   155 	Reviewed by Chris.

   156 

   157         * WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]):

   158 	Added a missing autorelease.

   159 

   160 2002-12-03  Darin Adler  <darin@apple.com>

   161 

   162 	Reviewed by Maciej.

   163 

   164         * WebView.subproj/WebView.m: Fixed a pair of strings that conflict.

   165         * English.lproj/Localizable.strings: Regenerated.

   166         * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

   167 

   168 2002-12-02  Trey Matteson  <trey@apple.com>

   169 

   170 	Refined bookmark notifications to be more detailed.  We now have added, removed,

   171 	willChange and didChange.

   172 

   173         * Bookmarks.subproj/WebBookmarkGroup.h:   New API.

   174         * Bookmarks.subproj/WebBookmarkGroup.m:

   175         (-[WebBookmarkGroup _sendNotification:forBookmark:children:]):

   176         (-[WebBookmarkGroup _setTopBookmark:]):

   177         (-[WebBookmarkGroup _bookmarkWillChange:]):

   178         (-[WebBookmarkGroup _bookmarkDidChange:]):

   179         (-[WebBookmarkGroup _bookmarkChildren:wereAddedToParent:]):

   180         (-[WebBookmarkGroup _bookmarkChildren:wereRemovedToParent:]):

   181 	All just small pieces of flow control for posting the notes.

   182         * Bookmarks.subproj/WebBookmarkGroupPrivate.h:  Internal methods for posting the notes.

   183         * Bookmarks.subproj/WebBookmarkLeaf.m:

   184         (-[WebBookmarkLeaf setTitle:]):  Post da note

   185         (-[WebBookmarkLeaf setURLString:]):  Post da note

   186         (-[WebBookmarkLeaf description]):  Added for debugging.

   187         * Bookmarks.subproj/WebBookmarkList.m:

   188         (-[WebBookmarkList setTitle:]):  Post da note

   189         (-[WebBookmarkList removeChild:]):  Post da note

   190         (-[WebBookmarkList insertChild:atIndex:]):  Post da note

   191         * Bookmarks.subproj/WebBookmarkProxy.m:

   192         (-[WebBookmarkProxy setTitle:]):  Post da note

   193         * English.lproj/StringsNotToBeLocalized.txt:  New strings.

   194         * WebKit.exp:   New strings.

   195 

   196 2002-12-02  Maciej Stachowiak  <mjs@apple.com>

   197 

   198 	- added original URL field to action dictionary so that policy delegates

   199 	can avoid prompting over and over on redirects.

   200 	

   201         * WebKit.exp:

   202         * WebView.subproj/WebControllerPolicyDelegate.h:

   203         * WebView.subproj/WebControllerPolicyDelegate.m:

   204         * WebView.subproj/WebDataSource.m:

   205         (-[WebDataSource initWithRequest:]):

   206         * WebView.subproj/WebDataSourcePrivate.m:

   207         (-[WebDataSource _startLoading:]):

   208         * WebView.subproj/WebFrame.m:

   209         (-[WebFrame loadRequest:]):

   210         * WebView.subproj/WebFramePrivate.h:

   211         * WebView.subproj/WebFramePrivate.m:

   212         (-[WebFrame _actionInformationForNavigationType:event:originalURL:]):

   213         (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):

   214         (-[WebFrame _addExtraFieldsToRequest:]):

   215         (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]):

   216         (-[WebFrame _postWithURL:data:contentType:triggeringEvent:]):

   217 

   218 2002-11-28  Darin Adler  <darin@apple.com>

   219 

   220         * Downloads.subproj/WebDownloadHandler.m:

   221         (-[WebDownloadHandler createFileIfNecessary]): Add a FIXME.

   222         (-[WebDownloadHandler writeDataForkData:resourceForkData:]): Notify that the file system has

   223 	changed so the Finder can respond to the size change.

   224         (-[WebDownloadHandler finishedLoading]): Notify that the file system has changed now that the

   225 	download has completed and the files are closed (may be redundant now that we have the above,

   226 	but will do no harm).

   227 

   228         * Plugins.subproj/WebBaseNetscapePluginView.m:

   229         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):

   230 	Use _web_isCaseInsensitiveEqualToString instead of lowercaseString.

   231 

   232         * Misc.subproj/WebNSViewExtras.m: Tweak formatting.

   233 	

   234 2002-11-27  Richard Williamson   <rjw@apple.com>

   235 

   236         Fixed 3113393.  Client side redirects that happen <= 1 second

   237         update the current back/forward item, rather than creating

   238         a new one.

   239 

   240         * WebView.subproj/WebFramePrivate.h:

   241         * WebView.subproj/WebFramePrivate.m:

   242         (-[WebFrame _addBackForwardItemClippedAtTarget:]):

   243         (-[WebFrame _createOrUpdateItem]):

   244         (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]):

   245         (-[WebFrame _transitionToCommitted:]):

   246         (-[WebFrame _clientRedirectedTo:delay:fireDate:]):

   247         (-[WebFrame _clientRedirectCancelled]):

   248 

   249 2002-11-27  Richard Williamson   <rjw@apple.com>

   250 

   251         Fixed measurement error for Ahem font (and any font that

   252         has a tiny fractional value). 3112745, 3112742

   253          

   254         * WebCoreSupport.subproj/WebTextRenderer.m:

   255         (-[WebTextRenderer initWithFont:]):

   256 

   257 2002-11-26  Chris Blumenberg  <cblu@apple.com>

   258 

   259 	Fixed: 3090834 - Launch WMP (Window Media Player) when encountering WMP content

   260 

   261 	Added contentURL to WebPluginError. 

   262 

   263         * Plugins.subproj/WebNetscapePluginDocumentView.m:

   264         (-[WebNetscapePluginDocumentView setDataSource:]):

   265         * Plugins.subproj/WebNetscapePluginPackage.m:

   266         (-[WebNetscapePluginPackage initWithPath:]):

   267         * Plugins.subproj/WebNullPluginView.m:

   268         (-[WebNullPluginView viewDidMoveToWindow]):

   269         * Plugins.subproj/WebPluginError.h:

   270         * Plugins.subproj/WebPluginError.m:

   271         (-[WebPluginErrorPrivate dealloc]):

   272         (-[WebPluginError dealloc]):

   273         * WebCoreSupport.subproj/WebBridge.m:

   274         (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]):

   275         (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]):

   276 

   277 === Alexander-34 ===

   278 

   279 2002-11-26  Richard Williamson   <rjw@apple.com>

   280 

   281         Only cache page if the load has completed.

   282         * WebView.subproj/WebFramePrivate.m:

   283         (-[WebFrame _setState:]):

   284 

   285 2002-11-26  Chris Blumenberg  <cblu@apple.com>

   286 

   287 	Removed some logging.

   288 

   289         * WebView.subproj/WebControllerPrivate.m:

   290         (+[WebController _supportedImageMIMETypes]):

   291 

   292 2002-11-26  Chris Blumenberg  <cblu@apple.com>

   293 

   294 	Fixed: 3112003 - Show standalone tiffs using AppKit not QT plug-in

   295 

   296 	We now dynamically check NSImage for supported image types when registering WebImageView's and WebImageRepresentation's supported MIME types. 

   297 

   298         * WebView.subproj/WebControllerPrivate.h:

   299         * WebView.subproj/WebControllerPrivate.m:

   300         (+[WebController _supportedImageMIMETypes]): convert NSImage types to mime types

   301         * WebView.subproj/WebDataSourcePrivate.m:

   302         (+[WebDataSource _repTypes]): use _supportedImageMIMETypes to register mime types of WebImageRepresentation

   303         * WebView.subproj/WebViewPrivate.m:

   304         (+[WebView _viewTypes]): use _supportedImageMIMETypes to register mime types of WebImageView

   305 

   306 2002-11-26  Chris Blumenberg  <cblu@apple.com>

   307 

   308 	Fixed: 3061174 - javascript: URLs sent by plugins don't work

   309 

   310 	For "Javascript:" URLs. 

   311 

   312         * Plugins.subproj/WebBaseNetscapePluginView.m:

   313         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): lowercase the scheme

   314 

   315 2002-11-26  Richard Williamson   <rjw@apple.com>

   316 

   317         More work on back/forward cache.  It's ready for

   318         more general testing.  Although, to be safe I've

   319         left it disabled by default for tomorrow's release.

   320         It will log when a page is save and restored from

   321         the page cache.

   322                 

   323         * WebCoreSupport.subproj/WebBridge.m:

   324         (-[WebBridge saveDocumentToPageCache:]):

   325         * WebView.subproj/WebDataSourcePrivate.m:

   326         (-[WebDataSource _startLoading:]):

   327         (-[WebDataSource _commitIfReady:]):

   328         (-[WebDataSource _loadIcon]):

   329         * WebView.subproj/WebFramePrivate.h:

   330         * WebView.subproj/WebFramePrivate.m:

   331         (-[WebFrame _transitionToCommitted:]):

   332         (-[WebFrame _setState:]):

   333         (-[WebFrame _loadItem:fromItem:withLoadType:]):

   334         (-[WebFrame _continueLoadRequestAfterNavigationPolicy:request:]):

   335         (-[WebFrame _setProvisionalDataSource:]):

   336 

   337 2002-11-25  Richard Williamson   <rjw@apple.com>

   338 

   339         Cleanup leaking objects in page cache.

   340         Cleaned up API a bit.

   341         

   342         * History.subproj/WebBackForwardList.h:

   343         * History.subproj/WebBackForwardList.m:

   344         (-[WebBackForwardList dealloc]):

   345         (+[WebBackForwardList setUsesPageCache:]):

   346         (+[WebBackForwardList usesPageCache]):

   347         (+[WebBackForwardList setPageCacheSize:]):

   348         (+[WebBackForwardList pageCacheSize]):

   349         * History.subproj/WebHistoryItem.h:

   350         * History.subproj/WebHistoryItem.m:

   351         (-[WebHistoryItem setHasPageCache:]):

   352         * WebCoreSupport.subproj/WebBridge.m:

   353         (-[WebBridge saveDocumentToPageCache:]):

   354         * WebKit.exp:

   355         * WebView.subproj/WebFramePrivate.m:

   356         (-[WebFrame _canCachePage]):

   357         (-[WebFrame _purgePageCache]):

   358         (-[WebFrame _setState:]):

   359         (-[WebFrame _continueLoadRequestAfterNavigationPolicy:request:]):

   360 

   361 2002-11-25  Richard Williamson   <rjw@apple.com>

   362 

   363         Changed ordering of cachability check.

   364         

   365         * WebView.subproj/WebFramePrivate.m:

   366         (-[WebFrame _setState:]):

   367 

   368 2002-11-25  Richard Williamson   <rjw@apple.com>

   369 

   370         Changes fro back/forward cache.

   371         

   372         * History.subproj/WebHistoryItem.h:

   373         * History.subproj/WebHistoryItem.m:

   374         (+[WebHistoryItem setUsePageCache:]):

   375         (+[WebHistoryItem usePageCache]):

   376         * WebCoreSupport.subproj/WebBridge.m:

   377         (-[WebBridge saveDocumentToPageCache:]):

   378         * WebView.subproj/WebFramePrivate.h:

   379         * WebView.subproj/WebFramePrivate.m:

   380         (-[WebFrame _detachFromParent]):

   381         (-[WebFrame _canCachePage]):

   382         (-[WebFrame _setState:]):

   383 

   384 2002-11-25  Chris Blumenberg  <cblu@apple.com>

   385 

   386 	Fixed 2 drag-related crashes. Oops.

   387 

   388         * Misc.subproj/WebNSViewExtras.m:

   389         (-[NSView _web_dragPromisedImage:fromOrigin:withURL:title:event:]): put nil at the end of the array list.

   390         * WebView.subproj/WebHTMLView.m:

   391         (-[WebHTMLView mouseDragged:]): retain self before drag

   392 

   393 2002-11-25  Chris Blumenberg  <cblu@apple.com>

   394 

   395 	- Allow missing icons to be restored when going to the page of the missing icon.

   396 

   397         * Misc.subproj/WebIconDatabase.m:

   398         (-[WebIconDatabase _setIconURL:forSiteURL:]):

   399 

   400 2002-11-25  Richard Williamson   <rjw@apple.com>

   401 

   402         Changes for back/forward.  Currently disabled.

   403 

   404         * History.subproj/WebHistoryItem.h:

   405         * History.subproj/WebHistoryItem.m:

   406         (-[WebHistoryItem dealloc]):

   407         (-[WebHistoryItem setPageCacheEnabled:]):

   408         (-[WebHistoryItem pageCache]):

   409         * Misc.subproj/WebKitLogging.h:

   410         * Misc.subproj/WebKitLogging.m:

   411         * WebCoreSupport.subproj/WebBridge.m:

   412         (-[WebBridge saveDocumentToPageCache:]):

   413         * WebView.subproj/WebDataSource.m:

   414         (-[WebDataSource startLoading]):

   415         * WebView.subproj/WebDataSourcePrivate.h:

   416         * WebView.subproj/WebDataSourcePrivate.m:

   417         (-[WebDataSource _startLoading:]):

   418         (-[WebDataSource _startLoading]):

   419         (-[WebDataSource _commitIfReady:]):

   420         (-[WebDataSource _commitIfReady]):

   421         (-[WebDataSource _setStoredInPageCache:]):

   422         (-[WebDataSource _storedInPageCache]):

   423         * WebView.subproj/WebFramePrivate.h:

   424         * WebView.subproj/WebFramePrivate.m:

   425         (-[WebFrame _transitionToCommitted:]):

   426         (-[WebFrame _canCachePage]):

   427         (-[WebFrame _purgePageCache]):

   428         (-[WebFrame _setState:]):

   429         (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]):

   430         (-[WebFrame _continueLoadRequestAfterNavigationPolicy:request:]):

   431 

   432 2002-11-25  Richard Williamson   <rjw@apple.com>

   433 

   434         Fixed exception thrown often when creating mouseover status text (3110186).

   435         

   436         * WebView.subproj/WebHTMLViewPrivate.m:

   437         (-[WebHTMLView _elementAtPoint:]):

   438 

   439 2002-11-25  Darin Adler  <darin@apple.com>

   440 

   441 	- fixed a problem I discovered in testing where multiple identical bookmarks confuse us

   442 

   443         * Bookmarks.subproj/WebBookmarkList.m:

   444         (-[WebBookmarkList removeChild:]): Use indexOfObjectIdenticalTo: and removeObjectIdenticalTo:

   445 	instead of containsObject: and removeObject:.

   446         (-[WebBookmarkList insertChild:atIndex:]): Use indexOfObjectIdenticalTo: instead of

   447 	containsObject: in the assertion.

   448 

   449 2002-11-25  Chris Blumenberg  <cblu@apple.com>

   450 

   451 	Fixed: 3084350 - No URL flavors provided for images

   452 

   453         * Misc.subproj/WebNSViewExtras.h:

   454         * Misc.subproj/WebNSViewExtras.m:

   455         (-[NSView _web_dragPromisedImage:fromOrigin:withURL:title:event:]): renamed, simplifies dragging an image

   456         (-[WebFilePromiseDragSource initWithSource:]): subclass of NSFilePromiseDragSource, to be used later

   457         (-[WebFilePromiseDragSource draggingSource]):

   458         (-[WebFilePromiseDragSource dealloc]):

   459         * WebView.subproj/WebHTMLView.m:

   460         (-[WebHTMLView mouseDragged:]): call _web_dragPromisedImage:fromOrigin:withURL:title:event:, retain self

   461         (-[WebHTMLView draggedImage:endedAt:operation:]): added, release self

   462         * WebView.subproj/WebImageView.m:

   463         (-[WebImageView mouseDragged:]): call _web_dragPromisedImage:fromOrigin:withURL:title:event:, retain self

   464         (-[WebImageView draggedImage:endedAt:operation:]): added, release self

   465         * WebView.subproj/WebView.m:

   466         (-[WebView isDocumentHTML]): call isKindOfClass instead of className

   467         (-[WebView draggingEntered:]): check for WebFilePromiseDragSource

   468 

   469 2002-11-24  Trey Matteson  <trey@apple.com>

   470 

   471 	Added URLString method to WebHistoryItem to avoid silly conversions between

   472 	NSURL and NSString.  When the dust settles with our plans for NSURL we can

   473 	rationalize this API with the rest of WebKit.

   474 

   475         * History.subproj/WebHistoryItem.h:

   476         * History.subproj/WebHistoryItem.m:

   477         (-[WebHistoryItem URLString]):

   478 

   479 2002-11-24  Chris Blumenberg  <cblu@apple.com>

   480 

   481 	Added element keys for the image ALT and link TITLE attributes. This will eventually be used to fix other bugs. Also made WebKit and WebCore use the same element keys to simplify the conversion of the element dictionary.

   482 

   483         * WebView.subproj/WebController.h:

   484         * WebView.subproj/WebController.m:

   485         * WebView.subproj/WebHTMLViewPrivate.m:

   486         (-[WebHTMLView _elementAtPoint:]):

   487 

   488 2002-11-24  Chris Blumenberg  <cblu@apple.com>

   489 

   490 	Fixed: 3109945 - Assertion failure in -[WebIconDatabase_largestIconFromDictionary:]

   491 	Added error strings for download decoding errors.

   492 

   493         * English.lproj/Localizable.strings: Added error strings for download decoding errors

   494         * English.lproj/StringsNotToBeLocalized.txt:

   495         * Misc.subproj/WebIconDatabase.m:

   496         (-[WebIconDatabase _loadIconDictionaries]): tweak

   497         (-[WebIconDatabase _updateFileDatabase]): more error checking to prevent assert

   498         (-[WebIconDatabase _setIconURL:forSiteURL:]): added asserts to prevent a site URL <-> icon URL mapping without a icon URL -> icon mapping

   499         (-[WebIconDatabase _largestIconFromDictionary:]): tweak

   500         * Misc.subproj/WebNSPasteboardExtras.m:

   501         (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): declare pboard types if none have been declared, else append types

   502         * WebView.subproj/WebView.m:

   503         (+[WebView initialize]): Added error strings for download decoding errors

   504 

   505 2002-11-24  Maciej Stachowiak  <mjs@apple.com>

   506 

   507 	- fixed 3067939 - no support for window.document.lastModified

   508 

   509         * WebView.subproj/WebDataSourcePrivate.m:

   510         (-[WebDataSource _commitIfReady]): Pass last modified date to WebCore.

   511         * WebView.subproj/WebFramePrivate.m:

   512         (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]): Pass

   513 	nil last modified date.

   514 

   515 2002-11-23  Chris Blumenberg  <cblu@apple.com>

   516 

   517 	Fixed: 3109835 - Download errors aren't communicated to client

   518 

   519 	Cleaned-up WebMainResourceClient and WebBaseResourceHandleDelegate a little.

   520 

   521         * Misc.subproj/WebIconDatabase.m:

   522         (-[WebIconDatabase defaultIconWithSize:]): tweak

   523         (-[WebIconDatabase releaseIconForSiteURL:]): don't retain site URL here 

   524         (-[WebIconDatabase _setIcon:forIconURL:]): tweak

   525         (-[WebIconDatabase _setIconURL:forSiteURL:]): tweak

   526         (-[WebIconDatabase _releaseIconForIconURLString:]): retain site URL here 

   527         (-[WebIconDatabase _releaseFutureIconForSiteURL:]): tweak

   528         (-[WebIconDatabase _sendNotificationForSiteURL:]): tweak

   529         * WebView.subproj/WebBaseResourceHandleDelegate.h:

   530         * WebView.subproj/WebBaseResourceHandleDelegate.m:

   531         (-[WebBaseResourceHandleDelegate cancelWithError:]): made public

   532         (-[WebBaseResourceHandleDelegate cancel]): cancel downloads too, call cancelWithError

   533         (-[WebBaseResourceHandleDelegate cancelQuietly]): call cancelWithError

   534         (-[WebBaseResourceHandleDelegate cancelledError]): tweak

   535         (-[WebBaseResourceHandleDelegate notifyDelegatesOfInterruptionByPolicyChange]): tweak

   536         * WebView.subproj/WebMainResourceClient.m:

   537         (-[WebMainResourceClient receivedError:]): stop downloadHandler if downloading, else notify controller

   538         (-[WebMainResourceClient cancel]): call receivedError

   539         (-[WebMainResourceClient checkContentPolicyForResponse:andCallSelector:]): tweak

   540         (-[WebMainResourceClient handle:didReceiveData:]): stop load for download errors, report error

   541         (-[WebMainResourceClient handleDidFinishLoading:]): call didFailLoadingWithError is download error

   542         (-[WebMainResourceClient handle:didFailLoadingWithError:]): call receivedError

   543 

   544 2002-11-22  Darin Adler  <darin@apple.com>

   545 

   546         * Misc.subproj/WebCoreStatistics.h:

   547         * Misc.subproj/WebCoreStatistics.m:

   548         (+[WebCoreStatistics javaScriptRootObjectClasses]):

   549 	Update for name change -- root object classes, not all live object classes.

   550 

   551 2002-11-22  Chris Blumenberg  <cblu@apple.com>

   552 

   553 	Fixed assertion while loading local files.

   554 

   555         * Misc.subproj/WebIconDatabase.m: we don't have icon URLs for files

   556         * WebView.subproj/WebDataSourcePrivate.m:

   557         (-[WebDataSource _loadIcon]): Only try loading favicon as the root of server if scheme is http or https. This isn't really a feature of other protocols.

   558 

   559 2002-11-22  Chris Blumenberg  <cblu@apple.com>

   560 

   561         * WebView.subproj/WebMainResourceClient.m:

   562         (-[WebMainResourceClient continueAfterContentPolicy:response:]): Added a FIXME around saveFilenameForResponse:andRequest: because the API expects a path but is asking for a filename.

   563 

   564 2002-11-22  Chris Blumenberg  <cblu@apple.com>

   565 

   566 	Fixed: 3104693 - QT movie doesn't show video while still downloading

   567 

   568 	The initial size of plug-in should be 0,0 instead of 1,1 or else we don't get the layout

   569 

   570         * Plugins.subproj/WebNetscapePluginDocumentView.m:

   571         (-[WebNetscapePluginDocumentView initWithFrame:]):

   572 

   573 2002-11-22  Chris Blumenberg  <cblu@apple.com>

   574 

   575 	Fixed: 3078737 - Crash in -[WebHistoryItem dealloc] after closing last window

   576 

   577         * Misc.subproj/WebIconDatabase.m:

   578         (-[WebIconDatabase releaseIconForSiteURL:]): retain the site URL string because it may get released from beneath

   579         (-[WebIconDatabase _updateFileDatabase]): tweak

   580         (-[WebIconDatabase _iconsForIconURLString:]): disable timings for deployment build

   581         (-[WebIconDatabase _setIconURL:forSiteURL:]): tweak

   582         (-[WebIconDatabase _releaseIconForIconURLString:]): tweak

   583         (-[WebIconDatabase _scaleIcon:toSize:]): disable timings for deployment build

   584         * Misc.subproj/WebIconDatabasePrivate.h:

   585         * WebView.subproj/WebDataSourcePrivate.m:

   586         (-[WebDataSource _updateIconDatabaseWithURL:]): new, does the db binding

   587         (-[WebDataSource _loadIcon]): call _updateIconDatabaseWithURL

   588 

   589 2002-11-22  Chris Blumenberg  <cblu@apple.com>

   590 

   591 	Attempt to fix: 3078737 - Crash in -[WebHistoryItem dealloc] after closing last window

   592 	I haven't found anything that would cause the crash. I did some clean-up, added asserts and error messages in hopes that this help me track this down.

   593 

   594         * Misc.subproj/WebIconDatabase.h:

   595         * Misc.subproj/WebIconDatabase.m:

   596         (-[WebIconDatabase init]):

   597         (-[WebIconDatabase iconForSiteURL:withSize:cache:]):

   598         (-[WebIconDatabase iconForSiteURL:withSize:]):

   599         (-[WebIconDatabase retainIconForSiteURL:]):

   600         (-[WebIconDatabase releaseIconForSiteURL:]):

   601         (-[WebIconDatabase delayDatabaseCleanup]):

   602         (-[WebIconDatabase allowDatabaseCleanup]):

   603         (-[WebIconDatabase _iconDictionariesAreGood]):

   604         (-[WebIconDatabase _loadIconDictionaries]):

   605         (-[WebIconDatabase _updateFileDatabase]):

   606         (-[WebIconDatabase _hasIconForSiteURL:]):

   607         (-[WebIconDatabase _iconsForIconURLString:]):

   608         (-[WebIconDatabase _iconForFileURL:withSize:]):

   609         (-[WebIconDatabase _setIcon:forIconURL:]):

   610         (-[WebIconDatabase _setIconURL:forSiteURL:]):

   611         (-[WebIconDatabase _retainIconForIconURLString:]):

   612         (-[WebIconDatabase _releaseIconForIconURLString:]):

   613         (-[WebIconDatabase _retainFutureIconForSiteURL:]):

   614         (-[WebIconDatabase _releaseFutureIconForSiteURL:]):

   615         (-[WebIconDatabase _releaseOriginalIconsOnDisk]):

   616         (-[WebIconDatabase _sendNotificationForSiteURL:]):

   617         (-[WebIconDatabase _addObject:toSetForKey:inDictionary:]):

   618         (-[WebIconDatabase _largestIconFromDictionary:]):

   619         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]):

   620         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]):

   621         (-[WebIconDatabase _scaleIcon:toSize:]):

   622         * Misc.subproj/WebIconDatabasePrivate.h:

   623         * WebKit.exp:

   624         * WebView.subproj/WebDataSourcePrivate.m:

   625         (-[WebDataSource _loadIcon]):

   626 

   627 2002-11-22  Richard Williamson   <rjw@apple.com>

   628 

   629         Fixed rendering issues associated with 3100120.

   630         We now correctly map surrogate pairs in UTF-16.  khtml still has

   631         issues dealing with characters outside BMP.  These are tracked

   632         with 3109251 and 3109258.

   633         

   634         Surrogate pairs are treated as exceptions and have their own character

   635         to glyph map.

   636         

   637         * Misc.subproj/WebUnicode.h:

   638         * Misc.subproj/WebUnicode.m:

   639         (shapedString):

   640         * WebCoreSupport.subproj/WebTextRenderer.h:

   641         * WebCoreSupport.subproj/WebTextRenderer.m:

   642         (glyphForUnicodeCharacter):

   643         (findLengthOfCharacterCluster):

   644         (-[WebTextRenderer substituteFontForString:]):

   645         (-[WebTextRenderer convertUnicodeCharacters:length:toGlyphs:]):

   646         (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:]):

   647         (-[WebTextRenderer extendUnicodeCharacterToGlyphMapToInclude:]):

   648         (-[WebTextRenderer extendCharacterToGlyphMapToInclude:]):

   649 

   650 2002-11-22  John Sullivan  <sullivan@apple.com>

   651 

   652         * Resources/url_icon.tiff:

   653 	new generic URL icon -- little blue globe, pretty nice

   654 

   655         * WebKit.exp:

   656 	removed symbol for WebTextRendererFactory which was in here

   657 	to support an obsolete SPI hack

   658 

   659 2002-11-22  Trey Matteson  <trey@apple.com>

   660 

   661 	Added more detailed notifications on history changes.

   662 	All changes below are just posting the new notes at the right time.

   663 

   664         * English.lproj/StringsNotToBeLocalized.txt:

   665         * History.subproj/WebHistory.h:

   666         * History.subproj/WebHistory.m:

   667         (-[WebHistory _sendNotification:entries:]):

   668         (-[WebHistory addEntry:]):

   669         (-[WebHistory removeEntry:]):

   670         (-[WebHistory removeEntries:]):

   671         (-[WebHistory removeAllEntries]):

   672         (-[WebHistory addEntries:]):

   673         (-[WebHistory loadHistory]):

   674         * WebKit.exp:

   675 

   676 2002-11-22  Richard Williamson   <rjw@apple.com>

   677 

   678         Changed NSString category methods to include _web_ prefix.

   679 

   680         * Misc.subproj/WebKitNSStringExtras.h:

   681         * Misc.subproj/WebKitNSStringExtras.m:

   682         (-[NSString _web_widthForString:font:]):

   683 

   684 2002-11-22  Richard Williamson   <rjw@apple.com>

   685 

   686         Simplified drawing and measuring SPI for use by Alex.

   687 

   688         * Misc.subproj/WebKitNSStringExtras.h: Added.

   689         * Misc.subproj/WebKitNSStringExtras.m: Added.

   690         (-[NSString widthForString:font:]):

   691         * WebKit.pbproj/project.pbxproj:

   692 

   693 2002-11-21  Chris Blumenberg  <cblu@apple.com>

   694 

   695 	Removed workaround for: 3093170 - Handle clients receive data with length 0

   696 

   697 	as it's now fixed.

   698 

   699         * Downloads.subproj/WebDownloadHandler.m:

   700         (-[WebDownloadHandler receivedData:]): remove workaround

   701         * WebView.subproj/WebMainResourceClient.m:

   702         (-[WebMainResourceClient handle:didReceiveData:]): added asserts

   703 

   704 2002-11-21  Richard Williamson   <rjw@apple.com>

   705 

   706         A different fix to 3078065 that doesn't depend on the appkit's idea of

   707         fixed pitch font.

   708         

   709         The fix is to adjust the width of all characters that have the same width

   710         as the space character to match the adjustment of the space character.

   711         This has the slight downside that non-monospace fonts that contain glyphs

   712         with the same width as the space character will have an extra adjustment.

   713         In practice this is not noticeable as the adjustment is always sub-pixel.

   714         Nor of course does this cause any mislayout, as it's done at the lowest

   715         level for both measurement and drawing.

   716         

   717         Until we move kthml internals to floats this will be just fine.

   718         

   719         * WebCoreSupport.subproj/WebTextRenderer.h:

   720         * WebCoreSupport.subproj/WebTextRenderer.m:

   721         (widthForGlyph):

   722         (-[WebTextRenderer initWithFont:]):

   723         (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:]):

   724 tAfterNavigationPolicy:request:]):

   725 

   726 2002-11-21  Maciej Stachowiak  <mjs@apple.com>

   727 

   728         * Makefile.am: Pass symroots for this tree to pbxbuild.

   729 

   730 2002-11-21  Chris Blumenberg  <cblu@apple.com>

   731 

   732 	Fixed: 3009881 - plugins get mouse-overs even when mouse is in menus

   733 	Fixed: 3108240 - Loading datasource sometimes doesn't have cancelled error when cancelled

   734 

   735         * Plugins.subproj/WebBaseNetscapePluginView.m:

   736         (-[WebBaseNetscapePluginView sendNullEvent]): check if menus are showing

   737         (-[WebBaseNetscapePluginView restartNullEvents]): tweak

   738         * WebView.subproj/WebDataSourcePrivate.m:

   739         (-[WebDataSource _stopLoading]): set cancelled error if main handle is gone

   740 

   741 === Alexander-33 ===

   742 

   743 2002-11-20  Darin Adler  <darin@apple.com>

   744 

   745         * Plugins.subproj/WebBaseNetscapePluginView.m:

   746         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):

   747 	Unescape the string before executing it, so we don't suffer from bug 3083043

   748 	here in the javascript: URLs that come from plug-ins.

   749 

   750         * English.lproj/StringsNotToBeLocalized.txt: Update.

   751 

   752 2002-11-20  Chris Blumenberg  <cblu@apple.com>

   753 

   754 	Fixed: 3079134 - Throttle plug-ins while in background

   755 

   756         * Plugins.subproj/WebBaseNetscapePluginView.h:

   757         * Plugins.subproj/WebBaseNetscapePluginView.m:

   758         (-[WebBaseNetscapePluginView sendNullEvent]): new

   759         (-[WebBaseNetscapePluginView stopNullEvents]): stops timer

   760         (-[WebBaseNetscapePluginView restartNullEvents]): stops timer if there is one, and starts a new one based on window activation state

   761         (-[WebBaseNetscapePluginView start]): call restartNullEvents

   762         (-[WebBaseNetscapePluginView stop]): call stopNullEvents

   763         (-[WebBaseNetscapePluginView windowBecameKey:]): call restartNullEvents

   764         (-[WebBaseNetscapePluginView windowResignedKey:]): call restartNullEvents

   765         (-[WebBaseNetscapePluginView windowDidMiniaturize:]): call stopNullEvents

   766         (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): call restartNullEvents

   767         * Plugins.subproj/WebNetscapePluginNullEventSender.h: Removed. No need for another class, use a timer.

   768         * Plugins.subproj/WebNetscapePluginNullEventSender.m: Removed. No need for another class, use a timer.

   769         * WebKit.pbproj/project.pbxproj:

   770 

   771 2002-11-20  Richard Williamson   <rjw@apple.com>

   772 

   773         Fixed 3107007.  Letter-spacing is causing width to be miscalculated.

   774         This also fixed some selection problems.

   775         

   776         * WebCoreSupport.subproj/WebTextRenderer.m:

   777         (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:]):

   778 

   779 2002-11-20  Richard Williamson   <rjw@apple.com>

   780 

   781         Fixed mono spaced fonts to always render with mono spacing! (3078065)

   782         

   783         * WebCoreSupport.subproj/WebTextRenderer.h:

   784         * WebCoreSupport.subproj/WebTextRenderer.m:

   785         (widthForGlyph):

   786         (-[WebTextRenderer initWithFont:]):

   787 

   788 2002-11-20  Chris Blumenberg  <cblu@apple.com>

   789 

   790 	Fixed: 3074926 - crash in BitsToPix() trying to print cnet page

   791 

   792         * Plugins.subproj/WebBaseNetscapePluginView.m:

   793         (-[WebBaseNetscapePluginView drawRect:]): disable experimental plug-in printing code.

   794 

   795 2002-11-20  Chris Blumenberg  <cblu@apple.com>

   796 

   797 	Minor clean-up, logging and more error checking in plug-in code.

   798 

   799         * Plugins.subproj/WebBaseNetscapePluginStream.m:

   800         (-[WebBaseNetscapePluginStream setResponse:]):

   801         (-[WebBaseNetscapePluginStream receivedData:]):

   802         (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):

   803         * Plugins.subproj/npapi.m:

   804         (NPN_UserAgent):

   805         (NPN_MemFree):

   806         (NPN_MemFlush):

   807         (NPN_ReloadPlugins):

   808 

   809 2002-11-20  Chris Blumenberg  <cblu@apple.com>

   810 	

   811 	Fixed: 3061174 - javascript: URLs sent by plugins don't work

   812 

   813         * Plugins.subproj/WebBaseNetscapePluginView.m:

   814         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):

   815 

   816 2002-11-20  Darin Adler  <darin@apple.com>

   817 

   818         * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

   819 

   820 2002-11-19  Chris Blumenberg  <cblu@apple.com>

   821 

   822 	Fixed: 3106061 - REGRESSION: Copy in text view copies all text not just selection

   823 

   824         * Misc.subproj/WebSearchableTextView.m:

   825         (-[WebSearchableTextView copy:]):

   826 

   827 2002-11-19  Chris Blumenberg  <cblu@apple.com>

   828 

   829 	Fixed: 3092588 - redraw errors in QT controller if window is in background

   830 

   831 	We need to send update events after we activate/deactivate after all.

   832 

   833         * Plugins.subproj/WebBaseNetscapePluginView.m:

   834         (-[WebBaseNetscapePluginView windowBecameKey:]):

   835         (-[WebBaseNetscapePluginView windowResignedKey:]):

   836 

   837 2002-11-19  Chris Blumenberg  <cblu@apple.com>

   838 

   839 	Fixed: 3020720 - dropping a folder in the page address makes the folder open in Finder, empties the field

   840 

   841         * Misc.subproj/WebNSPasteboardExtras.m:

   842         (-[NSPasteboard _web_bestURL]): Don't accept directories.

   843 

   844 2002-11-19  Chris Blumenberg  <cblu@apple.com>

   845 

   846 	Fixed: 3068112 - extra line breaks when copying from source window

   847 

   848         * Misc.subproj/WebSearchableTextView.m:

   849         (-[WebSearchableTextView copy:]): Convert CRLF to LF

   850 

   851 2002-11-19  David Hyatt  <hyatt@apple.com>

   852 

   853 	Make sure that if the scrollers are shown/hidden that we

   854 	force an immediate layout, since if we don't, an intervening

   855 	display can cause us to show scrollbars when they really

   856 	shouldn't be there.

   857 	

   858         * WebView.subproj/WebDynamicScrollBarsView.m:

   859         (-[WebDynamicScrollBarsView updateScrollers]):

   860 

   861 2002-11-19  Chris Blumenberg  <cblu@apple.com>

   862 

   863 	Fixed: 3100597 - repro NSArray exception using contextual menu

   864 

   865         * Misc.subproj/WebNSPasteboardExtras.m:

   866         (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): more error checking

   867 

   868 2002-11-19  Trey Matteson  <trey@apple.com>

   869 

   870 	Just a tweak to the description printout.

   871 

   872         * History.subproj/WebHistoryItem.m:

   873         (-[WebHistoryItem description]):

   874 

   875 2002-11-18  Chris Blumenberg  <cblu@apple.com>

   876 

   877 	Real fix for: 3104183 - Assert loading www.louisvuitton.com

   878 

   879 	Since we don't consider plug-in content as a subresource, attaching plug-in streams to the datasource has no affect on the loading state of the datasource. Both stopLoading on WebFrame and _stopLoading datasource, would not stop plug-ins streams after th

   880 e data source was done loading. Because of this, I've decided to not keep a list of plug-in streams attached to the data source and pulled my previous change. To fix this bug, WebBaseResourceHandleDelegate now retains the controller.

   881 

   882         * Plugins.subproj/WebNetscapePluginStream.m:

   883         (-[WebNetscapePluginStream start]):

   884         (-[WebNetscapePluginStream cancel]):

   885         (-[WebNetscapePluginStream handleDidFinishLoading:]):

   886         (-[WebNetscapePluginStream handle:didFailLoadingWithError:]):

   887         * WebView.subproj/WebBaseResourceHandleDelegate.h:

   888         * WebView.subproj/WebBaseResourceHandleDelegate.m:

   889         (-[WebBaseResourceHandleDelegate _releaseResources]):

   890         (-[WebBaseResourceHandleDelegate setDataSource:]):

   891         (-[WebBaseResourceHandleDelegate handle:willSendRequest:]):

   892         (-[WebBaseResourceHandleDelegate handleDidFinishLoading:]):

   893         (-[WebBaseResourceHandleDelegate handle:didFailLoadingWithError:]):

   894         (-[WebBaseResourceHandleDelegate _cancelWithError:]):

   895         * WebView.subproj/WebDataSourcePrivate.h:

   896         * WebView.subproj/WebDataSourcePrivate.m:

   897         (-[WebDataSourcePrivate dealloc]):

   898         (-[WebDataSource _stopLoading]):

   899         (-[WebDataSource _makeHandleDelegates:deferCallbacks:]):

   900         (-[WebDataSource _defersCallbacksChanged]):

   901 

   902 2002-11-18  Chris Blumenberg  <cblu@apple.com>

   903 

   904 	Fixed: 3104183 - Assert loading www.louisvuitton.com

   905 

   906 	We need to treat plug-in streams like subresources except they don't change the loading state of the data source.

   907 

   908         * Plugins.subproj/WebNetscapePluginStream.m:

   909         (-[WebNetscapePluginStream start]): call _addPluginStream

   910         (-[WebNetscapePluginStream cancel]): call _removePluginStream

   911         (-[WebNetscapePluginStream handleDidFinishLoading:]): call _removePluginStream

   912         (-[WebNetscapePluginStream handle:didFailLoadingWithError:]): call _removePluginStream

   913         * WebView.subproj/WebDataSourcePrivate.h:

   914         * WebView.subproj/WebDataSourcePrivate.m:

   915         (-[WebDataSourcePrivate dealloc]): release pluginStreams

   916         (-[WebDataSource _addPluginStream:]): just like addSubresourceClient except don't change the loading state.

   917         (-[WebDataSource _removePluginStream:]): just like removeSubresourceClient except don't change the loading state.

   918         (-[WebDataSource _stopLoading]): stop plug-ins streams

   919         (-[WebDataSource _makeHandleDelegates:deferCallbacks:]): 

   920         (-[WebDataSource _defersCallbacksChanged]): call _makeHandleDelegates:deferCallbacks: for subresources and plug-in streams.

   921 

   922 2002-11-18  Richard Williamson   <rjw@apple.com>

   923 

   924         Check for usesBackForwardList was excluding all load types.

   925         

   926         * WebView.subproj/WebFramePrivate.m:

   927         (-[WebFrame _transitionToCommitted]):

   928 

   929 2002-11-18  Chris Blumenberg  <cblu@apple.com>

   930 

   931 	Fixed: 3098767 - REGRESSION: standalone quicktime content just shows blank window

   932 

   933 	Check the instance not the class for the class type.

   934 

   935         * Plugins.subproj/WebNetscapePluginRepresentation.m:

   936         (-[WebNetscapePluginRepresentation receivedData:withDataSource:]):

   937 

   938 2002-11-18  Ken Kocienda  <kocienda@apple.com>

   939 

   940 	Added feature to import bookmarks/favorites from MSIE. This

   941 	fixes Radar 2961230 (import Mac IE bookmarks).

   942 

   943         * Bookmarks.subproj/WebBookmarkImporter.h: Added.

   944         * Bookmarks.subproj/WebBookmarkImporter.m: Added.

   945         (_breakStringIntoLines):

   946         (_HREFRangeFromSpec):

   947         (_HREFTextFromSpec):

   948         (_linkTextRangeFromSpec):

   949         (_linkTextFromSpec):

   950         (-[WebBookmarkImporter initWithPath:group:]):

   951         (-[WebBookmarkImporter topBookmark]):

   952         (-[WebBookmarkImporter error]):

   953         (-[WebBookmarkImporter dealloc]):

   954         * Bookmarks.subproj/WebBookmarkList.m:

   955         (-[WebBookmarkList init]): Create the bookmark list object. This

   956 	was not created with the -init initializer, causing bookmark lists

   957 	to fail.

   958         * English.lproj/Localizable.strings:

   959         * English.lproj/StringsNotToBeLocalized.txt:

   960         * WebKit.exp:

   961         * WebKit.pbproj/project.pbxproj:

   962 

   963 2002-11-17  Trey Matteson  <trey@apple.com>

   964 

   965 	Code cleanup to make some internal methods return autoreleased objects.

   966 

   967         * WebView.subproj/WebFramePrivate.m:

   968         (-[WebFrame _addBackForwardItemClippedAtTarget:]):

   969         (-[WebFrame _createItem]):

   970         (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]):

   971         (-[WebFrame _transitionToCommitted]):

   972 

   973 2002-11-17  Trey Matteson  <trey@apple.com>

   974 

   975 	Fixed 3102076 - REGRESSION: infinite recursion involving bridge end

   976 	Fixed 3100929 - REGRESSION: serverRedirectedForDataSource: not sent on server redirects

   977 	Fixed 3103381 - REGRESSION: Going back from anchor doesn't restore scroll position

   978 

   979         * WebView.subproj/WebBaseResourceHandleDelegate.m:

   980         (-[WebBaseResourceHandleDelegate handle:willSendRequest:]):  Return the copy of the

   981 	request that we make instead of the original.

   982         * WebView.subproj/WebMainResourceClient.m:

   983         (-[WebMainResourceClient handle:willSendRequest:]):  Call super after we make our mods

   984 	to the request, so the copy that super makes for us includes those mods.

   985 

   986         * WebView.subproj/WebFramePrivate.h:  Added new state, WebFrameStateCompleting.

   987         * WebView.subproj/WebFramePrivate.m:

   988         (-[WebFrame _transitionToLayoutAcceptable]):  Completing state is a NOP.

   989         (-[WebFrame _transitionToCommitted]):  Completing state is a NOP.

   990         (-[WebFrame _isLoadComplete]):  Go to Completing state before calling [bridge end].

   991 	Go to Completed state afterwards, only if no new loads started in the meantime.

   992         (-[WebFrame _loadItem:fromItem:withLoadType:]):  When doing anchor nav to get to the

   993 	item, save and restore scroll state, and set the current item.

   994         (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]):

   995 	Reorder the steps so the right scroll state gets saved to the right place.  Also, don't

   996 	add a backForward item if we're doing a client redirect to an anchor.

   997 

   998 2002-11-17  David Hyatt  <hyatt@apple.com>

   999 

  1000 	Back out my previous fix.  I have a better one that is

  1001 	confined to WebCore.

  1002 	

  1003         * WebView.subproj/WebFramePrivate.m:

  1004         (-[WebFrame _isLoadComplete]):

  1005 

  1006 2002-11-17  David Hyatt  <hyatt@apple.com>

  1007 

  1008 	The needsdisplay is necessary even for HTML documents.

  1009 	I over-optimized here.  Fixes the directory.apple.com

  1010 	regression and the santa clara library regression.

  1011 	

  1012         * WebView.subproj/WebFramePrivate.m:

  1013         (-[WebFrame _isLoadComplete]):

  1014 

  1015 2002-11-17  Darin Adler  <darin@apple.com>

  1016 

  1017 	- update for change to WebCore API so it never uses NSURL

  1018 

  1019         * WebCoreSupport.subproj/WebBridge.m:

  1020         (-[WebBridge createWindowWithURL:frameName:]): Take NSString instead of NSURL.

  1021         (-[WebBridge startLoadingResource:withURL:]): Ditto.

  1022         (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): Ditto.

  1023         (-[WebBridge reportClientRedirectToURL:delay:fireDate:]): Ditto.

  1024         (-[WebBridge setIconURL:]): Ditto.

  1025         (-[WebBridge setIconURL:withType:]): Ditto.

  1026         (-[WebBridge loadURL:reload:triggeringEvent:isFormSubmission:]): Ditto.

  1027         (-[WebBridge postWithURL:data:contentType:triggeringEvent:]): Ditto.

  1028         (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Ditto.

  1029         (-[WebBridge userAgentForURL:]): Ditto.

  1030         (-[WebBridge requestedURL]): Return NSString instead of NSURL.

  1031         (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): Take NSString instead of NSURL.

  1032         (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): Take NSString instead of NSURL.

  1033 

  1034         * WebCoreSupport.subproj/WebCookieAdapter.m:

  1035         (-[WebCookieAdapter cookiesForURL:]): Take NSString instead of NSURL.

  1036         (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]): Ditto.

  1037 

  1038         * WebView.subproj/WebDataSourcePrivate.m:

  1039         (-[WebDataSource _commitIfReady]): Pass NSString instead of NSURL.

  1040         * WebView.subproj/WebFramePrivate.m:

  1041         (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]): Pass NSString instead of NSURL

  1042         (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): Turn bridge URL into NSURL so we

  1043 	can call _web_URLByRemovingFragment on it.

  1044         * WebView.subproj/WebHTMLViewPrivate.m:

  1045         (-[WebHTMLView _elementAtPoint:]): Convert NSString to NSURL when making the WebKit element dictionary.

  1046 

  1047 2002-11-17  Maciej Stachowiak  <mjs@apple.com>

  1048 

  1049 	- fixed 2949193 - implement onKeyDown, onKeyPress, and onKeyUp event handlers

  1050 	

  1051         * WebView.subproj/WebHTMLViewPrivate.h:

  1052         * WebView.subproj/WebHTMLViewPrivate.m:

  1053         (+[WebHTMLView load]): Pose as NSWindow too now.

  1054         (-[WebHTMLView _interceptKeyEvent:toView:]): Pass event to WebCore and

  1055 	see if WebCore wants to block it.

  1056         (-[WebNSWindow sendEvent:]): For all key events that would go to a

  1057 	subview of a WebHTMLView, let the WebHTMLView take a first crack

  1058 	at it.

  1059 

  1060 2002-11-15  Darin Adler  <darin@apple.com>

  1061 

  1062 	- fixed 3079214 -- text/plain page shows up slowly, a few pages at a time

  1063 

  1064         * WebView.subproj/WebTextView.m:

  1065         (-[WebTextView initWithFrame:]): Remove unneeded setWidthTracksTextView:, because

  1066 	that's the default.

  1067         (-[WebTextView dataSourceUpdated:]): Replace the thing each time in the RTF case.

  1068         (-[WebTextView viewDidMoveToSuperview]): Here's where we resize, but only the width.

  1069 	Resizing the height was causing the bug.

  1070         (-[WebTextView layout]): Do nothing.

  1071         (-[WebTextView setAcceptsDrags:]): Update to new name. Since we weren't

  1072 	importing WebDocument.h, we never noticed that this file got out of sync.

  1073         (-[WebTextView acceptsDrags]): Ditto.

  1074         (-[WebTextView setAcceptsDrops:]): Ditto.

  1075         (-[WebTextView acceptsDrops]): Ditto.

  1076 

  1077         * WebView.subproj/WebDocument.h: Fix typo. It said setAcceptsDrags: twice.

  1078 

  1079 2002-11-15  Darin Adler  <darin@apple.com>

  1080 

  1081         * WebView.subproj/WebFramePrivate.m: Removed a bunch of tabs and fixed indenting.

  1082 

  1083 2002-11-15  Maciej Stachowiak  <mjs@apple.com>

  1084 

  1085 	- fixed 3102016 - REGRESSION: Command-clicking on a link can open _two_ windows.

  1086 	

  1087         * WebView.subproj/WebDataSourcePrivate.h:

  1088         * WebView.subproj/WebDataSourcePrivate.m:

  1089         (-[WebDataSource _setJustOpenedForTargetedLink:]):

  1090         (-[WebDataSource _justOpenedForTargetedLink]):

  1091         * WebView.subproj/WebFrame.m:

  1092         (-[WebFrame findOrCreateFramedNamed:]):

  1093         * WebView.subproj/WebFramePrivate.h:

  1094         * WebView.subproj/WebFramePrivate.m:

  1095         (-[WebFrame _continueAfterNavigationPolicy:]):

  1096         (-[WebFrame _loadDataSource:withLoadType:]):

  1097         (-[WebFrame _downloadRequest:toPath:]):

  1098         (-[WebFrame _setJustOpenedForTargetedLink:]):

  1099 

  1100 2002-11-15  Darin Adler  <darin@apple.com>

  1101 

  1102         * WebView.subproj/WebFramePrivate.m:

  1103         (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):

  1104 	Give the listener a slightly longer lifetime, to make this API a bit more foolproof.

  1105 

  1106 2002-11-15  Maciej Stachowiak  <mjs@apple.com>

  1107 

  1108 	Fix world leak I introduced, and also add an early return when needed.

  1109 	

  1110         * WebView.subproj/WebFramePrivate.m:

  1111         (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]):

  1112         (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):

  1113 

  1114 2002-11-15  Maciej Stachowiak  <mjs@apple.com>

  1115 

  1116 	Make navigation policy asynchronous for real.

  1117 	

  1118         * WebKit.pbproj/project.pbxproj:

  1119         * WebView.subproj/WebControllerPolicyDelegate.h:

  1120         * WebView.subproj/WebControllerPolicyDelegate.m:

  1121         (-[WebPolicyDecisionListenerPrivate initWithTarget:action:]):

  1122         (-[WebPolicyDecisionListenerPrivate dealloc]):

  1123         (-[WebPolicyDecisionListener usePolicy:]):

  1124         (-[WebPolicyDecisionListener _initWithTarget:action:]):

  1125         (-[WebPolicyDecisionListener dealloc]):

  1126         (-[WebPolicyDecisionListener _invalidate]):

  1127         * WebView.subproj/WebControllerPolicyDelegatePrivate.h: Added.

  1128         * WebView.subproj/WebDefaultPolicyDelegate.m:

  1129         (-[WebDefaultPolicyDelegate decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):

  1130         * WebView.subproj/WebFrame.m:

  1131         (-[WebFrame stopLoading]):

  1132         * WebView.subproj/WebFramePrivate.h:

  1133         * WebView.subproj/WebFramePrivate.m:

  1134         (-[WebFramePrivate dealloc]):

  1135         (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]):