1 2007-10-11  Mark Rowe  <mrowe@apple.com>

     2 

     3         Reviewed by Tim Hatcher.

     4 

     5         Fix for <rdar://problem/5488678>.  Disable debugging symbols in production builds for 10.4

     6         PowerPC to prevent a huge STABS section from being generated.

     7 

     8         * Configurations/Base.xcconfig:

     9 

    10 2007-10-10  Alice Liu  <alice.liu@apple.com>

    11 

    12         Reviewed by Geoff Garen.

    13 

    14         Fixed <rdar://5464402> Crash when running fast/frames/onload-remove-iframe-crash.html in DRT

    15         createFrame() now returns a RefPtr instead of a raw Frame pointer. 

    16         Making this change improves the way we handle frames on Windows WebKit. 

    17 

    18         * WebCoreSupport/WebFrameLoaderClient.h:

    19         * WebCoreSupport/WebFrameLoaderClient.mm:

    20         (WebFrameLoaderClient::createFrame):

    21 

    22 2007-10-04  Beth Dakin  <bdakin@apple.com>

    23 

    24         Reviewed by John Sullivan.

    25 

    26         Fix for <rdar://problem/5441823> REGRESSION (r25142, Tiger only): 

    27         Vertical scroll bar not redrawn properly when going back in history 

    28         (15033)

    29 

    30         This fix if-defs r25142 to be Leopard-only since it causes 

    31         correctness issues on Tiger and does not seem to have any 

    32         performance impact on Tiger either.

    33 

    34         * WebView/WebDynamicScrollBarsView.m:

    35         (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]):

    36         (-[WebDynamicScrollBarsView reflectScrolledClipView:]):

    37 

    38 2007-10-04  Mark Rowe  <mrowe@apple.com>

    39 

    40         Reviewed by Oliver.

    41 

    42         Switch to default level of debugging symbols to resolve <rdar://problem/5488678>.

    43         The "full" level appears to offer no observable benefits even though the documentation

    44         suggests it be used for dead code stripping.  This should also decrease link times.

    45 

    46         * Configurations/Base.xcconfig:

    47 

    48 2007-10-04  Adele Peterson  <adele@apple.com>

    49 

    50         Reviewed by Darin.

    51 

    52         WebKit part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content

    53 

    54         * WebView/WebHTMLView.mm: (-[WebHTMLView becomeFirstResponder]): Pass in the FocusDirection.

    55 

    56 2007-10-04  Darin Adler  <darin@apple.com>

    57 

    58         * WebView/WebHTMLView.mm: (-[WebHTMLView _updateActiveState]):

    59         Removed a bogus comment.

    60 

    61 2007-10-02  Kevin Decker  <kdecker@apple.com>

    62 

    63         Reviewed by Mark Rowe.

    64 

    65         Re-added _minimumRequiredSafariBuildNumber. It turns out older version of Safari still rely

    66         on this method, so we need to keep it around at least until the next major Safari release.

    67 

    68         * StringsNotToBeLocalized.txt:

    69         * WebView/WebView.mm:

    70         (+[WebView _minimumRequiredSafariBuildNumber]):

    71         * WebView/WebViewPrivate.h:

    72 

    73 2007-10-02  Kevin Decker  <kdecker@apple.com>

    74 

    75         Reviewed by John Sullivan.

    76 

    77         <rdar://problem/5517710> 

    78 

    79         * WebView/WebView.mm: Removed -[WebView _minimumRequiredSafariBuildNumber] because newer

    80          versions of Safari no longer use this method. This won't break existing Safaris because

    81          they always use a respondsToSelector check before calling this.

    82          

    83         * WebView/WebViewPrivate.h: Ditto. 

    84 

    85 2007-09-27  John Sullivan  <sullivan@apple.com>

    86 

    87         Reviewed by Ollie

    88         

    89         - fixed <rdar://problem/5408186> REGRESSION (5522-5523.9): Safari leaks every browser window

    90         

    91         The leak started occurring when we removed the code to clear the delegates and the host window

    92         from Safari as part of the fix for 5479443. But it turns out that Safari code was masking a

    93         bug here in WebView: setHostWindow:nil needs to be called before setting _private->closed to

    94         YES, or it will do nothing at all, causing a world leak due to a circular reference between

    95         the window and the WebView.

    96         

    97         I toyed with a more complex fix, but this is the simplest one that retains the fix for 5479443

    98         while otherwise restoring the code order to be as close as possible to what it was before

    99         5479443 was fixed.

   100 

   101         * WebView/WebView.mm:

   102         (-[WebView _close]):

   103         Moved the call that sets _private->closed to YES to be after the code that clears the delegates

   104         and the host window. Added a comment about this order.

   105 

   106 2007-09-27  Kevin Decker  <kdecker@apple.com>

   107 

   108         Rubber stamped by Darin.

   109 

   110         <rdar://problem/5493093>

   111 

   112         * WebKit.order: Added.

   113         * WebKit.xcodeproj/project.pbxproj:  We're changing from using an order file built by

   114          another team to using one we actually check into our project repository. Linker settings for

   115          Symbol Ordering Flags have been updated accordingly.

   116 

   117 2007-09-26  Geoffrey Garen  <ggaren@apple.com>

   118 

   119         Reviewed by Adele Peterson.

   120         

   121         Fixed <rdar://problem/5507476> Promote cache model SPI to API

   122         

   123         Promoted cache model SPI to API. This was just a move, with some small 

   124         edits to the documentation (changing 'application' to 'WebView' in 

   125         some cases, since the interface is now per-WebView).

   126 

   127         * WebView/WebPreferences.h:

   128         * WebView/WebPreferences.m:

   129         (-[WebPreferences setCacheModel:]):

   130         (-[WebPreferences cacheModel]):

   131         * WebView/WebPreferencesPrivate.h:

   132 

   133 2007-09-24  Timothy Hatcher  <timothy@apple.com>

   134 

   135         Reviewed by Darin.

   136 

   137         <rdar://problem/5498016> Photoshop CS3: Adobe Help Viewer 1.1 crashes in 9A553

   138 

   139         WebKit started calling the mouseDidMoveOverElement delegate method with a nil dictionary in r14982.

   140         We originally intended to call this delegate method sometimes with a nil dictionary, but due to

   141         a bug dating back to WebKit 1.0 this delegate was never called with nil! Unfortunately we can't

   142         start calling this with nil since it will break Adobe Help Viewer, and possibly other clients.

   143 

   144         * WebView/WebView.mm:

   145         (-[WebView _mouseDidMoveOverElement:modifierFlags:]):

   146 

   147 2007-09-21  Kevin Decker  <kdecker@apple.com>

   148 

   149         * Plugins/WebBaseNetscapePluginView.mm: Build fix. 

   150         The first argument of aglChoosePixelFormat() has changed from const AGLDevice *gdevs on Tiger to

   151         const void *gdevs on Leopard.

   152 

   153 2007-09-20  Kevin Decker  <kdecker@apple.com>

   154 

   155         Reviewed by Darin Adler.

   156 

   157         <rdar://problem/5493093>

   158 

   159         Reduced launch time by lazily linking both the AGL and OpenGL frameworks until they are really needed.

   160 

   161         * Plugins/WebBaseNetscapePluginView.mm: Soft link all AGL and OpenGL functions used by

   162         WebBaseNetscapePluginView.

   163 

   164         * WebKit.xcodeproj/project.pbxproj: Removed AGL and OpenGL from the project.

   165 

   166 2007-09-20  John Sullivan  <sullivan@apple.com>

   167 

   168         Build fix for stoooopid old PPC gcc compiler

   169 

   170         * WebCoreSupport/WebEditorClient.mm:

   171         (WebEditorClient::checkSpellingOfString):

   172         replace perfectly valid ?: syntax with if/else

   173 

   174 2007-09-19  John Sullivan  <sullivan@apple.com>

   175 

   176         Reviewed by Darin Adler.

   177 

   178         - WebKit part of speculative fix for <rdar://problem/5490627>, about crashes constructing a

   179           String using the values filled in by checkSpellingOfString()

   180 

   181         * WebCoreSupport/WebEditorClient.mm:

   182         (WebEditorClient::checkSpellingOfString):

   183         convert NSNotFound to -1, since WebCore code expects -1 for this purpose. We already do this

   184         in checkGrammarOfString.

   185 

   186 2007-09-19  Kevin Decker  <kdecker@apple.com>

   187 

   188         Reviewed by Darin Adler.

   189 

   190         <rdar://problem/5491066> soft link Accelerate.framework

   191         

   192         * Misc/WebGraphicsExtras.c:

   193         (WebConvertBGRAToARGB): Improve launch time performance and reduce vsize

   194         footprint by soft linking the Accelerate.framework.

   195         * WebKit.xcodeproj/project.pbxproj: Remove no longer needed frameworks.

   196 

   197 2007-09-18  Geoffrey Garen  <ggaren@apple.com>

   198 

   199         Reviewed by Darin Adler.

   200         

   201         Fixed <rdar://problem/5490204> In some cases, WebKit can make the 

   202         Foundation disk cache way too big or way too small

   203         

   204         Use the actual location of the foundation disk cache, rather than 

   205         the user's home directory, when determining how big to make it.

   206 

   207         * WebView/WebView.mm:

   208         (+[WebView _setCacheModel:]):

   209 

   210 2007-09-17  Geoffrey Garen  <ggaren@apple.com>

   211 

   212         Reviewed by Darin Adler.

   213 

   214         Fixed a hang due to an infinite script running in the window's unload 

   215         event handler, which may be the cause of <rdar://problem/5479443> 

   216         REGRESSION: Hang due to infinite JS recursion on close @ engadget.com 

   217         (onunload-based ad)

   218 

   219         * WebView/WebUIDelegatePrivate.h: Added FIXME.

   220         

   221         * WebView/WebView.h: Clarified headerdoc ambiguity about when delegate 

   222         methods stop firing.

   223 

   224         * WebView/WebView.mm:

   225         (-[WebView _close]): The fix: don't nil out our delegates until after

   226         detaching the FrameLoader, because the act of detaching the FrameLoader

   227         might fire important delegate methods, like webViewShouldInterruptJavaScript:.

   228         Don't do other tear-down either, because the unload event handler needs 

   229         to run in a fully constructed page.

   230         

   231         This change is fairly low risk because niling out our delegates is a 

   232         very recent, never-shipped feature in WebKit, so it's unlikely that any 

   233         apps rely on it in a crazy way.

   234 

   235 2007-09-15  Darin Adler  <darin@apple.com>

   236 

   237         Reviewed by John Sullivan.

   238 

   239         - fix <rdar://problem/5391540> REGRESSION: Can't drag images from Safari to applications

   240           in the dock (Tiger Preview, others in Leopard)

   241 

   242         * Misc/WebNSPasteboardExtras.mm:

   243         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):

   244         Re-implement code here that has been missing for the last couple of years since we

   245         did some image refactoring. Was pretty easy now that we can freely call C++ code

   246         in WebKit.

   247 

   248 2007-09-14  Mark Rowe  <mrowe@apple.com>

   249 

   250         Build fix for Tiger.

   251 

   252         * WebView/WebArchive.m:

   253         (-[WebArchive initWithCoder:]): Use @catch(id) rather than @catch(...).

   254         * WebView/WebPreferences.m:

   255         (-[WebPreferences initWithCoder:]): Ditto.

   256         * WebView/WebResource.mm:

   257         (-[WebResource initWithCoder:]): Ditto.

   258         (-[WebResource _initWithPropertyList:]): Ditto.

   259 

   260 2007-09-14  Darin Adler  <darin@apple.com>

   261 

   262         Reviewed by Geoff Garen and Tim Hatcher.

   263 

   264         - fixed <rdar://problem/5482745> initFromCoder: and initWithPropertyList: functions

   265           should guard against incorrect types

   266 

   267         * WebView/WebArchive.m:

   268         (isArrayOfClass): Added helper function.

   269         (-[WebArchive _initWithPropertyList:]): Tweaked function to remove the need for a

   270         type cast.

   271         (-[WebArchive initWithCoder:]): Added type checking for the main resource,

   272         subresources array, and subframe archives array. Also replaced NS_DURING with @try.

   273         * WebView/WebPreferences.m: (-[WebPreferences initWithCoder:]): Added type checking

   274         for the identifier and the values dictionary, including ensuring that it's a mutable

   275         dictionary.

   276         * WebView/WebResource.mm:

   277         (-[WebResource initWithCoder:]): Added type checking for all the fields.

   278         (-[WebResource _initWithPropertyList:]): Added type checking for the NSURLResponse.

   279 

   280         * WebKit.exp: Removed accidentally exported internal symbol; I checked and it's not

   281         used anywhere.

   282 

   283 2007-09-13  Darin Adler  <darin@apple.com>

   284 

   285         Reviewed by Oliver.

   286 

   287         - fix <rdar://problem/5470457> REGRESSION: Input method inline hole is mishandled in text

   288           <input> elements with maxlength limit

   289 

   290         * WebView/WebHTMLView.mm:

   291         (-[WebHTMLView _selectionChanged]): Tweaked code a bit.

   292         (-[WebHTMLView markedRange]): Simplified logic, since markedTextNSRange works when there's

   293         no composition range.

   294         (-[WebHTMLView hasMarkedText]): Call directly to Editor instead of bridge.

   295         (-[WebHTMLView unmarkText]): Call new confirmComposition to make it clear that this is

   296         confirming text, not just unmarking it to discard it.

   297         (extractUnderlines): Added. Converts directly from an NSAttributedString to the

   298         CompositionUnderline vector that's used by WebCore.

   299         (-[WebHTMLView setMarkedText:selectedRange:]): Changed to use the new setComposition.

   300         (-[WebHTMLView insertText:]): Changed to use confirmComposition when appropriate, instead

   301         of relying on special behavior of Editor::insertText.

   302         (-[WebHTMLView _updateSelectionForInputManager]): Rewrote to use getCompositionSelection

   303         and confirmCompositionWithoutDisturbingSelection.

   304 

   305         * WebCoreSupport/WebEditorClient.h:

   306         * WebCoreSupport/WebEditorClient.mm:

   307         Removed obsolete markedTextAbandoned function.

   308  

   309 2007-09-12  David Kilzer  <ddkilzer@apple.com>

   310 

   311         Rubber-stamped by Darin and reviewed by Adam.

   312 

   313         Removed import of unused icon database headers.

   314 

   315         * WebCoreSupport/WebFrameBridge.mm:

   316 

   317 2007-09-11  Timothy Hatcher  <timothy@apple.com>

   318 

   319         Reviewed by Darin.

   320 

   321         Remove the unused class_getMethodImplementation function.

   322 

   323         * Misc/WebNSObjectExtras.h:

   324 

   325 2007-09-11  Geoffrey Garen  <ggaren@apple.com>

   326 

   327         Reviewed by Oliver Hunt.

   328         

   329         Fixed CFNetwork version check so it actually works.

   330 

   331         * Misc/WebKitVersionChecks.h:

   332         * WebView/WebView.mm:

   333         (+[WebView _setCacheModel:]): Don't use NSVersionOfLinkTimeLibrary because

   334         we don't link against CFNetwork directly, so it returns -1. Also, use

   335         the proper hex encoding instead of decimal numbers.

   336 

   337 2007-09-11  Darin Adler  <darin@apple.com>

   338 

   339         - redo fix for <rdar://problem/5472899> REGRESSION (TOT): Crash in FrameLoadDelegate loading stationery

   340 

   341         * WebView/WebView.mm:

   342         (getMethod): Added.

   343         (-[WebView _cacheResourceLoadDelegateImplementations]): Use getMethod.

   344         (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto.

   345 

   346 2007-09-11  Darin Adler  <darin@apple.com>

   347 

   348         Rubber-stamped by Dave Harrison.

   349 

   350         * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

   351         Removed wkCreateURLPasteboardFlavorTypeName and wkCreateURLNPasteboardFlavorTypeName.

   352 

   353 2007-09-11  Darin Adler  <darin@apple.com>

   354 

   355         Reviewed by Mark Rowe.

   356 

   357         - fix <rdar://problem/5472899> REGRESSION (TOT): Crash in FrameLoadDelegate loading stationery

   358 

   359         * Misc/WebNSObjectExtras.h:

   360         (class_getMethodImplementation): Added.

   361         (method_setImplementation): Added.

   362 

   363         * WebView/WebHTMLView.mm: (+[WebHTMLViewPrivate initialize]):

   364         * Carbon/HIViewAdapter.m: (+[HIViewAdapter bindHIViewToNSView:nsView:]):

   365         Remove old-ObjC code path, since WebNSObjectExtras.h now implements everything we need.

   366 

   367         * WebView/WebView.mm:

   368         (-[WebView _cacheResourceLoadDelegateImplementations]): Don't bother doing a separate

   369         respondsToSelector call, since class_getMethodImplementation will return 0 for selectors

   370         that we don't respond to. The bug fix is to actually set the cached pointer to 0.

   371         Also get rid of the unnecessary use of a macro; instead use the functions from

   372         WebNSObjectExtras.h on Tiger and the appropriate function directly on Leopard.

   373         (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto.

   374 

   375 2007-09-11  Darin Adler  <darin@apple.com>

   376 

   377         Reviewed by Sam, Ollie.

   378 

   379         * WebView/WebView.mm: (+[WebView _setCacheModel:]): A slightly cleaner 64-bit

   380         fix for the NSURLCache capacity code in this file.

   381 

   382 2007-09-11  Darin Adler  <darin@apple.com>

   383 

   384         Rubber-stamped by Mark Rowe.

   385 

   386         * Misc/WebNSPasteboardExtras.mm: Fix incorrect strings in my last check-in.

   387         The strings I checked in were wrong and were breaking layout tests too.

   388         These new ones match what WebKitSystemInterface was returning.

   389 

   390 2007-09-10  Geoffrey Garen  <ggaren@apple.com>

   391 

   392         Fixed 64-bit build (I think).

   393 

   394         * WebView/WebView.mm:

   395         (max): Added. In 64-bit land, -diskCapacity magically starts returning

   396         unsigned long instead of unsigned, so we define a custom max() that's

   397         willing to compare unsigned to unsigned long.

   398 

   399 2007-09-10  Darin Adler  <darin@apple.com>

   400 

   401         Reviewed by Tim Hatcher.

   402 

   403         - <rdar://problem/5471082> Removing WebURLPboardType from headers broke SPI-using applications

   404 

   405         Rolled out my fix for bug 4582212 and fixed it in a much simpler way.

   406 

   407         * Misc/WebNSPasteboardExtras.h:

   408         * Misc/WebNSPasteboardExtras.mm:

   409         * WebCoreSupport/WebPasteboardHelper.mm:

   410         * WebKit.exp:

   411         * WebView/WebHTMLView.mm:

   412         * WebView/WebView.mm:

   413         Rolled out the new PasteboardType functions and changed the PboardType globals to be initialized

   414         with constant values.

   415 

   416 2007-09-10  Timothy Hatcher  <timothy@apple.com>

   417 

   418         Reviewed by Darin.

   419 

   420         Always animate when calling _scrollTo.

   421 

   422         * WebView/WebFrameView.mm:

   423         (-[WebFrameView _scrollVerticallyBy:]):

   424         (-[WebFrameView _scrollHorizontallyBy:]):

   425 

   426 2007-09-08  Brady Eidson  <beidson@apple.com>

   427 

   428         Reviewed by Darin

   429 

   430         <rdar://problem/5434431> - Asynchronous Icon Database

   431 

   432         WebKit side of things

   433         Mainly, there are Notifications WebKit has to listen for now that tell it when to either call back into WebCore

   434         for some purpose or to send the webView:didReceiveIcon: delegate call

   435 

   436         Many smaller tweaks as well.

   437 

   438         * Misc/WebIconDatabase.h:

   439         * Misc/WebIconDatabase.mm:

   440         (defaultClient):

   441         (-[WebIconDatabase init]):

   442         (+[WebIconDatabase delayDatabaseCleanup]): Accessor so clients can prevent the thread from cleaning up the database

   443           before they've done all their necessary retaining of icons.

   444         (+[WebIconDatabase allowDatabaseCleanup]):

   445         (-[WebIconDatabase removeAllIcons]):

   446         (-[WebIconDatabase _isEnabled]):

   447         (-[WebIconDatabase _sendNotificationForURL:]):

   448         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]):

   449         (-[WebIconDatabase _databaseDirectory]):

   450 

   451         (-[ThreadEnabler threadEnablingSelector:]): Quick and dirty class to enabled Cocoa multithreading

   452         (+[ThreadEnabler enableThreading]):

   453         (importToWebCoreFormat):

   454         * Misc/WebIconDatabaseInternal.h: Expose the internal methods of WebIconDatabase that are required by WebIconDatabaseClient

   455 

   456         * Misc/WebNSNotificationCenterExtras.h: Added. - Great utility class whose design was borrowed from Colloquy

   457           that allows the posting of a Cocoa notification on the main thread from *any* thread

   458         * Misc/WebNSNotificationCenterExtras.m: Added.

   459         (-[NSNotificationCenter postNotificationOnMainThreadWithName:object:]):

   460         (-[NSNotificationCenter postNotificationOnMainThreadWithName:object:userInfo:]):

   461         (-[NSNotificationCenter postNotificationOnMainThreadWithName:object:userInfo:waitUntilDone:]):

   462         (+[NSNotificationCenter _postNotificationName:]):

   463 

   464         * WebCoreSupport/WebFrameLoaderClient.h:

   465         * WebCoreSupport/WebFrameLoaderClient.mm:

   466         (WebFrameLoaderClient::dispatchDidReceiveIcon): Send the webView:didReceiveIcon: delegate call

   467         (WebFrameLoaderClient::registerForIconNotification):

   468 

   469         * WebCoreSupport/WebIconDatabaseClient.h: Added.

   470         * WebCoreSupport/WebIconDatabaseClient.mm: Added.

   471         (WebIconDatabaseClient::performImport):  Perform the Safari 2 icon import

   472         (WebIconDatabaseClient::dispatchDidRemoveAllIcons): Send the NSNotification

   473         (WebIconDatabaseClient::dispatchDidAddIconForPageURL): Ditto

   474 

   475         * WebView/WebView.mm:

   476         (-[WebView _receivedIconChangedNotification:]): Check and see if this notification is for this WebView's current URL by

   477           calling back into the IconDatabase

   478         (-[WebView _registerForIconNotification:]): Support for WebIconDatabaseClient

   479         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Dispatch this delegate call as well as unregister for the notification

   480         * WebView/WebViewInternal.h:

   481 

   482         * WebKit.xcodeproj/project.pbxproj:

   483 

   484 2007-09-07  Geoffrey Garen  <ggaren@apple.com>

   485 

   486         Suggested by Maciej Stachowiak.

   487         

   488         Added wKiosk Browser to the browser list. Pretty sweet app.

   489 

   490         * WebView/WebPreferences.m:

   491         (cacheModelForMainBundle):

   492 

   493 2007-09-07  Geoffrey Garen  <ggaren@apple.com>

   494 

   495         Build fix.

   496 

   497         * WebView/WebView.mm:

   498         (+[WebView _setCacheModel:]):

   499 

   500 2007-09-05  Geoffrey Garen  <ggaren@apple.com>

   501 

   502         Reviewed by Darin Adler, Maciej Stachowiak, Mark Rowe, Tim Hatcher.

   503         

   504         Fixed <rdar://problem/5326009> Make non-browser WebKit clients have no 

   505         memory cache, or a very tiny one

   506         

   507         High level explanation:

   508             - Added SPI for specifying a cache model on a per-WebView basis. 

   509             (Hopefully, this will become API soon.) We balance competing

   510             cache models simply by using the largest one that pertains at a

   511             given time.

   512 

   513             - Added heuristic for guessing a default cache model in WebViews

   514             that don't specify one:

   515                 1) Default to DocumentViewer for apps linked on or after this

   516                 WebKit. Default to DocumentBrowser otherwise.

   517 

   518                 2) Assign specific defaults to well-known clients based on 

   519                 bundle ID.

   520 

   521                 3) Grow the default to DocumentBrowser if a navigation takes 

   522                 place.

   523 

   524             - As a part of the DocumentBrowser & PrimaryWebBrowser settings:

   525                 1) Make the Foundation disk cache much much bigger than the 

   526                 default 20MB, if space allows. (This is a hedge against a small 

   527                 WebCore cache in DocumentBrowser mode, but also an all-around 

   528                 win for page load speed.)

   529 

   530                 2) Scaled the Foundation memory cache's capacity with physical

   531                 RAM, just like we do with other caches. This is a small win on

   532                 low memory systems.

   533 

   534         * Misc/WebKitSystemBits.h:

   535         * Misc/WebKitSystemBits.m:

   536         (WebMemorySize): Renamed from "WebSystemMainMemory."

   537         (WebHomeDirectoryFreeSize): Added function to measure the free space

   538         on the user's home directory. We use this as a factor in determining 

   539         the disk cache's cacpacity.

   540 

   541         * Misc/WebKitVersionChecks.h: Support for linked on or after check.

   542         

   543         * WebCoreSupport/WebFrameLoaderClient.h:

   544         * WebCoreSupport/WebFrameLoaderClient.mm:

   545         (WebFrameLoaderClient::didPerformFirstNavigation): Implementation of

   546         heuristic rule #3.

   547 

   548         * WebView/WebPreferenceKeysPrivate.h:

   549         * WebView/WebPreferences.m:

   550         (cacheModelForMainBundle): Implementation of heuristic rule #2.

   551         (-[NSMutableDictionary _web_checkLastReferenceForIdentifier:]): Added

   552         notification for when a WebPreferences instance becomes inert. We use

   553         this to shrink the cache model back down if possible. Moved this code

   554         into a WebPreferences method, since it's not really a feature of 

   555         NSDictionary.

   556 

   557         * WebView/WebPreferencesPrivate.h: SPI declarations.

   558         

   559         * WebView/WebView.mm: Replaced manual notification posts with calls to

   560         the _postPreferencesChangesNotification convenience method.

   561 

   562         (-[WebView _preferencesChangedNotification:]): Merged dispersed code

   563         for updating preferences-related settings into this one function. This

   564         was needed for an earlier version of the patch, even though the 

   565         current version could probably do without it.

   566 

   567         (+[WebView _preferencesChangedNotification:]): Added a class-level 

   568         listener for WebPreferences changes. This listener takes care of 

   569         modifying the class-level global cache model setting if necessary.

   570 

   571         (+[WebPreferences standardPreferences]): Removed call to 

   572         _postPreferencesChangesNotification because the notification already 

   573         posts when you create the WebPreferences object. (I noticed this 

   574         inefficiency because my new _preferencesChangedNotification: method was

   575         called excessively at startup.)

   576 

   577         Also Added explicit tracking of WebPreferences clients, so we know when

   578         a WebPreferences instance becomes inert:

   579         

   580         (-[WebPreferences didRemoveFromWebView]):

   581         (-[WebPreferences willAddToWebView]):

   582 

   583         (+[WebView _setCacheModel:]): Translates a cache model into actual 

   584         settings in various APIs. Caches that have unbounded value grow 

   585         linearly relative to available space. Caches that have bounded value 

   586         grow inverse-squaredly relative to available space.

   587 

   588 >>>>>>> .r25438

   589 2007-09-05  Timothy Hatcher  <timothy@apple.com>

   590 

   591         Reviewed by Darin.

   592 

   593         <rdar://problem/5443883> Uncaught Objective-C exceptions in WebKit clients lead to hard-to-diagnose crashes

   594 

   595         Changed all the direct delegate calls to use helper functions that have direct access to

   596         WebView's delegate objects. These helper methods will catch any ObjC exceptions and call

   597         ReportDiscardedDelegateException to log the discarded exception. WebView's that have

   598         catchesDelegateExceptions set to NO will not pay the cost of a @try/@catch. The delegate

   599         forwarders also have the same behavior.

   600 

   601         * Misc/WebKitLogging.h:

   602         * Misc/WebKitLogging.m:

   603         (ReportDiscardedDelegateException):

   604         * Plugins/WebBaseNetscapePluginView.mm:

   605         (-[WebBaseNetscapePluginView loadPluginRequest:]):

   606         * Plugins/WebNullPluginView.mm:

   607         (-[WebNullPluginView viewDidMoveToWindow]):

   608         * WebCoreSupport/WebChromeClient.mm:

   609         (WebChromeClient::createWindow):

   610         (WebChromeClient::createModalDialog):

   611         (WebChromeClient::runModal):

   612         (WebChromeClient::toolbarsVisible):

   613         (WebChromeClient::statusbarVisible):

   614         (WebChromeClient::addMessageToConsole):

   615         (WebChromeClient::canRunBeforeUnloadConfirmPanel):

   616         (WebChromeClient::runBeforeUnloadConfirmPanel):

   617         (WebChromeClient::runJavaScriptAlert):

   618         (WebChromeClient::runJavaScriptConfirm):

   619         (WebChromeClient::runJavaScriptPrompt):

   620         (WebChromeClient::shouldInterruptJavaScript):

   621         (WebChromeClient::setStatusbarText):

   622         (WebChromeClient::print):

   623         * WebCoreSupport/WebContextMenuClient.mm:

   624         (WebContextMenuClient::getCustomMenuFromDefaultItems):

   625         (WebContextMenuClient::contextMenuItemSelected):

   626         * WebCoreSupport/WebDragClient.mm:

   627         (WebDragClient::startDrag):

   628         * WebCoreSupport/WebEditorClient.mm:

   629         (WebEditorClient::textFieldDidBeginEditing):

   630         (WebEditorClient::textFieldDidEndEditing):

   631         (WebEditorClient::textDidChangeInTextField):

   632         (WebEditorClient::doTextFieldCommandFromEvent):

   633         (WebEditorClient::textWillBeDeletedInTextField):

   634         (WebEditorClient::textDidChangeInTextArea):

   635         * WebCoreSupport/WebFrameBridge.mm:

   636         (-[WebFrameBridge viewForPluginWithFrame:URL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):

   637         * WebCoreSupport/WebFrameLoaderClient.mm:

   638         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):

   639         (WebFrameLoaderClient::assignIdentifierToInitialRequest):

   640         (WebFrameLoaderClient::dispatchWillSendRequest):

   641         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):

   642         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):

   643         (WebFrameLoaderClient::dispatchDidReceiveResponse):

   644         (WebFrameLoaderClient::willCacheResponse):

   645         (WebFrameLoaderClient::dispatchDidReceiveContentLength):

   646         (WebFrameLoaderClient::dispatchDidFinishLoading):

   647         (WebFrameLoaderClient::dispatchDidFailLoading):

   648         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):

   649         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):

   650         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):

   651         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):

   652         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):

   653         (WebFrameLoaderClient::dispatchWillClose):

   654         (WebFrameLoaderClient::dispatchDidReceiveIcon):

   655         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):

   656         (WebFrameLoaderClient::dispatchDidReceiveTitle):

   657         (WebFrameLoaderClient::dispatchDidCommitLoad):

   658         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):

   659         (WebFrameLoaderClient::dispatchDidFailLoad):

   660         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):

   661         (WebFrameLoaderClient::dispatchDidFinishLoad):

   662         (WebFrameLoaderClient::dispatchDidFirstLayout):

   663         (WebFrameLoaderClient::dispatchCreatePage):

   664         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):

   665         (WebFrameLoaderClient::dispatchWillSubmitForm):

   666         (WebFrameLoaderClient::dispatchDidLoadMainResource):

   667         * WebView/WebHTMLView.mm:

   668         (-[WebHTMLView callDelegateDoCommandBySelectorIfNeeded:]):

   669         (-[WebHTMLView validateUserInterfaceItem:]):

   670         * WebView/WebPDFView.mm:

   671         (-[WebPDFView validateUserInterfaceItem:]):

   672         (-[WebPDFView PDFViewSavePDFToDownloadFolder:]):

   673         * WebView/WebView.mm:

   674         (-[WebView _openNewWindowWithRequest:]):

   675         (-[WebView _menuForElement:defaultItems:]):

   676         (-[WebView _mouseDidMoveOverElement:modifierFlags:]):

   677         (-[WebView _cacheResourceLoadDelegateImplementations]):

   678         (-[WebView _cacheFrameLoadDelegateImplementations]):

   679         (-[WebView _policyDelegateForwarder]):

   680         (-[WebView _UIDelegateForwarder]):

   681         (-[WebView _editingDelegateForwarder]):

   682         (-[WebView _scriptDebugDelegateForwarder]):

   683         (-[WebView _setCatchesDelegateExceptions:]):

   684         (-[WebView _catchesDelegateExceptions]):

   685         (-[_WebSafeForwarder initWithTarget:defaultTarget:]):

   686         (-[_WebSafeForwarder forwardInvocation:]):

   687         (-[_WebSafeForwarder methodSignatureForSelector:]):

   688         (-[WebView _commonInitializationWithFrameName:groupName:]):

   689         (-[WebView validateUserInterfaceItem:]):

   690         (-[WebView _headerHeight]):

   691         (-[WebView _footerHeight]):

   692         (-[WebView _drawHeaderInRect:]):

   693         (-[WebView _drawFooterInRect:]):

   694         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):

   695         (CallDelegate):

   696         (CallDelegateReturningFloat):

   697         (CallDelegateReturningBoolean):

   698         (CallUIDelegate):

   699         (CallUIDelegateReturningFloat):

   700         (CallUIDelegateReturningBoolean):

   701         (CallFrameLoadDelegate):

   702         (CallResourceLoadDelegate):

   703         (CallFormDelegate):

   704         (CallFormDelegateReturningBoolean):

   705         * WebView/WebViewInternal.h:

   706         * WebView/WebViewPrivate.h:

   707 

   708 >>>>>>> .r25411

   709 2007-09-04  Timothy Hatcher  <timothy@apple.com>

   710 

   711         Reviewed by Darin.

   712 

   713         <rdar://problem/5452908> NIBs saved in the Pre-10.2 format while Safari 3 installed do not work without Safari 3

   714 

   715         This happened because we encoded a new field that the old WebKit does not know how to read.

   716         And NSCoder throws an exception if initWithCoder finishes while there is still unread data in the archive.

   717 

   718         The WebViewVersion is now 4 to distinguish that we do not encode/decode allowsUndo.

   719 

   720         * WebView/WebView.mm:

   721         (-[WebView initWithCoder:]): Only try to read allowsUndo if the version is 3.

   722         (-[WebView encodeWithCoder:]): No longer encode allowsUndo.

   723 

   724 2007-09-04  David Hyatt  <hyatt@apple.com>

   725 

   726         Fix for <rdar://problem/5271213>, resizing iChat window is slower than in

   727         Tiger.  This patch implements a fast scaling mode that can be used by

   728         WebViews, e.g., during window resizing.

   729 

   730         Reviewed by John Sullivan

   731 

   732         * WebView/WebView.mm:

   733         (-[WebView _setUseFastImageScalingMode:]):

   734         (-[WebView _inFastImageScalingMode]):

   735         * WebView/WebViewPrivate.h:

   736 

   737 2007-09-04  Darin Adler  <darin@apple.com>

   738 

   739         Reviewed by Hyatt.

   740 

   741         * WebView/WebView.mm:

   742         (-[WebView _loadBackForwardListFromOtherView:]): Added missing null check.

   743         (-[WebView _setInitiatedDrag:]): Ditto.

   744         (-[WebView _clearUndoRedoOperations]): Ditto.

   745         (-[WebView encodeWithCoder:]): Ditto.

   746         (-[WebView backForwardList]): Ditto.

   747         (-[WebView setMaintainsBackForwardList:]): Ditto.

   748 

   749 2007-09-04  Tristan O'Tierney  <tristan@apple.com>

   750 

   751         Reviewed by John Sullivan.

   752         

   753         <rdar://problem/5454935> Can't reply to this message in Mail -- -[DOMRange webArchive] is throwing an exception

   754 

   755         * WebView/WebArchiver.mm:

   756         (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):

   757         Guard the creation of WebResource by ensuring that the passed in

   758         responseURL is never nil.

   759 

   760 2007-09-03  Mark Rowe  <mrowe@apple.com>

   761 

   762         Reviewed by Tim Hatcher.

   763 

   764         <rdar://problem/5452164> Production build with in symbols directory has no debug info

   765 

   766         Enable debug symbol generation on all build configurations.  Production builds are stripped

   767         of symbols by Xcode during deployment post-processing.

   768 

   769         * Configurations/Base.xcconfig:

   770         * WebKit.xcodeproj/project.pbxproj:

   771 

   772 2007-09-02  Brady Eidson  <beidson@apple.com>

   773 

   774         Reviewed by John Sullivan and Mark Rowe

   775 

   776         Groundwork for support for monitoring IconDatabase in-memory statistics

   777  

   778         * Misc/WebCoreStatistics.h:

   779         * Misc/WebCoreStatistics.mm:

   780         (+[WebCoreStatistics iconPageURLMappingCount]):

   781         (+[WebCoreStatistics iconRetainedPageURLCount]):

   782         (+[WebCoreStatistics iconRecordCount]):

   783         (+[WebCoreStatistics iconsWithDataCount]):

   784 

   785 2007-09-01  Oliver Hunt  <oliver@apple.com>

   786 

   787         Reviewed by Sam.

   788 

   789         <rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions

   790 

   791         EditorClient::setInputMethodState stub

   792 

   793         * WebCoreSupport/WebEditorClient.h:

   794         * WebCoreSupport/WebEditorClient.mm:

   795         (WebEditorClient::setInputMethodState):

   796 

   797 2007-08-30  Maciej Stachowiak  <mjs@apple.com>

   798 

   799         Reviewed by Tim.

   800         

   801         <rdar://problem/5439953> REGRESSION: Cannot load feeds in widgets in Dashcode due to change in WebKit delegate methods

   802 

   803         * WebView/WebFrame.mm:

   804         (-[WebFrame _attachScriptDebugger]): Don't create the debugger object if the frame has not yet

   805         created its script interpreter, to avoid premature dispatch of windowScriptObjectAvailable/Cleared

   806         delegate methods. The script debugger will be created in any case when the window object does appear.

   807 

   808 2007-08-29  Darin Adler  <darin@apple.com>

   809 

   810         Reviewed by Tim Hatcher.

   811 

   812         - fix <rdar://problem/4582212> WebKit inappropriately adds +initialize to

   813           NSPasteboard via a category, prevents AppKit initialize

   814           http://bugs.webkit.org/show_bug.cgi?id=9417

   815 

   816         * Misc/WebNSPasteboardExtras.h: Got rid of the global data objects and replaced

   817         them with global functions.

   818 

   819         * Misc/WebNSPasteboardExtras.mm:

   820         (initializePasteboardTypes): Changed the initialize method to be this function.

   821         (WebURLPasteboardType): Added, calls the initialize function and then returns

   822         the value of the global.

   823         (WebURLNamePasteboardType): Ditto.

   824         (+[NSPasteboard _web_writableTypesForURL]): Changed to call the new function instead

   825         of getting at the global directly.

   826         (+[NSPasteboard _web_dragTypesForURL]): Ditto.

   827         (-[NSPasteboard _web_writeURL:andTitle:types:]): Ditto.

   828         * WebCoreSupport/WebPasteboardHelper.mm:

   829         (WebPasteboardHelper::urlFromPasteboard): Ditto.

   830         * WebView/WebHTMLView.mm:

   831         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.

   832 

   833         * WebView/WebView.mm:

   834         (+[WebView initialize]): Added a call to one of the functions to take advantage

   835         of the side effect that initializes the globals; this is to help out old versions

   836         of Safari.

   837         (+[WebView URLTitleFromPasteboard:]): Changed to call the new function instead

   838         of getting at the global directly.

   839 

   840         * WebKit.exp: Add exports of the new functions.

   841 

   842 2007-08-29  Adele Peterson  <adele@apple.com>

   843 

   844         Reviewed by Darin.

   845 

   846         Fix for http://bugs.webkit.org/show_bug.cgi?id=15098

   847         <rdar://problem/5440319> REGRESSION (9A530-9A534): Double scroll bar on pdfs

   848 

   849         * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView):

   850          Don't suppress scrollbars before the view creation if we're making the view for a non-html view

   851 

   852         * WebView/WebFrameViewInternal.h: Make _scrollView return a WebDynamicScrollBarsView since so many clients were relying on it being that type anyway.

   853         * WebView/WebFrameView.mm:

   854         (-[WebFrameView _setDocumentView:]):

   855         (-[WebFrameView _scrollView]):

   856         (-[WebFrameView setAllowsScrolling:]):

   857         (-[WebFrameView allowsScrolling]):

   858         * WebView/WebView.mm:

   859         (-[WebView setAlwaysShowVerticalScroller:]):

   860         (-[WebView alwaysShowVerticalScroller]):

   861         (-[WebView setAlwaysShowHorizontalScroller:]):

   862         (-[WebView alwaysShowHorizontalScroller]):

   863 

   864 2007-08-29  David Hyatt  <hyatt@apple.com>

   865 

   866         The method that was swizzled to fix 5441281 does not exist on Tiger.

   867         Tiger has to do a double swizzle instead (of resetCursorRects and NSCursor's

   868         set method) in order to roughly achieve the same effect.

   869 

   870         Reviewed by darin

   871 

   872         * WebView/WebHTMLView.mm:

   873         (resetCursorRects):

   874         (setCursor):

   875         (+[WebHTMLViewPrivate initialize]):

   876 

   877 2007-08-29  Anders Carlsson  <andersca@apple.com>

   878 

   879         Fix 64-bit build.

   880         

   881         * WebCoreSupport/WebFrameBridge.mm:

   882 

   883 2007-08-29  David Hyatt  <hyatt@apple.com>

   884 

   885         Fix for 5441281, remove our dependency on cursor rects and drag margins

   886         in AppKit for a large performance boost on the PLT and iBench.

   887 

   888         Reviewed by darin

   889 

   890         * Plugins/WebBaseNetscapePluginView.h:

   891         * Plugins/WebBaseNetscapePluginView.mm:

   892         (-[WebBaseNetscapePluginView sendNullEvent]):

   893         (-[WebBaseNetscapePluginView mouseEntered:]):

   894         (-[WebBaseNetscapePluginView mouseExited:]):

   895         (-[WebBaseNetscapePluginView stop]):

   896         Clean up cursor setting from Netscape plugins.  Don't unconditionally mutate

   897         the cursor when a plugin stops.

   898 

   899         * WebView/WebFrameView.mm:

   900         (-[WebFrameView _setDocumentView:]):

   901         Suppress the resetting of drag margins while the new document view is being

   902         added to the view hierarchy.

   903 

   904         * WebView/WebHTMLView.mm:

   905         (-[NSWindow _web_borderView]):

   906         Expose the border view of the NSWindow so that it can be hit tested.

   907 

   908         (setCursorForMouseLocation):

   909         Apply a method swizzle to override the private AppKit method, _setCursorForMouseLocation.

   910         We have to do this to suppress the cursor rect invalidation handling from resetting

   911         the cursor for no reason.

   912 

   913         The swizzle will do a hit test and allow the cursor set to occur if the mouse ends up

   914         being over a plugin or over a view other than a WebHTMLView.

   915 

   916         (+[WebHTMLViewPrivate initialize]):

   917         The swizzle for setCursorForMouseLocation is set up here.

   918 

   919         (-[WebHTMLView _frameOrBoundsChanged]):

   920         Add a 100ms delay to the fake mouse moved event that fires when the view moves

   921         under the mouse (without the mouse moving).  This happens on iBench when the

   922         pages get scrolled.  By adding a delay we ensure that even with the mouse inside

   923         the window, we don't experience cursor thrashing when pages are updating and

   924         scrolling rapidly.

   925 

   926 2007-08-28  Anders Carlsson  <andersca@apple.com>

   927 

   928         Reviewed by Darin.

   929 

   930         <rdar://problem/5424866> Bottom portion of any Web Clip widget appears transparent

   931         

   932         * WebCoreSupport/WebFrameBridge.mm:

   933         Use the enum from FrameLoaderTypes.h.

   934         

   935         * WebCoreSupport/WebFrameLoaderClient.mm:

   936         (WebFrameLoaderClient::objectContentType):

   937         Return ObjectContentNetscapePlugin and ObjectContentOtherPlugin depending on the plug-in type.

   938 

   939 2007-08-28  Mark Rowe  <mrowe@apple.com>

   940 

   941         Reviewed by Maciej Stachowiak.

   942 

   943         Fix fallout from the fix for <rdar://problem/5437983> (Loading history containing 100,000 entries adds 20s to Safari's startup)

   944         in r25275.  The array of entries for each day was being maintained in the reverse of the order that was expected.

   945 

   946         * History/WebHistory.mm:

   947         (-[WebHistoryPrivate insertItem:forDateKey:]): Maintain the array of entries in descending order.

   948 

   949 2007-08-28  Mark Rowe  <mrowe@apple.com>

   950 

   951         Fix the buildbot build.

   952 

   953         * History/WebHistory.mm:

   954         (timeIntervalForBeginningOfDay):  Explicitly cast to silence compiler warning.

   955 

   956 2007-08-28  Mark Rowe  <mrowe@apple.com>

   957 

   958         Reviewed by Darin Adler.

   959 

   960         <rdar://problem/5437983> Loading history containing 100,000 entries adds 20s to Safari's startup

   961 

   962         Move WebHistoryItemPrivate from using a sorted array of NSCalendarDate's that map to a sorted array of arrays

   963         of WebHistoryItem's over to using a HashMap of NSTimeIntervals and arrays of WebHistoryItems.  NSTimeInterval

   964         uses less memory and is substantially cheaper during comparisons than NSCalendarDate.  The use of the HashMap

   965         avoids the needs to repeatedly search within an array to locate the array that corresponds to the given days

   966         history items.

   967 

   968         The result of these changes is that loading 100,000 history items drops from around 25s to 1.6s.  Loading

   969         100 items drops from 0.003s to 0.002s.

   970 

   971         * History/WebHistory.mm:

   972         (-[WebHistoryPrivate init]):

   973         (-[WebHistoryPrivate dealloc]):

   974         (timeIntervalForBeginningOfDay): Return the NSTimeInterval representing the beginning of the specified day.

   975         (-[WebHistoryPrivate findKey:forDay:]):

   976         (-[WebHistoryPrivate insertItem:forDateKey:]): Perform a binary search within the day's history items rather than a linear search.

   977         (-[WebHistoryPrivate _removeItemFromDateCaches:]):

   978         (-[WebHistoryPrivate _addItemToDateCaches:]):

   979         (-[WebHistoryPrivate removeAllItems]):

   980         (-[WebHistoryPrivate orderedLastVisitedDays]): Generate and cache the sorted NSArray of NSCalendarDate's exposed in the API.

   981         This cache is invalidated by _removeItemFromDateCaches: and _addItemToDateCaches: when needed.

   982         (-[WebHistoryPrivate orderedItemsLastVisitedOnDay:]):

   983         (-[WebHistoryPrivate arrayRepresentation]):

   984         (-[WebHistoryPrivate _loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]): Use an autorelease pool to keep the

   985         number of live autoreleased objects generated to a reasonable level.

   986         * History/WebHistoryItem.mm:

   987         (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):

   988         (-[WebHistoryItem initFromDictionaryRepresentation:]): Use the new HistoryItem constructor that accepts the alternate title

   989         rather than setting it after construction.  This prevents a modification notification from being sent for each WebHistoryItem that is loaded.

   990         * History/WebHistoryItemInternal.h:

   991         * History/WebHistoryPrivate.h:

   992         * Misc/WebNSCalendarDateExtras.h: Removed as _webkit_compareDay: is no longer used.

   993         * Misc/WebNSCalendarDateExtras.m: Removed.

   994         * WebKit.xcodeproj/project.pbxproj:

   995 

   996 2007-08-28  Anders Carlsson  <andersca@apple.com>

   997 

   998         Reviewed by Darin.

   999 

  1000         <rdar://problem/5298296> XMLHttpRequest readyState 3 & responseText buffer issues

  1001         

  1002         Expose WKSetNSURLRequestShouldContentSniff to WebCore.

  1003         

  1004         * WebCoreSupport/WebSystemInterface.m:

  1005         (InitWebCoreSystemInterface):

  1006 

  1007 2007-08-24  Kevin McCullough  <kmccullough@apple.com>

  1008 

  1009         Reviewed by Darin.

  1010 

  1011         <rdar://problem/5437038> 1 credential object leaked for each call to credentialWithUser:password:persistence

  1012         - Use initWithUser instead of credentialWithUser because credentialWithUser leaks.

  1013 

  1014         * Panels/WebAuthenticationPanel.m:

  1015         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):

  1016         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):

  1017 

  1018 2007-08-24  Adele Peterson  <adele@apple.com>

  1019 

  1020         Fix by Darin, reviewed by Adele.

  1021 

  1022         Fix for <rdar://problem/5433422> Upon quitting, WebKit loads the WebPlugin shared database and immediately closes it

  1023 

  1024         * Plugins/WebPluginDatabase.h: Added closeSharedDatabase, which won't create a new database if we're just trying to close it.

  1025         * Plugins/WebPluginDatabase.m: (+[WebPluginDatabase closeSharedDatabase]): Added.

  1026         * WebView/WebView.mm:

  1027         (-[WebView _close]): Call closeSharedDatabase.

  1028         (+[WebView _applicationWillTerminate]): Call closeSharedDatabase.

  1029 

  1030 2007-08-24  Timothy Hatcher  <timothy@apple.com>

  1031 

  1032         Reviewed by John Sullivan.

  1033 

  1034         <rdar://problem/5410937> HIWebView in SimpleCarbonWeb doesn't seem to be getting adequate invalidation when window is resized

  1035 

  1036         This is a more localized fix for yesterday's change. Now explicitly call _web_layoutIfNeededRecursive inside the

  1037         HIWebView Draw() function. Adds a FIXME to explain that we need to do layout before Carbon has decided what regions to draw.

  1038         Doing layout in Draw() will potentially cause drawing to happen in two passes, but this has always been a problem in Carbon.

  1039 

  1040         * Carbon/HIWebView.m:

  1041         (Draw): Call _web_layoutIfNeededRecursive on the main WebHTMLView.

  1042         (SetFocusPart): Fix to work in ObjC++ (now that HIWebView.m is treated as a ObjC++ file.)

  1043         * WebView/WebView.mm: Removes the 4 displayIfNeeded methods from yesterday's change.

  1044         * WebKit.xcodeproj/project.pbxproj: Force the file type of HIWebView.m to ObjC++ so WebHTMLViewInternal.h can be included.

  1045 

  1046 2007-08-23  Timothy Hatcher  <timothy@apple.com>

  1047 

  1048         Reviewed by Dave Hyatt.

  1049 

  1050         <rdar://problem/5410937> HIWebView in SimpleCarbonWeb doesn't seem to be getting adequate invalidation when window is resized

  1051 

  1052         The Carbon HIWebView was relying on layout happening when displayIfNeededInRect: was called on the WebView.

  1053         This would happen on Tiger because _recursiveDisplayRectIfNeededIgnoringOpacity: would always do a layout if needed.

  1054         Doing a layout in _recursiveDisplayRectIfNeededIgnoringOpacity was removed in Leopard in favor of viewWillDraw, and

  1055         the fact that adding new dirty rects inside _recursiveDisplayRectIfNeededIgnoringOpacity on Leopard will not

  1056         cause a drawRect in the same display loop.

  1057 

  1058         So any client on Leopard calling displayIfNeeded* on the WebView would get a layout and any new dirty rects. So

  1059         _web_layoutIfNeededRecursive needs to be called on the main frame's WebHTMLView to make sure we layout and

  1060         display anything that is really needed.

  1061 

  1062         * WebView/WebHTMLView.mm:

  1063         (-[WebHTMLView _layoutIfNeeded]):

  1064         (-[WebHTMLView _web_layoutIfNeededRecursive]):

  1065         * WebView/WebHTMLViewInternal.h:

  1066         * WebView/WebView.mm:

  1067         (-[WebView displayIfNeeded]): Call _web_layoutIfNeededRecursive on the main WebHTMLView.

  1068         (-[WebView displayIfNeededIgnoringOpacity]): Ditto.

  1069         (-[WebView displayIfNeededInRect:]): Ditto. 

  1070         (-[WebView displayIfNeededInRectIgnoringOpacity:]): Ditto.

  1071 

  1072 2007-08-22  Timothy Hatcher  <timothy@apple.com>

  1073 

  1074         Rolling out r25102 for <rdar://problem/5410937> until

  1075         <rdar://problem/5429920> is resolved.

  1076 

  1077         * Carbon/CarbonUtils.m:

  1078         (WebInitForCarbon):

  1079         (PoolCleaner):

  1080         * Carbon/CarbonWindowAdapter.h:

  1081         * Carbon/CarbonWindowAdapter.m:

  1082         * Carbon/CarbonWindowContentView.h:

  1083         * Carbon/CarbonWindowContentView.m:

  1084         * Carbon/CarbonWindowFrame.h:

  1085         * Carbon/CarbonWindowFrame.m:

  1086         * Carbon/HIViewAdapter.h:

  1087         * Carbon/HIViewAdapter.m:

  1088         * Carbon/HIWebView.h:

  1089         * Carbon/HIWebView.m:

  1090 

  1091 2007-08-20  John Sullivan  <sullivan@apple.com>

  1092 

  1093         Reviewed by Adam Roben

  1094         

  1095         WebKit part of fix for: 

  1096         <rdar://problem/5417777> WebKit focus ring color no longer matches system focus rings

  1097 

  1098         * Misc/WebNSAttributedStringExtras.mm:

  1099         now includes <WebCore/ColorMac.h> to account for moved declaration

  1100         * WebView/WebFrame.mm:

  1101         ditto

  1102         

  1103         * WebView/WebViewPrivate.h:

  1104         * WebView/WebView.mm:

  1105         (+[WebView _setUsesTestModeFocusRingColor:]):

  1106         new SPI, calls through to new WebCore function. This is used by DumpRenderTree to make sure the

  1107         focus ring color is always the same when performing layout tests, regardless of OS X version.

  1108         (+[WebView _usesTestModeFocusRingColor]):

  1109         new SPI, calls through to new WebCore function

  1110 

  1111 2007-08-20  Antti Koivisto  <antti@apple.com>

  1112 

  1113         Reviewed by John.

  1114         

  1115         Fix <rdar://problem/5378390>

  1116         Crash at Range::startContainer() when creating multiple ToDos on the same line

  1117         

  1118         Null check range.

  1119         

  1120         No layout test, this only happens with ObjC API.

  1121 

  1122         * WebView/WebHTMLView.mm:

  1123         (-[WebHTMLView _expandSelectionToGranularity:]):

  1124 

  1125 2007-08-20  Maciej Stachowiak  <mjs@apple.com>

  1126 

  1127         Not reviewed, fix for crash on launch bug in last patch.

  1128 

  1129         * WebView/WebHTMLView.mm:

  1130         (-[WebHTMLView setDataSource:]): Remove an assertion, fix code to work right in the

  1131         face of that condition.

  1132 

  1133 2007-08-18  Maciej Stachowiak  <mjs@apple.com>

  1134 

  1135         Reviewed by Darin.