--- a/telephonyserverplugins/common_tsy/commontsy/src/mmstorage/cmmenstoretsy.cpp Mon Mar 15 12:45:06 2010 +0200
+++ b/telephonyserverplugins/common_tsy/commontsy/src/mmstorage/cmmenstoretsy.cpp Wed Mar 31 23:24:02 2010 +0300
@@ -27,7 +27,8 @@
// ======== MEMBER FUNCTIONS ========
-CMmENStoreTsy::CMmENStoreTsy()
+CMmENStoreTsy::CMmENStoreTsy():
+ iReqHandleType(EMultimodeENStoreReqHandleUnknown)
{
}
@@ -311,8 +312,13 @@
TInt ret = KErrNone;
TInt trapError = KErrNone;
- // Reset last tsy request type
- iReqHandleType = EMultimodeENStoreReqHandleUnknown;
+ // Ensure the ReqHandleType is unset.
+ // This will detect cases where this method indirectly calls itself
+ // (e.g. servicing a client call that causes a self-reposting notification to complete and thus repost).
+ // Such cases are not supported because iReqHandleType is in the context of this class instance,
+ // not this request, and we don't want the values set by the inner request and the outer request
+ // interfering with each other.
+ __ASSERT_DEBUG(iReqHandleType==EMultimodeENStoreReqHandleUnknown, User::Invariant());
// Trap and call function that dispatches function requests
TRAP ( trapError, ret = DoExtFuncL( aTsyReqHandle, aIpc, aPackage ); );
@@ -337,6 +343,9 @@
#else
iTsyReqHandleStore->SetTsyReqHandle( iReqHandleType, aTsyReqHandle );
#endif
+ // We've finished with this value now. Clear it so it doesn't leak
+ // up to any other instances of this method down the call stack
+ iReqHandleType = EMultimodeENStoreReqHandleUnknown;
}
return KErrNone;