diff -r 962e6306d9d2 -r 7ef16719d8cb smsprotocols/smsstack/gsmu/src/gsmupdu.cpp --- a/smsprotocols/smsstack/gsmu/src/gsmupdu.cpp Fri Feb 19 23:59:33 2010 +0200 +++ b/smsprotocols/smsstack/gsmu/src/gsmupdu.cpp Fri Mar 12 15:49:38 2010 +0200 @@ -153,7 +153,6 @@ TGsmuLex8 lex(aGsmSms.Pdu()); smspdu->DecodeL(lex); - // TODO Service centre address should be in rigth format when it comes from TSY smspdu->SetParsedServiceCenterAddressL(aGsmSms.Sca()); CleanupStack::Pop(smspdu); @@ -488,11 +487,6 @@ // -// TODO move this to the DCS descriptions -// Also, the functions available are dependant on bits 7 to 4 in the data coding scheme. -// Functions panic when they are not available. -// This requires the caller to have some knowledge of ETSI GSM 03.38 in order to keep the data coding scheme in a consistent state. -// /** * Updates the three pieces of concatenation data (reference number, * pdu index and max pdu number) in this PDU. @@ -2636,7 +2630,8 @@ { // // Throw away rest of the pdu - some pdus received with this bit set don't appear to conform to 03.40 v7.4.0 spec. - // TODO Will need to review later, though this appears safest option now. + // This appears safest option. + // TODO check new versions of 03.40 to make sre that it is still the right option // ((TSmsOctet&)iParameterIndicator)=TSmsParameterIndicator::ESmsPIDExtension; return; @@ -2852,7 +2847,8 @@ { // // Throw away rest of the pdu - some pdus received with this bit set don't appear to conform to 03.40 v7.4.0 spec. - // TODO Will need to review later, though this appears safest option now. + // This appears safest option. + // TODO check new versions of 03.40 to make sre that it is still the right option // ((TSmsOctet&)iParameterIndicator)=TSmsParameterIndicator::ESmsPIDExtension; return;