FCL/sf/os/kernelhwsrv: comparison userlibandfileserver/fileserver/sfile/sf_plugin

equal deleted inserted replaced

-:43365a9b78a3
+:d8d70de2bd36
 #include "sf_std.h"
 #include "sf_plugin_priv.h"
 CFsObjectCon* FsPluginManager::iPluginFactories = NULL;
 CFsObjectCon* FsPluginManager::iPluginConns     = NULL;
-RFastLock FsPluginManager::iChainLock;
+RReadWriteLock FsPluginManager::iChainLock;
 RPointerArray<CFsPlugin> FsPluginManager::iPluginChain;
 CFsSyncMessageScheduler* FsPluginManager::iScheduler = NULL;
 TBool IsPagableDrive(TInt aDrive)
 	{
 		{
 		pP->Close();
 		return err;
 		}
-	LockChain();
+	WriteLockChain();
 	err = InsertInPluginStack(pP,aPos);
 	UnlockChain();
 	if(err != KErrNone)
 		{
 		pP->Close();
 /**
 Transfer any outstanding requests to next/previous plugin depending on
 if it is post filter or not
-Must be called with the plugin chain locked.
+Must be called with the plugin chain write-locked.
 Attains plugin-thread's listlock.
 */
 void FsPluginManager::TransferRequests(CPluginThread* aPluginThread)
 	{
 	aPluginThread->iListLock.Wait();
 	            }
 	        if(pR->IsPostOperation())
 	            {
 	            //[set the plugin to] pass the request backwards in the chain
-	            PrevPlugin(pR->iCurrentPlugin, &mR, EFalse);
+	            PrevPlugin(pR->iCurrentPlugin, &mR);
 	            }
 	        else //IsPreOperations
 	            {
 	            //[set the plugin to] pass the request forwards in the chain
-	            NextPlugin(pR->iCurrentPlugin, &mR, EFalse);
+	            NextPlugin(pR->iCurrentPlugin, &mR);
 	            }
 	        if(pR->iCurrentPlugin)
 	            {
 	            pR->iCurrentPlugin->iThreadP->DeliverBack(pR);
 	}
 /**
 Find the next plugin that supports the operation
+Must be called with the plugin chain (at least read-) locked.
 @param aPlugin - On calling the function this may contain either NULL or the current plugin.
 If it is called with NULL, then we start to look for plugins from the beginning of the chain.
 If is is called with a plugin then we start to look after that plugin for the next one.
 On return, aPlugin shall contain either a plugin or NULL.
-@param aLock - If this is set to ETRUE, then the function shall lock the plugin chain.
-If this is set to EFALSE, then the caller of the function MUST already hold the lock.
 @param aCheckCurrentOperation - Optional, if false, will return the next plugin,
 								whether the plugin is currently registered
 								for the current function or not. (so long as mounted on the current drive)
 */
-TInt FsPluginManager::NextPlugin(CFsPlugin*& aPlugin, CFsMessageRequest* aMsgRequest,TBool aLock, TBool aCheckCurrentOperation)
+TInt FsPluginManager::NextPlugin(CFsPlugin*& aPlugin, CFsMessageRequest* aMsgRequest, TBool aCheckCurrentOperation)
 	{
 	if(aMsgRequest->DirectToDrive())
 		{
 		aPlugin = NULL;
 		return KErrNotFound;
 	TInt start;
 	TInt function = aMsgRequest->Operation()->Function();
 	TInt drive = aMsgRequest->DriveNumber();
-	if(aLock)
-	    LockChain();
 	//the plugin chain lock must be held by this point.
 	TInt count = iPluginChain.Count();
 	if(aPlugin == NULL)
 		start=0;
 				{
 				if((function == EFsDismountPlugin) || (iPluginChain[i]->IsMounted(drive)))
 					{
 					aPlugin = iPluginChain[i];
-					if(aLock)
-					    UnlockChain();
 					return KErrNone;
 					}
 				}
 			}
 		}
 	aPlugin = NULL;
-	if(aLock)
-	    UnlockChain();
 	return KErrNotFound;
 	}
 /**
 Find the next plugin that supports the operation
+Must be called with the plugin chain (at least read-) locked.
 @see FsPluginManager::NextPlugin
 */
-TInt FsPluginManager::PrevPlugin(CFsPlugin*& aPlugin, CFsMessageRequest* aMsgRequest, TBool aLock)
+TInt FsPluginManager::PrevPlugin(CFsPlugin*& aPlugin, CFsMessageRequest* aMsgRequest)
 	{
 	if(aMsgRequest->DirectToDrive() && (aMsgRequest->CurrentOperationPtr() != NULL))
 		{
 		aPlugin = NULL;
 		return KErrNotFound;
 		}
 	TInt start;
 	TInt function = aMsgRequest->Operation()->Function();
 	TInt drive = aMsgRequest->DriveNumber();
-	if(aLock)
-	    LockChain();
 	//the plugin chain lock must be held by this point.
 	TInt count= iPluginChain.Count();
 	if(aPlugin == NULL)
 				{
 				if((function == EFsDismountPlugin) || (iPluginChain[i]->IsMounted(drive)))
 					{
 					aPlugin = iPluginChain[i];
-					if(aLock)
-					    UnlockChain();
 					return KErrNone;
 					}
 				}
 			}
 		}
 	aPlugin = NULL;
-	if(aLock)
-	    UnlockChain();
 	return KErrNotFound;
 	}
 /**
 Inserts the plugin in the stack (chain)
 /**
 Finds a plugin by unique position
 */
 CFsPlugin* FsPluginManager::FindByUniquePosition(TInt aUniquePosition)
 	{
-	LockChain();
+	ReadLockChain();
 	CFsPlugin* plugin = NULL;
 	TInt count= iPluginChain.Count();
 	for(TInt i=0;i<count;i++)
 		{
 		if(aUniquePosition == iPluginChain[i]->iUniquePos)
 	aPlugin = iPluginChain[aPos];
 	return KErrNone;
 	}
 /**
-Locks the chain
+Locks the chain for reading
 */
-void FsPluginManager::LockChain()
+void FsPluginManager::ReadLockChain()
 	{
-	iChainLock.Wait();
+iChainLock.ReadLock();
 	}
+/**
+Locks the chain for writing
+*/
+void FsPluginManager::WriteLockChain()
+{
+iChainLock.WriteLock();
+}
 /**
 Unlocks the chain
 */
 void FsPluginManager::UnlockChain()
 	{
-	iChainLock.Signal();
+iChainLock.Unlock();
 	}
 /**
 Gets plugin conn from handle
 */
 	__PRINT2(_L("FsPluginManager::CompleteSessionRequests(%08x, %d)"), aSession, aValue);
 	// Iterate through all plugins, cancelling outstanding session requests
 	aRequest->Set(CancelPluginOp, aSession);
-	FsPluginManager::LockChain();
+	FsPluginManager::ReadLockChain();
 	TInt count = FsPluginManager::ChainCount();
 	TInt oldCount = count;
 	TInt i;
 	for(i=0; i<count; i++)
 	    {
 	    aRequest->Dispatch();
 	    //Cancel is delivered to the front of the request queue
 	    //so hopefully this wont take too long.
 	    FsPluginManager::UnlockChain();
 	    User::WaitForRequest(aRequest->Status());
-	    FsPluginManager::LockChain();
+	    FsPluginManager::ReadLockChain();
 	    __ASSERT_ALWAYS(aRequest->Status().Int()==KErrNone||aRequest->Status().Int()==KErrCancel,Fault(ESessionDisconnectThread2));
 	    count = FsPluginManager::ChainCount();
 	    //If a plugin was removed whilst the chain was unlocked we need to make sure we don't skip any plugins
 	    if(count != oldCount)
 	        {

changeset 247	d8d70de2bd36
parent 200	73ea206103e6
child 273	6a75fa55495f