1 1.1      "Restart Timer default is 3 seconds (with Configure-Requests)\n"

     2 comment: default parameters

     3 

     4 

     5 1.2      "Restart Timer default is 3 seconds (with Terminate-Requests)\n"

     6 comment: default parameters

     7 

     8 

     9 1.3		"- ANVL: Configure Restart Timer to be different than 3 seconds\n"

    10 default:

    11 PPPEnableRestartTimer = 0 //:disabled - 1:enabled

    12 PPPRestartPeriod= 3000 //default 3 Seconds

    13 now:

    14 [lcp]

    15 PPPEnableRestartTimer = 1

    16 PPPRestartPeriod= 6000

    17 

    18 

    19 1.4		"Max Terminate default is 2\n"

    20 comment: in the test code we extend this timer

    21 default:

    22 PPPEnableRestartTimer = 0 //:disabled - 1:enabled

    23 PPPRestartPeriod= 3000 //default 3 Seconds

    24 now:

    25 [lcp]

    26 PPPEnableRestartTimer = 1

    27 PPPRestartPeriod= 30000

    28 

    29 comment: The default Max Terminate in the code is 10. Hence this test will fail.

    30 

    31 

    32 1.5     "Max Terminate MUST be configurable\n"

    33 comment: in the test code we extend this timer

    34 default:

    35 PPPEnableRestartTimer = 0 //:disabled - 1:enabled

    36 PPPRestartPeriod= 3000 //default 3 Seconds

    37 now:

    38 [lcp]

    39 PPPEnableRestartTimer = 1

    40 PPPRestartPeriod= 30000

    41 

    42 comment: The default Max Terminate in the code is 10. Hence this test should pass since it is defferent that the default 2.

    43 

    44 

    45 1.6     "Max Configure default is 10\n"

    46 comment: this value in the code is by default 10, but the ini files looks like this:

    47 [lcp]

    48 PPPEnableMaxRestart = 0 //:disabled - 1:enabled

    49 PPPMaxRestartCount = 20 //default

    50 

    51 

    52 1.7     "Max Configure MUST be configurable\n"

    53 note that the default in the code and the ini file differs:10 in the code, 20 in the ini file

    54 default:

    55 PPPEnableMaxRestart = 0 //:disabled - 1:enabled

    56 PPPMaxRestartCount = 20 //default

    57 now:

    58 [lcp]

    59 PPPEnableMaxRestart = 1

    60 PPPMaxRestartCount = 5

    61 

    62 

    63 1.8     "Max Failure default is 5\n"

    64 comment: the value in the code is by default is 5

    65 

    66 

    67 1.9     "Max Failure MUST be configurable\n"

    68 default:

    69 PPPEnableMaxFailure = 0 //:disabled  - 1:enabled

    70 PPPMaxFailureCount = 5 //default

    71 now:

    72 [lcp]

    73 PPPEnableMaxFailure = 1

    74 PPPMaxFailureCount = 2

    75 

    76 

    77 3.1      "An implementation wishing to open connection MUST transmit a Configure-Request\n"

    78 comment: default parameters

    79 

    80 3.3     "The Identifier field MUST be changed whenever the content of the Options field changes.\n"

    81 default:

    82 PPPEnableMru= 1

    83 PPPMru= 1500

    84 now:

    85 PPPEnableMru= 1

    86 PPPMru= 576

    87 

    88 

    89 3.4      "Upon reception of Configure-Request, an appropriate reply MUST be transmitted.\n",

    90 comment: default parameters

    91 

    92 

    93 3.5      "Configure-Requests with bad lengths are ignored\n"

    94 comment: default parameters

    95 

    96 

    97 3.6      "Configuration Options SHOULD NOT be included with default values\n"

    98 default:

    99 PPPEnableMru= 1

   100 PPPMru= 1500

   101 now:

   102 [link]

   103 PPPEnableMru= 1

   104 PPPMru= 576

   105 

   106 

   107 4.1      "If every Option and value received in Configure-Request is recognizable then the implementation MUST transmit Configure-Ack\n"

   108 comment: default parameters

   109 

   110 

   111 4.2      "Discard Configure-Acks whose Identifier and/or Option fields do not match those of the Configure-Request.\n"

   112 comment: default parameters

   113 

   114 

   115 4.3     "The Options in the Configure-Ack contains the Options field copied from the Configure-Request\n"

   116 comment: default parameters

   117 

   118 

   119 4.4      "A Configure-Ack with invalid Options should be discarded\n"

   120 default:

   121 [link]

   122 PPPEnableAccm= 1

   123 PPPAccm= FFFFFF0F // The example below would enable accm config and negate the need to escape values 4 - 7 inclusive

   124 now:

   125 [link]

   126 PPPEnableAccm= 1

   127 PPPAccm= 0xA5A5A5A5

   128 

   129 

   130 4.5      "Configure-Ack with bad length is discarded\n"

   131 comment: default parameters

   132 

   133 

   134 4.6      "Unsolicited Configure-Acks are discarded\n"

   135 comment: default parameters

   136 

   137 

   138 5.1     "If all Options are known, but some have unacceptable values a Configure-Nak is sent with appropriate values indicated\n"

   139 comment: default parameters

   140 

   141 

   142 5.2      "Options which have no value fields (boolean Options) MUST use the Configure-Reject reply instead.\n"

   143 comment: default parameters

   144 

   145 

   146 5.4     "If Identifier in Configure-Nak does not match that of the last Configure-Request it MUST be discarded\n"

   147 comment: default parameters

   148 comment: says that we have to open a connection with a magic number option. How do we do that?

   149 

   150 

   151 5.5     "Reception of Configure-Nak indicates that new Configure-Request MAY be sent with the Options modified as in the Configure-Nak\n"

   152 default:

   153 PPPEnableMru= 1

   154 PPPMru= 1500

   155 now:

   156 [link]

   157 PPPEnableMru= 1

   158 PPPMru= 576

   159 

   160 

   161 5.6     "A Configure-Nak may contain Options with default values if different from the Configure-Request\n",

   162 default:

   163 PPPEnableMru= 1

   164 PPPMru= 1500

   165 now:

   166 [link]

   167 PPPEnableMru= 1

   168 PPPMru= 576

   169 

   170 

   171 5.9     "Unsolicited Configure-Naks are discarded\n"

   172 comment: default parameters

   173 

   174 

   175 5.10     "Configure-Nak with bad length is discarded\n"

   176 comment: default parameters

   177 

   178 

   179 5.11     "Configure-Nak with no Options should be ignored\n"

   180 comment: default parameters

   181 

   182 

   183 6.1     "If Options received in Configure-Request are not acceptable for negotiation then Configure-Reject MUST be sent\n"

   184 comment: default parameters

   185 

   186 

   187 6.2     "Invalid Configure-Rejects are discarded\n"

   188 comment: default parameters

   189 

   190 

   191 6.3     "A Configure-Request with none of the rejected Options should be sent when valid Configure-Reject is received\n"

   192 default:

   193 [link]

   194 PPPEnableAccm= 1

   195 PPPAccm= FFFFFF0F // The example below would enable accm config and negate the need to escape values 4 - 7 inclusive

   196 now:

   197 [link]

   198 PPPEnableAccm= 1

   199 PPPAccm= 0xA5A5A5A5

   200 

   201 

   202 6.4     "Configure-Rejects with bad lengths should be discarded\n"

   203 comment: default parameters

   204 

   205 

   206 6.5     "Configure-Reject with no Options should be ignored\n"

   207 comment: default parameters

   208 

   209 

   210 6.6     "Unsolicited Configure-Rejects are discarded\n"

   211 comment: default parameters

   212 

   213 

   214 7.1     "A LCP implementation wishing to close connection SHOULD transmit a LCP packet with the Code field set to 5 (Terminate-Request)\n"

   215 comment: default parameters

   216 

   217 

   218 7.2     "Terminate-Request packets SHOULD continue to be sent until Terminate-Ack is received.\n"

   219 comment: default parameters

   220 

   221 

   222 7.3     "Terminate-Request packets SHOULD continue to be sent until the lower layer indicates that it has gone down.\n"

   223 comment: default parameters

   224 

   225 

   226 7.4     "Terminate-Request packets SHOULD continue to be sent until a sufficiently large number have been transmitted\n"

   227 comment: default parameters

   228 

   229 

   230 7.5     "Upon reception of Terminate-Request, a Terminate-Ack MUST be transmitted\n"

   231 comment: default parameters

   232 

   233 

   234 7.7     "An unelicited Terminate-Ack means peer is in need of renegotiation\n"

   235 comment: default parameters

   236 

   237 

   238 7.9     "Bad length Terminate-Request packets should be discarded\n"

   239 comment: default parameters

   240 

   241 

   242 7.10     "Bad length Terminate-Ack packets should be discarded\n"

   243 comment: default parameters

   244 

   245 

   246 8.1     "Reception of a LCP packet with an invalid Code MUST be reported by transmitting a Code-Reject\n"

   247 comment: default parameters

   248 

   249 

   250 8.2     "The Identifier field MUST be changed for each Code-Reject sent.\n"

   251 comment: default parameters

   252 

   253 

   254 8.3     "The Rejected-Information MUST be truncated to comply with the peer's established MRU.\n"

   255 comment: default parameters

   256 

   257 

   258 8.4     "Unsolicited Code-Reject should be discarded\n"

   259 comment: default parameters

   260 

   261 

   262 8.5     "Bad length Code-Reject packets should be discarded\n"

   263 comment: default parameters

   264 

   265 

   266 8.6     "A Code-Reject of a packet such as an Echo-Reply communicates an unrecoverable error that terminates the connection\n"

   267 comment: default parameters

   268 

   269 

   270 9.1     "Reception of a PPP packet with an unknown Protocol field MUST be reported back to the peer by transmitting a Protocol-Reject\n"

   271 comment: default parameters

   272 

   273 

   274 9.2     "Upon reception of a Protocol-Reject, the implementation MUST stop sending packets of the indicated protocol\n"

   275 comment: default parameters, think so.

   276 comment: Did not really understand this test.

   277 

   278 

   279 9.3     "The Identifier field MUST be changed for each Protocol-Reject sent.\n"

   280 comment: default parameters

   281 

   282 

   283 9.4     "The Rejected-Information MUST be truncated to comply with the peer's established MRU.\n"

   284 comment: default parameters

   285 

   286 

   287 9.5     "Protocol-Reject of LCP should cause full connection shutdown\n"

   288 comment: default parameters

   289 

   290 

   291 9.6     "Protocol-Rejects with bad lengths should be ignored\n"

   292 comment: default parameters

   293 

   294 

   295 9.7     "Discard Protocol-Reject with unknown protocol\n"

   296 comment: default parameters

   297 

   298 

   299 9.8     "Protocol-Reject packets can only be sent in the LCP Opened state\n"

   300 comment: default parameters

   301 

   302 

   303 9.9     "Protocol-Reject of LCP (RXJ- in state 2-9) causes full shutdown\n"

   304 comment: default parameters

   305 

   306 

   307 9.10     "Protocol-Reject packets received in any state other than LCP Opened SHOULD be silently discarded\n"

   308 comment: default parameters

   309 

   310 

   311 10.1     "Echo-Request fields correctly filled in\n"

   312 comment: default parameters

   313 comment, need to get DUT to send echo request.

   314 

   315 

   316 10.2     "Upon reception of an Echo-Request, a correctly formatted Echo-Reply is sent\n"

   317 comment: default parameters

   318 

   319 

   320 10.3     "On transmission, the Identifier field MUST be changed whenever a valid reply has been received for a previous request.\n"

   321 comment: default parameters

   322 comment, need to get DUT to send echo request.

   323 

   324 

   325 10.4     "Echo-Request and Echo-Reply packets MUST only be sent in the LCP Opened state; any received when not in that state are discarded.\n"

   326 comment: default parameters

   327 comment, need to get DUT to send echo request.

   328 

   329 

   330 10.5     "Echo-Reply Data must be truncated to accommodate peer's MRU\n"

   331 comment: default parameters

   332 

   333 

   334 10.6     "Unsolicited Echo-Reply is discarded\n"

   335 comment: default parameters

   336 

   337 

   338 10.7     "Echo-Reply with Identifier different from Echo-Request is ignored\n"

   339 comment: default parameters

   340 comment, need to get DUT to send echo request.

   341 

   342 

   343 10.8     "Echo-Requests with non-zero Magic-Numbers are discarded when Magic-Number has not been negotiated\n"

   344 comment: default parameters

   345 

   346 

   347 10.9     "Echo-Requests with bad Magic-Numbers are discarded when Magic-Number has been negotiated\n"

   348 comment: default parameters

   349 comment: says that we have to open a connection with a magic number option. How do we do that?

   350 

   351 

   352 10.10     "Echo-Requests with bad lengths are discarded\n"

   353 comment: default parameters

   354 

   355 

   356 10.11     "Echo-Requests should be retransmitted if no Echo-Reply is received\n"

   357 comment: default parameters

   358 comment, need to get DUT to send echo request.

   359 

   360 

   361 10.12     "Echo-Replies with non-zero Magic-Numbers are discarded when Magic-Number has not been negotiated\n"

   362 comment: default parameters

   363 comment, need to get DUT to send echo request.

   364 

   365 

   366 10.13     "Echo-Replies with bad Magic-Numbers are discarded when Magic-Number has been negotiated\n"

   367 comment, need to get DUT to send echo request.

   368 comment: says that we have to open a connection with a magic number option. How do we do that?

   369 

   370 

   371 10.14     "Echo-Replies with bad lengths are discarded\n"

   372 comment: default parameters

   373 comment, need to get DUT to send echo request.

   374 

   375 

   376 12.1     "Validate format of Maximum-Receive-Unit Option fields\n"

   377 default:

   378 PPPEnableMru= 1

   379 PPPMru= 1500

   380 now:

   381 PPPEnableMru= 1

   382 PPPMru= 576

   383 

   384 

   385 12.2     "Check Maximum-Receive-Unit Option is functional\n"

   386 comment: long test. Seems to be really in 2 parts.

   387 default:

   388 PPPEnableMru= 1

   389 PPPMru= 1500

   390 now:

   391 PPPEnableMru= 1

   392 PPPMru= 576

   393 

   394 

   395 12.3     "The default Maximum-Receive-Unit is 1500 octets.\n"

   396 comment: default parameters

   397 

   398 

   399 12.4     "If a Maximum-Receive-Unit of less than 1500 is negotiated, packets of length 1500 must still be accepted\n"

   400 default:

   401 PPPEnableMru= 1

   402 PPPMru= 1500

   403 now:

   404 PPPEnableMru= 1

   405 PPPMru= 576

   406 

   407 

   408 12.6     "A Maximum-Receive-Unit of less than 4 should not be allowed\n"

   409 comment: default parameters

   410 

   411 

   412 12.7	 "If an Option is received (MRU) in a Configure-Request but with an incorrect Length, a Configure-Nak SHOULD be transmitted unless the Length goes beyond the end of the packet\n"

   413 comment: default parameters

   414 

   415 

   416 13.1     "Validate format of Async-Control-Character-Map Option fields\n",

   417 default:

   418 [link]

   419 PPPEnableAccm= 1

   420 PPPAccm= FFFFFF0F // The example below would enable accm config and negate the need to escape values 4 - 7 inclusive

   421 now:

   422 [link]

   423 PPPEnableAccm= 1

   424 PPPAccm= 0xA5A5A5A5

   425 

   426 

   427 13.2     "Validate functionality of Async-Control-Character-Map Option\n"

   428 comment: default parameters

   429 

   430 

   431 13.3	 "If an Option is received (ACCM) in a Configure-Request but with an incorrect Length, a Configure-Nak SHOULD be transmitted unless the Length goes beyond the end of the packet\n"

   432 comment: default parameters

   433 

   434 

   435 14.1     "Validate format of Authentication-Protocol Option fields\n"

   436 comment: we have to enable PAP on the DUT side. How do we do that?

   437 

   438 

   439 14.2     "An implementation MUST NOT include multiple Authentication-Protocol Configuration Options in its Configure-Request packets.\n"

   440 comment: long test. Seems to be really in 2 parts.

   441 comment: we have to enable PAP on the DUT side. How do we do that?

   442 

   443 

   444 14.5	 "If an Option is received (Auth Protocol) in a Configure-Request but with an incorrect Length, a Configure-Nak SHOULD be transmitted unless the Length goes beyond the end of the packet\n"

   445 comment: default parameters

   446 

   447 

   448 15.1     "Validate format of Quality-Protocol Option fields\n"

   449 comment: we must here set the LQM. How do we do that? What is it?

   450 

   451 

   452 15.4	 "If an Option is received (Quality Protocol) in a Configure-Request but with an incorrect Length, a Configure-Nak SHOULD be transmitted\n"

   453 comment: default parameters

   454 

   455 

   456 16.1     "Validate format of Magic-Number Option fields\n"

   457 comment: says that we have to open a connection with a magic number option. How do we do that?

   458 

   459 

   460 16.2     "A Magic-Number of zero is illegal and MUST always be Nak'd, if it is not Rejected outright.\n"

   461 comment: default parameters

   462 

   463 

   464 16.3     "If Magic-Number Option in a received Configure-Request is different than the last Magic-Number Option sent, it SHOULD be acknowleged\n"

   465 comment: says that we have to open a connection with a magic number option. How do we do that?

   466 

   467 

   468 16.4     "If a received Configure-Request has the same Magic-Number Option as the last Configure-Request sent, MUST send Configure-Nak\n"

   469 comment: says that we have to open a connection with a magic number option. How do we do that?

   470 

   471 

   472 16.5     "A new Configure-Request SHOULD NOT be sent to the peer until normal processing would cause it to be sent\n"

   473 comment: says that we have to open a connection with a magic number option. How do we do that?

   474 

   475 

   476 16.7	 "If Magic-Number requested, MUST NOT reject request for Magic-Number\n"

   477 comment: says that we have to open a connection with a magic number option. How do we do that?

   478 

   479 

   480 16.8     "If Magic-Number Option is rejected, it SHOULD be treated as if a Configure-Ack had been received\n"

   481 comment: says that we have to open a connection with a magic number option. How do we do that?

   482 

   483 

   484 16.10	 "If an Option is received (Magic Number) in a Configure-Request but with an incorrect Length, a Configure-Nak SHOULD be transmitted unless the Length goes beyond the end of the packet\n"

   485 comment: default parameters

   486 

   487 

   488 17.1     "Validate format of Protocol-Field-Compression Option fields\n"

   489 comment: must enable Protocol-Field-Compression. How do we do that?

   490 

   491 

   492 17.2     "When negotiated, PPP implementations MUST accept PPP packets with either double-octet or single-octet Protocol fields\n"

   493 comment: must enable Protocol-Field-Compression. How do we do that?

   494 

   495 

   496 17.3     "Reject single-octet Protocol fields when compression not negotiated\n"

   497 comment: must _disable_ Protocol-Field-Compression. How do we do that?

   498 

   499 

   500 17.5     "When a Protocol field is compressed, the Data Link Layer FCS field is calculated on the compressed frame, not the original frame.\n"

   501 comment: must enable Protocol-Field-Compression. How do we do that?

   502 

   503 

   504 17.6	 "If an Option is received (PFC) in a Configure-Request but with an incorrect Length, a Configure-Nak SHOULD be transmitted unless the Length goes beyond the end of the packet\n"

   505 comment: default parameters

   506 

   507 

   508 18.1     "Validate format of Address-and-Control-Field-Compression Option fields\n"

   509 comment: configure DUT to use ACFC Option Fields. How do we do that?

   510 

   511 

   512 18.2     "Validate correct functioning of Address and Control field compression\n"

   513 comment: configure DUT to use ACFC Option Fields. How do we do that?

   514 

   515 

   516 18.3     "The Address and Control fields MUST NOT be compressed when sending any LCP packet; this rule guarantees unambiguous recognition of LCP's\n"

   517 comment: configure DUT to use ACFC Option Fields. How do we do that?

   518 

   519 

   520 18.4     "When Address and Control fields are compressed, the Data Link Layer Layer FCS field is calculated on compressed frame, not the original\n"

   521 comment: configure DUT to use ACFC Option Fields. How do we do that?

   522 

   523 

   524 18.5	 "If an Option is received (ACFC) in a Configure-Request but with an incorrect Length, a Configure-Nak SHOULD be transmitted unless the Length goes beyond the end of the packet\n"

   525 comment: default parameters

   526 

   527 

   528 19.1	 "None of the Configuration Options in this specification can be listed more than once.\n"

   529 comment: default parameters

   530 

   531 

   532 20.1     "Try to send packets with bad FCS\n"

   533 comment: IPCP connection has to be made? How do we do that?Echo?

   534 comment: default parameters

   535 

   536 20.2     "Send an HDLC packet of 100K to try to overflow input buffers\n"

   537 comment: default parameters

   538 

   539 

   540 20.3     "If using Echo-Requests to monitor link quality, DUT should terminate link after some number of Echo-Replies are not received\n"

   541 comment: test wants DUT to: Send n periodic Echo-Requests to verify link is up

   542 comment: how do we send periodic messages from DUT?

   543 

   544 

   545 20.4     "Ensure that when a Config-Ack is sent before Max Configure is reached, a Connection can be properly established\n"

   546 comment: default parameters

   547 

   548 

   549 20.5     "Ensure that when a Config-Ack is sent after the Restart Timer that a Config-Req is retransmitted\n"

   550 comment: default parameters

   551