Re-merge fixes for bugs 1860 and 1543. RCL_3
authorPat Downey <patd@symbian.org>
Tue, 18 May 2010 17:08:50 +0100
branchRCL_3
changeset 27 0ba1f0ab80be
parent 25 1799ab513ec3 (diff)
parent 20 7ea2c3c49480 (current diff)
child 29 8d17ed1e2513
Re-merge fixes for bugs 1860 and 1543.
--- a/charconvfw/numbergrouping/Src/NumberGrouping.cpp	Fri Apr 30 13:21:39 2010 +0100
+++ b/charconvfw/numbergrouping/Src/NumberGrouping.cpp	Tue May 18 17:08:50 2010 +0100
@@ -698,7 +698,7 @@
     RPointerArray<TDesC>& aGroupingPatternsList,
     TInt& aMaxExtraCharacters )
     {
-
+    CleanupResetAndDestroyPushL(aGroupingPatternsList);
     TPNGGroupingInfo* groupingInfo = new (ELeave) TPNGGroupingInfo;
     CleanupStack::PushL( groupingInfo );
 
@@ -762,7 +762,11 @@
         User::Leave(err);
         }
     else
+        {
         CleanupStack::Pop( groupingInfo ); // Success. This object now not owned by the cleanupstack
+        }        
+    
+    CleanupStack::Pop(&aGroupingPatternsList);
     }
 
 void CPNGNumberGrouping::ParseForAfterPositions(
--- a/fontservices/fontstore/inc/openfontlinkedtypefaceextension.h	Fri Apr 30 13:21:39 2010 +0100
+++ b/fontservices/fontstore/inc/openfontlinkedtypefaceextension.h	Tue May 18 17:08:50 2010 +0100
@@ -20,6 +20,8 @@
 #ifndef OPENFONTLINKEDTYPEFACEEXTENSION_H
 #define OPENFONTLINKEDTYPEFACEEXTENSION_H
 
+class COpenFontLinkedTypefaceSpecification;
+
 /**
 Interface for handling, creating and modifying linked typefaces.
 
--- a/fontservices/fontstore/inc/openfontlinkedtypefacespecification.h	Fri Apr 30 13:21:39 2010 +0100
+++ b/fontservices/fontstore/inc/openfontlinkedtypefacespecification.h	Tue May 18 17:08:50 2010 +0100
@@ -20,6 +20,10 @@
 #ifndef OPENFONTLINKEDTYPEFACESPECIFICATION_H_
 #define OPENFONTLINKEDTYPEFACESPECIFICATION_H_
 
+class COpenFontLinkedTypefaceElementSpec;
+class CLinkedTypefaceGroup;
+class TLinkedTypefaceSpecificationArgs;
+
 /**
 This class contains the specification of a linked typeface passed from font store to a rasterizer. It is made up of groups and typefaces.
 A group (CLinkedTypefaceGroup) contains a number of attributes that can apply to similar typefaces
--- a/textrendering/textformatting/test/tbandformat/src/helper/bandvalidator.cpp	Fri Apr 30 13:21:39 2010 +0100
+++ b/textrendering/textformatting/test/tbandformat/src/helper/bandvalidator.cpp	Tue May 18 17:08:50 2010 +0100
@@ -154,6 +154,7 @@
 	
 TBool CBandValidator::GetVisibleLineInfosL(const CTextView& aView, RArray<TTmLineInfo>& aVisibleLines)
 	{
+    CleanupClosePushL(aVisibleLines);
 	const CTextLayout* layout = aView.Layout();
 	__ASSERT_ALWAYS(layout, User::Invariant());
 	const CTmTextLayout& tmLayout = layout->TagmaTextLayout();
@@ -163,6 +164,7 @@
 	TTmLineInfo startLine;	
 	if(!(tmLayout.LineNumberToLine(firstLineNumber, startLine)))
 		{
+        CleanupStack::Pop(&aVisibleLines);
 		return EFalse;
 		}
 //get last visible line
@@ -179,11 +181,13 @@
 			//it is, so just get the last formatted line
 			if(!(tmLayout.LineNumberToLine((tmLayout.Lines())-1, endLine)))
 				{
+                CleanupStack::Pop(&aVisibleLines);
 				return EFalse;
 				}
 			}
 		else
 			{
+            CleanupStack::Pop(&aVisibleLines);
 			return EFalse;
 			}
 		}
@@ -196,11 +200,14 @@
 		TTmLineInfo lineInfo;
 		if(!(tmLayout.LineNumberToLine(lineNumber, lineInfo)))
 			{
+            CleanupStack::Pop(&aVisibleLines);
 			return EFalse;
 			}
 		User::LeaveIfError(aVisibleLines.Append(lineInfo));
 		lineNumber++;
 		}
+	
+	CleanupStack::Pop(&aVisibleLines);
 	return ETrue;	
 	}