srcanamdw/codescanner/scripts/ConnectAndDontCloseMemberVariable.py
author noe\swadi
Thu, 18 Feb 2010 12:29:02 +0530
changeset 1 22878952f6e2
permissions -rw-r--r--
Committing the CodeScanner Core tool This component has been moved from the StaticAnaApps package. BUG : 5889 (http://developer.symbian.org/webbugs/show_bug.cgi?id=5889).
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
1
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
     1
# #################################################################
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
     2
# Copyright (c) 2009 Nokia Corporation and/or its subsidiary(-ies).
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
     3
# All rights reserved.
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
     4
# 
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
     5
# Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
     6
# 
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
     7
# * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
     8
# * Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
     9
# * Neither the name of Nokia Corporation nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    10
# 
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    11
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    12
# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS 
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    13
# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF 
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    14
# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN 
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    15
# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.#
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    16
#
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    17
# ConnectAndDontCloseMemberVariable.py
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    18
#
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    19
# Checks : Calling Connect() or Open() on a member variable without 
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    20
# calling Close() in the destructor.
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    21
#
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    22
# Reason : If Connect() or Open() is called on any member variable, 
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    23
# then Close() must be called in the destructor.
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    24
#
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    25
# #################################################################
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    26
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    27
script = CScript("ConnectAndDontCloseMemberVariable")
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    28
script.iReString = r"""
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    29
	^\s*				# start of line plus optional whitespace
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    30
	i[A-Z]\w+			# member variable name
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    31
	(\.|->)				# "." or "->"
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    32
	(Connect|Open)
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    33
	\s*\(\s*\)
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    34
	\s*;
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    35
	"""
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    36
script.iFileExts = ["cpp"]
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    37
script.iCategory = KCategoryWrongFunctionality
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    38
script.iIgnore = KIgnoreCommentsAndQuotes
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    39
script.iSeverity = KSeverityMedium
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    40
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    41
ConnectAndDontCloseLeavingFunction = re.compile("""
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    42
	[A-Za-z0-9]+
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    43
	L
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    44
	(C|D|P)*
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    45
	\s*
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    46
	\(
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    47
	""", re.VERBOSE)
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    48
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    49
def ConnectNotCloseCompare(lines, currentline, rematch, filename):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    50
	line = lines[currentline]
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    51
	m = rematch.search(line)
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    52
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    53
	if m:
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    54
		# get the variable name, between the '*' and the '='
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    55
		startindex = line.find("i")
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    56
		if (startindex == -1):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    57
			startindex = 0
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    58
		endindex = line.find("Connect")
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    59
		if (endindex == -1):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    60
			endindex = line.find("Open")
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    61
		variable = line[startindex:endindex]
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    62
		if (len(variable) < 1):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    63
			return 0
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    64
		variable = TrimVariableName(variable)
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    65
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    66
		# see if variable is closed within this function before a Leave
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    67
		i = currentline
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    68
		bracketdepth = GetBracketDepth(lines, i)
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    69
		while (i < len(lines)) and (bracketdepth  > 0):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    70
			line = lines[i]
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    71
			if (line.find(variable) >= 0):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    72
				if (line.find("Close") >= 0):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    73
					return 0
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    74
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    75
			bracketdepth += line.count("{")
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    76
			bracketdepth -= line.count("}")
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    77
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    78
			if (line.find("User::Leave") >= 0):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    79
				bracketdepth = 0
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    80
			if (line.find("ELeave") >= 0):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    81
				bracketdepth = 0
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    82
			if (ConnectAndDontCloseLeavingFunction.search(line)):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    83
				bracketdepth = 0
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    84
				
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    85
			i = i + 1
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    86
		
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    87
		# look for destructor and see if variable is closed there
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    88
		stringToFind = "~" + scanner.iCurrentClassName
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    89
		i = 1
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    90
		foundDestructor = 0
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    91
		bracketdepth = 0
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    92
		while (i < len(lines)):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    93
			thisLine = lines[i]
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    94
			if (thisLine.find(stringToFind) >= 0) and (foundDestructor == 0):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    95
				while (i < len(lines)) and (foundDestructor == 0):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    96
					thisLine = lines[i]
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    97
					if (thisLine.find('{') >= 0):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    98
						foundDestructor = 1
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
    99
					else:
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
   100
						i = i + 1
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
   101
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
   102
			if (foundDestructor):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
   103
				bracketdepth += thisLine.count("{")
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
   104
				bracketdepth -= thisLine.count("}")
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
   105
				if (bracketdepth == 0):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
   106
					return 1
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
   107
				
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
   108
				if (thisLine.find(variable) >= 0):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
   109
					if (thisLine.find("Close") >= 0):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
   110
						return 0
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
   111
			i = i + 1
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
   112
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
   113
		if (foundDestructor):
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
   114
			return 1
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
   115
	return 0
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
   116
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
   117
script.iCompare	= ConnectNotCloseCompare
22878952f6e2 Committing the CodeScanner Core tool
noe\swadi
parents:
diff changeset
   118
scanner.AddScript(script)