|
1 # ################################################################# |
|
2 # Copyright (c) 2009 Nokia Corporation and/or its subsidiary(-ies). |
|
3 # All rights reserved. |
|
4 # |
|
5 # Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: |
|
6 # |
|
7 # * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. |
|
8 # * Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. |
|
9 # * Neither the name of Nokia Corporation nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. |
|
10 # |
|
11 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, |
|
12 # THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS |
|
13 # BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF |
|
14 # SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN |
|
15 # CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.# |
|
16 # |
|
17 # noleavetrap.py |
|
18 # |
|
19 # Checks : TRAP used with no leaving functions. |
|
20 # |
|
21 # Reason : A TRAP is unnecessary if there are no leaving functions. |
|
22 # |
|
23 # ################################################################# |
|
24 |
|
25 script = CScript("noleavetrap") |
|
26 script.iReString = "^\s*TRAPD?" |
|
27 script.iFileExts = ["cpp"] |
|
28 script.iCategory = KCategoryCodeReviewGuides |
|
29 script.iIgnore = KIgnoreCommentsAndQuotes |
|
30 script.iSeverity = KSeverityLow |
|
31 |
|
32 reLeave = re.compile("(L[CDP]?\s*\(|ELeave|\)\s*\(|<<|>>)") |
|
33 |
|
34 def noleavetrapcompare(lines, currentline, rematch, filename): |
|
35 line = lines[currentline] |
|
36 m = rematch.search(line) |
|
37 if m: |
|
38 if (line.find("(") == -1) and (currentline + 1 < len(lines)): |
|
39 currentline += 1 |
|
40 line = lines[currentline] |
|
41 |
|
42 bracketCount = line.count("(") - line.count(")") |
|
43 found = reLeave.search(line) |
|
44 |
|
45 while (bracketCount > 0) and (currentline + 1 < len(lines)): |
|
46 currentline += 1 |
|
47 line = lines[currentline] |
|
48 bracketCount += line.count("(") - line.count(")") |
|
49 if not found: |
|
50 found = reLeave.search(line) |
|
51 |
|
52 if found: |
|
53 return 0 |
|
54 else: |
|
55 return 1 |
|
56 |
|
57 return 0 |
|
58 |
|
59 script.iCompare = noleavetrapcompare |
|
60 scanner.AddScript(script) |