|
1 # ################################################################# |
|
2 # Copyright (c) 2009 Nokia Corporation and/or its subsidiary(-ies). |
|
3 # All rights reserved. |
|
4 # |
|
5 # Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: |
|
6 # |
|
7 # * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. |
|
8 # * Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. |
|
9 # * Neither the name of Nokia Corporation nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. |
|
10 # |
|
11 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, |
|
12 # THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS |
|
13 # BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF |
|
14 # SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN |
|
15 # CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.# |
|
16 # |
|
17 # rssnames.py |
|
18 # |
|
19 # Checks : Duplicate RSS names. |
|
20 # |
|
21 # Reason : Resource files with clashing NAME fields can cause the |
|
22 # wrong resource file to be accessed. This can lead to incorrect |
|
23 # functionality or panics. |
|
24 # |
|
25 # ################################################################# |
|
26 |
|
27 script = CScript("rssnames") |
|
28 script.iReString = "^\s*NAME\s+(\w+)" |
|
29 script.iFileExts = ["rss"] |
|
30 script.iCategory = KCategoryCodeReviewGuides |
|
31 script.iIgnore = KIgnoreCommentsAndQuotes |
|
32 script.iSeverity = KSeverityLow |
|
33 |
|
34 rssnames = [] |
|
35 |
|
36 def rsscompare(lines, currentline, rematch, filename): |
|
37 m = rematch.search(lines[currentline]) |
|
38 if m: |
|
39 text = m.group(1).lower() |
|
40 shortfilename = filename[filename.rfind("/") + 1:].lower() |
|
41 for pair in rssnames: |
|
42 if (pair[0] == text): |
|
43 if (pair[1] == shortfilename): |
|
44 return 0 |
|
45 else: |
|
46 scanner.iRendererManager.ReportAnnotation(pair[2]) |
|
47 return 1 |
|
48 |
|
49 rssnames.append([text, shortfilename, filename]) |
|
50 return 0 |
|
51 else: |
|
52 return 0 |
|
53 |
|
54 script.iCompare = rsscompare |
|
55 scanner.AddScript(script) |