buildframework/helium/sf/java/quality/src/com/nokia/helium/quality/ant/taskdefs/CodeScannerTask.java
changeset 628 7c4a911dc066
parent 588 c7c26511138f
child 645 b8d81fa19e7d
--- a/buildframework/helium/sf/java/quality/src/com/nokia/helium/quality/ant/taskdefs/CodeScannerTask.java	Wed Jun 16 16:51:40 2010 +0300
+++ b/buildframework/helium/sf/java/quality/src/com/nokia/helium/quality/ant/taskdefs/CodeScannerTask.java	Fri Aug 13 14:59:05 2010 +0300
@@ -17,30 +17,30 @@
 
 package com.nokia.helium.quality.ant.taskdefs;
 
-import java.io.*;
+import java.io.File;
 import java.util.Vector;
 
+import org.apache.tools.ant.BuildException;
 import org.apache.tools.ant.Task;
-import org.apache.tools.ant.BuildException;
+import org.apache.tools.ant.taskdefs.ExecTask;
 import org.apache.tools.ant.types.Path;
-import org.apache.tools.ant.taskdefs.ExecTask;
 
 /**
- * This task executes codescanner - and writes the results to the output directory.
- * Codescanner parses C++ code and flags any inconsistencies or errors in output files. 
- * Configuration files are used to determine what passes and fails the checking e.g. maximum length of lines,
- * whether 'C' type comments are allowed as well as C++ comments, does it adhere to the company coding 
- * guidelines and much more. Every person writing any C++ code 
- * should run codescanner on their code to ensure it follows the coding guidelines. The output logs 
- * should have no errors and preferably no warnings before the code should be checked into SCM, e.g. synergy or SVN.
- *
+ * This task executes codescanner - and writes the results to the output directory. Codescanner
+ * parses C++ code and flags any inconsistencies or errors in output files. Configuration files are
+ * used to determine what passes and fails the checking e.g. maximum length of lines, whether 'C'
+ * type comments are allowed as well as C++ comments, does it adhere to the company coding
+ * guidelines and much more. Every person writing any C++ code should run codescanner on their code
+ * to ensure it follows the coding guidelines. The output logs should have no errors and preferably
+ * no warnings before the code should be checked into SCM, e.g. synergy or SVN.
+ * 
  * Below is an example of how to use the target to run codescanner.
- *
+ * 
  * <pre>
  * &lt;property name="codescanner.output.dir" location="./cs" /&gt;
  * &lt;property name="codescanner.output.type" value="html" /&gt;
  * &lt;property name="codescanner.config" location="./codescanner_config.xml" /&gt;
- *
+ * 
  * &lt;hlm:codescanner dest="${codescanner.output.dir}"
  *      format="${codescanner.output.type}"
  *      failonerror="true"
@@ -64,8 +64,7 @@
     private boolean failonerror;
 
     /**
-     * This defines if the task should fails in case of error while 
-     * executing codescanner.
+     * This defines if the task should fails in case of error while executing codescanner.
      * 
      * @param failonerror
      * @ant.not-required Default is false for backward compatibility.
@@ -163,11 +162,6 @@
     @Override
     public void execute() {
         // creating the exec subtask
-        String osType = System.getProperty("os.name");
-        if (!osType.toLowerCase().startsWith("win")) {
-            this.log("CODESCANNER: run in windows only");
-            return;
-        }
         ExecTask task = new ExecTask();
         task.setProject(getProject());
         task.setTaskName(this.getTaskName());
@@ -179,18 +173,18 @@
         }
         if (configuration != null) {
             if (!configuration.exists()) {
-                throw new BuildException("Could not find the file "
-                        + configuration);
-            } else {
+                throw new BuildException("Could not find the file " + configuration);
+            }
+            else {
                 task.createArg().setValue("-c");
                 task.createArg().setValue(configuration.getAbsolutePath());
             }
-        } else {
-            throw new BuildException(
-                    "'configuration' attribute must be defined");
+        }
+        else {
+            throw new BuildException("'configuration' attribute must be defined");
         }
         if (!format.contains("xml")) {
-           setFormat("xml," + format);
+            setFormat("xml," + format);
         }
         this.log("Output format: " + format);
         // -t off
@@ -224,7 +218,8 @@
             if (i != srcs.size() - 1) {
                 task.createArg().setValue("-i");
                 task.createArg().setValue(srcs.elementAt(i));
-            } else {
+            }
+            else {
                 task.createArg().setValue(srcs.elementAt(i));
                 task.createArg().setValue(dest.toString());
             }