# HG changeset patch # User l12wang # Date 1259111916 21600 # Node ID f0e9dc42b68e0999505ef92d5ee9edbabaebaf6d # Parent 09f3d307f0818cf43a49dc2b74e40374970964e2 Don't log failure in setting breakpoint as error in Error Log view. diff -r 09f3d307f081 -r f0e9dc42b68e cdt/cdt_6_0_x/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/service/BreakpointsMediator.java --- a/cdt/cdt_6_0_x/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/service/BreakpointsMediator.java Mon Nov 23 00:59:16 2009 -0600 +++ b/cdt/cdt_6_0_x/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/service/BreakpointsMediator.java Tue Nov 24 19:18:36 2009 -0600 @@ -648,7 +648,7 @@ return bpsInfo.toArray(new PlatformBreakpointInfo[bpsInfo.size()]); } - protected void doBreakpointsAddedInExecutor(PlatformBreakpointInfo[] bpsInfo, Collection bpTargetDMCs, RequestMonitor rm) { + protected void doBreakpointsAddedInExecutor(PlatformBreakpointInfo[] bpsInfo, Collection bpTargetDMCs, final RequestMonitor rm) { final Map> eventBPs = new HashMap>(bpsInfo.length, 1); @@ -657,7 +657,11 @@ protected void handleCompleted() { processPendingRequests(); fireUpdateBreakpointsStatus(eventBPs, BreakpointEventType.ADDED); - super.handleCompleted(); + if (rm != null) + // don't call this if "rm" is null as this will + // log errors if any and pack Eclipse error + // log view with errors useless to user. + super.handleCompleted(); } }; int processPendingCountingRmCount = 0; @@ -936,7 +940,7 @@ } protected void doBreakpointsRemovedInExecutor(IBreakpoint[] bpCandidates, - Collection targetContexts, RequestMonitor rm) { + Collection targetContexts, final RequestMonitor rm) { final Map> eventBPs = new HashMap>(bpCandidates.length, 1); @@ -946,7 +950,11 @@ protected void handleCompleted() { processPendingRequests(); fireUpdateBreakpointsStatus(eventBPs, BreakpointEventType.REMOVED); - super.handleCompleted(); + if (rm != null) + // don't call this if "rm" is null as this will + // log errors if any and pack Eclipse error + // log view with errors useless to user. + super.handleCompleted(); } }; int processPendingCountingRmCount = 0;