# HG changeset patch # User tasneems@symbian.org # Date 1267153473 28800 # Node ID bf86f4fadeb4baa83d373c3a93401f16f385791b # Parent cae914a9293db6237fd141497e51d9c2ad32e819 Fixed bug 1967: Confusing deployment preferences error. Fixed bug 2077: Superfluous logging messages when selecting emulator. diff -r cae914a9293d -r bf86f4fadeb4 org.symbian.tools.wrttools/src/org/symbian/tools/wrttools/core/deploy/DeployPreferencePage.java --- a/org.symbian.tools.wrttools/src/org/symbian/tools/wrttools/core/deploy/DeployPreferencePage.java Thu Feb 25 17:40:36 2010 -0800 +++ b/org.symbian.tools.wrttools/src/org/symbian/tools/wrttools/core/deploy/DeployPreferencePage.java Thu Feb 25 19:04:33 2010 -0800 @@ -139,7 +139,7 @@ emulatorDeployerPathText.setText(emulatorHashMap.get(selectionCombo.getText()).concat(IWRTConstants.DEPLOY_PATH)); } /* TODO XXX */ - log.info("DeployPreferencePage.addSelectionListener: Emulator Deployer Path Text: "+ emulatorDeployerPathText); + //log.info("DeployPreferencePage.addSelectionListener: Emulator Deployer Path Text: "+ emulatorDeployerPathText); } } }); @@ -224,7 +224,7 @@ } /* TODO XXX */ - log.info("DeployPreferencePage.updateButtonStates: Emulator Deployer Path Text: "+ emulatorDeployerPathText); + //log.info("DeployPreferencePage.updateButtonStates: Emulator Deployer Path Text: "+ emulatorDeployerPathText); } else if(deviceRadioButton != null && deviceRadioButton.getSelection()){ @@ -285,11 +285,11 @@ selectionCombo.setItems(emulatorItems); emulatorDeployerPathText.setText(prefStore.getString(PreferenceConstants.SELECTED_EMULATOR_PATH)); /* TODO XXX */ - log.info("DeployPreferencePage.performDefaults: Emulator Deployer Path Text: "+ emulatorDeployerPathText); + //log.info("DeployPreferencePage.performDefaults: Emulator Deployer Path Text: "+ emulatorDeployerPathText); } /* TODO XXX */ - log.info("DeployPreferencePage.performDefaults: emulatorRadioButton not selected: "+ emulatorDeployerPathText); + //log.info("DeployPreferencePage.performDefaults: emulatorRadioButton not selected: "+ emulatorDeployerPathText); /*if(deviceRadioButton != null && deviceRadioButton.getSelection()){ devices = new String[1]; diff -r cae914a9293d -r bf86f4fadeb4 org.symbian.tools.wrttools/src/org/symbian/tools/wrttools/core/deploy/WrtDeployActionDelegate.java --- a/org.symbian.tools.wrttools/src/org/symbian/tools/wrttools/core/deploy/WrtDeployActionDelegate.java Thu Feb 25 17:40:36 2010 -0800 +++ b/org.symbian.tools.wrttools/src/org/symbian/tools/wrttools/core/deploy/WrtDeployActionDelegate.java Thu Feb 25 19:04:33 2010 -0800 @@ -107,7 +107,7 @@ } else { MessageDialog.openInformation(shell, "Deploy error", - " Invalid deployment preferences" + " dest path: " + destinationPath + "deployerType:" + deployerType + " store:" + store); + " Invalid deployment preferences. Use \"Deployment Settings for WRT Application\" to set deployment preferences."); } }