# HG changeset patch # User timkelly # Date 1281107559 18000 # Node ID 08a6717c4a99b558451401743c91f8669ae7c33d # Parent 6b0252f3c70e9f808cab99f7a0fec7a37a4006ae don't add SBSv2 macro for SBSv1 diff -r 6b0252f3c70e -r 08a6717c4a99 core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/sdk/core/model/SBSv1BuildInfo.java --- a/core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/sdk/core/model/SBSv1BuildInfo.java Thu Aug 05 15:32:59 2010 -0500 +++ b/core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/sdk/core/model/SBSv1BuildInfo.java Fri Aug 06 10:12:39 2010 -0500 @@ -322,8 +322,6 @@ public List getBuiltinMacros(ISymbianBuildContext context) { List macros = new ArrayList(); - macros.add("SBSV2"); //$NON-NLS-1$ - // add the macros that should always be defined macros.add("__SYMBIAN32__"); //$NON-NLS-1$ macros.add("_UNICODE"); //$NON-NLS-1$ @@ -339,9 +337,11 @@ return macros; } - // TODO: This needs to move under ISymianBuildContext. For abld we can use this method. - // For SBSv2, this is configuration dependent and the information is obtained from - // the sbs --query=config[] call. + /** + * ABLD specifc mechanism of parsing perl script to get targettypes. This is imperfect + * but is the best way to generalize targettypes. Raptor/SBSv2 API improves on this + * by retrieving configuration specific targettypes. + */ public List getSupportedTargetTypes() { synchronized (supportedTargetTypesList) {