# HG changeset patch # User Ed Swartz # Date 1277842478 18000 # Node ID 2b3cd56e10904d09b02128b0810882e78d865fbc # Parent e848131666c1f0cc7c544613f3116a4e176b7f97 Bug 11438: Fix cause for TCFClient.dll crasher. It is a client-side bug caused by not filtering out bad inputs. diff -r e848131666c1 -r 2b3cd56e1090 connectivity/com.nokia.tcf/src/com/nokia/tcf/impl/TCAPIConnection.java --- a/connectivity/com.nokia.tcf/src/com/nokia/tcf/impl/TCAPIConnection.java Mon Jun 28 08:59:09 2010 -0500 +++ b/connectivity/com.nokia.tcf/src/com/nokia/tcf/impl/TCAPIConnection.java Tue Jun 29 15:14:38 2010 -0500 @@ -501,9 +501,13 @@ settings = new String[1]; } else { // Add other connections here + return new Status(Status.ERROR, Activator.PLUGIN_ID, (int)TCErrorConstants.TCAPI_ERR_MEDIA_NOT_SUPPORTED, + "Unknown connection type: " + type, null); } + return finishConnect(type, settings, inConnection, inMessageOptions, inMessageIds); + } else { + return status; } - return finishConnect(type, settings, inConnection, inMessageOptions, inMessageIds); } protected void ensureWritableFile(String filePath) throws IOException { // ensure file path points to a writable regular file