# HG changeset patch
# User dadubrow
# Date 1271363541 18000
# Node ID 4881c5997074c2af649fa24261424d9b260408ba
# Parent 0b00d1889d7326559bbe3c1bea9c0e1399d926db
modify IConnectionFactory2
diff -r 0b00d1889d73 -r 4881c5997074 connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/interfaces/IConnectionFactory.java
--- a/connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/interfaces/IConnectionFactory.java Thu Apr 15 12:34:48 2010 -0500
+++ b/connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/interfaces/IConnectionFactory.java Thu Apr 15 15:32:21 2010 -0500
@@ -37,13 +37,14 @@
* @param parent Composite
* @param errorReporter IValidationErrorReporter
* @param initialSettings Map may be null
- * @deprecated
+ * @deprecated use IConnectionFactory2.createEditingUI(Composite, IValidationErrorReporter, Map, com.nokia.carbide.remoteconnections.interfaces.IConnectionFactory2.ISettingsChangedListener)
*/
void createEditingUI(Composite parent, IValidationErrorReporter errorReporter, Map initialSettings);
/**
* Returns the settings from the editing UI as name value pairs
* @return Map
+ * @deprecated use IConnectionFactory2.IEditingUI.getSettings() or IConnectionFactory2.getDefaultSettings()
*/
Map getSettingsFromUI();
diff -r 0b00d1889d73 -r 4881c5997074 connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/interfaces/IConnectionFactory2.java
--- a/connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/interfaces/IConnectionFactory2.java Thu Apr 15 12:34:48 2010 -0500
+++ b/connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/interfaces/IConnectionFactory2.java Thu Apr 15 15:32:21 2010 -0500
@@ -48,4 +48,5 @@
IEditingUI createEditingUI(Composite parent, IValidationErrorReporter errorReporter,
Map initialSettings, ISettingsChangedListener settingsListener);
+ Map getDefaultSettings();
}
diff -r 0b00d1889d73 -r 4881c5997074 connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/settings/ui/ConnectionSettingsPage.java
--- a/connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/settings/ui/ConnectionSettingsPage.java Thu Apr 15 12:34:48 2010 -0500
+++ b/connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/settings/ui/ConnectionSettingsPage.java Thu Apr 15 15:32:21 2010 -0500
@@ -840,6 +840,9 @@
}
public Map getSettings() {
+ if (editingUI != null)
+ return editingUI.getSettings();
+
if (connectionFactory == null) {
IConnection connectionToEdit = settingsWizard.getConnectionToEdit();
if (connectionToEdit == null || !connectionToEdit.getConnectionType().equals(getConnectionType())) {