# HG changeset patch
# User timkelly
# Date 1281039918 18000
# Node ID 73303c546665605d065d3823dc06d448eb684174
# Parent  05c2648e3e25398480d3f219b3c976f47598b20e
clean up some TODO comments

diff -r 05c2648e3e25 -r 73303c546665 core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/api/sdk/BuildContextSBSv1.java
--- a/core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/api/sdk/BuildContextSBSv1.java	Thu Aug 05 15:02:27 2010 -0500
+++ b/core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/api/sdk/BuildContextSBSv1.java	Thu Aug 05 15:25:18 2010 -0500
@@ -226,7 +226,6 @@
 	}
 
 	public String getDefaultDefFileDirectoryName() {
-		// TODO: How the ASSP option affects the path?
 
 		String dirName = getDefFileDirectoryNameForPlatform(platform);
 		if (dirName == null) {
diff -r 05c2648e3e25 -r 73303c546665 core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/api/sdk/SBSv2Utils.java
--- a/core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/api/sdk/SBSv2Utils.java	Thu Aug 05 15:02:27 2010 -0500
+++ b/core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/api/sdk/SBSv2Utils.java	Thu Aug 05 15:25:18 2010 -0500
@@ -84,8 +84,7 @@
     	if (!enableSBSv1Support()) {
     		supportedSDKs.addAll(sdks);
     	} else {
-	    	//TODO need a better way to do this from Symbian.
-	    	// For now, just filter out anything older than 9.4
+	    	// Filter out anything older than 9.4
 	    	for (ISymbianSDK sdk : sdks) {
 	    		Version osVersion = sdk.getOSVersion();
 	    		if (osVersion.getMajor() > 8 || osVersion.getMajor() == 0 ||
diff -r 05c2648e3e25 -r 73303c546665 core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/sdk/core/model/SBSv1BuildInfo.java
--- a/core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/sdk/core/model/SBSv1BuildInfo.java	Thu Aug 05 15:02:27 2010 -0500
+++ b/core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/sdk/core/model/SBSv1BuildInfo.java	Thu Aug 05 15:25:18 2010 -0500
@@ -263,9 +263,7 @@
 				// Currently only variation of ARMV5 is supported... So just hard code the variated platform
 				// Only add the build platform if it's not virtual.
 				if (!sbvPlatform.isVirtual()){
-					// TODO: Hard code build context hack
 					binaryVariantContextList.add(new BuildContextSBSv1(sdk, BuildContextSBSv1.ARMV5_PLATFORM + "." + sbvPlatform.getName(), ISymbianBuildContext.DEBUG_TARGET));
-					// TODO: Hard code build context hack
 					binaryVariantContextList.add(new BuildContextSBSv1(sdk, BuildContextSBSv1.ARMV5_PLATFORM + "." + sbvPlatform.getName(), ISymbianBuildContext.RELEASE_TARGET));
 				}
 			}
diff -r 05c2648e3e25 -r 73303c546665 core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/sdk/core/model/SBSv2BuildInfo.java
--- a/core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/sdk/core/model/SBSv2BuildInfo.java	Thu Aug 05 15:02:27 2010 -0500
+++ b/core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/sdk/core/model/SBSv2BuildInfo.java	Thu Aug 05 15:25:18 2010 -0500
@@ -163,7 +163,7 @@
 					meaning = aliasToMeaningMap.get(alias);
 				}
 				if (meaning == null){
-					continue; // TODO: How to handle this scenario
+					continue; 
 				}
 				SBSv2ConfigQueryData configQueryData = new SBSv2ConfigQueryData(alias, meaning, configQueryXML);
 				ISBSv2BuildContext sbsv2Context = new BuildContextSBSv2(sdk, alias, configQueryData);
diff -r 05c2648e3e25 -r 73303c546665 core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/sdk/core/model/SDKManager.java
--- a/core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/sdk/core/model/SDKManager.java	Thu Aug 05 15:02:27 2010 -0500
+++ b/core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/sdk/core/model/SDKManager.java	Thu Aug 05 15:25:18 2010 -0500
@@ -226,7 +226,6 @@
 		}
 		
 		if (!new File(installPath).exists()){
-			//TODO: Localise
 			String errMsg = "CSL Arm Toolchain installation path pointed by registry key '" 
 							+  CSL_ARM_TOOLCHAIN_REG_PATH 
 							+ "' does not exist."; //$NON-NLS-N$
diff -r 05c2648e3e25 -r 73303c546665 core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/sdk/core/model/SymbianSDK.java
--- a/core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/sdk/core/model/SymbianSDK.java	Thu Aug 05 15:02:27 2010 -0500
+++ b/core/com.nokia.carbide.cpp.sdk.core/src/com/nokia/carbide/cpp/internal/sdk/core/model/SymbianSDK.java	Thu Aug 05 15:25:18 2010 -0500
@@ -321,7 +321,6 @@
 	
 	/**
 	 * Parses the epoc32\kit\manifest.xml file and add the relavant SDK information 
-	 * Currently this is just a bunch of hackish code to parse the simplest manifest.xml file that really does nothing useful at all
 	 * For a manifest to be properly mapped you need at minimum: epocRoot, id, and label filled out.
 	 */
 	
diff -r 05c2648e3e25 -r 73303c546665 core/com.nokia.carbide.templatewizard/src/com/nokia/carbide/internal/api/templatewizard/ui/TemplateWizardPage.java
--- a/core/com.nokia.carbide.templatewizard/src/com/nokia/carbide/internal/api/templatewizard/ui/TemplateWizardPage.java	Thu Aug 05 15:02:27 2010 -0500
+++ b/core/com.nokia.carbide.templatewizard/src/com/nokia/carbide/internal/api/templatewizard/ui/TemplateWizardPage.java	Thu Aug 05 15:25:18 2010 -0500
@@ -118,7 +118,7 @@
 			
 			if (type instanceof UidFieldType) {
 				values.put(type.getId(), value.toLowerCase());
-				// least hacky way to support this without creating a language out of templates
+				// simplest way to support this without creating a language out of templates
 				values.put(type.getId() + UIDComposite.WITHOUT_0X_PREFIX, 
 						UIDComposite.getWithout0x(value).toLowerCase());
 			}
diff -r 05c2648e3e25 -r 73303c546665 project/com.nokia.carbide.cpp.project.ui/src/com/nokia/carbide/cpp/internal/project/utils/BldInfImportWrapper.java
--- a/project/com.nokia.carbide.cpp.project.ui/src/com/nokia/carbide/cpp/internal/project/utils/BldInfImportWrapper.java	Thu Aug 05 15:02:27 2010 -0500
+++ b/project/com.nokia.carbide.cpp.project.ui/src/com/nokia/carbide/cpp/internal/project/utils/BldInfImportWrapper.java	Thu Aug 05 15:25:18 2010 -0500
@@ -113,8 +113,7 @@
         		project.setSessionProperty(CarbideBuilderPlugin.SBSV2_PROJECT, isSBSv2);
         		
         		// TODO pass PKG file path to postProjectCreatedActions, currently passing null
-        		
-        		
+     
         		ProjectCorePlugin.postProjectCreatedActions(project, projectRelativePath, selectedConfigs, components, debugMMP, null, monitor);
 
         		if (monitor.isCanceled()) {