# HG changeset patch # User Ed Swartz # Date 1259962294 21600 # Node ID 91399e4af0cf6a475ec20cbdabd5f212ea9b08cb # Parent baa31ffa93b51648ba481674468caf7d3cb9fcbf Other error parser fixes caused by the CDT change. Also make the test generate some more JUnit-friendly error messages. diff -r baa31ffa93b5 -r 91399e4af0cf builder/com.nokia.carbide.cdt.builder.test/data/errorpatterns/bugzilla/5618.gcce.regression.xml --- a/builder/com.nokia.carbide.cdt.builder.test/data/errorpatterns/bugzilla/5618.gcce.regression.xml Fri Dec 04 14:51:45 2009 -0600 +++ b/builder/com.nokia.carbide.cdt.builder.test/data/errorpatterns/bugzilla/5618.gcce.regression.xml Fri Dec 04 15:31:34 2009 -0600 @@ -1,20 +1,20 @@ - + - + - + - + - + - + - + - + diff -r baa31ffa93b5 -r 91399e4af0cf builder/com.nokia.carbide.cdt.builder.test/data/errorpatterns/bugzilla/6417.gcce.regression.xml --- a/builder/com.nokia.carbide.cdt.builder.test/data/errorpatterns/bugzilla/6417.gcce.regression.xml Fri Dec 04 14:51:45 2009 -0600 +++ b/builder/com.nokia.carbide.cdt.builder.test/data/errorpatterns/bugzilla/6417.gcce.regression.xml Fri Dec 04 15:31:34 2009 -0600 @@ -21,9 +21,9 @@ - + - + @@ -161,21 +161,21 @@ - + - + - + - + - + - + @@ -233,12 +233,12 @@ - + - + - + - + diff -r baa31ffa93b5 -r 91399e4af0cf builder/com.nokia.carbide.cdt.builder.test/src/com/nokia/carbide/cdt/builder/test/errorParsers/CarbideErrorParserTestHarness.java --- a/builder/com.nokia.carbide.cdt.builder.test/src/com/nokia/carbide/cdt/builder/test/errorParsers/CarbideErrorParserTestHarness.java Fri Dec 04 14:51:45 2009 -0600 +++ b/builder/com.nokia.carbide.cdt.builder.test/src/com/nokia/carbide/cdt/builder/test/errorParsers/CarbideErrorParserTestHarness.java Fri Dec 04 15:31:34 2009 -0600 @@ -212,12 +212,13 @@ } if (result.description.equals(expected.description) == false) { if (expected.description.equals(EMPTY) == false) { - Assert.fail("Unexpected message: EXPECTED value is: " + expected.description + ", ACTUAL: " + result.description); + Assert.assertEquals("Unexpected message", + expected.description, result.description); } } else { if (result.description.equals(expected.description) == false) { - Assert.fail("Message from IDE marker is " + result.description + - ", expected value is " + expected.description); + Assert.assertEquals("Message from IDE marker does not match", + expected.description, result.description); return false; } } @@ -247,8 +248,7 @@ if (HostOS.IS_UNIX && result.externalPath.makeRelative().equals(expected.externalPath.makeRelative())) { // fine } else { - Assert.fail("External path string from IDE marker is " + result.externalPath + - ", expected value is " + expected.externalPath); + Assert.assertEquals("External path string from IDE marker", expected.externalPath, result.externalPath); return false; } }