# HG changeset patch # User timkelly # Date 1272377268 18000 # Node ID 9b50c8036532fbf3ff8a7bb87ab922e59d539545 # Parent f1114f700e653e58b9df15c01001005eac8b38d7# Parent 7c4a4568b9c5129d76f15ce8d99ccd560d29f1a3 merge commit diff -r f1114f700e65 -r 9b50c8036532 builder/com.nokia.carbide.cdt.builder/src/com/nokia/carbide/cdt/internal/builder/ui/BuildSettingsUI.java --- a/builder/com.nokia.carbide.cdt.builder/src/com/nokia/carbide/cdt/internal/builder/ui/BuildSettingsUI.java Tue Apr 27 09:07:35 2010 -0500 +++ b/builder/com.nokia.carbide.cdt.builder/src/com/nokia/carbide/cdt/internal/builder/ui/BuildSettingsUI.java Tue Apr 27 09:07:48 2010 -0500 @@ -33,6 +33,7 @@ private Shell shell; private TabFolder tabFolder; + private boolean wantsSBSv1; private boolean wantsSBSv2; private boolean projectSetting; @@ -66,8 +67,9 @@ private Label extraArgsLabel; private Text extraArgsText; - public BuildSettingsUI(Shell shell, boolean wantsSBSv2, boolean projectSetting) { + public BuildSettingsUI(Shell shell, boolean wantsSBSv1, boolean wantsSBSv2, boolean projectSetting) { this.shell = shell; + this.wantsSBSv1 = wantsSBSv1; this.wantsSBSv2 = wantsSBSv2; this.projectSetting = projectSetting; } @@ -81,7 +83,7 @@ // for project settings we show either sbsv1 or sbsv2. for workspace prefs // we potentially show both - if ((projectSetting && !wantsSBSv2) || !projectSetting) { + if (wantsSBSv1) { createSBSv1TabComposite(); } diff -r f1114f700e65 -r 9b50c8036532 builder/com.nokia.carbide.cdt.builder/src/com/nokia/carbide/cdt/internal/builder/ui/BuilderPreferencePage.java --- a/builder/com.nokia.carbide.cdt.builder/src/com/nokia/carbide/cdt/internal/builder/ui/BuilderPreferencePage.java Tue Apr 27 09:07:35 2010 -0500 +++ b/builder/com.nokia.carbide.cdt.builder/src/com/nokia/carbide/cdt/internal/builder/ui/BuilderPreferencePage.java Tue Apr 27 09:07:48 2010 -0500 @@ -36,19 +36,22 @@ } protected Control createContents(Composite parent) { - buildSettingsUI = new BuildSettingsUI(parent.getShell(), SBSv2Utils.enableSBSv2Support(), false); + buildSettingsUI = new BuildSettingsUI(parent.getShell(), SBSv2Utils.enableSBSv1Support(), SBSv2Utils.enableSBSv2Support(), false); Control control = buildSettingsUI.createControl(parent); - buildSettingsUI.setDefaultCleanLevelv1(getCleanLevel()); buildSettingsUI.setBuildTestComponents(isBuildingTestComps()); - buildSettingsUI.setManageDependencies(manageDependencies()); buildSettingsUI.setUseIncrementalBuilder(useIncrementalBuilder()); buildSettingsUI.setUseConcurrentBuilding(useConcurrentBuilding()); buildSettingsUI.setNumConcurrentBuildJobs(concurrentBuildJobs()); - buildSettingsUI.setPromptForMMPChangedAction(promptForMMPChangedAction()); - buildSettingsUI.setDefaultMMPChangedAction(defaultMMPChangedAction()); buildSettingsUI.setUseBuiltInEnvVars(useBuiltInX86Vars()); - buildSettingsUI.setDontPromtTrackDeps(promtDontTrackDependencies()); + + if (SBSv2Utils.enableSBSv1Support()) { + buildSettingsUI.setDefaultCleanLevelv1(getCleanLevel()); + buildSettingsUI.setManageDependencies(manageDependencies()); + buildSettingsUI.setPromptForMMPChangedAction(promptForMMPChangedAction()); + buildSettingsUI.setDefaultMMPChangedAction(defaultMMPChangedAction()); + buildSettingsUI.setDontPromtTrackDeps(promtDontTrackDependencies()); + } if (SBSv2Utils.enableSBSv2Support()) { buildSettingsUI.setDefaultCleanLevelv2(getCleanLevelv2()); @@ -76,16 +79,19 @@ @Override protected void performApply() { IPreferenceStore store = CarbideBuilderPlugin.getDefault().getPreferenceStore(); - store.setValue(BuilderPreferenceConstants.PREF_CLEAN_LEVEL, buildSettingsUI.getDefaultCleanLevelv1()); store.setValue(BuilderPreferenceConstants.PREF_BUILD_TEST_COMPS, buildSettingsUI.getBuildTestComponents()); - store.setValue(BuilderPreferenceConstants.PREF_MANAGE_DEPENDENCIES, buildSettingsUI.getManageDependencies()); store.setValue(BuilderPreferenceConstants.PREF_USE_INCREMENTAL_BUILDER, buildSettingsUI.getUseIncrementalBuilder()); store.setValue(BuilderPreferenceConstants.PREF_USE_CONCURRENT_BUILDING, buildSettingsUI.getUseConcurrentBuilding()); store.setValue(BuilderPreferenceConstants.PREF_CONCURRENT_BUILD_JOBS, buildSettingsUI.getNumConcurrentBuildJobs()); - store.setValue(BuilderPreferenceConstants.PREF_MMP_CHANGED_ACTION_PROMPT, buildSettingsUI.getPromptForMMPChangedAction()); - store.setValue(BuilderPreferenceConstants.PREF_DEFAULT_MMP_CHANGED_ACTION, buildSettingsUI.getDefaultMMPChangedAction()); store.setValue(BuilderPreferenceConstants.PREF_USE_BUILIN_X86_VARS, buildSettingsUI.getUseBuiltInEnvVars()); - store.setValue(BuilderPreferenceConstants.PREF_DONT_PROMPT_FOR_DEPENDENCY_MISMATCH, buildSettingsUI.getDontPromtTrackDeps()); // global setting only + + if (SBSv2Utils.enableSBSv1Support()) { + store.setValue(BuilderPreferenceConstants.PREF_CLEAN_LEVEL, buildSettingsUI.getDefaultCleanLevelv1()); + store.setValue(BuilderPreferenceConstants.PREF_MANAGE_DEPENDENCIES, buildSettingsUI.getManageDependencies()); + store.setValue(BuilderPreferenceConstants.PREF_MMP_CHANGED_ACTION_PROMPT, buildSettingsUI.getPromptForMMPChangedAction()); + store.setValue(BuilderPreferenceConstants.PREF_DEFAULT_MMP_CHANGED_ACTION, buildSettingsUI.getDefaultMMPChangedAction()); + store.setValue(BuilderPreferenceConstants.PREF_DONT_PROMPT_FOR_DEPENDENCY_MISMATCH, buildSettingsUI.getDontPromtTrackDeps()); // global setting only + } if (SBSv2Utils.enableSBSv2Support()) { store.setValue(BuilderPreferenceConstants.PREF_CLEAN_LEVEL_V2, buildSettingsUI.getDefaultCleanLevelv2()); @@ -98,16 +104,19 @@ } protected void performDefaults() { - buildSettingsUI.setDefaultCleanLevelv1(0); buildSettingsUI.setBuildTestComponents(true); - buildSettingsUI.setManageDependencies(true); buildSettingsUI.setUseIncrementalBuilder(false); buildSettingsUI.setUseConcurrentBuilding(true); buildSettingsUI.setNumConcurrentBuildJobs(4); - buildSettingsUI.setPromptForMMPChangedAction(true); - buildSettingsUI.setDefaultMMPChangedAction(0); buildSettingsUI.setUseBuiltInEnvVars(true); - buildSettingsUI.setDontPromtTrackDeps(false); + + if (SBSv2Utils.enableSBSv1Support()) { + buildSettingsUI.setDefaultCleanLevelv1(0); + buildSettingsUI.setManageDependencies(true); + buildSettingsUI.setPromptForMMPChangedAction(true); + buildSettingsUI.setDefaultMMPChangedAction(0); + buildSettingsUI.setDontPromtTrackDeps(false); + } if (SBSv2Utils.enableSBSv2Support()) { buildSettingsUI.setDefaultCleanLevelv2(0); diff -r f1114f700e65 -r 9b50c8036532 builder/com.nokia.carbide.cdt.builder/src/com/nokia/carbide/cdt/internal/builder/ui/CarbideCPPProjectSettingsPage.java --- a/builder/com.nokia.carbide.cdt.builder/src/com/nokia/carbide/cdt/internal/builder/ui/CarbideCPPProjectSettingsPage.java Tue Apr 27 09:07:35 2010 -0500 +++ b/builder/com.nokia.carbide.cdt.builder/src/com/nokia/carbide/cdt/internal/builder/ui/CarbideCPPProjectSettingsPage.java Tue Apr 27 09:07:48 2010 -0500 @@ -154,7 +154,7 @@ sbsv2Project = CarbideBuilderPlugin.getBuildManager().isCarbideSBSv2Project(project); } - buildSettingsUI = new BuildSettingsUI(parent.getShell(), sbsv2Project, true); + buildSettingsUI = new BuildSettingsUI(parent.getShell(), !sbsv2Project, sbsv2Project, true); buildSettingsUI.createControl(optionsGroup); noDefaultAndApplyButton(); diff -r f1114f700e65 -r 9b50c8036532 core/com.nokia.carbide.cpp.doc.user/html/reference/trk/wnd_new_connection_wizard.htm --- a/core/com.nokia.carbide.cpp.doc.user/html/reference/trk/wnd_new_connection_wizard.htm Tue Apr 27 09:07:35 2010 -0500 +++ b/core/com.nokia.carbide.cpp.doc.user/html/reference/trk/wnd_new_connection_wizard.htm Tue Apr 27 09:07:48 2010 -0500 @@ -37,17 +37,17 @@ Connection Name -

Enter a name for the connection.

+

Enter a name to identify the connection.

Connection Settings

Displays COM Port, Baud Rate, IP Addresss, Channel and Port settings according to the chosen connection type.

-