Attach listener to connection name changes, rename Device -> Connection
authorEd Swartz <ed.swartz@nokia.com>
Fri, 18 Dec 2009 10:19:18 -0600
changeset 710 47bb893ba749
parent 709 c92b05bdc957
child 711 d97b8b6bce37
child 713 6c5fbb4d875b
Attach listener to connection name changes, rename Device -> Connection
connectivity/com.nokia.carbide.remoteConnections/plugin.xml
connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/internal/ui/ConnectionStatusSelectorContribution.java
connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/internal/ui/ConnectionUIUtils.java
connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/internal/ui/DeviceStatusSelectorContribution.java
connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/messages.properties
connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/view/ConnectionsView.java
--- a/connectivity/com.nokia.carbide.remoteConnections/plugin.xml	Fri Dec 18 09:54:29 2009 -0600
+++ b/connectivity/com.nokia.carbide.remoteConnections/plugin.xml	Fri Dec 18 10:19:18 2009 -0600
@@ -83,7 +83,7 @@
         <toolbar
 			id="com.nokia.carbide.cpp.news.contributions.toolbar.trim">
 			<control
-				class="com.nokia.carbide.remoteconnections.internal.ui.DeviceStatusSelectorContribution"
+				class="com.nokia.carbide.remoteconnections.internal.ui.ConnectionStatusSelectorContribution"
 				id="deviceStatusSelectorContribution">
 			</control>
         </toolbar>
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/internal/ui/ConnectionStatusSelectorContribution.java	Fri Dec 18 10:19:18 2009 -0600
@@ -0,0 +1,367 @@
+/*
+* Copyright (c) 2009 Nokia Corporation and/or its subsidiary(-ies).
+* All rights reserved.
+* This component and the accompanying materials are made available
+* under the terms of the License "Eclipse Public License v1.0"
+* which accompanies this distribution, and is available
+* at the URL "http://www.eclipse.org/legal/epl-v10.html".
+*
+* Initial Contributors:
+* Nokia Corporation - initial contribution.
+*
+* Contributors:
+*
+* Description: 
+*
+*/
+
+package com.nokia.carbide.remoteconnections.internal.ui;
+
+import java.text.MessageFormat;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.List;
+
+import org.eclipse.jface.layout.GridDataFactory;
+import org.eclipse.jface.layout.GridLayoutFactory;
+import org.eclipse.swt.SWT;
+import org.eclipse.swt.custom.CLabel;
+import org.eclipse.swt.events.MouseAdapter;
+import org.eclipse.swt.events.MouseEvent;
+import org.eclipse.swt.events.SelectionAdapter;
+import org.eclipse.swt.events.SelectionEvent;
+import org.eclipse.swt.graphics.Image;
+import org.eclipse.swt.graphics.Point;
+import org.eclipse.swt.widgets.Composite;
+import org.eclipse.swt.widgets.Control;
+import org.eclipse.swt.widgets.Display;
+import org.eclipse.swt.widgets.Menu;
+import org.eclipse.swt.widgets.MenuItem;
+import org.eclipse.swt.widgets.Shell;
+import org.eclipse.ui.IWorkbench;
+import org.eclipse.ui.IWorkbenchWindow;
+import org.eclipse.ui.PartInitException;
+import org.eclipse.ui.PlatformUI;
+import org.eclipse.ui.menus.WorkbenchWindowControlContribution;
+
+import com.nokia.carbide.remoteconnections.Messages;
+import com.nokia.carbide.remoteconnections.RemoteConnectionsActivator;
+import com.nokia.carbide.remoteconnections.interfaces.IConnection;
+import com.nokia.carbide.remoteconnections.interfaces.IConnectionsManager;
+import com.nokia.carbide.remoteconnections.interfaces.IConnectionsManager.IConnectionListener;
+import com.nokia.carbide.remoteconnections.interfaces.IConnectionsManager.IConnectionsManagerListener;
+import com.nokia.carbide.remoteconnections.internal.api.IConnection2;
+import com.nokia.carbide.remoteconnections.internal.api.IConnection2.IConnectionStatus;
+import com.nokia.carbide.remoteconnections.internal.api.IConnection2.IConnectionStatusChangedListener;
+import com.nokia.carbide.remoteconnections.internal.registry.Registry;
+import com.nokia.carbide.remoteconnections.view.ConnectionsView;
+import com.nokia.cpp.internal.api.utils.core.TextUtils;
+import com.nokia.cpp.internal.api.utils.ui.WorkbenchUtils;
+
+
+/**
+ * This widget appears in the Eclipse trim and allows the user to select the
+ * "default" device connection and also see its status at a glance. 
+ */
+public class ConnectionStatusSelectorContribution extends WorkbenchWindowControlContribution
+		implements IConnectionListener, IConnectionStatusChangedListener, IConnectionsManagerListener {
+
+	private Composite container;
+	private CLabel connectionInfo;
+	private IConnectionsManager manager;
+	private IConnection defaultConnection;
+	
+	public ConnectionStatusSelectorContribution() {
+		manager = RemoteConnectionsActivator.getConnectionsManager();
+	}
+	
+	/*
+	 * (non-Javadoc)
+	 * @see org.eclipse.jface.action.ControlContribution#createControl(org.eclipse.swt.widgets.Composite)
+	 */
+	@Override
+	protected Control createControl(Composite parent) {
+		
+		// This UI is recreated whenever the default connection changes.
+		
+		manager.addConnectionListener(this);
+		Registry.instance().addConnectionStoreChangedListener(this);
+		
+		container = new Composite(parent, SWT.NONE);
+		GridLayoutFactory.fillDefaults().margins(2, 0).applyTo(container);
+
+		// Create a label for the trim.
+		connectionInfo = new CLabel(container, SWT.FLAT);
+		GridDataFactory.fillDefaults().grab(false, true).applyTo(connectionInfo);
+		
+		String text = Messages.getString("DeviceStatusSelectorContribution_NoDefaultConnectionMessage"); //$NON-NLS-1$
+		defaultConnection = manager.getDefaultConnection();
+		if (defaultConnection != null) {
+			text = defaultConnection.getDisplayName();
+			if (defaultConnection instanceof IConnection2) {
+				((IConnection2) defaultConnection).addStatusChangedListener(ConnectionStatusSelectorContribution.this);
+			}
+		}
+		
+		connectionInfo.setText(text);
+		
+		updateConnectionStatus(getConnectionStatus(defaultConnection));
+		
+		connectionInfo.addMouseListener (new MouseAdapter() {
+			public void mouseDown(MouseEvent event) {
+				Shell shell = connectionInfo.getShell();
+				final Display display = shell.getDisplay();
+				
+				final Menu menu = new Menu(shell, SWT.POP_UP);
+				populateConnectionMenu(menu);
+				
+				Point screenLoc = connectionInfo.toDisplay(event.x, event.y);
+				menu.setLocation(screenLoc.x, screenLoc.y);
+				menu.setVisible(true);
+				
+				while (!menu.isDisposed() && menu.isVisible()) {
+					if (!display.readAndDispatch())
+						display.sleep();
+				}
+				menu.dispose();
+			}
+			/* (non-Javadoc)
+			 * @see org.eclipse.swt.events.MouseAdapter#mouseDoubleClick(org.eclipse.swt.events.MouseEvent)
+			 */
+			@Override
+			public void mouseDoubleClick(MouseEvent ev) {
+				// NOTE: the menu usually comes up before double-click is seen
+				if (ev.button == 1) {
+					openConnectionsView();
+				}
+			}
+		});
+		
+		RemoteConnectionsActivator.setHelp(container, "DeviceStatusSelector");
+		return container;
+	}
+
+	/**
+	 * @param ev
+	 */
+	protected void openConnectionsView() {
+		try {
+			WorkbenchUtils.getView(ConnectionsView.VIEW_ID);
+        } 
+        catch (PartInitException e) {
+        	RemoteConnectionsActivator.logError(e);
+        }
+	}
+
+	/**
+	 * @param defaultConnection
+	 * @param status
+	 * @return
+	 */
+	private String createDeviceStatusTooltip(IConnection defaultConnection,
+			IConnectionStatus status) {
+		if (defaultConnection == null) {
+			return Messages.getString("DeviceStatusSelectorContribution.NoDynamicOrManualConnectionsTooltip"); //$NON-NLS-1$
+		}
+		
+		String statusString = null;
+		if (status != null) {
+			statusString = status.getDescription();
+		}
+		
+		if (TextUtils.isEmpty(statusString))
+			statusString = Messages.getString("DeviceStatusSelectorContribution.NotInUse"); //$NON-NLS-1$
+		
+		return MessageFormat.format(Messages.getString("DeviceStatusSelectorContribution.DeviceStatusFormat"), defaultConnection.getDisplayName(), statusString); //$NON-NLS-1$
+	}
+
+	/**
+	 * Get the image representing the connection status.
+	 * @param connection
+	 * @return Image, to be disposed
+	 */
+	private IConnectionStatus getConnectionStatus(IConnection connection) {
+		if (!(connection instanceof IConnection2)) {
+			return null;
+		} else {
+			return ((IConnection2) connection).getStatus();
+		}
+	}
+	
+	/**
+	 * @return
+	 */
+	protected void populateConnectionMenu(Menu menu) {
+		IConnection defaultConnection = manager.getDefaultConnection();
+
+		// Display the connections with dynamic ones first, 
+		// then static ones, separated by a separator
+
+		List<IConnection> dynamicConnections = new ArrayList<IConnection>();
+		List<IConnection> staticConnections = new ArrayList<IConnection>();
+		for (IConnection connection : RemoteConnectionsActivator.getConnectionsManager().getConnections()) {
+			if (connection instanceof IConnection2 && ((IConnection2)connection).isDynamic()) 
+				dynamicConnections.add(connection);
+			else
+				staticConnections.add(connection);
+		}
+		
+
+		Comparator<IConnection> connectionComparator = new Comparator<IConnection>() {
+			public int compare(IConnection o1, IConnection o2) {
+				return o1.getDisplayName().compareToIgnoreCase(o2.getDisplayName());
+			}
+		};
+		Collections.sort(dynamicConnections, connectionComparator);
+		Collections.sort(staticConnections, connectionComparator);
+
+		MenuItem label = new MenuItem(menu, SWT.NONE);
+		label.setEnabled(false);
+		label.setText(Messages.getString("DeviceStatusSelectorContribution_SelectTheDefaultConnectionMessage")); //$NON-NLS-1$
+		
+		for (IConnection connection : dynamicConnections) {
+			createConnectionMenuItem(menu, connection, defaultConnection);
+		}
+		
+		new MenuItem(menu, SWT.SEPARATOR);
+		
+		for (IConnection connection : staticConnections) {
+			createConnectionMenuItem(menu, connection, defaultConnection);
+		}
+		
+		new MenuItem(menu, SWT.SEPARATOR);
+		
+		MenuItem openView = new MenuItem(menu, SWT.PUSH);
+		openView.setText("Open Remote Connections view");
+		openView.addSelectionListener(new SelectionAdapter() {
+			@Override
+			public void widgetSelected(SelectionEvent e) {
+				openConnectionsView();
+			}
+		});
+	}
+
+	/**
+	 * @param menu
+	 * @param connection
+	 * @param defaultConnection 
+	 */
+	private MenuItem createConnectionMenuItem(Menu menu, final IConnection connection, IConnection defaultConnection) {
+		MenuItem item = new MenuItem(menu, SWT.CHECK);
+		
+		boolean isDefault = false;
+		isDefault = connection.equals(defaultConnection);
+		
+		item.setSelection(isDefault);
+		
+		item.setText(connection.getDisplayName());
+		
+		item.addSelectionListener(new SelectionAdapter() {
+			@Override
+			public void widgetSelected(SelectionEvent e) {
+				manager.setDefaultConnection(connection);
+			}
+		});		
+		
+		return item;
+	}
+
+	/*
+	 * (non-Javadoc)
+	 * @see org.eclipse.jface.action.ContributionItem#dispose()
+	 */
+	public void dispose() {
+		if (defaultConnection instanceof IConnection2)
+			((IConnection2) defaultConnection).removeStatusChangedListener(this);
+		
+		manager.removeConnectionListener(this);
+		super.dispose();
+	}
+
+	/* (non-Javadoc)
+	 * @see com.nokia.carbide.remoteconnections.interfaces.IConnectionsManager.IConnectionListener#connectionAdded(com.nokia.carbide.remoteconnections.interfaces.IConnection)
+	 */
+	public void connectionAdded(IConnection connection) {
+		updateUI();
+	}
+	
+	/* (non-Javadoc)
+	 * @see com.nokia.carbide.remoteconnections.interfaces.IConnectionsManager.IConnectionListener#connectionRemoved(com.nokia.carbide.remoteconnections.interfaces.IConnection)
+	 */
+	public void connectionRemoved(IConnection connection) {
+		updateUI();
+	}
+	/* (non-Javadoc)
+	 * @see com.nokia.carbide.remoteconnections.interfaces.IConnectionsManager.IConnectionListener#defaultConnectionSet(com.nokia.carbide.remoteconnections.interfaces.IConnection)
+	 */
+	public void defaultConnectionSet(IConnection connection) {
+		defaultConnection = connection;
+		updateUI();
+	}
+
+	/* (non-Javadoc)
+	 * @see com.nokia.carbide.remoteconnections.internal.IConnection2.IStatusChangedListener#statusChanged(com.nokia.carbide.remoteconnections.internal.IConnection2.IStatus)
+	 */
+	public void statusChanged(IConnectionStatus status) {
+		updateConnectionStatus(status);
+	}
+	
+	/**
+	 * @param status
+	 */
+	private void updateConnectionStatus(IConnectionStatus status) {
+		Image deviceImage = ConnectionUIUtils.getConnectionStatusImage(status);
+		connectionInfo.setImage(deviceImage);
+		connectionInfo.setToolTipText(createDeviceStatusTooltip(defaultConnection, status));
+	}
+
+	/**
+	 * 
+	 */
+	private void updateUI() {
+		// perform update in UI thread
+		final IWorkbench workbench = PlatformUI.getWorkbench();
+		workbench.getDisplay().asyncExec(new Runnable() {
+			public void run() {
+				IWorkbenchWindow window = workbench.getActiveWorkbenchWindow();
+				if (window != null) {
+					update();
+				}
+			}
+		});		
+	}
+
+	/*
+	 * (non-Javadoc)
+	 * @see org.eclipse.jface.action.ContributionItem#isDynamic()
+	 */
+	@Override
+	public boolean isDynamic() {
+		return true;
+	}
+
+	/*
+	 * (non-Javadoc)
+	 * @see org.eclipse.jface.action.ContributionItem#update()
+	 */
+	@Override
+	public void update() {
+		getParent().update(true);
+	}
+
+	/* (non-Javadoc)
+	 * @see com.nokia.carbide.remoteconnections.interfaces.IConnectionsManager.IConnectionsManagerListener#connectionStoreChanged()
+	 */
+	public void connectionStoreChanged() {
+		updateUI();
+	}
+
+	/* (non-Javadoc)
+	 * @see com.nokia.carbide.remoteconnections.interfaces.IConnectionsManager.IConnectionsManagerListener#displayChanged()
+	 */
+	public void displayChanged() {
+		updateUI();
+	}
+
+}
\ No newline at end of file
--- a/connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/internal/ui/ConnectionUIUtils.java	Fri Dec 18 09:54:29 2009 -0600
+++ b/connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/internal/ui/ConnectionUIUtils.java	Fri Dec 18 10:19:18 2009 -0600
@@ -124,11 +124,12 @@
 		if (connection instanceof IConnection2) {
 			IConnectionStatus status = ((IConnection2) connection).getStatus();
 			return getConnectionStatusImage(status);
+		} else {
+			if (isConnectionInUse(connection)) {
+				return ConnectionUIUtils.STATUS_INUSE_IMG;
+			}
+			return ConnectionUIUtils.CONNECTION_IMG;
 		}
-		if (isConnectionInUse(connection)) {
-			return ConnectionUIUtils.STATUS_INUSE_IMG;
-		}
-		return ConnectionUIUtils.CONNECTION_IMG;
 	}
 
 	/**
--- a/connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/internal/ui/DeviceStatusSelectorContribution.java	Fri Dec 18 09:54:29 2009 -0600
+++ /dev/null	Thu Jan 01 00:00:00 1970 +0000
@@ -1,350 +0,0 @@
-/*
-* Copyright (c) 2009 Nokia Corporation and/or its subsidiary(-ies).
-* All rights reserved.
-* This component and the accompanying materials are made available
-* under the terms of the License "Eclipse Public License v1.0"
-* which accompanies this distribution, and is available
-* at the URL "http://www.eclipse.org/legal/epl-v10.html".
-*
-* Initial Contributors:
-* Nokia Corporation - initial contribution.
-*
-* Contributors:
-*
-* Description: 
-*
-*/
-
-package com.nokia.carbide.remoteconnections.internal.ui;
-
-import java.text.MessageFormat;
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.Comparator;
-import java.util.List;
-
-import org.eclipse.jface.layout.GridDataFactory;
-import org.eclipse.jface.layout.GridLayoutFactory;
-import org.eclipse.swt.SWT;
-import org.eclipse.swt.custom.CLabel;
-import org.eclipse.swt.events.MouseAdapter;
-import org.eclipse.swt.events.MouseEvent;
-import org.eclipse.swt.events.SelectionAdapter;
-import org.eclipse.swt.events.SelectionEvent;
-import org.eclipse.swt.graphics.Image;
-import org.eclipse.swt.graphics.Point;
-import org.eclipse.swt.widgets.Composite;
-import org.eclipse.swt.widgets.Control;
-import org.eclipse.swt.widgets.Display;
-import org.eclipse.swt.widgets.Menu;
-import org.eclipse.swt.widgets.MenuItem;
-import org.eclipse.swt.widgets.Shell;
-import org.eclipse.ui.IWorkbench;
-import org.eclipse.ui.IWorkbenchWindow;
-import org.eclipse.ui.PartInitException;
-import org.eclipse.ui.PlatformUI;
-import org.eclipse.ui.menus.WorkbenchWindowControlContribution;
-
-import com.nokia.carbide.remoteconnections.Messages;
-import com.nokia.carbide.remoteconnections.RemoteConnectionsActivator;
-import com.nokia.carbide.remoteconnections.interfaces.IConnection;
-import com.nokia.carbide.remoteconnections.interfaces.IConnectionsManager;
-import com.nokia.carbide.remoteconnections.interfaces.IConnectionsManager.IConnectionListener;
-import com.nokia.carbide.remoteconnections.internal.api.IConnection2;
-import com.nokia.carbide.remoteconnections.internal.api.IConnection2.IConnectionStatus;
-import com.nokia.carbide.remoteconnections.internal.api.IConnection2.IConnectionStatusChangedListener;
-import com.nokia.carbide.remoteconnections.view.ConnectionsView;
-import com.nokia.cpp.internal.api.utils.core.TextUtils;
-import com.nokia.cpp.internal.api.utils.ui.WorkbenchUtils;
-
-
-/**
- * This widget appears in the Eclipse trim and allows the user to select the
- * "default" device connection and also see its status at a glance. 
- */
-public class DeviceStatusSelectorContribution extends WorkbenchWindowControlContribution
-		implements IConnectionListener, IConnectionStatusChangedListener {
-
-	private Composite container;
-	private CLabel deviceInfo;
-	private IConnectionsManager manager;
-	private IConnection defaultConnection;
-	
-	public DeviceStatusSelectorContribution() {
-		manager = RemoteConnectionsActivator.getConnectionsManager();
-	}
-	
-	/*
-	 * (non-Javadoc)
-	 * @see org.eclipse.jface.action.ControlContribution#createControl(org.eclipse.swt.widgets.Composite)
-	 */
-	@Override
-	protected Control createControl(Composite parent) {
-		
-		// This UI is recreated whenever the default connection changes.
-		
-		manager.addConnectionListener(this);
-		
-		container = new Composite(parent, SWT.NONE);
-		GridLayoutFactory.fillDefaults().margins(2, 0).applyTo(container);
-
-		// Create a label for the trim.
-		deviceInfo = new CLabel(container, SWT.FLAT);
-		GridDataFactory.fillDefaults().grab(false, true).applyTo(deviceInfo);
-		
-		String text = Messages.getString("DeviceStatusSelectorContribution_NoDefaultConnectionMessage"); //$NON-NLS-1$
-		defaultConnection = manager.getDefaultConnection();
-		if (defaultConnection != null) {
-			text = defaultConnection.getDisplayName();
-			if (defaultConnection instanceof IConnection2) {
-				((IConnection2) defaultConnection).addStatusChangedListener(DeviceStatusSelectorContribution.this);
-			}
-		}
-		
-		deviceInfo.setText(text);
-		
-		updateConnectionStatus(getConnectionStatus(defaultConnection));
-		
-		deviceInfo.addMouseListener (new MouseAdapter() {
-			public void mouseDown(MouseEvent event) {
-				Shell shell = deviceInfo.getShell();
-				final Display display = shell.getDisplay();
-				
-				final Menu menu = new Menu(shell, SWT.POP_UP);
-				populateConnectionMenu(menu);
-				
-				Point screenLoc = deviceInfo.toDisplay(event.x, event.y);
-				menu.setLocation(screenLoc.x, screenLoc.y);
-				menu.setVisible(true);
-				
-				while (!menu.isDisposed() && menu.isVisible()) {
-					if (!display.readAndDispatch())
-						display.sleep();
-				}
-				menu.dispose();
-			}
-			/* (non-Javadoc)
-			 * @see org.eclipse.swt.events.MouseAdapter#mouseDoubleClick(org.eclipse.swt.events.MouseEvent)
-			 */
-			@Override
-			public void mouseDoubleClick(MouseEvent ev) {
-				// NOTE: the menu usually comes up before double-click is seen
-				if (ev.button == 1) {
-					openConnectionsView();
-				}
-			}
-		});
-		
-		RemoteConnectionsActivator.setHelp(container, "DeviceStatusSelector");
-		return container;
-	}
-
-	/**
-	 * @param ev
-	 */
-	protected void openConnectionsView() {
-		try {
-			WorkbenchUtils.getView(ConnectionsView.VIEW_ID);
-        } 
-        catch (PartInitException e) {
-        	RemoteConnectionsActivator.logError(e);
-        }
-	}
-
-	/**
-	 * @param defaultConnection
-	 * @param status
-	 * @return
-	 */
-	private String createDeviceStatusTooltip(IConnection defaultConnection,
-			IConnectionStatus status) {
-		if (defaultConnection == null) {
-			return Messages.getString("DeviceStatusSelectorContribution.NoDynamicOrManualConnectionsTooltip"); //$NON-NLS-1$
-		}
-		
-		String statusString = null;
-		if (status != null) {
-			statusString = status.getDescription();
-		}
-		
-		if (TextUtils.isEmpty(statusString))
-			statusString = Messages.getString("DeviceStatusSelectorContribution.UnknownStatus"); //$NON-NLS-1$
-		
-		return MessageFormat.format(Messages.getString("DeviceStatusSelectorContribution.DeviceStatusFormat"), defaultConnection.getDisplayName(), statusString); //$NON-NLS-1$
-	}
-
-	/**
-	 * Get the image representing the connection status.
-	 * @param connection
-	 * @return Image, to be disposed
-	 */
-	private IConnectionStatus getConnectionStatus(IConnection connection) {
-		if (!(connection instanceof IConnection2)) {
-			return null;
-		} else {
-			return ((IConnection2) connection).getStatus();
-		}
-	}
-	
-	/**
-	 * @return
-	 */
-	protected void populateConnectionMenu(Menu menu) {
-		IConnection defaultConnection = manager.getDefaultConnection();
-
-		// Display the connections with dynamic ones first, 
-		// then static ones, separated by a separator
-
-		List<IConnection> dynamicConnections = new ArrayList<IConnection>();
-		List<IConnection> staticConnections = new ArrayList<IConnection>();
-		for (IConnection connection : RemoteConnectionsActivator.getConnectionsManager().getConnections()) {
-			if (connection instanceof IConnection2 && ((IConnection2)connection).isDynamic()) 
-				dynamicConnections.add(connection);
-			else
-				staticConnections.add(connection);
-		}
-		
-
-		Comparator<IConnection> connectionComparator = new Comparator<IConnection>() {
-			public int compare(IConnection o1, IConnection o2) {
-				return o1.getDisplayName().compareToIgnoreCase(o2.getDisplayName());
-			}
-		};
-		Collections.sort(dynamicConnections, connectionComparator);
-		Collections.sort(staticConnections, connectionComparator);
-
-		MenuItem label = new MenuItem(menu, SWT.NONE);
-		label.setEnabled(false);
-		label.setText(Messages.getString("DeviceStatusSelectorContribution_SelectTheDefaultConnectionMessage")); //$NON-NLS-1$
-		
-		for (IConnection connection : dynamicConnections) {
-			createConnectionMenuItem(menu, connection, defaultConnection);
-		}
-		
-		new MenuItem(menu, SWT.SEPARATOR);
-		
-		for (IConnection connection : staticConnections) {
-			createConnectionMenuItem(menu, connection, defaultConnection);
-		}
-		
-		new MenuItem(menu, SWT.SEPARATOR);
-		
-		MenuItem openView = new MenuItem(menu, SWT.PUSH);
-		openView.setText("Open Remote Connections view");
-		openView.addSelectionListener(new SelectionAdapter() {
-			@Override
-			public void widgetSelected(SelectionEvent e) {
-				openConnectionsView();
-			}
-		});
-	}
-
-	/**
-	 * @param menu
-	 * @param connection
-	 * @param defaultConnection 
-	 */
-	private MenuItem createConnectionMenuItem(Menu menu, final IConnection connection, IConnection defaultConnection) {
-		MenuItem item = new MenuItem(menu, SWT.CHECK);
-		
-		boolean isDefault = false;
-		isDefault = connection.equals(defaultConnection);
-		
-		item.setSelection(isDefault);
-		
-		item.setText(connection.getDisplayName());
-		
-		item.addSelectionListener(new SelectionAdapter() {
-			@Override
-			public void widgetSelected(SelectionEvent e) {
-				manager.setDefaultConnection(connection);
-			}
-		});		
-		
-		return item;
-	}
-
-	/*
-	 * (non-Javadoc)
-	 * @see org.eclipse.jface.action.ContributionItem#dispose()
-	 */
-	public void dispose() {
-		if (defaultConnection instanceof IConnection2)
-			((IConnection2) defaultConnection).removeStatusChangedListener(this);
-		
-		manager.removeConnectionListener(this);
-		super.dispose();
-	}
-
-	/* (non-Javadoc)
-	 * @see com.nokia.carbide.remoteconnections.interfaces.IConnectionsManager.IConnectionListener#connectionAdded(com.nokia.carbide.remoteconnections.interfaces.IConnection)
-	 */
-	public void connectionAdded(IConnection connection) {
-		updateUI();
-	}
-	
-	/* (non-Javadoc)
-	 * @see com.nokia.carbide.remoteconnections.interfaces.IConnectionsManager.IConnectionListener#connectionRemoved(com.nokia.carbide.remoteconnections.interfaces.IConnection)
-	 */
-	public void connectionRemoved(IConnection connection) {
-		updateUI();
-	}
-	/* (non-Javadoc)
-	 * @see com.nokia.carbide.remoteconnections.interfaces.IConnectionsManager.IConnectionListener#defaultConnectionSet(com.nokia.carbide.remoteconnections.interfaces.IConnection)
-	 */
-	public void defaultConnectionSet(IConnection connection) {
-		defaultConnection = connection;
-		updateUI();
-	}
-
-	/* (non-Javadoc)
-	 * @see com.nokia.carbide.remoteconnections.internal.IConnection2.IStatusChangedListener#statusChanged(com.nokia.carbide.remoteconnections.internal.IConnection2.IStatus)
-	 */
-	public void statusChanged(IConnectionStatus status) {
-		updateConnectionStatus(status);
-	}
-	
-	/**
-	 * @param status
-	 */
-	private void updateConnectionStatus(IConnectionStatus status) {
-		Image deviceImage = ConnectionUIUtils.getConnectionStatusImage(status);
-		deviceInfo.setImage(deviceImage);
-		deviceInfo.setToolTipText(createDeviceStatusTooltip(defaultConnection, status));
-	}
-
-	/**
-	 * 
-	 */
-	private void updateUI() {
-		// perform update in UI thread
-		final IWorkbench workbench = PlatformUI.getWorkbench();
-		workbench.getDisplay().asyncExec(new Runnable() {
-			public void run() {
-				IWorkbenchWindow window = workbench.getActiveWorkbenchWindow();
-				if (window != null) {
-					update();
-				}
-			}
-		});		
-	}
-
-	/*
-	 * (non-Javadoc)
-	 * @see org.eclipse.jface.action.ContributionItem#isDynamic()
-	 */
-	@Override
-	public boolean isDynamic() {
-		return true;
-	}
-
-	/*
-	 * (non-Javadoc)
-	 * @see org.eclipse.jface.action.ContributionItem#update()
-	 */
-	@Override
-	public void update() {
-		getParent().update(true);
-	}
-
-}
\ No newline at end of file
--- a/connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/messages.properties	Fri Dec 18 09:54:29 2009 -0600
+++ b/connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/messages.properties	Fri Dec 18 10:19:18 2009 -0600
@@ -55,7 +55,7 @@
 DeviceStatusSelectorContribution_SelectTheDefaultConnectionMessage=Select the default connection:
 DeviceStatusSelectorContribution.DeviceStatusFormat={0}: {1}
 DeviceStatusSelectorContribution.NoDynamicOrManualConnectionsTooltip=No default connection selected.
-DeviceStatusSelectorContribution.UnknownStatus=Unknown status
+DeviceStatusSelectorContribution.NotInUse=Not in use
 ExportPage.BrowseGroupLabel=Connections file:
 ExportPage.Description=Select connections to export
 ExportPage.FileDialogTitle=Save As
--- a/connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/view/ConnectionsView.java	Fri Dec 18 09:54:29 2009 -0600
+++ b/connectivity/com.nokia.carbide.remoteConnections/src/com/nokia/carbide/remoteconnections/view/ConnectionsView.java	Fri Dec 18 10:19:18 2009 -0600
@@ -189,8 +189,9 @@
 		protected void setValue(Object element, Object value) {
 			IConnection connection = (IConnection) ((TreeNode) element).getValue();
 			connection.setDisplayName(value.toString());
-			viewer.refresh(true);
-			packColumns();
+			//viewer.refresh(true);
+			//packColumns();
+			Registry.instance().updateDisplays();
 			Registry.instance().storeConnections();
 		}
 	}