Bug 11438: Fix cause for TCFClient.dll crasher. It is a client-side bug caused by not filtering out bad inputs.
authorEd Swartz <ed.swartz@nokia.com>
Tue, 29 Jun 2010 15:14:38 -0500
changeset 1556 707b5fa4c143
parent 1554 f83f6a37088e
child 1557 c431b953b863
Bug 11438: Fix cause for TCFClient.dll crasher. It is a client-side bug caused by not filtering out bad inputs.
connectivity/com.nokia.tcf/src/com/nokia/tcf/impl/TCAPIConnection.java
--- a/connectivity/com.nokia.tcf/src/com/nokia/tcf/impl/TCAPIConnection.java	Tue Jun 29 14:04:33 2010 -0500
+++ b/connectivity/com.nokia.tcf/src/com/nokia/tcf/impl/TCAPIConnection.java	Tue Jun 29 15:14:38 2010 -0500
@@ -501,9 +501,13 @@
 				settings = new String[1];
 			} else {
 				// Add other connections here
+				return new Status(Status.ERROR, Activator.PLUGIN_ID, (int)TCErrorConstants.TCAPI_ERR_MEDIA_NOT_SUPPORTED, 
+						"Unknown connection type: " + type, null); 
 			}
+			return finishConnect(type, settings, inConnection, inMessageOptions, inMessageIds);
+		} else {
+			return status;
 		}
-		return finishConnect(type, settings, inConnection, inMessageOptions, inMessageIds);
 	}
 	protected void ensureWritableFile(String filePath) throws IOException {
 		// ensure file path points to a writable regular file