Add more language codes and stifle these unknown language warnings forever (bug 10958)
authorEd Swartz <ed.swartz@nokia.com>
Fri, 14 May 2010 10:59:33 -0500
changeset 1358 b1fb3bf8174e
parent 1357 b0d425db83b6
child 1359 d927acd507a6
Add more language codes and stifle these unknown language warnings forever (bug 10958)
project/com.nokia.carbide.cpp.epoc.engine.tests/src/com/nokia/carbide/cpp/epoc/engine/tests/model/TestMMPView5.java
project/com.nokia.carbide.cpp.epoc.engine/src/com/nokia/carbide/cpp/epoc/engine/model/mmp/EMMPLanguage.java
project/com.nokia.carbide.cpp.epoc.engine/src/com/nokia/carbide/internal/cpp/epoc/engine/model/mmp/MMPView.java
--- a/project/com.nokia.carbide.cpp.epoc.engine.tests/src/com/nokia/carbide/cpp/epoc/engine/tests/model/TestMMPView5.java	Fri May 14 10:52:41 2010 -0500
+++ b/project/com.nokia.carbide.cpp.epoc.engine.tests/src/com/nokia/carbide/cpp/epoc/engine/tests/model/TestMMPView5.java	Fri May 14 10:59:33 2010 -0500
@@ -489,6 +489,22 @@
 		// ensure the unknown languages don't abort processing
 		assertEquals(3, seen.size());
 	}
+	public void testMissingLanguagesBug10958() {
+		// this has unknown languages
+		String text = 
+			"LANG 01 02 1000 1001 33\n";
+		IMMPView view;
+		makeModel(text);
+		view = getView(mmpConfig);
+		List<EMMPLanguage> languages = view.getLanguages();
+		
+		// add new entries
+		languages.add(EMMPLanguage.Punjabi);
+		
+		// should not remove unknown entries 
+		commitTest(view, "LANG 01 02 1000 1001 33 77\n");
+
+	}
 	
 	public void testUnterminatedCrossDocumentParseBug7886() {
 		String text =
--- a/project/com.nokia.carbide.cpp.epoc.engine/src/com/nokia/carbide/cpp/epoc/engine/model/mmp/EMMPLanguage.java	Fri May 14 10:52:41 2010 -0500
+++ b/project/com.nokia.carbide.cpp.epoc.engine/src/com/nokia/carbide/cpp/epoc/engine/model/mmp/EMMPLanguage.java	Fri May 14 10:59:33 2010 -0500
@@ -236,6 +236,13 @@
     /*
      * Discontinuity
      */
+    E14346("14346", 14346),  //$NON-NLS-1$
+    E14387("14387", 14387),  //$NON-NLS-1$
+    E14412("14412", 14412),  //$NON-NLS-1$
+    E14419("14419", 14419),  //$NON-NLS-1$
+    /*
+     * Discontinuity
+     */
     SC_NonLocalized(Messages.getString("EMMPLanguage.NonLocalized"), 0); //$NON-NLS-1$
 
 	private String key;
--- a/project/com.nokia.carbide.cpp.epoc.engine/src/com/nokia/carbide/internal/cpp/epoc/engine/model/mmp/MMPView.java	Fri May 14 10:52:41 2010 -0500
+++ b/project/com.nokia.carbide.cpp.epoc.engine/src/com/nokia/carbide/internal/cpp/epoc/engine/model/mmp/MMPView.java	Fri May 14 10:59:33 2010 -0500
@@ -213,12 +213,14 @@
 			try {
 				list.add(EMMPLanguage.fromCode(node.getValue()));
 			} catch (IllegalArgumentException e) {
-				// ignore unknown language
+				// ignore unknown language... completely! (I'm tired of these bug reports)
+				/*
 				EpocEnginePlugin.log(
 						Logging.newStatus(EpocEnginePlugin.getDefault(), 
 								new IllegalArgumentException(
 										"Warning, ignoring unknown language code: " + node.getValue() + " in " + stmt)
 				));
+				*/
 			}
 		}
 		return list;