fix potential NPE + add bundle discovery for testing
authordadubrow
Mon, 17 May 2010 10:36:46 -0500
changeset 1366 c61bb9dcfe74
parent 1365 d0f403a0b234
child 1367 4fc74a5f356a
fix potential NPE + add bundle discovery for testing
core/com.nokia.carbide.discovery.ui/src/com/nokia/carbide/discovery/ui/view/DiscoveryView.java
--- a/core/com.nokia.carbide.discovery.ui/src/com/nokia/carbide/discovery/ui/view/DiscoveryView.java	Mon May 17 10:06:28 2010 -0500
+++ b/core/com.nokia.carbide.discovery.ui/src/com/nokia/carbide/discovery/ui/view/DiscoveryView.java	Mon May 17 10:36:46 2010 -0500
@@ -15,6 +15,7 @@
 import org.eclipse.core.runtime.Platform;
 import org.eclipse.equinox.internal.p2.discovery.Catalog;
 import org.eclipse.equinox.internal.p2.discovery.DiscoveryCore;
+import org.eclipse.equinox.internal.p2.discovery.compatibility.BundleDiscoveryStrategy;
 import org.eclipse.equinox.internal.p2.discovery.compatibility.RemoteBundleDiscoveryStrategy;
 import org.eclipse.equinox.internal.p2.discovery.model.CatalogItem;
 import org.eclipse.equinox.internal.p2.ui.discovery.DiscoveryUi;
@@ -82,15 +83,16 @@
 		Catalog catalog = new Catalog();
 		catalog.setEnvironment(DiscoveryCore.createEnvironment());
 		catalog.setVerifyUpdateSiteAvailability(false);
-
-		// look for descriptors from installed bundles
-//		catalog.getDiscoveryStrategies().add(new BundleDiscoveryStrategy());
-
+		
 		// look for remote descriptor
 		RemoteBundleDiscoveryStrategy remoteDiscoveryStrategy = new RemoteBundleDiscoveryStrategy();
 		String url = getFromServerProperties(DIRECTORY_KEY);
-		remoteDiscoveryStrategy.setDirectoryUrl(url);
-		catalog.getDiscoveryStrategies().add(remoteDiscoveryStrategy);
+		if (url != null) {
+			remoteDiscoveryStrategy.setDirectoryUrl(url);
+			catalog.getDiscoveryStrategies().add(remoteDiscoveryStrategy);
+		}
+		else // look for descriptors from installed bundles
+			catalog.getDiscoveryStrategies().add(new BundleDiscoveryStrategy());
 
 		return catalog;
 	}