MCL/sf/app/commonemail: comparison emailservices/emailserver/cmailhandlerplugin/src/fsnotificationhandlerbaseimpl.cpp

equal deleted inserted replaced

-:efd4f1afd43e
+:d620048b4810
 * Description: This file implements class CFSNotificationHandlerBase.
 *
 */
 #include <centralrepository.h>
-//<cmail>
 #include "emailtrace.h"
 #include "cfsmailclient.h"
-//</cmail>
 #include "fsnotificationhandlermgr.h"
 #include "fsnotificationhandlerbase.h"
 #include "cmailhandlerpluginpanic.h"
 #include "commonemailcrkeys.h"
 #include "freestyleemailcenrepkeys.h"
 #include "FreestyleEmailUiConstants.h"
+const TInt KTimerDelay = 20;
 // ======== MEMBER FUNCTIONS ========
 CFSNotificationHandlerBase::CFSNotificationHandlerBase(
 MFSNotificationHandlerMgr& aOwner ) :
 iOwner( aOwner ),
 }
 void CFSNotificationHandlerBase::ConstructL()
 {
 FUNC_LOG;
+iTimer = CNewMailNotificationTimer::NewL( *this );
 }
 CFSNotificationHandlerBase::~CFSNotificationHandlerBase()
 {
 FUNC_LOG;
 REComSession::DestroyedImplementation( iDestructorKey );
+delete iTimer;
+iNewInboxEntries.Reset();
 }
 CFSMailClient& CFSNotificationHandlerBase::MailClient() const
 {
 FUNC_LOG;
 if ( !iObserving )
 {
 return;
 }
-/* TBool capabilitiesToContinue( CapabilitiesToContinueL( aEvent,
-aMailbox,
-aParam1,
-aParam2,
-aParam3) );
-if ( !capabilitiesToContinue )
-{
-return;
-}*/
 HandleEventL( aEvent, aMailbox, aParam1, aParam2, aParam3 );
 }
 return EFalse;
 }
 }
 TBool CFSNotificationHandlerBase::MessagesCauseNotificationL( TFSMailMsgId aMailboxId,
-CFSMailFolder& aParentFolder,
+TFSMailMsgId aParentFolderId,
 const RArray<TFSMailMsgId>& aMsgIdList )
 {
 FUNC_LOG;
+CFSMailFolder* parentFolder(
+MailClient().GetFolderByUidL( aMailboxId, aParentFolderId ) );
+User::LeaveIfNull( parentFolder );
+CleanupStack::PushL( parentFolder );
 CFSMailMessage* newestMsg( NULL );
 TRAPD( notFoundError,
 newestMsg =
-NewestMsgInFolderL( aParentFolder ) );
+NewestMsgInFolderL( *parentFolder ) );
 if ( notFoundError == KErrNotFound )
 {
 // For some odd reason we are not able to get the newest
 // message from the folder. This should not be possible
 // as we just received notification of a new message.
 TTime dateOfNewest( newestMsg->GetDate() );
 delete newestMsg;
 newestMsg = NULL;
-TFSMailMsgId parentFolderId( aParentFolder.GetFolderId() );
+CleanupStack::PopAndDestroy( parentFolder );
-TInt index( 0 );
 const TInt entriesCount( aMsgIdList.Count() );
-while ( index < entriesCount )
+TInt index( entriesCount-1 );
+// go from back of list, as messages are coming from earliest to latest..
+while ( index >= 0 )
 {
 // Let's get the message. We need to check from it that
 // it is really unread. This info is stored in the
 // flags. Also check that the message is newest.
 // EFSMsgDataEnvelope is used as TFSMailDetails
 // so that we get enough data.
 CFSMailMessage*
 currentMessage( MailClient().GetMessageByUidL(
 aMailboxId,
-parentFolderId,
+aParentFolderId,
 aMsgIdList[index],
 EFSMsgDataEnvelope ) );
 User::LeaveIfNull( currentMessage );
 const TTime dateOfCurrentMsg( currentMessage->GetDate() );
 {
 // At least one of the messages is unread and newest.
 return ETrue;
 }
-++index;
+--index;
 }
 return EFalse;
 }
 parentFolderId = static_cast< TFSMailMsgId* >( aParam2 );
 if ( parentFolderId == NULL )
 {
 User::Leave( KErrArgument );
 }
-CFSMailFolder* parentFolder(
-MailClient().GetFolderByUidL( aMailbox, *parentFolderId ) );
-User::LeaveIfNull( parentFolder );
-CleanupStack::PushL( parentFolder );
 // Set the notification on only in cases that the new mail is
 // in folder of type EFSInbox
-if ( parentFolder->GetFolderType() == EFSInbox )
+if ( iOwner.GetFolderTypeL( aMailbox, parentFolderId ) == EFSInbox )
 {
 RArray<TFSMailMsgId>* newEntries(
 static_cast< RArray<TFSMailMsgId>* >( aParam1 ) );
-if ( MessagesCauseNotificationL(
+TInt count = newEntries->Count();
-aMailbox,
+for ( TInt i = 0; i<count;i++ )
-*parentFolder,
+{
-*newEntries ) )
+TFSMailMsgId msgId = newEntries->operator []( i );
+TNewMailInfo info( msgId, aMailbox, *parentFolderId );
+iNewInboxEntries.AppendL( info );
+}
+if (iTimer->IsActive() )
+{
+iTimer->Cancel();
+}
+iTimer->After( KTimerDelay );
+}
+else
+{
+// If messages are in some other folder than in inbox
+// they have no effect on the notification
+}
+}
+else
+{
+// No other events than new mail are handled. For example
+// moving of messages and changing message status has no
+// effect on the notification.
+}
+}
+void CFSNotificationHandlerBase::TimerExpiredL()
+{
+// process collected insert requests
+RArray<TFSMailMsgId> msgIds;
+TFSMailMsgId mailBoxId;
+TFSMailMsgId parentFolderId;
+for ( TInt i = 0; i< iNewInboxEntries.Count(); i++ )
+{
+TNewMailInfo& info = iNewInboxEntries[ i ];
+if ( mailBoxId.IsNullId() && parentFolderId.IsNullId() )
+{
+// starting new group is starting to collect
+mailBoxId = info.iMailBox;
+parentFolderId = info.iParentFolderId;
+}
+if ( mailBoxId == info.iMailBox && parentFolderId == info.iParentFolderId )
+{
+// collect message ids for the same mailbox and parent folder
+msgIds.Append( info.iMsgId );
+}
+else
+{
+// process collected message ids for the same mailbox and parent folder
+if ( msgIds.Count()&& MessagesCauseNotificationL( mailBoxId, parentFolderId, msgIds ) )
 {
 TurnNotificationOn();
 }
-}
+// clear data and start collecting again
-else
+msgIds.Reset();
-{
+mailBoxId = TFSMailMsgId();
-// If messages are in some other folder than in inbox
+parentFolderId = TFSMailMsgId();
-// they have no effect on the notification
+}
 }
-CleanupStack::PopAndDestroy( parentFolder );
+// process collected message ids for the same mailbox and parent folder
-}
+if ( msgIds.Count() && MessagesCauseNotificationL( mailBoxId, parentFolderId, msgIds ) )
-else
+{
-{
+TurnNotificationOn();
-// No other events than new mail are handled. For example
+}
-// moving of messages and changing message status has no
+// clear processed entries
-// effect on the notification.
+msgIds.Reset();
-}
+iNewInboxEntries.Reset();
 }
 CFSMailMessage* CFSNotificationHandlerBase::NewestMsgInFolderL(
-/*const*/ CFSMailFolder& aFolder ) const
+CFSMailFolder& aFolder ) const
 {
 FUNC_LOG;
 // Load info only necessary for sorting by date into the messages.
 TFSMailDetails details( EFSMsgDataDate );
 criteriaDate.iOrder = EFSMailDescending;
 RArray<TFSMailSortCriteria> sorting;
 CleanupClosePushL( sorting );
 // First criteria appended would be the primary criteria
-// but here we don't have any other criterias
+// but here we don't have any other criteria
 sorting.Append( criteriaDate );
 MFSMailIterator* iterator = aFolder.ListMessagesL( details, sorting );
-// Resetting array of sort criterias already here because
+// Resetting array of sort criteria already here because
 // the iterator does not need it anymore.
 CleanupStack::PopAndDestroy(); // sorting
 // CleanupStack::PushL doesn't work for M-class
 CleanupDeletePushL( iterator );
 CleanupStack::PopAndDestroy(); // messages
 CleanupStack::PopAndDestroy( iterator );
 return outcome;
 }
+CNewMailNotificationTimer::CNewMailNotificationTimer( MFSTimerObserver& aObserver ) :
+CTimer( EPriorityIdle ), iObserver( aObserver )
+{
+FUNC_LOG;
+}
+void CNewMailNotificationTimer::ConstructL()
+{
+FUNC_LOG;
+CTimer::ConstructL();
+CActiveScheduler::Add( this );
+}
+CNewMailNotificationTimer* CNewMailNotificationTimer::NewL(
+MFSTimerObserver& aObserver )
+{
+FUNC_LOG;
+CNewMailNotificationTimer* self =
+new( ELeave ) CNewMailNotificationTimer( aObserver );
+CleanupStack::PushL( self );
+self->ConstructL();
+CleanupStack::Pop( self );
+return self;
+}
+CNewMailNotificationTimer::~CNewMailNotificationTimer()
+{
+FUNC_LOG;
+Cancel();
+}
+void CNewMailNotificationTimer::DoCancel()
+{
+FUNC_LOG;
+// Cancel Base class
+CTimer::DoCancel();
+}
+void CNewMailNotificationTimer::RunL()
+{
+FUNC_LOG;
+iObserver.TimerExpiredL();
+}
 void Panic( TCmailhandlerPanic aPanic )
 {
 _LIT( KPanicText, "emailhandlerplugin" );
 User::Panic( KPanicText, aPanic );
 }

branch	RCL_3
changeset 22	d620048b4810
parent 12	4ce476e64c59