diff -r 94dc1107e8b2 -r 40a3f856b14d phoneapp/phoneuistates/src/cphonesinglecall.cpp --- a/phoneapp/phoneuistates/src/cphonesinglecall.cpp Thu Jul 15 18:38:16 2010 +0300 +++ b/phoneapp/phoneuistates/src/cphonesinglecall.cpp Thu Aug 19 09:54:27 2010 +0300 @@ -122,7 +122,6 @@ // Update phone number availability for menu use PhoneNumberAvailableInPhoneEngineL( callStateData.CallId() ); - } // ----------------------------------------------------------- @@ -229,7 +228,7 @@ break; case MEngineMonitor::EPEMessageDialing: - HandleDiallingL( aCallId ); + HandleDialingL( aCallId ); break; /* Flow through */ @@ -503,7 +502,9 @@ KPSUidScreenSaver, KScreenSaverAllowScreenSaver, EPhoneScreensaverNotAllowed ); - + IsNumberEntryUsedL() ? + BeginTransEffectLC( ECallUiAppear ) : + BeginTransEffectLC( ENumberEntryOpen ); BeginUiUpdateLC(); // Hide the number entry if it exists @@ -519,7 +520,7 @@ AllowShowingOfWaitingCallHeaderL( dialerParam ); // Close fast swap window if it's displayed - CEikonEnv::Static()->DismissTaskList(); + EikonEnv()->DismissTaskList(); // Show incoming call buttons SetTouchPaneButtons( EPhoneWaitingCallButtons ); @@ -528,15 +529,13 @@ DisplayIncomingCallL( aCallId, dialerParam ); EndUiUpdate(); - + EndTransEffect(); // This query is required to dismiss // Operation cannot be completed in waiting and single state if ( iSwitchToVideoQuery ) { iViewCommandHandle->ExecuteCommandL( EPhoneViewRemoveQuery ); } - - // Go to incoming state UpdateCbaL( EPhoneCallHandlingCallWaitingCBA ); iStateMachine->ChangeState( EPhoneStateWaitingInSingle ); } @@ -547,7 +546,7 @@ // void CPhoneSingleCall::DisplayIncomingCallL( TInt aCallId, - const TPhoneCmdParamBoolean aCommandParam ) + const TPhoneCmdParamBoolean /*aCommandParam*/ ) { __LOGMETHODSTARTEND( EPhoneUIStates, "CPhoneSingleCall::DisplayIncomingCallL()"); @@ -565,12 +564,8 @@ // Indicate that the Phone needs to be sent to the background if // an application other than the top application is in the foreground - TPhoneCmdParamBoolean booleanParam; - booleanParam.SetBoolean( !TopAppIsDisplayedL() ); - iViewCommandHandle->ExecuteCommandL( - EPhoneViewSetNeedToReturnToForegroundAppStatus, - &booleanParam ); - + SetNeedToReturnToForegroundAppStatusL( !TopAppIsDisplayedL() ); + // Bring Phone app in the foreground TPhoneCmdParamInteger uidParam; uidParam.SetInteger( KUidPhoneApplication.iUid ); @@ -610,61 +605,31 @@ } // ----------------------------------------------------------- -// CPhoneSingleCall::HandleDiallingL +// CPhoneSingleCall::HandleDialingL // ----------------------------------------------------------- // -void CPhoneSingleCall::HandleDiallingL( TInt aCallId ) +void CPhoneSingleCall::HandleDialingL( TInt aCallId ) { __LOGMETHODSTARTEND( EPhoneUIStates, - "CPhoneSingleCall::HandleDiallingL()"); + "CPhoneSingleCall::HandleDialingL()"); CPhonePubSubProxy::Instance()->ChangePropertyValue( KPSUidScreenSaver, KScreenSaverAllowScreenSaver, EPhoneScreensaverNotAllowed ); - - BeginUiUpdateLC(); - - SetNumberEntryVisibilityL(EFalse); - - // Show incoming call buttons - SetTouchPaneButtons( EPhoneCallSetupAndSingleButtons ); - // Display call setup DisplayCallSetupL( aCallId ); - - EndUiUpdate(); - - // Go to call setup state - UpdateCbaL( EPhoneCallHandlingCallSetupCBA ); iStateMachine->ChangeState( EPhoneStateCallSetupInSingle ); } - + // ----------------------------------------------------------- -// CPhoneSingleCall::DisplayCallSetupL +// CPhoneSingleCall::DoStateSpecificCallSetUpDefinitionsL // ----------------------------------------------------------- // -void CPhoneSingleCall::DisplayCallSetupL( TInt aCallId ) +EXPORT_C void CPhoneSingleCall::DoStateSpecificCallSetUpDefinitionsL() { - __LOGMETHODSTARTEND( EPhoneUIStates, - "CPhoneSingleCall::DisplayCallSetupL()"); - // Close menu bar, if it is displayed - iViewCommandHandle->ExecuteCommandL( EPhoneViewMenuBarClose ); - - // Remove dialogs if necessary - iViewCommandHandle->ExecuteCommandL( EPhoneViewRemovePhoneDialogs ); - - // Capture keys when the phone is dialling - CaptureKeysDuringCallNotificationL( ETrue ); - - // Force telephony to the foreground - TPhoneCmdParamInteger uidParam; - uidParam.SetInteger( KUidPhoneApplication.iUid ); - iViewCommandHandle->ExecuteCommandL( EPhoneViewBringAppToForeground, - &uidParam ); - - // Display call setup header - DisplayHeaderForOutgoingCallL( aCallId ); + // Show incoming call buttons + SetTouchPaneButtons( EPhoneCallSetupAndSingleButtons ); } // -----------------------------------------------------------