2005-12-17  Maciej Stachowiak  <mjs@apple.com>

        Rubber stamped by Eric.

        - removed unused SPI headers

        * WebCore.xcodeproj/project.pbxproj:

        * kwq/DOM-compat.h: Removed.

2005-12-18  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - fix http://bugs.webkit.org/show_bug.cgi?id=6144

          REGRESSION: DOMStringImpl leak in code to make DOMString from NSString

        * kwq/DOMInternal.mm: (DOMString::DOMString): Remove now-unneeded ref.

2005-12-18  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - fix http://bugs.webkit.org/show_bug.cgi?id=5680

          containsOnlyWhitespace does not need to be a virtual function

        * khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): Cast

        pointer to a TextImpl before calling containsOnlyWhitespace; the code already

        checked isTextNode.

        * khtml/rendering/render_line.cpp: (khtml::shouldDrawDecoration): Expanded an

        if statement into a few separate ones for slight additional clarity. Added a

        check of isTextNode and cast pointer to a TextImpl.

        * khtml/xml/dom_nodeimpl.h: Remove containsOnlyWhitespace function.

        * khtml/xml/dom_textimpl.h: Remove virtual keyword from containsOnlyWhitespace.

2005-12-18  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed by Hyatt, landed by Darin.

        Test: fast/text/international/bidi-ignored-for-first-child-inline.html

        Fix for: http://bugs.webkit.org/show_bug.cgi?id=5980

        Bidi properties of an inline container whose first child is an

        inline container are ignored

        * khtml/rendering/bidi.cpp:

        (khtml::RenderBlock::bidiNext):

        Adjust embedding at inline containers' boundaries instead of inside.

        (khtml::RenderBlock::bidiFirst):

        (khtml::RenderBlock::determineStartPosition):

2005-12-18  Alexey Proskuryakov  <ap@nypop.com>

        Reviewed and landed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=5932

          Wrong encoding used for http://www.miel.ru

        * kwq/KWQCharsets.mm: (KWQCFStringEncodingFromIANACharsetName):

        Fall back on ICU encoding names if we don't find the name in the WebCore

        encoding names table.

2005-12-18  Alexey Proskuryakov  <ap@nypop.com>

        Reviewed and landed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=5927

          Result of XSLT transformation has no charset defined

        * khtml/xml/dom_docimpl.cpp: (DocumentImpl::applyXSLTransform):

        Get encoding from transform and pass in to XSLTProcessor.

        * khtml/xsl/xslt_processorimpl.h:

        * khtml/xsl/xslt_processorimpl.cpp:

        (DOM::XSLTProcessorImpl::createDocumentFromSource): Added encoding parameter.

        Create a Decoder and use it to decode the source document (default encoding UTF-8).

        (DOM::XSLTProcessorImpl::transformToString): Add an encoding result. Set it to the

        encoding from the libxml2 document object.

        (DOM::XSLTProcessorImpl::transformToDocument): Get encoding from transform and pass

        in to XSLTProcessor.

        (DOM::XSLTProcessorImpl::transformToFragment): Ditto.

2005-12-18  Alexey Proskuryakov  <ap@nypop.com>

        Reviewed by Eric, landed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=5631

          KWQKHTMLPart::attributedString ignores many tags

        * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):

        Fix incorrectly nested else.

2005-12-17  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed and landed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=5768

          pages with frames that are all "fixed" get no layout and are blank (like www.farnell.nl)

        * khtml/rendering/render_frames.cpp: (RenderFrameSet::layout):

        * manual-tests/bugzilla-5768.html: Added. Can't seem to get it to work (fail) as an automated test.

        * manual-tests/resources/frame1.html: Added.

        * manual-tests/resources/frame2.html: Added.

2005-12-17  Anders Carlsson  <andersca@mac.com>

        Reviewed by Darin.

        - Fix <http://bugs.webkit.org/show_bug.cgi?id=6120>

        Random crashes when running the test suite

        * khtml/css/css_ruleimpl.h:

        (DOM::CSSMediaRuleImpl::media):

        Make m_lstMedia a smart pointer.

2005-12-17  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed and landed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=5479

          Can't select text with RTL override rendered by ATSUI

        * khtml/rendering/font.h: Remove reversed parameter from checkSelectionPoint, replacing

        it with a text direction parameter.

        * khtml/rendering/render_text.cpp: (InlineTextBox::offsetForPosition): Ditto.

        * kwq/KWQFontMetrics.h: Add a directional override parameter to checkSelectionPoint.

        * kwq/KWQFontMetrics.mm: (QFontMetrics::checkSelectionPoint): Pass the directional override

        through to the text renderer. Don't pass the reversed flag redundantly -- use the rtl flag

        in the style instead.

        * kwq/WebCoreTextRenderer.h: Remove reversed parameter from pointToOffset.

2005-12-16  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        DOMString should hold its impl in a RefPtr

        http://bugs.webkit.org/show_bug.cgi?id=6106

        I also cleaned up spacing in dom_string.cpp

        No tests needed (no functionality changes).

        * khtml/dom/dom_string.cpp:

        (DOM::DOMString::DOMString):

        (DOM::DOMString::operator += ):

        (DOM::DOMString::insert):

        (DOM::DOMString::operator []):

        (DOM::DOMString::find):

        (DOM::DOMString::length):

        (DOM::DOMString::truncate):

        (DOM::DOMString::remove):

        (DOM::DOMString::split):

        (DOM::DOMString::lower):

        (DOM::DOMString::upper):

        (DOM::DOMString::percentage):

        (DOM::DOMString::unicode):

        (DOM::DOMString::qstring):

        (DOM::DOMString::toInt):

        (DOM::DOMString::copy):

        (DOM::strcasecmp):

        (DOM::DOMString::toCoordsArray):

        (DOM::DOMString::toLengthArray):

        (DOM::operator==):

        * khtml/dom/dom_string.h:

        (DOM::DOMString::DOMString):

        (DOM::DOMString::impl):

2005-12-16  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        XSLTProcessorImpl should use RefPtr instead of manual ref/deref

        http://bugs.webkit.org/show_bug.cgi?id=6110

        No test cases needed (no functionality changes).

        * khtml/xsl/xsl_stylesheetimpl.cpp:

        (DOM::XSLImportRuleImpl::XSLImportRuleImpl):

        (DOM::XSLImportRuleImpl::~XSLImportRuleImpl):

        (DOM::XSLImportRuleImpl::setStyleSheet):

        * khtml/xsl/xsl_stylesheetimpl.h:

        (DOM::XSLImportRuleImpl::styleSheet):

2005-12-16  Adele Peterson  <adele@apple.com>

        Reviewed by Maciej.

        Fix for <rdar://problem/4381546> Safari crash at www.dallascowboys.com in KWQListIteratorImpl::current()

        * khtml/khtml_part.cpp:

        (KHTMLPart::slotFinishedParsing): ref the part before calling checkCompleted.

2005-12-16  Vicki Murley  <vicki@apple.com>

        Reviewed by Tim O.

	- fix <rdar://problem/4380428> window.onbeforeunload works on IE but not on Safari

        * khtml/ecma/kjs_window.cpp:

2005-12-16  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Eric.

        Fixed http://bugs.webkit.org/show_bug.cgi?id=6112

        REGRESSION: navigator.plugins empty.

        Layout test added:

        * fast/js/Plug-ins-expected.checksum: Added.

        * fast/js/Plug-ins-expected.png: Added.

        * fast/js/Plug-ins-expected.txt: Added.

        * fast/js/Plug-ins.html: Added.

        * khtml/ecma/kjs_navigator.cpp:

        (KJS::PluginBase::PluginBase): Changed initialization of KConfig from

        empty string to pluginsinfo.

2005-12-16  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed and landed by Darin.

        Test: fast/text/international/bidi-european-terminators.html

        Fix for: http://bugs.webkit.org/show_bug.cgi?id=6014

        Bidi algorithm: incorrect resolved levels for neutrals between R and

        ET ON L

        * khtml/rendering/bidi.cpp:

        (khtml::RenderBlock::bidiReorderLine):

        Keep track of the last position before the current run of ETs directly

        using a new BidiState member, lastBeforeET.

2005-12-16  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed and landed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=5486

          DumpRenderTree should print the RTL and directional override flags for text runs

        * kwq/KWQRenderTreeDebug.cpp: (writeTextRun): Dump the additional flags.

2005-12-16  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed and landed by Darin.

        Fix for: http://bugs.webkit.org/show_bug.cgi?id=6043

        Incorrect selection highlighting in pre-formatted text with tabs

        * khtml/rendering/render_text.cpp: Correct parameters in calls to RenderText::width().

        (InlineTextBox::selectionRect):

        (InlineTextBox::placeEllipsisBox):

        (InlineTextBox::paintDecoration):

        (InlineTextBox::paintMarker):

        (InlineTextBox::paintMarkedTextUnderline):

        * manual-tests/pre-tab-selection-rect.html: Added.

2005-12-16  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed and landed by Darin.

        Test: fast/js/replace-child-siblings.html

        Fix for: http://bugs.webkit.org/show_bug.cgi?id=6069

        Assertion failure in RenderBlock::addChildToFlow during replaceChild

        * khtml/xml/dom_nodeimpl.cpp:

        (DOM::ContainerNodeImpl::replaceChild): If the new child was right

        before or right after the old child, then it just stays.

2005-12-15  Darin Adler  <darin@apple.com>

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=5688

          speed up JavaScript parsing by not creating a UString just to parse

        * khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getListener): Use listenerObj instead of

        listenerObjImp.

        * khtml/ecma/kjs_html.cpp: (KJS::Image::getValueProperty): Ditto.

        * khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): Ditto.

        * khtml/ecma/kjs_window.h:

        * khtml/ecma/kjs_window.cpp:

        (KJS::Window::getListener): Ditto.

        (KJS::Window::getJSLazyEventListener): Take code as a DOMString, not QString.

        * khtml/ecma/kjs_events.cpp:

        (KJS::jsStringOrUndefined): Renamed function and moved it to the top of the file.

        (KJS::JSAbstractEventListener::handleEvent): Cleaned up function, removed double

        logging, and fixed code path to not use UString::ascii().

        (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): Updated since type

        of the window object is now Window.

        (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): Ditto.

        (KJS::JSUnprotectedEventListener::windowObj): Ditto.

        (KJS::JSEventListener::JSEventListener): Ditto.

        (KJS::JSEventListener::~JSEventListener): Ditto.

        (KJS::JSEventListener::windowObj): Ditto.

        (KJS::JSLazyEventListener::JSLazyEventListener): Ditto. Also changed code to be

        a DOMString instead of a QString.

        (KJS::JSLazyEventListener::handleEvent): Removed function because the base class

        handleEvent already calls listenerObj which takes care of parseCode -- no need to

        do an additional parseCode here.

        (KJS::JSLazyEventListener::parseCode): Rearrange and clean up a bit. Code is now

        a DOMString instead of a QString.

        (KJS::Clipboard::Clipboard): Remove explicit ref since we now use a RefPtr for

        the clipboard object.

        (KJS::Clipboard::getValueProperty): Update to call jsStringOrUndefined.

        * khtml/ecma/kjs_events.h: Reformatted the file. Changed windowObj functions to

        return Window* instead of ObjectImp*. Removed listenerObjImp function. Removed

        destructors from many classes that don't need them. Used a RefPtr for the

        ClipboardImpl in a Clipboard object.

        * khtml/ecma/kjs_proxy.h:

        * khtml/ecma/kjs_proxy.cpp:

        (KJSProxyImpl::evaluate): Take filename and code as DOMString instead of QString.

        (KJSProxyImpl::createHTMLEventHandler): Take URL and code as DOMString.

        * khtml/xml/dom_docimpl.h:

        * khtml/xml/dom_docimpl.cpp:

        (DocumentImpl::createHTMLEventListener): Take a DOMString rather than a QString for the

        JavaScript code.

        (DocumentImpl::setHTMLWindowEventListener): Added an overload that takes an attribute

        pointer. Calls through after extracting the code from the attribute value.

        * khtml/html/html_elementimpl.h:

        * khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setHTMLEventListener): New

        version of function that takes an attribute pointer; calls through to the base class

        after extracting the code from the attribute value.

        * khtml/html/html_baseimpl.cpp:

        (HTMLBodyElementImpl::parseMappedAttribute): Change to use new setHTMLWindowEventListener

        and setHTMLEventListener that takes an attribute pointer.

        (HTMLFrameElementImpl::parseMappedAttribute): Ditto.

        (HTMLFrameSetElementImpl::parseMappedAttribute): Ditto.

        * khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Ditto.

        * khtml/html/html_formimpl.cpp:

        (DOM::HTMLFormElementImpl::parseMappedAttribute): Ditto.

        (DOM::HTMLButtonElementImpl::parseMappedAttribute): Ditto.

        (DOM::HTMLInputElementImpl::parseMappedAttribute): Ditto.

        (DOM::HTMLLabelElementImpl::parseMappedAttribute): Ditto.

        (DOM::HTMLSelectElementImpl::parseMappedAttribute): Ditto.

        (DOM::HTMLTextAreaElementImpl::parseMappedAttribute): Ditto.

        * khtml/html/html_imageimpl.cpp:

        (DOM::HTMLImageElementImpl::parseMappedAttribute): Ditto.

        * khtml/html/html_objectimpl.cpp:

        (DOM::HTMLObjectElementImpl::parseMappedAttribute): Ditto.

        * khtml/html/html_headimpl.h:

        * khtml/html/html_headimpl.cpp:

        (HTMLScriptElementImpl::notifyFinished): Don't convert URL to QString since we now take

        a DOMString.

        (HTMLScriptElementImpl::evaluateScript): Change to take script as a DOMString.

        * khtml/khtml_part.h:

        * khtml/khtml_part.cpp: (KHTMLPart::createHTMLEventListener): Take a DOMString rather than

        a QString for the JavaScript code.

        * kwq/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]): Change

        code path so it doesn't convert an NSString to UTF-8 to get it into the JavaScript

        machinery. Use QString::fromNSString instead for now.

2005-12-15  Darin Adler  <darin@apple.com>

        - fix crash caused by my last check-in

        * khtml/ecma/domparser.cpp: (KJS::DOMParserProtoFunc::callAsFunction):

        Use RefPtr to ref/deref the tokenizer.

2005-12-15  Darin Adler  <darin@apple.com>

        * khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::exitText):

        Add missing null check.

2005-12-15  Geoffrey Garen  <ggaren@apple.com>

        Fixed <rdar://problem/4381444> Remove GMail-specific work-around 

        previously added.

        Reviewed by Darin.

        No test case because this patch just turns on already-tested behavior

        for GMail.

        * khtml/ecma/kjs_html.cpp:

        (KJS::HTMLElement::textAreaGetter): Removed code that hid the

        selectionEnd property from sites on the GMail domain.

2005-12-15  Darin Adler  <darin@apple.com>

        Reviewed by Eric.

        - fix http://bugs.webkit.org/show_bug.cgi?id=6092

          REGRESSION: dom/xhtml/level2/html//HTMLInputElement01.xhtml crashes

        * khtml/xml/xml_tokenizer.cpp:

        (khtml::XMLTokenizer::XMLTokenizer): Initialize the new m_currentNodeIsReferenced

        field to false for the document case, and true for the non-0 fragment case. Also

        don't reference the document in the document tokenizer case to avoid a circular

        reference -- HTML parser already does both of these things.

        (khtml::XMLTokenizer::~XMLTokenizer): Call setCurrentNode(0) to release the current

        node in case the tokenizer is being destroyed without finishing parsing. Only call

        deref on the document inthe fragment-parsing case.

        (khtml::XMLTokenizer::setCurrentNode): Added. Reference the current node only if

        it's not the document. Just as with the HTML parser, use a boolean to track whether

        the current node needs a deref or not.

        (khtml::XMLTokenizer::startElementNs): Use a RefPtr to keep the newly created element

        alive at least until setCurrentNode is called. Remove the bogus explicit delete of

        of the node after calling addChild, since reference counting takes care of it.

        Stop parsing if we fail to create an element.

        (khtml::XMLTokenizer::endElementNs): Use setCurrentNode and use a local variable

        to avoid reference count thrash.

        (khtml::XMLTokenizer::characters): Changed to only support text nodes. CDATA no

        longer calls this function. 

        (khtml::XMLTokenizer::enterText): Use setCurrentNode, and remove bogus delete call. 

        (khtml::XMLTokenizer::exitText): Add checks for stopped parser and for whether

        the current node is a text node so this can be called unconditionally.

        (khtml::XMLTokenizer::cdataBlock): Use setCurrentNode and move the call before the

        call to attach to make sure the node is already ref'd when attach is called.

        (khtml::XMLTokenizer::finish): Call setCurrentNode(0) to release the nodes we've

        been parsing.

        (khtml::XMLTokenizer::executeScripts): Fixed incorrect cast to TextImpl to cast to

        the base class CharacterDataImpl instead.

2005-12-15  Eric Seidel  <eseidel@apple.com>

        Reviewed by Tim Hatcher.

	Made SVG on by default!

        Also removed last two KHTML_NO_CPLUSPLUS_DOM #ifs and turned off.

        Removed APPLE_COMPILE_HACK, fixing or replacing with #if 0 for now.

        * WebCore.xcodeproj/project.pbxproj: Made SVG default!

        * ksvg2/KSVGSettings.cpp: Removed.

        * ksvg2/css/SVGCSSStyleSelector.cpp: fixed copyright.

        * ksvg2/svg/SVGCursorElementImpl.cpp:

        (SVGCursorElementImpl::notifyFinished): fixed

        * ksvg2/svg/SVGElementImpl.cpp:

        (SVGElementImpl::parseMappedAttribute): removed dead code.

        * ksvg2/svg/SVGImageElementImpl.cpp:

        (SVGImageElementImpl::createRenderer): #if 0

        (SVGImageElementImpl::notifyFinished): #if 0

        * ksvg2/svg/SVGSVGElementImpl.cpp:

        (SVGSVGElementImpl::pixelUnitToMillimeterX): #if 0

        (SVGSVGElementImpl::pixelUnitToMillimeterY): #if 0

        * kwq/DOM.mm: removed KHTML_NO_CPLUSPLUS_DOM

        (ObjCNodeFilterCondition::acceptNode):

        * kwq/KWQKHTMLPart.mm: removed KHTML_NO_CPLUSPLUS_DOM

2005-12-15  Eric Seidel  <eseidel@apple.com>

	Fix build break.  (Files missed in previous commit.)

        * khtml/css/csshelper.cpp:

        * khtml/ecma/kjs_navigator.cpp:

        * khtml/rendering/render_canvasimage.cpp:

        * khtml/rendering/render_image.cpp:

2005-12-15  Adele Peterson  <adele@apple.com>

        Reviewed by John.

        - Fix for <rdar://problem/4258232> Crash in HTMLOptionElementImpl::index when option element has no corresponding select - http://www.mattkruse.com/javascript/datadumper/

        Test: fast/forms/option-index.html

        * khtml/html/html_formimpl.cpp:

        (DOM::HTMLOptionElementImpl::index): nil check for select element.

2005-12-15  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        Remove more legacy code from khtml/kwq

        http://bugs.webkit.org/show_bug.cgi?id=6091

        No tests needed, no functionality changes.

        * ForwardingHeaders/kapplication.h: Removed.

        * ForwardingHeaders/kcompletionbox.h: Removed.

        * ForwardingHeaders/kdatastream.h: Removed.

        * ForwardingHeaders/kfiledialog.h: Removed.

        * ForwardingHeaders/kfileitem.h: Removed.

        * ForwardingHeaders/khtml_iface.h: Removed.

        * ForwardingHeaders/khtml_pagecache.h: Removed.

        * ForwardingHeaders/khtml_printsettings.h: Removed.

        * ForwardingHeaders/khtml_run.h: Removed.

        * ForwardingHeaders/kiconloader.h: Removed.

        * ForwardingHeaders/kio/kprotocolmanager.h: Removed.

        * ForwardingHeaders/kio/netaccess.h: Removed.

        * ForwardingHeaders/kmessagebox.h: Removed.

        * ForwardingHeaders/kmimetype.h: Removed.

        * ForwardingHeaders/kmultipledrag.h: Removed.

        * ForwardingHeaders/kparts/partmanager.h: Removed.

        * ForwardingHeaders/kprinter.h: Removed.

        * ForwardingHeaders/kprotocolmanager.h: Removed.

        * ForwardingHeaders/ksimpleconfig.h: Removed.

        * ForwardingHeaders/ksslcertchain.h: Removed.

        * ForwardingHeaders/ksslinfodlg.h: Removed.

        * ForwardingHeaders/kstdaction.h: Removed.

        * ForwardingHeaders/ktempfile.h: Removed.

        * ForwardingHeaders/ktrader.h: Removed.

        * ForwardingHeaders/kurldrag.h: Removed.

        * ForwardingHeaders/kxmlguifactory.h: Removed.

        * ForwardingHeaders/netaccess.h: Removed.

        * ForwardingHeaders/private/qucomextra_p.h: Removed.

        * ForwardingHeaders/qasyncimageio.h: Removed.

        * ForwardingHeaders/qbitmap.h: Removed.

        * ForwardingHeaders/qclipboard.h: Removed.

        * ForwardingHeaders/qdir.h: Removed.

        * ForwardingHeaders/qdrawutil.h: Removed.

        * ForwardingHeaders/qfontdatabase.h: Removed.

        * ForwardingHeaders/qfontinfo.h: Removed.

        * ForwardingHeaders/qglobal.h: Removed.

        * ForwardingHeaders/qhbox.h: Removed.

        * ForwardingHeaders/qinputdialog.h: Removed.

        * ForwardingHeaders/qintcache.h: Removed.

        * ForwardingHeaders/qmetaobject.h: Removed.

        * ForwardingHeaders/qmovie.h: Removed.

        * ForwardingHeaders/qobjectlist.h: Removed.

        * ForwardingHeaders/qtooltip.h: Removed.

        * ForwardingHeaders/scheduler.h: Removed.

        * WebCore.xcodeproj/project.pbxproj:

        * khtml/css/cssstyleselector.cpp:

        * khtml/ecma/kjs_proxy.cpp:

        (KJSProxyImpl::KJSProxyImpl):

        (KJSProxyImpl::initScript):

        * khtml/ecma/kjs_window.cpp:

        * khtml/ecma/kjs_window.moc: Removed.

        * khtml/html/html_documentimpl.cpp:

        (DOM::HTMLDocumentImpl::HTMLDocumentImpl):

        * khtml/html/html_documentimpl.moc: Removed.