2002-12-03  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by: Darin Adler

	- fixed Deployment build.

        * kjs/dtoa.cpp: Work around warnings.

2002-12-03  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3114790 - Gamespot reviews pages badly mis-rendering

	because floating point numbers format wide

	Reviewed by: David Hyatt

	* kjs/dtoa.cpp: Imported float <--> string conversion routines

	from David M. Gay. I changed this to fix warnings and avoid

	colliding with names of standard library functions.

        * kjs/dtoa.h: Added a header I made up for dtoa.cpp

        * kjs/ustring.cpp:

        (UString::from): Use new double to string routine (kjs_strtod).

        (UString::toDouble): Use new string to double routine (kjs_dtoa).

        * JavaScriptCore.pbproj/project.pbxproj: Added new files

2002-11-27  John Sullivan  <sullivan@apple.com>

        * kjs/collector.cpp:

	removed puts("COLLECT") leftover debugging spam that was

	buggin' gramps

=== Alexander-34 ===

2002-11-26  Maciej Stachowiak  <mjs@apple.com>

	Change ActivationImp to be allocated via the garbage collector

	again instead of on the stack. This fixes the following four

	regressions but sadly it causes a 6% performance hit. It's

	probably possibly to reduce the hit a bit by being smarter about

	inlining and the way the marking list variant is implemented, but

	I'll look into that later.

	- fixed 3111500 - REGRESSION: crash in "KJS::ScopeChain::mark()" on www.posci.com

	- fixed 3111145 - REGRESSION: reproducible crash in KJS hashtable lookup at time.com

	- fixed 3110897 - REGRESSION: javascript crasher on http://bmwgallery.tripod.com/

	- fixed 3109987 - REGRESSION: Reproducible crash in KJS ObjectImp at live365.com

	Also:

	- improved DEBUG_COLLECTOR mode a bit by never giving memory back

	to the system.

        * kjs/collector.cpp:

        * kjs/context.h:

        * kjs/function.cpp:

        (ActivationImp::ActivationImp):

        (ActivationImp::mark):

        (ActivationImp::createArgumentsObject):

        * kjs/function.h:

        * kjs/internal.cpp:

        (ContextImp::ContextImp):

        (ContextImp::mark):

        * kjs/list.cpp:

        * kjs/list.h:

        * kjs/value.cpp:

        (Value::Value):

2002-11-26  Darin Adler  <darin@apple.com>

        * kjs/property_map.cpp:

	(PropertyMap::save): Look at the attributes the same way in the single hash entry

	case as in the actual hash table case. Change the rule for which attributes to save

	to "attributes that don't have the ReadOnly, DontEnum, or Function bit set".

        Also fix bug where saving an empty property map would leave the count set to the old value.

2002-11-26  Richard Williamson   <rjw@apple.com>

        Remove debugging code.  Could be cause of performance regresssion.

        * kjs/nodes.cpp:

        (FunctionCallNode::evaluate):

        Restire attributes correctly.

        * kjs/property_map.cpp:

2002-11-25  Richard Williamson   <rjw@apple.com>

        Use delete[] (not delete) operator to delete array.

        * kjs/property_map.cpp:

2002-11-25  Richard Williamson   <rjw@apple.com>

        Added debugging info.  Fixed property map save function.

        * kjs/nodes.cpp:

        (FunctionCallNode::evaluate):

        * kjs/property_map.cpp:

2002-11-25  Richard Williamson   <rjw@apple.com>

        Changes for back/forward.  Currently disabled.

        * kjs/property_map.cpp:

        * kjs/property_map.h:

2002-11-25  Darin Adler  <darin@apple.com>

        * kjs/property_map.cpp: Rearrange code a little bit and tweak indentation.

	This might provide a tiny speedup because we don't look at the single entry

	any more in cases where the _table pointer is non-0.

2002-11-24  Darin Adler  <darin@apple.com>

	- changed ScopeChain to not ref each item in the chain, and use

        marking instead; gains 1% on JavaScript iBench

        * kjs/context.h: Return chain by reference.

        * kjs/internal.cpp: (ContextImp::mark): Mark the scope chain.

        * kjs/interpreter.cpp: (Context::scopeChain): Return chain by reference.

        * kjs/interpreter.h: Make some Context methods inline.

        * kjs/nodes.cpp:

        (ThisNode::evaluate): Get at ContextImp directly.

        (ResolveNode::evaluateReference): Ditto.

        (VarDeclNode::evaluate): Ditto.

        (VarDeclNode::processVarDecls): Ditto.

        (FuncDeclNode::processFuncDecl): Pass ScopeChain directly to avoid copying.

        (FuncExprNode::evaluate): Ditto.

        * kjs/object.cpp: Make scope and setScope inline.

        * kjs/object.h: Make scope return a chain by reference. Make scope and

	setScope both be inline. Use a normal ScopeChain instead of NoRefScopeChain

	since they are now one and the same.

        * kjs/scope_chain.cpp: Remove all the code to ref and deref objects.

	Merge NoRefScopeChain in with ScopeChain since they both work this way now.

        * kjs/scope_chain.h: Remove NoRefScopeChain and simplify the ref counts.

	Make more functions inline.

2002-11-24  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3098356 - Hard hang on movie search at www.movietickets.com

        * kjs/string_object.cpp:

        (StringProtoFuncImp::call): When doing a regexp replacement that

	results in an empty match, always move on to the next character

	after doing the replacement. The previous code would hit an

	infinite loop if an initial empty match was replaced with the

	empty string.

2002-11-24  Maciej Stachowiak  <mjs@apple.com>

	- fixed 3095446 - Crash on AppleScript page due to very long argument list

        * kjs/grammar.y: Don't try to construct the argument list in the

	right order, since that blows out the parser stack.

	* kjs/nodes.cpp:

        (ArgumentsNode::ArgumentsNode): Instead reverse the argument list

	here.

        * kjs/nodes.h: Make ArgumentsNode a friend of ArgumentListNode.

        * kjs/grammar.cpp: Updated from grammar.y.

2002-11-23  Maciej Stachowiak  <mjs@apple.com>

	- completed Darin's mostly-fix for 3037795 - Resource use

	increases when accessing very high index value in array

	The two missing pieces were handling sparse properties when

	shrinking the array, and when sorting. Thse are now both taken

	care of.

        * kjs/array_instance.h:

        * kjs/array_object.cpp:

        (ArrayInstanceImp::put):

        (ArrayInstanceImp::deleteProperty):

        (ArrayInstanceImp::resizeStorage):

        (ArrayInstanceImp::setLength):

        (ArrayInstanceImp::sort):

        (ArrayInstanceImp::pushUndefinedObjectsToEnd):

        * kjs/identifier.h:

        * kjs/object.h:

        * kjs/property_map.cpp:

        * kjs/property_map.h:

        * kjs/reference_list.cpp:

        (ReferenceList::append):

        (ReferenceList::length):

        * kjs/reference_list.h:

        * kjs/ustring.cpp:

        (UString::toUInt32):

        * kjs/ustring.h:

2002-11-23  Maciej Stachowiak  <mjs@apple.com>

	Numerous collector changes for a net gain of 3% on JS ibench:

	- Replaced per-block bitmap with free list.

	- Increased number of empty blocks kept around to 2.

	- Doubled block size.

	- When scanning heap in collector, skip scanning the rest of a

	block as soon as we see as many live cells as the the number of

	used cells it had originally.

	Also the following collector changes unrelated to performance:

	- Made constants `const int' instead of `static const int'.

	- Miscellaneous code cleanup.

        * kjs/collector.cpp:

	- Added debugging mode enabled by defining DEBUG_GC which asserts

	when a destroyed ValueImp

        * kjs/internal.cpp:

        (ContextImp::mark):

        * kjs/value.cpp:

        (Value::Value):

        * kjs/value.h:

	* kjs/config.h:

2002-11-22  Darin Adler  <darin@apple.com>

	- replaced List class with a vector rather than a linked list, changed it

	to use a pool of instances instead of all the nodes allocated off of the

	heap; gives 10% gain on iBench

        * kjs/list.h: Complete rewrite.

        * kjs/list.cpp: Ditto.

        * kjs/array_object.cpp: (compareWithCompareFunctionForQSort): Go back to

	doing a clear and two appends here. Fast with the new list implementation.

        * kjs/collector.h: Remove _COLLECTOR hack and just make rootObjectClasses

	return a const void *.

        * kjs/collector.cpp: Remove _COLLECTOR hack, and various other minor tweaks.

2002-11-22  Darin Adler  <darin@apple.com>

	- prepare to reimplement KJS::List; move to its own file, add statistics

        * kjs/function_object.cpp: (FunctionProtoFuncImp::call): Use new copyTail()

	function rather than copy() and removeFirst().

        * kjs/identifier.cpp: Add statistics, off by default.

        * kjs/property_map.cpp: Add statistics, off by default.

        * kjs/list.cpp: Added. Moved code here. To be rewritten.

        * kjs/list.h: Added. Moved interface here. To be rewritten.

        * kjs/types.cpp: Removed.

        * kjs/types.h: Now just an empty header that includes other headers.

        * JavaScriptCore.pbproj/project.pbxproj: Add new files, rearrange.

2002-11-22  Maciej Stachowiak  <mjs@apple.com>

	- reduce cell size to 56 bytes from 64, now that nearly all

	objects fit in that size. .5% speed gain and probably some

	footprint gain.

        * kjs/collector.cpp: Change CELL_SIZE from 64 to 56.

2002-11-22  Darin Adler  <darin@apple.com>

	- change ScopeChain to be a singly linked list shares tails, gives 11% gain on iBench

        * kjs/context.h:

        (ContextImp::pushScope): Make inline, use push instead of prepend, and pass imp pointer.

        (ContextImp::popScope): Make inline, use pop instead of removeFirst.

        * kjs/function.cpp: (DeclaredFunctionImp::DeclaredFunctionImp): No need to copy.

        * kjs/function_object.cpp: (FunctionObjectImp::construct): Use push instead of

	prepend, and pass imp pointer.

        * kjs/internal.cpp: (ContextImp::ContextImp): Use clear, push instead of prepend,

	and pass imp pointers.

        * kjs/nodes.cpp: (ResolveNode::evaluateReference): Use isEmpty, pop, and top instead

	of ScopeChainIterator.

        * kjs/object.h: Change _scope to be a NoRefScopeChain.

        * kjs/object.cpp: No need to initialize _scope any more, since it's not a NoRefScopeChain.

        * kjs/scope_chain.h: Rewrite, different implementation and interface.

        * kjs/scope_chain.cpp: More of the same.

2002-11-22  Maciej Stachowiak  <mjs@apple.com>

	- a simple change for .4% gain on ibench - instead of unmarking

	all objects at the start of collection, instead unmark as part of

	the sweep phase

        * kjs/collector.cpp:

        (Collector::collect): Remove separate unmarking pass and instead

	unmark the objects that don't get collected during the sweep

	phase.

2002-11-21  Darin Adler  <darin@apple.com>

	- stop garbage collecting the ActivationImp objects, gets 3% on iBench

	- pave the way to separate the argument lists from scope chains

        * kjs/context.h: Added. Moved ContextImp here so it can use things defined

	in function.h

        * kjs/scope_chain.h: Added. Starting as a copy of List, to be improved.

        * kjs/scope_chain.cpp: Added. Starting as a copy of List, to be improved.

        * JavaScriptCore.pbproj/project.pbxproj: Rearranged things, added context.h.

        * kjs/function.cpp:

        (FunctionImp::call): Pass InterpreterImp, not ExecState, to ContextImp.

        (DeclaredFunctionImp::DeclaredFunctionImp): List -> ScopeChain.

        (ActivationImp::createArgumentsObject): ArgumentList -> List.

        (GlobalFuncImp::call): Pass InterpreterImp, not an ExecState, to ContextImp.

        * kjs/function.h: List -> ScopeChain.

        * kjs/function_object.cpp: (FunctionObjectImp::construct): List -> ScopeChain.

        * kjs/internal.cpp:

        (ContextImp::ContextImp): Set the context in the interpreter.

        (ContextImp::~ContextImp): Set the context in the interpreter to the caller.

        (ContextImp::mark): Mark all the activation objects.

        (InterpreterImp::InterpreterImp): Initialize context to 0.

        (InterpreterImp::mark): Mark the top context.

        (InterpreterImp::evaluate): Pass InterpreterImp to ContextImp.

        * kjs/internal.h: Move ContextImp to its own header. Add setContext to InterpreterImp.

        * kjs/interpreter.cpp: (Context::scopeChain): List -> ScopeChain.

        * kjs/interpreter.h: List -> ScopeChain.

        * kjs/nodes.cpp:

        (ResolveNode::evaluateReference): List -> ScopeChain.

        (FuncDeclNode::processFuncDecl): List -> ScopeChain.

        (FuncExprNode::evaluate): List -> ScopeChain.

        * kjs/object.cpp: List -> ScopeChain.

        * kjs/object.h: List -> ScopeChain.

        * kjs/types.h: Remove needsMarking features from List.

        * kjs/types.cpp: Ditto.

2002-11-21  Maciej Stachowiak  <mjs@apple.com>

	- reduced the size of PropertyMap by storing sizes and such in the

	dynamically allocated part of the object to reduce the size of

	ObjectImp - .5% speed improvement on JS iBench.

        * kjs/property_map.cpp:

        * kjs/property_map.h:

2002-11-21  Maciej Stachowiak  <mjs@apple.com>

        * Makefile.am: Pass symroots for this tree to pbxbuild.

=== Alexander-33 ===

2002-11-21  Darin Adler  <darin@apple.com>

        * kjs/property_map.cpp: More assertions.

2002-11-21  Darin Adler  <darin@apple.com>

        * kjs/property_map.cpp: Turn that consistency check back off.

2002-11-21  Darin Adler  <darin@apple.com>

	- someone somewhere must be defining a macro named check, causing a compile failure in WebCore

	Rename check() to checkConsistency().

        * kjs/property_map.h: Rename.

        * kjs/property_map.cpp: Yes, rename.

2002-11-21  Darin Adler  <darin@apple.com>

	- add self-check to property map in hopes of finding the cnet.com bug

        * kjs/property_map.h: Add check() function.

        * kjs/property_map.cpp: Add the checking, controlled by DO_CONSISTENCY_CHECK.

	 - fixed UChar interface so it's not so slow in debug builds

        * kjs/ustring.h: Nothing in UChar needs to be private.

        * kjs/function.cpp: (GlobalFuncImp::call):

        * kjs/function_object.cpp: (FunctionObjectImp::construct):

        * kjs/identifier.cpp:

        * kjs/lexer.cpp: (Lexer::setCode), (Lexer::shift):

        * kjs/lookup.cpp: (keysMatch):

        * kjs/ustring.cpp: (UString::Rep::computeHash), (KJS::compare):

	Use the "uc" field instead of the "unicode()" inline function.

2002-11-21  Darin Adler  <darin@apple.com>

	- fixed a null-dereference I ran into while trying to reproduce bug 3107351

        * kjs/function.h: Change ActivationImp constructor to take context parameter.

        * kjs/function.cpp: (ActivationImp::ActivationImp): Take context parameter,

	not execution state parameter.

        * kjs/internal.cpp: (ContextImp::ContextImp): Initialize activation object

	from context, not execution state, because the new context is not yet in the

	execution state.

2002-11-20  Darin Adler  <darin@apple.com>

	- added a feature for Richard to use in his back/forward cache

        * kjs/object.h: Added save/restoreProperties.

        * kjs/property_map.h: Here too.

        * kjs/property_map.cpp: Here too.

2002-11-20  Darin Adler  <darin@apple.com>

	- created argument list objects only on demand for a 7.5% speedup

        * kjs/function.h: Change ActivationImp around.

        * kjs/function.cpp:

        (FunctionImp::call): Pass a pointer to the arguments list to avoid ref/unref.

        (FunctionImp::get): Get the function pointer from the context directly,

	not the activation object.

        (ArgumentsImp::ArgumentsImp): Add an overload that takes no arguments.

        (ActivationImp::ActivationImp): Store a context pointer and an arguments object pointer.

        (ActivationImp::get): Special case for arguments, create it and return it.

        (ActivationImp::put): Special case for arguments, can't be set.

        (ActivationImp::hasProperty): Special case for arguments, return true.

        (ActivationImp::deleteProperty): Special case for arguments, refuse to delete.

        (ActivationImp::mark): Mark the arguments object.

        (ActivationImp::createArgumentsObject): Do the work of actually creating it.

        (GlobalFuncImp::call): Use stack-based objects for the ContextImp and ExecState.

        * kjs/internal.h: Keep function and arguments pointer in the context.

        * kjs/internal.cpp:

        (ContextImp::ContextImp): Don't pass in the func and args when making an ActivationImp.

        (InterpreterImp::evaluate): Use stack-based objects here.

        * kjs/types.h: Add ArgumentList as a synonym for List, soon to be separate.

2002-11-20  Maciej Stachowiak  <mjs@apple.com>

	Reduced the size of ValueImp by 8 bytes for a .5% speedup.

        * kjs/value.h: Removed destructed flag. Made refcount and flag 16

	bits each.

        * kjs/value.cpp:

        (ValueImp::~ValueImp): Don't set destructed flag.

2002-11-20  Darin Adler  <darin@apple.com>

        * kjs/types.cpp: Keep ref count for the whole lists of nodes.

	Doesn't speed things up much, less than 1%.

2002-11-20  Maciej Stachowiak  <mjs@apple.com>

        * kjs/collector.cpp:

        (Collector::allocate): Clear the flags on newly allocated objects.

2002-11-20  Darin Adler  <darin@apple.com>

	- oops, checked in big regression instead of 5% speedup

        * kjs/function.cpp: (ActivationImp::ActivationImp): Make a marking

	list, not a refing list.

	- a cut at the sparse array implementation

        * kjs/array_instance.h: Keep storageLength separate from length.

        * kjs/array_object.cpp:

        (ArrayInstanceImp::ArrayInstanceImp): Start with storageLength == length.

        (ArrayInstanceImp::get): Check against storage length.

        (ArrayInstanceImp::put): Ditto.

        (ArrayInstanceImp::hasProperty): Ditto.

        (ArrayInstanceImp::deleteProperty): Ditto.

        (ArrayInstanceImp::setLength): Only enlarge storage length up to a cutoff.

        (ArrayInstanceImp::mark): Use storageLength.

        (ArrayInstanceImp::pushUndefinedObjectsToEnd): Added FIXME.

2002-11-20  Darin Adler  <darin@apple.com>

	- decrease ref/deref -- 5% speedup in iBench

        * JavaScriptCore.pbproj/project.pbxproj: Added array_instance.h

        * kjs/array_instance.h: Added so it can be shared by function.h.

        * kjs/array_object.cpp:

        * kjs/array_object.h:

        * kjs/bool_object.cpp:

        * kjs/bool_object.h:

        * kjs/collector.cpp:

        * kjs/date_object.cpp:

        * kjs/date_object.h:

        * kjs/error_object.cpp:

        * kjs/function.cpp:

        * kjs/function.h:

        * kjs/function_object.cpp:

        * kjs/internal.cpp:

        * kjs/internal.h:

        * kjs/math_object.cpp:

        * kjs/nodes.cpp:

        * kjs/number_object.cpp:

        * kjs/object.cpp:

        * kjs/object.h:

        * kjs/object_object.cpp:

        * kjs/property_map.cpp:

        * kjs/reference.cpp:

        * kjs/reference.h:

        * kjs/regexp_object.cpp:

        * kjs/string_object.cpp:

        * kjs/string_object.h:

        * kjs/value.cpp:

        * kjs/value.h:

	Switched lots of interfaces so they don't require ref/deref.

2002-11-20  Maciej Stachowiak  <mjs@apple.com>

	Fixed the two most obvious problems with the new GC for another 6%

	improvement.

        * kjs/collector.cpp:

        (Collector::allocate): Don't bother doing the bit tests on a bitmap word if

	all it's bits are on.

        (Collector::collect): Track memoryFull boolean.

        * kjs/collector.h: Inlined outOfMemory since it was showing up on profiles.

2002-11-20  Maciej Stachowiak  <mjs@apple.com>

	Rewrote garbage collector to make blocks of actual memory instead

	of blocks of pointers. 7% improvement on JavaScript

	iBench. There's still lots of room to tune the new GC, this is

	just my first cut.

        * kjs/collector.cpp:

        (Collector::allocate):

        (Collector::collect):

        (Collector::size):

        (Collector::outOfMemory):

        (Collector::finalCheck):

        (Collector::numGCNotAllowedObjects):

        (Collector::numReferencedObjects):

        (Collector::liveObjectClasses):

        * kjs/collector.h: