webengine/osswebengine/WebCore/ChangeLog-2007-10-14
changeset 0 dd21522fd290
equal deleted inserted replaced
-1:000000000000 0:dd21522fd290
       
     1 2007-10-11  Jon Honeycutt  <jhoneycutt@apple.com>
       
     2 
       
     3         Reviewed by Anders.
       
     4 
       
     5         Handle a race condition that could arise if a plugin was loaded while it
       
     6         was scheduled to be freed: check whether the timer that schedules
       
     7         library frees is active in PluginPackageWin::load().
       
     8 
       
     9         * plugins/win/PluginPackageWin.cpp:
       
    10         (WebCore::PluginPackageWin::freeLibrarySoon): Added assertions
       
    11         (WebCore::PluginPackageWin::freeLibraryTimerFired): Added assertion
       
    12         (WebCore::PluginPackageWin::load): If we are scheduled to free this
       
    13         library, cancel the timer, and don't call LoadLibrary
       
    14 
       
    15 2007-10-11  Justin Garcia  <justin.garcia@apple.com>
       
    16 
       
    17         Reviewed by Harrison.
       
    18 
       
    19         <rdar://problem/5483567> REGRESSION (Tiger only): Pasting words copied from TextEdit in Mail adds extra newline
       
    20         
       
    21         * editing/ReplaceSelectionCommand.cpp:
       
    22         (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): Added.
       
    23         We would like to insert the fragment as-is if possible, but AppKit on Tiger
       
    24         creates fragments from RTF data that have carriage returns and spaces at the
       
    25         beginning and end, and those need to be removed since they'll interfere with 
       
    26         paragraph merging.
       
    27         (WebCore::ReplaceSelectionCommand::doApply):
       
    28         * editing/ReplaceSelectionCommand.h:
       
    29 
       
    30 2007-10-10  Justin Garcia  <justin.garcia@apple.com>
       
    31 
       
    32         Reviewed by Maciej.
       
    33         
       
    34         <rdar://problem/5521237> Pasting a word copied from TextEdit after a regular, breaking space, adds a leading newline
       
    35         
       
    36         * editing/CompositeEditCommand.cpp:
       
    37         (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
       
    38         Fixed a typo.
       
    39 
       
    40 2007-10-10  Jon Honeycutt  <jhoneycutt@apple.com>
       
    41 
       
    42         Reviewed by Darin.
       
    43 
       
    44         <rdar://5530519> REGRESSION (303-310A18): Crash when closing tab with
       
    45         pdf file (Reader 7 only)
       
    46 
       
    47         Reader 7 subclasses its parent window, so posting a WM_DESTROY to this
       
    48         window puts us in plugin code. When the plugin forwards the message
       
    49         back to the original window proc, and we free the plugin library from
       
    50         there, we will jump back to code we just freed when we return, so delay 
       
    51         calling FreeLibrary at least until the next message loop
       
    52 
       
    53         * plugins/win/PluginPackageWin.cpp:
       
    54         (WebCore::PluginPackageWin::freeLibrarySoon): Start a timer to free the
       
    55         plugin library
       
    56         (WebCore::PluginPackageWin::freeLibraryTimerFired): Free the library
       
    57         (WebCore::PluginPackageWin::PluginPackageWin): Initialize the timer that
       
    58         will free this library
       
    59         (WebCore::PluginPackageWin::unloadWithoutShutdown): Call
       
    60         freeLibrarySoon()
       
    61         * plugins/win/PluginPackageWin.h: Added m_freeLibraryTimer
       
    62 
       
    63 2007-10-11  Ada Chan  <adachan@apple.com>
       
    64 
       
    65         <rdar://problem/5534421> 
       
    66         Switched to using wkGetDefaultHTTPCookieStorage() and removed some cookie-related
       
    67         methods we no longer need in ResourceHandle.
       
    68         
       
    69         <rdar://problem/5244261> "Never" cookie policy was ignored on windows
       
    70         Need to set the cookie accept policy on each CFURLRequest.
       
    71         
       
    72         Reviewed by Oliver.
       
    73 
       
    74         * platform/network/ResourceHandle.h:
       
    75         * platform/network/cf/ResourceHandleCFNet.cpp:
       
    76         (WebCore::makeFinalRequest):
       
    77         * platform/network/cf/ResourceRequestCFNet.cpp:
       
    78         (WebCore::ResourceRequest::doUpdatePlatformRequest):
       
    79         * platform/network/win/CookieJarWin.cpp:
       
    80         (WebCore::setCookies):
       
    81         (WebCore::cookies):
       
    82         (WebCore::cookiesEnabled):
       
    83 
       
    84 2007-10-11  Mark Rowe  <mrowe@apple.com>
       
    85 
       
    86         Reviewed by Tim Hatcher.
       
    87 
       
    88         Fix for <rdar://problem/5488678>.  Disable debugging symbols in production builds for 10.4
       
    89         PowerPC to prevent a huge STABS section from being generated.
       
    90 
       
    91         * Configurations/Base.xcconfig:
       
    92 
       
    93 2007-10-11  Lars Knoll  <lars@trolltech.com>
       
    94 
       
    95         Reviewed by Erik Seidel and Simon.
       
    96 
       
    97         Ensure that setting innerHTML on an element doesn't do
       
    98         weird things with the document.
       
    99         Fixes most issues with http://bugs.webkit.org/show_bug.cgi?id=15456
       
   100 
       
   101         Test: fast/innerHTML/innerHTML-changing-document-properties.xhtml
       
   102 
       
   103         * dom/XMLTokenizer.cpp:
       
   104         (WebCore::XMLTokenizer::write):
       
   105         (WebCore::XMLTokenizer::startDocument):
       
   106         (WebCore::XMLTokenizer::end):
       
   107         (WebCore::):
       
   108 
       
   109 2007-10-10  George Staikos  <staikos@kde.org>
       
   110 
       
   111         Reviewed by Adam Roben.
       
   112 
       
   113         Fix Qt build on Win32 with VS2005.
       
   114 
       
   115         * loader/FTPDirectoryDocument.cpp:
       
   116         (WebCore::processFileDateString):
       
   117         * loader/FTPDirectoryParser.cpp:
       
   118         (WebCore::parseOneFTPLine):
       
   119 
       
   120 2007-10-10  Alice Liu  <alice.liu@apple.com>
       
   121 
       
   122         Reviewed by Geoff Garen.
       
   123 
       
   124         Fixed <rdar://5464402> Crash when running fast/frames/onload-remove-iframe-crash.html in DRT
       
   125         createFrame() now returns a RefPtr instead of a raw Frame pointer. 
       
   126         Making this change improves the way we handle frames on Windows webkit. 
       
   127 
       
   128         * loader/FrameLoader.cpp:
       
   129         (WebCore::FrameLoader::loadSubframe):
       
   130         * loader/FrameLoaderClient.h:
       
   131         * platform/graphics/svg/SVGImageEmptyClients.h:
       
   132         (WebCore::SVGEmptyFrameLoaderClient::createFrame):
       
   133 
       
   134 2007-10-10  Simon Hausmann  <hausmann@kde.org>
       
   135 
       
   136         Reviewed by Lars.
       
   137 
       
   138         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
       
   139         includes are needed for INT_MAX, std::auto_ptr and the like.
       
   140 
       
   141         WARNING: NO TEST CASES ADDED OR CHANGED
       
   142 
       
   143         * bridge/AXObjectCache.h:
       
   144         * ksvg2/misc/SVGDocumentExtensions.h:
       
   145         * platform/Base64.cpp:
       
   146         * platform/graphics/svg/SVGPaintServerPattern.h:
       
   147         * platform/graphics/svg/SVGResourceMasker.h:
       
   148 
       
   149 2007-10-08  Sam Weinig  <sam@webkit.org>
       
   150 
       
   151         Reviewed by Steve Falkenburg.
       
   152 
       
   153         Fix for <rdar://problem/5519698> CrashTracer: [USER] 47 crashes in Safari at com.apple.WebCore: WebCore::XMLTokenizer::lineNumber const + 9
       
   154 
       
   155         Test: fast/innerHTML/innerHTML-script-tag-crash.xhtml
       
   156 
       
   157         * dom/XMLTokenizer.cpp:
       
   158         (WebCore::XMLTokenizer::lineNumber): Return 1 when there is no context.
       
   159         (WebCore::XMLTokenizer::columnNumber): ditto.
       
   160 
       
   161 2007-10-08  Adam Roben  <aroben@apple.com>
       
   162 
       
   163         Fix Bug 15305: Crash when dragging an image when "load images automatically" preference is off
       
   164 
       
   165         http://bugs.webkit.org/show_bug.cgi?id=15305
       
   166         <rdar://problem/5524774>
       
   167 
       
   168         Reviewed by Eric Seidel.
       
   169 
       
   170         No test possible: to reproduce this you have to change a WebKit
       
   171         preference and reload the page. See
       
   172         http://bugs.webkit.org/show_bug.cgi?id=15414
       
   173 
       
   174         * platform/win/ClipboardWin.cpp:
       
   175         (WebCore::createGlobalImageFileDescriptor): ASSERT that we have an
       
   176         image and that it has a SharedBuffer.
       
   177         (WebCore::writeImageToDataObject): The fix: null-check imageBuffer.
       
   178 
       
   179 2007-10-05  Geoffrey Garen  <ggaren@apple.com>
       
   180 
       
   181         Reviewed by Sam Weinig.
       
   182         
       
   183         New fix for <rdar://problem/5522487> REGRESSION: With JavaScript 
       
   184         disabled, any page load causes a crash in PropertyMap::put
       
   185         
       
   186         Explicitly remove the "document" property from the window. The old 
       
   187         solution would leave a stale "document" property around after JavaScript
       
   188         was re-enabled.
       
   189 
       
   190         The architecture for disabling JavaScript could use some consolidation. 
       
   191         It seems wrong that a script proxy even exists when JavaScript is 
       
   192         disabled. It also seems wrong that so many individual call sites are 
       
   193         responsible for checking whether JavaScript is enabled. I've filed a 
       
   194         bug about this: http://bugs.webkit.org/show_bug.cgi?id=15385.
       
   195 
       
   196         * bindings/js/kjs_proxy.cpp:
       
   197         (WebCore::KJSProxy::clearDocumentWrapper):
       
   198         * bindings/js/kjs_proxy.h:
       
   199         * page/Frame.cpp:
       
   200         (WebCore::Frame::setDocument):
       
   201 
       
   202 2007-10-05  Jon Honeycutt  <jhoneycutt@apple.com>
       
   203 
       
   204         Reviewed by Anders.
       
   205 
       
   206         <rdar://5520913> Ticketmaster.com doesn't display correctly (Flash
       
   207         related?)
       
   208 
       
   209         The plugin is requesting files that don't exist on the server, and
       
   210         we are passing the 404 error page to the plugin. This change cancels the
       
   211         stream if the response code indicates a failure.
       
   212 
       
   213         This is a port of the safari / mac code.
       
   214 
       
   215         * loader/win/NetscapePlugInStreamLoaderWin.cpp:
       
   216         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): If the
       
   217         response code indicates a failure, cancel the stream
       
   218 
       
   219 2007-10-05  Geoffrey Garen  <ggaren@apple.com>
       
   220 
       
   221         Reviewed by Sam Weinig.
       
   222         
       
   223         Fixed <rdar://problem/5522487> REGRESSION: With JavaScript disabled, 
       
   224         any page load causes a crash in PropertyMap::put
       
   225         
       
   226         The problem was that we were using JavaScript when JavaScript was
       
   227         disabled. The architecture for disabling JavaScript could use some
       
   228         consolidation, but this is the simplest, safest change for now.
       
   229         
       
   230         Currently passing layout tests still pass.
       
   231 
       
   232         * bindings/js/kjs_proxy.cpp:
       
   233         (WebCore::KJSProxy::updateDocumentWrapper):
       
   234 
       
   235 2007-10-04  Beth Dakin  <bdakin@apple.com>
       
   236 
       
   237         Reviewed by John Sullivan.
       
   238 
       
   239         Fix for <rdar://problem/5441823> REGRESSION (r25142, Tiger only): 
       
   240         Vertical scroll bar not redrawn properly when going back in history 
       
   241         (15033)
       
   242 
       
   243         This fix if-defs r25142 to be Leopard-only since it causes 
       
   244         correctness issues on Tiger and does not seem to have any 
       
   245         performance impact on Tiger either.
       
   246 
       
   247         * loader/FrameLoader.cpp:
       
   248         (WebCore::FrameLoader::transitionToCommitted):
       
   249 
       
   250 2007-10-05  Ada Chan  <adachan@apple.com>
       
   251 
       
   252         <rdar://problem/5436617> Favicons sometimes don't show up even when they are
       
   253         in the database
       
   254         - A client can try to retain an icon for a page before the database is actually
       
   255         opened.  Since isOpened() is not a requirement to retain an icon, remove the check
       
   256         for that.  Instead, we'll check to make sure whether this database is enabled
       
   257         before proceeding.
       
   258 
       
   259         Reviewed by Brady.
       
   260 
       
   261         * loader/icon/IconDatabase.cpp:
       
   262         (WebCore::IconDatabase::retainIconForPageURL):
       
   263         (WebCore::IconDatabase::releaseIconForPageURL): only check isOpen() before we
       
   264         schedule for a sync.
       
   265 
       
   266 2007-10-05  Lars Knoll  <lars@trolltech.com>
       
   267 
       
   268         Reviewed by olliej.
       
   269 
       
   270         fix a hang in editing/selection/extend-by-word-002.html
       
   271 
       
   272         * platform/qt/TextBreakIteratorQt.cpp:
       
   273         (WebCore::CharBreakIteratorQt::next):
       
   274         (WebCore::characterBreakIterator):
       
   275 
       
   276 2007-10-04  Mark Rowe  <mrowe@apple.com>
       
   277 
       
   278         Reviewed by Oliver.
       
   279 
       
   280         Switch to default level of debugging symbols to resolve <rdar://problem/5488678>.
       
   281         The "full" level appears to offer no observable benefits even though the documentation
       
   282         suggests it be used for dead code stripping.  This should also decrease link times.
       
   283 
       
   284         * Configurations/Base.xcconfig:
       
   285 
       
   286 2007-10-04  Adele Peterson  <adele@apple.com>
       
   287 
       
   288         Reviewed by Darin.
       
   289 
       
   290         WebCore part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content
       
   291 
       
   292         * page/FocusController.h: Added FocusDirection argument.
       
   293         * page/FocusController.cpp: (WebCore::FocusController::setInitialFocus):
       
   294           Use FocusDirection argument instead of key modifiers to send direction to advanceFocus.
       
   295         * WebCore.exp: Updated symbol.
       
   296 
       
   297 2007-10-04  Kevin Decker  <kdecker@apple.com>
       
   298 
       
   299         Reviewed by John.
       
   300         
       
   301         <rdar://problems/5516309>
       
   302         
       
   303         * page/FrameView.cpp:
       
   304         (WebCore::FrameView::updateControlTints): Avoid the expense of updating tints on controls for the
       
   305         empty-window case since this can take a significant amount of time even on windows that have no
       
   306         content at all. Note this fix specifically optimizes the empty window/tab case; for a more broad
       
   307         fix John wrote up rdar://problem/5521050.
       
   308 
       
   309 2007-10-04  Darin Adler  <darin@apple.com>
       
   310 
       
   311         * page/Frame.h: Put functions into categories to indicate other classes
       
   312         we'd like to move them into in the future. Just organizational -- no code
       
   313         change.
       
   314 
       
   315 2007-10-04  Lars Knoll  <lars@trolltech.com>
       
   316 
       
   317         Reviewed by maciej.
       
   318 
       
   319         fix a crash in the FrameLoader that can happen under certain
       
   320         conditions in the Qt port.
       
   321 
       
   322         Test: fast/loader/iframe-crash-on-missing-image.xhtml
       
   323 
       
   324         * loader/FrameLoader.cpp:
       
   325         (WebCore::FrameLoader::receivedMainResourceError):
       
   326 
       
   327 2007-10-03  Alp Toker  <alp@atoker.com>
       
   328 
       
   329         Reviewed by Adam.
       
   330 
       
   331         http://bugs.webkit.org/show_bug.cgi?id=14726
       
   332         [gtk] API design. Mapping the WebView delegates to signals.
       
   333 
       
   334         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
       
   335 
       
   336         * WebCore.pro:
       
   337 
       
   338 2007-10-03  Alp Toker  <alp@atoker.com>
       
   339 
       
   340         Reviewed by Eric.
       
   341 
       
   342         http://bugs.webkit.org/show_bug.cgi?id=14129
       
   343         [CAIRO] Support the canvas element
       
   344 
       
   345         Add a new canvas implementation using Cairo for rendering.
       
   346 
       
   347         * html/CanvasGradient.cpp:
       
   348         (WebCore::CanvasGradient::CanvasGradient):
       
   349         (WebCore::CanvasGradient::~CanvasGradient):
       
   350         (WebCore::CanvasGradient::addColorStop):
       
   351         (WebCore::CanvasGradient::platformShading):
       
   352         * html/CanvasGradient.h:
       
   353         * html/CanvasRenderingContext2D.cpp:
       
   354         (WebCore::CanvasRenderingContext2D::setFillStyle):
       
   355         (WebCore::CanvasRenderingContext2D::fill):
       
   356         (WebCore::CanvasRenderingContext2D::stroke):
       
   357         (WebCore::CanvasRenderingContext2D::fillRect):
       
   358         (WebCore::CanvasRenderingContext2D::drawImage):
       
   359         (WebCore::CanvasRenderingContext2D::applyStrokePattern):
       
   360         * html/CanvasStyle.cpp:
       
   361         (WebCore::CanvasStyle::applyStrokeColor):
       
   362         * html/HTMLCanvasElement.cpp:
       
   363         (WebCore::HTMLCanvasElement::~HTMLCanvasElement):
       
   364         (WebCore::HTMLCanvasElement::reset):
       
   365         (WebCore::HTMLCanvasElement::paint):
       
   366         (WebCore::HTMLCanvasElement::createDrawingContext):
       
   367         (WebCore::HTMLCanvasElement::createPlatformImage):
       
   368         * html/HTMLCanvasElement.h:
       
   369 
       
   370 2007-10-03  Lars Knoll  <lars@trolltech.com>
       
   371 
       
   372         Signed off by olliej.
       
   373 
       
   374         move WebKitQt to WebKit/qt for consistency with the other ports.
       
   375 
       
   376         WARNING: NO TEST CASES ADDED OR CHANGED
       
   377 
       
   378         * WebCore.pro:
       
   379 
       
   380 2007-10-02  Sam Weinig  <sam@webkit.org>
       
   381 
       
   382         Reviewed by Oliver and Adam.
       
   383 
       
   384         Patch for <rdar://problem/5506968> Fail to DnD local file with non-ascii character in path from desktop to Safari (can open it with file menu)
       
   385 
       
   386         Use CoreFoundation to do the conversion from path to URL, as the Windows API was not
       
   387         correctly converting to UTF-8 and we know CFURL will.
       
   388 
       
   389         * platform/win/ClipboardUtilitiesWin.cpp:
       
   390         (WebCore::urlFromPath):
       
   391         (WebCore::getURL):
       
   392 
       
   393 2007-10-02  Tristan O'Tierney  <tristan@apple.com>
       
   394 
       
   395         Reviewed by Darin Adler.
       
   396 
       
   397         <rdar://problem/5511842> REGRESSION: Webkit stops responding while loading Apple Store Canada page (15304)
       
   398         
       
   399         Included the NSSynchronousURLConnection_PrivateMode mode, in addition to the default run loop modes
       
   400         as an acceptable mode when using performSelectorOnMainThread with our syncronous url callbacks.
       
   401 
       
   402         * platform/network/mac/ResourceHandleMac.mm:
       
   403         (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
       
   404         Added NSSynchronousURLConnection_PrivateMode to the list of accepted modes.
       
   405 
       
   406 2007-10-02  Darin Adler  <darin@apple.com>
       
   407 
       
   408         Reviewed by Adam.
       
   409 
       
   410         - add support for GDI objects to OwnPtr; I plan to use this
       
   411           to fix some GDI handle leaks
       
   412 
       
   413         * css/CSSGrammar.y: Change parser to avoid macro that conflicts
       
   414         with macro defined in Windows system headers: FLOAT. This is needed
       
   415         because OwnPtr.h will now include <windows.h>.
       
   416         * css/CSSParser.cpp: (WebCore::CSSParser::lex): Ditto.
       
   417         * css/tokenizer.flex: Ditto.
       
   418 
       
   419         * platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor):
       
   420         Use OwnPtr for a few HBITMAP objects as a test case.
       
   421 
       
   422         * platform/win/COMPtr.h: (COMPtr::COMPtr): Fix so that we can use
       
   423         Query with other COMPtr. Before this would not compile if it was
       
   424         ever instantiated.
       
   425 
       
   426 2007-10-02  Steve Falkenburg  <sfalken@apple.com>
       
   427 
       
   428         Reviewed by Adam, Ada.
       
   429 
       
   430         Fix leak of GDI handle when we call MLANG.
       
   431 
       
   432         * platform/win/FontCacheWin.cpp:
       
   433         (WebCore::FontCache::getFontDataForCharacters):
       
   434 
       
   435 2007-10-02  Lars Knoll  <lars@trolltech.com>
       
   436 
       
   437         Reviewed by Olliej.
       
   438 
       
   439         The cookies() method should only return the value of the
       
   440         cookie, not additional info such as the expiration date.
       
   441 
       
   442         * platform/qt/CookieJarQt.cpp:
       
   443         (WebCore::cookies):
       
   444 
       
   445 2007-10-01  Lars Knoll  <lars@trolltech.com>
       
   446 
       
   447         Reviewed by Eric.
       
   448 
       
   449         Fix a wrong extension mapping in the MIMETypeRegistry and identify about: url's as frames in the FrameLoaderClient.
       
   450 
       
   451         * platform/qt/MIMETypeRegistryQt.cpp:
       
   452         (WebCore::):
       
   453 
       
   454 2007-10-01  Justin Garcia  <justin.garcia@apple.com>
       
   455 
       
   456         Reviewed by Harrison.
       
   457 
       
   458         <rdar://problem/5516183> REGRESSION: Creating a ToDo on an incoming message fails
       
   459         
       
   460         Rolling out r25721.
       
   461 
       
   462         * editing/ReplaceSelectionCommand.cpp:
       
   463         (WebCore::ReplaceSelectionCommand::doApply):
       
   464         * editing/ReplaceSelectionCommand.h:
       
   465 
       
   466 2007-10-01  Beth Dakin  <bdakin@apple.com>
       
   467 
       
   468         Reviewed by Adam.
       
   469 
       
   470         Fix for <rdar://problem/5515426> NetNewsWire 3 crashes at launch in 
       
   471         WebCore::FrameView::layout (other repro scenarios too)
       
   472 
       
   473         The new call to updateWidget() that we added to FrameView::layout() 
       
   474         can destroy the RenderPartObject. And so we were crashing on the 
       
   475         subsequent call to updateWidgetPosition(). This patch fixes that by 
       
   476         checking to make sure the RenderPartObject is still in the HashSet 
       
   477         after updateWidget(). Because m_widgetUpdateSet can be modified 
       
   478         during the call to updateWidget(), we need it to be intact while we 
       
   479         are iterating through the copy, so we cannot use the HashSet::swap 
       
   480         call we were using before. This patch instead uses a Vector to 
       
   481         iterate through the HashSet data and calls clear() on the HashSet 
       
   482         at the end.
       
   483 
       
   484         * page/FrameView.cpp:
       
   485         (WebCore::FrameView::layout):
       
   486 
       
   487 2007-10-01  Eli Fidler  <eli@staikos.net>
       
   488 
       
   489         Reviewed by George Staikos.
       
   490 
       
   491         Switch bogus assert to a conditional and return.  This case happens
       
   492         when a widget is hidden.
       
   493 
       
   494         * platform/qt/WidgetQt.cpp:
       
   495         (WebCore::Widget::invalidateRect):
       
   496 
       
   497 2007-09-30  Darin Adler  <darin@apple.com>
       
   498 
       
   499         Reviewed by Maciej.
       
   500 
       
   501         - tone down the assertion I asked Harrison to include in his fix for
       
   502           <rdar://problem/5511128>; it's OK to re-ref and deref the document
       
   503           as long as you do so after the children are done being destroyed
       
   504 
       
   505         No effect on release builds. Assertion change only.
       
   506 
       
   507         Besides the changes listed below, renamed m_hasDeleted flag to
       
   508         m_deletionHasBegun.
       
   509 
       
   510         * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeAllChildren):
       
   511         Added code to set the m_deletionHasBegun flag and some assertions
       
   512         that test its state.
       
   513 
       
   514         * dom/Document.h: Removed m_hasDeleted -- we now use m_deletionHasBegun
       
   515         in the base class TreeShared.
       
   516         * dom/Document.cpp:
       
   517         (WebCore::Document::Document): Removed initialization of m_hasDeleted.
       
   518         (WebCore::Document::removedLastRef): Added code to clear
       
   519         m_inRemovedLastRefFunction if we end up deciding not to delete this.
       
   520 
       
   521         * platform/Shared.h:
       
   522         (WebCore::TreeShared::TreeShared): Added m_deletionHasBegun in addition to
       
   523         m_inRemovedLastRefFunction (formerly named m_hasRemovedLastRef).
       
   524         (WebCore::TreeShared::~TreeShared): Assert that m_deletionHasBegun is true.
       
   525         (WebCore::TreeShared::ref): Assert neither flag is true.
       
   526         (WebCore::TreeShared::deref): Ditto.
       
   527         (WebCore::TreeShared::hasOneRef): Ditto.
       
   528         (WebCore::TreeShared::removedLastRef): Made private. Added code to
       
   529         set m_hasDeleted to true. Also removed cast; since this class template
       
   530         has a virtual destructor, we don't need to cast before calling delete.
       
   531 
       
   532 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
       
   533 
       
   534         Reviewed by Mark.
       
   535 
       
   536         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
       
   537         Remove Bakefiles from svn.
       
   538 
       
   539         * Projects/gdk/webcore-gdk.bkl: Removed.
       
   540         * Projects/wx/webcore-wx.bkl: Removed.
       
   541         * WebCoreSources.bkl: Removed.
       
   542         * webcore-base.bkl: Removed.
       
   543 
       
   544 2007-09-28  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
       
   545 
       
   546         Reviewed by Mark.
       
   547 
       
   548         -Fix http://bugs.webkit.org/show_bug.cgi?id=15254.
       
   549 
       
   550         * platform/gtk/RenderThemeGtk.cpp:
       
   551         (WebCore::RenderThemeGtk::determineState):
       
   552             - Apply state if control is readonly
       
   553             - Added state GTK_STATE_SELECTED of object is checked
       
   554             - Apply GTK_STATE_ACTIVE if RenderObject isFocused()
       
   555         (WebCore::RenderThemeGtk::paintTextField):
       
   556         (WebCore::RenderThemeGtk::gtkEntry):
       
   557             - Implemented theme-aware text field based on gtk/gtkentry.c implementation
       
   558 
       
   559 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
       
   560 
       
   561         Reviewed by Eric.
       
   562 
       
   563         Build fix for Mac Gtk+ and Qt builds. In revision 25798 changing
       
   564         XSLTProcessor.cpp was forgotten.
       
   565 
       
   566         * xml/XSLTProcessor.cpp: Use PLATFORM(MAC) instead of PLATFORM(DARWIN)
       
   567 
       
   568 2007-09-29  Adam Roben  <aroben@apple.com>
       
   569 
       
   570         Fix <rdar://4965715> Horizontal scrollwheel scrolling moves in opposite direction on Vista
       
   571 
       
   572         Reviewed by Sam.
       
   573 
       
   574         No regression test possible.
       
   575 
       
   576         * platform/win/WheelEventWin.cpp:
       
   577         (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use a negative
       
   578         delta when scrolling right to match EventHandler's expectations (which
       
   579         are based on AppKit).
       
   580 
       
   581 2007-09-28  Kevin Decker  <kdecker@apple.com>
       
   582 
       
   583         Reviewed by Mark Rowe
       
   584 
       
   585         Build fix for Mac Gtk+ and Qt builds.
       
   586         
       
   587         * xml/XSLStyleSheet.cpp: Use PLATFORM(MAC) instead of PLATFORM(DARWIN)
       
   588         * xml/XSLTExtensions.cpp: Ditto.
       
   589 
       
   590 2007-09-28  David Harrison  <harrison@apple.com>
       
   591 
       
   592         Reviewed by Darin Adler.
       
   593 
       
   594         <rdar://problem/5511128> Crash closing or reloading this SVG
       
   595 
       
   596         * dom/ContainerNode.cpp:
       
   597         (WebCore::dispatchChildInsertionEvents):
       
   598         (WebCore::dispatchChildRemovalEvents):
       
   599         Use DocPtr instead of RefPtr, since these events are dispatched
       
   600         when the Document is being being torn down by removedLastRef().
       
   601 
       
   602         * dom/DocPtr.h:
       
   603         (WebCore::DocPtr::DocPtr):
       
   604         Fix longstanding typo in template so that the DocPtr(DocPtr) constructor can be used.
       
   605 
       
   606         * dom/Document.cpp:
       
   607         (WebCore::Document::Document):
       
   608         (WebCore::Document::removedLastRef):
       
   609         * dom/Document.h:
       
   610         (WebCore::Document::selfOnlyRef):
       
   611         (WebCore::Document::selfOnlyDeref):
       
   612         * platform/Shared.h:
       
   613         (WebCore::Shared::Shared):
       
   614         (WebCore::Shared::ref):
       
   615         (WebCore::Shared::deref):
       
   616         (WebCore::Shared::hasOneRef):
       
   617         (WebCore::TreeShared::TreeShared):
       
   618         (WebCore::TreeShared::ref):
       
   619         (WebCore::TreeShared::deref):
       
   620         (WebCore::TreeShared::hasOneRef):
       
   621         (WebCore::TreeShared::refCount):
       
   622         Add debug-only checks for a document being ref-counted while being deleted.
       
   623 
       
   624 2007-09-27  Kevin McCullough  <kmccullough@apple.com>
       
   625 
       
   626         Reviewed by Darin.
       
   627 
       
   628         - <rdar://5261371> Nothing downloaded when exporting bookmarks from iGoogle web history
       
   629 
       
   630         Function for use by WebKit. Currently used only on Windows.
       
   631 
       
   632         * platform/network/ResourceResponse.cpp:
       
   633         (WebCore::ResourceResponse::isAttachment):
       
   634         * platform/network/ResourceResponse.h:
       
   635 
       
   636 2007-09-27  Mitz Pettel  <mitz@webkit.org>
       
   637 
       
   638         Reviewed by Dave Hyatt.
       
   639 
       
   640         - fix http://bugs.webkit.org/show_bug.cgi?id=15262
       
   641           REGRESSION: Margin-top:18px is pushing down the multiple select list box outside the div.
       
   642 
       
   643         Reflected in existing tests.
       
   644 
       
   645         * css/html4.css: Changed listboxes to use border-box sizing, to match Firefox,
       
   646         WinIE and apparently also Safari 2.
       
   647 
       
   648 2007-09-27  Kevin Decker  <kdecker@apple.com>
       
   649 
       
   650         <rdar://problem/5493093>
       
   651     
       
   652         Rubber stamped by John Sullivan.
       
   653         
       
   654         * WebCore.order: Added.
       
   655         * WebCore.xcodeproj/project.pbxproj:  We're changing from using an order file built by another team to using one
       
   656          we actually check into our project repository. Linker settings for Symbol Ordering Flags have been updated
       
   657          accordingly.
       
   658          
       
   659 2007-09-27  Antti Koivisto  <antti@apple.com>
       
   660 
       
   661         Reviewed by Geoff.
       
   662         
       
   663         Fix for <rdar://problem/5499125>
       
   664         REGRESSION (r21367): After launching Kidzui beta, a webview frame fails to appear in its main window
       
   665         
       
   666         If window object properties were modified when it had initial empty document (synchronously after 
       
   667         window.open() for example) those modifications were lost when the real document was switched in.
       
   668         
       
   669         Match Firefox behavior where window properties are not cleared if the inital document and the loaded one
       
   670         have matching security domains.
       
   671 
       
   672         Tests: fast/dom/Window/window-early-properties.html
       
   673                http/tests/security/window-properties-clear-domain.html
       
   674                http/tests/security/window-properties-clear-port.html
       
   675                http/tests/security/window-properties-pass.html
       
   676 
       
   677         * WebCore.exp:
       
   678         * loader/FrameLoader.cpp:
       
   679         (WebCore::FrameLoader::FrameLoader):
       
   680         (WebCore::FrameLoader::init):
       
   681         (WebCore::FrameLoader::clear):
       
   682         (WebCore::FrameLoader::isSecureTransition):
       
   683         (WebCore::FrameLoader::begin):
       
   684         * loader/FrameLoader.h:
       
   685         If we are transitioning from initial empty document to the final one, do a domain security check
       
   686         between old security policy URL and new URL. If that passes don't clear script proxy and script objects.
       
   687         
       
   688         * bindings/js/kjs_proxy.cpp:
       
   689         (WebCore::KJSProxy::updateDocumentWrapper):
       
   690         * bindings/js/kjs_proxy.h:
       
   691         * page/Frame.cpp:
       
   692         (WebCore::Frame::setDocument):
       
   693         Since we don't always clear window properties anymore, we need to update the document property to point to
       
   694         the newly created one. 
       
   695         
       
   696 2007-09-27  Kevin Decker  <kdecker@apple.com>
       
   697 
       
   698         Reviewed by Darin.
       
   699 
       
   700         <rdar://problem/5493093>
       
   701         
       
   702         * WebCore.xcodeproj/project.pbxproj: Removed libxslt from statically linked frameworks.
       
   703         * platform/mac/SoftLinking.h: Formatting tweakes, added SOFT_LINK_LIBRARY, and if'def for 
       
   704         PLATFORM(DARWIN)
       
   705         * xml/XSLStyleSheet.cpp: Soft-linked libxslt.
       
   706         * xml/XSLTExtensions.cpp: Removed the call to xsltGenericError, and added a FIXME comment stating
       
   707         that it might be helpful to push any errors from xmlXPathNewValueTree up to the Javascript Console. 
       
   708         * xml/XSLTProcessor.cpp: Soft-linked libxslt.
       
   709         
       
   710 2007-09-27  Adele Peterson  <adele@apple.com>
       
   711 
       
   712         Reviewed by Brady.
       
   713 
       
   714         Fix for <rdar://problem/5453350> REGRESSION (r18541, Tiger only): Refreshing a cached https page does not reload CSS and JavaScript resources
       
   715         http://bugs.webkit.org/show_bug.cgi?id=15121
       
   716 
       
   717         * loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest): Now sets the cache policy to ReloadIgnoringCacheData.  Without setting the cache policy,
       
   718         the default policy in this case was ReturnCacheDataElseLoad.  If we're in a situation where the resource is in the cache, we want to make sure to avoid loading from the cache in this case.
       
   719 
       
   720 2007-09-27  Timothy Hatcher  <timothy@apple.com>
       
   721 
       
   722         Reviewed by Darin.
       
   723 
       
   724         <rdar://problem/5199546> CrashTracer: [REGRESSION] 8216 crashes in Safari at com.apple.WebCore: WebCore::ResourceHandle::client const + 6
       
   725 
       
   726         On Tiger NSURLConnection can sometimes call the connection:willCacheResponse: delegate method on
       
   727         a secondary thread instead of the main thread. This was never an issue before, since the implementation 
       
   728         of this method was very simple and thread safe.
       
   729 
       
   730         The fix is to block during connection:willCacheResponse: and perform the work on the main thread.
       
   731         We need to block since this delegate method needs to return a result. If we are already on the
       
   732         main thread (which sometimes we are), the method does nothing different. If we are on a secondary
       
   733         thread, we make a mutable dictionary to hold all the arguments and later the result object.
       
   734         Then performSelectorOnMainThread:withObject: using the _callConnectionWillCacheResponseWithInfo:
       
   735         selector. This new method just pulls the arguments out for the dictionary and calls the real
       
   736         connection:willCacheResponse: delegate method (this time on the main thread). The result is stored
       
   737         in the dictionary, and when performSelectorOnMainThread:withObject: finishes the result is pulled
       
   738         out and returned.
       
   739 
       
   740         * platform/network/mac/ResourceHandleMac.mm:
       
   741         (-[WebCoreResourceHandleAsDelegate _callConnectionWillCacheResponseWithInfo:]):
       
   742         (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
       
   743 
       
   744 2007-09-27  David Hyatt  <hyatt@apple.com>
       
   745 
       
   746         Update to reflect the minimal WebKitSystemInterface changes required
       
   747         to support @font-face.
       
   748 
       
   749         Reviewed by john
       
   750 
       
   751         * platform/mac/FontDataMac.mm:
       
   752         (WebCore::FontData::platformInit):
       
   753         (WebCore::FontData::platformWidthForGlyph):
       
   754         * platform/mac/WebCoreSystemInterface.h:
       
   755         * platform/mac/WebCoreSystemInterface.mm:
       
   756 
       
   757 2007-09-26  Darin Adler  <darin@apple.com>
       
   758 
       
   759         - fix Windows build
       
   760 
       
   761         * platform/win/ClipboardWin.cpp:
       
   762         (WebCore::writeURL): Add a check for empty URL. Remove the check for invalid URL.
       
   763         (WebCore::ClipboardWin::setData): Remove the check for invalid URL.
       
   764         * plugins/win/PluginViewWin.cpp:
       
   765         (WebCore::PluginViewWin::start): Check for empty URL instead of invalid URL.
       
   766         (WebCore::PluginViewWin::load): Same here.
       
   767 
       
   768 2007-09-26  Darin Adler  <darin@apple.com>
       
   769 
       
   770         Reviewed by John Sullivan.
       
   771 
       
   772         - fix <rdar://problem/5491054> REGRESSION (Mail, plain-text only): Nothing happens
       
   773           when you click on rdar://<num>&<num> links (or AOL links in Safari)
       
   774 
       
   775         Remove the non-useful concept of a "malformed"/"invalid" URL.
       
   776 
       
   777         There are URLs we can parse, and others we can't, but that's not sufficient to
       
   778         determine if we should try to work with the URL. It's entirely possible that
       
   779         a so-called "malformed" URL will work just fine if it's passed to the right
       
   780         software.
       
   781 
       
   782         * platform/KURL.h: Removed isMalformed() and isValid().
       
   783 
       
   784         * loader/Cache.cpp: (WebCore::Cache::requestResource): Removed unneeded check
       
   785         if the URL is valid. But do check for an empty URL just to guarantee we don't
       
   786         trip up with a null string. It's possible we can remove this empty URL check
       
   787         later, but it's less risky to leave the empty string behavior alone for now.
       
   788 
       
   789         * loader/FrameLoader.cpp:
       
   790         (WebCore::FrameLoader::urlSelected): Removed unneeded check if the URL is valid.
       
   791         Back on 2007-07-08, we realized that we needed to allow empty URLs. But we also
       
   792         need to allow other URLs here. This is the code path from the Mail case.
       
   793         (WebCore::FrameLoader::submitForm): Replaced URL validity check with a check
       
   794         for an empty URL (same reasoning as for requestResource above).
       
   795 
       
   796         * page/InspectorController.cpp: (WebCore::InspectorResource::type):
       
   797         * rendering/RenderObject.cpp: (WebCore::RenderObject::addPDFURLRect):
       
   798         Removed unneeded check for an invalid URL. In both of these cases it's definitely
       
   799         safe to allow event an empty URL.
       
   800 
       
   801 2007-09-26  George Staikos  <staikos@kde.org>
       
   802 
       
   803         Reviewed by John Sullivan.
       
   804 
       
   805         Only highlight the applicable portion of the text run for a search
       
   806         highlight.  No way to make a testcase for this presently.
       
   807 
       
   808         * rendering/InlineTextBox.cpp:
       
   809         (WebCore::InlineTextBox::paintTextMatchMarker):
       
   810 
       
   811 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
       
   812 
       
   813         Reviewed by Adam.
       
   814 
       
   815         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
       
   816           LGPL'ed files contain incorrect FSF address
       
   817 
       
   818         * LICENSE-LGPL-2:
       
   819         * LICENSE-LGPL-2.1:
       
   820         * WebCorePrefix.h:
       
   821         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
       
   822         * bindings/js/JSDOMWindowCustom.cpp:
       
   823         * bindings/js/JSDocumentCustom.cpp:
       
   824         * bindings/js/JSHTMLCollectionCustom.cpp:
       
   825         * bindings/js/JSHTMLElementWrapperFactory.cpp:
       
   826         * bindings/js/JSHTMLElementWrapperFactory.h:
       
   827         * bindings/js/JSHTMLInputElementBase.cpp:
       
   828         * bindings/js/JSHTMLInputElementBase.h:
       
   829         * bindings/js/JSHTMLOptionElementConstructor.cpp:
       
   830         * bindings/js/JSHTMLOptionElementConstructor.h:
       
   831         * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
       
   832         * bindings/js/JSHTMLSelectElementCustom.cpp:
       
   833         * bindings/js/JSNodeFilterCondition.cpp:
       
   834         * bindings/js/JSNodeFilterCondition.h:
       
   835         * bindings/js/JSNodeIteratorCustom.cpp:
       
   836         * bindings/js/JSSVGElementWrapperFactory.cpp:
       
   837         * bindings/js/JSSVGElementWrapperFactory.h:
       
   838         * bindings/js/JSSVGMatrixCustom.cpp:
       
   839         * bindings/js/JSSVGPathSegCustom.cpp:
       
   840         * bindings/js/JSSVGPathSegListCustom.cpp:
       
   841         * bindings/js/JSSVGPointListCustom.cpp:
       
   842         * bindings/js/JSTreeWalkerCustom.cpp:
       
   843         * bindings/js/JSXMLHttpRequest.cpp:
       
   844         * bindings/js/JSXMLHttpRequest.h:
       
   845         * bindings/js/kjs_binding.cpp:
       
   846         * bindings/js/kjs_binding.h:
       
   847         * bindings/js/kjs_css.cpp:
       
   848         * bindings/js/kjs_css.h:
       
   849         * bindings/js/kjs_dom.cpp:
       
   850         * bindings/js/kjs_dom.h:
       
   851         * bindings/js/kjs_events.cpp:
       
   852         * bindings/js/kjs_events.h:
       
   853         * bindings/js/kjs_html.cpp:
       
   854         * bindings/js/kjs_html.h:
       
   855         * bindings/js/kjs_navigator.cpp:
       
   856         * bindings/js/kjs_navigator.h:
       
   857         * bindings/js/kjs_proxy.cpp:
       
   858         * bindings/js/kjs_proxy.h:
       
   859         * bindings/js/kjs_window.cpp:
       
   860         * bindings/js/kjs_window.h:
       
   861         * bindings/objc/DOMImplementationFront.cpp:
       
   862         * bindings/objc/DOMImplementationFront.h:
       
   863         * bindings/scripts/CodeGenerator.pm:
       
   864         * bindings/scripts/CodeGeneratorJS.pm:
       
   865         * bindings/scripts/CodeGeneratorObjC.pm:
       
   866         * bindings/scripts/IDLParser.pm:
       
   867         * bindings/scripts/IDLStructure.pm:
       
   868         * bindings/scripts/generate-bindings.pl:
       
   869         * config.h:
       
   870         * css/CSSBorderImageValue.cpp:
       
   871         * css/CSSBorderImageValue.h:
       
   872         * css/CSSCharsetRule.cpp:
       
   873         * css/CSSCharsetRule.h:
       
   874         * css/CSSCharsetRule.idl:
       
   875         * css/CSSComputedStyleDeclaration.cpp:
       
   876         * css/CSSComputedStyleDeclaration.h:
       
   877         * css/CSSCursorImageValue.cpp:
       
   878         * css/CSSCursorImageValue.h:
       
   879         * css/CSSFontFaceRule.cpp:
       
   880         * css/CSSFontFaceRule.h:
       
   881         * css/CSSFontFaceRule.idl:
       
   882         * css/CSSGrammar.y:
       
   883         * css/CSSHelper.cpp:
       
   884         * css/CSSHelper.h:
       
   885         * css/CSSImageValue.cpp:
       
   886         * css/CSSImageValue.h:
       
   887         * css/CSSImportRule.cpp:
       
   888         * css/CSSImportRule.h:
       
   889         * css/CSSImportRule.idl:
       
   890         * css/CSSInheritedValue.cpp:
       
   891         * css/CSSInheritedValue.h:
       
   892         * css/CSSInitialValue.cpp:
       
   893         * css/CSSInitialValue.h:
       
   894         * css/CSSMediaRule.cpp:
       
   895         * css/CSSMediaRule.h:
       
   896         * css/CSSMediaRule.idl:
       
   897         * css/CSSMutableStyleDeclaration.cpp:
       
   898         * css/CSSMutableStyleDeclaration.h:
       
   899         * css/CSSNamespace.h:
       
   900         * css/CSSPageRule.cpp:
       
   901         * css/CSSPageRule.h:
       
   902         * css/CSSPageRule.idl:
       
   903         * css/CSSParser.cpp:
       
   904         * css/CSSParser.h:
       
   905         * css/CSSPrimitiveValue.cpp:
       
   906         * css/CSSPrimitiveValue.h:
       
   907         * css/CSSPrimitiveValue.idl:
       
   908         * css/CSSProperty.cpp:
       
   909         * css/CSSProperty.h:
       
   910         * css/CSSQuirkPrimitiveValue.h:
       
   911         * css/CSSRule.cpp:
       
   912         * css/CSSRule.h:
       
   913         * css/CSSRule.idl:
       
   914         * css/CSSRuleList.cpp:
       
   915         * css/CSSRuleList.h:
       
   916         * css/CSSSelector.cpp:
       
   917         * css/CSSSelector.h:
       
   918         * css/CSSStyleDeclaration.cpp:
       
   919         * css/CSSStyleDeclaration.h:
       
   920         * css/CSSStyleDeclaration.idl:
       
   921         * css/CSSStyleRule.cpp:
       
   922         * css/CSSStyleRule.h:
       
   923         * css/CSSStyleRule.idl:
       
   924         * css/CSSStyleSelector.cpp:
       
   925         * css/CSSStyleSelector.h:
       
   926         * css/CSSStyleSheet.cpp:
       
   927         * css/CSSStyleSheet.h:
       
   928         * css/CSSStyleSheet.idl:
       
   929         * css/CSSUnknownRule.h:
       
   930         * css/CSSUnknownRule.idl:
       
   931         * css/CSSValue.h:
       
   932         * css/CSSValue.idl:
       
   933         * css/CSSValueList.cpp:
       
   934         * css/CSSValueList.h:
       
   935         * css/Counter.h:
       
   936         * css/Counter.idl:
       
   937         * css/DashboardRegion.h:
       
   938         * css/FontFamilyValue.cpp:
       
   939         * css/FontFamilyValue.h:
       
   940         * css/FontValue.cpp:
       
   941         * css/FontValue.h:
       
   942         * css/MediaFeatureNames.cpp:
       
   943         * css/MediaFeatureNames.h:
       
   944         * css/MediaList.cpp:
       
   945         * css/MediaList.h:
       
   946         * css/Pair.h:
       
   947         * css/RGBColor.idl:
       
   948         * css/Rect.h:
       
   949         * css/Rect.idl:
       
   950         * css/ShadowValue.cpp:
       
   951         * css/ShadowValue.h:
       
   952         * css/StyleBase.cpp:
       
   953         * css/StyleBase.h:
       
   954         * css/StyleList.cpp:
       
   955         * css/StyleList.h:
       
   956         * css/StyleSheet.cpp:
       
   957         * css/StyleSheet.h:
       
   958         * css/StyleSheet.idl:
       
   959         * css/StyleSheetList.cpp:
       
   960         * css/StyleSheetList.h:
       
   961         * css/StyleSheetList.idl:
       
   962         * css/html4.css:
       
   963         * css/make-css-file-arrays.pl:
       
   964         * css/makegrammar.pl:
       
   965         * css/makeprop.pl:
       
   966         * css/maketokenizer:
       
   967         * css/makevalues.pl:
       
   968         * css/quirks.css:
       
   969         * dom/AtomicStringList.h:
       
   970         * dom/Attr.cpp:
       
   971         * dom/Attr.h:
       
   972         * dom/Attr.idl:
       
   973         * dom/Attribute.cpp:
       
   974         * dom/Attribute.h:
       
   975         * dom/BeforeUnloadEvent.cpp:
       
   976         * dom/BeforeUnloadEvent.h:
       
   977         * dom/CDATASection.cpp:
       
   978         * dom/CDATASection.h:
       
   979         * dom/CDATASection.idl:
       
   980         * dom/CSSMappedAttributeDeclaration.cpp:
       
   981         * dom/CSSMappedAttributeDeclaration.h:
       
   982         * dom/CharacterData.cpp:
       
   983         * dom/CharacterData.h:
       
   984         * dom/CharacterData.idl:
       
   985         * dom/ChildNodeList.cpp:
       
   986         * dom/ChildNodeList.h:
       
   987         * dom/Clipboard.h:
       
   988         * dom/ClipboardEvent.cpp:
       
   989         * dom/ClipboardEvent.h:
       
   990         * dom/Comment.cpp:
       
   991         * dom/Comment.h:
       
   992         * dom/Comment.idl:
       
   993         * dom/ContainerNode.cpp:
       
   994         * dom/ContainerNode.h:
       
   995         * dom/DOMImplementation.cpp:
       
   996         * dom/DOMImplementation.h:
       
   997         * dom/DOMImplementation.idl:
       
   998         * dom/DocPtr.h:
       
   999         * dom/Document.cpp:
       
  1000         * dom/Document.h:
       
  1001         * dom/Document.idl:
       
  1002         * dom/DocumentFragment.cpp:
       
  1003         * dom/DocumentFragment.h:
       
  1004         * dom/DocumentFragment.idl:
       
  1005         * dom/DocumentMarker.h:
       
  1006         * dom/DocumentType.cpp:
       
  1007         * dom/DocumentType.h:
       
  1008         * dom/DocumentType.idl:
       
  1009         * dom/EditingText.cpp:
       
  1010         * dom/EditingText.h:
       
  1011         * dom/Element.cpp:
       
  1012         * dom/Element.h:
       
  1013         * dom/Element.idl:
       
  1014         * dom/Entity.cpp:
       
  1015         * dom/Entity.h:
       
  1016         * dom/Entity.idl:
       
  1017         * dom/EntityReference.cpp:
       
  1018         * dom/EntityReference.h:
       
  1019         * dom/EntityReference.idl:
       
  1020         * dom/Event.cpp:
       
  1021         * dom/Event.h:
       
  1022         * dom/Event.idl:
       
  1023         * dom/EventListener.h:
       
  1024         * dom/EventListener.idl:
       
  1025         * dom/EventNames.cpp:
       
  1026         * dom/EventNames.h:
       
  1027         * dom/EventTarget.idl:
       
  1028         * dom/EventTargetNode.cpp:
       
  1029         * dom/EventTargetNode.h:
       
  1030         * dom/ExceptionCode.h:
       
  1031         * dom/KeyboardEvent.cpp:
       
  1032         * dom/KeyboardEvent.h:
       
  1033         * dom/KeyboardEvent.idl:
       
  1034         * dom/MappedAttribute.cpp:
       
  1035         * dom/MappedAttribute.h:
       
  1036         * dom/MappedAttributeEntry.h:
       
  1037         * dom/MouseEvent.cpp:
       
  1038         * dom/MouseEvent.h:
       
  1039         * dom/MouseEvent.idl:
       
  1040         * dom/MouseRelatedEvent.cpp:
       
  1041         * dom/MouseRelatedEvent.h:
       
  1042         * dom/MutationEvent.cpp:
       
  1043         * dom/MutationEvent.h:
       
  1044         * dom/MutationEvent.idl:
       
  1045         * dom/NameNodeList.cpp:
       
  1046         * dom/NameNodeList.h:
       
  1047         * dom/NamedAttrMap.cpp:
       
  1048         * dom/NamedAttrMap.h:
       
  1049         * dom/NamedMappedAttrMap.cpp:
       
  1050         * dom/NamedMappedAttrMap.h:
       
  1051         * dom/NamedNodeMap.h:
       
  1052         * dom/NamedNodeMap.idl:
       
  1053         * dom/Node.cpp:
       
  1054         * dom/Node.h:
       
  1055         * dom/Node.idl:
       
  1056         * dom/NodeFilter.cpp:
       
  1057         * dom/NodeFilter.h:
       
  1058         * dom/NodeFilter.idl:
       
  1059         * dom/NodeFilterCondition.cpp:
       
  1060         * dom/NodeFilterCondition.h:
       
  1061         * dom/NodeIterator.cpp:
       
  1062         * dom/NodeIterator.h:
       
  1063         * dom/NodeIterator.idl:
       
  1064         * dom/NodeList.cpp:
       
  1065         * dom/NodeList.h:
       
  1066         * dom/NodeList.idl:
       
  1067         * dom/Notation.cpp:
       
  1068         * dom/Notation.h:
       
  1069         * dom/Notation.idl:
       
  1070         * dom/ProcessingInstruction.cpp:
       
  1071         * dom/ProcessingInstruction.h:
       
  1072         * dom/ProcessingInstruction.idl:
       
  1073         * dom/QualifiedName.cpp:
       
  1074         * dom/QualifiedName.h:
       
  1075         * dom/Range.cpp:
       
  1076         * dom/Range.h:
       
  1077         * dom/Range.idl:
       
  1078         * dom/RangeException.h:
       
  1079         * dom/RangeException.idl:
       
  1080         * dom/RegisteredEventListener.cpp:
       
  1081         * dom/RegisteredEventListener.h:
       
  1082         * dom/StyleElement.cpp:
       
  1083         * dom/StyleElement.h:
       
  1084         * dom/StyledElement.cpp:
       
  1085         * dom/StyledElement.h:
       
  1086         * dom/Text.cpp:
       
  1087         * dom/Text.h:
       
  1088         * dom/Text.idl:
       
  1089         * dom/Tokenizer.h:
       
  1090         * dom/Traversal.cpp:
       
  1091         * dom/Traversal.h:
       
  1092         * dom/TreeWalker.cpp:
       
  1093         * dom/TreeWalker.h:
       
  1094         * dom/TreeWalker.idl:
       
  1095         * dom/UIEvent.cpp:
       
  1096         * dom/UIEvent.h:
       
  1097         * dom/UIEvent.idl:
       
  1098         * dom/UIEventWithKeyState.cpp:
       
  1099         * dom/UIEventWithKeyState.h:
       
  1100         * dom/WheelEvent.cpp:
       
  1101         * dom/WheelEvent.h:
       
  1102         * dom/WheelEvent.idl:
       
  1103         * dom/XMLTokenizer.cpp:
       
  1104         * dom/XMLTokenizer.h:
       
  1105         * html/FormDataList.cpp:
       
  1106         * html/FormDataList.h:
       
  1107         * html/HTMLAnchorElement.cpp:
       
  1108         * html/HTMLAnchorElement.h:
       
  1109         * html/HTMLAnchorElement.idl:
       
  1110         * html/HTMLAppletElement.cpp:
       
  1111         * html/HTMLAppletElement.h:
       
  1112         * html/HTMLAppletElement.idl:
       
  1113         * html/HTMLAreaElement.cpp:
       
  1114         * html/HTMLAreaElement.h:
       
  1115         * html/HTMLAreaElement.idl:
       
  1116         * html/HTMLBRElement.cpp:
       
  1117         * html/HTMLBRElement.h:
       
  1118         * html/HTMLBRElement.idl:
       
  1119         * html/HTMLBaseElement.cpp:
       
  1120         * html/HTMLBaseElement.h:
       
  1121         * html/HTMLBaseElement.idl:
       
  1122         * html/HTMLBaseFontElement.cpp:
       
  1123         * html/HTMLBaseFontElement.h:
       
  1124         * html/HTMLBaseFontElement.idl:
       
  1125         * html/HTMLBlockquoteElement.cpp:
       
  1126         * html/HTMLBlockquoteElement.h:
       
  1127         * html/HTMLBlockquoteElement.idl:
       
  1128         * html/HTMLBodyElement.cpp:
       
  1129         * html/HTMLBodyElement.h:
       
  1130         * html/HTMLBodyElement.idl:
       
  1131         * html/HTMLButtonElement.cpp:
       
  1132         * html/HTMLButtonElement.h:
       
  1133         * html/HTMLButtonElement.idl:
       
  1134         * html/HTMLCollection.cpp:
       
  1135         * html/HTMLCollection.h:
       
  1136         * html/HTMLCollection.idl:
       
  1137         * html/HTMLDListElement.cpp:
       
  1138         * html/HTMLDListElement.h:
       
  1139         * html/HTMLDListElement.idl:
       
  1140         * html/HTMLDirectoryElement.cpp:
       
  1141         * html/HTMLDirectoryElement.h:
       
  1142         * html/HTMLDirectoryElement.idl:
       
  1143         * html/HTMLDivElement.cpp:
       
  1144         * html/HTMLDivElement.h:
       
  1145         * html/HTMLDivElement.idl:
       
  1146         * html/HTMLDocument.cpp:
       
  1147         * html/HTMLDocument.h:
       
  1148         * html/HTMLDocument.idl:
       
  1149         * html/HTMLElement.cpp:
       
  1150         * html/HTMLElement.h:
       
  1151         * html/HTMLElement.idl:
       
  1152         * html/HTMLElementFactory.cpp:
       
  1153         * html/HTMLElementFactory.h:
       
  1154         * html/HTMLEmbedElement.cpp:
       
  1155         * html/HTMLEmbedElement.h:
       
  1156         * html/HTMLEmbedElement.idl:
       
  1157         * html/HTMLEntityNames.gperf:
       
  1158         * html/HTMLFieldSetElement.cpp:
       
  1159         * html/HTMLFieldSetElement.h:
       
  1160         * html/HTMLFieldSetElement.idl:
       
  1161         * html/HTMLFontElement.cpp:
       
  1162         * html/HTMLFontElement.h:
       
  1163         * html/HTMLFontElement.idl:
       
  1164         * html/HTMLFormCollection.cpp:
       
  1165         * html/HTMLFormCollection.h:
       
  1166         * html/HTMLFormElement.cpp:
       
  1167         * html/HTMLFormElement.h:
       
  1168         * html/HTMLFormElement.idl:
       
  1169         * html/HTMLFrameElement.cpp:
       
  1170         * html/HTMLFrameElement.h:
       
  1171         * html/HTMLFrameElement.idl:
       
  1172         * html/HTMLFrameElementBase.cpp:
       
  1173         * html/HTMLFrameElementBase.h:
       
  1174         * html/HTMLFrameOwnerElement.cpp:
       
  1175         * html/HTMLFrameOwnerElement.h:
       
  1176         * html/HTMLFrameSetElement.cpp:
       
  1177         * html/HTMLFrameSetElement.h:
       
  1178         * html/HTMLFrameSetElement.idl:
       
  1179         * html/HTMLGenericFormElement.cpp:
       
  1180         * html/HTMLGenericFormElement.h:
       
  1181         * html/HTMLHRElement.cpp:
       
  1182         * html/HTMLHRElement.h:
       
  1183         * html/HTMLHRElement.idl:
       
  1184         * html/HTMLHeadElement.cpp:
       
  1185         * html/HTMLHeadElement.h:
       
  1186         * html/HTMLHeadElement.idl:
       
  1187         * html/HTMLHeadingElement.cpp:
       
  1188         * html/HTMLHeadingElement.h:
       
  1189         * html/HTMLHeadingElement.idl:
       
  1190         * html/HTMLHtmlElement.cpp:
       
  1191         * html/HTMLHtmlElement.h:
       
  1192         * html/HTMLHtmlElement.idl:
       
  1193         * html/HTMLIFrameElement.cpp:
       
  1194         * html/HTMLIFrameElement.h:
       
  1195         * html/HTMLIFrameElement.idl:
       
  1196         * html/HTMLImageElement.cpp:
       
  1197         * html/HTMLImageElement.h:
       
  1198         * html/HTMLImageElement.idl:
       
  1199         * html/HTMLImageLoader.cpp:
       
  1200         * html/HTMLImageLoader.h:
       
  1201         * html/HTMLInputElement.cpp:
       
  1202         * html/HTMLInputElement.h:
       
  1203         * html/HTMLInputElement.idl:
       
  1204         * html/HTMLIsIndexElement.cpp:
       
  1205         * html/HTMLIsIndexElement.h:
       
  1206         * html/HTMLIsIndexElement.idl:
       
  1207         * html/HTMLKeygenElement.cpp:
       
  1208         * html/HTMLKeygenElement.h:
       
  1209         * html/HTMLLIElement.cpp:
       
  1210         * html/HTMLLIElement.h:
       
  1211         * html/HTMLLIElement.idl:
       
  1212         * html/HTMLLabelElement.cpp:
       
  1213         * html/HTMLLabelElement.h:
       
  1214         * html/HTMLLabelElement.idl:
       
  1215         * html/HTMLLegendElement.cpp:
       
  1216         * html/HTMLLegendElement.h:
       
  1217         * html/HTMLLegendElement.idl:
       
  1218         * html/HTMLLinkElement.cpp:
       
  1219         * html/HTMLLinkElement.h:
       
  1220         * html/HTMLLinkElement.idl:
       
  1221         * html/HTMLMapElement.cpp:
       
  1222         * html/HTMLMapElement.h:
       
  1223         * html/HTMLMapElement.idl:
       
  1224         * html/HTMLMarqueeElement.cpp:
       
  1225         * html/HTMLMarqueeElement.h:
       
  1226         * html/HTMLMarqueeElement.idl:
       
  1227         * html/HTMLMenuElement.cpp:
       
  1228         * html/HTMLMenuElement.h:
       
  1229         * html/HTMLMenuElement.idl:
       
  1230         * html/HTMLMetaElement.cpp:
       
  1231         * html/HTMLMetaElement.h:
       
  1232         * html/HTMLMetaElement.idl:
       
  1233         * html/HTMLModElement.cpp:
       
  1234         * html/HTMLModElement.h:
       
  1235         * html/HTMLModElement.idl:
       
  1236         * html/HTMLNameCollection.cpp:
       
  1237         * html/HTMLNameCollection.h:
       
  1238         * html/HTMLOListElement.cpp:
       
  1239         * html/HTMLOListElement.h:
       
  1240         * html/HTMLOListElement.idl:
       
  1241         * html/HTMLObjectElement.cpp:
       
  1242         * html/HTMLObjectElement.h:
       
  1243         * html/HTMLObjectElement.idl:
       
  1244         * html/HTMLOptGroupElement.cpp:
       
  1245         * html/HTMLOptGroupElement.h:
       
  1246         * html/HTMLOptGroupElement.idl:
       
  1247         * html/HTMLOptionElement.cpp:
       
  1248         * html/HTMLOptionElement.h:
       
  1249         * html/HTMLOptionElement.idl:
       
  1250         * html/HTMLOptionsCollection.cpp:
       
  1251         * html/HTMLOptionsCollection.h:
       
  1252         * html/HTMLOptionsCollection.idl:
       
  1253         * html/HTMLParagraphElement.cpp:
       
  1254         * html/HTMLParagraphElement.h:
       
  1255         * html/HTMLParagraphElement.idl:
       
  1256         * html/HTMLParamElement.cpp:
       
  1257         * html/HTMLParamElement.h:
       
  1258         * html/HTMLParamElement.idl:
       
  1259         * html/HTMLParser.cpp:
       
  1260         * html/HTMLParser.h:
       
  1261         * html/HTMLPlugInElement.cpp:
       
  1262         * html/HTMLPlugInElement.h:
       
  1263         * html/HTMLPreElement.cpp:
       
  1264         * html/HTMLPreElement.h:
       
  1265         * html/HTMLPreElement.idl:
       
  1266         * html/HTMLQuoteElement.cpp:
       
  1267         * html/HTMLQuoteElement.h:
       
  1268         * html/HTMLQuoteElement.idl:
       
  1269         * html/HTMLScriptElement.cpp:
       
  1270         * html/HTMLScriptElement.h:
       
  1271         * html/HTMLScriptElement.idl:
       
  1272         * html/HTMLSelectElement.cpp:
       
  1273         * html/HTMLSelectElement.h:
       
  1274         * html/HTMLSelectElement.idl:
       
  1275         * html/HTMLStyleElement.cpp:
       
  1276         * html/HTMLStyleElement.h:
       
  1277         * html/HTMLStyleElement.idl:
       
  1278         * html/HTMLTableCaptionElement.cpp:
       
  1279         * html/HTMLTableCaptionElement.h:
       
  1280         * html/HTMLTableCaptionElement.idl:
       
  1281         * html/HTMLTableCellElement.cpp:
       
  1282         * html/HTMLTableCellElement.h:
       
  1283         * html/HTMLTableCellElement.idl:
       
  1284         * html/HTMLTableColElement.cpp:
       
  1285         * html/HTMLTableColElement.h:
       
  1286         * html/HTMLTableColElement.idl:
       
  1287         * html/HTMLTableElement.cpp:
       
  1288         * html/HTMLTableElement.h:
       
  1289         * html/HTMLTableElement.idl:
       
  1290         * html/HTMLTablePartElement.cpp:
       
  1291         * html/HTMLTablePartElement.h:
       
  1292         * html/HTMLTableRowElement.cpp:
       
  1293         * html/HTMLTableRowElement.h:
       
  1294         * html/HTMLTableRowElement.idl:
       
  1295         * html/HTMLTableSectionElement.cpp:
       
  1296         * html/HTMLTableSectionElement.h:
       
  1297         * html/HTMLTableSectionElement.idl:
       
  1298         * html/HTMLTextAreaElement.cpp:
       
  1299         * html/HTMLTextAreaElement.h:
       
  1300         * html/HTMLTextAreaElement.idl:
       
  1301         * html/HTMLTitleElement.cpp:
       
  1302         * html/HTMLTitleElement.h:
       
  1303         * html/HTMLTitleElement.idl:
       
  1304         * html/HTMLTokenizer.cpp:
       
  1305         * html/HTMLTokenizer.h:
       
  1306         * html/HTMLUListElement.cpp:
       
  1307         * html/HTMLUListElement.h:
       
  1308         * html/HTMLUListElement.idl:
       
  1309         * ksvg2/css/SVGCSSParser.cpp:
       
  1310         * ksvg2/css/SVGCSSStyleSelector.cpp:
       
  1311         * ksvg2/css/SVGRenderStyle.cpp:
       
  1312         * ksvg2/css/SVGRenderStyle.h:
       
  1313         * ksvg2/css/SVGRenderStyleDefs.cpp:
       
  1314         * ksvg2/css/SVGRenderStyleDefs.h:
       
  1315         * ksvg2/events/JSSVGLazyEventListener.cpp:
       
  1316         * ksvg2/events/JSSVGLazyEventListener.h:
       
  1317         * ksvg2/events/SVGZoomEvent.cpp:
       
  1318         * ksvg2/events/SVGZoomEvent.h:
       
  1319         * ksvg2/misc/KCanvasRenderingStyle.cpp:
       
  1320         * ksvg2/misc/KCanvasRenderingStyle.h:
       
  1321         * ksvg2/misc/PointerEventsHitRules.cpp:
       
  1322         * ksvg2/misc/PointerEventsHitRules.h:
       
  1323         * ksvg2/misc/SVGDocumentExtensions.cpp:
       
  1324         * ksvg2/misc/SVGDocumentExtensions.h:
       
  1325         * ksvg2/misc/SVGImageLoader.cpp:
       
  1326         * ksvg2/misc/SVGImageLoader.h:
       
  1327         * ksvg2/misc/SVGTimer.cpp:
       
  1328         * ksvg2/misc/SVGTimer.h:
       
  1329         * ksvg2/misc/TimeScheduler.cpp:
       
  1330         * ksvg2/misc/TimeScheduler.h:
       
  1331         * ksvg2/scripts/cssmakeprops:
       
  1332         * ksvg2/scripts/cssmakevalues:
       
  1333         * ksvg2/svg/ColorDistance.cpp:
       
  1334         * ksvg2/svg/ColorDistance.h:
       
  1335         * ksvg2/svg/GradientAttributes.h:
       
  1336         * ksvg2/svg/LinearGradientAttributes.h:
       
  1337         * ksvg2/svg/PatternAttributes.h:
       
  1338         * ksvg2/svg/RadialGradientAttributes.h:
       
  1339         * ksvg2/svg/SVGAElement.cpp:
       
  1340         * ksvg2/svg/SVGAElement.h:
       
  1341         * ksvg2/svg/SVGAngle.cpp:
       
  1342         * ksvg2/svg/SVGAngle.h:
       
  1343         * ksvg2/svg/SVGAngle.idl:
       
  1344         * ksvg2/svg/SVGAnimateColorElement.cpp:
       
  1345         * ksvg2/svg/SVGAnimateColorElement.h:
       
  1346         * ksvg2/svg/SVGAnimateElement.cpp:
       
  1347         * ksvg2/svg/SVGAnimateElement.h:
       
  1348         * ksvg2/svg/SVGAnimateMotionElement.cpp:
       
  1349         * ksvg2/svg/SVGAnimateMotionElement.h:
       
  1350         * ksvg2/svg/SVGAnimateTransformElement.cpp:
       
  1351         * ksvg2/svg/SVGAnimateTransformElement.h:
       
  1352         * ksvg2/svg/SVGAnimatedPathData.cpp:
       
  1353         * ksvg2/svg/SVGAnimatedPathData.h:
       
  1354         * ksvg2/svg/SVGAnimatedPoints.cpp:
       
  1355         * ksvg2/svg/SVGAnimatedPoints.h:
       
  1356         * ksvg2/svg/SVGAnimatedTemplate.h:
       
  1357         * ksvg2/svg/SVGAnimationElement.cpp:
       
  1358         * ksvg2/svg/SVGAnimationElement.h:
       
  1359         * ksvg2/svg/SVGCircleElement.cpp:
       
  1360         * ksvg2/svg/SVGCircleElement.h:
       
  1361         * ksvg2/svg/SVGClipPathElement.cpp:
       
  1362         * ksvg2/svg/SVGClipPathElement.h:
       
  1363         * ksvg2/svg/SVGColor.cpp:
       
  1364         * ksvg2/svg/SVGColor.h:
       
  1365         * ksvg2/svg/SVGColor.idl:
       
  1366         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
       
  1367         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
       
  1368         * ksvg2/svg/SVGCursorElement.cpp:
       
  1369         * ksvg2/svg/SVGCursorElement.h:
       
  1370         * ksvg2/svg/SVGDefsElement.cpp:
       
  1371         * ksvg2/svg/SVGDefsElement.h:
       
  1372         * ksvg2/svg/SVGDescElement.cpp:
       
  1373         * ksvg2/svg/SVGDescElement.h:
       
  1374         * ksvg2/svg/SVGDocument.cpp:
       
  1375         * ksvg2/svg/SVGDocument.h:
       
  1376         * ksvg2/svg/SVGDocument.idl:
       
  1377         * ksvg2/svg/SVGElement.cpp:
       
  1378         * ksvg2/svg/SVGElement.h:
       
  1379         * ksvg2/svg/SVGElement.idl:
       
  1380         * ksvg2/svg/SVGElementInstance.cpp:
       
  1381         * ksvg2/svg/SVGElementInstance.h:
       
  1382         * ksvg2/svg/SVGElementInstanceList.cpp:
       
  1383         * ksvg2/svg/SVGElementInstanceList.h:
       
  1384         * ksvg2/svg/SVGEllipseElement.cpp:
       
  1385         * ksvg2/svg/SVGEllipseElement.h:
       
  1386         * ksvg2/svg/SVGException.h:
       
  1387         * ksvg2/svg/SVGExternalResourcesRequired.cpp:
       
  1388         * ksvg2/svg/SVGExternalResourcesRequired.h:
       
  1389         * ksvg2/svg/SVGFEBlendElement.cpp:
       
  1390         * ksvg2/svg/SVGFEBlendElement.h:
       
  1391         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
       
  1392         * ksvg2/svg/SVGFEColorMatrixElement.h:
       
  1393         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
       
  1394         * ksvg2/svg/SVGFEComponentTransferElement.h:
       
  1395         * ksvg2/svg/SVGFECompositeElement.cpp:
       
  1396         * ksvg2/svg/SVGFECompositeElement.h:
       
  1397         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
       
  1398         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
       
  1399         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
       
  1400         * ksvg2/svg/SVGFEDisplacementMapElement.h:
       
  1401         * ksvg2/svg/SVGFEDistantLightElement.cpp:
       
  1402         * ksvg2/svg/SVGFEDistantLightElement.h:
       
  1403         * ksvg2/svg/SVGFEFloodElement.cpp:
       
  1404         * ksvg2/svg/SVGFEFloodElement.h:
       
  1405         * ksvg2/svg/SVGFEFuncAElement.cpp:
       
  1406         * ksvg2/svg/SVGFEFuncAElement.h:
       
  1407         * ksvg2/svg/SVGFEFuncBElement.cpp:
       
  1408         * ksvg2/svg/SVGFEFuncBElement.h:
       
  1409         * ksvg2/svg/SVGFEFuncGElement.cpp:
       
  1410         * ksvg2/svg/SVGFEFuncGElement.h:
       
  1411         * ksvg2/svg/SVGFEFuncRElement.cpp:
       
  1412         * ksvg2/svg/SVGFEFuncRElement.h:
       
  1413         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
       
  1414         * ksvg2/svg/SVGFEGaussianBlurElement.h:
       
  1415         * ksvg2/svg/SVGFEImageElement.cpp:
       
  1416         * ksvg2/svg/SVGFEImageElement.h:
       
  1417         * ksvg2/svg/SVGFELightElement.cpp:
       
  1418         * ksvg2/svg/SVGFELightElement.h:
       
  1419         * ksvg2/svg/SVGFEMergeElement.cpp:
       
  1420         * ksvg2/svg/SVGFEMergeElement.h:
       
  1421         * ksvg2/svg/SVGFEMergeNodeElement.cpp:
       
  1422         * ksvg2/svg/SVGFEMergeNodeElement.h:
       
  1423         * ksvg2/svg/SVGFEOffsetElement.cpp:
       
  1424         * ksvg2/svg/SVGFEOffsetElement.h:
       
  1425         * ksvg2/svg/SVGFEPointLightElement.cpp:
       
  1426         * ksvg2/svg/SVGFEPointLightElement.h:
       
  1427         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
       
  1428         * ksvg2/svg/SVGFESpecularLightingElement.h:
       
  1429         * ksvg2/svg/SVGFESpotLightElement.cpp:
       
  1430         * ksvg2/svg/SVGFESpotLightElement.h:
       
  1431         * ksvg2/svg/SVGFETileElement.cpp:
       
  1432         * ksvg2/svg/SVGFETileElement.h:
       
  1433         * ksvg2/svg/SVGFETurbulenceElement.cpp:
       
  1434         * ksvg2/svg/SVGFETurbulenceElement.h:
       
  1435         * ksvg2/svg/SVGFilterElement.cpp:
       
  1436         * ksvg2/svg/SVGFilterElement.h:
       
  1437         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
       
  1438         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
       
  1439         * ksvg2/svg/SVGFitToViewBox.cpp:
       
  1440         * ksvg2/svg/SVGFitToViewBox.h:
       
  1441         * ksvg2/svg/SVGForeignObjectElement.cpp:
       
  1442         * ksvg2/svg/SVGForeignObjectElement.h:
       
  1443         * ksvg2/svg/SVGGElement.cpp:
       
  1444         * ksvg2/svg/SVGGElement.h:
       
  1445         * ksvg2/svg/SVGGradientElement.cpp:
       
  1446         * ksvg2/svg/SVGGradientElement.h:
       
  1447         * ksvg2/svg/SVGImageElement.cpp:
       
  1448         * ksvg2/svg/SVGImageElement.h:
       
  1449         * ksvg2/svg/SVGLangSpace.cpp:
       
  1450         * ksvg2/svg/SVGLangSpace.h:
       
  1451         * ksvg2/svg/SVGLength.cpp:
       
  1452         * ksvg2/svg/SVGLength.h:
       
  1453         * ksvg2/svg/SVGLength.idl:
       
  1454         * ksvg2/svg/SVGLengthList.cpp:
       
  1455         * ksvg2/svg/SVGLengthList.h:
       
  1456         * ksvg2/svg/SVGLineElement.cpp:
       
  1457         * ksvg2/svg/SVGLineElement.h:
       
  1458         * ksvg2/svg/SVGLinearGradientElement.cpp:
       
  1459         * ksvg2/svg/SVGLinearGradientElement.h:
       
  1460         * ksvg2/svg/SVGList.h:
       
  1461         * ksvg2/svg/SVGListTraits.h:
       
  1462         * ksvg2/svg/SVGLocatable.cpp:
       
  1463         * ksvg2/svg/SVGLocatable.h:
       
  1464         * ksvg2/svg/SVGMPathElement.cpp:
       
  1465         * ksvg2/svg/SVGMPathElement.h:
       
  1466         * ksvg2/svg/SVGMarkerElement.cpp:
       
  1467         * ksvg2/svg/SVGMarkerElement.h:
       
  1468         * ksvg2/svg/SVGMaskElement.cpp:
       
  1469         * ksvg2/svg/SVGMaskElement.h:
       
  1470         * ksvg2/svg/SVGMatrix.idl:
       
  1471         * ksvg2/svg/SVGMetadataElement.cpp:
       
  1472         * ksvg2/svg/SVGMetadataElement.h:
       
  1473         * ksvg2/svg/SVGMetadataElement.idl:
       
  1474         * ksvg2/svg/SVGNumber.idl:
       
  1475         * ksvg2/svg/SVGNumberList.cpp:
       
  1476         * ksvg2/svg/SVGNumberList.h:
       
  1477         * ksvg2/svg/SVGPaint.cpp:
       
  1478         * ksvg2/svg/SVGPaint.h:
       
  1479         * ksvg2/svg/SVGParserUtilities.cpp:
       
  1480         * ksvg2/svg/SVGParserUtilities.h:
       
  1481         * ksvg2/svg/SVGPathElement.cpp:
       
  1482         * ksvg2/svg/SVGPathElement.h:
       
  1483         * ksvg2/svg/SVGPathSeg.h:
       
  1484         * ksvg2/svg/SVGPathSegArc.cpp:
       
  1485         * ksvg2/svg/SVGPathSegArc.h:
       
  1486         * ksvg2/svg/SVGPathSegClosePath.cpp:
       
  1487         * ksvg2/svg/SVGPathSegClosePath.h:
       
  1488         * ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
       
  1489         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
       
  1490         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
       
  1491         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
       
  1492         * ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
       
  1493         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
       
  1494         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
       
  1495         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
       
  1496         * ksvg2/svg/SVGPathSegLineto.cpp:
       
  1497         * ksvg2/svg/SVGPathSegLineto.h:
       
  1498         * ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
       
  1499         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
       
  1500         * ksvg2/svg/SVGPathSegLinetoVertical.cpp:
       
  1501         * ksvg2/svg/SVGPathSegLinetoVertical.h:
       
  1502         * ksvg2/svg/SVGPathSegList.cpp:
       
  1503         * ksvg2/svg/SVGPathSegList.h:
       
  1504         * ksvg2/svg/SVGPathSegMoveto.cpp:
       
  1505         * ksvg2/svg/SVGPathSegMoveto.h:
       
  1506         * ksvg2/svg/SVGPatternElement.cpp:
       
  1507         * ksvg2/svg/SVGPatternElement.h:
       
  1508         * ksvg2/svg/SVGPoint.idl:
       
  1509         * ksvg2/svg/SVGPointList.cpp:
       
  1510         * ksvg2/svg/SVGPointList.h:
       
  1511         * ksvg2/svg/SVGPolyElement.cpp:
       
  1512         * ksvg2/svg/SVGPolyElement.h:
       
  1513         * ksvg2/svg/SVGPolygonElement.cpp:
       
  1514         * ksvg2/svg/SVGPolygonElement.h:
       
  1515         * ksvg2/svg/SVGPolylineElement.cpp:
       
  1516         * ksvg2/svg/SVGPolylineElement.h:
       
  1517         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
       
  1518         * ksvg2/svg/SVGPreserveAspectRatio.h:
       
  1519         * ksvg2/svg/SVGRadialGradientElement.cpp:
       
  1520         * ksvg2/svg/SVGRadialGradientElement.h:
       
  1521         * ksvg2/svg/SVGRect.idl:
       
  1522         * ksvg2/svg/SVGRectElement.cpp:
       
  1523         * ksvg2/svg/SVGRectElement.h:
       
  1524         * ksvg2/svg/SVGRenderingIntent.h:
       
  1525         * ksvg2/svg/SVGSVGElement.cpp:
       
  1526         * ksvg2/svg/SVGSVGElement.h:
       
  1527         * ksvg2/svg/SVGSVGElement.idl:
       
  1528         * ksvg2/svg/SVGScriptElement.cpp:
       
  1529         * ksvg2/svg/SVGScriptElement.h:
       
  1530         * ksvg2/svg/SVGSetElement.cpp:
       
  1531         * ksvg2/svg/SVGSetElement.h:
       
  1532         * ksvg2/svg/SVGStopElement.cpp:
       
  1533         * ksvg2/svg/SVGStopElement.h:
       
  1534         * ksvg2/svg/SVGStringList.cpp:
       
  1535         * ksvg2/svg/SVGStringList.h:
       
  1536         * ksvg2/svg/SVGStylable.cpp:
       
  1537         * ksvg2/svg/SVGStylable.h:
       
  1538         * ksvg2/svg/SVGStyleElement.cpp:
       
  1539         * ksvg2/svg/SVGStyleElement.h:
       
  1540         * ksvg2/svg/SVGStyledElement.cpp:
       
  1541         * ksvg2/svg/SVGStyledElement.h:
       
  1542         * ksvg2/svg/SVGStyledLocatableElement.cpp:
       
  1543         * ksvg2/svg/SVGStyledLocatableElement.h:
       
  1544         * ksvg2/svg/SVGStyledTransformableElement.cpp:
       
  1545         * ksvg2/svg/SVGStyledTransformableElement.h:
       
  1546         * ksvg2/svg/SVGSwitchElement.cpp:
       
  1547         * ksvg2/svg/SVGSwitchElement.h:
       
  1548         * ksvg2/svg/SVGSymbolElement.cpp:
       
  1549         * ksvg2/svg/SVGSymbolElement.h:
       
  1550         * ksvg2/svg/SVGTRefElement.cpp:
       
  1551         * ksvg2/svg/SVGTRefElement.h:
       
  1552         * ksvg2/svg/SVGTSpanElement.cpp:
       
  1553         * ksvg2/svg/SVGTSpanElement.h:
       
  1554         * ksvg2/svg/SVGTests.cpp:
       
  1555         * ksvg2/svg/SVGTests.h:
       
  1556         * ksvg2/svg/SVGTextContentElement.cpp:
       
  1557         * ksvg2/svg/SVGTextContentElement.h:
       
  1558         * ksvg2/svg/SVGTextElement.cpp:
       
  1559         * ksvg2/svg/SVGTextElement.h:
       
  1560         * ksvg2/svg/SVGTextPositioningElement.cpp:
       
  1561         * ksvg2/svg/SVGTextPositioningElement.h:
       
  1562         * ksvg2/svg/SVGTitleElement.cpp:
       
  1563         * ksvg2/svg/SVGTitleElement.h:
       
  1564         * ksvg2/svg/SVGTransform.cpp:
       
  1565         * ksvg2/svg/SVGTransform.h:
       
  1566         * ksvg2/svg/SVGTransform.idl:
       
  1567         * ksvg2/svg/SVGTransformDistance.cpp:
       
  1568         * ksvg2/svg/SVGTransformDistance.h:
       
  1569         * ksvg2/svg/SVGTransformList.cpp:
       
  1570         * ksvg2/svg/SVGTransformList.h:
       
  1571         * ksvg2/svg/SVGTransformable.cpp:
       
  1572         * ksvg2/svg/SVGTransformable.h:
       
  1573         * ksvg2/svg/SVGURIReference.cpp:
       
  1574         * ksvg2/svg/SVGURIReference.h:
       
  1575         * ksvg2/svg/SVGUnitTypes.h:
       
  1576         * ksvg2/svg/SVGUseElement.cpp:
       
  1577         * ksvg2/svg/SVGUseElement.h:
       
  1578         * ksvg2/svg/SVGViewElement.cpp:
       
  1579         * ksvg2/svg/SVGViewElement.h:
       
  1580         * ksvg2/svg/SVGZoomAndPan.cpp:
       
  1581         * ksvg2/svg/SVGZoomAndPan.h:
       
  1582         * loader/Cache.cpp:
       
  1583         * loader/Cache.h:
       
  1584         * loader/CachedCSSStyleSheet.cpp:
       
  1585         * loader/CachedCSSStyleSheet.h:
       
  1586         * loader/CachedImage.cpp:
       
  1587         * loader/CachedImage.h:
       
  1588         * loader/CachedResource.cpp:
       
  1589         * loader/CachedResource.h:
       
  1590         * loader/CachedResourceClient.h:
       
  1591         * loader/CachedResourceClientWalker.cpp:
       
  1592         * loader/CachedResourceClientWalker.h:
       
  1593         * loader/CachedScript.cpp:
       
  1594         * loader/CachedScript.h:
       
  1595         * loader/CachedXBLDocument.cpp:
       
  1596         * loader/CachedXBLDocument.h:
       
  1597         * loader/CachedXSLStyleSheet.cpp:
       
  1598         * loader/CachedXSLStyleSheet.h:
       
  1599         * loader/DocLoader.cpp:
       
  1600         * loader/DocLoader.h:
       
  1601         * loader/FTPDirectoryParser.cpp:
       
  1602         * loader/FTPDirectoryParser.h:
       
  1603         * loader/Request.cpp:
       
  1604         * loader/Request.h:
       
  1605         * loader/TextResourceDecoder.cpp:
       
  1606         * loader/TextResourceDecoder.h:
       
  1607         * loader/loader.cpp:
       
  1608         * loader/loader.h:
       
  1609         * page/Chrome.cpp:
       
  1610         * page/Chrome.h:
       
  1611         * page/ChromeClient.h:
       
  1612         * page/Frame.cpp:
       
  1613         * page/Frame.h:
       
  1614         * page/FramePrivate.h:
       
  1615         * page/FrameTree.cpp:
       
  1616         * page/FrameTree.h:
       
  1617         * page/FrameView.cpp:
       
  1618         * page/FrameView.h:
       
  1619         * page/MouseEventWithHitTestResults.cpp:
       
  1620         * page/MouseEventWithHitTestResults.h:
       
  1621         * page/Page.cpp:
       
  1622         * page/Page.h:
       
  1623         * page/Plugin.h:
       
  1624         * page/mac/ChromeMac.mm:
       
  1625         * platform/Arena.cpp:
       
  1626         * platform/Arena.h:
       
  1627         * platform/AtomicString.cpp:
       
  1628         * platform/AtomicString.h:
       
  1629         * platform/AtomicStringImpl.h:
       
  1630         * platform/BidiContext.cpp:
       
  1631         * platform/BidiContext.h:
       
  1632         * platform/BidiResolver.h:
       
  1633         * platform/Font.cpp:
       
  1634         * platform/Font.h:
       
  1635         * platform/FontData.h:
       
  1636         * platform/FontDescription.h:
       
  1637         * platform/FontFallbackList.h:
       
  1638         * platform/PlatformString.h:
       
  1639         * platform/PopupMenu.h:
       
  1640         * platform/PopupMenuClient.h:
       
  1641         * platform/SearchPopupMenu.h:
       
  1642         * platform/SegmentedString.cpp:
       
  1643         * platform/SegmentedString.h:
       
  1644         * platform/Shared.h:
       
  1645         * platform/StaticConstructors.h:
       
  1646         * platform/String.cpp:
       
  1647         * platform/StringHash.h:
       
  1648         * platform/StringImpl.cpp:
       
  1649         * platform/StringImpl.h:
       
  1650         * platform/TextBreakIterator.h:
       
  1651         * platform/TextBreakIteratorICU.cpp:
       
  1652         * platform/TextBreakIteratorInternalICU.h:
       
  1653         * platform/TextStyle.h:
       
  1654         * platform/UnicodeRange.cpp:
       
  1655         * platform/UnicodeRange.h:
       
  1656         * platform/cf/StringCF.cpp:
       
  1657         * platform/cf/StringImplCF.cpp:
       
  1658         * platform/graphics/FloatPoint3D.cpp:
       
  1659         * platform/graphics/FloatPoint3D.h:
       
  1660         * platform/graphics/Icon.h:
       
  1661         * platform/graphics/IntSizeHash.h:
       
  1662         * platform/graphics/PathTraversalState.cpp:
       
  1663         * platform/graphics/cairo/CairoPath.h:
       
  1664         * platform/graphics/cairo/PathCairo.cpp:
       
  1665         * platform/graphics/mac/IconMac.mm:
       
  1666         * platform/graphics/qt/IconQt.cpp:
       
  1667         * platform/graphics/svg/SVGResourceFilter.cpp:
       
  1668         * platform/graphics/svg/SVGResourceFilter.h:
       
  1669         * platform/graphics/svg/cg/SVGPaintServerCg.cpp:
       
  1670         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
       
  1671         * platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp:
       
  1672         * platform/graphics/svg/cg/SVGPaintServerSolidCg.cpp:
       
  1673         * platform/graphics/svg/filters/SVGDistantLightSource.h:
       
  1674         * platform/graphics/svg/filters/SVGFEBlend.cpp:
       
  1675         * platform/graphics/svg/filters/SVGFEBlend.h:
       
  1676         * platform/graphics/svg/filters/SVGFEColorMatrix.cpp:
       
  1677         * platform/graphics/svg/filters/SVGFEColorMatrix.h:
       
  1678         * platform/graphics/svg/filters/SVGFEComponentTransfer.cpp:
       
  1679         * platform/graphics/svg/filters/SVGFEComponentTransfer.h:
       
  1680         * platform/graphics/svg/filters/SVGFEComposite.cpp:
       
  1681         * platform/graphics/svg/filters/SVGFEComposite.h:
       
  1682         * platform/graphics/svg/filters/SVGFEConvolveMatrix.cpp:
       
  1683         * platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
       
  1684         * platform/graphics/svg/filters/SVGFEDiffuseLighting.cpp:
       
  1685         * platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
       
  1686         * platform/graphics/svg/filters/SVGFEDisplacementMap.cpp:
       
  1687         * platform/graphics/svg/filters/SVGFEDisplacementMap.h:
       
  1688         * platform/graphics/svg/filters/SVGFEFlood.cpp:
       
  1689         * platform/graphics/svg/filters/SVGFEFlood.h:
       
  1690         * platform/graphics/svg/filters/SVGFEGaussianBlur.cpp:
       
  1691         * platform/graphics/svg/filters/SVGFEGaussianBlur.h:
       
  1692         * platform/graphics/svg/filters/SVGFEImage.cpp:
       
  1693         * platform/graphics/svg/filters/SVGFEImage.h:
       
  1694         * platform/graphics/svg/filters/SVGFEMerge.cpp:
       
  1695         * platform/graphics/svg/filters/SVGFEMerge.h:
       
  1696         * platform/graphics/svg/filters/SVGFEMorphology.cpp:
       
  1697         * platform/graphics/svg/filters/SVGFEMorphology.h:
       
  1698         * platform/graphics/svg/filters/SVGFEOffset.cpp:
       
  1699         * platform/graphics/svg/filters/SVGFEOffset.h:
       
  1700         * platform/graphics/svg/filters/SVGFESpecularLighting.cpp:
       
  1701         * platform/graphics/svg/filters/SVGFESpecularLighting.h:
       
  1702         * platform/graphics/svg/filters/SVGFETile.h:
       
  1703         * platform/graphics/svg/filters/SVGFETurbulence.cpp:
       
  1704         * platform/graphics/svg/filters/SVGFETurbulence.h:
       
  1705         * platform/graphics/svg/filters/SVGFilterEffect.cpp:
       
  1706         * platform/graphics/svg/filters/SVGFilterEffect.h:
       
  1707         * platform/graphics/svg/filters/SVGLightSource.cpp:
       
  1708         * platform/graphics/svg/filters/SVGLightSource.h:
       
  1709         * platform/graphics/svg/filters/SVGPointLightSource.h:
       
  1710         * platform/graphics/svg/filters/SVGSpotLightSource.h:
       
  1711         * platform/graphics/svg/filters/cg/SVGFEBlendCg.mm:
       
  1712         * platform/graphics/svg/filters/cg/SVGFEColorMatrixCg.mm:
       
  1713         * platform/graphics/svg/filters/cg/SVGFEComponentTransferCg.mm:
       
  1714         * platform/graphics/svg/filters/cg/SVGFECompositeCg.mm:
       
  1715         * platform/graphics/svg/filters/cg/SVGFEDiffuseLightingCg.mm:
       
  1716         * platform/graphics/svg/filters/cg/SVGFEDisplacementMapCg.mm:
       
  1717         * platform/graphics/svg/filters/cg/SVGFEFloodCg.mm:
       
  1718         * platform/graphics/svg/filters/cg/SVGFEGaussianBlurCg.mm:
       
  1719         * platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
       
  1720         * platform/graphics/svg/filters/cg/SVGFEHelpersCg.mm:
       
  1721         * platform/graphics/svg/filters/cg/SVGFEImageCg.mm:
       
  1722         * platform/graphics/svg/filters/cg/SVGFEMergeCg.mm:
       
  1723         * platform/graphics/svg/filters/cg/SVGFEOffsetCg.mm:
       
  1724         * platform/graphics/svg/filters/cg/SVGFESpecularLightingCg.mm:
       
  1725         * platform/graphics/svg/filters/cg/SVGFETileCg.mm:
       
  1726         * platform/graphics/svg/filters/cg/SVGFilterEffectCg.mm:
       
  1727         * platform/graphics/svg/qt/RenderPathQt.cpp:
       
  1728         * platform/graphics/svg/qt/SVGPaintServerGradientQt.cpp:
       
  1729         * platform/graphics/svg/qt/SVGPaintServerLinearGradientQt.cpp:
       
  1730         * platform/graphics/svg/qt/SVGPaintServerPatternQt.cpp:
       
  1731         * platform/graphics/svg/qt/SVGPaintServerQt.cpp:
       
  1732         * platform/graphics/svg/qt/SVGPaintServerRadialGradientQt.cpp:
       
  1733         * platform/graphics/svg/qt/SVGPaintServerSolidQt.cpp:
       
  1734         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
       
  1735         * platform/graphics/svg/qt/SVGResourceFilterQt.cpp:
       
  1736         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
       
  1737         * platform/graphics/win/IconWin.cpp:
       
  1738         * platform/gtk/FontPlatformData.h:
       
  1739         * platform/gtk/FontPlatformDataGtk.cpp:
       
  1740         * platform/gtk/PopupMenuGtk.cpp:
       
  1741         * platform/gtk/RenderThemeGtk.cpp:
       
  1742         * platform/gtk/RenderThemeGtk.h:
       
  1743         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
       
  1744         * platform/image-decoders/png/PNGImageDecoder.cpp:
       
  1745         * platform/mac/FontMac.mm:
       
  1746         * platform/mac/FontPlatformData.h:
       
  1747         * platform/mac/LocalCurrentGraphicsContext.h:
       
  1748         * platform/mac/LocalCurrentGraphicsContext.mm:
       
  1749         * platform/mac/PopupMenuMac.mm:
       
  1750         * platform/mac/SearchPopupMenuMac.mm:
       
  1751         * platform/mac/StringImplMac.mm:
       
  1752         * platform/mac/StringMac.mm:
       
  1753         * platform/mac/TextBreakIteratorInternalICUMac.mm:
       
  1754         * platform/network/FormData.cpp:
       
  1755         * platform/network/FormData.h:
       
  1756         * platform/qt/FileChooserQt.cpp:
       
  1757         * platform/qt/FontQt.cpp:
       
  1758         * platform/qt/MenuEventProxy.h:
       
  1759         * platform/qt/PlugInInfoStoreQt.cpp:
       
  1760         * platform/qt/PopupMenuQt.cpp:
       
  1761         * platform/qt/QWebPopup.cpp:
       
  1762         * platform/qt/QWebPopup.h:
       
  1763         * platform/qt/RenderThemeQt.cpp:
       
  1764         * platform/qt/RenderThemeQt.h:
       
  1765         * platform/qt/SearchPopupMenuQt.cpp:
       
  1766         * platform/qt/TextBreakIteratorQt.cpp:
       
  1767         * platform/qt/WheelEventQt.cpp:
       
  1768         * platform/win/FontPlatformData.h:
       
  1769         * platform/win/FontPlatformDataWin.cpp:
       
  1770         * platform/win/PopupMenuWin.cpp:
       
  1771         * platform/win/SearchPopupMenuWin.cpp:
       
  1772         * platform/win/TextBreakIteratorInternalICUWin.cpp:
       
  1773         * rendering/AutoTableLayout.cpp:
       
  1774         * rendering/AutoTableLayout.h:
       
  1775         * rendering/CounterNode.cpp:
       
  1776         * rendering/CounterNode.h:
       
  1777         * rendering/DataRef.h:
       
  1778         * rendering/EllipsisBox.cpp:
       
  1779         * rendering/EllipsisBox.h:
       
  1780         * rendering/FixedTableLayout.cpp:
       
  1781         * rendering/FixedTableLayout.h:
       
  1782         * rendering/GapRects.h:
       
  1783         * rendering/HitTestRequest.h:
       
  1784         * rendering/HitTestResult.cpp:
       
  1785         * rendering/HitTestResult.h:
       
  1786         * rendering/InlineBox.cpp:
       
  1787         * rendering/InlineBox.h:
       
  1788         * rendering/InlineFlowBox.cpp:
       
  1789         * rendering/InlineFlowBox.h:
       
  1790         * rendering/InlineRunBox.h:
       
  1791         * rendering/InlineTextBox.cpp:
       
  1792         * rendering/InlineTextBox.h:
       
  1793         * rendering/Length.h:
       
  1794         * rendering/ListMarkerBox.cpp:
       
  1795         * rendering/ListMarkerBox.h:
       
  1796         * rendering/RenderApplet.cpp:
       
  1797         * rendering/RenderApplet.h:
       
  1798         * rendering/RenderArena.cpp:
       
  1799         * rendering/RenderArena.h:
       
  1800         * rendering/RenderBR.cpp:
       
  1801         * rendering/RenderBR.h:
       
  1802         * rendering/RenderBlock.cpp:
       
  1803         * rendering/RenderBlock.h:
       
  1804         * rendering/RenderBox.cpp:
       
  1805         * rendering/RenderBox.h:
       
  1806         * rendering/RenderButton.cpp:
       
  1807         * rendering/RenderButton.h:
       
  1808         * rendering/RenderContainer.cpp:
       
  1809         * rendering/RenderContainer.h:
       
  1810         * rendering/RenderCounter.cpp:
       
  1811         * rendering/RenderCounter.h:
       
  1812         * rendering/RenderFieldset.cpp:
       
  1813         * rendering/RenderFieldset.h:
       
  1814         * rendering/RenderFileUploadControl.cpp:
       
  1815         * rendering/RenderFileUploadControl.h:
       
  1816         * rendering/RenderFlexibleBox.cpp:
       
  1817         * rendering/RenderFlexibleBox.h:
       
  1818         * rendering/RenderFlow.cpp:
       
  1819         * rendering/RenderFlow.h:
       
  1820         * rendering/RenderForeignObject.cpp:
       
  1821         * rendering/RenderForeignObject.h:
       
  1822         * rendering/RenderFrame.cpp:
       
  1823         * rendering/RenderFrame.h:
       
  1824         * rendering/RenderFrameSet.cpp:
       
  1825         * rendering/RenderFrameSet.h:
       
  1826         * rendering/RenderImage.cpp:
       
  1827         * rendering/RenderImage.h:
       
  1828         * rendering/RenderInline.cpp:
       
  1829         * rendering/RenderInline.h:
       
  1830         * rendering/RenderLayer.cpp:
       
  1831         * rendering/RenderLayer.h:
       
  1832         * rendering/RenderLegend.cpp:
       
  1833         * rendering/RenderLegend.h:
       
  1834         * rendering/RenderListItem.cpp:
       
  1835         * rendering/RenderListItem.h:
       
  1836         * rendering/RenderListMarker.cpp:
       
  1837         * rendering/RenderListMarker.h:
       
  1838         * rendering/RenderMenuList.cpp:
       
  1839         * rendering/RenderMenuList.h:
       
  1840         * rendering/RenderObject.cpp:
       
  1841         * rendering/RenderObject.h:
       
  1842         * rendering/RenderPart.cpp:
       
  1843         * rendering/RenderPart.h:
       
  1844         * rendering/RenderPartObject.cpp:
       
  1845         * rendering/RenderPartObject.h:
       
  1846         * rendering/RenderPath.cpp:
       
  1847         * rendering/RenderPath.h:
       
  1848         * rendering/RenderReplaced.cpp:
       
  1849         * rendering/RenderReplaced.h:
       
  1850         * rendering/RenderSVGBlock.cpp:
       
  1851         * rendering/RenderSVGBlock.h:
       
  1852         * rendering/RenderSVGContainer.cpp:
       
  1853         * rendering/RenderSVGContainer.h:
       
  1854         * rendering/RenderSVGGradientStop.cpp:
       
  1855         * rendering/RenderSVGGradientStop.h:
       
  1856         * rendering/RenderSVGHiddenContainer.cpp:
       
  1857         * rendering/RenderSVGHiddenContainer.h:
       
  1858         * rendering/RenderSVGImage.cpp:
       
  1859         * rendering/RenderSVGImage.h:
       
  1860         * rendering/RenderSVGInline.cpp:
       
  1861         * rendering/RenderSVGInline.h:
       
  1862         * rendering/RenderSVGInlineText.cpp:
       
  1863         * rendering/RenderSVGInlineText.h:
       
  1864         * rendering/RenderSVGTSpan.cpp:
       
  1865         * rendering/RenderSVGTSpan.h:
       
  1866         * rendering/RenderSVGText.cpp:
       
  1867         * rendering/RenderSVGText.h:
       
  1868         * rendering/RenderSlider.cpp:
       
  1869         * rendering/RenderSlider.h:
       
  1870         * rendering/RenderStyle.cpp:
       
  1871         * rendering/RenderStyle.h:
       
  1872         * rendering/RenderTable.cpp:
       
  1873         * rendering/RenderTable.h:
       
  1874         * rendering/RenderTableCell.cpp:
       
  1875         * rendering/RenderTableCell.h:
       
  1876         * rendering/RenderTableCol.cpp:
       
  1877         * rendering/RenderTableCol.h:
       
  1878         * rendering/RenderTableRow.cpp:
       
  1879         * rendering/RenderTableRow.h:
       
  1880         * rendering/RenderTableSection.cpp:
       
  1881         * rendering/RenderTableSection.h:
       
  1882         * rendering/RenderText.cpp:
       
  1883         * rendering/RenderText.h:
       
  1884         * rendering/RenderTextControl.cpp:
       
  1885         * rendering/RenderTextControl.h:
       
  1886         * rendering/RenderTextFragment.cpp:
       
  1887         * rendering/RenderTextFragment.h:
       
  1888         * rendering/RenderTheme.cpp:
       
  1889         * rendering/RenderTheme.h:
       
  1890         * rendering/RenderThemeMac.h:
       
  1891         * rendering/RenderThemeMac.mm:
       
  1892         * rendering/RenderThemeSafari.cpp:
       
  1893         * rendering/RenderThemeSafari.h:
       
  1894         * rendering/RenderThemeWin.cpp:
       
  1895         * rendering/RenderThemeWin.h:
       
  1896         * rendering/RenderView.cpp:
       
  1897         * rendering/RenderView.h:
       
  1898         * rendering/RenderWidget.cpp:
       
  1899         * rendering/RenderWidget.h:
       
  1900         * rendering/RootInlineBox.cpp:
       
  1901         * rendering/RootInlineBox.h:
       
  1902         * rendering/SVGInlineFlowBox.cpp:
       
  1903         * rendering/SVGInlineFlowBox.h:
       
  1904         * rendering/SVGInlineTextBox.cpp:
       
  1905         * rendering/SVGInlineTextBox.h:
       
  1906         * rendering/SVGRootInlineBox.cpp:
       
  1907         * rendering/SVGRootInlineBox.h:
       
  1908         * rendering/TableLayout.h:
       
  1909         * rendering/bidi.cpp:
       
  1910         * rendering/bidi.h:
       
  1911         * rendering/break_lines.cpp:
       
  1912         * rendering/break_lines.h:
       
  1913         * xml/DOMParser.cpp:
       
  1914         * xml/DOMParser.h:
       
  1915         * xml/DOMParser.idl:
       
  1916         * xml/XMLHttpRequest.cpp:
       
  1917         * xml/XMLHttpRequest.h:
       
  1918         * xml/XMLSerializer.cpp:
       
  1919         * xml/XMLSerializer.h:
       
  1920         * xml/XMLSerializer.idl:
       
  1921         * xml/XPathEvaluator.idl:
       
  1922         * xml/XPathExpression.idl:
       
  1923         * xml/XPathNSResolver.idl:
       
  1924         * xml/XPathResult.idl:
       
  1925         * xml/XSLImportRule.cpp:
       
  1926         * xml/XSLImportRule.h:
       
  1927         * xml/XSLStyleSheet.cpp:
       
  1928         * xml/XSLStyleSheet.h:
       
  1929         * xml/XSLTProcessor.cpp:
       
  1930         * xml/XSLTProcessor.h:
       
  1931 
       
  1932 2007-09-25  Darin Adler  <darin@apple.com>
       
  1933 
       
  1934         Reviewed by Harrison.
       
  1935 
       
  1936         - fix <rdar://problem/5503225> CrashTracer: [USER] 2 crashes in Dashcode
       
  1937           at com.apple.WebCore: WebCore::Frame::document const + 0
       
  1938 
       
  1939         * page/FrameView.cpp: (WebCore::FrameView::updateControlTints):
       
  1940         Added null check.
       
  1941 
       
  1942 2007-09-25  Beth Dakin  <bdakin@apple.com>
       
  1943 
       
  1944         Reviewed by Darin.
       
  1945 
       
  1946         Fixes http://bugs.webkit.org/show_bug.cgi?id=15282 r25726 caused 
       
  1947         plugins/mouse-events.html to fail
       
  1948 
       
  1949         * page/FrameView.cpp:
       
  1950         (WebCore::FrameView::layout): We need to call 
       
  1951         updateWidgetPosition() after updating each widget.
       
  1952 
       
  1953 2007-09-25  Anders Carlsson  <andersca@apple.com>
       
  1954 
       
  1955         Build fix.
       
  1956         
       
  1957         * page/Chrome.cpp:
       
  1958         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
       
  1959 
       
  1960 2007-09-25  Anders Carlsson  <andersca@apple.com>
       
  1961 
       
  1962         Reviewed by Geoff.
       
  1963 
       
  1964         <rdar://problem/5283916>
       
  1965         JavaScript timers may be firing while JavaScript alerts are displayed.
       
  1966         
       
  1967         Pause JavaScript timeouts while calling UI delegate methods that might show dialogs.
       
  1968         
       
  1969         * page/Chrome.cpp:
       
  1970         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
       
  1971         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
       
  1972 
       
  1973 2007-09-26  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  1974 
       
  1975         Reviewed by Anders.
       
  1976 
       
  1977         Implement PopupMenu using GtkMenu.
       
  1978 
       
  1979         * platform/PopupMenu.h:
       
  1980         * platform/gtk/PopupMenuGtk.cpp:
       
  1981         (WebCore::PopupMenu::PopupMenu):
       
  1982         (WebCore::PopupMenu::~PopupMenu):
       
  1983         (WebCore::PopupMenu::show):
       
  1984         (WebCore::PopupMenu::hide):
       
  1985         (WebCore::PopupMenu::updateFromElement):
       
  1986         (WebCore::PopupMenu::itemWritingDirectionIsNatural):
       
  1987         (WebCore::PopupMenu::menuItemActivated):
       
  1988         (WebCore::PopupMenu::menuUnmapped):
       
  1989         (WebCore::PopupMenu::menuPositionFunction):
       
  1990         (WebCore::PopupMenu::menuRemoveItem):
       
  1991 
       
  1992 2007-09-23  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  1993 
       
  1994         Rubber stamped by Mark.
       
  1995 
       
  1996         Obey the Coding-Style and move the asterisk to the
       
  1997         left to be part of the type.
       
  1998 
       
  1999         * platform/gtk/RenderThemeGtk.h:
       
  2000 
       
  2001 2007-09-25  Beth Dakin  <bdakin@apple.com>
       
  2002 
       
  2003         Reviewed by Darin.
       
  2004 
       
  2005         Fix for <rdar://problem/5466459> CrashTracer: [USER] 1 crash in 
       
  2006         NetNewsWire at com.apple.WebCore: WebCore::bidiNext + 485 (15241)
       
  2007 
       
  2008         Mitz discovered that this crash appeared because r25128 made it 
       
  2009         possible for RenderPartObject::updateWidget() to be called during 
       
  2010         layout. updateWidget() can, through a series of calls, cause an 
       
  2011         attach/detach to happen, which is very bad in the middle of a 
       
  2012         layout and is what led to this crash. This patch fixes that by 
       
  2013         having the FrameView keep track of a queue of RenderPartObjects 
       
  2014         that need to call updateWidget(), and it goes through the queue 
       
  2015         calling updateWidget() as soon as layout is done.
       
  2016 
       
  2017         * page/FrameView.cpp: We only want to call updateWidget() if we are 
       
  2018         not in a nested layout. Unfortunately, the existing variables on 
       
  2019         FrameViewPrivate do not have exactly the information that we need, 
       
  2020         so I added nestedLayoutCount.
       
  2021         (WebCore::FrameViewPrivate::reset): Reset nestedLayoutCount.
       
  2022         (WebCore::FrameView::layout): Increment nestedLayoutCount once we 
       
  2023         have gotten through all of the early returns. Call updateWidget() 
       
  2024         after layout is nestedLayoutCount is 1 and there are widgets to 
       
  2025         update. Decrement nestedLayoutCount at the end.
       
  2026         (WebCore::FrameView::addWidgetToUpdate):
       
  2027         (WebCore::FrameView::removeWidgetToUpdate):
       
  2028         * page/FrameView.h:
       
  2029         * rendering/RenderPartObject.cpp:
       
  2030         (WebCore::RenderPartObject::~RenderPartObject): Remove this from 
       
  2031         the FrameView's update set.
       
  2032         (WebCore::RenderPartObject::layout): Instead of calling 
       
  2033         updateWidget() immediately, add this to the update widget set on 
       
  2034         FrameView.
       
  2035         * rendering/RenderPartObject.h:
       
  2036 
       
  2037 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
       
  2038 
       
  2039         Reviewed by Mark Rowe.
       
  2040 
       
  2041         - fix http://bugs.webkit.org/show_bug.cgi?id=15275
       
  2042           SVG dependency on WebCore/dom/XMLTokenizer.cpp
       
  2043 
       
  2044         * dom/XMLTokenizer.cpp: Moved #include "SVGStyleElement.h" into #if ENABLE(SVG).
       
  2045 
       
  2046 2007-09-25  Justin Garcia  <justin.garcia@apple.com>
       
  2047 
       
  2048         Reviewed by Darin.
       
  2049 
       
  2050         <rdar://problem/5483567> 
       
  2051         REGRESSION (Tiger only, workaround in AppKit on Leopard): Pasting words copied from TextEdit in Mail adds extra newline
       
  2052         
       
  2053         * editing/ReplaceSelectionCommand.cpp:
       
  2054         (WebCore::ReplaceSelectionCommand::removeUnrenderedNodes): Added.
       
  2055         (WebCore::ReplaceSelectionCommand::doApply): Call removeUnrenderedNodes
       
  2056         to prevent unrendered spaces from interfering with paragraph merging.
       
  2057         * editing/ReplaceSelectionCommand.h:
       
  2058 
       
  2059 2007-09-24  Steve Falkenburg  <sfalken@apple.com>
       
  2060 
       
  2061         Reviewed by Darin.
       
  2062 
       
  2063         - fix <rdar://problem/5502513>
       
  2064 
       
  2065         * platform/win/FontCacheWin.cpp:
       
  2066         (WebCore::FontCache::getFontLinkInterface):
       
  2067         Roll back this file; the old code leaked a global COM object, but that's
       
  2068         no big deal and the new code caused a crash on quit.
       
  2069 
       
  2070 2007-09-24  Anders Carlsson  <andersca@apple.com>
       
  2071 
       
  2072         Reviewed by Adam.
       
  2073 
       
  2074         <rdar://problem/5494608>
       
  2075         Seed: Safari will follow links in Flash movies without clicking.
       
  2076 
       
  2077         Make sure to handle mouseover and mouseout so the plug-in can track when the mouse is over it.
       
  2078                 
       
  2079         * plugins/win/PluginViewWin.cpp:
       
  2080         (WebCore::PluginViewWin::handleMouseEvent):
       
  2081 
       
  2082 2007-09-24  Mike Fenton  <mike@staikos.net>
       
  2083 
       
  2084         Reviewed by George Staikos.
       
  2085 
       
  2086         Switch to using a QImage instead of a QPixmap to make transparency work.
       
  2087 
       
  2088         * html/CanvasRenderingContext2D.cpp:
       
  2089         (WebCore::CanvasRenderingContext2D::drawImage):
       
  2090         * html/HTMLCanvasElement.cpp:
       
  2091         (WebCore::HTMLCanvasElement::paint):
       
  2092         (WebCore::HTMLCanvasElement::createDrawingContext):
       
  2093         (WebCore::HTMLCanvasElement::createPlatformImage):
       
  2094         * html/HTMLCanvasElement.h:
       
  2095 
       
  2096 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
       
  2097 
       
  2098         Reviewed by Sam.
       
  2099 
       
  2100         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
       
  2101 
       
  2102         * WebCore.vcproj/WebCore.vcproj:
       
  2103 
       
  2104 2007-09-24  Brady Eidson  <beidson@apple.com>
       
  2105 
       
  2106         Reviewed by John Sullivan
       
  2107 
       
  2108         * loader/icon/IconDatabase.cpp:
       
  2109         (WebCore::IconDatabase::iconForPageURL): Assert the page url is non-null
       
  2110 
       
  2111 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  2112 
       
  2113         Rubber stamped by Adam.
       
  2114 
       
  2115         Renamed files from *Gdk to *Gtk (see #14732) using the
       
  2116         work of Juan A. Suarez Romero as a base.
       
  2117 
       
  2118         GDK -> GTK
       
  2119 
       
  2120         * Projects/gdk/webcore-gdk.bkl:
       
  2121         * WebCore.pro:
       
  2122         * WebCoreSources.bkl:
       
  2123         * loader/gdk: Removed.
       
  2124         * loader/gdk/DocumentLoaderGdk.cpp: Removed.
       
  2125         * loader/gtk: Added.
       
  2126         * loader/gtk/DocumentLoaderGdk.cpp: Removed.
       
  2127         * loader/gtk/DocumentLoaderGtk.cpp: Added.
       
  2128         * page/FrameView.cpp:
       
  2129         * page/FrameView.h:
       
  2130         * page/gdk: Removed.
       
  2131         * page/gdk/DragControllerGdk.cpp: Removed.
       
  2132         * page/gdk/EventHandlerGdk.cpp: Removed.
       
  2133         * page/gdk/FrameGdk.cpp: Removed.
       
  2134         * page/gtk: Added.
       
  2135         * page/gtk/DragControllerGdk.cpp: Removed.
       
  2136         * page/gtk/DragControllerGtk.cpp: Added.
       
  2137         * page/gtk/EventHandlerGdk.cpp: Removed.
       
  2138         * page/gtk/EventHandlerGtk.cpp: Added.
       
  2139         (WebCore::EventHandler::createDraggingClipboard):
       
  2140         * page/gtk/FrameGdk.cpp: Removed.
       
  2141         * page/gtk/FrameGtk.cpp: Added.
       
  2142         * platform/ContextMenuItem.h:
       
  2143         * platform/Cursor.h:
       
  2144         * platform/DragData.h:
       
  2145         * platform/DragImage.h:
       
  2146         * platform/FontData.h:
       
  2147         * platform/NotImplemented.h:
       
  2148         * platform/PlatformKeyboardEvent.h:
       
  2149         * platform/PlatformMenuDescription.h:
       
  2150         * platform/PlatformMouseEvent.h:
       
  2151         * platform/PlatformWheelEvent.h:
       
  2152         * platform/ScrollView.h:
       
  2153         * platform/Widget.h:
       
  2154         * platform/gdk: Removed.
       
  2155         * platform/gdk/ClipboardGdk.cpp: Removed.
       
  2156         * platform/gdk/ClipboardGdk.h: Removed.
       
  2157         * platform/gdk/ContextMenuGdk.cpp: Removed.
       
  2158         * platform/gdk/ContextMenuItemGdk.cpp: Removed.
       
  2159         * platform/gdk/CookieJarGdk.cpp: Removed.
       
  2160         * platform/gdk/CursorGdk.cpp: Removed.
       
  2161         * platform/gdk/DragDataGdk.cpp: Removed.
       
  2162         * platform/gdk/DragImageGdk.cpp: Removed.
       
  2163         * platform/gdk/FileChooserGdk.cpp: Removed.
       
  2164         * platform/gdk/FileSystemGdk.cpp: Removed.
       
  2165         * platform/gdk/FontCacheGdk.cpp: Removed.
       
  2166         * platform/gdk/FontDataGdk.cpp: Removed.
       
  2167         * platform/gdk/FontGdk.cpp: Removed.
       
  2168         * platform/gdk/FontPlatformData.h: Removed.
       
  2169         * platform/gdk/FontPlatformDataGdk.cpp: Removed.
       
  2170         * platform/gdk/GlyphPageTreeNodeGdk.cpp: Removed.
       
  2171         * platform/gdk/KeyEventGdk.cpp: Removed.
       
  2172         * platform/gdk/KeyboardCodes.h: Removed.
       
  2173         * platform/gdk/LocalizedStringsGdk.cpp: Removed.
       
  2174         * platform/gdk/LoggingGdk.cpp: Removed.
       
  2175         * platform/gdk/MIMETypeRegistryGdk.cpp: Removed.
       
  2176         * platform/gdk/MouseEventGdk.cpp: Removed.
       
  2177         * platform/gdk/PasteboardGdk.cpp: Removed.
       
  2178         * platform/gdk/PlatformScreenGdk.cpp: Removed.
       
  2179         * platform/gdk/PlatformScrollBar.h: Removed.
       
  2180         * platform/gdk/PlatformScrollBarGdk.cpp: Removed.
       
  2181         * platform/gdk/PopupMenuGdk.cpp: Removed.
       
  2182         * platform/gdk/RenderThemeGdk.cpp: Removed.
       
  2183         * platform/gdk/RenderThemeGdk.h: Removed.
       
  2184         * platform/gdk/ScrollViewGdk.cpp: Removed.
       
  2185         * platform/gdk/SearchPopupMenuGdk.cpp: Removed.
       
  2186         * platform/gdk/SharedTimerLinux.cpp: Removed.
       
  2187         * platform/gdk/SoundGdk.cpp: Removed.
       
  2188         * platform/gdk/SystemTimeLinux.cpp: Removed.
       
  2189         * platform/gdk/TemporaryLinkStubs.cpp: Removed.
       
  2190         * platform/gdk/WheelEventGdk.cpp: Removed.
       
  2191         * platform/gdk/WidgetGdk.cpp: Removed.
       
  2192         * platform/graphics/GraphicsContext.h:
       
  2193         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
  2194         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
       
  2195         (WebCore::GraphicsContext::setPlatformFont):
       
  2196         * platform/graphics/gdk: Removed.
       
  2197         * platform/graphics/gdk/IconGdk.cpp: Removed.
       
  2198         * platform/graphics/gdk/ImageGdk.cpp: Removed.
       
  2199         * platform/graphics/gtk: Added.
       
  2200         * platform/graphics/gtk/IconGdk.cpp: Removed.
       
  2201         * platform/graphics/gtk/IconGtk.cpp: Added.
       
  2202         * platform/graphics/gtk/ImageGdk.cpp: Removed.
       
  2203         * platform/graphics/gtk/ImageGtk.cpp: Added.
       
  2204         * platform/gtk: Added.
       
  2205         * platform/gtk/ClipboardGdk.cpp: Removed.
       
  2206         * platform/gtk/ClipboardGdk.h: Removed.
       
  2207         * platform/gtk/ClipboardGtk.cpp: Added.
       
  2208         (WebCore::ClipboardGtk::ClipboardGtk):
       
  2209         (WebCore::ClipboardGtk::~ClipboardGtk):
       
  2210         (WebCore::ClipboardGtk::clearData):
       
  2211         (WebCore::ClipboardGtk::clearAllData):
       
  2212         (WebCore::ClipboardGtk::getData):
       
  2213         (WebCore::ClipboardGtk::setData):
       
  2214         (WebCore::ClipboardGtk::types):
       
  2215         (WebCore::ClipboardGtk::dragLocation):
       
  2216         (WebCore::ClipboardGtk::dragImage):
       
  2217         (WebCore::ClipboardGtk::setDragImage):
       
  2218         (WebCore::ClipboardGtk::dragImageElement):
       
  2219         (WebCore::ClipboardGtk::setDragImageElement):
       
  2220         (WebCore::ClipboardGtk::createDragImage):
       
  2221         (WebCore::ClipboardGtk::declareAndWriteDragImage):
       
  2222         (WebCore::ClipboardGtk::writeURL):
       
  2223         (WebCore::ClipboardGtk::writeRange):
       
  2224         (WebCore::ClipboardGtk::hasData):
       
  2225         * platform/gtk/ClipboardGtk.h: Added.
       
  2226         * platform/gtk/ContextMenuGdk.cpp: Removed.
       
  2227         * platform/gtk/ContextMenuGtk.cpp: Added.
       
  2228         * platform/gtk/ContextMenuItemGdk.cpp: Removed.
       
  2229         * platform/gtk/ContextMenuItemGtk.cpp: Added.
       
  2230         * platform/gtk/CookieJarGdk.cpp: Removed.
       
  2231         * platform/gtk/CookieJarGtk.cpp: Added.
       
  2232         * platform/gtk/CursorGdk.cpp: Removed.
       
  2233         * platform/gtk/CursorGtk.cpp: Added.
       
  2234         * platform/gtk/DragDataGdk.cpp: Removed.
       
  2235         * platform/gtk/DragDataGtk.cpp: Added.
       
  2236         * platform/gtk/DragImageGdk.cpp: Removed.
       
  2237         * platform/gtk/DragImageGtk.cpp: Added.
       
  2238         * platform/gtk/FileChooserGdk.cpp: Removed.
       
  2239         * platform/gtk/FileChooserGtk.cpp: Added.
       
  2240         * platform/gtk/FileSystemGdk.cpp: Removed.
       
  2241         * platform/gtk/FileSystemGtk.cpp: Added.
       
  2242         * platform/gtk/FontCacheGdk.cpp: Removed.
       
  2243         * platform/gtk/FontCacheGtk.cpp: Added.
       
  2244         * platform/gtk/FontDataGdk.cpp: Removed.
       
  2245         * platform/gtk/FontDataGtk.cpp: Added.
       
  2246         * platform/gtk/FontGdk.cpp: Removed.
       
  2247         * platform/gtk/FontGtk.cpp: Added.
       
  2248         * platform/gtk/FontPlatformDataGdk.cpp: Removed.
       
  2249         * platform/gtk/FontPlatformDataGtk.cpp: Added.
       
  2250         * platform/gtk/GlyphPageTreeNodeGdk.cpp: Removed.
       
  2251         * platform/gtk/GlyphPageTreeNodeGtk.cpp: Added.
       
  2252         * platform/gtk/KeyEventGdk.cpp: Removed.
       
  2253         * platform/gtk/KeyEventGtk.cpp: Added.
       
  2254         * platform/gtk/LocalizedStringsGdk.cpp: Removed.
       
  2255         * platform/gtk/LocalizedStringsGtk.cpp: Added.
       
  2256         * platform/gtk/LoggingGdk.cpp: Removed.
       
  2257         * platform/gtk/LoggingGtk.cpp: Added.
       
  2258         * platform/gtk/MIMETypeRegistryGdk.cpp: Removed.
       
  2259         * platform/gtk/MIMETypeRegistryGtk.cpp: Added.
       
  2260         * platform/gtk/MouseEventGdk.cpp: Removed.
       
  2261         * platform/gtk/MouseEventGtk.cpp: Added.
       
  2262         * platform/gtk/PasteboardGdk.cpp: Removed.
       
  2263         * platform/gtk/PasteboardGtk.cpp: Added.
       
  2264         * platform/gtk/PlatformScreenGdk.cpp: Removed.
       
  2265         * platform/gtk/PlatformScreenGtk.cpp: Added.
       
  2266         * platform/gtk/PlatformScrollBarGdk.cpp: Removed.
       
  2267         * platform/gtk/PlatformScrollBarGtk.cpp: Added.
       
  2268         * platform/gtk/PopupMenuGdk.cpp: Removed.
       
  2269         * platform/gtk/PopupMenuGtk.cpp: Added.
       
  2270         * platform/gtk/RenderThemeGdk.cpp: Removed.
       
  2271         * platform/gtk/RenderThemeGdk.h: Removed.
       
  2272         * platform/gtk/RenderThemeGtk.cpp: Added.
       
  2273         (WebCore::theme):
       
  2274         (WebCore::RenderThemeGtk::RenderThemeGtk):
       
  2275         (WebCore::RenderThemeGtk::close):
       
  2276         (WebCore::RenderThemeGtk::addIntrinsicMargins):
       
  2277         (WebCore::RenderThemeGtk::supportsFocus):
       
  2278         (WebCore::RenderThemeGtk::determineState):
       
  2279         (WebCore::RenderThemeGtk::determineShadow):
       
  2280         (WebCore::RenderThemeGtk::getThemeData):
       
  2281         (WebCore::RenderThemeGtk::setCheckboxSize):
       
  2282         (WebCore::RenderThemeGtk::paintCheckbox):
       
  2283         (WebCore::RenderThemeGtk::setRadioSize):
       
  2284         (WebCore::RenderThemeGtk::paintRadio):
       
  2285         (WebCore::RenderThemeGtk::paintButton):
       
  2286         (WebCore::RenderThemeGtk::adjustTextFieldStyle):
       
  2287         (WebCore::RenderThemeGtk::paintTextField):
       
  2288         (WebCore::RenderThemeGtk::paintTextArea):
       
  2289         (WebCore::RenderThemeGtk::adjustButtonStyle):
       
  2290         (WebCore::RenderThemeGtk::systemFont):
       
  2291         (WebCore::RenderThemeGtk::gtkButton):
       
  2292         (WebCore::RenderThemeGtk::gtkCheckbox):
       
  2293         (WebCore::RenderThemeGtk::gtkRadioButton):
       
  2294         (WebCore::RenderThemeGtk::gtkWindowContainer):
       
  2295         * platform/gtk/RenderThemeGtk.h: Added.
       
  2296         * platform/gtk/ScrollViewGdk.cpp: Removed.
       
  2297         * platform/gtk/ScrollViewGtk.cpp: Added.
       
  2298         * platform/gtk/SearchPopupMenuGdk.cpp: Removed.
       
  2299         * platform/gtk/SearchPopupMenuGtk.cpp: Added.
       
  2300         * platform/gtk/SoundGdk.cpp: Removed.
       
  2301         * platform/gtk/SoundGtk.cpp: Added.
       
  2302         * platform/gtk/WheelEventGdk.cpp: Removed.
       
  2303         * platform/gtk/WheelEventGtk.cpp: Added.
       
  2304         * platform/gtk/WidgetGdk.cpp: Removed.
       
  2305         * platform/gtk/WidgetGtk.cpp: Added.
       
  2306         * platform/network/ResourceHandle.h:
       
  2307 
       
  2308 2007-09-23  Rob Buis  <buis@kde.org>
       
  2309 
       
  2310         Reviewed by Hyatt.
       
  2311 
       
  2312         http://bugs.webkit.org/show_bug.cgi?id=15025
       
  2313         Background repeat css property is not inherited from parent if unspecified
       
  2314 
       
  2315         Don't let invalid url specification in background shorthand make
       
  2316         the entire shorthand invalid.
       
  2317 
       
  2318         * css/CSSParser.cpp:
       
  2319         (WebCore::CSSParser::parseBackgroundImage):
       
  2320         (WebCore::CSSParser::parseBackgroundProperty):
       
  2321         * css/CSSParser.h:
       
  2322 
       
  2323 2007-09-22  Adam Roben  <aroben@apple.com>
       
  2324 
       
  2325         Fix Bug 15251: REGRESSION: <input type=range> doesn't respond to form.reset() or setting input.value
       
  2326 
       
  2327         http://bugs.webkit.org/show_bug.cgi?id=15251
       
  2328         <rdar://5498169>
       
  2329 
       
  2330         Reviewed by Maciej.
       
  2331 
       
  2332         Test: fast/forms/range-reset.html
       
  2333 
       
  2334         * html/HTMLInputElement.cpp:
       
  2335         (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): <input
       
  2336         type=range> should be storing its value separately from the value
       
  2337         attribute, as do all of our variable-input input types.
       
  2338 
       
  2339 2007-09-21  Mark Rowe  <mrowe@apple.com>
       
  2340 
       
  2341         Build fix for non-Mac platforms after r25697.
       
  2342         
       
  2343         Rename Frame::cleanupPlatformScriptObjects to Frame::clearPlatformScriptObjects.
       
  2344 
       
  2345         * bridge/win/FrameWin.cpp:
       
  2346         * page/gdk/FrameGdk.cpp:
       
  2347         * page/qt/FrameQt.cpp:
       
  2348         * platform/wx/TemporaryLinkStubs.cpp:
       
  2349 
       
  2350 2007-09-21  Adele Peterson  <adele@apple.com>
       
  2351 
       
  2352         Reviewed by Sam.
       
  2353 
       
  2354         Fix for <rdar://problem/5497357> REGRESSION: Safari doesn't show the month days on AirFrance reservation page
       
  2355 
       
  2356         Test: fast/dom/HTMLSelectElement/options-collection-set-string-length.html
       
  2357 
       
  2358         * bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::setLength):
       
  2359           Convert the value to a number.  We already have code here to check if the value is not a number.
       
  2360           This matches other browsers, which allow a string value to be used to set the length.
       
  2361 
       
  2362 2007-09-21  Timothy Hatcher  <timothy@apple.com>
       
  2363 
       
  2364         Reviewed by Darin.
       
  2365 
       
  2366         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded
       
  2367 
       
  2368         Calling -[WebView windowScriptObject] before the page loads would give you nil. This behavior didn't match Tiger.
       
  2369         The API behavior in Tiger let you get the window script object once and keep ahold of it as long as you needed it.
       
  2370         The window object would remain valid even after page loads. This change restores the Tiger behavior.
       
  2371 
       
  2372         <rdar://problem/5495790> NULL dereference crash beneath Bindings::RootObject::interpreter when saving Dashcode document
       
  2373 
       
  2374         The changes to WebScriptObject's _isSafeScript call also fixed the crash in Dashcode.
       
  2375 
       
  2376         * bindings/objc/WebScriptObject.mm:
       
  2377         (-[WebScriptObject _setOriginRootObject:andRootObject:]): New method used to update the the root objects,
       
  2378         so the WebScriptObject can still be used after a page load.
       
  2379         (-[WebScriptObject _isSafeScript]): Call [self _rootObject] instead of accessing the data member directly.
       
  2380         DOMNode has an override for the _rootObject method, and it can return 0 when _private->_rootObject
       
  2381         is non-zero. We would return YES here when it wasn't safe and later crash with my modified layout tests.
       
  2382         Checking _rootObject first prevents other calls sites from needing to check for a valid root object,
       
  2383         this fixed the Dashcode crash.
       
  2384         (-[WebScriptObject _imp]): Ditto.
       
  2385 
       
  2386         * bindings/objc/WebScriptObjectPrivate.h: Add _setOriginRootObject:andRootObject:.
       
  2387 
       
  2388         * loader/FrameLoader.cpp:
       
  2389         (WebCore::FrameLoader::clear): Call the renamed clearScriptObjects function.
       
  2390         (WebCore::FrameLoader::dispatchWindowObjectAvailable): Some gratuitous code cleanup.
       
  2391 
       
  2392         * page/Frame.cpp:
       
  2393         (WebCore::Frame::clearScriptObjects): Renamed cleanupScriptObject to clearScriptObjects.
       
  2394         Call clearPlatformScriptObjects last so m_bindingRootObject is already NULL.
       
  2395         (WebCore::Frame::windowScriptNPObject): Hold a JSLock before accessing the window. This
       
  2396         change is unrelated to the bug, but should be fixed.
       
  2397 
       
  2398         * page/mac/FrameMac.mm:
       
  2399         (WebCore::Frame::windowScriptObject): Return a script object even if the interpreter is NULL.
       
  2400         This resotres the Tiger behavior of always being able to access the window object.
       
  2401         (WebCore::Frame::clearPlatformScriptObjects): Keep the window script object around, and update
       
  2402         the root objects for the window script object.
       
  2403 
       
  2404         * page/Frame.h: Rename cleanupScriptObject to clearScriptObjects.
       
  2405         * page/FramePrivate.h: Use a RetainPtr for m_windowScriptObject.
       
  2406 
       
  2407 2007-09-21  Mike Fenton  <mike@staikos.net>
       
  2408 
       
  2409         Reviewed by George Staikos.
       
  2410 
       
  2411         Fix styled pen support by not clobbering QPen properties.
       
  2412 
       
  2413         * html/CanvasStyle.cpp:
       
  2414         (WebCore::CanvasStyle::applyStrokeColor):
       
  2415         (WebCore::CanvasStyle::applyFillColor):
       
  2416 
       
  2417 2007-09-21  Oliver Hunt  <oliver@apple.com>
       
  2418 
       
  2419         Reviewed by Tristan and Darin
       
  2420 
       
  2421         http://bugs.webkit.org/show_bug.cgi?id=15239
       
  2422         <rdar://problem/5491955> REGRESSION (r25547): With Hanin IME, one cannot input characters into forms (15239)
       
  2423         
       
  2424         This problem was caused by the setComposition method failing to clear
       
  2425         the composition markers in the presence of an empty string.  This would 
       
  2426         result in the caret being locked within the 0 length bounds of the "composition"
       
  2427         and so preventing basic keyboard interaction.
       
  2428 
       
  2429         * editing/Editor.cpp:
       
  2430         (WebCore::Editor::setComposition):
       
  2431 
       
  2432 2007-09-21  Adele Peterson  <adele@apple.com>
       
  2433 
       
  2434         Reviewed by Tristan.
       
  2435 
       
  2436         Fix for <rdar://problem/5497346> "Check spelling when I click Send" crashes on stationery messages every time
       
  2437 
       
  2438         No test. I wasn't able to find a way to get this to occur with Safari or DumpRenderTree.
       
  2439 
       
  2440         * editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): Updated comment.
       
  2441         * editing/htmlediting.cpp:
       
  2442         (WebCore::firstEditablePositionAfterPositionInRoot): Only return the root position if its editable.
       
  2443         (WebCore::maxDeepOffset): Added nil check & assert.
       
  2444 
       
  2445 2007-09-21  Anders Carlsson  <andersca@apple.com>
       
  2446 
       
  2447         Reviewed by Steve.
       
  2448 
       
  2449         <rdar://problem/5404339>
       
  2450         Site redirects continuosly, starving UI thread, causing app to hang.
       
  2451         
       
  2452         Use GetQueueStatus to see if there are input messages in the queue that aren't being processed.
       
  2453         If so, use a low-priority timer instead of PostMessage.
       
  2454         
       
  2455         * platform/win/SharedTimerWin.cpp:
       
  2456         (WebCore::setSharedTimerFireTime):
       
  2457 
       
  2458 2007-09-22  Darin Adler  <darin@apple.com>
       
  2459 
       
  2460         Reviewed by Anders.
       
  2461 
       
  2462         - add QueryInterface capabilities to COMPtr
       
  2463 
       
  2464         * platform/win/COMPtr.h:
       
  2465         (COMPtr::COMPtr): Added constructor that takes a Query tag and
       
  2466         does an appropriate QueryInterface.
       
  2467         (COMPtr::query): Added function to do a queryInterface.
       
  2468         (COMPtr::copyQueryInterfaceRef): Added private helper used by
       
  2469         both of the above. Note that when the query fails you get a 0,
       
  2470         which is the same thing you get if a 0 pointer is passed in.
       
  2471 
       
  2472         * platform/win/FontCacheWin.cpp:
       
  2473         (WebCore::FontCache::getFontLinkInterface): Convert to using
       
  2474         the new query as a test case. Also eliminate the unnecessary
       
  2475         second global variable and use COMPtr objects rather than just
       
  2476         leaking references.
       
  2477 
       
  2478         * platform/win/WCDataObject.h: Removed unneeded include and
       
  2479         using statements.
       
  2480 
       
  2481 2007-09-21  Anders Carlsson  <andersca@apple.com>
       
  2482 
       
  2483         Reviewed by Adam.
       
  2484 
       
  2485         <rdar://problem/5494790>
       
  2486         clicking any link in the Flash regions at bananarepublic.com results in bad page
       
  2487 
       
  2488         Don't replace the frame contents, the Mac version doesn't do this.
       
  2489         
       
  2490         * plugins/win/PluginViewWin.cpp:
       
  2491         (WebCore::PluginViewWin::performRequest):
       
  2492 
       
  2493 2007-09-21  Anders Carlsson  <andersca@apple.com>
       
  2494 
       
  2495         Reviewed by Darin.
       
  2496 
       
  2497         <rdar://problem/5496700>
       
  2498         Repro crash loading http://www.tivo.com/whatistivo/tivohd/index.html
       
  2499 
       
  2500         Don't continue if the plug-in cancelled the stream.
       
  2501                 
       
  2502         * loader/win/NetscapePlugInStreamLoaderWin.cpp:
       
  2503         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
       
  2504 
       
  2505 2007-09-21  Kevin Decker  <kdecker@apple.com>
       
  2506 
       
  2507         * platform/mac/SoftLinking.h: Build fix; added necessary #imports. 
       
  2508 
       
  2509 2007-09-21  Kevin Decker  <kdecker@apple.com>
       
  2510 
       
  2511         Reviewed by Darin Adler.
       
  2512 
       
  2513         * WebCore.xcodeproj/project.pbxproj: Added SoftLinking.h to the project.
       
  2514         * platform/mac/SoftLinking.h: Contains a new macro; useful in helping to lazily load frameworks.
       
  2515 
       
  2516 2007-09-20  Ada Chan  <adachan@apple.com>
       
  2517 
       
  2518         <rdar://problem/5477240> Regression: Footer is too high in print preview
       
  2519         Make computePageRectsForFrame() return the height of the page adjusted for margins.
       
  2520 
       
  2521         Reviewed by Steve.
       
  2522 
       
  2523         * bridge/win/FrameWin.cpp:
       
  2524         (WebCore::computePageRectsForFrame):
       
  2525         * bridge/win/FrameWin.h:
       
  2526 
       
  2527 2007-09-19  Kevin McCullough  <kmccullough@apple.com>
       
  2528 
       
  2529         Reviewed by Hyatt.
       
  2530 
       
  2531         - <rdar://problem/5101991> Avril Lavigne music player comes up in a window with scrollbars
       
  2532         - Implementing missing scrollbar functionality to allow turning off scrollbars correctly.
       
  2533 
       
  2534         * platform/ScrollView.h:
       
  2535         * platform/win/ScrollViewWin.cpp:
       
  2536         (WebCore::ScrollView::ScrollViewPrivate::setAllowsScrolling):
       
  2537         (WebCore::ScrollView::ScrollViewPrivate::allowsScrolling):
       
  2538         (WebCore::ScrollView::updateScrollbars):
       
  2539         (WebCore::ScrollView::setAllowsScrolling):
       
  2540         (WebCore::ScrollView::allowsScrolling):
       
  2541 
       
  2542 2007-09-20  Brady Eidson  <beidson@apple.com>
       
  2543 
       
  2544         Reviewed by Dave Hyatt
       
  2545 
       
  2546         <rdar://problem/5245981> - No favicon shows up for cnet.com
       
  2547         
       
  2548         CNet's favicon has two images in it - a 32x32 white square, and a 16x16 image that is their actual icon
       
  2549         Till now on Windows we've always gone straight for the first image in an icon for the favicon, now we
       
  2550         actually do proper size matching
       
  2551 
       
  2552         * platform/graphics/BitmapImage.h:
       
  2553 
       
  2554         * platform/graphics/Image.h:
       
  2555         (WebCore::Image::getHBITMAPOfSize): 
       
  2556         (WebCore::Image::drawFrameMatchingSourceSize): Search through the frames of the image for the correct size
       
  2557 
       
  2558         * platform/graphics/win/ImageWin.cpp:
       
  2559         (WebCore::BitmapImage::getHBITMAP):
       
  2560         (WebCore::BitmapImage::getHBITMAPOfSize):
       
  2561         (WebCore::BitmapImage::drawFrameMatchingSourceSize):
       
  2562 
       
  2563 2007-09-20  Steve Falkenburg  <sfalken@apple.com>
       
  2564 
       
  2565         Reviewed by Brady.
       
  2566 
       
  2567         Call ascii() instead of utf8() from debug logging code to avoid threading
       
  2568         issues associated w/ converting to UTF8.
       
  2569 
       
  2570         * loader/icon/IconDatabase.cpp:
       
  2571         (WebCore::makeAllDirectories):
       
  2572         (WebCore::IconDatabase::retainIconForPageURL):
       
  2573         (WebCore::IconDatabase::releaseIconForPageURL):
       
  2574         (WebCore::IconDatabase::setIconDataForIconURL):
       
  2575         (WebCore::IconDatabase::setIconURLForPageURL):
       
  2576         (WebCore::IconDatabase::loadDecisionForIconURL):
       
  2577         (WebCore::IconDatabase::getOrCreatePageURLRecord):
       
  2578         (WebCore::IconDatabase::iconDatabaseSyncThread):
       
  2579         (WebCore::IconDatabase::performOpenInitialization):
       
  2580         (WebCore::IconDatabase::checkIntegrity):
       
  2581         (WebCore::IconDatabase::performURLImport):
       
  2582         (WebCore::IconDatabase::readFromDatabase):
       
  2583         (WebCore::IconDatabase::writeToDatabase):
       
  2584         (WebCore::readySQLStatement):
       
  2585         (WebCore::IconDatabase::setIconURLForPageURLInSQLDatabase):
       
  2586         (WebCore::IconDatabase::setIconIDForPageURLInSQLDatabase):
       
  2587         (WebCore::IconDatabase::removePageURLFromSQLDatabase):
       
  2588         (WebCore::IconDatabase::getIconIDForIconURLFromSQLDatabase):
       
  2589         (WebCore::IconDatabase::addIconURLToSQLDatabase):
       
  2590         (WebCore::IconDatabase::getImageDataForIconURLFromSQLDatabase):
       
  2591         (WebCore::IconDatabase::removeIconFromSQLDatabase):
       
  2592         (WebCore::IconDatabase::writeIconSnapshotToSQLDatabase):
       
  2593 
       
  2594 2007-09-20  Mike Fenton  <mike@staikos.net>
       
  2595 
       
  2596         Reviewed by George Staikos.
       
  2597 
       
  2598         Implement gradients and more of canvas for Qt.  Style changes and some
       
  2599         of the stroking fixes by George.
       
  2600 
       
  2601         * html/CanvasGradient.cpp:
       
  2602         (WebCore::CanvasGradient::CanvasGradient):
       
  2603         (WebCore::CanvasGradient::~CanvasGradient):
       
  2604         (WebCore::CanvasGradient::addColorStop):
       
  2605         (WebCore::CanvasGradient::platformShading):
       
  2606         * html/CanvasGradient.h:
       
  2607         * html/CanvasRenderingContext2D.cpp:
       
  2608         (WebCore::CanvasRenderingContext2D::fill):
       
  2609         (WebCore::CanvasRenderingContext2D::stroke):
       
  2610         (WebCore::CanvasRenderingContext2D::fillRect):
       
  2611         (WebCore::CanvasRenderingContext2D::applyFillPattern):
       
  2612 
       
  2613 2007-09-20  Rob Buis  <buis@kde.org>
       
  2614 
       
  2615         Reviewed by Mitz.
       
  2616 
       
  2617         http://bugs.webkit.org/show_bug.cgi?id=15235
       
  2618         Options can not be removed from a Select element with OptGroup's using JavaScript
       
  2619         <rdar://problem/5494123>
       
  2620 
       
  2621         Remove HTMLOptionElement children against the proper parent node.
       
  2622 
       
  2623         * html/HTMLSelectElement.cpp:
       
  2624         (WebCore::HTMLSelectElement::remove):
       
  2625 
       
  2626 2007-09-19  John Sullivan  <sullivan@apple.com>
       
  2627 
       
  2628         Reviewed by Darin Adler.
       
  2629         
       
  2630         - WebCore part of speculative fix for <rdar://problem/5490627>, about crashes constructing a
       
  2631           String using the values filled in by checkSpellingOfString()
       
  2632 
       
  2633         * editing/Editor.cpp:
       
  2634         (WebCore::findFirstMisspellingInRange):
       
  2635         initialize out parameters the way we do elsewhere; add many assertions for improper results
       
  2636         from checkSpellingOfString(); don't create a String at all until we've checked all the ways
       
  2637         that checkSpellingOfString() results could indicate invalid string, even the unexpected ones;
       
  2638         as an optimization, don't construct a String at all when looping through to mark all instances.
       
  2639 
       
  2640 2007-09-18  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  2641 
       
  2642         Reviewed by Adam.
       
  2643 
       
  2644         There is no need to have FTPDirectoryDocument stubs. We can
       
  2645         compile FTPDirectoryDocument.cpp and FTPDirectoryTokenizer.cpp
       
  2646         instead.
       
  2647 
       
  2648         * WebCore.pro:
       
  2649         * platform/gdk/TemporaryLinkStubs.cpp:
       
  2650         * platform/qt/TemporaryLinkStubs.cpp:
       
  2651 
       
  2652 2007-09-18  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  2653 
       
  2654         Reviewed by Adam.
       
  2655 
       
  2656         Remove includes that are not needed.
       
  2657 
       
  2658         * platform/gdk/TemporaryLinkStubs.cpp:
       
  2659 
       
  2660 2007-09-18  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  2661 
       
  2662         Reviewed by Adam.
       
  2663 
       
  2664         Move the Pasteboard stubs to PasteboardGdk.cpp.
       
  2665 
       
  2666         * WebCore.pro:
       
  2667         * platform/gdk/PasteboardGdk.cpp: Added.
       
  2668         (WebCore::Pasteboard::generalPasteboard):
       
  2669         (WebCore::Pasteboard::writeSelection):
       
  2670         (WebCore::Pasteboard::writeURL):
       
  2671         (WebCore::Pasteboard::writeImage):
       
  2672         (WebCore::Pasteboard::clear):
       
  2673         (WebCore::Pasteboard::canSmartReplace):
       
  2674         (WebCore::Pasteboard::documentFragment):
       
  2675         (WebCore::Pasteboard::plainText):
       
  2676         (WebCore::Pasteboard::Pasteboard):
       
  2677         * platform/gdk/TemporaryLinkStubs.cpp:
       
  2678 
       
  2679 2007-09-18  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  2680 
       
  2681         Reviewed by Adam.
       
  2682 
       
  2683         Move the Icon stubs to IconGdk.cpp
       
  2684 
       
  2685         * WebCore.pro:
       
  2686         * platform/gdk/TemporaryLinkStubs.cpp:
       
  2687         * platform/graphics/gdk/IconGdk.cpp: Added.
       
  2688         (WebCore::Icon::Icon):
       
  2689         (WebCore::Icon::~Icon):
       
  2690         (WebCore::Icon::newIconForFile):
       
  2691 
       
  2692 2007-09-18  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  2693 
       
  2694         Reviewed by Adam.
       
  2695 
       
  2696         Move the Font stubs to FontGdk.cpp
       
  2697 
       
  2698         * platform/gdk/FontGdk.cpp:
       
  2699         (WebCore::Font::drawComplexText):
       
  2700         (WebCore::Font::floatWidthForComplexText):
       
  2701         (WebCore::Font::offsetForPositionForComplexText):
       
  2702         (WebCore::Font::selectionRectForComplexText):
       
  2703         * platform/gdk/TemporaryLinkStubs.cpp:
       
  2704 
       
  2705 2007-09-18  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  2706 
       
  2707         Reviewed by Adam.
       
  2708 
       
  2709         Move the SearchPopupMenu stubs to SearchPopupMenuGdk.cpp
       
  2710 
       
  2711         * WebCore.pro:
       
  2712         * platform/gdk/SearchPopupMenuGdk.cpp: Added.
       
  2713         (WebCore::SearchPopupMenu::SearchPopupMenu):
       
  2714         (WebCore::SearchPopupMenu::saveRecentSearches):
       
  2715         (WebCore::SearchPopupMenu::loadRecentSearches):
       
  2716         (WebCore::SearchPopupMenu::enabled):
       
  2717         * platform/gdk/TemporaryLinkStubs.cpp:
       
  2718 
       
  2719 2007-09-18  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  2720 
       
  2721         Reviewed by Adam.
       
  2722 
       
  2723         Move the ContextMenu and ContextMenuItem stubs to
       
  2724         ContextMenuGdk.cpp and ContextMenuItemGdk.cpp.
       
  2725 
       
  2726         * WebCore.pro:
       
  2727         * platform/gdk/ContextMenuGdk.cpp: Added.
       
  2728         (WebCore::ContextMenu::ContextMenu):
       
  2729         (WebCore::ContextMenu::~ContextMenu):
       
  2730         (WebCore::ContextMenu::appendItem):
       
  2731         (WebCore::ContextMenu::setPlatformDescription):
       
  2732         (WebCore::ContextMenu::platformDescription):
       
  2733         (WebCore::ContextMenu::releasePlatformDescription):
       
  2734         * platform/gdk/ContextMenuItemGdk.cpp: Added.
       
  2735         (WebCore::ContextMenuItem::ContextMenuItem):
       
  2736         (WebCore::ContextMenuItem::~ContextMenuItem):
       
  2737         (WebCore::ContextMenuItem::releasePlatformDescription):
       
  2738         (WebCore::ContextMenuItem::type):
       
  2739         (WebCore::ContextMenuItem::setType):
       
  2740         (WebCore::ContextMenuItem::action):
       
  2741         (WebCore::ContextMenuItem::setAction):
       
  2742         (WebCore::ContextMenuItem::title):
       
  2743         (WebCore::ContextMenuItem::setTitle):
       
  2744         (WebCore::ContextMenuItem::platformSubMenu):
       
  2745         (WebCore::ContextMenuItem::setSubMenu):
       
  2746         (WebCore::ContextMenuItem::setChecked):
       
  2747         * platform/gdk/TemporaryLinkStubs.cpp:
       
  2748 
       
  2749 2007-09-18  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  2750 
       
  2751         Reviewed by Adam.
       
  2752 
       
  2753         Implement the WebCore::fileSize function using g_stat.
       
  2754 
       
  2755         * platform/gdk/FileSystemGdk.cpp:
       
  2756         (WebCore::fileSize):
       
  2757         * platform/gdk/TemporaryLinkStubs.cpp:
       
  2758 
       
  2759 2007-09-18  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  2760 
       
  2761         Reviewed by Adam.
       
  2762 
       
  2763         Move the ResourceHandle stubs from TemporaryLinkStubs
       
  2764         to the ResourceHandleCurl.cpp file. This affects the
       
  2765         Gtk+ and wx port as they share the curl implementation.
       
  2766 
       
  2767 
       
  2768         * platform/gdk/TemporaryLinkStubs.cpp:
       
  2769         * platform/network/curl/ResourceHandleCurl.cpp:
       
  2770         (WebCore::ResourceHandle::willLoadFromCache):
       
  2771         (WebCore::ResourceHandle::loadsBlocked):
       
  2772         * platform/wx/TemporaryLinkStubs.cpp:
       
  2773 
       
  2774 2007-09-17  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  2775 
       
  2776         Reviewed by Mark.
       
  2777 
       
  2778         Take http://bugs.webkit.org/show_bug.cgi?id=15221 into account
       
  2779         and change the variable names from nameSystem to systemName and
       
  2780         change the name of the function to stringByAdoptingFileSystemRepresentation.
       
  2781 
       
  2782         * platform/gdk/FileChooserGdk.cpp:
       
  2783         (WebCore::stringByAdoptingFileSystemRepresentation):
       
  2784         (WebCore::FileChooser::basenameForWidth):
       
  2785 
       
  2786 2007-09-19  Sam Weinig  <sam@webkit.org>
       
  2787 
       
  2788         Reviewed by Geoff Garen.
       
  2789 
       
  2790         Fix <rdar://problem/5492141> Assertion in isdigit() on windows Safari
       
  2791 
       
  2792         Test: fast/css/hexColor-isDigit-assert.html
       
  2793 
       
  2794         * platform/DeprecatedString.cpp:
       
  2795         (WebCore::isCharacterAllowedInBase): Check that the character is ascii 
       
  2796         to avoid an assertions on Windows.
       
  2797 
       
  2798 2007-09-19  Anders Carlsson  <andersca@apple.com>
       
  2799 
       
  2800         Reviewed by Geoff.
       
  2801 
       
  2802         <rdar://problem/5489879>
       
  2803         Combination of real player with high connection quality in selecting player makes Safari quit.
       
  2804         
       
  2805         Prevent the Real Player plug-in from calling the window proc recursively.
       
  2806         
       
  2807         * plugins/win/PluginViewWin.cpp:
       
  2808         (WebCore::PluginViewWin::wndProc):
       
  2809         (WebCore::PluginViewWin::setNPWindowRect):
       
  2810         (WebCore::PluginViewWin::determineQuirks):
       
  2811         (WebCore::PluginViewWin::PluginViewWin):
       
  2812         * plugins/win/PluginViewWin.h:
       
  2813         (WebCore::):
       
  2814 
       
  2815 2007-09-18  Adele Peterson  <adele@apple.com>
       
  2816 
       
  2817         Reviewed by Maciej.
       
  2818 
       
  2819         Fix for <rdar://problem/5472062> -webkit-user-select: none makes selection difficult
       
  2820         and for <rdar://problem/5472056> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)
       
  2821 
       
  2822         Tests:
       
  2823 
       
  2824         This fix has a few steps:
       
  2825         1) Removes the ignore value for the -webkit-user-select property.  We now decide when to prevent selection from starting by calling canStartSelection on the node.
       
  2826         2) Implements canStartSelection which returns false for all elements that used to have -webkit-user-select:ignore set, true for content editable nodes, 
       
  2827            and walks up the tree to ask the parent before allowing selection to be started on any other nodes.
       
  2828         3) We used to disallow selection from starting within -webkit-user-select:none blocks, but now we only use canStartSelection for that.  This will allow easy selections
       
  2829            in cases like iChat where there's a mix of selectable and non-selectable content.
       
  2830         4) Makes -webkit-user-select inherited.  After removing the "ignore" value, -webkit-user-select would behave like it was inherited anyways since we already allowed the text value to override the none value.
       
  2831 
       
  2832 
       
  2833         * css/html4.css: Removed all usage of -webkit-user-select: ignore.  This is now handled internally with canStartSelection().
       
  2834           Now -webkit-user-select won't be unintentionally overridden by nodes that don't want to allow selection to be started, but do want to honor the -webkit-user-select to
       
  2835           determine whether or not selection is allowed at all.
       
  2836 
       
  2837         * editing/SelectionController.cpp: (WebCore::SelectionController::selectAll):
       
  2838           Don't try to determine whether selection is allowed inside the root node here.  VisiblePosition and Selection creation will keep Selection endpoints out of -webkit-user-select:none regions.
       
  2839         
       
  2840         * dom/Node.h:
       
  2841         * dom/Node.cpp: (WebCore::Node::canStartSelection): Added. Always allows selection to be started in a content editable node.  If there's a parent, ask the parent if starting a selection is allowed.
       
  2842           If there's no parent, default to allowing selection.
       
  2843         * html/HTMLAnchorElement.h:
       
  2844         * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::canStartSelection): Added. If its not a link, then calls the base class. Disallows selection for non-editable links.
       
  2845           Allows selection for editable links.
       
  2846           This logic used to be done in CSSStyleSelector by changing the user-select property.
       
  2847         * html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::canStartSelection): Added. Disallows selection from starting in buttons.
       
  2848         * html/HTMLImageElement.h: (WebCore::HTMLImageElement::canStartSelection): Added. Disallows selection from starting in images.
       
  2849         * html/HTMLInputElement.h:
       
  2850         * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::canStartSelection): Added. Disallows selection from anything that's not a text field.  Text fields call up to the base class.
       
  2851           When they're editable, text controls will always be selectable because of the case for content editable content. Otherwise, they'll respect their parent element's decision about starting a selection. 
       
  2852         * html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::canStartSelection): Added. Disallows selection from starting in popup buttons.
       
  2853 
       
  2854         * page/EventHandler.cpp:
       
  2855         (WebCore::EventHandler::selectClosestWordFromMouseEvent): Use canMouseDownStartSelect instead of the ambiguously named shouldSelect().
       
  2856         (WebCore::EventHandler::handleMousePressEventTripleClick): ditto.
       
  2857         (WebCore::EventHandler::handleMousePressEventSingleClick): ditto.
       
  2858         (WebCore::EventHandler::updateSelectionForMouseDrag): Use canMouseDragExtendSelect.
       
  2859         (WebCore::EventHandler::selectCursor): Paint an ibeam in any region that allows you to click to create a selection.
       
  2860         (WebCore::EventHandler::canMouseDownStartSelect): Now fires the selectStart event, and calls canStartSelection instead of checking the user-select property.
       
  2861         (WebCore::EventHandler::canMouseDragExtendSelect): This is identical to canMouseDownStartSelect because of 12823, even though it seems strange that we would fire the selectStart event here.
       
  2862         * page/EventHandler.h:
       
  2863         * page/FocusController.cpp: (WebCore::clearSelectionIfNeeded): Calls canStartSelection instead of checking the user-select property to decide when to prevent selection creation. 
       
  2864         * rendering/RenderObject.cpp: (WebCore::RenderObject::draggableNode): ditto.
       
  2865         * rendering/RenderObject.h: Removed helper methods that are no longer needed.
       
  2866 
       
  2867         * rendering/RenderStyle.h: Made userSelect inherited.  After removing the "ignore" value, -webkit-user-select would behave like it was inherited 
       
  2868           anyways since we already allowed the text value to override the none value.
       
  2869           Removed the SELECT_AUTO and SELECT_IGNORE values since they're no longer used.
       
  2870         (WebCore::):
       
  2871         (WebCore::RenderStyle::userSelect):
       
  2872         (WebCore::RenderStyle::setUserSelect):
       
  2873         (WebCore::RenderStyle::initialUserSelect):
       
  2874         * rendering/RenderStyle.cpp:
       
  2875         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
       
  2876         (WebCore::StyleRareNonInheritedData::operator==):
       
  2877         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
       
  2878         (WebCore::StyleRareInheritedData::operator==):
       
  2879         (WebCore::RenderStyle::diff):
       
  2880 
       
  2881         * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Remove case for SELECT_AUTO and SELECT_IGNORE
       
  2882         * css/CSSStyleSelector.cpp:
       
  2883         (WebCore::CSSStyleSelector::adjustRenderStyle):  Remove adjustment for links.  This is now handled in HTMLAnchorElement::canStartSelection.
       
  2884         (WebCore::CSSStyleSelector::applyProperty): Map CSS_VAL_AUTO to SELECT_TEXT.  Remove CSS_VAL_IGNORE.
       
  2885 
       
  2886 2007-09-18  Timothy Hatcher  <timothy@apple.com>
       
  2887 
       
  2888         Reviewed by Darin.
       
  2889 
       
  2890         <rdar://problem/5478250> REGRESSION: After pasting text copied from Mail subject and typing return, the cursor disappears because of negative left margin
       
  2891 
       
  2892         When pasting text from the Mail subject line, the RTF pasteboard contains text that has a first line negative indent along with a
       
  2893         paragraph indent that has a counteracting positive indent. This results in the first line being flush left justified, and the remaining
       
  2894         wrapped lines being indented. When this is converted to a DOM fragment, AppKit makes a block element with a margin-left and a negative
       
  2895         text-indent that matches the RTF. So far this is all correct behavior.
       
  2896 
       
  2897         When this content is pasted on the line of an existing paragraph that has content, ReplaceSelectionCommand will decided to merge the paragraphs.
       
  2898         This will convert the block element to a style span that has all inherited style properties. These inherited properties will still contain block
       
  2899         properties that have no affect on inline elements. These block properties will hang around on the style span and will get cloned to new block
       
  2900         elements if the user hit return on that line. The new block elements would then have the text-indent but not the margin-left, so the text would be
       
  2901         hidden off the left edge of the page.
       
  2902 
       
  2903         In the end, we should never hang on to block-only properties in our style spans. This cuts out meaningless properties and prevents properties
       
  2904         from magically affecting blocks later if the style is cloned for a new block element during a future editing operation.
       
  2905 
       
  2906         * editing/ReplaceSelectionCommand.cpp:
       
  2907         (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Remove any inherited block properties that are now in the span's style.
       
  2908         * editing/markup.cpp:
       
  2909         (WebCore::createMarkup): Ditto.
       
  2910 
       
  2911 2007-09-18  Dave Hyatt  <hyatt@apple.com>
       
  2912 
       
  2913         Land a UnicodeRange helper class (ported from Mozilla) that we are going to use to prepare for making
       
  2914         language-sensitive fallback choices for fonts.
       
  2915 
       
  2916         Reviewed by olliej
       
  2917 
       
  2918         * WebCore.vcproj/WebCore.vcproj:
       
  2919         * platform/UnicodeRange.cpp: Added.
       
  2920         (WebCore::):
       
  2921         (WebCore::findCharUnicodeRange):
       
  2922         (WebCore::langGroupFromUnicodeRange):
       
  2923         * platform/UnicodeRange.h: Added.
       
  2924 
       
  2925 2007-09-18  Dave Hyatt  <hyatt@apple.com>
       
  2926 
       
  2927         Fix a bug in my previous patch.  Make sure to select the old font back into the HDC and to also release the HDC.
       
  2928        
       
  2929         Reviewed by aroben
       
  2930 
       
  2931         * platform/win/FontCacheWin.cpp:
       
  2932         (WebCore::FontCache::getFontDataForCharacters):
       
  2933 
       
  2934 2007-09-18  Sam Weinig  <sam@webkit.org>
       
  2935 
       
  2936         Reviewed by Darin.
       
  2937 
       
  2938         Patch for <rdar://problem/5488478> Safari crashes when passing null to Range.insertNode()
       
  2939 
       
  2940         Test: fast/dom/Range-insertNode-crash.html
       
  2941 
       
  2942         * dom/Range.cpp:
       
  2943         (WebCore::Range::insertNode): Null check the passed in node to insert.
       
  2944 
       
  2945 2007-09-18  Mike Fenton  <mike@staikos.net>
       
  2946 
       
  2947         Reviewed by George Staikos.
       
  2948 
       
  2949         Retain the pen properties when changing one aspect of the pen.
       
  2950 
       
  2951         * html/CanvasStyle.cpp:
       
  2952         (WebCore::CanvasStyle::applyStrokeColor):
       
  2953 
       
  2954 2007-09-18  Mike Fenton  <mike@staikos.net>
       
  2955 
       
  2956         Reviewed by George Staikos.
       
  2957 
       
  2958         Make <canvas> work in more cases by restarting the painter after we
       
  2959         finish painting, and restoring the pen and opacity.
       
  2960 
       
  2961         * html/HTMLCanvasElement.cpp:
       
  2962         (WebCore::HTMLCanvasElement::paint):
       
  2963 
       
  2964 2007-09-18  Mitz Pettel  <mitz@webkit.org>
       
  2965 
       
  2966         Reviewed by Darin.
       
  2967 
       
  2968         - fix http://bugs.webkit.org/show_bug.cgi?id=15169
       
  2969           Freeze on Google maps using the "Dig a hole" tool
       
  2970           <rdar://problem/5477414>
       
  2971 
       
  2972         Test: fast/dom/CSSStyleDeclaration-empty-string-property.html
       
  2973 
       
  2974         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
       
  2975         (WebCore::cssPropertyName): Added an early return if the property name
       
  2976         is the empty string, thus avoiding a loop that is not prepared for that
       
  2977         case.
       
  2978 
       
  2979 2007-09-19  Darin Adler <darin@apple.com>
       
  2980 
       
  2981         Reviewed by Adam.
       
  2982 
       
  2983         - fix <rdar://problem/5415734> <select> draws incorrectly if size of menu options
       
  2984           is changed after it pops up once
       
  2985 
       
  2986         * platform/win/PopupMenuWin.cpp:
       
  2987         (WebCore::PopupMenu::PopupMenu): Removed unnecessary initialization of IntRect.
       
  2988         (WebCore::PopupMenu::show): Check that the clientRect is empty instead of checking
       
  2989         the entire windowRect -- this fixes a bug where we pop up a tiny 2-pixel high black
       
  2990         box when you click on an empty menu.
       
  2991         (WebCore::PopupMenu::visibleItems): Base the number of items on the client rect
       
  2992         instead of the window rect. Rounding down means this would have worked anyway, but
       
  2993         it's more correct to do it this way.
       
  2994         (WebCore::PopupMenu::paint): Deallocate the bitmap so it gets reallocated if it
       
  2995         has the wrong width or height (or if GetObject returns false, which should not
       
  2996         happen in practice).
       
  2997 
       
  2998 2007-09-18  David Harrison  <harrison@apple.com>
       
  2999 
       
  3000         Reviewed by Darin.
       
  3001 
       
  3002         <rdar://problem/5486974> REGRESSION(r25373): 1/4 second to doubleclick word in GMail when using Kotoeri IM, also slow in other IMs (15163)
       
  3003 
       
  3004         Updated tests:
       
  3005         * fast/dom/Window/window-xy-properties-expected.txt:
       
  3006         * fast/dom/plugin-attributes-enumeration-expected.txt:
       
  3007         * fast/events/onerror-bubbling-expected.txt:
       
  3008         * fast/events/related-target-expected.txt:
       
  3009         * fast/forms/select-namedItem-expected.txt:
       
  3010         * fast/table/incomplete-table-in-fragment-2-expected.txt:
       
  3011         * fast/table/incomplete-table-in-fragment-hang-expected.txt:
       
  3012         * fast/table/large-rowspan-crash-expected.txt:
       
  3013         * plugins/embed-attributes-setting-expected.txt:
       
  3014 
       
  3015         * editing/TextIterator.cpp:
       
  3016         (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
       
  3017         Avoid VisiblePosition check if the current node is a descendant
       
  3018         of the start container and the start offset was 0. In that case
       
  3019         we already had enough context to correctly decide whether to emit
       
  3020         a newline after a preceding block. We chose not to emit
       
  3021         (m_haveEmitted is false), so don't second guess that.
       
  3022             
       
  3023         (WebCore::TextIterator::exitNode):
       
  3024         Changed some comments.
       
  3025 
       
  3026 2007-09-17  Geoffrey Garen  <ggaren@apple.com>
       
  3027 
       
  3028         Reviewed by Darin Adler.
       
  3029 
       
  3030         Speculative fix for <rdar://problem/5479443> REGRESSION: Hang due to 
       
  3031         infinite JS recursion on close @ engadget.com (onunload-based ad)
       
  3032         
       
  3033         If page is NULL, shouldInterruptScript now returns true, so you can't 
       
  3034         get stuck in a state in which a script executes forever without putting 
       
  3035         up a UI to ask if it should stop.
       
  3036 
       
  3037         * bindings/js/kjs_binding.cpp:
       
  3038         (KJS::ScriptInterpreter::shouldInterruptScript):
       
  3039 
       
  3040 2007-09-17  Dave Hyatt  <hyatt@apple.com>
       
  3041 
       
  3042         Fix for bug 14743, missing glyphs on many international sites because of MLang's tiny cache.
       
  3043         
       
  3044         Bypass Mlang's cache entirely.  Get the mapped font from MLang, obtain the font name, and then feed
       
  3045         the name back into our own system so that it gets created and cached again without MLang being involved.
       
  3046         Then free up the font obtained from MLang immediately so that its cache just remains empty.
       
  3047            
       
  3048         Reviewed by aroben
       
  3049 
       
  3050         * platform/FontData.h:
       
  3051         (WebCore::FontData::isSystemFont):
       
  3052         * platform/win/FontCacheWin.cpp:
       
  3053         (WebCore::FontCache::getFontDataForCharacters):
       
  3054         * platform/win/FontDataWin.cpp:
       
  3055         (WebCore::FontData::platformInit):
       
  3056         (WebCore::FontData::platformDestroy):
       
  3057         * platform/win/UniscribeController.cpp:
       
  3058         (WebCore::UniscribeController::shapeAndPlaceItem):
       
  3059         
       
  3060 2007-09-17  Adam Roben  <aroben@apple.com>
       
  3061 
       
  3062         Fix <rdar://5423441> Should get focus ring color from SafariTheme
       
  3063 
       
  3064         Reviewed by Hyatt.
       
  3065 
       
  3066         No regression test possible.
       
  3067 
       
  3068         * WebCore.vcproj/WebCore.vcproj: Added ColorSafari.cpp.
       
  3069         * platform/graphics/win/ColorSafari.cpp: Added.
       
  3070         (WebCore::makeRGBAFromCGColor): Added.
       
  3071         (WebCore::focusRingColor): Added. Gets the focus ring color from
       
  3072         SafariTheme if SafariTheme has support for it.
       
  3073         (WebCore::setFocusRingColorChangeFunction): Added.
       
  3074         * platform/win/TemporaryLinkStubs.cpp: Removed focus ring color
       
  3075         functions.
       
  3076 
       
  3077 2007-09-17  Anders Carlsson  <andersca@apple.com>
       
  3078 
       
  3079         Fix Windows build.
       
  3080 
       
  3081         * WebCore.vcproj/WebCore.vcproj:
       
  3082         * loader/NetscapePlugInStreamLoader.h:
       
  3083 
       
  3084 2007-09-17  Anders Carlsson  <andersca@apple.com>
       
  3085 
       
  3086         Fix Mac build.
       
  3087         
       
  3088         * loader/NetscapePlugInStreamLoader.cpp:
       
  3089         * loader/NetscapePlugInStreamLoader.h:
       
  3090         * loader/win/NetscapePlugInStreamLoaderWin.cpp: Copied from loader/NetscapePlugInStreamLoader.cpp.
       
  3091 
       
  3092 2007-09-17  Anders Carlsson  <andersca@apple.com>
       
  3093 
       
  3094         Reviewed by Adam.
       
  3095 
       
  3096         <rdar://problem/5483346>
       
  3097         crash at vw.com WebCore::PluginViewWin::disconnectStream.
       
  3098         
       
  3099         The following events would lead to this crash:
       
  3100         
       
  3101         1. a plug-in stream finishes loading and calls NPP_DestroyStream.
       
  3102         2. the DestroyStream handler calls NPN_Evaluate, submitting a form through JavaScript.
       
  3103         3. A new page is going to be loaded and DocumentLoader::stopLoading is called.
       
  3104         4. DocumentLoader::stopLoading will stop all loader, including the one that is done loading!
       
  3105         
       
  3106         The fix is to port NetscapePluginStreamLoader over from the Mac code and use it instead. This fixes the crash
       
  3107         because it disassociates the stream loader with the document loader _before_ calling NPP_DestroyStream, whereas
       
  3108         SubresourceLoader does this _after_ calling NPP_DestroyStream. 
       
  3109         
       
  3110         * loader/NetscapePlugInStreamLoader.cpp:
       
  3111         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
       
  3112         (WebCore::NetscapePlugInStreamLoader::~NetscapePlugInStreamLoader):
       
  3113         (WebCore::NetscapePlugInStreamLoader::create):
       
  3114         (WebCore::NetscapePlugInStreamLoader::isDone):
       
  3115         (WebCore::NetscapePlugInStreamLoader::releaseResources):
       
  3116         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
       
  3117         (WebCore::NetscapePlugInStreamLoader::didReceiveData):
       
  3118         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
       
  3119         (WebCore::NetscapePlugInStreamLoader::didFail):
       
  3120         (WebCore::NetscapePlugInStreamLoader::didCancel):
       
  3121         * loader/NetscapePlugInStreamLoader.h:
       
  3122         (WebCore::NetscapePlugInStreamLoaderClient::didFinishLoading):
       
  3123         * plugins/win/PluginStreamWin.cpp:
       
  3124         (WebCore::PluginStreamWin::start):
       
  3125         (WebCore::PluginStreamWin::didReceiveResponse):
       
  3126         (WebCore::PluginStreamWin::didReceiveData):
       
  3127         (WebCore::PluginStreamWin::didFail):
       
  3128         (WebCore::PluginStreamWin::didFinishLoading):
       
  3129         * plugins/win/PluginStreamWin.h:
       
  3130         * plugins/win/PluginViewWin.cpp:
       
  3131         (WebCore::PluginViewWin::load):
       
  3132 
       
  3133 2007-09-17  Anders Carlsson  <andersca@apple.com>
       
  3134 
       
  3135         Reviewed by Adam.
       
  3136 
       
  3137         <rdar://problem/5483839>
       
  3138         Crash loading http://www.microsoft.com if Silverlight 1.0 is installed.
       
  3139         
       
  3140         Work around a problem in our NPRuntime implementation by never unloading the silverlight plug-in dll.
       
  3141         
       
  3142         * plugins/win/PluginViewWin.cpp:
       
  3143         (WebCore::PluginViewWin::~PluginViewWin):
       
  3144         (WebCore::PluginViewWin::determineQuirks):
       
  3145         * plugins/win/PluginViewWin.h:
       
  3146         (WebCore::):
       
  3147 
       
  3148 2007-09-17  Brady Eidson  <beidson@apple.com>
       
  3149 
       
  3150         Reviewed by John Sullivan
       
  3151 
       
  3152         Fix for http://bugs.webkit.org/show_bug.cgi?id=15178
       
  3153         and
       
  3154         <rdar://problem/5474001>
       
  3155 
       
  3156         The stress test proves that this was an overzealous ASSERT.  It is very possible to mark an icon
       
  3157         for addition to the on-disk database and then mark it for removal before it is ever written out.  
       
  3158         This is not an error and was already handled gracefully
       
  3159 
       
  3160         * loader/icon/IconDatabase.cpp:
       
  3161         (WebCore::IconDatabase::removeIconFromSQLDatabase): Don't ASSERT of log if the icon wasn't on disk
       
  3162 
       
  3163 2007-09-17  Brady Eidson  <beidson@apple.com>
       
  3164 
       
  3165         Reviewed by Oliver
       
  3166 
       
  3167         <rdar://problem/5487048> - ASSERT in stress test in IconDatabase
       
  3168 
       
  3169         If a PageURLRecord went away, it never clears its URL from the IconRecord it retained.
       
  3170 
       
  3171         * loader/icon/PageURLRecord.cpp:
       
  3172         (WebCore::PageURLRecord::~PageURLRecord): Set the icon record to 0, clearing the page url
       
  3173         * loader/icon/PageURLRecord.h: Add the destructor
       
  3174 
       
  3175 2007-09-17  Antti Koivisto  <antti@apple.com>
       
  3176 
       
  3177         Reviewed by Darin.
       
  3178         
       
  3179         Fix <rdar://problem/5480050>
       
  3180         Leopard9A551 with Dashcode 112: Dashcode crash when dragging image into canvas.
       
  3181         
       
  3182         If @import stylesheet was modified through CSS DOM style selector would not get updated. This
       
  3183         could lead to crashes.
       
  3184 
       
  3185         Test: fast/css/import-style-update.html
       
  3186 
       
  3187         * css/CSSStyleSheet.cpp:
       
  3188         (WebCore::CSSStyleSheet::styleSheetChanged):
       
  3189 
       
  3190 2007-09-17  Anders Carlsson  <andersca@apple.com>
       
  3191 
       
  3192         Reviewed by Adam.
       
  3193 
       
  3194         <rdar://problem/5421997>
       
  3195         http://bugs.webkit.org/show_bug.cgi?id=14247
       
  3196         Display problem with Flash - image does not stop changing
       
  3197         
       
  3198         Port the manual load code over from the Mac version.
       
  3199 
       
  3200         * plugins/win/PluginDatabaseWin.cpp:
       
  3201         (WebCore::PluginDatabaseWin::createPluginView):
       
  3202         * plugins/win/PluginDatabaseWin.h:
       
  3203         Add load manually parameter.
       
  3204         
       
  3205         * plugins/win/PluginStreamWin.cpp:
       
  3206         (WebCore::PluginStreamWin::stop):
       
  3207         If we're loading manually, cancel the main resource load.
       
  3208          
       
  3209         (WebCore::PluginStreamWin::destroyStream):
       
  3210         Don't disconnect the stream if we're loading manually.
       
  3211         
       
  3212         * plugins/win/PluginViewWin.cpp:
       
  3213         (WebCore::PluginViewWin::setFrameGeometry):
       
  3214         Always call updateWindow()
       
  3215         
       
  3216         (WebCore::PluginViewWin::PluginViewWin):
       
  3217         Initialize loadManually.
       
  3218         
       
  3219         (WebCore::PluginViewWin::init):
       
  3220         Don't set the width and height of the window here since it will make the plug-in HWND show briefly
       
  3221         before it's been positioned.
       
  3222         
       
  3223         (WebCore::PluginViewWin::didReceiveResponse):
       
  3224         Create the manual stream.
       
  3225         
       
  3226         (WebCore::PluginViewWin::didReceiveData):
       
  3227         (WebCore::PluginViewWin::didFinishLoading):
       
  3228         (WebCore::PluginViewWin::didFail):
       
  3229         Call through to the manual stream.
       
  3230         
       
  3231         * plugins/win/PluginViewWin.h:
       
  3232 
       
  3233 2007-09-16  Sam Weinig  <sam@webkit.org>
       
  3234 
       
  3235         Reviewed by Maciej.
       
  3236 
       
  3237         Fix for http://bugs.webkit.org/show_bug.cgi?id=14693
       
  3238         document.width/height doesn't force layout
       
  3239 
       
  3240         Test: fast/dom/document-width-height-force-layout.html
       
  3241 
       
  3242         * html/HTMLDocument.cpp:
       
  3243         (WebCore::HTMLDocument::width): Force layout.
       
  3244         (WebCore::HTMLDocument::height): ditto.
       
  3245         * html/HTMLDocument.h:
       
  3246 
       
  3247 2007-09-15  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  3248 
       
  3249         Reviewed by Mark.
       
  3250 
       
  3251         Convert the filenames from WebCore::String to the filesystem encoding
       
  3252         and vice versa using g_filename_{from,to}_utf8 functions. Also add the needed NULL
       
  3253         checks for the return values where glib and gtk+ can return NULL.
       
  3254 
       
  3255         * platform/gdk/FileChooserGdk.cpp:
       
  3256         (WebCore::convertToStringByAdoptingTheFilesystemRepresentation):
       
  3257         (WebCore::FileChooser::openFileChooser):
       
  3258         (WebCore::FileChooser::basenameForWidth):
       
  3259 
       
  3260 2007-09-15  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  3261 
       
  3262         Reviewed by Mark.
       
  3263 
       
  3264         Use the new WebCore::String::fromUTF8 function to create
       
  3265         the labels.
       
  3266 
       
  3267         * platform/gdk/LocalizedStringsGdk.cpp:
       
  3268         (WebCore::submitButtonDefaultLabel):
       
  3269         (WebCore::inputElementAltText):
       
  3270         (WebCore::resetButtonDefaultLabel):
       
  3271         (WebCore::searchableIndexIntroduction):
       
  3272         (WebCore::fileButtonChooseFileLabel):
       
  3273         (WebCore::fileButtonNoFileSelectedLabel):
       
  3274         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
       
  3275         (WebCore::contextMenuItemTagDownloadLinkToDisk):
       
  3276         (WebCore::contextMenuItemTagCopyLinkToClipboard):
       
  3277         (WebCore::contextMenuItemTagOpenImageInNewWindow):
       
  3278         (WebCore::contextMenuItemTagDownloadImageToDisk):
       
  3279         (WebCore::contextMenuItemTagCopyImageToClipboard):
       
  3280         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
       
  3281         (WebCore::contextMenuItemTagCopy):
       
  3282         (WebCore::contextMenuItemTagGoBack):
       
  3283         (WebCore::contextMenuItemTagGoForward):
       
  3284         (WebCore::contextMenuItemTagStop):
       
  3285         (WebCore::contextMenuItemTagReload):
       
  3286         (WebCore::contextMenuItemTagCut):
       
  3287         (WebCore::contextMenuItemTagPaste):
       
  3288         (WebCore::contextMenuItemTagNoGuessesFound):
       
  3289         (WebCore::contextMenuItemTagIgnoreSpelling):
       
  3290         (WebCore::contextMenuItemTagLearnSpelling):
       
  3291         (WebCore::contextMenuItemTagSearchWeb):
       
  3292         (WebCore::contextMenuItemTagLookUpInDictionary):
       
  3293         (WebCore::contextMenuItemTagOpenLink):
       
  3294         (WebCore::contextMenuItemTagIgnoreGrammar):
       
  3295         (WebCore::contextMenuItemTagSpellingMenu):
       
  3296         (WebCore::contextMenuItemTagShowSpellingPanel):
       
  3297         (WebCore::contextMenuItemTagCheckSpelling):
       
  3298         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
       
  3299         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
       
  3300         (WebCore::contextMenuItemTagFontMenu):
       
  3301         (WebCore::contextMenuItemTagBold):
       
  3302         (WebCore::contextMenuItemTagItalic):
       
  3303         (WebCore::contextMenuItemTagUnderline):
       
  3304         (WebCore::contextMenuItemTagOutline):
       
  3305         (WebCore::contextMenuItemTagWritingDirectionMenu):
       
  3306         (WebCore::contextMenuItemTagDefaultDirection):
       
  3307         (WebCore::contextMenuItemTagLeftToRight):
       
  3308         (WebCore::contextMenuItemTagRightToLeft):
       
  3309         (WebCore::contextMenuItemTagInspectElement):
       
  3310         (WebCore::searchMenuNoRecentSearchesText):
       
  3311         (WebCore::searchMenuRecentSearchesText):
       
  3312         (WebCore::searchMenuClearRecentSearchesText):
       
  3313 
       
  3314 2007-09-15  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  3315 
       
  3316         Reviewed by Mark.
       
  3317 
       
  3318         Add WebCore::String::fromUTF8 to convert from UTF-8
       
  3319         to a WebCore::String. This is meant to be used by
       
  3320         the Gtk+ port and the signature and implementation
       
  3321         is similiar to the one of DeprecatedString.
       
  3322 
       
  3323         * platform/PlatformString.h:
       
  3324         * platform/String.cpp:
       
  3325         (WebCore::String::fromUTF8):
       
  3326 
       
  3327 2007-09-13  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  3328 
       
  3329         Reviewed by Anders.
       
  3330 
       
  3331         Implement the fileExists and deleteFile functions
       
  3332         using glib.
       
  3333 
       
  3334         * WebCore.pro:
       
  3335         * platform/gdk/FileSystemGdk.cpp: Added.
       
  3336         (WebCore::fileExists):
       
  3337         * platform/gdk/TemporaryLinkStubs.cpp:
       
  3338 
       
  3339 2007-09-16  David Harrison  <harrison@apple.com>
       
  3340 
       
  3341         Reviewed by Darin.
       
  3342 
       
  3343         <rdar://problem/5472125> REGRESSION (9A535-9A548): No VO cursor shown when navigating in a mail message body
       
  3344 
       
  3345         The problem was that the visible units code was mishandling non-editable content, generating null
       
  3346         VisiblePositions instead of the actual boundary VisiblePositions.
       
  3347         
       
  3348         Updated tests:
       
  3349         * fast/dom/Window/window-xy-properties-expected.txt:
       
  3350         * fast/dom/plugin-attributes-enumeration-expected.txt:
       
  3351         * fast/events/onerror-bubbling-expected.txt:
       
  3352         * fast/events/related-target-expected.txt:
       
  3353         * fast/forms/select-namedItem-expected.txt:
       
  3354         * fast/table/incomplete-table-in-fragment-2-expected.txt:
       
  3355         * fast/table/incomplete-table-in-fragment-hang-expected.txt:
       
  3356         * fast/table/large-rowspan-crash-expected.txt:
       
  3357         * plugins/embed-attributes-setting-expected.txt:
       
  3358        
       
  3359         Source Changes:
       
  3360         * editing/VisiblePosition.cpp:
       
  3361         (WebCore::VisiblePosition::next):
       
  3362         (WebCore::VisiblePosition::previous):
       
  3363         (WebCore::VisiblePosition::honorEditableBoundaryAtOrBefore):
       
  3364         (WebCore::VisiblePosition::honorEditableBoundaryAtOrAfter):
       
  3365         Rename firstEditablePositionAtOrAfter to honorEditableBoundaryAtOrAfter.
       
  3366         Rename firstEditablePositionAtOrBefore to honorEditableBoundaryAtOrBefore.
       
  3367         Changed these two functions to handle non-editable positions.
       
  3368         
       
  3369         * editing/VisiblePosition.h:
       
  3370         * editing/visible_units.cpp:
       
  3371         (WebCore::previousWordPosition):
       
  3372         (WebCore::nextWordPosition):
       
  3373         (WebCore::positionAvoidingFirstPositionInTable):
       
  3374         (WebCore::startPositionForLine):
       
  3375         (WebCore::startOfLine):
       
  3376         (WebCore::endOfLine):
       
  3377         (WebCore::previousSentencePosition):
       
  3378         (WebCore::nextSentencePosition):
       
  3379         Rename firstEditablePositionAtOrAfter to honorEditableBoundaryAtOrAfter.
       
  3380         Rename firstEditablePositionAtOrBefore to honorEditableBoundaryAtOrBefore.
       
  3381         Also, startOfLine() now calls positionAvoidingFirstPositionInTable() in the empty block early return case.
       
  3382         positionAvoidingFirstPositionInTable() was the logic startOfLine() used in the normal case. Now in a reusable function.
       
  3383 
       
  3384 2007-09-14  Oliver Hunt  <oliver@apple.com>
       
  3385 
       
  3386         Reviewed by Adam.
       
  3387 
       
  3388         Mac doesn't have any kind of not implemented macro, so we'll actually implement
       
  3389         fileSize.
       
  3390 
       
  3391         * platform/mac/FileSystemMac.mm:
       
  3392         (WebCore::fileSize):
       
  3393 
       
  3394 2007-09-14  Timothy Hatcher  <timothy@apple.com>
       
  3395 
       
  3396         Initialize m_dialogArguments to 0. Fixes the newly crashing layout tests.
       
  3397 
       
  3398         * bindings/js/kjs_window.cpp:
       
  3399         (KJS::WindowPrivate::WindowPrivate):
       
  3400 
       
  3401 2007-09-14  Oliver Hunt  <oliver@apple.com>
       
  3402 
       
  3403         Reviewed by Brady, John H.
       
  3404 
       
  3405         <rdar://problem/5483632> File system operation wrappers are unimplemented on windows
       
  3406         
       
  3407         Implement Windows versions of fileExists and deleteFile. 
       
  3408         Also corrects fileSize to use a 64-bit version of stat.
       
  3409 
       
  3410         * platform/win/FileSystemWin.cpp:
       
  3411         (WebCore::fileSize):  
       
  3412           Renamed argument to be more consistent with others.
       
  3413           And converted to _stat32i64 to allow 64-bit filesizes
       
  3414         (WebCore::fileExists):
       
  3415         (WebCore::deleteFile):
       
  3416         * platform/win/TemporaryLinkStubs.cpp:
       
  3417 
       
  3418 2007-09-14  Oliver Hunt  <oliver@apple.com>
       
  3419 
       
  3420         Reviewed by Sam and Geoff.
       
  3421 
       
  3422         <rdar://problem/5333272> Cannot upload files when path contains 
       
  3423         non-ascii/multibyte characters
       
  3424 
       
  3425         We can't use _stat to determine file size on Windows as it may not 
       
  3426         correctly handle multibyte characters, so we have to use _wstat.
       
  3427         
       
  3428         In deference to the fact that we may one day use the FormDataStreamCFNet.cpp
       
  3429         on Mac i've wrapped the call to _wstat with a generic fileSize
       
  3430         method in FileSystem.h
       
  3431 
       
  3432         * WebCore.vcproj/WebCore.vcproj:
       
  3433         * platform/FileSystem.h:
       
  3434         * platform/network/cf/FormDataStreamCFNet.cpp:
       
  3435         * platform/win/FileSystemWin.cpp: Added.
       
  3436         (WebCore::setHTTPBody):
       
  3437         * platform/gdk/TemporaryLinkStubs.cpp:
       
  3438         * platform/mac/FileSystemMac.mm:
       
  3439         (WebCore::fileSize):
       
  3440         * platform/qt/TemporaryLinkStubs.cpp:
       
  3441 
       
  3442 2007-09-14  Timothy Hatcher  <timothy@apple.com>
       
  3443 
       
  3444         Reviewed by Sam.
       
  3445 
       
  3446         <rdar://problem/5472970> REGRESSION (r24276): TinyMCE popups show an empty window with no content
       
  3447 
       
  3448         Accessing the document of a window before the load finished would cause the window
       
  3449         object to hold onto the initial empty document, and never switch over to the real document
       
  3450         once the load finished. This regression was caused by r24276 which added a check to prevent
       
  3451         clearing the window object when the load finished. The absence of this clear allowed the
       
  3452         dialogArguments set with showModalDialog to persist on the window after the load. However,
       
  3453         not clearing the window would keep other properties (and the empty document object) around.
       
  3454 
       
  3455         So the fix is to store away the dialog arguments that were passed to showModalDialog and
       
  3456         put them back on the window object in the dialogArguments property each time
       
  3457         the window is cleared.
       
  3458 
       
  3459         * bindings/js/kjs_window.cpp:
       
  3460         (KJS::createWindow): No longer put dialogArguments on the window here.
       
  3461         (KJS::showModalDialog): Put dialogArguments on the window and call
       
  3462         setDialogArgumentsAndReturnValueSlot to remember the arguments.
       
  3463         (KJS::Window::clear): Put m_dialogArguments back on the window as dialogArguments.
       
  3464         (KJS::WindowFunc::callAsFunction): Call the new setDialogArgumentsAndReturnValue.
       
  3465         (KJS::Window::setDialogArgumentsAndReturnValue): Store the arguments in m_dialogArguments.
       
  3466         * bindings/js/kjs_window.h: Rename setReturnValueSlot to setDialogArgumentsAndReturnValueSlot.
       
  3467         * manual-tests/modal-dialog-arguments.html: Confirmed that this test still passes.
       
  3468 
       
  3469         Reverted r24276 which was all the changes in FrameLoader.cpp and FrameLoader.h.
       
  3470 
       
  3471         * loader/FrameLoader.cpp:
       
  3472         (WebCore::FrameLoader::FrameLoader): Remove m_shouldClearWindowProperties.
       
  3473         (WebCore::FrameLoader::createWindow): Remove the call to setShouldClearWindowProperties.
       
  3474         (WebCore::FrameLoader::clear): No longer check m_shouldClearWindowProperties, clear the
       
  3475         window whenever clearWindowProperties is set.
       
  3476         (WebCore::FrameLoader::begin): Remove m_shouldClearWindowProperties.
       
  3477         (WebCore::FrameLoader::open): Ditto.
       
  3478         * loader/FrameLoader.h: Remove m_shouldClearWindowProperties.
       
  3479 
       
  3480 2007-09-14  Brady Eidson  <beidson@apple.com>
       
  3481 
       
  3482         How about a build fix that works on *all* platforms?
       
  3483 
       
  3484         * platform/Threading.h:
       
  3485         (WebCore::initializeThreading):
       
  3486 
       
  3487 2007-09-14  Brady Eidson  <beidson@apple.com>
       
  3488 
       
  3489         Roll out my previous build fix and just make the stupid thing inline
       
  3490         (I knew there was something easier but oh boy, no coffee yet... weinig?)
       
  3491 
       
  3492 2007-09-14  Brady Eidson  <beidson@apple.com>
       
  3493 
       
  3494         Rubberstamped by Mark Rowe
       
  3495 
       
  3496         Add the logging channel I just created to the initialize list on Mac
       
  3497 
       
  3498         * platform/mac/LoggingMac.mm:
       
  3499         (WebCore::InitializeLoggingChannelsIfNecessary):
       
  3500 
       
  3501 2007-09-14  Brady Eidson  <beidson@apple.com>
       
  3502 
       
  3503         Build fix
       
  3504 
       
  3505         That method can't go in the header, apparently
       
  3506 
       
  3507         * platform/Threading.h:
       
  3508         * platform/gdk/TemporaryLinkStubs.cpp:
       
  3509         (WebCore::initializeThreading):
       
  3510         * platform/mac/Threading.mm:
       
  3511         (WebCore::initializeThreading):
       
  3512         * platform/qt/TemporaryLinkStubs.cpp:
       
  3513         (WebCore::initializeThreading):
       
  3514 
       
  3515 2007-09-14  Brady Eidson  <beidson@apple.com>
       
  3516 
       
  3517         Reviewed by Darin
       
  3518 
       
  3519         -Add callOnMainThread() implementation to Windows
       
  3520 
       
  3521         * WebCore.vcproj/WebCore.vcproj:
       
  3522         
       
  3523         * loader/icon/IconDatabase.cpp:
       
  3524         (WebCore::IconDatabase::open): Call initializeThreading() from the main thread before kicking off the secondary thread
       
  3525         
       
  3526         * platform/Logging.cpp: Added Threading logging channel
       
  3527         (WebCore::):
       
  3528         * platform/Logging.h: Ditto
       
  3529         
       
  3530         * platform/Threading.h:
       
  3531         (WebCore::initializeThreading): Added - only needs Windows impl for now
       
  3532         * platform/win/ThreadingWin.cpp: Added.
       
  3533         (WebCore::callFunctionsOnMainThread): Calls each function currently in the main-thread queue
       
  3534         (WebCore::ThreadingWindowWndProc):
       
  3535         (WebCore::initializeThreading): Creates a message-only window to use for callOnMainThread()
       
  3536         (WebCore::callOnMainThread): Queues the function to be called and posts a message to the threading
       
  3537           window such that the function-call-queue can be addressed
       
  3538         
       
  3539         * platform/win/TemporaryLinkStubs.cpp:
       
  3540         (WebCore::signedPublicKeyAndChallengeString):
       
  3541         
       
  3542 2007-09-14  Anders Carlsson  <andersca@apple.com>
       
  3543 
       
  3544         Reviewed by Adam.
       
  3545 
       
  3546         <rdar://problem/5316743>
       
  3547         Safari does not handle filename parameter of content-disposition
       
  3548         
       
  3549         Use CFURLResponseCopySuggestedFilename instead of our own hand-rolled implementation. 
       
  3550         
       
  3551         While we do return the correct filename in all cases I've tried, using CFNetwork is better because
       
  3552         it might handle corner cases that we don't.
       
  3553         
       
  3554         * platform/network/cf/ResourceResponseCFNet.cpp:
       
  3555         (WebCore::ResourceResponse::doUpdateResourceResponse):
       
  3556         
       
  3557 2007-09-14  Geoffrey Garen  <ggaren@apple.com>
       
  3558 
       
  3559         Reviewed by Adam Roben.
       
  3560 
       
  3561         Fixed http://bugs.webkit.org/show_bug.cgi?id=15209
       
  3562         Sometimes removing an iframe from the DOM does not remove its frame 
       
  3563         from the page
       
  3564 
       
  3565         * loader/FrameLoader.cpp:
       
  3566         (WebCore::FrameLoader::requestFrame): Use the contentFrame pointer
       
  3567         directly instead of searching for a frame by the frame element's name, 
       
  3568         because the frame element's name may have changed. (Another reason to do
       
  3569         this is that it's just plain more straight-forward and efficient.)
       
  3570 
       
  3571 2007-09-14  Darin Adler  <darin@apple.com>
       
  3572 
       
  3573         Reviewed by Mitz and Kevin Decker.
       
  3574 
       
  3575         - fix http://bugs.webkit.org/show_bug.cgi?id=15197
       
  3576           <rdar://problem/5478271> REGRESSION: Some Yahoo text entry fields
       
  3577           render as lines rather than text entry boxes
       
  3578 
       
  3579         Test: fast/forms/textarea-rows-cols.html
       
  3580 
       
  3581         * html/HTMLTextAreaElement.cpp:
       
  3582         (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Use constants for the default number
       
  3583         of rows and columns.
       
  3584         (WebCore::HTMLTextAreaElement::parseMappedAttribute): If rows/cols attribute has a value
       
  3585         that's missing, non-numeric, or zero, then use the default value. Also check for the
       
  3586         case where the effective value of the attribute isn't changing.
       
  3587 
       
  3588 2007-09-14  Sven Herzberg  <sven@imendio.com>
       
  3589 
       
  3590         Reviewed by George.
       
  3591 
       
  3592         Don't maintain obsolete code, fixes:
       
  3593         http://bugs.webkit.org/show_bug.cgi?id=15215
       
  3594 
       
  3595         * platform/gdk/FontPlatformData.cpp: remove static
       
  3596         FontPlatformData::list() (isn't used at any place)
       
  3597 
       
  3598 2007-09-14  Sven Herzberg  <sven@imendio.com>
       
  3599 
       
  3600         Reviewed by Adam Roben.
       
  3601 
       
  3602         Don't use fontconfig types if necessary, fixes:
       
  3603         http://bugs.webkit.org/show_bug.cgi?id=15203
       
  3604 
       
  3605         * platform/gdk/FontPlatformData.cpp: don't use an FcBool to store the
       
  3606         initialized state, use a plain c++ bool instead
       
  3607 
       
  3608 2007-09-13  Brady Eidson  <beidson@apple.com>
       
  3609 
       
  3610         Reviewed by Maciej
       
  3611 
       
  3612         <rdar://problem/5480437> - No site icon at launch and related error messages
       
  3613 
       
  3614         The error message was actually indicative of a larger bug that might've resulted in icons getting
       
  3615         improperly pruned because they were never added to the set of retained page URLs.
       
  3616 
       
  3617         To solve the no-icon-at-launch problem, we send the "didReceiveIcon:" delegate call for every page 
       
  3618         load that has an icon, whether the icon comes in from network, from disk, or was already in ram
       
  3619 
       
  3620         * loader/FrameLoader.cpp:
       
  3621         (WebCore::FrameLoader::startIconLoader): Always send the didReceiveIcon delegate call when an icon's 
       
  3622           image data is known
       
  3623 
       
  3624         * loader/icon/IconDatabase.cpp:
       
  3625         (WebCore::IconDatabase::retainIconForPageURL): Much more accurately track the set of retained pages by
       
  3626           adding them when their retain count moves from 0 to 1
       
  3627 
       
  3628         * loader/icon/PageURLRecord.h:
       
  3629         (WebCore::PageURLRecord::retain): Correctly distinguish the "retain count just went from 0 to 1" case
       
  3630           in the return value
       
  3631 
       
  3632 2007-09-13  Brady Eidson  <beidson@apple.com>
       
  3633 
       
  3634         Rubberstamped by Geoff and Maciej
       
  3635 
       
  3636         Fix MSVC build warning due to out of range data in a char array
       
  3637 
       
  3638         * loader/icon/IconDatabase.cpp:
       
  3639         (WebCore::IconDatabase::defaultIcon): The buffer is now unsigned data
       
  3640 
       
  3641         * platform/SharedBuffer.cpp:
       
  3642         (WebCore::SharedBuffer::SharedBuffer): Add the "unsigned char*" c'tor
       
  3643         * platform/SharedBuffer.h:
       
  3644 
       
  3645 2007-09-13  Darin Adler  <darin@apple.com>
       
  3646 
       
  3647         Reviewed by Oliver.
       
  3648 
       
  3649         - fix <rdar://problem/5470457> REGRESSION: Input method inline hole is mishandled in text
       
  3650           <input> elements with maxlength limit
       
  3651 
       
  3652         * editing/Editor.h: Moved MarkedTextUnderline here and renamed it CompositionUnderline.
       
  3653         Moved the rest of the marked text API here and used the term that will be more familiar
       
  3654         to those on platforms other than Macintosh, "composition". This helps prevent confusion
       
  3655         with the other kinds of mark -- the emacs "mark" and spelling/grammar marks. Also
       
  3656         cleaned up the conditionals a bit for the Macintosh-specific parts of this header.
       
  3657 
       
  3658         * editing/Editor.cpp:
       
  3659         (WebCore::Editor::Editor): Updated for name change.
       
  3660         (WebCore::Editor::clear): Added. To be called by FrameLoader::clear().
       
  3661         (WebCore::Editor::insertTextWithoutSendingTextEvent): Removed code to make inserted
       
  3662         text replace the marked text range -- we now deal with this explicitly by not
       
  3663         calling this function to replace marked text. Also removed unneeded code that was
       
  3664         specific to the use of this to replace the marked text.
       
  3665         (WebCore::Editor::selectComposition): Renamed from selectMarkedText. Updated since
       
  3666         the composition range is not stored as a Range.
       
  3667         (WebCore::Editor::confirmComposition): Added. To be called when changing a composition
       
  3668         into actual text. Unlike the old code path, deletes the composition first, then inserts
       
  3669         the text, triggering the normal insertion code path and events. This is helpful because
       
  3670         it means the inserted text will be truncated by the <input> element, for example.
       
  3671         (WebCore::Editor::confirmCompositionWithoutDisturbingSelection): Added.
       
  3672         (WebCore::Editor::setComposition): Added. To be called when changing the composition.
       
  3673         Takes parameters for the underlines and selection. Unlike the old code path, this passes
       
  3674         a flag down that indicates the inserted text is part of a composition. This is helpful
       
  3675         because we don't send the event that will cause the <input> element to do truncation.
       
  3676         It's also a better API for future improvements to our input method handling.
       
  3677         (WebCore::Editor::revealSelectionAfterEditingOperation): Updated for name change.
       
  3678         (WebCore::Editor::setIgnoreCompositionSelectionChange): Ditto.
       
  3679         (WebCore::Editor::compositionRange): Added. Needed now that the composition is not
       
  3680         stored as a Range.
       
  3681         (WebCore::Editor::getCompositionSelection): Added.
       
  3682 
       
  3683         * editing/TypingCommand.h:
       
  3684         * editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText):
       
  3685         Added an insertedTextIsComposition parameter, and don't send the BeforeTextInsertedEvent
       
  3686         if it's true.
       
  3687 
       
  3688         * loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Replaced the Macintosh-specific
       
  3689         call to setMarkedTextRange with a call to the new Editor::clear().
       
  3690 
       
  3691         * page/Frame.h:
       
  3692         * page/Frame.cpp:
       
  3693         * page/FramePrivate.h:
       
  3694         * page/mac/FrameMac.mm:
       
  3695         Removed the marked text code. It was streamlined and moved to Editor, except for the
       
  3696         Mac-specific code, which was moved into WebKit.
       
  3697 
       
  3698         * page/mac/WebCoreFrameBridge.h:
       
  3699         * page/mac/WebCoreFrameBridge.mm: Removed some now-unneeded marked text code.
       
  3700         (-[WebCoreFrameBridge markedTextNSRange]): Updated for name/API change.
       
  3701 
       
  3702         * rendering/InlineTextBox.h:
       
  3703         * rendering/InlineTextBox.cpp:
       
  3704         (WebCore::InlineTextBox::paint): Updated marked text code for name changes, and also
       
  3705         streamlined the code a bit for the case where there is no composition.
       
  3706         (WebCore::InlineTextBox::paintCompositionBackground): Name change.
       
  3707         (WebCore::InlineTextBox::paintCompositionUnderline): Ditto.
       
  3708 
       
  3709         * rendering/RenderTextControl.h:
       
  3710         * rendering/RenderTextControl.cpp:
       
  3711         (WebCore::RenderTextControl::finishText): Added. Helper function shared by the
       
  3712         (WebCore::RenderTextControl::text):
       
  3713         (WebCore::getNextSoftBreak):
       
  3714         (WebCore::RenderTextControl::textWithHardLineBreaks):
       
  3715 
       
  3716         * platform/CharacterNames.h: Added newlineCharacter.
       
  3717 
       
  3718         * dom/Range.h: Remove the now-unneeded version of toString that converts <br>
       
  3719         elements into newlines.
       
  3720         * dom/Range.cpp:
       
  3721         (WebCore::Range::toString): Changed this to use a Vector<UChar> instead of
       
  3722         a String so it will not have pathological reallocation performance, and removed
       
  3723         the <br> feature.
       
  3724         (WebCore::Range::pastEndNode): Made this return 0 when there is no start node.
       
  3725         This bit of extra robustness guarantees you can't do a null dereference if the
       
  3726         start node is 0 and the end node is not. Not sure this case really exists.
       
  3727 
       
  3728         * page/ContextMenuController.cpp: (ContextMenuController::contextMenuItemSelected):
       
  3729         Removed a semi-bogus use of Range::toString(true). The right function to use here
       
  3730         is plainText().
       
  3731 
       
  3732         * bridge/EditorClient.h: Removed obsolete markedTextAbandoned function.
       
  3733 
       
  3734         * WebCore.exp: Updated for above changes. 
       
  3735 
       
  3736 2007-09-13  Anders Carlsson  <andersca@apple.com>
       
  3737 
       
  3738         Reviewed by Adam and Geoff.
       
  3739 
       
  3740         <rdar://problem/5304000>
       
  3741         Windows Safari doesn't always call NPP_SetWindow() for NPAPI plugins.
       
  3742         
       
  3743         This does two things:
       
  3744         
       
  3745         1. Makes sure that the plug-in get the correct initial size.
       
  3746         
       
  3747         2. Always updates the size of the HWND, even if the widget size didn't change. This is because
       
  3748         the widget size can be different before the HWND has been created.
       
  3749         
       
  3750         * plugins/win/PluginDatabaseWin.cpp:
       
  3751         (WebCore::PluginDatabaseWin::createPluginView):
       
  3752         * plugins/win/PluginDatabaseWin.h:
       
  3753         * plugins/win/PluginViewWin.cpp:
       
  3754         (WebCore::PluginViewWin::setFrameGeometry):
       
  3755         (WebCore::PluginViewWin::PluginViewWin):
       
  3756         * plugins/win/PluginViewWin.h:
       
  3757 
       
  3758 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
       
  3759 
       
  3760         Reviewed by Geof, Sam, Adam, Hyatt, Darin.
       
  3761 
       
  3762         - <rdar://problem/5480234> JS setTimeout function requires a second argument
       
  3763         - Removed check for number of arguments in setTimeout to behave like other browsers.
       
  3764         - Added layoutTest setTimeout-no-arguments.html
       
  3765 
       
  3766         * bindings/js/kjs_window.cpp:
       
  3767         (KJS::WindowFunc::callAsFunction):
       
  3768 
       
  3769 2007-09-13   Dave Hyatt  <hyatt@apple.com>
       
  3770 
       
  3771         Some minor Windows font improvements before I make the larger changes.
       
  3772         
       
  3773         Reviewed by aroben, weinig
       
  3774 
       
  3775         * platform/win/FontCacheWin.cpp:
       
  3776         (WebCore::FontCache::getFontDataForCharacters):
       
  3777         Don't use the currently selected font in the HDC when passing priority code pages to MLANG.  Make
       
  3778         sure to use ACP code pages instead so that there won't be any confusion regarding traditional vs.
       
  3779         simplified chinese, etc.
       
  3780 
       
  3781         * platform/win/FontDataWin.cpp:
       
  3782         (WebCore::FontData::containsCharacters):
       
  3783         Rewrite containsCharacters so that it isn't glyph-dependent (since CG doesn't shape, this call is
       
  3784         rejecting fonts that it shouldn't).  Re-implement this method in terms of MLang and use code page
       
  3785         testing.
       
  3786         
       
  3787         * platform/win/UniscribeController.cpp:
       
  3788         (WebCore::UniscribeController::itemizeShapeAndPlace):
       
  3789         Add some comments to explain the additional item in the items array.
       
  3790        
       
  3791         (WebCore::UniscribeController::shape):
       
  3792         Fix up the missing glyph check when doing uniscribe shaping.  Only wgDefault matters as far as doing
       
  3793         font fallback.
       
  3794         
       
  3795 2007-09-13  kuchhal  <kuchhal@yahoo.com>
       
  3796 
       
  3797         Reviewed, tweaked and landed by Anders.
       
  3798 
       
  3799         <rdar://problem/5461153> 
       
  3800         http://bugs.webkit.org/show_bug.cgi?id=15143
       
  3801         Crash seen on Windows
       
  3802         
       
  3803         Null check frame before calling Frame::settings.
       
  3804         
       
  3805         * loader/PluginDocument.cpp:
       
  3806         (WebCore::PluginTokenizer::writeRawData):
       
  3807 
       
  3808 2007-09-12  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  3809 
       
  3810         Reviewed by Mark.
       
  3811 
       
  3812         Implement the FileChooser for the WebKit/Gtk+ port by using
       
  3813         the GtkFileChooserDialog and g_path_get_basename to get the
       
  3814         basename for the current filename.
       
  3815 
       
  3816 
       
  3817         * WebCore.pro:
       
  3818         * platform/gdk/FileChooserGdk.cpp: Added.
       
  3819         (WebCore::FileChooser::FileChooser):
       
  3820         (WebCore::FileChooser::~FileChooser):
       
  3821         (WebCore::FileChooser::openFileChooser):
       
  3822         (WebCore::FileChooser::basenameForWidth):
       
  3823         * platform/gdk/TemporaryLinkStubs.cpp:
       
  3824 
       
  3825 2007-09-12  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  3826 
       
  3827         Reviewed by Mark.
       
  3828 
       
  3829         Move the "string" functions from the TemporaryLinkStubs.cpp
       
  3830         to LocalizedStringsGdk.cpp and implement them using the text
       
  3831         from the win port and glib-i18n (gettext).
       
  3832 
       
  3833         * platform/gdk/LocalizedStringsGdk.cpp: Added.
       
  3834         (WebCore::submitButtonDefaultLabel):
       
  3835         (WebCore::inputElementAltText):
       
  3836         (WebCore::resetButtonDefaultLabel):
       
  3837         (WebCore::searchableIndexIntroduction):
       
  3838         (WebCore::fileButtonChooseFileLabel):
       
  3839         (WebCore::fileButtonNoFileSelectedLabel):
       
  3840         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
       
  3841         (WebCore::contextMenuItemTagDownloadLinkToDisk):
       
  3842         (WebCore::contextMenuItemTagCopyLinkToClipboard):
       
  3843         (WebCore::contextMenuItemTagOpenImageInNewWindow):
       
  3844         (WebCore::contextMenuItemTagDownloadImageToDisk):
       
  3845         (WebCore::contextMenuItemTagCopyImageToClipboard):
       
  3846         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
       
  3847         (WebCore::contextMenuItemTagCopy):
       
  3848         (WebCore::contextMenuItemTagGoBack):
       
  3849         (WebCore::contextMenuItemTagGoForward):
       
  3850         (WebCore::contextMenuItemTagStop):
       
  3851         (WebCore::contextMenuItemTagReload):
       
  3852         (WebCore::contextMenuItemTagCut):
       
  3853         (WebCore::contextMenuItemTagPaste):
       
  3854         (WebCore::contextMenuItemTagNoGuessesFound):
       
  3855         (WebCore::contextMenuItemTagIgnoreSpelling):
       
  3856         (WebCore::contextMenuItemTagLearnSpelling):
       
  3857         (WebCore::contextMenuItemTagSearchWeb):
       
  3858         (WebCore::contextMenuItemTagLookUpInDictionary):
       
  3859         (WebCore::contextMenuItemTagOpenLink):
       
  3860         (WebCore::contextMenuItemTagIgnoreGrammar):
       
  3861         (WebCore::contextMenuItemTagSpellingMenu):
       
  3862         (WebCore::contextMenuItemTagShowSpellingPanel):
       
  3863         (WebCore::contextMenuItemTagCheckSpelling):
       
  3864         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
       
  3865         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
       
  3866         (WebCore::contextMenuItemTagFontMenu):
       
  3867         (WebCore::contextMenuItemTagBold):
       
  3868         (WebCore::contextMenuItemTagItalic):
       
  3869         (WebCore::contextMenuItemTagUnderline):
       
  3870         (WebCore::contextMenuItemTagOutline):
       
  3871         (WebCore::contextMenuItemTagWritingDirectionMenu):
       
  3872         (WebCore::contextMenuItemTagDefaultDirection):
       
  3873         (WebCore::contextMenuItemTagLeftToRight):
       
  3874         (WebCore::contextMenuItemTagRightToLeft):
       
  3875         (WebCore::contextMenuItemTagInspectElement):
       
  3876         (WebCore::searchMenuNoRecentSearchesText):
       
  3877         (WebCore::searchMenuRecentSearchesText):
       
  3878         (WebCore::searchMenuClearRecentSearchesText):
       
  3879         (WebCore::unknownFileSizeText):
       
  3880         * platform/gdk/TemporaryLinkStubs.cpp:
       
  3881 
       
  3882 2007-09-10  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  3883 
       
  3884         Reviewed by Mark.
       
  3885 
       
  3886         EventHandlerGdk::createDraggingClipboard must succeed otherwise an
       
  3887         ASSERT is hit. Add Clipboard stubs for the Gdk/Gtk+ port and
       
  3888         instantiate ClipboardGdk from the EventHandlerGdk to make the ASSERT
       
  3889         go away. In contrast to the Windows and Mac port this clipboard is not
       
  3890         inheriting CachedResourceClient. This was proposed by Oliver.
       
  3891 
       
  3892         * WebCore.pro:
       
  3893         * page/gdk/EventHandlerGdk.cpp:
       
  3894         * platform/gdk/ClipboardGdk.cpp: Added.
       
  3895         (WebCore::ClipboardGdk::ClipboardGdk):
       
  3896         (WebCore::ClipboardGdk::~ClipboardGdk):
       
  3897         (WebCore::ClipboardGdk::clearData):
       
  3898         (WebCore::ClipboardGdk::clearAllData):
       
  3899         (WebCore::ClipboardGdk::getData):
       
  3900         (WebCore::ClipboardGdk::setData):
       
  3901         (WebCore::ClipboardGdk::types):
       
  3902         (WebCore::ClipboardGdk::dragLocation):
       
  3903         (WebCore::ClipboardGdk::dragImage):
       
  3904         (WebCore::ClipboardGdk::setDragImage):
       
  3905         (WebCore::ClipboardGdk::dragImageElement):
       
  3906         (WebCore::ClipboardGdk::setDragImageElement):
       
  3907         (WebCore::ClipboardGdk::createDragImage):
       
  3908         (WebCore::ClipboardGdk::declareAndWriteDragImage):
       
  3909         (WebCore::ClipboardGdk::writeURL):
       
  3910         (WebCore::ClipboardGdk::writeRange):
       
  3911         (WebCore::ClipboardGdk::hasData):
       
  3912         * platform/gdk/ClipboardGdk.h: Added.
       
  3913 
       
  3914 2007-09-12  Oliver Hunt  <oliver@apple.com>
       
  3915 
       
  3916         Reviewed by Adam.
       
  3917 
       
  3918         Corrections missed in previous revision
       
  3919 
       
  3920         * platform/Cursor.h:
       
  3921         * platform/win/CursorWin.cpp:
       
  3922         (WebCore::loadCursorByName):
       
  3923 
       
  3924 2007-09-12  Oliver Hunt  <oliver@apple.com>
       
  3925 
       
  3926         Reviewed by Adam.
       
  3927 
       
  3928         Fixing 
       
  3929             <rdar://problem/5018591> Windows doesn't have a standard vertical text cursor
       
  3930             <rdar://problem/5224996> Add zoom in and zoom out cursors
       
  3931 
       
  3932         Added SharedCursor for CursorWin so we can correctly track lifetime of custom/image
       
  3933         based cursors, such as the vertical text and zooming cursors.
       
  3934 
       
  3935         * platform/Cursor.h:
       
  3936         (WebCore::SharedCursor::SharedCursor):
       
  3937         (WebCore::SharedCursor::~SharedCursor):
       
  3938         (WebCore::SharedCursor::nativeCursor):
       
  3939         * platform/win/CursorWin.cpp:
       
  3940         (WebCore::Cursor::Cursor):
       
  3941         (WebCore::loadCursorByName):
       
  3942         (WebCore::loadSharedCursor):
       
  3943         (WebCore::pointerCursor):
       
  3944         (WebCore::crossCursor):
       
  3945         (WebCore::handCursor):
       
  3946         (WebCore::iBeamCursor):
       
  3947         (WebCore::waitCursor):
       
  3948         (WebCore::helpCursor):
       
  3949         (WebCore::eastResizeCursor):
       
  3950         (WebCore::northResizeCursor):
       
  3951         (WebCore::northEastResizeCursor):
       
  3952         (WebCore::northWestResizeCursor):
       
  3953         (WebCore::southResizeCursor):
       
  3954         (WebCore::southEastResizeCursor):
       
  3955         (WebCore::southWestResizeCursor):
       
  3956         (WebCore::westResizeCursor):
       
  3957         (WebCore::northSouthResizeCursor):
       
  3958         (WebCore::eastWestResizeCursor):
       
  3959         (WebCore::northEastSouthWestResizeCursor):
       
  3960         (WebCore::northWestSouthEastResizeCursor):
       
  3961         (WebCore::columnResizeCursor):
       
  3962         (WebCore::rowResizeCursor):
       
  3963         (WebCore::moveCursor):
       
  3964         (WebCore::verticalTextCursor):
       
  3965         (WebCore::progressCursor):
       
  3966         (WebCore::notAllowedCursor):
       
  3967         (WebCore::zoomInCursor):
       
  3968         (WebCore::zoomOutCursor):
       
  3969         * platform/win/WidgetWin.cpp:
       
  3970         (WebCore::Widget::setCursor):
       
  3971 
       
  3972 2007-09-12  Brady Eidson  <beidson@apple.com>
       
  3973 
       
  3974         Reviewed by Geoff Garen
       
  3975 
       
  3976         <rdar://problem/5478577> - Further improve cold launch time with Icon Database changes
       
  3977 
       
  3978         * loader/icon/IconDatabase.cpp:
       
  3979         (WebCore::IconDatabase::open): Store the directory and full path for later usage and access in the API, respectively
       
  3980           Move the makeAllDirectories() call to the background thread.
       
  3981         (WebCore::IconDatabase::IconDatabase): Don't set up the timer here...
       
  3982         (WebCore::IconDatabase::scheduleOrDeferSyncTimer): Create the timer on demand
       
  3983         (WebCore::IconDatabase::iconDatabaseSyncThread): makeAllDirectories() here where it's not as expensive
       
  3984         (WebCore::IconDatabase::cleanupSyncThread): Cleanup the directory as well as full path
       
  3985 
       
  3986         * loader/icon/IconDatabase.h: m_syncTimer becomes an OwnPtr, and we add the database directory
       
  3987           as a member to set it on the main thread and act with it on the background thread
       
  3988 
       
  3989 2007-09-12  Justin Garcia  <justin.garcia@apple.com>
       
  3990 
       
  3991         Reviewed by Tristan.
       
  3992 
       
  3993         <rdar://problem/5469868> 
       
  3994         GoogleDocs: A hang occurs when applying list styling to a selection in a <table>
       
  3995         
       
  3996         When list insertion moves selected paragraphs into list items, it relies on 
       
  3997         the selection preservation code inside moveParagraphs to iterate over the 
       
  3998         selected paragraphs.  If a selection is ever restored incorrectly (before
       
  3999         the original, or inside the original) list insertion will go into an infinite loop.
       
  4000         
       
  4001         In this hang, a table was selected and the selection preservation code incorrectly
       
  4002         restored a selection, placing it inside the table.
       
  4003         
       
  4004         The bug was that a TextIterator, when being used for selection preservation, must
       
  4005         emit a character between every VisiblePosition in the Range used to create the
       
  4006         iterator.
       
  4007         
       
  4008         * editing/TextIterator.cpp:
       
  4009         (WebCore::TextIterator::TextIterator): Renamed the boolean that we use for 
       
  4010         selection preservation.  It used to be m_emitForReplacedElements because
       
  4011         we believed that replaced elements were the only case where TextIterators
       
  4012         should have emitted differently when used for selection preservation.
       
  4013         (WebCore::TextIterator::handleReplacedElement): Ditto.
       
  4014         (WebCore::TextIterator::shouldRepresentNodeOffsetZero): Represent the 
       
  4015         position before block tables, but only if we are emitting for selection 
       
  4016         preservation.
       
  4017         (WebCore::TextIterator::shouldEmitSpaceBeforeAndAfterNode): We should emit 
       
  4018         a space before and after block tables if we are emitting for selection 
       
  4019         preservation (because we have VisiblePositions before and after them).
       
  4020         (WebCore::TextIterator::handleNonTextNode): Use a renamed variable.
       
  4021         * editing/TextIterator.h: Made shouldEmitSpaceBeforeAndAfterNode a member
       
  4022         function, because whether or not we emit spaces before and after a block
       
  4023         table depends we're emitting for selection preservation.
       
  4024 
       
  4025 2007-09-12  Beth Dakin  <bdakin@apple.com>
       
  4026 
       
  4027         Reviewed by Hyatt.
       
  4028 
       
  4029         Fix for <rdar://problem/5464998> REGRESSION (9A543): Using Sort 
       
  4030         options takes you back to search screen on zappos.com
       
  4031 
       
  4032         The current mechanism for preserving form elements across removes 
       
  4033         did not work in the case where the input was moved by the parser to 
       
  4034         be out of scope of the form. This fixes that problem by having the 
       
  4035         parser keep track of the preserve boolean rather than the current 
       
  4036         form element.
       
  4037 
       
  4038         * dom/Tokenizer.h:
       
  4039         (WebCore::Tokenizer::isHTMLTokenizer): New function.
       
  4040         * html/HTMLFormElement.cpp:
       
  4041         (WebCore::HTMLFormElement::HTMLFormElement): Get rid of 
       
  4042         m_preserveAcrossRemove.
       
  4043         * html/HTMLFormElement.h:
       
  4044         (WebCore::HTMLFormElement::isMalformed): Get rid of 
       
  4045         m_preserveAcrossRemove.
       
  4046         * html/HTMLGenericFormElement.cpp:
       
  4047         (WebCore::HTMLGenericFormElement::removedFromTree): Ask the parser 
       
  4048         if it is currently handling residual style rather than asking the 
       
  4049         form if it wants to preserveAcrossRemove.
       
  4050         * html/HTMLParser.cpp:
       
  4051         (WebCore::HTMLParser::HTMLParser): New boolean to initialize.
       
  4052         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Set 
       
  4053         m_handlingResidualStyleAcrossBlocks to true at the beginning and 
       
  4054         false at the end.
       
  4055         * html/HTMLParser.h:
       
  4056         (WebCore::HTMLParser::isHandlingResidualStyleAcrossBlocks):
       
  4057         * html/HTMLTokenizer.h:
       
  4058         (WebCore::HTMLTokenizer::isHTMLTokenizer):
       
  4059         (WebCore::HTMLTokenizer::htmlParser):
       
  4060 
       
  4061 2007-09-12  George Staikos  <staikos@kde.org>
       
  4062 
       
  4063         Fix compilation in some configurations for patch I reviewed and missed
       
  4064         this option on.
       
  4065 
       
  4066         * platform/qt/CursorQt.cpp:
       
  4067         (WebCore::Cursor::Cursor):
       
  4068 
       
  4069 2007-09-12  Brady Eidson  <beidson@apple.com>
       
  4070 
       
  4071         Reviewed by Tim Hatcher and Kevin Decker
       
  4072 
       
  4073         <rdar://problem/5367045> - Launch time regression due to accessing resource from a different bundle
       
  4074 
       
  4075         When the default icon was moved from WebKit to WebCore, we had to access an entirely new bundle on launch which
       
  4076         measurably increased time during launch accessing the disk.
       
  4077 
       
  4078         Instead of moving it back to the WebKit bundle, lets make launch time even faster by compiling in the icon.
       
  4079 
       
  4080         * Resources/urlIcon.tiff: Removed.
       
  4081 
       
  4082         * WebCore.xcodeproj/project.pbxproj: Removed urlIcon.tiff
       
  4083 
       
  4084         * loader/icon/IconDatabase.cpp:
       
  4085         (WebCore::IconDatabase::defaultIcon): Compile in the icon data here.
       
  4086 
       
  4087 2007-09-12  Adam Roben  <aroben@apple.com>
       
  4088 
       
  4089         Always specify that slider thumbs are small when painting with SafariTheme
       
  4090 
       
  4091         This is the only size we support.
       
  4092 
       
  4093         Reviewed by Sam.
       
  4094 
       
  4095         * rendering/RenderThemeSafari.cpp:
       
  4096         (WebCore::RenderThemeSafari::paintSliderThumb):
       
  4097 
       
  4098 2007-09-12  Brady Eidson  <beidson@apple.com>
       
  4099 
       
  4100         Reviewed by Darin
       
  4101 
       
  4102         <rdar://problem/5474753> - ASSERT in IconDatabase ReadySQLStatement
       
  4103 
       
  4104         * loader/icon/IconDatabase.cpp:
       
  4105         (WebCore::readySQLStatement): This is a LOG_ERROR situation, not really an ASSERT situation
       
  4106 
       
  4107 2007-09-12  Adam Roben  <aroben@apple.com>
       
  4108 
       
  4109         Don't ask SafariTheme to draw focus rings around text controls
       
  4110 
       
  4111         We do this ourselves.
       
  4112 
       
  4113         Reviewed by Oliver.
       
  4114 
       
  4115         * rendering/RenderThemeSafari.cpp:
       
  4116 
       
  4117 2007-09-11  Brady Eidson  <beidson@apple.com>
       
  4118 
       
  4119         Reviewed by Darin
       
  4120 
       
  4121         <rdar://problem/5475639> and http://bugs.webkit.org/show_bug.cgi?id=15185 -
       
  4122         Prevent two WebKits from fighting over the database schema in the future in case it ever changes again
       
  4123 
       
  4124         By telling the "older schema" WebKit to simply close itself and not bother to do any icon related stuff
       
  4125         if the database schema is newer, we prevent the possibility of an older webkit run side-by-side with a newer
       
  4126         WebKit causing icon database issues.
       
  4127 
       
  4128         * loader/icon/IconDatabase.cpp:
       
  4129         (WebCore::IconDatabase::defaultDatabaseFilename): Rev the icon database filename to be "WebpageIcons.db"  The name is
       
  4130           more appropriate for what is actually stored in the file, and since we're already not converting v5 to v6 icons, 
       
  4131           making this leap now makes sense and gives us a good "future-proof" baseline
       
  4132         (WebCore::isValidDatabase): Change the validity check to be "less then" instead of "not equal to" - the
       
  4133           "greater than" case is now handled in performOpenInitialization()
       
  4134         (WebCore::IconDatabase::performOpenInitialization): If the schema version is greater than the current, then
       
  4135           close the database as to not conflict with the newer version.  Also noted that the integrity check failure 
       
  4136           should actually close the sql database, not the icondatabase
       
  4137         (WebCore::IconDatabase::syncThreadMainLoop): If termination has already been requested, skip straight to cleanup
       
  4138         (WebCore::IconDatabase::cleanupSyncThread): More correctly set the "sync thread running" flag to false here,
       
  4139           as the thread can now decide to exit on its own
       
  4140 
       
  4141 2007-09-12  Mike Fenton <mike@staikos.net>
       
  4142 
       
  4143         Reviewed by George Staikos.
       
  4144 
       
  4145         Patch from Mike Fenton to allow custom cursors.
       
  4146 
       
  4147         * platform/qt/CursorQt.cpp:
       
  4148 
       
  4149 2007-09-11  Kevin Decker <kdecker@apple.com>
       
  4150 
       
  4151         Reviewed by Oliver Hunt.
       
  4152 
       
  4153         Fixed: <rdar://problem/5472402> crash due to infinite recursion in expandUseElementsInShadowTree on SVG from wikipedia
       
  4154 
       
  4155         * ksvg2/svg/SVGUseElement.cpp: Added SVG_EXPERIMENTAL #ifdef for expandUseElementsInShadowTree().
       
  4156         (WebCore::SVGUseElement::buildPendingResource): Ditto.
       
  4157         (WebCore::SVGUseElement::associateInstancesWithShadowTreeElements): Tweaked an ASSERT to not fire on non-experimental builds.
       
  4158         * ksvg2/svg/SVGUseElement.h: Added SVG_EXPERIMENTAL #ifdef for expandUseElementsInShadowTree().
       
  4159 
       
  4160 2007-09-11  Brady Eidson  <beidson@apple.com>
       
  4161 
       
  4162         Reviewed by Maciej
       
  4163 
       
  4164         Fix for <rdar://problem/5473046> - Crash when resetting all icons
       
  4165 
       
  4166         Originally I'd written the "reset all icons" to be synchronous on the main thread, but it
       
  4167         was decided that it should be async since it involved I/O.  Turns out it needs to be... both!
       
  4168         Synchronous removal of all in-memory records of icons, and then continue and clean up the 
       
  4169         on-disk database on the background thread.
       
  4170 
       
  4171         Also, it turns out that resetting all the page url retain counts should *not* be part of 
       
  4172         "reset all icons" because it breaks various contracts the API makes about maintaining retain counts.
       
  4173 
       
  4174         The problem that occured here was removing all the icons, then all the history items that were 
       
  4175         removed as part of "Reset Safari..." would try to release their icon, but their icon doesn't exist
       
  4176         anymore.
       
  4177 
       
  4178         We get around this by simply leaving the in-memory page url records and retain counts alone - they
       
  4179         are still wiped from disk.
       
  4180 
       
  4181         * loader/icon/IconDatabase.cpp:
       
  4182         (WebCore::IconDatabase::removeAllIcons): Clear in-memory records of all icons then tell the thread to
       
  4183           wipe the on-disk tables
       
  4184         (WebCore::IconDatabase::removeAllIconsOnThread): Only do the disk cleanup - in-memory maintenance is
       
  4185           handled on the main thread
       
  4186         (WebCore::IconDatabase::cleanupSyncThread): Now that it's possible for new "icons to be written to disk"
       
  4187           to appear while on-disk deleting is occuring, let the cleanup procedure perform 1 final write *after*
       
  4188           it does the remove all icons
       
  4189         * loader/icon/IconDatabase.h: Removed unused lock and condition
       
  4190 
       
  4191         * loader/icon/PageURLRecord.cpp:
       
  4192         (WebCore::PageURLRecord::setIconRecord): Allow setting a NULL icon record, so a PageURLRecord can be
       
  4193           cleared as part of removeAllIcons()
       
  4194 
       
  4195 2007-09-11  Tristan O'Tierney  <tristan@apple.com>
       
  4196 
       
  4197         Reviewed by David Harrison.
       
  4198         
       
  4199         <rdar://problem/5467203> CrashTracer: [USER] 1 crash in Mail at <unknown binary>: WebCore::Range::startContainer const
       
  4200 
       
  4201         * editing/SelectionController.cpp:
       
  4202         (WebCore::SelectionController::addRange):
       
  4203         (WebCore::SelectionController::setSelectedRange):
       
  4204         Added a check to make sure the passed in Range* value is not null
       
  4205         before performing operations on it.
       
  4206 
       
  4207 2007-09-11  Justin Garcia  <justin.garcia@apple.com>
       
  4208 
       
  4209         Reviewed by Maciej.
       
  4210         
       
  4211         <rdar://problem/5458246> 
       
  4212         GoogleDocs: A hang occurs when applying list styling to selection that contains a <HR>
       
  4213         
       
  4214         List insertion moves selected paragraphs into list items, and relies on the selection
       
  4215         preservation code inside moveParagraphs to iterate over the selected paragraphs.
       
  4216         When list insertion would try to listify a paragraph that came after a list item 
       
  4217         containing an <hr>, the selection preservation code would set an incorrect ending 
       
  4218         selection because of a TextIterator bug, and we would try to listify the same 
       
  4219         paragraph over and over.
       
  4220         
       
  4221         * editing/CompositeEditCommand.cpp:
       
  4222         (WebCore::CompositeEditCommand::moveParagraphs): Pass range compliant equivalents to
       
  4223         the Range constructor here.  The position [hr, 0] is not a valid DOM Range endpoint 
       
  4224         for example.
       
  4225         * editing/TextIterator.cpp:
       
  4226         (WebCore::shouldEmitSpaceForNode): Added.
       
  4227         (WebCore::TextIterator::handleNonTextNode): Emit a space to represent a horizontal rule,
       
  4228         since it has VisiblePositions before and after it, but only for TextIterators used for
       
  4229         selection preservation, so innerText will be unaffected.
       
  4230 
       
  4231 2007-09-11  Ada Chan  <adachan@apple.com>
       
  4232 
       
  4233         <rdar://problem/5472130> Support NTLM authentication via CFNetwork.
       
  4234 
       
  4235         Reviewed by Darin.
       
  4236 
       
  4237         * platform/network/ProtectionSpace.h:
       
  4238         (WebCore::):
       
  4239         * platform/network/cf/AuthenticationCF.cpp:
       
  4240         (WebCore::createCF):
       
  4241         (WebCore::core):
       
  4242 
       
  4243 2007-09-11  Darin Adler  <darin@apple.com>
       
  4244 
       
  4245         Rubber-stamped by Dave Harrison.
       
  4246 
       
  4247         - fixed pasteboard types here to match WebKit and use constants instead of
       
  4248           WebKitSystemInterface
       
  4249 
       
  4250         * platform/mac/PasteboardMac.mm: Use constants for all pasteboard type strings.
       
  4251 
       
  4252         * platform/mac/WebCoreSystemInterface.h: Removed wkCreateURLPasteboardFlavorTypeName
       
  4253         and wkCreateURLNPasteboardFlavorTypeName.
       
  4254 
       
  4255 2007-09-11  Sven Herzberg  <sven@imendio.com>
       
  4256 
       
  4257         Reviewed by Mark.
       
  4258 
       
  4259         Remove unnecessary fields in FontPlatformData
       
  4260         http://bugs.webkit.org/show_bug.cgi?id=15177
       
  4261 
       
  4262         * platform/gdk/FontDataGdk.cpp: removed the destroy code of the fields
       
  4263         that have been removed
       
  4264         * platform/gdk/FontPlatformData.h: removed m_fontFace, m_fontMatrix
       
  4265         and m_options; hask on m_scaledFont
       
  4266         * platform/gdk/FontPlatformDataGdk.cpp: simplified setFont() by using
       
  4267         m_scaledFont only; turned the former struct members into local
       
  4268         variables
       
  4269 
       
  4270 2007-09-11  George Staikos  <staikos@kde.org>
       
  4271 
       
  4272         Reviewed by Anders.
       
  4273 
       
  4274         Work around gcc bug with some old gcc versions.
       
  4275 
       
  4276         * platform/qt/WidgetQt.cpp:
       
  4277         (WebCore::Widget::convertToContainingWindow):
       
  4278         (WebCore::Widget::convertFromContainingWindow):
       
  4279 
       
  4280 2007-09-10  Mitz Pettel  <mitz@webkit.org>
       
  4281 
       
  4282         Reviewed by Maciej Stachowiak.
       
  4283 
       
  4284         - fix http://bugs.webkit.org/show_bug.cgi?id=15157
       
  4285           Image defined in background-position: top center gets unexpectedly truncated
       
  4286           <rdar://problem/5469095>
       
  4287 
       
  4288         Test: fast/repaint/body-background-image.html
       
  4289 
       
  4290         * rendering/RenderBox.cpp:
       
  4291         (WebCore::RenderBox::imageChanged): Refined the logic for when the root takes
       
  4292         over painting the background, to match paintBoxDecorations(). In particular,
       
  4293         if the root has defined a background, the body should paint its own background.
       
  4294 
       
  4295 2007-09-10  David Harrison  <harrison@apple.com>
       
  4296 
       
  4297         Reviewed by Kevin and Tristan.
       
  4298 
       
  4299         Tests added:
       
  4300         * editing/pasteboard/paste-into-anchor-text.html: Added.
       
  4301         * editing/pasteboard/paste-table-cells.html: Added.
       
  4302 
       
  4303         Source changes:
       
  4304         * editing/CompositeEditCommand.cpp:
       
  4305         (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
       
  4306         Nil check enclosingAnchor.
       
  4307         
       
  4308         * editing/ReplaceSelectionCommand.cpp:
       
  4309         (WebCore::ReplaceSelectionCommand::removeNodeAndPruneAncestors):
       
  4310         New. Keeps m_firstNodeInserted and m_lastLeafInserted updated.
       
  4311         
       
  4312         (WebCore::ReplaceSelectionCommand::negateStyleRulesThatAffectAppearance):
       
  4313         Added a comment.
       
  4314         
       
  4315         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
       
  4316         Let ReplaceSelectionCommand::removeNodeAndPruneAncestors() update the nodes.
       
  4317          
       
  4318         (WebCore::ReplaceSelectionCommand::doApply):
       
  4319         Pass originalVisPosBeforeEndBR to shouldRemoveEndBR()
       
  4320         
       
  4321         (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR):
       
  4322         Don't remove the br if nothing was inserted.
       
  4323         
       
  4324         * editing/ReplaceSelectionCommand.h:
       
  4325         Add VisiblePosition parameter to shouldRemoveEndBR()
       
  4326         
       
  4327         * editing/markup.cpp:
       
  4328         (WebCore::createMarkup):
       
  4329         Wrap orphan tr element with a table element, just like we were doing
       
  4330         for tobody elements.
       
  4331 
       
  4332 2007-09-10  David Kilzer  <ddkilzer@apple.com>
       
  4333 
       
  4334         Rubberstamped by Kevin Decker.
       
  4335 
       
  4336         No test required since there is no change in functionality.
       
  4337 
       
  4338         * history/BackForwardList.cpp:
       
  4339         (WebCore::BackForwardList::BackForwardList): Fix misspelling of DefaultCapacitiy to DefaultCapacity.
       
  4340 
       
  4341 2007-09-10  Mitz Pettel  <mitz@webkit.org>
       
  4342 
       
  4343         Reviewed by Adele Peterson.
       
  4344 
       
  4345         - fix http://bugs.webkit.org/show_bug.cgi?id=15156
       
  4346           REGRESSION (r24594-r24668): The bottom of styled <select> button text is clipped out
       
  4347           <rdar://problem/5464301>
       
  4348 
       
  4349         Test: fast/forms/menulist-clip.html
       
  4350 
       
  4351         * rendering/RenderMenuList.cpp:
       
  4352         (WebCore::RenderMenuList::controlClipRect): Use correct coordinates for
       
  4353         the inner block's content rect.
       
  4354 
       
  4355 2007-09-10  Brady Eidson  <beidson@apple.com>
       
  4356 
       
  4357         Reviewed by Darin, Sam, Oliver, Geoff, probably others - what a fun one to review!
       
  4358 
       
  4359         <rdar://problem/5471641> - URLs get the wrong icon
       
  4360 
       
  4361         Turns out sqlite3_reset() doesn't clear bindings, so previously bound icons were being
       
  4362         written out for pages without icons.  Easy fix!
       
  4363 
       
  4364         * loader/icon/IconDatabase.cpp:
       
  4365         (WebCore::IconDatabase::writeIconSnapshotToSQLDatabase): For null icons, manually
       
  4366           bind NULL - otherwise, the previously bound icon will be written out to disk
       
  4367 
       
  4368         * loader/icon/SQLStatement.cpp:
       
  4369         (WebCore::SQLStatement::bindNull): Access to sqlite3_bind_null
       
  4370         * loader/icon/SQLStatement.h:
       
  4371 
       
  4372 2007-09-10  Anders Carlsson  <andersca@apple.com>
       
  4373 
       
  4374         Reviewed by Oliver and Darin.
       
  4375 
       
  4376         <rdar://problem/5468613>
       
  4377         Using shockwave pages first time after plugin install crashed safari in PluginPing.
       
  4378         
       
  4379         Only restore the window proc if the plugin didn't override it.
       
  4380         
       
  4381         * plugins/win/PluginViewWin.cpp:
       
  4382         (WebCore::PluginViewWin::stop):
       
  4383 
       
  4384 2007-09-10  Justin Garcia  <justin.garcia@apple.com>
       
  4385 
       
  4386         Reviewed by Darin.
       
  4387 
       
  4388         <rdar://problem/5467405> 
       
  4389         Revert back behavior of -webkit-user-select to fix widget selection problems
       
  4390         
       
  4391         Rolled out r25086 and r25057.  I will be re-opening:
       
  4392         <rdar://problem/5333725> -webkit-user-select: none makes selection difficult
       
  4393         Which we will either to defer or fix by introducing a new value of -webkit-user-select.
       
  4394         <rdar://problem/5370059> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)
       
  4395         Which we will either defer or fix with Adele's patch that doesn't involve making 
       
  4396         -webkit-user-select inherited.
       
  4397 
       
  4398         * css/CSSComputedStyleDeclaration.cpp:
       
  4399         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
  4400         * css/CSSStyleSelector.cpp:
       
  4401         (WebCore::CSSStyleSelector::adjustRenderStyle):
       
  4402         (WebCore::CSSStyleSelector::applyProperty):
       
  4403         * editing/SelectionController.cpp:
       
  4404         (WebCore::SelectionController::selectAll):
       
  4405         * page/EventHandler.cpp:
       
  4406         (WebCore::EventHandler::selectClosestWordFromMouseEvent):
       
  4407         (WebCore::EventHandler::handleMousePressEventTripleClick):
       
  4408         (WebCore::EventHandler::handleMousePressEventSingleClick):
       
  4409         (WebCore::EventHandler::updateSelectionForMouseDrag):
       
  4410         (WebCore::EventHandler::selectCursor):
       
  4411         (WebCore::EventHandler::canMouseDownStartSelect):
       
  4412         * page/EventHandler.h:
       
  4413         * rendering/RenderObject.cpp:
       
  4414         (WebCore::selectStartNode):
       
  4415         (WebCore::RenderObject::canSelect):
       
  4416         (WebCore::RenderObject::shouldSelect):
       
  4417         (WebCore::RenderObject::draggableNode):
       
  4418         * rendering/RenderObject.h:
       
  4419         * rendering/RenderStyle.cpp:
       
  4420         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
       
  4421         (WebCore::StyleRareNonInheritedData::operator==):
       
  4422         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
       
  4423         (WebCore::StyleRareInheritedData::operator==):
       
  4424         (WebCore::RenderStyle::diff):
       
  4425         * rendering/RenderStyle.h:
       
  4426         (WebCore::):
       
  4427         (WebCore::RenderStyle::userSelect):
       
  4428         (WebCore::RenderStyle::setUserSelect):
       
  4429         (WebCore::RenderStyle::initialUserSelect):
       
  4430 
       
  4431 2007-09-10  Antti Koivisto  <antti@apple.com>
       
  4432 
       
  4433         Reviewed by Kevin.
       
  4434 
       
  4435         Fix <rdar://problem/5444866>
       
  4436         REGRESSION: missing text in Acrobat "Getting Started" screen due to change in load ordering of large resources
       
  4437         
       
  4438         Make external scripts loaded using file: wait until all style sheet loads have completed before executing. 
       
  4439         Fixes a class of problems where there is a dependency between script and stylesheet and results would effectively 
       
  4440         get randomized based on which order the resources arrived. In Tiger file loads were effectively serialized by
       
  4441         lower level components, which is why this regressed. 
       
  4442 
       
  4443         Test: http/tests/local/stylesheet-and-script-load-order.html
       
  4444 
       
  4445         * dom/Document.cpp:
       
  4446         (WebCore::Document::removePendingSheet):
       
  4447         * dom/Tokenizer.h:
       
  4448         (WebCore::Tokenizer::executeScriptsWaitingForStylesheets):
       
  4449         * html/HTMLTokenizer.cpp:
       
  4450         (WebCore::HTMLTokenizer::HTMLTokenizer):
       
  4451         (WebCore::HTMLTokenizer::begin):
       
  4452         (WebCore::HTMLTokenizer::executeScriptsWaitingForStylesheets):
       
  4453         (WebCore::HTMLTokenizer::notifyFinished):
       
  4454         * html/HTMLTokenizer.h:
       
  4455 
       
  4456 2007-09-08  David Smith  <catfish.man@gmail.com>
       
  4457 
       
  4458         Reviewed by Maciej Stachowiak.
       
  4459         
       
  4460         http://bugs.webkit.org/show_bug.cgi?id=15148
       
  4461         Bug 15148: Poor performance on crazy DOM raytracer
       
  4462         
       
  4463         Switch data structures to avoid quadratic behavior.
       
  4464 
       
  4465         * rendering/RenderBlock.cpp:
       
  4466         (WebCore::RenderBlock::layoutPositionedObjects): Update for ListHashSet
       
  4467         (WebCore::RenderBlock::markPositionedObjectsForLayout): Update for ListHashSet
       
  4468         (WebCore::RenderBlock::insertPositionedObject): Use ListHashSet to avoid expensive uniqueing
       
  4469         (WebCore::RenderBlock::removePositionedObject): Update for ListHashSet
       
  4470         (WebCore::RenderBlock::removePositionedObjects): Update for ListHashSet
       
  4471         (WebCore::RenderBlock::lowestPosition): Update for ListHashSet
       
  4472         (WebCore::RenderBlock::rightmostPosition): Update for ListHashSet
       
  4473         (WebCore::RenderBlock::leftmostPosition): Update for ListHashSet
       
  4474         (WebCore::RenderBlock::rightBottom): Update for ListHashSet
       
  4475         * rendering/RenderBlock.h: Change m_positionedObjects from DeprecatedPtrList to ListHashSet
       
  4476 
       
  4477 2007-09-09  Brady Eidson <beidson@apple.com>
       
  4478 
       
  4479         Rubberstamped by Darin
       
  4480 
       
  4481         pthread_main_np() is a Darwin thing, not a Mac thing
       
  4482 
       
  4483         * loader/icon/IconDatabase.cpp:
       
  4484         (WebCore::IconDatabase::IconDatabase):
       
  4485 
       
  4486 2007-09-09  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  4487 
       
  4488         Build fix for Gtk+ by adding WebCore::callOnMainThread to the TemporaryLinkStubs.
       
  4489 
       
  4490         * platform/gdk/TemporaryLinkStubs.cpp:
       
  4491         (WebCore::callOnMainThread):
       
  4492 
       
  4493 2007-09-08  George Staikos  <staikos@kde.org>
       
  4494 
       
  4495         Reviewed by Olliej.
       
  4496 
       
  4497         Separate out and implement FileSystem functions,  and stub out the
       
  4498         icondatabase function for future implementation.
       
  4499 
       
  4500         * WebCore.pro:
       
  4501         * platform/qt/FileSystemQt.cpp: Added.
       
  4502         (WebCore::fileExists):
       
  4503         (WebCore::deleteFile):
       
  4504         * platform/qt/TemporaryLinkStubs.cpp:
       
  4505         * platform/qt/ThreadingQt.cpp: Added.
       
  4506         (WebCore::callOnMainThread):
       
  4507 
       
  4508 2007-09-08  Mark Rowe  <mrowe@apple.com>
       
  4509 
       
  4510         Build fix for when ENABLE(ICONDATABASE) is not set.
       
  4511 
       
  4512         * loader/icon/IconDatabaseNone.cpp:
       
  4513         (WebCore::IconDatabase::~IconDatabase):
       
  4514 
       
  4515 2007-09-08  Mark Rowe  <mrowe@apple.com>
       
  4516 
       
  4517         More fixes for the Qt and Gtk builds.
       
  4518 
       
  4519         * WebCore.pro: Update for file changes.
       
  4520         * loader/icon/IconDatabase.cpp: Include errno.h for EDEADLK.
       
  4521         * loader/icon/PageURLRecord.h:
       
  4522 
       
  4523 2007-09-08  Justin Garcia  <justin.garcia@apple.com>
       
  4524 
       
  4525         Backing my change back in without the changes to VisiblePosition::next 
       
  4526         and previous that weren't necessary to fix the bug and were causing some
       
  4527         layout test failures.  Most of the failures appeared to be fixes but I
       
  4528         want more time to investigate and have to move to on to another task.
       
  4529 
       
  4530         * editing/Selection.cpp:
       
  4531         (WebCore::Selection::validate):
       
  4532         * editing/visible_units.cpp:
       
  4533         (WebCore::endOfWord):
       
  4534 
       
  4535 2007-09-08  Brady Eidson  <beidson@apple.com>
       
  4536 
       
  4537         Reviewed by Mark Rowe
       
  4538 
       
  4539         Fix the _NSAutoreleaseNoPool() errors on launch - We were using NSFileManager on the secondary
       
  4540         thread with no NSAutoreleasePool in place
       
  4541 
       
  4542         * loader/icon/IconDatabase.cpp:
       
  4543         (WebCore::IconDatabase::iconDatabaseSyncThread):
       
  4544 
       
  4545 2007-09-08  Sam Weinig  <sam@webkit.org>
       
  4546 
       
  4547         Add fix to the correct file.
       
  4548 
       
  4549         * loader/icon/SQLDatabase.h:
       
  4550         * loader/icon/SQLStatement.h:
       
  4551 
       
  4552 2007-09-08  Sam Weinig  <sam@webkit.org>
       
  4553 
       
  4554         Fix Windows build.
       
  4555 
       
  4556         * loader/icon/SQLStatement.h: Disable boolean conversion warning.
       
  4557 
       
  4558 2007-09-08  Brady Eidson  <beidson@apple.com>
       
  4559 
       
  4560         Build fix for non-Mac platforms that use Icon Database
       
  4561 
       
  4562         * loader/icon/IconDatabase.cpp:
       
  4563         (WebCore::IconDatabase::IconDatabase): Apparently only Mac has the beauty that is pthread_main_np()
       
  4564 
       
  4565 2007-09-08  Mark Rowe  <mrowe@apple.com>
       
  4566 
       
  4567         Build fix.
       
  4568 
       
  4569         * WebCore.xcodeproj/project.pbxproj: Headers used up in WebKit need to be be "private" rather than "project".
       
  4570 
       
  4571 2007-09-08  Brady Eidson  <beidson@apple.com>
       
  4572 
       
  4573         Reviewed by Darin
       
  4574 
       
  4575         <rdar://problem/5434431> - Asynchronous Icon Database
       
  4576 
       
  4577         The IconDatabase API was originally designed to be fully asynchronous - if an icon wasn't read in from disk
       
  4578         when you asked for it, you would be notified when it was.
       
  4579 
       
  4580         Safari 2 did writes on a background thread, but reads blocked the main thread.
       
  4581 
       
  4582         The current WebCore implementation using SQLite attempted to get rid of the background thread by defering expensive 
       
  4583         writes via timers, but falls short in moderate to extreme usage cases
       
  4584 
       
  4585         Time to make the IconDatabase live up to it's fully asynchronous destiny.
       
  4586 
       
  4587         This should -
       
  4588         - Make the browser instantly usable while converting Safari 2 icons in the background occurs
       
  4589         - Remedy any UI slowness/blocking when on slow network home directories
       
  4590         - Remedy random UI slowness, pauses, and stutters do to random I/O occurring at the exact wrong time or under heavy
       
  4591           disk usage from swapping or other apps on the system
       
  4592         - Allow certain long-running procedures to be interruptible (Safari 2 import, reading icons in from disk when trying to quit, etc)
       
  4593 
       
  4594         This will have a noticeable effect on current Safari 2 and Safari 3 beta browsers, including icons not appearing in bookmarks, history,
       
  4595         or the location field the first time they're asked for, as current released Safari's don't properly listen for these async notifations.  
       
  4596         The second time such a menu or view is brought up, the icon should be there.
       
  4597 
       
  4598         Additionally this includes a SQLite schema change which will be a lot more efficient but will result in the loss of current SQLite icons.
       
  4599         Converting from Safari 2 style icons will still work.
       
  4600 
       
  4601         WebCore, welcome to multi-threadedness
       
  4602 
       
  4603         * WebCore.exp:
       
  4604         * WebCore.xcodeproj/project.pbxproj:
       
  4605         * WebCore.vcproj/WebCore.vcproj:
       
  4606 
       
  4607         * loader/DocumentLoader.cpp:
       
  4608         (WebCore::DocumentLoader::iconLoadDecisionAvailable): Called when an Icon becomes available that was requested by this 
       
  4609           DocumentLoader (to support the webView:didReceiveIcon: delegate call in WebKit)
       
  4610         * loader/DocumentLoader.h:
       
  4611 
       
  4612         * loader/FrameLoader.cpp:
       
  4613         (WebCore::FrameLoader::iconLoadDecisionAvailable): Called from the DocumentLoaders who get notified - if the FrameLoader 
       
  4614           ends up not caring because the WebView has transitioned to a new page, nothing occurs.  Otherwise, the FrameLoader possibly
       
  4615           starts it Icon Loader and possibly sends the webView:didReceiveIcon: delegate call
       
  4616         (WebCore::FrameLoader::startIconLoader): Instead of "Yes, load the icon now" or "No, don't load it" there is a third possibility -
       
  4617           "You might be asked to load your icon later."  Add supporting logic for receiving this state, and being called a second time
       
  4618           when the load decision is finally available.
       
  4619         * loader/FrameLoader.h:
       
  4620 
       
  4621         * loader/FrameLoaderClient.h: Added "registerForIconNotification" which is a way to tell WebViews "The icon you are interested in might
       
  4622           become available via the generic WebIconDatabaseDidAddIconNotification instead of a targeted delegate call"
       
  4623           A WebView can then receive the generic notification and pass on it's own targeted delegate call.
       
  4624 
       
  4625         * loader/icon/IconDataCache.cpp: Removed.
       
  4626         * loader/icon/IconDataCache.h: Removed.
       
  4627 
       
  4628         * loader/icon/IconDatabase.cpp:
       
  4629         (WebCore::urlForLogging): Cut a URL down in length for sane logging and debugging
       
  4630         (WebCore::defaultClient): Return the default, empty IconDatabaseClient incase the API doesn't set one.
       
  4631 
       
  4632         Following block of methods are for the Main thread's usage -
       
  4633         (WebCore::IconDatabase::setClient):
       
  4634         (WebCore::makeAllDirectories): Small optimization that checks to see if the entire path exists already, and doesn't try to loop
       
  4635           through each patch component if the full path is already present
       
  4636         (WebCore::IconDatabase::open): Makes all directories to the target path and kicks off the background thread - nothing more.
       
  4637         (WebCore::IconDatabase::close): Signals the thread to quit and waits for it to do so
       
  4638         (WebCore::IconDatabase::removeAllIcons): Purge the icon database
       
  4639         (WebCore::IconDatabase::iconForPageURL):
       
  4640         (WebCore::IconDatabase::readIconForPageURLFromDisk):
       
  4641         (WebCore::IconDatabase::iconURLForPageURL):
       
  4642         (WebCore::IconDatabase::defaultIcon):
       
  4643         (WebCore::IconDatabase::retainIconForPageURL):
       
  4644         (WebCore::IconDatabase::releaseIconForPageURL):
       
  4645         (WebCore::IconDatabase::setIconDataForIconURL):
       
  4646         (WebCore::IconDatabase::setIconURLForPageURL):
       
  4647         (WebCore::IconDatabase::loadDecisionForIconURL): Determine if an icon loader should load now.  If the decision is "maybe later", then
       
  4648           mark the DocumentLoader to be notified later when the final decision is available.
       
  4649         (WebCore::IconDatabase::iconDataKnownForIconURL): Determine if the actual image data has been read from disk (or set from the loader) for 
       
  4650           icon URL in question
       
  4651         (WebCore::IconDatabase::setEnabled):
       
  4652         (WebCore::IconDatabase::isEnabled):
       
  4653         (WebCore::IconDatabase::setPrivateBrowsingEnabled):
       
  4654         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
       
  4655         (WebCore::IconDatabase::delayDatabaseCleanup): Restore this method from a year ago, as asynchronous pruning of icons can now occur on a 
       
  4656           background thread.
       
  4657         (WebCore::IconDatabase::allowDatabaseCleanup):
       
  4658         (WebCore::IconDatabase::checkIntegrityBeforeOpening):
       
  4659         (WebCore::IconDatabase::pageURLMappingCount):
       
  4660         (WebCore::IconDatabase::retainedPageURLCount):
       
  4661         (WebCore::IconDatabase::iconRecordCount):
       
  4662         (WebCore::IconDatabase::iconRecordCountWithData):
       
  4663         (WebCore::IconDatabase::IconDatabase):
       
  4664         (WebCore::IconDatabase::~IconDatabase):
       
  4665         (WebCore::IconDatabase::notifyPendingLoadDecisions): Tell all the registered DocumentLoaders "Hey, we've read in all URL mappings from disk,
       
  4666           so check to see if you are interested in any of them"
       
  4667         (WebCore::IconDatabase::notifyPendingLoadDecisionsInternal):
       
  4668         (WebCore::IconDatabase::wakeSyncThread): Wake the sync thread, if it is idle
       
  4669         (WebCore::IconDatabase::scheduleOrDeferSyncTimer): Even though we're on a background thread, we still defer writing out to disk during
       
  4670           periods of high activity
       
  4671         (WebCore::IconDatabase::syncTimerFired): Call wakeSyncThread()
       
  4672 
       
  4673         Following block of methods may be used by either thread -
       
  4674         (WebCore::IconDatabase::isOpen):
       
  4675         (WebCore::IconDatabase::databasePath):
       
  4676         (WebCore::IconDatabase::defaultDatabaseFilename):
       
  4677         (WebCore::IconDatabase::getOrCreateIconRecord):
       
  4678         (WebCore::IconDatabase::getOrCreatePageURLRecord):
       
  4679 
       
  4680         Following block of methods are used by the secondary thread only -
       
  4681         (WebCore::IconDatabase::importIconURLForPageURL): For the Safari 2 import procedure - write a URL mapping directly out to disk
       
  4682         (WebCore::IconDatabase::importIconDataForIconURL): For the Safari 2 import procedure - write an Icon directly out to disk
       
  4683         (WebCore::IconDatabase::shouldStopThreadActivity): To check and see if the thread should stop what it is doing now to do something
       
  4684           more important (such as quit, or delete all icons)
       
  4685         (WebCore::IconDatabase::iconDatabaseSyncThreadStart):
       
  4686         (WebCore::IconDatabase::iconDatabaseSyncThread): Entry point for the background thread
       
  4687         (WebCore::databaseVersionNumber):
       
  4688         (WebCore::isValidDatabase):
       
  4689         (WebCore::createDatabaseTables):
       
  4690         (WebCore::IconDatabase::performOpenInitialization): Open and validate the SQLite database, making sure it's schema jives with what
       
  4691           is expected
       
  4692         (WebCore::IconDatabase::checkIntegrity):
       
  4693         (WebCore::IconDatabase::performURLImport): Import all the Page URL -> Icon URL mappings from the database.  Done "1st thing" on startup,
       
  4694           this is necessary to be able to give the loader decisions about whether or not it should load icons from the network
       
  4695         (WebCore::IconDatabase::syncThreadMainLoop): Main loop - sleeps until woken up, then does a read cycle and a write cycle until both cycles
       
  4696           do no work - then it goes back to sleep.
       
  4697         (WebCore::IconDatabase::readFromDatabase): Reads icons from the database that clients are waiting on
       
  4698         (WebCore::IconDatabase::writeToDatabase): Writes any changes page -> icon url mappings to disk, as well as any new image data that has 
       
  4699           been received from the loader
       
  4700         (WebCore::IconDatabase::pruneUnretainedIcons): Done only once, and only after the first write to the database, this procedure removes all
       
  4701           icons and page URLs from disk that haven't been retained by any client.  Note that the prune can be delayed by utilizing delayDatabaseCleanup()
       
  4702         (WebCore::IconDatabase::checkForDanglingPageURLs): Usually part of the prune procedure, prunes any pages who point to icons that no longer exist 
       
  4703           in the database
       
  4704         (WebCore::IconDatabase::removeAllIconsOnThread): Completely purge both the on-disk and in memory records of all icons
       
  4705         (WebCore::IconDatabase::deleteAllPreparedStatements): Part of removeAllIcons and the thread cleanup procedure
       
  4706         (WebCore::IconDatabase::cleanupSyncThread): Write out any last remaining writes to disk, close the database, and then end the thread
       
  4707         (WebCore::IconDatabase::imported): Checks the DB to see if the Safari 2 import has occured
       
  4708         (WebCore::IconDatabase::setImported): Sets the "Safari 2 imported" flag
       
  4709         (WebCore::readySQLStatement):
       
  4710         (WebCore::IconDatabase::setIconURLForPageURLInSQLDatabase): This and the following "SQLDatabase" suffixed methods are pretty self explanatory
       
  4711         (WebCore::IconDatabase::setIconIDForPageURLInSQLDatabase):
       
  4712         (WebCore::IconDatabase::removePageURLFromSQLDatabase):
       
  4713         (WebCore::IconDatabase::getIconIDForIconURLFromSQLDatabase):
       
  4714         (WebCore::IconDatabase::addIconURLToSQLDatabase):
       
  4715         (WebCore::IconDatabase::getImageDataForIconURLFromSQLDatabase):
       
  4716         (WebCore::IconDatabase::removeIconFromSQLDatabase):
       
  4717         (WebCore::IconDatabase::writeIconSnapshotToSQLDatabase):
       
  4718         * loader/icon/IconDatabase.h:
       
  4719 
       
  4720         * loader/icon/IconDatabaseClient.h: Added.
       
  4721         (WebCore::IconDatabaseClient::~IconDatabaseClient):
       
  4722         (WebCore::IconDatabaseClient::performImport): Perform the Safari 2 import, implemented by WebKit
       
  4723         (WebCore::IconDatabaseClient::dispatchDidRemoveAllIcons): Send the API notification
       
  4724         (WebCore::IconDatabaseClient::dispatchDidAddIconForPageURL): Ditto
       
  4725 
       
  4726         * loader/icon/IconDatabaseNone.cpp: Best attempt to keep non icon-DB platforms building
       
  4727         (WebCore::IconDatabase::defaultDatabaseFilename):
       
  4728         (WebCore::IconDatabase::readIconForPageURLFromDisk):
       
  4729         (WebCore::IconDatabase::loadDecisionForIconURL):
       
  4730         (WebCore::IconDatabase::iconDataKnownForIconURL):
       
  4731         (WebCore::IconDatabase::setIconURLForPageURL):
       
  4732         (WebCore::IconDatabase::isEnabled):
       
  4733         (WebCore::IconDatabase::delayDatabaseCleanup):
       
  4734         (WebCore::IconDatabase::allowDatabaseCleanup):
       
  4735         (WebCore::IconDatabase::setClient):
       
  4736 
       
  4737         * loader/icon/IconRecord.cpp: Added.
       
  4738         (WebCore::IconRecord::IconRecord): IconRecord used to be "IconDataCache" - it is merely a container for the url, timestamp, and image for a site icon.
       
  4739           It is Shared, and therefore ref counted - PageURLRecords are the owning containers.  This is a tricky way to track how many page urls are retaining 
       
  4740           an IconRecord and therefore tracking when we should try to get rid of one.
       
  4741         (WebCore::IconRecord::~IconRecord):
       
  4742         (WebCore::IconRecord::image):
       
  4743         (WebCore::IconRecord::setImageData):
       
  4744         (WebCore::IconRecord::loadImageFromResource):
       
  4745         (WebCore::IconRecord::imageDataStatus): Return whether the image data hasn't been read yet, exists in memory, or is absent (site with no icon)
       
  4746         (WebCore::IconRecord::snapshot): Returns a snapshot of the icon's data - url, timestamp, and image data - to be written to disk
       
  4747         * loader/icon/IconRecord.h: Added.
       
  4748         (WebCore::IconSnapshot::IconSnapshot):
       
  4749         (WebCore::IconRecord::getTimestamp):
       
  4750         (WebCore::IconRecord::setTimestamp):
       
  4751         (WebCore::IconRecord::iconURL):
       
  4752         (WebCore::IconRecord::retainingPageURLs):
       
  4753 
       
  4754         * loader/icon/PageURLRecord.cpp: Added.
       
  4755         (WebCore::PageURLRecord::PageURLRecord): PageURLRecord is fundamentally a pairing of a Page URL to an Icon.  It has manual ref counting for the sake
       
  4756           of "retainIconForPageURL" and "releaseIconForPageURL", and can provide a quick snapshot of it's Page URL -> Icon URL mapping for writing to
       
  4757           the database
       
  4758         (WebCore::PageURLRecord::setIconRecord):
       
  4759         (WebCore::PageURLRecord::snapshot):
       
  4760         * loader/icon/PageURLRecord.h: Added.
       
  4761         (WebCore::PageURLSnapshot::PageURLSnapshot):
       
  4762         (WebCore::PageURLRecord::url):
       
  4763         (WebCore::PageURLRecord::PageURLRecord::iconRecord):
       
  4764         (WebCore::PageURLRecord::retain):
       
  4765         (WebCore::PageURLRecord::release):
       
  4766         (WebCore::PageURLRecord::retainCount):
       
  4767 
       
  4768         * platform/SharedBuffer.cpp:
       
  4769         (WebCore::SharedBuffer::copy): Added a deep copy method for the purposes of handing icon data across the thread boundary into the icon database
       
  4770         * platform/SharedBuffer.h:
       
  4771 
       
  4772         * platform/graphics/svg/SVGImageEmptyClients.h:
       
  4773         (WebCore::SVGEmptyFrameLoaderClient::registerForIconNotification):
       
  4774 
       
  4775         * platform/win/TemporaryLinkStubs.cpp:
       
  4776         (WebCore::callOnMainThread): Only other IconDatabase utilizing platform - keep their build going
       
  4777 
       
  4778 2007-09-07  David Kilzer  <ddkilzer@apple.com>
       
  4779 
       
  4780         Reviewed by Timothy Hatcher.
       
  4781 
       
  4782         Housekeeping.  No test required.
       
  4783 
       
  4784         * bindings/objc/WebScriptObjectInternal.h: Removed unused file.
       
  4785         * bindings/objc/WebScriptObjectPrivate.h: Updated copyright statement.
       
  4786 
       
  4787 2007-09-07  Justin Garcia  <justin.garcia@apple.com>
       
  4788         
       
  4789         Rolling out my changes from r25421 while I investigate the layout test failures
       
  4790         they caused.
       
  4791         
       
  4792         * editing/Selection.cpp:
       
  4793         (WebCore::Selection::validate):
       
  4794         * editing/VisiblePosition.cpp:
       
  4795         (WebCore::VisiblePosition::next):
       
  4796         (WebCore::VisiblePosition::previous):
       
  4797         (WebCore::VisiblePosition::lastEditablePositionAtOrBefore):
       
  4798         (WebCore::VisiblePosition::firstEditablePositionAtOrAfter):
       
  4799         * editing/VisiblePosition.h:
       
  4800         * editing/visible_units.cpp:
       
  4801         (WebCore::endOfWord):
       
  4802         (WebCore::previousWordPosition):
       
  4803         (WebCore::nextWordPosition):
       
  4804         (WebCore::startOfLine):
       
  4805         (WebCore::endOfLine):
       
  4806         (WebCore::previousSentencePosition):
       
  4807         (WebCore::nextSentencePosition):
       
  4808 
       
  4809 2007-09-05  Geoffrey Garen  <ggaren@apple.com>
       
  4810 
       
  4811         Reviewed by Darin Adler, Maciej Stachowiak, Mark Rowe, Tim Hatcher.
       
  4812         
       
  4813         Fixed <rdar://problem/5326009> Make non-browser WebKit clients have no 
       
  4814         memory cache, or a very tiny one
       
  4815 
       
  4816         Added a client callback to notify WebKit when the first navigation has
       
  4817         taken place. "Navigation" here means a transition from one page to 
       
  4818         another that ends up in the back/forward list.
       
  4819         
       
  4820         WebKit Mac uses this notification to grow its cache model under certain
       
  4821         circumstances.
       
  4822         
       
  4823         * loader/FrameLoader.cpp:
       
  4824         (WebCore::FrameLoader::addBackForwardItemClippedAtTarget):
       
  4825         * loader/FrameLoaderClient.h:
       
  4826 
       
  4827         * platform/graphics/svg/SVGImageEmptyClients.h:
       
  4828         (WebCore::SVGEmptyFrameLoaderClient::didPerformFirstNavigation): Ah, 
       
  4829         SVGEmptyFrameLoaderClient, my old friend. 
       
  4830 
       
  4831 2007-09-07  Adele Peterson  <adele@apple.com>
       
  4832 
       
  4833         Reviewed by Dave Harrison.
       
  4834 
       
  4835         Fix for <rdar://problem/5428427> Wrong characters are re-converted after doing reconversion with Kotoeri
       
  4836 
       
  4837         Revert change for<rdar://problem/5279521> and add nil checks for the result of TextIterator::rangeFromLocationAndLength
       
  4838         TextIterator::exitNode shouldn't require the m_lastTextNode to be true, but we can't change that without making the logic in _web_attributedStringFromRange match.
       
  4839         We'll get that for free when we switch to use TextIterator in _web_attributedStringFromRange.
       
  4840 
       
  4841         * editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Added nil checks.
       
  4842         * editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): ditto.
       
  4843         * editing/TextIterator.cpp: (WebCore::TextIterator::exitNode): Re-added check for m_lastTextNode before emitting newline.
       
  4844 
       
  4845 2007-09-07  Ada Chan  <adachan@apple.com>
       
  4846 
       
  4847         <rdar://problem/5395928> Need to be able to handle context menu item selection by index
       
  4848         
       
  4849         Reviewed by Beth.
       
  4850 
       
  4851         * platform/ContextMenu.h: Added method to retrieve context menu item by index
       
  4852         * platform/win/ContextMenuWin.cpp:
       
  4853         (WebCore::ContextMenu::ContextMenu): call setPlatformDescription() since that will handle
       
  4854         adding the MNS_NOTIFYBYPOS style to the context menu.
       
  4855         (WebCore::contextMenuItemByIdOrPosition): helper method so we don't have to duplicate code
       
  4856         between itemWithAction() and itemAtIndex().
       
  4857         (WebCore::ContextMenu::itemWithAction):
       
  4858         (WebCore::ContextMenu::itemAtIndex):
       
  4859         (WebCore::ContextMenu::setPlatformDescription): add MNS_NOTIFYBYPOS style to the context menu
       
  4860         so we will get notified by menu position through WM_MENUCOMMAND when the item is selected.
       
  4861 
       
  4862 2007-09-07  Justin Garcia  <justin.garcia@apple.com>
       
  4863 
       
  4864         Reviewed by Darin.
       
  4865         
       
  4866         <rdar://problem/5057506> Double-clicking after ToDo content doesn't select the paragraph break
       
  4867         
       
  4868         * editing/Selection.cpp:
       
  4869         (WebCore::Selection::validate):
       
  4870         Moved the code that moves across a paragraph boundary
       
  4871         when expanding selections by word granularity from
       
  4872         endOfWord to here.
       
  4873         In the word and paragraph granularity cases, if the 
       
  4874         end of the selection is at the end of the last paragraph 
       
  4875         in the last cell of a block table, expand it so that 
       
  4876         it ends at the start of the paragraph after the table, 
       
  4877         instead of just after the table, so that ToDo content 
       
  4878         gets the same double/tripled click behavior that normal 
       
  4879         paragraphs get (added two testcases).
       
  4880         When expanding the selection to include paragraph
       
  4881         breaks, pass VisiblePosition::next true so that it
       
  4882         doesn't change editability.
       
  4883         * editing/VisiblePosition.cpp:
       
  4884         (WebCore::VisiblePosition::next): Renamed the bool because it's now also
       
  4885         used to keep non-editable positions non-editable.
       
  4886         (WebCore::VisiblePosition::previous): Ditto.
       
  4887         (WebCore::VisiblePosition::lastPositionWithSameEditabilityAtOrBefore):
       
  4888         Renamed this function and made it also work with non-editable positions.
       
  4889         (WebCore::VisiblePosition::firstPositionWithSameEditabilityAtOrAfter):
       
  4890         Ditto.
       
  4891         * editing/VisiblePosition.h:
       
  4892         * editing/visible_units.cpp:
       
  4893         (WebCore::endOfWord): Called the renamed function.
       
  4894         (WebCore::previousWordPosition): Ditto.
       
  4895         (WebCore::nextWordPosition): Ditto.
       
  4896         (WebCore::startOfLine): Ditto.
       
  4897         (WebCore::endOfLine): Ditto.
       
  4898         (WebCore::previousSentencePosition): Ditto.
       
  4899         (WebCore::nextSentencePosition): Ditto.
       
  4900 
       
  4901 2007-09-07  Brady Eidson  <beidson@apple.com>
       
  4902 
       
  4903         Reviewed by Sam
       
  4904 
       
  4905         <rdar://problem/5089241> - ASSERT and other funky effects in IconLoader with large 404 pages
       
  4906 
       
  4907         There were two problems:
       
  4908         1 - I originally didn't expect SubresourceLoader to keep pulling in data after it received a 404 response,
       
  4909             but if the server sends back a complex 404 page, the loader did just that.  That could result in the 
       
  4910             IconLoader "finishing" twice
       
  4911         2 - In this case, the long messy 404 page would be committed to the database as image data.  This would 
       
  4912             result in wasted space on disk, wasted space in RAM, and wasting processor time trying to parse 50k+
       
  4913             of HTML as image data
       
  4914 
       
  4915         Fix is two parts - 1, monitor the "m_loadIsInProgress" flag and 2, make ::finishLoading() take an actual 
       
  4916         SharedBuffer argument that is what should be committed to the database so the ResourceHandle is unnecessary
       
  4917 
       
  4918         * loader/icon/IconLoader.cpp:
       
  4919         (WebCore::IconLoader::didReceiveResponse): If the response is not valid, commit null data 
       
  4920         (WebCore::IconLoader::didFail): If we've already finished loading once (the 404 response), don't
       
  4921           finish again!
       
  4922         (WebCore::IconLoader::didFinishLoading): Ditto
       
  4923         (WebCore::IconLoader::finishLoading): Take a SharedBuffer argumnt as the actual data to commit
       
  4924         * loader/icon/IconLoader.h: Add a SharedBuffer arg to ::finishLoading()
       
  4925 
       
  4926 2007-09-07  Brady Eidson  <beidson@apple.com>
       
  4927 
       
  4928         Reviewed by Darin
       
  4929 
       
  4930         Inline the in-header definitions for non-Mac platforms
       
  4931 
       
  4932         * platform/AutodrainedPool.h:
       
  4933         (WebCore::AutodrainedPool::AutodrainedPool):
       
  4934         (WebCore::AutodrainedPool::~AutodrainedPool):
       
  4935         (WebCore::AutodrainedPool::cycle):
       
  4936 
       
  4937 2007-09-07  Brady Eidson  <beidson@apple.com>
       
  4938 
       
  4939         Reviewed by Darin
       
  4940 
       
  4941         Add some AutoreleasePool and Threading utilities in preparation for the multi-threaded
       
  4942         fix for <rdar://problem/5434431>
       
  4943 
       
  4944         AutodrainedPool wraps an NSAutoreleasePool and tracks a "cycle" count.  This allows clients
       
  4945         in WebCore to simply call ::cycle() and after a preset number of iterations the pool will drain
       
  4946         and recreate the underlying NSAutoreleasePool
       
  4947    
       
  4948         Threading utilities include C++ wrappers for pthread mutexes and conditions, as well as a generic
       
  4949         "callOnMainThread()" function for any non-main thread to use.
       
  4950 
       
  4951         * platform/AutodrainedPool.h: Added.  
       
  4952         (WebCore::AutodrainedPool::AutodrainedPool): Empty implementations for all non-mac platforms
       
  4953         (WebCore::AutodrainedPool::~AutodrainedPool): ditto
       
  4954         (WebCore::AutodrainedPool::cycle): ditto
       
  4955         * platform/mac/AutodrainedPool.mm: Added.
       
  4956         (WebCore::AutodrainedPool::AutodrainedPool): 
       
  4957         (WebCore::AutodrainedPool::~AutodrainedPool):
       
  4958         (WebCore::AutodrainedPool::cycle): Keep track of number of cycles, and drain/recreate the pool if the
       
  4959           cycle limit is hit
       
  4960 
       
  4961         * platform/Threading.h: Added.
       
  4962         (WebCore::Mutex::Mutex): C++ wrapper for pthread_mutex
       
  4963         (WebCore::Mutex::~Mutex):
       
  4964         (WebCore::Mutex::lock):
       
  4965         (WebCore::Mutex::tryLock):
       
  4966         (WebCore::Mutex::unlock):
       
  4967         (WebCore::MutexLocker::MutexLocker): Handles automatically locking/unlocking a Mutex (for early returns
       
  4968           from a function, for example)
       
  4969         (WebCore::MutexLocker::~MutexLocker):
       
  4970         (WebCore::ThreadCondition::ThreadCondition): C++ wrapper for pthread_condition
       
  4971         (WebCore::ThreadCondition::~ThreadCondition):
       
  4972         (WebCore::ThreadCondition::wait):
       
  4973         (WebCore::ThreadCondition::signal):
       
  4974         (WebCore::ThreadCondition::broadcast):
       
  4975         * platform/mac/Threading.mm: Added.
       
  4976         (-[WebCoreFunctionWrapper initWithFunction:]): Obj-C implementation of "callOnMainThread"
       
  4977         (-[WebCoreFunctionWrapper _call]):
       
  4978         (WebCore::callOnMainThread):
       
  4979 
       
  4980 2007-09-07  George Staikos  <staikos@kde.org>
       
  4981 
       
  4982         Fix typo.
       
  4983 
       
  4984         * loader/ProgressTracker.h:
       
  4985         (WebCore::ProgressTracker::totalPageAndResourceBytesToLoad):
       
  4986 
       
  4987 2007-09-07  Qing Zhao  <qing@staikos.net>
       
  4988 
       
  4989         Reviewed by Anders and George.
       
  4990 
       
  4991         Add accessors for these two variables.
       
  4992 
       
  4993         * loader/ProgressTracker.h:
       
  4994         (WebCore::ProgressTracker::totalPageAndResourseBytesToLoad):
       
  4995         (WebCore::ProgressTracker::totalBytesReceived):
       
  4996 
       
  4997 2007-09-06  Tristan O'Tierney  <tristan@apple.com>
       
  4998 
       
  4999         Reviewed by Maciej Stachowiak.
       
  5000         
       
  5001         <rdar://problem/5333496> Back button stopped working on sfgate.com (14957)
       
  5002         
       
  5003         This fix is specifically targted to address sfgate.com and reuters.com with minimal
       
  5004         impact to other areas of the frameloader.  It does not cause any regression tests to fail.
       
  5005         I've added two layout tests: One to detect this particular bug, and one to address
       
  5006         a secondary issue: if an iframe navigation occurs during onload by a timeout an
       
  5007         additional history item is added, similarly to firefox.  We tried to match firefox
       
  5008         more than IE with this fix but did gain a little bit of IE compatability.
       
  5009 
       
  5010         Tests: http/tests/navigation/onload-navigation-iframe-timeout.html
       
  5011                http/tests/navigation/onload-navigation-iframe.html
       
  5012 
       
  5013         * dom/Document.h:
       
  5014         (WebCore::Document::processingLoadEvent):
       
  5015         Return the m_processingLoadEvent boolean so FrameLoader knows
       
  5016         that the document is in the middle of calling <body onload>
       
  5017         
       
  5018         * html/HTMLFrameOwnerElement.cpp:
       
  5019         (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
       
  5020         * html/HTMLFrameOwnerElement.h:
       
  5021         (WebCore::HTMLFrameOwnerElement::createdByParser):
       
  5022         (WebCore::HTMLFrameOwnerElement::setCreatedByParser):
       
  5023         Added support for a new member variable of frame elements: m_createdByParser.
       
  5024         This lets us specifically target the fix to only iframes created via JS
       
  5025         and not in-document.
       
  5026         
       
  5027         * loader/FrameLoader.cpp:
       
  5028         (WebCore::FrameLoader::FrameLoader):
       
  5029         Initialize m_navigationDuringLoad to false
       
  5030         
       
  5031         (WebCore::FrameLoader::provisionalLoadStarted):
       
  5032         Determine if the load we're about to start is occuring during
       
  5033         an onload.
       
  5034         
       
  5035         (WebCore::FrameLoader::updateHistoryForStandardLoad):
       
  5036         If the current frameloader is for a child frame, and the navigation is occuring
       
  5037         during an onload update the current history item rather than adding a new one.
       
  5038         
       
  5039         * loader/FrameLoader.h:
       
  5040         Added a new member variable, m_navigationDuringLoad to track
       
  5041         the navigation status during the on load, rather than trying to determine
       
  5042         the status after (which is nearly impossible due to a new runloop spin).
       
  5043 
       
  5044 2007-09-06  David Kilzer  <ddkilzer@apple.com>
       
  5045 
       
  5046         Reviewed by Darin.
       
  5047 
       
  5048         The implementation of BackForwardList::clearPageCache() was removed in r21793.
       
  5049         It's now safe to remove it from the header.
       
  5050 
       
  5051         * history/BackForwardList.h: Removed clearPageCache().
       
  5052 
       
  5053 2007-09-06  Anders Carlsson  <andersca@apple.com>
       
  5054 
       
  5055         Reviewed by Ada.
       
  5056 
       
  5057         <rdar://problem/5457844>
       
  5058         Crash when using mouse wheel with plug-ins disabled.
       
  5059 
       
  5060         Null check the widget.
       
  5061 
       
  5062         * page/EventHandler.cpp:
       
  5063         (WebCore::EventHandler::handleWheelEvent):
       
  5064 
       
  5065 2007-09-06  Anders Carlsson  <andersca@apple.com>
       
  5066 
       
  5067         Reviewed by Mitz.
       
  5068 
       
  5069         Small tweak.
       
  5070         
       
  5071         * plugins/win/PluginStreamWin.cpp:
       
  5072         (WebCore::PluginStreamWin::startStream):
       
  5073 
       
  5074 2007-09-06  Anders Carlsson  <andersca@apple.com>
       
  5075 
       
  5076         Reviewed by Adam and Steve.
       
  5077 
       
  5078         <rdar://problem/5459321>
       
  5079         ADOBE: Safari 3 on Windows is passing bogus values in stream->headers in NPP_NewStream, causing Flash Player to crash.
       
  5080         
       
  5081         Serialize the headers into a stream and pass it to NPP_NewStream in stream->headers.
       
  5082         
       
  5083         * plugins/win/PluginStreamWin.cpp:
       
  5084         (WebCore::PluginStreamWin::startStream):
       
  5085         * plugins/win/PluginStreamWin.h:
       
  5086 
       
  5087 2007-09-06  Darin Adler  <darin@apple.com>
       
  5088 
       
  5089         Reviewed by Hyatt.
       
  5090 
       
  5091         - fix http://bugs.webkit.org/show_bug.cgi?id=15153
       
  5092           REGRESSION: Assertion failure in FrameView::scheduleRelayout() (m_frame->view() == this)
       
  5093 
       
  5094         Back out the willRemove() part of the previous patch.
       
  5095         It was incorrect and not needed to fix the bug anyway.
       
  5096 
       
  5097         * dom/Document.cpp: (WebCore::Document::detach): Remove willRemove().
       
  5098 
       
  5099         * loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Put the willRemove() call
       
  5100         back here where it was originally before the previous fix.
       
  5101 
       
  5102         * history/CachedPage.cpp: (WebCore::CachedPage::clear):
       
  5103         * page/Frame.cpp:
       
  5104         (WebCore::Frame::setView):
       
  5105         (WebCore::Frame::setDocument):
       
  5106         Added FIXMEs about the fact that we call detach() on the document but not willRemove().
       
  5107 
       
  5108 2007-09-05  Timothy Hatcher  <timothy@apple.com>
       
  5109 
       
  5110         Reviewed by Darin.
       
  5111 
       
  5112         Changed the blocked exception log message to match AppKit's blocked exception message.
       
  5113 
       
  5114         * platform/mac/BlockExceptions.mm:
       
  5115         (ReportBlockedObjCException):
       
  5116 
       
  5117 2007-09-06  Darin Adler  <darin@apple.com>
       
  5118 
       
  5119         Reviewed by Hyatt.
       
  5120 
       
  5121         - <rdar://problem/5457865> REGRESSION (9A527): Safari crashes when opening a page
       
  5122           that immediately redirects to a PDF
       
  5123 
       
  5124         I don't know how to make an automated test that trips over this.
       
  5125 
       
  5126         The immediate cause of this regression was making a back/forward list entry in
       
  5127         this case. Earlier, the quick redirect would not results in a separate entry.
       
  5128         That's possibly a bug too, but it's better to fix the crash first.
       
  5129 
       
  5130         The page cache was putting the document into a strange state: Still attached but
       
  5131         with the renderer set to 0. There was no good reason to do this, so got rid of it.
       
  5132         Moved the responsibility to the caller of not calling detach() when moving into
       
  5133         the page cache. This is more of a frame loader thing than a document thing.
       
  5134 
       
  5135         * dom/Document.cpp: (WebCore::Document::detach): Added assertions that this is
       
  5136         only called on a document that's attached and not in the page cache. Also moved
       
  5137         the call to willRemove in here, so that callers can't make the mistake of not
       
  5138         calling that function. Removed the incorrectly-positioned code that made this
       
  5139         function do less if it was called on a document in the page cache.
       
  5140 
       
  5141         * history/CachedPage.cpp: (WebCore::CachedPage::clear): Removed the code to handle
       
  5142         a document with a renderer of 0. There was no need to put the document into this
       
  5143         state. Any document in the page cache will always be "attached".
       
  5144 
       
  5145         * loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Added a check to prevent
       
  5146         from calling an unnecessary cancelParsing() on a document that's in the page cache
       
  5147         and guard the call to detach() with a check of attached(), like all other calls to
       
  5148         detach() on DOM objects.
       
  5149 
       
  5150         * page/Frame.cpp:
       
  5151         (WebCore::Frame::setView): Added a missing check of attached(), like all other
       
  5152         calls to detach() on DOM objects. Also added code to not call detach() on the
       
  5153         document when it's in the page cache.
       
  5154         (WebCore::Frame::setDocument): This call site already had the attached() check,
       
  5155         but was missing the page cache check.
       
  5156 
       
  5157 2007-09-05  David Harrison  <harrison@apple.com>
       
  5158 
       
  5159         Reviewed by Darin.
       
  5160 
       
  5161         Follow up on my fix for <rdar://problem/5306171>.
       
  5162         My first patch (r25373) broke svg/custom/stroke-width-click.svg.
       
  5163 
       
  5164         * editing/TextIterator.cpp:
       
  5165         (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
       
  5166         Add currPos.isNotNull() check because positions in non-html content (like svg)
       
  5167         do not have visible positions, and we don't want to emit for them either.
       
  5168 
       
  5169 2007-09-06  Mitz Pettel  <mitz@webkit.org>
       
  5170 
       
  5171         Reviewed by Adam Roben.
       
  5172 
       
  5173         - fix http://bugs.webkit.org/show_bug.cgi?id=14685
       
  5174           <rdar://problem/5349755> text-align affects <select> button but not its drop-down menu
       
  5175 
       
  5176         * platform/PlatformString.h:
       
  5177         (WebCore::String::defaultWritingDirection):
       
  5178         * platform/StringImpl.cpp:
       
  5179         (WebCore::StringImpl::defaultWritingDirection): Moved textDirectionForParagraph()
       
  5180         from RenderMenuList.cpp here.
       
  5181         * platform/StringImpl.h:
       
  5182         * platform/win/PopupMenuWin.cpp:
       
  5183         (WebCore::PopupMenu::itemWritingDirectionIsNatural): Changed to return 'true'.
       
  5184         (WebCore::PopupMenu::paint): Changed to use natural directionality for menu
       
  5185         items.
       
  5186         * rendering/RenderMenuList.cpp:
       
  5187         (WebCore::RenderMenuList::adjustInnerStyle): Use defaultWritingDirection.
       
  5188 
       
  5189 2007-09-06  Maciej Stachowiak  <mjs@apple.com>
       
  5190 
       
  5191         Reviewed by Oliver Hunt.
       
  5192 
       
  5193         - fixed <rdar://problem/5455457> REGRESSION (9A527-9A535): Colloquy crash on launch in WebCoreScriptDebugger initWithDelegate (with announce.js plug-in installed)
       
  5194 
       
  5195         * page/mac/FrameMac.mm:
       
  5196         (WebCore::Frame::windowScriptObject): Ensure that -[WebView
       
  5197         windowScriptObject] and -[WebFrame windowObject] return null until
       
  5198         the windowScriptObjectAvailable: delegate method is sent.
       
  5199 
       
  5200 2007-09-05  David Harrison  <harrison@apple.com>
       
  5201 
       
  5202         Reviewed by Kevin Decker.
       
  5203 
       
  5204         <rdar://problem/5306171> Mail: The first return after an attachment in multipart/mixed message is lost
       
  5205 
       
  5206         Test added: editing/selection/toString-1.html
       
  5207         
       
  5208         Source changes:
       
  5209         * editing/TextIterator.cpp:
       
  5210         (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
       
  5211         - Remove outdated and erroneous check for m_lastTextNode.
       
  5212         - Fix VisiblePosition check to look for line diff. Simple position diff gives the
       
  5213         wrong answer when the start is table/0 and the current is the first position
       
  5214         inside the content of the table.
       
  5215 
       
  5216 2007-09-04  Marvin Decker  <marv.decker@gmail.com>
       
  5217 
       
  5218         Reviewed by Maciej Stachowiak.
       
  5219 
       
  5220         http://bugs.webkit.org/show_bug.cgi?id=15072
       
  5221         Bug 15072: Fix ImageDecoder.cpp to not copy incoming data
       
  5222 
       
  5223         Change ImageDecoder::setData to take a SharedBuffer*.
       
  5224 
       
  5225         * platform/graphics/cairo/ImageSourceCairo.cpp:
       
  5226         (WebCore::ImageSource::setData):
       
  5227         * platform/image-decoders/ImageDecoder.h:
       
  5228         (WebCore::RGBA32Buffer::bytes):
       
  5229         (WebCore::RGBA32Buffer::height):
       
  5230         (WebCore::ImageDecoder::setData):
       
  5231         * platform/image-decoders/gif/GIFImageDecoder.cpp:
       
  5232         (WebCore::GIFImageDecoder::setData):
       
  5233         (WebCore::GIFImageDecoder::frameCount):
       
  5234         (WebCore::GIFImageDecoder::decode):
       
  5235         (WebCore::GIFImageDecoder::decodingHalted):
       
  5236         (WebCore::GIFImageDecoder::initFrameBuffer):
       
  5237         * platform/image-decoders/gif/GIFImageDecoder.h:
       
  5238         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
       
  5239         (WebCore::JPEGImageDecoder::setData):
       
  5240         (WebCore::JPEGImageDecoder::decode):
       
  5241         * platform/image-decoders/jpeg/JPEGImageDecoder.h:
       
  5242         * platform/image-decoders/png/PNGImageDecoder.cpp:
       
  5243         (WebCore::PNGImageDecoder::setData):
       
  5244         (WebCore::PNGImageDecoder::decode):
       
  5245         (WebCore::PNGImageDecoder::headerAvailable):
       
  5246         (WebCore::PNGImageDecoder::rowAvailable):
       
  5247         * platform/image-decoders/png/PNGImageDecoder.h:
       
  5248 
       
  5249 2007-09-04  David Hyatt  <hyatt@apple.com>
       
  5250 
       
  5251         Fix for <rdar://problem/5271213>, resizing iChat window is slower than in
       
  5252         Tiger. This patch implements a fast scaling mode that can be used by
       
  5253         WebViews, e.g., during window resizing.
       
  5254 
       
  5255         Reviewed by John Sullivan
       
  5256 
       
  5257         * WebCore.exp:
       
  5258         * WebCore.xcodeproj/project.pbxproj:
       
  5259         * page/Frame.cpp:
       
  5260         (WebCore::FramePrivate::FramePrivate):
       
  5261         * page/Page.cpp:
       
  5262         (WebCore::Page::Page):
       
  5263         (WebCore::Page::inLowQualityImageInterpolationMode):
       
  5264         (WebCore::Page::setInLowQualityImageInterpolationMode):
       
  5265         * page/Page.h:
       
  5266         * platform/graphics/GraphicsContext.cpp:
       
  5267         (WebCore::GraphicsContext::drawImage):
       
  5268         * platform/graphics/GraphicsContext.h:
       
  5269         (WebCore::GraphicsContext::setUseLowQualityImageInterpolation):
       
  5270         (WebCore::GraphicsContext::useLowQualityImageInterpolation):
       
  5271         * platform/graphics/cg/GraphicsContextCG.cpp:
       
  5272         (WebCore::GraphicsContext::setUseLowQualityImageInterpolation):
       
  5273         (WebCore::GraphicsContext::useLowQualityImageInterpolation):
       
  5274         * rendering/RenderImage.cpp:
       
  5275         (WebCore::RenderImage::paint):
       
  5276 
       
  5277 2007-09-04  Brady Eidson  <beidson@apple.com>
       
  5278 
       
  5279         Reviewed by Adam
       
  5280 
       
  5281         Some SQLite tweaks for debugging
       
  5282         -In debug builds, track the thread that opened the database and enforce that any statements
       
  5283          that operate on the SQLDatabase do so from the thread that opened it
       
  5284         -Track whether or not a transaction is in progress for the SQLDatabase to find cases where
       
  5285          someone opens a new transaction while there is still one outstanding (a SQLite logic error)
       
  5286 
       
  5287         * loader/icon/SQLDatabase.cpp:
       
  5288         (WebCore::SQLDatabase::SQLDatabase): 
       
  5289         (WebCore::SQLDatabase::open): Track the opening thread.  Also, return false if the DB failed to
       
  5290           open instead of trying to run a PRAGMA on it!
       
  5291         (WebCore::SQLDatabase::close): Reset the opening thread
       
  5292         * loader/icon/SQLDatabase.h:
       
  5293         (WebCore::SQLDatabase::transactionInProgress): 
       
  5294         (WebCore::SQLDatabase::sqlite3Handle): For access to the raw sqlite3* handle to do a thread
       
  5295           safety check
       
  5296 
       
  5297         * loader/icon/SQLStatement.cpp:
       
  5298         (WebCore::SQLStatement::prepare): Use the new sqlite3Handle accessor
       
  5299         (WebCore::SQLStatement::step): Ditto
       
  5300 
       
  5301         * loader/icon/SQLTransaction.cpp:
       
  5302         (WebCore::SQLTransaction::SQLTransaction): Removed the c'tor form that could automatically
       
  5303           begin the transaction - never used and shouldn't be in practice!
       
  5304         (WebCore::SQLTransaction::begin): Maintain the transaction-in-progress flag on the DB
       
  5305         (WebCore::SQLTransaction::commit): Ditto
       
  5306         (WebCore::SQLTransaction::rollback): Ditto
       
  5307         * loader/icon/SQLTransaction.h:
       
  5308 
       
  5309 2007-09-04  David Harrison  <harrison@apple.com>
       
  5310 
       
  5311         Reviewed by Maciej and John.
       
  5312 
       
  5313         <rdar://problem/5452675> CrashTracer: [USER] 10 crashes in Mail at com.apple.WebCore: WebCore::Node::nodeIndex const + 6
       
  5314 
       
  5315         * editing/InsertParagraphSeparatorCommand.cpp:
       
  5316         (WebCore::InsertParagraphSeparatorCommand::doApply):
       
  5317         Adjust pos to pos.downstream() after the refNode is calculated, but before the insertion. Doing it earlier
       
  5318         undid the logic of positionAvoidingSpecialElementBoundary(). The downstream is still needed just to set the
       
  5319         ending selection.
       
  5320 
       
  5321 2007-09-04  Antti Koivisto  <antti@apple.com>
       
  5322 
       
  5323         Reviewed by Maciej.
       
  5324         
       
  5325         Fix <rdar://problem/5452112>
       
  5326         REGRESSION: Initially focused textfield on www.mac.com login page has no insertion point, and doesn't accept typed characters
       
  5327         
       
  5328         Use updateLayoutIgnorePendingStylesheets() instead of updateLayout(). We need to have rendering to set input focus.
       
  5329 
       
  5330         Test: fast/forms/focus-style-pending.html
       
  5331 
       
  5332         * dom/Element.cpp:
       
  5333         (WebCore::Element::focus):
       
  5334 
       
  5335 2007-09-04  Girish Ramakrishnan  <girish@trolltech.com>
       
  5336 
       
  5337         Reviewed by Simon.
       
  5338 
       
  5339         Fixed Qt build on Windows
       
  5340 
       
  5341         * html/HTMLFormElement.cpp:
       
  5342         (WebCore::pathGetFilename):
       
  5343 
       
  5344 2007-09-03  David Harrison  <harrison@apple.com>
       
  5345 
       
  5346         Reviewed by Kevin Decker.
       
  5347 
       
  5348         <rdar://problem/5456785> REGRESSION (r15963-r15970): Heading text not placed in VoiceOver Item Chooser (15132)
       
  5349 
       
  5350         * bridge/mac/WebCoreAXObject.mm:
       
  5351         (-[WebCoreAXObject title]):
       
  5352         For headings, return the text under the element instead of nil.
       
  5353 
       
  5354 2007-08-20  Oleg Sukhodolsky <son.two@gmail.com>
       
  5355 
       
  5356         Reviewed by Mark.
       
  5357 
       
  5358         WebKitQt/WebCoreSupport should not be added to INCLUDEPATH for gdk-port
       
  5359 
       
  5360         * WebCore.pro:
       
  5361 
       
  5362 2007-09-03  Mark Rowe  <mrowe@apple.com>
       
  5363 
       
  5364         Reviewed by Tim Hatcher.
       
  5365 
       
  5366         <rdar://problem/5452164> Production build with in symbols directory has no debug info
       
  5367 
       
  5368         Enable debug symbol generation on all build configurations.  Production builds are stripped
       
  5369         of symbols by Xcode during deployment post-processing.
       
  5370 
       
  5371         * Configurations/Base.xcconfig:
       
  5372         * WebCore.xcodeproj/project.pbxproj:
       
  5373 
       
  5374 2007-09-02  Brady Eidson  <beidson@apple.com>
       
  5375 
       
  5376         Reviewed by John Sullivan and Mark Rowe
       
  5377 
       
  5378         Groundwork for support for monitoring IconDatabase in-memory statistics
       
  5379 
       
  5380         * WebCore.exp:
       
  5381         * loader/icon/IconDatabase.cpp:
       
  5382         (WebCore::IconDatabase::pageURLMappingCount): Stub for now
       
  5383         (WebCore::IconDatabase::retainedPageURLCount): Ditto
       
  5384         (WebCore::IconDatabase::iconRecordCount): Ditto
       
  5385         (WebCore::IconDatabase::iconRecordCountWithData): Ditto
       
  5386         * loader/icon/IconDatabase.h:
       
  5387 
       
  5388 2007-09-02  Mark Rowe  <mrowe@apple.com>
       
  5389 
       
  5390         Reviewed by Antti.
       
  5391 
       
  5392         <rdar://problem/5454704> WebKit seems to get too-narrow widths for "Monotype Corsiva", so lays out incorrectly
       
  5393 
       
  5394         * platform/mac/FontDataMac.mm:
       
  5395         (WebCore::FontData::determinePitch): Work around NSFont incorrectly reporting Monotype Corsiva as fixed pitch.
       
  5396 
       
  5397 2007-09-01  Darin Adler  <darin@apple.com>
       
  5398 
       
  5399         - rolled out fix for bug 12988 because it broke getElementById in a layout test
       
  5400           I'm working on a new fix.
       
  5401 
       
  5402         * dom/Document.cpp: Rolled out.
       
  5403 
       
  5404 2007-09-01  Oliver Hunt  <oliver@apple.com>
       
  5405 
       
  5406         Reviewed by Sam.
       
  5407 
       
  5408         <rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions
       
  5409 
       
  5410         Adding a new EditorClient method so it is possible to inform WebKit of focus changes.
       
  5411         Also added new virtual method Node::shouldUseInputMethod to allow us to trivially check
       
  5412         whether an input method should be used when processing input for the currently focused
       
  5413         Node.
       
  5414 
       
  5415         * bridge/EditorClient.h:
       
  5416         * dom/Node.cpp:
       
  5417         (WebCore::Node::shouldUseInputMethod):
       
  5418         * dom/Node.h:
       
  5419         * html/HTMLInputElement.cpp:
       
  5420         (WebCore::HTMLInputElement::shouldUseInputMethod):
       
  5421         * html/HTMLInputElement.h:
       
  5422         * html/HTMLTextAreaElement.cpp:
       
  5423         (WebCore::HTMLTextAreaElement::shouldUseInputMethod):
       
  5424         * html/HTMLTextAreaElement.h:
       
  5425         * page/FocusController.cpp:
       
  5426         (WebCore::FocusController::setFocusedNode):
       
  5427         * platform/graphics/svg/SVGImageEmptyClients.h:
       
  5428         (WebCore::SVGEmptyEditorClient::setInputMethodState):
       
  5429 
       
  5430 2007-09-01  Rob Buis  <buis@kde.org>
       
  5431 
       
  5432         Reviewed by Darin.
       
  5433 
       
  5434         http://bugs.webkit.org/show_bug.cgi?id=12988
       
  5435         First element (in document order) is not returned when other duplicate ID-ed elements were created first
       
  5436 
       
  5437         Reset the element id cache when id's are added or removed and there
       
  5438         are duplicates for that id.
       
  5439 
       
  5440         Tests: fast/dom/duplicate-ids-document-order.html
       
  5441 
       
  5442         * dom/Document.cpp:
       
  5443         (WebCore::Document::getElementById):
       
  5444         (WebCore::Document::addElementById):
       
  5445         (WebCore::Document::removeElementById):
       
  5446 
       
  5447 2007-09-01  Rob Buis  <buis@kde.org>
       
  5448 
       
  5449         Reviewed by Darin.
       
  5450 
       
  5451         http://bugs.webkit.org/show_bug.cgi?id=15083
       
  5452         Some symbols in WebKit do not need to be exported
       
  5453 
       
  5454         Do not export these symbols.
       
  5455 
       
  5456         * dom/QualifiedName.cpp:
       
  5457         (WebCore::hashComponents):
       
  5458         * dom/XMLTokenizer.cpp:
       
  5459         (WebCore::toString):
       
  5460         (WebCore::getTokenizer):
       
  5461         * history/HistoryItem.cpp:
       
  5462         (WebCore::defaultNotifyHistoryItemChanged):
       
  5463         * platform/Arena.cpp:
       
  5464         (WebCore::CeilingLog2):
       
  5465         * platform/graphics/Color.cpp:
       
  5466         (WebCore::calcHue):
       
  5467         * platform/graphics/Path.cpp:
       
  5468         (WebCore::pathLengthApplierFunction):
       
  5469         * platform/graphics/cg/PathCG.cpp:
       
  5470         (WebCore::CGPathToCFStringApplierFunction):
       
  5471         (WebCore::CFStringFromCGPath):
       
  5472         * rendering/RenderText.cpp:
       
  5473         (WebCore::isSpaceAccordingToStyle):
       
  5474 
       
  5475 2007-08-31  Alice Liu  <alice.liu@apple.com>
       
  5476 
       
  5477         Reviewed by Tim Hatcher.
       
  5478 
       
  5479         Fixed <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply() after dropping a selected image over container's close box
       
  5480 
       
  5481         * editing/DeleteButtonController.cpp:
       
  5482         (WebCore::DeleteButtonController::show):
       
  5483         Factored out the code in ::show() that created and styled the elements of the Deletion UI
       
  5484 
       
  5485         (WebCore::DeleteButtonController::createDeletionUI):
       
  5486         Neglecting to move the append of the deletionUI elements into the same clause that handles the creation
       
  5487         of them ended up creating multiple elements at were repeatedly appended to the target, resulting in a 
       
  5488         bloated table deletion UI which was slow to show and hide. 
       
  5489 
       
  5490         * editing/DeleteButtonController.h:
       
  5491         (WebCore::DeleteButtonController::enabled):
       
  5492         Restore this function to how it used to be pre-r25305, sans asserts
       
  5493 
       
  5494         * editing/EditCommand.cpp:
       
  5495         Add disable/enable sandwich when undoing/redoing commands too
       
  5496         (WebCore::EditCommand::unapply):
       
  5497         (WebCore::EditCommand::reapply):
       
  5498 
       
  5499 2007-08-31  Antti Koivisto  <antti@apple.com>
       
  5500 
       
  5501         Reviewed by Anders.
       
  5502 
       
  5503         Fix <rdar://problem/5452943>
       
  5504         REGRESSION (r25283): Reproducible crash in HTMLObjectElement::getInstance under guard malloc
       
  5505         
       
  5506         Calling updateLayoutIgnorePendingStylesheets() may do arbitrary things to render tree so
       
  5507         no RenderObjects can be cached over it.
       
  5508 
       
  5509         * html/HTMLEmbedElement.cpp:
       
  5510         (WebCore::findWidgetRenderer):
       
  5511         (WebCore::HTMLEmbedElement::getInstance):
       
  5512         * html/HTMLObjectElement.cpp:
       
  5513         (WebCore::HTMLObjectElement::getInstance):
       
  5514 
       
  5515 2007-08-31  Anders Carlsson  <andersca@apple.com>
       
  5516 
       
  5517         Reviewed by Mitz.
       
  5518 
       
  5519         <rdar://problem/5443936>
       
  5520         Crash after QT movie completes playback at apple.com/imac
       
  5521         
       
  5522         If the plug-in or one of its children have focus, set it to NULL to prevent the web view window from getting the focus, 
       
  5523         which can cause a layout to happen while in HTMLObjectElement::detach. (This is what we do on the Mac).
       
  5524         
       
  5525         * plugins/win/PluginViewWin.cpp:
       
  5526         (WebCore::PluginViewWin::setParent):
       
  5527 
       
  5528 2007-08-30  Adele Peterson  <adele@apple.com>
       
  5529 
       
  5530         Reviewed by Justin.
       
  5531 
       
  5532         Fix for <rdar://problem/5450600> REGRESSION: can't paste in textfield if its in a body that has user-select:none set (affects widgets)
       
  5533 
       
  5534         Test: editing/pasteboard/paste-plaintext-user-select-none.html
       
  5535 
       
  5536         * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::insertFragmentForTestRendering):
       
  5537           Copy the user-select style from the current selection node and apply it so it is considered during the test rendering.
       
  5538           This is important since we recently changed user-select to be inherited.  When we consider valid VisiblePositions for the test rendering,
       
  5539           we need to have the correct user-select value that will actually be used for the real insertion.
       
  5540 
       
  5541 2007-08-31  Anders Carlsson  <andersca@apple.com>
       
  5542 
       
  5543         Reviewed by Oliver.
       
  5544 
       
  5545         <rdar://problem/5423939>
       
  5546         http://bugs.webkit.org/show_bug.cgi?id=15013
       
  5547         ASSERTION FAILED !m_inDestructor in WebCore::Shared<WebCore::PluginStreamWin>::ref() on Windows
       
  5548         
       
  5549         Protect the stream in case it's destroyed by the plug-in.
       
  5550         
       
  5551         * plugins/win/PluginStreamWin.cpp:
       
  5552         (WebCore::PluginStreamWin::didReceiveData):
       
  5553 
       
  5554 a2007-08-31  Darin Adler  <darin@apple.com>
       
  5555 
       
  5556         Reviewed by Anders.
       
  5557 
       
  5558         - http://bugs.webkit.org/show_bug.cgi?id=15122
       
  5559 
       
  5560         * editing/htmlediting.cpp: (WebCore::avoidIntersectionWithNode):
       
  5561         Change assertion so that it only fires when actually modifying the selection.
       
  5562         This isn't nearly as helpful, because the old assertion could catch potential
       
  5563         problems in more cases, but it's not obvious how to do better.
       
  5564 
       
  5565 2007-08-30  Oliver Hunt  <oliver@apple.com>
       
  5566 
       
  5567         Reviewed by Adam.
       
  5568         
       
  5569         <rdar://problem/5430772> REGRESSION(303-310A5) list items do not show with mouse over on istweb.apple.com/quack.apple.com
       
  5570         
       
  5571         VC++ treats bitfields as signed members, so Node::m_styleChange would be
       
  5572         sign extended if it was assigned the value FullStyleChange.  This caused
       
  5573         style recalculation to stop propagating.  
       
  5574         
       
  5575         We work around this VC++ oddity by storing the enum as an unsigned, and
       
  5576         casting back to StyleChangeType in the getter.
       
  5577                 
       
  5578         Test: fast/css/hover-affects-child.html
       
  5579 
       
  5580         * dom/Node.h:
       
  5581         (WebCore::Node::styleChangeType):
       
  5582 
       
  5583 2007-08-29  Justin Garcia  <justin.garcia@apple.com>
       
  5584 
       
  5585         Reviewed by Darin.
       
  5586 
       
  5587         <rdar://problem/5368833> 
       
  5588         REGRESSION: Pasting a triple-clicked line of quoted text at the top of a message adds an extra, quoted line
       
  5589 
       
  5590         * editing/CompositeEditCommand.cpp:
       
  5591         (WebCore::CompositeEditCommand::insertParagraphSeparator): Added an option for
       
  5592         using a plain div to hold the new paragraph, instead of a clone of the previous
       
  5593         block.
       
  5594         * editing/CompositeEditCommand.h:
       
  5595         * editing/InsertParagraphSeparatorCommand.cpp: Ditto.
       
  5596         (WebCore::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand): Ditto.
       
  5597         (WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.
       
  5598         * editing/InsertParagraphSeparatorCommand.h:
       
  5599         * editing/ReplaceSelectionCommand.cpp:
       
  5600         (WebCore::ReplaceSelectionCommand::doApply): Use a default block element when creating
       
  5601         new paragraphs, so that empty paragraphs don't contain the block style of the previous
       
  5602         one.
       
  5603         Don't expand collapsed brs at the end of inserted content, this was the root of the bug.
       
  5604         We'd copy <blockquote>hello<br></blockquote><br class="Apple-interchange-newline">
       
  5605         and get an extra paragraph.  The removed code used to make sure that if the copied 
       
  5606         selection ends with a paragraph break that is represented in the copied markup by a 
       
  5607         regular br (not an interchange newline br), that that paragraph break appears in the 
       
  5608         pasted content, but shouldMergeEnd, which was introduced after this code was written, 
       
  5609         now takes care of that.
       
  5610         (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): Inserted content should always
       
  5611         displace placeholder brs, even if that inserted content ends with a br.
       
  5612         * editing/markup.cpp:
       
  5613         (WebCore::needInterchangeNewlineAfter): This code failed to add an interchange newline
       
  5614         if the user copied <div>hello</div><br>, only don't add an interchange newline when
       
  5615         copying ^hello<br>^<br>, because then the copied paragraph break will already be 
       
  5616         represented in the copied markup by a br.
       
  5617         (WebCore::createMarkup):
       
  5618 
       
  5619 2007-08-30  David Harrison  <harrison@apple.com>
       
  5620 
       
  5621         Reviewed by Darin.
       
  5622 
       
  5623         <rdar://problem/5423900> Seed: safari crashes on submit feedback page in -[WebCoreAXObject isAttachment]
       
  5624 
       
  5625         * bridge/mac/WebCoreAXObject.mm:
       
  5626         (-[WebCoreAXObject isAttachment]):
       
  5627         Add nil check since element could be detached.
       
  5628 
       
  5629 2007-08-30  Mitz Pettel  <mitz@webkit.org>
       
  5630 
       
  5631         Reviewed by Dave Hyatt.
       
  5632 
       
  5633         - fix http://bugs.webkit.org/show_bug.cgi?id=13282
       
  5634           <rdar://problem/5126392> REGRESSION (NativePopUp): Rightmost character cut off in pop-up menu
       
  5635 
       
  5636         * rendering/RenderMenuList.cpp:
       
  5637         (WebCore::RenderMenuList::updateOptionsWidth): When measuring option text, use
       
  5638         the same WebCore run rounding behavior that is used to draw it in the popup button.
       
  5639 
       
  5640 2007-08-30  Riku Voipio  <riku.voipio@iki.fi>
       
  5641 
       
  5642         Reviewed by Dave Kilzer.
       
  5643 
       
  5644         Better ARM defines.
       
  5645 
       
  5646         * platform/DeprecatedString.h: Update comments to reflect the
       
  5647         change and update test to fit changes to Platform.h.
       
  5648 
       
  5649 2007-08-30  Darin Adler  <darin@apple.com>
       
  5650 
       
  5651         Reviewed by Tim Hatcher.
       
  5652 
       
  5653         - fix http://bugs.webkig.org/show_bug.cgi?id=14981
       
  5654           DEBUG builds of WebKit hang videwing Yahoo! Mail messages
       
  5655           with ~5 MB text attachment
       
  5656 
       
  5657         * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::checkConsistency):
       
  5658         * rendering/RenderFlow.cpp: (WebCore::RenderFlow::checkConsistency):
       
  5659         * rendering/RenderText.cpp: (WebCore::RenderText::checkConsistency):
       
  5660         Put the actual consistency check inside an ifdef. If you need it you can
       
  5661         turn it on. There's still some function call overhead in builds that don't
       
  5662         have NDEBUG defined, but that's worth it so we can turn this on and off
       
  5663         without recompiling the world.
       
  5664 
       
  5665         - small code style improvement to recently changed function
       
  5666 
       
  5667         * editing/TextIterator.cpp: (WebCore::plainTextToMallocAllocatedBuffer):
       
  5668         Use a typedef and make_pair to make the code dealing with the pair simpler to read.
       
  5669 
       
  5670 2007-08-30  Simon Hausmann  <hausmann@kde.org>
       
  5671 
       
  5672         Reviewed by Zack.
       
  5673 
       
  5674         Fix Qt/Gdk build. gcc on Linux at least doesn't like initializing
       
  5675         variables between jumps with goto ("jump to label foo crosses
       
  5676         initialization of bar").
       
  5677 
       
  5678         * editing/TextIterator.cpp:
       
  5679         (WebCore::plainTextToMallocAllocatedBuffer):
       
  5680 
       
  5681 2007-08-30  Darin Adler  <darin@apple.com>
       
  5682 
       
  5683         Reviewed by Antti.
       
  5684  
       
  5685         - fix <rdar://problem/5423270> CrashTracer: [USER] 1 crash in Safari at com.apple.WebCore:
       
  5686           WebCore::plainTextToMallocAllocatedBuffer + 762
       
  5687 
       
  5688         * editing/TextIterator.cpp: (WebCore::plainTextToMallocAllocatedBuffer):
       
  5689         Check for a malloc failure and exit the function if it failed.
       
  5690 
       
  5691 2007-08-29  Anders Carlsson  <andersca@apple.com>
       
  5692 
       
  5693         Reviewed by Oliver.
       
  5694 
       
  5695         <rdar://problem/5404329>
       
  5696         Plugin content starves WM_TIMER events on UI thread (affects idle behavior of app) on http://www.vincent-vella.com/, http://www.sagmeister.com/
       
  5697         
       
  5698         Add a tiny delay to invalidation timer to prevent it from starving other timers.
       
  5699         
       
  5700         * plugins/win/PluginViewWin.cpp:
       
  5701         (WebCore::PluginViewWin::invalidateRect):
       
  5702 
       
  5703 2007-08-29  Darin Adler  <darin@apple.com>
       
  5704 
       
  5705         Reviewed by Adele.
       
  5706 
       
  5707         * editing/htmlediting.cpp: (WebCore::avoidIntersectionWithNode):
       
  5708         Fix an assert that was firing for me all the time when doing editing operations.
       
  5709 
       
  5710 2007-08-29  Anders Carlsson <andersca@apple.com>
       
  5711 
       
  5712         Reviewed by Adam.
       
  5713 
       
  5714         <rdar://problem/5386098>
       
  5715         Repro hang with some Flash plugin content (http://dougmccune.com/blog/2007/07/25/coming-to-flexcamp-at-adobe/)
       
  5716         
       
  5717         In some cases, Flash ends up starving the main loop by sending a lot of WM_USER + 1 messages. Throttle these
       
  5718         messages so they won't end up hanging the web browser.
       
  5719         
       
  5720         * plugins/win/PluginViewWin.cpp:
       
  5721         (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
       
  5722         (WebCore::PluginMessageThrottlerWin::~PluginMessageThrottlerWin):
       
  5723         (WebCore::PluginMessageThrottlerWin::appendMessage):
       
  5724         (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):
       
  5725         (WebCore::PluginMessageThrottlerWin::allocateMessage):
       
  5726         (WebCore::PluginMessageThrottlerWin::isInlineMessage):
       
  5727         (WebCore::PluginMessageThrottlerWin::freeMessage):
       
  5728         (WebCore::PluginViewWndProc):
       
  5729         (WebCore::PluginViewWin::wndProc):
       
  5730         (WebCore::PluginViewWin::determineQuirks):
       
  5731         * plugins/win/PluginViewWin.h:
       
  5732         (WebCore::):
       
  5733         (WebCore::PluginViewWin::pluginWndProc):
       
  5734 
       
  5735 2007-08-29  Beth Dakin  <bdakin@apple.com>
       
  5736 
       
  5737         Reviewed by Hyatt.
       
  5738 
       
  5739         Fix for <rdar://problem/5436800> REGRESSION: PLT is 1.5% slower due 
       
  5740         to r24593 and r25098
       
  5741 
       
  5742         In r25098, we only called setCreatedByParser for XML! This patch 
       
  5743         calls it for HTML too, and takes care of the performance 
       
  5744         regression.
       
  5745 
       
  5746         * html/HTMLElementFactory.cpp:
       
  5747         (WebCore::styleConstructor):
       
  5748 
       
  5749 2007-08-29  Antti Koivisto  <antti@apple.com>
       
  5750 
       
  5751         Reviewed by Mitz.
       
  5752         
       
  5753         Fix <rdar://problem/5425951>
       
  5754         REGRESSION: change to updateLayoutIgnorePendingStylesheets causes SAP Portal page to render wrong
       
  5755         
       
  5756         If new nodes have been added or style recalc has been done with style sheets still pending, some nodes 
       
  5757         may not have had their real style calculated yet. Normally this state gets cleaned when style sheets arrive 
       
  5758         but in updateLayoutIgnorePendingStylesheets() we need to do full style recalc to get up-to-date style immediatly.
       
  5759         
       
  5760         Added a document flag to track if there are any nodes that did not have their real style calculated due to
       
  5761         pending stylesheets.
       
  5762 
       
  5763         Test: fast/dynamic/style-access-late-stylesheet-load.html
       
  5764 
       
  5765         * css/CSSStyleSelector.cpp:
       
  5766         (WebCore::CSSStyleSelector::styleForElement):
       
  5767         * dom/Document.cpp:
       
  5768         (WebCore::Document::Document):
       
  5769         (WebCore::Document::recalcStyle):
       
  5770         (WebCore::Document::updateLayoutIgnorePendingStylesheets):
       
  5771         * dom/Document.h:
       
  5772         (WebCore::Document::setHasNodesWithPlaceholderStyle):
       
  5773 
       
  5774 2007-08-29  Alice Liu  <alice.liu@apple.com>
       
  5775 
       
  5776         Reviewed by Maciej.
       
  5777 
       
  5778         We disable the DeleteButton UI before applying any editing commands.
       
  5779         This patch simply moves those disable/enable calls to a more correct place, closer to the actual application of the editing command. 
       
  5780 
       
  5781         * editing/EditCommand.cpp:
       
  5782         (WebCore::EditCommand::apply):
       
  5783         (WebCore::applyCommand):
       
  5784 
       
  5785 2007-08-28  Alice Liu  <alice.liu@apple.com>
       
  5786 
       
  5787         fixed <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply() 
       
  5788                                        after dropping a selected image over container's close box
       
  5789 
       
  5790         Reviewed by Darin and Maciej.
       
  5791 
       
  5792         * editing/DeleteButtonController.cpp:
       
  5793         (WebCore::DeleteButtonController::show):
       
  5794         (WebCore::DeleteButtonController::hide):
       
  5795         * editing/DeleteButtonController.h:
       
  5796         (WebCore::DeleteButtonController::enabled):
       
  5797         General changes made to DeleteButtonController: when hiding, it's not necessary to clear out 
       
  5798         the m_containerElement and m_target, especially since to fix this bug we need to keep 
       
  5799         their values around.  It's sufficient to just detach the container from target.
       
  5800 
       
  5801         * editing/EditCommand.cpp:
       
  5802         (WebCore::EditCommand::EditCommand):
       
  5803         Move the selection out of the deletion UI since we don't want to expose the deletion UI to any editing.
       
  5804 
       
  5805         * editing/Editor.cpp:
       
  5806         (WebCore::Editor::rangeForPoint):
       
  5807         Move the range out of the deletion UI since we don't want to expose the deletion UI to any editing.
       
  5808 
       
  5809         * editing/htmlediting.cpp:
       
  5810         * editing/htmlediting.h:
       
  5811         (WebCore::avoidIntersectionWithNode):
       
  5812         Moved function that operates on Range from markup.cpp to here
       
  5813         Added new implementation for function that operates on Selection
       
  5814 
       
  5815         * editing/markup.cpp:
       
  5816         (WebCore::createMarkup):
       
  5817         Moved function out of this file to htmlediting.cpp, and renamed to avoidIntersectionWithNode
       
  5818 
       
  5819 2007-08-29  David Hyatt  <hyatt@apple.com>
       
  5820 
       
  5821         Fix for 5441281, remove our dependency on cursor rects and drag margins
       
  5822         in AppKit for a large performance boost on the PLT and iBench.
       
  5823 
       
  5824         Reviewed by darin
       
  5825 
       
  5826         * platform/mac/WidgetMac.mm:
       
  5827         (WebCore::safeRemoveFromSuperview):
       
  5828         (WebCore::Widget::addToSuperview):
       
  5829         Suppress the resetting of drag margins when views are added and removed.
       
  5830 
       
  5831         (WebCore::Widget::setCursor):
       
  5832         Just use NSCursor's set method to immediately set the cursor.  We no longer
       
  5833         rely on NSScrollView/NSClipView setDocumentCursor, since that is implemented
       
  5834         using cursor rects.
       
  5835 
       
  5836 2007-08-29  Rick  <rick@writhe.org.uk>
       
  5837 
       
  5838         Reviewed by Tim Hatcher.
       
  5839 
       
  5840         Fix http://bugs.webkit.org/show_bug.cgi?id=14853
       
  5841         Bug 14853: Incorrect implementation of ArrayImpl's equality operator
       
  5842 
       
  5843         * platform/ArrayImpl.cpp:
       
  5844         (WebCore::ArrayImpl::operator==):
       
  5845         Fixed typo so that correct variable is used in equality comparison.
       
  5846 
       
  5847 2007-08-29  Peter Kasting  <zerodpx@gmail.com>
       
  5848 
       
  5849         Reviewed by Maciej.
       
  5850 
       
  5851         - fix http://bugs.webkit.org/show_bug.cgi?id=15096
       
  5852         Move the GIF frame duration minimum check into the various
       
  5853         ImageSource*.cpp backends and use the same values as
       
  5854         ImageSourceCG.cpp.
       
  5855 
       
  5856         * platform/graphics/cairo/ImageSourceCairo.cpp:
       
  5857         (WebCore::ImageSource::frameDurationAtIndex):
       
  5858         * platform/graphics/qt/ImageSourceQt.cpp:
       
  5859         (WebCore::ImageSource::frameDurationAtIndex):
       
  5860         * platform/image-decoders/gif/GIFImageReader.cpp:
       
  5861         (GIFImageReader::read):
       
  5862 
       
  5863 2007-08-29  Peter Kasting  <zerodpx@gmail.com>
       
  5864 
       
  5865         Reviewed by Maciej.
       
  5866 
       
  5867         - fix http://bugs.webkit.org/show_bug.cgi?id=15097
       
  5868         Make PNGImageDecoder.cpp size its frame buffer vector in its
       
  5869         constructor, so it never throws decoded image data away no matter
       
  5870         what order its functions are called in.
       
  5871 
       
  5872         * platform/image-decoders/png/PNGImageDecoder.cpp:
       
  5873         (WebCore::PNGImageDecoder::PNGImageDecoder):
       
  5874         (WebCore::PNGImageDecoder::frameBufferAtIndex):
       
  5875         (WebCore::PNGImageDecoder::decode):
       
  5876         (WebCore::PNGImageDecoder::rowAvailable):
       
  5877         (WebCore::PNGImageDecoder::pngComplete):
       
  5878 
       
  5879 2007-08-29  Peter Kasting  <zerodpx@gmail.com>
       
  5880 
       
  5881         Reviewed by Maciej.
       
  5882 
       
  5883         - fix http://bugs.webkit.org/show_bug.cgi?id=15104
       
  5884         Don't double-compensate for sizeof(unsigned) when making a buffer
       
  5885         overflow check in the GIF decoder.  Now interlaced GIFs don't
       
  5886         sometimes get nothing/garbage in some of the bottom rows.
       
  5887 
       
  5888         * platform/image-decoders/gif/GIFImageDecoder.cpp:
       
  5889         (WebCore::GIFImageDecoder::haveDecodedRow):
       
  5890 
       
  5891 2007-08-28  Sam Weinig  <sam@webkit.org>
       
  5892 
       
  5893         Reviewed by Darin.
       
  5894 
       
  5895         Update fix landed in r25249 to account for XMLHttpRequest, which can also be EventTargets.
       
  5896 
       
  5897         Tests: http/tests/security/listener/xss-XMLHttpRequest-addEventListener.html
       
  5898                http/tests/security/listener/xss-XMLHttpRequest-shortcut.html
       
  5899 
       
  5900         * bindings/js/JSXMLHttpRequest.cpp:
       
  5901         (KJS::JSXMLHttpRequest::putValueProperty): Use the Window object associated with document's frame, not the active Window.
       
  5902         (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction): ditto
       
  5903         * xml/XMLHttpRequest.h:
       
  5904         (WebCore::XMLHttpRequest::document): Expose Document member so bindings can access the correct frame.
       
  5905 
       
  5906 2007-08-28  Anders Carlsson  <andersca@apple.com>
       
  5907 
       
  5908         Reviewed by Darin.
       
  5909 
       
  5910         <rdar://problem/5424866> Bottom portion of any Web Clip widget appears transparent
       
  5911 
       
  5912         Restore the previous behavior, creating plug-ins on attach, for WebKit plug-ins. Netscape plug-ins
       
  5913         are still created during the first layout.
       
  5914         
       
  5915         * html/HTMLEmbedElement.cpp:
       
  5916         (WebCore::HTMLEmbedElement::getInstance):
       
  5917         Only call layout if the renderer doesn't have a widget.
       
  5918         
       
  5919         * html/HTMLObjectElement.cpp:
       
  5920         (WebCore::HTMLObjectElement::getInstance):
       
  5921         Likewise.
       
  5922         
       
  5923         * loader/FrameLoader.cpp:
       
  5924         (WebCore::FrameLoader::shouldUsePlugin):
       
  5925         Update for enum change.
       
  5926         
       
  5927         * loader/FrameLoaderTypes.h:
       
  5928         Add ObjectContentNetscapePlugin and ObjectContentOtherPlugin.
       
  5929         
       
  5930         * page/mac/WebCoreFrameBridge.h:
       
  5931         Get rid of the enum here, we can use the one in FrameLoaderTypes.h
       
  5932         
       
  5933         * rendering/RenderPartObject.cpp:
       
  5934         (WebCore::RenderPartObject::updateWidget):
       
  5935         Only create the plug-in if it's not a Netscape plug-in.
       
  5936         
       
  5937         (WebCore::RenderPartObject::layout):
       
  5938         Fix indentation.
       
  5939         
       
  5940 2007-08-28  David Harrison  <harrison@apple.com>
       
  5941 
       
  5942         Reviewed by Darin.
       
  5943 
       
  5944         <rdar://problem/5415006> Command Left in a To Do causes caret to disappear
       
  5945 
       
  5946         The selection was ending up inside non-editable content at the To Do Options
       
  5947         arrow image, rather then at the editable position just to the left of that image.
       
  5948         The problem was that startPositionForLine looked only at line boxes, and there
       
  5949         is no linebox for the editable position at the far left of a To Do, which is
       
  5950         a table. Addressed by having startPositionForLine use table offset 0 instead
       
  5951         of the first VisiblePosition inside the table.
       
  5952         
       
  5953         Found and fixed the similar case with option-left (move by word position).
       
  5954         
       
  5955         Test cases:
       
  5956         * editing/selection/mixed-editability-8.html: Added.
       
  5957         * editing/selection/mixed-editability-9.html: Added.
       
  5958 
       
  5959         Source changes:
       
  5960         * editing/SelectionController.cpp:
       
  5961         (WebCore::SelectionController::modifyMovingLeftBackward):
       
  5962         
       
  5963         * editing/VisiblePosition.cpp:
       
  5964         (WebCore::VisiblePosition::next):
       
  5965         (WebCore::VisiblePosition::previous):
       
  5966         (WebCore::VisiblePosition::stayInEditableContentLeft):
       
  5967         (WebCore::VisiblePosition::stayInEditableContentRight):
       
  5968         Factored stayInEditableContentLeft() and stayInEditableContentRight()
       
  5969         out of previous() and next().
       
  5970         
       
  5971         * editing/VisiblePosition.h:
       
  5972         Declare stayInEditableContentLeft() and stayInEditableContentRight().
       
  5973 
       
  5974         * editing/visible_units.cpp:
       
  5975         (WebCore::previousWordPosition):
       
  5976         (WebCore::nextWordPosition):
       
  5977         (WebCore::startOfLine):
       
  5978         (WebCore::endOfLine):
       
  5979         (WebCore::previousSentencePosition):
       
  5980         (WebCore::nextSentencePosition):
       
  5981         Call stayInEditableContentLeft() or stayInEditableContentRight(), as 
       
  5982         appropriate, so prevent crossing from editable content into
       
  5983         uneditable content.
       
  5984         
       
  5985         (WebCore::startPositionForLine):
       
  5986         Use table offset 0 instead of the first VisiblePosition in the table.
       
  5987         
       
  5988 2007-08-28  Mark Rowe  <mrowe@apple.com>
       
  5989 
       
  5990         Reviewed by Darin Adler.
       
  5991 
       
  5992         <rdar://problem/5443453> Decreasing history expiration time from 1 year to 1 week can lead to long hang while icon database syncs
       
  5993 
       
  5994         Perform the sync inside a SQLite transaction.  This drops the time taken for the sync from over 90s to under half a second in the
       
  5995         extreme case of over 90,000 URLs being pruned.
       
  5996 
       
  5997         * loader/icon/IconDatabase.cpp:
       
  5998         (WebCore::IconDatabase::syncDatabase):
       
  5999 
       
  6000 2007-08-28  Mark Rowe  <mrowe@apple.com>
       
  6001 
       
  6002         Reviewed by Darin Adler.
       
  6003 
       
  6004         <rdar://problem/5437983> Loading history containing 100,000 entries adds 20s to Safari's startup
       
  6005 
       
  6006         Add a new constructor for HistoryItem that initializes the alternate title.  This prevents WebHistoryItem
       
  6007         in WebKit from having explicitly set the display title, which triggers a history item changed notification
       
  6008         to be posted, for each history item loaded.
       
  6009 
       
  6010         * WebCore.exp:
       
  6011         * history/HistoryItem.cpp:
       
  6012         (WebCore::HistoryItem::HistoryItem):
       
  6013         * history/HistoryItem.h:
       
  6014 
       
  6015 2007-08-28  Anders Carlsson  <andersca@apple.com>
       
  6016 
       
  6017         Reviewed by Darin.
       
  6018 
       
  6019         <rdar://problem/5298296> XMLHttpRequest readyState 3 & responseText buffer issues
       
  6020         
       
  6021         Add a shouldContentSniff flag to ResourceLoader and ResourceHandle and have XMLHttpRequest 
       
  6022         pass in false when creating its subresource loader.
       
  6023         
       
  6024         * WebCore.exp:
       
  6025         * loader/MainResourceLoader.cpp:
       
  6026         (WebCore::MainResourceLoader::MainResourceLoader):
       
  6027         (WebCore::MainResourceLoader::loadNow):
       
  6028         * loader/ResourceLoader.cpp:
       
  6029         (WebCore::ResourceLoader::ResourceLoader):
       
  6030         (WebCore::ResourceLoader::load):
       
  6031         * loader/ResourceLoader.h:
       
  6032         * loader/SubresourceLoader.cpp:
       
  6033         (WebCore::SubresourceLoader::SubresourceLoader):
       
  6034         (WebCore::SubresourceLoader::create):
       
  6035         * loader/SubresourceLoader.h:
       
  6036         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
       
  6037         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
       
  6038         * platform/mac/WebCoreSystemInterface.h:
       
  6039         * platform/mac/WebCoreSystemInterface.mm:
       
  6040         * platform/network/ResourceHandle.cpp:
       
  6041         (WebCore::ResourceHandle::ResourceHandle):
       
  6042         (WebCore::ResourceHandle::create):
       
  6043         * platform/network/ResourceHandle.h:
       
  6044         * platform/network/ResourceHandleInternal.h:
       
  6045         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
       
  6046         * platform/network/mac/ResourceHandleMac.mm:
       
  6047         (WebCore::ResourceHandle::start):
       
  6048         * xml/XMLHttpRequest.cpp:
       
  6049         (WebCore::XMLHttpRequest::send):
       
  6050 
       
  6051 2007-08-27  Steve Falkenburg  <sfalken@apple.com>
       
  6052 
       
  6053         Added getter for committedFirstRealDocumentLoad.
       
  6054         
       
  6055         Reviewed by Maciej.
       
  6056 
       
  6057         * loader/FrameLoader.h: Added committedFirstRealDocumentLoad.
       
  6058         (WebCore::FrameLoader::committedFirstRealDocumentLoad): Added.
       
  6059 
       
  6060 2007-08-27  Antti Koivisto  <antti@apple.com>
       
  6061 
       
  6062         Reviewed by Maciej.
       
  6063         
       
  6064         Fix <rdar://problem/5433144>
       
  6065         REGRESSION: Unable to click "Select" link at Expedia for car rentals
       
  6066         
       
  6067         javascript: URLs need special handling when serializing. Escaping them like
       
  6068         normal attribute values can do bad things. Try hard to not escape anything,
       
  6069         escape quote characters only if really necessary. Try to match Firefox.
       
  6070 
       
  6071         Test: fast/innerHTML/javascript-url.html
       
  6072 
       
  6073         * editing/markup.cpp:
       
  6074         (WebCore::urlAttributeToQuotedString):
       
  6075         (WebCore::startMarkup):
       
  6076 
       
  6077 2007-08-27  David Hyatt  <hyatt@apple.com>
       
  6078 
       
  6079         Fix for 5441224, micro-optimizations to improve the PLT by 1%.
       
  6080 
       
  6081         Reviewed by Darin
       
  6082 
       
  6083         * css/CSSStyleSelector.cpp:
       
  6084         (WebCore::CSSStyleSelector::canShareStyleWithElement):
       
  6085         * platform/mac/FontMac.mm:
       
  6086         (WebCore::Font::drawGlyphs):
       
  6087         * rendering/RenderInline.cpp:
       
  6088         (WebCore::RenderInline::requiresLayer):
       
  6089         * rendering/RenderObject.cpp:
       
  6090         (WebCore::RenderObject::isBody):
       
  6091         * rendering/RenderObject.h:
       
  6092         (WebCore::RenderObject::renderArena):
       
  6093         (WebCore::RenderObject::isRoot):
       
  6094 
       
  6095 2007-08-27  Mitz Pettel  <mitz@webkit.org>
       
  6096 
       
  6097         Reviewed by Darin.
       
  6098 
       
  6099         - fix http://bugs.webkit.org/show_bug.cgi?id=15091
       
  6100           Crash in RenderBlock::skipWhitespace during layout <rdar://problem/5439631> 
       
  6101 
       
  6102         Test: fast/replaced/applet-disabled-positioned.html
       
  6103 
       
  6104         * html/HTMLAppletElement.cpp:
       
  6105         (WebCore::HTMLAppletElement::createRenderer): Changed to call
       
  6106         RenderObject::createObject(), which accounts for style.
       
  6107 
       
  6108 2007-08-26  Antti Koivisto  <antti@apple.com>
       
  6109 
       
  6110         Reviewed by Darin.
       
  6111         
       
  6112         Fix for <rdar://problem/5433726>
       
  6113         Mail crash at WebCore::Frame::styleForSelectionStart() when deleting a selection in a HTML message (http://www.yahoo.com/)
       
  6114 
       
  6115         Test: editing/style/temporary-span-crash.html
       
  6116 
       
  6117         * page/Frame.cpp:
       
  6118         (WebCore::Frame::styleForSelectionStart):
       
  6119         Temporary span created here might not have renderer if document has style sheet that makes it display:none.
       
  6120         Set display:inline explicitly in spans style attribute. This temporary span does not need to get its display 
       
  6121         value from actual document style sheets. Null check the renderer too to be sure.
       
  6122 
       
  6123 
       
  6124 2007-08-24  Sam Weinig  <sam@webkit.org>
       
  6125 
       
  6126         Reviewed by Adele.
       
  6127 
       
  6128         Fix for <rdar://problem/5426142>
       
  6129 
       
  6130         Use the EventTarget's frame when creating the EventListener.
       
  6131 
       
  6132         Tests: http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener.html
       
  6133                http/tests/security/listener/xss-JSTargetNode-onclick-shortcut.html
       
  6134                http/tests/security/listener/xss-window-onclick-addEventListener.html
       
  6135                http/tests/security/listener/xss-window-onclick-shortcut.html
       
  6136 
       
  6137         * bindings/js/JSEventTargetNode.cpp:
       
  6138         (WebCore::JSEventTargetNode::setListener):
       
  6139         (WebCore::JSEventTargetNodePrototypeFunction::callAsFunction):
       
  6140         * bindings/js/kjs_window.cpp:
       
  6141         (KJS::WindowFunc::callAsFunction):
       
  6142 
       
  6143 2007-08-25  Mitz Pettel  <mitz@webkit.org>
       
  6144 
       
  6145         Reviewed by Sam Weinig.
       
  6146 
       
  6147         - fix http://bugs.webkit.org/show_bug.cgi?id=15077
       
  6148           REGRESSION: Cannot drag selected text out of a background window
       
  6149 
       
  6150         * manual-tests/drag-out-of-background-window.html: Added.
       
  6151         * page/EventHandler.cpp:
       
  6152         (WebCore::EventHandler::eventMayStartDrag): Added missing coordinate
       
  6153         conversion.
       
  6154 
       
  6155 2007-08-25  Rob Buis  <buis@kde.org>
       
  6156 
       
  6157         Reviewed by Darin.
       
  6158 
       
  6159         http://bugs.webkit.org/show_bug.cgi?id=14848
       
  6160         DOM table rules are not updated when changed
       
  6161 
       
  6162         On a dynamic rules attr change, mark the table cells and
       
  6163         their ancestors (up to and including the table tag) as
       
  6164         changed.
       
  6165 
       
  6166         Tests: fast/table/rules-attr-dynchange1.html
       
  6167                fast/table/rules-attr-dynchange2.html
       
  6168 
       
  6169         * html/HTMLTableElement.cpp:
       
  6170         (WebCore::isTableCellAncestor):
       
  6171         (WebCore::setTableCellsChanged):
       
  6172         (WebCore::HTMLTableElement::parseMappedAttribute):
       
  6173 
       
  6174 2007-08-25  Adele Peterson  <adele@apple.com>
       
  6175 
       
  6176         Reviewed by Mitz.
       
  6177 
       
  6178         Fix for http://bugs.webkit.org/show_bug.cgi?id=15073
       
  6179         <rdar://problem/5426557> REGRESSION: Can no longer drag text from textareas
       
  6180         
       
  6181         Test: fast/forms/drag-out-of-textarea.html
       
  6182 
       
  6183         * rendering/RenderTextControl.cpp: (WebCore::RenderTextControlInnerBlock::nodeAtPoint):
       
  6184           Only restricts hit testing if the placeholder text is visible.
       
  6185         * rendering/RenderTextControl.h: (WebCore::RenderTextControl::placeholderIsVisible): Added. 
       
  6186 
       
  6187 2007-08-25  Peter Kasting <zerodpx@gmail.org>
       
  6188 
       
  6189         Reviewed by Sam Weinig.
       
  6190 
       
  6191         Part 2 of http://bugs.webkit.org/show_bug.cgi?id=14967.
       
  6192         Eliminate all remaining implicit conversions of wtf::Vector<T> to T*.  Where code was
       
  6193         previously checking that the Vector's data pointer was non-NULL, check !Vector::isEmpty()
       
  6194         instead.
       
  6195 
       
  6196         * bindings/js/kjs_navigator.cpp:
       
  6197         (KJS::PluginBase::cachePluginDataIfNecessary):
       
  6198         * loader/mac/LoaderNSURLExtras.m:
       
  6199         (suggestedFilenameWithMIMEType):
       
  6200         * page/FrameView.cpp:
       
  6201         (WebCore::FrameView::~FrameView):
       
  6202         (WebCore::FrameView::pauseScheduledEvents):
       
  6203         (WebCore::FrameView::resumeScheduledEvents):
       
  6204         (WebCore::FrameView::dispatchScheduledEvents):
       
  6205         * platform/mac/PlugInInfoStoreMac.mm:
       
  6206         (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
       
  6207 
       
  6208 2007-08-25  Mitz Pettel  <mitz@webkit.org>
       
  6209 
       
  6210         Rubber-stamped by Adam Roben
       
  6211 
       
  6212         - remove unused file
       
  6213 
       
  6214         * platform/win/MouseEventWin.cpp: Removed.
       
  6215 
       
  6216 2007-08-25  Jasper Bryant-Greene  <m@ni.ac.nz>
       
  6217 
       
  6218         Reviewed by Oliver Hunt.
       
  6219 
       
  6220         Set paintingDisabled to true in Cairo's GraphicsContext constructor
       
  6221         when passed a null PlatformGraphicsContext.
       
  6222 
       
  6223         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
  6224         (WebCore::GraphicsContext::GraphicsContext):
       
  6225 
       
  6226 2007-08-25  Mitz Pettel  <mitz@webkit.org>
       
  6227 
       
  6228         Reviewed by Dave Hyatt.
       
  6229 
       
  6230         - fix http://bugs.webkit.org/show_bug.cgi?id=15056
       
  6231           REGRESSION (r21472): Digg Podcasts Episodes Render "Digg" counter incorrectly
       
  6232 
       
  6233         Covered by fast/parser/residual-style-close-across-n-blocks.html
       
  6234 
       
  6235         * html/HTMLParser.cpp:
       
  6236         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): If the
       
  6237         residual style was closed before anything else in the block (so it does
       
  6238         not apply to anything inside the block) avoid creating an empty element for
       
  6239         it inside the block.
       
  6240 
       
  6241 2007-08-25  Mitz Pettel  <mitz@webkit.org>
       
  6242 
       
  6243         Reviewed by Dave Hyatt.
       
  6244 
       
  6245         - fix http://bugs.webkit.org/show_bug.cgi?id=14972
       
  6246           Moving cursor down in contentEditable section fails if styled line-height:1em
       
  6247 
       
  6248         Test: editing/selection/move-by-line-003.html
       
  6249 
       
  6250         * rendering/RenderText.cpp:
       
  6251         (WebCore::RenderText::positionForCoordinates): Changed hit testing so that each
       
  6252         line is tested for hits between its overflow top and the next line's overflow top.
       
  6253         This matches RenderBlock::positionForCoordinates.
       
  6254 
       
  6255 2007-08-25  Mitz Pettel  <mitz@webkit.org>
       
  6256 
       
  6257         Reviewed by Justin.
       
  6258 
       
  6259         - fix http://bugs.webkit.org/show_bug.cgi?id=14792
       
  6260           <rdar://problem/5367763> REGRESSION: Copy inserts carriage return in middle of selection
       
  6261 
       
  6262         Test: editing/pasteboard/newlines-around-floating-or-positioned.html
       
  6263 
       
  6264         * editing/TextIterator.cpp:
       
  6265         (WebCore::shouldEmitNewlinesBeforeAndAfterNode): Do not emit newlines around
       
  6266         floating or positioned blocks. This behavior seems to match WinIE's.
       
  6267 
       
  6268 2007-08-23  Justin Garcia  <justin.garcia@apple.com>
       
  6269 
       
  6270         Reviewed by Darin.
       
  6271         
       
  6272         <rdar://problem/5432254> GoogleDocs: A hang occurs when applying list style to selected table
       
  6273         
       
  6274         * editing/DeleteSelectionCommand.cpp:
       
  6275         (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the position
       
  6276         that marked the start of the range to delete has been removed from the
       
  6277         document, and it was inside the node that holds the position that marks
       
  6278         the end of the range to delete, don't remove any children of that node,
       
  6279         because we don't know how many to remove.  For example, if the end is
       
  6280         [a, 5] and the start was in some descendant of a and was removed, don't
       
  6281         remove any of the children of a.  We will now refuse to remove some content
       
  6282         incorrectly, but that's less dangerous than removing content incorrectly.
       
  6283         Long term we need to update these positions as we remove content from the 
       
  6284         document, but that seems like a more risky change.  Added a testcase.
       
  6285         * editing/InsertListCommand.cpp:
       
  6286         (WebCore::InsertListCommand::modifyRange): If the end of the selection to 
       
  6287         modify is just after a table, and if the start of the selection is inside 
       
  6288         that table, the last paragraph that we'll want modify is the last one inside 
       
  6289         the table, not the paragraph that contains the table itself. Adjust 
       
  6290         startOfLastParagraph here to avoid infinite recursion.
       
  6291 
       
  6292 2007-08-24  Anders Carlsson  <andersca@apple.com>
       
  6293 
       
  6294         Reviewed by Geoff.
       
  6295 
       
  6296         <rdar://problem/5430165>
       
  6297         REGRESSION: Dynamically loaded images fail to load
       
  6298 
       
  6299         * html/HTMLImageLoader.cpp:
       
  6300         (WebCore::HTMLImageLoader::HTMLImageLoader):
       
  6301         Initialize the m_elementIsProtected member.
       
  6302 
       
  6303         (WebCore::HTMLImageLoader::~HTMLImageLoader):
       
  6304         Assert that the element is not protected.
       
  6305         
       
  6306         (WebCore::HTMLImageLoader::setLoadingImage):
       
  6307         If the image is not null, protect the element. Otherwise, unprotect it.
       
  6308         
       
  6309         (WebCore::HTMLImageLoader::dispatchLoadEvent):
       
  6310         Unprotect the element here.
       
  6311 
       
  6312         (WebCore::HTMLImageLoader::protectElement):
       
  6313         (WebCore::HTMLImageLoader::unprotectElement):
       
  6314         New methods which protect and unprotect the element.
       
  6315         
       
  6316         * html/HTMLImageLoader.h:
       
  6317 
       
  6318 2007-08-24  Kevin McCullough  <kmccullough@apple.com>
       
  6319 
       
  6320         - Updated ChangeLog
       
  6321 
       
  6322 2007-08-24  Beth Dakin  <bdakin@apple.com>
       
  6323 
       
  6324         Reviewed by Hyatt and Adele.
       
  6325 
       
  6326         Fix for <rdar://problem/5417203> Google Gmail 1.0 widget - unread 
       
  6327         count is missing
       
  6328 
       
  6329         * rendering/FixedTableLayout.cpp:
       
  6330         (WebCore::FixedTableLayout::calcWidthArray): Calc pref widths for 
       
  6331         our cells, if needed.
       
  6332 
       
  6333 2007-08-24  Kevin McCullough  <kmccullough@apple.com>
       
  6334 
       
  6335         Reviewed by Darin.
       
  6336 
       
  6337         <rdar://problem/5437038> 1 credential object leaked for each call to credentialWithUser:password:persistence
       
  6338         - Use initWithUser instead of credentialWithUser because credentialWithUser leaks.
       
  6339 
       
  6340         * platform/network/mac/AuthenticationMac.mm:
       
  6341         (WebCore::mac):
       
  6342         * platform/network/mac/ResourceHandleMac.mm:
       
  6343         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
       
  6344         (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]):
       
  6345 
       
  6346 2007-08-24  Jon Honeycutt  <jhoneycutt@apple.com>
       
  6347 
       
  6348         Reviewed by Darin.
       
  6349 
       
  6350         <rdar://problem/5433236> Print preview of empty txt file crashes Safari
       
  6351         Fix: Adjust computePageRectsForFrame to always return at least one 
       
  6352         page rect, even if document height is zero.
       
  6353 
       
  6354         * WebCore.vcproj/WebCore.vcproj:
       
  6355         * bridge/win/FrameWin.h: Added Vector& parameter to 
       
  6356         computePagesRectsForFrame; changed its return type to void.
       
  6357         * bridge/win/FrameWin.cpp:
       
  6358         (WebCore::computePageRectsForFrame): Reordered the loop that inserts
       
  6359         rects into the vector.
       
  6360 
       
  6361 2007-08-24  Antti Koivisto  <antti@apple.com>
       
  6362 
       
  6363         Reviewed by Oliver
       
  6364 
       
  6365         Fix <rdar://problem/5393758>
       
  6366         Crash in WebCore::FontData::platformInit
       
  6367         
       
  6368         Null check glyph page. 
       
  6369         
       
  6370         If font has somehow failed to initialize it is possible to have null glyph page. Based on
       
  6371         crash dumps this seems to occasionally happen when running Mail under guard malloc. 
       
  6372         
       
  6373         No test case, I don't know how to get to this state.
       
  6374 
       
  6375         * platform/FontData.cpp:
       
  6376         (WebCore::FontData::FontData):
       
  6377         * platform/mac/FontDataMac.mm:
       
  6378         (WebCore::FontData::platformInit):
       
  6379 
       
  6380 2007-08-24  George Wright  <george.wright@collabora.co.uk>
       
  6381 
       
  6382         Reviewed by Oliver.
       
  6383 
       
  6384         http://bugs.webkit.org/show_bug.cgi?id=15071
       
  6385         [cairo] SVG skews are incorrect
       
  6386 
       
  6387         Fix Cairo implementation of AffineTransform::shear so that shearing is
       
  6388         done in the correct direction.
       
  6389 
       
  6390         * platform/graphics/cairo/AffineTransformCairo.cpp:
       
  6391         (WebCore::AffineTransform::shear):
       
  6392 
       
  6393 2007-08-23  Anders Carlsson  <andersca@apple.com>
       
  6394 
       
  6395         Reviewed by Steve.
       
  6396 
       
  6397         If necessary, re-set the window proc after each call to NPP_SetWindow. This is to ensure that
       
  6398         our window proc is always run even if a plug-in subclasses the window and replaces the window proc.
       
  6399         
       
  6400         Also, make sure that the default window proc is of type ASCII so we can eliminate the 
       
  6401         * plugins/win/PluginViewWin.cpp:
       
  6402         (WebCore::registerPluginView):
       
  6403         (WebCore::PluginViewWndProc):
       
  6404         (WebCore::PluginViewWin::setNPWindowRect):
       
  6405         (WebCore::PluginViewWin::stop):
       
  6406         (WebCore::PluginViewWin::determineQuirks):
       
  6407         (WebCore::PluginViewWin::PluginViewWin):
       
  6408         (WebCore::PluginViewWin::init):
       
  6409         * plugins/win/PluginViewWin.h:
       
  6410         (WebCore::):
       
  6411         (WebCore::PluginViewWin::pluginWndProc):
       
  6412 
       
  6413 2007-08-23  Justin Garcia  <justin.garcia@apple.com>
       
  6414 
       
  6415         Reviewed by Adele.
       
  6416 
       
  6417         <rdar://problem/5156801> REGRESSION: Crash at DeleteSelectionCommand::doApply() when deleting table content
       
  6418 
       
  6419         * editing/DeleteSelectionCommand.cpp:
       
  6420         (WebCore::DeleteSelectionCommand::handleGeneralDelete): Use a RefPtr
       
  6421         for node.  If the node to be removed contains the selection, and if
       
  6422         the next node to be removed (nextNode) is inside the deletion UI,
       
  6423         removing node will remove nextNode from the document.  nextNode is
       
  6424         a RefPtr, but node isn't and when nextNode falls out of scope the node
       
  6425         that node points to will be destroyed and we'll end up using a stale pointer.
       
  6426         Long term we should probably just disable the deletion UI before editing 
       
  6427         operations because the undo of the removal of node in the situation 
       
  6428         described above relies on the presence of the deletion UI, but it isn't 
       
  6429         present because its added and removed in a non-undoable way.
       
  6430 
       
  6431 2007-08-23  Mitz Pettel  <mitz@webkit.org>
       
  6432 
       
  6433         Reviewed by Darin.
       
  6434 
       
  6435         - fix http://bugs.webkit.org/show_bug.cgi?id=14899
       
  6436           !d->m_view->needsLayout() in Frame::paint() (Causes assert)
       
  6437 
       
  6438         WebKit copies the width and height attributes of an <embed> to its
       
  6439         nearest <object> ancestor. This used to be done in updateWidget(), but
       
  6440         that could lead to the document being dirty right after layout and
       
  6441         before painting. The patch moves the copying of the attributes to when
       
  6442         the <embed> is inserted into the document or its attributes change.
       
  6443 
       
  6444         * html/HTMLEmbedElement.cpp:
       
  6445         (WebCore::HTMLEmbedElement::insertedIntoDocument):
       
  6446         (WebCore::HTMLEmbedElement::attributeChanged):
       
  6447         * html/HTMLEmbedElement.h:
       
  6448         * manual-tests/bugzilla-14899.html: Added.
       
  6449         * rendering/RenderPartObject.cpp:
       
  6450         (WebCore::RenderPartObject::updateWidget):
       
  6451 
       
  6452 2007-08-22  Anders Carlsson  <andersca@apple.com>
       
  6453 
       
  6454         Reviewed by Darin and Oliver.
       
  6455 
       
  6456         <rdar://problem/5422410>
       
  6457         http://bugs.webkit.org/show_bug.cgi?id=15019
       
  6458         REGRESSION (r25124-r25140): New posts and hot topics won't show at mobile01.com
       
  6459 
       
  6460         Remove the call to checkCallImplicitClose(). Calling it in loadPlugin is bad for two reasons:
       
  6461         
       
  6462         1. It could cause onload to be dispatched even when the page has subresources that are still
       
  6463         loading, such as images.
       
  6464         
       
  6465         2. Now that loadPlugin is called during layout, it could cause onload to be dispatched during
       
  6466         layout, which can execute javascript and do pretty much anything while the render tree is in an
       
  6467         inconsistent state.
       
  6468         
       
  6469         * loader/FrameLoader.cpp:
       
  6470         (WebCore::FrameLoader::loadPlugin):
       
  6471 
       
  6472 2007-08-22  Anders Carlsson  <andersca@apple.com>
       
  6473 
       
  6474         Reviewed by Adam.
       
  6475 
       
  6476         <rdar://problem/5430584>
       
  6477         http://bugs.webkit.org/show_bug.cgi?id=15053        
       
  6478         WebKit does not check Windows Registry HKEY_CURRENT_USER for NPAPI plugin locations
       
  6479         
       
  6480         * plugins/win/PluginDatabaseWin.cpp:
       
  6481         (WebCore::addPluginsFromRegistry):
       
  6482         (WebCore::PluginDatabaseWin::getPluginsInPaths):
       
  6483 
       
  6484 2007-08-22  Justin Garcia  <justin.garcia@apple.com>
       
  6485 
       
  6486         Reviewed by Adam.
       
  6487         
       
  6488         <rdar://problem/5418891> CrashTracer: [USER] 1 crash in Mail at -[WebViewEditor webView:shouldInsertText:replacingDOMRange:givenAction:]
       
  6489 
       
  6490         * editing/BreakBlockquoteCommand.cpp:
       
  6491         (WebCore::BreakBlockquoteCommand::doApply): We're reusing the topBlockquote
       
  6492         variable.  Null it out first.  If there is no new topBlockquote and we don't null
       
  6493         it out first, we'll assume that there was a new one and crash.
       
  6494 
       
  6495 2007-08-22  Kevin McCullough  <kmccullough@apple.com>
       
  6496 
       
  6497         Reviewed by Adele.
       
  6498 
       
  6499         - rdar:5423067 Reapplyingthe change but only when the text area is in focus.
       
  6500 
       
  6501         * html/HTMLTextAreaElement.cpp:
       
  6502         (WebCore::HTMLTextAreaElement::setValue):
       
  6503 
       
  6504 2007-08-21  David Hyatt  <hyatt@apple.com>
       
  6505 
       
  6506         Fix for <rdar://problem/5249757> Painting of JPGs in WebKit is too slow.
       
  6507 
       
  6508         Use a new Leopard API for fast tiling of images.  We only use this API
       
  6509         when the whole image is being tiled and when the current CGImageRef to tile
       
  6510         has a size that matches the size of the whole image.
       
  6511 
       
  6512         We can optimize border-image in the future by adding a cache of the 9
       
  6513         sub-images.
       
  6514 
       
  6515         Reviewed by darin
       
  6516 
       
  6517         * platform/graphics/cg/ImageCG.cpp:
       
  6518         (WebCore::Image::drawPattern):
       
  6519 
       
  6520 2007-08-22  Kevin McCullough  <kmccullough@apple.com>
       
  6521 
       
  6522         - Rolling back since I need to update some layouttests this change breaks.
       
  6523 
       
  6524         * html/HTMLTextAreaElement.cpp:
       
  6525         (WebCore::HTMLTextAreaElement::setValue):
       
  6526 
       
  6527 2007-08-21  Kevin McCullough  <kmccullough@apple.com>
       
  6528 
       
  6529         Reviewed by Geof, Adam, Hyatt, Maciej and Oliver.
       
  6530 
       
  6531         - In order to match the behavior of the other major browsers, selection is moved to the end of the text value when a change occurs to the contents of a text area instead of remembering the location of the selection.
       
  6532         - <rdar://problem/5423067> gmail is super annoying when trying to add a new name to the TO, CC or BCC fields
       
  6533 
       
  6534         * html/HTMLTextAreaElement.cpp:
       
  6535         (WebCore::HTMLTextAreaElement::setValue):
       
  6536 
       
  6537 2007-08-21  Adam Roben  <aroben@apple.com>
       
  6538 
       
  6539         Build fix for Mac
       
  6540 
       
  6541         Keep FrameView::layoutIfNeededRecursive Windows- and Gtk-only for now
       
  6542         (sadly). This will have to wait until we merge ScrollView and FrameView.
       
  6543 
       
  6544         Reviewed by NOBODY.
       
  6545 
       
  6546         * page/FrameView.cpp:
       
  6547         * page/FrameView.h:
       
  6548 
       
  6549 2007-08-21  Adam Roben  <aroben@apple.com>
       
  6550 
       
  6551         Fix an ASSERT when using Find in Page
       
  6552 
       
  6553         Reviewed by Darin.
       
  6554 
       
  6555         No test possible.
       
  6556 
       
  6557         * bridge/win/FrameWin.cpp:
       
  6558         (WebCore::imageFromSelection): Make sure to update layout before
       
  6559         painting so we don't hit an ASSERT in painting code (Frame::selectionImage
       
  6560         in FrameMac.mm does this as well).
       
  6561 
       
  6562 2007-08-21  Adam Roben  <aroben@apple.com>
       
  6563 
       
  6564         Made FrameView::layoutIfNeededRecursive available to all platforms
       
  6565 
       
  6566         Currently it's only used on Gtk+ and Windows.
       
  6567 
       
  6568         Reviewed by Darin.
       
  6569 
       
  6570         * page/FrameView.cpp: Removed #ifdef.
       
  6571         * page/FrameView.h: Ditto.
       
  6572 
       
  6573 2007-08-21  Adele Peterson  <adele@apple.com>
       
  6574 
       
  6575         Build fix for release build.
       
  6576 
       
  6577         * rendering/AutoTableLayout.cpp:
       
  6578         (WebCore::AutoTableLayout::calcEffectiveWidth):
       
  6579         (WebCore::AutoTableLayout::layout):
       
  6580 
       
  6581 2007-08-21  Mitz Pettel  <mitz@webkit.org>
       
  6582 
       
  6583         Reviewed by Darin.
       
  6584 
       
  6585         - fix http://bugs.webkit.org/show_bug.cgi?id=15010
       
  6586           <rdar://problem/5423956> REGRESSION (r25000-r25065): Table rendering broken by a recent nightly
       
  6587 
       
  6588         Test: fast/table/max-width-integer-overflow.html
       
  6589 
       
  6590         Avoid integer overflows when dealing with maximum widths by
       
  6591         1) using floating point arithmetic when summing or multiplying column max widths
       
  6592         2) capping max widths at INT_MAX / 2
       
  6593 
       
  6594         * rendering/AutoTableLayout.cpp:
       
  6595         (WebCore::AutoTableLayout::calcPrefWidths):
       
  6596         (WebCore::AutoTableLayout::calcEffectiveWidth):
       
  6597         (WebCore::AutoTableLayout::layout):
       
  6598 
       
  6599 2007-08-20  John Sullivan  <sullivan@apple.com>
       
  6600 
       
  6601         Reviewed by Adam Roben
       
  6602 
       
  6603         WebCore part of fix for: 
       
  6604         <rdar://problem/5417777> WebKit focus ring color no longer matches system focus rings
       
  6605         
       
  6606         Adele wrote the first version of this patch. No test cases added because I made sure the 
       
  6607         layout tests are unaffected. Two additional bug fixes were made in passing, but neither 
       
  6608         of them had any effect on any known real-world case, and both were too difficult to write 
       
  6609         test cases for to be worthwhile.
       
  6610 
       
  6611         * WebCore.exp:
       
  6612         added symbols for these new functions so WebKit can call them
       
  6613         
       
  6614         * WebCore.xcodeproj/project.pbxproj:
       
  6615         updated for new file
       
  6616         
       
  6617         * platform/graphics/mac/ColorMac.h: Added.
       
  6618         New file to hold the increasing amount of Mac-specific color stuff.
       
  6619         
       
  6620         * platform/graphics/Color.h:
       
  6621         removed #if PLATFORM(MAC) code, which is now in ColorMac.h
       
  6622         
       
  6623         * platform/graphics/mac/ColorMac.mm:
       
  6624         (WebCore::makeRGBAFromNSColor):
       
  6625         new static function to convert an NSColor object to an RGBA32 struct
       
  6626         (WebCore::colorFromNSColor):
       
  6627         new public function to convert an NSColor object to a WebCore-style Color object
       
  6628         (WebCore::focusRingColor):
       
  6629         Uses (cached) systemFocusRingColor instead of hardwired values, unless usesTestModeFocusRingColor is true,
       
  6630         in which case it uses the old hardwired color
       
  6631         (WebCore::usesTestModeFocusRingColor):
       
  6632         returns value of global var
       
  6633         (WebCore::setUsesTestModeFocusRingColor):
       
  6634         sets value of global var
       
  6635         (+[WebCoreControlTintObserver controlTintDidChange]):
       
  6636         Uses [NSColor keyboardFocusIndicatorColor] to set systemFocusRingColor; don't compile if COLORMATCH_EVERYTHING
       
  6637         is set since we don't know what it would take to satisfy this state.
       
  6638 
       
  6639         * bindings/objc/DOMRGBColor.mm:
       
  6640         now includes ColorMac.h to account for moved declarations
       
  6641         * bridge/mac/WebCoreAXObject.mm:
       
  6642         ditto
       
  6643         
       
  6644         * page/mac/FrameMac.mm:
       
  6645         (WebCore::convertAttributesToUnderlines):
       
  6646         now uses new colorFromNSColor. The old code was swapping G & B, but it didn't matter in practice because
       
  6647         this function is only used to convert the color of an input manager's marked text underline, which is always black
       
  6648         
       
  6649         * page/mac/WebCoreFrameBridge.mm:
       
  6650         (-[WebCoreFrameBridge setBaseBackgroundColor:]):
       
  6651         now uses new colorFromNSColor. The old code was swapping G & B, but it didn't matter in practice because
       
  6652         this function is only called with a grayscale color perhaps containing an alpha value
       
  6653                 
       
  6654         * rendering/RenderView.cpp:
       
  6655         (WebCore::RenderView::paintBoxDecorations):
       
  6656         just updated a comment
       
  6657 
       
  6658 2007-08-20  Mitz Pettel  <mitz@webkit.org>
       
  6659 
       
  6660         Reviewed by Dave Hyatt.
       
  6661 
       
  6662         - fix http://bugs.webkit.org/show_bug.cgi?id=15023
       
  6663           REGRESSION (r21113-r21143): JavaScript tooltip rendering bug
       
  6664 
       
  6665         Test: fast/repaint/layer-visibility.html
       
  6666 
       
  6667         * rendering/RenderLayer.cpp:
       
  6668         (WebCore::RenderLayer::setHasVisibleContent): Cache the layer's
       
  6669         rects when it changes to visible.
       
  6670 
       
  6671 2007-08-20  Kevin Decker <kdecker@apple.com>
       
  6672 
       
  6673         Reviewed by Anders.
       
  6674 
       
  6675         Fixed: <rdar://problem/5325262> REGRESSION (Tiger-Leopard): PictureTalk plug-in doesn't work
       
  6676 
       
  6677         The problem was that this particular plug-in handles "text/ptf", but WebCore wasn't giving the plug-in a chance to load
       
  6678         any type with "text/"
       
  6679 
       
  6680         * dom/DOMImplementation.cpp:
       
  6681         (WebCore::DOMImplementation::createDocument): Allow plug-ins to once again use "text/" MIME types, but only if the MIME
       
  6682         type is not "text/plain". Disallowing plug-ins to use text/plain prevents plug-ins from hijacking a fundamental type 
       
  6683         that the browser is expected to handle, and also serves as an optimization to prevent loading the plug-in database in 
       
  6684         the common case.
       
  6685 
       
  6686 2007-08-20  Adam Roben  <aroben@apple.com>
       
  6687 
       
  6688         Remove workarounds for <rdar://problem/5386894> now that it's been fixed
       
  6689 
       
  6690         Reviewed by Darin.
       
  6691 
       
  6692         Tests: fast/loader/local-svg-parsed-as-svg.svg
       
  6693                fast/loader/local-xhtml-parsed-as-xhtml.xhtml
       
  6694 
       
  6695         * platform/network/cf/ResourceResponseCFNet.cpp:
       
  6696         (WebCore::ResourceResponse::doUpdateResourceResponse): Removed hackish
       
  6697         workaround.
       
  6698 
       
  6699 2007-08-20  Anders Carlsson  <andersca@apple.com>
       
  6700 
       
  6701         Reviewed by Adam.
       
  6702 
       
  6703         <rdar://problem/5412988>
       
  6704         Crash when visiting http://www.rockonflash.com/blog/?p=58
       
  6705         
       
  6706         * plugins/win/PluginViewWin.cpp:
       
  6707         (WebCore::PluginViewWin::updateWindow):
       
  6708         Just return if the plugin view hasn't been inserted in the hierarchy yet.
       
  6709 
       
  6710 2007-08-20  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  6711 
       
  6712         Reviewed by Zack.
       
  6713 
       
  6714         Do not define svg as ImageMIMEType if we can use ksvg2.
       
  6715 
       
  6716         * platform/MIMETypeRegistry.cpp:
       
  6717         (WebCore::initialiseSupportedImageMIMETypes):
       
  6718 
       
  6719 2007-08-19  Adam Roben  <aroben@apple.com>
       
  6720 
       
  6721         Gtk+ build fix.
       
  6722 
       
  6723         * platform/gdk/TemporaryLinkStubs.cpp: Removed const.
       
  6724 
       
  6725 2007-08-19  Adam Roben  <aroben@apple.com>
       
  6726 
       
  6727         Fix <rdar://5395835> REGRESSION (r24527): Context menu for edit fields is missing "Font & Writing Direction"
       
  6728 
       
  6729         The problem was that ContextMenuItem::setSubMenu was just copying the
       
  6730         HMENU from the ContextMenu passed in on Windows, but that HMENU was
       
  6731         later getting destroyed when the ContextMenu went out of scope.
       
  6732 
       
  6733         I added a new ContextMenu::releasePlatformDescription method that is
       
  6734         used in setSubMenu instead. I think an ultimately better design would
       
  6735         be for setSubMenu to take ownership of the ContextMenu that's passed in
       
  6736         (as should insertItem and appendItem), but I decided to be conservative
       
  6737         and just make the changes needed to fix the bug.
       
  6738 
       
  6739         Reviewed by Darin.
       
  6740 
       
  6741         No test possible.
       
  6742 
       
  6743         * platform/ContextMenu.h: Added releasePlatformDescription.
       
  6744         * platform/gdk/TemporaryLinkStubs.cpp: Added stub implementation.
       
  6745         * platform/mac/ContextMenuMac.mm:
       
  6746         (WebCore::ContextMenu::releasePlatformDescription): Implemented, though
       
  6747         it's never called on this platform.
       
  6748         * platform/qt/ContextMenuQt.cpp:
       
  6749         (WebCore::ContextMenu::releasePlatformDescription): Ditto.
       
  6750         * platform/win/ContextMenuItemWin.cpp:
       
  6751         (WebCore::ContextMenuItem::setSubMenu): Call releasePlatformDescription
       
  6752         since we need to take ownership of the HMENU.
       
  6753         * platform/win/ContextMenuWin.cpp:
       
  6754         (WebCore::ContextMenu::releasePlatformDescription): Implemented.
       
  6755 
       
  6756 2007-08-18  Maciej Stachowiak  <mjs@apple.com>
       
  6757 
       
  6758         Reviewed by Darin.
       
  6759 
       
  6760         - fixed <rdar://problem/5198272> REGRESSION: PLT 1.5% slower due to r21367 (change to start frames with empty documents)
       
  6761         
       
  6762         There were three main cuases of extra time due to creating the initial empty document:
       
  6763         
       
  6764         1) Creating an extra WebHTMLView and swapping it for a new one for each frame created.
       
  6765         2) Parsing the minimal markup for the initial document's contents.
       
  6766         3) Clearing the Window object an extra time and dispatching the corresponding delegate method.
       
  6767         
       
  6768         The WebCore part of the fixes addresses 2 and 3.
       
  6769         
       
  6770         * loader/FrameLoader.cpp:
       
  6771         (WebCore::FrameLoader::init): Don't parse "<html><body>" for the initial
       
  6772         empty document; it turns out not to be needed.
       
  6773         (WebCore::FrameLoader::dispatchWindowObjectAvailable): Don't 
       
  6774         dispatch the delegate if we haven't created a ScriptInterpreter yet.
       
  6775         * bindings/js/kjs_proxy.cpp:
       
  6776         (WebCore::KJSProxy::initScriptIfNeeded): Dispatch the window object
       
  6777         delegate when we first create the interpreter, since that is now done
       
  6778         lazily.
       
  6779         * loader/FrameLoader.h:
       
  6780         (WebCore::FrameLoader::committingFirstRealLoad): Helper for WebKit
       
  6781         to know when to reuse a WebHTMLView.
       
  6782 
       
  6783 2007-08-19  Mitz Pettel  <mitz@webkit.org>
       
  6784 
       
  6785         Reviewed by Adam Roben.
       
  6786 
       
  6787         - fix http://bugs.webkit.org/show_bug.cgi?id=15008
       
  6788           ASSERTION FAILED: !firstLineBox() == !lastLineBox() setting content on image
       
  6789 
       
  6790         Test: fast/images/text-content-crash-2.html
       
  6791 
       
  6792         * html/HTMLImageLoader.cpp:
       
  6793         (WebCore::HTMLImageLoader::setImage): Added a check that the renderer is an
       
  6794         image.
       
  6795         (WebCore::HTMLImageLoader::updateFromElement): Ditto.
       
  6796         (WebCore::HTMLImageLoader::notifyFinished): Ditto.
       
  6797 
       
  6798 2007-08-17  Maciej Stachowiak  <mjs@apple.com>
       
  6799 
       
  6800         Reviewed by Darin.
       
  6801 
       
  6802         - WebCore part of fix to scrollbar suppression hack for Leopard
       
  6803 
       
  6804         * loader/FrameLoader.cpp:
       
  6805         (WebCore::FrameLoader::transitionToCommitted): Suppress scrollbars earlier, so it happens
       
  6806         before any potential view swap.
       
  6807 
       
  6808 2007-08-17  Antti Koivisto  <antti@apple.com>
       
  6809 
       
  6810         Reviewed by Hyatt.
       
  6811         
       
  6812         Fix <rdar://problem/5403773>
       
  6813         CrashTracer: [USER] 88 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::paint + 846
       
  6814 
       
  6815         * rendering/RenderBlock.cpp:
       
  6816         (WebCore::RenderBlock::removePositionedObjects):
       
  6817         
       
  6818         Fix crash in http://www.infobae.com/interior/home.html
       
  6819         Positioned objects removed from m_positionedObjects would in some cases not get added back to any 
       
  6820         positioned objects list. Adding objects happens in block layout but since layout was not invalidated 
       
  6821         correctly in removePositionedObjects() it would not get invoked. As a result some positioned objects 
       
  6822         would stay in layout dirty state leading to crashes and other bad things.
       
  6823         
       
  6824         * rendering/RenderTableSection.cpp:
       
  6825         (WebCore::RenderTableSection::paint):
       
  6826         
       
  6827         Add needLayout() guard to eliminate this class of crashes from release builds. 
       
  6828         Assert commented out for now since one existing layout test can't handle it.
       
  6829 
       
  6830 2007-08-17  Kevin Decker <kdecker@apple.com>
       
  6831 
       
  6832         Code change by Darin, landed and reviewed by me.
       
  6833 
       
  6834         Fixed: <rdar://problem/5252836> Adobe Help Viewer: Japanese characters in the Help Tree structure are shown as garbage
       
  6835         Added fast/encoding/namespace-tolerance.html test.
       
  6836 
       
  6837         * loader/TextResourceDecoder.cpp:
       
  6838         (WebCore::TextResourceDecoder::checkForHeadCharset): Slightly loosen the charset decoder heuristic by tweaking it
       
  6839         to ignore namespaces. This restores compatibility to documents which (1) use namespace prefixes on HTML elements
       
  6840         (2) specify a non-latin charset and (3) contain non-latin characters.
       
  6841         
       
  6842         Added fast/encoding/namespace-tolerance.html test.
       
  6843         
       
  6844 2007-08-17  Anders Carlsson  <andersca@apple.com>
       
  6845 
       
  6846         Reviewed by Dave Hyatt.
       
  6847         
       
  6848         <rdar://problem/5379040>
       
  6849         REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes
       
  6850 
       
  6851         Instantiate plug-ins during the first layout instead of doing so when creating the renderer.
       
  6852         This ensures that the plug-in widget will have a correct initial size.
       
  6853         
       
  6854         * html/HTMLEmbedElement.cpp:
       
  6855         (WebCore::HTMLEmbedElement::getInstance):
       
  6856         Force a layout if the plug-in doesn't have an instance.
       
  6857         
       
  6858         (WebCore::HTMLEmbedElement::attach):
       
  6859         Pass true to updateWidget, causing it to only create a widget if it won't be a plug-in.
       
  6860         
       
  6861         * html/HTMLIFrameElement.cpp:        
       
  6862         (WebCore::HTMLIFrameElement::attach):
       
  6863         Pass false to updateWidget, this will only create subframes anyway.
       
  6864         
       
  6865         * html/HTMLObjectElement.cpp:
       
  6866         (WebCore::HTMLObjectElement::getInstance):
       
  6867         Force a layout if the plug-in doesn't have an instance.
       
  6868         
       
  6869         (WebCore::HTMLObjectElement::attach):
       
  6870         Pass true to updateWidget, causing it to only create a widget if it won't be a plug-in.
       
  6871         
       
  6872         * loader/FrameLoader.cpp:
       
  6873         (WebCore::FrameLoader::loadPlugin):
       
  6874         Get the size from the renderer and pass it to the client.
       
  6875         
       
  6876         * loader/FrameLoaderClient.h:
       
  6877         * page/mac/WebCoreFrameBridge.h:
       
  6878         * platform/graphics/svg/SVGImageEmptyClients.h:
       
  6879         (WebCore::SVGEmptyFrameLoaderClient::createPlugin):
       
  6880         Update declarations.
       
  6881         
       
  6882         * rendering/RenderPart.cpp:
       
  6883         (WebCore::RenderPart::setWidget):
       
  6884         No need to mark the renderer as dirty here.
       
  6885         
       
  6886         * rendering/RenderPartObject.h:
       
  6887         * rendering/RenderPartObject.cpp:
       
  6888         (WebCore::RenderPartObject::updateWidget):
       
  6889         Add a parameter, onlyCreateNonPlugins. If this is true the widget 
       
  6890         will only be created if it's not a plug-in.
       
  6891         
       
  6892         (WebCore::RenderPartObject::layout):
       
  6893         Call updateWidget here if m_widget is 0, causing the plug-in to be instantiated.
       
  6894         
       
  6895 2007-08-17  Oliver Hunt  <oliver@apple.com>
       
  6896 
       
  6897         Reviewed by Maciej.
       
  6898 
       
  6899         http://bugs.webkit.org/show_bug.cgi?id=14189
       
  6900         <rdar://problem/5319511> REPRODUCIBLE CRASH: Canvas createPattern(canvas, ...) crashes on Windows (14189)
       
  6901 
       
  6902         Ensure that we actually retain the CG pattern correctly.
       
  6903 
       
  6904         Credit to Henry Mason <hmason@mac.com> for finding the cause of this.
       
  6905 
       
  6906         * html/CanvasPattern.cpp:
       
  6907         (WebCore::CanvasPattern::~CanvasPattern):
       
  6908         (WebCore::CanvasPattern::createPattern):
       
  6909         * html/CanvasPattern.h:
       
  6910         (WebCore::CanvasPattern::platformImage):
       
  6911 
       
  6912 2007-08-16  Geoffrey Garen  <ggaren@apple.com>
       
  6913 
       
  6914         Build fix. (Maybe?)
       
  6915         
       
  6916         * loader/Cache.cpp:
       
  6917         (WebCore::Cache::pruneLiveResources):
       
  6918         (WebCore::Cache::pruneDeadResources):
       
  6919 
       
  6920 2007-08-16  Justin Garcia  <justin.garcia@apple.com>
       
  6921 
       
  6922         Reviewed by Harrison.
       
  6923 
       
  6924         <rdar://problem/5378473> 
       
  6925         REGRESSION: Undoing a deletion that is part of an open typing command fails to reinsert the caret
       
  6926         
       
  6927         We recently made Undo of a series of deletes select all of the 
       
  6928         characters that were deleted, not just the most recently deleted
       
  6929         character.  But the code that did this set a new starting selection 
       
  6930         after every delete, even those that were part of an open typing 
       
  6931         command that started with character insertions or forward deletes, 
       
  6932         operations that when undone, remove the starting selection being 
       
  6933         set from the document.
       
  6934         
       
  6935         After this change we only set a new starting selection if the open typing
       
  6936         command was opened by a backward delete. The new behavior matches TextEdit.  
       
  6937         We don't do something similar or forward deletes because TextEdit opens 
       
  6938         and closes a new typing command on forward delete (added a FIXME about this).
       
  6939 
       
  6940         * editing/TypingCommand.cpp:
       
  6941         (WebCore::TypingCommand::TypingCommand): Initialize 
       
  6942         m_openedByBackwardDelete.
       
  6943         (WebCore::TypingCommand::forwardDeleteKeyPressed): Added a FIXME about
       
  6944         how in TextEdit, forward deletes open and close a new typing command.
       
  6945         (WebCore::TypingCommand::doApply): Set m_openedByBackwardDelete
       
  6946         appropriately.
       
  6947         (WebCore::TypingCommand::deleteKeyPressed): Only set the starting
       
  6948         selection if this delete is the first one in an open typing command
       
  6949         or one in a series of deletes that opened the typing command.
       
  6950         * editing/TypingCommand.h: Added m_openedByBackwardDelete.
       
  6951 
       
  6952 2007-08-13  Geoffrey Garen  <ggaren@apple.com>
       
  6953 
       
  6954         Reviewed by Dave Hyatt.
       
  6955         
       
  6956         Tweaked the cache eviction model to better balance between live and 
       
  6957         dead resources.
       
  6958         
       
  6959         For the sake of avoiding evictions during the PLT, the old model 
       
  6960         required the sum of dead and live resources to grow to twice the cache 
       
  6961         capacity before evicting, and would then evict dead or live down to 0 
       
  6962         if necessary. This was a too-high high water mark, which would nullify 
       
  6963         much of the value of eviction, and a too-low low water mark, which 
       
  6964         would nullify much of the value of the LRU-SP strategy.
       
  6965         
       
  6966         This patch changes the model in 3 ways.
       
  6967         
       
  6968         1. The new model for dead resources is a flexible window with a fixed 
       
  6969         minimum and maximum. The dead resource window is big when live resource 
       
  6970         pressure is small, and vice versa. This has the immediate advantage of
       
  6971         cutting the high water mark by up to 50%. It also enables the following
       
  6972         tunable optimizations in future patches:
       
  6973             a. A dead resource limit of 0 for clients who want that. (Just set
       
  6974             the fixed maximum to 0.)
       
  6975             b. A much higher low water mark. (Just set the fixed minimum to, 
       
  6976             say, 25% of the cache's capacity.)
       
  6977             c. A much lower high water mark for users who browse simple pages
       
  6978             in one tab. (Just set the fixed maximum to, say, 50% of the cache's
       
  6979             capacity.)
       
  6980         
       
  6981         I plan to make the changes that actually take advantage of these 
       
  6982         tunable optimizations in another check-in.
       
  6983 
       
  6984         The new model won't hurt the PLT because it will notice the PLT's low
       
  6985         live resource size, and up the dead resource capacity in response. For
       
  6986         the same reason, the new model should establish a good balance in 
       
  6987         real-world use.
       
  6988         
       
  6989         2. Live resource eviction is now based on size(), not encodedSize().
       
  6990         So, a page with lots of large, encoded images will start evicting 
       
  6991         resources, if necessary, even before all the images paint. This allows 
       
  6992         you to more accurately stipulate an exact high water mark.
       
  6993         
       
  6994         3. When pruning, prune to a small percentage below capacity, to avoid
       
  6995         just having to prune again immediately.
       
  6996 
       
  6997         Layout tests pass. PLT shows no regression.
       
  6998 
       
  6999         * history/PageCache.cpp:
       
  7000         (WebCore::PageCache::releaseAutoreleasedPagesNow): Updated for rename.
       
  7001 
       
  7002         * loader/Cache.cpp: Implemented the algorithm explained above.
       
  7003         * loader/Cache.h: Removed explicit tracking of decoded data size, since
       
  7004         it was unused.
       
  7005 
       
  7006         * loader/CachedResource.cpp: ditto on tracking of decoded data size
       
  7007 
       
  7008 2007-08-16  Darin Adler  <darin@apple.com>
       
  7009 
       
  7010         Reviewed by Tim Hatcher.
       
  7011 
       
  7012         - fix <rdar://problem/5415029> In Mail, a crash occurs at WebCore::Node::isDescendantOf()
       
  7013           when attempting to delete a selection in a table
       
  7014 
       
  7015         The bug was caused by createMarkup trying to operate on a range that
       
  7016         has an endpoint in the delete button DOM, because it removes that DOM
       
  7017         during its operation! Still working on a regression test -- it's hard
       
  7018         to make the kind of bad selection that's needed with the DOM, so I might
       
  7019         have to use the eventSender.
       
  7020 
       
  7021         * editing/DeleteButtonController.h: Made some of the identifiers private.
       
  7022         We can make them public if we need to use them. Added a getter function
       
  7023         for the container element so we can figure out if a given node is inside
       
  7024         the DOM added for the delete button.
       
  7025 
       
  7026         * editing/markup.cpp:
       
  7027         (WebCore::moveEndpointsBeforeNode): Added. General purpose helper function
       
  7028         that moves endpoints of a range to before a given node -- we do this before
       
  7029         removing the delete button, so the endpoint is where the delete button was,
       
  7030         rather than having an endpoint that's not in the document.
       
  7031         (WebCore::createMarkup): Always return empty string, not null string.
       
  7032         Get the document by calling ownerDocument on the range rather than getting
       
  7033         the document of the commonAncestorContainer. That's because we need to
       
  7034         get at the delete button before calling commonAncestorContainer. Call
       
  7035         moveEndpointsBeforeNode to move the range endpoints out of the delete
       
  7036         button interface before calling disable() which will remove it from the
       
  7037         DOM if it's in there. Added an early return for the case where commonAncestor
       
  7038         is non-0. If this happens, we would crash later because pastEndNode would
       
  7039         not be in the tree. This change alone would prevent the crash, but we'd get
       
  7040         bad markup, so we need the moveEndpointsBeforeNode fix. Added null checks
       
  7041         for the frame to the range version as in the single-node version so this
       
  7042         won't crash immediately on documents that are not in a frame. For the
       
  7043         single-node version, added a check if a ndoe of 0 and a node inside the
       
  7044         delete button user interface, and return the empty string for those cases.
       
  7045 
       
  7046 2007-08-16  Justin Garcia  <justin.garcia@apple.com>
       
  7047 
       
  7048         Reviewed by Maciej.
       
  7049         
       
  7050         <rdar://problem/5378847> After creating and removing a ToDo, the caret disappears as soon as I start to type
       
  7051         
       
  7052         * editing/InsertTextCommand.cpp:
       
  7053         (WebCore::InsertTextCommand::input): A whitespace text node inserted by Mail
       
  7054         when a ToDo is removed is completely removed by deleteInsignificantWhitespace,
       
  7055         and since it contains the text insertion position, insertion fails.
       
  7056         Save the position before the node where text insertion will occur,
       
  7057         and if that node is removed, use the saved position for insertion.
       
  7058 
       
  7059 2007-08-16  Darin Adler  <darin@apple.com>
       
  7060 
       
  7061         Reviewed by Adele.
       
  7062 
       
  7063         - fix <rdar://problem/5413488> REGRESSION: every DOM element is about 40
       
  7064           bytes bigger because it has a Timer
       
  7065 
       
  7066         Moved the timer to the document from the element.
       
  7067 
       
  7068         * dom/Document.h: Made frame() inline. Added updateFocusApperanceSoon(),
       
  7069         cancelFocusAppearanceUpdate(), m_updateFocusAppearanceTimer,
       
  7070         clearXMLVersion(), and updateFocusAppearanceTimerFired(). Also made
       
  7071         everything that was previously protected be private instead.
       
  7072         * dom/Document.cpp:
       
  7073         (WebCore::Document::Document): Initialize m_updateFocusAppearanceTimer.
       
  7074         (WebCore::Document::updateFocusAppearanceSoon): Added. Starts timer.
       
  7075         (WebCore::Document::cancelFocusAppearanceUpdate): Added. Stops timer.
       
  7076         (WebCore::Document::updateFocusAppearanceTimerFired): Added. If the
       
  7077         focused node is a focusable element, then calls
       
  7078         updateFocusAppearance(false) on it.
       
  7079 
       
  7080         * dom/Element.h: Removed default value of the boolean parameter to
       
  7081         updateFocusAppareance. Removed needsFocusAppearanceUpdate(),
       
  7082         setNeedsFocusAppearanceUpdate(), updateFocusAppearanceTimerFired(),
       
  7083         stopUpdateFocusAppearanceTimer(), m_updateFocusAppearanceTimer, and
       
  7084         m_needsFocusAppearanceUpdate. Added
       
  7085         updateFocusAppearanceSoonAfterAttach() and cancelFocusAppearanceUpdate().
       
  7086         * dom/Element.cpp:
       
  7087         (WebCore::ElementRareData::ElementRareData): Added initializer for
       
  7088         m_needsFocusAppearanceUpdateSoonAfterAttach.
       
  7089         (WebCore::Element::Element): Removed initializers for
       
  7090         m_updateFocusAppearanceTimer and m_needsFocusAppearanceUpdate.
       
  7091         (WebCore::Element::attach): Updated code that starts the focus
       
  7092         appearance timer to instead call updateFocusAppearanceSoon() on the
       
  7093         document.
       
  7094         (WebCore::Element::detach): Replaced call to
       
  7095         stopUpdateFocusAppearanceTimer with call to cancelFocusAppearanceUpdate.
       
  7096         (WebCore::Element::focus): Added check for node that's already focused,
       
  7097         to match the logic that's in the derived classes. This makes it safe for
       
  7098         us to remove the override in the derived classes. Also replaced the code
       
  7099         that called setNeedsFocusAppearanceUpdate(true) with code to set the
       
  7100         rare data flag m_needsFocusAppearanceUpdateSoonAfterAttach and added a
       
  7101         call to cancelFocusAppearanceUpdate() in the case where there's no focus
       
  7102         appearance update.
       
  7103         (WebCore::Element::blur): Replaced call to
       
  7104         stopUpdateFocusAppearanceTimer with call to cancelFocusAppearanceUpdate.
       
  7105         (WebCore::Element::cancelFocusAppearanceUpdate): Added. Sets
       
  7106         m_needsFocusAppearanceUpdateSoonAfterAttach to false, and then calls
       
  7107         cancelFocusAppearanceUpdate() on the document, but only if the element
       
  7108         is the focused node of the document.
       
  7109 
       
  7110         * html/HTMLDocument.cpp:
       
  7111         (WebCore::HTMLDocument::HTMLDocument): Replaced code that sets
       
  7112         m_xmlVersion directly with a call to a new inline clearXMLVersion()
       
  7113         function.
       
  7114         (WebCore::HTMLDocument::setCookie): Replaced use of m_policyBaseURL with
       
  7115         policyBaseURL().
       
  7116         (WebCore::HTMLDocument::createTokenizer): Replaced uses of m_frame with
       
  7117         frame().
       
  7118         (WebCore::HTMLDocument::determineParseMode): Replaced code that sets
       
  7119         pMode and hMode directly with calls to setParseMode and setHTMLMode.
       
  7120         Replaced use of m_styleSelector with styleSelector().
       
  7121 
       
  7122         * html/HTMLInputElement.h: Removed now-unneed override of focus().
       
  7123         Removed default value of the boolean parameter to updateFocusAppareance.
       
  7124         * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateFocusAppearance):
       
  7125         Pass the restorePreviousSelection boolean through -- while it's ignored,
       
  7126         it no longer has a default value.
       
  7127 
       
  7128         * html/HTMLTextAreaElement.h: Removed now-unneed override of focus().
       
  7129         Removed default value of the boolean parameter to updateFocusAppareance.
       
  7130         * html/HTMLTextAreaElement.cpp: Ditto.
       
  7131 
       
  7132         * WebCore.exp: Removed the Document::frame() symbol, since it's now inline.
       
  7133 
       
  7134 2007-08-15  Antti Koivisto  <antti@apple.com>
       
  7135 
       
  7136         Reviewed by Maciej.
       
  7137         
       
  7138         Fix <rdar://problem/5388936>
       
  7139         Crash while setting display:none for a table cell with selection
       
  7140         
       
  7141         Super class destroy() could (through some selection code in removeChild()) trigger section recalc 
       
  7142         in middle of RenderTableCell::destroy(), cleaning section dirty bit. This would later crash in 
       
  7143         layout since cell grid would still have refence to the dead cell.
       
  7144         
       
  7145         Ensure table sections are dirty when leaving destroy method.
       
  7146         
       
  7147         I can't figure out tests for row and section changes but they look like
       
  7148         they could crash in similar way as cell.
       
  7149 
       
  7150         * rendering/RenderTableCell.cpp:
       
  7151         (WebCore::RenderTableCell::destroy):
       
  7152         * rendering/RenderTableRow.cpp:
       
  7153         (WebCore::RenderTableRow::destroy):
       
  7154         * rendering/RenderTableSection.cpp:
       
  7155         (WebCore::RenderTableSection::destroy):
       
  7156 
       
  7157 2007-08-15  Maciej Stachowiak  <mjs@apple.com>
       
  7158 
       
  7159         Reviewed by Geoff.
       
  7160 
       
  7161         <rdar://problem/5389696> leak of 32-byte NSData object (and more?) in WebIconDatabase code path with each refresh of http://www.apple.com
       
  7162         
       
  7163         * platform/graphics/BitmapImage.h: Use RetainPtr for m_nsImage and m_tiffRep
       
  7164         * platform/graphics/mac/ImageMac.mm:
       
  7165         (WebCore::BitmapImage::initPlatformData): No need to do anything now
       
  7166         (WebCore::BitmapImage::invalidatePlatformData): Simplify
       
  7167         (WebCore::BitmapImage::getTIFFRepresentation): Use RetainPtr to avoid leaks
       
  7168         (WebCore::BitmapImage::getNSImage): Use RetainPtr to avoid leaks
       
  7169 
       
  7170 2007-08-15  Darin Adler  <darin@apple.com>
       
  7171 
       
  7172         Reviewed by Anders.
       
  7173 
       
  7174         - fix <rdar://problem/5094895> REGRESSION (r19094): JavaScript timers don't
       
  7175           work inside showModalDialog; caret also doesn't blink
       
  7176 
       
  7177         * platform/Timer.h: Added fireTimersInNestedEventLoop.
       
  7178         * platform/Timer.cpp:
       
  7179         (WebCore::TimerBase::fireTimers): Added code to exit if the timersReadyToFire
       
  7180         is cleared. This indicates that someone fired the timers in the nested event
       
  7181         loop, so we should not fire any more timers ourselves.
       
  7182         (WebCore::TimerBase::fireTimersInNestedEventLoop): Added. Sets timersReadyToFire
       
  7183         to 0 so we won't return early and do nothing if the shared timer first. Then
       
  7184         calls updateSharedTimer() so the shared timer will get scheduled as needed based
       
  7185         on any pending timers.
       
  7186 
       
  7187         * page/Chrome.cpp: (WebCore::Chrome::runModal): Call
       
  7188         fireTimersInNestedEventLoop before calling runModal on the client.
       
  7189 
       
  7190         * manual-tests/modal-dialog.html: Added a test that uses a timeout.
       
  7191         * manual-tests/show-modal-dialog-test.html: Fixed a typo.
       
  7192 
       
  7193 2007-08-15  Justin Garcia  <justin.garcia@apple.com>
       
  7194 
       
  7195         Reviewed by Darin.
       
  7196         
       
  7197         http://bugs.webkit.org/show_bug.cgi?id=14971
       
  7198         REGRESSION: cannot select reporter's e-mail in bugzilla
       
  7199 
       
  7200         * page/EventHandler.cpp:
       
  7201         (WebCore::EventHandler::canMouseDragExtendSelect): Allow drag-selecting inside
       
  7202         a -webkit-user-select:ignore region.
       
  7203 
       
  7204 2007-08-15  Beth Dakin  <bdakin@apple.com>
       
  7205 
       
  7206         Reviewed by Hyatt.
       
  7207 
       
  7208         Rolling back in. I made a silly mistake in XMLTokenizer that caused 
       
  7209         this patch to crash SVG tests. It's fixed now!
       
  7210 
       
  7211         Refactor of change for <rdar://problem/5404899> REGRESSION: Mail 
       
  7212         crash in WebCore::FontFallbackList::fontDataAt() after dragging 
       
  7213         image into text multiple times
       
  7214 
       
  7215         The original fix that I made last night prevents the pending style 
       
  7216         sheet count from being incremented until the element is in the 
       
  7217         document. This fix prevents the style sheet from loading at all 
       
  7218         until it is in the document.
       
  7219 
       
  7220         Here is the fix.
       
  7221         * dom/StyleElement.cpp:
       
  7222         (WebCore::StyleElement::insertedIntoDocument): Call process.
       
  7223         (WebCore::StyleElement::removedFromDocument): This can be reverted 
       
  7224         to its original state before my patch last night.
       
  7225         (WebCore::StyleElement::process): childrenChanged is now called 
       
  7226         process. Return early if your not in the document.
       
  7227         (WebCore::StyleElement::createSheet): Revert change from last 
       
  7228         night. The inDocument check is now in caller childrenChanged.
       
  7229         * dom/StyleElement.h: insertedIntoDocument() must now accept an 
       
  7230         element in addition to a document.
       
  7231 
       
  7232         This is an optimization to prevent calling updateStyleSelector() 
       
  7233         too frequently.
       
  7234         * dom/XMLTokenizer.cpp:
       
  7235         (WebCore::XMLTokenizer::startElementNs):
       
  7236         * html/HTMLStyleElement.cpp:
       
  7237         (WebCore::HTMLStyleElement::HTMLStyleElement):
       
  7238         (WebCore::HTMLStyleElement::finishedParsing):
       
  7239         (WebCore::HTMLStyleElement::insertedIntoDocument):
       
  7240         (WebCore::HTMLStyleElement::childrenChanged):
       
  7241         (WebCore::HTMLStyleElement::sheetLoaded):
       
  7242         * html/HTMLStyleElement.h:
       
  7243         * ksvg2/svg/SVGStyleElement.cpp:
       
  7244         (WebCore::SVGStyleElement::SVGStyleElement):
       
  7245         (WebCore::SVGStyleElement::finishedParsing):
       
  7246         (WebCore::SVGStyleElement::insertedIntoDocument):
       
  7247         (WebCore::SVGStyleElement::childrenChanged):
       
  7248         (WebCore::SVGStyleElement::sheetLoaded):
       
  7249         * ksvg2/svg/SVGStyleElement.h:
       
  7250         (WebCore::SVGStyleElement::setCreatedByParser):
       
  7251 
       
  7252         This is a name change. Document::stylesheetLoaded() 
       
  7253         is now Document::removePendingSheet()
       
  7254         * dom/Document.cpp:
       
  7255         (WebCore::Document::removePendingSheet):
       
  7256         * dom/Document.h:
       
  7257         * dom/ProcessingInstruction.cpp:
       
  7258         (WebCore::ProcessingInstruction::sheetLoaded):
       
  7259         * html/HTMLLinkElement.cpp:
       
  7260         (WebCore::HTMLLinkElement::~HTMLLinkElement):
       
  7261         (WebCore::HTMLLinkElement::setDisabledState):
       
  7262         (WebCore::HTMLLinkElement::process):
       
  7263         (WebCore::HTMLLinkElement::sheetLoaded):
       
  7264         * page/Frame.cpp:
       
  7265         (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader):
       
  7266         (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
       
  7267 
       
  7268         This is another name change. closeRenderer() is now 
       
  7269         finishedParsing()
       
  7270         * dom/Node.h:
       
  7271         (WebCore::Node::finishedParsing):
       
  7272         * dom/XMLTokenizer.cpp:
       
  7273         (WebCore::XMLTokenizer::endElementNs):
       
  7274         (WebCore::):
       
  7275         * html/HTMLAppletElement.cpp:
       
  7276         (WebCore::HTMLAppletElement::finishedParsing):
       
  7277         * html/HTMLAppletElement.h:
       
  7278         * html/HTMLGenericFormElement.cpp:
       
  7279         (WebCore::HTMLFormControlElementWithState::finishedParsing):
       
  7280         * html/HTMLGenericFormElement.h:
       
  7281         * html/HTMLObjectElement.cpp:
       
  7282         (WebCore::HTMLObjectElement::finishedParsing):
       
  7283         * html/HTMLObjectElement.h:
       
  7284         * html/HTMLParser.cpp:
       
  7285         (WebCore::HTMLParser::insertNode):
       
  7286         (WebCore::HTMLParser::popOneBlockCommon):
       
  7287         * html/HTMLScriptElement.cpp:
       
  7288         (WebCore::HTMLScriptElement::finishedParsing):
       
  7289         * html/HTMLScriptElement.h:
       
  7290         (WebCore::HTMLStyleElement::setCreatedByParser):
       
  7291         * ksvg2/svg/SVGAnimationElement.cpp:
       
  7292         (WebCore::SVGAnimationElement::finishedParsing):
       
  7293         * ksvg2/svg/SVGAnimationElement.h:
       
  7294         * ksvg2/svg/SVGElement.cpp:
       
  7295         (WebCore::SVGElement::finishedParsing):
       
  7296         * ksvg2/svg/SVGElement.h:
       
  7297 
       
  7298 2007-08-15  David Harrison  <harrison@apple.com>
       
  7299 
       
  7300         Reviewed by Antti Koivisto.
       
  7301 
       
  7302         <rdar://problem/5411803> Bumpercar crashes when loading a partial URL (FrameLoader::receivedMainResourceError())
       
  7303 
       
  7304         * loader/MainResourceLoader.cpp:
       
  7305         (WebCore::MainResourceLoader::receivedError):
       
  7306         Nil check for the FrameLoader.
       
  7307 
       
  7308 2007-08-14  Steve Falkenburg  <sfalken@apple.com>
       
  7309 
       
  7310         <rdar://problem/5411482> Windows user agent language always returns "en"
       
  7311         
       
  7312         Implement defaultLanguage().
       
  7313 
       
  7314         Reviewed by Oliver.
       
  7315 
       
  7316         * WebCore.vcproj/WebCore.vcproj: Added Language.cpp.
       
  7317         * platform/win/Language.cpp: Added.
       
  7318         (WebCore::localeInfo): Added.
       
  7319         (WebCore::defaultLanguage): Added.
       
  7320         * platform/win/TemporaryLinkStubs.cpp: Remove defaultLanguage stub.
       
  7321 
       
  7322 2007-08-14  Sam Weinig  <sam@webkit.org>
       
  7323 
       
  7324         Reviewed by Geoff and Oliver.
       
  7325 
       
  7326         Fix for <rdar://problem/5267870>
       
  7327         Mangleme: Reproducible assertion failure in -[WebCoreFrameBridge installInFrame:]
       
  7328 
       
  7329         - Change embed/plugin code path to detach the frame on willRemove instead of detach.
       
  7330           This matches what frame and iframe do.
       
  7331 
       
  7332         Test: http/tests/misc/embedCrasher.html
       
  7333 
       
  7334         * html/HTMLPlugInElement.cpp:
       
  7335         (WebCore::HTMLPlugInElement::willRemove):
       
  7336         * html/HTMLPlugInElement.h:
       
  7337 
       
  7338 2007-08-14  Adele Peterson  <adele@apple.com>
       
  7339 
       
  7340         Reviewed by Maciej.
       
  7341 
       
  7342         Fix for <rdar://problem/5370059> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)
       
  7343 
       
  7344         This change makes -webkit-user-select an inherited css property.  For "user-select: none" we were already 
       
  7345         acting like it was an inheritable property, where we let user-select:text on the children override its parent's user-select:none.
       
  7346         By making user-select really inherited (instead of inherited for some values), we eliminate the need for crawling up the tree to see 
       
  7347         if an ancestor has user-select ignore set.
       
  7348 
       
  7349         * page/EventHandler.cpp: (WebCore::EventHandler::canMouseDownStartSelect):
       
  7350           Now that user-select is inherited, you don't need to walk up the render tree looking for ancestors with user-select:ignore set.
       
  7351 
       
  7352         * css/CSSStyleSelector.cpp: Eliminate SELECT_AUTO.
       
  7353         (WebCore::CSSStyleSelector::adjustRenderStyle):
       
  7354         (WebCore::CSSStyleSelector::applyProperty):
       
  7355         * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
  7356 
       
  7357         * rendering/RenderStyle.h:
       
  7358         (WebCore::): Eliminate SELECT_AUTO.  Make userSelect inherited.
       
  7359         (WebCore::RenderStyle::userSelect):
       
  7360         (WebCore::RenderStyle::setUserSelect):
       
  7361         (WebCore::RenderStyle::initialUserSelect):
       
  7362         * rendering/RenderStyle.cpp:
       
  7363         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
       
  7364         (WebCore::StyleRareNonInheritedData::operator==):
       
  7365         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
       
  7366         (WebCore::StyleRareInheritedData::operator==):
       
  7367         (WebCore::RenderStyle::diff):
       
  7368 
       
  7369 2007-08-15  Peter Kasting  <zerodpx@gmail.org>
       
  7370 
       
  7371         Reviewed by Darin.
       
  7372         
       
  7373         http://bugs.webkit.org/show_bug.cgi?id=14967 part 1 - Eliminate most implicit
       
  7374         conversions of wtf::Vector<T> to T* by explicitly calling .data()
       
  7375 
       
  7376         * html/HTMLSelectElement.cpp:
       
  7377         (WebCore::HTMLSelectElement::saveState):
       
  7378         * platform/KURL.cpp:
       
  7379         (WebCore::KURL::KURL):
       
  7380         (WebCore::KURL::init):
       
  7381         (WebCore::KURL::decode_string):
       
  7382         (WebCore::KURL::parse):
       
  7383         (WebCore::KURL::encode_string):
       
  7384         * platform/cf/KURLCFNet.cpp:
       
  7385         (WebCore::KURL::KURL):
       
  7386         * platform/mac/KURLMac.mm:
       
  7387         (WebCore::KURL::KURL):
       
  7388         * rendering/RenderFrameSet.cpp:
       
  7389         (WebCore::RenderFrameSet::layOutAxis):
       
  7390 
       
  7391 2007-08-14  Ricci Adams  <iccir@apple.com>
       
  7392 
       
  7393         Reviewed by Darin, Hyatt.
       
  7394 
       
  7395         - fix <rdar://problem/5407795> -apple-line-clamp should never display less than one line
       
  7396 
       
  7397         * rendering/RenderFlexibleBox.cpp:(WebCore::RenderFlexibleBox::layoutVerticalBox): Use
       
  7398         max to make sure it never computes a minimum of less than one line.
       
  7399 
       
  7400 2007-08-14  Brady Eidson  <beidson@apple.com>
       
  7401 
       
  7402         Reviewed by Darin, John, Maciej, Oliver, and Tim
       
  7403 
       
  7404         <rdar://problem/5394708> - Crash on launch with corrupt icon database
       
  7405 
       
  7406         The main part of the fix is to not disable SQLite's default level of protection - to leave the sync options at their normal,
       
  7407         mostly safe levels.  
       
  7408 
       
  7409         But in case lightning strikes at the exact right moment and someone ends up with a corrupt database, add some support code to
       
  7410         detect that condition and recover from it.  
       
  7411 
       
  7412         This is mainly accomplished by exposing the "PRAGMA integrity_check;" facilities of sqlite through IconDatabase SPI as well as
       
  7413         running that integrity check if a journal file is detected at launch (a strong indication that the last quit was not clean).
       
  7414         There's also a method exposed to allow clients to tell the icon database "I suspect something bad happened, please check integrity"
       
  7415 
       
  7416         * loader/icon/IconDatabase.cpp:
       
  7417         (WebCore::IconDatabase::checkIntegrityBeforeOpening): Allow clients to suggest an integrity check
       
  7418         (WebCore::IconDatabase::open): Add a check to see if the journal file for the database exists.  If it does, run the integrity
       
  7419           check.  Also run the check if a client has suggested it to be necessary.
       
  7420           If the integrity-check fails, we sadly have to destroy the database and recreate from scratch.
       
  7421           Also - quite importantly - do not adjust the default sync preferences for the SQLDatabase.  They were an optimization that 
       
  7422           might have been valid at one time but no longer affects any benchmarks we care about.
       
  7423         (WebCore::IconDatabase::checkIntegrity): Perform the SQLite integrity_check pragma
       
  7424         * loader/icon/IconDatabase.h:
       
  7425 
       
  7426         * loader/icon/IconDatabaseNone.cpp:
       
  7427         (WebCore::IconDatabase::checkIntegrity): Keep IconDatabaseNone users building
       
  7428         (WebCore::IconDatabase::checkIntegrityBeforeOpening): Ditto
       
  7429 
       
  7430         * loader/icon/SQLDatabase.cpp:
       
  7431         (WebCore::SQLDatabase::open): Make a copy of the path string so we don't accidentally mutate anyone else's string on ::close()
       
  7432 
       
  7433         * platform/FileSystem.h: Added. Begin a long-needed platform file system abstraction
       
  7434         * platform/mac/FileSystemMac.mm: Added.
       
  7435         (WebCore::fileExists): Check if a file exists
       
  7436         (WebCore::deleteFile): Delete a file
       
  7437 
       
  7438         * platform/gdk/TemporaryLinkStubs.cpp:
       
  7439         (WebCore::fileExists):
       
  7440         (WebCore::deleteFile):
       
  7441         * platform/qt/TemporaryLinkStubs.cpp:
       
  7442         (WebCore::fileExists):
       
  7443         (WebCore::deleteFile):
       
  7444         * platform/win/TemporaryLinkStubs.cpp:
       
  7445         (WebCore::fileExists):
       
  7446         (WebCore::deleteFile):
       
  7447 
       
  7448         * WebCore.exp:
       
  7449         * WebCore.xcodeproj/project.pbxproj:
       
  7450 
       
  7451 2007-08-14  Jon Honeycutt  <jhoneycutt@apple.com>
       
  7452 
       
  7453         Reviewed by Steve.
       
  7454 
       
  7455         Build fix for Windows.
       
  7456 
       
  7457         * html/HTMLFormElement.cpp:
       
  7458 
       
  7459 2007-08-14  George Staikos  <staikos@kde.org>
       
  7460 
       
  7461         Only connect the menu signal once.
       
  7462 
       
  7463         * platform/qt/ContextMenuQt.cpp:
       
  7464         (WebCore::ContextMenu::ContextMenu):
       
  7465         (WebCore::ContextMenu::insertItem):
       
  7466 
       
  7467 2007-08-14  Justin Garcia  <justin.garcia@apple.com>
       
  7468 
       
  7469         Reviewed by Tim.
       
  7470 
       
  7471         <rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element
       
  7472 
       
  7473         * editing/DeleteButtonController.cpp:
       
  7474         (WebCore::DeleteButtonController::show): Use -webkit-user-select:ignore for
       
  7475         the deletion UI.
       
  7476 
       
  7477 2007-08-14  Antti Koivisto  <antti@apple.com>
       
  7478 
       
  7479         Reviewed by Darin.
       
  7480         
       
  7481         Fix <rdar://problem/5143183>
       
  7482         Air Mail postmark shows up wrong in Firefox due to use of CSS background-position-x/y
       
  7483         
       
  7484         Safari was using non-standard background-position-x/y properties when serializing style, both normal 
       
  7485         and computed. As a result Safari generated CSS would not render correctly in Firefox. 
       
  7486         
       
  7487         Use standard background-position property instead.
       
  7488 
       
  7489         * css/CSSComputedStyleDeclaration.cpp:
       
  7490         (WebCore::):
       
  7491         * css/CSSMutableStyleDeclaration.cpp:
       
  7492         (WebCore::CSSMutableStyleDeclaration::cssText):
       
  7493 
       
  7494 2007-08-14  Sam Weinig  <sam@webkit.org>
       
  7495 
       
  7496         Reviewed by Brady and Dr. Harrison.
       
  7497 
       
  7498         Fix typo.  'whitespace' property is spelled 'white-space'.
       
  7499 
       
  7500         * page/inspector/inspector.css:
       
  7501 
       
  7502 2007-08-13  Beth Dakin  <bdakin@apple.com>
       
  7503 
       
  7504         Reviewed by Maciej.
       
  7505 
       
  7506         Fix for <rdar://problem/5404899> REGRESSION: Mail crash in 
       
  7507         WebCore::FontFallbackList::fontDataAt() after dragging image into 
       
  7508         text multiple times
       
  7509 
       
  7510         We were crashing because style information was not up-to-date. This 
       
  7511         patch fixes the problem in two ways:
       
  7512 
       
  7513         Style information was not up to date at the time of the crash 
       
  7514         because the document thought there was still a pending style sheet. 
       
  7515         The pending style sheet counter was incremented when a call to 
       
  7516         cloneNode from Mail cloned a style node with an imported style 
       
  7517         sheet. Because Mail disables the cache, the style sheet did not 
       
  7518         load immediately for the cloned node, and we do not check again to 
       
  7519         see if it has loaded in time to decrement the pending style sheet 
       
  7520         counter before the crash point. The fix here is only to increment 
       
  7521         the pending style sheet counter for elements that are already in 
       
  7522         the document.
       
  7523         * dom/StyleElement.cpp:
       
  7524         (WebCore::StyleElement::insertedIntoDocument): If we have a CSS 
       
  7525         style sheet that is currently loading, increment the pending style 
       
  7526         sheet counter. This should keep the counter accurate in the case 
       
  7527         where a style node is cloned and then immediately inserted into the 
       
  7528         document.
       
  7529         (WebCore::StyleElement::removedFromDocument): If we have a CSS 
       
  7530         style sheet that is currently loading, decrement the pending style 
       
  7531         sheet count. This is required to keep the correct balance, given 
       
  7532         the change above.
       
  7533         (WebCore::StyleElement::createSheet): Only addPendingSheet() and 
       
  7534         checkLoaded() if we are in the document.
       
  7535 
       
  7536         Here is Darin's original fix. It seems worth keeping this fix too. 
       
  7537         Font style information should not cause a crash if there are still 
       
  7538         pending style sheets. This is good belt-and-suspenders in case 
       
  7539         there is another way to run into this bug with a wacky timing 
       
  7540         issue.
       
  7541         * css/CSSStyleSelector.cpp:
       
  7542         (WebCore::CSSStyleSelector::styleForElement): Update the font.
       
  7543 
       
  7544 2007-08-13  Alexey Proskuryakov  <ap@webkit.org>
       
  7545 
       
  7546         Reviewed by Darin.
       
  7547 
       
  7548         http://bugs.webkit.org/show_bug.cgi?id=14635
       
  7549         rdar://problem/5340188
       
  7550         Uploading file with non-ASCII character in path fails
       
  7551 
       
  7552         File upload cannot be tested in DumpRenderTree.
       
  7553 
       
  7554         * html/HTMLFormElement.cpp:
       
  7555         (WebCore::pathGetFilename): A cross-platform helper that extracts a file name from a path.
       
  7556         (WebCore::HTMLFormElement::formData): Use the above helper instead of code that doesn't
       
  7557         work on Windows.
       
  7558 
       
  7559 2007-08-13  Alexey Proskuryakov  <ap@webkit.org>
       
  7560 
       
  7561         Reviewed by Darin.
       
  7562 
       
  7563         http://bugs.webkit.org/show_bug.cgi?id=14951
       
  7564         REGRESSION: page interpreted as UTF-8 because of stray <?xml> after <head>
       
  7565 
       
  7566         Test: fast/encoding/misplaced-xml-declaration.html
       
  7567 
       
  7568         * loader/TextResourceDecoder.cpp:
       
  7569         (WebCore::TextResourceDecoder::checkForHeadCharset): Only honor XML declaration
       
  7570         at the very beginning of the file.
       
  7571 
       
  7572 2007-08-13  Oliver Hunt  <oliver@apple.com>
       
  7573 
       
  7574         rs=sam
       
  7575 
       
  7576         Correct accidentally modified code.
       
  7577 
       
  7578         * platform/mac/FontDataMac.mm:
       
  7579         (WebCore::FontData::platformInit):
       
  7580 
       
  7581 2007-08-13  Adele Peterson  <adele@apple.com>
       
  7582 
       
  7583         Reviewed by Brady.
       
  7584 
       
  7585         Fix for http://bugs.webkit.org/show_bug.cgi?id=14746
       
  7586         <rdar://problem/5401041> REGRESSION: Form state not saved for forms that submit via HTTPS even if they do not contain a password field
       
  7587 
       
  7588         * loader/FrameLoader.cpp: (WebCore::FrameLoader::saveDocumentState): Restore our old behavior that will save form state for secure forms.
       
  7589           This will also match Firefox behavior.
       
  7590 
       
  7591         * dom/Document.cpp: Removed secureFormAdded(), secureFormRemoved(), hasSecureForm() which are no longer used.
       
  7592         * dom/Document.h:
       
  7593         * html/HTMLFormElement.cpp:
       
  7594         (WebCore::HTMLFormElement::attach):
       
  7595         (WebCore::HTMLFormElement::parseMappedAttribute):
       
  7596 
       
  7597 2007-08-13  Oliver Hunt  <oliver@apple.com>
       
  7598 
       
  7599         Reviewed by Maciej.
       
  7600 
       
  7601         <rdar://problem/5386183> REGRESSION (9A504-9A508): Underline of inline hole is too thin 
       
  7602         on Japanese DotMac page
       
  7603         
       
  7604         Hack the line metrics for the Hiragino font families so that they always allow space for
       
  7605         the marked text underline.
       
  7606         
       
  7607         * platform/mac/FontDataMac.mm:
       
  7608         (WebCore::FontData::platformInit):
       
  7609 
       
  7610 2007-08-13  David Hyatt  <hyatt@apple.com>
       
  7611 
       
  7612         Reviewed by aroben
       
  7613  
       
  7614         <rdar://problem/5400446> messed up content on calendar.yahoo.com and my.yahoo.com
       
  7615 
       
  7616         Fix some more bad assumptions about <html> being the first child of the document now that we
       
  7617         properly support HTML5's model (where a comment node preceding <html> will in fact be its sibling).
       
  7618 
       
  7619         * html/HTMLParser.cpp:
       
  7620         (WebCore::HTMLParser::handleError):
       
  7621         (WebCore::HTMLParser::createHead):
       
  7622 
       
  7623 2007-08-13  Justin Garcia  <justin.garcia@apple.com>
       
  7624 
       
  7625         Reviewed by Darin.
       
  7626         
       
  7627         <rdar://problem/5333725> -webkit-user-select: none makes selection difficult
       
  7628         
       
  7629         Let users create selections if they mouse down in a -webkit-user-select:none
       
  7630         region, just (continue to) disallow selection endpoints in those regions, and
       
  7631         don't paint those regions as selected if they are fully enclosed by a selection. 
       
  7632         For example, in xxyyyxx where x is -webkit-user-select:none, a user can mouse down
       
  7633         between the first two xs and drag across yyy to the second two xs to create a 
       
  7634         selection xx^yyy^xx.
       
  7635         
       
  7636         * editing/SelectionController.cpp:
       
  7637         (WebCore::SelectionController::selectAll): Allow selectAll inside a root
       
  7638         that has -webkit-user-select:none, because it may contain content that
       
  7639         is selectable (VisiblePosition and Selection creation will keep Selection
       
  7640         endpoints out of -webkit-user-select:none regions).
       
  7641         * page/EventHandler.cpp:
       
  7642         (WebCore::EventHandler::selectClosestWordFromMouseEvent): Use canMouseDownStartSelect
       
  7643         instead of the ambiguously named shouldSelect().
       
  7644         (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto.
       
  7645         (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto.
       
  7646         (WebCore::EventHandler::updateSelectionForMouseDrag): Use canMouseDragExtendSelect.
       
  7647         (WebCore::EventHandler::selectCursor): Paint an ibeam in -webkit-user-select:none regions,
       
  7648         because you can click in those regions to create a selection.
       
  7649         (WebCore::EventHandler::canMouseDownStartSelect): Now fires the selectStart event, and
       
  7650         returns true in -webkit-user-select: none regions.
       
  7651         (WebCore::EventHandler::canMouseDragExtendSelect): This is identical to 
       
  7652         canMouseDownStartSelect because of 12823, even though it seems strange that we would fire 
       
  7653         the selectStart event here.
       
  7654         * page/EventHandler.h:
       
  7655         * rendering/RenderObject.cpp:
       
  7656         (WebCore::RenderObject::draggableNode): Only -webkit-user-select:ignore regions will
       
  7657         prevent selection creation.
       
  7658         * rendering/RenderObject.h:
       
  7659 
       
  7660 2007-08-13  Anders Carlsson  <andersca@apple.com>
       
  7661 
       
  7662         Reviewed by Maciej.
       
  7663 
       
  7664         <rdar://problem/5360748>
       
  7665         REGRESSION (r21002-r21003): Flash widget sniffer doesn't work (affects iWeb)
       
  7666 
       
  7667         Don't check whether the document is being parsed or not, because the node list
       
  7668         could be accessed after the document has finished parsing.
       
  7669         
       
  7670         * dom/Node.cpp:
       
  7671         (WebCore::Node::registerNodeList):
       
  7672 
       
  7673 2007-08-13  Lars Knoll  <lars@trolltech.com>
       
  7674 
       
  7675         Reviewed by Simon.
       
  7676 
       
  7677         no need to update regions that are not visible on the webpage.
       
  7678 
       
  7679         * platform/qt/ScrollViewQt.cpp:
       
  7680         (WebCore::ScrollView::updateContents):
       
  7681 
       
  7682 2007-08-12  Maciej Stachowiak  <mjs@apple.com>
       
  7683 
       
  7684         Reviewed by Darin and Sam.
       
  7685         
       
  7686         <rdar://problem/5395213> cross-domain access to individual components of location object should be denied.
       
  7687 
       
  7688         * bindings/js/kjs_window.cpp:
       
  7689         (KJS::Location::put): Add the appropriate cross-domain access checks.
       
  7690 
       
  7691 2007-08-12  Darin Adler  <darin@apple.com>
       
  7692 
       
  7693         Reviewed by John Sullivan.
       
  7694 
       
  7695         - fix <rdar://problem/5403724> REGRESSION: text inputs are not scrolled to make inline input visible (14912)
       
  7696 
       
  7697         * editing/Editor.h: Made setIgnoreMarkedTextSelectionChange no longer inline.
       
  7698         It now has a side effect of revealing the selection when you set it to false.
       
  7699         Added private revealSelectionAfterEditingOperation helper.
       
  7700         * editing/Editor.cpp:
       
  7701         (WebCore::Editor::deleteRange): Calls revealSelectionAfterEditingOperation instead
       
  7702         of calling m_frame->revealSelection directly.
       
  7703         (WebCore::Editor::replaceSelectionWithFragment): Ditto.
       
  7704         (WebCore::Editor::insertOrderedList): Ditto.
       
  7705         (WebCore::Editor::insertUnorderedList): Ditto.
       
  7706         (WebCore::Editor::increaseSelectionListLevel): Ditto.
       
  7707         (WebCore::Editor::increaseSelectionListLevelOrdered): Ditto.
       
  7708         (WebCore::Editor::increaseSelectionListLevelUnordered): Ditto.
       
  7709         (WebCore::Editor::decreaseSelectionListLevel): Ditto.
       
  7710         (WebCore::Editor::insertLineBreak): Ditto.
       
  7711         (WebCore::Editor::insertParagraphSeparator): Ditto.
       
  7712         (WebCore::Editor::replaceMarkedText): Ditto.
       
  7713         (WebCore::Editor::revealSelectionAfterEditingOperation): Added. Calls revealSelection,
       
  7714         unless we are in the ignoreMarkedTextSelectionChange state. If we are in that state,
       
  7715         we're in the middle of a composite editing operation and we shouldn't try to scroll
       
  7716         to reveal the selection until the operation is done.
       
  7717         (WebCore::Editor::setIgnoreMarkedTextSelectionChange): Made no longer inline. If
       
  7718         changing the state from true to false, then calls revealSelectionAfterEditingOperation.
       
  7719 
       
  7720         * WebCore.exp: Add new entry point for no-longer-inline setter function.
       
  7721 
       
  7722 2007-08-12  Geoffrey Garen  <ggaren@apple.com>
       
  7723 
       
  7724         Reviewed by Maciej Stachowiak, Dave Hyatt.
       
  7725         
       
  7726         Changed the dead resource LRU-SP algorithm to measure an object's
       
  7727         total size, not just its encoded size. This will allow us to make 
       
  7728         better decisions about what data to evict when the cache is small. For 
       
  7729         example, the PLT can now run with a 16MB cache without fully evicting
       
  7730         any resources.
       
  7731         
       
  7732         (Previously, we had assumed that decoded size would be an OK estimate
       
  7733         of encoded size, but that is not true of GIF, whose decoded size can be 
       
  7734         orders of magnitude greater than its encoded size.)
       
  7735         
       
  7736         Subtly, destroying a resource's decoded data now increases its recency 
       
  7737         by moving it to the head of a smaller LRU list. This is slightly odd,
       
  7738         but, since all resources get the same treatment, it shouldn't hurt 
       
  7739         the eviction algorithm.
       
  7740 
       
  7741         * history/PageCache.cpp:
       
  7742         (WebCore::PageCache::releaseAutoreleasedPagesNow): Make sure that a
       
  7743         dead resource eviction doesn't happen until we've released all of our
       
  7744         dead pages. Otherwise, the cache will make terrible decisions about 
       
  7745         what to evict because all of our dead resources will seem live.
       
  7746 
       
  7747         * loader/Cache.cpp:
       
  7748         (WebCore::Cache::Cache):
       
  7749         (WebCore::Cache::pruneLiveResources):
       
  7750         (WebCore::Cache::pruneDeadResources): Removed call to 
       
  7751         removeFromLiveDecodedResourcesList because this happens automatically
       
  7752         now as a part of the process of changing the resource's decoded size.
       
  7753         (WebCore::Cache::lruListFor): *** The key change. *** Compute the 
       
  7754         appropriate LRU list based on total size, not encoded size.
       
  7755         (WebCore::Cache::dumpLRULists): Added debug logging function to help
       
  7756         visualize the cache.
       
  7757 
       
  7758         * loader/Cache.h:
       
  7759         (WebCore::Cache::setDeadResourcePruneEnabled):
       
  7760         (WebCore::Cache::deadResourcePruneEnabled):
       
  7761 
       
  7762         * loader/CachedImage.cpp: Moved decoded size tracking code from here
       
  7763         up into the base class. Currently, only CachedImage has a use for that
       
  7764         functionality, but other subclasses might need it in the future, and
       
  7765         the base class is already responsible for similar code related to 
       
  7766         encoded size tracking.
       
  7767         (WebCore::CachedImage::decodedSizeChanged):
       
  7768         * loader/CachedImage.h:
       
  7769 
       
  7770         * loader/CachedResource.cpp:
       
  7771         (WebCore::CachedResource::CachedResource):
       
  7772         (WebCore::CachedResource::setDecodedSize): Move us in the LRU-SP list
       
  7773         just like setEncodedSize does, since decoded size counts now, too.
       
  7774         (WebCore::CachedResource::setEncodedSize): Changed slightly to match
       
  7775         the style of setDecodedSize.
       
  7776 
       
  7777         * loader/CachedResource.h:
       
  7778         (WebCore::CachedResource::decodedSize):
       
  7779 
       
  7780 2007-08-11  Mitz Pettel  <mitz@webkit.org>
       
  7781 
       
  7782         Reviewed by Darin.
       
  7783 
       
  7784         - fix http://bugs.webkit.org/show_bug.cgi?id=13670
       
  7785           <rdar://problem/5399619> Table misrender when one of the TDs has width=100%
       
  7786 
       
  7787         Tests: fast/table/100-percent-cell-width.html
       
  7788                fast/table/percent-widths-stretch.html
       
  7789 
       
  7790         * rendering/AutoTableLayout.cpp:
       
  7791         (WebCore::AutoTableLayout::calcPrefWidths): Changed the value used instead of
       
  7792         0% to avoid division by zero from 1% to less than 0.01%. Removed code that
       
  7793         added 0.5px to non-percent widths when calculating the scaling factor. The
       
  7794         latter change is covered by the percent-widths-stretch test, where the new
       
  7795         results match both WinIE 7 and Firefox 3.
       
  7796 
       
  7797 2007-08-11  Darin Adler  <darin@apple.com>
       
  7798 
       
  7799         Reviewed by Antti.
       
  7800 
       
  7801         - fix <rdar://problem/5266535> REGRESSION: <img> inside <map> no longer allowed in strict mode
       
  7802           (breaks chemicalelements.com)
       
  7803 
       
  7804         Test: fast/parser/strict-img-in-map.html
       
  7805 
       
  7806         * html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::checkDTD): Removed FIXME saying this
       
  7807         code is strange, since this code matches the HTML 4 specification almost exactly. Made
       
  7808         <img> elements allowed even in strict mode and added small comments to clarify what comes
       
  7809         from the DTD and what is non-standard.
       
  7810 
       
  7811 2007-08-11  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  7812 
       
  7813         Reviewed by Anders.
       
  7814 
       
  7815         Implement passing events to a subframe. The code is copied from
       
  7816         the windows port and passSubframeEventToSubframe was removed as it
       
  7817         is not called and it is not avilable in the windows port as well.
       
  7818 
       
  7819         * page/gdk/EventHandlerGdk.cpp:
       
  7820         (WebCore::EventHandler::passMousePressEventToSubframe):
       
  7821         (WebCore::EventHandler::passMouseMoveEventToSubframe):
       
  7822         (WebCore::EventHandler::passMouseReleaseEventToSubframe):
       
  7823 
       
  7824 2007-08-11  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  7825 
       
  7826         Reviewed by Lars.
       
  7827 
       
  7828         GdkEventKey::string is not supposed to be used. The length
       
  7829         of this string is zero for non ascii characters. Use the
       
  7830         gdk_unicode_to_keyval to convert the keyval to a UChar and construct
       
  7831         a String. This change makes it possible to input non ascii
       
  7832         characters.
       
  7833 
       
  7834         * platform/gdk/KeyEventGdk.cpp:
       
  7835         (WebCore::keyIdentifierForGdkKeyCode):
       
  7836         (WebCore::singleCharacterString):
       
  7837         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
       
  7838 
       
  7839 2007-08-11  Andrew Wellington  <proton@wiretapped.net>
       
  7840 
       
  7841         Reviewed by Mark Rowe.
       
  7842         
       
  7843         Fix http://bugs.webkit.org/show_bug.cgi?id=14645
       
  7844         getPropertyValue should be case insensitive
       
  7845         
       
  7846         When we get the propertyID for a given string we convert to lowercase.
       
  7847         
       
  7848         This also applies to setProperty, removeProperty and others.
       
  7849         
       
  7850         * css/CSSStyleDeclaration.cpp:
       
  7851         (WebCore::propertyID):
       
  7852 
       
  7853 2007-08-11  Mark Rowe  <mrowe@apple.com>
       
  7854 
       
  7855         Build fix.  Change "#ifdef PLATFORM(GDK)" to "#if PLATFORM(GDK)".
       
  7856 
       
  7857         * page/FrameView.cpp:
       
  7858         * page/FrameView.h:
       
  7859 
       
  7860 2007-08-11  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  7861 
       
  7862         Reviewed by Adam.
       
  7863 
       
  7864         Copy the WebFrame::layoutIfNeededRecursive method of the windows port
       
  7865         to FrameView to be used by the Gtk+ port. Simplify the implementation due
       
  7866         moving it to the FrameView class.
       
  7867 
       
  7868         Implement the ScrollView::children() method for the Gtk+ port and make it
       
  7869         available to the FrameView as children() is used within the layoutIfNeededRecursive method.
       
  7870 
       
  7871         * page/FrameView.cpp:
       
  7872         (WebCore::FrameView::layoutIfNeededRecursive):
       
  7873         * page/FrameView.h:
       
  7874         * platform/ScrollView.h:
       
  7875         * platform/gdk/ScrollViewGdk.cpp:
       
  7876 
       
  7877 2007-08-11  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  7878 
       
  7879         Reviewed by Adam.
       
  7880 
       
  7881         To fix text selection make the PlatformMouseEvent set the pressed
       
  7882         button even when moving the mouse.
       
  7883         
       
  7884         Add building of the WebKit::DragClient stubs as they are needed to
       
  7885         make text selection work.
       
  7886 
       
  7887         * WebCore.pro:
       
  7888         * platform/gdk/MouseEventGdk.cpp:
       
  7889         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
       
  7890 
       
  7891 2007-08-10  Anders Carlsson  <andersca@apple.com>
       
  7892 
       
  7893         Reviewed by Darin and Maciej.
       
  7894 
       
  7895         <rdar://problem/5360748>
       
  7896         REGRESSION(r21002-r21003) Flash widget sniffer doesn't work
       
  7897         
       
  7898         Add a per-document NodeList counter. When parsing, only call notifyNodeListsChildrenChanged
       
  7899         if the document has node lists. Also, make sure to reset the cache when the node list count has 
       
  7900         been 0 and a new node list is registered to avoid any stale cache information.
       
  7901         
       
  7902         * dom/ContainerNode.cpp:
       
  7903         (WebCore::ContainerNode::addChild):
       
  7904         * dom/Document.cpp:
       
  7905         (WebCore::Document::Document):
       
  7906         * dom/Document.h:
       
  7907         (WebCore::Document::addNodeList):
       
  7908         (WebCore::Document::removeNodeList):
       
  7909         (WebCore::Document::hasNodeLists):
       
  7910         * dom/Node.cpp:
       
  7911         (WebCore::Node::registerNodeList):
       
  7912         (WebCore::Node::unregisterNodeList):
       
  7913 
       
  7914 2007-08-10  Timothy Hatcher  <timothy@apple.com>
       
  7915 
       
  7916         Reviewed by Adam.
       
  7917 
       
  7918         <rdar://problem/5394449> Stop using some Carbon UI APIs for 64 bit
       
  7919 
       
  7920         Disable NPObject use in 64-bit on Mac OS X.
       
  7921 
       
  7922         * Configurations/WebCore.xcconfig: Add a framework search path to the sub-framworks of Carbon.
       
  7923         * WebCore.xcodeproj/project.pbxproj: Filter out the Frame::windowScriptNPObject() symbol in 64-bit.
       
  7924         * bindings/objc/DOM.mm:
       
  7925         (-[DOMElement _NPObject]): Return null in 64-bit.
       
  7926         * config.h: Set WTF_USE_NPOBJECT to 0 in 64-bit Mac OS X.
       
  7927         * page/Frame.cpp:
       
  7928         (WebCore::Frame::cleanupScriptObjects): Add more #if USE(NPOBJECT) blocks where needed.
       
  7929         * page/Frame.h: Ditto.
       
  7930         * page/mac/FrameMac.mm:
       
  7931         (WebCore::Frame::createScriptInstanceForWidget): Ditto.
       
  7932         * page/mac/WebCoreFrameBridge.h: Ditto.
       
  7933         * page/mac/WebCoreFrameBridge.mm: Ditto.
       
  7934 
       
  7935 2007-08-10  Mitz Pettel  <mitz@webkit.org>
       
  7936 
       
  7937         Reviewed by Justin.
       
  7938 
       
  7939         - fix <rdar://problem/5397344> http://bugs.webkit.org/show_bug.cgi?id=14911
       
  7940           REGRESSION: Clicking in pasted text doesn't position the insertion point correctly
       
  7941 
       
  7942         Test: editing/selection/inline-closest-leaf-child.html
       
  7943 
       
  7944         * rendering/RootInlineBox.cpp:
       
  7945         (WebCore::RootInlineBox::closestLeafChildForXPos): Return the last leaf if
       
  7946         it's the closest match, or if no other leaf matches (for example if all
       
  7947         leaves are list markers or non-editable where editable is required).
       
  7948 
       
  7949 2007-08-10  Anders Carlsson  <andersca@apple.com>
       
  7950 
       
  7951         Reviewed by Geoff.
       
  7952 
       
  7953         <rdar://problem/5390568> 
       
  7954         REGRESSION: -[WebFrame loadHTMLString:baseURL:] leaks the data source.
       
  7955         
       
  7956         Revert the fix for <rdar://problem/5133420> which caused us to not cancel 
       
  7957         substitute data loads. It's better to remove the assertion in the WebKit layer.
       
  7958         
       
  7959         * loader/ResourceLoader.cpp:
       
  7960         (WebCore::ResourceLoader::didCancel):
       
  7961 
       
  7962 2007-08-10  Sam Weinig  <sam@webkit.org>
       
  7963 
       
  7964         Rubber-stamped by Adam Roben.
       
  7965 
       
  7966         Fix Windows, Qt and Gtk build.
       
  7967 
       
  7968         * WebCore.pro:
       
  7969         * WebCore.vcproj/WebCore.vcproj:
       
  7970 
       
  7971 2007-08-09  Sam Weinig  <sam@webkit.org>
       
  7972 
       
  7973         Reviewed by Maciej.
       
  7974 
       
  7975         Fix for <rdar://problem/5395618>
       
  7976 
       
  7977         Use checkNodeSecurity when setting the 'src' or 'location' attribute of an
       
  7978         iframe or frame element.  
       
  7979 
       
  7980         * WebCore.xcodeproj/project.pbxproj:
       
  7981         * bindings/js/JSAttrCustom.cpp: Added.
       
  7982         (WebCore::JSAttr::setValue): Call checkNodeSecurity for attributes with a current iframe or frame
       
  7983         ownerElement when setting src to a javascript: URL.
       
  7984         * bindings/js/JSElementCustom.cpp: Added.
       
  7985         (WebCore::allowSettingSrcToJavascriptURL):
       
  7986         (WebCore::JSElement::setAttribute): Call checkNodeSecurity when element is a frame or iframe and 
       
  7987         setting he src attribute to a javascript: URL.
       
  7988         (WebCore::JSElement::setAttributeNode): Ditto.
       
  7989         (WebCore::JSElement::setAttributeNS): Ditto.
       
  7990         (WebCore::JSElement::setAttributeNodeNS): Ditto.
       
  7991         * bindings/js/JSHTMLFrameElementCustom.cpp: Added.
       
  7992         (WebCore::allowSettingJavascriptURL):
       
  7993         (WebCore::JSHTMLFrameElement::setSrc): Call checkNodeSecurity when setting to a javascript: URL.
       
  7994         (WebCore::JSHTMLFrameElement::setLocation): Ditto.
       
  7995         * bindings/js/JSHTMLIFrameElementCustom.cpp: Added.
       
  7996         (WebCore::JSHTMLIFrameElement::setSrc): Call checkNodeSecurity when setting to a javascript: URL.
       
  7997         * bindings/scripts/CodeGeneratorJS.pm: Add support for [CustomGetter] and [CustomSetter]
       
  7998         * dom/Attr.idl:
       
  7999         * dom/Element.idl:
       
  8000         * html/HTMLFrameElement.idl:
       
  8001         * html/HTMLIFrameElement.idl:
       
  8002 
       
  8003 2007-08-10  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  8004 
       
  8005         Reviewed by Anders.
       
  8006 
       
  8007         Make the containingWindow a GtkContainer and make use of the
       
  8008         GtkWidget::window instead of the GtkLayout::bin_window.
       
  8009 
       
  8010         * platform/Widget.h:
       
  8011         * platform/gdk/PlatformScreenGdk.cpp:
       
  8012         (WebCore::screenDepth):
       
  8013         * platform/gdk/ScrollViewGdk.cpp:
       
  8014         (WebCore::ScrollView::updateContents):
       
  8015         (WebCore::ScrollView::update):
       
  8016         * platform/gdk/WidgetGdk.cpp:
       
  8017         (WebCore::Widget::setContainingWindow):
       
  8018         (WebCore::Widget::setCursor):
       
  8019 
       
  8020 2007-08-10  Simon Hausmann  <hausmann@kde.org>
       
  8021 
       
  8022         Reviewed by Lars.
       
  8023 
       
  8024         Revert r24699 as it broke timers. The precision of QTime::toTime_t() is just seconds, which is not good enough. Revert back
       
  8025         to the old implementation and use the simple implementation of currentTime() from win/ for the Qt/Windows build (fingers crossed :)
       
  8026 
       
  8027         * WebCore.pro:
       
  8028         * platform/qt/SystemTimeQt.cpp:
       
  8029         (WebCore::currentTime):
       
  8030 
       
  8031 2007-08-10  Simon Hausmann  <hausmann@kde.org>
       
  8032 
       
  8033         Reviewed by Lars.
       
  8034 
       
  8035         Recognize .htm as valid extension for text/html.
       
  8036 
       
  8037         * platform/qt/MIMETypeRegistryQt.cpp:
       
  8038         (WebCore::):
       
  8039 
       
  8040 2007-08-10  Lars Knoll  <lars@trolltech.com>
       
  8041 
       
  8042         Reviewed by Simon.
       
  8043 
       
  8044         remove an assertion that leads to crashes. The whole design of WidgetQt and ScrollViewQt needs to be reevaluated soon anyways.
       
  8045 
       
  8046         * platform/qt/ScrollViewQt.cpp:
       
  8047 
       
  8048 2007-08-10  Mark Rowe  <mrowe@apple.com>
       
  8049 
       
  8050         Fix the Mac build.
       
  8051 
       
  8052         * ForwardingHeaders/bindings/runtime_object.h: Added.
       
  8053 
       
  8054 2007-08-10  Simon Hausmann  <hausmann@kde.org>
       
  8055 
       
  8056         Reviewed by Lars.
       
  8057 
       
  8058         Make sure -fno-strict-aliasing is also added for mkspecs like linux-g++-64.
       
  8059 
       
  8060         * WebCore.pro:
       
  8061 
       
  8062 2007-08-10  Simon Hausmann  <hausmann@kde.org>
       
  8063 
       
  8064         Reviewed by Lars.
       
  8065 
       
  8066         Enable JavaScript bindings for HTML Object/Applet elements in the Qt port.
       
  8067 
       
  8068         * WebCore.pro:
       
  8069         * bindings/js/kjs_dom.cpp:
       
  8070         * html/HTMLAppletElement.h:
       
  8071         * html/HTMLEmbedElement.h:
       
  8072         * page/qt/FrameQt.cpp:
       
  8073         (WebCore::Frame::createScriptInstanceForWidget):
       
  8074 
       
  8075 2007-08-10  Mitz Pettel  <mitz@webkit.org>
       
  8076 
       
  8077         Reviewed by Dave Hyatt.
       
  8078 
       
  8079         - fix http://bugs.webkit.org/show_bug.cgi?id=14798
       
  8080           Incorrect bidi reordering of neutrals and digits after RTL embed
       
  8081           and other bugs in the bidi algorithm.
       
  8082 
       
  8083         Test: fast/text/international/bidi-neutral-run.html
       
  8084 
       
  8085         Fixed several bugs in resolving the embedding level of runs of neutral
       
  8086         characters. Changed the logic to rely on the eor direction only for
       
  8087         the number types, and otherwise consider the last strong type.
       
  8088 
       
  8089         * platform/BidiContext.h:
       
  8090         (WebCore::BidiContext::BidiContext): Added an ASSERT.
       
  8091         * platform/BidiResolver.h:
       
  8092         (WebCore::::embed):
       
  8093         (WebCore::::createBidiRunsForLine):
       
  8094         * platform/graphics/GraphicsContext.cpp:
       
  8095         (WebCore::TextRunIterator::atEnd): Changed to return true instead of
       
  8096         crashing when called on the empty iterator.
       
  8097 
       
  8098 2007-08-09  Mark Rowe  <mrowe@apple.com>
       
  8099 
       
  8100         Reviewed by Antti.
       
  8101 
       
  8102         <rdar://problem/5400709> Versioning in debug and release builds should include minor and tiny version before +
       
  8103 
       
  8104         * Configurations/Version.xcconfig:
       
  8105         * WebCore.xcodeproj/project.pbxproj: Add a shell script phase to make to dependency between
       
  8106         Version.xcconfig and Info.plist explicit to Xcode.
       
  8107 
       
  8108 2007-08-09  Mitz Pettel  <mitz@webkit.org>
       
  8109 
       
  8110         Reviewed by Justin Garcia.
       
  8111 
       
  8112         - fix http://bugs.webkit.org/show_bug.cgi?id=14347
       
  8113           REGRESSION (r21291): Initiating a drag near the edge of a selection deselects it
       
  8114 
       
  8115         Test: editing/selection/contains-boundaries.html
       
  8116 
       
  8117         * editing/SelectionController.cpp:
       
  8118         (WebCore::SelectionController::contains): Changed to return true for the
       
  8119         selection boundaries too.
       
  8120 
       
  8121 2007-08-09  Mitz Pettel  <mitz@webkit.org>
       
  8122 
       
  8123         Reviewed by Dave Hyatt.
       
  8124 
       
  8125         - fix http://bugs.webkit.org/show_bug.cgi?id=14742
       
  8126           Document::recalcStyle(Force) called for every updateStyleIgnorePendingStylesheets while waiting for stylesheets
       
  8127           <rdar://problem/5376306>
       
  8128 
       
  8129         updateStyleSelector() is normally called when something changes that factors
       
  8130         into the style selector. However, updateLayoutIgnorePendingStylesheets() calls it for
       
  8131         a different reason, namely to account for all the preceding changes that were ignored
       
  8132         because of the early return in updateStyleSelector(). After that, the early return
       
  8133         can no longer occur, so changes are accounted for as they happen, and
       
  8134         updateLayoutIgnorePendingStylesheets() does not need to call updateStyleSelector()
       
  8135         again.
       
  8136 
       
  8137         * dom/Document.cpp:
       
  8138         (WebCore::Document::updateLayoutIgnorePendingStylesheets): Call updateStyleSelector()
       
  8139         only before the first layout.
       
  8140 
       
  8141 2007-08-09  Mitz Pettel  <mitz@webkit.org>
       
  8142 
       
  8143         Reviewed by Adam Roben.
       
  8144 
       
  8145         - fix http://bugs.webkit.org/show_bug.cgi?id=14362
       
  8146           Opening a select list always highlights first element in list
       
  8147 
       
  8148         * platform/win/PopupMenuWin.cpp:
       
  8149         (WebCore::PopupWndProc): Track the mouse only inside the popup.
       
  8150 
       
  8151 2007-08-09  Mitz Pettel  <mitz@webkit.org>
       
  8152 
       
  8153         Reviewed by Dave Hyatt.
       
  8154 
       
  8155         - fix http://bugs.webkit.org/show_bug.cgi?id=14875
       
  8156           Textarea with nowrap - left/right nav, Up/down nav both hide text
       
  8157 
       
  8158         Test: fast/layers/scroll-rect-to-visible.html
       
  8159 
       
  8160         * rendering/RenderLayer.cpp:
       
  8161         (WebCore::RenderLayer::scrollRectToVisible): Account for borders and scroll bars.
       
  8162 
       
  8163 2007-08-09  Geoffrey Garen  <ggaren@apple.com>
       
  8164 
       
  8165         Reviewed by Dave Hyatt.
       
  8166         
       
  8167         Refactored live decoded resource eviction to be more modular / 
       
  8168         encapsulated. 
       
  8169         
       
  8170         This fixes one known place where we forgot to hook into the live 
       
  8171         decoded eviction mechanism -- canvas. There might be other, unknown 
       
  8172         places. In a canvas test page, which I broke off from the Safari 
       
  8173         pageout test, I saw an RPRVT reduction of ~10MB.
       
  8174         
       
  8175         A few renames:
       
  8176         - "m_lastLiveAccessTime" => "m_lastDecodedAccessTime" because the data
       
  8177         point we're recording is access to the resource in decoded form.
       
  8178         
       
  8179         - "liveResourceAccessed" => "didAccessDecodedData" for the same reason.
       
  8180 
       
  8181         - "pruneAllResources" => "pruneDeadResources" because this function 
       
  8182         does not prune live resources.
       
  8183         
       
  8184         And the fix:
       
  8185         Instead of updating cache metadata at the call site whenver drawing an 
       
  8186         image, just have an image notify its observer whenever it draws. The 
       
  8187         observer, which is a CachedResource, can then update the metadata.
       
  8188         
       
  8189         * loader/Cache.cpp: Renames
       
  8190         * loader/Cache.h: Removed stale declarations, updated comments
       
  8191         * loader/CachedImage.cpp:
       
  8192         (WebCore::CachedImage::didDraw): Implemented didDraw to update cache
       
  8193         metadata whenever our image draws.
       
  8194         * loader/CachedImage.h: Grouped parts of the ImageObserver interface.
       
  8195         * loader/CachedResource.cpp:
       
  8196         (WebCore::CachedResource::CachedResource):
       
  8197         (WebCore::CachedResource::deref):
       
  8198         (WebCore::CachedResource::didAccessDecodedData): Made this function
       
  8199         slightly more modular by allowing the caller to provide a time stamp.
       
  8200         In theory, not all CachedResources will necessarily want to use the 
       
  8201         current paint time stamp.
       
  8202         * platform/graphics/cg/ImageCG.cpp:
       
  8203         (WebCore::BitmapImage::draw): Notify our observer that we drew.
       
  8204         (WebCore::Image::drawPattern): ditto
       
  8205         * platform/graphics/cg/PDFDocumentImage.cpp:
       
  8206         (WebCore::PDFDocumentImage::draw): ditto
       
  8207         * platform/graphics/svg/SVGImage.cpp:
       
  8208         (WebCore::SVGImage::draw): ditto
       
  8209         
       
  8210         Removed old code at image drawing call sites:
       
  8211         
       
  8212         * rendering/RenderBox.cpp:
       
  8213         (WebCore::RenderBox::paintBackgroundExtended):
       
  8214         * rendering/RenderImage.cpp:
       
  8215         (WebCore::RenderImage::paint):
       
  8216         * rendering/RenderListMarker.cpp:
       
  8217         (WebCore::RenderListMarker::paint):
       
  8218         * rendering/RenderObject.cpp:
       
  8219         (WebCore::RenderObject::paintBorderImage):
       
  8220 
       
  8221 2007-08-10  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  8222 
       
  8223         Reviewed by Adam.
       
  8224 
       
  8225         Move the various *ClientGdk.{h,cpp} away from the WebCore directory as
       
  8226         of http://bugs.webkit.org/show_bug.cgi?id=14727.
       
  8227 
       
  8228         * WebCore.pro:
       
  8229         * platform/gdk/TemporaryLinkStubs.cpp:
       
  8230 
       
  8231 2007-08-09  Anders Carlsson  <andersca@apple.com>
       
  8232 
       
  8233         Reviewed by Maciej.
       
  8234 
       
  8235         <rdar://problem/5400029> iframes with an image src rarely load image
       
  8236         
       
  8237         Don't try to shrink standalone images in subframes. The resize event is not 
       
  8238         sent for subframes which screws up the shrink-to-fit logic.
       
  8239         
       
  8240         * loader/ImageDocument.cpp:
       
  8241         (WebCore::ImageDocument::createDocumentStructure):
       
  8242         (WebCore::ImageDocument::imageChanged):
       
  8243         (WebCore::ImageDocument::shouldShrinkToFit):
       
  8244         * loader/ImageDocument.h:
       
  8245 
       
  8246 2007-08-10  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  8247 
       
  8248         Reviewed by Adam.
       
  8249 
       
  8250         Implement FrameLoaderClientGdk::createFrame mostly by copying
       
  8251         the windows implementation. A method similiar to WebFrame::loadURLIntoChild
       
  8252         was not introduced instead we have a simplified version similiar to the
       
  8253         one of the Qt port.
       
  8254 
       
  8255         Remove building of WebKit/gtk/webkitgtkframedata.{cpp,h}.
       
  8256 
       
  8257         * WebCore.pro:
       
  8258         * loader/gdk/FrameLoaderClientGdk.cpp:
       
  8259         (WebCore::FrameLoaderClientGdk::createFrame):
       
  8260 
       
  8261 2007-08-10  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  8262 
       
  8263         Reviewed by Adam.
       
  8264 
       
  8265         Use the ScrollView/Widget design of the Windows port to only use one
       
  8266         native window for the whole page. This will make it possible to implement
       
  8267         FrameLoaderClientGdk::createFrame.
       
  8268 
       
  8269         In contrast to the windows port the ScrollBars are GtkWidgets. To paint them
       
  8270         at the right position we need to position them correctly. To not scroll the
       
  8271         ScrollBar's belonging to the ScrollView a ScrollViewScrollbar is introduced with
       
  8272         a different geometryChanged method.
       
  8273 
       
  8274         To allow the Gtk+ way of scrolling the ScrollView allows to get GtkAdjustments
       
  8275         set. In this case no ScrollViewScrollbar will be created.
       
  8276 
       
  8277 
       
  8278         * platform/ScrollView.h:
       
  8279         * platform/Widget.h:
       
  8280         * platform/gdk/PlatformScreenGdk.cpp:
       
  8281         (WebCore::screenDepth):
       
  8282         * platform/gdk/PlatformScrollBar.h:
       
  8283         * platform/gdk/PlatformScrollBarGdk.cpp:
       
  8284         (PlatformScrollbar::PlatformScrollbar):
       
  8285         (PlatformScrollbar::~PlatformScrollbar):
       
  8286         (PlatformScrollbar::setRect):
       
  8287         (PlatformScrollbar::geometryChanged):
       
  8288         * platform/gdk/ScrollViewGdk.cpp:
       
  8289         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
       
  8290         (WebCore::ScrollView::ScrollViewPrivate::~ScrollViewPrivate):
       
  8291         (WebCore::ScrollViewScrollbar::ScrollViewScrollbar):
       
  8292         (WebCore::ScrollViewScrollbar::geometryChanged):
       
  8293         (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
       
  8294         (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
       
  8295         (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
       
  8296         (WebCore::ScrollView::ScrollViewPrivate::adjustmentChanged):
       
  8297         (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
       
  8298         (WebCore::ScrollView::ScrollViewPrivate::windowClipRect):
       
  8299         (WebCore::ScrollView::setGtkAdjustments):
       
  8300         (WebCore::ScrollView::updateContents):
       
  8301         (WebCore::ScrollView::update):
       
  8302         (WebCore::ScrollView::visibleWidth):
       
  8303         (WebCore::ScrollView::resizeContents):
       
  8304         (WebCore::ScrollView::contentsX):
       
  8305         (WebCore::ScrollView::scrollOffset):
       
  8306         (WebCore::ScrollView::maximumScroll):
       
  8307         (WebCore::ScrollView::scrollBy):
       
  8308         (WebCore::ScrollView::suppressScrollbars):
       
  8309         (WebCore::ScrollView::setHScrollbarMode):
       
  8310         (WebCore::ScrollView::setVScrollbarMode):
       
  8311         (WebCore::ScrollView::setScrollbarsMode):
       
  8312         (WebCore::ScrollView::setFrameGeometry):
       
  8313         (WebCore::ScrollView::addChild):
       
  8314         (WebCore::ScrollView::removeChild):
       
  8315         (WebCore::ScrollView::scrollRectIntoViewRecursively):
       
  8316         (WebCore::ScrollView::wheelEvent):
       
  8317         (WebCore::ScrollView::updateScrollbars):
       
  8318         (WebCore::ScrollView::windowToContents):
       
  8319         (WebCore::ScrollView::contentsToWindow):
       
  8320         (WebCore::ScrollView::scrollbarUnderMouse):
       
  8321         (WebCore::ScrollView::convertChildToSelf):
       
  8322         (WebCore::ScrollView::convertSelfToChild):
       
  8323         (WebCore::ScrollView::paint):
       
  8324         (WebCore::ScrollView::geometryChanged):
       
  8325         (WebCore::ScrollView::scroll):
       
  8326         (WebCore::ScrollView::addToDirtyRegion):
       
  8327         (WebCore::ScrollView::scrollBackingStore):
       
  8328         (WebCore::ScrollView::updateBackingStore):
       
  8329         * platform/gdk/WidgetGdk.cpp:
       
  8330         (WebCore::WidgetPrivate::gdkDrawable):
       
  8331         (WebCore::Widget::Widget):
       
  8332         (WebCore::Widget::setContainingWindow):
       
  8333         (WebCore::Widget::containingWindow):
       
  8334         (WebCore::Widget::frameGeometry):
       
  8335         (WebCore::Widget::setFrameGeometry):
       
  8336         (WebCore::Widget::setParent):
       
  8337         (WebCore::Widget::parent):
       
  8338         (WebCore::Widget::setCursor):
       
  8339         (WebCore::Widget::show):
       
  8340         (WebCore::Widget::hide):
       
  8341         (WebCore::Widget::removeFromParent):
       
  8342         (WebCore::Widget::paint):
       
  8343         (WebCore::Widget::invalidate):
       
  8344         (WebCore::Widget::invalidateRect):
       
  8345         (WebCore::Widget::convertToContainingWindow):
       
  8346         (WebCore::Widget::convertFromContainingWindow):
       
  8347         (WebCore::Widget::convertChildToSelf):
       
  8348         (WebCore::Widget::convertSelfToChild):
       
  8349         (WebCore::Widget::suppressInvalidation):
       
  8350         (WebCore::Widget::setSuppressInvalidation):
       
  8351 
       
  8352 2007-08-09  Adele Peterson  <adele@apple.com>
       
  8353 
       
  8354         Fix by Brady, reviewed by me.
       
  8355 
       
  8356         Fix for <rdar://problem/5380697> connection:willSendRequest:redirectResponse: is called on every NSURLConnection
       
  8357 
       
  8358         * platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
       
  8359           Work around a behavior change in CFNetwork where willSendRequest gets called more often by returning early.
       
  8360 
       
  8361 2007-08-09  Darin Adler  <darin@apple.com>
       
  8362 
       
  8363         Reviewed by Antti.
       
  8364 
       
  8365         - fix <rdar://problem/4889753> REGRESSION: Selection doesn't continue with drag selecting
       
  8366           when autoscrolling vertically (in Notes as well as Safari)
       
  8367 
       
  8368         The bug doesn't happen inside DumpRenderTree, so I was unable to make an automated
       
  8369         regression test.
       
  8370 
       
  8371         * manual-tests/autoscroll-when-outside-window.html: Added.
       
  8372 
       
  8373         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Removed unneeded null
       
  8374         check for the layer's renderer and the document, neither of which can be null. Call
       
  8375         the new updateSelectionForMouseDrag instead of doing selection updating here.
       
  8376 
       
  8377         * page/EventHandler.h:
       
  8378         * page/EventHandler.cpp:
       
  8379         (WebCore::EventHandler::handleMouseDraggedEvent): Refactored most of the logic
       
  8380         about updating the selection into updateSelectionForMouseDrag.
       
  8381         (WebCore::EventHandler::updateSelectionForMouseDrag): Added. The public version of
       
  8382         this function takes no parameters, and is for use from auto-scrolling code. The
       
  8383         private version of this function takes node and point parameters and contains the
       
  8384         shared code, including everything from updateSelectionForMouseDragOverPosition.
       
  8385         Aside from the code motion, variable name changes, and sharing more code, this
       
  8386         differs from the old code in RenderLayer::autoscroll in the following ways:
       
  8387 
       
  8388           1) The old code did hit testing only in the layer that was auto-scrolling,
       
  8389              and the new code instead starts the hit testing at the root layer, which is
       
  8390              better because it's the same thing we do for mouse moved events. Further,
       
  8391              the code to do this by calling convertToLayerCoords had a bug  because the
       
  8392              x and y variables were uninitialized.
       
  8393           2) The old code passed false for active to HitTestRequest, which was wrong.
       
  8394              The new code passes true. This flag needs to be true for hit testing done
       
  8395              while the mouse is down and false for hit testing done while the mouse is up.
       
  8396           3) The old code did not have the SVG-specific logic to match the mouse moved case.
       
  8397           4) The old code wouldn't do any selection updating if the return value from hitTest
       
  8398              was false, which is incorrect. The new code ignores the return value as it should.
       
  8399 
       
  8400 2007-08-08  Beth Dakin  <bdakin@apple.com>
       
  8401 
       
  8402         Reviewed by Geoff Garen.
       
  8403 
       
  8404         Fx for <rdar://problem/5286443>, http://bugs.webkit.org/
       
  8405         show_bug.cgi?id=14268 REGRESSION: Radio buttons don't stay selected 
       
  8406         due to unclosed <label> tags
       
  8407 
       
  8408         This patch maintains the behavior that allows <label> tags to nest. 
       
  8409         This matches WinIE, and appears to match the spec, since the spec 
       
  8410         does not explicitly say that they cannot nest. It fixes the bug 
       
  8411         instead by calling setDefaultHandled() in two places it should have 
       
  8412         been called anyway. This keeps the appropriate button checked as 
       
  8413         the event bubbles.
       
  8414 
       
  8415         * html/HTMLInputElement.cpp:
       
  8416         (WebCore::HTMLInputElement::postDispatchEventHandler):
       
  8417         * html/HTMLLabelElement.cpp:
       
  8418         (WebCore::HTMLLabelElement::defaultEventHandler):
       
  8419 
       
  8420 2007-08-08  Justin Garcia  <justin.garcia@apple.com>
       
  8421 
       
  8422         Reviewed by Oliver.
       
  8423 
       
  8424         <rdar://problem/5387578> Crash at ReplaceSelectionCommand::doApply() when pasting just after table cell content
       
  8425         
       
  8426         ReplaceSelectionCommand::doApply() inserts a line break before insertion
       
  8427         to prevent block nesting.  InsertLineBreakCommand::doApply was accidently
       
  8428         destroying a text node when it removed insignificant whitespace and then
       
  8429         setting a nil endingSelection().
       
  8430 
       
  8431         * editing/InsertLineBreakCommand.cpp:
       
  8432         (WebCore::InsertLineBreakCommand::doApply): If insignificant whitespace
       
  8433         removal removes textNode from the document, insert a text node containing
       
  8434         the non-breaking space we were attempting to insert and then insert it
       
  8435         at the position that the removed textNode occupied.
       
  8436 
       
  8437 2007-08-08  Geoffrey Garen  <ggaren@apple.com>
       
  8438 
       
  8439         Reviewed by Maciej Stachowiak.
       
  8440 
       
  8441         Added a thrash check to live decoded resource eviction.
       
  8442         
       
  8443         Here's the strategy: Stamp every image with its paint time. Don't evict 
       
  8444         a live decoded resource until another resource paints with a reasonably
       
  8445         (1 second) larger time stamp. 
       
  8446         
       
  8447         If no other resource paints, or another resource paints, but very soon 
       
  8448         after the resource in question, the resource in question is very likely 
       
  8449         to paint again soon. In fact, it's probably still on screen. So we 
       
  8450         leave it alone. (Previously, we evicted it on a timer, but that would 
       
  8451         evict a resource that was still on screen, hurting speed without 
       
  8452         helping memory use.)
       
  8453 
       
  8454         In theory, this algorithm allows a single large resource or closely 
       
  8455         related set of resources to linger in the live decoded cache even 
       
  8456         though the cache is over its limit. However, that can only happen as 
       
  8457         long as no other resource ever paints again, which guarantees an 
       
  8458         absolute cap on cache memory usage from then on. Also, the resources 
       
  8459         will only linger as long as they remain live. Upon going dead, they 
       
  8460         will flush. Also, these circumstances are so rare that they are almost 
       
  8461         impossible to encounter in the wild. So don't sweat it.
       
  8462         
       
  8463         Stop evicting if the next resource painted too recently:
       
  8464         
       
  8465         * loader/Cache.cpp:
       
  8466         (WebCore::Cache::pruneLiveResources):
       
  8467         * loader/CachedResource.cpp:
       
  8468         (WebCore::CachedResource::CachedResource):
       
  8469         (WebCore::CachedResource::liveResourceAccessed):
       
  8470         * loader/CachedResource.h:
       
  8471 
       
  8472         Track the paint time stamp in Frame. We do this to give a consistent
       
  8473         stamp to all resources painted in a single paint operation (in case the
       
  8474         operation takes a significant amount of time), and to avoid excessive 
       
  8475         calls to system time functions, which hurt the PLT:
       
  8476 
       
  8477         * page/Frame.cpp:
       
  8478         (WebCore::Frame::paint):
       
  8479         * page/Frame.h:
       
  8480         (WebCore::Frame::currentPaintTimeStamp):
       
  8481 
       
  8482 2007-08-08  Sam Weinig  <sam@webkit.org>
       
  8483 
       
  8484         Reviewed by Adam Roben.
       
  8485 
       
  8486         Update project file to reflect the moving of character-sets.txt
       
  8487         and make-charset-table.pl to platform/mac a while ago.
       
  8488 
       
  8489         * WebCore.xcodeproj/project.pbxproj:
       
  8490 
       
  8491 2007-08-08  Justin Garcia  <justin.garcia@apple.com>
       
  8492 
       
  8493         Reviewed by Harrison.
       
  8494 
       
  8495         <rdar://problem/5390681> WebKit asserts when deleting To Do content selected with a double-click
       
  8496         
       
  8497         * dom/Position.cpp:
       
  8498         (WebCore::Position::trailingWhitespacePosition): Use VisiblePosition::characterAfter
       
  8499         to look for a trailing space.  The old code would incorrectly return a position before
       
  8500         a non-editable space if it had a collapsed space before it.
       
  8501 
       
  8502 2007-08-08  Sam Weinig  <sam@webkit.org>
       
  8503 
       
  8504         Reviewed by Brady.
       
  8505 
       
  8506         Make protocol and host compares case-insensitive.
       
  8507 
       
  8508         * bindings/js/kjs_window.cpp:
       
  8509         (KJS::Window::isSafeScript):
       
  8510         * dom/Document.cpp:
       
  8511         (WebCore::Document::initSecurityPolicyURL):
       
  8512         * platform/DeprecatedString.cpp:
       
  8513         (WebCore::equalIgnoringCase):
       
  8514         * platform/DeprecatedString.h:
       
  8515         (WebCore::equalIgnoringCase):
       
  8516 
       
  8517 2007-08-08  Justin Garcia  <justin.garcia@apple.com>
       
  8518 
       
  8519         Reviewed by Harrison.
       
  8520 
       
  8521         <rdar://problem/5390681> WebKit asserts when deleting To Do content selected with a double-click
       
  8522 
       
  8523         * dom/Position.cpp:
       
  8524         (WebCore::Position::leadingWhitespacePosition): Added checks to prevent expansion across editable an boundary.
       
  8525         (WebCore::Position::trailingWhitespacePosition): Ditto.
       
  8526 
       
  8527 2007-08-08  Adele Peterson  <adele@apple.com>
       
  8528 
       
  8529         Reviewed by John.
       
  8530 
       
  8531         Fix for <rdar://problem/5393798> 100% reproducible crash in WebCore::Scrollbar::setValue
       
  8532 
       
  8533         * page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent):
       
  8534           If the hit testing originally determined the event was in a scrollbar, 
       
  8535           refetch the MouseEventWithHitTestResults in case the scrollbar widget was destroyed when the mouse event was handled.
       
  8536 
       
  8537 2007-08-08  Sam Weinig  <sam@webkit.org>
       
  8538 
       
  8539         Reviewed by Geoff Garen.
       
  8540 
       
  8541         Fix for <rdar://problem/5354635>
       
  8542 
       
  8543         Match Firefox's model for data: URLs by not allowing them script access
       
  8544         to any frames other then itself.
       
  8545 
       
  8546         * bindings/js/kjs_window.cpp:
       
  8547         (KJS::Window::isSafeScript):
       
  8548         * dom/Document.cpp:
       
  8549         (WebCore::Document::initSecurityPolicyURL):
       
  8550 
       
  8551 2007-08-08  Darin Adler  <darin@apple.com>
       
  8552 
       
  8553         Reviewed by Kevin Decker.
       
  8554 
       
  8555         - fix for <rdar://problem/5390708> CrashTracer: [USER] 27 crashes in Safari at
       
  8556           com.apple.WebCore: WTF::HashMap<etc>::set + 68, beneath pruneUnretainedIconsAtStartup
       
  8557 
       
  8558         * loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::pruneUnretainedIconsOnStartup):
       
  8559         Eliminate an unnecessary HashMap from the implementation; we can just use the
       
  8560         m_pageURLToRetainCount map directly. This simplifies the code and allows us to handle
       
  8561         the empty string, which otherwise poses a problem for HashMap.
       
  8562 
       
  8563 2007-08-08  Antti Koivisto  <antti@apple.com>
       
  8564 
       
  8565         Reviewed by Darin.
       
  8566         
       
  8567         Fix for <rdar://problem/5391576>
       
  8568         Malformed table innerHTML causes Safari to crash in HTMLParser::handleError (14894)
       
  8569         
       
  8570         Add null checks to protect against 
       
  8571         
       
  8572         e.innerHTML = "<tr>text</tr>";
       
  8573         
       
  8574         type cases. Normal assumptions about document tree structure don't hold when parsing 
       
  8575         fragments. Results don't match Firefox in all cases. It seems to have some sort of 
       
  8576         anything-goes fragment parsing mode.
       
  8577         
       
  8578         * html/HTMLParser.cpp:
       
  8579         (WebCore::HTMLParser::handleError):
       
  8580 
       
  8581 2007-08-07  Kevin McCullough  <kmccullough@apple.com>
       
  8582 
       
  8583         Reviewed by Maciej and Hyatt.
       
  8584 
       
  8585         - <rdar://problem/4976879> REGRESSION: Safari doesn't work with Zimbra enhanced login.
       
  8586         - Reverting a previous change, and modifying how documents are created so that we better match other browsers behavior with respect to namespaceURIs.
       
  8587 
       
  8588         * WebCore.xcodeproj/project.pbxproj:
       
  8589         * dom/DOMImplementation.cpp:
       
  8590         (WebCore::DOMImplementation::createDocument):
       
  8591         * dom/Document.cpp:
       
  8592         (WebCore::Document::Document):
       
  8593         (WebCore::Document::createElement):
       
  8594         * dom/Document.h:
       
  8595         * html/HTMLDocument.cpp:
       
  8596         (WebCore::HTMLDocument::createElement):
       
  8597         * html/HTMLDocument.h:
       
  8598 
       
  8599 2007-08-08  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
       
  8600 
       
  8601         Reviewed and landed by Brady
       
  8602 
       
  8603         Fixes <http://bugs.webkit.org/show_bug.cgi?id=13422>
       
  8604 
       
  8605         Bug 13422: REGRESSION: Page reload loses page position
       
  8606 
       
  8607         * loader/FrameLoader.cpp:
       
  8608         (WebCore::FrameLoader::updateHistoryForReload):
       
  8609 
       
  8610 2007-08-08  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  8611 
       
  8612         Reviewed by Niko.
       
  8613 
       
  8614         Be paranoid and disconnect from the signal before going away.
       
  8615 
       
  8616         * platform/gdk/PlatformScrollBarGdk.cpp:
       
  8617         (PlatformScrollbar::~PlatformScrollbar):
       
  8618 
       
  8619 2007-08-08  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  8620 
       
  8621         Reviewed by Niko.
       
  8622 
       
  8623         Use GraphicsContext::translatePoint in RenderThemeGdk to paint at the
       
  8624         right position.
       
  8625         This is needed as the Gtk+ theming code does not know about the translation
       
  8626         of the GraphicsContext.
       
  8627 
       
  8628         * platform/gdk/RenderThemeGdk.cpp:
       
  8629         (WebCore::RenderThemeGdk::paintCheckbox):
       
  8630         (WebCore::RenderThemeGdk::paintRadio):
       
  8631         (WebCore::RenderThemeGdk::paintButton):
       
  8632 
       
  8633 2007-08-08  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  8634 
       
  8635         Reviewed by Niko.
       
  8636 
       
  8637         Implement Widget::paint for the Gtk port. This is needed to paint
       
  8638         Widgets in z-order. The original GdkEventExpose is stored within the
       
  8639         GraphicsContext and then used to draw the children. This is similiar
       
  8640         to gtk_container_propagate_expose but we try to honor the GraphicsConntext
       
  8641         translation.
       
  8642 
       
  8643         * platform/gdk/WidgetGdk.cpp:
       
  8644         (WebCore::Widget::paint):
       
  8645         * platform/graphics/GraphicsContext.h:
       
  8646         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
  8647         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
       
  8648         (WebCore::GraphicsContext::setGdkExposeEvent):
       
  8649         (WebCore::GraphicsContext::gdkExposeEvent):
       
  8650         (WebCore::GraphicsContext::gdkDrawable):
       
  8651         (WebCore::GraphicsContext::translatePoint):
       
  8652 
       
  8653 2007-08-08  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  8654 
       
  8655         Reviewed by Oliver Hunt.
       
  8656 
       
  8657         Implement PlatformScrollbar by calling ScrollBar::setValue from 
       
  8658         gtkValueChange connected to the value-changed signal of the
       
  8659         GtkAdjustment.
       
  8660         Update 'value' of the GtkAdjustment in updateThumbPosition and
       
  8661         set upper, page-increment, step-increment and page_size in
       
  8662         updateThumbProportion.
       
  8663 
       
  8664         This is from bug http://bugs.webkit.org/show_bug.cgi?id=14795.
       
  8665 
       
  8666         * platform/gdk/PlatformScrollBar.h:
       
  8667         * platform/gdk/PlatformScrollBarGdk.cpp:
       
  8668         (PlatformScrollbar::PlatformScrollbar):
       
  8669         (PlatformScrollbar::updateThumbPosition):
       
  8670         (PlatformScrollbar::updateThumbProportion):
       
  8671         (PlatformScrollbar::gtkValueChanged):
       
  8672 
       
  8673 2007-08-07  Geoffrey Garen  <ggaren@apple.com>
       
  8674 
       
  8675         Reviewed by Maciej Stachowiak. Based on earlier review from Dave Hyatt.
       
  8676 
       
  8677         First chunk of work for <rdar://problem/5326009> Make non-browser 
       
  8678         WebKit clients have no memory cache, or a very tiny one
       
  8679         
       
  8680         Layout tests pass.
       
  8681         
       
  8682         Removed decodedSizeWillChange mechanism because my last patch to
       
  8683         change the live resources list to a strict LRU model made that code
       
  8684         vestigial.
       
  8685         
       
  8686         Renamed "liveResourcesList" and related stuff => 
       
  8687         "liveDecodedResourcesList" because only live resources with decoded 
       
  8688         data are kept in the list.
       
  8689 
       
  8690         * loader/CachedImage.cpp:
       
  8691         (WebCore::CachedImage::decodedSizeChanged): Only add ourselves to the
       
  8692         list if we're live, our decoded size has grown, and we're not in the 
       
  8693         list already. (Otherwise, either we're not live, we're not decoded,
       
  8694         or we're already in the list.)
       
  8695 
       
  8696         * loader/CachedResource.cpp:
       
  8697         (WebCore::CachedResource::liveResourceAccessed): Only re-insert
       
  8698         ourselves into the list if we're already there. (In theory, this should
       
  8699         be always, but it's a little more clear to check.)
       
  8700 
       
  8701 2007-08-08  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  8702 
       
  8703         Reviewed by Adam.
       
  8704 
       
  8705         Kill class FrameGdk and move the stubs to page/gdk/FrameGdk.cpp and the
       
  8706         remainings into WebKitGtkFrame.
       
  8707         The DRT functionality of class FrameGdk is currently lost.
       
  8708 
       
  8709         * WebCore.pro:
       
  8710         * loader/gdk/FrameLoaderClientGdk.cpp:
       
  8711         * loader/gdk/FrameLoaderClientGdk.h:
       
  8712         * page/gdk/FrameGdk.cpp: Renamed from WebCore/platform/gdk/FrameGdk.cpp.
       
  8713         (WebCore::Frame::issueTransposeCommand):
       
  8714         (WebCore::Frame::cleanupPlatformScriptObjects):
       
  8715         (WebCore::Frame::dragImageForSelection):
       
  8716         (WebCore::Frame::dashboardRegionsChanged):
       
  8717         * platform/gdk/FrameGdk.h: Removed.
       
  8718         * platform/gdk/TemporaryLinkStubs.cpp: Removed Frame stub, added the loadResourceIntoArray stub
       
  8719         * platform/gdk/WidgetGdk.cpp:
       
  8720 
       
  8721 2007-08-08  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  8722 
       
  8723         Reviewed by Adam.
       
  8724 
       
  8725         Remove the event handling code and move it to WebKit/gtk/Api/webkitgtkpage.cpp
       
  8726 
       
  8727         * platform/gdk/FrameGdk.cpp:
       
  8728         * platform/gdk/FrameGdk.h:
       
  8729 
       
  8730 2007-08-07  Holger Hans Peter Freyther  <zecke@selfish.org>
       
  8731 
       
  8732         Reviewed by Niko.
       
  8733 
       
  8734         Switch from the generic union GdkEvent to the specific struct GdkEvent*. This is needed
       
  8735         to make WebKitGtkPage handle the events by reimplementing the default handlers in the near
       
  8736         future.
       
  8737 
       
  8738         * platform/PlatformKeyboardEvent.h:
       
  8739         * platform/PlatformMouseEvent.h:
       
  8740         * platform/PlatformWheelEvent.h:
       
  8741         * platform/gdk/FrameGdk.cpp:
       
  8742         (WebCore::FrameGdk::handleGdkEvent):
       
  8743         * platform/gdk/KeyEventGdk.cpp:
       
  8744         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
       
  8745         * platform/gdk/MouseEventGdk.cpp:
       
  8746         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
       
  8747         * platform/gdk/WheelEventGdk.cpp:
       
  8748         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
       
  8749 
       
  8750 2007-08-07  George Staikos  <staikos@kde.org>
       
  8751 
       
  8752         Some QStyles don't handle negative maximum well (crash)
       
  8753 
       
  8754         * platform/qt/PlatformScrollBarQt.cpp:
       
  8755         (WebCore::PlatformScrollbar::paint):
       
  8756 
       
  8757 2007-08-07  Antti Koivisto  <antti@apple.com>
       
  8758 
       
  8759         Reviewed by Hyatt.
       
  8760 
       
  8761         Fix <rdar://problem/5102553>
       
  8762         Mail spins trying to display or edit a specific long plain text message in WebCore::TimerBase::...
       
  8763 
       
  8764         Calling removeLeftoverAnonymousBoxes() from RenderBlock::addChildToFlow() made adding children
       
  8765         O(n^2) in simple cases (repeated <div><div></div></div> for example).
       
  8766         
       
  8767         I couldn't find any limited fix so here is a more complete one. It removes iterating/recursing 
       
  8768         removeLeftoverAnonymousBoxes() method altogether. Instead of hunting around wildly, just get 
       
  8769         rid of anonymous boxes with block children when they occur.
       
  8770 
       
  8771         * rendering/RenderBlock.cpp:
       
  8772         (WebCore::RenderBlock::addChildToFlow):
       
  8773         * rendering/RenderButton.h:
       
  8774         (WebCore::RenderButton::removeLeftoverAnonymousBlock):
       
  8775         * rendering/RenderContainer.cpp:
       
  8776         (WebCore::RenderContainer::removeLeftoverAnonymousBlock):
       
  8777         * rendering/RenderContainer.h:
       
  8778         * rendering/RenderObject.cpp:
       
  8779         (WebCore::RenderObject::handleDynamicFloatPositionChange):
       
  8780         (WebCore::RenderObject::removeLeftoverAnonymousBlock):
       
  8781         * rendering/RenderObject.h:
       
  8782         * rendering/RenderTextControl.h:
       
  8783         (WebCore::RenderTextControl::removeLeftoverAnonymousBlock):
       
  8784 
       
  8785 2007-08-06  Sam Weinig  <sam@webkit.org>
       
  8786 
       
  8787         Reviewed by Maciej.
       
  8788 
       
  8789         Fix for <rdar://problem/5354689>
       
  8790 
       
  8791         - Use document variable to determine permissions instead
       
  8792           of traversing the frame tree. 
       
  8793 
       
  8794         * bindings/js/kjs_window.cpp:
       
  8795         (KJS::Window::isSafeScript):
       
  8796         * dom/Document.cpp:
       
  8797         (WebCore::Document::Document):
       
  8798         (WebCore::Document::initSecurityPolicyURL):
       
  8799         * dom/Document.h:
       
  8800         (WebCore::Document::securityPolicyURL):
       
  8801         * loader/FrameLoader.cpp:
       
  8802         (WebCore::FrameLoader::setOpener): We must re-initialize the
       
  8803         safeScript URL when setting the opener because the opener was
       
  8804         not known at Document construction.
       
  8805 
       
  8806 2007-08-06  David Hyatt  <hyatt@apple.com>
       
  8807 
       
  8808         Make sure to clear out the parent of the ellipsis box so that it doesn't
       
  8809         trigger the consistency check for line boxes.
       
  8810 
       
  8811         Reviewed by darin
       
  8812 
       
  8813         * ChangeLog:
       
  8814         * rendering/RootInlineBox.cpp:
       
  8815         (WebCore::RootInlineBox::detachEllipsisBox):
       
  8816 
       
  8817 2007-08-06  David Hyatt  <hyatt@apple.com>
       
  8818 
       
  8819         Back out fix for <rdar://problem/5366582> and replace it with the correct
       
  8820         fix.  Make sure to delete the line box tree before splitting an inline flow
       
  8821         into a continuation.  The added layout test for the original checkin covers
       
  8822         the problem.
       
  8823 
       
  8824         Reviewed by beth
       
  8825 
       
  8826         * rendering/RenderBlock.cpp:
       
  8827         (WebCore::RenderBlock::makeChildrenNonInline):
       
  8828         Back out fix.
       
  8829 
       
  8830         * rendering/RenderFlow.cpp:
       
  8831         (WebCore::RenderFlow::destroy):
       
  8832         Back out fix.
       
  8833 
       
  8834         * rendering/RenderInline.cpp:
       
  8835         (WebCore::RenderInline::splitFlow):
       
  8836         Here's the new fix.
       
  8837 
       
  8838 2007-08-06  Geoffrey Garen  <ggaren@apple.com>
       
  8839 
       
  8840         Reviewed by Darin Adler.
       
  8841         
       
  8842         Touching a file to force a re-build.
       
  8843 
       
  8844 2007-08-06  Darin Adler  <darin@apple.com>
       
  8845 
       
  8846         - fix release build
       
  8847 
       
  8848         * rendering/RenderText.h: (WebCore::RenderText::checkConsistency):
       
  8849         Add missing const.
       
  8850 
       
  8851 2007-08-06  Darin Adler  <darin@apple.com>
       
  8852 
       
  8853         Reviewed by Maciej.
       
  8854 
       
  8855         - fix <rdar://problem/5366582> crash on it.eurosport.yahoo.com page
       
  8856 
       
  8857         Test: fast/dynamic/inline-to-block-crash.html
       
  8858 
       
  8859         I added some consistency checks for the line box tree, which helped me figure out
       
  8860         what was going on with this bug pretty quickly.
       
  8861 
       
  8862         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::makeChildrenNonInline):
       
  8863         This is the actual fix. If the block needs layout, then don't try to delete the line
       
  8864         box tree because it's going to be rebuilt as part of layout. More importantly, the
       
  8865         child list in the tree is no good, so we will crash if we try to delete here.
       
  8866 
       
  8867         * rendering/RenderFlow.cpp: (WebCore::RenderFlow::destroy):
       
  8868         Here's a second fix. We have the same issue in the code that handles anonymous
       
  8869         blocks -- if it's already running as part of layout, we can't walk through the
       
  8870         already partly destroyed line box tree. This crashed in one of the layout tests.
       
  8871 
       
  8872         * rendering/InlineBox.h: Made more fields private, since I wanted to do a bit more
       
  8873         work in setters. Made setNextOnLine() and setPrevOnLine() assert that the box has a
       
  8874         parent. Made parent() assert that the parent is good. Also removed the unused
       
  8875         isChildOfParent() function.
       
  8876         * rendering/InlineBox.cpp: (WebCore::InlineBox::~InlineBox): At destruction time, if
       
  8877         we are still attached to a parent, tag that parent as having a "bad" child list.
       
  8878 
       
  8879         * rendering/InlineFlowBox.h: Added m_reasonForBadChildList, checkConsistency(),
       
  8880         setHasBadChildList(), and hasBadChildList(). Also changed firstChild() and lastChild() so
       
  8881         they call checkConsistency() and made all the fields private instead of protected.
       
  8882         * rendering/InlineFlowBox.cpp:
       
  8883         (WebCore::InlineFlowBox::addToLine): Added consistency checks before and after adding a
       
  8884         box to the line. Also checked that next and prev start out as 0. Changed manipulation of
       
  8885         next and prev to use accessor functions.
       
  8886         (WebCore::InlineFlowBox::removeChild): Added consistency checks before and after removing
       
  8887         the box from the line.
       
  8888         (WebCore::InlineFlowBox::deleteLine): Use firstChild() instead of getting at m_firstChild
       
  8889         directly so we get a consistency check. Also set the parent to 0 before destroying so that
       
  8890         the assertion in ~InlineBox will work properly.
       
  8891         (WebCore::InlineFlowBox::extractLine): Ditto.
       
  8892         (WebCore::InlineFlowBox::attachLine): Ditto.
       
  8893         (WebCore::InlineFlowBox::adjustPosition): Ditto.
       
  8894         (WebCore::InlineFlowBox::checkConsistency): Added. Checks consistency of the child list by
       
  8895         looking at the parent, next, and prev pointers. Also asserts that we are not yet in the
       
  8896         "bad" child list state, which happens if one of our children is destroyed without removing
       
  8897         it from our list; that's normal, but once it happens we can't look at our child list again.
       
  8898 
       
  8899         * rendering/InlineTextBox.h:
       
  8900         * rendering/InlineTextBox.cpp: Remove unnneeded destroy/new/delete functions -- these are
       
  8901         inherited from the InlineBox base class and don't need to be defined again.
       
  8902 
       
  8903         * rendering/RenderFlow.h:
       
  8904         * rendering/RenderFlow.cpp:
       
  8905         (WebCore::RenderFlow::~RenderFlow): Assert that there are no children to confirm that we
       
  8906         didn't leak something.
       
  8907         (WebCore::RenderFlow::extractLineBox): Added consistency checks before and after removing
       
  8908         a run of boxes from the list.
       
  8909         (WebCore::RenderFlow::attachLineBox): Added consistency checks before and after adding
       
  8910         a box to the list.
       
  8911         (WebCore::RenderFlow::removeLineBox): Added consistency checks before and after removing
       
  8912         a box from the list.
       
  8913         (WebCore::RenderFlow::createInlineBox): Added consistency checks before and after adding
       
  8914         a box to the list.
       
  8915         (WebCore::RenderFlow::checkConsistency): Added.
       
  8916 
       
  8917         * rendering/RenderText.h:
       
  8918         * rendering/RenderText.cpp:
       
  8919         (WebCore::RenderText::~RenderText): Assert that there are no children to confirm that we
       
  8920         didn't leak something.
       
  8921         (WebCore::RenderText::extractTextBox): Added consistency checks before and after removing
       
  8922         a run of boxes from the list.
       
  8923         (WebCore::RenderText::attachTextBox): Added consistency checks before and after adding
       
  8924         a box to the list.
       
  8925         (WebCore::RenderText::removeTextBox): Added consistency checks before and after removing
       
  8926         a box from the list.
       
  8927         (WebCore::RenderText::deleteTextBoxes): Added code to call setHasBadChildList since this
       
  8928         destroys line boxes without informing the parent.
       
  8929         (WebCore::RenderText::checkConsistency): Added.
       
  8930 
       
  8931 2007-08-06  Adele Peterson  <adele@apple.com>
       
  8932 
       
  8933         Reviewed by Darin.
       
  8934 
       
  8935         Fix for <rdar://problem/5382483> REGRESSION: <select> element's text is clipped when a CSS line-height is specified
       
  8936 
       
  8937         Don't honor line-height for styled popup buttons.  We already don't honor line-height for unstyled popups
       
  8938         and since IE and FF don't honor it at all for popups, we shouldn't either.
       
  8939 
       
  8940         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
       
  8941         * rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
       
  8942 
       
  8943 2007-08-06  Antti  <antti@apple.com>
       
  8944 
       
  8945         Reviewed by Darin.
       
  8946 
       
  8947         Fix <rdar://problem/5378214>
       
  8948         Mail crashes at RenderLayer::paintLayer() when dragging a selection over To Do text
       
  8949         
       
  8950         ObjC interface does not guarantee that Document::updateRendering() gets called after
       
  8951         modification are made to document. This can lead to situation where paint()
       
  8952         is invoked with document still dirty which can then crash in number of interesting ways.
       
  8953         
       
  8954         - add hasChangedChild() as needsLayout() condition. layout() will then call recalcStyle() 
       
  8955           catching most cases and making sure document is not dirty when entering painting.
       
  8956         - protect recalcStyle() and layout() from being executed during painting. There are some
       
  8957           cases needsLayout() protection does not cover.
       
  8958         
       
  8959         No layout test, these states are very hard or impossible to reach using Javascript interface
       
  8960         (which generally guarantees that updateRendering() is done right after execution).
       
  8961 
       
  8962         * dom/Document.cpp:
       
  8963         (WebCore::Document::recalcStyle):
       
  8964         * page/Frame.cpp:
       
  8965         (WebCore::Frame::paint):
       
  8966         (WebCore::Frame::setPaintRestriction):
       
  8967         (WebCore::Frame::isPainting):
       
  8968         (WebCore::FramePrivate::FramePrivate):
       
  8969         * page/Frame.h:
       
  8970         * page/FramePrivate.h:
       
  8971         * page/FrameView.cpp:
       
  8972         (WebCore::FrameView::layout):
       
  8973         (WebCore::FrameView::needsLayout):
       
  8974 
       
  8975 2007-08-05  Maciej Stachowiak  <mjs@apple.com>
       
  8976 
       
  8977         Reviewed by Darin Adler.
       
  8978         
       
  8979         <rdar://problem/5369110> CrashTracer: [USER] reproducible crash opening particular mail messages
       
  8980 
       
  8981         * platform/network/mac/ResourceHandleMac.mm:
       
  8982         (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Make sure to retain
       
  8983         self for the body of this method. Otherwise, the willSendRequest could trigger events which will
       
  8984         cancel the connection, and we access ivars after this point.
       
  8985         (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): retain and release
       
  8986         in the right order.
       
  8987 
       
  8988 2007-08-04  Adam Roben  <aroben@apple.com>
       
  8989 
       
  8990         Another workaround for <rdar://problem/5386894>
       
  8991 
       
  8992         Reviewed by Sam.
       
  8993 
       
  8994         This fixed ~150 failing tests.
       
  8995 
       
  8996         * platform/network/cf/ResourceResponseCFNet.cpp:
       
  8997         (WebCore::ResourceResponse::doUpdateResourceResponse): Hardcode the
       
  8998         MIME type for .svg files as well.
       
  8999 
       
  9000 2007-08-04  Adam Roben  <aroben@apple.com>
       
  9001 
       
  9002         Workaround for <rdar://problem/5386894> CFURLResponseGetMIMEType returns "text/html" for local .xhtml and .xml files
       
  9003 
       
  9004         Reviewed by Sam.
       
  9005 
       
  9006         This fixes ~350 failing tests.
       
  9007 
       
  9008         * platform/network/cf/ResourceResponseCFNet.cpp:
       
  9009         (WebCore::ResourceResponse::doUpdateResourceResponse): Use a workaround
       
  9010         identical to the one in ResourceResponseMac.mm, but include .xml files
       
  9011         as well.
       
  9012 
       
  9013 2007-08-04  David Kilzer  <ddkilzer@webkit.org>
       
  9014 
       
  9015         Reviewed by Oliver.
       
  9016 
       
  9017         - fix for http://bugs.webkit.org/show_bug.cgi?id=14882
       
  9018           <rdar://problem/5386550> REGRESSION (r24866): text/plain documents are always downloaded
       
  9019 
       
  9020         The supportedNonImageMimeTypes list is used to determine which MIME types may be viewed
       
  9021         within the web browser (e.g., plug-ins add their own MIME types to the list during
       
  9022         initialization), so we must add "text/plain" and "text/" back to the list.  Since
       
  9023         this change would then break DOMImplementation::isTextMIMEType(), that method was reverted
       
  9024         to its original form and MIMETypeRegistry::shouldTreatAsText() was removed.
       
  9025 
       
  9026         * dom/DOMImplementation.cpp:
       
  9027         (WebCore::DOMImplementation::isTextMIMEType): Revert to previous version.
       
  9028         * platform/MIMETypeRegistry.cpp:
       
  9029         (WebCore::initialiseSupportedNonImageMimeTypes): Added back "text/plain" and "text/" to the list.
       
  9030         (WebCore::MIMETypeRegistry::shouldTreatAsText): Removed.
       
  9031         * platform/MIMETypeRegistry.h:
       
  9032 
       
  9033 2007-08-03  Brady Eidson  <beidson@apple.com>
       
  9034 
       
  9035         Reviewed by Oliver
       
  9036 
       
  9037         Fix for http://bugs.webkit.org/show_bug.cgi?id=14824 and <rdar://problem/5372989>
       
  9038 
       
  9039         Two issues - 
       
  9040         1 - The WebCore MIMEType registry was designed assuming the list of types would never change
       
  9041             That is false, as WebKit has API and SPI calls which directly mutate the MIMETypeRegistry
       
  9042         2 - DOMImplementation didn't consult the registry for any MIMEType that started with "text/", 
       
  9043             instead maintaining it's own hard coded rules
       
  9044 
       
  9045         * dom/DOMImplementation.cpp:
       
  9046         (WebCore::DOMImplementation::isTextMIMEType): For now, call through to the MIMETypeRegistry
       
  9047           until we decided a different fate for this function
       
  9048 
       
  9049         * platform/MIMETypeRegistry.cpp:
       
  9050         (WebCore::initialiseSupportedNonImageMimeTypes):  "SupportedNonImageMIMETypes" is really a misnomer for 
       
  9051           "MIMETypes we should show as HTML" but that line has slowly been blurred since Tiger.  In an attempt
       
  9052           to start to unblur it, remove "text/" and "text/plain"
       
  9053         (WebCore::MIMETypeRegistry::shouldTreatAsText):  The decision is very close to the old DOMImplementation 
       
  9054           method, except we don't automatically hand off "text/" types as true if they are in the set of supported
       
  9055           MIMETypes
       
  9056         (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes): Non-const (can be changed!)
       
  9057         (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes): Non-const (can be changed!)
       
  9058         (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes): Non-const (can be changed!)
       
  9059         * platform/MIMETypeRegistry.h:
       
  9060 
       
  9061 2007-08-03  Adele Peterson  <adele@apple.com>
       
  9062 
       
  9063         Reviewed by Adam.
       
  9064 
       
  9065         Fix for <rdar://problem/5345862> CrashTracer: [USER] 4 crashes in Safari at com.apple.WebCore: WebCore::Frame::isContentEditable const + 10
       
  9066 
       
  9067         Couldn't reproduce the problem, but a nil check for the frame should fix this.
       
  9068 
       
  9069         * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
       
  9070 
       
  9071 2007-08-03  Anders Carlsson  <andersca@apple.com>
       
  9072 
       
  9073         Reviewed by Oliver.
       
  9074 
       
  9075         <rdar://problem/5383286>
       
  9076         XMLHTTPRequest does not return 401 when user cancels authentication dialog (affects .Mac)
       
  9077         
       
  9078         * loader/ResourceLoader.h:
       
  9079         Make receivedCancellation virtual.
       
  9080         
       
  9081         * loader/SubresourceLoader.cpp:
       
  9082         (WebCore::SubresourceLoader::receivedCancellation):
       
  9083         Call SubresourceLoaderClient::receivedCancellation.
       
  9084         
       
  9085         * xml/XMLHttpRequest.cpp:
       
  9086         (WebCore::XMLHttpRequest::receivedCancellation):
       
  9087         Save the failure response.
       
  9088 
       
  9089 2007-08-03  Anders Carlsson  <andersca@apple.com>
       
  9090 
       
  9091         Reviewed by Geoff.
       
  9092 
       
  9093         <rdar://problem/5374393> 
       
  9094         Image change on disk not noticed by WebView; -[WebCache setDisabled:] used to cause a reload every time
       
  9095         
       
  9096         This is essentially a better fix for the crash in <rdar://problem/5362783>.
       
  9097         
       
  9098         * loader/DocLoader.cpp:
       
  9099         (WebCore::DocLoader::requestResource):
       
  9100         If the resource already exists in the m_docResources map, remove it and disassociate it from the doc loader.
       
  9101 
       
  9102 2007-08-03  Oliver Hunt  <oliver@apple.com>
       
  9103 
       
  9104         Reviewed by Geoff.
       
  9105 
       
  9106         <rdar://problem/5375190> Mail crashed in WebCore::CachedImage::imageSize() const when viewing a particular message
       
  9107 
       
  9108         Fix the uncached load path to confirm that the type of resource being 
       
  9109         returned actually matches the type that was requested.
       
  9110 
       
  9111         Also make sure we never create a resource in the Cache for invalid urls.
       
  9112 
       
  9113         * loader/Cache.cpp:
       
  9114         (WebCore::Cache::requestResource):
       
  9115         * loader/DocLoader.cpp:
       
  9116         (WebCore::DocLoader::requestResource):
       
  9117 
       
  9118 2007-08-03  Mitz Pettel  <mitz@webkit.org>
       
  9119 
       
  9120         Reviewed by Adele.
       
  9121 
       
  9122         - fix http://bugs.webkit.org/show_bug.cgi?id=14879
       
  9123           REGRESSION: First item in select (pop-up menu) is displayed even if another item was selected via JavaScript
       
  9124 
       
  9125         Test: fast/forms/menulist-deselect-update.html
       
  9126 
       
  9127         * html/HTMLOptionElement.cpp:
       
  9128         (WebCore::HTMLOptionElement::setSelected): Reordered to allow setSelectedIndex() to call setChanged().
       
  9129 
       
  9130 2007-08-03  Anders Carlsson  <andersca@apple.com>
       
  9131 
       
  9132         Reviewed by Darin.
       
  9133 
       
  9134         <rdar://problem/5286444>
       
  9135         http://bugs.webkit.org/show_bug.cgi?id=14269
       
  9136         REGRESSION: Gmail links stop working after computer sleep
       
  9137         
       
  9138         Add a PowerNotifier object that takes care of resetting and firing the shared timer when coming
       
  9139         back from sleep.
       
  9140         
       
  9141         * platform/mac/SharedTimerMac.cpp:
       
  9142         (-[PowerNotifier init]):
       
  9143         (-[PowerNotifier didWake:]):
       
  9144         (WebCore::setSharedTimerFireTime):
       
  9145 
       
  9146 2007-08-04  Mark Rowe  <mrowe@apple.com>
       
  9147 
       
  9148         Windows build fix.
       
  9149 
       
  9150         * rendering/RenderTextControl.cpp: Don't use the same name for two arguments.
       
  9151 
       
  9152 2007-08-03  Mitz Pettel  <mitz@webkit.org>
       
  9153 
       
  9154         Reviewed by Darin.
       
  9155 
       
  9156         - fix http://bugs.webkit.org/show_bug.cgi?id=14653
       
  9157           REGRESSION (r23994): No caret is drawn after clicking a search field's placeholder text
       
  9158           <rdar://problem/5383841>
       
  9159 
       
  9160         Test: fast/forms/search-click-in-placeholder.html
       
  9161 
       
  9162         Defined a subclass of RenderBlock that never hit-tests children for use in
       
  9163         text controls. This avoids returning placeholder text as the hit node.
       
  9164         Since text controls cannot contain inline elements, there is no harm in
       
  9165         doing that unconditionally, and not just in the case that the field is
       
  9166         showing placeholder text.
       
  9167 
       
  9168         * rendering/RenderTextControl.cpp:
       
  9169         (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
       
  9170         (WebCore::RenderTextControlInnerBlock::~RenderTextControlInnerBlock):
       
  9171         (WebCore::RenderTextControlInnerBlock::nodeAtPoint):
       
  9172         (WebCore::RenderTextControl::createSubtreeIfNeeded):
       
  9173 
       
  9174 2007-08-02  Oliver Hunt  <oliver@apple.com>
       
  9175 
       
  9176         Reviewed by Geoff
       
  9177 
       
  9178         Fix for <rdar://problem/5369332> Xcode crashes while selecting a hyperlink within a AppleScript dictionary (WebCore::Font::drawGlyphBuffer)
       
  9179 
       
  9180         There were many places where we were not correctly retaining/releasing the
       
  9181         NSFont object stored in the C++ PlatformFontData object, this resulted in
       
  9182         the GC incorrectly collecting the NSFont.
       
  9183 
       
  9184         This patch fixes the problem by prevent direct modification of the PlatformFontData
       
  9185         font pointer, allowing us to enforce correct CFRetain/Release behaviour.
       
  9186 
       
  9187         * platform/FontData.h:
       
  9188         (WebCore::FontData::getNSFont):
       
  9189         * platform/mac/FontCacheMac.mm:
       
  9190         (WebCore::FontCache::getFontDataForCharacters):
       
  9191         (WebCore::FontCache::createFontPlatformData):
       
  9192         * platform/mac/FontDataMac.mm:
       
  9193         (WebCore::initFontData):
       
  9194         (WebCore::FontData::platformInit):
       
  9195         (WebCore::FontData::platformDestroy):
       
  9196         (WebCore::FontData::smallCapsFontData):
       
  9197         (WebCore::FontData::containsCharacters):
       
  9198         (WebCore::FontData::determinePitch):
       
  9199         (WebCore::FontData::platformWidthForGlyph):
       
  9200         (WebCore::FontData::checkShapesArabic):
       
  9201         * platform/mac/FontMac.mm:
       
  9202         (WebCore::initializeATSUStyle):
       
  9203         (WebCore::overrideLayoutOperation):
       
  9204         (WebCore::Font::drawGlyphs):
       
  9205         * platform/mac/FontPlatformData.h:
       
  9206         (WebCore::FontPlatformData::FontPlatformData):
       
  9207         (WebCore::FontPlatformData::~FontPlatformData):
       
  9208         (WebCore::FontPlatformData::hash):
       
  9209         (WebCore::FontPlatformData::operator==):
       
  9210         (WebCore::FontPlatformData::font):
       
  9211         (WebCore::FontPlatformData::setFont):
       
  9212 
       
  9213 2007-08-03  Antti Koivisto  <antti@apple.com>
       
  9214 
       
  9215         Oops, this change wasn't supposed to be commited.
       
  9216 
       
  9217         * page/mac/WebCoreFrameBridge.mm:
       
  9218         (-[WebCoreFrameBridge setBaseBackgroundColor:]):
       
  9219 
       
  9220 2007-08-02  Antti Koivisto  <antti@apple.com>
       
  9221 
       
  9222         Reviewed by Darin.
       
  9223 
       
  9224         <rdar://problem/5355951>
       
  9225         plainText() fragments TCMalloc heap badly on large pages
       
  9226         
       
  9227         also likely fixes some cases of
       
  9228         <rdar://problem/5335382>
       
  9229         CrashTracer: [REGRESSION] 73 crashes in Safari at com.apple.WebCore: WebCore::DeprecatedStringData::increaseUnicodeSize + 52
       
  9230         
       
  9231         If you load http://dscoder.com/test.txt with WebKit build with TCMalloc and system malloc you see that
       
  9232         Safari RPRVT with TCMalloc is 118.8MB
       
  9233         Safari RPRVT with system malloc is 69.7MB
       
  9234         
       
  9235         Difference is almost entirely caused by heap fragmentation from a full document plainText() call (for indexing purposes).
       
  9236         
       
  9237         The patch helps in two ways:
       
  9238         - construct plainText string in pieces to avoid O(n^2) reallocs
       
  9239         - allocate buffers using system malloc so they can be returned back to OS and don't fragment and grow TCMalloc heap
       
  9240     
       
  9241         This shrinks http://dscoder.com/test.txt RPRVT to 79.0MB and makes full document plainText() take 50ms instead of 500ms.
       
  9242         The benefits are not limited to extreme cases, web pages above ~200kB can show substantial improvement in RPRVT.
       
  9243 
       
  9244         * editing/TextIterator.cpp:
       
  9245         (WebCore::plainTextToMallocAllocatedBuffer):
       
  9246         (WebCore::plainText):
       
  9247         * editing/TextIterator.h:
       
  9248         * page/mac/WebCoreFrameBridge.mm:
       
  9249         (-[WebCoreFrameBridge selectedString]):
       
  9250         (-[WebCoreFrameBridge stringForRange:]):
       
  9251 
       
  9252 2007-08-02  David Hyatt  <hyatt@apple.com>
       
  9253 
       
  9254         Fix for 5374437, allow comment nodes to be the child of a document.
       
  9255         Refine the check to always make a root element to check documentElement()
       
  9256         rather than firstChild(), since a comment node could be present as the
       
  9257         firstChild() now.
       
  9258 
       
  9259         Reviewed by Tim Hatcher
       
  9260 
       
  9261         * html/HTMLDocument.cpp:
       
  9262         (WebCore::HTMLDocument::childAllowed):
       
  9263         * html/HTMLParser.cpp:
       
  9264         (WebCore::HTMLParser::finished):
       
  9265 
       
  9266 2007-08-02  Antti Koivisto  <antti@apple.com>
       
  9267 
       
  9268         Reviewed by Darin.
       
  9269         
       
  9270         <rdar://problem/5228138>
       
  9271         REGRESSION(Leopard): test failures: tests that test Georgian numbering
       
  9272 
       
  9273         Fix to Georgian number tables to get CSS2.1 test results right. Font has relevant characters now 
       
  9274         which revealed that results were actually wrong. 
       
  9275 
       
  9276         * rendering/RenderListMarker.cpp:
       
  9277         (WebCore::toGeorgian):
       
  9278 
       
  9279 2007-08-02  Ada Chan  <adachan@apple.com>
       
  9280 
       
  9281         Reviewed by Steve.
       
  9282 
       
  9283         <rdar://problem/5079175> Added parameters headerHeight and footerHeight to 
       
  9284         computePageRectsForFrame() so we can account for the header and footer when
       
  9285         calculating page heights for this frame.
       
  9286 
       
  9287         * bridge/win/FrameWin.cpp:
       
  9288         (WebCore::computePageRectsForFrame):
       
  9289         * bridge/win/FrameWin.h:
       
  9290 
       
  9291 2007-08-02  Alice Liu  <alice.liu@apple.com>
       
  9292 
       
  9293         Reviewed by Kevin McCullough.
       
  9294 
       
  9295         fixed <rdar://problem/5310312> REGRESSION: javascript is mis-escaped at http://labs.zarate.org/passwd causing bookmarklet to break
       
  9296         
       
  9297         * WebCore.exp:
       
  9298         expose some calls for WebKit to call. 
       
  9299         * manual-tests/JavaScript-bookmarklets.html: Added.
       
  9300 
       
  9301 2007-08-01  Adam Treat  <treat@kde.org>
       
  9302 
       
  9303         Reviewed by George Staikos.
       
  9304 
       
  9305         Add an interface to manage global history for clients
       
  9306 
       
  9307         * WebCore.pro:
       
  9308         * platform/qt/TemporaryLinkStubs.cpp:
       
  9309 
       
  9310 2007-08-01  Adam Treat  <treat@kde.org>
       
  9311 
       
  9312         Reviewed by George Staikos.
       
  9313 
       
  9314         Do not call update or paint from inside a paint event.
       
  9315 
       
  9316         * platform/qt/ScrollViewQt.cpp:
       
  9317         (WebCore::ScrollView::updateContents):
       
  9318         * platform/qt/WidgetQt.cpp:
       
  9319         (WebCore::Widget::invalidateRect):
       
  9320 
       
  9321 2007-08-01  Timothy Hatcher  <timothy@apple.com>
       
  9322 
       
  9323         Reviewed by Justin.
       
  9324 
       
  9325         <rdar://problem/5376156> Mail crash in DeleteButtonController::hide() when dropping selected image on DIV's border
       
  9326 
       
  9327         Add the container element back so the selection can not touch the deletion UI nodes. The container
       
  9328         has style to prevent user selection, user drag and user modification.
       
  9329 
       
  9330         * editing/DeleteButtonController.cpp:
       
  9331         (WebCore::DeleteButtonController::show): Make the container node, and append the button and outline elements.
       
  9332         (WebCore::DeleteButtonController::hide): Remove the container elements and null out the other nodes.
       
  9333         * editing/DeleteButtonController.h:
       
  9334 
       
  9335 2007-08-01  Steve Falkenburg  <sfalken@apple.com>
       
  9336 
       
  9337         Build mod: Fix sln to match configs in vcproj.
       
  9338         
       
  9339         Reviewed by Adam.
       
  9340 
       
  9341         * WebCore.vcproj/WebCore.make:
       
  9342 
       
  9343 2007-07-31  David Harrison  <harrison@apple.com>
       
  9344 
       
  9345         Reviewed by Justin.
       
  9346 
       
  9347         <rdar://problem/5362659> CrashTracer: [USER] 11 crashes in Mail at WebCore::InsertLineBreakCommand::doApply()
       
  9348 
       
  9349         The problem was that deleting with the X control leaves the selection inside the fragment that was deleted.
       
  9350 
       
  9351         * editing/DeleteButtonController.cpp:
       
  9352         (WebCore::DeleteButtonController::deleteTarget):
       
  9353         Because the deletion UI only appears when the selection is entirely
       
  9354         within the target, we unconditionally update the selection to be
       
  9355         a caret where the target had been.
       
  9356 
       
  9357 2007-07-31  Adele Peterson  <adele@apple.com>
       
  9358 
       
  9359         Reviewed by Hyatt.
       
  9360 
       
  9361          Fix for <rdar://problem/5339395> REGRESSION:http://sudokucraving.com does not render grid correctly
       
  9362 
       
  9363         * rendering/RenderTextControl.h: (WebCore::RenderTextControl::hasControlClip): Clip for search fields.
       
  9364         * rendering/RenderTextControl.cpp:
       
  9365         (WebCore::RenderTextControl::controlClipRect): Added a control clip so the search field's cancel button and magnifier glass
       
  9366          never draw outside the control's bounds.
       
  9367         (WebCore::RenderTextControl::calcPrefWidths): Only include the inner box's padding when calculating the min/max width without using calcContentBoxWidth.
       
  9368          Our old behavior was causing that inner padding to get counted twice.  Also, no need to add in the border
       
  9369          for an inner box that can't be controlled from outside this class.
       
  9370         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::calcPrefWidths): ditto.
       
  9371 
       
  9372 2007-07-31  Anders Carlsson  <andersca@apple.com>
       
  9373 
       
  9374         Reviewed by Geoff.
       
  9375 
       
  9376         Speculative fix for <rdar://problem/5359695> 
       
  9377         REGRESSION (Tiger Beta): Multiple crashes in WebCore::Widget::getView() const + 6
       
  9378                 
       
  9379         * page/EventHandler.cpp:
       
  9380         (WebCore::EventHandler::updateDragAndDrop):
       
  9381         Null check the frame view.
       
  9382 
       
  9383 2007-07-31  Timothy Hatcher  <timothy@apple.com>
       
  9384 
       
  9385         Reviewed by Oliver and Beth.
       
  9386 
       
  9387         <rdar://problem/5211271> ADOBE Leopard 9A410: At the first Launching InDesign after deactivate, EULA page gets blanked.
       
  9388 
       
  9389         Rename needsAcrobatFrameReloadingQuirk to needsAdobeFrameReloadingQuirk, since this now applies to more Adobe applications.
       
  9390 
       
  9391         * WebCore.exp:
       
  9392         * page/Settings.cpp:
       
  9393         (WebCore::Settings::Settings):
       
  9394         (WebCore::Settings::setNeedsAdobeFrameReloadingQuirk):
       
  9395         * page/Settings.h:
       
  9396         (WebCore::Settings::needsAcrobatFrameReloadingQuirk):
       
  9397 
       
  9398 2007-07-31  Matt Perry  <mpComplete@gmail.com>
       
  9399 
       
  9400         Reviewed by Brady and Darin, tweaked by Brady, landed by Brady
       
  9401 
       
  9402         Fix for http://bugs.webkit.org/show_bug.cgi?id=14757 and <rdar://problem/5364692>
       
  9403         HTMLTokenizer::processingData implementation is incorrect
       
  9404 
       
  9405         * html/HTMLTokenizer.cpp:
       
  9406         (WebCore::HTMLTokenizer::processingData): Made it also return true if the HTMLTokenizer was inside the write() call.
       
  9407         * loader/FrameLoader.cpp:
       
  9408         (WebCore::FrameLoader::FrameLoader):
       
  9409         (WebCore::FrameLoader::checkLoadCompleteTimerFired):
       
  9410         (WebCore::FrameLoader::scheduleCheckLoadComplete):
       
  9411         (WebCore::FrameLoader::stopForUserCancel): Changed a call to checkLoadComplete to be asynchronous, since
       
  9412         stopForUserCancel can be called while parsing.
       
  9413         * loader/FrameLoader.h:
       
  9414 
       
  9415 2007-07-31  Anders Carlsson  <andersca@apple.com>
       
  9416 
       
  9417         Reviewed by Geoff.
       
  9418 
       
  9419         <rdar://problem/5371582>
       
  9420         REGRESSION: PLT .5% slower due to r24451 (copying HTMLCollection objects)
       
  9421         
       
  9422         Make the hash maps store CollectionInfo pointers to reduce amount of copying when
       
  9423         inserting/rehashing etc.
       
  9424         
       
  9425         * dom/Document.cpp:
       
  9426         (WebCore::Document::~Document):
       
  9427         (WebCore::Document::nameCollectionInfo):
       
  9428         * dom/Document.h:
       
  9429 
       
  9430 2007-07-31  Sam Weinig  <sam@webkit.org>
       
  9431 
       
  9432         Reviewed by Mitz.
       
  9433 
       
  9434         Fix for http://bugs.webkit.org/show_bug.cgi?id=14825
       
  9435         Non-integer hsl() colours are ignored
       
  9436 
       
  9437         * css/CSSParser.cpp:
       
  9438         (WebCore::CSSParser::parseHSLParameters): Parse hue as a Number,
       
  9439         not an Integer. 
       
  9440 
       
  9441 2007-07-30  Justin Garcia  <justin.garcia@apple.com>
       
  9442 
       
  9443         Reviewed by Darin.
       
  9444 
       
  9445         <rdar://problem/5369009> Crash due to infinite recursion in moveParagraphs on delete
       
  9446         
       
  9447         After the delete, we moved content into the previous block, and a style
       
  9448         rule turned a style span in the moved content into a block, throwing
       
  9449         moveParagraphs into infinite recursion, as it continually tried and failed
       
  9450         to get the style span into the same paragraph as the content just before it.
       
  9451         
       
  9452         Added a method to ReplaceSelectionCommand to keep inserted style spans 
       
  9453         from turning into blocks because of style rules.  Will add code to prevent
       
  9454         other kinds of content from changing appearance because of style rules,
       
  9455         post-Leopard (5371536). Also added a bool to ReplaceSelectionCommand's 
       
  9456         constructor to guard against infinite recursion.
       
  9457 
       
  9458         * editing/CompositeEditCommand.cpp:
       
  9459         (WebCore::CompositeEditCommand::moveParagraphs):
       
  9460         * editing/JSEditor.cpp:
       
  9461         * editing/ReplaceSelectionCommand.cpp:
       
  9462         (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
       
  9463         (WebCore::ReplaceSelectionCommand::negateStyleRulesThatEffectAppearance):
       
  9464         (WebCore::ReplaceSelectionCommand::doApply):
       
  9465         * editing/ReplaceSelectionCommand.h:
       
  9466 
       
  9467 2007-07-30  Anders Carlsson  <andersca@apple.com>
       
  9468 
       
  9469         Reviewed by Brady.
       
  9470 
       
  9471         <rdar://problem/5371515>
       
  9472         BitmapImage::getTIFFRepresentation() bug results in favicons not working at many sites
       
  9473 
       
  9474         Don't bail out if a single frame is invalid.
       
  9475         
       
  9476         * platform/graphics/mac/ImageMac.mm:
       
  9477         (WebCore::BitmapImage::getTIFFRepresentation):
       
  9478 
       
  9479 2007-07-30  Adele Peterson  <adele@apple.com>
       
  9480 
       
  9481         Reviewed by Darin.
       
  9482 
       
  9483         Fix for <rdar://problem/5274937> Safari 3 breaks Missing Sync's WebKit code by crashing
       
  9484 
       
  9485         * loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): Nil check for the FrameLoader.
       
  9486 
       
  9487 2007-07-30  Anders Carlsson  <andersca@apple.com>
       
  9488 
       
  9489         Reviewed by Darin.
       
  9490 
       
  9491         <rdar://problem/5370710> 
       
  9492         REGRESSION: After switching from Bookmark view, the Find Banner won't appear while displaying a PDF file
       
  9493 
       
  9494         Add a hasHTMLView to FrameLoaderClient. This is only useful for clients who can show different views for different
       
  9495         MIME types and URL schemes.
       
  9496         
       
  9497         * loader/FrameLoader.cpp:
       
  9498         (WebCore::FrameLoader::transitionToCommitted):
       
  9499         Call delegate methods here if the current view is not a HTML view.
       
  9500         
       
  9501         * loader/FrameLoaderClient.h:
       
  9502         (WebCore::FrameLoaderClient::hasHTMLView):
       
  9503 
       
  9504 2007-07-30  Sam Weinig  <sam@webkit.org>
       
  9505 
       
  9506         Reviewed by Maciej.
       
  9507 
       
  9508         Fix for <rdar://problem/5363896>
       
  9509         REGRESSION: Setting document.domain does not override port-based cross-frame security checks -- breaks SAP NetWeaver
       
  9510 
       
  9511         Updates the results for:
       
  9512             http/tests/security/cross-frame-access-port-explicit-domain.html
       
  9513             http/tests/security/cross-frame-access-protocol-explicit-domain.html
       
  9514 
       
  9515         * bindings/js/kjs_window.cpp:
       
  9516         (KJS::createWindow): Use the new setDomainInternal method.
       
  9517         (KJS::Window::isSafeScript): Don't set check the port or protocol 
       
  9518         if both documents have explicitly set document.domain in the DOM
       
  9519         and the those domains are equal.
       
  9520         * dom/Document.cpp:
       
  9521         (WebCore::Document::Document):
       
  9522         (WebCore::Document::setDomain): Remove force parameter and change 
       
  9523         all calls that relied on it use the new setDomainInternal method
       
  9524         which does the same thing.
       
  9525         (WebCore::Document::setDomainInternal): 
       
  9526         * dom/Document.h: Add new m_domainWasSetInDOM variable and accessor.
       
  9527         (WebCore::Document::domainWasSetInDOM):
       
  9528         * loader/FrameLoader.cpp:
       
  9529         (WebCore::FrameLoader::checkCallImplicitClose): Use the new setDomainInternal method. 
       
  9530 
       
  9531 2007-07-30  Justin Garcia  <justin.garcia@apple.com>
       
  9532 
       
  9533         Reviewed by Tristan.
       
  9534         
       
  9535         <rdar://problem/5098931> Attachments are lost when they are moved into a ToDo after a delete
       
  9536         
       
  9537         Added an editor client method for asking whether or not it is
       
  9538         OK to merge content after a delete.
       
  9539 
       
  9540         * bridge/EditorClient.h:
       
  9541         * editing/DeleteSelectionCommand.cpp:
       
  9542         (WebCore::DeleteSelectionCommand::mergeParagraphs): Ask if the 
       
  9543         merge is allowed.
       
  9544         * platform/gdk/EditorClientGdk.cpp: 
       
  9545         (WebCore::EditorClientGdk::shouldMoveRangeAfterDelete): Added a method stub.
       
  9546         * platform/gdk/EditorClientGdk.h:
       
  9547         * platform/graphics/svg/SVGImageEmptyClients.h: 
       
  9548         (WebCore::SVGEmptyEditorClient::shouldMoveRangeAfterDelete): Ditto.
       
  9549 
       
  9550 2007-07-30  Alexey Proskuryakov  <ap@webkit.org>
       
  9551 
       
  9552         Reviewed by Anders.
       
  9553 
       
  9554         <rdar://problem/5352526>
       
  9555         http://bugs.webkit.org/show_bug.cgi?id=14704
       
  9556         REGRESSION: sync XMLHttpRequest.send() raises an exception for failed authentication
       
  9557 
       
  9558         Test: http/tests/xmlhttprequest/failed-auth.html
       
  9559 
       
  9560         * platform/network/mac/ResourceHandleMac.mm:
       
  9561         (WebCore::ResourceHandle::loadResourceSynchronously): Make the fake response better match the real one
       
  9562         in case of failed authentication. Unfortunately, NSURLConnection doesn't give us the real response.
       
  9563 
       
  9564         * xml/XMLHttpRequest.cpp:
       
  9565         (WebCore::XMLHttpRequest::send): If the response has an HTTP code in it, then the error wasn't
       
  9566         a network one, and an exception shouldn't be raised.
       
  9567 
       
  9568 2007-07-30  Anders Carlsson  <andersca@apple.com>
       
  9569 
       
  9570         Reviewed by Darin.
       
  9571 
       
  9572         <rdar://problem/4942372> REGRESSION: Anchor links in Mail don't work anymore
       
  9573         
       
  9574         Make it possible for KURL to handle addig fragments to non-hierarchical URLs
       
  9575         such as mailto: and cid:.
       
  9576     
       
  9577         * platform/KURL.cpp:
       
  9578         (WebCore::KURL::init):
       
  9579         If the base URL is not hierarchical but the relative URL is a fragment, then 
       
  9580         allow parsing it.
       
  9581         
       
  9582         (WebCore::KURL::parse):
       
  9583         If the URL is not hierarchical, set the fragment start and end positions correctly.
       
  9584 
       
  9585 2007-07-30  Simon Hausmann  <hausmann@kde.org>
       
  9586 
       
  9587         Reviewed by Lars.
       
  9588 
       
  9589         On Windows make sure the dll also ends up in $$OUTPUT_DIR/bin, so that QtLauncher can find it.
       
  9590 
       
  9591         * WebCore.pro:
       
  9592 
       
  9593 2007-07-30  Simon Hausmann  <hausmann@kde.org>
       
  9594 
       
  9595         Reviewed by Lars.
       
  9596 
       
  9597         Removed the __BUILDING_QT ifdef in JSStringRef.h and changed UChar for the Qt build to use wchar_t on Windows.
       
  9598 
       
  9599         * platform/TextEncoding.cpp:
       
  9600         (WebCore::TextEncoding::encode):
       
  9601 
       
  9602 2007-07-30  Simon Hausmann  <hausmann@kde.org>
       
  9603 
       
  9604         Reviewed by Lars.
       
  9605 
       
  9606         Don't link against libxml/libxslt unless we really need it.
       
  9607 
       
  9608         * WebCore.pro:
       
  9609 
       
  9610 2007-07-29  Tristan O'Tierney  <tristan@apple.com>
       
  9611 
       
  9612         Reviewed by Oliver Hunt.
       
  9613 
       
  9614         <rdar://problem/5369282> REGRESSION: DOMHTMLInput throwing exception due to missing _isEdited method
       
  9615 
       
  9616         * bindings/objc/DOMHTML.mm:
       
  9617         (-[DOMHTMLInputElement _isEdited]):
       
  9618         (-[DOMHTMLTextAreaElement _isEdited]):
       
  9619         * bindings/objc/DOMPrivate.h:
       
  9620         Renamed _isUserEdited to _isEdited.
       
  9621 
       
  9622 2007-07-29  Adam Treat  <treat@kde.org>
       
  9623 
       
  9624         Reviewed by George Staikos.
       
  9625 
       
  9626         Correctly set the update rect for the scrollbars when they are invalidated.
       
  9627         Do not paint entire page for each scroll delta.  Cache the dirty regions
       
  9628         when webkit calls ScrollView::updateContents as webkit expects the paint
       
  9629         routine to use the dirty regions bounding rect.
       
  9630 
       
  9631         These changes greatly reduce the cpu load as we are no longer painting the
       
  9632         entire page for each 1px scroll :P
       
  9633 
       
  9634         * platform/qt/ScrollViewQt.cpp:
       
  9635         (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
       
  9636         (WebCore::ScrollView::updateContents):
       
  9637         (WebCore::ScrollView::paint):
       
  9638         * platform/qt/WidgetQt.cpp:
       
  9639         (WebCore::Widget::invalidateRect):
       
  9640 
       
  9641 2007-07-29  Adele Peterson  <adele@apple.com>
       
  9642 
       
  9643         Reviewed by John.
       
  9644 
       
  9645         WebCore part of fix for <rdar://problem/5102522> REGRESSION: Can't tab to webview that doesn't have editable content (affects Safari, preview pane in Mail)
       
  9646 
       
  9647         * WebCore.exp:
       
  9648         * page/FocusController.cpp:
       
  9649         (WebCore::FocusController::setInitialFocus): Added.
       
  9650         (WebCore::FocusController::advanceFocus): Don't give the focus back to the chrome if this is the initial focus.
       
  9651         * page/FocusController.h:
       
  9652 
       
  9653 2007-07-29  Adam Treat  <treat@kde.org>
       
  9654 
       
  9655         Reviewed by Alexey Proskuryakov.
       
  9656 
       
  9657         WebCore::Widget::setParent should be virtual.
       
  9658         It is reimplemented in ScrollViewQt for instance.
       
  9659 
       
  9660         * platform/Widget.h:
       
  9661 
       
  9662 2007-07-29  Alp Toker  <alp.toker@collabora.co.uk>
       
  9663 
       
  9664         Reviewed by bdash.
       
  9665 
       
  9666         http://bugs.webkit.org/show_bug.cgi?id=14711 (revisited)
       
  9667         RenderThemeGdk's buttons are state-agnostic (pressed, hovered)
       
  9668 
       
  9669         Generalize shadow state into a function.
       
  9670         use a GtkHBox to work around a theme bug (thanks to Nigel Tao).
       
  9671 
       
  9672         * platform/gdk/RenderThemeGdk.cpp:
       
  9673         (WebCore::RenderThemeGdk::determineShadow):
       
  9674         (WebCore::RenderThemeGdk::paintCheckbox):
       
  9675         (WebCore::RenderThemeGdk::paintRadio):
       
  9676         (WebCore::RenderThemeGdk::paintButton):
       
  9677         (WebCore::RenderThemeGdk::gtkWindowContainer):
       
  9678         * platform/gdk/RenderThemeGdk.h:
       
  9679 
       
  9680 2007-07-27  Adele Peterson  <adele@apple.com>
       
  9681 
       
  9682         Reviewed by Darin. 
       
  9683 
       
  9684         Temporary fix for Windows to prevent crashing on all frame pages.  Darin
       
  9685         is working on a more permanent fix.
       
  9686 
       
  9687         * loader/FrameLoader.cpp:
       
  9688 
       
  9689 2007-07-27  Adam Treat  <treat@kde.org>
       
  9690 
       
  9691         Reviewed by David Hyatt.
       
  9692 
       
  9693         Fix crash when using QtWebKit canvas support.
       
  9694 
       
  9695         * ChangeLog:
       
  9696         * html/HTMLCanvasElement.cpp:
       
  9697         (WebCore::HTMLCanvasElement::reset):
       
  9698 
       
  9699 2007-07-27  Darin Adler  <darin@apple.com>
       
  9700 
       
  9701         * rendering/RenderLayer.cpp: Rolled out accidentally-checked-in code.
       
  9702 
       
  9703 2007-07-27  Darin Adler  <darin@apple.com>
       
  9704 
       
  9705         Reviewed by John Sullivan.
       
  9706 
       
  9707         - fix <rdar://problem/5261393> In Mail the plain text alternatives to messages with attachments show weird little OBJ thingies
       
  9708 
       
  9709         The "weird little thingies" are U+FFFC characters. It's good to render them as zero-width, the way we do
       
  9710         with control characters -- helps Mail and doesn't hurt web browsing.
       
  9711 
       
  9712         Test: fast/text/zero-width-characters.html
       
  9713 
       
  9714         * platform/CharacterNames.h: Add names for leftToRightMark, rightToLeftMark, and objectReplacementCharacter.
       
  9715         * platform/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage): Give objectReplacementCharacter
       
  9716         zero width in the same way we do it for the various other characters.
       
  9717 
       
  9718 2007-07-27  Lars Knoll <lars@trolltech.com>
       
  9719 
       
  9720         Reviewed by Zack
       
  9721 
       
  9722         Enable XSLT support for the gtk port.
       
  9723 
       
  9724         * WebCore.pro:
       
  9725 
       
  9726 2007-07-27  Zack Rusin  <zack@kde.org>
       
  9727 
       
  9728         Reviewed by Zack and Lars.
       
  9729 
       
  9730         Premature end after finishing parsing is a fatal error.
       
  9731 
       
  9732         * dom/XMLTokenizer.cpp:
       
  9733         (WebCore::XMLTokenizer::end):
       
  9734 
       
  9735 2007-07-27  Lars Knoll  <lars@trolltech.com>
       
  9736 
       
  9737         Reviewed by Zack and Lars.
       
  9738 
       
  9739         Simplify conversions that go from a QStringRef to a WebCore::String to not use a temporary QString.
       
  9740 
       
  9741         * dom/XMLTokenizer.cpp:
       
  9742         (WebCore::):
       
  9743 
       
  9744 2007-07-27  Zack Rusin  <zack@kde.org>
       
  9745 
       
  9746         Reviewed by Zack and Lars.
       
  9747 
       
  9748         Fix entity handling in the main document content (attributes still broken)
       
  9749 
       
  9750         * dom/XMLTokenizer.cpp:
       
  9751         (WebCore::):
       
  9752 
       
  9753 2007-07-27  Lars Knoll  <lars@trolltech.com>
       
  9754 
       
  9755         Reviewed by Zack and Lars.
       
  9756 
       
  9757         Correctly convert a null QString into a null WebCore::String. Add a String(const QStringRef&) constructor so that we can avoid converting QStringRef via QString to WebCore::String.
       
  9758 
       
  9759         * dom/XMLTokenizer.cpp:
       
  9760         (WebCore::):
       
  9761         * platform/PlatformString.h:
       
  9762         * platform/qt/StringQt.cpp:
       
  9763         (WebCore::String::String):
       
  9764 
       
  9765 2007-07-27  Zack Rusin  <zack@kde.org>
       
  9766 
       
  9767         Reviewed by Zack and Lars.
       
  9768 
       
  9769         Parse version and encoding of the xml document.
       
  9770 
       
  9771         * dom/XMLTokenizer.cpp:
       
  9772         (WebCore::XMLTokenizer::write):
       
  9773 
       
  9774 2007-07-27  Zack Rusin  <zack@kde.org>
       
  9775 
       
  9776         Reviewed by Zack and Lars.
       
  9777 
       
  9778         Correctly or semi-correctly parse the public and system id.
       
  9779 
       
  9780         Patch from Lars.
       
  9781 
       
  9782         * dom/XMLTokenizer.cpp:
       
  9783         (WebCore::):
       
  9784 
       
  9785 2007-07-27  Zack Rusin  <zack@kde.org>
       
  9786 
       
  9787         Reviewed by Zack and Lars.
       
  9788 
       
  9789         Fix uri parsing for attributes.
       
  9790 
       
  9791         * dom/XMLTokenizer.cpp:
       
  9792         (WebCore::):
       
  9793 
       
  9794 2007-07-27  Zack Rusin  <zack@kde.org>
       
  9795 
       
  9796         Reviewed by Zack and Lars.
       
  9797 
       
  9798         Fixing qualified name parsing - from Lars.
       
  9799 
       
  9800         * dom/XMLTokenizer.cpp:
       
  9801         (WebCore::XMLTokenizer::insertErrorMessageBlock):
       
  9802         (WebCore::):
       
  9803 
       
  9804 2007-07-27  Zack Rusin  <zack@kde.org>
       
  9805 
       
  9806         Reviewed by Zack and Lars.
       
  9807 
       
  9808         Parse dtd's
       
  9809 
       
  9810         * dom/XMLTokenizer.cpp:
       
  9811         (WebCore::XMLTokenizer::resumeParsing):
       
  9812         (WebCore::):
       
  9813         * dom/XMLTokenizer.h:
       
  9814 
       
  9815 2007-07-27  Zack Rusin  <zack@kde.org>
       
  9816 
       
  9817         Reviewed by Zack and Lars.
       
  9818 
       
  9819         Implement error handling.
       
  9820 
       
  9821         Add our copyrights
       
  9822 
       
  9823         * dom/XMLTokenizer.cpp:
       
  9824         (WebCore::XMLTokenizer::handleError):
       
  9825         (WebCore::XMLTokenizer::end):
       
  9826         (WebCore::):
       
  9827         * dom/XMLTokenizer.h:
       
  9828 
       
  9829 2007-07-27  Zack Rusin  <zack@kde.org>
       
  9830 
       
  9831         Reviewed by Zack and Lars.
       
  9832 
       
  9833         Making the stylesheets work (plus everything else basically)
       
  9834 
       
  9835         * dom/XMLTokenizer.cpp:
       
  9836         (WebCore::XMLTokenizer::write):
       
  9837         (WebCore::XMLTokenizer::insertErrorMessageBlock):
       
  9838         (WebCore::):
       
  9839         * dom/XMLTokenizer.h:
       
  9840 
       
  9841 2007-07-27  Zack Rusin  <zack@kde.org>
       
  9842 
       
  9843         Reviewed by Zack and Lars.
       
  9844 
       
  9845         Remove the libxml dependency when not compiling with XSLT.
       
  9846 
       
  9847         Just ifdefing, displaying xml doesn't work.
       
  9848 
       
  9849         * WebCore.pro:
       
  9850         * dom/XMLTokenizer.cpp:
       
  9851         (WebCore::XMLTokenizer::XMLTokenizer):
       
  9852         (WebCore::XMLTokenizer::write):
       
  9853         (WebCore::XMLTokenizer::startElementNs):
       
  9854         (WebCore::XMLTokenizer::enterText):
       
  9855         (WebCore::XMLTokenizer::exitText):
       
  9856         (WebCore::XMLTokenizer::initializeParserContext):
       
  9857         (WebCore::XMLTokenizer::end):
       
  9858         (WebCore::XMLTokenizer::lineNumber):
       
  9859         (WebCore::XMLTokenizer::columnNumber):
       
  9860         (WebCore::XMLTokenizer::stopParsing):
       
  9861         (WebCore::XMLTokenizer::resumeParsing):
       
  9862         (WebCore::):
       
  9863         * dom/XMLTokenizer.h:
       
  9864 
       
  9865 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
  9866 
       
  9867         Reviewed by Zack.
       
  9868 
       
  9869         Work around bug in the moc when used as preprocessor for generating the bindings. -DFOO=1 is needed instead of -DFOO
       
  9870         to make the <hash>if FOO conditional match.
       
  9871 
       
  9872         * WebCore.pro:
       
  9873 
       
  9874 2007-07-27  Patrick Hanna  <phanna@email.unc.edu>
       
  9875 
       
  9876         Reviewed by Darin Adler.
       
  9877 
       
  9878         Change PluginBase::refresh to be static and update PluginsFunc::callAsFunction accordingly. Now we no longer
       
  9879         allocate an instance of a JSObject subclass on the stack which could lead to a crash during garbage collection.
       
  9880 
       
  9881         * bindings/js/kjs_navigator.cpp:
       
  9882         (KJS::PluginsFunc::callAsFunction):
       
  9883 
       
  9884 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
  9885 
       
  9886         Done with and reviewed by Lars and Zack.
       
  9887 
       
  9888         Fix snprintf hack for the Qt/Windows build with mingw-gcc. MingW has snprintf, so we don't need this helper function.
       
  9889 
       
  9890         * page/FrameTree.cpp:
       
  9891         * platform/DeprecatedString.cpp:
       
  9892         (WebCore::DeprecatedString::format):
       
  9893         * platform/String.cpp:
       
  9894         (WebCore::String::format):
       
  9895 
       
  9896 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
  9897 
       
  9898         Done with and reviewed by Lars and Zack.
       
  9899 
       
  9900         Make the DocTypeStrings.cpp generation work with MingW. Cleaned it up to be a regular extra compiler at the same time.
       
  9901 
       
  9902         * WebCore.pro:
       
  9903 
       
  9904 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
  9905 
       
  9906         Done with and reviewed by Lars and Zack.
       
  9907 
       
  9908         MingW build fixes: Do the "OBJECTS_TRAILING_SLASH" trick not only for win32-msvc but for all win32 mkspecs. Added LIB/INCLUDE hack from Qt to make us pick up 3rdparty libraries such as libxml from these environment variables.
       
  9909 
       
  9910         * WebCore.pro:
       
  9911 
       
  9912 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
  9913 
       
  9914         Done with and reviewed by Lars and Zack.
       
  9915 
       
  9916         Use $(MOVE) instead of mv to eliminated the shell dependency and replaced the long shell line to call bison and modify the css grammar file with a few lines of portable perl code.
       
  9917 
       
  9918         * WebCore.pro:
       
  9919         * css/makegrammar.pl: Added.
       
  9920 
       
  9921 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
  9922 
       
  9923         Done with and reviewed by Lars and Zack.
       
  9924 
       
  9925         On make install on Windows copy the dll into the bin dir.
       
  9926 
       
  9927         * WebCore.pro:
       
  9928 
       
  9929 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
  9930 
       
  9931         Done with and reviewed by Lars and Zack.
       
  9932 
       
  9933         Link in libxml and libxslt on Windows.
       
  9934 
       
  9935         * WebCore.pro:
       
  9936 
       
  9937 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
  9938 
       
  9939         Done with and reviewed by Lars and Zack.
       
  9940 
       
  9941         Temporarily disable the ICO support for the Qt build on Windows.
       
  9942 
       
  9943         * WebCore.pro:
       
  9944         * platform/graphics/qt/ImageDecoderQt.cpp:
       
  9945 
       
  9946 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
  9947 
       
  9948         Done with and reviewed by Lars and Zack.
       
  9949 
       
  9950         Fix evaluation with ActiveState Perl 5.6. Somehow it tried to treat nameEntries as array.
       
  9951 
       
  9952         * bindings/scripts/CodeGeneratorJS.pm:
       
  9953 
       
  9954 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
  9955 
       
  9956         Done with and reviewed by Lars and Zack.
       
  9957 
       
  9958         Fix compilation with MSVC in the Qt build (missing header files).
       
  9959 
       
  9960         * loader/icon/IconDatabaseNone.cpp:
       
  9961         * platform/graphics/svg/SVGImage.cpp:
       
  9962 
       
  9963 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
  9964 
       
  9965         Done with and reviewed by Lars and Zack.
       
  9966 
       
  9967         Disable the favicon database on Windows for now, to eliminate the sqlite dependency.
       
  9968 
       
  9969         * WebCore.pro:
       
  9970 
       
  9971 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
  9972 
       
  9973         Done with and reviewed by Lars and Zack.
       
  9974 
       
  9975         Added custom preprocessor support to make_names.pl and use the moc for it in the Qt build.
       
  9976 
       
  9977         * WebCore.pro:
       
  9978         * ksvg2/scripts/make_names.pl:
       
  9979 
       
  9980 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
  9981 
       
  9982         Done with and reviewed by Lars and Zack.
       
  9983 
       
  9984         Disable the batch mode for nmake to work around the clash of Node.c and Node.cpp both mapping to Node.obj
       
  9985 
       
  9986         * WebCore.pro:
       
  9987 
       
  9988 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
  9989 
       
  9990         Done with and reviewed by Lars and Zack.
       
  9991 
       
  9992         Fix compilation under Windows (removed sys/time.h dependency, use Qt instead).
       
  9993 
       
  9994         * platform/qt/SystemTimeQt.cpp:
       
  9995 
       
  9996 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
  9997 
       
  9998         Done with and reviewed by Lars and Zack.
       
  9999 
       
 10000         Fix compilation on Windows.
       
 10001 
       
 10002         * platform/graphics/qt/PathQt.cpp:
       
 10003 
       
 10004 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10005 
       
 10006         Done with and reviewed by Lars and Zack.
       
 10007 
       
 10008         Fix generation of ColorData.c on Windows.
       
 10009 
       
 10010         * WebCore.pro:
       
 10011 
       
 10012 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10013 
       
 10014         Done with and reviewed by Lars and Zack.
       
 10015 
       
 10016         Fix compilation under Qt/Windows.
       
 10017 
       
 10018         * loader/icon/IconDatabase.cpp:
       
 10019         (WebCore::IconDatabase::open):
       
 10020 
       
 10021 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10022 
       
 10023         Done with and reviewed by Lars and Zack.
       
 10024 
       
 10025         Changed extendedAttributes to be a variable instead of a hash directly. Required to work with ActiveState perl.
       
 10026 
       
 10027         * bindings/scripts/IDLStructure.pm:
       
 10028 
       
 10029 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10030 
       
 10031         Done with and reviewed by Lars and Zack.
       
 10032 
       
 10033         Fix header guard generation for CSSGrammar.h under Windows
       
 10034 
       
 10035         * WebCore.pro:
       
 10036 
       
 10037 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10038 
       
 10039         Done with and reviewed by Lars and Zack.
       
 10040 
       
 10041         Fix build with moc as preprocessor. Don't rely the preprocessor preserving whitespace at the beginning of lines.
       
 10042 
       
 10043         * bindings/scripts/IDLParser.pm:
       
 10044 
       
 10045 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10046 
       
 10047         Done with and reviewed by Lars and Zack.
       
 10048 
       
 10049         Make make-css-file-arrays.pl work on Windows by not calling /usr/bin/gcc as preprocessor for the Qt build.
       
 10050 
       
 10051         * WebCore.pro:
       
 10052         * css/make-css-file-arrays.pl:
       
 10053 
       
 10054 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10055 
       
 10056         Done with and reviewed by Lars and Zack.
       
 10057 
       
 10058         More gperf commandline fixes for Windows.
       
 10059 
       
 10060         * WebCore.pro:
       
 10061 
       
 10062 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10063 
       
 10064         Done with and reviewed by Lars and Zack.
       
 10065 
       
 10066         More quoting fixes for perl under Windows.
       
 10067 
       
 10068         * WebCore.pro:
       
 10069 
       
 10070 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10071 
       
 10072         Done with and reviewed by Lars and Zack.
       
 10073 
       
 10074         Fix command quoting under Windows
       
 10075 
       
 10076         * WebCore.pro:
       
 10077 
       
 10078 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10079 
       
 10080         Done with and reviewed by Lars and Zack.
       
 10081 
       
 10082         Fix cssmakeprops and cssmakevalue scripts to work on Windows without cygwin perl. Avoid inplace substitutions and direct invocation of /bin/sh. Also call gperf with arguments that GnuWin32's gperf understands.
       
 10083 
       
 10084         * ksvg2/scripts/cssmakeprops:
       
 10085         * ksvg2/scripts/cssmakevalues:
       
 10086 
       
 10087 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10088 
       
 10089         Done with and reviewed by Lars and Zack.
       
 10090 
       
 10091         Beautiful hacks to make more of the extra compiler magic work under Windows outside of cygwin.
       
 10092 
       
 10093         * WebCore.pro:
       
 10094 
       
 10095 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10096 
       
 10097         Done with and reviewed by Lars and Zack.
       
 10098 
       
 10099         Correctly propagate the custom preprocessor option through the idl parser and the codegenerator.
       
 10100 
       
 10101         * bindings/scripts/CodeGenerator.pm:
       
 10102         * bindings/scripts/generate-bindings.pl:
       
 10103 
       
 10104 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10105 
       
 10106         Done with and reviewed by Lars and Zack.
       
 10107 
       
 10108         When constructing the absolute path when searching for IDL files in the list of search paths don't prepend a slash if $SOURCEROOT as environment variable is not set. In the Qt build we pass absolute search paths already and we don't set SOURCEROOT. Under Unix that gives a double slash for the directory which works fine, under Windows we get /c:\webkit\foo which of course does not work.
       
 10109 
       
 10110         * bindings/scripts/CodeGenerator.pm:
       
 10111 
       
 10112 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10113 
       
 10114         Done with and reviewed by Lars and Zack.
       
 10115 
       
 10116         Relax the regular expression that tries to find constant declarations in the IDL source to not require leading whitespace. This makes it work with preprocessors that happen to eliminate leading whitespace.
       
 10117 
       
 10118         * bindings/scripts/IDLParser.pm:
       
 10119 
       
 10120 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10121 
       
 10122         Done with and reviewed by Lars and Zack.
       
 10123 
       
 10124         Try to use the moc as preprocessor for the IDL bindings generator
       
 10125 
       
 10126         * WebCore.pro:
       
 10127 
       
 10128 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10129 
       
 10130         Done with and reviewed by Lars and Zack.
       
 10131 
       
 10132         Make it possible to specify the preprocessor the bindings generator uses instead of hardcoding /usr/bin/gcc (which is of course no option on Windows). Also try to use a more portable and Windows friendly way of opening the reading pipe to the preprocessor.
       
 10133 
       
 10134         * bindings/scripts/IDLParser.pm:
       
 10135         * bindings/scripts/generate-bindings.pl:
       
 10136 
       
 10137 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10138 
       
 10139         Done with and reviewed by Lars and Zack.
       
 10140 
       
 10141         Don't use stdout redirection for make_names.pl as it doesn't work under Windows perl (outside cygwin).
       
 10142 
       
 10143         * ksvg2/scripts/make_names.pl:
       
 10144 
       
 10145 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10146 
       
 10147         Done with and reviewed by Lars and Zack.
       
 10148 
       
 10149         Fix DocTypeStrings.cpp generation to work on Windows with cmd.exe
       
 10150 
       
 10151         * WebCore.pro:
       
 10152 
       
 10153 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10154 
       
 10155         Reviewed by Lars.
       
 10156 
       
 10157         Work around aliasing bugs in WebCore by compiling with -fno-strict-aliasing for gcc builds for now.
       
 10158 
       
 10159         * WebCore.pro:
       
 10160 
       
 10161 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10162 
       
 10163         Reviewed by Lars.
       
 10164 
       
 10165         Use -Wreturn-type only when compiling with g++
       
 10166 
       
 10167         * WebCore.pro:
       
 10168 
       
 10169 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10170 
       
 10171         Reviewed by Zack.
       
 10172 
       
 10173         Don't use pkg-config on Windows for the Qt build
       
 10174 
       
 10175         * WebCore.pro:
       
 10176 
       
 10177 2007-07-27  Simon Hausmann  <hausmann@kde.org>
       
 10178 
       
 10179         Reviewed by Zack.
       
 10180 
       
 10181         Fix compilation with MSVC.
       
 10182 
       
 10183         * platform/graphics/qt/ImageDecoderQt.cpp:
       
 10184 
       
 10185 2007-07-26  Tristan O'Tierney  <tristan@apple.com>
       
 10186 
       
 10187         Reviewed by Anders Carlsson.
       
 10188 
       
 10189         <rdar://problem/5350019> REGRESSION: Pages on milliyet.com are added to Back list when visited, causing Back button to just reload
       
 10190 
       
 10191         * loader/FrameLoader.cpp:
       
 10192         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
       
 10193         If the policy action is FrameLoadTypeRedirectLockHistory, don't add the frame load url to the history.
       
 10194 
       
 10195 2007-07-26  Anders Carlsson  <andersca@apple.com>
       
 10196 
       
 10197         Reviewed by Geoff.
       
 10198 
       
 10199         Add a FIXME about caching pages with plug-ins that have outstanding NPObjects.
       
 10200         
       
 10201         * loader/FrameLoader.cpp:
       
 10202         (WebCore::FrameLoader::canCachePage):
       
 10203 
       
 10204 2007-07-26  David Hyatt  <hyatt@apple.com>
       
 10205 
       
 10206         FIx for <rdar://problem/5289721> CrashTracer: [REGRESSION] 2658 crashes in Safari at com.apple.WebCore: WebCore::RenderInline::height const + 16
       
 10207 
       
 10208         Adding a null check for now and an assert.  We don't know how/why this
       
 10209         bug happens, but hopefully the assert will help people to reproduce.
       
 10210 
       
 10211         Reviewed by kevin
       
 10212 
       
 10213         * rendering/RenderInline.cpp:
       
 10214         (WebCore::RenderInline::height):
       
 10215 
       
 10216 2007-07-26  Anders Carlsson  <andersca@apple.com>
       
 10217 
       
 10218         Reviewed by Oliver.
       
 10219 
       
 10220         <rdar://problem/5362783>
       
 10221         In Mail, a crash occurs at WTF::fastMalloc() when attempting to create a new HTML message from http://nytimes.com/
       
 10222         
       
 10223         If the cache is disabled and there is already a resource with the given URL, return it instead of creating a new one.
       
 10224         
       
 10225         * loader/DocLoader.cpp:
       
 10226         (WebCore::DocLoader::requestResource):
       
 10227 
       
 10228 2007-07-26  Adele Peterson  <adele@apple.com>
       
 10229 
       
 10230         Reviewed by Geoff. 
       
 10231 
       
 10232         Build fix.
       
 10233 
       
 10234         * platform/network/cf/ResourceRequest.h:
       
 10235 
       
 10236 2007-07-26  Anders Carlsson  <andersca@apple.com>
       
 10237 
       
 10238         Reviewed by John Sullivan.
       
 10239 
       
 10240         <rdar://problem/5349389> 
       
 10241         Some frame load delegate methods not called when loading a page from the BF cache
       
 10242         
       
 10243         These calls were moved to FrameLoader::begin, which is never called for pages loaded
       
 10244         from the BF cache. This happened in revision 24490.
       
 10245          
       
 10246         * loader/FrameLoader.cpp:
       
 10247         (WebCore::FrameLoader::transitionToCommitted):
       
 10248         Call delegate methods if the load is from the BF cache.
       
 10249 
       
 10250 2007-07-26  Kevin McCullough  <kmccullough@apple.com>
       
 10251 
       
 10252         Reviewed by Darin, Geoff and Sam.
       
 10253 
       
 10254         - <rdar://problem/5150461> Resizing the window larger than the screen causes no resize.
       
 10255         - We now better match the behavior of other browsers.
       
 10256 
       
 10257         * bindings/js/kjs_window.cpp:
       
 10258         (KJS::constrainToVisible):
       
 10259         (KJS::WindowFunc::callAsFunction):
       
 10260 
       
 10261 2007-07-26  Tristan O'Tierney  <tristan@apple.com>
       
 10262 
       
 10263         Reviewed by Adele Peterson.
       
 10264         
       
 10265         <rdar://problem/5359921> WebCore should maintain a dirty flag for confirmation on unsaved changes
       
 10266 
       
 10267         * bindings/objc/DOMHTML.mm:
       
 10268         (-[DOMHTMLInputElement _isUserEdited]):
       
 10269         (-[DOMHTMLTextAreaElement _isUserEdited]):
       
 10270         Renamed _isEdited to _isUserEdited since the functionality is now different
       
 10271         
       
 10272         * bindings/objc/DOMPrivate.h:
       
 10273         Renamed _isEdited to _isUserEdited.
       
 10274         
       
 10275         * rendering/RenderTextControl.cpp:
       
 10276         (WebCore::RenderTextControl::RenderTextControl):
       
 10277         Defaulted m_userEdited to false
       
 10278         
       
 10279         (WebCore::RenderTextControl::updateFromElement):
       
 10280         Set m_userEdited to false, since the change wasn't triggered first by an edit
       
 10281         
       
 10282         (WebCore::RenderTextControl::subtreeHasChanged):
       
 10283         Set m_userEdited to true, since it has been touched by the user
       
 10284         
       
 10285         * rendering/RenderTextControl.h:
       
 10286         (WebCore::RenderTextControl::isUserEdited):
       
 10287         (WebCore::RenderTextControl::setUserEdited):
       
 10288         Added two new methods to set/return the userEdited boolean value.
       
 10289         
       
 10290 2007-07-26  Geoffrey Garen  <ggaren@apple.com>
       
 10291 
       
 10292         Reviewed by Beth Dakin.
       
 10293 
       
 10294         Fixed NULL-dereference crash seen on buildbot.
       
 10295         
       
 10296         No bug filed because this is a part of <rdar://problem/5241167>.
       
 10297 
       
 10298         * history/PageCache.h:
       
 10299         (WebCore::PageCache::get): NULL-check HistoryItems passed to get()
       
 10300         and remove(), to match the old semantics of HashMap. For clarity,
       
 10301         ASSERT that add() is not called with NULL arguments.
       
 10302 
       
 10303 2007-07-26  Anders Carlsson  <andersca@apple.com>
       
 10304 
       
 10305         Reviewed by Oliver Hunt.
       
 10306 
       
 10307         <rdar://problem/5361106> Crash in user style sheet when loading webpage
       
 10308 
       
 10309         Null check m_frame.
       
 10310         
       
 10311         * dom/Document.cpp:
       
 10312         (WebCore::Document::stylesheetLoaded):
       
 10313 
       
 10314 2007-07-26  Geoffrey Garen  <ggaren@apple.com>
       
 10315 
       
 10316         Used `svn merge -r24646:24645' to revert project changes I accidentally
       
 10317         checked in.
       
 10318 
       
 10319         * WebCore.xcodeproj/project.pbxproj:
       
 10320 
       
 10321 2007-07-26  Geoffrey Garen  <ggaren@apple.com>
       
 10322 
       
 10323         Reviewed by Darin Adler.
       
 10324 
       
 10325         Fixed <rdar://problem/5241167> REGRESSION: PLT 1% slower due to r21793 
       
 10326         (global page cache cap)
       
 10327         
       
 10328         I just measured a .1%-.2% regression in PLT average, but a .4% win in 
       
 10329         PLT fastest run, so I think this regression is licked.
       
 10330 
       
 10331         Surprisingly, the combination of wtf data structures I originally used 
       
 10332         for PageCache turned out to be too slow, so I reworked PageCache to use
       
 10333         a hand-crafted linked list for LRU tracking (instead of ListHashSet), 
       
 10334         to store its CachedPages in the HistoryItems to which they corresponded 
       
 10335         (instead of using a HashMap), and to ref/deref HistoryItems manually
       
 10336         (instead of using RefPtr, which would ref once for every reference in 
       
 10337         the linked list).
       
 10338 
       
 10339         * history/HistoryItem.h: Added data members for PageCache data. Made
       
 10340         PageCache a friend so it could access them. Ideally (from an 
       
 10341         encapsulation perspective), we would store this data an independent 
       
 10342         structure, but that's just too slow.
       
 10343 
       
 10344         * history/PageCache.cpp: Added a hand-crafted linked list for LRU 
       
 10345         tracking.
       
 10346         (WebCore::PageCache::PageCache):
       
 10347         (WebCore::PageCache::add): Adopt the HistoryItem's ref when it's added.
       
 10348         (WebCore::PageCache::remove): deref() the Historyitem when it's 
       
 10349         removed.
       
 10350         (WebCore::PageCache::prune):
       
 10351         (WebCore::PageCache::addToLRUList):
       
 10352         (WebCore::PageCache::removeFromLRUList):
       
 10353 
       
 10354         * history/PageCache.h:
       
 10355         (WebCore::PageCache::get): Inlined just in case.
       
 10356 
       
 10357 2007-07-26  Adam Treat  <treat@kde.org>
       
 10358 
       
 10359         Reviewed by George Staikos.
       
 10360 
       
 10361         Launch the context menu in the right place.
       
 10362 
       
 10363         * platform/qt/ContextMenuQt.cpp:
       
 10364         (WebCore::ContextMenu::setPlatformDescription):
       
 10365 
       
 10366 2007-07-25  Maciej Stachowiak  <mjs@apple.com>
       
 10367 
       
 10368         Reviewed by Mark.
       
 10369 
       
 10370         - follow-up to previous change to avoid assertion failures in debug
       
 10371         
       
 10372         * xml/XMLHttpRequest.cpp:
       
 10373         (WebCore::XMLHttpRequest::getResponseText): hold JSLock when needed
       
 10374         (WebCore::XMLHttpRequest::open): ditto
       
 10375         (WebCore::XMLHttpRequest::didFinishLoading): ditto
       
 10376         (WebCore::XMLHttpRequest::didReceiveData): ditto
       
 10377         * xml/XMLHttpRequest.h:
       
 10378 
       
 10379 2007-07-25  Anders Carlsson  <andersca@apple.com>
       
 10380 
       
 10381         Reviewed by Darin.
       
 10382 
       
 10383         <rdar://problem/5327912> 
       
 10384         iDisk: Web iDisk & main iDisk appear blank
       
 10385         
       
 10386         Prepend any remaining text that scripts might have written.
       
 10387         
       
 10388         * html/HTMLTokenizer.cpp:
       
 10389         (WebCore::HTMLTokenizer::scriptExecution):
       
 10390 
       
 10391 2007-07-25  Kevin McCullough  <kmccullough@apple.com>
       
 10392 
       
 10393         Reviewed by Tim, Darin, Oliver.
       
 10394 
       
 10395         - <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
       
 10396         - Check for file:// urls when clicking links, not block all schemes that are treated as local.
       
 10397 
       
 10398         * loader/FrameLoader.cpp:
       
 10399         (WebCore::FrameLoader::load):
       
 10400 
       
 10401 2007-07-25  Maciej Stachowiak  <mjs@apple.com>
       
 10402 
       
 10403         Reviewed by Darin.
       
 10404 
       
 10405         - fixed <rdar://problem/5300291> Optimize GC to reclaim big, temporary objects (like XMLHttpRequest.responseXML) quickly
       
 10406         
       
 10407         With this plus related JavaScriptCore changes, a number of XMLHttpRequest situations that
       
 10408         result in huge data sets are addressed, including a single huge responseXML on an XMR done
       
 10409         repeatedly, or accessing responseText repeatedly during loading of a single large XHR.
       
 10410         
       
 10411         In addition to the GC changes in JavaScriptCore, I changed responseText to be stored as a
       
 10412         KJS::UString instead of a WebCore::String so that the JavaScript responseText value can
       
 10413         share the buffer (indeed multiple intermediate responseTexts can share its buffer).
       
 10414 
       
 10415         
       
 10416         First of all, here's some manual test cases that will each blow out the process VM without this fix,
       
 10417         but will settle into decent steady state with.
       
 10418         
       
 10419         * manual-tests/memory: Added.
       
 10420         * manual-tests/memory/MessageUidsAlreadyDownloaded2: Added.
       
 10421         * manual-tests/memory/string-growth.html: Added.
       
 10422         * manual-tests/memory/xhr-multiple-requests-responseText.html: Added.
       
 10423         * manual-tests/memory/xhr-multiple-requests-responseXML.html: Added.
       
 10424         * manual-tests/memory/xhr-multiple-requests.html: Added.
       
 10425         * manual-tests/memory/xhr-repeated-string-access.xml: Added.
       
 10426 
       
 10427         And here's the actual code changes:
       
 10428         
       
 10429         * WebCore.xcodeproj/project.pbxproj:
       
 10430         * bindings/js/JSDocumentCustom.cpp:
       
 10431         (WebCore::toJS): Record extra cost if the document is frameless (counting the nodes
       
 10432         doesn't make a measurable performance difference here in any case I could find)
       
 10433         * bindings/js/JSXMLHttpRequest.cpp:
       
 10434         (KJS::JSXMLHttpRequest::getValueProperty): Adjust for the fact that ressponseText
       
 10435         is now stored as a UString.
       
 10436         * bindings/js/kjs_binding.cpp:
       
 10437         (KJS::jsOwnedStringOrNull): New helper.
       
 10438         * bindings/js/kjs_binding.h:
       
 10439         * xml/XMLHttpRequest.cpp:
       
 10440         (WebCore::XMLHttpRequest::getResponseText): It's a UString!
       
 10441         (WebCore::XMLHttpRequest::getResponseXML): handle the fact that m_responseText
       
 10442         is a UString.
       
 10443         (WebCore::XMLHttpRequest::XMLHttpRequest): ditto.
       
 10444         (WebCore::XMLHttpRequest::abort): call dropProtection
       
 10445         (WebCore::XMLHttpRequest::didFinishLoading): call dropProtection
       
 10446         (WebCore::XMLHttpRequest::dropProtection): after removing our GC protection,
       
 10447         report extra cost of this XHR's responseText buffer.
       
 10448         * xml/XMLHttpRequest.h:
       
 10449 
       
 10450 2007-07-25  Timothy Hatcher  <timothy@apple.com>
       
 10451 
       
 10452         Reviewed by Brady.
       
 10453 
       
 10454         <rdar://problem/4796657> table deletion outline does not always follow the table size as editing occurs inside
       
 10455 
       
 10456         Change the outline element to position itself automaticlly using the top, left, bottom and right CSS properties.
       
 10457         This made the container element redundant, so it has been removed. Now the outline element and the delete button
       
 10458         both get appended to the target element and positioned based on that container element. This removes the need
       
 10459         to update the width and height when the target contents changed.
       
 10460 
       
 10461         * editing/DeleteButtonController.cpp:
       
 10462         (WebCore::DeleteButtonController::show): Change the style properties and remove the container element.
       
 10463         (WebCore::DeleteButtonController::hide): Remove the button and outline from the target element.
       
 10464         * editing/DeleteButtonController.h: Removed updateOutlineStyle, respondToChangedContents and m_containerElement.
       
 10465         * editing/Editor.cpp:
       
 10466         (WebCore::Editor::respondToChangedContents): Remove the call to DeleteButtonController respondToChangedContents.
       
 10467 
       
 10468 2007-07-25  Anders Carlsson  <andersca@apple.com>
       
 10469 
       
 10470         Reviewed by Darin.
       
 10471 
       
 10472         <rdar://problem/5344471>
       
 10473         CrashTracer: [USER] 1 crash in Mail at WebCore::PluginTokenizer::writeRawData(char const*, int)
       
 10474         
       
 10475         Make sure to layout so we'll have a renderer. Also null-check the renderer for extra safety.
       
 10476         
       
 10477         * loader/PluginDocument.cpp:
       
 10478         (WebCore::PluginTokenizer::writeRawData):
       
 10479 
       
 10480 2007-07-25  Marvin Decker  <marv.decker@gmail.com>
       
 10481 
       
 10482         Reviewed by Maciej, Darin.
       
 10483 
       
 10484         - http://bugs.webkit.org/show_bug.cgi?id=14030
       
 10485 
       
 10486         Add ResourceHandle::setClient to resolve some messiness with handle
       
 10487         releasing. Clear the client when ResourceLoader is going to release
       
 10488         the handle to prevent crashes in the case where somebody still holds a
       
 10489         reference (this doesn't seem to currently happen in practice). Add
       
 10490         NULL-checking for ResourceHandle implementations using the client.
       
 10491 
       
 10492         * loader/ResourceLoader.cpp:
       
 10493         (WebCore::ResourceLoader::releaseResources):
       
 10494         * platform/network/ResourceHandle.cpp:
       
 10495         (WebCore::ResourceHandle::fireBlockedFailure):
       
 10496         (WebCore::ResourceHandle::setClient):
       
 10497         * platform/network/ResourceHandle.h:
       
 10498         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 10499         (WebCore::willSendRequest):
       
 10500         (WebCore::didReceiveResponse):
       
 10501         (WebCore::didReceiveData):
       
 10502         (WebCore::didFinishLoading):
       
 10503         (WebCore::didFail):
       
 10504         (WebCore::willCacheResponse):
       
 10505         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
       
 10506         (WebCore::ResourceHandle::receivedCancellation):
       
 10507         * platform/network/mac/ResourceHandleMac.mm:
       
 10508         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
       
 10509         (WebCore::ResourceHandle::didCancelAuthenticationChallenge):
       
 10510         (WebCore::ResourceHandle::receivedCancellation):
       
 10511         (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
       
 10512         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
       
 10513         (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
       
 10514         (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
       
 10515         (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):
       
 10516         (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
       
 10517         (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
       
 10518 
       
 10519 2007-07-25  Maxime Britto  <mbritto@pleyo.com>
       
 10520 
       
 10521         Reviewed by Darin.
       
 10522 
       
 10523         - fix http://bugs.webkit.org/show_bug.cgi?id=11756
       
 10524           REGRESSION: link targeting a frame in another window does not work
       
 10525           <rdar://problem/5286420>
       
 10526 
       
 10527         Test: http/tests/navigation/target-frame-from-window.html
       
 10528 
       
 10529         Fix a typo error to really compare the present domain to the domain of the parent of the targeted frame.
       
 10530 
       
 10531         * loader/FrameLoader.cpp: (WebCore::FrameLoader::canTarget):
       
 10532 
       
 10533 2007-07-25  Mitz Pettel  <mitz@webkit.org>
       
 10534 
       
 10535         Reviewed by Darin.
       
 10536 
       
 10537         - fix http://bugs.webkit.org/show_bug.cgi?id=14758
       
 10538           REGRESSION: Repeated text after line break on facebook.com
       
 10539 
       
 10540         Test: fast/text/reset-emptyRun.html
       
 10541 
       
 10542         * platform/BidiResolver.h:
       
 10543         (WebCore::::deleteRuns): Re-add a line that was removed for no reason at all
       
 10544         during refactoring in r24485.
       
 10545         * rendering/bidi.cpp:
       
 10546         (WebCore::BidiState::deleteRuns): Ditto.
       
 10547 
       
 10548 2007-07-24  Oliver Hunt  <oliver@apple.com>
       
 10549 
       
 10550         Reviewed by Adam and Justin.
       
 10551 
       
 10552         <rdar://problem/5141779> WebView editableDOMRangeForPoint: & moveDragCaretToPoint: returns last position in DOMText range
       
 10553 
       
 10554         Remove bridge implementation for editableDOMRangeForPoint: and moveDragCaretToPoint:. 
       
 10555         Now use cross-platform code Editor::rangeForPoint and DragController::placeDragCaret instead.
       
 10556         This required lifting local code from DragController.cpp into the shared methods
       
 10557         Frame::visiblePositionForPoint and Frame::documentAtPoint.
       
 10558 
       
 10559         * WebCore.exp:
       
 10560         * editing/Editor.cpp:
       
 10561         (WebCore::Editor::rangeForPoint):
       
 10562         * editing/Editor.h:
       
 10563         * page/DragController.cpp:
       
 10564         (WebCore::DragController::dragEnded):
       
 10565         (WebCore::DragController::performDrag):
       
 10566         (WebCore::DragController::dragEnteredOrUpdated):
       
 10567         (WebCore::DragController::tryDocumentDrag):
       
 10568         (WebCore::DragController::operationForLoad):
       
 10569         (WebCore::setSelectionToDragCaret):
       
 10570         (WebCore::DragController::concludeDrag):
       
 10571         (WebCore::DragController::placeDragCaret):
       
 10572         * page/DragController.h:
       
 10573         * page/Frame.cpp:
       
 10574         (WebCore::Frame::visiblePositionForPoint):
       
 10575         (WebCore::Frame::documentAtPoint):
       
 10576         * page/Frame.h:
       
 10577         * page/mac/WebCoreFrameBridge.h:
       
 10578         * page/mac/WebCoreFrameBridge.mm:
       
 10579 
       
 10580 2007-07-24  Sam Weinig  <sam@webkit.org>
       
 10581 
       
 10582         Rubber-stamped by Adam Roben.
       
 10583 
       
 10584         Remove unused .strip files.
       
 10585 
       
 10586         * WebCore.xcodeproj/project.pbxproj:
       
 10587 
       
 10588 2007-07-24  Adele Peterson  <adele@apple.com>
       
 10589 
       
 10590         Reviewed by Hyatt.
       
 10591 
       
 10592         Fix for <rdar://problem/5308492> Computed width for elements with box-sizing: border-box is not equal to the width set in the CSS
       
 10593 
       
 10594         Test: fast/css/getComputedStyle-border-box.html
       
 10595 
       
 10596         * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 10597           For the width and height properties, when you get the value from the renderer, use the renderer's box sizing value to determine the size.
       
 10598 
       
 10599 2007-07-24  Anders Carlsson  <andersca@apple.com>
       
 10600 
       
 10601         Reviewed by Kevin Decker.
       
 10602 
       
 10603         <rdar://problem/5355781>
       
 10604         REGRESSION: reproducible crash in CoreFoundation!CFRunLoopFinished on Flash pages
       
 10605         
       
 10606         Null check the loader.
       
 10607         
       
 10608         * plugins/win/PluginStreamWin.cpp:
       
 10609         (WebCore::PluginStreamWin::start):
       
 10610 
       
 10611 2007-07-24  Adele Peterson  <adele@apple.com>
       
 10612 
       
 10613         Reviewed by Hyatt and Adam.
       
 10614 
       
 10615         Fix for <rdar://problem/5130590> REGRESSION: style="width:1px" on <select> element no longer hides the element
       
 10616 
       
 10617         Removed hack that forced large padding on popup buttons.  Now we put that padding in the inner block, so that
       
 10618         the specified width will be honored.
       
 10619 
       
 10620         * rendering/RenderMenuList.cpp:
       
 10621         (WebCore::RenderMenuList::adjustInnerStyle): Set the padding on the inner block based on the metrics provided by the theme.
       
 10622         (WebCore::RenderMenuList::controlClipRect): Clip to the intersection of the inner content box and the outer content box.
       
 10623          This will leave room for the arrows which sit in the inner box padding, and if the inner box ever spills out of the outer box, 
       
 10624          that will get clipped too.
       
 10625         (WebCore::RenderMenuList::calcPrefWidths):  Add in the inner box's padding and border to the pref widths.
       
 10626 
       
 10627         * rendering/RenderThemeMac.mm:
       
 10628         (WebCore::RenderThemeMac::paintMenuList): Only inflate the rect for the shadow if the rect is big enough to fit the whole control.
       
 10629          Also, on Leopard, the NSCell will draw outside of a small rect, so add a clip for that case.
       
 10630         (WebCore::RenderThemeMac::paintMenuListButton): Restrict font scale to make sure the arrows will actually fit in the bounds vertically.
       
 10631          Don't draw the arrows if they won't fit horizontally.  Reset padding.  Since WinIE doesn't honor padding for popups, its not critical to
       
 10632          support padding at this time.
       
 10633         (WebCore::RenderThemeMac::adjustMenuListStyle): Don't set the padding here.  Instead, we're going to set the padding on the inner block of the select.
       
 10634         (WebCore::RenderThemeMac::adjustMenuListButtonStyle): ditto.
       
 10635         (WebCore::RenderThemeMac::popupInternalPaddingLeft): Added.  Provides internal padding values for RenderMenuList.
       
 10636         (WebCore::RenderThemeMac::popupInternalPaddingRight): ditto.
       
 10637         (WebCore::RenderThemeMac::popupInternalPaddingTop): ditto.
       
 10638         (WebCore::RenderThemeMac::popupInternalPaddingBottom): ditto.
       
 10639         * rendering/RenderThemeMac.h:
       
 10640 
       
 10641         * rendering/RenderThemeSafari.cpp:  The same changes that were made to RenderThemeMac were made here, with variations for the arrow differences.
       
 10642           This code should be refactored and shared, but now did not seem like the right time to do that refactoring.
       
 10643         (WebCore::RenderThemeSafari::paintMenuList):
       
 10644         (WebCore::RenderThemeSafari::paintMenuListButton):
       
 10645         (WebCore::RenderThemeSafari::adjustMenuListStyle):
       
 10646         (WebCore::RenderThemeSafari::popupInternalPaddingLeft):
       
 10647         (WebCore::RenderThemeSafari::popupInternalPaddingRight):
       
 10648         (WebCore::RenderThemeSafari::popupInternalPaddingTop):
       
 10649         (WebCore::RenderThemeSafari::popupInternalPaddingBottom):
       
 10650         (WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
       
 10651         * rendering/RenderThemeSafari.h:
       
 10652 
       
 10653         * rendering/RenderTheme.h: Added to provide internal padding values for RenderMenuList.
       
 10654         (WebCore::RenderTheme::popupInternalPaddingLeft):
       
 10655         (WebCore::RenderTheme::popupInternalPaddingRight):
       
 10656         (WebCore::RenderTheme::popupInternalPaddingTop):
       
 10657         (WebCore::RenderTheme::popupInternalPaddingBottom):
       
 10658 
       
 10659 2007-07-24  Lars Knoll  <lars@trolltech.com>
       
 10660 
       
 10661         Reviewed by Adam Roben & David Kilzer.
       
 10662 
       
 10663         replace the makeprop and makevalues shell scripts by equivalent perl versions. This is required to remove the last shell dependency when building QtWebKit on Windows.
       
 10664 
       
 10665         * DerivedSources.make:
       
 10666         * WebCore.pro:
       
 10667         * WebCore.xcodeproj/project.pbxproj:
       
 10668         * css/makeprop: Added.
       
 10669         * css/makeprop.pl: Removed.
       
 10670         * css/makevalues: Added.
       
 10671         * css/makevalues.pl: Removed.
       
 10672 
       
 10673 2007-07-24  Beth Dakin  <bdakin@apple.com>
       
 10674 
       
 10675         Reviewed by Darin.
       
 10676 
       
 10677         Fix for http://bugs.webkit.org/show_bug.cgi?id=14714 REGRESSION: 
       
 10678         ASSERTION FAILED: i < size() in Vector.h:401 on negative -webkit-
       
 10679         column-width
       
 10680         - and -
       
 10681         http://bugs.webkit.org/show_bug.cgi?id=14718 REGRESSION: ASSERTION 
       
 10682         FAILED: i < size() in Vector.h:401 on zero -webkit-column-count
       
 10683 
       
 10684         * rendering/RenderBlock.cpp:
       
 10685         (WebCore::RenderBlock::calcColumnWidth): Make 1 the minimum value 
       
 10686         for column-width and column-count. Since the spec does not address 
       
 10687         what to do with negative values for these properties, we are 
       
 10688         patching the rendering code instead of the parser.
       
 10689 
       
 10690 2007-07-24  Anders Carlsson  <andersca@apple.com>
       
 10691 
       
 10692         Reviewed by Steve.
       
 10693         
       
 10694         <rdar://problem/5355403>
       
 10695         REGRESSION: 303A2 does not display pdf files with AdobeReader 8.1
       
 10696         
       
 10697         Close the file before handing off the file name to the plug-in.
       
 10698         
       
 10699         * plugins/win/PluginStreamWin.cpp:
       
 10700         (WebCore::PluginStreamWin::destroyStream):
       
 10701 
       
 10702 2007-07-24  Alp Toker  <alp.toker@collabora.co.uk>
       
 10703 
       
 10704         Reviewed by Adam.
       
 10705 
       
 10706         http://bugs.webkit.org/show_bug.cgi?id=14711
       
 10707         RenderThemeGdk's buttons are state-agnostic (pressed, hovered)
       
 10708 
       
 10709         Remove unnecessary label from widget instances.
       
 10710         Render check and radio widgets correctly.
       
 10711         Determine the widget state and render it appropriately.
       
 10712 
       
 10713         * platform/gdk/RenderThemeGdk.cpp:
       
 10714         (WebCore::RenderThemeGdk::determineState):
       
 10715         (WebCore::RenderThemeGdk::paintCheckbox):
       
 10716         (WebCore::RenderThemeGdk::paintRadio):
       
 10717         (WebCore::RenderThemeGdk::paintButton):
       
 10718         (WebCore::RenderThemeGdk::gtkButton):
       
 10719         (WebCore::RenderThemeGdk::gtkCheckbox):
       
 10720         (WebCore::RenderThemeGdk::gtkRadioButton):
       
 10721         * platform/gdk/RenderThemeGdk.h:
       
 10722 
       
 10723 2007-07-24  Mark Rowe  <mrowe@apple.com>
       
 10724 
       
 10725         Reviewed by Antti.
       
 10726 
       
 10727         <rdar://problem/5356666> NSMenuItem's seen leaking on buildbot
       
 10728 
       
 10729         * platform/mac/ContextMenuItemMac.mm:
       
 10730         (WebCore::ContextMenuItem::releasePlatformDescription): Transfer ownership from the RetainPtr's CF-based retain
       
 10731         count to the Foundation retain count so that callers of releasePlatformDescription can use -[NSObject release]
       
 10732         to dispose of it in a manner that won't leak under Obj-C GC.
       
 10733         * platform/mac/ContextMenuMac.mm:
       
 10734         (WebCore::ContextMenu::appendItem): Release platformItem as we were transferred its ownership by releasePlatformDescription.
       
 10735         (WebCore::ContextMenu::insertItem): ditto.
       
 10736 
       
 10737 2007-07-24  Mitz Pettel  <mitz@webkit.org>
       
 10738 
       
 10739         Reviewed by Darin.
       
 10740 
       
 10741         - fix http://bugs.webkit.org/show_bug.cgi?id=14684
       
 10742           Hebrew text in Safari chrome is reversed (LTR instead of RTL)
       
 10743 
       
 10744         Test: fast/text/drawBidiText.html
       
 10745 
       
 10746         * WebCore.pro:
       
 10747         * WebCore.vcproj/WebCore.vcproj:
       
 10748         * WebCore.xcodeproj/project.pbxproj:
       
 10749         * WebCoreSources.bkl:
       
 10750         * manual-tests/chrome-bidi-text.html: Added.
       
 10751         * manual-tests/resources/chrome-bidi-text-window.html: Added.
       
 10752         * platform/BidiReorderCharacters.cpp: Removed.
       
 10753         * platform/BidiReorderCharacters.h: Removed.
       
 10754         * platform/BidiResolver.h:
       
 10755         (WebCore::BidiCharacterRun::start): Added accessor method.
       
 10756         (WebCore::BidiCharacterRun::stop): Ditto.
       
 10757         (WebCore::BidiCharacterRun::level): Ditto.
       
 10758         (WebCore::BidiCharacterRun::next): Ditto.
       
 10759         (WebCore::::appendRun): Added default implementation.
       
 10760         * platform/TextStyle.h:
       
 10761         (WebCore::TextStyle::setDirectionalOverride): Added accessor method.
       
 10762         * platform/graphics/GraphicsContext.cpp:
       
 10763         (WebCore::TextRunIterator::TextRunIterator): Added. A BidiResolver-
       
 10764         compliant iterator over the characters in a TextRun.
       
 10765         (WebCore::TextRunIterator::offset):
       
 10766         (WebCore::TextRunIterator::increment):
       
 10767         (WebCore::TextRunIterator::atEnd):
       
 10768         (WebCore::TextRunIterator::current):
       
 10769         (WebCore::TextRunIterator::direction):
       
 10770         (WebCore::TextRunIterator::operator==):
       
 10771         (WebCore::TextRunIterator::operator!=):
       
 10772         (WebCore::GraphicsContext::drawBidiText): Added. Applies the Unicode
       
 10773         Bidi Algorithm to the text and draws the resulting unidirectional runs
       
 10774         in the right order and with the right directionality.
       
 10775         * platform/graphics/GraphicsContext.h:
       
 10776         * platform/win/PopupMenuWin.cpp:
       
 10777         (WebCore::PopupMenu::paint): Replaced the use of a character buffer
       
 10778         and BidiReorderCharacters with calling to drawBidiText(). Removed special
       
 10779         handling of '-webkit-rtl-ordering:visual' because that CSS property is an
       
 10780         implementation detail of WebCore's visual Hebrew support, and the UA stylesheet
       
 10781         sets it to 'logical' for this form control. Authors can specify the ordering
       
 10782         using the 'direction' and 'unicode-bidi' properties.
       
 10783         * platform/win/WebCoreTextRenderer.cpp:
       
 10784         (WebCore::isOneLeftToRightRun): Added. Checks if the text consists of
       
 10785         a single left-to-right run, in which case it requires no bidi processing.
       
 10786         (WebCore::doDrawTextAtPoint): Changed to call drawBidiText if the text
       
 10787         is not entirely left-to-right.
       
 10788         * rendering/RenderFileUploadControl.cpp:
       
 10789         (WebCore::RenderFileUploadControl::paintObject): Replaced the use of a
       
 10790         character buffer in BidiReorderCharacters with calling to drawBidiText().
       
 10791         Removed special handling of '-webkit-rtl-ordering:visual' for the same reason
       
 10792         stated above.
       
 10793         * rendering/RenderListBox.cpp:
       
 10794         (WebCore::RenderListBox::paintItemForeground): Ditto. Also changed the
       
 10795         run-rounding modes used when drawing to match those used when measuring.
       
 10796 
       
 10797 2007-07-23  Oliver Hunt  <oliver@apple.com>
       
 10798 
       
 10799         Reviewed by Steve.
       
 10800 
       
 10801         Windows build fix, remove superfluous !
       
 10802 
       
 10803         * page/EventHandler.cpp:
       
 10804         (WebCore::EventHandler::keyEvent):
       
 10805 
       
 10806 2007-07-23  Adam Roben  <aroben@apple.com>
       
 10807 
       
 10808         Add an assignment operator for BString that takes a BSTR
       
 10809 
       
 10810         Reviewed by Geoff and Oliver.
       
 10811 
       
 10812         * platform/win/BString.cpp:
       
 10813         (WebCore::BString::operator=):
       
 10814         * platform/win/BString.h:
       
 10815 
       
 10816 2007-07-23  Justin Garcia  <justin.garcia@apple.com>
       
 10817 
       
 10818         Reviewed by Geoff.
       
 10819         
       
 10820         <rdar://problem/5354455> Word selection when right-clicking can be confusing (14728)
       
 10821 
       
 10822         * page/EventHandler.cpp:
       
 10823         (WebCore::EventHandler::sendContextMenuEvent): In non-editable content,
       
 10824         only do word selection over text.  In editable content, we will continue
       
 10825         to select images, line breaks and other elements on right-clicks, to match 
       
 10826         TextEdit.  For now, in editable content, we'll live with the cases where 
       
 10827         positionForPoint creates selections that aren't underneath the mouse.  These
       
 10828         aren't regressions because we've always done word selection on right clicks
       
 10829         in editable content.
       
 10830 
       
 10831 2007-07-23  Anders Carlsson  <andersca@apple.com>
       
 10832 
       
 10833         Reviewed by Oliver.
       
 10834 
       
 10835         <rdar://problem/5335354>
       
 10836         REGRESSION(r21359-r21368): Can't edit inside RTEF editable region
       
 10837         
       
 10838         If Document::open is called and there's a pending load that has not yet started,
       
 10839         that load should be cancelled.
       
 10840         
       
 10841         * dom/Document.cpp:
       
 10842         (WebCore::Document::open):
       
 10843 
       
 10844 2007-07-23  Timothy Hatcher  <timothy@apple.com>
       
 10845 
       
 10846         Reviewed by Hyatt.
       
 10847 
       
 10848         <rdar://problem/5242145> REGRESSION: Clicking on symbol in documentation often doesn't scroll to symbol
       
 10849 
       
 10850         A renderer for the anchor wasn't always available at the time parsing finished. So we need
       
 10851         to bail out of gotoAnchor if stylesheets are pending and remember to call gotoAnchor later
       
 10852         once all of the pending stylesheets load.
       
 10853 
       
 10854         * dom/Document.cpp:
       
 10855         (WebCore::Document::Document): Initialize m_gotoAnchorNeededAfterStylesheetsLoad to false.
       
 10856         (WebCore::Document::stylesheetLoaded): If we have no more pending stylesheets, call gotoAnchor if needed.
       
 10857         * dom/Document.h:
       
 10858         (WebCore::Document::gotoAnchorNeededAfterStylesheetsLoad): New method.
       
 10859         (WebCore::Document::setGotoAnchorNeededAfterStylesheetsLoad): Ditto.
       
 10860         * loader/FrameLoader.cpp:
       
 10861         (WebCore::FrameLoader::gotoAnchor): Bail early if the document still has pending stylesheets.
       
 10862         * loader/FrameLoader.h: Make gotoAnchor() public.
       
 10863 
       
 10864 2007-07-23  John Sullivan  <sullivan@apple.com>
       
 10865 
       
 10866         Reviewed by Darin
       
 10867         
       
 10868         - fixed <rdar://problem/5327887> Printing Mail note (or Safari page) with misspelled word prints red underline
       
 10869 
       
 10870         * rendering/InlineTextBox.cpp:
       
 10871         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
       
 10872         When printing, bail out without doing any work. Also moved a couple of lines down below another early
       
 10873         bailout since they were pointless above it.
       
 10874 
       
 10875 2007-07-23  Oliver Hunt  <oliver@apple.com>
       
 10876 
       
 10877         Reviewed by Darin.
       
 10878         
       
 10879         <rdar://problem/5353577> WebKit key event behaviour needs to better match other browsers keyevent behaviour
       
 10880         <rdar://problem/5352152> REGRESSION (24399-24479): Pressing Enter in a search field at apple.com no longer starts a search with Korean IM
       
 10881         <rdar://problem/5352649> WebKit should send keyDown event on autorepeat keyDowns
       
 10882         http://bugs.webkit.org/show_bug.cgi?id=14690
       
 10883 
       
 10884         Perform Input Method call first so that our behaviour is determined by whether or not 
       
 10885         the input method has actually handle the event, rather than by making guesses based 
       
 10886         on the existences of marked text.  This fixes issues with IMs that have side effects
       
 10887         even on events they do not handle.
       
 10888 
       
 10889         Refactored the code in order to improve clarity given the hoisting required by performing
       
 10890         the IM call earlier.
       
 10891 
       
 10892         * page/EventHandler.cpp:
       
 10893         (WebCore::EventHandler::keyEvent):
       
 10894 
       
 10895 2007-07-23  Anders Carlsson  <andersca@apple.com>
       
 10896 
       
 10897         Reviewed by Darin.
       
 10898 
       
 10899         <rdar://problem/5045711> 
       
 10900         http://bugs.webkit.org/show_bug.cgi?id=12938
       
 10901         Google calendar settings page crashes
       
 10902         
       
 10903         Move handling of checked radio buttons to a new class, HTMLFormElement::CheckedRadioButtons. 
       
 10904         Each <form> element has an instance of this class. For radio buttons without a containing 
       
 10905         form, the document has an instance of HTMLFormElement::CheckedRadioButtons where the
       
 10906         state of those radio buttons will be stored.
       
 10907         be stored.
       
 10908         
       
 10909         This also fixes another bug where removing a checked radio button that does not have a
       
 10910         containing form would not remove the radio button from the checked radio buttons map,
       
 10911         which could lead to a crash due to a dangling pointer.
       
 10912         
       
 10913         * dom/Document.cpp:
       
 10914         (WebCore::Document::~Document):
       
 10915         * dom/Document.h:
       
 10916         (WebCore::Document::checkedRadioButtons):
       
 10917         * html/HTMLFormElement.cpp:
       
 10918         (WebCore::HTMLFormElement::registerFormElement):
       
 10919         (WebCore::HTMLFormElement::removeFormElement):
       
 10920         (WebCore::HTMLFormElement::CheckedRadioButtons::didCheckButton):
       
 10921         (WebCore::HTMLFormElement::CheckedRadioButtons::checkedButtonForGroup):
       
 10922         (WebCore::HTMLFormElement::CheckedRadioButtons::removeButtonIfChecked):
       
 10923         * html/HTMLFormElement.h:
       
 10924         (WebCore::HTMLFormElement::checkedRadioButtons):
       
 10925         * html/HTMLGenericFormElement.cpp:
       
 10926         (WebCore::HTMLGenericFormElement::insertedIntoTree):
       
 10927         * html/HTMLInputElement.cpp:
       
 10928         (WebCore::HTMLInputElement::~HTMLInputElement):
       
 10929         (WebCore::checkedRadioButtons):
       
 10930         (WebCore::HTMLInputElement::isKeyboardFocusable):
       
 10931         (WebCore::HTMLInputElement::setInputType):
       
 10932         (WebCore::HTMLInputElement::parseMappedAttribute):
       
 10933         (WebCore::HTMLInputElement::setChecked):
       
 10934         (WebCore::HTMLInputElement::preDispatchEventHandler):
       
 10935         (WebCore::HTMLInputElement::willMoveToNewOwnerDocument):
       
 10936         * manual-tests/remove-form-node-with-radio-buttons-crash.html: Added.
       
 10937 
       
 10938 2007-07-23  David Hyatt  <hyatt@apple.com>
       
 10939 
       
 10940         Fix for 5350587, hang in iExploder text 8101.  The code that painted outlines for continuations was buggy
       
 10941         in that it assumed the chain was always inline-block-inline, but this is only true for the innermost chained
       
 10942         continuation.  To make this more robust, we always just use the inline's containing block's containing block,
       
 10943         which should be guaranteed to enclose all renderers in the continuation chain.  In addition, there is now a
       
 10944         null check (to guarantee no more hangs) and an assert (to check if we hit this situation again where the block
       
 10945         used to paint does not properly enclose the continuation chain).
       
 10946 
       
 10947         Reviewed by beth
       
 10948 
       
 10949         fast/inline/outline-continuation.html
       
 10950 
       
 10951         * rendering/RenderBlock.cpp:
       
 10952         (WebCore::RenderBlock::paintContinuationOutlines):
       
 10953         * rendering/InlineFlowBox.cpp:
       
 10954         (WebCore::RenderInline::paint):
       
 10955 
       
 10956 2007-07-22  Holger Hans Peter Freyther  <zecke@selfish.org>
       
 10957 
       
 10958         Reviewed by Adam.
       
 10959 
       
 10960         WARNING: NO TEST CASES ADDED OR CHANGED
       
 10961 
       
 10962         Add the WebKit/Gtk API to the buildsystem, ask qmake to create a
       
 10963         pkg-config file and install headers and libraries.
       
 10964 
       
 10965         Start to emit signals from FrameLoaderClientGdk, hide the kit Frame
       
 10966         inside the the FrameLoaderClientGdk.
       
 10967 
       
 10968         Move ChromeClientGdk to WebKit/gtk/WebCoreSupport
       
 10969 
       
 10970         * WebCore.pro:
       
 10971         * loader/gdk/FrameLoaderClientGdk.cpp:
       
 10972         * loader/gdk/FrameLoaderClientGdk.h:
       
 10973         * platform/gdk/ChromeClientGdk.h: Removed.
       
 10974         * platform/gdk/FrameGdk.cpp: Remove code not belonging here
       
 10975         * platform/gdk/FrameGdk.h:
       
 10976         * platform/gdk/ScrollViewGdk.cpp: The gdkDrawable won't exist at that time and it is fine
       
 10977         * platform/gdk/TemporaryLinkStubs.cpp: Removed ChromeClientGdk stubs
       
 10978 
       
 10979 2007-07-22  Maciej Stachowiak  <mjs@apple.com>
       
 10980 
       
 10981         Reviewed by Adam.
       
 10982 
       
 10983         <rdar://problem/5353174> REGRESSION: 1% JavaScript performance regression fro Window refactoring (14717)
       
 10984         http://bugs.webkit.org/show_bug.cgi?id=14717
       
 10985         
       
 10986         * bindings/js/kjs_window.cpp:
       
 10987         * bindings/js/kjs_window.h:
       
 10988         (KJS::Window::impl): inlined
       
 10989         * page/DOMWindow.cpp:
       
 10990         * page/DOMWindow.h:
       
 10991         (WebCore::DOMWindow::frame): inlined
       
 10992 
       
 10993 2007-07-22  Darin Adler  <darin@apple.com>
       
 10994 
       
 10995         * platform/ContextMenu.cpp: Added missing include.
       
 10996 
       
 10997 2007-07-22  Sam Weinig  <sam@webkit.org>
       
 10998 
       
 10999         Reviewed by Darin.
       
 11000 
       
 11001         Fix for http://bugs.webkit.org/show_bug.cgi?id=14682
       
 11002         REGRESSION(24285-24399): alerts do not appear at W3C RTL test page
       
 11003 
       
 11004         Test: fast/dom/Window/window-function-name-getter-precedence.html
       
 11005 
       
 11006         * bindings/js/JSDOMWindowCustom.cpp:
       
 11007         (WebCore::JSDOMWindow::customGetOwnPropertySlot): Make sure to return functions
       
 11008         before the custom name getter.
       
 11009 
       
 11010 2007-07-22  Darin Adler  <darin@apple.com>
       
 11011 
       
 11012         Reviewed by Adam.
       
 11013 
       
 11014         - fix <rdar://problem/5353263> ContextMenuItem and ContextMenu objects leaking (seen on buildbot)
       
 11015 
       
 11016         * platform/ContextMenu.cpp:
       
 11017         (WebCore::separatorItem): Return an auto_ptr instead of a raw pointer, since this function
       
 11018         creates an object that's the caller's responsibility to delete.
       
 11019         (WebCore::createAndAppendFontSubMenu): Create the context menu on the stack, not the heap,
       
 11020         since setSubMenu does not take ownership, and hence the objects were leaking.
       
 11021         (WebCore::createAndAppendSpellingAndGrammarSubMenu): Ditto.
       
 11022         (WebCore::createAndAppendSpellingSubMenu): Ditto.
       
 11023         (WebCore::createAndAppendSpeechSubMenu): Ditto.
       
 11024         (WebCore::createAndAppendWritingDirectionSubMenu): Ditto.
       
 11025 
       
 11026 2007-07-22  Darin Adler  <darin@apple.com>
       
 11027 
       
 11028         Reviewed by Kevin Decker.
       
 11029 
       
 11030         - fix <rdar://problem/5126394> REGRESSION: Crash after clicking back button in test application (13250)
       
 11031           http://bugs.webkit.org/show_bug.cgi?id=13250
       
 11032 
       
 11033         * bindings/objc/WebScriptObject.mm:
       
 11034         (_didExecute): Removed unnecessary check for isValid() since the _rootObject method already
       
 11035         takes care of that check.
       
 11036         (-[WebScriptObject _imp]): Made this return 0 if there is not a valid rootObject.
       
 11037         (-[WebScriptObject _isSafeScript]): Made this always return false if there is not a valid
       
 11038         rootObject, eliminating the need to check _rootObject for nil if the code is checking _isSafeScript.
       
 11039         (-[WebScriptObject callWebScriptMethod:withArguments:]): Removed check of _rootObject, since it's
       
 11040         immediately followed by a check of _isSafeScript. Removed awkward conversion of name from NSString *
       
 11041         to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no
       
 11042         arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check
       
 11043         the _imp pointer. Added a second check of _isSafeScript after calling get to get the function
       
 11044         object, since arbitrary changes could occur in there, including navigation to a new frame.
       
 11045         This also takes care of null checking the second call to _imp.
       
 11046         (-[WebScriptObject evaluateWebScript:]): Removed check of _rootObject, since it's
       
 11047         immediately followed by a check of _isSafeScript. Removed awkward conversion of script from NSString *
       
 11048         to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no
       
 11049         arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check
       
 11050         the _imp pointer.
       
 11051         (-[WebScriptObject setValue:forKey:]): Removed check of _rootObject, since it's
       
 11052         immediately followed by a check of _isSafeScript. Removed awkward conversion of key from NSString *
       
 11053         to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no
       
 11054         arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check
       
 11055         the _imp pointer.
       
 11056         (-[WebScriptObject valueForKey:]): Ditto.
       
 11057         (-[WebScriptObject removeWebScriptKey:]): Ditto.
       
 11058         (-[WebScriptObject stringRepresentation]): Removed check of _rootObject, since it's
       
 11059         immediately followed by a check of _isSafeScript. Removed unnecessary local variable
       
 11060         and const_cast from the call to the _imp method.
       
 11061         (-[WebScriptObject webScriptValueAtIndex:]): Removed check of _rootObject, since it's
       
 11062         immediately followed by a check of _isSafeScript.
       
 11063         (-[WebScriptObject setWebScriptValueAtIndex:value:]): Ditto.
       
 11064         (-[WebScriptObject JSObject]): Ditto.
       
 11065 
       
 11066 2007-07-22  Darin Adler  <darin@apple.com>
       
 11067 
       
 11068         Reviewed by Anders Carlsson and John Sullivan.
       
 11069 
       
 11070         - speculative fix for <rdar://problem/5337500> CrashTracer: [USER] 4 crashes in Mail
       
 11071           at WebCore::HTMLImageElement::isURLAttribute(WebCore::Attribute*) const
       
 11072 
       
 11073         * editing/markup.cpp: Added AttributeChange class.
       
 11074         (WebCore::completeURLs): Changed function so that all the URL completion is done in
       
 11075         a separate pass after finding all the URL attributes. This is safer, since actually
       
 11076         applying an attribute change could have any arbitrary effect on the document; it's
       
 11077         tricky to iterate a document while it's being modified and we don't have the checks
       
 11078         here that would be needed to make that work in pathological cases.
       
 11079 
       
 11080 2007-07-18  Darin Adler  <darin@apple.com>
       
 11081 
       
 11082         Reviewed by Adam.
       
 11083 
       
 11084         - fix <rdar://problem/5350604> REGRESSION: Crash in inspector controller code after
       
 11085           clicking back button in test application (14337)
       
 11086 
       
 11087         * page/InspectorController.cpp: (WebCore::InspectorController::addScriptResource):
       
 11088         Replace an assertion that was firing with some code that at least doesn't immediately crash.
       
 11089 
       
 11090 2007-07-22  Darin Adler  <darin@apple.com>
       
 11091 
       
 11092         Reviewed by Anders.
       
 11093 
       
 11094         - improve the fix for <rdar://problem/5298816> Crash redirecting message,
       
 11095           in -[SharedBufferData initWithSharedBuffer:]; fixes a crash seen on the buildbot
       
 11096 
       
 11097         * loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader): Call setDocLoader(0) on all
       
 11098         the resources so they don't try to use a stale DocLoader pointer later.
       
 11099 
       
 11100 2007-07-21  Mitz Pettel  <mitz@webkit.org>
       
 11101 
       
 11102         Reviewed by Sam Weinig.
       
 11103 
       
 11104         - fixed typos and markup in the following manual tests
       
 11105 
       
 11106         * manual-tests/accidental-strict-mode.html:
       
 11107         * manual-tests/caretScrolling.html:
       
 11108         * manual-tests/close-on-closedWindow.html:
       
 11109 
       
 11110 2007-07-21  Sam Weinig  <sam@webkit.org>
       
 11111 
       
 11112         Reviewed by Mitz.
       
 11113 
       
 11114         Patch for <rdar://problem/5352013>
       
 11115         The computed style for background-position is wrong for the initial value
       
 11116 
       
 11117         - Set the initial value for background-position-x and background-position-y (and
       
 11118           therefore background-position) to 0% instead of 0px.
       
 11119 
       
 11120         * rendering/RenderStyle.cpp:
       
 11121         (WebCore::BackgroundLayer::BackgroundLayer):
       
 11122         * rendering/RenderStyle.h:
       
 11123         (WebCore::RenderStyle::initialBackgroundXPosition):
       
 11124         (WebCore::RenderStyle::initialBackgroundYPosition):
       
 11125 
       
 11126 2007-07-20  Brady Eidson  <beidson@apple.com>
       
 11127 
       
 11128         Reviewed by Adele and Andersca
       
 11129 
       
 11130         <rdar://problem/5336105> - WebBackForwardList created from scratch is unusable (always leads to crash)
       
 11131 
       
 11132         * WebCore.exp: Export the BackForwardList c'tor so WebKit can create one explicitly
       
 11133 
       
 11134 2007-07-20  Sam Weinig  <sam@webkit.org>
       
 11135 
       
 11136         Reviewed by Beth Dakin.
       
 11137 
       
 11138         Fix for <rdar://problem/5351901>
       
 11139         Computed value of border-position should return a CSSValueList, not a CSSPrimitiveValue
       
 11140 
       
 11141         - Return a space separated CSSValueList for background-position
       
 11142           instead of a CSSPrimitiveValue (string type).
       
 11143         - Remove the "else if (renderer)" case as it never returns a different
       
 11144           value than just calling length.value().
       
 11145         - Make background-position-x and background-position-y behave like
       
 11146           background-position.  Fix case of initial value return 'auto' instead
       
 11147           of 0.
       
 11148 
       
 11149         Test: fast/css/getComputedStyle-background-position.html
       
 11150 
       
 11151         * css/CSSComputedStyleDeclaration.cpp:
       
 11152         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 11153 
       
 11154 2007-07-20  Geoffrey Garen  <ggaren@apple.com>
       
 11155 
       
 11156         Build fix for non-Mac platforms.
       
 11157         
       
 11158         * bindings/js/GCController.cpp:
       
 11159 
       
 11160 2007-07-20  Anders Carlsson  <andersca@apple.com>
       
 11161 
       
 11162         Reviewed by Darin.
       
 11163 
       
 11164         If the style sheet requested is a user style sheet, don't store it in the DocLoader's resource map;
       
 11165         user style sheets can outlive their doc loaders.
       
 11166 
       
 11167         * loader/DocLoader.cpp:
       
 11168         (WebCore::DocLoader::requestCSSStyleSheet):
       
 11169 
       
 11170 2007-07-20  Justin Garcia  <justin.garcia@apple.com>
       
 11171 
       
 11172         Reviewed by Darin.
       
 11173 
       
 11174         <rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it
       
 11175         
       
 11176         * bridge/EditorClient.h: Removed a client method for enabling/disabling
       
 11177         word selection on right clicks.
       
 11178         * editing/Editor.cpp: Ditto.
       
 11179         * editing/Editor.h:
       
 11180         * page/EventHandler.cpp:
       
 11181         (WebCore::EventHandler::sendContextMenuEvent): Select the
       
 11182         word underneath the mouse regardless of whether its editable.
       
 11183 
       
 11184 2007-07-20  Ada Chan  <adachan@apple.com>
       
 11185 
       
 11186         Reviewed by Darin and Adam.
       
 11187 
       
 11188         <rdar://problem/5338385> Fixed infinite loop in ScrollView::scrollRectIntoViewRecursively().
       
 11189         Also removed an unused local variable.
       
 11190 
       
 11191         * platform/win/ScrollViewWin.cpp:
       
 11192         (WebCore::ScrollView::scrollRectIntoViewRecursively):
       
 11193 
       
 11194 2007-07-21  Antti  <antti@apple.com>
       
 11195 
       
 11196         Reviewed by Darin.
       
 11197         
       
 11198         Fix <rdar://problem/5305788>
       
 11199         REGRESSION: Safari sometimes loads IE-specific stylesheet on www.apaema.org
       
 11200         
       
 11201         Pick the preferred style sheet set based on document order even if the sheet is still loading. Previously 
       
 11202         the set was chosen based on which stylesheet happened to arrive first. Just fix the problem at hand 
       
 11203         and resist urge to start refactoring this function.
       
 11204 
       
 11205         * dom/Document.cpp:
       
 11206         (WebCore::Document::recalcStyleSelector):
       
 11207 
       
 11208 2007-07-20  Sam Weinig  <sam@webkit.org>
       
 11209 
       
 11210         Reviewed by Darin.
       
 11211 
       
 11212         Fix for <rdar://problem/5351252>
       
 11213         Computed value for -webkit-background-size and border-spacing
       
 11214         should be space separated CSSValueLists.
       
 11215 
       
 11216         * css/CSSComputedStyleDeclaration.cpp:
       
 11217         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 11218 
       
 11219 2007-07-20  Geoffrey Garen  <ggaren@apple.com>
       
 11220 
       
 11221         Suggested by Darin Adler.
       
 11222         
       
 11223         Slight tweak to my last commit: changed gcController() to return a 
       
 11224         reference instead of a pointer.
       
 11225 
       
 11226 2007-07-20  Geoffrey Garen  <ggaren@apple.com>
       
 11227 
       
 11228         Reviewed by Darin Adler.
       
 11229         
       
 11230         Fixed http://bugs.webkit.org/show_bug.cgi?id=12900 Page tear-down 
       
 11231         forces garbage collection once per frame
       
 11232 
       
 11233         Also fixed <rdar://problem/5286989> GC on window close does not always 
       
 11234         bring the JS object count down to 0
       
 11235         
       
 11236         Implemented a 0-delay GC timer in WebCore. Instead of forcing GC
       
 11237         immediately, code that thinks it has created a lot of garbage starts
       
 11238         the timer. This has two advantages: 
       
 11239 
       
 11240         1) Multiple GCs can coalesce. In my pathological test case, this 
       
 11241         improves performance by an order of magnitude. 
       
 11242         
       
 11243         2) Conservative marking is less likely to keep alive important dead
       
 11244         objects, like the window object, because the stack is small and free of
       
 11245         JS processing when the timer fires.
       
 11246 
       
 11247         Added GCController.h/.cpp, sometimes blindly:
       
 11248         * WebCore.pro:
       
 11249         * WebCore.vcproj/WebCore.vcproj:
       
 11250         * WebCore.xcodeproj/project.pbxproj:
       
 11251         * WebCoreSources.bkl:
       
 11252 
       
 11253         Added singleton that implements GC on a 0-delay timer:
       
 11254         * bindings/js/GCController.h: Added.
       
 11255         * bindings/js/GCController.cpp: Added.
       
 11256         
       
 11257         Changed Collector::collect() calls below to call to the singleton:
       
 11258         * bindings/js/kjs_proxy.cpp:
       
 11259         (WebCore::KJSProxy::~KJSProxy):
       
 11260         * bindings/js/kjs_window.cpp:
       
 11261         (KJS::Window::clear):
       
 11262         * history/CachedPage.cpp:
       
 11263         (WebCore::CachedPage::clear):
       
 11264         
       
 11265         * page/Frame.cpp:
       
 11266         (WebCore::Frame::~Frame): Removed previous slightly hackish attempt to
       
 11267         avoid conservative marking of the window object.
       
 11268 
       
 11269 2007-07-20  Anders Carlsson  <andersca@apple.com>
       
 11270     
       
 11271         Reviewed by Darin.
       
 11272 
       
 11273         <rdar://problem/5298816> Crash redirecting message, in -[SharedBufferData initWithSharedBuffer:]
       
 11274         
       
 11275         Have cached resources keep track of what DocLoader they belong to. This is so that they can remove themselves
       
 11276         from the DocLoader's resource map when they're destroyed when the cache is disabled.
       
 11277         
       
 11278         * html/HTMLImageLoader.cpp:
       
 11279         (WebCore::HTMLImageLoader::updateFromElement):
       
 11280         * loader/Cache.cpp:
       
 11281         (WebCore::Cache::requestResource):
       
 11282         * loader/CachedResource.cpp:
       
 11283         (WebCore::CachedResource::CachedResource):
       
 11284         (WebCore::CachedResource::~CachedResource):
       
 11285         * loader/CachedResource.h:
       
 11286         (WebCore::CachedResource::setDocLoader):
       
 11287 
       
 11288 2007-07-20  Brady Eidson  <beidson@apple.com>
       
 11289 
       
 11290         Reviewed by Darin
       
 11291 
       
 11292         <rdar://problem/5153021> and http://bugs.webkit.org/show_bug.cgi?id=13364
       
 11293 
       
 11294         The issue here was that if a document in a subframe was loaded from a URL, but then a script did 
       
 11295         document.open or document.write during parsing, we would overwrite the document's url and baseurl 
       
 11296         with the parent frame's url.  WRONG!
       
 11297 
       
 11298         * dom/Document.cpp:
       
 11299         (WebCore::Document::open): Only set the url and baseURL in document.open if they are still empty or about:blank
       
 11300 
       
 11301 2007-07-20  Maciej Stachowiak  <mjs@apple.com>
       
 11302 
       
 11303         Reviewed by Oliver.
       
 11304 
       
 11305         <rdar://problem/5326303> REGRESSION: blur event fires upon navigating away from a page with focused element
       
 11306 
       
 11307 
       
 11308         
       
 11309         The proximate cause was the recent change to keep focus on the
       
 11310         WebHTMLView when switching views. But the reason this happend was
       
 11311         that didCommitLoadForFrame got called at a time when the new view
       
 11312         was in place, but the old document was still there. This was a
       
 11313         longstanding problem with the delegate, and fixing it cleans it
       
 11314         up.
       
 11315 
       
 11316         * loader/FrameLoader.cpp:
       
 11317         (WebCore::FrameLoader::begin): Don't send dispatchWindowObjectAvailable if
       
 11318         caller asked not to (this is to allow order of delegates to be the same).
       
 11319         (WebCore::FrameLoader::transitionToCommitted): Don't emit didCommitLoadForFrame here.
       
 11320         (WebCore::FrameLoader::receivedFirstData): Instead do it here, after calling begin(),
       
 11321         so the new document is set up.
       
 11322         * loader/FrameLoader.h: Add new optional parameter to begin().
       
 11323 
       
 11324 2007-07-20  Sam Weinig  <sam@webkit.org>
       
 11325 
       
 11326         Reviewed by Beth Dakin.
       
 11327 
       
 11328         Update for fix for http://bugs.webkit.org/show_bug.cgi?id=14646
       
 11329         <rdar://problem/5340449>
       
 11330 
       
 11331         - Return a CSSValueList instead of CSSValue (with a Pair type) for
       
 11332           computed values of border radii.
       
 11333         - Add ability to CSSValueList to print out a space separated list
       
 11334           instead of a comma.
       
 11335         - Add border radii to list of computed styles that we create and can
       
 11336           iterate over.
       
 11337 
       
 11338         * css/CSSComputedStyleDeclaration.cpp:
       
 11339         (WebCore::):
       
 11340         (WebCore::getBorderRadiusCornerValue):
       
 11341         * css/CSSValueList.cpp:
       
 11342         (WebCore::CSSValueList::CSSValueList):
       
 11343         (WebCore::CSSValueList::cssText):
       
 11344         * css/CSSValueList.h:
       
 11345 
       
 11346 2007-07-20  Mitz Pettel  <mitz@webkit.org>
       
 11347 
       
 11348         Reviewed by Darin.
       
 11349 
       
 11350         - http://bugs.webkit.org/show_bug.cgi?id=14626
       
 11351           Make bidiReorderCharacters independent of RenderBlock
       
 11352 
       
 11353         No layout test possible because there is no change in functionality.
       
 11354 
       
 11355         This patch generalizes RenderBlock's implementation of the Unicode Bidi Algorithm
       
 11356         in the form of the BidiResolver class template. An instance of a BidiResolver class
       
 11357         can generate a sequence of runs with corresponding level and override attributes,
       
 11358         given a range specified by start and end iterators. The iterators can optionally
       
 11359         call back to the BidiResolver instance to push or pop explicit embedding levels.
       
 11360 
       
 11361         The patch replaces BidiState with a specialization of BidiResolver that uses
       
 11362         BidiIterators and generates BidiRuns. It also eliminates some of the file statics
       
 11363         in bidi.cpp, instead relying on BidiResolver data members.
       
 11364 
       
 11365         The patch makes the BidiContext part of BidiStatus, thus making BidiStatus the
       
 11366         entire state that needs to be saved and restored in order to restart the bidi
       
 11367         algorithm at a given point. Previously, you had to keep and pass around two
       
 11368         separate structures, namely the BidiContext and the BidiStatus.
       
 11369 
       
 11370         bidiReorderCharacters is implemented without relying on render objects, using
       
 11371         a BidiResolver specialization that uses simple character buffer iterators and
       
 11372         simple run structures.
       
 11373 
       
 11374         * WebCore.pro:
       
 11375         * WebCore.vcproj/WebCore.vcproj:
       
 11376         * WebCore.xcodeproj/project.pbxproj:
       
 11377         * WebCoreSources.bkl:
       
 11378         * platform/BidiContext.cpp: Added.
       
 11379         (WebCore::operator==):
       
 11380         * platform/BidiContext.h: Added.
       
 11381         (WebCore::BidiContext::BidiContext):
       
 11382         (WebCore::BidiContext::ref):
       
 11383         (WebCore::BidiContext::deref):
       
 11384         (WebCore::BidiContext::parent):
       
 11385         (WebCore::BidiContext::level):
       
 11386         (WebCore::BidiContext::dir):
       
 11387         (WebCore::BidiContext::override):
       
 11388         * platform/BidiReorderCharacters.cpp: Added.
       
 11389         (WebCore::CharacterBufferIterator::CharacterBufferIterator):
       
 11390         (WebCore::CharacterBufferIterator::offset):
       
 11391         (WebCore::CharacterBufferIterator::increment):
       
 11392         (WebCore::CharacterBufferIterator::atEnd):
       
 11393         (WebCore::CharacterBufferIterator::current):
       
 11394         (WebCore::CharacterBufferIterator::direction):
       
 11395         (WebCore::CharacterBufferIterator::operator==):
       
 11396         (WebCore::CharacterBufferIterator::operator!=):
       
 11397         (WebCore::::appendRun):
       
 11398         (WebCore::bidiReorderCharacters):
       
 11399         * platform/BidiReorderCharacters.h: Added.
       
 11400         * platform/BidiResolver.h: Added.
       
 11401         (WebCore::BidiStatus::BidiStatus):
       
 11402         (WebCore::operator==):
       
 11403         (WebCore::operator!=):
       
 11404         (WebCore::BidiCharacterRun::BidiCharacterRun):
       
 11405         (WebCore::BidiCharacterRun::reversed):
       
 11406         (WebCore::BidiCharacterRun::dirOverride):
       
 11407         (WebCore::BidiCharacterRun::next):
       
 11408         (WebCore::BidiResolver::):
       
 11409         (WebCore::BidiResolver::context):
       
 11410         (WebCore::BidiResolver::setContext):
       
 11411         (WebCore::BidiResolver::setLastDir):
       
 11412         (WebCore::BidiResolver::setLastStrongDir):
       
 11413         (WebCore::BidiResolver::setEorDir):
       
 11414         (WebCore::BidiResolver::dir):
       
 11415         (WebCore::BidiResolver::setDir):
       
 11416         (WebCore::BidiResolver::status):
       
 11417         (WebCore::BidiResolver::setStatus):
       
 11418         (WebCore::BidiResolver::adjustEmbedding):
       
 11419         (WebCore::BidiResolver::setAdjustEmbedding):
       
 11420         (WebCore::BidiResolver::firstRun):
       
 11421         (WebCore::BidiResolver::lastRun):
       
 11422         (WebCore::BidiResolver::runCount):
       
 11423         (WebCore::::embed):
       
 11424         (WebCore::::deleteRuns):
       
 11425         (WebCore::::reverseRuns):
       
 11426         (WebCore::::createBidiRunsForLine):
       
 11427         * platform/win/PopupMenuWin.cpp:
       
 11428         (WebCore::PopupMenu::paint):
       
 11429         * rendering/RenderBlock.h:
       
 11430         * rendering/RenderFileUploadControl.cpp:
       
 11431         (WebCore::RenderFileUploadControl::paintObject):
       
 11432         * rendering/RenderListBox.cpp:
       
 11433         (WebCore::RenderListBox::paintItemForeground):
       
 11434         * rendering/RootInlineBox.cpp:
       
 11435         (WebCore::RootInlineBox::childRemoved):
       
 11436         (WebCore::RootInlineBox::lineBreakBidiStatus):
       
 11437         (WebCore::RootInlineBox::setLineBreakInfo):
       
 11438         * rendering/RootInlineBox.h:
       
 11439         (WebCore::RootInlineBox::RootInlineBox):
       
 11440         * rendering/bidi.cpp:
       
 11441         (WebCore::BidiIterator::BidiIterator):
       
 11442         (WebCore::BidiState::deleteRuns):
       
 11443         (WebCore::operator==):
       
 11444         (WebCore::operator!=):
       
 11445         (WebCore::bidiNext):
       
 11446         (WebCore::bidiFirst):
       
 11447         (WebCore::BidiState::addRun):
       
 11448         (WebCore::appendRunsForObject):
       
 11449         (WebCore::BidiState::appendRun):
       
 11450         (WebCore::RenderBlock::constructLine):
       
 11451         (WebCore::RenderBlock::computeHorizontalPositionsForLine):
       
 11452         (WebCore::RenderBlock::computeVerticalPositionsForLine):
       
 11453         (WebCore::RenderBlock::bidiReorderLine):
       
 11454         (WebCore::buildCompactRuns):
       
 11455         (WebCore::RenderBlock::layoutInlineChildren):
       
 11456         (WebCore::RenderBlock::determineStartPosition):
       
 11457         (WebCore::RenderBlock::determineEndPosition):
       
 11458         (WebCore::RenderBlock::matchedEndLine):
       
 11459         (WebCore::RenderBlock::skipWhitespace):
       
 11460         * rendering/bidi.h:
       
 11461         (WebCore::BidiRun::BidiRun):
       
 11462         (WebCore::BidiRun::next):
       
 11463 
       
 11464 2007-07-20  Darin Adler  <darin@apple.com>
       
 11465 
       
 11466         Reviewed by John Sullivan.
       
 11467 
       
 11468         - fix for <rdar://problem/5331723> <rdar://problem/5331723> Safari gives error
       
 11469           103 for URLs that Adobe Lightroom's Preview feature produces, with ":1" in the hostname
       
 11470 
       
 11471         Test: fast/loader/file-URL-with-port-number.html
       
 11472 
       
 11473         * platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::portAllowed):
       
 11474         Don't do any port blocking for file URLs.
       
 11475 
       
 11476 2007-07-20  Mitz Pettel  <mitz@webkit.org>
       
 11477 
       
 11478         Reviewed by Darin.
       
 11479 
       
 11480         - fix http://bugs.webkit.org/show_bug.cgi?id=14689
       
 11481           REGRESSION (3.0.2-TOT): <select> menu items have incorrect background color
       
 11482 
       
 11483         * manual-tests/item-background.html: Added.
       
 11484         * platform/PopupMenuClient.h:
       
 11485         * platform/graphics/Color.cpp:
       
 11486         (WebCore::blendComponent): Renamed the static method blend() to this.
       
 11487         (WebCore::Color::blend): Added. Compositing (in "normal" or "source over"
       
 11488         blend mode) B.blend(C) over A is equivalent to compositing C over the
       
 11489         result of compositing B over A.
       
 11490         (WebCore::Color::blendWithWhite): Changed for the above rename.
       
 11491         * platform/graphics/Color.h:
       
 11492         * platform/win/PopupMenuWin.cpp:
       
 11493         (WebCore::PopupMenu::paint): Changed to use itemBackgroundColor().
       
 11494         * rendering/RenderMenuList.cpp:
       
 11495         (WebCore::RenderMenuList::itemBackgroundColor): Added. Returns the color
       
 11496         that would result from overlaying the item's background color over the
       
 11497         menu's background color over solid white. Note that clientStyle() cannot
       
 11498         be used for the menu's background color, since background color is not
       
 11499         inherited by the inner block (the regression resulted from changing
       
 11500         clientStyle() to return the inner block's style), and that the color
       
 11501         returned from this method is guaranteed to be opaque.
       
 11502         * rendering/RenderMenuList.h:
       
 11503         * rendering/RenderTextControl.cpp:
       
 11504         (WebCore::RenderTextControl::itemBackgroundColor): Added.
       
 11505         * rendering/RenderTextControl.h:
       
 11506 
       
 11507 2007-07-20  Rob Buis  <buis@kde.org>
       
 11508 
       
 11509         Reviewed by Darin.
       
 11510 
       
 11511         http://bugs.webkit.org/show_bug.cgi?id=14642
       
 11512         REGRESSION(r24064-24096): Reflection type effect in canvas tag broke
       
 11513 
       
 11514         Do not stop the fill/stroke operation when encountering an empty path.
       
 11515 
       
 11516         * html/CanvasRenderingContext2D.cpp:
       
 11517         (WebCore::CanvasRenderingContext2D::fill):
       
 11518         (WebCore::CanvasRenderingContext2D::stroke):
       
 11519 
       
 11520 2007-07-20  Lars Knoll  <lars@trolltech.com>
       
 11521 
       
 11522         Reviewed by Simon.
       
 11523 
       
 11524         Remove some files that are not used anymore.
       
 11525 
       
 11526         * platform/qt/FontCacheQt.cpp: Removed.
       
 11527         * platform/qt/FontDataQt.cpp: Removed.
       
 11528         * platform/qt/FontPlatformData.h: Removed.
       
 11529         * platform/qt/FontPlatformDataQt.cpp: Removed.
       
 11530         * platform/qt/GlyphPageTreeNodeQt.cpp: Removed.
       
 11531 
       
 11532 2007-07-20  Lars Knoll  <lars@trolltech.com>
       
 11533 
       
 11534         Reviewed by Simon.
       
 11535 
       
 11536         use the correct font for spaces.
       
 11537 
       
 11538         * platform/qt/FontQt.cpp:
       
 11539         (WebCore::generateComponents):
       
 11540 
       
 11541 2007-07-20  Lars Knoll  <lars@trolltech.com>
       
 11542 
       
 11543         Reviewed by Simon.
       
 11544 
       
 11545         spaces where not correctly taken into account for both offsetForPosition and selectionRectForText. Because of that selections sort of worked in LTR text, but completely failed in RTL.
       
 11546 
       
 11547         * platform/qt/FontQt.cpp:
       
 11548         (WebCore::TextRunComponent::isSpace):
       
 11549         (WebCore::TextRunComponent::TextRunComponent):
       
 11550         (WebCore::generateComponents):
       
 11551         (WebCore::Font::drawText):
       
 11552         (WebCore::Font::offsetForPosition):
       
 11553         (WebCore::Font::selectionRectForText):
       
 11554 
       
 11555 2007-07-20  Lars Knoll  <lars@trolltech.com>
       
 11556 
       
 11557         Reviewed by Simon.
       
 11558 
       
 11559         fix up some smaller issues in selection handling. It's still not perfect and selections in mixed rtl/ltr text are still broken, but it's getting there.
       
 11560 
       
 11561         * platform/qt/FontQt.cpp:
       
 11562         (WebCore::Font::offsetForPosition):
       
 11563         (WebCore::cursorToX):
       
 11564         (WebCore::Font::selectionRectForText):
       
 11565 
       
 11566 2007-07-20  Lars Knoll  <lars@trolltech.com>
       
 11567 
       
 11568         Reviewed by Simon.
       
 11569 
       
 11570         make offsetForPosition and selectionRectForText work correctly with small caps.
       
 11571 
       
 11572         * platform/qt/FontQt.cpp:
       
 11573         (WebCore::Font::offsetForPosition):
       
 11574         (WebCore::cursorToX):
       
 11575         (WebCore::Font::selectionRectForText):
       
 11576 
       
 11577 2007-07-20  Lars Knoll  <lars@trolltech.com>
       
 11578 
       
 11579         Reviewed by Simon.
       
 11580 
       
 11581         clip the drawn text correctly when needed.
       
 11582 
       
 11583         * platform/qt/FontQt.cpp:
       
 11584         (WebCore::Font::drawText):
       
 11585 
       
 11586 2007-07-20  Lars Knoll  <lars@trolltech.com>
       
 11587 
       
 11588         Reviewed by Simon.
       
 11589 
       
 11590         Fix offsetForPosition and selectionRectForText methods.
       
 11591 
       
 11592         * platform/qt/FontQt.cpp:
       
 11593         (WebCore::Font::offsetForPosition):
       
 11594         (WebCore::cursorToX):
       
 11595         (WebCore::Font::selectionRectForText):
       
 11596 
       
 11597 2007-07-20  Lars Knoll  <lars@trolltech.com>
       
 11598 
       
 11599         Reviewed by Simon.
       
 11600 
       
 11601         fix BiDi text rendering.
       
 11602 
       
 11603         * platform/qt/FontQt.cpp:
       
 11604         (WebCore::TextRunComponent::TextRunComponent):
       
 11605         (WebCore::generateComponents):
       
 11606         (WebCore::Font::drawText):
       
 11607 
       
 11608 2007-07-20  Mark Rowe  <mrowe@apple.com>
       
 11609 
       
 11610         Reviewed by Maciej.
       
 11611 
       
 11612         Move FTPDirectoryTokenizer::m_templateDocumentData to be a function-scoped static
       
 11613         to avoid creating a global initializer.  This fixes the build for x86_64.
       
 11614 
       
 11615         * loader/FTPDirectoryDocument.cpp:
       
 11616         (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
       
 11617 
       
 11618 2007-07-19  Geoffrey Garen  <ggaren@apple.com>
       
 11619 
       
 11620         Reviewed by Maciej Stachowiak.
       
 11621         
       
 11622         Fixed <rdar://problem/5347849> Cache eviction of live decoded data is 
       
 11623         thrash-y
       
 11624         
       
 11625         The solution here is to evict live decoded data based on a strict LRU
       
 11626         model. This should work well as a "scrolling window."
       
 11627 
       
 11628         With this patch, I see a substantial reduction in CPU while scrolling
       
 11629         through a page with large images on a low memory system. Layout tests
       
 11630         pass.
       
 11631 
       
 11632         * loader/Cache.h: Changed from a size-based vector of LRU lists to a
       
 11633         single LRU list in order to implement strict LRU.
       
 11634         
       
 11635         * loader/CachedResource.h: Removed tracking of access count, since that
       
 11636         was the old cache eviction model.
       
 11637 
       
 11638 2007-07-19  Oliver Hunt  <oliver@apple.com>
       
 11639 
       
 11640         Reviewed by Maciej.
       
 11641 
       
 11642         <rdar://problem/5076807> REGRESSION: Can't undo conversion of inline text (by hitting ESC)
       
 11643         <rdar://problem/5346167> DOM key events triggered during IME composition differ in webkit/mac vs all windows browsers
       
 11644 
       
 11645         We now basically match the behaviour of IE/Windows. This means that during composition keydown and autorepeat
       
 11646         keys generate keydown events with a keyCode of 229, which correlates to the windows VK_PROCESSKEY message.
       
 11647         keyup events are generated with the keyCode of the actual key that was pressed.
       
 11648 
       
 11649         The only difference is on the first keydown of a composition, in which IE will use keyCode == 229, and we will
       
 11650         send an event with the keyCode for the actual key that was pressed.
       
 11651 
       
 11652         * page/EventHandler.cpp:
       
 11653         (WebCore::EventHandler::keyEvent):
       
 11654         * platform/PlatformKeyboardEvent.h:
       
 11655         (WebCore::PlatformKeyboardEvent::setWindowsKeyCode):
       
 11656 
       
 11657 2007-07-19  Brady Eidson  <beidson@apple.com>
       
 11658 
       
 11659         Reviewed by Sam
       
 11660 
       
 11661         <rdar://problem/5134929> REGRESSION: Colon detected as delimiting an empty port is stripped
       
 11662 
       
 11663         The fix for this was in KURL::parse() which had a slightly changed rule that would strip the colon if there
       
 11664         was no port.
       
 11665 
       
 11666         An additional canonicalization fix was made in window.location.host to match the expected behavior of leaving
       
 11667         the colon in place - before this fix, if the colon was there but no port was there, we'd see the port as 0.
       
 11668 
       
 11669         * bindings/js/kjs_window.cpp:
       
 11670         (KJS::Location::put): Call setHostAndPort instead of setHost and setPort seperately
       
 11671 
       
 11672         * manual-tests/location-host-canonicalization.html: Added.
       
 11673 
       
 11674         * platform/KURL.cpp:
       
 11675         (WebCore::KURL::setHostAndPort): Set the host and port as one string component then reparse the URL
       
 11676         (WebCore::KURL::parse): Change one line to consider the empty colon as part of the host name
       
 11677         * platform/KURL.h:
       
 11678 
       
 11679 2007-07-19  Anders Carlsson  <andersca@apple.com>
       
 11680 
       
 11681         Reviewed by Adam.
       
 11682 
       
 11683         <rdar://problem/5288617>
       
 11684         Crash playing a very large QuickTime movie in Safari
       
 11685         
       
 11686         <rdar://problem/5271174>
       
 11687         http://bugs.webkit.org/show_bug.cgi?id=14148
       
 11688         LEAK: Serious memory consumption and leak when loading QT movies.
       
 11689         
       
 11690         Don't keep plugin stream data in memory since some plugin resources (like QT movies)
       
 11691         can be really big. If a plug-in wants data in a file, create a file and write data to it 
       
 11692         as it's coming from the wire, instead of using a big buffer.
       
 11693         
       
 11694         * loader/ResourceLoader.cpp:
       
 11695         (WebCore::ResourceLoader::ResourceLoader):
       
 11696         (WebCore::ResourceLoader::addData):
       
 11697         (WebCore::ResourceLoader::willStopBufferingData):
       
 11698         * loader/ResourceLoader.h:
       
 11699         (WebCore::ResourceLoader::setShouldBufferData):
       
 11700         * plugins/win/PluginStreamWin.cpp:
       
 11701         (WebCore::PluginStreamWin::PluginStreamWin):
       
 11702         (WebCore::PluginStreamWin::start):
       
 11703         (WebCore::PluginStreamWin::startStream):
       
 11704         (WebCore::PluginStreamWin::destroyStream):
       
 11705         (WebCore::PluginStreamWin::didReceiveData):
       
 11706         (WebCore::PluginStreamWin::didFinishLoading):
       
 11707         * plugins/win/PluginStreamWin.h:
       
 11708 
       
 11709 2007-07-19  Geoffrey Garen  <ggaren@apple.com>
       
 11710 
       
 11711         Reviewed by Darin Adler.
       
 11712         
       
 11713         Fixed <rdar://problem/5348384> Restore old return value behavior of 
       
 11714         stringByEvaluatingJavaScriptFromString
       
 11715         
       
 11716         Return an empty string unless you have a string, boolean, or number
       
 11717         result.
       
 11718 
       
 11719         * WebCore.xcodeproj/project.pbxproj:
       
 11720         * page/mac/WebCoreFrameBridge.mm:
       
 11721         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
       
 11722 
       
 11723 2007-07-19  Darin Adler  <darin@apple.com>
       
 11724 
       
 11725         Reviewed by Alexey.
       
 11726 
       
 11727         - fix http://bugs.webkit.org/show_bug.cgi?id=14666
       
 11728           remove unused xxx-encodings.txt for all platforms other than Mac
       
 11729 
       
 11730         * platform/gdk/gdk-encodings.txt: Removed.
       
 11731         * platform/win/win-encodings.txt: Removed.
       
 11732         * platform/wx/wx-encodings.txt: Removed.
       
 11733 
       
 11734         * platform/character-sets.txt: Moved into mac subdirectory since it's only used for Mac; at some
       
 11735         point I hope to remove it completely.
       
 11736         * platform/make-charset-table.pl: Ditto.
       
 11737         * platform/mac/character-sets.txt: Copied from platform/character-sets.txt.
       
 11738         * platform/mac/make-charset-table.pl: Copied from platform/make-charset-table.pl.
       
 11739 
       
 11740         * DerivedSources.make: Moved CharsetData.cpp into the MACOS section.
       
 11741         Changed the build rule to use Mac-specific paths for everything and got rid of
       
 11742         make variables.
       
 11743 
       
 11744         * WebCore.vcproj/build-generated-files.sh: Removed code to set ENCODINGS_FILE and ENCODINGS_PREFIX.
       
 11745         * WebCore.xcodeproj/project.pbxproj: Ditto.
       
 11746         * make-generated-sources.sh: Ditto.
       
 11747 
       
 11748         * Projects/gdk/webcore-gdk.bkl: Removed code to pass gdk-encodings.txt to make-generated-sources.sh.
       
 11749         * Projects/wx/webcore-wx.bkl: Ditto, but for wx-encodings.txt.
       
 11750 
       
 11751 2007-07-19  Antti  <antti@apple.com>
       
 11752 
       
 11753         Reviewed by Darin.
       
 11754 
       
 11755         Fix <rdar://problem/5257371>
       
 11756         Dashcode Client crash when clicking on placemarks in Maps widget in WebCore::DeprecatedPtrListImpl::addIterator
       
 11757         
       
 11758         FlexibleBoxes should never have inline children. Don't move children out from last remaining anonymous block.
       
 11759 
       
 11760         * rendering/RenderBlock.cpp:
       
 11761         (WebCore::RenderBlock::removeChild): real fix
       
 11762         * rendering/RenderFlexibleBox.cpp:
       
 11763         (WebCore::RenderFlexibleBox::layoutVerticalBox): just to be sure, this is checked elsewhere too
       
 11764 
       
 11765 2007-07-19  Anders Carlsson  <andersca@apple.com>
       
 11766 
       
 11767         Reviewed by Darin.
       
 11768 
       
 11769         <rdar://problem/5322268>
       
 11770         Safari Crash at http://www.exlibrisgroup.com/sfx_openurl.htm
       
 11771         
       
 11772         Add a real copy constructor and assignment operator for CollectionInfo
       
 11773         so that the vectors in the cache maps will be copied correctly.
       
 11774         
       
 11775         * html/HTMLCollection.cpp:
       
 11776         (WebCore::HTMLCollection::CollectionInfo::CollectionInfo):
       
 11777         (WebCore::HTMLCollection::CollectionInfo::swap):
       
 11778         * html/HTMLCollection.h:
       
 11779         (WebCore::HTMLCollection::CollectionInfo::operator=):
       
 11780         (WebCore::HTMLCollection::CollectionInfo::copyCacheMap):
       
 11781 
       
 11782 2007-07-19  David Hyatt  <hyatt@apple.com>
       
 11783 
       
 11784         Fix for 5237574, Colloquy main view does not size correctly.  Make
       
 11785         sure to reset the baseilne when calculating a row's height/baseline, so
       
 11786         that old values don't stick around.
       
 11787 
       
 11788         Reviewed by Tim Hatcher
       
 11789 
       
 11790         * rendering/RenderTableSection.cpp:
       
 11791         (WebCore::RenderTableSection::calcRowHeight):
       
 11792 
       
 11793 2007-07-19  Antti  <antti@apple.com>
       
 11794 
       
 11795         Reviewed by John.
       
 11796         
       
 11797         Fix <rdar://problem/5346697>
       
 11798         REGRESSION(r23773): Visibile children on invisible layer are not painted (fast/layers/layer-visibility.html fails)
       
 11799         
       
 11800         Test m_hasVisibleContent instead of renderer()->style()->visibility(). 
       
 11801         This takes children into account too.
       
 11802 
       
 11803         Regression spotted by Mitz.
       
 11804 
       
 11805         * rendering/RenderLayer.cpp:
       
 11806         (WebCore::RenderLayer::paintLayer):
       
 11807 
       
 11808 2007-07-18  Oliver Hunt  <oliver@apple.com>
       
 11809 
       
 11810         Rubber stamped by maciej
       
 11811 
       
 11812         Rollout patch from r24437.
       
 11813 
       
 11814         * page/EventHandler.cpp:
       
 11815         (WebCore::EventHandler::keyEvent):
       
 11816 
       
 11817 2007-07-18  Oliver Hunt  <oliver@apple.com>
       
 11818 
       
 11819         Reviewed by Kevin M.
       
 11820 
       
 11821         Fix for <rdar://problem/5346167> DOM key events triggered during
       
 11822                 IME composition differ in webkit/mac vs all windows browsers
       
 11823 
       
 11824         We no longer send DOM key events during IME composition.  This behaviour 
       
 11825         matches the behaviour of WebKit/Win.
       
 11826 
       
 11827         * page/EventHandler.cpp:
       
 11828         (WebCore::EventHandler::keyEvent):
       
 11829 
       
 11830 2007-07-18  Sam Weinig  <sam@webkit.org>
       
 11831 
       
 11832         Reviewed by Oliver.
       
 11833 
       
 11834         Fix for http://bugs.webkit.org/show_bug.cgi?id=14646
       
 11835         WebKit border radius properties are unavailable via JavaScript
       
 11836 
       
 11837         Test: fast/dom/getComputedStyle-borderRadius.html
       
 11838 
       
 11839         * css/CSSComputedStyleDeclaration.cpp:
       
 11840         (WebCore::getBorderRadiusCornerValue): Helper function that returns a single value if
       
 11841         width and the height of the corner radius are equal, and otherwise a pair.
       
 11842         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 11843 
       
 11844 2007-07-18  Anders Carlsson  <andersca@apple.com>
       
 11845 
       
 11846         Reviewed by Darin.
       
 11847 
       
 11848         <rdar://problem/5262136> Double form repost alert going forward on britishairways.com
       
 11849         
       
 11850         When checking if the request has changed and a new policy callback needs to be sent, 
       
 11851         ignore the request headers. NSURLConnection in Leopard will always call willSendRequest,
       
 11852         with a request that was different from the one passed to -[NSURLConnection connectionWithRequest:]
       
 11853         (a few Accept headers are added).
       
 11854 
       
 11855         * loader/FrameLoader.cpp:
       
 11856         (WebCore::FrameLoader::checkNavigationPolicy):
       
 11857         * platform/network/ResourceRequestBase.cpp:
       
 11858         (WebCore::equalIgnoringHeaderFields):
       
 11859         (WebCore::operator==):
       
 11860         * platform/network/ResourceRequestBase.h:
       
 11861 
       
 11862 2007-07-18  Anders Carlsson  <andersca@apple.com>
       
 11863 
       
 11864         Reviewed by Darin.
       
 11865 
       
 11866         <rdar://problem/5340098>
       
 11867         http://bugs.webkit.org/show_bug.cgi?id=13366
       
 11868         REGRESSION (r10935): AOL beta music player doesn't play
       
 11869 
       
 11870         The AOL beta music player has a typo, causing it to create an <embed"> element inside of
       
 11871         an <object> element
       
 11872         Because of this, it will not be treated as an embed tag, so its name will not be added
       
 11873         to the document's named item map. Furthermore, since the <object> contains a child that
       
 11874         is not a <param>, the object's name won't be added either.
       
 11875         
       
 11876         The (somewhat ugly) fix is to add <object> to the named map only if it has <param> or
       
 11877         unknown elements as children.
       
 11878         
       
 11879         * html/HTMLObjectElement.cpp:
       
 11880         (WebCore::HTMLObjectElement::updateDocNamedItem):
       
 11881 
       
 11882 2007-07-18  Timothy Hatcher  <timothy@apple.com>
       
 11883 
       
 11884         Reviewed by Adam.
       
 11885 
       
 11886         <rdar://problem/5343767> Should have a way to disable the Web Inspector
       
 11887 
       
 11888         This change facilitates the ability to turn the Web Inspector on and off.
       
 11889 
       
 11890         Makes the InspectorClient be required to create a new Page. This also means that
       
 11891         InspectorController will never be NULL. Adds a new function on Page to test
       
 11892         if the inspector is enabled.
       
 11893 
       
 11894         * WebCore.exp: New symbol for the Page constructor.
       
 11895         * WebCore.pro: Add InspectorClientGdk.cpp.
       
 11896         * WebCoreSources.bkl: ditto.
       
 11897         * html/HTMLDocument.cpp:
       
 11898         (WebCore::HTMLDocument::createTokenizer):
       
 11899         * loader/FrameLoader.cpp:
       
 11900         (WebCore::FrameLoader::detachFromParent): Don't null check the InspectorCOntroller.
       
 11901         (WebCore::FrameLoader::dispatchDidCommitLoad): Ditto.
       
 11902         (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest): Ditto.
       
 11903         (WebCore::FrameLoader::dispatchWillSendRequest): Ditto.
       
 11904         (WebCore::FrameLoader::dispatchDidReceiveResponse): Ditto.
       
 11905         (WebCore::FrameLoader::dispatchDidReceiveContentLength): Ditto.
       
 11906         (WebCore::FrameLoader::dispatchDidFinishLoading): Ditto.
       
 11907         (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache): Ditto.
       
 11908         * page/ContextMenuController.cpp:
       
 11909         (WebCore::ContextMenuController::handleContextMenuEvent): Ask the InspectorController if it is enabled.
       
 11910         (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
       
 11911         * page/InspectorController.cpp:
       
 11912         (WebCore::InspectorController::enabled): Ask the Page's settings if developer extras are enabled.
       
 11913         (WebCore::InspectorController::inspect): Check if the InspectorController is enabled.
       
 11914         (WebCore::InspectorController::focusNode): Ditto.
       
 11915         (WebCore::InspectorController::highlight): Ditto.
       
 11916         (WebCore::InspectorController::hideHighlight): Ditto.
       
 11917         (WebCore::InspectorController::addMessageToConsole): Ditto.
       
 11918         (WebCore::InspectorController::attachWindow): Ditto.
       
 11919         (WebCore::InspectorController::detachWindow): Ditto.
       
 11920         (WebCore::InspectorController::windowScriptObjectAvailable): Ditto.
       
 11921         (WebCore::InspectorController::didCommitLoad): Ditto.
       
 11922         (WebCore::InspectorController::frameDetachedFromParent): Ditto.
       
 11923         (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
       
 11924         (WebCore::InspectorController::identifierForInitialRequest): Ditto.
       
 11925         (WebCore::InspectorController::willSendRequest): Ditto.
       
 11926         (WebCore::InspectorController::didReceiveResponse): Ditto.
       
 11927         (WebCore::InspectorController::didReceiveContentLength): Ditto.
       
 11928         (WebCore::InspectorController::didFinishLoading): Ditto.
       
 11929         (WebCore::InspectorController::didFailLoading): Ditto.
       
 11930         * page/InspectorController.h:
       
 11931         * page/Page.cpp:
       
 11932         (WebCore::Page::Page): Require an InspectorClient.
       
 11933         (WebCore::Page::~Page): Always call pageDestroyed on the InspectorController.
       
 11934         (WebCore::Page::inspectorEnabled): Check the WebCore settings if the developer extras are enabled.
       
 11935         * page/Page.h:
       
 11936         * page/gdk/InspectorClientGdk.cpp: Added.
       
 11937         (WebCore::InspectorClientGdk::inspectorDestroyed): Empty stub calling notImplemented.
       
 11938         (WebCore::InspectorClientGdk::createPage): Ditto.
       
 11939         (WebCore::InspectorClientGdk::showWindow): Ditto.
       
 11940         (WebCore::InspectorClientGdk::closeWindow): Ditto.
       
 11941         (WebCore::InspectorClientGdk::attachWindow): Ditto.
       
 11942         (WebCore::InspectorClientGdk::detachWindow): Ditto.
       
 11943         (WebCore::InspectorClientGdk::highlight): Ditto.
       
 11944         (WebCore::InspectorClientGdk::hideHighlight): Ditto.
       
 11945         (WebCore::InspectorClientGdk::inspectedURLChanged): Ditto.
       
 11946         * page/gdk/InspectorClientGdk.h: Added.
       
 11947         * platform/graphics/svg/SVGImage.cpp:
       
 11948         (WebCore::SVGImage::dataChanged): Pass in a dummy InspectorClient.
       
 11949         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 11950         (WebCore::SVGEmptyInspectorClient::~SVGEmptyInspectorClient): Empty dummy implementation.
       
 11951         (WebCore::SVGEmptyInspectorClient::inspectorDestroyed): Ditto.
       
 11952         (WebCore::SVGEmptyInspectorClient::createPage): Ditto.
       
 11953         (WebCore::SVGEmptyInspectorClient::showWindow): Ditto.
       
 11954         (WebCore::SVGEmptyInspectorClient::closeWindow): Ditto.
       
 11955         (WebCore::SVGEmptyInspectorClient::attachWindow): Ditto.
       
 11956         (WebCore::SVGEmptyInspectorClient::detachWindow): Ditto.
       
 11957         (WebCore::SVGEmptyInspectorClient::highlight): Ditto.
       
 11958         (WebCore::SVGEmptyInspectorClient::hideHighlight): Ditto.
       
 11959         (WebCore::SVGEmptyInspectorClient::inspectedURLChanged): Ditto.
       
 11960 
       
 11961 2007-07-18  Anders Carlsson  <andersca@apple.com>
       
 11962 
       
 11963         Make some headers private instead of project.
       
 11964         
       
 11965         * WebCore.xcodeproj/project.pbxproj:
       
 11966 
       
 11967 2007-07-18  John Sullivan  <sullivan@apple.com>
       
 11968 
       
 11969         Reviewed by Maciej and Kevin Decker
       
 11970 
       
 11971         - fixed <rdar://problem/5315926> REGRESSION: ~.4% PLT regression from r23949 (canonicalization change)
       
 11972 
       
 11973         * loader/mac/LoaderNSURLExtras.m:
       
 11974         (canonicalURL):
       
 11975         Rolled out the fix for 5249730 that caused this regression. 5249730 is addressed a different way now.
       
 11976 
       
 11977 2007-07-18  Sam Weinig  <sam@webkit.org>
       
 11978 
       
 11979         Build fix.
       
 11980 
       
 11981         * WebCore.xcodeproj/project.pbxproj:
       
 11982         * loader/gdk/FrameLoaderClientGdk.cpp:
       
 11983         (WebCore::FrameLoaderClientGdk::objectContentType):
       
 11984         * platform/graphics/win/ImageWin.cpp:
       
 11985         * platform/network/cf/ResourceResponseCFNet.cpp:
       
 11986         * platform/win/ClipboardWin.cpp:
       
 11987         (WebCore::createGlobalImageFileDescriptor):
       
 11988 
       
 11989 2007-07-18  Sam Weinig  <sam@webkit.org>
       
 11990 
       
 11991         Rubber-stamped by Adam Roben.
       
 11992 
       
 11993         Rename MimeTypeRegistry to MIMETypeRegistry and xmlhttprequest to XMLHttpRequest
       
 11994 
       
 11995         * WebCore.exp:
       
 11996         * WebCore.pro:
       
 11997         * WebCore.vcproj/WebCore.vcproj:
       
 11998         * bindings/js/JSXMLHttpRequest.cpp:
       
 11999         * bindings/js/kjs_binding.cpp:
       
 12000         * bindings/js/kjs_dom.cpp:
       
 12001         * dom/Document.cpp:
       
 12002         * html/HTMLFormElement.cpp:
       
 12003         (WebCore::HTMLFormElement::formData):
       
 12004         * html/HTMLObjectElement.cpp:
       
 12005         (WebCore::HTMLObjectElement::containsJavaApplet):
       
 12006         * loader/FrameLoader.cpp:
       
 12007         (WebCore::FrameLoader::requestObject):
       
 12008         * loader/mac/LoaderNSURLExtras.m:
       
 12009         (suggestedFilenameWithMIMEType):
       
 12010         * platform/MIMETypeRegistry.cpp: Copied from platform/MimeTypeRegistry.cpp.
       
 12011         (WebCore::initialiseSupportedImageMIMETypes):
       
 12012         (WebCore::initialiseMIMETypeRegistry):
       
 12013         (WebCore::MIMETypeRegistry::getMIMETypeForPath):
       
 12014         (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
       
 12015         (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType):
       
 12016         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
       
 12017         (WebCore::MIMETypeRegistry::isJavaAppletMIMEType):
       
 12018         (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes):
       
 12019         (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes):
       
 12020         (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes):
       
 12021         * platform/MIMETypeRegistry.h: Copied from platform/MimeTypeRegistry.h.
       
 12022         * platform/MimeTypeRegistry.cpp: Removed.
       
 12023         * platform/MimeTypeRegistry.h: Removed.
       
 12024         * platform/gdk/MIMETypeRegistryGdk.cpp: Copied from platform/gdk/MimeTypeRegistryGdk.cpp.
       
 12025         (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
       
 12026         * platform/gdk/MimeTypeRegistryGdk.cpp: Removed.
       
 12027         * platform/graphics/BitmapImage.cpp:
       
 12028         * platform/graphics/Image.cpp:
       
 12029         (WebCore::Image::supportsType):
       
 12030         * platform/mac/DragDataMac.mm:
       
 12031         * platform/mac/MIMETypeRegistryMac.mm: Copied from platform/mac/MimeTypeRegistryMac.mm.
       
 12032         (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
       
 12033         (WebCore::MIMETypeRegistry::getExtensionsForMIMEType):
       
 12034         (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
       
 12035         * platform/mac/MimeTypeRegistryMac.mm: Removed.
       
 12036         * platform/mac/PasteboardMac.mm:
       
 12037         (WebCore::Pasteboard::writeImage):
       
 12038         * platform/qt/MIMETypeRegistryQt.cpp: Copied from platform/qt/MimeTypeRegistryQt.cpp.
       
 12039         (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
       
 12040         * platform/qt/MimeTypeRegistryQt.cpp: Removed.
       
 12041         * platform/win/MIMETypeRegistryWin.cpp: Copied from platform/win/MimeTypeRegistryWin.cpp.
       
 12042         (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
       
 12043         (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
       
 12044         * platform/win/MimeTypeRegistryWin.cpp: Removed.
       
 12045         * rendering/RenderPartObject.cpp:
       
 12046         (WebCore::RenderPartObject::updateWidget):
       
 12047         * xml/xmlhttprequest.cpp: Removed.
       
 12048         * xml/xmlhttprequest.h: Removed.
       
 12049         * xml/XMLHttpRequest.cpp: Copied from xml/xmlhttprequest.cpp.
       
 12050         * xml/XMLHttpRequest.h: Copied from xml/xmlhttprequest.h.
       
 12051 
       
 12052 2007-07-18  Sam Weinig  <sam@webkit.org>
       
 12053 
       
 12054         Rubber-stamped by Adam Roben.
       
 12055 
       
 12056         Rename csshelper.h, csshelper.cpp, cssparser.h, cssparser.cpp,
       
 12057         cssstyleselector.h, and cssstyleselector.cpp to be CamelCase.
       
 12058 
       
 12059         * WebCore.pro:
       
 12060         * WebCore.vcproj/WebCore.vcproj:
       
 12061         * bindings/objc/DOM.mm:
       
 12062         * bindings/objc/DOMHTML.mm:
       
 12063         * css/CSSGrammar.y:
       
 12064         * css/CSSMediaRule.cpp:
       
 12065         * css/CSSMutableStyleDeclaration.cpp:
       
 12066         * css/CSSPrimitiveValue.cpp:
       
 12067         * css/CSSStyleSheet.cpp:
       
 12068         * css/MediaList.cpp:
       
 12069         * css/MediaQueryExp.cpp:
       
 12070         * css/csshelper.cpp: Removed.
       
 12071         * css/csshelper.h: Removed.
       
 12072         * css/CSSHelper.cpp: Copied from css/csshelper.cpp.
       
 12073         * css/CSSHelper.h: Copied from css/csshelper.h.
       
 12074         * css/cssparser.cpp: Removed.
       
 12075         * css/cssparser.h: Removed.
       
 12076         * css/CSSParser.cpp: Copied from css/cssparser.cpp.
       
 12077         * css/CSSParser.h: Copied from css/cssparser.h.
       
 12078         * css/cssstyleselector.cpp: Removed.
       
 12079         * css/cssstyleselector.h: Removed.
       
 12080         * css/CSSStyleSelector.cpp: Copied from css/cssstyleselector.cpp.
       
 12081         * css/CSSStyleSelector.h: Copied from css/cssstyleselector.h.
       
 12082         * dom/Document.cpp:
       
 12083         * dom/Element.cpp:
       
 12084         * dom/StyledElement.cpp:
       
 12085         * editing/ApplyStyleCommand.cpp:
       
 12086         * editing/markup.cpp:
       
 12087         * html/CanvasGradient.cpp:
       
 12088         * html/CanvasRenderingContext2D.cpp:
       
 12089         * html/CanvasStyle.cpp:
       
 12090         * html/HTMLAnchorElement.cpp:
       
 12091         * html/HTMLBaseElement.cpp:
       
 12092         * html/HTMLBodyElement.cpp:
       
 12093         * html/HTMLDocument.cpp:
       
 12094         * html/HTMLEmbedElement.cpp:
       
 12095         * html/HTMLFormElement.cpp:
       
 12096         * html/HTMLFrameElementBase.cpp:
       
 12097         * html/HTMLImageElement.cpp:
       
 12098         * html/HTMLImageLoader.cpp:
       
 12099         * html/HTMLLinkElement.cpp:
       
 12100         * html/HTMLObjectElement.cpp:
       
 12101         * html/HTMLOptGroupElement.cpp:
       
 12102         * html/HTMLOptionElement.cpp:
       
 12103         * html/HTMLSelectElement.cpp:
       
 12104         * html/HTMLTableElement.cpp:
       
 12105         * html/HTMLTablePartElement.cpp:
       
 12106         * html/HTMLTokenizer.cpp:
       
 12107         * ksvg2/css/SVGCSSParser.cpp:
       
 12108         * ksvg2/css/SVGCSSStyleSelector.cpp:
       
 12109         * ksvg2/svg/SVGAElement.cpp:
       
 12110         * ksvg2/svg/SVGClipPathElement.cpp:
       
 12111         * ksvg2/svg/SVGGradientElement.cpp:
       
 12112         * ksvg2/svg/SVGLength.cpp:
       
 12113         * ksvg2/svg/SVGMaskElement.cpp:
       
 12114         * ksvg2/svg/SVGStyledElement.cpp:
       
 12115         * ksvg2/svg/SVGUseElement.cpp:
       
 12116         * page/DOMWindow.cpp:
       
 12117         * page/mac/FrameMac.mm:
       
 12118         * page/mac/WebCoreFrameBridge.mm:
       
 12119         * rendering/HitTestResult.cpp:
       
 12120         * rendering/RenderObject.cpp:
       
 12121         * rendering/RenderStyle.cpp:
       
 12122         * rendering/RenderThemeMac.mm:
       
 12123 
       
 12124 2007-07-18  Brady Eidson  <beidson@apple.com>
       
 12125 
       
 12126         Rubberstamped by Adam
       
 12127 
       
 12128         * platform/win/SharedBufferWin.cpp:
       
 12129         (WebCore::SharedBuffer::createWithContentsOfFile): Correct license on this newly checked in file from yesterday
       
 12130 
       
 12131 2007-07-18  Maciej Stachowiak  <mjs@apple.com>
       
 12132 
       
 12133         Reviewed by Oliver.
       
 12134 
       
 12135         - fixed <rdar://problem/5340603> REGRESSION: javascript being written to the screen in Safari
       
 12136 
       
 12137         Test Case: fast/tokenizer/badscript.html
       
 12138         
       
 12139         * html/HTMLTokenizer.cpp:
       
 12140         (WebCore::HTMLTokenizer::parseTag): Don't apply our self-closing
       
 12141         <script> quirk in cases where the / appears in a mangled attribtue
       
 12142         value.
       
 12143 
       
 12144 2007-07-17  Peter Kasting  <zerodpx@gmail.com>
       
 12145 
       
 12146         Reviewed by Hyatt.
       
 12147 
       
 12148         http://bugs.webkit.org/show_bug.cgi?id=13618
       
 12149         Don't set link targets to "_blank" on middle-click; rely on the policy
       
 12150         delegate to do the right thing.
       
 12151 
       
 12152         * html/HTMLAnchorElement.cpp:
       
 12153         (WebCore::HTMLAnchorElement::defaultEventHandler):
       
 12154 
       
 12155 2007-07-17  Oliver Hunt  <oliver@apple.com>
       
 12156 
       
 12157         Reviewed by Maciej.
       
 12158 
       
 12159         Fix for <rdar://problem/4799967> Safari and other WebKit 
       
 12160         apps sometimes crash in WebCore::FontData::platformInit
       
 12161 
       
 12162         Always retain/release our font handle, instead of only retaining
       
 12163         in the presence of GC.
       
 12164 
       
 12165         * platform/mac/FontPlatformData.h:
       
 12166         (WebCore::FontPlatformData::FontPlatformData):
       
 12167         (WebCore::FontPlatformData::~FontPlatformData):
       
 12168 
       
 12169 2007-07-17  Sam Weinig  <sam@webkit.org>
       
 12170 
       
 12171         Reviewed by Geoff Garen.
       
 12172 
       
 12173         Fix for <rdar://problem/5333957>
       
 12174                 http://bugs.webkit.org/show_bug.cgi?id=14610
       
 12175 
       
 12176         Original patch by Feng Qian.
       
 12177 
       
 12178         - Clear the selection object when disconnecting a frame.
       
 12179 
       
 12180         Test: http/tests/security/cross-frame-access-selection.html
       
 12181 
       
 12182         * loader/FrameLoader.cpp:
       
 12183         (WebCore::FrameLoader::clear):
       
 12184         * page/DOMWindow.cpp:
       
 12185         (WebCore::DOMWindow::disconnectFrame):
       
 12186         (WebCore::DOMWindow::clear):
       
 12187         * page/DOMWindow.h:
       
 12188         * page/Frame.cpp:
       
 12189         (WebCore::Frame::clearScriptProxy):
       
 12190         (WebCore::Frame::clearDOMWindow):
       
 12191         * page/Frame.h:
       
 12192 
       
 12193 2007-07-17  Oliver Hunt  <oliver@apple.com>
       
 12194 
       
 12195         Reviewed by Sam.
       
 12196 
       
 12197         Fix for <rdar://problem/5154518> REGRESSION: Hitting return does
       
 12198         nothing in ruby terminal at http://tryruby.hobix.com/
       
 12199 
       
 12200         Calling event.preventDefault() during a keydown event should not 
       
 12201         prevent the keypress event from firing.
       
 12202 
       
 12203         * WebCore.xcodeproj/project.pbxproj:
       
 12204         * page/EventHandler.cpp:
       
 12205         (WebCore::EventHandler::keyEvent):
       
 12206         (WebCore::EventHandler::defaultKeyboardEventHandler):
       
 12207 
       
 12208 2007-07-17  Anders Carlsson  <andersca@apple.com>
       
 12209 
       
 12210         Reviewed by Geoff.
       
 12211 
       
 12212         <rdar://problem/4993463> 
       
 12213         http://bugs.webkit.org/show_bug.cgi?id=12732
       
 12214         REGRESSION: Comments fields on ircimages not showing up in nightly
       
 12215 
       
 12216         Postpone setting the frame name to just right before we request the frame. Otherwise, 
       
 12217         two calls to FrameTree::uniqueChildName will return the same frame name and in that case only
       
 12218         one Frame object will actually be created and multiple iframe elements will refer to it.
       
 12219         
       
 12220         * html/HTMLFrameElementBase.cpp:
       
 12221         (WebCore::HTMLFrameElementBase::openURL):
       
 12222         (WebCore::HTMLFrameElementBase::setNameAndOpenURL):
       
 12223         (WebCore::HTMLFrameElementBase::setNameAndOpenURLCallback):
       
 12224         (WebCore::HTMLFrameElementBase::insertedIntoDocument):
       
 12225         (WebCore::HTMLFrameElementBase::attach):
       
 12226         * html/HTMLFrameElementBase.h:
       
 12227 
       
 12228 2007-07-17  Brady Eidson  <beidson@apple.com>
       
 12229 
       
 12230         Reviewed by Steve
       
 12231 
       
 12232         Required for <rdar://problem/4516185> - FTP Directory Listings
       
 12233 
       
 12234         * WebCore.vcproj/WebCore.vcproj: Added SharedBufferWin
       
 12235         
       
 12236         * platform/SharedBuffer.cpp: Windows doesn't get the default empty resource anymore
       
 12237         * platform/win/SharedBufferWin.cpp: Added.
       
 12238         (WebCore::SharedBuffer::createWithContentsOfFile):
       
 12239 
       
 12240 2007-07-17  Brady Eidson  <beidson@apple.com>
       
 12241 
       
 12242         Reviewed by Tim Hatcher
       
 12243 
       
 12244         Tweak the class names we give to the icon table cell to make it easier to style
       
 12245 
       
 12246         * loader/FTPDirectoryDocument.cpp:
       
 12247           (WebCore::FTPDirectoryTokenizer::appendEntry): The the table cell a "IconCell" class name and
       
 12248           either a "FileType" or "DirectoryType" class name depending on the type
       
 12249 
       
 12250 2007-07-17  Holger Hans Peter Freyther  <zecke@selfish.org>
       
 12251 
       
 12252         Reviewed by NOBODY.
       
 12253 
       
 12254         Build fix after r24366 add an additional ResourceRequest parameter to
       
 12255         the download method.
       
 12256 
       
 12257         * loader/gdk/FrameLoaderClientGdk.cpp:
       
 12258         (WebCore::FrameLoaderClientGdk::download):
       
 12259         * loader/gdk/FrameLoaderClientGdk.h:
       
 12260 
       
 12261 2007-07-17  Adam Roben  <aroben@apple.com>
       
 12262 
       
 12263         Fix Bug 14324: Cannot remove/customize the "Inspect Element" contextual menu item
       
 12264         http://bugs.webkit.org/show_bug.cgi?id=14324
       
 12265 
       
 12266         Reviewed by Tim.
       
 12267 
       
 12268         No regression test possible.
       
 12269 
       
 12270         * page/ContextMenuController.cpp:
       
 12271         (WebCore::ContextMenuController::handleContextMenuEvent): Add the
       
 12272         Inspect Element item to the menu before passing it to the
       
 12273         ContextMenuClient so that the UI delegate has a chance to
       
 12274         modify/remove the item.
       
 12275 
       
 12276 2007-07-17  Adam Roben  <aroben@apple.com>
       
 12277 
       
 12278         Remove ContextMenuClient::shouldIncludeInspectElementItem
       
 12279 
       
 12280         Reviewed by Tim.
       
 12281 
       
 12282         No regression test possible.
       
 12283 
       
 12284         * page/ContextMenuClient.h:
       
 12285         * page/ContextMenuController.cpp:
       
 12286         (WebCore::ContextMenuController::handleContextMenuEvent): Use Settings
       
 12287         to determine whether to include the Inspect Element item.
       
 12288         * page/gdk/ContextMenuClientGdk.cpp:
       
 12289         * page/gdk/ContextMenuClientGdk.h:
       
 12290         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 12291 
       
 12292 2007-07-17  Adam Roben  <aroben@apple.com>
       
 12293 
       
 12294         Initialize ContextMenuController::m_page
       
 12295 
       
 12296         Somehow this variable had never been initialized before.
       
 12297 
       
 12298         Reviewed by Tim.
       
 12299 
       
 12300         * page/ContextMenuController.cpp:
       
 12301         (WebCore::ContextMenuController::ContextMenuController):
       
 12302         * page/ContextMenuController.h:
       
 12303         * page/Page.cpp:
       
 12304         (WebCore::Page::Page):
       
 12305 
       
 12306 2007-07-17  Adam Roben  <aroben@apple.com>
       
 12307 
       
 12308         Add Settings::developerExtrasEnabled
       
 12309 
       
 12310         Reviewed by Tim.
       
 12311 
       
 12312         * WebCore.exp:
       
 12313         * page/Settings.cpp:
       
 12314         * page/Settings.h:
       
 12315 
       
 12316 2007-07-17  Justin Garcia  <justin.garcia@apple.com>
       
 12317 
       
 12318         Reviewed by Antti.
       
 12319 
       
 12320         <rdar://problem/5206311> 
       
 12321         Whitespace can't be removed when editing text pasted into from web page
       
 12322         
       
 12323         The whitespace comes from table rows that aren't being removed after they are
       
 12324         emptied out during a deletion.
       
 12325 
       
 12326         * editing/DeleteSelectionCommand.cpp:
       
 12327         (WebCore::isTableCell):
       
 12328         (WebCore::isTableRow):
       
 12329         (WebCore::isTableCellEmpty):
       
 12330         (WebCore::isTableRowEmpty):
       
 12331         (WebCore::DeleteSelectionCommand::initializePositionData): Remember the table
       
 12332         rows that contained the start and end of the selection.
       
 12333         (WebCore::DeleteSelectionCommand::removePreviouslySelectedEmptyTableRows):
       
 12334         Remove table rows that come before the end of the selection
       
 12335         that was removed (except for the row that contained the start of the selection
       
 12336         and any before that).
       
 12337         Remove table rows that are come after the start of the selection
       
 12338         that was removed (except for the row that contained the end of the selection
       
 12339         and any after that).
       
 12340         (WebCore::DeleteSelectionCommand::doApply): Call the new function.
       
 12341         * editing/DeleteSelectionCommand.h:
       
 12342 
       
 12343 2007-07-17  Geoffrey Garen  <ggaren@apple.com>
       
 12344 
       
 12345         Reviewed by Kevin Decker.
       
 12346 
       
 12347         Removed ASSERT that was breaking the pageout test. It's trivial to
       
 12348         reproduce this ASSERT when navigating between pages that change their
       
 12349         names, but nothing bad seems to happen.
       
 12350 
       
 12351         * page/Page.cpp:
       
 12352         (WebCore::Page::goToItem):
       
 12353 
       
 12354 2007-07-17  Geoffrey Garen  <ggaren@apple.com>
       
 12355 
       
 12356         Build fix.
       
 12357         
       
 12358         * plugins/win/PluginViewWin.cpp: Pass false for lockHistory like we
       
 12359         do elsewhere.
       
 12360 
       
 12361 2007-07-17  Holger Hans Peter Freyther  <zecke@selfish.org>
       
 12362 
       
 12363         Reviewed by Maciej.
       
 12364 
       
 12365         Implement the callback responsible for handling HTTP headers. This
       
 12366         callback gets called for every header.
       
 12367         We will add these headers to our ResourceResponse and on the 'end-of-header'
       
 12368         indicator we will update the ResourceResponse and dispatch it.
       
 12369 
       
 12370         This patch adds various set methods to ResourceResponse. This improves
       
 12371         the readability of the headerCallback and avoids storing a CURL handle inside
       
 12372         the ResourceResponse which would be needed to implement ResourceResponse::doUpdateResourceResponse
       
 12373 
       
 12374         Add a destructor for ResourceHandleManager which would free the resources and remove
       
 12375         a unused variable.
       
 12376 
       
 12377         * platform/network/ResourceHandleInternal.h:
       
 12378         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
       
 12379         * platform/network/ResourceResponse.cpp:
       
 12380         (WebCore::ResourceResponse::setUrl):
       
 12381         (WebCore::ResourceResponse::setMimeType):
       
 12382         (WebCore::ResourceResponse::setExpectedContentLength):
       
 12383         (WebCore::ResourceResponse::setTextEncodingName):
       
 12384         (WebCore::ResourceResponse::setSuggestedFilename):
       
 12385         * platform/network/ResourceResponse.h:
       
 12386         * platform/network/curl/ResourceHandleCurl.cpp:
       
 12387         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
       
 12388         * platform/network/curl/ResourceHandleManager.cpp:
       
 12389         (WebCore::ResourceHandleManager::~ResourceHandleManager):
       
 12390         (WebCore::ResourceHandleManager::sharedInstance):
       
 12391         (WebCore::headerCallback):
       
 12392         * platform/network/curl/ResourceHandleManager.h:
       
 12393 
       
 12394 2007-07-17  Sam Weinig  <sam@webkit.org>
       
 12395 
       
 12396         Reviewed by Adam Roben.
       
 12397 
       
 12398         Convert JS undefined to the empty string when calling alert, confirm, and prompt. 
       
 12399 
       
 12400         Test: fast/dom/Window/alert-undefined.html
       
 12401 
       
 12402         * page/DOMWindow.idl:
       
 12403 
       
 12404 2007-07-17  Geoffrey Garen  <ggaren@apple.com>
       
 12405 
       
 12406         Reviewed by Kevin McCulough.
       
 12407 
       
 12408         Fixed failing layout test.
       
 12409         
       
 12410         Renamed "FrameLoadTypeInternal" to "FrameLoadTypeRedirectWithLockedHistory".
       
 12411         This is almost certainly not a correct name for the original intent
       
 12412         of this load type, but it's a correct name for its current behavior.
       
 12413         
       
 12414         (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory):
       
 12415         When history is supposed to be locked, and no current history item
       
 12416         exists, only add a new history item if you're the top-level frame.
       
 12417         
       
 12418         This rule, combined with the rule that setting iframe.src should not
       
 12419         create a history item, is pretty hackish. On the other hand, it
       
 12420         matches WinIE and doesn't cause any test regressions. So I'm OK with
       
 12421         it as a short-term solution until the solution described in 
       
 12422         <rdar://problem/5339292> can be implemented.
       
 12423 
       
 12424 2007-07-17  Tristan O'Tierney  <tristan@apple.com>
       
 12425 
       
 12426         Reviewed by Maciej Stachowiak.
       
 12427 
       
 12428         <rdar://problem/5294691> Source of file is misrepresented if downloaded by typing in URL in Safari address bar
       
 12429 
       
 12430         * loader/FrameLoaderClient.h:
       
 12431         * loader/MainResourceLoader.cpp:        
       
 12432         (WebCore::MainResourceLoader::continueAfterContentPolicy):
       
 12433         Added an extra request parameter, initialRequest, to the download() method
       
 12434         by passing up the resource handle's request.
       
 12435         
       
 12436         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 12437         (WebCore::SVGEmptyFrameLoaderClient::download):
       
 12438         Added an extra parameter to the empty SVG download method.
       
 12439         
       
 12440 2007-07-17  Antti  <antti@apple.com>
       
 12441 
       
 12442         Reviewed by home-bradee.
       
 12443 
       
 12444         <rdar://problem/5336372>
       
 12445         Icon database uses too much memory
       
 12446         
       
 12447         XRaying Safari startup memory consumption revealed that icon database is eating quite
       
 12448         a bit of RAM if Icon.db is large (which it probably is if it has been in use for a while, 
       
 12449         mine used for getting figures below was 2.6MB). 
       
 12450         
       
 12451         Note that the wins are less impressive with smaller Icon.db.
       
 12452         
       
 12453         This patch addresses three separate issues
       
 12454         
       
 12455         - SQLite fails to free the memory used by temporary tables. Icon database uses a temporary table
       
 12456           on startup for pruning unused page urls. This wastes around 1MB. Addressed by rewriting
       
 12457           pruning so it does not need a temporary table. The new method is also quite a bit faster speeding
       
 12458           up Safari launch time by around 100ms
       
 12459         - SQLite has it's own memory cache limited by default to 3MB. Icon database does not really need that much.
       
 12460           Dropped the cache size to 300kB saving ~1MB on startup. 
       
 12461           Smaller cache slows down startup by ~30ms (more than compensated by faster pruning above)
       
 12462         - Don't populate m_pageURLToIconURLMap with all urls from database on startup, instead let it get populated
       
 12463           when urls are accessed (user opens history menu for example). This shouldn't have any real performance impact 
       
 12464           as the accesses are icon loads that need to hit the database anyway. This saves ~700kB.
       
 12465           
       
 12466         All in all with this Icon.db these changes reduce allocated memory by around 2.7MB on startup. Release build
       
 12467         Safari RPRVT (empty start page) goes from 12.4MB to 10.4MB (TCMalloc pooling probably explaining why the win 
       
 12468         looks bit smaller here).
       
 12469 
       
 12470         * loader/icon/IconDatabase.cpp:
       
 12471         (WebCore::IconDatabase::IconDatabase):
       
 12472         (WebCore::IconDatabase::open):
       
 12473         (WebCore::IconDatabase::deleteAllPreparedStatements):
       
 12474         (WebCore::IconDatabase::retainIconForPageURL):
       
 12475         (WebCore::IconDatabase::releaseIconForPageURL):
       
 12476         (WebCore::IconDatabase::establishIconIDForIconURL):
       
 12477         (WebCore::IconDatabase::pruneUnretainedIconsOnStartup):
       
 12478         * loader/icon/IconDatabase.h:
       
 12479 
       
 12480 2007-07-17  Darin Adler  <darin@apple.com>
       
 12481 
       
 12482         Reviewed by Mitz.
       
 12483 
       
 12484         - fix http://bugs.webkit.org/show_bug.cgi?id=14569
       
 12485           Repro crash due to saved state not being cleared when select and textarea elements
       
 12486           are adopted by another document
       
 12487 
       
 12488         Test: fast/forms/saved-state-adoptNode-crash.html
       
 12489 
       
 12490         * dom/Document.h:
       
 12491         (WebCore::Document::registerFormElementWithState): Updated parameter type to be
       
 12492         HTMLFormControlElementWithState.
       
 12493         (WebCore::Document::unregisterFormElementWithState): Ditto.
       
 12494         Also removed isFormElementRegistered function and changed the type of the
       
 12495         m_formElementsWithState ListHashSet.
       
 12496         * dom/Document.cpp: (WebCore::Document::formElementsState): Updated to use new type,
       
 12497         for set contents and to use new saveState() function and only save state for elements
       
 12498         that return true.
       
 12499 
       
 12500         * html/HTMLGenericFormElement.h: Added HTMLFormControlElementWithState class,
       
 12501         derived from HTMLGenericFormElement, and moved down all the behavior related to
       
 12502         saving form control element state. Also removed the unnecessary default parameter
       
 12503         to the HTMLGenericFormElement constructor.
       
 12504         * html/HTMLGenericFormElement.cpp:
       
 12505         (WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState): Added.
       
 12506         Calls registerFormElementWithState.
       
 12507         (WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState): Added.
       
 12508         Calls unregisterFormElementWithState.
       
 12509         (WebCore::HTMLFormControlElementWithState::willMoveToNewOwnerDocument): Added.
       
 12510         Calls unregisterFormElementWithState.
       
 12511         (WebCore::HTMLFormControlElementWithState::didMoveToNewOwnerDocument): Added.
       
 12512         Calls registerFormElementWithState.
       
 12513         (WebCore::HTMLFormControlElementWithState::closeRenderer): Moved to this class from
       
 12514         the base class.
       
 12515 
       
 12516         * html/HTMLInputElement.h: Updated the base class name and overrode saveState instead
       
 12517         of stateValue.
       
 12518         * html/HTMLInputElement.cpp: Updated the base class name.
       
 12519         (WebCore::HTMLInputElement::init): Removed the call to registerFormElementWithState.
       
 12520         (WebCore::HTMLInputElement::~HTMLInputElement): Removed the call to
       
 12521         unregisterFormElementWithState. Also changed the code to only call the
       
 12522         unregisterForDidRestoreFromCacheCallback function for type PASSWORD (consistency
       
 12523         and efficiency).
       
 12524         (WebCore::HTMLInputElement::setInputType): Removed calls to registerFormElementWithState
       
 12525         and unregisterFormElementWithState; we now let the element stay registered and simply
       
 12526         don't save or restore state for password fields.
       
 12527         (WebCore::HTMLInputElement::saveState): Updated function name and signature to replace
       
 12528         the old stateValue function. Returns false for password fields.
       
 12529         (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Removed the call to
       
 12530         unregisterFormElementWithState.
       
 12531         (WebCore::HTMLInputElement::didMoveToNewOwnerDocument): Removed the call to
       
 12532         registerFormElementWithState.
       
 12533 
       
 12534         * html/HTMLSelectElement.h: Updated the base class name and overrode saveState instead
       
 12535         of stateValue.
       
 12536         * html/HTMLSelectElement.cpp: Updated the base class name.
       
 12537         (WebCore::HTMLSelectElement::HTMLSelectElement): Removed the call to
       
 12538         registerFormElementWithState.
       
 12539         (WebCore::HTMLSelectElement::~HTMLSelectElement): Removed the call to
       
 12540         unregisterFormElementWithState.
       
 12541         (WebCore::HTMLSelectElement::saveState): Updated function name and signature to
       
 12542         replace the old stateValue function.
       
 12543         (WebCore::HTMLSelectElement::setLength): Updated to use document() instead of
       
 12544         ownerDocument(); the latter is just a slower virtual-function way of doing the
       
 12545         same thing in all cases except for Document and XPathNamespace.
       
 12546 
       
 12547         * html/HTMLTextAreaElement.h: Update the base class name, overrode saveState instead
       
 12548         of stateValue, and removed the now-unnecessary explicit destructor.
       
 12549         * html/HTMLTextAreaElement.cpp: Updated the base class name.
       
 12550         (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Removed the call to
       
 12551         registerFormElementWithState.
       
 12552         (WebCore::HTMLTextAreaElement::saveState): Updated function name and signature to replace
       
 12553         the old stateValue function.
       
 12554 
       
 12555 2007-07-17  Sam Weinig  <sam@webkit.org>
       
 12556 
       
 12557         Reviewed by Darin.
       
 12558 
       
 12559         - Make HTMLFrameOwnerElement::contentWindow() return a DOMWindow instead of a Frame
       
 12560         - Remove the unnecessary hack in HTMLFrameElement.idl and HTMLIFrameElement.idl that
       
 12561           converted from Frame to Window now that it is not necessary.
       
 12562         - Remove now unused [NullCheck] extended attribute from CodeGeneratorJS.pm.
       
 12563 
       
 12564         * bindings/scripts/CodeGeneratorJS.pm:
       
 12565         * html/HTMLDocument.idl:
       
 12566         * html/HTMLFrameElement.idl:
       
 12567         * html/HTMLFrameOwnerElement.cpp:
       
 12568         (WebCore::HTMLFrameOwnerElement::contentWindow):
       
 12569         * html/HTMLFrameOwnerElement.h:
       
 12570         * html/HTMLIFrameElement.idl:
       
 12571 
       
 12572 2007-07-16  Sam Weinig  <sam@webkit.org>
       
 12573 
       
 12574         Reviewed by Adam Roben.
       
 12575 
       
 12576         Move self, opener, parent, top, window, and frames from kjs_window
       
 12577         to DOMWindow and auto-generate the bindings for them.
       
 12578 
       
 12579         * bindings/js/kjs_window.cpp:
       
 12580         (KJS::Window::getValueProperty):
       
 12581         * bindings/js/kjs_window.h:
       
 12582         (KJS::Window::):
       
 12583         * page/DOMWindow.cpp:
       
 12584         (WebCore::DOMWindow::self):
       
 12585         (WebCore::DOMWindow::opener):
       
 12586         (WebCore::DOMWindow::parent):
       
 12587         (WebCore::DOMWindow::top):
       
 12588         * page/DOMWindow.h:
       
 12589         (WebCore::DOMWindow::window):
       
 12590         (WebCore::DOMWindow::frames):
       
 12591         * page/DOMWindow.idl:
       
 12592 
       
 12593 2007-07-16  Geoffrey Garen  <ggaren@apple.com>
       
 12594 
       
 12595         Reviewed by Sam Weinig.
       
 12596         
       
 12597         Fixed <rdar://problem/5334483> REGRESSION: JavaScript-induced 
       
 12598         window.open loads not added to back/forward list
       
 12599         
       
 12600         I did an audit of our history rules in loading and tried to establish
       
 12601         some sane uniformity.
       
 12602         
       
 12603         The uniform rule is:
       
 12604             - HTTP redirects and HTTP redirects simulated by <meta http-equiv>
       
 12605             add a history item if and only if the redirect takes > 1 second.
       
 12606             - Other navigations, including JavaScript navigations, always
       
 12607             add a history item, except for location.replace navigations.
       
 12608 
       
 12609         In the future, we'll want to refine the second case to be more like the
       
 12610         first. I've filed <rdar://problem/5339292> about that.
       
 12611 
       
 12612         * bindings/js/JSHTMLDocumentCustom.cpp:
       
 12613         (WebCore::JSHTMLDocument::setLocation): Don't pass 'true' for 
       
 12614         userGesture unconditionally. userGesture is used to determine popup 
       
 12615         blocking, not history item creation.
       
 12616 
       
 12617         * bindings/js/kjs_window.cpp: Pass 'false' for lockHistory in all loads
       
 12618         except location.replace, which intends to lock history.
       
 12619 
       
 12620         * loader/FrameLoader.cpp: Distinguish between lockHistory and 
       
 12621         userGesture. The former determines whether a new history item gets
       
 12622         created. The latter determines whether JavaScript can open popup
       
 12623         windows. Start passing these variables in functions that used to
       
 12624         swallow or conflate them.
       
 12625         
       
 12626         (WebCore::FrameLoader::requestFrame): Pass 'true' for lockHistory here
       
 12627         because that's usually correct when setting the 'src' attribute of a
       
 12628         child frame, and we want to avoid regressing <rdar://problem/4921797>.
       
 12629 
       
 12630         (WebCore::FrameLoader::load): Use the lockHistory variable to determine
       
 12631         whether to start a history-creating load. Using userGesture for this
       
 12632         purpose is wrong, as explained above.
       
 12633 
       
 12634         * loader/FrameLoader.h: Renamed one variant of scheduleRedirection to
       
 12635         scheduleHTTPRedirection because the behavior there of measuring elapsed
       
 12636         time is specific to the HTTP redirection case.
       
 12637 
       
 12638         * page/ContextMenuController.cpp:
       
 12639         (WebCore::ContextMenuController::contextMenuItemSelected): lockHistory
       
 12640         can always be false here because this navigation is never the result of
       
 12641         a redirection.
       
 12642 
       
 12643 2007-07-16  Sam Weinig  <sam@webkit.org>
       
 12644 
       
 12645         Reviewed by Adam and Maciej.
       
 12646 
       
 12647         Move the frameElement attribute from kjs_window to DOMWindow and
       
 12648         auto-generate the bindings for it. 
       
 12649 
       
 12650         * bindings/js/kjs_window.cpp:
       
 12651         (KJS::Window::getValueProperty):
       
 12652         * bindings/js/kjs_window.h:
       
 12653         (KJS::Window::):
       
 12654         * bindings/scripts/CodeGeneratorJS.pm:
       
 12655         * page/DOMWindow.cpp:
       
 12656         (WebCore::DOMWindow::frameElement):
       
 12657         (WebCore::DOMWindow::devicePixelRatio):
       
 12658         * page/DOMWindow.h:
       
 12659         * page/DOMWindow.idl:
       
 12660 
       
 12661 2007-07-16  Sam Weinig  <sam@webkit.org>
       
 12662 
       
 12663         Reviewed by Adam.
       
 12664 
       
 12665         Move more functions from kjs_window to DOMWindow and auto-generate
       
 12666         the bindings for them.
       
 12667 
       
 12668         * bindings/js/kjs_window.cpp:
       
 12669         (KJS::WindowFunc::callAsFunction):
       
 12670         * bindings/js/kjs_window.h:
       
 12671         (KJS::Window::):
       
 12672         * page/DOMWindow.cpp:
       
 12673         (WebCore::DOMWindow::print):
       
 12674         (WebCore::DOMWindow::stop):
       
 12675         (WebCore::DOMWindow::alert):
       
 12676         (WebCore::DOMWindow::confirm):
       
 12677         (WebCore::DOMWindow::prompt):
       
 12678         (WebCore::DOMWindow::find):
       
 12679         * page/DOMWindow.h:
       
 12680         * page/DOMWindow.idl:
       
 12681 
       
 12682 2007-07-17  Mark Rowe  <mrowe@apple.com>
       
 12683 
       
 12684         Gdk build fix.
       
 12685 
       
 12686         * platform/gdk/ChromeClientGdk.h:
       
 12687 
       
 12688 2007-07-16  Brady Eidson  <beidson@apple.com>
       
 12689 
       
 12690         Reviewed by Adam
       
 12691 
       
 12692         Begin the arduous task of localizing FTP directory listings while removing a global initializer!
       
 12693 
       
 12694         * loader/FTPDirectoryDocument.cpp:
       
 12695         (WebCore::processFilesizeString):
       
 12696 
       
 12697         * page/mac/WebCoreViewFactory.h:
       
 12698 
       
 12699         * platform/LocalizedStrings.h:
       
 12700 
       
 12701         * platform/gdk/TemporaryLinkStubs.cpp:
       
 12702         (WebCore::unknownFileSizeText):
       
 12703 
       
 12704         * platform/mac/LocalizedStringsMac.mm:
       
 12705         (WebCore::unknownFileSizeText):
       
 12706 
       
 12707         * platform/qt/Localizations.cpp:
       
 12708         (WebCore::unknownFileSizeText):
       
 12709 
       
 12710 2007-07-16  Sam Weinig  <sam@webkit.org>
       
 12711 
       
 12712         Reviewed by Oliver.
       
 12713 
       
 12714         Remove more redundant isSafeScript checks.
       
 12715 
       
 12716         * bindings/js/kjs_window.cpp:
       
 12717         (KJS::Window::getOwnPropertySlot):
       
 12718 
       
 12719 2007-07-16  Sam Weinig  <sam@webkit.org>
       
 12720 
       
 12721         Reviewed by Oliver.
       
 12722 
       
 12723         Turn off -Wshorten-64-to-32 warning for 64-bit builds.
       
 12724 
       
 12725         * Configurations/Base.xcconfig:
       
 12726 
       
 12727 2007-07-16  Anders Carlsson  <andersca@apple.com>
       
 12728 
       
 12729         Reviewed by Oliver.
       
 12730 
       
 12731         <rdar://problem/5336276>
       
 12732         ASSERT(cs->accessCount() > 0) when instantiating widget templates in DashCode
       
 12733 
       
 12734         If the cache is disabled, accessCount will always be 0. Account for this in the assert.
       
 12735         
       
 12736         * html/HTMLTokenizer.cpp:
       
 12737         (WebCore::HTMLTokenizer::reset):
       
 12738         (WebCore::HTMLTokenizer::notifyFinished):
       
 12739 
       
 12740 2007-07-16  Brady Eidson  <beidson@apple.com>
       
 12741 
       
 12742         Reviewed by Darin.
       
 12743 
       
 12744         Append FTP row entries to the first TBODY instead of the TABLE element itself, 
       
 12745         as many TABLE elements end up with an implicit TBODY and that's where most people would
       
 12746         expect it to be added.
       
 12747 
       
 12748         * html/HTMLTableElement.h:
       
 12749         (WebCore::HTMLTableElement::firstTBody): Added this accessor
       
 12750 
       
 12751         * loader/FTPDirectoryDocument.cpp:
       
 12752         (WebCore::FTPDirectoryTokenizer::appendEntry): Add to the first tbody if it exists
       
 12753 
       
 12754 2007-07-16  Justin Garcia  <justin.garcia@apple.com>
       
 12755 
       
 12756         Reviewed by Adele.
       
 12757 
       
 12758         <rdar://problem/5240265> 
       
 12759         REGRESSION: Clicking a <button> clears the selection in contenteditable areas
       
 12760 
       
 12761         * page/FocusController.cpp:
       
 12762         (WebCore::clearSelectionIfNeeded): Don't clear the selection if
       
 12763         the mouse press that caused the focus shift occurred in 
       
 12764         a -webkit-user-select: ignore region.
       
 12765 
       
 12766 2007-07-16  David Hyatt  <hyatt@apple.com>
       
 12767 
       
 12768         Fix for 5335829, avoid creating a pathological # of FontData objects
       
 12769         on Windows.  The MLang service actually caches and reuses HFONTs, which
       
 12770         means it is safe to use our FontPlatformData -> FontData cache.
       
 12771 
       
 12772         Reviewed by olliej
       
 12773 
       
 12774         * platform/win/FontCacheWin.cpp:
       
 12775         (WebCore::FontCache::getFontDataForCharacters):
       
 12776 
       
 12777 2007-07-16  Adam Roben  <aroben@apple.com>
       
 12778 
       
 12779         Added a manual test to test calling window.print on a subframe.
       
 12780 
       
 12781         Reviewed by Darin.
       
 12782 
       
 12783         * manual-tests/resources/print-subframe.html: Added.
       
 12784         * manual-tests/window-print-subframe.html: Added.
       
 12785 
       
 12786 2007-07-16  Adam Roben  <aroben@apple.com>
       
 12787 
       
 12788         Replace Frame::print with Chrome::print
       
 12789 
       
 12790         This also adds a Frame* parameter to Chrome::print and
       
 12791         ChromeClient::print so that it knows which Frame to print.
       
 12792 
       
 12793         Reviewed by Darin.
       
 12794 
       
 12795         All tests pass.
       
 12796 
       
 12797         * bindings/js/kjs_window.cpp:
       
 12798         (KJS::WindowFunc::callAsFunction): Call Chrome::print.
       
 12799         * editing/JSEditor.cpp: Ditto.
       
 12800 
       
 12801         * bridge/win/FrameWin.cpp: Removed Frame::print.
       
 12802         * page/Frame.h: Ditto.
       
 12803         * page/mac/FrameMac.mm: Ditto.
       
 12804         * page/qt/FrameQt.cpp: Ditto.
       
 12805         * platform/gdk/FrameGdk.cpp: Ditto.
       
 12806         * page/mac/WebCoreFrameBridge.h: Removed -print.
       
 12807 
       
 12808         * page/Chrome.cpp: Added Frame* parameter to Chrome::print and pass it
       
 12809         up to the ChromeClient.
       
 12810         * page/Chrome.h: Ditto.
       
 12811         * page/ChromeClient.h: Ditto.
       
 12812         * platform/gdk/TemporaryLinkStubs.cpp: Ditto.
       
 12813         * platform/graphics/svg/SVGImageEmptyClients.h: Ditto.
       
 12814 
       
 12815 2007-07-16  Adele Peterson  <adele@apple.com>
       
 12816 
       
 12817         Reviewed by Brady.
       
 12818 
       
 12819         Fix for <rdar://problem/5321490> REGRESSION: visibility:hidden property doesn't hide parts of file input element and listbox
       
 12820         http://bugs.webkit.org/show_bug.cgi?id=14565
       
 12821 
       
 12822         Tests:
       
 12823         fast/forms/hidden-input-file.html
       
 12824         fast/forms/hidden-listbox.html
       
 12825 
       
 12826         * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
       
 12827         Only paint if the control is supposed to be visible.
       
 12828         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject):
       
 12829         ditto.  We already had checks to prevent drawing the text that considered the option's style too, but if visibility: hidden
       
 12830         was just set on the listbox then a lot of extra work was being done, and the scrollbar was drawing too.  This change fixes that.
       
 12831 
       
 12832 2007-07-16  David Hyatt  <hyatt@apple.com>
       
 12833 
       
 12834         Fix for Radar 5338081, text-shadow should be reset on form controls so that
       
 12835         it doesn't inherit in when set e.g., on the <body>.
       
 12836 
       
 12837         Reviewed by beth
       
 12838 
       
 12839         * css/html4.css:
       
 12840 
       
 12841 2007-07-16  Holger Hans Peter Freyther  <zecke@selfish.org>
       
 12842 
       
 12843         Reviewed by Niko.
       
 12844 
       
 12845         FrameView, PlatformScrollbar and changes to the way we draw
       
 12846 
       
 12847         Fix the lifetime of PlatformScrollbar, use a default width and
       
 12848         height and fix drawing of the PlatformScrollbar and other widgets
       
 12849         the following way: FrameGdk handles the expose events of the Frame
       
 12850         and will make the frame redraw and now it will draw the childrent of
       
 12851         the FrameView as well. This approach has the issue of honoring the
       
 12852         z-order of elements inside the RenderTree. Honoring the z-order will
       
 12853         be a bit more work
       
 12854 
       
 12855         Widget can now handle Widget::setGtkWidget call where the GtkWidget
       
 12856         has not yet a GdkWindow allocated. We will lazily set the GdkDrawable.
       
 12857 
       
 12858         In preparation of honoring the z-order of the RenderTree for RenderWidgets
       
 12859         it is started to store native objects inside the GraphicsContext. Doing this
       
 12860         nicely eliminates the need of RenderThemeGdk to do any drawing to a temporary
       
 12861         GdkPixmap. This should fix themes with rounded buttons.
       
 12862 
       
 12863         ScrollView implement add- and removeChild to get a working PlatformScrollbar
       
 12864 
       
 12865 
       
 12866         * platform/Widget.h:
       
 12867         * platform/gdk/FrameGdk.cpp:
       
 12868         (frame_gdk_expose_child): Will send the expose to all children
       
 12869         (WebCore::FrameGdk::handleGdkEvent): Painting changes, move to mouseMoved
       
 12870         * platform/gdk/PlatformScreenGdk.cpp:
       
 12871         (WebCore::screenDepth): gdkDrawable
       
 12872         * platform/gdk/PlatformScrollBarGdk.cpp:
       
 12873         (PlatformScrollbar::PlatformScrollbar): Fix ownership
       
 12874         (PlatformScrollbar::~PlatformScrollbar): Fix ownership
       
 12875         (PlatformScrollbar::paint): Widget::paint will do the right thing soon
       
 12876         * platform/gdk/RenderThemeGdk.cpp: No need for using a GdkPixmap, draw directly
       
 12877         (WebCore::RenderThemeGdk::paintCheckbox): No need for using a GdkPixmap, draw directly
       
 12878         (WebCore::RenderThemeGdk::paintRadio): No need for using a GdkPixmap, draw directly
       
 12879         (WebCore::RenderThemeGdk::paintButton): No need for using a GdkPixmap, draw directly
       
 12880         * platform/gdk/RenderThemeGdk.h: remove the copyContext call
       
 12881         * platform/gdk/ScrollViewGdk.cpp: gdkDrawable
       
 12882         (WebCore::ScrollView::updateView): gdkDrawable
       
 12883         (WebCore::ScrollView::update): clear the area to fix repainting issues
       
 12884         (WebCore::ScrollView::setGtkWidget): gdkDrawable
       
 12885         (WebCore::ScrollView::addChild): implement
       
 12886         (WebCore::ScrollView::removeChild): implement
       
 12887         * platform/gdk/TemporaryLinkStubs.cpp: Not needed header removed
       
 12888         * platform/gdk/WidgetGdk.cpp:
       
 12889         (WebCore::Widget::gdkDrawable): Renamed from drawable
       
 12890         (WebCore::Widget::setGtkWidget): use gdkDrawable
       
 12891         (WebCore::Widget::setCursor): gdkDrawable
       
 12892         (WebCore::Widget::show): gdkDrawable
       
 12893         (WebCore::Widget::hide): gdkDrawable
       
 12894         * platform/graphics/GraphicsContext.h: Allow to set the GdkDrawable, e.g. used inside a expose event
       
 12895         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
 12896         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
       
 12897         (WebCore::GraphicsContext::setGdkDrawable):
       
 12898         (WebCore::GraphicsContext::gdkDrawable):
       
 12899 
       
 12900 2007-07-16  Holger Hans Peter Freyther  <zecke@selfish.org>
       
 12901 
       
 12902         Reviewed by Maciej.
       
 12903 
       
 12904         Lazily update the scrollbars (e.g. on loading a page) to
       
 12905         generate less expose events, which will lead to laying out less often
       
 12906          and will fix http://bugs.webkit.org/show_bug.cgi?id=14020.
       
 12907 
       
 12908         * platform/gdk/ScrollViewGdk.cpp:
       
 12909         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
       
 12910         (WebCore::ScrollView::update):
       
 12911         (WebCore::ScrollView::resizeContents):
       
 12912         (WebCore::ScrollView::updateScrollbars):
       
 12913 
       
 12914 2007-07-16  Rob Buis  <buis@kde.org>
       
 12915 
       
 12916         Reviewed by Maciej.
       
 12917 
       
 12918         http://bugs.webkit.org/show_bug.cgi?id=14462
       
 12919         non empty <style> element doesn't work
       
 12920 
       
 12921         Return an empty sheet for empty <style> elements
       
 12922         instead of a null sheet. Clean up StyleElement a bit.
       
 12923 
       
 12924         * dom/StyleElement.cpp:
       
 12925         (WebCore::StyleElement::StyleElement):
       
 12926         (WebCore::StyleElement::sheet):
       
 12927         (WebCore::StyleElement::childrenChanged):
       
 12928         (WebCore::StyleElement::createSheet):
       
 12929         * dom/StyleElement.h:
       
 12930         (WebCore::StyleElement::setLoading):
       
 12931         * html/HTMLStyleElement.cpp:
       
 12932         (WebCore::HTMLStyleElement::HTMLStyleElement):
       
 12933         (WebCore::HTMLStyleElement::sheet):
       
 12934         * html/HTMLStyleElement.h:
       
 12935         (WebCore::HTMLStyleElement::setLoading):
       
 12936         * ksvg2/svg/SVGStyleElement.cpp:
       
 12937         (WebCore::SVGStyleElement::sheet):
       
 12938         (WebCore::SVGStyleElement::sheetLoaded):
       
 12939         * ksvg2/svg/SVGStyleElement.h:
       
 12940 
       
 12941 2007-07-15  Oliver Hunt  <oliver@apple.com>
       
 12942 
       
 12943         Reviewed by Adam.
       
 12944 
       
 12945         Fix for fix for <rdar://problem/5336602> REGRESSION: tab characters
       
 12946                         cannot be entered into text fields
       
 12947                         http://bugs.webkit.org/show_bug.cgi?id=14032
       
 12948 
       
 12949         Need to use UChar not char.
       
 12950 
       
 12951         * html/HTMLInputElement.cpp:
       
 12952         (WebCore::HTMLInputElement::constrainValue):
       
 12953 
       
 12954 2007-07-15  Sam Weinig  <sam@webkit.org>
       
 12955 
       
 12956         Reviewed by Geoff Garen.
       
 12957 
       
 12958         Remove redundant calls to isSafeScript()
       
 12959 
       
 12960         * bindings/js/JSDOMWindowCustom.cpp:
       
 12961         (WebCore::JSDOMWindow::customPut):
       
 12962         * bindings/js/kjs_window.cpp:
       
 12963         (KJS::Window::put):
       
 12964 
       
 12965 2007-07-15  Geoffrey Garen  <ggaren@apple.com>
       
 12966 
       
 12967         Reviewed by Maciej Stachowiak.
       
 12968         
       
 12969         Removed incorrect error log, seen while running layout tests.
       
 12970         
       
 12971         Perhaps at some point FrameLoadTypeInteral had a specific meaning
       
 12972         that prevented it from being used in non-child frame, non-redirect
       
 12973         situations. However, that meaning has been lost and nobody remembers
       
 12974         how to get it back.
       
 12975         
       
 12976         We currently use FrameLoadTypeInternal for any load that is not
       
 12977         initiated by a user gesture, so it's trivial to produce this error
       
 12978         log, even though nothing has gone wrong.
       
 12979 
       
 12980         * loader/FrameLoader.cpp:
       
 12981         (WebCore::FrameLoader::updateHistoryForInternalLoad):
       
 12982 
       
 12983 2007-07-15  Oliver Hunt  <oliver@apple.com>
       
 12984 
       
 12985         Reviewed by Maciej
       
 12986 
       
 12987         Fix for <rdar://problem/5336602> REGRESSION: tab characters cannot be entered into text fields
       
 12988                 http://bugs.webkit.org/show_bug.cgi?id=14032
       
 12989 
       
 12990         constrainValue attempted to block control characters from being inserted 
       
 12991         by a simple less than ' ' check, which prevent tab characters from being
       
 12992         inserted.  This patch adds an additional check to allow the tab character 
       
 12993         again
       
 12994 
       
 12995         * html/HTMLInputElement.cpp:
       
 12996         (WebCore::HTMLInputElement::constrainValue):
       
 12997 
       
 12998 2007-07-14  Brady Eidson  <beidson@apple.com>
       
 12999 
       
 13000         Third shot at blind Qt/GDK build fix
       
 13001 
       
 13002         * platform/gdk/TemporaryLinkStubs.cpp:
       
 13003         (FTPDirectoryDocument::createTokenizer):
       
 13004         * platform/qt/TemporaryLinkStubs.cpp:
       
 13005         (FTPDirectoryDocument::createTokenizer):
       
 13006 
       
 13007 2007-07-14  Brady Eidson  <beidson@apple.com>
       
 13008 
       
 13009         Reviewed by Sam
       
 13010 
       
 13011         Windows build fix
       
 13012 
       
 13013         * WebCore.vcproj/WebCore.vcproj:
       
 13014 
       
 13015 2007-07-14  Sam Weinig  <sam@webkit.org>
       
 13016 
       
 13017         Fix Tiger build.
       
 13018 
       
 13019         * config.h:
       
 13020 
       
 13021 2007-07-14  Brady Eidson  <beidson@apple.com>
       
 13022 
       
 13023         Blind attempt at (hopefully) fixing the Qt and GDK builds
       
 13024 
       
 13025         * platform/gdk/TemporaryLinkStubs.cpp:
       
 13026         (FTPDirectoryDocument::FTPDirectoryDocument):
       
 13027         * platform/qt/TemporaryLinkStubs.cpp:
       
 13028         (FTPDirectoryDocument::FTPDirectoryDocument):
       
 13029 
       
 13030 2007-07-14  Brady Eidson  <beidson@apple.com>
       
 13031 
       
 13032         Reviewed by Sam Weinig
       
 13033 
       
 13034         Initial check-in for <rdar://problem/3154486> - Supporting FTP directory listings in the browser
       
 13035 
       
 13036         Development has taken place on both Leopard and Windows (windows enabling patch will follow shortly)
       
 13037         Support will only exist on platforms whose network layers (ie, ResourceHandle) support piping the raw
       
 13038         FTP Directory data into the engine.  
       
 13039 
       
 13040         This is known to include Leopard, Windows, and CURL based platforms - probably others
       
 13041         Known incompatible platforms include Tiger.
       
 13042 
       
 13043         The FTP listing page is built in HTML.  An external HTML document can be provided as a template for the 
       
 13044         directory listing.  This document is parsed, and expected to have a <table> with a certain class in it.
       
 13045         As FTP directory listings come in, each entry is added to this table as a row.
       
 13046 
       
 13047         If no HTML template is provided to work with, a very basic empty document is hard coded that contains only 
       
 13048         this special table.
       
 13049 
       
 13050         Upgrades to the look and feel of the directory listings can take place largely in this HTML template which,
       
 13051         admittedly, is conspicuously absent in this initial checkin
       
 13052 
       
 13053         * WebCore.exp: New Settings symbols for WebKit
       
 13054         * WebCore.xcodeproj/project.pbxproj:
       
 13055 
       
 13056         * config.h: If BUILDING_ON_TIGER, disable FTP directory listing support
       
 13057 
       
 13058         * dom/DOMImplementation.cpp:
       
 13059         (WebCore::DOMImplementation::createDocument): Create an FTPDirectoryDocument if the mime type is 
       
 13060           "application/x-ftp-directory"
       
 13061 
       
 13062         * loader/FTPDirectoryDocument.cpp: Added.
       
 13063         (WebCore::FTPDirectoryTokenizer::isWaitingForScripts):
       
 13064         (WebCore::FTPDirectoryTokenizer::checkBuffer):
       
 13065         (WebCore::FTPDirectoryTokenizer::FTPDirectoryTokenizer): Building on HTML tokenizer, this facilitates 
       
 13066           parsing FTP Directory listings in the engine
       
 13067         (WebCore::FTPDirectoryTokenizer::appendEntry): Add a table row for a directory listing to the document
       
 13068         (WebCore::FTPDirectoryTokenizer::createTDForFilename): Create the TD for the filename with the anchor in it
       
 13069 
       
 13070         (WebCore::processFilesizeString): Prettify the filesize
       
 13071         (WebCore::wasLastDayOfMonth):
       
 13072         (WebCore::processFileDateString): Prettify the date
       
 13073         (WebCore::FTPDirectoryTokenizer::parseAndAppendOneLine):
       
 13074         (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate): Loads the HTML template that FTP directory listings
       
 13075           can build on top of
       
 13076         (WebCore::FTPDirectoryTokenizer::createBasicDocument): Creates a most basic document (body and one table) to
       
 13077           append the rows to in case the document template is not loaded and parsed
       
 13078         (WebCore::FTPDirectoryTokenizer::write): Add the FTP listing to the buffer and parse entries out of it
       
 13079         (WebCore::FTPDirectoryTokenizer::finish): 
       
 13080 
       
 13081         (WebCore::FTPDirectoryDocument::FTPDirectoryDocument): Special document-type for FTP directory listings
       
 13082         (WebCore::FTPDirectoryDocument::createTokenizer):
       
 13083         * loader/FTPDirectoryDocument.h: Added.
       
 13084         (WebCore::FTPDirectoryDocument::isImageDocument):
       
 13085         
       
 13086         * loader/FTPDirectoryParser.cpp: Added.
       
 13087         (WebCore::parseOneFTPLine): Adapted from ParseFTPList.cpp from Firefox - parses most known
       
 13088           FTP directory listing styles into discrete FTP directory entries
       
 13089         * loader/FTPDirectoryParser.h: Added.
       
 13090         (WebCore::ListState::ListState): Maintains FTP Parser state
       
 13091         (WebCore::ListResult::ListResult): Represents one FTP directory listing
       
 13092         (WebCore::ListResult::clear):
       
 13093 
       
 13094         * loader/FrameLoader.cpp:
       
 13095         (WebCore::FrameLoader::checkContentPolicy): If the Settings say to bypass the policy check for 
       
 13096           "application/x-ftp-directory", skip it.  This will allow people to test this feature even if their 
       
 13097           browser/WebKit app would otherwise not allow it
       
 13098 
       
 13099         * page/Settings.cpp:
       
 13100         (WebCore::Settings::Settings):
       
 13101         (WebCore::Settings::setFTPDirectoryTemplatePath): Set the path to the FTP listing document template
       
 13102         (WebCore::Settings::setForceFTPDirectoryListings): Set to bypass the policy delegate check for mime type
       
 13103           "application/x-ftp-directory"
       
 13104         * page/Settings.h:
       
 13105         (WebCore::Settings::ftpDirectoryTemplatePath):
       
 13106         (WebCore::Settings::forceFTPDirectoryListings):
       
 13107 
       
 13108         * platform/Logging.cpp: Add an "LogFTP" logging channel
       
 13109         * platform/Logging.h:
       
 13110         * platform/mac/LoggingMac.mm:
       
 13111         (WebCore::InitializeLoggingChannelsIfNecessary):
       
 13112 
       
 13113         * platform/MimeTypeRegistry.cpp:
       
 13114         (WebCore::initialiseSupportedNonImageMimeTypes): Add "application/x-ftp-directory"
       
 13115 
       
 13116         * platform/SharedBuffer.cpp:
       
 13117         (WebCore::SharedBuffer::createWithContentsOfFile): Stub for now
       
 13118         * platform/SharedBuffer.h:
       
 13119 
       
 13120         * platform/mac/SharedBufferMac.mm:
       
 13121         (WebCore::SharedBuffer::createWithContentsOfFile): Load contents of the file into an NSData, then
       
 13122           wrap that NSData
       
 13123 
       
 13124 2007-07-14  Alexey Proskuryakov  <ap@webkit.org>
       
 13125 
       
 13126         Reviewed by Darin.
       
 13127 
       
 13128         http://bugs.webkit.org/show_bug.cgi?id=14618
       
 13129         REGRESSION(13464): drivehq.com login form doesn't work
       
 13130 
       
 13131         Test: http/tests/misc/post-submit-button.html
       
 13132 
       
 13133         * html/HTMLInputElement.cpp:
       
 13134         (WebCore::HTMLInputElement::appendFormData): Append a submit even if its value is empty.
       
 13135 
       
 13136 2007-07-13  Oliver Hunt  <oliver@apple.com>
       
 13137 
       
 13138         Reviewed by Sam.
       
 13139 
       
 13140         Fix for 
       
 13141             <rdar://problem/5335265> REGRESSION: WebCore::DragController crashes if WebDragSourceActionDHTML cleared
       
 13142             http://bugs.webkit.org/show_bug.cgi?id=13652
       
 13143 
       
 13144         Reorder logic for drag initiation: we can always preflight the clipboard, regardless as to whether 
       
 13145         we are performing any dhtml drag handling    
       
 13146 
       
 13147         * page/EventHandler.cpp:
       
 13148         (WebCore::EventHandler::handleDrag):
       
 13149 
       
 13150 2007-07-13  Matt Lilek  <pewtermoose@gmail.com>
       
 13151 
       
 13152         Reviewed by Tim Hatcher.
       
 13153 
       
 13154         Bug 14401: Semi-regression: Can no longer copy anything from the inspector
       
 13155         http://bugs.webkit.org/show_bug.cgi?id=14401
       
 13156 
       
 13157         * page/inspector/inspector.css:
       
 13158 
       
 13159 2007-07-13  Beth Dakin  <bdakin@apple.com>
       
 13160 
       
 13161         Reviewed by Hyatt.
       
 13162 
       
 13163         Fix for <rdar://problem/5304742> A hang occurs when attempting to 
       
 13164         display web clip banner at http://www.signonsandiego.com/sports/
       
 13165         chargers/index.html
       
 13166 
       
 13167         Here is the actual fix. 
       
 13168         * rendering/RenderInline.cpp:
       
 13169         (WebCore::RenderInline::absoluteRects): Set topLevel to 
       
 13170         false when we recurse to get our children's absoluteRects.
       
 13171         * rendering/RenderInline.h: New boolean parameter 
       
 13172         topLevel that defaults to true.
       
 13173         * rendering/RenderObject.cpp:
       
 13174         (WebCore::RenderObject::absoluteRects):
       
 13175         * rendering/RenderObject.h:
       
 13176 
       
 13177         And these are just other implementations/declarations of this 
       
 13178         (virtual) function that have to add the parameter. No behavior 
       
 13179         change here.
       
 13180         * rendering/RenderPath.cpp:
       
 13181         (WebCore::RenderPath::absoluteRects):
       
 13182         * rendering/RenderPath.h:
       
 13183         * rendering/RenderSVGContainer.cpp:
       
 13184         (WebCore::RenderSVGContainer::absoluteRects):
       
 13185         * rendering/RenderSVGContainer.h:
       
 13186         * rendering/RenderSVGHiddenContainer.cpp:
       
 13187         (WebCore::RenderSVGHiddenContainer::absoluteRects):
       
 13188         * rendering/RenderSVGHiddenContainer.h:
       
 13189         * rendering/RenderSVGImage.cpp:
       
 13190         (WebCore::RenderSVGImage::absoluteRects):
       
 13191         * rendering/RenderSVGImage.h:
       
 13192         * rendering/RenderSVGInlineText.cpp:
       
 13193         (WebCore::RenderSVGInlineText::absoluteRects):
       
 13194         * rendering/RenderSVGInlineText.h:
       
 13195         * rendering/RenderSVGTSpan.cpp:
       
 13196         (WebCore::RenderSVGTSpan::absoluteRects):
       
 13197         * rendering/RenderSVGTSpan.h:
       
 13198         * rendering/RenderSVGText.cpp:
       
 13199         (WebCore::RenderSVGText::absoluteRects):
       
 13200         * rendering/RenderSVGText.h:
       
 13201         * rendering/RenderText.cpp:
       
 13202         (WebCore::RenderText::absoluteRects):
       
 13203         * rendering/RenderText.h:
       
 13204         * rendering/RenderView.cpp:
       
 13205         (WebCore::RenderView::absoluteRects):
       
 13206         * rendering/RenderView.h:
       
 13207 
       
 13208 2007-07-13  Mitz Pettel  <mitz@webkit.org>
       
 13209 
       
 13210         Reviewed by Hyatt.
       
 13211 
       
 13212         - fix http://bugs.webkit.org/show_bug.cgi?id=13438 <rdar://problem/5153030>
       
 13213               Run rounding makes word-break:break-all/word not functional
       
 13214 
       
 13215         Test: fast/text/word-break-run-rounding.html
       
 13216 
       
 13217         * rendering/RenderText.cpp:
       
 13218         (WebCore::RenderText::calcPrefWidths): Update the maximum width only on word
       
 13219         boundaries to avoid rounding errors.
       
 13220         * rendering/bidi.cpp:
       
 13221         (WebCore::RenderBlock::findNextLineBreak): Integrated breakAll with the
       
 13222         midWordBreak/wrapW mechanism. Also made the wrapW upper bound more accurate
       
 13223         by resetting it when tmpW is committed.
       
 13224 
       
 13225 2007-07-13  Sam Weinig  <sam@webkit.org>
       
 13226 
       
 13227         Reviewed by Geoff Garen.
       
 13228 
       
 13229         Patch for <rdar://problem/5318394>
       
 13230         http site can read/write content of https site in same domain
       
 13231 
       
 13232         Add protocol and port checks in isSafeScript.
       
 13233 
       
 13234         * bindings/js/kjs_window.cpp:
       
 13235         (KJS::Window::isSafeScript):
       
 13236 
       
 13237 2007-07-13  Anders Carlsson  <andersca@apple.com>
       
 13238 
       
 13239         Reviewed by Mitz Pettel.
       
 13240 
       
 13241         <rdar://problem/5298870> 
       
 13242         REGRESSION: In Yahoo Mail modal dialog, OK and Cancel buttons do not work, and descriptive text is missing (14327)
       
 13243         
       
 13244         http://bugs.webkit.org/show_bug.cgi?id=14327
       
 13245         REGRESSION (r21367): dialogArguments not set in window generated by showModalDialog
       
 13246 
       
 13247         When creating popup windows/dialogs, prevent the window properties from being cleared by the initial frame load.
       
 13248         
       
 13249         * loader/FrameLoader.cpp:
       
 13250         (WebCore::FrameLoader::FrameLoader):
       
 13251         (WebCore::FrameLoader::createWindow):
       
 13252         (WebCore::FrameLoader::clear):
       
 13253         (WebCore::FrameLoader::begin):
       
 13254         (WebCore::FrameLoader::open):
       
 13255         * loader/FrameLoader.h:
       
 13256         (WebCore::FrameLoader::setShouldClearWindowProperties):
       
 13257         * manual-tests/modal-dialog-arguments.html: Added.
       
 13258 
       
 13259 2007-07-13  Steve Falkenburg  <sfalken@apple.com>
       
 13260 
       
 13261         Update ResourceError related code to account for changes in CF interfaces.
       
 13262 
       
 13263         Reviewed by Darin, Ada.
       
 13264 
       
 13265         * platform/network/ResourceError.h: Change Mac conditionals to CF to share more code.
       
 13266         * platform/network/cf/ResourceErrorCF.cpp:
       
 13267         (WebCore::ResourceError::ResourceError): Modified based on CFErrorRef changes
       
 13268         (WebCore::ResourceError::unpackPlatformError): Ported from ResourceErrorMac.mm.
       
 13269         (WebCore::ResourceError::operator CFErrorRef): Ported from ResourceErrorMac.mm.
       
 13270         (WebCore::ResourceError::operator CFStreamError): Modified based on CFErrorRef changes.
       
 13271 
       
 13272 2007-07-13  Antti Koivisto  <antti@apple.com>
       
 13273 
       
 13274         Reviewed by Adele.
       
 13275         
       
 13276         Fix <rdar://problem/5192256>
       
 13277         click() in onchange handler causes another change event (causes hang at http://forums.whirlpool.net.au/)
       
 13278         
       
 13279         Guard against generating a simulated event from within a simulated event in the same node. Try to
       
 13280         match Firefox behavior.
       
 13281 
       
 13282         * dom/EventTargetNode.cpp:
       
 13283         (WebCore::EventTargetNode::dispatchSimulatedMouseEvent):
       
 13284         (WebCore::EventTargetNode::dispatchSimulatedClick):
       
 13285         * dom/Node.cpp:
       
 13286         (WebCore::Node::Node):
       
 13287         * dom/Node.h:
       
 13288 
       
 13289 2007-07-13  Antti Koivisto  <antti@apple.com>
       
 13290 
       
 13291         Reviewed by Darin.
       
 13292         
       
 13293         Fix <rdar://problem/5333387>
       
 13294         Combination of selection and click() on checkbox crashes
       
 13295         
       
 13296         Ensure there is no pending style update before doing synchronous paint. Under certain
       
 13297         circumstances this ends up doing style recalc in middle of paint() which may
       
 13298         for example tear down the rendering tree being painted, with bad results.
       
 13299 
       
 13300         * dom/ContainerNode.cpp:
       
 13301         (WebCore::ContainerNode::setActive):
       
 13302 
       
 13303 2007-07-13  Antti Koivisto  <antti@apple.com>
       
 13304 
       
 13305         Reviewed by Adele.
       
 13306         
       
 13307         Fix <rdar://problem/5333365>
       
 13308         Calling click() is very slow
       
 13309         
       
 13310         There is a 100ms delay in ContainerNode::setActive() to do an activation effect. It is used for
       
 13311         simulated mouse activations (using keyboard for example). However, it shouldn't be done when calling from javascript 
       
 13312         (through click() interface) since it hangs script execution.
       
 13313 
       
 13314         * html/HTMLElement.cpp:
       
 13315         (WebCore::HTMLElement::click):
       
 13316 
       
 13317 2007-07-13  Mitz Pettel  <mitz@webkit.org>
       
 13318 
       
 13319         Reviewed by Dave Hyatt.
       
 13320 
       
 13321         - fix http://bugs.webkit.org/show_bug.cgi?id=13873
       
 13322           Incomplete repaint of replaced element's box shadow
       
 13323 
       
 13324         Tests: fast/repaint/box-shadow-h.html
       
 13325                fast/repaint/box-shadow-v.html
       
 13326 
       
 13327         * rendering/RenderHTMLCanvas.cpp:
       
 13328         (WebCore::RenderHTMLCanvas::layout): Added a call to adjustOverflowForBoxShadow().
       
 13329         * rendering/RenderImage.cpp:
       
 13330         (WebCore::RenderImage::layout): Ditto.
       
 13331         * rendering/RenderPartObject.cpp:
       
 13332         (WebCore::RenderPartObject::layout): Ditto.
       
 13333         * rendering/RenderReplaced.cpp:
       
 13334         (WebCore::RenderReplaced::RenderReplaced): Initialize m_hasOverflow.
       
 13335         (WebCore::RenderReplaced::~RenderReplaced): Added. Removes this object from the
       
 13336         overflow rect map if it has overflow.
       
 13337         (WebCore::RenderReplaced::shouldPaint): Account for overflow.
       
 13338         (WebCore::RenderReplaced::adjustOverflowForBoxShadow): Added. Creates or
       
 13339         removes an entry for this object in the global overflow rect map.
       
 13340         (WebCore::RenderReplaced::overflowHeight): Added.
       
 13341         (WebCore::RenderReplaced::overflowWidth): Added.
       
 13342         (WebCore::RenderReplaced::overflowLeft): Added.
       
 13343         (WebCore::RenderReplaced::overflowTop): Added.
       
 13344         (WebCore::RenderReplaced::overflowRect): Added.
       
 13345         * rendering/RenderReplaced.h:
       
 13346 
       
 13347 2007-07-13  Mitz Pettel  <mitz@webkit.org>
       
 13348 
       
 13349         Reviewed by Dave Hyatt.
       
 13350 
       
 13351         - fix http://bugs.webkit.org/show_bug.cgi?id=14395
       
 13352           When a <p> is inside <li> two <BR>s are rendered
       
 13353 
       
 13354         Test: fast/lists/marker-before-empty-inline.html
       
 13355 
       
 13356         * rendering/RenderBlock.h:
       
 13357         * rendering/RenderListItem.cpp:
       
 13358         (WebCore::getParentOfFirstLineBox): Changed to skip empty inline flows that
       
 13359         do not actually generate any line boxes. Limited the nested lists quirk to
       
 13360         the case where the list is a child of the list item, to match Firefox.
       
 13361         * rendering/bidi.cpp:
       
 13362         (WebCore::requiresLineBox): Added. Factored out of skipWhitespace.
       
 13363         (WebCore::RenderBlock::generatesLineBoxesForInlineChild): Added. Checkes
       
 13364         whether the child or any of its siblings following it will generate a line
       
 13365         box in the flow.
       
 13366         (WebCore::RenderBlock::skipWhitespace):
       
 13367 
       
 13368 2007-07-13  Holger Hans Peter Freyther  <zecke@selfish.org>
       
 13369 
       
 13370         Reviewed by Alexey.
       
 13371 
       
 13372         Move HTTP methods to parse Content-Type from xmlhttprequest.cpp
       
 13373         which is LGPL to HTTPParsers.cpp. As both files were written by the
       
 13374         same author and the advice to move them came from him I think this move
       
 13375         is what is meant to be done.
       
 13376 
       
 13377         Move filenameFromHTTPContentDisposition to HTTPParsers as well. This parse
       
 13378         function uses Vector<String>::split and doesn't honor quoting. This needs
       
 13379         to be fixed in later versions.
       
 13380 
       
 13381         http://bugs.webkit.org/show_bug.cgi?id=5954 and http://bugs.webkit.org/show_bug.cgi?id=14059
       
 13382         benefit from this change.
       
 13383 
       
 13384         * platform/network/HTTPParsers.cpp:
       
 13385         (WebCore::filenameFromHTTPContentDisposition):
       
 13386         (WebCore::extractMIMETypeFromMediaType):
       
 13387         (WebCore::extractCharsetFromMediaType):
       
 13388         * platform/network/HTTPParsers.h:
       
 13389         * platform/network/cf/ResourceResponseCFNet.cpp:
       
 13390         * xml/xmlhttprequest.cpp:
       
 13391         (WebCore::XMLHttpRequest::responseMIMEType):
       
 13392         (WebCore::XMLHttpRequest::didReceiveResponse):
       
 13393 
       
 13394 2007-07-13  Mark Rowe  <mrowe@apple.com>
       
 13395 
       
 13396         Reviewed by Mitz.
       
 13397 
       
 13398         Build fix.  Stub out ChromeClientGdk::print and SVGEmptyChromeClient::print.
       
 13399 
       
 13400         * platform/gdk/ChromeClientGdk.h:
       
 13401         * platform/gdk/TemporaryLinkStubs.cpp:
       
 13402         (ChromeClientGdk::print):
       
 13403         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 13404         (WebCore::SVGEmptyChromeClient::print):
       
 13405 
       
 13406 2007-07-12  Alice Liu  <alice.liu@apple.com>
       
 13407 
       
 13408         Reviewed by Maciej and Steve.
       
 13409 
       
 13410         fixed <rdar://4982432> window.print() needs to be implemented
       
 13411 
       
 13412         * bridge/win/FrameWin.cpp:
       
 13413         (WebCore::Frame::print):
       
 13414         * page/Chrome.cpp:
       
 13415         (WebCore::Chrome::print):
       
 13416         * page/Chrome.h:
       
 13417         * page/ChromeClient.h:
       
 13418         * platform/win/TemporaryLinkStubs.cpp:
       
 13419 
       
 13420 2007-07-11  Justin Garcia  <justin.garcia@apple.com>
       
 13421 
       
 13422         Reviewed by Harrison.
       
 13423         
       
 13424         <rdar://problem/5300379> Mail hung on option-delete
       
 13425         
       
 13426         We were starting backward iteration at [container, 0] and
       
 13427         emitting for container over and over.
       
 13428 
       
 13429         * editing/TextIterator.cpp:
       
 13430         (WebCore::SimplifiedBackwardsTextIterator::advance): Don't 
       
 13431         emit characters for a node if we're starting iteration at 
       
 13432         [container, 0].  Don't emit characters for exiting containers
       
 13433         if we've already done so.
       
 13434 
       
 13435 2007-07-12  Kevin Decker  <kdecker@apple.com>
       
 13436 
       
 13437         Reviewed by Mark Rowe.
       
 13438 
       
 13439         <rdar://problem/5039463> find a good gray that works well for full frame plug-ins; consistent look for plugins
       
 13440 
       
 13441         * loader/PluginDocument.cpp:
       
 13442         (WebCore::PluginTokenizer::createDocumentStructure): Changed values to a darker gray, per request from the HI team.
       
 13443 
       
 13444 2007-07-11  Sam Weinig  <sam@webkit.org>
       
 13445 
       
 13446         Reviewed by Maciej.
       
 13447 
       
 13448         Patch for <rdar://problem/5329841>
       
 13449         Calling window.closed on a closed window causes Safari to crash
       
 13450 
       
 13451         - Replaces the Frame member variable in KJS::Window for more appropriate DOMWindow
       
 13452         - Adds additional new null checks as necessary
       
 13453         - Removes bogus toBoolean method
       
 13454         - Removes unused scheduleClose method
       
 13455 
       
 13456         Test: fast/dom/Window/window-closed-crash.html
       
 13457 
       
 13458         * bindings/js/JSCustomXPathNSResolver.cpp:
       
 13459         (WebCore::JSCustomXPathNSResolver::create):
       
 13460         * bindings/js/JSDOMWindowCustom.cpp:
       
 13461         (WebCore::JSDOMWindow::customGetOwnPropertySlot):
       
 13462         (WebCore::JSDOMWindow::customPut):
       
 13463         * bindings/js/JSXMLHttpRequest.cpp:
       
 13464         (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
       
 13465         * bindings/js/kjs_events.cpp:
       
 13466         (WebCore::JSAbstractEventListener::handleEvent):
       
 13467         (WebCore::JSLazyEventListener::parseCode):
       
 13468         * bindings/js/kjs_window.cpp:
       
 13469         (KJS::Window::Window):
       
 13470         (KJS::Window::impl):
       
 13471         (KJS::Window::interpreter):
       
 13472         (KJS::Window::location):
       
 13473         (KJS::Window::find):
       
 13474         (KJS::allowPopUp):
       
 13475         (KJS::createWindow):
       
 13476         (KJS::canShowModalDialog):
       
 13477         (KJS::canShowModalDialogNow):
       
 13478         (KJS::showModalDialog):
       
 13479         (KJS::Window::getValueProperty):
       
 13480         (KJS::Window::childFrameGetter):
       
 13481         (KJS::Window::indexGetter):
       
 13482         (KJS::Window::namedItemGetter):
       
 13483         (KJS::Window::getOwnPropertySlot):
       
 13484         (KJS::Window::put):
       
 13485         (KJS::Window::isSafeScript):
       
 13486         (KJS::Window::setListener):
       
 13487         (KJS::Window::getListener):
       
 13488         (KJS::Window::clear):
       
 13489         (KJS::WindowFunc::callAsFunction):
       
 13490         (KJS::Window::updateLayout):
       
 13491         (KJS::ScheduledAction::execute):
       
 13492         (KJS::Window::disconnectFrame):
       
 13493         (KJS::Location::put):
       
 13494         (KJS::LocationFunc::callAsFunction):
       
 13495         * bindings/js/kjs_window.h:
       
 13496         * page/mac/WebCoreFrameBridge.mm:
       
 13497         (updateRenderingForBindings):
       
 13498 
       
 13499 2007-07-12  Mark Rowe  <mrowe@apple.com>
       
 13500 
       
 13501         Reviewed by Ada.
       
 13502 
       
 13503         <rdar://problem/5329877> REGRESSION: Document::setTransformSource leaks an xmlDocPtr if called more than once per document
       
 13504 
       
 13505         * dom/Document.cpp:
       
 13506         (WebCore::Document::setTransformSource): Free any existing m_transformSource before overwriting it, rather than simply leaking it.
       
 13507         * dom/Document.h:
       
 13508 
       
 13509 2007-07-12  Holger Hans Peter Freyther  <zecke@selfish.org>
       
 13510 
       
 13511         Reviewed by Mark Rowe.
       
 13512 
       
 13513         Fix compilation of the CURL backend after the removing of accessors from ResourceHandle in r24202
       
 13514 
       
 13515         * platform/network/curl/ResourceHandleManager.cpp:
       
 13516         (WebCore::ResourceHandleManager::setupPOST):
       
 13517         (WebCore::ResourceHandleManager::startJob):
       
 13518 
       
 13519 2007-07-12  Mark Rowe  <mrowe@apple.com>
       
 13520 
       
 13521         Reviewed by Darin.
       
 13522 
       
 13523         <rdar://problem/5327189> Logic error in DeprecatedString::to{,U}Int{,64} can lead to reading past end of buffer
       
 13524 
       
 13525         The fix for reading past the end of the buffer is to verify we are not at the end of the string before checking
       
 13526         for a leading '+' character.  Rather than fixing the logic error in four nearly-identical functions I chose to
       
 13527         extract the common functionality into the toIntegralType helper function which the four functions call through to.
       
 13528 
       
 13529         * platform/DeprecatedString.cpp:
       
 13530         (WebCore::isCharacterAllowedInBase):
       
 13531         (WebCore::toIntegralType):
       
 13532         (WebCore::DeprecatedString::toInt):
       
 13533         (WebCore::DeprecatedString::toInt64):
       
 13534         (WebCore::DeprecatedString::toUInt):
       
 13535         (WebCore::DeprecatedString::toUInt64):
       
 13536 
       
 13537 2007-07-12  George Staikos  <staikos@kde.org>
       
 13538 
       
 13539         Reviewed by Alexey.
       
 13540 
       
 13541         Remove unused variables and fix rendering of comoboxes.
       
 13542 
       
 13543         * platform/graphics/qt/ImageQt.cpp:
       
 13544         (WebCore::BitmapImage::draw):
       
 13545         * platform/qt/RenderThemeQt.cpp:
       
 13546         (WebCore::RenderThemeQt::paintMenuList):
       
 13547 
       
 13548 2007-07-11  Oliver Hunt  <oliver@apple.com>
       
 13549 
       
 13550         Reviewed by Maciej
       
 13551 
       
 13552         Fix for <rdar://problem/5329712> GMail crash when trying to compose new message
       
 13553 
       
 13554         * platform/win/FontDataWin.cpp:
       
 13555         (WebCore::FontData::containsCharacters):
       
 13556 
       
 13557 2007-07-11  Alexey Proskuryakov  <ap@webkit.org>
       
 13558 
       
 13559         Reviewed by Darin.
       
 13560 
       
 13561         http://bugs.webkit.org/show_bug.cgi?id=14584
       
 13562         XMLHttpRequest treats null login/password incorrectly
       
 13563 
       
 13564         Test: http/tests/xmlhttprequest/null-auth.php
       
 13565 
       
 13566         * xml/xmlhttprequest.cpp:
       
 13567         (WebCore::XMLHttpRequest::open):
       
 13568         * xml/xmlhttprequest.h:
       
 13569         Split the open() method into three to distinguish between missing and null credentials.
       
 13570 
       
 13571         * bindings/js/JSXMLHttpRequest.cpp:
       
 13572         (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction): Call the appropriate open().
       
 13573 
       
 13574 2007-07-11  Oliver Hunt  <oliver@apple.com>
       
 13575 
       
 13576         Build fix for windows
       
 13577 
       
 13578         * page/Frame.cpp:
       
 13579         (WebCore::Frame::firstRectForRange):
       
 13580 
       
 13581 2007-07-11  Oliver Hunt  <oliver@apple.com>
       
 13582 
       
 13583         Reviewed by Maciej.
       
 13584 
       
 13585         Fix <rdar://problem/5329481> Character range rect code for IME support needs to be crossplatform
       
 13586 
       
 13587         Move -[WebCoreFrameBridge firstRectForDOMRange:] to Frame::firstRectForRange
       
 13588 
       
 13589         * page/Frame.cpp:
       
 13590         (WebCore::Frame::firstRectForRange):
       
 13591         * page/Frame.h:
       
 13592         * page/mac/WebCoreFrameBridge.mm:
       
 13593         (-[WebCoreFrameBridge firstRectForDOMRange:]):
       
 13594 
       
 13595 2007-07-11  Steve Falkenburg  <sfalken@apple.com>
       
 13596 
       
 13597         Static analysis build fix.
       
 13598         
       
 13599         Only specify /analyze (PREfast) if it is available.
       
 13600         Prevents entire project from rebuilding each time.        
       
 13601 
       
 13602         Reviewed by Hyatt.
       
 13603 
       
 13604         * WebCore.vcproj/WebCore.vcproj:
       
 13605 
       
 13606 2007-07-11  George Staikos  <staikos@kde.org>
       
 13607 
       
 13608         Reviewed by Olliej.
       
 13609 
       
 13610         Make comboboxes update when the current item is changed.
       
 13611 
       
 13612         * platform/qt/PopupMenuQt.cpp:
       
 13613         (WebCore::PopupMenu::updateFromElement):
       
 13614         * platform/qt/QWebPopup.cpp:
       
 13615         (WebCore::QWebPopup::activeChanged):
       
 13616 
       
 13617 2007-07-11  George Staikos  <staikos@kde.org>
       
 13618 
       
 13619         Reviewed by Brady.
       
 13620 
       
 13621         Add a destructor to cleanup the SQL handle.
       
 13622 
       
 13623         * loader/icon/SQLDatabase.h:
       
 13624         (WebCore::SQLDatabase::~SQLDatabase):
       
 13625 
       
 13626 2007-07-11  Holger Hans Peter Freyther  <zecke@selfish.org>
       
 13627 
       
 13628         Reviewed by Darin.
       
 13629 
       
 13630         As of http://bugs.webkit.org/show_bug.cgi?id=14527 move the
       
 13631         WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore
       
 13632 
       
 13633         * ForwardingHeaders/JavaScriptCore: Removed.
       
 13634         * ForwardingHeaders/JavaScriptCore/APICast.h: Removed.
       
 13635         * ForwardingHeaders/JavaScriptCore/JSBase.h: Removed.
       
 13636         * ForwardingHeaders/JavaScriptCore/JSContextRef.h: Removed.
       
 13637         * ForwardingHeaders/JavaScriptCore/JSLock.h: Removed.
       
 13638         * ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Removed.
       
 13639         * ForwardingHeaders/JavaScriptCore/JSStringRef.h: Removed.
       
 13640         * ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Removed.
       
 13641         * ForwardingHeaders/JavaScriptCore/JSValueRef.h: Removed.
       
 13642         * ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Removed.
       
 13643 
       
 13644 2007-07-11  Anders Carlsson  <andersca@apple.com>
       
 13645 
       
 13646         Fix build.
       
 13647         
       
 13648         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 13649         (WebCore::willSendRequest):
       
 13650         (WebCore::didReceiveResponse):
       
 13651         (WebCore::didReceiveData):
       
 13652         (WebCore::didFinishLoading):
       
 13653         (WebCore::didFail):
       
 13654         (WebCore::didReceiveChallenge):
       
 13655 
       
 13656 2007-07-11  George Staikos  <staikos@kde.org>
       
 13657 
       
 13658         Repair the build.
       
 13659 
       
 13660         * platform/network/qt/ResourceHandleQt.cpp:
       
 13661         (WebCore::ResourceHandle::start):
       
 13662 
       
 13663 2007-07-11  Adele Peterson  <adele@apple.com>
       
 13664 
       
 13665         Reviewed by Darin.
       
 13666 
       
 13667         Fix for <rdar://problem/5230188> REGRESSION: Active/inactive marked text is not distinguished in textfields and textareas
       
 13668 
       
 13669         We were previously trying to leave room for 1px of space between the text and the underline.
       
 13670         This change removes that requirement so that if we don't have room for the extra space, we still draw the thick underline
       
 13671         touching the text.
       
 13672 
       
 13673         * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintMarkedTextUnderline):
       
 13674 
       
 13675 2007-07-11  Anders Carlsson  <andersca@apple.com>
       
 13676 
       
 13677         Reviewed by Darin and Geoff.
       
 13678 
       
 13679         <rdar://problem/5313508>
       
 13680         REGRESSION (Leopard): http/tests/xmlhttprequest/basic-auth.html hangs
       
 13681         
       
 13682         Leopard Foundation now ignores credentials passed in as part of the URL so we need to pass them ourselves.
       
 13683         
       
 13684         For the asynchronous case, we simply keep track of the URL and if it has a user name and password, we
       
 13685         pass those if we're asked to authenticate.
       
 13686                 
       
 13687         For the synchronous case, implement a new connection delegate and run it in a separate mode so 
       
 13688         no other sources will fire.
       
 13689 
       
 13690         * platform/network/mac/ResourceHandleMac.mm:
       
 13691         (WebCore::ResourceHandle::loadResourceSynchronously):
       
 13692         (-[WebCoreResourceHandleAsDelegate dealloc]):
       
 13693         (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
       
 13694         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
       
 13695         (-[WebCoreSynchronousLoader _isDone]):
       
 13696         (-[WebCoreSynchronousLoader dealloc]):
       
 13697         (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]):
       
 13698         (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]):
       
 13699         (-[WebCoreSynchronousLoader connection:didReceiveResponse:]):
       
 13700         (-[WebCoreSynchronousLoader connection:didReceiveData:]):
       
 13701         (-[WebCoreSynchronousLoader connectionDidFinishLoading:]):
       
 13702         (-[WebCoreSynchronousLoader connection:didFailWithError:]):
       
 13703         (-[WebCoreSynchronousLoader _data]):
       
 13704         (-[WebCoreSynchronousLoader _response]):
       
 13705         (-[WebCoreSynchronousLoader _error]):
       
 13706         (+[WebCoreSynchronousLoader loadRequest:returningResponse:error:]):
       
 13707 
       
 13708 2007-07-11  Darin Adler  <darin@apple.com>
       
 13709 
       
 13710         Reviewed by Sam Weinig.
       
 13711 
       
 13712         - fix <rdar://problem/5315265> REGRESSION: Leopard launch time -
       
 13713           there are about 190 stats of icudt36b files during launch
       
 13714 
       
 13715         * platform/TextEncodingRegistry.cpp: (WebCore::atomicCanonicalTextEncodingName):
       
 13716         Add a special case for the empty string so we don't load the extended text
       
 13717         encodings just so we can return 0 for that case.
       
 13718 
       
 13719 2007-07-11  Anders Carlsson  <andersca@apple.com>
       
 13720 
       
 13721         Reviewed by Darin.
       
 13722 
       
 13723         Remove a bunch of unneeded accessors from ResourceHandle.
       
 13724         
       
 13725         * loader/icon/IconLoader.cpp:
       
 13726         (WebCore::IconLoader::didReceiveResponse):
       
 13727         (WebCore::IconLoader::didFail):
       
 13728         (WebCore::IconLoader::didFinishLoading):
       
 13729         * platform/network/ResourceHandle.cpp:
       
 13730         * platform/network/ResourceHandle.h:
       
 13731 
       
 13732 2007-07-09  Justin Garcia  <justin.garcia@apple.com>
       
 13733 
       
 13734         Reviewed by Darin.
       
 13735         
       
 13736         <rdar://problem/5234383> REGRESSION: Sentence breaker method returning entire document length
       
 13737         
       
 13738         The functions for moving the caret to the next/previous sentence boundary
       
 13739         were in many cases moving to the beginning/end of the document.  The functions that 
       
 13740         should move the caret to an equivalent position in the next/previous sentence behaved
       
 13741         like the aforementioned functions ought to.  Put the code from the second two functions
       
 13742         in the first and made sure that the second two are properly FIXMEd.  They're rarely 
       
 13743         used (filed 5323691).
       
 13744         
       
 13745         * editing/SelectionController.cpp:
       
 13746         (WebCore::SelectionController::modify): Added an option for sentenceBoundary granularity,
       
 13747         so that we can test the functions that were broken from JS.
       
 13748         * editing/visible_units.cpp:
       
 13749         (WebCore::startOfSentence): Removed the FIXME about 5234383.
       
 13750         (WebCore::endSentenceBoundary): Make this function do what nextSentencePositionBoundary
       
 13751         current does.
       
 13752         (WebCore::endOfSentence): Removed the FIXME about 5234383.
       
 13753         (WebCore::previousSentencePosition): Removed an incorrect FIXME.
       
 13754         (WebCore::nextSentencePositionBoundary): Tweaked FIXME.  This function is
       
 13755         identical, not close to endSentenceBoundary.
       
 13756         (WebCore::nextSentencePosition): Removed an incorrect FIXME.
       
 13757 
       
 13758 2007-07-11  Rob Buis  <buis@kde.org>
       
 13759 
       
 13760         Reviewed by Darin.
       
 13761 
       
 13762         http://bugs.webkit.org/show_bug.cgi?id=14453
       
 13763         REGRESSION: www.nzherald.co.nz almost all the formating is gone
       
 13764  
       
 13765         Be less strict for the hex color definition.
       
 13766 
       
 13767         * css/CSSGrammar.y:
       
 13768         * css/cssparser.cpp:
       
 13769         (WebCore::CSSParser::lex):
       
 13770         (WebCore::CSSParser::text):
       
 13771         * css/tokenizer.flex:
       
 13772 
       
 13773 2007-07-11  Rob Buis  <buis@kde.org>
       
 13774 
       
 13775         Reviewed by Oliver.
       
 13776 
       
 13777         Forgot to commit this as part of commit r24146. Now we are sure
       
 13778         createElement creates elements in the xhtml namespace only.
       
 13779 
       
 13780         * ksvg2/svg/SVGDocument.cpp:
       
 13781         * ksvg2/svg/SVGDocument.h:
       
 13782 
       
 13783 2007-07-10  Sam Weinig  <sam@webkit.org>
       
 13784 
       
 13785         Reviewed by Oliver.
       
 13786 
       
 13787         Move more attributes from the pure JS bindings in KJS::Window
       
 13788         to the implementation in DOMWindow and autogenerate the new bindings
       
 13789 
       
 13790         Test: fast/dom/Window/get-set-properties.html
       
 13791 
       
 13792         * bindings/js/JSDOMWindowCustom.cpp:
       
 13793         (WebCore::JSDOMWindow::customGetOwnPropertySlot): Change to use propHashTable in
       
 13794         JSDOMWindow instead of KJS::Window
       
 13795         * bindings/js/kjs_window.cpp:
       
 13796         (KJS::Window::getValueProperty):
       
 13797         (KJS::Window::put):
       
 13798         * bindings/js/kjs_window.h:
       
 13799         (KJS::Window::):
       
 13800         * bindings/scripts/CodeGeneratorJS.pm: Cleanup getValueProperty and put generation
       
 13801         to reduce code duplication. 
       
 13802         * page/DOMWindow.cpp:
       
 13803         (WebCore::DOMWindow::closed):
       
 13804         (WebCore::DOMWindow::length):
       
 13805         (WebCore::DOMWindow::name):
       
 13806         (WebCore::DOMWindow::setName):
       
 13807         (WebCore::DOMWindow::status):
       
 13808         (WebCore::DOMWindow::setStatus):
       
 13809         (WebCore::DOMWindow::defaultStatus):
       
 13810         (WebCore::DOMWindow::setDefaultStatus):
       
 13811         * page/DOMWindow.h:
       
 13812         (WebCore::DOMWindow::defaultstatus):
       
 13813         (WebCore::DOMWindow::setDefaultstatus):
       
 13814         * page/DOMWindow.idl:
       
 13815 
       
 13816 2007-07-10  Sam Weinig  <sam@webkit.org>
       
 13817 
       
 13818         Reviewed by Geoff.
       
 13819 
       
 13820         Fix for <rdar://problem/5326791> XSS vulnerability: ability to set window.defaultStatus,
       
 13821         window.defaultstatus and window.status cross domains
       
 13822 
       
 13823         Test: http/tests/security/cross-frame-access-put.html
       
 13824 
       
 13825         * bindings/js/kjs_window.cpp:
       
 13826         (KJS::Window::put): Adds isSafeScript check for defaultStatus,
       
 13827         defaultstatus and status cases.
       
 13828 
       
 13829 2007-07-10  Sam Weinig  <sam@webkit.org>
       
 13830 
       
 13831         Fix build for BuildBot.
       
 13832 
       
 13833         * page/DOMWindow.cpp:
       
 13834         (WebCore::DOMWindow::outerHeight):
       
 13835         (WebCore::DOMWindow::outerWidth):
       
 13836         (WebCore::DOMWindow::screenX):
       
 13837         (WebCore::DOMWindow::screenY):
       
 13838 
       
 13839 2007-07-10  Brady Eidson  <beidson@apple.com>
       
 13840 
       
 13841         Reviewed by Sam
       
 13842 
       
 13843         <rdar://problem/5326653> - REGRESSION: [WebBackForwardList forwardListCount] might return incorrect result
       
 13844 
       
 13845         No layout test because this is an API issue that can't be tested in DRT or the browser
       
 13846 
       
 13847         * history/BackForwardList.cpp:
       
 13848         (WebCore::BackForwardList::forwardListCount): If the index is NoCurrentItemIndex, return 0
       
 13849 
       
 13850 2007-07-10  Sam Weinig  <sam@webkit.org>
       
 13851 
       
 13852         Reviewed by Darin.
       
 13853 
       
 13854         Move more readonly attributes from pure JS bindings in KJS::Window
       
 13855         to the implementation in DOMWindow and autogenerate the new bindings.
       
 13856 
       
 13857         * bindings/js/kjs_window.cpp:
       
 13858         (KJS::Window::getValueProperty):  Sort the hashmap comment into categories
       
 13859         to make further migration easier.
       
 13860         * bindings/js/kjs_window.h: Sort the enum into categories to make further
       
 13861         migration easier.
       
 13862         (KJS::Window::):
       
 13863         * page/DOMWindow.cpp: Add new methods.
       
 13864         (WebCore::DOMWindow::focus):
       
 13865         (WebCore::DOMWindow::blur):
       
 13866         (WebCore::DOMWindow::offscreenBuffering):
       
 13867         (WebCore::DOMWindow::outerHeight):
       
 13868         (WebCore::DOMWindow::outerWidth):
       
 13869         (WebCore::DOMWindow::innerHeight):
       
 13870         (WebCore::DOMWindow::innerWidth):
       
 13871         (WebCore::DOMWindow::screenX):
       
 13872         (WebCore::DOMWindow::screenY):
       
 13873         (WebCore::DOMWindow::scrollX):
       
 13874         (WebCore::DOMWindow::scrollY):
       
 13875         (WebCore::DOMWindow::getComputedStyle):
       
 13876         (WebCore::DOMWindow::getMatchedCSSRules): Add null Document assertion.
       
 13877         (WebCore::DOMWindow::devicePixelRatio): Add null Frame and Page checks.
       
 13878         * page/DOMWindow.h:
       
 13879         (WebCore::DOMWindow::screenLeft):
       
 13880         (WebCore::DOMWindow::screenTop):
       
 13881         (WebCore::DOMWindow::pageXOffset):
       
 13882         (WebCore::DOMWindow::pageYOffset):
       
 13883         * page/DOMWindow.idl:
       
 13884 
       
 13885 2007-07-10  Oliver Hunt  <oliver@apple.com>
       
 13886 
       
 13887         Reviewed by Maciej.
       
 13888 
       
 13889         Fix for <rdar://problem/5326417> Editor::unmarkText needs to be crossplatform
       
 13890 
       
 13891         Missed this in earlier patch to make text marking platform independent.
       
 13892 
       
 13893         * editing/Editor.cpp:
       
 13894         (WebCore::Editor::unmarkText):
       
 13895            Add platform independent impl
       
 13896         * editing/mac/EditorMac.mm:
       
 13897            Remove the old mac path.
       
 13898 
       
 13899 2007-07-10  Geoffrey Garen  <ggaren@apple.com>
       
 13900 
       
 13901         Reviewed by Tim Hatcher.
       
 13902 
       
 13903         Added a Page counter. This helped me while investigating 
       
 13904         <rdar://problem/5314463> 40MB of WebKit memory still allocated after 
       
 13905         closing large email in Mail
       
 13906 
       
 13907         * WebCore.xcodeproj/project.pbxproj:
       
 13908         * page/Page.cpp:
       
 13909         (WebCore::):
       
 13910         (WebCore::PageCounter::~PageCounter):
       
 13911         (WebCore::Page::Page):
       
 13912         (WebCore::Page::~Page):
       
 13913 
       
 13914 2007-07-10  Timothy Hatcher  <timothy@apple.com>
       
 13915 
       
 13916         Reviewed by Geoff.
       
 13917 
       
 13918         <rdar://problem/5326126> InspectorResource holds onto more data than it needs
       
 13919 
       
 13920         Reduces the fixed size of InspectorResource from 630 bytes to 224 bytes. Now
       
 13921         selectively pick out parts of the ResourceRequest and ResourceResponse objects
       
 13922         for the info needed and store that directly in InspectorResource.
       
 13923 
       
 13924         The ResourceRequest and ResourceResponse objects hold a reference to the original
       
 13925         NSURL object, so almost double the data was being kept around. So the struct size
       
 13926         reduction is just the tip of the ice burg on what this really saves.
       
 13927 
       
 13928         In a test of 100,000 XMLHTTPRequests using a 85 byte long data URL, I see ~21 MB less
       
 13929         RSIZE compared to Safari running without this change.
       
 13930 
       
 13931         * page/InspectorController.cpp:
       
 13932         (WebCore::InspectorResource::InspectorResource):
       
 13933         (WebCore::InspectorResource::type):
       
 13934         (WebCore::addSourceToFrame):
       
 13935         (WebCore::scriptObjectForRequest):
       
 13936         (WebCore::scriptObjectForResponse):
       
 13937         (WebCore::InspectorController::addScriptResource):
       
 13938         (WebCore::InspectorController::addAndUpdateScriptResource):
       
 13939         (WebCore::updateResourceRequest):
       
 13940         (WebCore::updateResourceResponse):
       
 13941         (WebCore::InspectorController::updateScriptResourceRequest):
       
 13942         (WebCore::InspectorController::updateScriptResourceResponse):
       
 13943         (WebCore::InspectorController::didLoadResourceFromMemoryCache):
       
 13944         (WebCore::InspectorController::identifierForInitialRequest):
       
 13945         (WebCore::InspectorController::willSendRequest):
       
 13946         (WebCore::InspectorController::didReceiveResponse):
       
 13947         (WebCore::InspectorController::didFailLoading):
       
 13948         * page/InspectorController.h:
       
 13949 
       
 13950 2007-07-10  Darin Adler  <darin@apple.com>
       
 13951 
       
 13952         Reviewed by Brady.
       
 13953 
       
 13954         - fix crash introduced by my patch for 5318732, only seen in release builds
       
 13955 
       
 13956         * page/Page.cpp: (WebCore::Page::~Page): Added a missing null check.
       
 13957 
       
 13958 2007-07-10  Andrea Cavalli  <amc82@cam.ac.uk>
       
 13959 
       
 13960         Reviewed by George Staikos.
       
 13961 
       
 13962         Fixed render theme for text field.
       
 13963 
       
 13964         * platform/qt/RenderThemeQt.cpp:
       
 13965         (WebCore::RenderThemeQt::paintTextField):
       
 13966 
       
 13967 2007-07-10  Qing Zhao  <qing@staikos.net>
       
 13968 
       
 13969         Reviewed by George Staikos.
       
 13970 
       
 13971         Draw focus rings for nodes that are not rendered by QStyle.
       
 13972 
       
 13973         * platform/graphics/qt/GraphicsContextQt.cpp:
       
 13974         (WebCore::focusRingColor):
       
 13975         (WebCore::GraphicsContext::drawFocusRing):
       
 13976         * platform/qt/RenderThemeQt.cpp:
       
 13977         (WebCore::RenderThemeQt::supportsFocusRing):
       
 13978         (WebCore::RenderThemeQt::supportsFocus):
       
 13979 
       
 13980 2007-07-10  Nikolas Zimmermann  <zimmermann@kde.org>
       
 13981 
       
 13982         Reviewed by Geoff.
       
 13983 
       
 13984         Fix 'unsigned int' overflow in CodeGeneratorJS.pm.
       
 13985         This fixes hashing of "SVG_FEBLEND_MODE_NORMAL". Its hashvalue exceeded 2^32, which
       
 13986         is no problem in perl but in the cpp code. Emulate C/C++ behaviour by using "% 2^32" in
       
 13987         the perl code. Testcase available in feature-branch soon (js-svg-constructors.svg).
       
 13988 
       
 13989         * bindings/scripts/CodeGeneratorJS.pm:
       
 13990 
       
 13991 2007-07-10  Geoffrey Garen  <ggaren@apple.com>
       
 13992 
       
 13993         Reviewed by Maciej Stachowiak.
       
 13994 
       
 13995         Disabled Arena recycling in RenderArena. PLT shows no regression 
       
 13996         (possibly a small speedup), and this can reduce allocated memory in 
       
 13997         WebKit clients by about 120K (4K per Arena * 30 Arenas).
       
 13998         
       
 13999         I happened upon this optimization while investigating 
       
 14000         <rdar://problem/5314463> WebKit hangs on to 40MB RAM after closing 
       
 14001         large email in Mail (appears to be render tree arena allocator), 
       
 14002         although I don't think it will come close to fixing that bug 
       
 14003         completely.
       
 14004 
       
 14005         * rendering/RenderArena.cpp:
       
 14006         (WebCore::RenderArena::~RenderArena): Use FinishArenaPool, which frees
       
 14007         the ArenaPool's Arenas immediately.
       
 14008 
       
 14009 2007-07-10  Mitz Pettel  <mitz@webkit.org>
       
 14010 
       
 14011         Reviewed by Hyatt.
       
 14012 
       
 14013         - fix http://bugs.webkit.org/show_bug.cgi?id=14449
       
 14014           REGRESSION (r14345-r14375): Absolutely positioned image does not scale to containing element's height
       
 14015 
       
 14016         Test: fast/replaced/absolute-position-percentage-height.html
       
 14017 
       
 14018         * rendering/RenderBox.cpp:
       
 14019         (WebCore::RenderBox::calcReplacedHeightUsing): For positioned elements, evaluate
       
 14020         the percentage with respect to the container's final height.
       
 14021 
       
 14022 2007-07-10  Brady Eidson  <beidson@apple.com>
       
 14023 
       
 14024         Reviewed by Mark Rowe
       
 14025 
       
 14026         Add 64-bit integer converters to our string classes for future work
       
 14027 
       
 14028         * platform/DeprecatedString.cpp:
       
 14029         (WebCore::DeprecatedString::toInt64):
       
 14030         (WebCore::DeprecatedString::toUInt64):
       
 14031         * platform/DeprecatedString.h:
       
 14032 
       
 14033         * platform/PlatformString.h:
       
 14034         * platform/String.cpp:
       
 14035         (WebCore::String::toInt64):
       
 14036         (WebCore::String::toUInt64):
       
 14037 
       
 14038         * platform/StringImpl.cpp:
       
 14039         (WebCore::StringImpl::toInt64):
       
 14040         (WebCore::StringImpl::toUInt64):
       
 14041         * platform/StringImpl.h:
       
 14042 
       
 14043 2007-07-10  Darin Adler  <darin@apple.com>
       
 14044 
       
 14045         Reviewed by Anders.
       
 14046 
       
 14047         - fix <rdar://problem/5318732> REGRESSION: In Mail, a crash occurs when attempting to send
       
 14048           a HTML based message (nytimes.com, washingtonpost.com, latimes.com)
       
 14049 
       
 14050         Did an audit of calls to get the inspector and most other uses of Page* and added null
       
 14051         checks since Frame* can outlast its Page*.
       
 14052 
       
 14053         * loader/FrameLoader.cpp:
       
 14054         (WebCore::FrameLoader::createWindow): Added null check.
       
 14055         (WebCore::FrameLoader::loadSubframe): Ditto.
       
 14056         (WebCore::FrameLoader::load): Ditto.
       
 14057         (WebCore::FrameLoader::transitionToCommitted): Ditto.
       
 14058         (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto.
       
 14059         (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Ditto.
       
 14060         (WebCore::FrameLoader::addExtraFieldsToRequest): Ditto.
       
 14061         (WebCore::FrameLoader::loadResourceSynchronously): Ditto.
       
 14062         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto.
       
 14063         (WebCore::FrameLoader::requestFromDelegate): Ditto.
       
 14064         (WebCore::FrameLoader::canGoBackOrForward): Ditto.
       
 14065         (WebCore::FrameLoader::getHistoryLength): Ditto.
       
 14066         (WebCore::FrameLoader::historyURL): Ditto.
       
 14067         (WebCore::FrameLoader::cachePageForHistoryItem): Ditto.
       
 14068         (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Ditto.
       
 14069         (WebCore::FrameLoader::goToItem): Ditto.
       
 14070         (WebCore::FrameLoader::dispatchWindowObjectAvailable): Ditto.
       
 14071         (WebCore::FrameLoader::dispatchDidCommitLoad): Ditto.
       
 14072         (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest): Ditto.
       
 14073         (WebCore::FrameLoader::dispatchWillSendRequest): Ditto.
       
 14074         (WebCore::FrameLoader::dispatchDidReceiveResponse): Ditto.
       
 14075         (WebCore::FrameLoader::dispatchDidReceiveContentLength): Ditto.
       
 14076         (WebCore::FrameLoader::dispatchDidFinishLoading): Ditto.
       
 14077         (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache): Ditto.
       
 14078 
       
 14079         * page/ContextMenuController.h:
       
 14080         * page/ContextMenuController.cpp:
       
 14081         (WebCore::ContextMenuController::ContextMenuController): Removed unneeded and
       
 14082         unused Page* parameter.
       
 14083         (WebCore::openNewWindow): Added null check.
       
 14084         (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
       
 14085 
       
 14086         * page/InspectorController.h:
       
 14087         (WebCore::InspectorController::pageDestroyed): Added. Since this object is
       
 14088         owned by the Page and has a back-pointer to it, it needs an explicit disconnect.
       
 14089         There's already a higher-level one, but this is more reliable than that.
       
 14090         * page/InspectorController.cpp:
       
 14091         (WebCore::InspectorController::windowScriptObjectAvailable): Added null check.
       
 14092         (WebCore::InspectorController::windowUnloading): Ditto.
       
 14093 
       
 14094         * page/Page.cpp:
       
 14095         (WebCore::Page::Page): Updated for change in parameters of ContextMenuController 
       
 14096         constructor.
       
 14097         (WebCore::Page::~Page): Added call to InspectorController pageDestroyed().
       
 14098 
       
 14099         * page/Chrome.cpp: Updated includes.
       
 14100         * page/DragController.cpp: Ditto.
       
 14101 
       
 14102 2007-07-10  Adam Treat  <adam@staikos.net>
       
 14103 
       
 14104         Reviewed by George Staikos.
       
 14105 
       
 14106         Bring scroll wheel out of Ludicrous Speed.
       
 14107 
       
 14108         * platform/qt/WheelEventQt.cpp:
       
 14109         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
       
 14110 
       
 14111 2007-07-09  Geoffrey Garen  <ggaren@apple.com>
       
 14112 
       
 14113         Reviewed by Maciej Stachowiak.
       
 14114 
       
 14115         Fixed http://bugs.webkit.org/show_bug.cgi?id=13241 | <rdar://problem/5126396>
       
 14116         onload fires before content is finished loading (woot.com)
       
 14117         
       
 14118         * dom/Document.cpp:
       
 14119         (WebCore::Document::close): Try to go through the normal "Am I done loading?"
       
 14120         machinery before dispatching the load event. As the comment indicates, 
       
 14121         we can't do this in all cases, so the fix isn't perfect. However, a perfect 
       
 14122         solution would require much riskier sweeping changes to the loader, which 
       
 14123         are best left for later, I think.
       
 14124 
       
 14125         * xml/XSLTProcessor.cpp:
       
 14126         (WebCore::XSLTProcessor::createDocumentFromSource): Removed a slightly
       
 14127         worse solution to the same problem.
       
 14128 
       
 14129 2007-07-10  Rob Buis  <buis@kde.org>
       
 14130 
       
 14131         Reviewed by Maciej.
       
 14132 
       
 14133         http://bugs.webkit.org/show_bug.cgi?id=8007
       
 14134         createElement() and XHTML (A dynamically created table not rendered as such)
       
 14135 
       
 14136         Follow the HTML5 rules of making the name lowercase and then
       
 14137         creating the element in the xhtml namespace.
       
 14138 
       
 14139         * dom/Document.cpp:
       
 14140         (WebCore::Document::createElement):
       
 14141         * dom/Document.h:
       
 14142         * html/HTMLDocument.cpp:
       
 14143         * html/HTMLDocument.h:
       
 14144 
       
 14145 2007-07-09  Qing Zhao  <qing@staikos.net>
       
 14146 
       
 14147         Reviewed by George Staikos.
       
 14148 
       
 14149         Add qt context menu support.
       
 14150 
       
 14151         * WebCore.pro:
       
 14152         * platform/ContextMenu.h:
       
 14153         * platform/ContextMenuItem.h:
       
 14154         (WebCore::PlatformMenuItemDescriptionType::PlatformMenuItemDescriptionType):
       
 14155         * platform/qt/ContextMenuItemQt.cpp:
       
 14156         (WebCore::ContextMenuItem::ContextMenuItem):
       
 14157         (WebCore::ContextMenuItem::~ContextMenuItem):
       
 14158         (WebCore::ContextMenuItem::releasePlatformDescription):
       
 14159         (WebCore::ContextMenuItem::type):
       
 14160         (WebCore::ContextMenuItem::setType):
       
 14161         (WebCore::ContextMenuItem::action):
       
 14162         (WebCore::ContextMenuItem::setAction):
       
 14163         (WebCore::ContextMenuItem::title):
       
 14164         (WebCore::ContextMenuItem::setTitle):
       
 14165         (WebCore::ContextMenuItem::platformSubMenu):
       
 14166         (WebCore::ContextMenuItem::setSubMenu):
       
 14167         (WebCore::ContextMenuItem::setChecked):
       
 14168         (WebCore::ContextMenuItem::setEnabled):
       
 14169         (WebCore::ContextMenuItem::enabled):
       
 14170         * platform/qt/ContextMenuQt.cpp:
       
 14171         (WebCore::ContextMenu::ContextMenu):
       
 14172         (WebCore::ContextMenu::~ContextMenu):
       
 14173         (WebCore::ContextMenu::appendItem):
       
 14174         (WebCore::ContextMenu::itemCount):
       
 14175         (WebCore::ContextMenu::insertItem):
       
 14176         (WebCore::ContextMenu::setPlatformDescription):
       
 14177         (WebCore::ContextMenu::platformDescription):
       
 14178 
       
 14179 2007-07-09  Anders Carlsson  <andersca@apple.com>
       
 14180 
       
 14181         Build fix.
       
 14182         
       
 14183         * plugins/win/PluginViewWin.cpp:
       
 14184         (WebCore::PluginViewWin::performRequest):
       
 14185 
       
 14186 2007-07-09  Anders Carlsson  <andersca@apple.com>
       
 14187 
       
 14188         Reviewed by Geoff.
       
 14189 
       
 14190         Get rid of the node argument in our various script execution functions.
       
 14191         
       
 14192         * bindings/js/kjs_proxy.cpp:
       
 14193         (WebCore::KJSProxy::evaluate):
       
 14194         * bindings/js/kjs_proxy.h:
       
 14195         * bindings/js/kjs_window.cpp:
       
 14196         (KJS::ScheduledAction::execute):
       
 14197         * dom/XMLTokenizer.cpp:
       
 14198         (WebCore::XMLTokenizer::endElementNs):
       
 14199         (WebCore::XMLTokenizer::notifyFinished):
       
 14200         * html/HTMLScriptElement.cpp:
       
 14201         (WebCore::HTMLScriptElement::evaluateScript):
       
 14202         * html/HTMLTokenizer.cpp:
       
 14203         (WebCore::HTMLTokenizer::scriptExecution):
       
 14204         * loader/FrameLoader.cpp:
       
 14205         (WebCore::FrameLoader::changeLocation):
       
 14206         (WebCore::FrameLoader::urlSelected):
       
 14207         (WebCore::FrameLoader::submitForm):
       
 14208         (WebCore::FrameLoader::replaceContentsWithScriptResult):
       
 14209         (WebCore::FrameLoader::executeScript):
       
 14210         * loader/FrameLoader.h:
       
 14211         * page/mac/WebCoreFrameBridge.mm:
       
 14212         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
       
 14213         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
       
 14214 
       
 14215 2007-07-09  Justin Garcia  <justin.garcia@apple.com>
       
 14216 
       
 14217         Rolling the fix for 5290534 back in now that 5310404 has been fixed in Mail.
       
 14218 
       
 14219         * editing/DeleteSelectionCommand.cpp:
       
 14220         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
       
 14221 
       
 14222 2007-07-09  Geoffrey Garen  <ggaren@apple.com>
       
 14223 
       
 14224         Reviewed by Anders Carlsson.
       
 14225 
       
 14226         A little more FrameLoader cleanup while working on <rdar://problem/5126396>.
       
 14227         
       
 14228         Rename: "checkEmitLoadEvent" => "checkCallImplicitClose" because the function
       
 14229         doesn't emit the load event; it just calls implicitClose.
       
 14230         
       
 14231         Rename: "m_wasLoadEventEmitted" => "m_didCallImplicitClose" because the variable
       
 14232         tracks whether implicitClose was called.
       
 14233 
       
 14234         * dom/Document.cpp:
       
 14235         (WebCore::Document::implicitClose): Turned 12 lines of code into 6, adding ASSERT.
       
 14236         * loader/FrameLoader.h: Removed bogus declaration of non-existent emitLoadEvent().
       
 14237 
       
 14238 2007-07-09  Justin Garcia  <justin.garcia@apple.com>
       
 14239 
       
 14240         Reviewed by John.
       
 14241         
       
 14242         REGRESSION: Crash when deleting table content in Leopard Mail
       
 14243 
       
 14244         * editing/DeleteSelectionCommand.cpp:
       
 14245         (WebCore::DeleteSelectionCommand::handleGeneralDelete): Use a RefPtr
       
 14246         for the next node to delete, in case it is destroyed when the
       
 14247         current node is deleted.  In the crash reported in the radar, we
       
 14248         crash because the next node is the div that holds the delete button
       
 14249         and it's destroyed when the node that contains the selection is removed.
       
 14250 
       
 14251 2007-07-09  Adam Treat  <adam@staikos.net>
       
 14252 
       
 14253         Reviewed by George Staikos.
       
 14254 
       
 14255         Convert QWebFrame from a QFrame to a pure QObject to eliminate all
       
 14256         traces of widgets.
       
 14257 
       
 14258         * page/qt/EventHandlerQt.cpp:
       
 14259         (WebCore::EventHandler::passSubframeEventToSubframe):
       
 14260         * platform/ScrollView.h:
       
 14261         * platform/Widget.h:
       
 14262         * platform/qt/PlatformScrollBarQt.cpp:
       
 14263         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
       
 14264         (WebCore::PlatformScrollbar::handleMousePressEvent):
       
 14265         (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
       
 14266         * platform/qt/PopupMenuQt.cpp:
       
 14267         (WebCore::PopupMenu::show):
       
 14268         * platform/qt/ScrollViewQt.cpp:
       
 14269         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
       
 14270         (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
       
 14271         (WebCore::ScrollView::ScrollViewPrivate::windowClipRect):
       
 14272         (WebCore::ScrollView::updateContents):
       
 14273         (WebCore::ScrollView::update):
       
 14274         (WebCore::ScrollView::geometryChanged):
       
 14275         (WebCore::ScrollView::windowToContents):
       
 14276         (WebCore::ScrollView::contentsToWindow):
       
 14277         (WebCore::ScrollView::convertChildToSelf):
       
 14278         (WebCore::ScrollView::convertSelfToChild):
       
 14279         (WebCore::ScrollView::scrollbarUnderMouse):
       
 14280         (WebCore::ScrollView::addChild):
       
 14281         (WebCore::ScrollView::paint):
       
 14282         * platform/qt/WidgetQt.cpp:
       
 14283         (WebCore::WidgetPrivate::WidgetPrivate):
       
 14284         (WebCore::WidgetPrivate::~WidgetPrivate):
       
 14285         (WebCore::WidgetPrivate::setGeometry):
       
 14286         (WebCore::WidgetPrivate::geometry):
       
 14287         (WebCore::Widget::frameGeometry):
       
 14288         (WebCore::Widget::setFocus):
       
 14289         (WebCore::Widget::setCursor):
       
 14290         (WebCore::Widget::show):
       
 14291         (WebCore::Widget::hide):
       
 14292         (WebCore::Widget::qwebframe):
       
 14293         (WebCore::Widget::setQWebFrame):
       
 14294         (WebCore::Widget::qwidget):
       
 14295         (WebCore::Widget::setQWidget):
       
 14296         (WebCore::Widget::setFrameGeometry):
       
 14297         (WebCore::Widget::isEnabled):
       
 14298         (WebCore::Widget::setEnabled):
       
 14299         (WebCore::Widget::setIsSelected):
       
 14300         (WebCore::Widget::invalidate):
       
 14301         (WebCore::Widget::invalidateRect):
       
 14302         (WebCore::Widget::removeFromParent):
       
 14303         (WebCore::Widget::geometryChanged):
       
 14304         (WebCore::Widget::convertToContainingWindow):
       
 14305         (WebCore::Widget::convertFromContainingWindow):
       
 14306         (WebCore::Widget::convertChildToSelf):
       
 14307         (WebCore::Widget::convertSelfToChild):
       
 14308         (WebCore::Widget::containingWindow):
       
 14309 
       
 14310 2007-07-09  Anders Carlsson  <andersca@apple.com>
       
 14311 
       
 14312         Reviewed by Oliver.
       
 14313 
       
 14314         Add DocumentLoader::isLoadingMainResource.
       
 14315 
       
 14316         * WebCore.exp:
       
 14317 
       
 14318 2007-07-09  John Sullivan  <sullivan@apple.com>
       
 14319 
       
 14320         Reviewed by Darin
       
 14321 
       
 14322         * WebCore.exp:
       
 14323         * WebCore.xcodeproj/project.pbxproj:
       
 14324         exported String::createCFString, needed for <rdar://problem/5320208>
       
 14325 
       
 14326 2007-07-09  Mitz Pettel  <mitz@webkit.org>
       
 14327 
       
 14328         Reviewed by Maciej.
       
 14329 
       
 14330         Test case for the bug below, which is http://bugs.webkit.org/show_bug.cgi?id=14207
       
 14331 
       
 14332         * manual-tests/flash-unload-tab.html: Added.
       
 14333 
       
 14334 2007-07-09  Maciej Stachowiak  <mjs@apple.com>
       
 14335 
       
 14336         Reviewed by Oliver.
       
 14337 
       
 14338         <rdar://problem/5295734> Repro crash closing tab/window @ maps.google.com in
       
 14339         WTF::HashSet<KJS::RuntimeObjectImp*, WTF::PtrHash<KJS::RuntimeObjectImp*>,
       
 14340         WTF::HashTraits<KJS::RuntimeObjectImp*> >::add + 11
       
 14341         
       
 14342         Automated test case is not possible. Did not bother with manual test this time.
       
 14343 
       
 14344         * bindings/js/kjs_dom.cpp:
       
 14345         (WebCore::getRuntimeObject): Check that runtime root isn't null, as well as instance;
       
 14346         this should cover the case where the plugin is already shut down and onunload time.
       
 14347 
       
 14348 2007-07-08  Maciej Stachowiak  <mjs@apple.com>
       
 14349 
       
 14350         Reviewed by Sam.
       
 14351 
       
 14352         - fixed <rdar://problem/5220706> REGRESSION (TOT): repro crash in -[WebView(WebViewInternal) _addObject:forIdentifier:] [14425]
       
 14353         http://bugs.webkit.org/show_bug.cgi?id=14425
       
 14354 
       
 14355         * bindings/js/kjs_window.cpp:
       
 14356         (KJS::createWindow): No longer take an immediate argument - always do immediate loads
       
 14357         on a newly created Window. Also, do a load of "" to make sure that the right info makes
       
 14358         it to the app.
       
 14359         (KJS::showModalDialog): Updated for above.
       
 14360         (KJS::WindowFunc::callAsFunction): Updated for above.
       
 14361         * dom/Document.cpp:
       
 14362         (WebCore::Document::shouldBeAllowedToLoadLocalResources): If our URL is about:blank,
       
 14363         we're allowed if our opener is (since the opener must have written the contents).
       
 14364         * loader/FrameLoader.cpp:
       
 14365         (WebCore::FrameLoader::changeLocation): Add a variant which takes a KURL, which it
       
 14366         expects to be pre-completed. This is to avoid completing "" to the opener URL.
       
 14367         (WebCore::FrameLoader::urlSelected): Allow loading empty URLs.
       
 14368         * loader/FrameLoader.h:
       
 14369         
       
 14370         Test case is manual only, since it takes particular app behavior to reproduce:
       
 14371         
       
 14372         * manual-tests/new-window-subresource-crash.html: Added.
       
 14373 
       
 14374 2007-07-08  Mitz Pettel  <mitz@webkit.org>
       
 14375 
       
 14376         Reviewed by Maciej.
       
 14377 
       
 14378         - fix leaks introduced in r24099
       
 14379 
       
 14380         * dom/Element.cpp:
       
 14381         (WebCore::Element::~Element): Do not delete the cached computed style here.
       
 14382         (WebCore::Element::detach): Delete the computed style here instead.
       
 14383         (WebCore::Element::computedStyle): Removed a redundant ref() which was
       
 14384         causing the leak. Changed to return 0 if the element is not attached,
       
 14385         because in that case there is currently no way to tell when to delete the computed
       
 14386         style.
       
 14387 
       
 14388 2007-07-08  Mitz Pettel  <mitz@webkit.org>
       
 14389 
       
 14390         Reviewed by Darin.
       
 14391 
       
 14392         - fix http://bugs.webkit.org/show_bug.cgi?id=12384
       
 14393           getComputedStyle with td.style.display='none' reports '' for all properties except display
       
 14394 
       
 14395         Test: fast/css/computed-style-without-renderer.html
       
 14396 
       
 14397         Implement rich computed style for elements that do not have a renderer.
       
 14398 
       
 14399         * css/CSSComputedStyleDeclaration.cpp:
       
 14400         (WebCore::getPositionOffsetValue): Changed to take a RenderStyle instead of
       
 14401         a RenderObject.
       
 14402         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed to
       
 14403         use the computed style returned by the node instead of going through the
       
 14404         renderer. Changed properties that compute by measuring the renderer to
       
 14405         fall back on returning the length from the RenderStyle if a renderer does
       
 14406         not exist.
       
 14407         (WebCore::CSSComputedStyleDeclaration::length): Changed to return the number
       
 14408         of properties we can compute even if the element has no renderer.
       
 14409         (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties): Changed
       
 14410         to use the computed style returned by the node instead of going through the
       
 14411         renderer.
       
 14412         * dom/Element.cpp:
       
 14413         (WebCore::ElementRareData::ElementRareData): Added a computed style member,
       
 14414         used to cache computed style for elements that do not have a renderer.
       
 14415         (WebCore::ElementRareData::resetComputedStyle): Added.
       
 14416         (WebCore::Element::~Element): Delete the cached computed style.
       
 14417         (WebCore::Element::recalcStyle): Added code to delete the cached computed
       
 14418         style when necessary.
       
 14419         (WebCore::Element::computedStyle): Added. Returns the style used in rendering
       
 14420         the element, if available. Otherwise uses the style selector to compute style
       
 14421         for the element.
       
 14422         * dom/Element.h:
       
 14423         * dom/Node.cpp:
       
 14424         (WebCore::Node::computedStyle): Added. This method returns either the style
       
 14425         used in rendering the node, or the style that would be used if the node
       
 14426         had a renderer.
       
 14427         * dom/Node.h:
       
 14428 
       
 14429 2007-07-08  Mitz Pettel  <mitz@webkit.org>
       
 14430 
       
 14431         Reviewed by Darin.
       
 14432 
       
 14433         - fix http://bugs.webkit.org/show_bug.cgi?id=14544
       
 14434           Scroll wheel events are ignored when the cursor is over an iframe's border
       
 14435 
       
 14436         * page/mac/EventHandlerMac.mm:
       
 14437         (WebCore::EventHandler::passWheelEventToWidget): Changed to return false if
       
 14438         the event coordinates are not inside the widget's NSView hierarchy.
       
 14439 
       
 14440 2007-07-08  Rob Buis  <buis@kde.org>
       
 14441 
       
 14442         Reviewed by Mitz.
       
 14443 
       
 14444         http://bugs.webkit.org/show_bug.cgi?id=10752
       
 14445         The inspector should not respond to Make Text Smaller/Bigger commands
       
 14446 
       
 14447         Use the -webkit-text-size-adjust property to ignore text sizing        
       
 14448         and do not take the zoom factor into account for line height when
       
 14449         -webkit-text-size-adjust is set to none.
       
 14450 
       
 14451         * css/cssstyleselector.cpp:
       
 14452         (WebCore::CSSStyleSelector::applyProperty):
       
 14453         * page/inspector/inspector.css:
       
 14454 
       
 14455 2007-07-08  Darin Adler  <darin@apple.com>
       
 14456 
       
 14457         Reviewed by Maciej.
       
 14458 
       
 14459         - fix <rdar://problem/5318994> Integer overflow in WebCore's Base64.cpp:base64Encode
       
 14460 
       
 14461         * platform/Base64.cpp:
       
 14462         (WebCore::base64Encode): Check against a maximum size.
       
 14463         (WebCore::base64Decode): Ditto.
       
 14464 
       
 14465 2007-07-08  Darin Adler  <darin@apple.com>
       
 14466 
       
 14467         Reviewed by Maciej.
       
 14468 
       
 14469         - fix <rdar://problem/5124665> WebCore secondary-thread assertion should use linked-on-or-after check instead of building on Tiger check
       
 14470 
       
 14471         * platform/ThreadCheck.h: Renamed _WebCoreThreadViolationCheck to reportThreadViolation
       
 14472         since it's in the WebCore namespace and also we shouldn't use leading underscores since
       
 14473         those are reserved for the compiler and standard library. Added a new function named
       
 14474         setDefaultThreadViolationBehavior and an enum for the parameter. Removed the
       
 14475         threadViolationIsException parameter from WebCoreReportThreadViolation since we use
       
 14476         a global variable for it now. Got rid of the unnecessary use of do while (0) in the
       
 14477         WebCoreThreadViolationCheck macro -- since it's only a single function call it's already
       
 14478         a statement and doesn't need to be turned into one with the do while (0) trick.
       
 14479 
       
 14480         * platform/mac/ThreadCheck.mm:
       
 14481         (WebCore::readThreadViolationBehaviorFromUserDefaults): Moved the code to read from
       
 14482         NSUserDefaults into this helper function. Changed it to use stringForKey instead of
       
 14483         objectForKey so we don't get a "method not found" if someone puts something other than
       
 14484         a string in there. Updated to use the new globals.
       
 14485         (WebCore::setDefaultThreadViolationBehavior): Added.
       
 14486         (WebCore::reportThreadViolation): Simplified, now that most of the work is in the
       
 14487         readThreadViolationBehaviorFromUserDefaults function.
       
 14488         (WebCoreReportThreadViolation): Changed to use a global variable instead of parameter
       
 14489         to determine how to report a violation. Added LogOnFirstThreadViolation, which will
       
 14490         log only once for each function that violates.
       
 14491 
       
 14492         * WebCore.exp: Updated for above changes.
       
 14493 
       
 14494 2007-07-08  Mitz Pettel  <mitz@webkit.org>
       
 14495 
       
 14496         Reviewed by Darin.
       
 14497 
       
 14498         - fix http://bugs.webkit.org/show_bug.cgi?id=14221
       
 14499           Repro crash (ASSERTION FAILED: oldText in RenderBlock::updateFirstLetter() during relayout of :before content with first-letter style)
       
 14500 
       
 14501         Test: fast/css-generated-content/before-with-first-letter.html
       
 14502 
       
 14503         * rendering/RenderContainer.cpp:
       
 14504         (WebCore::RenderContainer::updateBeforeAfterContentForContainer): If a child
       
 14505         of the existing 'before' container is not text, do not assume that it is an
       
 14506         image, since it can also be an inline wrapping a first-letter. In that case,
       
 14507         do not update its style (so in particular, keep it a FIRST_LETTER type style)
       
 14508         and leave it to updateFirstLetter() to take care of.
       
 14509 
       
 14510 2007-07-07  Sam Weinig  <sam@webkit.org>
       
 14511 
       
 14512         Reviewed by Oliver Hunt.
       
 14513 
       
 14514         Bailout early in Window::put() if attribute is readonly to avoid
       
 14515         extra calls to isSafeScript().
       
 14516 
       
 14517         * bindings/js/kjs_window.cpp:
       
 14518         (KJS::Window::put):
       
 14519 
       
 14520 2007-07-07  Darin Adler  <darin@apple.com>
       
 14521 
       
 14522         Reviewed by Oliver Hunt.
       
 14523 
       
 14524         - fix <rdar://problem/5292364> REGRESSION: ZX Spectrum 3.0 widget - graphic anomalies in widget window frame
       
 14525 
       
 14526         Updated Dashboard quirk so it affects fill, stroke, and clip, rather than just stroke.
       
 14527 
       
 14528         Test: fast/canvas/fill-stroke-clip-reset-path.html
       
 14529 
       
 14530         * html/CanvasRenderingContext2D.h: Added clearPathForDashboardBackwardCompatibilityMode.
       
 14531         * html/CanvasRenderingContext2D.cpp:
       
 14532         (WebCore::CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode): Added.
       
 14533         (WebCore::CanvasRenderingContext2D::fill): Call the new function.
       
 14534         (WebCore::CanvasRenderingContext2D::stroke): Replaced in-line code with a call to the new function.
       
 14535         (WebCore::CanvasRenderingContext2D::clip): Call the new function.
       
 14536 
       
 14537 2007-07-07  Rob Buis  <buis@kde.org>
       
 14538 
       
 14539         Reviewed and tweaked by Darin.
       
 14540 
       
 14541         http://bugs.webkit.org/show_bug.cgi?id=8994
       
 14542         Canvas doesn't reset on resize
       
 14543 
       
 14544         Also reset the rendering context when resetting the canvas.
       
 14545 
       
 14546         * html/HTMLCanvasElement.cpp:
       
 14547         (WebCore::HTMLCanvasElement::reset):
       
 14548         (WebCore::HTMLCanvasElement::drawingContext):
       
 14549 
       
 14550 2007-07-07  Alexey Proskuryakov  <ap@webkit.org>
       
 14551 
       
 14552         Reviewed by Maciej.
       
 14553 
       
 14554         http://bugs.webkit.org/show_bug.cgi?id=14525
       
 14555         Support exslt:node-set()
       
 14556 
       
 14557         Test: fast/xsl/exslt-node-set.xml
       
 14558 
       
 14559         * xml/XSLTExtensions.cpp: Added.
       
 14560         (WebCore::exsltNodeSetFunction): A copy of exslt:node-set() implementation
       
 14561         from libexslt 1.1.11 (shipped with Tiger).
       
 14562         (WebCore::registerXSLTExtensions): This function registers any WebCore-provided
       
 14563         extensions on a context. Currently, the only extension is exslt:node-set().
       
 14564         * xml/XSLTExtensions.h: Added.
       
 14565 
       
 14566         * xml/XSLTProcessor.cpp:
       
 14567         (WebCore::XSLTProcessor::transformToString):
       
 14568         Register extensions when creating a context.
       
 14569 
       
 14570         * WebCore.pro:
       
 14571         * WebCore.vcproj/WebCore.vcproj:
       
 14572         * WebCore.xcodeproj/project.pbxproj:
       
 14573         * WebCoreSources.bkl:
       
 14574         Add XSLTExtensions.{h,cpp} to projects.
       
 14575 
       
 14576 2007-07-06  Maciej Stachowiak  <mjs@apple.com>
       
 14577 
       
 14578         Reviewed by Oliver.
       
 14579 
       
 14580         - fixed <rdar://problem/5133420> ASSERT in WebDocumentLoaderMac::decreaseLoadCount() un-discarding Gmail message
       
 14581         
       
 14582         test case: fast/loader/early-load-cancel.html
       
 14583 
       
 14584         * loader/ResourceLoader.cpp:
       
 14585         (WebCore::ResourceLoader::didCancel): Don't send cancel-related client callbacks
       
 14586         if we never even sent willSendRequest because we were deferred.
       
 14587 
       
 14588 2007-07-06  Oliver Hunt  <oliver@apple.com>
       
 14589 
       
 14590         Reviewed by Maciej.
       
 14591 
       
 14592         Pulled a number of methods from WebKit and WebCoreFrameBridge into 
       
 14593         C++ objects.
       
 14594 
       
 14595         * WebCore.exp:
       
 14596         * WebCore.xcodeproj/project.pbxproj:
       
 14597         * editing/Editor.cpp:
       
 14598         (WebCore::Editor::replaceMarkedText):
       
 14599             From -[WebCoreFrameBridge replaceMarkedTextWithText:]
       
 14600         * editing/Editor.h:
       
 14601         * page/Frame.cpp:
       
 14602         (WebCore::Frame::setMarkedTextRange):
       
 14603             Pulled platform independent logic from Mac specific implementation
       
 14604         (WebCore::Frame::selectRangeInMarkedText):
       
 14605             Converted from -[WebHTMLView _selectRangeInMarkedText:]
       
 14606         * page/Frame.h:
       
 14607         * page/mac/FrameMac.mm:
       
 14608         (WebCore::Frame::setMarkedTextRange):
       
 14609             Now only does Mac specific logic when manipulating initial
       
 14610             NSAttributedString
       
 14611         * page/mac/WebCoreFrameBridge.h:
       
 14612         * page/mac/WebCoreFrameBridge.mm:
       
 14613             Removed -[WebCoreFrameBridge replaceMarkedTextWithText:]
       
 14614 
       
 14615 2007-07-06  Mitz Pettel  <mitz@webkit.org>
       
 14616 
       
 14617         Reviewed by Darin.
       
 14618 
       
 14619         - fix http://bugs.webkit.org/show_bug.cgi?id=14545
       
 14620           REGRESSION (r21854-r21869): Repro crash in RenderBlock::updateFirstLetter @ nola.com/rose/
       
 14621 
       
 14622         Test: fast/css/first-letter-capitalized.html
       
 14623 
       
 14624         * rendering/RenderBlock.cpp:
       
 14625         (WebCore::RenderBlock::updateFirstLetter): Moved the call to setFirstLetter
       
 14626         further down so that the first letter is not destroyed if a text transform
       
 14627         is applied to the remaining text fragment when it is add to the render tree.
       
 14628         * rendering/RenderText.cpp:
       
 14629         (WebCore::RenderText::previousCharacter): Factored out of setTextInternal.
       
 14630         (WebCore::RenderText::setTextInternal): Changed to call previousCharacter().
       
 14631         * rendering/RenderText.h:
       
 14632         * rendering/RenderTextFragment.cpp:
       
 14633         (WebCore::RenderTextFragment::previousCharacter): Override to return the
       
 14634         character in the original string before the start of the fragment. 
       
 14635         * rendering/RenderTextFragment.h:
       
 14636 
       
 14637 2007-07-06  Mitz Pettel  <mitz@webkit.org>
       
 14638 
       
 14639         Reviewed by Beth.
       
 14640 
       
 14641         - fix http://bugs.webkit.org/show_bug.cgi?id=14536
       
 14642           Unnecessary layout done when mousing down in text field
       
 14643 
       
 14644         No test possible because there is no change in functionality.
       
 14645 
       
 14646         * rendering/RenderTextControl.cpp:
       
 14647         (WebCore::RenderTextControl::setStyle): Reset the height and the width in
       
 14648         the old style to avoid getting a layout hint as a result of having mutated
       
 14649         the old style during layout.
       
 14650         (WebCore::RenderTextControl::layout): Update children's layout if an inner
       
 14651         block's dimensions should change. This need for layout was previously masked
       
 14652         by the bug.
       
 14653 
       
 14654 2007-07-06  Brady Eidson  <beidson@apple.com>
       
 14655 
       
 14656         Fix builds that use IconDatabaseNone.cpp - better, this time
       
 14657 
       
 14658         * loader/icon/IconDatabaseNone.cpp:
       
 14659         (WebCore::IconDatabase::isOpen):
       
 14660 
       
 14661 2007-07-06  Brady Eidson  <beidson@apple.com>
       
 14662 
       
 14663         Fix builds that use IconDatabaseNone.cpp
       
 14664 
       
 14665         * loader/icon/IconDatabaseNone.cpp:
       
 14666         (WebCore::IconDatabase::databasePath): 
       
 14667 
       
 14668 2007-07-06  John Sullivan  <sullivan@apple.com>
       
 14669 
       
 14670         Reviewed by Brady
       
 14671         
       
 14672         - WebCore part of fix for: 
       
 14673           <rdar://problem/5310739> Time Machine shouldn't back up WebKit's icon database files
       
 14674         
       
 14675         * loader/icon/IconDatabase.h:
       
 14676         * loader/icon/IconDatabase.cpp:
       
 14677         (WebCore::IconDatabase::isOpen): 
       
 14678         made this method const (necessary to make IconDatabase::databasePath const)
       
 14679         (WebCore::IconDatabase::databasePath): 
       
 14680         new method, returns SQLDatabase's path if open, otherwise empty string
       
 14681         
       
 14682         * loader/icon/SQLDatabase.cpp:
       
 14683         (WebCore::SQLDatabase::open):
       
 14684         don't append a null character to the m_path ivar. The appended null character was making the path()
       
 14685         method return a String with a trailing null, which is bad. However, there were no callers to the
       
 14686         path() method until now. Instead of appending a null character to the ivar, use charactersWithNullTermination()
       
 14687         instead of characters() when opening the database.
       
 14688         
       
 14689         * loader/icon/SQLDatabase.h:
       
 14690         (WebCore::SQLDatabase::isOpen):
       
 14691         made this method const (necessary to make IconDatabase::databasePath const)
       
 14692         (WebCore::SQLDatabase::path):
       
 14693         made this method const (not required for these changes, but seemed worth doing at the same time)
       
 14694 
       
 14695         * WebCore.exp:
       
 14696         added symbol for IconDatabase::databasePath
       
 14697 
       
 14698 2007-07-06  George Staikos  <staikos@kde.org>
       
 14699 
       
 14700         No real functional change - just move the localizations out and
       
 14701         stick some placeholder text in.
       
 14702 
       
 14703         * platform/qt/Localizations.cpp: Added.
       
 14704         (WebCore::submitButtonDefaultLabel):
       
 14705         (WebCore::inputElementAltText):
       
 14706         (WebCore::resetButtonDefaultLabel):
       
 14707         (WebCore::defaultLanguage):
       
 14708         (WebCore::searchableIndexIntroduction):
       
 14709         (WebCore::fileButtonChooseFileLabel):
       
 14710         (WebCore::fileButtonNoFileSelectedLabel):
       
 14711         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
       
 14712         (WebCore::contextMenuItemTagDownloadLinkToDisk):
       
 14713         (WebCore::contextMenuItemTagCopyLinkToClipboard):
       
 14714         (WebCore::contextMenuItemTagOpenImageInNewWindow):
       
 14715         (WebCore::contextMenuItemTagDownloadImageToDisk):
       
 14716         (WebCore::contextMenuItemTagCopyImageToClipboard):
       
 14717         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
       
 14718         (WebCore::contextMenuItemTagCopy):
       
 14719         (WebCore::contextMenuItemTagGoBack):
       
 14720         (WebCore::contextMenuItemTagGoForward):
       
 14721         (WebCore::contextMenuItemTagStop):
       
 14722         (WebCore::contextMenuItemTagReload):
       
 14723         (WebCore::contextMenuItemTagCut):
       
 14724         (WebCore::contextMenuItemTagPaste):
       
 14725         (WebCore::contextMenuItemTagNoGuessesFound):
       
 14726         (WebCore::contextMenuItemTagIgnoreSpelling):
       
 14727         (WebCore::contextMenuItemTagLearnSpelling):
       
 14728         (WebCore::contextMenuItemTagSearchWeb):
       
 14729         (WebCore::contextMenuItemTagLookUpInDictionary):
       
 14730         (WebCore::contextMenuItemTagOpenLink):
       
 14731         (WebCore::contextMenuItemTagIgnoreGrammar):
       
 14732         (WebCore::contextMenuItemTagSpellingMenu):
       
 14733         (WebCore::contextMenuItemTagShowSpellingPanel):
       
 14734         (WebCore::contextMenuItemTagCheckSpelling):
       
 14735         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
       
 14736         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
       
 14737         (WebCore::contextMenuItemTagFontMenu):
       
 14738         (WebCore::contextMenuItemTagBold):
       
 14739         (WebCore::contextMenuItemTagItalic):
       
 14740         (WebCore::contextMenuItemTagUnderline):
       
 14741         (WebCore::contextMenuItemTagOutline):
       
 14742         (WebCore::contextMenuItemTagWritingDirectionMenu):
       
 14743         (WebCore::contextMenuItemTagDefaultDirection):
       
 14744         (WebCore::contextMenuItemTagLeftToRight):
       
 14745         (WebCore::contextMenuItemTagRightToLeft):
       
 14746         (WebCore::contextMenuItemTagInspectElement):
       
 14747         (WebCore::searchMenuNoRecentSearchesText):
       
 14748         (WebCore::searchMenuRecentSearchesText):
       
 14749         (WebCore::searchMenuClearRecentSearchesText):
       
 14750         (WebCore::AXWebAreaText):
       
 14751         (WebCore::AXLinkText):
       
 14752         (WebCore::AXListMarkerText):
       
 14753         (WebCore::AXImageMapText):
       
 14754         (WebCore::AXHeadingText):
       
 14755         * platform/qt/TemporaryLinkStubs.cpp:
       
 14756 
       
 14757 2007-07-06  Geoffrey Garen  <ggaren@apple.com>
       
 14758 
       
 14759         Reviewed by Anders Carlsson.
       
 14760 
       
 14761         A little more FrameLoader cleanup while working on <rdar://problem/5126396>.
       
 14762         
       
 14763         Moved url() and URL() methods next to each other to highlight their subtlety.
       
 14764 
       
 14765         * loader/FrameLoader.cpp:
       
 14766         (WebCore::FrameLoader::url):
       
 14767         * loader/FrameLoader.h:
       
 14768 
       
 14769 2007-07-06  Geoffrey Garen  <ggaren@apple.com>
       
 14770 
       
 14771         Reviewed by Anders Carlsson.
       
 14772 
       
 14773         A little FrameLoader cleanup while working on <rdar://problem/5126396>.
       
 14774         
       
 14775         Renamed endIfNotLoading() to endIfNotLoadingMainResource() because "loading"
       
 14776         and "loadingMainResource" have distinct meanings and this function
       
 14777         honors the latter.
       
 14778 
       
 14779         (WebCore::FrameLoader::endIfNotLoadingMainResource): Protect after the
       
 14780         early return to avoid ref count churn.
       
 14781         * loader/FrameLoader.h:
       
 14782         (WebCore::FrameLoader::isLoadingMainResource): Inlined this function.
       
 14783 
       
 14784 2007-07-06  Adam Treat  <adam@staikos.net>
       
 14785 
       
 14786         Reviewed by George Staikos.
       
 14787 
       
 14788         Convert QWebFrame to a QFrame from a scroll area.
       
 14789 
       
 14790         * page/qt/EventHandlerQt.cpp:
       
 14791         (WebCore::EventHandler::passSubframeEventToSubframe):
       
 14792         (WebCore::EventHandler::passWheelEventToWidget):
       
 14793         (WebCore::EventHandler::createDraggingClipboard):
       
 14794         (WebCore::EventHandler::passMousePressEventToScrollbar):
       
 14795         * platform/ScrollView.h:
       
 14796         * platform/Widget.h:
       
 14797         * platform/qt/PlatformScrollBar.h:
       
 14798         * platform/qt/PlatformScrollBarQt.cpp:
       
 14799         (WebCore::PlatformScrollbar::setRect):
       
 14800         (WebCore::PlatformScrollbar::frameGeometry):
       
 14801         (WebCore::PlatformScrollbar::setFrameGeometry):
       
 14802         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
       
 14803         (WebCore::PlatformScrollbar::handleMousePressEvent):
       
 14804         (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
       
 14805         * platform/qt/ScrollViewQt.cpp:
       
 14806         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
       
 14807         (WebCore::ScrollView::ScrollViewPrivate::~ScrollViewPrivate):
       
 14808         (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
       
 14809         (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
       
 14810         (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
       
 14811         (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
       
 14812         (WebCore::ScrollView::ScrollViewPrivate::windowClipRect):
       
 14813         (WebCore::ScrollView::ScrollView):
       
 14814         (WebCore::ScrollView::~ScrollView):
       
 14815         (WebCore::ScrollView::setScrollArea):
       
 14816         (WebCore::ScrollView::horizontalScrollBar):
       
 14817         (WebCore::ScrollView::verticalScrollBar):
       
 14818         (WebCore::ScrollView::updateContents):
       
 14819         (WebCore::ScrollView::update):
       
 14820         (WebCore::ScrollView::visibleWidth):
       
 14821         (WebCore::ScrollView::visibleHeight):
       
 14822         (WebCore::ScrollView::visibleContentRect):
       
 14823         (WebCore::ScrollView::setContentsPos):
       
 14824         (WebCore::ScrollView::resizeContents):
       
 14825         (WebCore::ScrollView::setFrameGeometry):
       
 14826         (WebCore::ScrollView::geometryChanged):
       
 14827         (WebCore::ScrollView::contentsX):
       
 14828         (WebCore::ScrollView::contentsY):
       
 14829         (WebCore::ScrollView::contentsWidth):
       
 14830         (WebCore::ScrollView::contentsHeight):
       
 14831         (WebCore::ScrollView::windowToContents):
       
 14832         (WebCore::ScrollView::contentsToWindow):
       
 14833         (WebCore::ScrollView::scrollOffset):
       
 14834         (WebCore::ScrollView::maximumScroll):
       
 14835         (WebCore::ScrollView::scrollBy):
       
 14836         (WebCore::ScrollView::scrollRectIntoViewRecursively):
       
 14837         (WebCore::ScrollView::hScrollbarMode):
       
 14838         (WebCore::ScrollView::vScrollbarMode):
       
 14839         (WebCore::ScrollView::suppressScrollbars):
       
 14840         (WebCore::ScrollView::setHScrollbarMode):
       
 14841         (WebCore::ScrollView::setVScrollbarMode):
       
 14842         (WebCore::ScrollView::setScrollbarsMode):
       
 14843         (WebCore::ScrollView::setStaticBackground):
       
 14844         (WebCore::ScrollView::inWindow):
       
 14845         (WebCore::ScrollView::updateScrollbars):
       
 14846         (WebCore::ScrollView::scrollbarUnderMouse):
       
 14847         (WebCore::ScrollView::addChild):
       
 14848         (WebCore::ScrollView::removeChild):
       
 14849         (WebCore::ScrollView::paint):
       
 14850         (WebCore::ScrollView::wheelEvent):
       
 14851         (WebCore::ScrollView::scroll):
       
 14852         (WebCore::ScrollView::windowResizerRect):
       
 14853         (WebCore::ScrollView::resizerOverlapsContent):
       
 14854         (WebCore::ScrollView::adjustOverlappingScrollbarCount):
       
 14855         (WebCore::ScrollView::setParent):
       
 14856         (WebCore::ScrollView::addToDirtyRegion):
       
 14857         (WebCore::ScrollView::scrollBackingStore):
       
 14858         (WebCore::ScrollView::updateBackingStore):
       
 14859         * platform/qt/WidgetQt.cpp:
       
 14860         (WebCore::WidgetPrivate::canvas):
       
 14861         (WebCore::WidgetPrivate::setGeometry):
       
 14862         (WebCore::WidgetPrivate::geometry):
       
 14863         (WebCore::Widget::setQWidget):
       
 14864         (WebCore::Widget::paint):
       
 14865         (WebCore::Widget::originalGeometry):
       
 14866         (WebCore::Widget::geometryChanged):
       
 14867 
       
 14868 2007-07-06  Anders Carlsson  <andersca@apple.com>
       
 14869 
       
 14870         Reviewed by Mitz.
       
 14871 
       
 14872         <rdar://problem/5280532> 
       
 14873         REGRESSION: Can't access nested embed by document.name if object is not immediate parent
       
 14874         
       
 14875         Traverse up the tree looking for an object element.
       
 14876         
       
 14877         * html/HTMLEmbedElement.cpp:
       
 14878         (WebCore::HTMLEmbedElement::getInstance):
       
 14879 
       
 14880 2007-07-06  George Staikos  <staikos@kde.org>
       
 14881 
       
 14882         Qt build fix: Don't clobber qmake variables that are already set.
       
 14883 
       
 14884         * WebCore.pro:
       
 14885 
       
 14886 2007-07-05  Maciej Stachowiak  <mjs@apple.com>
       
 14887 
       
 14888         Reviewed by Antti.
       
 14889 
       
 14890         - <rdar://problem/5311093> JavaScriptCore fails to build with strict-aliasing warnings
       
 14891 
       
 14892         * platform/StringHash.h:
       
 14893         (WTF::): Adapt to newer way to do storage types.
       
 14894 
       
 14895 2007-07-06  Bernhard Rosenkraenzer  <bero@arklinux.org>
       
 14896 
       
 14897         Reviewed by Sam.
       
 14898 
       
 14899         Fix for http://bugs.webkit.org/show_bug.cgi?id=13985
       
 14900         Bug 13985: WebCore/rendering/RenderTable.cpp fails to compile with gcc 4.2.x
       
 14901 
       
 14902         * rendering/RenderTable.cpp:
       
 14903         (WebKit::RenderTable::calcBorderLeft)
       
 14904         (WebKit::RenderTable::calcBorderRight)
       
 14905 
       
 14906 2007-07-06  Maxime Britto  <mbritto@pleyo.com>
       
 14907 
       
 14908         Reviewed by Maciej.
       
 14909 
       
 14910         Fix http://bugs.webkit.org/show_bug.cgi?id=13038
       
 14911         Bug 13038: ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame
       
 14912 
       
 14913         Modify an ASSERT in goToItem related to going back/forward in history.  We don't need to check the frameset if the target is _blank.
       
 14914         The attached test case is a manual one since it relies on having pages opened in tabs in Safari.
       
 14915 
       
 14916         * manual-tests/goBack-blank-tab-page.html: Added.
       
 14917         * manual-tests/resources/before-go-back.html: Added.
       
 14918         * manual-tests/resources/will-go-back.html: Added.
       
 14919         * page/Page.cpp:
       
 14920         (WebCore::Page::goToItem):
       
 14921 
       
 14922 2007-07-06  Mitz Pettel  <mitz@webkit.org>
       
 14923 
       
 14924         Reviewed by Maciej.
       
 14925 
       
 14926         - fix http://bugs.webkit.org/show_bug.cgi?id=14400
       
 14927           Assertion failure (SHOULD NEVER BE REACHED) going back on YouTube
       
 14928 
       
 14929         Test: fast/forms/button-state-restore.html
       
 14930 
       
 14931         * dom/Document.h:
       
 14932         (WebCore::Document::isFormElementRegistered): Added.
       
 14933         * html/HTMLGenericFormElement.cpp:
       
 14934         (WebCore::HTMLGenericFormElement::closeRenderer): Restore saved form
       
 14935         element state only if the element is registered with the document to
       
 14936         have its state saved.
       
 14937 
       
 14938 2007-07-06  Mitz Pettel  <mitz@webkit.org>
       
 14939 
       
 14940         Reviewed by Maciej.
       
 14941 
       
 14942         - fix http://bugs.webkit.org/show_bug.cgi?id=14487
       
 14943           Incomplete repaint of background and border of boxes with -webkit-border-fit:lines
       
 14944 
       
 14945         Test: fast/repaint/border-fit-lines.html
       
 14946 
       
 14947         * rendering/RenderObject.cpp:
       
 14948         (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Do a full repaint if
       
 14949         -webkit-border-fit:lines was specified.
       
 14950 
       
 14951 2007-07-06  Tony Chang  <idealisms@gmail.com>
       
 14952 
       
 14953         Reviewed by Maciej.
       
 14954 
       
 14955         http://bugs.webkit.org/show_bug.cgi?id=14516
       
 14956         Bug 14516: crash loading multipart/x-mixed-replace data on windows safari
       
 14957 
       
 14958         NULL check m_resourceData to prevent a crash in Safari on Windows.
       
 14959 
       
 14960         * loader/ResourceLoader.cpp:
       
 14961         (WebCore::ResourceLoader::clearResourceData):
       
 14962 
       
 14963 2007-07-06  Jungshik Shin  <jungshik.shin@gmail.com>
       
 14964 
       
 14965         Reviewed by Alexey.
       
 14966 
       
 14967         - Add UTF-32 encoding support 
       
 14968           http://bugs.webkit.org/show_bug.cgi?id=13415
       
 14969 
       
 14970         Test:
       
 14971          - fast/encoding/utf-32-big-endian-bom.html
       
 14972          - fast/encoding/utf-32-big-endian-nobom.xml
       
 14973          - fast/encoding/utf-32-little-endian-bom.html
       
 14974          - fast/encoding/utf-32-little-endian-nobom.xml
       
 14975 
       
 14976         * loader/TextResourceDecoder.cpp:
       
 14977         (WebCore::TextResourceDecoder::checkForBOM):
       
 14978         (WebCore::TextResourceDecoder::checkForHeadCharset):
       
 14979         * platform/TextDecoder.cpp:
       
 14980         (WebCore::TextDecoder::checkForBOM):
       
 14981         * platform/TextDecoder.h:
       
 14982         * platform/TextEncoding.cpp:
       
 14983         (WebCore::UTF32BigEndianEncoding):
       
 14984         (WebCore::UTF32LittleEndianEncoding):
       
 14985         * platform/TextEncoding.h:
       
 14986 
       
 14987 2007-07-06  Holger Hans Peter Freyther  <zecke@selfish.org>
       
 14988 
       
 14989         Reviewed by Maciej.
       
 14990 
       
 14991         Start implementening RenderThemeGdk/Gtk using GtkStyle. The approach is
       
 14992         to allocate one native control for each widget type. And use margins, spacing,
       
 14993         style properties from the Widget. And for drawing use GtkStyle on the rect supplied.
       
 14994 
       
 14995         This should allow nice integration and be relative resource friendly. Mozilla is using
       
 14996         a similiar approach. They seem to share the GdkPixmap among several operations and this
       
 14997         will be an obvious candidate for improvements. Create a normally big enough GdkPixmap and
       
 14998         use that for drawing and then set clip regions for cairo to make sure to not go beyond the
       
 14999         width and height.
       
 15000 
       
 15001         The next steps will be to introduce states for the widgets, add more widgets, handle focus,
       
 15002         and various other style attributes, honor the size and margin and use that to propagate this
       
 15003         back to RenderStyle*.
       
 15004 
       
 15005         * platform/gdk/RenderThemeGdk.cpp:
       
 15006         (WebCore::RenderThemeGdk::RenderThemeGdk):
       
 15007         (WebCore::RenderThemeGdk::setCheckboxSize):
       
 15008         (WebCore::RenderThemeGdk::paintCheckbox):
       
 15009         (WebCore::RenderThemeGdk::setRadioSize):
       
 15010         (WebCore::RenderThemeGdk::paintRadio):
       
 15011         (WebCore::RenderThemeGdk::paintButton):
       
 15012         (WebCore::RenderThemeGdk::copyToContext):
       
 15013         (WebCore::RenderThemeGdk::gtkButton):
       
 15014         (WebCore::RenderThemeGdk::gtkCheckbox):
       
 15015         (WebCore::RenderThemeGdk::gtkRadioButton):
       
 15016         (WebCore::RenderThemeGdk::gtkWindowContainer):
       
 15017         * platform/gdk/RenderThemeGdk.h:
       
 15018 
       
 15019 2007-07-06  Rob Buis  <buis@kde.org>
       
 15020 
       
 15021         Reviewed by Adam.
       
 15022 
       
 15023         http://bugs.webkit.org/show_bug.cgi?id=14442
       
 15024         Adding a stop with value 1.0 to a gradient that has already been used has no effect
       
 15025 
       
 15026         Implement start and end stop handling differently so they are not
       
 15027         in the color stop array.
       
 15028 
       
 15029         * html/CanvasGradient.cpp:
       
 15030         (WebCore::compareStops):
       
 15031         (WebCore::CanvasGradient::getColor):
       
 15032         (WebCore::CanvasGradient::findStop):
       
 15033 
       
 15034 2007-07-06  Adam Roben  <aroben@apple.com>
       
 15035 
       
 15036         Fix <rdar://problem/5301994> Garbled text still showing on some sites
       
 15037 
       
 15038         Replace calls to GetGlyphIndices with wkGetGlyphs.
       
 15039 
       
 15040         Reviewed by Alice.
       
 15041 
       
 15042         * platform/win/GlyphPageTreeNodeWin.cpp:
       
 15043         (WebCore::GlyphPage::fill): Use wkGetGlyphs.
       
 15044         * platform/win/FontDataWin.cpp:
       
 15045         (WebCore::FontData::containsCharacters):
       
 15046 
       
 15047 2007-07-06  Matt Lilek  <pewtermoose@gmail.com>
       
 15048 
       
 15049         Not reviewed - Windows build fix.
       
 15050 
       
 15051         * bridge/win/FrameWin.cpp:
       
 15052         (WebCore::imageFromSelection):
       
 15053 
       
 15054 2007-07-06  George Staikos  <staikos@kde.org>
       
 15055 
       
 15056         Reviewed by Maciej.
       
 15057 
       
 15058         Switch USE(ICONDATABASE) to ENABLE(ICONDATABASE) and activate the
       
 15059         flag via the .pro file
       
 15060 
       
 15061         * WebCore.pro:
       
 15062         * loader/icon/IconDatabase.h:
       
 15063 
       
 15064 2007-07-05  John Sullivan  <sullivan@apple.com>
       
 15065 
       
 15066         Reviewed by Adam
       
 15067 
       
 15068         - WebCore part of fix for <rdar://problem/5315033>
       
 15069 
       
 15070         * rendering/RenderObject.h:
       
 15071         replaced PaintRestrictionSelectionOnlyWhiteText with PaintRestrictionSelectionOnlyBlackText
       
 15072         (WebCore::RenderObject::PaintInfo::PaintInfo):
       
 15073         replaced forceWhiteText with forceBlackText
       
 15074 
       
 15075         * rendering/RenderObject.cpp:
       
 15076         (WebCore::RenderObject::addLineBoxRects):
       
 15077         added a useSelectionHeight parameter, which defaults to false; this method is unimplemented
       
 15078         at this level so this has no effect.
       
 15079 
       
 15080         * rendering/RenderText.h:
       
 15081         * rendering/RenderText.cpp:
       
 15082         (WebCore::RenderText::addLineBoxRects):
       
 15083         added a useSelectionHeight parameter, which defaults to false. If true, use the vertical position
       
 15084         and height returned by selectionRect rather than replacing it with the more tight-fitting position
       
 15085         and height of the line box.
       
 15086 
       
 15087         * dom/Range.h:
       
 15088         * dom/Range.cpp:
       
 15089         (WebCore::Range::addLineBoxRects):
       
 15090         added a useSelectionHeight parameter, which defaults to false. Passes this along to RenderObject.        
       
 15091 
       
 15092         * page/Frame.h:
       
 15093         renamed parameter to selectionImage
       
 15094         * page/Frame.cpp:
       
 15095         (WebCore::Frame::selectionTextRects):
       
 15096         pass true for addLineBoxRects new useSelectionHeight parameter, so the rects returned by this new
       
 15097         method will match the height that the selection would be painted here
       
 15098         (WebCore::Frame::paint):
       
 15099         updated for white->black name changes
       
 15100         
       
 15101         * page/mac/FrameMac.mm:
       
 15102         (WebCore::Frame::selectionImage):
       
 15103         updated for white->black name changes
       
 15104         
       
 15105         * rendering/InlineFlowBox.cpp:
       
 15106         (WebCore::InlineFlowBox::paintTextDecorations):
       
 15107         updated for white->black name changes
       
 15108 
       
 15109         * rendering/RenderLayer.cpp:
       
 15110         (WebCore::RenderLayer::paintLayer):
       
 15111         updated for white->black name changes
       
 15112 
       
 15113         * rendering/InlineTextBox.cpp:
       
 15114         (WebCore::InlineTextBox::paint):
       
 15115         updated for white->black name changes, and actually use black instead of white. This was the goal
       
 15116         of all the name changes.
       
 15117 
       
 15118 2007-07-05  Anders Carlsson  <andersca@apple.com>
       
 15119 
       
 15120         Reviewed by Oliver.
       
 15121 
       
 15122         Fix layout test failures.
       
 15123         
       
 15124         * loader/FrameLoader.cpp:
       
 15125         (WebCore::FrameLoader::commitProvisionalLoad):
       
 15126         Don't make a representation if we're creating the initial document.
       
 15127 
       
 15128 2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>
       
 15129 
       
 15130         Fix Bug 14388: Input in text fields limited to 1024 characters
       
 15131         http://bugs.webkit.org/show_bug.cgi?id=14388
       
 15132 
       
 15133         Slightly modified by Adam Roben.
       
 15134 
       
 15135         Reviewed by Adele.
       
 15136 
       
 15137         Tests: fast/forms/input-implicit-length-limit.html
       
 15138                fast/forms/input-maxlength.html
       
 15139 
       
 15140         * html/HTMLInputElement.cpp: Bump limit to 524288.
       
 15141         (WebCore::HTMLInputElement::init):
       
 15142         (WebCore::HTMLInputElement::parseMappedAttribute):
       
 15143         * html/HTMLInputElement.h:
       
 15144 
       
 15145 2007-07-05  Anders Carlsson  <andersca@apple.com>
       
 15146 
       
 15147         Build fix.
       
 15148         
       
 15149         * loader/FrameLoader.cpp:
       
 15150         (WebCore::FrameLoader::init):
       
 15151 
       
 15152 2007-07-05  Sam Weinig  <sam@webkit.org>
       
 15153 
       
 15154         Reviewed by Geoff.
       
 15155 
       
 15156         Add focus, blur and close functions to DOMWindow implementation class
       
 15157         and move bindings from Window to JSDOMWindow.
       
 15158 
       
 15159         * bindings/js/JSDOMWindowCustom.cpp:
       
 15160         (WebCore::JSDOMWindow::customGetOwnPropertySlot):
       
 15161         * bindings/js/kjs_window.cpp:
       
 15162         (KJS::Window::getOwnPropertySlot):
       
 15163         (KJS::WindowFunc::callAsFunction):
       
 15164         * bindings/js/kjs_window.h:
       
 15165         (KJS::Window::):
       
 15166         * bindings/scripts/CodeGeneratorJS.pm: Move prototype function declaration from
       
 15167         the implementation to the header.
       
 15168         * page/DOMWindow.cpp:
       
 15169         (WebCore::DOMWindow::focus):
       
 15170         (WebCore::DOMWindow::blur):
       
 15171         (WebCore::DOMWindow::close):
       
 15172         * page/DOMWindow.h:
       
 15173         * page/DOMWindow.idl:
       
 15174 
       
 15175 2007-07-05  Justin Garcia  <justin.garcia@apple.com>
       
 15176 
       
 15177         Reviewed by Harrison.
       
 15178 
       
 15179         <rdar://problem/5279521> REGRESSION: In Mail, a crash occurs at WebCore::Range::startPosition() when attempting to apply alignment to selected image/text in message body
       
 15180 
       
 15181         * editing/TextIterator.cpp:
       
 15182         (WebCore::TextIterator::exitNode): Previously emitted content shouldn't have
       
 15183         to come from a text node in order to emit a '\n' as we exit block containers.
       
 15184 
       
 15185 2007-07-05  Anders Carlsson  <andersca@apple.com>
       
 15186 
       
 15187         Reviewed by Geoff.
       
 15188 
       
 15189         <rdar://problem/5315284> REGRESSION: Leopard Launch Time - plugins are being accessed at startup.
       
 15190 
       
 15191         Set a response that has a MIME type of "text/html" on the document loader so WebKit won't refresh the 
       
 15192         plugin database looking for a plug-in that can handle the document's MIME type (which will be null anyway).
       
 15193                  
       
 15194         * loader/FrameLoader.cpp:
       
 15195         (WebCore::FrameLoader::init):
       
 15196 
       
 15197 2007-07-05  Anders Carlsson  <andersca@apple.com>
       
 15198 
       
 15199         Reviewed by Oliver.
       
 15200 
       
 15201         <rdar://problem/5106788>
       
 15202         WebKit loads user style sheets too late as seen in Mail (breaks DataDetectors; Mail flashes wrong font)
       
 15203 
       
 15204         Let the document know when the user style sheet is loading so that it try not to display anything
       
 15205         until the user style sheet has finished loading.
       
 15206         
       
 15207         * page/Frame.cpp:
       
 15208         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
       
 15209         (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader):
       
 15210         (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
       
 15211         (WebCore::Frame::setUserStyleSheetLocation):
       
 15212 
       
 15213 2007-07-05  Sam Weinig  <sam@webkit.org>
       
 15214 
       
 15215         Reviewed by Darin.
       
 15216 
       
 15217         Move JSDOMWindow overriding getOwnPropertySlot logic from KJS::Window
       
 15218         up into JSDOMWindow.  No change in functionality so no testcase required. 
       
 15219 
       
 15220         * bindings/js/JSDOMWindowCustom.cpp:
       
 15221         (WebCore::JSDOMWindow::customGetOwnPropertySlot):
       
 15222         * bindings/js/kjs_window.cpp:
       
 15223         (KJS::Window::getOwnPropertySlot):
       
 15224         * bindings/js/kjs_window.h:
       
 15225 
       
 15226 2007-07-05  Mitz Pettel  <mitz@webkit.org>
       
 15227 
       
 15228         Reviewed and Landed by Sam.
       
 15229 
       
 15230         - fix bug 14465 for window.showModalDialog
       
 15231 
       
 15232         * bindings/js/kjs_window.cpp:
       
 15233         (KJS::parseModalDialogFeatures):
       
 15234         (KJS::showModalDialog):
       
 15235 
       
 15236 2007-07-05  Sam Weinig  <sam@webkit.org>
       
 15237 
       
 15238         Reviewed by Mitz.
       
 15239 
       
 15240         Patch for http://bugs.webkit.org/show_bug.cgi?id=14465
       
 15241         window.open() uses the literal "undefined" as the URL
       
 15242 
       
 15243         * bindings/js/kjs_window.cpp:
       
 15244         (KJS::WindowFunc::callAsFunction): add checks for undefined and null values when setting the url.
       
 15245         * manual-tests/open-url-undefined.html: Added.
       
 15246 
       
 15247 2007-07-05  Holger Hans Peter Freyther  <zecke@selfish.org>
       
 15248 
       
 15249         Reviewed by Rob Buis.
       
 15250 
       
 15251         Rework FontData and FontPlatformData for the Gdk work to make valgrind
       
 15252         happy.
       
 15253 
       
 15254         Move destroying of FontConfig and Cairo objects held in FontPlatformData
       
 15255         to FontData::platformDestroy. The ownership of these objects is held by
       
 15256         FontData. This is following the Mac and Qt port at least.
       
 15257 
       
 15258         Currently it is possible that FontPlatformData will not create cairo resources
       
 15259         in this case at least make sure the variables are initialized to 0.
       
 15260         Initialize x,y of the cairo_glyph_t with zero to avoid extents.x_advance depending
       
 15261         on subtracing with not defined values.
       
 15262 
       
 15263         FontPlatformData::hash. Using FontDescription is a bad idea as we don't have a clue
       
 15264         about how it is packed, if holes are present, etc. The FcPattern and the m_fontMatrix
       
 15265         should be good enough to describe the Font. All other objects are created using these
       
 15266         variables
       
 15267 
       
 15268         Replace C-style casts with C++ casts, in this case reinterpret_cast.
       
 15269 
       
 15270         * platform/gdk/FontDataGdk.cpp:
       
 15271         (WebCore::FontData::platformInit): Don't assert
       
 15272         (WebCore::FontData::platformDestroy): Take over ownership
       
 15273         (WebCore::FontData::platformWidthForGlyph): initialize
       
 15274         (WebCore::FontData::setFont): be paranoid and assert
       
 15275         * platform/gdk/FontPlatformData.h:
       
 15276         (WebCore::FontPlatformData::FontPlatformData): Initialize everything
       
 15277         (WebCore::FontPlatformData::hash): make valgrind happy and don't use m_fontDescription
       
 15278         * platform/gdk/FontPlatformDataGdk.cpp:
       
 15279         (WebCore::FontPlatformData::FontPlatformData):
       
 15280         (WebCore::FontPlatformData::~FontPlatformData): FontData::platformDestroy will do this
       
 15281         (WebCore::FontPlatformData::list): Don't use C-style casts.
       
 15282         (WebCore::FontPlatformData::setFont): m_fontFace, m_fontMatrix, m_options might not be initialized
       
 15283         (WebCore::FontPlatformData::operator==): Don't use C-style casts.
       
 15284 
       
 15285 2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>
       
 15286 
       
 15287         Reviewed by Mark Rowe.
       
 15288 
       
 15289         http://bugs.webkit.org/show_bug.cgi?id=14445
       
 15290         GraphicsContextCairo code style cleanup
       
 15291 
       
 15292         Follow the cr naming convention for cairo_t*.
       
 15293         Remove trailing whitespace.
       
 15294         Replace C casts with C++ casts.
       
 15295         Avoid needless casts.
       
 15296 
       
 15297         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
 15298         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
       
 15299         (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
       
 15300         (WebCore::GraphicsContext::GraphicsContext):
       
 15301         (WebCore::GraphicsContext::platformContext):
       
 15302         (WebCore::GraphicsContext::savePlatformState):
       
 15303         (WebCore::GraphicsContext::restorePlatformState):
       
 15304         (WebCore::GraphicsContext::drawRect):
       
 15305         (WebCore::adjustLineToPixelBoundaries):
       
 15306         (WebCore::GraphicsContext::drawLine):
       
 15307         (WebCore::GraphicsContext::drawEllipse):
       
 15308         (WebCore::GraphicsContext::strokeArc): Save/restore the graphics state.
       
 15309         (WebCore::GraphicsContext::drawConvexPolygon):
       
 15310         (WebCore::GraphicsContext::fillRect):
       
 15311         (WebCore::GraphicsContext::clip):
       
 15312         (WebCore::GraphicsContext::drawFocusRing):
       
 15313         (WebCore::GraphicsContext::roundToDevicePixels):
       
 15314         (WebCore::GraphicsContext::translate):
       
 15315         (WebCore::GraphicsContext::origin):
       
 15316         (WebCore::GraphicsContext::setPlatformStrokeThickness):
       
 15317         (WebCore::GraphicsContext::setPlatformStrokeStyle):
       
 15318         (WebCore::GraphicsContext::setPlatformFont):
       
 15319         (WebCore::GraphicsContext::concatCTM):
       
 15320         (WebCore::GraphicsContext::addInnerRoundedRectClip):
       
 15321         (WebCore::GraphicsContext::beginTransparencyLayer):
       
 15322         (WebCore::GraphicsContext::endTransparencyLayer):
       
 15323         (WebCore::GraphicsContext::clearRect):
       
 15324         (WebCore::GraphicsContext::setLineCap):
       
 15325         (WebCore::GraphicsContext::setLineJoin):
       
 15326         (WebCore::GraphicsContext::setMiterLimit):
       
 15327         (WebCore::GraphicsContext::setCompositeOperation):
       
 15328         (WebCore::GraphicsContext::beginPath):
       
 15329         (WebCore::GraphicsContext::addPath):
       
 15330         (WebCore::GraphicsContext::rotate):
       
 15331         (WebCore::GraphicsContext::scale):
       
 15332         * platform/graphics/cairo/ImageBufferCairo.cpp:
       
 15333         (WebCore::ImageBuffer::ImageBuffer):
       
 15334         * platform/graphics/cairo/ImageCairo.cpp: Avoid the confusing ctxt/context naming scheme.
       
 15335         (WebCore::BitmapImage::draw):
       
 15336         (WebCore::Image::drawPattern):
       
 15337 
       
 15338 2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>
       
 15339 
       
 15340         Reviewed by Mark Rowe.
       
 15341 
       
 15342         http://bugs.webkit.org/show_bug.cgi?id=14531
       
 15343         Cairo SVGImage::nativeImageForCurrentFrame() has no return
       
 15344 
       
 15345         Return the Cairo surface from the frame cache.
       
 15346 
       
 15347         Also add a fall-through else macro with notImplemented() so that future
       
 15348         ports do not make the same mistake.
       
 15349 
       
 15350         * platform/graphics/svg/SVGImage.cpp:
       
 15351         (WebCore::SVGImage::nativeImageForCurrentFrame):
       
 15352 
       
 15353 2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>
       
 15354 
       
 15355         Reviewed by Mark Rowe.
       
 15356 
       
 15357         http://bugs.webkit.org/show_bug.cgi?id=14513
       
 15358         Cairo animated GIF support is broken
       
 15359 
       
 15360         Implement ImageSource::frameIsCompleteAtIndex() to enable animated GIFs.
       
 15361 
       
 15362         * platform/graphics/cairo/ImageSourceCairo.cpp:
       
 15363         (WebCore::ImageSource::frameIsCompleteAtIndex):
       
 15364 
       
 15365 2007-07-04  Matt Perry  <mpComplete@gmail.com>
       
 15366 
       
 15367         Reviewed by Adam.
       
 15368 
       
 15369         Fix for http://bugs.webkit.org/show_bug.cgi?id=13400
       
 15370         Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location
       
 15371         <rdar://problem/5153025>
       
 15372 
       
 15373         Treat userGesture as always true for setLocation, forcing a back/forward
       
 15374         entry to be created.
       
 15375 
       
 15376         * bindings/js/JSHTMLDocumentCustom.cpp:
       
 15377         (WebCore::JSHTMLDocument::setLocation):
       
 15378 
       
 15379 2007-07-04  Adam Roben  <aroben@apple.com>
       
 15380 
       
 15381         Restore MouseEventWithHitTestResults::targetNode's old behavior
       
 15382 
       
 15383         Reviewed by Mark.
       
 15384 
       
 15385         Fixes fast/images/imagemap-case and fast/replace/image-map.
       
 15386 
       
 15387         * page/MouseEventWithHitTestResults.cpp:
       
 15388         (WebCore::MouseEventWithHitTestResults::targetNode): Use the inner
       
 15389         node, not the inner non-shared node.
       
 15390 
       
 15391 2007-07-04  Adam Roben  <aroben@apple.com>
       
 15392 
       
 15393         Mac, Qt, and Gdk build fixes.
       
 15394 
       
 15395         * page/EventHandler.h:
       
 15396         * page/gdk/EventHandlerGdk.cpp:
       
 15397         * page/mac/EventHandlerMac.mm:
       
 15398         (WebCore::EventHandler::passSubframeEventToSubframe):
       
 15399         * page/qt/EventHandlerQt.cpp:
       
 15400 
       
 15401 2007-07-04  Adam Roben  <aroben@apple.com>
       
 15402 
       
 15403         Fix the Qt/Gdk builds.
       
 15404 
       
 15405         * page/gdk/EventHandlerGdk.cpp:
       
 15406         * page/qt/EventHandlerQt.cpp:
       
 15407 
       
 15408 2007-07-04  Adam Roben  <aroben@apple.com>
       
 15409 
       
 15410         Move tooltip logic down into WebCore so that it can be shared cross-platform
       
 15411 
       
 15412         Reviewed by Sam.
       
 15413 
       
 15414         * page/Chrome.cpp:
       
 15415         (WebCore::Chrome::setToolTip): Added.
       
 15416         * page/Chrome.h:
       
 15417         * page/ChromeClient.h:
       
 15418         * page/EventHandler.cpp:
       
 15419         (WebCore::EventHandler::mouseMoved): Call Chrome::setToolTip.
       
 15420         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 15421 
       
 15422         Added stubs for Gdk:
       
 15423 
       
 15424         * platform/gdk/ChromeClientGdk.h:
       
 15425         * platform/gdk/TemporaryLinkStubs.cpp:
       
 15426         (ChromeClientGdk::setToolTip):
       
 15427 
       
 15428 2007-07-04  Adam Roben  <aroben@apple.com>
       
 15429 
       
 15430         Add Settings::showsURLsInToolTips
       
 15431 
       
 15432         Reviewed by Sam.
       
 15433 
       
 15434         * WebCore.exp:
       
 15435         * page/Settings.cpp:
       
 15436         (WebCore::Settings::Settings):
       
 15437         * page/Settings.h:
       
 15438 
       
 15439 2007-07-04  Adam Roben  <aroben@apple.com>
       
 15440 
       
 15441         Move logic for calling mouseDidMoveOverElement into WebCore
       
 15442 
       
 15443         Reviewed by Sam.
       
 15444 
       
 15445         * page/EventHandler.cpp:
       
 15446         (WebCore::EventHandler::mouseMoved): Added. Calls Chrome::mouseDidMoveOverElement.
       
 15447         (WebCore::EventHandler::handleMouseMoveEvent): Now takes an optional
       
 15448         HitTestResult* parameter which is used to communicate to the caller the
       
 15449         node the mouse is over.
       
 15450         * page/EventHandler.h:
       
 15451         * page/mac/EventHandlerMac.mm:
       
 15452         (WebCore::EventHandler::mouseMoved): Changed to call the overloaded
       
 15453         mouseMoved().
       
 15454         (WebCore::EventHandler::passMouseMoveEventToSubframe): Pass hoveredNode
       
 15455         through to the subframe so we can get the deepest node hovered, not
       
 15456         just the node's parent frame.
       
 15457         * page/win/EventHandlerWin.cpp:
       
 15458         (WebCore::EventHandler::passMouseMoveEventToSubframe): Ditto.
       
 15459 
       
 15460 2007-07-04  Adam Roben  <aroben@apple.com>
       
 15461 
       
 15462         Add Chrome::mouseDidMoveOverElement
       
 15463 
       
 15464         This does the work of calling up to the ChromeClient (which will call
       
 15465         the UI delegate).
       
 15466 
       
 15467         Reviewed by Sam.
       
 15468 
       
 15469         * page/Chrome.cpp:
       
 15470         (WebCore::Chrome::mouseDidMoveOverElement): Added.
       
 15471         * page/Chrome.h:
       
 15472         * page/ChromeClient.h:
       
 15473         * platform/graphics/svg/SVGImageEmptyClients.h: Updated for change to
       
 15474         ChromeClient.
       
 15475         * platform/gdk/ChromeClientGdk.h:
       
 15476         * platform/gdk/TemporaryLinkStubs.cpp:
       
 15477         (ChromeClientGdk::mouseDidMoveOverElement):
       
 15478 
       
 15479 2007-07-04  Adam Roben  <aroben@apple.com>
       
 15480 
       
 15481         Changed PlatformMouseEvent to store the modifier flags of the event
       
 15482 
       
 15483         Reviewed by Sam.
       
 15484 
       
 15485         * platform/PlatformMouseEvent.h:
       
 15486         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
       
 15487         * platform/mac/PlatformMouseEventMac.mm:
       
 15488         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
       
 15489         * platform/win/PlatformMouseEventWin.cpp:
       
 15490         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
       
 15491 
       
 15492 2007-07-04  Adam Roben  <aroben@apple.com>
       
 15493 
       
 15494         Add HitTestResult::setToNonShadowAncestor
       
 15495 
       
 15496         Reviewed by Sam.
       
 15497 
       
 15498         * page/EventHandler.cpp:
       
 15499         (WebCore::EventHandler::hitTestResultAtPoint): Moved logic into
       
 15500         HitTestResult::setToNonShadowAncestor.
       
 15501         * rendering/HitTestResult.cpp:
       
 15502         (WebCore::HitTestResult::setToNonShadowAncestor):
       
 15503         * rendering/HitTestResult.h:
       
 15504 
       
 15505 2007-07-04  Adam Roben  <aroben@apple.com>
       
 15506 
       
 15507         Change MouseEventWithHitTestResults to hold onto a HitTestResult
       
 15508 
       
 15509         Reviewed by Sam.
       
 15510 
       
 15511         * dom/Document.cpp:
       
 15512         (WebCore::Document::prepareMouseEvent):
       
 15513         * page/MouseEventWithHitTestResults.cpp:
       
 15514         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
       
 15515         (WebCore::MouseEventWithHitTestResults::targetNode):
       
 15516         (WebCore::MouseEventWithHitTestResults::localPoint):
       
 15517         (WebCore::MouseEventWithHitTestResults::scrollbar):
       
 15518         * page/MouseEventWithHitTestResults.h:
       
 15519         (WebCore::MouseEventWithHitTestResults::event):
       
 15520         (WebCore::MouseEventWithHitTestResults::hitTestResult):
       
 15521 
       
 15522 2007-07-04  Matt Lilek  <pewtermoose@gmail.com>
       
 15523 
       
 15524         Not reviewed, gdk build fix.
       
 15525 
       
 15526         * platform/gdk/FrameGdk.cpp:
       
 15527 
       
 15528 2007-07-05  Antti Koivisto  <antti@apple.com>
       
 15529 
       
 15530         Reviewed by John.
       
 15531         
       
 15532         Fix Repro crash due to infinite recursion in HTMLParser::handleError @ youos.com
       
 15533         <rdar://problem/5237811>
       
 15534         
       
 15535         It is possible to add table parts (thead etc) without table ancestor to a document fragment. If a new table element
       
 15536         was added to such a part, as in
       
 15537         
       
 15538         div.innerHTML = '<tbody><table>';
       
 15539         
       
 15540         the parser error handling code would try to pop the previous table as normal. However since
       
 15541         the table does not actually exist nothing would happen and parser would go to infinite recursion.
       
 15542         
       
 15543         Solution here is to pop table parts one by one when handling the error inside a fragment instead of trying to pop
       
 15544         the table straight away (as it might not exist).
       
 15545 
       
 15546         * html/HTMLParser.cpp:
       
 15547         (WebCore::HTMLParser::handleError):
       
 15548 
       
 15549 2007-07-04  Qing Zhao  <qing@staikos.net>
       
 15550 
       
 15551         Reviewed by George Staikos.
       
 15552 
       
 15553         Draw menulist (comboboxes) without text overlap on the button.
       
 15554 
       
 15555         * platform/qt/RenderThemeQt.cpp:
       
 15556         (WebCore::RenderThemeQt::setPopupPadding):
       
 15557 
       
 15558 2007-07-04  George Staikos  <staikos@kde.org>
       
 15559 
       
 15560         Compile
       
 15561 
       
 15562         * page/qt/FrameQt.cpp:
       
 15563         * WebCore.pro:
       
 15564 
       
 15565 2007-07-04  Sam Weinig  <sam@webkit.org>
       
 15566 
       
 15567         Reviewed by Mitz.
       
 15568 
       
 15569         Patch for http://bugs.webkit.org/show_bug.cgi?id=14504
       
 15570         REGRESSION (r23573): Amazon Book Excerpt can not be viewed in recent nightly
       
 15571 
       
 15572         - Made it possible (again) to shadow window properties with local variable names.
       
 15573 
       
 15574         Test: fast/dom/Window/window-property-shadowing.html
       
 15575 
       
 15576         * bindings/js/JSDOMWindowCustom.cpp:
       
 15577         (WebCore::JSDOMWindow::customPut):
       
 15578         * bindings/js/kjs_window.cpp:
       
 15579         (KJS::Window::put):
       
 15580         * bindings/scripts/CodeGeneratorJS.pm:
       
 15581         * page/DOMWindow.idl:
       
 15582 
       
 15583 2007-07-03  Alice Liu  <alice.liu@apple.com>
       
 15584 
       
 15585         Reviewed by Adam.
       
 15586 
       
 15587         Fixed <rdar://problem/5225119> support smart pasting on Windows
       
 15588 
       
 15589         * WebCore.vcproj/WebCore.vcproj:
       
 15590         * WebCore.xcodeproj/project.pbxproj:
       
 15591             Added new files
       
 15592         * editing/SmartReplace.cpp: Added.
       
 15593         (WebCore::isCharacterSmartReplaceExempt):
       
 15594             Added non-CF implementation placeholder
       
 15595         * editing/SmartReplace.h: Added.
       
 15596         * editing/SmartReplaceCF.cpp: Added.
       
 15597         (WebCore::getSmartSet):
       
 15598         (WebCore::isCharacterSmartReplaceExempt):
       
 15599             Added new implementation
       
 15600 
       
 15601         * bridge/win/FrameWin.cpp:
       
 15602         * page/Frame.h:
       
 15603         * page/mac/FrameMac.mm:
       
 15604             Removed old declaration and implementation
       
 15605 
       
 15606         * editing/ReplaceSelectionCommand.cpp:
       
 15607         (WebCore::ReplaceSelectionCommand::doApply):
       
 15608             Changed to call the new function instead of old
       
 15609 
       
 15610         * page/mac/WebCoreFrameBridge.h:
       
 15611         * page/mac/WebCoreFrameBridge.mm:
       
 15612             Removed old declaration and implementation
       
 15613         (-[WebCoreFrameBridge smartInsertForString:replacingRange:beforeString:afterString:]):
       
 15614             Changed to call the new function instead of old
       
 15615 
       
 15616         * platform/win/PasteboardWin.cpp:
       
 15617         (WebCore::Pasteboard::Pasteboard):
       
 15618             Register new clipboard format
       
 15619         (WebCore::Pasteboard::writeSelection):
       
 15620             Set data for smartpaste format on clipboard
       
 15621         (WebCore::Pasteboard::canSmartReplace):
       
 15622             Added non-stub implementation
       
 15623 
       
 15624 2007-07-04  Qing Zhao  <qing@staikos.net>
       
 15625 
       
 15626         Reviewed by George Staikos.
       
 15627 
       
 15628         Similar to the PlatformScrollbar fixes, adjust the painter to make the
       
 15629         styler draw all subcontrols, and in this case the focus rect, in the
       
 15630         proper location
       
 15631 
       
 15632         * platform/qt/RenderThemeQt.cpp:
       
 15633         (WebCore::RenderThemeQt::paintMenuList):
       
 15634 
       
 15635 2007-07-04  Mitz Pettel  <mitz@webkit.org>
       
 15636 
       
 15637         Reviewed by Maciej.
       
 15638 
       
 15639         - fix http://bugs.webkit.org/show_bug.cgi?id=14495
       
 15640           REGRESSION: Wrong cursor is displayed during drag and drop when text is selected
       
 15641           <rdar://problem/5312384>
       
 15642 
       
 15643         No test possible because DumpRenderTree cannot query the current cursor.
       
 15644 
       
 15645         * page/EventHandler.cpp:
       
 15646         (WebCore::EventHandler::selectCursor): Changed into a member function and
       
 15647         added that if the last mouse down event could not have started a
       
 15648         selection, then the cursor should not change to an I-beam unconditionally.
       
 15649         (WebCore::EventHandler::handleMouseMoveEvent):
       
 15650         * page/EventHandler.h:
       
 15651 
       
 15652 2007-07-04  Holger Hans Peter Freyther  <zecke@selfish.org>
       
 15653 
       
 15654         Reviewed by Rob Buis.
       
 15655 
       
 15656         A little progress in tracking dependencies.
       
 15657 
       
 15658         * WebCore.pro: Add DEPENDPATH for the Gdk port.
       
 15659 
       
 15660 2007-07-03  Darin Adler  <darin@apple.com>
       
 15661 
       
 15662         Reviewed by Tim Hatcher.
       
 15663 
       
 15664         - fix <rdar://problem/5221297> Font family name in the cssText for a DOMCSSStyleDeclaration needs quotes
       
 15665 
       
 15666         Test: editing/style/font-family-with-space.html
       
 15667 
       
 15668         * css/FontFamilyValue.cpp:
       
 15669         (WebCore::isValidCSSIdentifier): Added. Implements the same rule that the CSS lexer does.
       
 15670         (WebCore::quoteStringIfNeeded): Changed to call isValidCSSIdentifier instead of just
       
 15671         checking for a leading "#" character.
       
 15672         * editing/markup.cpp:
       
 15673         (WebCore::escapeTextForMarkup): Changed to take a String parameter for better efficiency.
       
 15674         (WebCore::renderedText): Changed to return a String for better efficiency.
       
 15675         (WebCore::addNamespace): Updated to pass String to escapeTextForMarkup.
       
 15676         (WebCore::startMarkup): Updated to pass String to escapeTextForMarkup. Added missing call
       
 15677         to escapeTextForMarkup in the special case for the style property.
       
 15678         (WebCore::createMarkup): Changed from single quotes to double quotes and also added missing
       
 15679         call to escapeTextForMarkup in two special cases for the style property.
       
 15680 
       
 15681 2007-07-03  Sam Weinig  <sam@webkit.org>
       
 15682 
       
 15683         Reviewed by Darin.
       
 15684 
       
 15685         Twelfth round of fixes for implicit 64-32 bit conversion errors.
       
 15686         <rdar://problem/5292262>
       
 15687 
       
 15688         - Add casts and accompanying FIXMEs to avoid remaining compiler errors.
       
 15689 
       
 15690         * WebCore.xcodeproj/project.pbxproj:
       
 15691         * loader/FrameLoader.cpp:
       
 15692         (WebCore::FrameLoader::opened):
       
 15693         (WebCore::FrameLoader::sendRemainingDelegateMessages):
       
 15694         * loader/FrameLoader.h:
       
 15695         * loader/ResourceLoader.cpp:
       
 15696         (WebCore::ResourceLoader::didReceiveData):
       
 15697         * platform/network/mac/ResourceHandleMac.mm:
       
 15698         (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
       
 15699         (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
       
 15700         * platform/network/mac/ResourceResponseMac.mm:
       
 15701         (WebCore::ResourceResponse::nsURLResponse):
       
 15702 
       
 15703 2007-07-03  Anders Carlsson  <andersca@apple.com>
       
 15704 
       
 15705         Reviewed by Adam.
       
 15706 
       
 15707         <rdar://problem/5093862>
       
 15708         Nothing shown in plugin area when trying to play content using the DivX plugin
       
 15709         
       
 15710         Defer calling SetWindow for the DivX plugin, just like we do with the WMP plugin.
       
 15711                 
       
 15712         * plugins/win/PluginViewWin.cpp:
       
 15713         (WebCore::PluginViewWin::determineQuirks):
       
 15714 
       
 15715 2007-07-03  Sam Weinig  <sam@webkit.org>
       
 15716 
       
 15717         Reviewed by Brady Eidson.
       
 15718 
       
 15719         Ninth round of fixes for implicit 64-32 bit conversion errors.
       
 15720         <rdar://problem/5292262>
       
 15721 
       
 15722         - Fix function signature to use unsigned long instead of unsigned long long.
       
 15723 
       
 15724         * loader/ProgressTracker.cpp:
       
 15725         (WebCore::ProgressTracker::completeProgress):
       
 15726         * loader/ProgressTracker.h:
       
 15727 
       
 15728 2007-07-03  Sam Weinig  <sam@webkit.org>
       
 15729 
       
 15730         Reviewed by Oliver.
       
 15731 
       
 15732         Eighth round of fixes for implicit 64-32 bit conversion errors.
       
 15733         <rdar://problem/5292262>
       
 15734 
       
 15735         - Convert SVG implementation files to use floats instead of doubles
       
 15736           to match the spec/IDLs.
       
 15737 
       
 15738         * bindings/scripts/CodeGeneratorJS.pm:
       
 15739         * ksvg2/svg/SVGAngle.cpp:
       
 15740         * ksvg2/svg/SVGAnimatedTemplate.h:
       
 15741         * ksvg2/svg/SVGAnimationElement.cpp:
       
 15742         (WebCore::SVGAnimationElement::getEndTime):
       
 15743         (WebCore::SVGAnimationElement::getStartTime):
       
 15744         (WebCore::SVGAnimationElement::getCurrentTime):
       
 15745         (WebCore::SVGAnimationElement::getSimpleDuration):
       
 15746         * ksvg2/svg/SVGAnimationElement.h:
       
 15747         * ksvg2/svg/SVGFitToViewBox.cpp:
       
 15748         (WebCore::SVGFitToViewBox::parseViewBox):
       
 15749         * ksvg2/svg/SVGLength.cpp:
       
 15750         (WebCore::SVGLength::setValueAsString):
       
 15751         * ksvg2/svg/SVGLinearGradientElement.cpp:
       
 15752         (WebCore::SVGLinearGradientElement::buildGradient):
       
 15753         * ksvg2/svg/SVGMatrix.idl:
       
 15754         * ksvg2/svg/SVGNumber.idl:
       
 15755         * ksvg2/svg/SVGParserUtilities.cpp:
       
 15756         (WebCore::SVGPathParser::parseSVG):
       
 15757         (WebCore::SVGPathParser::calculateArc):
       
 15758         (WebCore::SVGPathParser::svgLineToHorizontal):
       
 15759         (WebCore::SVGPathParser::svgLineToVertical):
       
 15760         (WebCore::SVGPathParser::svgCurveToCubicSmooth):
       
 15761         (WebCore::SVGPathParser::svgCurveToQuadratic):
       
 15762         (WebCore::SVGPathParser::svgCurveToQuadraticSmooth):
       
 15763         (WebCore::SVGPathParser::svgArcTo):
       
 15764         * ksvg2/svg/SVGParserUtilities.h:
       
 15765         * ksvg2/svg/SVGPathElement.cpp:
       
 15766         (WebCore::SVGPathElement::SVGPathElement):
       
 15767         (WebCore::SVGPathElement::getTotalLength):
       
 15768         (WebCore::SVGPathElement::getPointAtLength):
       
 15769         (WebCore::SVGPathElement::getPathSegAtLength):
       
 15770         (WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
       
 15771         (WebCore::SVGPathElement::createSVGPathSegMovetoRel):
       
 15772         (WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
       
 15773         (WebCore::SVGPathElement::createSVGPathSegLinetoRel):
       
 15774         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
       
 15775         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
       
 15776         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
       
 15777         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
       
 15778         (WebCore::SVGPathElement::createSVGPathSegArcAbs):
       
 15779         (WebCore::SVGPathElement::createSVGPathSegArcRel):
       
 15780         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
       
 15781         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
       
 15782         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
       
 15783         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
       
 15784         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
       
 15785         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
       
 15786         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
       
 15787         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
       
 15788         (WebCore::SVGPathElement::svgMoveTo):
       
 15789         (WebCore::SVGPathElement::svgLineTo):
       
 15790         (WebCore::SVGPathElement::svgLineToHorizontal):
       
 15791         (WebCore::SVGPathElement::svgLineToVertical):
       
 15792         (WebCore::SVGPathElement::svgCurveToCubic):
       
 15793         (WebCore::SVGPathElement::svgCurveToCubicSmooth):
       
 15794         (WebCore::SVGPathElement::svgCurveToQuadratic):
       
 15795         (WebCore::SVGPathElement::svgCurveToQuadraticSmooth):
       
 15796         (WebCore::SVGPathElement::svgArcTo):
       
 15797         (WebCore::SVGPathElement::parseMappedAttribute):
       
 15798         * ksvg2/svg/SVGPathElement.h:
       
 15799         * ksvg2/svg/SVGPathSegArc.cpp:
       
 15800         (WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs):
       
 15801         (WebCore::SVGPathSegArcAbs::setX):
       
 15802         (WebCore::SVGPathSegArcAbs::x):
       
 15803         (WebCore::SVGPathSegArcAbs::setY):
       
 15804         (WebCore::SVGPathSegArcAbs::y):
       
 15805         (WebCore::SVGPathSegArcAbs::setR1):
       
 15806         (WebCore::SVGPathSegArcAbs::r1):
       
 15807         (WebCore::SVGPathSegArcAbs::setR2):
       
 15808         (WebCore::SVGPathSegArcAbs::r2):
       
 15809         (WebCore::SVGPathSegArcAbs::setAngle):
       
 15810         (WebCore::SVGPathSegArcAbs::angle):
       
 15811         (WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
       
 15812         (WebCore::SVGPathSegArcRel::setX):
       
 15813         (WebCore::SVGPathSegArcRel::x):
       
 15814         (WebCore::SVGPathSegArcRel::setY):
       
 15815         (WebCore::SVGPathSegArcRel::y):
       
 15816         (WebCore::SVGPathSegArcRel::setR1):
       
 15817         (WebCore::SVGPathSegArcRel::r1):
       
 15818         (WebCore::SVGPathSegArcRel::setR2):
       
 15819         (WebCore::SVGPathSegArcRel::r2):
       
 15820         (WebCore::SVGPathSegArcRel::setAngle):
       
 15821         (WebCore::SVGPathSegArcRel::angle):
       
 15822         * ksvg2/svg/SVGPathSegArc.h:
       
 15823         * ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
       
 15824         (WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs):
       
 15825         (WebCore::SVGPathSegCurvetoCubicAbs::setX):
       
 15826         (WebCore::SVGPathSegCurvetoCubicAbs::x):
       
 15827         (WebCore::SVGPathSegCurvetoCubicAbs::setY):
       
 15828         (WebCore::SVGPathSegCurvetoCubicAbs::y):
       
 15829         (WebCore::SVGPathSegCurvetoCubicAbs::setX1):
       
 15830         (WebCore::SVGPathSegCurvetoCubicAbs::x1):
       
 15831         (WebCore::SVGPathSegCurvetoCubicAbs::setY1):
       
 15832         (WebCore::SVGPathSegCurvetoCubicAbs::y1):
       
 15833         (WebCore::SVGPathSegCurvetoCubicAbs::setX2):
       
 15834         (WebCore::SVGPathSegCurvetoCubicAbs::x2):
       
 15835         (WebCore::SVGPathSegCurvetoCubicAbs::setY2):
       
 15836         (WebCore::SVGPathSegCurvetoCubicAbs::y2):
       
 15837         (WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
       
 15838         (WebCore::SVGPathSegCurvetoCubicRel::setX):
       
 15839         (WebCore::SVGPathSegCurvetoCubicRel::x):
       
 15840         (WebCore::SVGPathSegCurvetoCubicRel::setY):
       
 15841         (WebCore::SVGPathSegCurvetoCubicRel::y):
       
 15842         (WebCore::SVGPathSegCurvetoCubicRel::setX1):
       
 15843         (WebCore::SVGPathSegCurvetoCubicRel::x1):
       
 15844         (WebCore::SVGPathSegCurvetoCubicRel::setY1):
       
 15845         (WebCore::SVGPathSegCurvetoCubicRel::y1):
       
 15846         (WebCore::SVGPathSegCurvetoCubicRel::setX2):
       
 15847         (WebCore::SVGPathSegCurvetoCubicRel::x2):
       
 15848         (WebCore::SVGPathSegCurvetoCubicRel::setY2):
       
 15849         (WebCore::SVGPathSegCurvetoCubicRel::y2):
       
 15850         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
       
 15851         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
       
 15852         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs):
       
 15853         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX):
       
 15854         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x):
       
 15855         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY):
       
 15856         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y):
       
 15857         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX2):
       
 15858         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x2):
       
 15859         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY2):
       
 15860         (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y2):
       
 15861         (WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
       
 15862         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX):
       
 15863         (WebCore::SVGPathSegCurvetoCubicSmoothRel::x):
       
 15864         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY):
       
 15865         (WebCore::SVGPathSegCurvetoCubicSmoothRel::y):
       
 15866         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX2):
       
 15867         (WebCore::SVGPathSegCurvetoCubicSmoothRel::x2):
       
 15868         (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY2):
       
 15869         (WebCore::SVGPathSegCurvetoCubicSmoothRel::y2):
       
 15870         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
       
 15871         * ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
       
 15872         (WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs):
       
 15873         (WebCore::SVGPathSegCurvetoQuadraticAbs::setX):
       
 15874         (WebCore::SVGPathSegCurvetoQuadraticAbs::x):
       
 15875         (WebCore::SVGPathSegCurvetoQuadraticAbs::setY):
       
 15876         (WebCore::SVGPathSegCurvetoQuadraticAbs::y):
       
 15877         (WebCore::SVGPathSegCurvetoQuadraticAbs::setX1):
       
 15878         (WebCore::SVGPathSegCurvetoQuadraticAbs::x1):
       
 15879         (WebCore::SVGPathSegCurvetoQuadraticAbs::setY1):
       
 15880         (WebCore::SVGPathSegCurvetoQuadraticAbs::y1):
       
 15881         (WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
       
 15882         (WebCore::SVGPathSegCurvetoQuadraticRel::setX):
       
 15883         (WebCore::SVGPathSegCurvetoQuadraticRel::x):
       
 15884         (WebCore::SVGPathSegCurvetoQuadraticRel::setY):
       
 15885         (WebCore::SVGPathSegCurvetoQuadraticRel::y):
       
 15886         (WebCore::SVGPathSegCurvetoQuadraticRel::setX1):
       
 15887         (WebCore::SVGPathSegCurvetoQuadraticRel::x1):
       
 15888         (WebCore::SVGPathSegCurvetoQuadraticRel::setY1):
       
 15889         (WebCore::SVGPathSegCurvetoQuadraticRel::y1):
       
 15890         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
       
 15891         (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
       
 15892         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
       
 15893         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs):
       
 15894         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setX):
       
 15895         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::x):
       
 15896         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setY):
       
 15897         (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::y):
       
 15898         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
       
 15899         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setX):
       
 15900         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::x):
       
 15901         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setY):
       
 15902         (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::y):
       
 15903         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
       
 15904         * ksvg2/svg/SVGPathSegLineto.cpp:
       
 15905         (WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs):
       
 15906         (WebCore::SVGPathSegLinetoAbs::setX):
       
 15907         (WebCore::SVGPathSegLinetoAbs::x):
       
 15908         (WebCore::SVGPathSegLinetoAbs::setY):
       
 15909         (WebCore::SVGPathSegLinetoAbs::y):
       
 15910         (WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
       
 15911         (WebCore::SVGPathSegLinetoRel::setX):
       
 15912         (WebCore::SVGPathSegLinetoRel::x):
       
 15913         (WebCore::SVGPathSegLinetoRel::setY):
       
 15914         (WebCore::SVGPathSegLinetoRel::y):
       
 15915         * ksvg2/svg/SVGPathSegLineto.h:
       
 15916         * ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
       
 15917         (WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs):
       
 15918         (WebCore::SVGPathSegLinetoHorizontalAbs::setX):
       
 15919         (WebCore::SVGPathSegLinetoHorizontalAbs::x):
       
 15920         (WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
       
 15921         (WebCore::SVGPathSegLinetoHorizontalRel::setX):
       
 15922         (WebCore::SVGPathSegLinetoHorizontalRel::x):
       
 15923         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
       
 15924         * ksvg2/svg/SVGPathSegLinetoVertical.cpp:
       
 15925         (WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs):
       
 15926         (WebCore::SVGPathSegLinetoVerticalAbs::setY):
       
 15927         (WebCore::SVGPathSegLinetoVerticalAbs::y):
       
 15928         (WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
       
 15929         (WebCore::SVGPathSegLinetoVerticalRel::setY):
       
 15930         (WebCore::SVGPathSegLinetoVerticalRel::y):
       
 15931         * ksvg2/svg/SVGPathSegLinetoVertical.h:
       
 15932         * ksvg2/svg/SVGPathSegList.cpp:
       
 15933         (WebCore::SVGPathSegList::getPathSegAtLength):
       
 15934         * ksvg2/svg/SVGPathSegList.h:
       
 15935         * ksvg2/svg/SVGPathSegMoveto.cpp:
       
 15936         (WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs):
       
 15937         (WebCore::SVGPathSegMovetoAbs::setX):
       
 15938         (WebCore::SVGPathSegMovetoAbs::x):
       
 15939         (WebCore::SVGPathSegMovetoAbs::setY):
       
 15940         (WebCore::SVGPathSegMovetoAbs::y):
       
 15941         (WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
       
 15942         (WebCore::SVGPathSegMovetoRel::setX):
       
 15943         (WebCore::SVGPathSegMovetoRel::x):
       
 15944         (WebCore::SVGPathSegMovetoRel::setY):
       
 15945         (WebCore::SVGPathSegMovetoRel::y):
       
 15946         * ksvg2/svg/SVGPathSegMoveto.h:
       
 15947         * ksvg2/svg/SVGPolyElement.cpp:
       
 15948         (WebCore::SVGPolyElement::svgPolyTo):
       
 15949         * ksvg2/svg/SVGRadialGradientElement.cpp:
       
 15950         (WebCore::SVGRadialGradientElement::buildGradient):
       
 15951         * ksvg2/svg/SVGSVGElement.cpp:
       
 15952         (WebCore::SVGSVGElement::viewport):
       
 15953         (WebCore::SVGSVGElement::getCurrentTime):
       
 15954         * ksvg2/svg/SVGStopElement.cpp:
       
 15955         (WebCore::SVGStopElement::SVGStopElement):
       
 15956         (WebCore::SVGStopElement::parseMappedAttribute):
       
 15957         * ksvg2/svg/SVGStopElement.h:
       
 15958         * ksvg2/svg/SVGTransform.cpp:
       
 15959         (SVGTransform::translate):
       
 15960         (SVGTransform::scale):
       
 15961         * ksvg2/svg/SVGTransformDistance.cpp:
       
 15962         (WebCore::SVGTransformDistance::addToSVGTransform):
       
 15963         (WebCore::SVGTransformDistance::distance):
       
 15964         * ksvg2/svg/SVGTransformable.cpp:
       
 15965         (WebCore::SVGTransformable::parseTransformAttribute):
       
 15966 
       
 15967 2007-07-03  Anders Carlsson  <andersca@apple.com>
       
 15968 
       
 15969         Reviewed by Darin.
       
 15970 
       
 15971         <rdar://problem/5289718>
       
 15972         http://bugs.webkit.org/show_bug.cgi?id=14437
       
 15973         CrashTracer: [REGRESSION] 76 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 6 (14437)
       
 15974         
       
 15975         Based on a patch from Maxime Britto.
       
 15976         
       
 15977         * page/mac/WebCoreFrameBridge.mm:
       
 15978         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
       
 15979         If the script caused the frame to go away, return nil. This can only happen if a plugin in a subframe destroys
       
 15980         its frame.
       
 15981 
       
 15982         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
       
 15983         ASSERT that this is only called on the main frame.
       
 15984 
       
 15985 2007-07-03  John Sullivan  <sullivan@apple.com>
       
 15986 
       
 15987         Written by Darin, reviewed by me
       
 15988         
       
 15989         - fixed <rdar://problem/5249730> REGRESSION (Leopard, around 9A464): Safari opens the same local 
       
 15990           documents more than once due to canonicalization change
       
 15991 
       
 15992         * loader/mac/LoaderNSURLExtras.m:
       
 15993         (canonicalURL):
       
 15994         pass URL through KURL so we get KURL's version of canonicalization as well as
       
 15995         NSURLProtocol's version of canonicalization
       
 15996 
       
 15997 2007-07-03  Sam Weinig  <sam@webkit.org>
       
 15998 
       
 15999         Reviewed by Darin.
       
 16000 
       
 16001         Seventh round of fixes for implicit 64-32 bit conversion errors.
       
 16002         <rdar://problem/5292262>
       
 16003 
       
 16004         - Adds more narrowPrecision functions to FloatPoint, FloatSize and FloatRect.
       
 16005         - Changes over more implicit conversions to use new functions.
       
 16006 
       
 16007         * bindings/js/kjs_window.cpp:
       
 16008         (KJS::WindowFunc::callAsFunction):
       
 16009         * platform/graphics/FloatPoint.cpp:
       
 16010         (WebCore::FloatPoint::matrixTransform):
       
 16011         (WebCore::FloatPoint::narrowPrecision):
       
 16012         * platform/graphics/FloatPoint.h:
       
 16013         * platform/graphics/FloatRect.cpp:
       
 16014         (WebCore::FloatRect::narrowPrecision):
       
 16015         * platform/graphics/FloatRect.h:
       
 16016         * platform/graphics/FloatSize.cpp:
       
 16017         (WebCore::FloatSize::narrowPrecision):
       
 16018         * platform/graphics/FloatSize.h:
       
 16019         * platform/graphics/Path.cpp:
       
 16020         (WebCore::Path::createRoundedRectangle):
       
 16021         (WebCore::Path::createRectangle):
       
 16022         (WebCore::Path::createEllipse):
       
 16023         * platform/graphics/mac/ColorMac.mm:
       
 16024         (WebCore::nsColor):
       
 16025         * platform/graphics/mac/IconMac.mm:
       
 16026         (WebCore::Icon::paint):
       
 16027         * platform/graphics/svg/cg/CgSupport.cpp:
       
 16028         (WebCore::applyStrokeStyleToContext):
       
 16029         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
       
 16030         (WebCore::CGShadingRefForRadialGradient):
       
 16031         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
       
 16032         (WebCore::SVGPaintServerGradient::handleBoundingBoxModeAndGradientTransformation):
       
 16033         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
       
 16034         (WebCore::applyLuminanceToAlphaFilter):
       
 16035         (WebCore::applyExpandAlphatoGrayscaleFilter):
       
 16036         (WebCore::transformImageIntoGrayscaleMask):
       
 16037         * platform/mac/WebCoreTextRenderer.mm:
       
 16038         (WebCoreDrawTextAtPoint):
       
 16039         * rendering/RenderPath.cpp:
       
 16040         (WebCore::RenderPath::mapAbsolutePointToLocal):
       
 16041         * rendering/RenderSVGContainer.cpp:
       
 16042         (WebCore::RenderSVGContainer::calcViewport):
       
 16043         * rendering/RenderSVGImage.cpp:
       
 16044         (WebCore::RenderSVGImage::nodeAtPoint):
       
 16045         * rendering/RenderSVGText.cpp:
       
 16046         (WebCore::RenderSVGText::relativeBBox):
       
 16047 
       
 16048 2007-07-03  Anders Carlsson  <andersca@apple.com>
       
 16049 
       
 16050         Reviewed by Adam.
       
 16051 
       
 16052         <rdar://problem/5261523>
       
 16053         Crash playing MP11 on cnbc.com
       
 16054         
       
 16055         The WMP Netscape plugin still creates a window even when windowless mode is turned on. Work around this by
       
 16056         always removing the "windowlessvideo" parameter before passing it to the plugin.
       
 16057         According to http://msdn2.microsoft.com/en-us/library/bb249373.aspx, "The windowlessVideo property is not 
       
 16058         supported for Netscape Navigator. Setting a value for this property in Navigator may yield unexpected results."
       
 16059         
       
 16060         * plugins/win/PluginViewWin.cpp:
       
 16061         (WebCore::PluginViewWndProc):
       
 16062         (WebCore::PluginViewWin::paint):
       
 16063         (WebCore::PluginViewWin::invalidateRect):
       
 16064         (WebCore::PluginViewWin::determineQuirks):
       
 16065         (WebCore::PluginViewWin::setParameters):
       
 16066         (WebCore::PluginViewWin::PluginViewWin):
       
 16067         (WebCore::PluginViewWin::init):
       
 16068         * plugins/win/PluginViewWin.h:
       
 16069         (WebCore::):
       
 16070 
       
 16071 2007-07-03  Qing Zhao  <qing@staikos.net>
       
 16072 
       
 16073         Reviewed by George Staikos.
       
 16074 
       
 16075         Only draw sunken state for appropriate widgets. Not, for example, for
       
 16076         lineedits.
       
 16077 
       
 16078         * platform/qt/RenderThemeQt.cpp:
       
 16079         (WebCore::RenderThemeQt::applyTheme):
       
 16080 
       
 16081 2007-07-03  Antti Koivisto  <antti@apple.com>
       
 16082 
       
 16083         Reviewed by Maciej.
       
 16084         
       
 16085         REGRESSION: misplaced selection ring remains after link is no longer focused.
       
 16086         <rdar://problem/5205580>
       
 16087         
       
 16088         Fix placement of selection ring when part of the ring is in a different layer.
       
 16089 
       
 16090         * rendering/RenderFlow.cpp:
       
 16091         (WebCore::RenderFlow::addFocusRingRects): Get coordinates right when moving to a different layer.
       
 16092         * rendering/RenderObject.cpp:
       
 16093         (WebCore::RenderObject::setStyle): 
       
 16094         Don't reset state variables when not necessary.  When repaint() was called at the end of setSyle() it would
       
 16095         get repaint rects wrong in some cases.
       
 16096 
       
 16097 2007-07-03  Antti Koivisto  <antti@apple.com>
       
 16098 
       
 16099         Reviewed by Maciej.
       
 16100 
       
 16101         Blind fix for CrashTracer: [USER] 25 crashes in Safari at com.apple.WebCore: WebCore::Frame::document const + 6
       
 16102         <rdar://problem/5263939>
       
 16103         
       
 16104         No one has managed to reproduce this but it looks like null check is needed here. There are plausible ways
       
 16105         m_frame could be null for a live FrameView object.
       
 16106 
       
 16107         * page/FrameView.cpp:
       
 16108         (WebCore::FrameView::needsLayout):
       
 16109 
       
 16110 2007-07-02  Oliver Hunt  <oliver@apple.com>
       
 16111 
       
 16112         Reviewed by Darin.
       
 16113 
       
 16114         Fix for <rdar://problem/5098378> single-pixel image optimization needs to be rewritten to not depend on floating point bitmap
       
 16115         Tested by fast/replaced/image-solid-color-with-alpha.html
       
 16116 
       
 16117         Switch from float to byte based bitmap when pulling the color from 1x1 pixel images so
       
 16118         that we can use the single pixel image optimisation in WebKit/win.
       
 16119 
       
 16120         * platform/graphics/cg/ImageCG.cpp:
       
 16121         (WebCore::BitmapImage::checkForSolidColor):
       
 16122 
       
 16123 2007-07-02  Adam Roben  <aroben@apple.com>
       
 16124 
       
 16125         Fix Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error
       
 16126         http://bugs.webkit.org/show_bug.cgi?id=14498
       
 16127 
       
 16128         There were two bugs:
       
 16129         1) xPos/yPos were flipped
       
 16130         2) + binds tighter than ?:, so the order of operations was incorrect
       
 16131 
       
 16132         Reviewed by Darin.
       
 16133 
       
 16134         Test: fast/inline-block/14498-positionForCoordinates.html
       
 16135 
       
 16136         * rendering/RenderContainer.cpp:
       
 16137         (WebCore::RenderContainer::positionForCoordinates):
       
 16138 
       
 16139 2007-07-02  Darin Adler  <darin@apple.com>
       
 16140 
       
 16141         Reviewed by Kevin Decker and Tim Hatcher.
       
 16142 
       
 16143         - fix <rdar://problem/5307906> some classes need finalize methods because
       
 16144           of non-trivial work done in dealloc methods
       
 16145 
       
 16146         * bindings/objc/DOMRGBColor.mm:
       
 16147         (+[DOMRGBColor initialize]): Added. Tells finalizer to run on main thread,
       
 16148         which is needed because we are sharing a CFDictionary here with no locking.
       
 16149 
       
 16150         * bridge/mac/WebCoreAXObject.mm:
       
 16151         (+[WebCoreAXObject initialize]): Added. Tells finalizer to run on main thread.
       
 16152         (-[WebCoreAXObject finalize]): Added. Calls detach.
       
 16153 
       
 16154         * WebCore.xcodeproj/project.pbxproj: Let Xcode do what it wants to do.
       
 16155 
       
 16156 2007-07-02  Sam Weinig  <sam@webkit.org>
       
 16157 
       
 16158         Reviewed by Darin.
       
 16159 
       
 16160         Sixth round of fixes for implicit 64-32 bit conversion errors.
       
 16161         <rdar://problem/5292262>
       
 16162 
       
 16163         Use new narrowPrecisionToFloat() and narrowPrecisionToCGFloat() where
       
 16164         appropriate.
       
 16165 
       
 16166         * html/CanvasRenderingContext2D.cpp:
       
 16167         (WebCore::CanvasRenderingContext2D::setShadow):
       
 16168         (WebCore::CanvasRenderingContext2D::applyShadow):
       
 16169         * html/CanvasStyle.cpp:
       
 16170         (WebCore::CanvasStyle::applyStrokeColor):
       
 16171         (WebCore::CanvasStyle::applyFillColor):
       
 16172         * ksvg2/svg/SVGAngle.cpp:
       
 16173         * ksvg2/svg/SVGAnimationElement.cpp:
       
 16174         (WebCore::SVGAnimationElement::parseKeyNumbers):
       
 16175         (WebCore::parseKeySplines):
       
 16176         (WebCore::SVGAnimationElement::handleTimerEvent):
       
 16177         (WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds):
       
 16178         * ksvg2/svg/SVGPatternElement.cpp:
       
 16179         (WebCore::SVGPatternElement::buildPattern):
       
 16180         * ksvg2/svg/SVGRadialGradientElement.cpp:
       
 16181         (WebCore::SVGRadialGradientElement::buildGradient):
       
 16182         * platform/graphics/cg/AffineTransformCG.cpp:
       
 16183         (WebCore::AffineTransform::AffineTransform):
       
 16184         (WebCore::AffineTransform::setMatrix):
       
 16185         (WebCore::AffineTransform::map):
       
 16186         (WebCore::AffineTransform::setA):
       
 16187         (WebCore::AffineTransform::setB):
       
 16188         (WebCore::AffineTransform::setC):
       
 16189         (WebCore::AffineTransform::setD):
       
 16190         (WebCore::AffineTransform::setE):
       
 16191         (WebCore::AffineTransform::setF):
       
 16192         (WebCore::AffineTransform::scale):
       
 16193         (WebCore::AffineTransform::rotate):
       
 16194         (WebCore::AffineTransform::translate):
       
 16195         (WebCore::AffineTransform::shear):
       
 16196 
       
 16197 2007-07-02  John Sullivan  <sullivan@apple.com>
       
 16198 
       
 16199         * page/mac/WebCoreFrameBridge.mm:
       
 16200         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
       
 16201         added a comment
       
 16202 
       
 16203 2007-07-02  Sam Weinig  <sam@webkit.org>
       
 16204 
       
 16205         Rubberstamped by Darin.
       
 16206 
       
 16207         Rename FloatConversionUtilities.h to FloatConversion.h.
       
 16208         Fix Win32 build.
       
 16209 
       
 16210         * WebCore.vcproj/WebCore.vcproj:
       
 16211         * WebCore.xcodeproj/project.pbxproj:
       
 16212         * platform/DeprecatedString.cpp:
       
 16213         * platform/FloatConversion.h: Copied from platform/FloatConversionUtilities.h.
       
 16214         * platform/FloatConversionUtilities.h: Removed.
       
 16215         * platform/StringImpl.cpp:
       
 16216 
       
 16217 2007-07-02  Sam Weinig  <sam@webkit.org>
       
 16218 
       
 16219         Reviewed by Darin.
       
 16220 
       
 16221         Fifth round of fixes for implicit 64-32 bit conversion errors.
       
 16222         <rdar://problem/5292262>
       
 16223 
       
 16224         Add toFloat() method to string classes and use it where appropriate.
       
 16225 
       
 16226         * WebCore.xcodeproj/project.pbxproj:
       
 16227         * css/cssparser.cpp:
       
 16228         (WebCore::CSSParser::lex):
       
 16229         * ksvg2/svg/SVGAngle.cpp:
       
 16230         (WebCore::SVGAngle::setValueAsString):
       
 16231         * platform/AtomicString.h:
       
 16232         (WebCore::AtomicString::toFloat):
       
 16233         * platform/DeprecatedString.cpp:
       
 16234         (WebCore::DeprecatedString::toFloat):
       
 16235         * platform/DeprecatedString.h:
       
 16236         * platform/FloatConversionUtilities.h: Added.
       
 16237         (WebCore::narrowPrecisionToFloat):
       
 16238         (WebCore::narrowPrecisionToCGFloat):
       
 16239         * platform/PlatformString.h:
       
 16240         * platform/String.cpp:
       
 16241         (WebCore::String::toFloat):
       
 16242         * platform/StringImpl.cpp:
       
 16243         (WebCore::StringImpl::toFloat):
       
 16244         * platform/StringImpl.h:
       
 16245 
       
 16246 2007-07-02  Sam Weinig  <sam@webkit.org>
       
 16247 
       
 16248         Reviewed by Kevin McCullough.
       
 16249 
       
 16250         Fourth round of fixes for implicit 64-32 bit conversion errors.
       
 16251         <rdar://problem/5292262>
       
 16252 
       
 16253         Use new piDouble and piFloat constants instead of M_PI.
       
 16254 
       
 16255         * html/CanvasRenderingContext2D.cpp:
       
 16256         (WebCore::CanvasRenderingContext2D::rotate):
       
 16257         * ksvg2/svg/SVGParserUtilities.cpp:
       
 16258         (WebCore::SVGPathParser::calculateArc):
       
 16259         * platform/graphics/Path.cpp:
       
 16260         (WebCore::pathLengthApplierFunction):
       
 16261         (WebCore::Path::createEllipse):
       
 16262         * platform/graphics/cg/GraphicsContextCG.cpp:
       
 16263         (WebCore::GraphicsContext::drawEllipse):
       
 16264         (WebCore::GraphicsContext::strokeArc):
       
 16265         * platform/graphics/cg/PDFDocumentImage.cpp:
       
 16266         (WebCore::PDFDocumentImage::setCurrentPage):
       
 16267         * platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
       
 16268         * rendering/RenderPath.cpp:
       
 16269         (WebCore::drawMarkerWithData):
       
 16270 
       
 16271 2007-07-01  Adam Roben  <aroben@apple.com>
       
 16272 
       
 16273         Clarify/fix {Shadow,BorderImage}ParseContext's memory management
       
 16274 
       
 16275         Prefast emitted warnings that drew my attention to
       
 16276         {Shadow,BorderImage}ParseContext::failed().  It turned out that these
       
 16277         methods were actually correct, but rather confusing. "failed" really
       
 16278         meant "abort and clean up" rather than "did you fail?", which was
       
 16279         unclear. However, once I figured that out, the "and clean up" part was
       
 16280         still a bit confusing, because all failed() did was to set a flag that
       
 16281         would later cause the ParseContext's members to be deleted in the
       
 16282         destructor. To clear this up, I've gotten rid of the failed() method
       
 16283         altogether. It always returned false, so I've replaced all calls to
       
 16284         it with the value false.
       
 16285 
       
 16286         I also noticed that the lifetime management of the ParseContexts'
       
 16287         members was in all cases confusing, and in some cases wrong. The
       
 16288         m_border{Top,Right,Bottom,Left} members of BorderImageParseContext
       
 16289         were leaked whenever a border-image property was successfully parsed.
       
 16290         I fixed that by holding these members in OwnPtrs. The
       
 16291         CSSPrimitiveValue members of {Shadow,BorderImage}ParseContext, which
       
 16292         inherit from Shared, were being explicitly deleted, which is not a
       
 16293         safe way to manage the lifetime of objects that inherit from Shared.
       
 16294         To fix this, I put those members inside RefPtrs. These two changes
       
 16295         allowed me to remove the destructors entirely.
       
 16296 
       
 16297         Reviewed by Darin.
       
 16298 
       
 16299         All regression tests pass.
       
 16300 
       
 16301         * css/cssparser.cpp:
       
 16302         (WebCore::ShadowParseContext::commitValue): Use .release() to avoid
       
 16303         ref-count churn.
       
 16304         (WebCore::ShadowParseContext::commitLength): Use a RefPtr for the new
       
 16305         value to avoid a leak.
       
 16306         (WebCore::CSSParser::parseShadow): Use 'false' instead of
       
 16307         'context.failed()', and use .release() to avoid ref-count churn.
       
 16308         (WebCore::BorderImageParseContext::commitWidth): Updated to use
       
 16309         OwnPtr.
       
 16310         (WebCore::CSSParser::parseBorderImage): Use 'false' instead of
       
 16311         'context.failed'.
       
 16312 
       
 16313 2007-07-01  Anders Carlsson  <andersca@apple.com>
       
 16314 
       
 16315         Reviewed by John Sullivan.
       
 16316 
       
 16317         <rdar://problem/5297146>
       
 16318         Crash in Mail at WebCore::Frame::setUserStyleSheetLocation (reproducible w/ particular message)
       
 16319         
       
 16320         * loader/Cache.cpp:
       
 16321         (WebCore::Cache::requestResource):
       
 16322         Only insert the resource in the LRU list if the cache is enabled.
       
 16323         
       
 16324         (WebCore::Cache::insertInLRUList):
       
 16325         (WebCore::Cache::resourceAccessed):
       
 16326         Assert that the resource is in the cache.
       
 16327 
       
 16328 2007-07-01  Darin Adler  <darin@apple.com>
       
 16329 
       
 16330         * css/tokenizer.flex: Rolled out the fix for 14453.
       
 16331         The layout test wasn't passing. We'll try again.
       
 16332 
       
 16333 2007-07-01  Adam Roben  <aroben@apple.com>
       
 16334 
       
 16335         Fix a crash in ~PluginViewWin()
       
 16336 
       
 16337         This crash was introduced in r23827.
       
 16338 
       
 16339         Reviewed by Anders.
       
 16340 
       
 16341         Fixes dom/html/level2/html/HTMLAnchorElement01.html
       
 16342 
       
 16343         * plugins/win/PluginViewWin.cpp:
       
 16344         (WebCore::PluginViewWin::~PluginViewWin): Allow m_plugin to be null.
       
 16345 
       
 16346 2007-07-01  Rob Buis  <buis@kde.org>
       
 16347 
       
 16348         Reviewed by Darin.
       
 16349 
       
 16350         http://bugs.webkit.org/show_bug.cgi?id=14453
       
 16351         REGRESSION: www.nzherald.co.nz almost all the formating is gone
       
 16352  
       
 16353         * css/tokenizer.flex: Allow hex colors with 2, 4, or 5 hex digits.
       
 16354 
       
 16355 2007-07-01  Sam Weinig  <sam@webkit.org>
       
 16356 
       
 16357         Reviewed by Oliver.
       
 16358 
       
 16359         Third round of implicit 64-32 bit conversion errors fixes.
       
 16360         <rdar://problem/5292262>
       
 16361 
       
 16362         - Use new CSSPrimitiveValue::getDoubleValue() and CSSPrimitiveValue::getIntValue()
       
 16363           methods instead of CSSPrimitiveValue::getFloatValue() where appropriate.
       
 16364 
       
 16365         * css/CSSPrimitiveValue.cpp:
       
 16366         (WebCore::CSSPrimitiveValue::computeLengthInt):
       
 16367         (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
       
 16368         (WebCore::CSSPrimitiveValue::computeLengthShort):
       
 16369         (WebCore::CSSPrimitiveValue::computeLengthFloat):
       
 16370         (WebCore::CSSPrimitiveValue::computeLengthDouble):
       
 16371         (WebCore::CSSPrimitiveValue::getDoubleValue):
       
 16372         * css/CSSPrimitiveValue.h:
       
 16373         (WebCore::CSSPrimitiveValue::getDoubleValue):
       
 16374         (WebCore::CSSPrimitiveValue::getFloatValue):
       
 16375         (WebCore::CSSPrimitiveValue::getIntValue):
       
 16376         * css/Counter.h:
       
 16377         (WebCore::Counter::listStyleNumber):
       
 16378         * css/MediaQueryEvaluator.cpp:
       
 16379         (WebCore::parseAspectRatio):
       
 16380         * css/cssparser.cpp:
       
 16381         (WebCore::BorderImageParseContext::commitBorderImage):
       
 16382         * css/cssstyleselector.cpp:
       
 16383         (WebCore::convertToLength):
       
 16384         (WebCore::applyCounterList):
       
 16385         (WebCore::CSSStyleSelector::applyProperty):
       
 16386         (WebCore::CSSStyleSelector::mapBackgroundSize):
       
 16387         (WebCore::CSSStyleSelector::mapBackgroundXPosition):
       
 16388         (WebCore::CSSStyleSelector::mapBackgroundYPosition):
       
 16389         * html/HTMLTableElement.cpp:
       
 16390         (WebCore::HTMLTableElement::parseMappedAttribute):
       
 16391         * ksvg2/css/SVGCSSStyleSelector.cpp:
       
 16392         (WebCore::CSSStyleSelector::applySVGProperty):
       
 16393         * ksvg2/misc/KCanvasRenderingStyle.cpp:
       
 16394         (WebCore::KSVGPainterFactory::cssPrimitiveToLength):
       
 16395         (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
       
 16396 
       
 16397 2007-07-01  Pamela Greene  <pamg.bugs@gmail.com>
       
 16398 
       
 16399         Reviewed by Darin.
       
 16400 
       
 16401         Fix for <http://bugs.webkit.org/show_bug.cgi?id=14320>
       
 16402         Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
       
 16403         <rdar://problem/5290084>
       
 16404 
       
 16405         Use std::stable_sort() instead of qsort() to sort gradient stops.
       
 16406         Adjust the comparison function accordingly.
       
 16407 
       
 16408         * html/CanvasGradient.cpp:
       
 16409         (WebCore::compareStops):
       
 16410         (WebCore::CanvasGradient::findStop):
       
 16411 
       
 16412 2007-07-01  Holger Hans Peter Freyther  <zecke@selfish.org>
       
 16413 
       
 16414         Reviewed by Darin.
       
 16415 
       
 16416         m_usesPageCache was not initialized. As the b/f cache is only
       
 16417         implemented in the Mac port and WebView.mm is taking care of calling
       
 16418         Settings::setUsesPageCache I decided to make it false by default.
       
 16419 
       
 16420         * page/Settings.cpp:
       
 16421         (WebCore::Settings::Settings): m_usesPageCache was not initialized
       
 16422 
       
 16423 2007-07-01  Holger Hans Peter Freyther  <zecke@selfish.org>
       
 16424 
       
 16425         Reviewed by Darin.
       
 16426 
       
 16427         Inherited- and NonInheritedFlags is a bit field. But for comparsion
       
 16428         the other part of the union _iflags/_niflags is used for comparions.
       
 16429         This will compare 5 uninitialized bits of _iflags and 22 of _niflags.
       
 16430         Make sure the unused bits have a specified value.
       
 16431 
       
 16432         * ksvg2/css/SVGRenderStyle.h:
       
 16433         (WebCore::SVGRenderStyle::setBitDefaults): Make sure the unused bits
       
 16434         have a value as well.
       
 16435 
       
 16436 2007-06-30  Adam Roben  <aroben@apple.com>
       
 16437 
       
 16438         Compile WebCore with /W4 on Windows
       
 16439 
       
 16440         Some more warnings were disabled globally, including assignment within
       
 16441         a conditional, unused variable, and various warnings related to
       
 16442         inability to instantiate opaque structs.
       
 16443 
       
 16444         In addition, the "unreachable code" warning was turned off for
       
 16445         CSSGrammar.cpp and XPathGrammar.cpp.
       
 16446 
       
 16447         Reviewed by Oliver.
       
 16448 
       
 16449         * WebCore.vcproj/WebCore.vcproj:
       
 16450 
       
 16451 2007-06-29  Adam Roben  <aroben@apple.com>
       
 16452 
       
 16453         Give CString an equality operator to fix a bug in HTMLFormElement::formData
       
 16454 
       
 16455         The bug was spotted by MSVC /W4. The problem was that we were comparing
       
 16456         a CString to a char* using ==, but CString had no equality operator.
       
 16457         The result was that the CString was being cast to a const char* and a
       
 16458         pointer comparison was being done, which would (essentially) always
       
 16459         return false.
       
 16460 
       
 16461         There are two parts to the fix: get rid of CString's const char*
       
 16462         casting operator, and add an equality operator. Previous uses of the
       
 16463         casting operator have been changed to use CString::data().
       
 16464 
       
 16465         Test: http/misc/isindex-formdata.html
       
 16466 
       
 16467         Reviewed by Oliver.
       
 16468 
       
 16469         * dom/XMLTokenizer.cpp:
       
 16470         (WebCore::parseXMLDocumentFragment):
       
 16471         * html/HTMLDocument.cpp:
       
 16472         (WebCore::HTMLDocument::determineParseMode):
       
 16473         * html/HTMLFormElement.cpp:
       
 16474         (WebCore::HTMLFormElement::formData):
       
 16475         * loader/TextResourceDecoder.cpp:
       
 16476         (WebCore::TextResourceDecoder::checkForCSSCharset):
       
 16477         * platform/CString.cpp:
       
 16478         (WebCore::operator==):
       
 16479         * platform/CString.h:
       
 16480         * platform/KURL.cpp:
       
 16481         (WebCore::encodeRelativeString):
       
 16482         * platform/StringImpl.cpp:
       
 16483         (WebCore::StringImpl::toDouble):
       
 16484         * platform/network/cf/FormDataStreamCFNet.cpp:
       
 16485         (WebCore::setHTTPBody):
       
 16486         * platform/network/mac/FormDataStreamMac.mm:
       
 16487         (WebCore::setHTTPBody):
       
 16488         * platform/win/ClipboardUtilitiesWin.cpp:
       
 16489         (WebCore::markupToCF_HTML):
       
 16490         * plugins/win/PluginPackageWin.cpp:
       
 16491         (WebCore::splitString):
       
 16492         * plugins/win/PluginStreamWin.cpp:
       
 16493         (WebCore::PluginStreamWin::startStream):
       
 16494         (WebCore::PluginStreamWin::destroyStream):
       
 16495         (WebCore::PluginStreamWin::sendJavaScriptStream):
       
 16496         (WebCore::PluginStreamWin::didFinishLoading):
       
 16497         * plugins/win/PluginViewWin.cpp:
       
 16498         (WebCore::PluginViewWin::start):
       
 16499         (WebCore::createUTF8String):
       
 16500         (WebCore::PluginViewWin::userAgent):
       
 16501         * xml/XSLStyleSheet.cpp:
       
 16502         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
       
 16503         * xml/XSLTProcessor.cpp:
       
 16504         (WebCore::xsltParamArrayFromParameterMap):
       
 16505 
       
 16506 2007-06-29  Adam Roben  <aroben@apple.com>
       
 16507 
       
 16508         Initialize two variables that MSVC /W4 isn't smart enough to realize always get initialized
       
 16509 
       
 16510         Reviewed by John.
       
 16511 
       
 16512         * editing/Editor.cpp:
       
 16513         (WebCore::Editor::advanceToNextMisspelling):
       
 16514         * html/HTMLParser.cpp:
       
 16515 
       
 16516 2007-06-29  Adam Roben  <aroben@apple.com>
       
 16517 
       
 16518         Fix some possibly unitialized variables found by MSVC /W4
       
 16519 
       
 16520         Reviewed by John.
       
 16521 
       
 16522         * rendering/bidi.cpp:
       
 16523         (WebCore::RenderBlock::layoutInlineChildren):
       
 16524 
       
 16525 2007-06-29  Adam Roben  <aroben@apple.com>
       
 16526 
       
 16527         Remove bogus cast found by MSVC /W4
       
 16528 
       
 16529         Reviewed by John and Oliver.
       
 16530 
       
 16531         * ksvg2/css/SVGCSSParser.cpp:
       
 16532         (WebCore::CSSParser::parseSVGValue):
       
 16533 
       
 16534 2007-06-29  Adam Roben  <aroben@apple.com>
       
 16535 
       
 16536         Remove unused local functions uncovered by MSVC /W4
       
 16537 
       
 16538         Reviewed by John and Oliver.
       
 16539 
       
 16540         * platform/win/SearchPopupMenuWin.cpp:
       
 16541         * rendering/RenderText.cpp:
       
 16542 
       
 16543 2007-06-29  Adam Roben  <aroben@apple.com>
       
 16544 
       
 16545         Don't take the address of temporary values to appease MSVC /W4
       
 16546 
       
 16547         Reviewed by Oliver.
       
 16548 
       
 16549         No regression test possible.
       
 16550 
       
 16551         * platform/win/PopupMenuWin.cpp:
       
 16552         (WebCore::PopupMenu::invalidateItem):
       
 16553         (WebCore::PopupMenu::valueChanged):
       
 16554         (WebCore::PopupWndProc):
       
 16555         * platform/win/ScrollViewWin.cpp:
       
 16556         (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
       
 16557         * platform/win/UniscribeController.cpp:
       
 16558         (WebCore::UniscribeController::shapeAndPlaceItem):
       
 16559         * platform/win/WidgetWin.cpp:
       
 16560         (WebCore::Widget::invalidateRect):
       
 16561 
       
 16562 2007-06-29  Adam Roben  <aroben@apple.com>
       
 16563 
       
 16564         Make an int -> UINT conversion explicit that MSVC /W4 complains about
       
 16565 
       
 16566         Reviewed by John and Oliver.
       
 16567 
       
 16568         No regression test possible.
       
 16569 
       
 16570         * platform/win/SoundWin.cpp:
       
 16571 
       
 16572 2007-06-29  Adam Roben  <aroben@apple.com>
       
 16573 
       
 16574         Remove unreachable code uncovered by MSVC /W4
       
 16575 
       
 16576         Reviewed by Oliver.
       
 16577 
       
 16578         No regression test possible.
       
 16579 
       
 16580         * html/CanvasRenderingContext2D.cpp:
       
 16581         (WebCore::CanvasRenderingContext2D::createPattern):
       
 16582         * html/HTMLAnchorElement.cpp:
       
 16583         (WebCore::HTMLAnchorElement::isLiveLink):
       
 16584         * html/HTMLElement.cpp:
       
 16585         (WebCore::HTMLElement::contentEditable):
       
 16586         * platform/DeprecatedString.cpp:
       
 16587         (WebCore::allocateHandle):
       
 16588         (WebCore::freeHandle):
       
 16589         * plugins/win/npapi.cpp:
       
 16590         (pluginViewForInstance):
       
 16591         * rendering/RenderImage.cpp:
       
 16592         (WebCore::RenderImage::isWidthSpecified):
       
 16593         (WebCore::RenderImage::isHeightSpecified):
       
 16594         * rendering/RenderTheme.cpp:
       
 16595         (WebCore::RenderTheme::isControlStyled):
       
 16596 
       
 16597 2007-06-29  John Sullivan  <sullivan@apple.com>
       
 16598 
       
 16599         Reviewed by Oliver Hunt.
       
 16600         
       
 16601         - WebCore support for accessing the set of rectangles that encompass the selected text
       
 16602         
       
 16603         * page/Frame.h:
       
 16604         * page/Frame.cpp:
       
 16605         (WebCore::Frame::selectionTextRects):
       
 16606         new function, fills in a passed Vector with the line box rects that represent the selected range
       
 16607 
       
 16608         * rendering/RenderText.cpp:
       
 16609         (WebCore::RenderText::addLineBoxRects):
       
 16610         fixed off-by-one bug involving use of the confusing function InlineTextBox::end()
       
 16611 
       
 16612         * WebCore.exp:
       
 16613         exported symbol for this new function
       
 16614 
       
 16615 2007-06-29  Justin Garcia  <justin.garcia@apple.com>
       
 16616 
       
 16617         Reviewed by Harrison.
       
 16618         
       
 16619         <rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do
       
 16620         
       
 16621         Rolled out a change made in r23787.
       
 16622         
       
 16623         * editing/DeleteSelectionCommand.cpp:
       
 16624         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
       
 16625 
       
 16626 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
       
 16627 
       
 16628         Reviewed by Darin Adler, Anders Carlsson.
       
 16629         
       
 16630         Fixed <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML 
       
 16631         returns NULL if response MIME type is not XML -- breaks Wikipedia widget
       
 16632         
       
 16633         The spec says that responseXML must return null for any HTTP response
       
 16634         with a non-XML MIME type. Technically, that leaves non-HTTP responses
       
 16635         free to do whatever they want.
       
 16636 
       
 16637         * xml/xmlhttprequest.cpp:
       
 16638         (WebCore::XMLHttpRequest::getResponseXML): Only return null for non-XML
       
 16639         MIME types if the response was HTTP.
       
 16640 
       
 16641 2007-06-29  Sam Weinig  <sam@webkit.org>
       
 16642 
       
 16643         Reviewed by Darin.
       
 16644 
       
 16645         Second pass at fixing implicit 64-32 bit conversion errors.
       
 16646         <rdar://problem/5292262>
       
 16647 
       
 16648         - Use new JSValue::toFloat() method instead of toNumber() where
       
 16649           appropriate.
       
 16650 
       
 16651         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
       
 16652         (WebCore::JSCanvasRenderingContext2D::setFillColor):
       
 16653         (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
       
 16654         (WebCore::JSCanvasRenderingContext2D::strokeRect):
       
 16655         (WebCore::JSCanvasRenderingContext2D::drawImage):
       
 16656         (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
       
 16657         (WebCore::JSCanvasRenderingContext2D::setShadow):
       
 16658         * bindings/js/JSHTMLSelectElementCustom.cpp:
       
 16659         (WebCore::JSHTMLSelectElement::remove):
       
 16660         * bindings/js/JSSVGMatrixCustom.cpp:
       
 16661         (WebCore::JSSVGMatrix::rotateFromVector):
       
 16662         * bindings/js/kjs_events.cpp:
       
 16663         (KJS::JSClipboardPrototypeFunction::callAsFunction):
       
 16664         * bindings/scripts/CodeGeneratorJS.pm:
       
 16665         * ksvg2/svg/SVGScriptElement.cpp:
       
 16666         (WebCore::SVGScriptElement::executeScript):
       
 16667 
       
 16668 2007-06-29  Adele Peterson  <adele@apple.com>
       
 16669 
       
 16670         Rolling out fix for <rdar://problem/5301322> since it broke layout tests.
       
 16671 
       
 16672         * html/HTMLInputElement.h:
       
 16673         * html/HTMLTextAreaElement.h:
       
 16674 
       
 16675 2007-06-29  Geoffrey Garen  <ggaren@apple.com>
       
 16676 
       
 16677         Reviewed by Oliver Hunt.
       
 16678 
       
 16679         Fixed <rdar://problem/4962298> REGRESSION: Synchronous XHR for missing 
       
 16680         local file throws exception -- breaks Wikipedia widget
       
 16681 
       
 16682         * WebCore.xcodeproj/project.pbxproj:
       
 16683         * xml/xmlhttprequest.cpp:
       
 16684         (WebCore::XMLHttpRequest::send): Don't throw exceptions for local files.
       
 16685 
       
 16686 2007-06-29  Ada Chan  <adachan@apple.com>
       
 16687 
       
 16688         Reviewed by Adam.
       
 16689 
       
 16690         Fixed a previous fix to a signed/unsigned mismatch.
       
 16691 
       
 16692         * plugins/win/PluginPackageWin.cpp:
       
 16693         (WebCore::splitString):
       
 16694 
       
 16695 2007-06-29  Adele Peterson  <adele@apple.com>
       
 16696 
       
 16697         Reviewed by Ada and Kevin McCullough.
       
 16698 
       
 16699         Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas
       
 16700 
       
 16701         Implemented canSelectAll and selectAll for text fields and textareas, since they're special cases even when they're not editable.
       
 16702 
       
 16703         Tests:
       
 16704         fast/forms/input-readonly-select-all.html
       
 16705         fast/forms/textarea-readonly-select-all.html
       
 16706 
       
 16707         * html/HTMLInputElement.h:
       
 16708         (WebCore::HTMLInputElement::canSelectAll):
       
 16709         (WebCore::HTMLInputElement::selectAll):
       
 16710         * html/HTMLTextAreaElement.h:
       
 16711         (WebCore::HTMLTextAreaElement::canSelectAll):
       
 16712         (WebCore::HTMLTextAreaElement::selectAll):
       
 16713 
       
 16714 2007-06-29  Adam Roben  <aroben@apple.com>
       
 16715 
       
 16716         Build fix
       
 16717 
       
 16718         This is what happens when you test your patch on two OSs and then
       
 16719         commit from the wrong one.
       
 16720 
       
 16721         * rendering/RenderTextControl.cpp:
       
 16722         (WebCore::RenderTextControl::valueChanged):
       
 16723         (WebCore::RenderTextControl::itemText):
       
 16724         (WebCore::RenderTextControl::itemIsSeparator):
       
 16725 
       
 16726 2007-06-29  Adam Roben  <aroben@apple.com>
       
 16727 
       
 16728         Start compiling WebCore with /W3 under MSVC
       
 16729 
       
 16730         One warning was globally disabled: implicit conversion of int to bool.
       
 16731 
       
 16732         Reviewed by Darin.
       
 16733 
       
 16734         * WebCore.vcproj/WebCore.vcproj:
       
 16735 
       
 16736 2007-06-29  Adam Roben  <aroben@apple.com>
       
 16737 
       
 16738         Turn DeprecatedStringData's copy constructor into a static method to appease MSVC /W3
       
 16739 
       
 16740         DeprecatedStringData now has no public copy constructor. The single
       
 16741         call to the old one has been replaced with a call to the new
       
 16742         DeprecatedStringData::createAndAdopt static method.
       
 16743 
       
 16744         Reviewed by Darin.
       
 16745 
       
 16746         All regression tests pass.
       
 16747 
       
 16748         * platform/DeprecatedString.cpp:
       
 16749         (WebCore::DeprecatedStringData::createAndAdopt):
       
 16750         (WebCore::DeprecatedStringData::adopt):
       
 16751         (WebCore::DeprecatedString::detachIfInternal):
       
 16752         * platform/DeprecatedString.h:
       
 16753 
       
 16754 2007-06-29  Adam Roben  <aroben@apple.com>
       
 16755 
       
 16756         Fix more signed/unsigned mismatches uncovered by MSVC /W3
       
 16757 
       
 16758         Reviewed by John.
       
 16759 
       
 16760         No regression tests possible.
       
 16761 
       
 16762         * platform/network/cf/ResourceResponseCFNet.cpp:
       
 16763         (WebCore::filenameHasSaneExtension):
       
 16764         * platform/win/FontDataWin.cpp:
       
 16765         (WebCore::FontData::containsCharacters):
       
 16766         * platform/win/PlatformScrollBarSafari.cpp:
       
 16767         (WebCore::):
       
 16768         * platform/win/UniscribeController.cpp:
       
 16769         (WebCore::UniscribeController::advance):
       
 16770         (WebCore::UniscribeController::shapeAndPlaceItem):
       
 16771         * platform/win/WebCoreTextRenderer.cpp:
       
 16772         (WebCore::doDrawTextAtPoint):
       
 16773         * plugins/win/PluginDatabaseWin.cpp:
       
 16774         (WebCore::parseVersionString):
       
 16775         * plugins/win/PluginPackageWin.cpp:
       
 16776         (WebCore::splitString):
       
 16777         * plugins/win/PluginViewWin.cpp:
       
 16778         (WebCore::freeStringArray):
       
 16779         (WebCore::PluginViewWin::invalidateTimerFired):
       
 16780 
       
 16781 2007-06-29  Adam Roben  <aroben@apple.com>
       
 16782 
       
 16783         Change PopupMenuClient::listSize to return an int to appease warnings from MSVC /W3
       
 16784 
       
 16785         Reviewed by John.
       
 16786 
       
 16787         No regression test possible.
       
 16788 
       
 16789         * html/HTMLSelectElement.cpp:
       
 16790         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
       
 16791         * platform/PopupMenuClient.h:
       
 16792         * platform/win/PopupMenuWin.cpp:
       
 16793         (WebCore::PopupMenu::calculatePositionAndSize):
       
 16794         (WebCore::PopupMenu::focusFirst):
       
 16795         (WebCore::PopupMenu::focusLast):
       
 16796         (WebCore::PopupMenu::down):
       
 16797         (WebCore::PopupMenu::up):
       
 16798         (WebCore::PopupMenu::paint):
       
 16799         * rendering/RenderMenuList.cpp:
       
 16800         * rendering/RenderMenuList.h:
       
 16801         * rendering/RenderTextControl.cpp:
       
 16802         * rendering/RenderTextControl.h:
       
 16803 
       
 16804 2007-06-29  Adam Roben  <aroben@apple.com>
       
 16805 
       
 16806         Fix two typos spotted by MSVC /W3
       
 16807 
       
 16808         Both typos were a semicolon following the condition of an if. This
       
 16809         would cause the intended body of the if to always execute.
       
 16810 
       
 16811         Unfortunately neither of these fixes are testable.
       
 16812         BackForwardList::goForward is only called from WebBackForwardList, and
       
 16813         the createDragImageFromImage bug would only manifest itself when
       
 16814         CreateCompatibleDC failed.
       
 16815 
       
 16816         Reviewed by Mark.
       
 16817 
       
 16818         * history/BackForwardList.cpp:
       
 16819         (WebCore::BackForwardList::goForward):
       
 16820         * platform/win/DragImageWin.cpp:
       
 16821         (WebCore::createDragImageFromImage):
       
 16822 
       
 16823 2007-06-29  Adam Treat  <adam@staikos.net>
       
 16824 
       
 16825         Reviewed by george Staikos.
       
 16826 
       
 16827         Support horizontal and vertical scroll, and set the right units.
       
 16828 
       
 16829         * platform/qt/WheelEventQt.cpp:
       
 16830         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
       
 16831 
       
 16832 2007-06-28  Adam Roben  <aroben@apple.com>
       
 16833 
       
 16834         Get WebCore compiling with /W2 on Windows
       
 16835 
       
 16836         Reviewed by Steve.
       
 16837 
       
 16838         No regression tests affected.
       
 16839 
       
 16840         * WebCore.vcproj/WebCore.vcproj: Turn the warning level up to 2, and
       
 16841         disable two warnings: implicit int <=> float conversion, and class vs.
       
 16842         struct inconsistency.
       
 16843         * dom/CharacterData.cpp:
       
 16844         (WebCore::CharacterData::deleteData): Cast to int before negating.
       
 16845         * loader/Cache.cpp:
       
 16846         (WebCore::Cache::remove): Ditto.
       
 16847         * platform/graphics/Path.cpp:
       
 16848         (WebCore::pathLengthApplierFunction): Consistently use floats.
       
 16849         * platform/graphics/cg/GraphicsContextCG.cpp:
       
 16850         (WebCore::GraphicsContext::drawEllipse): Ditto.
       
 16851         * platform/win/GraphicsContextWin.cpp:
       
 16852         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Ditto.
       
 16853 
       
 16854 2007-06-28  Geoffrey Garen  <ggaren@apple.com>
       
 16855 
       
 16856         Reviewed by Maciej Stachowiak.
       
 16857         
       
 16858         Fixed <rdar://problem/5299005> DOM timers fire without a local autorelease 
       
 16859         pool => pathologically high high water mark
       
 16860         
       
 16861         I couldn't measure any performance problems with iBench HTML or PLT.
       
 16862 
       
 16863         * WebCore.xcodeproj/project.pbxproj: Changed .cpp file to be ObjC++.
       
 16864         * platform/mac/SharedTimerMac.cpp:
       
 16865         (WebCore::timerFired): Added autorelease pool.
       
 16866 
       
 16867 2007-06-28  Mitz Pettel  <mitz@webkit.org>
       
 16868 
       
 16869         Reviewed by Beth.
       
 16870 
       
 16871         - fix http://bugs.webkit.org/show_bug.cgi?id=14118
       
 16872           ASSERTION FAILED: !needsLayout() seen again
       
 16873 
       
 16874         Test: fast/dynamic/recursive-layout.html
       
 16875 
       
 16876         * page/FrameView.cpp:
       
 16877         (WebCore::FrameView::layout): Removed the midLayout guards around
       
 16878         the calls to invalidateSelection() and updateWidgetPositions(). Those
       
 16879         calls may dirty the layout, but in that case they also update it, so
       
 16880         they should be allowed to do it. Added an ASSERT to make sure that when
       
 16881         they return, the root is not marked for layout.
       
 16882 
       
 16883 2007-06-28  Sam Weinig  <sam@webkit.org>
       
 16884 
       
 16885         Rubberstamped by Adam Roben.
       
 16886 
       
 16887         Roll out r23861.  It caused the buildbot to fail on intel.
       
 16888 
       
 16889         * page/Page.cpp:
       
 16890         (WebCore::Page::goToItem):
       
 16891 
       
 16892 2007-06-26  Maxime Britto  <mbritto@pleyo.com>
       
 16893 
       
 16894         Reviewed by Geoff.
       
 16895 
       
 16896         Patch for http://bugs.webkit.org/show_bug.cgi?id=13038
       
 16897         ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame
       
 16898 
       
 16899         Modification of an ASSERT on goToItem related to go back/forward in
       
 16900         history.Don't need to check the frameset if the target is _blank.
       
 16901 
       
 16902          * page/Page.cpp:
       
 16903          (WebCore::Page::goToItem):
       
 16904 
       
 16905 2007-06-28  Anders Carlsson  <andersca@apple.com>
       
 16906 
       
 16907         Reviewed by Oliver.
       
 16908 
       
 16909         <rdar://problem/5234139>
       
 16910         <object> with PNG src rendered as image document.
       
 16911         
       
 16912         Complete the URL before passing it to the frame loader client.
       
 16913         
       
 16914         * html/HTMLObjectElement.cpp:
       
 16915         (WebCore::HTMLObjectElement::isImageType):
       
 16916 
       
 16917 2007-06-28  Rob Buis  <buis@kde.org>
       
 16918 
       
 16919         Reviewed by Maciej.
       
 16920 
       
 16921         http://bugs.webkit.org/show_bug.cgi?id=14373
       
 16922         CSS1: selectors (classes and IDs) cannot start with a dash or with a digit
       
 16923 
       
 16924         Make sure the id selector validates against the CSS2.1 identfier
       
 16925         definition, not the hexcolor/HASH definition.
       
 16926 
       
 16927         * css/CSSGrammar.y:
       
 16928         * css/cssparser.cpp:
       
 16929         (WebCore::CSSParser::lex):
       
 16930         (WebCore::CSSParser::text):
       
 16931         * css/tokenizer.flex:
       
 16932 
       
 16933 2007-06-28  Simon Hausmann  <hausmann@kde.org>
       
 16934 
       
 16935         Reviewed by Zack.
       
 16936 
       
 16937         Implemented PasteboardQt::writeSelection to copy the selected text into the Clipboard as well as PasteboardQt::plainText to retrieve plain text from the clipboard for pasting for example into form fields.
       
 16938 
       
 16939         * platform/qt/PasteboardQt.cpp:
       
 16940         (WebCore::Pasteboard::writeSelection):
       
 16941 
       
 16942 2007-06-28  Antti Koivisto  <antti@apple.com>
       
 16943 
       
 16944         Reviewed by Mitz.
       
 16945         
       
 16946         Fix http://bugs.webkit.org/show_bug.cgi?id=14332
       
 16947         Bug 14332: REGRESSION (r21145): <td> width ignored
       
 16948         <rdar://problem/5290123>
       
 16949         
       
 16950         Cells in table with non-zero cellpadding are not considered empty.
       
 16951 
       
 16952         * rendering/AutoTableLayout.cpp:
       
 16953         (WebCore::AutoTableLayout::recalcColumn):
       
 16954 
       
 16955 2007-06-28  Adam Roben  <aroben@apple.com>
       
 16956 
       
 16957         Fix <rdar://problem/5300455> Prefast: typo in RenderBlock::paintObject
       
 16958 
       
 16959         Reviewed by Hyatt.
       
 16960 
       
 16961         No layout test possible, as this bug didn't have any effect since
       
 16962         "bool & bool" has the same value as "bool && bool"
       
 16963 
       
 16964         * rendering/RenderBlock.cpp:
       
 16965         (WebCore::RenderBlock::paintObject): Changed & to &&.
       
 16966 
       
 16967 2007-06-28  Adam Roben  <aroben@apple.com>
       
 16968 
       
 16969         Fix <rdar://problem/5300443> word-break and -webkit-user-modify allow any value
       
 16970 
       
 16971         The bug was caused by two typos found by prefast.
       
 16972 
       
 16973         Reviewed by Hyatt.
       
 16974 
       
 16975         * css/cssparser.cpp:
       
 16976         (WebCore::CSSParser::parseValue): Fixed typos.
       
 16977 
       
 16978 2007-06-20  Matt Perry  <mpComplete@gmail.com>
       
 16979 
       
 16980         Reviewed by Adam.
       
 16981 
       
 16982         - Fix http://bugs.webkit.org/show_bug.cgi?id=14251:
       
 16983           onchange handler for select controls doesn't fire when changing via keyboard
       
 16984 
       
 16985         * html/HTMLSelectElement.cpp:
       
 16986         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Got rid of
       
 16987         a call to saveLastSelection in the "Enter" key handler for select
       
 16988         controls that was preventing onchange from firing.
       
 16989 
       
 16990 2007-06-27  Sam Weinig  <sam@webkit.org>
       
 16991 
       
 16992         Fix Gdk, Qt, and Win32 builds.
       
 16993 
       
 16994         * WebCore.pro:
       
 16995         * WebCore.vcproj/WebCore.vcproj:
       
 16996 
       
 16997 2007-06-27  Sam Weinig  <sam@webkit.org>
       
 16998 
       
 16999         Reviewed by Geoff.
       
 17000 
       
 17001         Patch for http://bugs.webkit.org/show_bug.cgi?id=14319
       
 17002         Move the Selection object out of the JS bindings
       
 17003 
       
 17004         - Renames JS Object Selection to DOMSelection to avoid a name
       
 17005           conflict.
       
 17006 
       
 17007         * DerivedSources.make:
       
 17008         * WebCore.xcodeproj/project.pbxproj:
       
 17009         * bindings/js/kjs_window.cpp:
       
 17010         (KJS::WindowPrivate::WindowPrivate):
       
 17011         (KJS::Window::mark):
       
 17012         (KJS::Window::clearHelperObjectProperties):
       
 17013         (KJS::WindowFunc::callAsFunction):
       
 17014         (KJS::Window::disconnectFrame):
       
 17015         * bindings/js/kjs_window.h:
       
 17016         (KJS::Window::):
       
 17017         * page/DOMSelection.cpp: Added.
       
 17018         (WebCore::DOMSelection::DOMSelection):
       
 17019         (WebCore::DOMSelection::frame):
       
 17020         (WebCore::DOMSelection::disconnectFrame):
       
 17021         (WebCore::DOMSelection::anchorNode):
       
 17022         (WebCore::DOMSelection::baseNode):
       
 17023         (WebCore::DOMSelection::anchorOffset):
       
 17024         (WebCore::DOMSelection::baseOffset):
       
 17025         (WebCore::DOMSelection::focusNode):
       
 17026         (WebCore::DOMSelection::extentNode):
       
 17027         (WebCore::DOMSelection::focusOffset):
       
 17028         (WebCore::DOMSelection::extentOffset):
       
 17029         (WebCore::DOMSelection::isCollapsed):
       
 17030         (WebCore::DOMSelection::type):
       
 17031         (WebCore::DOMSelection::rangeCount):
       
 17032         (WebCore::DOMSelection::collapse):
       
 17033         (WebCore::DOMSelection::collapseToEnd):
       
 17034         (WebCore::DOMSelection::collapseToStart):
       
 17035         (WebCore::DOMSelection::empty):
       
 17036         (WebCore::DOMSelection::setBaseAndExtent):
       
 17037         (WebCore::DOMSelection::setPosition):
       
 17038         (WebCore::DOMSelection::modify):
       
 17039         (WebCore::DOMSelection::getRangeAt):
       
 17040         (WebCore::DOMSelection::removeAllRanges):
       
 17041         (WebCore::DOMSelection::addRange):
       
 17042         (WebCore::DOMSelection::toString):
       
 17043         * page/DOMSelection.h: Added.
       
 17044         * page/DOMSelection.idl: Added.
       
 17045         * page/DOMWindow.cpp:
       
 17046         (WebCore::DOMWindow::disconnectFrame):
       
 17047         (WebCore::DOMWindow::getSelection):
       
 17048         * page/DOMWindow.h:
       
 17049         * page/DOMWindow.idl:
       
 17050 
       
 17051 2007-06-27  Sam Weinig  <sam@webkit.org>
       
 17052 
       
 17053         Reviewed by Maciej.
       
 17054 
       
 17055         2nd patch for http://bugs.webkit.org/show_bug.cgi?id=14111
       
 17056         Autogenerate Event JS binding
       
 17057 
       
 17058         - Cleanup kjs_events
       
 17059 
       
 17060         * bindings/js/kjs_events.cpp:
       
 17061         (WebCore::JSAbstractEventListener::JSAbstractEventListener):
       
 17062         (WebCore::JSAbstractEventListener::handleEvent):
       
 17063         (WebCore::JSAbstractEventListener::isHTMLEventListener):
       
 17064         (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
       
 17065         (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
       
 17066         (WebCore::JSUnprotectedEventListener::listenerObj):
       
 17067         (WebCore::JSUnprotectedEventListener::windowObj):
       
 17068         (WebCore::JSUnprotectedEventListener::clearWindowObj):
       
 17069         (WebCore::JSUnprotectedEventListener::mark):
       
 17070         (WebCore::JSEventListener::JSEventListener):
       
 17071         (WebCore::JSEventListener::~JSEventListener):
       
 17072         (WebCore::JSEventListener::listenerObj):
       
 17073         (WebCore::JSEventListener::windowObj):
       
 17074         (WebCore::JSEventListener::clearWindowObj):
       
 17075         (WebCore::JSLazyEventListener::JSLazyEventListener):
       
 17076         (WebCore::JSLazyEventListener::listenerObj):
       
 17077         (WebCore::JSLazyEventListener::parseCode):
       
 17078         (WebCore::getNodeEventListener):
       
 17079         (WebCore::JSClipboard::JSClipboard):
       
 17080         (WebCore::JSClipboard::getValueProperty):
       
 17081         (WebCore::JSClipboard::putValueProperty):
       
 17082         (WebCore::JSClipboardPrototypeFunction::callAsFunction):
       
 17083         (WebCore::toJS):
       
 17084         (WebCore::toClipboard):
       
 17085         * bindings/js/kjs_events.h:
       
 17086         (WebCore::JSClipboard::classInfo):
       
 17087         (WebCore::JSClipboard::impl):
       
 17088         * bindings/js/kjs_window.h:
       
 17089         * ksvg2/events/JSSVGLazyEventListener.h:
       
 17090 
       
 17091 2007-06-27  Sam Weinig  <sam@webkit.org>
       
 17092 
       
 17093         Reviewed by Adam Roben.
       
 17094 
       
 17095         Patch for http://bugs.webkit.org/show_bug.cgi?id=12045
       
 17096         Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
       
 17097         <rdar://problem/5286670>
       
 17098 
       
 17099         Test: fast/forms/thumbslider-no-parent-slider.html
       
 17100         Test: fast/forms/thumbslider-crash.html
       
 17101 
       
 17102         * rendering/RenderObject.h:
       
 17103         (WebCore::RenderObject::isSlider):
       
 17104         * rendering/RenderSlider.h:
       
 17105         (WebCore::RenderSlider::isSlider):
       
 17106         * rendering/RenderTheme.cpp:
       
 17107         (WebCore::RenderTheme::paint): Only paint thumbslider
       
 17108         if the parent renderer is a RenderSlider.
       
 17109         * rendering/RenderThemeMac.mm:
       
 17110         (WebCore::RenderThemeMac::paintSliderThumb):
       
 17111         * rendering/RenderThemeSafari.cpp:
       
 17112         (WebCore::RenderThemeSafari::paintSliderThumb):
       
 17113 
       
 17114 2007-06-27  George Staikos  <staikos@kde.org>
       
 17115 
       
 17116         Make Qt builds link when XSLT is turned off.
       
 17117 
       
 17118         * WebCore.pro:
       
 17119 
       
 17120 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
       
 17121 
       
 17122         Turn on static code analysis (Windows only).
       
 17123 
       
 17124         Affects only folks that have Visual Studio Team Suite installed,
       
 17125         or who have replaced their compiler with the version shipping in the
       
 17126         Vista SDK.
       
 17127         
       
 17128         Reviewed by Oliver.
       
 17129 
       
 17130         * WebCore.vcproj/WebCore.vcproj:
       
 17131 
       
 17132 2007-06-27  George Staikos  <staikos@kde.org>
       
 17133 
       
 17134         Remove old commented out files that no-longer exist.
       
 17135 
       
 17136         * WebCore.pro:
       
 17137 
       
 17138 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
       
 17139 
       
 17140         Reviewed by John.
       
 17141 
       
 17142         <rdar://problem/5247341> REGRESSION: Pasting sometimes leaves out trailing newline
       
 17143         
       
 17144         Pasting with a trailing interchange newline doesn't work when pasting
       
 17145         into an empty line.  Code that handles removing brs at the insertion
       
 17146         position tries to also handle trailing interchange newlines by re-using
       
 17147         those brs and fails.  Removed that code and handle all interchange
       
 17148         newlines with code later in doApply().
       
 17149 
       
 17150         * editing/ReplaceSelectionCommand.cpp:
       
 17151         (WebCore::ReplaceSelectionCommand::doApply): Don't try to re-use the
       
 17152         endBR when there's a trailing interchange newline.
       
 17153         
       
 17154 2007-06-27  Anders Carlsson  <andersca@apple.com>
       
 17155 
       
 17156         Reviewed by Oliver.
       
 17157 
       
 17158         <rdar://problem/5253950>
       
 17159         When Shockwave plugin has been loaded, exiting crashes Safari
       
 17160         
       
 17161         Add a "load count" for plugin packages. When the load count is zero, unload the plugin.
       
 17162         
       
 17163         * plugins/win/PluginPackageWin.cpp:
       
 17164         (WebCore::PluginPackageWin::PluginPackageWin):
       
 17165         (WebCore::PluginPackageWin::load):
       
 17166         (WebCore::PluginPackageWin::unload):
       
 17167         (WebCore::PluginPackageWin::unloadWithoutShutdown):
       
 17168         * plugins/win/PluginPackageWin.h:
       
 17169         
       
 17170         * plugins/win/PluginViewWin.cpp:
       
 17171         (WebCore::PluginViewWin::~PluginViewWin):
       
 17172         Make sure to unload the plugin package and clear any references to plugin script objects.
       
 17173 
       
 17174 2007-06-27  George Staikos  <staikos@kde.org>
       
 17175 
       
 17176         This was succeeding compile by luck.  Setup dependencies properly.
       
 17177 
       
 17178         * WebCore.pro:
       
 17179 
       
 17180 2007-06-27  Justin Garcia  <justin.garcia@apple.com>
       
 17181 
       
 17182         Reviewed by John.
       
 17183 
       
 17184         <rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list
       
 17185         
       
 17186         When a quoted numbered list is broken in half, it's cloned
       
 17187         to make the second list. That second list needs its start attribute
       
 17188         set so that the numbers of the list items in it will be preserved.
       
 17189 
       
 17190         * editing/BreakBlockquoteCommand.cpp:
       
 17191         (WebCore::BreakBlockquoteCommand::doApply): Set the start attribute
       
 17192         of a cloned list to be the original number of the first list item in it.
       
 17193 
       
 17194 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
       
 17195 
       
 17196         Reviewed by Geoff.
       
 17197 
       
 17198         http://bugs.webkit.org/show_bug.cgi?id=14413
       
 17199         GIF animation throttling is different from MSIE
       
 17200 
       
 17201         * platform/graphics/cg/ImageSourceCG.cpp:
       
 17202         (WebCore::ImageSource::frameDurationAtIndex):
       
 17203         Change the cut-off value to 50ms to match MSIE.
       
 17204 
       
 17205 2007-06-27  Sam Weinig  <sam@webkit.org>
       
 17206 
       
 17207         Reviewed by Darin.
       
 17208 
       
 17209         First pass at fixing implicit 64-32 bit conversion errors.
       
 17210         <rdar://problem/5292262>
       
 17211 
       
 17212         - Add 'f' suffix where necessary.
       
 17213 
       
 17214         * bridge/mac/WebCoreAXObject.mm:
       
 17215         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
       
 17216         * css/csshelper.h:
       
 17217         * css/cssstyleselector.cpp:
       
 17218         (WebCore::):
       
 17219         (WebCore::CSSStyleSelector::largerFontSize):
       
 17220         (WebCore::CSSStyleSelector::smallerFontSize):
       
 17221         * html/CanvasGradient.cpp:
       
 17222         (WebCore::CanvasGradient::addColorStop):
       
 17223         * html/CanvasPattern.cpp:
       
 17224         (WebCore::CanvasPattern::createPattern):
       
 17225         * ksvg2/css/SVGCSSStyleSelector.cpp:
       
 17226         (WebCore::CSSStyleSelector::applySVGProperty):
       
 17227         * ksvg2/css/SVGRenderStyle.h:
       
 17228         * ksvg2/events/SVGZoomEvent.cpp:
       
 17229         (WebCore::SVGZoomEvent::SVGZoomEvent):
       
 17230         * ksvg2/svg/SVGLength.cpp:
       
 17231         (WebCore::SVGLength::SVGLength):
       
 17232         (WebCore::SVGLength::value):
       
 17233         (WebCore::SVGLength::setValue):
       
 17234         (WebCore::SVGLength::valueAsPercentage):
       
 17235         (WebCore::SVGLength::PercentageOfViewport):
       
 17236         * ksvg2/svg/SVGSVGElement.cpp:
       
 17237         (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
       
 17238         (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
       
 17239         (WebCore::SVGSVGElement::getScreenCTM):
       
 17240         * ksvg2/svg/SVGTextContentElement.cpp:
       
 17241         (WebCore::SVGTextContentElement::getComputedTextLength):
       
 17242         (WebCore::SVGTextContentElement::getSubStringLength):
       
 17243         (WebCore::SVGTextContentElement::getRotationOfChar):
       
 17244         * ksvg2/svg/SVGTransformDistance.cpp:
       
 17245         (WebCore::SVGTransformDistance::SVGTransformDistance):
       
 17246         (WebCore::SVGTransformDistance::distance):
       
 17247         * page/InspectorController.cpp:
       
 17248         (WebCore::InspectorResource::InspectorResource):
       
 17249         * platform/graphics/FloatPoint3D.cpp:
       
 17250         (WebCore::FloatPoint3D::normalize):
       
 17251         * platform/graphics/Path.cpp:
       
 17252         (WebCore::pathLengthApplierFunction):
       
 17253         (WebCore::Path::createRoundedRectangle):
       
 17254         * platform/graphics/cg/GraphicsContextCG.cpp:
       
 17255         (WebCore::GraphicsContext::drawLine):
       
 17256         (WebCore::GraphicsContext::strokeArc):
       
 17257         * platform/graphics/cg/ImageCG.cpp:
       
 17258         (WebCore::FrameData::clear):
       
 17259         * platform/graphics/cg/ImageSourceCG.cpp:
       
 17260         (WebCore::ImageSource::frameDurationAtIndex):
       
 17261         * platform/graphics/cg/PDFDocumentImage.cpp:
       
 17262         (WebCore::PDFDocumentImage::setCurrentPage):
       
 17263         * platform/graphics/svg/SVGPaintServerPattern.cpp:
       
 17264         (WebCore::SVGPaintServerPattern::externalRepresentation):
       
 17265         * platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
       
 17266         (WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
       
 17267         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
       
 17268         (WebCore::cgGradientCallback):
       
 17269         (WebCore::CGShadingRefForRadialGradient):
       
 17270         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
       
 17271         * platform/mac/FontDataMac.mm:
       
 17272         (WebCore::webFallbackFontFamily):
       
 17273         * platform/mac/PopupMenuMac.mm:
       
 17274         (WebCore::PopupMenu::show):
       
 17275         * rendering/InlineFlowBox.cpp:
       
 17276         (WebCore::InlineFlowBox::placeBoxesHorizontally):
       
 17277         * rendering/RenderSlider.cpp:
       
 17278         (WebCore::RenderSlider::setValueForPosition):
       
 17279         (WebCore::RenderSlider::setPositionFromValue):
       
 17280 
       
 17281 2007-06-27  Alexey Proskuryakov  <ap@webkit.org>
       
 17282 
       
 17283         Reviewed by Geoff.
       
 17284 
       
 17285         http://bugs.webkit.org/show_bug.cgi?id=14288
       
 17286         XMLHttpRequest doesn't use a correct content type for file:// URLs
       
 17287 
       
 17288         Test: fast/dom/xmlhttprequest-html-response-encoding.html
       
 17289 
       
 17290         * xml/xmlhttprequest.cpp:
       
 17291         (WebCore::XMLHttpRequest::responseMIMEType): Use MIME type provided by
       
 17292         the network layer, since it provides it even for non-HTTP responses.
       
 17293 
       
 17294 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
       
 17295 
       
 17296         Reviewed by Sam Weinig.
       
 17297 
       
 17298         http://bugs.webkit.org/show_bug.cgi?id=14061
       
 17299         Implement more of FrameLoaderClientGdk
       
 17300 
       
 17301         Make FrameLoaderClientGdk work properly when the MIME type is set.
       
 17302 
       
 17303         * loader/gdk/FrameLoaderClientGdk.cpp:
       
 17304         (WebCore::FrameLoaderClientGdk::objectContentType):
       
 17305         (WebCore::FrameLoaderClientGdk::canShowMIMEType):
       
 17306 
       
 17307 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
       
 17308 
       
 17309         Reviewed by Maciej.
       
 17310 
       
 17311         http://bugs.webkit.org/show_bug.cgi?id=14058
       
 17312         Gdk font backend cleanup
       
 17313 
       
 17314         * platform/FontData.h: Remove obsolete function.
       
 17315         * platform/gdk/FontDataGdk.cpp:
       
 17316         (WebCore::FontData::containsCharacters): Lock/unlock only once.
       
 17317         (WebCore::FontData::platformWidthForGlyph): Remove needless cast.
       
 17318         * platform/gdk/FontPlatformData.h: Remove obsolete function.
       
 17319         * platform/gdk/FontPlatformDataGdk.cpp:
       
 17320         (WebCore::FontPlatformData::FontPlatformData): Pass the actual size,
       
 17321         not the pixel size.
       
 17322         (WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
       
 17323         * platform/gdk/GlyphPageTreeNodeGdk.cpp:
       
 17324         (WebCore::GlyphPage::fill): Lock/unlock only once.
       
 17325 
       
 17326 2007-06-26  Mitz Pettel  <mitz@webkit.org>
       
 17327 
       
 17328         Reviewed by Hyatt.
       
 17329 
       
 17330         - fix http://bugs.webkit.org/show_bug.cgi?id=14406
       
 17331           <colgroup>'s borders are ignored when it has <col> children
       
 17332 
       
 17333         Covered by existing tests.
       
 17334 
       
 17335         * rendering/RenderTableCell.cpp:
       
 17336         (WebCore::RenderTableCell::collapsedLeftBorder):
       
 17337         (WebCore::RenderTableCell::collapsedRightBorder):
       
 17338         (WebCore::RenderTableCell::collapsedTopBorder):
       
 17339         (WebCore::RenderTableCell::collapsedBottomBorder):
       
 17340 
       
 17341 2007-06-26  Mitz Pettel  <mitz@webkit.org>
       
 17342 
       
 17343         Reviewed by Oliver.
       
 17344 
       
 17345         - fix http://bugs.webkit.org/show_bug.cgi?id=14329
       
 17346           REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
       
 17347 
       
 17348         Test: fast/repaint/text-selection-rect-in-overflow-2.html
       
 17349 
       
 17350         * rendering/RenderObject.cpp:
       
 17351         (WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account
       
 17352         for overflow scroll and columns.
       
 17353         * rendering/RenderText.cpp:
       
 17354         (WebCore::RenderText::selectionRect): Adjust for columns only in the
       
 17355         non-clipped case, since RenderObject::absolutePosition() does not.
       
 17356 
       
 17357 2007-06-26  Mitz Pettel  <mitz@webkit.org>
       
 17358 
       
 17359         Reviewed by Sam.
       
 17360 
       
 17361         - http://bugs.webkit.org/show_bug.cgi?id=14415
       
 17362           Remove the unused method RenderObject::setTable()
       
 17363 
       
 17364         * rendering/RenderObject.h:
       
 17365 
       
 17366 2007-06-26  MorganL  <morganl.webkit@yahoo.com>
       
 17367 
       
 17368         Reviewed by Maciej.
       
 17369 
       
 17370         Implement http://bugs.webkit.org/show_bug.cgi?id=14225
       
 17371         Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs
       
 17372 
       
 17373         This change moves the bulk of ResourceRequest into a base class named
       
 17374         ResourceRequestBase with all platform-specific bits pushed into
       
 17375         ResourceRequest.  This allows ports to easily add new members to a
       
 17376         ResourceRequest without having to #ifdef the code that is shared
       
 17377         between ports.
       
 17378 
       
 17379         * WebCore.exp:
       
 17380         * WebCore.pro:
       
 17381         * WebCore.vcproj/WebCore.vcproj:
       
 17382         * WebCore.xcodeproj/project.pbxproj:
       
 17383         * platform/network/ResourceRequest.cpp: Removed.
       
 17384         * platform/network/ResourceRequest.h: Removed.
       
 17385         * platform/network/ResourceRequestBase.cpp: Added.
       
 17386         (WebCore::ResourceRequestBase::asResourceRequest):
       
 17387         (WebCore::ResourceRequestBase::isEmpty):
       
 17388         (WebCore::ResourceRequestBase::isNull):
       
 17389         (WebCore::ResourceRequestBase::url):
       
 17390         (WebCore::ResourceRequestBase::setURL):
       
 17391         (WebCore::ResourceRequestBase::cachePolicy):
       
 17392         (WebCore::ResourceRequestBase::setCachePolicy):
       
 17393         (WebCore::ResourceRequestBase::timeoutInterval):
       
 17394         (WebCore::ResourceRequestBase::setTimeoutInterval):
       
 17395         (WebCore::ResourceRequestBase::mainDocumentURL):
       
 17396         (WebCore::ResourceRequestBase::setMainDocumentURL):
       
 17397         (WebCore::ResourceRequestBase::httpMethod):
       
 17398         (WebCore::ResourceRequestBase::setHTTPMethod):
       
 17399         (WebCore::ResourceRequestBase::httpHeaderFields):
       
 17400         (WebCore::ResourceRequestBase::httpHeaderField):
       
 17401         (WebCore::ResourceRequestBase::setHTTPHeaderField):
       
 17402         (WebCore::ResourceRequestBase::httpBody):
       
 17403         (WebCore::ResourceRequestBase::setHTTPBody):
       
 17404         (WebCore::ResourceRequestBase::allowHTTPCookies):
       
 17405         (WebCore::ResourceRequestBase::setAllowHTTPCookies):
       
 17406         (WebCore::ResourceRequestBase::addHTTPHeaderField):
       
 17407         (WebCore::ResourceRequestBase::addHTTPHeaderFields):
       
 17408         (WebCore::operator==):
       
 17409         (WebCore::ResourceRequestBase::isConditional):
       
 17410         (WebCore::ResourceRequestBase::updatePlatformRequest):
       
 17411         (WebCore::ResourceRequestBase::updateResourceRequest):
       
 17412         * platform/network/ResourceRequestBase.h: Added.
       
 17413         (WebCore::):
       
 17414         (WebCore::ResourceRequestBase::httpContentType):
       
 17415         (WebCore::ResourceRequestBase::setHTTPContentType):
       
 17416         (WebCore::ResourceRequestBase::httpReferrer):
       
 17417         (WebCore::ResourceRequestBase::setHTTPReferrer):
       
 17418         (WebCore::ResourceRequestBase::clearHTTPReferrer):
       
 17419         (WebCore::ResourceRequestBase::httpUserAgent):
       
 17420         (WebCore::ResourceRequestBase::setHTTPUserAgent):
       
 17421         (WebCore::ResourceRequestBase::httpAccept):
       
 17422         (WebCore::ResourceRequestBase::setHTTPAccept):
       
 17423         (WebCore::ResourceRequestBase::ResourceRequestBase):
       
 17424         (WebCore::operator!=):
       
 17425         * platform/network/cf/ResourceRequest.h: Added.
       
 17426         (WebCore::ResourceRequest::ResourceRequest):
       
 17427         * platform/network/curl/ResourceRequest.h: Added.
       
 17428         (WebCore::ResourceRequest::ResourceRequest):
       
 17429         (WebCore::ResourceRequest::doUpdatePlatformRequest):
       
 17430         (WebCore::ResourceRequest::doUpdateResourceRequest):
       
 17431         * platform/network/mac/ResourceRequest.h: Added.
       
 17432         (WebCore::ResourceRequest::ResourceRequest):
       
 17433         * platform/network/qt/ResourceRequest.h: Added.
       
 17434         (WebCore::ResourceRequest::ResourceRequest):
       
 17435         (WebCore::ResourceRequest::doUpdatePlatformRequest):
       
 17436         (WebCore::ResourceRequest::doUpdateResourceRequest):
       
 17437 
       
 17438 2007-06-26  Adam Roben  <aroben@apple.com>
       
 17439 
       
 17440         Add ChangeLog entries from the Windows merge.
       
 17441 
       
 17442         Reviewed by Maciej.
       
 17443 
       
 17444         * ChangeLog:
       
 17445 
       
 17446 2007-06-26  Sam Weinig  <sam@webkit.org>
       
 17447 
       
 17448         Reviewed by Maciej.
       
 17449 
       
 17450         Make sure not to enumerate the toString() function.
       
 17451         <rdar://problem/5297118>
       
 17452 
       
 17453         * bindings/js/kjs_window.cpp:
       
 17454         * bindings/scripts/CodeGeneratorJS.pm: Add support for [DontEnum].
       
 17455         * html/HTMLAnchorElement.idl:
       
 17456 
       
 17457 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
       
 17458 
       
 17459         Reviewed by Mitz, landed by Anders.
       
 17460 
       
 17461         http://bugs.webkit.org/show_bug.cgi?id=14421
       
 17462         Implement GraphicsContext::clearRect()
       
 17463 
       
 17464         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
 17465         (WebCore::GraphicsContext::clearRect):
       
 17466 
       
 17467 2007-06-26  Alp Toker  <alp.toker@collabora.co.uk>
       
 17468 
       
 17469         Reviewed and landed by Anders.
       
 17470 
       
 17471         http://bugs.webkit.org/show_bug.cgi?id=14416
       
 17472         Content does not render fully in some cases
       
 17473 
       
 17474         Fix mismatched calls to cairo_save/restore due to an early method return.
       
 17475 
       
 17476         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
 17477         (WebCore::GraphicsContext::drawLine):
       
 17478 
       
 17479 2007-06-26  Tristan O'Tierney  <tristan@apple.com>
       
 17480 
       
 17481         Reviewed by John Sullivan.
       
 17482 
       
 17483         Added two accessor functions for <rdar://problem/4119138>
       
 17484 
       
 17485         * bindings/objc/DOMHTML.mm:
       
 17486         (-[DOMHTMLInputElement _isEdited]):
       
 17487         (-[DOMHTMLTextAreaElement _isEdited]):
       
 17488         Added an accessor to the isEdited value of a DOM node's render object
       
 17489 
       
 17490         * bindings/objc/DOMPrivate.h:
       
 17491         Added header definitions for _isEdited
       
 17492 
       
 17493 2007-06-26  Sam Weinig  <sam@webkit.org>
       
 17494 
       
 17495         Fix Win32 build.
       
 17496 
       
 17497         * WebCore.vcproj/WebCore.vcproj:
       
 17498 
       
 17499 2007-06-26  Sam Weinig  <sam@webkit.org>
       
 17500 
       
 17501         Fix Qt and Gdk builds.
       
 17502 
       
 17503         * WebCore.pro:
       
 17504 
       
 17505 2007-06-26  Sam Weinig  <sam@webkit.org>
       
 17506 
       
 17507         Reviewed by Geoff.
       
 17508 
       
 17509         Patch for http://bugs.webkit.org/show_bug.cgi?id=14111
       
 17510         Autogenerate Event JS binding
       
 17511 
       
 17512         - Moves the dataTransfer method into MouseEvent where it should be.
       
 17513 
       
 17514         * WebCore.xcodeproj/project.pbxproj:
       
 17515         * bindings/js/JSEventCustom.cpp: Added.
       
 17516         (WebCore::JSEvent::clipboardData):
       
 17517         (WebCore::toJS):
       
 17518         * bindings/js/JSEventTargetNode.cpp:
       
 17519         * bindings/js/JSXMLHttpRequest.cpp:
       
 17520         * bindings/js/kjs_events.cpp:
       
 17521         * bindings/js/kjs_events.h:
       
 17522         * bindings/objc/DOMUtility.mm:
       
 17523         (KJS::createDOMWrapper):
       
 17524         * bindings/scripts/CodeGeneratorJS.pm:
       
 17525         * dom/Event.h:
       
 17526         (WebCore::Event::returnValue):
       
 17527         (WebCore::Event::setReturnValue):
       
 17528         (WebCore::Event::clipboardData):
       
 17529         * dom/Event.idl:
       
 17530         * dom/MouseEvent.h:
       
 17531         (WebCore::MouseEvent::dataTransfer):
       
 17532         * dom/MouseEvent.idl:
       
 17533 
       
 17534 2007-06-26  Timothy Hatcher  <timothy@apple.com>
       
 17535 
       
 17536         Reviewed by Mark Rowe.
       
 17537 
       
 17538         Follow up fix for: Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
       
 17539         http://bugs.webkit.org/show_bug.cgi?id=14385
       
 17540 
       
 17541         Correctly remember the "Show implicit properties" setting as you switch nodes.
       
 17542 
       
 17543         * page/inspector/ResourcePanel.js:
       
 17544 
       
 17545 2007-06-26  Justin Garcia  <justin.garcia@apple.com>
       
 17546 
       
 17547         Reviewed by John.
       
 17548 
       
 17549         <rdar://problem/5290534> Crash at RenderTextControl::calcHeight() after deleting text in a search field
       
 17550         
       
 17551         Editing removed a node that was part of a search field's internal
       
 17552         structure that should not be removed.
       
 17553 
       
 17554         * editing/DeleteSelectionCommand.cpp:
       
 17555         (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the
       
 17556         selection to delete ends at [container, x], where x is the number
       
 17557         of children in container, don't remove container.  Special case
       
 17558         code elsewhere in this function will remove it if necessary.
       
 17559 
       
 17560 2007-06-25  Sam Weinig  <sam@webkit.org>
       
 17561 
       
 17562         Reviewed by Maciej.
       
 17563 
       
 17564         Patch for http://bugs.webkit.org/show_bug.cgi?id=11315
       
 17565         Mutating document.constructor.prototype mutates Object.prototype
       
 17566 
       
 17567         Test: fast/js/constructor.html
       
 17568 
       
 17569         * bindings/scripts/CodeGeneratorJS.pm: add constructor attribute to
       
 17570         classes with constructors.  It is an non-enumeratable, non-deletable,
       
 17571         readonly attribute.
       
 17572 
       
 17573 2007-06-26  George Staikos  <staikos@kde.org>
       
 17574 
       
 17575         Repair the OS X build.
       
 17576 
       
 17577         * WebCore.exp:
       
 17578 
       
 17579 2007-06-26  Adam Treat  <adam@staikos.net>
       
 17580 
       
 17581         Reviewed by Adam Roben.
       
 17582 
       
 17583         Make the SQLite icon database optional.
       
 17584 
       
 17585         * loader/icon/IconDatabase.cpp:
       
 17586         (WebCore::IconDatabase::isOpen):
       
 17587         (WebCore::IconDatabase::isPrivateBrowsingEnabled):
       
 17588         (WebCore::IconDatabase::enabled):
       
 17589         * loader/icon/IconDatabase.h:
       
 17590 
       
 17591 2007-06-25  Sam Weinig  <sam@webkit.org>
       
 17592 
       
 17593         Reviewed by Adam Roben.
       
 17594 
       
 17595         Patch for http://bugs.webkit.org/show_bug.cgi?id=14369
       
 17596         HTML syntax highlighting colors and DOM tree colors should be the same
       
 17597 
       
 17598         * css/view-source.css:
       
 17599         * page/inspector/ResourcePanel.js:
       
 17600         * page/inspector/inspector.css:
       
 17601         * page/inspector/inspector.js:
       
 17602         * page/inspector/utilities.js:
       
 17603 
       
 17604 2007-06-25  Adam Roben  <aroben@apple.com>
       
 17605 
       
 17606         Fix Bug 14402: Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari"
       
 17607         http://bugs.webkit.org/show_bug.cgi?id=14402
       
 17608 
       
 17609         The solution was to make KURL::lastPathComponent ignore trailing
       
 17610         slashes, which is what -[NSURL lastPathComponent] does, too.
       
 17611 
       
 17612         Reviewed by Oliver.
       
 17613 
       
 17614         * platform/KURL.cpp:
       
 17615         (WebCore::KURL::lastPathComponent):
       
 17616 
       
 17617 2007-06-25  Sam Weinig  <sam@webkit.org>
       
 17618 
       
 17619         Reviewed by Adam Roben.
       
 17620 
       
 17621         Patch for http://bugs.webkit.org/show_bug.cgi?id=14257
       
 17622         Web Inspector lists favicon.ico as "other" instead of "image"
       
 17623 
       
 17624         * page/InspectorController.cpp:
       
 17625         (WebCore::InspectorResource::type):
       
 17626 
       
 17627 2007-06-25  Adele Peterson  <adele@apple.com>
       
 17628 
       
 17629         Reviewed by Hyatt.
       
 17630 
       
 17631         Fix for <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
       
 17632         http://bugs.webkit.org/show_bug.cgi?id=14297
       
 17633 
       
 17634         Test: fast/overflow/hidden-scrollbar-resize.html
       
 17635 
       
 17636         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
       
 17637         Updated our shouldPaint check to consider visibility.
       
 17638 
       
 17639 2007-06-25  Oliver Hunt  <oliver@apple.com>
       
 17640 
       
 17641         Reviewed by Darin.
       
 17642 
       
 17643         <rdar://problem/5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info
       
 17644 
       
 17645         Fixing logic error in DragController
       
 17646 
       
 17647         * manual-tests/drop-text-acquires-style.html: Added.
       
 17648         * page/DragController.cpp:
       
 17649         (WebCore::documentFragmentFromDragData):
       
 17650 
       
 17651 2007-06-25  Sam Weinig  <sam@webkit.org>
       
 17652 
       
 17653         Reviewed by Adam Roben.
       
 17654 
       
 17655         Annotate prototypes by adding "Prototype" subtitle.
       
 17656 
       
 17657         * page/inspector/ResourcePanel.js:
       
 17658 
       
 17659 2007-06-25  George Staikos  <staikos@kde.org>
       
 17660 
       
 17661         Reviewed by Zack.
       
 17662 
       
 17663         Start to add proxy and SSL support to WebKitQt.  Proxying works.
       
 17664 
       
 17665         * platform/network/ResourceHandleInternal.h:
       
 17666         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
       
 17667         * platform/network/qt/ResourceHandleQt.cpp:
       
 17668         (WebCore::ResourceHandle::start):
       
 17669 
       
 17670 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
       
 17671 
       
 17672         Reviewed by Adam Roben.
       
 17673 
       
 17674         http://bugs.webkit.org/show_bug.cgi?id=14386
       
 17675         Gdk build fix
       
 17676 
       
 17677         * WebCore.pro: Fix gtk/gdk typo.
       
 17678 
       
 17679 2007-06-25  Timothy Hatcher  <timothy@apple.com>
       
 17680 
       
 17681         Reviewed by Anders.
       
 17682 
       
 17683         Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
       
 17684         http://bugs.webkit.org/show_bug.cgi?id=14385
       
 17685 
       
 17686         Add a toggle to show implict computed properties.
       
 17687 
       
 17688         * page/inspector/ResourcePanel.js:
       
 17689         * page/inspector/inspector.css:
       
 17690         * page/inspector/inspector.js:
       
 17691 
       
 17692 2007-06-25  Alp Toker  <alp.toker@collabora.co.uk>
       
 17693 
       
 17694         Reviewed by Mark.
       
 17695 
       
 17696         http://bugs.webkit.org/show_bug.cgi?id=13975
       
 17697         Use system-provided libjpeg and libpng
       
 17698 
       
 17699         * WebCore.pro: Remove bundled libjpeg and libpng sources.
       
 17700         * platform/image-decoders/jpeg: Remove sources.
       
 17701         * platform/image-decoders/png: Remove sources.
       
 17702 
       
 17703 2007-06-25  Mitz Pettel  <mitz@webkit.org>
       
 17704 
       
 17705         Reviewed by Darin.
       
 17706 
       
 17707         - fix http://bugs.webkit.org/show_bug.cgi?id=14202
       
 17708           Table caption renders too narrow sometimes
       
 17709 
       
 17710         Test: fast/table/caption-relayout.html
       
 17711 
       
 17712         * rendering/RenderTable.cpp:
       
 17713         (WebCore::RenderTable::layout): Mark the caption for layout if the table
       
 17714         width changed.
       
 17715 
       
 17716 2007-06-25  Mitz Pettel  <mitz@webkit.org>
       
 17717 
       
 17718         Reviewed by Darin.
       
 17719 
       
 17720         - fix http://bugs.webkit.org/show_bug.cgi?id=14245
       
 17721           Underline painted under <br>, not repainted properly
       
 17722 
       
 17723         Test: fast/inline/br-text-decoration.html
       
 17724 
       
 17725         * platform/graphics/cg/GraphicsContextCG.cpp:
       
 17726         (WebCore::GraphicsContext::drawLineForText): Added an early return if the line width
       
 17727         is zero. Also changed the line stroke to a rect fill, so that lines with length shorter
       
 17728         than their thickness paint correctly.
       
 17729 
       
 17730 2007-06-25  Mitz Pettel  <mitz@webkit.org>
       
 17731 
       
 17732         Reviewed by Maciej.
       
 17733 
       
 17734         - fix http://bugs.webkit.org/show_bug.cgi?id=14341
       
 17735           rules="none" ignored in certain cases
       
 17736 
       
 17737         Covered by existing tests.
       
 17738 
       
 17739         * html/HTMLTableElement.cpp:
       
 17740         (WebCore::HTMLTableElement::getSharedCellDecl):
       
 17741 
       
 17742 2007-06-24  Sam Weinig  <sam@webkit.org>
       
 17743 
       
 17744         Reviewed by Mitz.
       
 17745 
       
 17746         Patch for http://bugs.webkit.org/show_bug.cgi?id=14379
       
 17747         Anchor elements show up as their href in the properties pane, not HTMLAnchorElement
       
 17748 
       
 17749         * page/inspector/ResourcePanel.js: make sure not to call an overriden
       
 17750         toString() by using Object.prototype.toString.call().
       
 17751 
       
 17752 2007-06-24  Adam Roben  <aroben@apple.com>
       
 17753 
       
 17754         Fix http://bugs.webkit.org/show_bug.cgi?id=14374
       
 17755         Bug 14374: Computed Style section should be expanded by default
       
 17756 
       
 17757         Reviewed by Sam.
       
 17758 
       
 17759         No regression test possible.
       
 17760 
       
 17761         * page/inspector/ResourcePanel.js: Expand all style sections.
       
 17762 
       
 17763 2007-06-24  Adam Roben  <aroben@apple.com>
       
 17764 
       
 17765         Unify the style of enums in the Inspector JS
       
 17766 
       
 17767         All our enums are now represented by an object with a property for
       
 17768         each enum value.
       
 17769 
       
 17770         Reviewed by Sam.
       
 17771 
       
 17772         No regression test possible.
       
 17773 
       
 17774         * page/inspector/ConsolePanel.js:
       
 17775         * page/inspector/Resource.js:
       
 17776         * page/inspector/ResourcePanel.js:
       
 17777         * page/inspector/inspector.js:
       
 17778 
       
 17779 2007-06-23  Sam Weinig  <sam@webkit.org>
       
 17780 
       
 17781         Reviewed by Mitz.
       
 17782 
       
 17783         Patch for http://bugs.webkit.org/show_bug.cgi?id=14321
       
 17784         getComputedStyle(...).zIndex returns string "normal"
       
 17785 
       
 17786         Test: fast/css/getComputedStyle-zIndex-auto.html
       
 17787 
       
 17788         * css/CSSComputedStyleDeclaration.cpp:
       
 17789         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return 'auto' instead of 'normal'.
       
 17790 
       
 17791 2007-06-24  Matt Lilek  <pewtermoose@gmail.com>
       
 17792 
       
 17793         Reviewed by Tim Hatcher.
       
 17794 
       
 17795         Bug 14265: Cannot resize columns in webinspector
       
 17796         http://bugs.webkit.org/show_bug.cgi?id=14265
       
 17797 
       
 17798         * page/inspector/inspector.css:
       
 17799         * page/inspector/inspector.html:
       
 17800         * page/inspector/inspector.js:
       
 17801 
       
 17802 2007-06-23  Adam Roben  <aroben@apple.com>
       
 17803 
       
 17804         Silence a build warning about not finding `num-cpus`
       
 17805 
       
 17806         Reviewed by Mark Rowe.
       
 17807 
       
 17808         * WebCore.vcproj/build-generated-files.sh: Look for num-cpus in its new
       
 17809         location.
       
 17810 
       
 17811 2007-06-22  Anders Carlsson  <andersca@apple.com>
       
 17812 
       
 17813         Reviewed by Darin.
       
 17814 
       
 17815         * plugins/win/PluginStreamWin.cpp:
       
 17816         (WebCore::PluginStreamWin::didFinishLoading):
       
 17817         No need to fetch the size from resourceData.
       
 17818 
       
 17819 2007-06-22  Anders Carlsson  <andersca@apple.com>
       
 17820 
       
 17821         Reviewed by Darin.
       
 17822 
       
 17823         <rdar://problem/5288617>
       
 17824         Crash playing a very large QuickTime movie inside Safari.
       
 17825 
       
 17826         Get rid of m_completeDeliveryData and use the loader's resource data instead. This reduces the memory usage for 
       
 17827         plug-ins which loads large files and use a transfer mode of NP_ASFILE or NP_ASFILEONLY.
       
 17828         
       
 17829         * plugins/win/PluginStreamWin.cpp:
       
 17830         (WebCore::PluginStreamWin::PluginStreamWin):
       
 17831         (WebCore::PluginStreamWin::~PluginStreamWin):
       
 17832         (WebCore::PluginStreamWin::didReceiveData):
       
 17833         (WebCore::PluginStreamWin::didFinishLoading):
       
 17834         * plugins/win/PluginStreamWin.h:
       
 17835 
       
 17836 2007-06-22  Beth Dakin  <bdakin@apple.com>
       
 17837 
       
 17838         Reviewed by Oliver and Darin.
       
 17839 
       
 17840         Fix for <rdar://problem/5266999> Loading page from MangleMe fuzz 
       
 17841         tester crashes in RenderTableRow::addChild (giant ROWSPAN)
       
 17842 
       
 17843         We already have code that tries to prevent allocating too-large 
       
 17844         rowspans. The rowspan in this test, however, was small enough that 
       
 17845         we thought it was okay in that code, even though clearly it was 
       
 17846         still too large. I did a bunch of testing in Firefox, and it seems 
       
 17847         that they set a hard limit on the maximum rowspan right in the DOM 
       
 17848         -- 8k. So that is what this patch implements. 
       
 17849 
       
 17850         * html/HTMLTableCellElement.cpp:
       
 17851         (WebCore::HTMLTableCellElement::parseMappedAttribute):
       
 17852 
       
 17853 2007-06-22  Justin Garcia  <justin.garcia@apple.com>
       
 17854 
       
 17855         Reviewed by Darin.
       
 17856         
       
 17857         <rdar://problem/5272440> Adding To Do via Note received in e-mail adds newlines on delete
       
 17858         
       
 17859         Deletion inserts a placeholder after it removes full paragraphs if
       
 17860         one doesn't already exist.  The code that looked for a pre-existing
       
 17861         placeholder didn't work because of a bug in enclosingNodeOfType.
       
 17862 
       
 17863         * editing/htmlediting.cpp:
       
 17864         (WebCore::enclosingNodeOfType): We start looking at node->parentNode(),
       
 17865         but don't go above an editing root.
       
 17866 
       
 17867 2007-06-22  Anders Carlsson  <andersca@apple.com>
       
 17868 
       
 17869         Reviewed by Maciej and Geoff.
       
 17870 
       
 17871         <rdar://problem/5244734>
       
 17872         WebKit shouldn't send delegate resource load methods for the user stylesheet (doing so causes assertions in Safari)
       
 17873         
       
 17874         Add a sendResourceLoadCallbacks argument to the ResourceLoader and only send resource load callbacks if it's true. Make it so that
       
 17875         loading the user style sheet creates a resource loader with sendResourceLoadCallbacks set to false (done by adding a sendResourceLoadCallbacks 
       
 17876         argument to a bunch of classes).
       
 17877         
       
 17878         * loader/Cache.cpp:
       
 17879         (WebCore::createResource):
       
 17880         (WebCore::Cache::requestResource):
       
 17881         * loader/Cache.h:
       
 17882         * loader/CachedCSSStyleSheet.cpp:
       
 17883         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
       
 17884         * loader/CachedCSSStyleSheet.h:
       
 17885         * loader/CachedResource.cpp:
       
 17886         (WebCore::CachedResource::CachedResource):
       
 17887         * loader/CachedResource.h:
       
 17888         (WebCore::CachedResource::sendResourceLoadCallbacks):
       
 17889         * loader/DocLoader.cpp:
       
 17890         (WebCore::DocLoader::requestCSSStyleSheet):
       
 17891         (WebCore::DocLoader::requestResource):
       
 17892         (WebCore::DocLoader::checkCacheObjectStatus):
       
 17893         * loader/DocLoader.h:
       
 17894         * loader/MainResourceLoader.cpp:
       
 17895         (WebCore::MainResourceLoader::MainResourceLoader):
       
 17896         * loader/Request.cpp:
       
 17897         (WebCore::Request::Request):
       
 17898         * loader/Request.h:
       
 17899         (WebCore::Request::sendResourceLoadCallbacks):
       
 17900         * loader/ResourceLoader.cpp:
       
 17901         (WebCore::ResourceLoader::ResourceLoader):
       
 17902         (WebCore::ResourceLoader::willSendRequest):
       
 17903         (WebCore::ResourceLoader::didReceiveResponse):
       
 17904         (WebCore::ResourceLoader::didReceiveData):
       
 17905         (WebCore::ResourceLoader::didFinishLoadingOnePart):
       
 17906         (WebCore::ResourceLoader::didFail):
       
 17907         (WebCore::ResourceLoader::didCancel):
       
 17908         * loader/ResourceLoader.h:
       
 17909         (WebCore::ResourceLoader::sendResourceLoadCallbacks):
       
 17910         * loader/SubresourceLoader.cpp:
       
 17911         (WebCore::SubresourceLoader::SubresourceLoader):
       
 17912         (WebCore::SubresourceLoader::create):
       
 17913         * loader/SubresourceLoader.h:
       
 17914         * loader/loader.cpp:
       
 17915         (WebCore::Loader::load):
       
 17916         (WebCore::Loader::servePendingRequests):
       
 17917         * loader/loader.h:
       
 17918         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
       
 17919         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
       
 17920 
       
 17921 2007-06-21  Richard Connamacher  <rich@indieimage.com>
       
 17922 
       
 17923         Reviewed by Tim Hatcher.
       
 17924 
       
 17925         Bug 14305: Web Inspector marks local files with server-side compression tip
       
 17926         http://bugs.webkit.org/show_bug.cgi?id=14305
       
 17927 
       
 17928         * page/inspector/Resource.js:
       
 17929         (WebInspector.Resource._shouldCompress): Prevent server-side compression tip
       
 17930         from being given to local files
       
 17931 
       
 17932 2007-06-21  Mark Rowe  <mrowe@apple.com>
       
 17933 
       
 17934         Reviewed by Darin.
       
 17935 
       
 17936         Fix for <rdar://problem/5266928> REGRESSION: crash/assert failure beneath RenderFrameSet::layOutAxis when loading
       
 17937 
       
 17938         * platform/StringImpl.cpp:
       
 17939         (WebCore::StringImpl::toLengthArray): Simplify whitespace before checking for an empty string.  This avoids returning
       
 17940         a length of zero when the string is collapsed to empty by whitespace simplification.
       
 17941 
       
 17942 2007-06-21  Dave Hyatt  <hyatt@apple.com>
       
 17943 
       
 17944         Fix for <rdar://problem/5286978>, large font sizes crash Windows.
       
 17945         
       
 17946         Limit the maximum font size to 1,000,000 to avoid crashes and issues with platforms that
       
 17947         start failing to do anything useful if the font size is too big.
       
 17948         
       
 17949         Reviewed by olliej
       
 17950 
       
 17951         * css/cssstyleselector.cpp:
       
 17952         (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
       
 17953         
       
 17954 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
       
 17955 
       
 17956         Reviewed by Timothy.
       
 17957 
       
 17958         Stop shift+scroll wheel performing a horizontal scroll in Web Inspector
       
 17959 
       
 17960         * page/inspector/inspector.css: Set body margin to 0
       
 17961 
       
 17962 2007-06-21  Adam Treat  <adam@staikos.net>
       
 17963 
       
 17964         Reviewed by George Staikos.
       
 17965 
       
 17966         Implement the default resources on Qt.
       
 17967 
       
 17968         * platform/graphics/BitmapImage.h:
       
 17969         * platform/graphics/Image.h:
       
 17970         * platform/graphics/qt/ImageQt.cpp:
       
 17971         (WebCore::Image::loadPlatformResource):
       
 17972         (WebCore::BitmapImage::BitmapImage):
       
 17973         (WebCore::BitmapImage::initPlatformData):
       
 17974         (WebCore::BitmapImage::invalidatePlatformData):
       
 17975         (WebCore::BitmapImage::getPixmap):
       
 17976         * platform/qt/TemporaryLinkStubs.cpp:
       
 17977 
       
 17978 2007-06-21  Oliver Hunt  <oliver@apple.com>
       
 17979 
       
 17980         Reviewed by Darin.
       
 17981 
       
 17982         Use RetainPtr for holding currentEvent.  This removes explicit HardRetain/Release calls
       
 17983         and makes reference handling simpler in advance of IME refactoring.
       
 17984 
       
 17985         * WebCore.xcodeproj/project.pbxproj:
       
 17986         * page/mac/EventHandlerMac.mm:
       
 17987         (WebCore::currentEvent):
       
 17988         (WebCore::EventHandler::currentNSEvent):
       
 17989         (WebCore::EventHandler::wheelEvent):
       
 17990         (WebCore::EventHandler::keyEvent):
       
 17991         (WebCore::lastEventIsMouseUp):
       
 17992         (WebCore::EventHandler::passMouseDownEventToWidget):
       
 17993         (WebCore::EventHandler::eventLoopHandleMouseDragged):
       
 17994         (WebCore::EventHandler::eventLoopHandleMouseUp):
       
 17995         (WebCore::EventHandler::passSubframeEventToSubframe):
       
 17996         (WebCore::EventHandler::passWheelEventToWidget):
       
 17997         (WebCore::EventHandler::mouseDown):
       
 17998         (WebCore::EventHandler::mouseDragged):
       
 17999         (WebCore::EventHandler::mouseUp):
       
 18000         (WebCore::EventHandler::mouseMoved):
       
 18001 
       
 18002 2007-06-21  George Staikos  <staikos@kde.org>
       
 18003 
       
 18004         Reviewed by George & Marius.
       
 18005 
       
 18006         Patch by me, revision by Marius, minor rev by me.  Adds rendered
       
 18007         and stylable scrollbars.
       
 18008 
       
 18009         * page/qt/EventHandlerQt.cpp:
       
 18010         (WebCore::EventHandler::passMousePressEventToScrollbar):
       
 18011         * platform/Widget.h:
       
 18012         * platform/qt/PlatformScrollBar.h:
       
 18013         (WebCore::PlatformScrollbar::isWidget):
       
 18014         * platform/qt/PlatformScrollBarQt.cpp:
       
 18015         (WebCore::PlatformScrollbar::PlatformScrollbar):
       
 18016         (WebCore::PlatformScrollbar::~PlatformScrollbar):
       
 18017         (WebCore::PlatformScrollbar::updateThumbPosition):
       
 18018         (WebCore::PlatformScrollbar::updateThumbProportion):
       
 18019         (WebCore::PlatformScrollbar::width):
       
 18020         (WebCore::PlatformScrollbar::height):
       
 18021         (WebCore::PlatformScrollbar::setRect):
       
 18022         (WebCore::PlatformScrollbar::isEnabled):
       
 18023         (WebCore::PlatformScrollbar::setEnabled):
       
 18024         (WebCore::PlatformScrollbar::paint):
       
 18025         (WebCore::PlatformScrollbar::thumbPosition):
       
 18026         (WebCore::PlatformScrollbar::thumbLength):
       
 18027         (WebCore::PlatformScrollbar::trackLength):
       
 18028         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
       
 18029         (WebCore::PlatformScrollbar::handleMouseOutEvent):
       
 18030         (WebCore::PlatformScrollbar::handleMousePressEvent):
       
 18031         (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
       
 18032         (WebCore::PlatformScrollbar::startTimerIfNeeded):
       
 18033         (WebCore::PlatformScrollbar::stopTimerIfNeeded):
       
 18034         (WebCore::PlatformScrollbar::autoscrollPressedPart):
       
 18035         (WebCore::PlatformScrollbar::autoscrollTimerFired):
       
 18036         (WebCore::PlatformScrollbar::pressedPartScrollDirection):
       
 18037         (WebCore::PlatformScrollbar::pressedPartScrollGranularity):
       
 18038         (WebCore::PlatformScrollbar::thumbUnderMouse):
       
 18039         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
       
 18040         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
       
 18041         (WebCore::PlatformScrollbar::windowClipRect):
       
 18042         * platform/qt/ScrollViewQt.cpp:
       
 18043         (WebCore::ScrollView::addChild):
       
 18044         (WebCore::ScrollView::removeChild):
       
 18045         * platform/qt/WidgetQt.cpp:
       
 18046         (WebCore::WidgetPrivate::WidgetPrivate):
       
 18047         (WebCore::Widget::setQWidget):
       
 18048         (WebCore::Widget::invalidate):
       
 18049         (WebCore::Widget::invalidateRect):
       
 18050         (WebCore::Widget::setParent):
       
 18051         (WebCore::Widget::parent):
       
 18052 
       
 18053 2007-06-21  Geoffrey Garen  <ggaren@apple.com>
       
 18054 
       
 18055         Reviewed by Dave Hyatt.
       
 18056         
       
 18057         Fixed <rdar://problem/4977124> | http://bugs.webkit.org/show_bug.cgi?id=12646
       
 18058         REGRESSION: RapidWeaver's "Hello" HTML page doesn't display any DHTML 
       
 18059         effects when clicking on its links (12646)
       
 18060         
       
 18061         I'm rolling our r7703 for these reasons:
       
 18062 
       
 18063         1. It broke RapidWeaver.
       
 18064         
       
 18065         2. WebKit is now orders of magnitude faster when handling deep nesting
       
 18066         (5 seconds vs 3 minutes on my MBP in this particular case).
       
 18067 
       
 18068         3. Firefox, IE, and HTML5 all allow nested heading tags.
       
 18069         
       
 18070         4. Hyatt said so.
       
 18071 
       
 18072         * html/HTMLParser.cpp:
       
 18073         (WebCore::HTMLParser::parseToken):
       
 18074 
       
 18075 2007-06-21  Sam Weinig  <sam@webkit.org>
       
 18076 
       
 18077         Reviewed by Tim Hatcher.
       
 18078 
       
 18079         http://bugs.webkit.org/show_bug.cgi?id=14260
       
 18080         ASSERTION FAILED: m_mainResource->loader == loader going back in history on any page
       
 18081 
       
 18082         Remove assert for now as it is causing the back button to not
       
 18083         work in debug builds.
       
 18084 
       
 18085         * page/InspectorController.cpp:
       
 18086         (WebCore::InspectorController::didCommitLoad):
       
 18087 
       
 18088 2007-06-21  Lars Knoll <lars@trolltech.com>
       
 18089 
       
 18090         Remove some debug output.
       
 18091 
       
 18092         * platform/qt/FontQt.cpp:
       
 18093         (WebCore::generateComponents):
       
 18094         (WebCore::Font::width):
       
 18095 
       
 18096 2007-06-21  George Staikos  <staikos@kde.org>
       
 18097 
       
 18098         Repair Qt/Mac OS X build.
       
 18099 
       
 18100         * WebCore.pro:
       
 18101 
       
 18102 2007-06-21  Alexey Proskuryakov  <ap@webkit.org>
       
 18103 
       
 18104         Reviewed by Anders.
       
 18105 
       
 18106         http://bugs.webkit.org/show_bug.cgi?id=13905
       
 18107         REGRESSION: A Chinese dictionary widget has a problem with XMLHttpRequest response encoding
       
 18108 
       
 18109         Tiger WebKit accidentally looked at HTML Http-Equiv META to determine the response encoding
       
 18110         (regardless of the actual response MIME type). This was corrected a while ago to match other 
       
 18111         browsers and the draft XHR spec.
       
 18112 
       
 18113         Now restoring this functionality for "text/html", with spec editor's blessing.
       
 18114 
       
 18115         * xml/xmlhttprequest.cpp:
       
 18116         (WebCore::XMLHttpRequest::responseMIMEType):
       
 18117         (WebCore::XMLHttpRequest::responseIsXML):
       
 18118         (WebCore::XMLHttpRequest::didReceiveData):
       
 18119         * xml/xmlhttprequest.h:
       
 18120 
       
 18121 2007-06-21  Andrew Wellington  <proton@wiretapped.net>
       
 18122 
       
 18123         Mac build fix.
       
 18124 
       
 18125         * platform/Font.h:
       
 18126 
       
 18127 2007-06-21  Lars Knoll  <lars@trolltech.com>
       
 18128 
       
 18129         Reviewed by Simon.
       
 18130 
       
 18131         another small fix for letter spacing
       
 18132 
       
 18133         * platform/qt/FontQt.cpp:
       
 18134         (WebCore::generateComponents):
       
 18135 
       
 18136 2007-06-21  Lars Knoll  <lars@trolltech.com>
       
 18137 
       
 18138         Reviewed by Simon.
       
 18139 
       
 18140         fix word-spacing
       
 18141 
       
 18142         * platform/qt/FontQt.cpp:
       
 18143         (WebCore::generateComponents):
       
 18144         (WebCore::Font::width):
       
 18145 
       
 18146 2007-06-21  Lars Knoll  <lars@trolltech.com>
       
 18147 
       
 18148         Reviewed by Simon.
       
 18149 
       
 18150         fix letterspacing and small caps.
       
 18151 
       
 18152         * platform/Font.h:
       
 18153         * platform/graphics/qt/GraphicsContextQt.cpp:
       
 18154         (WebCore::GraphicsContext::setPlatformFont):
       
 18155         * platform/qt/FileChooserQt.cpp:
       
 18156         * platform/qt/FontQt.cpp:
       
 18157         (WebCore::TextRunComponent::TextRunComponent):
       
 18158         (WebCore::Font::Font):
       
 18159         (WebCore::Font::operator=):
       
 18160         (WebCore::Font::update):
       
 18161         (WebCore::generateComponents):
       
 18162         (WebCore::Font::selectionRectForText):
       
 18163         * platform/qt/RenderThemeQt.cpp:
       
 18164 
       
 18165 2007-06-21  Lars Knoll  <lars@trolltech.com>
       
 18166 
       
 18167         Reviewed by Simon.
       
 18168 
       
 18169         store the metrics and space width in the Font object
       
 18170 
       
 18171         * platform/Font.h:
       
 18172         * platform/qt/FontQt.cpp:
       
 18173         (WebCore::Font::Font):
       
 18174         (WebCore::Font::drawText):
       
 18175         (WebCore::Font::width):
       
 18176         (WebCore::Font::isFixedPitch):
       
 18177         (WebCore::Font::ascent):
       
 18178         (WebCore::Font::descent):
       
 18179         (WebCore::Font::lineSpacing):
       
 18180 
       
 18181 2007-06-21  Lars Knoll  <lars@trolltech.com>
       
 18182 
       
 18183         Reviewed by Simon.
       
 18184 
       
 18185         simplify some codepaths
       
 18186 
       
 18187         * platform/qt/FontQt.cpp:
       
 18188         (WebCore::Font::drawText):
       
 18189         (WebCore::Font::width):
       
 18190 
       
 18191 2007-06-21  Lars Knoll  <lars@trolltech.com>
       
 18192 
       
 18193         Reviewed by Simon.
       
 18194 
       
 18195         fix copyright header
       
 18196 
       
 18197         * platform/qt/FontQt.cpp:
       
 18198 
       
 18199 2007-06-21  Lars Knoll  <lars@trolltech.com>
       
 18200 
       
 18201         Reviewed by Simon.
       
 18202 
       
 18203         correctly load fonts when a list of font families is given
       
 18204 
       
 18205         * platform/qt/FontQt.cpp:
       
 18206         (WebCore::Font::Font):
       
 18207 
       
 18208 2007-06-21  Lars Knoll  <lars@trolltech.com>
       
 18209 
       
 18210         Reviewed by Simon.
       
 18211 
       
 18212         fix some more of the font support
       
 18213 
       
 18214         * platform/qt/FontQt.cpp:
       
 18215         (WebCore::Font::drawText):
       
 18216         (WebCore::Font::width):
       
 18217 
       
 18218 2007-06-21  Lars Knoll  <lars@trolltech.com>
       
 18219 
       
 18220         Reviewed by Simon.
       
 18221 
       
 18222         Compile fixes
       
 18223 
       
 18224         * platform/Font.h:
       
 18225         (WebCore::Font::isRoundingHackCharacter):
       
 18226         * platform/qt/FontQt.cpp:
       
 18227         (WebCore::Font::drawText):
       
 18228 
       
 18229 2007-06-21  Lars Knoll  <lars@trolltech.com>
       
 18230 
       
 18231         Reviewed by Simon.
       
 18232 
       
 18233         Some more work on the implementation of FontQt.
       
 18234 
       
 18235         * platform/qt/FontQt.cpp:
       
 18236         (WebCore::Font::Font):
       
 18237         (WebCore::Font::~Font):
       
 18238         (WebCore::Font::operator=):
       
 18239 
       
 18240 2007-06-21  Lars Knoll  <lars@trolltech.com>
       
 18241 
       
 18242         Reviewed by Simon.
       
 18243 
       
 18244         Started work on the new font infrastructure for the Qt port.
       
 18245 
       
 18246         * WebCore.pro:
       
 18247         * editing/Editor.cpp:
       
 18248         (WebCore::Editor::fontForSelection):
       
 18249         * platform/Font.h:
       
 18250         (WebCore::Font::treatAsSpace):
       
 18251         (WebCore::Font::treatAsZeroWidthSpace):
       
 18252         (WebCore::Font::isRoundingHackCharacter):
       
 18253         * platform/qt/FontQt.cpp:
       
 18254         (WebCore::Font::operator QFont):
       
 18255         * platform/qt/TemporaryLinkStubs.cpp:
       
 18256 
       
 18257 2007-06-21  Adam Roben  <aroben@apple.com>
       
 18258 
       
 18259         More Gdk build fixes.
       
 18260 
       
 18261         * page/gdk/ContextMenuClientGdk.cpp:
       
 18262         (WebCore::ContextMenuClientGdk::shouldIncludeInspectElementItem):
       
 18263         * page/gdk/ContextMenuClientGdk.h:
       
 18264         * platform/gdk/TemporaryLinkStubs.cpp:
       
 18265 
       
 18266 2007-06-21  Adam Roben  <aroben@apple.com>
       
 18267 
       
 18268         Speculative Gdk build fix.
       
 18269 
       
 18270         * page/InspectorController.h: Only include the JS headers we really
       
 18271         need to avoid pulling in ones like JSStringRefCF.h.
       
 18272 
       
 18273 2007-06-20  Adam Roben  <aroben@apple.com>
       
 18274 
       
 18275         Speculative Gdk build fix.
       
 18276 
       
 18277         * WebCore.pro: Don't try to build WebKitQt/Plugins on Gdk.
       
 18278 
       
 18279 2007-06-20  Adam Roben  <aroben@apple.com>
       
 18280 
       
 18281         Windows build fix.
       
 18282 
       
 18283         * WebCore.vcproj/WebCore.vcproj: Include ForwardingHeaders after
       
 18284         everything but $WebKitLibrariesDir so that we will pick up
       
 18285         JavaScriptCore headers directly.
       
 18286 
       
 18287 2007-06-15  George Staikos  <staikos@kde.org>
       
 18288 
       
 18289         Add missing symbol.
       
 18290 
       
 18291         * platform/qt/TemporaryLinkStubs.cpp:
       
 18292         (WebCore::contextMenuItemTagInspectElement):
       
 18293 
       
 18294 2007-06-20  Steve Falkenburg  <sfalken@apple.com>
       
 18295 
       
 18296         Reviewed by Maciej, Anders.
       
 18297         
       
 18298         <rdar://problem/5283789> Crash after dismissing JavaScript alert at end of test on http://lcamtuf.coredump.cx/ierace/
       
 18299 
       
 18300         Keep a reference to the Page (via the main frame) for the
       
 18301         load deferred pages.
       
 18302         
       
 18303         Reference is held via the frame since Page isn't refcounted.
       
 18304 
       
 18305         * page/Chrome.cpp:
       
 18306         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
       
 18307         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
       
 18308 
       
 18309 2007-06-15  Adam Treat <adam@staikos.net>
       
 18310 
       
 18311         Reviewed by George Staikos.
       
 18312 
       
 18313         Add ICO support to the Qt build.
       
 18314 
       
 18315         * WebCore.pro:
       
 18316         * platform/graphics/qt/ImageDecoderQt.cpp:
       
 18317         (Q_IMPORT_PLUGIN):
       
 18318 
       
 18319 2007-06-15  George Staikos  <staikos@kde.org>
       
 18320 
       
 18321         Fixing Qt build.
       
 18322 
       
 18323         * ForwardingHeaders/JavaScriptCore/APICast.h: Added.
       
 18324         * WebCore.pro:
       
 18325         * page/InspectorController.h:
       
 18326 
       
 18327 2007-06-20  Adam Roben  <aroben@apple.com>
       
 18328 
       
 18329         More speculative Qt/Gdk build fixes.
       
 18330 
       
 18331         * WebCore.pro: Add new files.
       
 18332 
       
 18333 2007-06-20  Adam Roben  <aroben@apple.com>
       
 18334 
       
 18335         Speculative Qt/Gdk build fix.
       
 18336 
       
 18337         Added forwarding headers for JavaScriptCore. We may eventually move
       
 18338         InspectorController off of the JSC API, but for now this is the
       
 18339         quickest way to a working build.
       
 18340 
       
 18341         * ForwardingHeaders/JavaScriptCore/JSBase.h: Added.
       
 18342         * ForwardingHeaders/JavaScriptCore/JSContextRef.h: Added.
       
 18343         * ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Added.
       
 18344         * ForwardingHeaders/JavaScriptCore/JSStringRef.h: Added.
       
 18345         * ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Added.
       
 18346         * ForwardingHeaders/JavaScriptCore/JSValueRef.h: Added.
       
 18347         * ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Added.
       
 18348 
       
 18349 2007-06-20  Sam Weinig  <sam@webkit.org>
       
 18350 
       
 18351         Rubber stamped by Adam Roben.
       
 18352 
       
 18353         Add licenses.
       
 18354 
       
 18355         * page/inspector/ConsolePanel.js:
       
 18356         * page/inspector/NetworkPanel.js:
       
 18357         * page/inspector/Resource.js:
       
 18358         * page/inspector/ResourceCategory.js:
       
 18359         * page/inspector/ResourcePanel.js:
       
 18360 
       
 18361 2007-06-20  Mark Rowe  <mrowe@apple.com>
       
 18362 
       
 18363         Reviewed by Adam.
       
 18364 
       
 18365         * WebCore.exp: Export InspectorController::inspect so WebKit can see it.
       
 18366 
       
 18367 2007-06-20  Geoffrey Garen  <ggaren@apple.com>
       
 18368 
       
 18369         Reviewed by Adele Peterson, Oliver Hunt, Anders Carlsson.
       
 18370 
       
 18371         Fixed <rdar://problem/5222911> Leopard9A446 : VitalSource Bookshelf 4.5: 
       
 18372         Crashes when you click on sign in (stringByEvaluatingJavaScriptFromString 
       
 18373         returning nil instead of "")
       
 18374 
       
 18375         I'm basically rolling out the change for <rdar://problem/4782422> because
       
 18376         my testing shows that it was backwards.
       
 18377         
       
 18378         * html/HTMLElement.cpp:
       
 18379         (dumpInnerHTML): New debug-only function to work around gdb being 
       
 18380         perpetually suck-tastic.
       
 18381 
       
 18382         * page/mac/WebCoreFrameBridge.mm:
       
 18383         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
       
 18384         
       
 18385         Return "", not nil. This function never used to return nil, so let's not
       
 18386         start now. I've filed <rdar://problem/5283271> to cover the documentation bug,
       
 18387 
       
 18388 2007-06-20  Adam Roben  <aroben@apple.com>
       
 18389 
       
 18390         Addressed some of Geoff's comments.
       
 18391 
       
 18392         * page/ContextMenuController.cpp:
       
 18393         (WebCore::ContextMenuController::handleContextMenuEvent): Added a
       
 18394         FIXME.
       
 18395         * platform/ContextMenu.cpp:
       
 18396         (WebCore::ContextMenu::addInspectElementItem): Null-check
       
 18397         frame->page().
       
 18398 
       
 18399 2007-06-20  Adam Roben  <aroben@apple.com>
       
 18400 
       
 18401         Fix crash in fast/dom/dir-no-body.html
       
 18402 
       
 18403         Reviewed by Mark.
       
 18404 
       
 18405         * html/HTMLDocument.cpp:
       
 18406         (WebCore::HTMLDocument::createTokenizer): Don't assume we have a
       
 18407         Frame, since we won't if someone creates an HTMLDocument from JS.
       
 18408 
       
 18409 2007-06-20  Adam Roben  <aroben@apple.com>
       
 18410 
       
 18411         Land the new Inspector.
       
 18412 
       
 18413         Co-written with Tim Hatcher.
       
 18414 
       
 18415         Reviewed by Anders, Adele, Hyatt, and Sam.
       
 18416 
       
 18417         No regression tests possible.
       
 18418 
       
 18419         Add a new InspectorController that is in charge of the Inspector. It
       
 18420         has an InspectorClient that controls the Inspector's window and node
       
 18421         highlight.
       
 18422 
       
 18423         * page/InspectorClient.h: Added.
       
 18424         (WebCore::InspectorClient::~InspectorClient):
       
 18425         * page/InspectorController.cpp: Added.
       
 18426         (WebCore::ConsoleMessage::ConsoleMessage):
       
 18427         (WebCore::InspectorResource::): Represents a single resource that the
       
 18428         Inspector knows about.
       
 18429         (WebCore::InspectorResource::InspectorResource):
       
 18430         (WebCore::InspectorResource::~InspectorResource):
       
 18431         (WebCore::InspectorResource::type):
       
 18432         (WebCore::InspectorResource::setScriptObject):
       
 18433         (WebCore::addSourceToFrame): Callback available from JS.
       
 18434         (WebCore::getResourceDocumentNode): Ditto.
       
 18435         (WebCore::highlightDOMNode): Ditto.
       
 18436         (WebCore::hideDOMNodeHighlight): Ditto.
       
 18437         (WebCore::loaded): Ditto.
       
 18438         (WebCore::unloading): Ditto.
       
 18439         (WebCore::attach): Ditto.
       
 18440         (WebCore::detach): Ditto.
       
 18441         (WebCore::log): Ditto.
       
 18442         (WebCore::search): Ditto.
       
 18443         (WebCore::inspectedWindow): Ditto.
       
 18444         (WebCore::InspectorController::InspectorController):
       
 18445         (WebCore::InspectorController::~InspectorController):
       
 18446         (WebCore::InspectorController::inspect): Called by
       
 18447         ContextMenuController to inspect a node.
       
 18448         (WebCore::InspectorController::focusNode):
       
 18449         (WebCore::InspectorController::highlight):
       
 18450         (WebCore::InspectorController::hideHighlight):
       
 18451         (WebCore::InspectorController::windowVisible):
       
 18452         (WebCore::InspectorController::setWindowVisible):
       
 18453         (WebCore::InspectorController::addMessageToConsole):
       
 18454         (WebCore::InspectorController::attachWindow):
       
 18455         (WebCore::InspectorController::detachWindow):
       
 18456         (WebCore::InspectorController::windowScriptObjectAvailable):
       
 18457         (WebCore::InspectorController::scriptObjectReady):
       
 18458         (WebCore::InspectorController::windowUnloading):
       
 18459         (WebCore::addHeaders): Static helper function.
       
 18460         (WebCore::objectForRequest): Ditto.
       
 18461         (WebCore::objectForResponse): Ditto.
       
 18462         (WebCore::InspectorController::addScriptResource):
       
 18463         (WebCore::InspectorController::addAndUpdateScriptResource):
       
 18464         (WebCore::InspectorController::removeScriptResource):
       
 18465         (WebCore::InspectorController::updateScriptResource):
       
 18466         (WebCore::InspectorController::populateScriptResources):
       
 18467         (WebCore::InspectorController::addScriptConsoleMessage):
       
 18468         (WebCore::callClearFunction): Static helper function.
       
 18469         (WebCore::InspectorController::clearScriptResources):
       
 18470         (WebCore::InspectorController::clearScriptConsoleMessages):
       
 18471         (WebCore::InspectorController::clearNetworkTimeline):
       
 18472         (WebCore::InspectorController::pruneResources):
       
 18473         (WebCore::InspectorController::didCommitLoad): Callback from
       
 18474         FrameLoader.
       
 18475         (WebCore::InspectorController::frameDetachedFromParent): Ditto.
       
 18476         (WebCore::InspectorController::addResource): Ditto.
       
 18477         (WebCore::InspectorController::removeResource): Ditto.
       
 18478         (WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
       
 18479         (WebCore::InspectorController::identifierForInitialRequest): Ditto.
       
 18480         (WebCore::InspectorController::willSendRequest): Ditto.
       
 18481         (WebCore::InspectorController::didReceiveResponse): Ditto.
       
 18482         (WebCore::InspectorController::didReceiveContentLength): Ditto.
       
 18483         (WebCore::InspectorController::didFinishLoading): Ditto.
       
 18484         (WebCore::InspectorController::didFailLoading): Ditto.
       
 18485         * page/InspectorController.h: Added.
       
 18486         (WebCore::InspectorController::inspectedPage):
       
 18487         (WebCore::InspectorController::scriptContext):
       
 18488         (WebCore::InspectorController::setScriptContext):
       
 18489         (WebCore::InspectorController::resources):
       
 18490         (WebCore::InspectorController::removeAllResources):
       
 18491 
       
 18492         Add the JavaScript that defines most of the behavior of the Inspector.
       
 18493         
       
 18494         * page/inspector/ConsolePanel.js: Added.
       
 18495         * page/inspector/NetworkPanel.js: Added.
       
 18496         * page/inspector/Resource.js: Added.
       
 18497         * page/inspector/ResourceCategory.js: Added.
       
 18498         * page/inspector/ResourcePanel.js: Added.
       
 18499         * page/inspector/inspector.js: Added.
       
 18500         * page/inspector/treeoutline.js: Renamed from WebKit/WebInspector/webInspector/treeoutline.js.
       
 18501         * page/inspector/utilities.js: Added.
       
 18502 
       
 18503         Add the Inspector's CSS and HTML.
       
 18504 
       
 18505         * page/inspector/inspector.css: Added.
       
 18506         * page/inspector/inspector.html: Added.
       
 18507 
       
 18508         Hang the InspectorController off of Page. We only create an
       
 18509         InspectorController if an InspectorClient is given to the Page.
       
 18510 
       
 18511         * page/Page.cpp:
       
 18512         (WebCore::Page::Page):
       
 18513         * page/Page.h:
       
 18514         (WebCore::Page::inspectorController):
       
 18515 
       
 18516         Use FrameLoader to notify the InspectorController of resource loads.
       
 18517 
       
 18518         * loader/FrameLoader.cpp:
       
 18519         (WebCore::FrameLoader::begin):
       
 18520         (WebCore::FrameLoader::transitionToCommitted):
       
 18521         (WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
       
 18522         (WebCore::FrameLoader::detachFromParent):
       
 18523         (WebCore::FrameLoader::assignIdentifierToInitialRequest):
       
 18524         (WebCore::FrameLoader::willSendRequest):
       
 18525         (WebCore::FrameLoader::didReceiveResponse):
       
 18526         (WebCore::FrameLoader::didReceiveData):
       
 18527         (WebCore::FrameLoader::sendRemainingDelegateMessages):
       
 18528         (WebCore::FrameLoader::requestFromDelegate):
       
 18529         (WebCore::FrameLoader::didFinishLoad):
       
 18530         (WebCore::FrameLoader::dispatchWindowObjectAvailable):
       
 18531         (WebCore::FrameLoader::dispatchDidCommitLoad):
       
 18532         (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest):
       
 18533         (WebCore::FrameLoader::dispatchWillSendRequest):
       
 18534         (WebCore::FrameLoader::dispatchDidReceiveResponse):
       
 18535         (WebCore::FrameLoader::dispatchDidReceiveContentLength):
       
 18536         (WebCore::FrameLoader::dispatchDidFinishLoading):
       
 18537         (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache):
       
 18538         * loader/FrameLoader.h:
       
 18539 
       
 18540         Send console messages to the InspectorController.
       
 18541 
       
 18542         * page/Chrome.cpp:
       
 18543         (WebCore::Chrome::addMessageToConsole): Send all console messages to
       
 18544         the InspectorController.
       
 18545         * page/Chrome.h: Add a new MessageLevel and MessageSource that are
       
 18546         used in the Inspector JS.
       
 18547 
       
 18548         Report HTML errors when the Inspector window is open.
       
 18549         We don't report errors when the window is closed because we don't want
       
 18550         to slow down the HTMLTokenizer.
       
 18551 
       
 18552         * html/HTMLDocument.cpp:
       
 18553         (WebCore::HTMLDocument::createTokenizer):
       
 18554         * html/HTMLParser.cpp:
       
 18555         (WebCore::HTMLParser::HTMLParser):
       
 18556         * html/HTMLParser.h:
       
 18557         * html/HTMLTokenizer.cpp:
       
 18558         (WebCore::HTMLTokenizer::HTMLTokenizer):
       
 18559         * html/HTMLTokenizer.h:
       
 18560 
       
 18561         Append the "Inspect Element" context menu item after passing the
       
 18562         context menu to the ContextMenuClient. This work used to be done in
       
 18563         WebKit.
       
 18564 
       
 18565         * page/ContextMenuClient.h:
       
 18566         * page/ContextMenuController.cpp:
       
 18567         (WebCore::ContextMenuController::handleContextMenuEvent): Add the
       
 18568         "Inspect Element" item.
       
 18569         (WebCore::ContextMenuController::contextMenuItemSelected): Handle the
       
 18570         "Inspect Element" item.
       
 18571         * platform/ContextMenu.cpp:
       
 18572         (WebCore::ContextMenu::addInspectElementItem):
       
 18573         (WebCore::ContextMenu::checkOrEnableIfNeeded): Updated for "Inspect
       
 18574         Element" item.
       
 18575         * platform/ContextMenu.h:
       
 18576         * platform/ContextMenuItem.h:
       
 18577         (WebCore::): Add ContextMenuItemTagInspectElement.
       
 18578         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 18579         * page/mac/WebCoreViewFactory.h: Add the "Inspect Element" localized
       
 18580         string.
       
 18581         * platform/LocalizedStrings.h: Ditto.
       
 18582         * platform/mac/LocalizedStringsMac.mm:
       
 18583         (WebCore::contextMenuItemTagInspectElement): Ditto.
       
 18584 
       
 18585         Miscellaneous changes:
       
 18586 
       
 18587         * css/view-source.css: Add message bubble styles.
       
 18588         * loader/DocumentLoader.h: Add a frame getter.
       
 18589         * platform/win/ScrollViewWin.cpp:
       
 18590         (WebCore::ScrollView::updateScrollbars): Respect
       
 18591         Frame::prohibitsScrolling.
       
 18592 
       
 18593         Add new images needed for the Inspector.
       
 18594 
       
 18595         * page/inspector/Images/attachedShadow.png: Added.
       
 18596         * page/inspector/Images/bottomShadow.png: Added.
       
 18597         * page/inspector/Images/breadcrumbBackground.png: Added.
       
 18598         * page/inspector/Images/checker.png: Added.
       
 18599         * page/inspector/Images/console.png: Added.
       
 18600         * page/inspector/Images/darkShadow.png: Added.
       
 18601         * page/inspector/Images/disclosureDownPressed.png: Added.
       
 18602         * page/inspector/Images/disclosureRightDown.png: Added.
       
 18603         * page/inspector/Images/disclosureRightPressed.png: Added.
       
 18604         * page/inspector/Images/document.png: Added.
       
 18605         * page/inspector/Images/domViewButton.png: Added.
       
 18606         * page/inspector/Images/domViewButtonSelected.png: Added.
       
 18607         * page/inspector/Images/downTriangle.png: Added.
       
 18608         * page/inspector/Images/errorIcon.png: Added.
       
 18609         * page/inspector/Images/errorMediumIcon.png: Added.
       
 18610         * page/inspector/Images/folder.png: Added.
       
 18611         * page/inspector/Images/goArrow.png: Added.
       
 18612         * page/inspector/Images/gradient.png: Added.
       
 18613         * page/inspector/Images/gradientHighlight.png: Added.
       
 18614         * page/inspector/Images/gradientHighlightBottom.png: Added.
       
 18615         * page/inspector/Images/hideStatusWidget.png: Added.
       
 18616         * page/inspector/Images/hideStatusWidgetPressed.png: Added.
       
 18617         * page/inspector/Images/network.png: Added.
       
 18618         * page/inspector/Images/paneBottomGrow.png: Added.
       
 18619         * page/inspector/Images/paneBottomGrowActive.png: Added.
       
 18620         * page/inspector/Images/paneGrowHandleLine.png: Added.
       
 18621         * page/inspector/Images/paneHeader.png: Added.
       
 18622         * page/inspector/Images/paneHeaderActive.png: Added.
       
 18623         * page/inspector/Images/plainDocument.png: Added.
       
 18624         * page/inspector/Images/popupArrows.png: Added.
       
 18625         * page/inspector/Images/rightTriangle.png: Added.
       
 18626         * page/inspector/Images/segment.png: Added.
       
 18627         * page/inspector/Images/segmentEnd.png: Added.
       
 18628         * page/inspector/Images/segmentHover.png: Added.
       
 18629         * page/inspector/Images/segmentHoverEnd.png: Added.
       
 18630         * page/inspector/Images/segmentSelected.png: Added.
       
 18631         * page/inspector/Images/segmentSelectedEnd.png: Added.
       
 18632         * page/inspector/Images/showStatusWidget.png: Added.
       
 18633         * page/inspector/Images/showStatusWidgetPressed.png: Added.
       
 18634         * page/inspector/Images/sidbarItemBackground.png: Added.
       
 18635         * page/inspector/Images/sidebarActionWidget.png: Added.
       
 18636         * page/inspector/Images/sidebarActionWidgetPressed.png: Added.
       
 18637         * page/inspector/Images/sidebarAttachWidget.png: Added.
       
 18638         * page/inspector/Images/sidebarAttachWidgetPressed.png: Added.
       
 18639         * page/inspector/Images/sidebarDetachWidget.png: Added.
       
 18640         * page/inspector/Images/sidebarDetachWidgetPressed.png: Added.
       
 18641         * page/inspector/Images/sidebarResizeWidget.png: Added.
       
 18642         * page/inspector/Images/sidebarSelection.png: Added.
       
 18643         * page/inspector/Images/sidebarSelectionBlurred.png: Added.
       
 18644         * page/inspector/Images/sidebarSelectionBlurredTall.png: Added.
       
 18645         * page/inspector/Images/sidebarSelectionGray.png: Added.
       
 18646         * page/inspector/Images/sidebarSelectionGrayTall.png: Added.
       
 18647         * page/inspector/Images/sidebarSelectionTall.png: Added.
       
 18648         * page/inspector/Images/sidebarStatusAreaBackground.png: Added.
       
 18649         * page/inspector/Images/sourceViewButton.png: Added.
       
 18650         * page/inspector/Images/sourceViewButtonSelected.png: Added.
       
 18651         * page/inspector/Images/splitviewDimple.png: Added.
       
 18652         * page/inspector/Images/splitviewDividerBackground.png: Added.
       
 18653         * page/inspector/Images/tab.png: Added.
       
 18654         * page/inspector/Images/tabSelected.png: Added.
       
 18655         * page/inspector/Images/timelinePillBlue.png: Added.
       
 18656         * page/inspector/Images/timelinePillGray.png: Added.
       
 18657         * page/inspector/Images/timelinePillGreen.png: Added.
       
 18658         * page/inspector/Images/timelinePillOrange.png: Added.
       
 18659         * page/inspector/Images/timelinePillPurple.png: Added.
       
 18660         * page/inspector/Images/timelinePillRed.png: Added.
       
 18661         * page/inspector/Images/timelinePillYellow.png: Added.
       
 18662         * page/inspector/Images/tipBalloon.png: Added.
       
 18663         * page/inspector/Images/tipBalloonBottom.png: Added.
       
 18664         * page/inspector/Images/tipIcon.png: Added.
       
 18665         * page/inspector/Images/tipIconPressed.png: Added.
       
 18666         * page/inspector/Images/toggleDown.png: Added.
       
 18667         * page/inspector/Images/toggleUp.png: Added.
       
 18668         * page/inspector/Images/toolbarBackground.png: Added.
       
 18669         * page/inspector/Images/toolbarBackgroundInactive.png: Added.
       
 18670         * page/inspector/Images/toolbarButton.png: Added.
       
 18671         * page/inspector/Images/toolbarButtonInactive.png: Added.
       
 18672         * page/inspector/Images/toolbarButtonPressed.png: Added.
       
 18673         * page/inspector/Images/toolbarButtonPressedInactive.png: Added.
       
 18674         * page/inspector/Images/toolbarSplitButtonDivider.png: Added.
       
 18675         * page/inspector/Images/toolbarSplitButtonDividerInactive.png: Added.
       
 18676         * page/inspector/Images/treeDownTriangleBlack.png: Added.
       
 18677         * page/inspector/Images/treeDownTriangleWhite.png: Added.
       
 18678         * page/inspector/Images/treeLeftTriangleBlack.png: Added.
       
 18679         * page/inspector/Images/treeRightTriangleBlack.png: Added.
       
 18680         * page/inspector/Images/treeRightTriangleWhite.png: Added.
       
 18681         * page/inspector/Images/warningIcon.png: Added.
       
 18682         * page/inspector/Images/warningMediumIcon.png: Added.
       
 18683         * page/inspector/Images/warningsErrors.png: Added.
       
 18684 
       
 18685         Build-fu:
       
 18686 
       
 18687         * WebCore.exp: Added new symbols.
       
 18688         * WebCore.xcodeproj/project.pbxproj: Added new source files and
       
 18689         resources.
       
 18690         * WebCore.vcproj/WebCore.vcproj: Ditto, and copy the resources to
       
 18691         $WebKitOutputDir.
       
 18692 
       
 18693         Windows build fixes:
       
 18694 
       
 18695         * history/HistoryItem.h: ResourceRequest is a struct.
       
 18696         * loader/FrameLoaderClient.h: Ditto.
       
 18697 
       
 18698 2007-06-20  Mitz Pettel  <mitz@webkit.org>
       
 18699 
       
 18700         Reviewed by Beth.
       
 18701 
       
 18702         - fix http://bugs.webkit.org/show_bug.cgi?id=14056
       
 18703           REGRESSION (r21113-21143): TR background not repainted via style class change
       
 18704 
       
 18705         Test: fast/repaint/table-row.html
       
 18706 
       
 18707         * rendering/RenderTableRow.cpp:
       
 18708         (WebCore::RenderTableRow::layout): Added a repaint to make up for the case where the
       
 18709         table row also needs layout, so it doesn't get a repaint in setStyle().
       
 18710 
       
 18711 2007-06-20  Mitz Pettel  <mitz@webkit.org>
       
 18712 
       
 18713         Reviewed by Adele.
       
 18714 
       
 18715         - fix http://bugs.webkit.org/show_bug.cgi?id=14040
       
 18716           Top and bottom border images flipped when using -webkit-border-image when border end up tiled
       
 18717 
       
 18718         Test: fast/borders/border-image-01.html
       
 18719 
       
 18720         Correctly account for the fact that "pattern space" is flipped.
       
 18721 
       
 18722         * platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
       
 18723         * platform/graphics/cg/ImageCG.cpp:
       
 18724         (WebCore::Image::drawPatternCallback):
       
 18725         (WebCore::Image::drawPattern):
       
 18726 
       
 18727 2007-06-20  Anders Carlsson  <andersca@apple.com>
       
 18728 
       
 18729         Reviewed by Darin.
       
 18730 
       
 18731         <rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
       
 18732         
       
 18733         Check for either '\r' or '\n' in the header value.
       
 18734         
       
 18735         * xml/xmlhttprequest.cpp:
       
 18736         (WebCore::isValidHeaderValue):
       
 18737 
       
 18738 2007-06-20  Patti Hoa  <patti@apple.com>
       
 18739 
       
 18740         Reviewed by Geoffrey Garen.
       
 18741 
       
 18742         <rdar://problem/4882527> VO should speak URL of image links that lack tags
       
 18743         Add additional change from review
       
 18744         
       
 18745         * bridge/mac/WebCoreAXObject.mm:
       
 18746         (-[WebCoreAXObject accessibilityAttributeValue:]):
       
 18747         Check if the element has imgTag before asking for its url
       
 18748         
       
 18749 2007-06-20  Patti Hoa  <patti@apple.com>
       
 18750 
       
 18751         Reviewed by Tristan O'Tierney.
       
 18752 
       
 18753         <rdar://problem/4882527> VO should speak URL of image links that lack tags
       
 18754         
       
 18755         * bridge/mac/WebCoreAXObject.mm:
       
 18756         (-[WebCoreAXObject accessibilityAttributeNames]):
       
 18757         (-[WebCoreAXObject accessibilityAttributeValue:]):
       
 18758         Return the url of images.
       
 18759 
       
 18760 2007-06-19  Anders Carlsson  <andersca@apple.com>
       
 18761 
       
 18762         Reviewed by Kevin Decker.
       
 18763 
       
 18764         <rdar://problem/5266289> REGRESSION (Safari 3 Beta 1): Incoming iChat messages are delayed
       
 18765         
       
 18766         Add a new m_deferMainResourceDataLoad that can be used to control whether a data load should be deferred using a timer or not.
       
 18767         
       
 18768         * loader/DocumentLoader.cpp:
       
 18769         (WebCore::DocumentLoader::DocumentLoader):
       
 18770         * loader/DocumentLoader.h:
       
 18771         (WebCore::DocumentLoader::deferMainResourceDataLoad):
       
 18772         * loader/MainResourceLoader.cpp:
       
 18773         (WebCore::MainResourceLoader::handleDataLoadSoon):
       
 18774         (WebCore::MainResourceLoader::loadNow):
       
 18775         (WebCore::MainResourceLoader::setDefersLoading):
       
 18776 
       
 18777 2007-06-19  Patti Hoa <patti@apple.com>
       
 18778 
       
 18779         Reviewed by Justin Garcia.
       
 18780         
       
 18781         <rdar://problem/5237325> Incorrect AXLeftLineTextMarkerRangeForTextMarker/AXPreviousLineStartTextMarkerForTextMarker for non-editable text
       
 18782         
       
 18783         * editing/visible_units.cpp:
       
 18784         (WebCore::startPositionForLine):
       
 18785         (WebCore::startOfLine):
       
 18786         (WebCore::endPositionForLine):
       
 18787         (WebCore::endOfLine):
       
 18788         Break down the line routines to allow another try to ask for start/end of line if the returned position is not valid.
       
 18789         An example would be when lineStart/lineEnd at different line than the input position.
       
 18790         This can happen if the input position is before the space character at the end of a soft-wrapped non-editable line, 
       
 18791         specifically a line without webkit-line-break:after-white-space style.
       
 18792 
       
 18793 2007-06-19  Patti Hoa  <patti@apple.com>
       
 18794 
       
 18795         Reviewed by Justin Garcia.
       
 18796         
       
 18797         <rdar://problem/3992645> VO view bounds misplaced when reading text after a line wrap
       
 18798         
       
 18799         * bridge/mac/WebCoreAXObject.mm:
       
 18800         (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
       
 18801         Improve the accuracy of the bounds for a given range
       
 18802         
       
 18803 2007-06-19  Anders Carlsson  <andersca@apple.com>
       
 18804 
       
 18805         Reviewed by Darin.
       
 18806 
       
 18807         <rdar://problem/5130630>
       
 18808         XPath fails LayoutTests on Windows
       
 18809         
       
 18810         * xml/XPathPredicate.cpp:
       
 18811         Include MathExtras.h here so we get a version of fmod that works around a bug in the Microsoft CRT.
       
 18812         
       
 18813         * xml/XPathValue.cpp:
       
 18814         (WebCore::XPath::Value::toNumber):
       
 18815         Instead of using NAN, which isn't really the NaN value on Windows, use numeric_limits.
       
 18816         
       
 18817 2007-06-19  Geoffrey Garen  <ggaren@apple.com>
       
 18818 
       
 18819         Reviewed by Darin Adler.
       
 18820 
       
 18821         Fixed cross-frame access. <rdar://problem/5251309>. 
       
 18822 
       
 18823         * bindings/js/kjs_window.cpp:
       
 18824         (KJS::Window::getValueProperty):
       
 18825         * bindings/scripts/CodeGeneratorJS.pm:
       
 18826         * page/DOMWindow.idl:
       
 18827 
       
 18828 2007-06-19  Anders Carlsson  <andersca@apple.com>
       
 18829 
       
 18830         Build fix.
       
 18831         
       
 18832         * platform/win/PopupMenuWin.cpp:
       
 18833 
       
 18834 2007-06-19  Lars Knoll <lars@trolltech.com>
       
 18835 
       
 18836         Reviewed by Zack
       
 18837 
       
 18838         Implement these methods correctly.
       
 18839 
       
 18840         * platform/qt/PlatformScreenQt.cpp:
       
 18841         (WebCore::screenRect):
       
 18842         (WebCore::screenAvailableRect):
       
 18843 
       
 18844 2007-06-19  Sam Weinig  <sam@webkit.org>
       
 18845 
       
 18846         Reviewed by Geoff.
       
 18847 
       
 18848         Patch for http://bugs.webkit.org/show_bug.cgi?id=14226
       
 18849         Move the History object out of the JS bindings
       
 18850 
       
 18851         - Autogenerate JSHistory.
       
 18852 
       
 18853         * DerivedSources.make:
       
 18854         * WebCore.pro:
       
 18855         * WebCore.vcproj/WebCore.vcproj:
       
 18856         * WebCore.xcodeproj/project.pbxproj:
       
 18857         * bindings/js/kjs_window.cpp:
       
 18858         (KJS::WindowPrivate::WindowPrivate):
       
 18859         (KJS::Window::mark):
       
 18860         (KJS::Window::getValueProperty):
       
 18861         (KJS::Window::clearHelperObjectProperties):
       
 18862         (KJS::Window::disconnectFrame):
       
 18863         * bindings/js/kjs_window.h:
       
 18864         (KJS::Window::):
       
 18865         * bridge/GlobalHistory.h: Copied from WebCore/bridge/History.h.
       
 18866         * bridge/History.h: Removed.
       
 18867         * bridge/mac/GlobalHistoryMac.mm: Copied from WebCore/bridge/mac/HistoryMac.mm.
       
 18868         * bridge/mac/HistoryMac.mm: Removed.
       
 18869         * bridge/win/GlobalHistoryWin.cpp: Copied from WebCore/bridge/win/HistoryWin.cpp.
       
 18870         * bridge/win/HistoryWin.cpp: Removed.
       
 18871         * css/cssstyleselector.cpp:
       
 18872         * page/DOMWindow.cpp:
       
 18873         (WebCore::DOMWindow::disconnectFrame):
       
 18874         (WebCore::DOMWindow::history):
       
 18875         * page/DOMWindow.h:
       
 18876         * page/DOMWindow.idl:
       
 18877         * page/History.cpp: Added.
       
 18878         (WebCore::History::History):
       
 18879         (WebCore::History::frame):
       
 18880         (WebCore::History::disconnectFrame):
       
 18881         (WebCore::History::length):
       
 18882         (WebCore::History::back):
       
 18883         (WebCore::History::forward):
       
 18884         (WebCore::History::go):
       
 18885         * page/History.h: Added.
       
 18886         * page/History.idl: Added.
       
 18887         * platform/gdk/TemporaryLinkStubs.cpp:
       
 18888         * platform/qt/TemporaryLinkStubs.cpp:
       
 18889         * platform/wx/TemporaryLinkStubs.cpp:
       
 18890 
       
 18891 2007-06-18  Sam Weinig  <sam@webkit.org>
       
 18892 
       
 18893         Qt build fix.
       
 18894 
       
 18895         * platform/qt/PlatformScreenQt.cpp:
       
 18896         (WebCore::screenDepth):
       
 18897         (WebCore::screenDepthPerComponent):
       
 18898         (WebCore::screenIsMonochrome):
       
 18899         (WebCore::screenRect):
       
 18900         (WebCore::screenAvailableRect):
       
 18901 
       
 18902 2007-06-18  Sam Weinig  <sam@webkit.org>
       
 18903 
       
 18904         Reviewed by Beth.
       
 18905 
       
 18906         Fix build and update licenses. 
       
 18907 
       
 18908         * WebCore.xcodeproj/project.pbxproj:
       
 18909         * page/BarInfo.cpp:
       
 18910         * page/BarInfo.h:
       
 18911         * page/BarInfo.idl:
       
 18912         * page/Screen.cpp:
       
 18913         (WebCore::Screen::height):
       
 18914         (WebCore::Screen::width):
       
 18915         (WebCore::Screen::colorDepth):
       
 18916         (WebCore::Screen::pixelDepth):
       
 18917         (WebCore::Screen::availLeft):
       
 18918         (WebCore::Screen::availTop):
       
 18919         (WebCore::Screen::availHeight):
       
 18920         (WebCore::Screen::availWidth):
       
 18921         * page/Screen.h:
       
 18922         * page/Screen.idl:
       
 18923 
       
 18924 2007-06-18  Anders Carlsson  <andersca@apple.com>
       
 18925 
       
 18926         Reviewed by John Sullivan.
       
 18927 
       
 18928         <rdar://problem/5277008> Assertion in [LocationChangeHandler finishedLoadingFrame:]
       
 18929         
       
 18930         Don't send any frame load callbacks if the document load hasn't been
       
 18931         committed for real.
       
 18932         
       
 18933         * loader/FrameLoader.cpp:
       
 18934         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
       
 18935 
       
 18936 2007-06-18  Sam Weinig  <sam@webkit.org>
       
 18937 
       
 18938         Reviewed by Geoff.
       
 18939 
       
 18940         Patch for http://bugs.webkit.org/show_bug.cgi?id=14193
       
 18941         Move the Screen object out of the JS bindings
       
 18942 
       
 18943         - Renames Screen.h to PlatformScreen.h to accommodate new class.
       
 18944         - Autogenerates JSScreen.
       
 18945 
       
 18946         * DerivedSources.make:
       
 18947         * WebCore.pro:
       
 18948         * WebCore.vcproj/WebCore.vcproj:
       
 18949         * WebCore.xcodeproj/project.pbxproj:
       
 18950         * bindings/js/kjs_window.cpp:
       
 18951         (KJS::WindowPrivate::WindowPrivate):
       
 18952         (KJS::Window::mark):
       
 18953         (KJS::Window::getValueProperty):
       
 18954         (KJS::Window::clearHelperObjectProperties):
       
 18955         * bindings/js/kjs_window.h:
       
 18956         (KJS::Window::):
       
 18957         * css/MediaQueryEvaluator.cpp:
       
 18958         * page/DOMWindow.cpp:
       
 18959         (WebCore::DOMWindow::DOMWindow):
       
 18960         (WebCore::DOMWindow::~DOMWindow):
       
 18961         (WebCore::DOMWindow::frame):
       
 18962         (WebCore::DOMWindow::disconnectFrame):
       
 18963         (WebCore::DOMWindow::screen):
       
 18964         * page/DOMWindow.h:
       
 18965         * page/DOMWindow.idl:
       
 18966         * page/Screen.cpp: Added.
       
 18967         (WebCore::Screen::Screen):
       
 18968         (WebCore::Screen::disconnectFrame):
       
 18969         (WebCore::Screen::height):
       
 18970         (WebCore::Screen::width):
       
 18971         (WebCore::Screen::colorDepth):
       
 18972         (WebCore::Screen::pixelDepth):
       
 18973         (WebCore::Screen::availLeft):
       
 18974         (WebCore::Screen::availTop):
       
 18975         (WebCore::Screen::availHeight):
       
 18976         (WebCore::Screen::availWidth):
       
 18977         * page/Screen.h: Added.
       
 18978         * page/Screen.idl: Added.
       
 18979         * page/mac/WebCoreFrameBridge.mm:
       
 18980         * platform/PlatformScreen.h: Copied from WebCore/platform/Screen.h.
       
 18981         * platform/Screen.h: Removed.
       
 18982         * platform/gdk/PlatformScreenGdk.cpp: Copied from WebCore/platform/gdk/ScreenGdk.cpp.
       
 18983         * platform/gdk/ScreenGdk.cpp: Removed.
       
 18984         * platform/mac/PlatformMouseEventMac.mm:
       
 18985         * platform/mac/PlatformScreenMac.mm: Copied from WebCore/platform/mac/ScreenMac.mm.
       
 18986         * platform/mac/ScreenMac.mm: Removed.
       
 18987         * platform/qt/PlatformScreenQt.cpp: Added.
       
 18988         (WebCore::WebCore::screenDepth):
       
 18989         (WebCore::WebCore::screenDepthPerComponent):
       
 18990         (WebCore::WebCore::screenIsMonochrome):
       
 18991         (WebCore::WebCore::screenRect):
       
 18992         (WebCore::WebCore::screenAvailableRect):
       
 18993         * platform/qt/TemporaryLinkStubs.cpp:
       
 18994         * platform/win/PlatformScreenWin.cpp: Copied from WebCore/platform/win/ScreenWin.cpp.
       
 18995         * platform/win/ScreenWin.cpp: Removed.
       
 18996         * rendering/RenderObject.cpp:
       
 18997 
       
 18998 2007-06-18  Sam Weinig  <sam@webkit.org>
       
 18999 
       
 19000         Reviewed by Geoff.
       
 19001 
       
 19002         Patch for http://bugs.webkit.org/show_bug.cgi?id=14211
       
 19003         Move the BarInfo object out of the JS bindings
       
 19004 
       
 19005         * DerivedSources.make:
       
 19006         * WebCore.pro:
       
 19007         * WebCore.vcproj/WebCore.vcproj:
       
 19008         * WebCore.xcodeproj/project.pbxproj:
       
 19009         * bindings/js/kjs_window.cpp:
       
 19010         (KJS::WindowPrivate::WindowPrivate):
       
 19011         (KJS::Window::mark):
       
 19012         (KJS::Window::getValueProperty):
       
 19013         (KJS::Window::clearHelperObjectProperties):
       
 19014         (KJS::Window::disconnectFrame):
       
 19015         * bindings/js/kjs_window.h:
       
 19016         (KJS::Window::):
       
 19017         * page/BarInfo.cpp: Added.
       
 19018         (WebCore::BarInfo::BarInfo):
       
 19019         (WebCore::BarInfo::disconnectFrame):
       
 19020         (WebCore::BarInfo::visible):
       
 19021         * page/BarInfo.h: Added.
       
 19022         (WebCore::BarInfo::):
       
 19023         * page/BarInfo.idl: Added.
       
 19024         * page/DOMWindow.cpp:
       
 19025         (WebCore::DOMWindow::~DOMWindow):
       
 19026         (WebCore::DOMWindow::disconnectFrame):
       
 19027         (WebCore::DOMWindow::locationbar):
       
 19028         (WebCore::DOMWindow::menubar):
       
 19029         (WebCore::DOMWindow::personalbar):
       
 19030         (WebCore::DOMWindow::scrollbars):
       
 19031         (WebCore::DOMWindow::statusbar):
       
 19032         (WebCore::DOMWindow::toolbar):
       
 19033         * page/DOMWindow.h:
       
 19034         * page/DOMWindow.idl:
       
 19035 
       
 19036 2007-06-18  Sam Weinig  <sam@webkit.org>
       
 19037 
       
 19038         Reviewed by Darin.
       
 19039 
       
 19040         Remove the FrameArray class and instead make window.frames another
       
 19041         self-reference for window (like window.window, window.self, etc).
       
 19042         This is what Firefox and what the HTML5 dictates.
       
 19043 
       
 19044         * bindings/js/kjs_window.cpp:
       
 19045         (KJS::WindowPrivate::WindowPrivate):
       
 19046         (KJS::Window::mark):
       
 19047         (KJS::Window::getValueProperty):
       
 19048         (KJS::Window::clearHelperObjectProperties):
       
 19049         (KJS::Window::disconnectFrame):
       
 19050         * bindings/js/kjs_window.h:
       
 19051 
       
 19052 2007-06-18  Mitz Pettel  <mitz@webkit.org>
       
 19053 
       
 19054         Reviewed by Adele.
       
 19055 
       
 19056         - fix http://bugs.webkit.org/show_bug.cgi?id=13413
       
 19057           Failed assertion in RenderTextControl::setSelectionRange in Google Spreadsheets
       
 19058 
       
 19059         Test: fast/forms/input-zero-height-focus.html
       
 19060 
       
 19061         * rendering/RenderTextControl.cpp:
       
 19062         (WebCore::RenderTextControl::setSelectionRange): Avoid setting the
       
 19063         selection in a zero-height text control.
       
 19064 
       
 19065 2007-06-18  Alp Toker  <alp.toker@collabora.co.uk>
       
 19066 
       
 19067         Reviewed by Sam Weinig.
       
 19068 
       
 19069         http://bugs.webkit.org/show_bug.cgi?id=14052
       
 19070         Implement SoundGdk
       
 19071 
       
 19072         * WebCore.pro:
       
 19073         * platform/gdk/SoundGdk.cpp: Added.
       
 19074         (WebCore::systemBeep):
       
 19075         * platform/gdk/TemporaryLinkStubs.cpp:
       
 19076         (WebCore::systemBeep):
       
 19077 
       
 19078 2007-06-18  Dave Hyatt  <hyatt@apple.com>
       
 19079 
       
 19080         Add support for horizontal mouse wheeling on Windows.
       
 19081         
       
 19082         Reviewed by aroben
       
 19083 
       
 19084         * platform/PlatformWheelEvent.h:
       
 19085         * platform/win/WheelEventWin.cpp:
       
 19086         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
       
 19087 
       
 19088 2007-06-17  Sam Weinig  <sam@webkit.org>
       
 19089 
       
 19090         Win32 build fix.
       
 19091 
       
 19092         * WebCore.vcproj/WebCore.vcproj:
       
 19093 
       
 19094 2007-06-15  David Hyatt  <hyatt@apple.com>
       
 19095 
       
 19096         Fix for bugzilla bugs 14183 and 14184, 'repeat' regressed in border-image
       
 19097         because of a botched 'round' support removal.  Also update for a change in
       
 19098         the spec that has the second stretch/round/repeat keyword match the first
       
 19099         if omitted.
       
 19100         
       
 19101         Reviewed by olliej
       
 19102 
       
 19103         * css/cssparser.cpp:
       
 19104         (WebCore::BorderImageParseContext::commitBorderImage):
       
 19105         * platform/graphics/Image.cpp:
       
 19106         (WebCore::Image::drawTiled):
       
 19107         * platform/graphics/Image.h:
       
 19108         (WebCore::Image::):
       
 19109 
       
 19110 2007-06-15  Sam Weinig  <sam@webkit.org>
       
 19111 
       
 19112         Reviewed by Darin.
       
 19113 
       
 19114         Patch for http://bugs.webkit.org/show_bug.cgi?id=14053
       
 19115         Autogenerate JS binding for Rect
       
 19116 
       
 19117         - Renames RectImpl to Rect, DOMStyleSheetList to JSStyleSheetList 
       
 19118           and DOMRGBColor to JSRGBColor
       
 19119         - Moves JSStyleSheetList and JSRGBColor into the WebCore namespace.
       
 19120 
       
 19121         * DerivedSources.make:
       
 19122         * WebCore.pro:
       
 19123         * WebCore.xcodeproj/project.pbxproj:
       
 19124         * bindings/js/kjs_css.cpp:
       
 19125         (WebCore::):
       
 19126         (WebCore::JSStyleSheetList::JSStyleSheetList):
       
 19127         (WebCore::JSStyleSheetList::~JSStyleSheetList):
       
 19128         (WebCore::JSStyleSheetList::getValueProperty):
       
 19129         (WebCore::JSStyleSheetList::indexGetter):
       
 19130         (WebCore::JSStyleSheetList::nameGetter):
       
 19131         (WebCore::JSStyleSheetList::getOwnPropertySlot):
       
 19132         (WebCore::toJS):
       
 19133         (WebCore::JSStyleSheetListFunc::callAsFunction):
       
 19134         (WebCore::JSRGBColor::JSRGBColor):
       
 19135         (WebCore::JSRGBColor::~JSRGBColor):
       
 19136         (WebCore::JSRGBColor::getOwnPropertySlot):
       
 19137         (WebCore::JSRGBColor::getValueProperty):
       
 19138         (WebCore::getJSRGBColor):
       
 19139         * bindings/js/kjs_css.h:
       
 19140         (WebCore::JSStyleSheetList::classInfo):
       
 19141         (WebCore::JSStyleSheetList::):
       
 19142         (WebCore::JSStyleSheetList::impl):
       
 19143         (WebCore::JSRGBColor::classInfo):
       
 19144         (WebCore::JSRGBColor::):
       
 19145         (WebCore::JSRGBColor::impl):
       
 19146         * bindings/objc/DOMUtility.mm:
       
 19147         (KJS::createDOMWrapper):
       
 19148         * bindings/scripts/CodeGeneratorJS.pm:
       
 19149         * bindings/scripts/CodeGeneratorObjC.pm:
       
 19150         * css/CSSBorderImageValue.cpp:
       
 19151         (WebCore::CSSBorderImageValue::CSSBorderImageValue):
       
 19152         * css/CSSBorderImageValue.h:
       
 19153         * css/CSSPrimitiveValue.cpp:
       
 19154         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
       
 19155         (WebCore::CSSPrimitiveValue::cssText):
       
 19156         * css/CSSPrimitiveValue.h:
       
 19157         (WebCore::CSSPrimitiveValue::getRectValue):
       
 19158         (WebCore::CSSPrimitiveValue::):
       
 19159         * css/DashboardRegion.h:
       
 19160         * css/Rect.h: Copied from css/RectImpl.h.
       
 19161         (WebCore::Rect::~Rect):
       
 19162         (WebCore::Rect::top):
       
 19163         (WebCore::Rect::right):
       
 19164         (WebCore::Rect::bottom):
       
 19165         (WebCore::Rect::left):
       
 19166         (WebCore::Rect::setTop):
       
 19167         (WebCore::Rect::setRight):
       
 19168         (WebCore::Rect::setBottom):
       
 19169         (WebCore::Rect::setLeft):
       
 19170         * css/Rect.idl:
       
 19171         * css/RectImpl.h: Removed.
       
 19172         * css/cssparser.cpp:
       
 19173         (WebCore::CSSParser::parseShape):
       
 19174         (WebCore::BorderImageParseContext::commitBorderImage):
       
 19175         * css/cssstyleselector.cpp:
       
 19176         (WebCore::CSSStyleSelector::applyProperty):
       
 19177         * page/DOMWindow.idl:
       
 19178 
       
 19179 2007-06-14  George Staikos  <staikos@kde.org>
       
 19180 
       
 19181         Reviewed by Lars.
       
 19182 
       
 19183         Implement missing tab support and a slight refactor.
       
 19184 
       
 19185         * platform/qt/PlatformKeyboardEventQt.cpp:
       
 19186         (WebCore::keyIdentifierForQtKeyCode):
       
 19187         (WebCore::windowsKeyCodeForKeyEvent):
       
 19188         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
       
 19189 
       
 19190 2007-06-14  Dave Hyatt  <hyatt@apple.com>
       
 19191 
       
 19192         Fix for Bugzilla bug 14806, missing text for bold/italic fonts in non-English Windows installs.
       
 19193         
       
 19194         This patch adds an additional step after the lookup by full name fails.  It will then look up
       
 19195         a PostScript name in a (localized full name) -> (PostScript name) cache.  If the name is not
       
 19196         found, then the font's name table is obtained and searched for a PostScript name (and the
       
 19197         result is cached).
       
 19198         
       
 19199         If lookup on PostScript name fails too, then we now properly fall back to the next font in the
       
 19200         list (so text should never be missing).
       
 19201 
       
 19202         Reviewed by Darin (thoroughly reviewed, super reviewed even)
       
 19203 
       
 19204         * platform/win/FontCacheWin.cpp:
       
 19205         * platform/win/FontPlatformDataWin.cpp:
       
 19206 
       
 19207 2007-06-14  Anders Carlsson  <andersca@apple.com>
       
 19208 
       
 19209         Reviewed by Geoff.
       
 19210 
       
 19211         Add Frame::cleanupScriptObjectsForPlugin which will invalidate the root object
       
 19212         for a given plug-in.
       
 19213 
       
 19214         * WebCore.exp:
       
 19215         * page/Frame.cpp:
       
 19216         (WebCore::Frame::cleanupScriptObjectsForPlugin):
       
 19217         * page/Frame.h:
       
 19218 
       
 19219 2007-06-14  Anders Carlsson  <andersca@apple.com>
       
 19220 
       
 19221         Reviewed by Geoff.
       
 19222 
       
 19223         <rdar://problem/5211677>
       
 19224         -[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>
       
 19225         
       
 19226         * loader/FrameLoader.cpp:
       
 19227         (WebCore::FrameLoader::requestObject):
       
 19228         If the object is a Java MIME type and Java is disabled, don't load the plug-in.
       
 19229         
       
 19230         * platform/MimeTypeRegistry.cpp:
       
 19231         (WebCore::MimeTypeRegistry::isJavaAppletMIMEType):
       
 19232         Clean this up and add another applet MIME type.
       
 19233 
       
 19234 2007-06-14  George Staikos  <staikos@kde.org>
       
 19235 
       
 19236         Reviewed by Lars.
       
 19237 
       
 19238         Implement the file chooser for Qt.
       
 19239 
       
 19240         * platform/qt/FileChooserQt.cpp:
       
 19241         (WebCore::FileChooser::openFileChooser):
       
 19242         (WebCore::FileChooser::basenameForWidth):
       
 19243 
       
 19244 2007-06-14  George Staikos  <staikos@kde.org>
       
 19245 
       
 19246         Reviewed by Lars.
       
 19247 
       
 19248         Add missing initialization of pointer.
       
 19249 
       
 19250         * platform/qt/ContextMenuQt.cpp:
       
 19251         (WebCore::ContextMenu::ContextMenu):
       
 19252 
       
 19253 2007-06-14  Anders Carlsson  <andersca@apple.com>
       
 19254 
       
 19255         Reviewed by Mitz.
       
 19256 
       
 19257         <rdar://problem/5244948>
       
 19258         Safari keeps on complaining about slow script playing NBC TV video (14133)
       
 19259 
       
 19260         http://bugs.webkit.org/show_bug.cgi?id=14133
       
 19261         Runaway JavaScript timer fires when spinning around in Google Maps street view
       
 19262 
       
 19263         Make sure to start and stop the timeout checker around calls to JS.
       
 19264 
       
 19265         * bindings/objc/WebScriptObject.mm:
       
 19266         (-[WebScriptObject callWebScriptMethod:withArguments:]):
       
 19267         (-[WebScriptObject evaluateWebScript:]):
       
 19268 
       
 19269 2007-06-14  George Staikos  <staikos@kde.org>
       
 19270 
       
 19271         Reviewed by Maciej.
       
 19272 
       
 19273         Keypress causes typeahead crash on empty selects due to modulo 0.
       
 19274 
       
 19275         * html/HTMLSelectElement.cpp:
       
 19276         (WebCore::HTMLSelectElement::typeAheadFind):
       
 19277 
       
 19278 2007-06-13  George Staikos  <staikos@kde.org>
       
 19279 
       
 19280         Reviewed by Lars.
       
 19281 
       
 19282         Compile without self-linking.
       
 19283 
       
 19284         * WebCore.pro:
       
 19285 
       
 19286 2007-06-13  Darin Adler  <darin@apple.com>
       
 19287 
       
 19288         Reviewed by Kevin Decker.
       
 19289 
       
 19290         - fix <rdar://problem/5264923> Safari frequently "stalls" beneath
       
 19291           +[NSFont fontWithName:size:] while loading a web page (searching on disk for the font)
       
 19292 
       
 19293         * platform/mac/WebFontCache.mm:
       
 19294         (+[WebFontCache internalFontWithFamily:traits:size:]): Renamed from fontWithFamily.
       
 19295         Took out the auto-activation code.
       
 19296         (+[WebFontCache fontWithFamily:traits:size:]): Added. Calls internalFontWithFamily,
       
 19297         then calls NSFont to trigger activation if that returned nil, then calls
       
 19298         internalFontWithFamily again.
       
 19299 
       
 19300 2007-06-13  Anders Carlsson  <andersca@apple.com>
       
 19301 
       
 19302         Reviewed by Geoff.
       
 19303 
       
 19304         Pass the root object to methods that end up creating new ObjcInstance objects.
       
 19305         
       
 19306         * bindings/objc/WebScriptObject.mm:
       
 19307         (listFromNSArray):
       
 19308         (-[WebScriptObject callWebScriptMethod:withArguments:]):
       
 19309         (-[WebScriptObject evaluateWebScript:]):
       
 19310         (-[WebScriptObject setValue:forKey:]):
       
 19311         (-[WebScriptObject valueForKey:]):
       
 19312         (-[WebScriptObject removeWebScriptKey:]):
       
 19313         (-[WebScriptObject setWebScriptValueAtIndex:value:]):
       
 19314 
       
 19315 2007-06-13  Anders Carlsson  <andersca@apple.com>
       
 19316 
       
 19317         Reviewed by Darin.
       
 19318 
       
 19319         <rdar://problem/5267992>
       
 19320         Make sure an alert doesn't allow loading to continue inside a script.
       
 19321         
       
 19322         Make sure to defer all loads where it's possible for a second main loop to be running.
       
 19323         
       
 19324         * page/Chrome.cpp:
       
 19325         (WebCore::Chrome::runModal):
       
 19326         (WebCore::Chrome::runBeforeUnloadConfirmPanel):
       
 19327         (WebCore::Chrome::runJavaScriptAlert):
       
 19328         (WebCore::Chrome::runJavaScriptConfirm):
       
 19329         (WebCore::Chrome::runJavaScriptPrompt):
       
 19330         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
       
 19331         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
       
 19332         
       
 19333         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 19334         (WebCore::ResourceHandle::setDefersLoading):
       
 19335         Implement this.
       
 19336 
       
 19337 2007-06-13  Alp Toker  <alp.toker@collabora.co.uk>
       
 19338 
       
 19339         Reviewed by Rob.
       
 19340 
       
 19341         http://bugs.webkit.org/show_bug.cgi?id=14060
       
 19342         Cairo SVG support
       
 19343 
       
 19344         * WebCore.pro: Add new files to the build.
       
 19345         * platform/graphics/svg/SVGPaintServerPattern.h:
       
 19346         * platform/graphics/svg/SVGPaintServerSolid.h:
       
 19347         * platform/graphics/svg/cairo: Added.
       
 19348         * platform/graphics/svg/cairo/RenderPathCairo.cpp: Added.
       
 19349         (WebCore::RenderPath::strokeContains):
       
 19350         (WebCore::RenderPath::strokeBBox):
       
 19351         * platform/graphics/svg/cairo/SVGPaintServerCairo.cpp: Added.
       
 19352         (WebCore::SVGPaintServer::draw):
       
 19353         (WebCore::SVGPaintServer::teardown):
       
 19354         (WebCore::SVGPaintServer::renderPath):
       
 19355         * platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp: Added.
       
 19356         (WebCore::SVGPaintServerGradient::setup):
       
 19357         * platform/graphics/svg/cairo/SVGPaintServerPatternCairo.cpp: Added.
       
 19358         (WebCore::SVGPaintServerPattern::setup):
       
 19359         * platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: Added.
       
 19360         (WebCore::SVGPaintServerSolid::setup):
       
 19361         * platform/graphics/svg/cairo/SVGResourceClipperCairo.cpp: Added.
       
 19362         (WebCore::SVGResourceClipper::applyClip):
       
 19363         * platform/graphics/svg/cairo/SVGResourceMaskerCairo.cpp: Added.
       
 19364         (WebCore::SVGResourceMasker::applyMask):
       
 19365 
       
 19366 2007-06-13  Simon Hausmann  <hausmann@kde.org>
       
 19367 
       
 19368         Reviewed by Lars.
       
 19369 
       
 19370         Added a make install target that installs the Qt port and renamed
       
 19371         WebKitQt to QtWebKit
       
 19372 
       
 19373         * WebCore.pro:
       
 19374 
       
 19375 2007-06-13  Adam Roben  <aroben@apple.com>
       
 19376 
       
 19377         Fix one more BITMAPINFO/BITMAPINFOHEADER typo.
       
 19378 
       
 19379         Rubberstamped by Oliver.
       
 19380 
       
 19381         * platform/win/DragImageWin.cpp:
       
 19382         (WebCore::allocImage):
       
 19383 
       
 19384 2007-06-12  Oliver Hunt  <oliver@apple.com>
       
 19385 
       
 19386         Reviewed by Darin.
       
 19387 
       
 19388         Use correct size for BITMAPINFOHEADER -- whoops.
       
 19389 
       
 19390         * platform/win/CursorWin.cpp:
       
 19391         (WebCore::Cursor::Cursor):
       
 19392         * platform/win/PasteboardWin.cpp:
       
 19393         (WebCore::Pasteboard::writeImage):
       
 19394 
       
 19395 2007-06-12  Sam Weinig  <sam@webkit.org>
       
 19396 
       
 19397         Reviewed by Oliver.
       
 19398 
       
 19399         Patch for http://bugs.webkit.org/show_bug.cgi?id=14109
       
 19400         Cleanup JSEvent and JSClipboard in preperation for autogeneration
       
 19401 
       
 19402         * bindings/js/kjs_events.cpp:
       
 19403         (KJS::DOMEvent::DOMEvent):
       
 19404         (KJS::DOMEvent::getValueProperty):
       
 19405         (KJS::DOMEvent::put):
       
 19406         (KJS::DOMEvent::putValueProperty):
       
 19407         (KJS::DOMEventPrototypeFunction::callAsFunction):
       
 19408         (KJS::toJS):
       
 19409         (KJS::toEvent):
       
 19410         (KJS::):
       
 19411         (KJS::JSClipboard::JSClipboard):
       
 19412         (KJS::JSClipboard::~JSClipboard):
       
 19413         (KJS::JSClipboard::getOwnPropertySlot):
       
 19414         (KJS::JSClipboard::getValueProperty):
       
 19415         (KJS::JSClipboard::put):
       
 19416         (KJS::JSClipboard::putValueProperty):
       
 19417         (KJS::JSClipboardPrototypeFunction::callAsFunction):
       
 19418         (KJS::toClipboard):
       
 19419         * bindings/js/kjs_events.h:
       
 19420         (KJS::DOMEvent::):
       
 19421         (KJS::DOMEvent::impl):
       
 19422         (KJS::JSClipboard::impl):
       
 19423         * dom/ClipboardEvent.h:
       
 19424         * dom/Event.h:
       
 19425         (WebCore::Event::srcElement):
       
 19426         (WebCore::Event::returnValue):
       
 19427         (WebCore::Event::clipboardData):
       
 19428         (WebCore::Event::dataTransfer):
       
 19429         (WebCore::Event::clipboard):
       
 19430         * dom/MouseEvent.h:
       
 19431 
       
 19432 2007-06-13  Lars Knoll <lars@trolltech.com>
       
 19433 
       
 19434         Reviewed by Niko.
       
 19435 
       
 19436         Small cleanup
       
 19437 
       
 19438         * platform/qt/PlugInInfoStoreQt.cpp:
       
 19439         (WebCore::PlugInInfoStore::supportsMIMEType):
       
 19440 
       
 19441 2007-06-13  Lars Knoll <lars@trolltech.com>
       
 19442 
       
 19443         Reviewed by Niko
       
 19444 
       
 19445         Implement the parts required for the JS bridge
       
 19446         to know about the plugins.
       
 19447 
       
 19448         * WebCore.pro:
       
 19449         * platform/qt/PlugInInfoStoreQt.cpp: Added.
       
 19450         (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
       
 19451         (WebCore::PlugInInfoStore::pluginCount):
       
 19452         (WebCore::PlugInInfoStore::supportsMIMEType):
       
 19453         (WebCore::refreshPlugins):
       
 19454         * platform/qt/TemporaryLinkStubs.cpp:
       
 19455 
       
 19456 === Merged the following changes from branches/WindowsMerge ===
       
 19457 
       
 19458 2007-06-09  Sam Weinig  <sam@webkit.org>
       
 19459 
       
 19460         Build fix.
       
 19461 
       
 19462         * WebCore.vcproj/WebCore.vcproj:
       
 19463 
       
 19464 2007-06-08  Anders Carlsson  <andersca@apple.com>
       
 19465 
       
 19466         Reviewed by Adam.
       
 19467 
       
 19468         If both the old and new WMP plugins are present, remove the old one
       
 19469         so we won't end up choosing it.
       
 19470         
       
 19471         * plugins/win/PluginDatabaseWin.cpp:
       
 19472         (WebCore::PluginDatabaseWin::getPluginsInPaths):
       
 19473 
       
 19474 2007-06-08  David Hyatt  <hyatt@apple.com>
       
 19475 
       
 19476         Update licenses/copyrights for WebCoreWin.
       
 19477 
       
 19478         Reviewed by mccullough
       
 19479 
       
 19480         * WebCorePrefix.cpp:
       
 19481         * bridge/win/FrameWin.cpp:
       
 19482         * bridge/win/FrameWin.h:
       
 19483         * bridge/win/HistoryWin.cpp:
       
 19484         * bridge/win/PageWin.cpp:
       
 19485         * page/win/EventHandlerWin.cpp:
       
 19486         * platform/graphics/cg/ColorCG.cpp:
       
 19487         * platform/graphics/cg/GraphicsContextPlatformPrivate.h:
       
 19488         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
       
 19489         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
       
 19490         * platform/graphics/win/IconWin.cpp:
       
 19491         * platform/graphics/win/ImageWin.cpp:
       
 19492         * platform/network/cf/FormDataStreamCFNet.cpp:
       
 19493         * platform/network/cf/FormDataStreamCFNet.h:
       
 19494         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 19495         * platform/network/cf/ResourceRequestCFNet.cpp:
       
 19496         * platform/network/cf/ResourceResponseCFNet.cpp:
       
 19497         * platform/network/win/CookieJarWin.cpp:
       
 19498         * platform/network/win/ResourceHandleWin.cpp:
       
 19499         * platform/network/win/ResourceHandleWin.h:
       
 19500         * platform/win/BString.cpp:
       
 19501         * platform/win/BString.h:
       
 19502         * platform/win/ClipboardWin.h:
       
 19503         * platform/win/ContextMenuWin.cpp:
       
 19504         * platform/win/CursorWin.cpp:
       
 19505         * platform/win/EditorWin.cpp:
       
 19506         * platform/win/FontCacheWin.cpp:
       
 19507         * platform/win/FontDataWin.cpp:
       
 19508         * platform/win/FontPlatformData.h:
       
 19509         * platform/win/FontPlatformDataWin.cpp:
       
 19510         * platform/win/FontWin.cpp:
       
 19511         * platform/win/GlyphPageTreeNodeWin.cpp:
       
 19512         * platform/win/GraphicsContextWin.cpp:
       
 19513         * platform/win/KeyEventWin.cpp:
       
 19514         * platform/win/MimeTypeRegistryWin.cpp:
       
 19515         * platform/win/NotImplemented.h:
       
 19516         * platform/win/PlatformMouseEventWin.cpp:
       
 19517         * platform/win/PlatformScrollBar.h:
       
 19518         * platform/win/PlatformScrollBarWin.cpp:
       
 19519         * platform/win/PopupMenuWin.cpp:
       
 19520         * platform/win/ScreenWin.cpp:
       
 19521         * platform/win/ScrollViewWin.cpp:
       
 19522         * platform/win/SearchPopupMenuWin.cpp:
       
 19523         * platform/win/SoundWin.cpp:
       
 19524         * platform/win/TemporaryLinkStubs.cpp:
       
 19525         * platform/win/TextBoundariesWin.cpp:
       
 19526         * platform/win/WebCoreHistory.cpp:
       
 19527         * platform/win/WebCoreHistory.h:
       
 19528         * platform/win/WebCoreSystemInterface.cpp:
       
 19529         * platform/win/WebCoreSystemInterface.h:
       
 19530         * platform/win/WheelEventWin.cpp:
       
 19531         * platform/win/WidgetWin.cpp:
       
 19532         * plugins/win/PlugInInfoStoreWin.cpp:
       
 19533         * plugins/win/PluginDatabaseWin.cpp:
       
 19534         * plugins/win/PluginDatabaseWin.h:
       
 19535         * plugins/win/PluginDebug.h:
       
 19536         * plugins/win/PluginPackageWin.cpp:
       
 19537         * plugins/win/PluginPackageWin.h:
       
 19538         * plugins/win/PluginStreamWin.cpp:
       
 19539         * plugins/win/PluginStreamWin.h:
       
 19540         * plugins/win/PluginViewWin.cpp:
       
 19541         * plugins/win/PluginViewWin.h:
       
 19542         * plugins/win/npapi.cpp:
       
 19543         * plugins/win/npfunctions.h:
       
 19544         * rendering/RenderThemeSafari.cpp:
       
 19545         * rendering/RenderThemeSafari.h:
       
 19546         * rendering/RenderThemeWin.h:
       
 19547 
       
 19548 2007-06-07  Sam Weinig  <sam@webkit.org>
       
 19549 
       
 19550         Fix build.
       
 19551 
       
 19552         * WebCore.vcproj/WebCore.vcproj:
       
 19553 
       
 19554 2007-06-07  Anders Carlsson  <andersca@apple.com>
       
 19555 
       
 19556         Reviewed by Steve.
       
 19557 
       
 19558         <rdar://problem/5252902>
       
 19559         Shockwave plug-in content crashes.
       
 19560         
       
 19561         Add a new quirk for plug-ins that need their WNDPROCs to be ASCII. If someone uses SetWindowLongA to set the WNDPROC to an ASCII one
       
 19562         and the previous one was an Unicode one, the value returned from SetWindowLongA (the old WNDPROC) will not be a function pointer, but instead
       
 19563         a special value. The Win32 API CallWndProc knows that when it encounters a special value it must convert the message to Unicode. Shockwave 
       
 19564         does not use CallWndProc but instead treats the WNDPROC as a function.
       
 19565         
       
 19566         * plugins/win/PluginViewWin.cpp:
       
 19567         (WebCore::PluginViewWndProc):
       
 19568         (WebCore::PluginViewWin::determineQuirks):
       
 19569         (WebCore::PluginViewWin::init):
       
 19570         * plugins/win/PluginViewWin.h:
       
 19571         (WebCore::):
       
 19572         (WebCore::PluginViewWin::quirks):
       
 19573 
       
 19574 2007-06-07  Sam Weinig  <sam@webkit.org>
       
 19575 
       
 19576         Build fix for the build fix.
       
 19577 
       
 19578         * WebCore.vcproj/WebCore.vcproj:
       
 19579 
       
 19580 2007-06-07  Sam Weinig  <sam@webkit.org>
       
 19581 
       
 19582         Build fix.
       
 19583 
       
 19584         * WebCore.vcproj/WebCore.vcproj:
       
 19585 
       
 19586 2007-06-06  Sam Weinig  <sam@webkit.org>
       
 19587 
       
 19588         Build fix.
       
 19589 
       
 19590         * WebCore.vcproj/WebCore.vcproj:
       
 19591 
       
 19592 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
       
 19593 
       
 19594         Reviewed by Oliver.
       
 19595 
       
 19596         Update to last fix.
       
 19597         Invalidate a list of rects rather than unioning them.
       
 19598 
       
 19599         * plugins/win/PluginViewWin.cpp:
       
 19600         (WebCore::PluginViewWin::invalidateTimerFired):
       
 19601         (WebCore::PluginViewWin::invalidateRect):
       
 19602         * plugins/win/PluginViewWin.h:
       
 19603 
       
 19604 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
       
 19605 
       
 19606         Reviewed by Oliver.
       
 19607 
       
 19608         <rdar://problem/5245016> 100A89+WebKit.dll: Can't select text in page location field at kids.yahoo.com
       
 19609         
       
 19610         Delay invalidates for windowless Flash to prevent Flash WM_PAINT and WM_USER+1 messages from
       
 19611         starving other HWNDs.
       
 19612         
       
 19613         This code defers the invalidate through a WebCore::Timer.  We could have used a Windows ::SetTimer
       
 19614         to further lessen CPU load, but this would have the additional risk of negatively impacting Flash
       
 19615         performance, since WebCore::Timer is set up to be more responsive than ::SetTimer.
       
 19616 
       
 19617         * plugins/win/PluginViewWin.cpp:
       
 19618         (WebCore::PluginViewWin::invalidateTimerFired): Added.
       
 19619         (WebCore::PluginViewWin::invalidateRect): Delay invalidates for windowless Flash.
       
 19620         (WebCore::PluginViewWin::determineQuirks): Add delayed invalidate quirk.
       
 19621         * plugins/win/PluginViewWin.h:
       
 19622 
       
 19623 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
       
 19624 
       
 19625         Reviewed by Adam.
       
 19626 
       
 19627         Update last fix to use startsWith instead of strcmpi.
       
 19628 
       
 19629         * plugins/win/PluginStreamWin.cpp:
       
 19630         (WebCore::PluginStreamWin::startStream):
       
 19631         * plugins/win/PluginViewWin.cpp:
       
 19632         (WebCore::scriptStringIfJavaScriptURL):
       
 19633 
       
 19634 2007-06-02  Steve Falkenburg  <sfalken@apple.com>
       
 19635 
       
 19636         Reviewed by gramps.
       
 19637 
       
 19638         Fix http://www.tvguide.com/ "LAUNCH VIDEO & PHOTO PLAYER" button.
       
 19639         Make "javascript" URL scheme string compare case insensitive.
       
 19640 
       
 19641         * plugins/win/PluginStreamWin.cpp:
       
 19642         (WebCore::PluginStreamWin::startStream): Use strcmpi.
       
 19643         * plugins/win/PluginViewWin.cpp:
       
 19644         (WebCore::scriptStringIfJavaScriptURL): Use strcmpi.
       
 19645 
       
 19646 2007-06-01  Anders Carlsson  <andersca@apple.com>
       
 19647 
       
 19648         Reviewed by Steve.
       
 19649 
       
 19650         If the value exists but is empty, return an empty String.
       
 19651         
       
 19652         * plugins/win/PluginPackageWin.cpp:
       
 19653         (WebCore::getVersionInfo):
       
 19654 
       
 19655 2007-06-01  Anders Carlsson  <andersca@apple.com>
       
 19656 
       
 19657         Reviewed by Steve.
       
 19658 
       
 19659         Add the default path for the new WMP Firefox plugin.
       
 19660 
       
 19661         * plugins/win/PluginDatabaseWin.cpp:
       
 19662         (WebCore::addWindowsMediaPlayerPluginPath):
       
 19663 
       
 19664 2007-05-31  Sam Weinig  <sam@webkit.org>
       
 19665 
       
 19666         Fixed build.
       
 19667 
       
 19668         * WebCore.vcproj/WebCore.vcproj:
       
 19669 
       
 19670 2007-05-31  Sam Weinig  <sam@webkit.org>
       
 19671 
       
 19672         Fixed build.
       
 19673 
       
 19674         * WebCore.vcproj/WebCore.vcproj:
       
 19675 
       
 19676 2007-05-30  Ada Chan  <adachan@apple.com>
       
 19677 
       
 19678         Reviewed by Adam.
       
 19679 
       
 19680         Fixed build.
       
 19681 
       
 19682         * platform/win/PopupMenuWin.cpp:
       
 19683         (WebCore::PopupMenu::itemWritingDirectionIsNatural):
       
 19684 
       
 19685 2007-05-30  Sam Weinig  <sam@webkit.org>
       
 19686 
       
 19687         Build Fix.
       
 19688 
       
 19689         * WebCore.vcproj/WebCore.vcproj:
       
 19690 
       
 19691 2007-05-29  Sam Weinig  <sam@webkit.org>
       
 19692 
       
 19693         Fix the build.
       
 19694 
       
 19695         * WebCore.vcproj/WebCore.vcproj:
       
 19696 
       
 19697 2007-05-29  Anders Carlsson  <andersca@apple.com>
       
 19698 
       
 19699         Reviewed by Adam.
       
 19700 
       
 19701         <rdar://4782915> plugin is not in the right place at jumble.com/play.html
       
 19702 
       
 19703         Pass the plugin window coordinates for windowed plugins too.
       
 19704         
       
 19705         * plugins/win/PluginViewWin.cpp:
       
 19706         (WebCore::PluginViewWin::setNPWindowRect):
       
 19707 
       
 19708 2007-05-29  Anders Carlsson  <andersca@apple.com>
       
 19709 
       
 19710         Reviewed by Adam.
       
 19711 
       
 19712         <rdar://problem/4761543> nike.com doesn't finish loading if Flash plugin is installed
       
 19713         <rdar://problem/5131528> play button on Flash in ESPN front page does not start movie
       
 19714         
       
 19715         Make sure to call NPP_SetWindow right after creating the plugin, and not from the main loop. However,
       
 19716         the WMP plugin needs to have the plugin's window coordinates set correctly when calling NPP_SetWindow so add a 
       
 19717         quirk for that.
       
 19718         
       
 19719         * plugins/win/PluginViewWin.cpp:
       
 19720         (WebCore::PluginViewWin::determineQuirks):
       
 19721         (WebCore::PluginViewWin::init):
       
 19722         * plugins/win/PluginViewWin.h:
       
 19723         (WebCore::):
       
 19724 
       
 19725 2007-05-29  Sam Weinig  <sam@webkit.org>
       
 19726 
       
 19727         Reviewed by Adam Roben.
       
 19728 
       
 19729         - Removes platform/win/NotImplemented.h because we have consolidated
       
 19730           the notImplemented() for all platforms in platform/NotImplemented.h
       
 19731         - Fixes remaining uses of old macro to use the new notImplemented() one.
       
 19732 
       
 19733         * WebCore.vcproj/WebCore.vcproj:
       
 19734         * page/win/EventHandlerWin.cpp:
       
 19735         (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
       
 19736         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
       
 19737         (WebCore::SVGResourceFilter::prepareFilter):
       
 19738         (WebCore::SVGResourceFilter::applyFilter):
       
 19739         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
       
 19740         (WebCore::SVGResourceMasker::applyMask):
       
 19741         * platform/win/GraphicsContextWin.cpp:
       
 19742         (WebCore::contextForImage):
       
 19743         * platform/win/NotImplemented.h: Removed.
       
 19744         * platform/win/SearchPopupMenuWin.cpp:
       
 19745         (WebCore::SearchPopupMenu::saveRecentSearches):
       
 19746         (WebCore::SearchPopupMenu::loadRecentSearches):
       
 19747         * platform/win/TemporaryLinkStubs.cpp:
       
 19748         (Frame::print):
       
 19749         (Frame::issueTransposeCommand):
       
 19750         (GraphicsContextPlatformPrivate::clip):
       
 19751         (WebCore::FrameView::updateBorder):
       
 19752         (Widget::setIsSelected):
       
 19753         (ScrollView::inWindow):
       
 19754         (WebCore::focusRingColor):
       
 19755         (WebCore::setFocusRingColorChangeFunction):
       
 19756         (Frame::setNeedsReapplyStyles):
       
 19757         (FrameLoader::overrideMediaType):
       
 19758         (DocumentLoader::getResponseModifiedHeader):
       
 19759         (ResourceHandle::willLoadFromCache):
       
 19760         (WebCore::userIdleTime):
       
 19761         (CachedPage::close):
       
 19762         (WebCore::supportedKeySizes):
       
 19763         (WebCore::signedPublicKeyAndChallengeString):
       
 19764         * plugins/win/PluginViewWin.cpp:
       
 19765         (WebCore::PluginViewWin::newStream):
       
 19766         (WebCore::PluginViewWin::write):
       
 19767         (WebCore::PluginViewWin::setValue):
       
 19768 
       
 19769 2007-05-29  Anders Carlsson  <andersca@apple.com>
       
 19770 
       
 19771         Build fix.
       
 19772         
       
 19773         * rendering/RenderThemeSafari.cpp:
       
 19774         (WebCore::RenderThemeSafari::adjustSliderThumbStyle):
       
 19775 
       
 19776 2007-05-29  Anders Carlsson  <andersca@apple.com>
       
 19777 
       
 19778         Reviewed by Adam.
       
 19779 
       
 19780         Port code from open source changeset 21808, fixing
       
 19781         http://bugs.webkit.org/show_bug.cgi?id=13871 
       
 19782         
       
 19783         * rendering/RenderThemeSafari.cpp:
       
 19784         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
       
 19785         * rendering/RenderThemeSafari.h:
       
 19786 
       
 19787 2007-05-29  Ada Chan  <adachan@apple.com>
       
 19788 
       
 19789         Build fix.
       
 19790         - Added "$(ProjectDir)..\platform\win" to include paths
       
 19791         - Added WebCore\bindings\js\JSCSSStyleDeclarationCustom.cpp to project
       
 19792 
       
 19793         * WebCore.vcproj/WebCore.vcproj:
       
 19794 
       
 19795 2007-05-28  Sam Weinig  <sam@webkit.org>
       
 19796 
       
 19797         Build fix.
       
 19798 
       
 19799         * WebCore.vcproj/WebCore.vcproj:
       
 19800 
       
 19801 2007-05-27  Sam Weinig  <sam@webkit.org>
       
 19802 
       
 19803         Build fix.
       
 19804 
       
 19805         * WebCore.vcproj/WebCore.vcproj:
       
 19806 
       
 19807 2007-05-24  Geoffrey Garen  <ggaren@apple.com>
       
 19808 
       
 19809         Reviewed by Darin Adler.
       
 19810 
       
 19811         Fixed a bug with Settings where a number of different objects held bare 
       
 19812         Settings* data members, even though the Page owns the Settings object and 
       
 19813         deletes it upon destruction.
       
 19814 
       
 19815         Added NULL checks since the Page can be deleted before the frame/document.
       
 19816 
       
 19817         * plugins/win/PluginViewWin.cpp:
       
 19818         (WebCore::PluginViewWin::load):
       
 19819 
       
 19820 2007-05-24  Sam Weinig  <sam@webkit.org>
       
 19821 
       
 19822         Reviewed by NOBODY.
       
 19823 
       
 19824         Build fix.
       
 19825 
       
 19826         * WebCore.vcproj/WebCore.vcproj:
       
 19827 
       
 19828 2007-05-24  Anders Carlsson  <andersca@apple.com>
       
 19829 
       
 19830         Reviewed by Adam.
       
 19831 
       
 19832         <rdar://5211882>
       
 19833         Need to relaunch Boomer to recognize newly installed QT plug-in
       
 19834         
       
 19835         <rdar://5061867>
       
 19836         After installing Flash, Safari would still not display pages that needed it
       
 19837         
       
 19838         * plugins/win/PluginDatabaseWin.cpp:
       
 19839         (WebCore::PluginDatabaseWin::refresh):
       
 19840         Return whether the plugin database changed or not.
       
 19841         
       
 19842         (WebCore::PluginDatabaseWin::findPlugin):
       
 19843         New function that tries to find a plug-in given its url and MIME type.
       
 19844         
       
 19845         (WebCore::PluginDatabaseWin::createPluginView):
       
 19846         If no plugin is found, refresh the database and search for the plugin again if the database changed.
       
 19847         
       
 19848 2007-05-24  Adele Peterson  <adele@apple.com>
       
 19849 
       
 19850         - fix http://bugs.webkit.org/show_bug.cgi?id=13837
       
 19851           Separator in new <select> widget disappears when block element with border is in document.
       
 19852 
       
 19853         * rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButton):
       
 19854          Added calls to set the stroke style and thickness when painting the arrows and the separator.
       
 19855 
       
 19856 2007-05-24  Sam Weinig  <sam@webkit.org>
       
 19857 
       
 19858         Build fix.
       
 19859 
       
 19860         * WebCore.vcproj/WebCore.vcproj:
       
 19861 
       
 19862 2007-05-23  Sam Weinig  <sam@webkit.org>
       
 19863 
       
 19864         Build fix.
       
 19865 
       
 19866         * WebCore.vcproj/WebCore.vcproj:
       
 19867 
       
 19868 2007-05-23  Anders Carlsson  <andersca@apple.com>
       
 19869 
       
 19870         Fix build.
       
 19871         
       
 19872         * platform/win/CursorWin.cpp:
       
 19873         (WebCore::zoomInCursor):
       
 19874         (WebCore::zoomOutCursor):
       
 19875 
       
 19876 2007-05-22  Ada Chan  <adachan@apple.com>
       
 19877 
       
 19878         Fix build.
       
 19879 
       
 19880         * plugins/win/PluginViewWin.cpp:
       
 19881         (WebCore::PluginViewWin::handleMouseEvent):
       
 19882 
       
 19883 2007-05-22  Justin Garcia  <justin.garcia@apple.com>
       
 19884 
       
 19885         Reviewed by oliver
       
 19886 
       
 19887         Build fix.
       
 19888 
       
 19889         * plugins/win/PluginViewWin.cpp:
       
 19890         (WebCore::PluginViewWin::handleMouseEvent): 
       
 19891 
       
 19892 2007-05-21  Sam Weinig  <sam@webkit.org>
       
 19893 
       
 19894         Reviewed by Oliver.
       
 19895 
       
 19896         Build fix.
       
 19897 
       
 19898         * WebCore.vcproj/WebCore.vcproj:
       
 19899 
       
 19900 2007-05-21  Sam Weinig  <sam@webkit.org>
       
 19901 
       
 19902         Reviewed by Adam.
       
 19903 
       
 19904         Build fix.
       
 19905 
       
 19906         * WebCore.vcproj/WebCore.vcproj:
       
 19907 
       
 19908 2007-05-17  Steve Falkenburg  <sfalken@apple.com>
       
 19909 
       
 19910         Reviewed by Geoff, Adam.
       
 19911 
       
 19912         Use precompiled headers (via WebCorePrefix.h) to speed up WebCoreWin builds.
       
 19913         This improved WebCore debug rebuild time from 40 minutes to 25 for me.
       
 19914         
       
 19915         A few files needed to be excluded, since they didn't build properly with
       
 19916         the prefix file: ColorData.c, CSSGrammar.cpp, HTMLEntityNames.c, XPathGrammar.cpp, XPathParser.cpp.
       
 19917 
       
 19918         * WebCore.vcproj/WebCore.vcproj: Turn on precompiled header, force includes flags.
       
 19919         * WebCorePrefix.cpp: Added.
       
 19920         * WebCorePrefix.h: Added.
       
 19921         * config.h: Modified to be compatible with WebCorePrefix.h.
       
 19922 
       
 19923 2007-05-18  Sam Weinig  <sam@webkit.org>
       
 19924 
       
 19925         Reviewed by Adam.
       
 19926 
       
 19927         Fixing the vcproj paths.
       
 19928 
       
 19929         * WebCore.vcproj/WebCore.vcproj:
       
 19930 
       
 19931 2007-05-18  Sam Weinig  <sam@webkit.org>
       
 19932 
       
 19933         Reviewed by Geoff.
       
 19934 
       
 19935         Build fix after r21577.
       
 19936 
       
 19937         * WebCore.vcproj/WebCore.vcproj:
       
 19938 
       
 19939 2007-05-18  Adam Roben  <aroben@apple.com>
       
 19940 
       
 19941         Build fix after r21562.
       
 19942 
       
 19943         * platform/win/TemporaryLinkStubs.cpp:
       
 19944         * platform/win/WidgetWin.cpp:
       
 19945         * plugins/win/PluginViewWin.cpp:
       
 19946         * plugins/win/PluginViewWin.h:
       
 19947 
       
 19948 2007-05-18  Anders Carlsson  <andersca@apple.com>
       
 19949 
       
 19950         Reviewed by Geoff.
       
 19951         
       
 19952         <rdar://problem/4914940> Some plugins won't redraw correctly when scrolling
       
 19953         
       
 19954         This patch does two things:
       
 19955         
       
 19956         1. It comments out the call to set the window's region to an empty region while it's being moved. This was done to prevent
       
 19957         the QT plugin from drawing outside its bounds when scrolling it when it's inside an iframe or div with overflow.
       
 19958         
       
 19959         2. It lets Windows handle its invalid region when moving the window and setting its new window region.
       
 19960         
       
 19961         * plugins/win/PluginViewWin.cpp:
       
 19962         (WebCore::PluginViewWin::updateWindow):
       
 19963 
       
 19964 2007-05-18  Adam Roben  <aroben@apple.com>
       
 19965 
       
 19966         Build fix after r21555.
       
 19967 
       
 19968         * page/win/EventHandlerWin.cpp:
       
 19969         (WebCore::EventHandler::passMouseMoveEventToSubframe):
       
 19970 
       
 19971 2007-05-17  Sam Weinig  <sam@webkit.org>
       
 19972 
       
 19973         Reviewed by Adam.
       
 19974 
       
 19975         Build Fix after <rdar://problem/5201423>
       
 19976 
       
 19977         * WebCore.vcproj/WebCore.vcproj:
       
 19978 
       
 19979 2007-05-17  Adele Peterson  <adele@apple.com>
       
 19980 
       
 19981         Reviewed by Hyatt.
       
 19982 
       
 19983         Follow up to <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
       
 19984 
       
 19985         * platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
       
 19986           Use the clientStyle to determine how to handle bidi text.  For popup buttons, which we restrict to LTR,
       
 19987           we will match the button text.
       
 19988 
       
 19989 2007-05-17  Anders Carlsson  <andersca@apple.com>
       
 19990 
       
 19991         Reviewed by Darin.
       
 19992 
       
 19993         <rdar://problem/5210600> New WMP plugin doesn't show any contents
       
 19994 
       
 19995         Call NPP_SetWindow after the window's size has been updated.
       
 19996         
       
 19997         * plugins/win/PluginViewWin.cpp:
       
 19998         (WebCore::PluginViewWin::setFrameGeometry):
       
 19999 
       
 20000 2007-05-17  Anders Carlsson  <andersca@apple.com>
       
 20001 
       
 20002         Reviewed by John.
       
 20003 
       
 20004         <rdar://problem/5204016> Repro crash on nytimes.com in MimeTypeRegistry::getMIMETypeForExtension
       
 20005         
       
 20006         Return null if the extension is null.
       
 20007         
       
 20008         * platform/win/MimeTypeRegistryWin.cpp:
       
 20009         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
       
 20010 
       
 20011 2007-05-16  Adele Peterson  <adele@apple.com>
       
 20012 
       
 20013         Reviewed by Hyatt.
       
 20014 
       
 20015         Fix for:
       
 20016             <rdar://problem/5092645> PopupMenuWin needs bidiReorderCharacters logic from RenderListBox
       
 20017             <rdar://problem/5205654> Select popup menus should always be ltr to match the mac
       
 20018 
       
 20019         * platform/win/PopupMenuWin.cpp:
       
 20020         (WebCore::PopupMenu::show): Remove special cases for RTL menus, since we are always going to left align.
       
 20021         (WebCore::PopupMenu::calculatePositionAndSize): ditto.
       
 20022         (WebCore::PopupMenu::paint): Added call to bidiReorderCharacters.
       
 20023 
       
 20024 2007-05-14  Oliver Hunt  <oliver@apple.com>
       
 20025 
       
 20026         Reviewed by Sam.
       
 20027 
       
 20028         Fix for <rdar://problem/5147895> REGRESSION: Content-Disposition: filename is ignored for drag-and-drop.
       
 20029 
       
 20030         If the image does not already have a title, fall back to the 
       
 20031         name suggested by Content-Disposition.
       
 20032 
       
 20033         * platform/win/ClipboardWin.cpp:
       
 20034         (WebCore::createGlobalImageFileDescriptor):
       
 20035 
       
 20036 2007-05-14  Oliver Hunt  <oliver@apple.com>
       
 20037 
       
 20038         Reviewed by Sam.
       
 20039 
       
 20040         Fix for <rdar://problem/5202805> Null dereference in createGlobalData(CString str)
       
 20041         
       
 20042         Null terminate manually to prevent us from dereferencing null.
       
 20043 
       
 20044         * platform/win/ClipboardUtilitiesWin.cpp:
       
 20045         (WebCore::createGlobalData):
       
 20046 
       
 20047 2007-05-14  Oliver Hunt  <oliver@apple.com>
       
 20048 
       
 20049         Reviewed by Geoff.
       
 20050 
       
 20051         Windows side of fix for
       
 20052         <rdar://problem/4728842> Can't drag-and-drop files onto <input type="file">
       
 20053 
       
 20054         * platform/win/ClipboardUtilitiesWin.cpp:
       
 20055         (WebCore::cfHDropFormat):
       
 20056           Need to be able to access externally
       
 20057           
       
 20058         * platform/win/ClipboardUtilitiesWin.h:
       
 20059           Declare cfHDropFormat
       
 20060           
       
 20061         * platform/win/DragDataWin.cpp:
       
 20062         (WebCore::DragData::containsFiles):
       
 20063         (WebCore::DragData::asFilenames):
       
 20064           Add implementation of containsFiles and asFilenames
       
 20065 
       
 20066 2007-05-14  Geoffrey Garen  <ggaren@apple.com>
       
 20067 
       
 20068         Build fix.
       
 20069 
       
 20070         * WebCore.vcproj/WebCore.vcproj:
       
 20071 
       
 20072 2007-05-14  Anders Carlsson  <andersca@apple.com>
       
 20073 
       
 20074         Reviewed by Geoff.
       
 20075 
       
 20076         <rdar://problem/5176940> Seed10: MS Silverlight 1.0 beta plug-in is not supported
       
 20077         
       
 20078         * plugins/win/PluginDatabaseWin.cpp:
       
 20079         (WebCore::addPluginsFromRegistry):
       
 20080         New function that adds plugins from the registry from HKEY_LOCAL_MACHINE/MozillaPlugins.
       
 20081 
       
 20082         * plugins/win/PluginViewWin.cpp:
       
 20083         (WebCore::PluginViewWin::invalidateRect):
       
 20084         (WebCore::PluginViewWin::forceRedraw):
       
 20085         Make these work with windowed plugins.
       
 20086         
       
 20087 2007-05-13  Darin Adler  <darin@apple.com>
       
 20088 
       
 20089         Requested by Hyatt.
       
 20090 
       
 20091         - internal part of http://bugs.webkit.org/show_bug.cgi?id=13529
       
 20092           DOM3 keyIdentifier text is incorrect
       
 20093 
       
 20094         * platform/win/KeyEventWin.cpp:
       
 20095         (WebCore::keyIdentifierForWindowsKeyCode): Use 4 digits for "U+" stuff.
       
 20096 
       
 20097 2007-05-12  Oliver Hunt  <oliver@apple.com>
       
 20098 
       
 20099         rs=hyatt.
       
 20100 
       
 20101         Stubs to prevent build bustage
       
 20102 
       
 20103         * platform/win/DragDataWin.cpp:
       
 20104         (WebCore::DragData::containsFiles):
       
 20105         (WebCore::DragData::asFilenames):
       
 20106 
       
 20107 2007-05-11  Darin Adler  <darin@apple.com>
       
 20108 
       
 20109         * WebCore.vcproj/WebCore.vcproj: Added new RenderWordBreak.cpp/h files.
       
 20110 
       
 20111 2007-05-10  Adele Peterson  <adele@apple.com>
       
 20112 
       
 20113         Reviewed by Hyatt.
       
 20114 
       
 20115         * bridge/win/FrameWin.cpp:
       
 20116         (WebCore::imageFromSelection): Updated to use selectionRect instead of visibleSelectionRect
       
 20117         
       
 20118 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
       
 20119 
       
 20120         Rubber-stamped by Geoff.
       
 20121 
       
 20122         Moved shared EditorWin code to Editor.cpp in open source.
       
 20123 
       
 20124         * platform/win/EditorWin.cpp: Deleted (moved) most of this file.
       
 20125 
       
 20126 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
       
 20127 
       
 20128         Reviewed by Darin, Oliver.
       
 20129 
       
 20130         Removed localized string stubs.
       
 20131 
       
 20132         * platform/win/TemporaryLinkStubs.cpp:
       
 20133 
       
 20134 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
       
 20135 
       
 20136         Reviewed by Ada.
       
 20137 
       
 20138         Updated for new editor interface.
       
 20139 
       
 20140         * platform/win/EditorWin.cpp:
       
 20141         (WebCore::Editor::advanceToNextMisspelling):
       
 20142         (WebCore::isRangeUngrammatical):
       
 20143 
       
 20144 2007-05-07  Alice Liu  <alice.liu@apple.com>
       
 20145 
       
 20146         Reviewed by Oliver.
       
 20147 
       
 20148         Fixed <rdar://5087119> Paste fidelity isn't as good as it is on the mac
       
 20149         and <rdar://5087118> Plain text copy/paste yields bad line endings on Boomer
       
 20150         and re-organized standalone functions in DragDataWin.cpp and PasteboardWin.cpp
       
 20151         into ClipboardUtilitiesWin.h/cpp.
       
 20152 
       
 20153         * WebCore.vcproj/WebCore.vcproj:
       
 20154         * platform/win/ClipboardUtilitiesWin.cpp: Added.
       
 20155         (WebCore::cfHDropFormat):
       
 20156         (WebCore::getWebLocData):
       
 20157         (WebCore::extractURL):
       
 20158         (WebCore::texthtmlFormat):
       
 20159         (WebCore::createGlobalData):
       
 20160         (WebCore::markupToCF_HTML):
       
 20161         (WebCore::urlToMarkup):
       
 20162         (WebCore::replaceNewlinesWithWindowsStyleNewlines):
       
 20163         (WebCore::replaceNBSPWithSpace):
       
 20164         (WebCore::urlWFormat):
       
 20165         (WebCore::urlFormat):
       
 20166         (WebCore::plainTextFormat):
       
 20167         (WebCore::plainTextWFormat):
       
 20168         (WebCore::filenameWFormat):
       
 20169         (WebCore::filenameFormat):
       
 20170         (WebCore::htmlFormat):
       
 20171         (WebCore::getURL):
       
 20172         (WebCore::getPlainText):
       
 20173         (WebCore::fragmentFromFilenames):
       
 20174         (WebCore::containsFilenames):
       
 20175         (WebCore::fragmentFromCF_HTML):
       
 20176         (WebCore::fragmentFromHTML):
       
 20177         (WebCore::containsHTML):
       
 20178         * platform/win/ClipboardUtilitiesWin.h: Added.
       
 20179         * platform/win/ClipboardWin.cpp:
       
 20180         (WebCore::ClipboardWin::writeRange):
       
 20181         * platform/win/DragDataWin.cpp:
       
 20182         * platform/win/PasteboardWin.cpp:
       
 20183         (WebCore::Pasteboard::writeSelection):
       
 20184         (WebCore::Pasteboard::documentFragment):
       
 20185 
       
 20186 2007-05-04  Steve Falkenburg  <sfalken@apple.com>
       
 20187 
       
 20188         Reviewed by Darin.
       
 20189 
       
 20190         Fix crash when using "check spelling while typing".
       
 20191 
       
 20192         * WebCore.vcproj/WebCore.vcproj: Added TextBreakIteratorInternalICUWin.cpp
       
 20193         * platform/win/TemporaryLinkStubs.cpp: Removed findSentenceBoundary, findNextSentenceFromIndex.
       
 20194 
       
 20195 2007-05-04  Alice Liu  <alice.liu@apple.com>
       
 20196 
       
 20197         Reviewed by Darin.
       
 20198 
       
 20199         changed use of DeprecatedString::fromUTF8 to UTF8Encoding().decode()
       
 20200 
       
 20201         * platform/win/DragDataWin.cpp:
       
 20202         (WebCore::fragmentFromHTML):
       
 20203         * platform/win/PasteboardWin.cpp:
       
 20204         (WebCore::Pasteboard::documentFragment):
       
 20205 
       
 20206 2007-05-03  Steve Falkenburg  <sfalken@apple.com>
       
 20207 
       
 20208         Reviewed by Ada, Oliver.
       
 20209 
       
 20210         Checkpoint:
       
 20211         <rdar://problem/4602372> Spelling
       
 20212         <rdar://problem/4769763> Spell checking engine support
       
 20213 
       
 20214         * platform/win/EditorWin.cpp:
       
 20215         (WebCore::findFirstBadGrammarInRange): Account for start offset when reporting bad grammar range (fixed my porting mistake).
       
 20216         (WebCore::Editor::advanceToNextMisspelling): Include user description with spelling error.
       
 20217         (WebCore::isRangeUngrammatical): Include user description with spelling error.
       
 20218 
       
 20219 2007-05-03  Alice Liu  <alice.liu@apple.com>
       
 20220 
       
 20221         Reviewed by Oliver.
       
 20222 
       
 20223         Fixed <rdar://5181466> HTML formatted clipboard data is not converted from UTF8 when pasted
       
 20224 
       
 20225         * platform/win/DragDataWin.cpp:
       
 20226         (WebCore::fragmentFromHTML):
       
 20227         * platform/win/PasteboardWin.cpp:
       
 20228         (WebCore::fragmentFromCF_HTML):
       
 20229         (WebCore::Pasteboard::documentFragment):
       
 20230 
       
 20231 2007-05-03  Oliver Hunt  <oliver@apple.com>
       
 20232 
       
 20233         Reviewed by Steve
       
 20234 
       
 20235         Fix misuse of GlobalLock.
       
 20236 
       
 20237         * platform/win/PasteboardWin.cpp:
       
 20238         (WebCore::createGlobalData):
       
 20239 
       
 20240 2007-05-03  Oliver Hunt  <oliver@apple.com>
       
 20241 
       
 20242         Reviewed by Steve.
       
 20243 
       
 20244         Add logic to draw underlines for grammar and spelling errors.
       
 20245         (rdar://problem/4769832)
       
 20246 
       
 20247         * platform/win/GraphicsContextWin.cpp:
       
 20248         (WebCore::spellingPatternColor):
       
 20249         (WebCore::grammarPatternColor):
       
 20250           Can't define global const with constructor so use function scoped globals instead.
       
 20251         (WebCore::setCGStrokeColor):
       
 20252           Utility function pulled over from GraphicsContextCG          
       
 20253         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
       
 20254         
       
 20255         * platform/win/TemporaryLinkStubs.cpp:
       
 20256           Remove old drawLineForMisspellingOrBadGrammar stub
       
 20257 
       
 20258 2007-05-01  Steve Falkenburg  <sfalken@apple.com>
       
 20259 
       
 20260         Reviewed by Oliver.
       
 20261 
       
 20262         Fix crash when retrieving title of context menu after it has been selected.
       
 20263         Necessary to get spelling corrections code working.
       
 20264 
       
 20265         * platform/win/ContextMenuWin.cpp:
       
 20266         (WebCore::ContextMenu::itemWithAction): menu item info fType is a set of flags, MFT_STRING is 0, so we need to or off flags before comparing.
       
 20267 
       
 20268 2007-04-29  Adam Roben  <aroben@apple.com>
       
 20269 
       
 20270         Build fix after r21183.
       
 20271 
       
 20272         * WebCore.vcproj/WebCore.vcproj: Added LayoutState.(h|cpp).
       
 20273 
       
 20274 2007-04-29  Oliver Hunt  <oliver@apple.com>
       
 20275 
       
 20276         Reviewed by Steve.
       
 20277 
       
 20278         Fix for <rdar://problem/5126393> REGRESSION (r19672-19697): Safari drag image drags at original size (13261)
       
 20279  
       
 20280         Prevent build bustage from opensource changes, correct scaling
       
 20281 
       
 20282         * platform/win/DragImageWin.cpp:
       
 20283         (WebCore::scaleDragImage):
       
 20284 
       
 20285 2007-04-24  Steve Falkenburg  <sfalken@apple.com>
       
 20286 
       
 20287         Reviewed by Darin, Oliver.
       
 20288 
       
 20289         Checkpoint:
       
 20290         <rdar://problem/4602372> Spelling
       
 20291         <rdar://problem/4769763> Spell checking engine support
       
 20292         
       
 20293         Ported code from EditorMac.mm into EditorWin.cpp.
       
 20294         Once this works, I'll move this code into Editor.cpp and remove it
       
 20295         form EditorMac.mm.
       
 20296 
       
 20297         * platform/win/EditorWin.cpp:
       
 20298         (WebCore::Editor::ignoreSpelling):
       
 20299         (WebCore::Editor::learnSpelling):
       
 20300         (WebCore::findFirstMisspellingInRange):
       
 20301         (WebCore::paragraphAlignedRangeForRange):
       
 20302         (WebCore::findFirstGrammarDetailInRange):
       
 20303         (WebCore::findFirstBadGrammarInRange):
       
 20304         (WebCore::Editor::advanceToNextMisspelling):
       
 20305         (WebCore::Editor::isSelectionMisspelled):
       
 20306         (WebCore::isRangeUngrammatical):
       
 20307         (WebCore::Editor::isSelectionUngrammatical):
       
 20308         (WebCore::Editor::guessesForUngrammaticalSelection):
       
 20309         (WebCore::Editor::guessesForMisspelledSelection):
       
 20310         (WebCore::Editor::showSpellingGuessPanel):
       
 20311         (WebCore::Editor::spellingPanelIsShowing):
       
 20312         (WebCore::Editor::markMisspellingsAfterTypingToPosition):
       
 20313         (WebCore::markAllMisspellingsInRange):
       
 20314         (WebCore::markAllBadGrammarInRange):
       
 20315         (WebCore::markMisspellingsOrBadGrammar):
       
 20316         (WebCore::Editor::markMisspellings):
       
 20317         (WebCore::Editor::markBadGrammar):
       
 20318         * platform/win/TemporaryLinkStubs.cpp:
       
 20319 
       
 20320 2007-04-23  Anders Carlsson  <andersca@apple.com>
       
 20321 
       
 20322         Reviewed by Ada.
       
 20323 
       
 20324         <rdar://problem/5061022>
       
 20325         REGRESSION: Acrobat 8 plug-in fails to scroll with trackpad two-finger scroll or mouse wheel (12995)
       
 20326         
       
 20327         * page/win/EventHandlerWin.cpp:
       
 20328         (WebCore::EventHandler::passWheelEventToWidget):
       
 20329         Get rid of passWheelEventToSubframe and pass wheel events to all widgets.
       
 20330 
       
 20331 2007-04-23  Adam Roben  <aroben@apple.com>
       
 20332 
       
 20333         Build fix.
       
 20334 
       
 20335         * page/win/EventHandlerWin.cpp: Removed passWheelEventToSubframe.
       
 20336 
       
 20337 2007-04-20  Beth Dakin  <bdakin@apple.com>
       
 20338 
       
 20339         Reviewed by Adam.
       
 20340 
       
 20341         Fix for <rdar://problem/5089822> Boomer does not send scroll events
       
 20342 
       
 20343         * platform/win/ScrollViewWin.cpp:
       
 20344         (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
       
 20345 
       
 20346 2007-04-19  Adam Roben  <aroben@apple.com>
       
 20347 
       
 20348         * WebCore.vcproj/WebCore.vcproj: Removed empty filter.
       
 20349 
       
 20350 2007-04-19  Adam Roben  <aroben@apple.com>
       
 20351 
       
 20352         * WebCore.vcproj/WebCore.vcproj: Removed unused files.
       
 20353 
       
 20354 2007-04-18  Adam Roben  <aroben@apple.com>
       
 20355 
       
 20356         Reviewed by Oliver.
       
 20357 
       
 20358         Added an equality operator to COMPtr.
       
 20359 
       
 20360         * platform/win/COMPtr.h:
       
 20361         (operator==):
       
 20362         (operator!=):
       
 20363 
       
 20364 2007-04-18  Oliver Hunt  <oliver@apple.com>
       
 20365 
       
 20366         Reviewed by Geoff.
       
 20367 
       
 20368         Allow images to be dragged from page and dropped as files.
       
 20369         This is the remainder of the fix for <rdar://problem/5035948> 
       
 20370           -- Dragging image or link from boomer doesn't create webloc 
       
 20371              or image file.
       
 20372 
       
 20373         * platform/win/ClipboardWin.cpp:
       
 20374         (WebCore::filesystemPathFromUrlOrTitle):
       
 20375           Make name generation nicer, and better match Firefox
       
 20376         
       
 20377         (WebCore::createGlobalURLContent):
       
 20378           rename function
       
 20379         
       
 20380         (WebCore::createGlobalImageFileContent):
       
 20381           Copies image data into global store
       
 20382         
       
 20383         (WebCore::createGlobalUrlFileDescriptor):
       
 20384           Rename function
       
 20385           Updated for parameter change on filesystemPathFromUrlOrTitle
       
 20386         
       
 20387         (WebCore::createGlobalImageFileDescriptor):
       
 20388           Set up file descriptor for image drag
       
 20389         
       
 20390         (WebCore::getCachedImage):
       
 20391           Helper function
       
 20392         
       
 20393         (WebCore::writeImageToDataObject):
       
 20394           Attempts to build and insert data for image->file drag
       
 20395         
       
 20396         (WebCore::ClipboardWin::declareAndWriteDragImage):
       
 20397           Attempts to build and insert data for image->file drag
       
 20398         
       
 20399         (WebCore::ClipboardWin::writeURL):
       
 20400           Add call to imageDataToDataObject
       
 20401 
       
 20402 2007-04-17  Adam Roben  <aroben@apple.com>
       
 20403 
       
 20404         Rubberstamped by Oliver.
       
 20405 
       
 20406         * platform/network/cf/ResourceHandleCFNet.cpp: Removed an unnecessary
       
 20407         include.
       
 20408 
       
 20409 2007-04-17  Oliver Hunt  <oliver@apple.com>
       
 20410 
       
 20411         Whoops, had code commented out from manual failure test.
       
 20412         Also fixed date of previous changelog entry
       
 20413 
       
 20414         * platform/win/ClipboardWin.cpp:
       
 20415         (WebCore::writeFileToDataObject):
       
 20416 
       
 20417 2007-04-17  Oliver Hunt  <oliver@apple.com>
       
 20418 
       
 20419         Reviewed by Ada.
       
 20420 
       
 20421         Partial fix for <rdar://problem/5035948> -- Dragging image 
       
 20422         or link from boomer doesn't create webloc or image file.
       
 20423         
       
 20424         Add all the ground work to set up FileDescriptors and FileContent
       
 20425         for allowing files to be created from drag and drop actions,
       
 20426         and hook up logic for links to create WebLoc data for drag and drop.
       
 20427 
       
 20428         * platform/win/ClipboardWin.cpp:
       
 20429         (WebCore::fileDescriptorFormat):
       
 20430         (WebCore::fileContentFormat):
       
 20431           Clipboard formats 
       
 20432           
       
 20433         (WebCore::pathRemoveBadFSCharacters):
       
 20434         (WebCore::filesystemPathFromUrlOrTitle):
       
 20435           Helper functions for create filenames
       
 20436           
       
 20437         (WebCore::createGlobalDataForURLContent):
       
 20438           Create the WebLoc content
       
 20439           
       
 20440         (WebCore::createGlobalDataForUrlFileDescriptor):
       
 20441           Create a file descriptor for the WebLoc data
       
 20442           
       
 20443         (WebCore::writeFileToDataObject):
       
 20444           Basic helper function to push generated file info
       
 20445           into the target DataObject
       
 20446           
       
 20447         (WebCore::ClipboardWin::writeURL):
       
 20448           Now puts WebLoc file onto the Clipboard
       
 20449 
       
 20450 2007-04-16  Adam Roben  <aroben@apple.com>
       
 20451 
       
 20452         Reviewed by Adele.
       
 20453 
       
 20454         Fix <rdar://problem/5002577> Focus ring SPI in GraphicsContextWin.cpp
       
 20455         needs to move to WebKitSystemInterface
       
 20456 
       
 20457         * platform/win/GraphicsContextWin.cpp:
       
 20458         (WebCore::GraphicsContext::drawFocusRing): Use wkDrawFocusRing.
       
 20459 
       
 20460 2007-04-14  Adam Roben  <aroben@apple.com>
       
 20461 
       
 20462         * WebCore.vcproj/WebCore.submit.sln: Use the Debug_Internal
       
 20463         configuration.
       
 20464 
       
 20465 2007-04-14  Adam Roben  <aroben@apple.com>
       
 20466 
       
 20467         Small correctness fix that is needed for building OpenSource.
       
 20468 
       
 20469         * platform/win/PopupMenuWin.cpp: Use RenderTheme instead of RenderThemeWin.
       
 20470 
       
 20471 2007-04-13  Adam Roben  <aroben@apple.com>
       
 20472 
       
 20473         Reviewed by Tim.
       
 20474 
       
 20475         Sync our config.h with the OpenSource version so we can merge ours in
       
 20476         later.
       
 20477 
       
 20478         * config.h: Added #defines from the OpenSource version, moved
       
 20479         Windows-specific defines inside #if PLATFORM(WIN[_OS]), and got rid
       
 20480         of assert.h
       
 20481         * platform/win/CursorWin.cpp:
       
 20482         (WebCore::Cursor::Cursor): Use ASSERT instead of assert.
       
 20483 
       
 20484 2007-04-13  Adam Roben  <aroben@apple.com>
       
 20485 
       
 20486         Rubberstamped by Tim.
       
 20487 
       
 20488         Removed the loader/win directory since it only contains empty files.
       
 20489 
       
 20490         * WebCore.vcproj/WebCore.vcproj: Removed empty files.
       
 20491         * loader/win/FrameLoaderWin.cpp: Removed.
       
 20492         * loader/win/ResourceLoaderWin.cpp: Removed.
       
 20493 
       
 20494 2007-04-12  Adam Roben  <aroben@apple.com>
       
 20495 
       
 20496         Rubberstamped by Steve.
       
 20497 
       
 20498         Removed unused file.
       
 20499 
       
 20500         * WebCore.vcproj/WebCore.sln: Removed.
       
 20501 
       
 20502 2007-04-12  Adam Roben  <aroben@apple.com>
       
 20503 
       
 20504         Didn't mean to commit this.
       
 20505 
       
 20506         * WebCore.vcproj/WebCore.vcproj:
       
 20507 
       
 20508 2007-04-12  Adam Roben  <aroben@apple.com>
       
 20509 
       
 20510         Reviewed by Steve.
       
 20511 
       
 20512         <rdar://problem/5131565> Need to be able to use debug WebKit with
       
 20513         release Safari.
       
 20514 
       
 20515         * WebCore.vcproj/WebCore.vcproj:
       
 20516         * WebCore.vcproj/debug.vsprops:
       
 20517         * WebCore.vcproj/debug_internal.vsprops: Added.
       
 20518         * WebCore.vcproj/release.vsprops:
       
 20519 
       
 20520 2007-04-11  Adam Roben  <aroben@apple.com>
       
 20521 
       
 20522         Reviewed by Tim.
       
 20523 
       
 20524         Get rid of FrameViewWin.cpp, since it's empty.
       
 20525 
       
 20526         * WebCore.vcproj/WebCore.vcproj:
       
 20527         * bridge/win/FrameViewWin.cpp: Removed.
       
 20528 
       
 20529 2007-04-11  Adam Roben  <aroben@apple.com>
       
 20530 
       
 20531         Reviewed by Anders.
       
 20532 
       
 20533         Update for changes to Pasteboard.
       
 20534 
       
 20535         * platform/win/PasteboardWin.cpp:
       
 20536         (WebCore::Pasteboard::writeImage):
       
 20537 
       
 20538 2007-04-10  Brady Eidson  <beidson@apple.com>
       
 20539 
       
 20540         Reviewed by Darin
       
 20541 
       
 20542         <rdar://problem/4887095> - PageCache and PageState should be combined
       
 20543 
       
 20544         Changed a TemporaryLinkStub and updated the project file
       
 20545 
       
 20546         * WebCore.vcproj/WebCore.vcproj:
       
 20547         * platform/win/TemporaryLinkStubs.cpp:
       
 20548         (CachedPage::close):
       
 20549 
       
 20550 2007-04-10  John Sullivan  <sullivan@apple.com>
       
 20551 
       
 20552         * platform/win/TemporaryLinkStubs.cpp:
       
 20553         (WebCore::Editor::markBadGrammar):
       
 20554         Keep build going: added stub for this new method
       
 20555 
       
 20556 2007-04-10  Anders Carlsson  <andersca@apple.com>
       
 20557 
       
 20558         Reviewed by Adam.
       
 20559 
       
 20560         <rdar://problem/5056988>
       
 20561         Can not open player on http://radioalice.com
       
 20562 
       
 20563         Fix scriptStringIfJavaScriptURL to not use the path of the URL. This would ignore any characters past 
       
 20564         a '?' character because that would be parsed as the query part of the URL.
       
 20565         
       
 20566         * plugins/win/PluginViewWin.cpp:
       
 20567         (WebCore::scriptStringIfJavaScriptURL):
       
 20568         Make this be more like the mac, chopping off the first 12 characters ("javascript:") 
       
 20569         and then decoding the remaining characters.
       
 20570 
       
 20571 2007-04-10  Anders Carlsson  <acarlsson@apple.com>
       
 20572 
       
 20573         * plugins/win/PluginViewWin.cpp:
       
 20574         (WebCore::PluginViewWin::PluginViewWin):
       
 20575         Initialize m_status.
       
 20576 
       
 20577 2007-04-09  Anders Carlsson  <acarlsson@apple.com>
       
 20578 
       
 20579         Reviewed by Adam.
       
 20580 
       
 20581         <rdar://problem/5062624>
       
 20582         No prompt to install QT for pages with uninstalled QT plug-in.
       
 20583         
       
 20584         Add a status() accessor to PluginViewWin. This can be used by WebKit to find out if the plug-in
       
 20585         loaded successfully or not.
       
 20586         
       
 20587         * plugins/win/PluginViewWin.cpp:
       
 20588         (WebCore::PluginViewWin::PluginViewWin):
       
 20589         (WebCore::PluginViewWin::init):
       
 20590         * plugins/win/PluginViewWin.h:
       
 20591         (WebCore::):
       
 20592         (WebCore::PluginViewWin::status):
       
 20593 
       
 20594 2007-04-09  Brady Eidson  <beidson@apple.com>
       
 20595 
       
 20596         Build fix
       
 20597 
       
 20598         * plugins/win/PluginViewWin.cpp:
       
 20599         (WebCore::PluginViewWin::performRequest): assume userGesture is true
       
 20600 
       
 20601 2007-04-09  Adam Roben  <aroben@apple.com>
       
 20602 
       
 20603         Build fix.
       
 20604 
       
 20605         * platform/win/PasteboardWin.cpp:
       
 20606         (WebCore::Pasteboard::writeImage):
       
 20607 
       
 20608 2007-04-08  Adam Roben  <aroben@apple.com>
       
 20609 
       
 20610         Reviewed by Oliver.
       
 20611 
       
 20612         Stubbed out Frame::dashboardRegionsChanged now that it's not
       
 20613         Mac-specific.
       
 20614 
       
 20615         * bridge/win/FrameWin.cpp:
       
 20616         (WebCore::Frame::dashboardRegionsChanged):
       
 20617 
       
 20618 2007-04-06  Oliver Hunt  <oliver@apple.com>
       
 20619 
       
 20620         Reviewed by Adam.
       
 20621 
       
 20622         Fix for rdar://problem/5097227 Can't drag Flash-based 
       
 20623         scrollbar on mtv.com
       
 20624         
       
 20625         The problem was when creating a mouse move event for the 
       
 20626         plugin we weren't passing on the mouse button state.  
       
 20627         
       
 20628         The opensource side of this patch adds logic that allows 
       
 20629         us to distinguish between a MouseEvent with NoButton and
       
 20630         a MouseEvent with LeftButton, so we can then provide the 
       
 20631         correct information to the plugin.
       
 20632 
       
 20633         * plugins/win/PluginViewWin.cpp:
       
 20634         (WebCore::PluginViewWin::handleMouseEvent):
       
 20635 
       
 20636 2007-04-06  Dave Hyatt  <hyatt@apple.com>
       
 20637 
       
 20638         Internal side of fix for bug 13274.
       
 20639 
       
 20640         Reviewed by olliej
       
 20641 
       
 20642         * page/win/EventHandlerWin.cpp:
       
 20643         (WebCore::EventHandler::passMousePressEventToSubframe):
       
 20644         * platform/win/PlatformScrollBarSafari.cpp:
       
 20645         (WebCore::PlatformScrollbar::handleMousePressEvent):
       
 20646         * platform/win/PopupMenuWin.cpp:
       
 20647         (WebCore::PopupMenu::PopupMenu):
       
 20648         (WebCore::PopupWndProc):
       
 20649         * platform/win/ScrollViewWin.cpp:
       
 20650         (WebCore::ScrollView::removeChild):
       
 20651         * platform/win/WidgetWin.cpp:
       
 20652 
       
 20653 2007-04-07  Mark Rowe  <mrowe@apple.com>
       
 20654 
       
 20655         Internal build fox after opensource r20753.
       
 20656 
       
 20657         * platform/win/PlatformMouseEventWin.cpp:
       
 20658         * platform/win/TemporaryLinkStubs.cpp:
       
 20659 
       
 20660 2007-04-03  Oliver Hunt  <oliver@apple.com>
       
 20661 
       
 20662         Buildfix
       
 20663 
       
 20664         * platform/network/cf/ResourceResponseCFNet.cpp:
       
 20665         (WebCore::ResourceResponse::doUpdateResourceResponse):
       
 20666            Adding .get() calls
       
 20667 
       
 20668 2007-04-03  Maciej Stachowiak  <mjs@apple.com>
       
 20669 
       
 20670         Reviewed by Alice.
       
 20671 
       
 20672         - fixed <rdar://problem/5107069> WebCore leaks a copy of the CFHTTPMessage CFDictionary (from CFHTTPMessageCopyAllHeaderFields)
       
 20673 
       
 20674         * platform/network/cf/ResourceResponseCFNet.cpp:
       
 20675         (WebCore::ResourceResponse::doUpdateResourceResponse): Use RetainPtr (once to avoid a leak and once
       
 20676         just as style cleanup).
       
 20677 
       
 20678 2007-04-02  Anders Carlsson  <andersca@apple.com>
       
 20679 
       
 20680         Reviewed by Adam.
       
 20681 
       
 20682         Fix crashes seen when running the plugin layout tests.
       
 20683         
       
 20684         * plugins/win/PluginPackageWin.cpp:
       
 20685         (WebCore::PluginPackageWin::load):
       
 20686         Fill in the enumerate pointer, not the evaluate pointer (it's already been filled in).
       
 20687         
       
 20688         * plugins/win/PluginStreamWin.cpp:
       
 20689         (WebCore::PluginStreamWin::didFinishLoading):
       
 20690         Handle the case where there was no plugin stream data at all.
       
 20691 
       
 20692 2007-04-02  Anders Carlsson  <andersca@apple.com>
       
 20693 
       
 20694         Reviewed by Darin.
       
 20695 
       
 20696         Check that NPStream pointers passed to NPN_DestroyStream are valid.
       
 20697         
       
 20698         * plugins/win/PluginStreamWin.cpp:
       
 20699         (WebCore::streams):
       
 20700         (WebCore::PluginStreamWin::PluginStreamWin):
       
 20701         (WebCore::PluginStreamWin::~PluginStreamWin):
       
 20702         (WebCore::PluginStreamWin::ownerForStream):
       
 20703         * plugins/win/PluginStreamWin.h:
       
 20704         * plugins/win/PluginViewWin.cpp:
       
 20705         (WebCore::PluginViewWin::destroyStream):
       
 20706 
       
 20707 2007-04-02  Anders Carlsson  <andersca@apple.com>
       
 20708 
       
 20709         Reviewed by Darin.
       
 20710 
       
 20711         <rdar://problem/5095582>
       
 20712         PluginViewWin doesn't implement NPN_DestroyStream.
       
 20713 
       
 20714         * plugins/win/PluginStreamWin.cpp:
       
 20715         (WebCore::PluginStreamWin::startStream):
       
 20716         Handle the case where NPN_DestroyStream is called from the newstream handler.
       
 20717         
       
 20718         * plugins/win/PluginViewWin.cpp:
       
 20719         (WebCore::PluginViewWin::destroyStream):
       
 20720         Implement this.
       
 20721 
       
 20722 2007-04-02  Anders Carlsson  <andersca@apple.com>
       
 20723 
       
 20724         Reviewed by Dave Hyatt.
       
 20725 
       
 20726         <rdar://problem/5097225> 
       
 20727         Mouse cursors don't work with windowless plugins
       
 20728         
       
 20729         * platform/win/WidgetWin.cpp:
       
 20730         (WebCore::Widget::setCursor):
       
 20731         Add an "ignoreNextSetCursor" boolean and don't call SetCursor if it's true.
       
 20732         
       
 20733         * plugins/win/PluginViewWin.cpp:
       
 20734         (WebCore::PluginViewWin::handleMouseEvent):
       
 20735         Store away the current cursor and make sure that it won't be reset.
       
 20736 
       
 20737 2007-04-02  Anders Carlsson  <andersca@apple.com>
       
 20738 
       
 20739         Reviewed by Adam.
       
 20740 
       
 20741         Fix logic in windowless paint functions.
       
 20742         
       
 20743         * plugins/win/PluginViewWin.cpp:
       
 20744         (WebCore::PluginViewWin::invalidateRect):
       
 20745         (WebCore::PluginViewWin::invalidateRegion):
       
 20746         (WebCore::PluginViewWin::forceRedraw):
       
 20747 
       
 20748 2007-03-31  Dave Hyatt  <hyatt@apple.com>
       
 20749 
       
 20750         Internal side of 13234.   Open source side was reviewed by
       
 20751         Mitz.  Layout of justified text was broken when dragged or
       
 20752         when a ::selection style was in effect.
       
 20753 
       
 20754         * platform/win/FontWin.cpp:
       
 20755         (WebCore::Font::selectionRectForComplexText):
       
 20756         (WebCore::Font::drawComplexText):
       
 20757         (WebCore::Font::floatWidthForComplexText):
       
 20758         * platform/win/UniscribeController.cpp:
       
 20759         (WebCore::UniscribeController::UniscribeController):
       
 20760         (WebCore::UniscribeController::offsetForPosition):
       
 20761         * platform/win/UniscribeController.h:
       
 20762         * platform/win/WebCoreTextRenderer.cpp:
       
 20763         (WebCore::doDrawTextAtPoint):
       
 20764 
       
 20765 2007-03-30  Anders Carlsson  <andersca@apple.com>
       
 20766 
       
 20767         Reviewed by Geoff.
       
 20768 
       
 20769         * plugins/win/PluginDatabaseWin.cpp:
       
 20770         (WebCore::PluginDatabaseWin::addExtraPluginPath):
       
 20771         * plugins/win/PluginDatabaseWin.h:
       
 20772         New function for adding an extra plugin path, to be used by DRT.
       
 20773         
       
 20774         * plugins/win/PluginPackageWin.cpp:
       
 20775         (WebCore::PluginPackageWin::load):
       
 20776         Set the current directory tho the plugin directory while loading the plugin. Add new NPN callbacks.
       
 20777         
       
 20778         * plugins/win/PluginViewWin.cpp:
       
 20779         (WebCore::PluginViewWin::invalidateRect):
       
 20780         (WebCore::PluginViewWin::invalidateRegion):
       
 20781         (WebCore::PluginViewWin::forceRedraw):
       
 20782         Don't do anything if the plugin is windowed.
       
 20783         
       
 20784         * plugins/win/npapi.cpp:
       
 20785         (NPN_PushPopupsEnabledState):
       
 20786         (NPN_PopPopupsEnabledState):
       
 20787         Add stubs.
       
 20788         
       
 20789         * plugins/win/npfunctions.h:
       
 20790         Add new methods and merge some fixes from the open source version.
       
 20791 
       
 20792 2007-03-29  Dave Hyatt  <hyatt@apple.com>
       
 20793 
       
 20794         Enable CG's local font cache.  rdar://problem/5070005
       
 20795        
       
 20796         Reviewed by aroben
       
 20797 
       
 20798         * platform/win/FontCacheWin.cpp:
       
 20799         (WebCore::FontCache::platformInit):
       
 20800 
       
 20801 2007-03-28  Maciej Stachowiak  <mjs@apple.com>
       
 20802 
       
 20803         Reviewed by Darin.
       
 20804 
       
 20805         - updates for <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
       
 20806 
       
 20807 
       
 20808         * platform/win/ScrollViewWin.cpp:
       
 20809         (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
       
 20810         (WebCore::ScrollView::scrollRectIntoViewRecursively):
       
 20811 
       
 20812 2007-03-27  Dave Hyatt  <hyatt@apple.com>
       
 20813 
       
 20814         Fix for 5090964, arabic text is all jumbled in list boxes and popup menus (and in the
       
 20815         Boomer app too).  The fallback font was not the right size because the font you're mapping
       
 20816         from had to be selected into the HDC first.
       
 20817        
       
 20818         Reviewed by ggaren
       
 20819 
       
 20820         * ChangeLog:
       
 20821         * platform/win/FontCacheWin.cpp:
       
 20822         (WebCore::FontCache::getFontDataForCharacters):
       
 20823 
       
 20824 2007-03-27  Geoffrey Garen  <ggaren@apple.com>
       
 20825 
       
 20826         Reviewed by Anders Carlsson.
       
 20827 
       
 20828         Fixed <rdar://problem/5085076> WebView stops painting after 
       
 20829         loading stand-alone netflix movie preview in WMP format
       
 20830         
       
 20831         The stand-alone WMP plug-in seems to do all its drawing in
       
 20832         the WM_ERASEBKGN phase, not the WM_PAINT phase, so our
       
 20833         InvalidateRect call for plug-in windows needs to specify 
       
 20834         'true' for whether the background region should be erased.
       
 20835         
       
 20836         A smart plug-in that wants to avoid background draws can
       
 20837         still do so by just returning 1 in response to WM_ERASEBKGN,
       
 20838         or by setting its background brush to NULL.
       
 20839 
       
 20840         * plugins/win/PluginViewWin.cpp:
       
 20841         (WebCore::PluginViewWin::updateWindow):
       
 20842 
       
 20843 2007-03-27  Anders Carlsson  <acarlsson@apple.com>
       
 20844 
       
 20845         Reviewed by Maciej.
       
 20846 
       
 20847         <rdar://problem/5091459>
       
 20848         Crash when destroying "null plugin"
       
 20849         
       
 20850         <rdar://problem/5056845>
       
 20851         Invoking itunes page has missing plugin icon on it
       
 20852         
       
 20853         * plugins/win/PluginViewWin.cpp:
       
 20854         (WebCore::PluginViewWin::paintMissingPluginIcon):
       
 20855         Clip before painting.
       
 20856         
       
 20857         (WebCore::freeStringArray):
       
 20858         Add null-check.
       
 20859         
       
 20860         (WebCore::PluginViewWin::PluginViewWin):
       
 20861         Initialize plugin names and values.
       
 20862         
       
 20863 2007-03-27  Dave Hyatt  <hyatt@apple.com>
       
 20864 
       
 20865         Add support for glyph offsets to the GlyphBuffer.
       
 20866        
       
 20867         Reviewed by olliej
       
 20868 
       
 20869         * platform/win/FontWin.cpp:
       
 20870         (WebCore::Font::drawGlyphs):
       
 20871         * platform/win/UniscribeController.cpp:
       
 20872         (WebCore::UniscribeController::shapeAndPlaceItem):
       
 20873 
       
 20874 2007-03-26  Antti Koivisto  <antti@apple.com>
       
 20875 
       
 20876         Reviewed by Darin.
       
 20877         
       
 20878         Initialize new m_isContinuous field in WheelEvent
       
 20879 
       
 20880         * platform/win/WheelEventWin.cpp:
       
 20881         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
       
 20882 
       
 20883 2007-03-27  Dave Hyatt  <hyatt@apple.com>
       
 20884 
       
 20885         Enable complex text.  Selection and small-caps support are now enabled with this patch.
       
 20886         
       
 20887         Reviewed by aroben
       
 20888 
       
 20889         * platform/win/FontWin.cpp:
       
 20890         (WebCore::Font::selectionRectForComplexText):
       
 20891         (WebCore::Font::drawComplexText):
       
 20892         (WebCore::Font::floatWidthForComplexText):
       
 20893         (WebCore::Font::offsetForPositionForComplexText):
       
 20894         * platform/win/UniscribeController.cpp:
       
 20895         (WebCore::UniscribeController::UniscribeController):
       
 20896         (WebCore::UniscribeController::floatWidth):
       
 20897         (WebCore::UniscribeController::offsetForPosition):
       
 20898         (WebCore::UniscribeController::advance):
       
 20899         (WebCore::UniscribeController::itemizeShapeAndPlace):
       
 20900         (WebCore::UniscribeController::shapeAndPlaceItem):
       
 20901         * platform/win/UniscribeController.h:
       
 20902         (WebCore::UniscribeController::runWidthSoFar):
       
 20903 
       
 20904 2007-03-26  Adele Peterson  <adele@apple.com>
       
 20905 
       
 20906         Reviewed by Adam.
       
 20907 
       
 20908         Fix for <rdar://problem/5088844> Popup menu is not positioned correctly on a yahoo comics page
       
 20909         
       
 20910         Fixes test: fast/forms/control-restrict-line-height.html
       
 20911         
       
 20912         This change was made in RenderThemeMac a while ago, and will fix the line height for aqua popup buttons, 
       
 20913         buttons and search fields.
       
 20914         
       
 20915         * rendering/RenderThemeSafari.cpp: WebCore::RenderThemeSafari::setFontFromControlSize):
       
 20916           Don't honor line-height for controls that have restricted font size.
       
 20917           
       
 20918 2007-03-25  Brady Eidson  <beidson@apple.com>
       
 20919 
       
 20920         Reviewed by Oliver
       
 20921 
       
 20922         <rdar://problem/5086888> - WebHistory(Item) Leak
       
 20923 
       
 20924         * platform/win/COMPtr.h:
       
 20925         (COMPtr::COMPtr): An an adoptRef constructor
       
 20926 
       
 20927 2007-03-24  Adam Roben  <aroben@apple.com>
       
 20928 
       
 20929         Reviewed by Maciej.
       
 20930 
       
 20931         Fix <rdar://problem/5076610> Crash in PluginViewWin::updateWindow when
       
 20932         loading a PDF page for the first time after installing Acrobat Reader
       
 20933 
       
 20934         Don't call PluginPackageWin::load() until the PluginViewWin has been
       
 20935         inserted into the Widget tree. load() can result in arbitrary code
       
 20936         execution (in this case, a EULA window appears which takes focus from
       
 20937         the WebView, causing Frame::setIsActive(false) to be called), and we
       
 20938         don't want to be in a transitional state when that happens.
       
 20939 
       
 20940         * plugins/win/PluginDatabaseWin.cpp:
       
 20941         (WebCore::PluginDatabaseWin::createPluginView): Call PluginViewWin's
       
 20942         one and only constructor.
       
 20943         * plugins/win/PluginViewWin.cpp:
       
 20944         (WebCore::PluginViewWin::setParent): Call init() after inserting
       
 20945         ourselves into the Widget tree.
       
 20946         (WebCore::PluginViewWin::PluginViewWin): Defer all real work until
       
 20947         init() is called.
       
 20948         (WebCore::PluginViewWin::init): Added. Calls m_plugin->load(), then
       
 20949         does the rest of the work that was once done by the constructor.
       
 20950         * plugins/win/PluginViewWin.h: Removed createNullPlugin and simplified
       
 20951         constructor, added setParent override and new init method.
       
 20952 
       
 20953 2007-03-24  Brady Eidson  <beidson@apple.com>
       
 20954 
       
 20955         Reviewed by Adam
       
 20956 
       
 20957         <rdar://problem/5086210> - Move RetainPtr to WTF for WebKitWin and the App
       
 20958 
       
 20959         * WebCore.vcproj/WebCore.vcproj: Add the ForwardingHeader to the vcprojs
       
 20960 
       
 20961 2007-03-23  Adele Peterson  <adele@apple.com>
       
 20962 
       
 20963         Reviewed by Maciej.
       
 20964 
       
 20965         Fix for <rdar://problem/5083928> In editable webviews, caps lock key is ignored
       
 20966 
       
 20967         * platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
       
 20968         Removed code to store lowercase characters in m_text.  Now that we use the character code
       
 20969         to create m_text this is already taken care of.  This does mean that m_unmodifiedText is
       
 20970         not right.  This is used for accesskeys, which don't work yet, so that is covered in rdar://5085596.
       
 20971         This also fixes line endings in this file.
       
 20972 
       
 20973 2007-03-22  Geoffrey Garen  <ggaren@apple.com>
       
 20974 
       
 20975         Reviewed by Adam Roben.
       
 20976         
       
 20977         Fixed <rdar://problem/5082985> Select menus are too see-through
       
 20978 
       
 20979         Upped alpha value from 90 to 95. Menus will still seem a little
       
 20980         more see-through than on the mac, since their backgrounds are
       
 20981         white, not grey, but white matches other Windows browsers.
       
 20982         
       
 20983         * ChangeLog:
       
 20984         * platform/win/PopupMenuWin.cpp:
       
 20985 
       
 20986 2007-03-22  Anders Carlsson  <acarlsson@apple.com>
       
 20987 
       
 20988         Reviewed by Maciej.
       
 20989 
       
 20990         <rdar://problem/5081539>
       
 20991         QT content is dupped on a page, if page is being previewed or printed.
       
 20992         
       
 20993         Don't update the frame geometry if the document is in printing mode.
       
 20994         
       
 20995         * plugins/win/PluginViewWin.cpp:
       
 20996         (WebCore::PluginViewWin::setFrameGeometry):
       
 20997 
       
 20998 2007-03-22  Beth Dakin  <bdakin@apple.com>
       
 20999 
       
 21000         Fix by Hyatt, reviewed and committed by me.
       
 21001 
       
 21002         Fix for <rdar://problem/5082360> Incomplete frame paint when 
       
 21003         shrinking window @ google.com
       
 21004 
       
 21005         * platform/win/ScrollViewWin.cpp:
       
 21006         (WebCore::ScrollView::setFrameGeometry): Wrong order!
       
 21007 
       
 21008 2007-03-22  Dave Hyatt  <hyatt@apple.com>
       
 21009 
       
 21010         Fix for crasher in layout caused by paints that happen without layout being current.  Change to be
       
 21011         more like the Mac and crawl the frame tree up front ensuring everyone is up to date before painting.
       
 21012 
       
 21013         Reviewed by olliej
       
 21014 
       
 21015         * platform/win/ScrollViewWin.cpp:
       
 21016         (WebCore::ScrollView::setFrameGeometry):
       
 21017         (WebCore::ScrollView::children):
       
 21018         (WebCore::ScrollView::geometryChanged):
       
 21019 
       
 21020 2007-03-22  Dave Hyatt  <hyatt@apple.com>
       
 21021 
       
 21022         Fix for mouse wheel issues.  Only return success from passWheelEventToSubframe is the event was
       
 21023         actually accepted.
       
 21024         
       
 21025         * page/win/EventHandlerWin.cpp:
       
 21026         (WebCore::EventHandler::passWheelEventToSubframe):
       
 21027 
       
 21028 2007-03-21  Dave Hyatt  <hyatt@apple.com>
       
 21029 
       
 21030         Fix numerous bugs in RTL support.  Only use a directional override if the run
       
 21031         tells us to.  Uniscribe will give incorrect results when measuring RTL runs as LTR if the
       
 21032         directional override is set.  Switch from logical order for glyphs to visual order
       
 21033         instead.  This is more similar to ATSUI (less similar to the fast code path, which always uses
       
 21034         logical ordering for glyph generation).  Using visual ordering forces a lot of games to be played
       
 21035         (have to walk the script items in backwards order for RTL for example), but Uniscribe does not combine
       
 21036         glyphs properly if visual ordering is not used.
       
 21037         
       
 21038         Add support for justification, letter-spacing, word-spacing and rounding hacks.  The CG vs. ATSUI layout
       
 21039         test now passes with identical results to the Mac.  The ATSUI spacing features layout test now
       
 21040         generates correct results (although they are different from the Mac because we fall back to Arial for
       
 21041         Hebrew instead of Lucida Grande).
       
 21042 
       
 21043         Reviewed by oliver
       
 21044 
       
 21045         * platform/win/UniscribeController.cpp:
       
 21046         (WebCore::UniscribeController::UniscribeController):
       
 21047         (WebCore::UniscribeController::resetControlAndState):
       
 21048         (WebCore::UniscribeController::shapeAndPlaceItem):
       
 21049         (WebCore::UniscribeController::shape):
       
 21050         * platform/win/UniscribeController.h:
       
 21051 
       
 21052 2007-03-20  Adam Roben  <aroben@apple.com>
       
 21053 
       
 21054         Reviewed by Ada.
       
 21055 
       
 21056         Added null-checks for ResourceHandle::cookieStorage() before passing it
       
 21057         into CFNetwork functions, which are not null-safe.
       
 21058 
       
 21059         * platform/network/win/CookieJarWin.cpp:
       
 21060         (WebCore::setCookies):
       
 21061         (WebCore::cookies):
       
 21062 
       
 21063 2007-03-20  Adam Roben  <aroben@apple.com>
       
 21064 
       
 21065         Build fix.
       
 21066 
       
 21067         * WebCore.vcproj/WebCore.vcproj: Added XPathNodeSet.(cpp|h).
       
 21068 
       
 21069 2007-03-20  Adam Roben  <aroben@apple.com>
       
 21070 
       
 21071         Reviewed by Oliver.
       
 21072 
       
 21073         Made the metrics of styled selects match those on the Mac to get
       
 21074         fast/forms/001.html passing.
       
 21075 
       
 21076         * rendering/RenderThemeSafari.cpp: Use 2px less padding for the
       
 21077         select's arrow since the arrow is 2px wider than on the Mac.
       
 21078 
       
 21079 2007-03-20  Adam Roben  <aroben@apple.com>
       
 21080 
       
 21081         Build fix.
       
 21082 
       
 21083         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 21084         (WebCore::makeFinalRequest): Fix typo.
       
 21085 
       
 21086 2007-03-20  Dave Hyatt  <hyatt@apple.com>
       
 21087 
       
 21088         Land advanced text code path (turned off).
       
 21089        
       
 21090         Reviewed by aroben
       
 21091         
       
 21092         * WebCore.vcproj/WebCore.vcproj:
       
 21093         * platform/win/FontCacheWin.cpp:
       
 21094         (WebCore::FontCache::createFontPlatformData):
       
 21095         * platform/win/FontDataWin.cpp:
       
 21096         (WebCore::FontData::platformInit):
       
 21097         (WebCore::FontData::platformDestroy):
       
 21098         (WebCore::FontData::smallCapsFontData):
       
 21099         (WebCore::FontData::scriptFontProperties):
       
 21100         * platform/win/FontWin.cpp:
       
 21101         (WebCore::Font::drawComplexText):
       
 21102         (WebCore::Font::floatWidthForComplexText):
       
 21103         (WebCore::Font::offsetForPositionForComplexText):
       
 21104         * platform/win/UniscribeController.cpp: Added.
       
 21105         (WebCore::UniscribeController::UniscribeController):
       
 21106         (WebCore::UniscribeController::resetControlAndState):
       
 21107         (WebCore::UniscribeController::shapeAndPlaceItem):
       
 21108         (WebCore::UniscribeController::shape):
       
 21109         * platform/win/UniscribeController.h: Added.
       
 21110         (WebCore::UniscribeController::width):
       
 21111         (WebCore::UniscribeController::glyphBuffer):
       
 21112 
       
 21113 2007-03-20  Anders Carlsson  <acarlsson@apple.com>
       
 21114 
       
 21115         Reviewed by Adam.
       
 21116 
       
 21117         <rdar://problem/4921198>
       
 21118         Cookie acceptance policy not settable
       
 21119 
       
 21120         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 21121         
       
 21122         (WebCore::willSendRequest):
       
 21123         (WebCore::willCacheResponse):
       
 21124         Remove FIXMEs.
       
 21125         
       
 21126         (WebCore::makeFinalRequest):
       
 21127         New function that makes a final CFURLRequest depending on cookie policy and whether any
       
 21128         invalid SSL certificates should be ignored.
       
 21129         
       
 21130         (WebCore::ResourceHandle::start):
       
 21131         (WebCore::ResourceHandle::loadResourceSynchronously):
       
 21132         Use makeFinalRequest.
       
 21133         
       
 21134         (WebCore::ResourceHandle::cookieStorageAcceptPolicy):
       
 21135         (WebCore::ResourceHandle::setCookieStorageAcceptPolicy):
       
 21136         (WebCore::ResourceHandle::cookieStorage):
       
 21137         (WebCore::ResourceHandle::setCookieStorage):
       
 21138         (WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate):
       
 21139         New functions for setting cookie policy, the deafult cookie storage and whether invalid
       
 21140         SSL certificates should result in an error.
       
 21141         
       
 21142         * platform/network/cf/ResourceRequestCFNet.cpp:
       
 21143         (WebCore::ResourceRequest::doUpdatePlatformRequest):
       
 21144         Set cookie storage, cookie policy and SSL properties.
       
 21145 
       
 21146         * platform/network/win/CookieJarWin.cpp:
       
 21147         (WebCore::setCookies):
       
 21148         (WebCore::cookies):
       
 21149         Use same functions as the mac (sorta).
       
 21150         
       
 21151         (WebCore::cookiesEnabled):
       
 21152         Implement this.
       
 21153 
       
 21154 2007-03-19  Adam Roben  <aroben@apple.com>
       
 21155 
       
 21156         Reviewed by Anders and Darin.
       
 21157 
       
 21158         Added JavaScriptStatistics to the project for
       
 21159         <rdar://problems/5071653>.
       
 21160 
       
 21161         * WebCore.vcproj/WebCore.vcproj: Added include/pthreads to the include
       
 21162         path, and added JavaScriptStatistics.(cpp|h).
       
 21163 
       
 21164 2007-03-18  David Hyatt  <hyatt@apple.com>
       
 21165 
       
 21166         Fix the CSS2 system font for 'menu' to match Mac.  Makes the system fonts layout test pass.
       
 21167 
       
 21168         * rendering/RenderThemeSafari.cpp:
       
 21169         (WebCore::RenderThemeSafari::systemFont):
       
 21170 
       
 21171 2007-03-18  Adam Roben  <aroben@apple.com>
       
 21172 
       
 21173         Reviewed by Hyatt.
       
 21174 
       
 21175         Changed the file upload button to say "Choose File" to match Mac.
       
 21176 
       
 21177         * platform/win/TemporaryLinkStubs.cpp:
       
 21178         (WebCore::fileButtonChooseFileLabel):
       
 21179 
       
 21180 2007-03-18  Geoffrey Garen  <ggaren@apple.com>
       
 21181 
       
 21182         Reviewed by Oliver Hunt.
       
 21183 
       
 21184         Fixed <rdar://problem/5061807> STRESS (2): Crash in PlatformScrollbar::setRect
       
 21185 
       
 21186         No test case because I can't seem to get the Windows DRT to cooperate. I'll try again tomorrow.
       
 21187 
       
 21188         The problem was that the FrameView would try to reset the document's scrollbars after having 
       
 21189         been removed from the page, so its page pointer would be NULL. Added NULL checks.
       
 21190 
       
 21191         This situation ultimately results from the FrameView's non-trivial destructor, which
       
 21192         creates a fragile dependency on tear-down timing. It looks like the timing on Windows
       
 21193         is slightly different from the timing on Mac. I didn't see any obvious resulting bugs,
       
 21194         though, so the NULL checks should be sufficient for now.
       
 21195 
       
 21196         * platform/win/ScrollViewWin.cpp:
       
 21197         (WebCore::ScrollView::windowResizerRect):
       
 21198         (WebCore::ScrollView::addToDirtyRegion):
       
 21199         (WebCore::ScrollView::scrollBackingStore):
       
 21200         (WebCore::ScrollView::updateBackingStore):
       
 21201 
       
 21202 2007-03-17  David Hyatt  <hyatt@apple.com>
       
 21203 
       
 21204         The internal side of the patch that ensures Boomer paints twice on ibench.  Don't let the timer beat out
       
 21205         that first paint.
       
 21206 
       
 21207         Reviewed by aroben
       
 21208 
       
 21209         * platform/win/ScrollViewWin.cpp:
       
 21210         (WebCore::ScrollView::update):
       
 21211 
       
 21212 2007-03-17  Adam Roben  <aroben@apple.com>
       
 21213 
       
 21214         Reviewed by Brady.
       
 21215 
       
 21216         Fix fast/dom/isindex-002.html.
       
 21217 
       
 21218         Add default strings to our two remaining unimplemented localizable
       
 21219         strings in WebCore.
       
 21220 
       
 21221         * platform/win/TemporaryLinkStubs.cpp:
       
 21222         (WebCore::searchableIndexIntroduction): Added English string from Mac.
       
 21223         (WebCore::inputElementAltText): Ditto.
       
 21224 
       
 21225 2007-03-17  Adele Peterson  <adele@apple.com>
       
 21226 
       
 21227         Reviewed by Hyatt.
       
 21228 
       
 21229         Fix for <rdar://problem/4960391> REGRESSION (r18922): onChange never fired after selecting an item from a menulist
       
 21230 
       
 21231         * platform/win/PopupMenuWin.cpp:
       
 21232         (WebCore::PopupMenu::PopupMenu): Initialize m_focusedIndex to 0.  Instead of using the client to track the focused index, we'll
       
 21233          keep track of it internally.  Our old behavior was trying to match Firefox by updating the selected index as you focus items, but that
       
 21234          doesn't seem necessary if the selection never gets committed.
       
 21235         (WebCore::PopupMenu::show): Initialize the focused index to the client's selected index.
       
 21236         (WebCore::PopupMenu::setFocusedIndex): Remove the fireOnChange argument.  Remove the call to valueChanged.
       
 21237         (WebCore::PopupMenu::focusedIndex): Return m_focusedIndex instead of getting this from the client.
       
 21238         (WebCore::PopupMenu::down): Use the focusedIndex.
       
 21239         (WebCore::PopupMenu::up): ditto.
       
 21240         (WebCore::PopupMenu::paint): Paint a selected appearance for the item with the focused index.
       
 21241 
       
 21242 2007-03-16  Adele Peterson  <adele@apple.com>
       
 21243 
       
 21244         Reviewed by Lou.
       
 21245 
       
 21246         Fix for <rdar://problem/5065040> cannot mousedown + drag in a <select> menu
       
 21247 
       
 21248         * platform/win/PopupMenuWin.cpp:
       
 21249         (WebCore::PopupMenu::show): Set the capture when the popup window comes up.
       
 21250         (WebCore::PopupWndProc): Release the capture only when the mouse is not down, and the mouse moves outside the popup window, 
       
 21251          or if you mouse up inside the window, and you're about to hide the popup.  The mouse will get recaptured if you mouse down
       
 21252          again in the window.
       
 21253 
       
 21254 2007-03-15  Brady Eidson  <beidson@apple.com>
       
 21255 
       
 21256         Reviewed by Oliver
       
 21257 
       
 21258         CFNetwork related cleanup that was a work around for previous deficiencies in CFURLDownload
       
 21259         This might fix some of the random crashers we see on stress testing if they end up 
       
 21260         downloading links.
       
 21261 
       
 21262         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 21263         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):  Always call cancel if theres a
       
 21264           connection - the ref-count-check hack is no longer neccesary
       
 21265         (WebCore::ResourceHandle::releaseConnectionForDownload): Give up the CFURLConnection without
       
 21266           derefing it
       
 21267 
       
 21268 2007-03-15  Maciej Stachowiak  <mjs@apple.com>
       
 21269 
       
 21270         Reviewed by Geoff and Steve.
       
 21271         
       
 21272         - fixed <rdar://problem/5029776> iBench JavaScript test slower than Opera
       
 21273         - fixes to use FastMalloc on Windows
       
 21274 
       
 21275         * config.h: Don't force USE_SYSTEM_MALLOC
       
 21276 
       
 21277 2007-03-15  Adam Roben  <aroben@apple.com>
       
 21278 
       
 21279         Rubberstamped by Hyatt.
       
 21280 
       
 21281         * platform/win/FontDataWin.cpp:
       
 21282         (WebCore::FontData::platformInit): Move the code to get the font face
       
 21283         to the top of the function for easier debugging.
       
 21284         * platform/win/FontPlatformDataWin.cpp:
       
 21285         (WebCore::FontPlatformData::FontPlatformData): ASSERT that we got a
       
 21286         valid CGFontRef back from CG, as CG and GDI should agree on the fonts
       
 21287         installed.
       
 21288 
       
 21289 2007-03-14  Anders Carlsson  <acarlsson@apple.com>
       
 21290 
       
 21291         Reviewed by Adam.
       
 21292 
       
 21293         Use CFURLResponseCopySuggestedFilename.
       
 21294         
       
 21295         * platform/network/cf/ResourceResponseCFNet.cpp:
       
 21296         (WebCore::suggestedFilenameForResponse):
       
 21297 
       
 21298 2007-03-14  Adam Roben  <aroben@apple.com>
       
 21299 
       
 21300         Reviewed by Hyatt.
       
 21301 
       
 21302         Use CG to get xHeight.
       
 21303 
       
 21304         * platform/win/FontDataWin.cpp:
       
 21305         (WebCore::scaleEmToUnits): Made robust against divide-by-zero errors.
       
 21306         (WebCore::FontData::platformInit): Ported Mac code to get xHeight using CG.
       
 21307 
       
 21308 2007-03-14  Anders Carlsson  <acarlsson@apple.com>
       
 21309 
       
 21310         Build fixes.
       
 21311         
       
 21312         * platform/graphics/win/ImageWin.cpp:
       
 21313         (WebCore::Image::loadPlatformResource):
       
 21314         * platform/win/EditorWin.cpp:
       
 21315 
       
 21316 2007-03-13  Adam Roben  <aroben@apple.com>
       
 21317 
       
 21318         Reviewed by Anders.
       
 21319 
       
 21320         * platform/win/FontDataWin.cpp:
       
 21321         (WebCore::scaleEmToUnits): Ported from FontDataMac.
       
 21322         (WebCore::FontData::platformInit): Use CG for metrics, and apply Mac's
       
 21323         line-height hack for Times, Helvetica, and Courier.
       
 21324         (WebCore::FontData::platformWidthForGlyph): Call wkGetGlyphAdvances to
       
 21325         use some CG SPI to match Mac.
       
 21326 
       
 21327 2007-03-12  Darin Adler  <darin@apple.com>
       
 21328 
       
 21329         * WebCore.vcproj/WebCore.vcproj: Added new JavaScript wrapper derived source files.
       
 21330 
       
 21331 2007-03-12  Anders Carlsson  <acarlsson@apple.com>
       
 21332 
       
 21333         Reviewed by Darin.
       
 21334 
       
 21335         <rdar://problem/5054694>
       
 21336         Repro crash when viewing fast/dom/HTMLObjectElement/object-as-frame.html
       
 21337         
       
 21338         * bridge/win/FrameWin.cpp:
       
 21339         (WebCore::Frame::createScriptInstanceForWidget):
       
 21340         Return 0 for frame views.
       
 21341 
       
 21342 2007-03-12  Anders Carlsson  <acarlsson@apple.com>
       
 21343 
       
 21344         Reviewed by Adam.
       
 21345 
       
 21346         <rdar://problem/5054713>
       
 21347         Crash in suggestedFilenameForResponse in two fast/encoding tests.
       
 21348         
       
 21349         Add null checks.
       
 21350         
       
 21351         * platform/network/cf/ResourceResponseCFNet.cpp:
       
 21352         (WebCore::suggestedFilenameForResponse):
       
 21353 
       
 21354 2007-03-12  Adele Peterson  <adele@apple.com>
       
 21355 
       
 21356         Reviewed by Oliver.
       
 21357 
       
 21358         Fix for <rdar://problem/5053618> Disable "recent searches" search field menu.
       
 21359 
       
 21360         * platform/win/SearchPopupMenuWin.cpp: (WebCore::SearchPopupMenu::enabled):
       
 21361 
       
 21362 2007-03-12  Adele Peterson  <adele@apple.com>
       
 21363 
       
 21364         Reviewed by Oliver.
       
 21365         
       
 21366         WebCore part of fix for <rdar://problem/5044790> preventing default of keypress event doesn't work (affects .mac)
       
 21367 
       
 21368         * platform/win/KeyEventWin.cpp:
       
 21369         (WebCore::singleCharacterString): Added inline keyword.   
       
 21370         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
       
 21371         Renamed arguments to be more meaningful.  Added characterCode argument to be used when constructing m_text.
       
 21372 
       
 21373 2007-03-12  Adele Peterson  <adele@apple.com>
       
 21374 
       
 21375         Reviewed by Oliver.
       
 21376 
       
 21377         Forking KeyEventWin.cpp from revision 20118.
       
 21378 
       
 21379         * WebCore.vcproj/WebCore.vcproj:
       
 21380         * platform/win/KeyEventWin.cpp: Added.
       
 21381 
       
 21382 2007-03-11  Oliver Hunt  <oliver@apple.com>
       
 21383 
       
 21384         Reviewed by Adele.
       
 21385 
       
 21386         Removed Frame::respondToChangedSelection stub
       
 21387         added Editor::markMisspellings stub
       
 21388 
       
 21389         * platform/win/TemporaryLinkStubs.cpp:
       
 21390         (WebCore::Editor::markMisspellings):
       
 21391 
       
 21392 2007-03-10  Geoffrey Garen  <ggaren@apple.com>
       
 21393 
       
 21394         Reviewed by Darin Adler.
       
 21395 
       
 21396         Fixed <rdar://problem/4587763> PAC file: lock inversion between QT and 
       
 21397         JSCore causes a hang @ www.panoramas.dk
       
 21398         
       
 21399         See JavaScriptCore ChangeLog for details.
       
 21400         
       
 21401         Stress test doesn't show any problems.
       
 21402         
       
 21403         Drop the JSLock before making calls through the plug-in API from functions
       
 21404         that may have been called by JavaScript.
       
 21405         
       
 21406         * plugins/win/PluginViewWin.cpp:
       
 21407         (WebCore::PluginViewWin::paint):
       
 21408         (WebCore::PluginViewWin::handleKeyboardEvent):
       
 21409         (WebCore::PluginViewWin::handleMouseEvent):
       
 21410         (WebCore::PluginViewWin::setNPWindowRect):
       
 21411         (WebCore::PluginViewWin::start):
       
 21412         (WebCore::PluginViewWin::stop):
       
 21413         (WebCore::PluginViewWin::performRequest):
       
 21414         (WebCore::PluginViewWin::bindingInstance):
       
 21415 
       
 21416 2007-03-09  Oliver Hunt  <oliver@apple.com>
       
 21417 
       
 21418         Reviewed by John.
       
 21419 
       
 21420         Fix the doubled text in the image used to drag a link
       
 21421 
       
 21422         * platform/win/WebCoreTextRenderer.cpp:
       
 21423         (WebCore::WebCoreDrawDoubledTextAtPoint):
       
 21424 
       
 21425 2007-03-09  Anders Carlsson  <acarlsson@apple.com>
       
 21426 
       
 21427         Reviewed by Adam.
       
 21428 
       
 21429         Implement setting the suggested filename for a response.
       
 21430         
       
 21431         * platform/network/cf/ResourceResponseCFNet.cpp:
       
 21432         (WebCore::filenameFromHTTPContentDisposition):
       
 21433         (WebCore::filenameHasSaneExtension):
       
 21434         (WebCore::suggestedFilenameForResponse):
       
 21435         (WebCore::ResourceResponse::doUpdateResourceResponse):
       
 21436         * platform/win/MimeTypeRegistryWin.cpp:
       
 21437         (WebCore::getMIMETypeForUTI):
       
 21438         
       
 21439         (WebCore::mimeTypeForExtension):
       
 21440         Fix two bugs in this function.
       
 21441         
       
 21442         (WebCore::MimeTypeRegistry::getPreferredExtensionForMIMEType):
       
 21443 
       
 21444 2007-03-09  Anders Carlsson  <acarlsson@apple.com>
       
 21445 
       
 21446         * plugins/win/PluginViewWin.cpp:
       
 21447         (WebCore::PluginViewWin::performRequest):
       
 21448         Fixup comments and remove an obsolete FIXME.
       
 21449 
       
 21450 2007-03-09  Oliver Hunt  <oliver@apple.com>
       
 21451 
       
 21452         Reviewed by Steve.
       
 21453 
       
 21454         Executing a script for a plugin can cause cause this to be deleted
       
 21455         so we take a reference to our parent prior to executing the script
       
 21456 
       
 21457         * plugins/win/PluginViewWin.cpp:
       
 21458         (WebCore::PluginViewWin::performRequest):
       
 21459 
       
 21460 2007-03-08  Oliver Hunt  <oliver@apple.com>
       
 21461 
       
 21462         Reviewed by Steve.
       
 21463 
       
 21464         Allow webloc files to be dropped onto the webview
       
 21465         
       
 21466         <rdar://problem/4883564> Regression: cannot open webloc file by dnd to Boomer's window
       
 21467 
       
 21468         * platform/win/DragDataWin.cpp:
       
 21469         (WebCore::cfHDropFormat):
       
 21470            Clipboard format for HDROP, non-static as i will need it elsewhere in the future 
       
 21471         (WebCore::getWebLocData):
       
 21472            Extract a url from a webloc file
       
 21473         (WebCore::getURL):
       
 21474            Call getWebLocData
       
 21475 
       
 21476 2007-03-08  Steve Falkenburg  <sfalken@apple.com>
       
 21477 
       
 21478         Fix Production build more
       
 21479 
       
 21480         * WebCore.vcproj/WebCore.vcproj:
       
 21481 
       
 21482 2007-03-08  Steve Falkenburg  <sfalken@apple.com>
       
 21483 
       
 21484         Production build fix
       
 21485 
       
 21486         * WebCore.vcproj/WebCore.vcproj:
       
 21487 
       
 21488 2007-03-08  Adam Roben  <aroben@apple.com>
       
 21489 
       
 21490         Reviewed by Steve.
       
 21491         
       
 21492         Fix <rdar://problem/4969070> Failed error pages show "unknown error"
       
 21493         rather than specific error
       
 21494 
       
 21495         Make ResourceError aware of kCFErrorDomainCFNetwork.
       
 21496 
       
 21497         * platform/network/cf/ResourceErrorCF.cpp:
       
 21498         (WebCore::ResourceError::ResourceError): Added case for
       
 21499         kCFErrorDomainCFNetwork.
       
 21500 
       
 21501 2007-03-06  Adam Roben  <aroben@apple.com>
       
 21502 
       
 21503         Fixing the build while semi-blind is fun.
       
 21504 
       
 21505         * platform/win/TemporaryLinkStubs.cpp:
       
 21506         (WebCore::supportedKeySizes): Need a namespace.
       
 21507         (WebCore::signedPublicKeyAndChallengeString): Ditto.
       
 21508 
       
 21509 2007-03-06  Adam Roben  <aroben@apple.com>
       
 21510 
       
 21511         It works better if you use valid C++ syntax.
       
 21512 
       
 21513         * platform/win/TemporaryLinkStubs.cpp:
       
 21514 
       
 21515 2007-03-06  Adam Roben  <aroben@apple.com>
       
 21516 
       
 21517         Build fix.
       
 21518 
       
 21519         * platform/win/TemporaryLinkStubs.cpp: Added missing stubs.
       
 21520 
       
 21521 2007-03-06  Adam Roben  <aroben@apple.com>
       
 21522 
       
 21523         Reviewed by Anders.
       
 21524 
       
 21525         Always keep rounding hacks on.
       
 21526 
       
 21527         * platform/win/FileChooserWin.cpp:
       
 21528         (WebCore::FileChooser::basenameForWidth): Tell StringTruncator to keep
       
 21529         rounding hacks on.
       
 21530         * platform/win/WebCoreTextRenderer.cpp:
       
 21531         (WebCore::WebCoreTextFloatWidth): Ditto.
       
 21532 
       
 21533 2007-03-06  Anders Carlsson  <acarlsson@apple.com>
       
 21534 
       
 21535         Build fix.
       
 21536         
       
 21537         * plugins/win/PluginViewWin.cpp:
       
 21538         (WebCore::PluginViewWin::userAgent):
       
 21539 
       
 21540 2007-03-05  Anders Carlsson  <acarlsson@apple.com>
       
 21541 
       
 21542         Reviewed by Adam.
       
 21543 
       
 21544         <rdar://problem/5041348>
       
 21545         Can't watch videos at cnn.com
       
 21546         
       
 21547         * plugins/win/PluginStreamWin.cpp:
       
 21548         (WebCore::PluginStreamWin::cancelAndDestroyStream):
       
 21549         Change this function back to call call stop() after destroyStream(). Also, make sure to
       
 21550         protect the stream since destroyStream can eventually, well, destroy it.
       
 21551 
       
 21552 2007-03-05  Anders Carlsson  <acarlsson@apple.com>
       
 21553 
       
 21554         Reviewed by Adam.
       
 21555 
       
 21556         <rdar://problem/4987743>
       
 21557         Regression: java content is represented as broken images on pages
       
 21558         
       
 21559         * plugins/win/PluginPackageWin.cpp:
       
 21560         (WebCore::PluginPackageWin::load):
       
 21561         Make sure to set the size of the NPPluginFuncs struct correctly.
       
 21562 
       
 21563 2007-03-05  Steve Falkenburg  <sfalken@apple.com>
       
 21564 
       
 21565         Fix build
       
 21566 
       
 21567         * plugins/win/PluginStreamWin.cpp:
       
 21568         (WebCore::PluginStreamWin::stop): Call cancel() instead of stopLoading(), since the latter was removed.
       
 21569 
       
 21570 2007-03-02  Adam Roben  <aroben@apple.com>
       
 21571 
       
 21572         Reviewed by Anders.
       
 21573 
       
 21574         Added optional underlining of a single character to
       
 21575         WebCoreTextRenderer.
       
 21576 
       
 21577         No layout tests possible.
       
 21578 
       
 21579         * platform/win/WebCoreTextRenderer.cpp:
       
 21580         (WebCore::doDrawTextAtPoint): Added. This is an extraction of the code
       
 21581         from DrawTextAtPoint that now also contains the underlining code.
       
 21582         (WebCore::WebCoreDrawTextAtPoint): Call the helper function.
       
 21583         (WebCore::WebCoreDrawDoubledTextAtPoint): Ditto.
       
 21584         * platform/win/WebCoreTextRenderer.h: Added optional underlinedIndex
       
 21585         parameters.
       
 21586 
       
 21587 2007-03-01  Anders Carlsson  <acarlsson@apple.com>
       
 21588 
       
 21589         Reviewed by Tim.
       
 21590 
       
 21591         * plugins/win/npfunctions.h:
       
 21592         Fix tyop.
       
 21593         
       
 21594 2007-02-28  Adam Roben  <aroben@apple.com>
       
 21595 
       
 21596         Reviewed by Anders.
       
 21597 
       
 21598         Clean up WebCoreTextRenderer. WebCoreDrawTextAtPoint now just draws
       
 21599         text at a point. It doesn't center truncate, clip, or modify alignment.
       
 21600 
       
 21601         No layout test possible.
       
 21602 
       
 21603         * platform/win/WebCoreTextRenderer.cpp:
       
 21604         (WebCore::WebCoreDrawTextAtPoint): Use only WebCore types, and don't
       
 21605         center truncate or modify alignment.
       
 21606         (WebCore::WebCoreDrawDoubledTextAtPoint): Moved from WebKitGraphics.cpp.
       
 21607         (WebCore::WebCoreTextFloatWidth): Added.
       
 21608         * platform/win/WebCoreTextRenderer.h: Updated/added declarations.
       
 21609 
       
 21610 2007-02-28  Adele Peterson  <adele@apple.com>
       
 21611 
       
 21612         Reviewed by Adam.
       
 21613 
       
 21614         Fix for <rdar://problem/4887423> REGRESSION: search results popup menu strings are not localized
       
 21615         and <rdar://problem/3517227> accessibility-related strings in WebCore are not localized
       
 21616 
       
 21617         * platform/win/TemporaryLinkStubs.cpp:
       
 21618         (WebCore::searchMenuNoRecentSearchesText):
       
 21619         (WebCore::searchMenuRecentSearchesText):
       
 21620         (WebCore::searchMenuClearRecentSearchesText):
       
 21621         (WebCore::AXWebAreaText):
       
 21622         (WebCore::AXLinkText):
       
 21623         (WebCore::AXListMarkerText):
       
 21624         (WebCore::AXImageMapText):
       
 21625         (WebCore::AXHeadingText):
       
 21626 
       
 21627 2007-02-28  Maciej Stachowiak  <mjs@apple.com>
       
 21628 
       
 21629         Reviewed by Adam.
       
 21630 
       
 21631         - fixed <rdar://problem/5005120> Crash: selecting View all RSS Articles from context menu of bookmark folder
       
 21632 
       
 21633         * platform/network/cf/ResourceRequestCFNet.cpp:
       
 21634         (WebCore::ResourceRequest::doUpdatePlatformRequest): Use RetainPtr
       
 21635         instead of explicit release, as this was caused by CFRelease on
       
 21636         a null pointer, and REtainPtr is tolerant.
       
 21637 
       
 21638 2007-02-27  Beth Dakin  <bdakin@apple.com>
       
 21639 
       
 21640         Reviewed by Adam.
       
 21641 
       
 21642         <rdar://problem/4956528> Implement Pasteboard::writeImage for 
       
 21643         Boomer context menus
       
 21644 
       
 21645         * platform/win/PasteboardWin.cpp:
       
 21646         (WebCore::Pasteboard::writeImage): Copy a bitmap to the clipboard.
       
 21647 
       
 21648 2007-02-27  Oliver Hunt  <oliver@apple.com>
       
 21649 
       
 21650         Reviewed by Lou and Steve.
       
 21651 
       
 21652         Add a store for current Cursor to fix <rdar://problem/4788352>
       
 21653 
       
 21654         * platform/win/WidgetWin.cpp:
       
 21655         (WebCore::Widget::setCursor):
       
 21656 
       
 21657 2007-02-26  Oliver Hunt  <oliver@apple.com>
       
 21658 
       
 21659         Reviewed by Maciej.
       
 21660 
       
 21661         To stop the drag image for transparent images from looking 
       
 21662         ugly (especially fully transparent images) we render the 
       
 21663         image to a white background prior to passing the image on to 
       
 21664         Windows
       
 21665         
       
 21666         <rdar://problem/5015946>
       
 21667 
       
 21668         * platform/win/DragImageWin.cpp:
       
 21669         (WebCore::createDragImageFromImage):
       
 21670 
       
 21671 2007-02-26  Adam Roben  <aroben@apple.com>
       
 21672 
       
 21673         Reviewed by Adele.
       
 21674 
       
 21675         * platform/win/GraphicsContextWin.cpp: Get rid of so-five-hours-ago SVG_SUPPORT.
       
 21676 
       
 21677 2007-02-26  Adam Roben  <aroben@apple.com>
       
 21678 
       
 21679         Build fix.
       
 21680 
       
 21681         * config.h: Remove redundant #define.
       
 21682         * WebCore.vcproj/WebCore.vcproj: Update to new macros.
       
 21683 
       
 21684 2007-02-26  Adam Roben  <aroben@apple.com>
       
 21685 
       
 21686         Rubberstamped by Ada.
       
 21687 
       
 21688         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp: Make #if match the header file.
       
 21689 
       
 21690 2007-02-26  Adam Roben  <aroben@apple.com>
       
 21691 
       
 21692         Reviewed by Darin.
       
 21693 
       
 21694         Build fix.
       
 21695 
       
 21696         * WebCore.vcproj/build-generated-files.sh: Updated FEATURE_DEFINES.
       
 21697         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp: Use shiny new ENABLE(SVG).
       
 21698         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp: Ditto.
       
 21699 
       
 21700 2007-02-25  Maciej Stachowiak  <mjs@apple.com>
       
 21701 
       
 21702         Reviewed by Adam.
       
 21703 
       
 21704         - fixed layout test failure in fast/overflow/scrollRevealButton
       
 21705         
       
 21706         I added a new ScrollView method, fullyClippedContentRect, that vies the content rect
       
 21707         as clipped by all ancestor scroll views, not just this one. Currently it only works
       
 21708         correctly on mac however. visibleContentRect, only accounting for the clipping from
       
 21709         this particular scroll view, is sufficient for most purposes.
       
 21710 
       
 21711         * platform/win/ScrollViewWin.cpp:
       
 21712         (WebCore::ScrolView::fullyClippedContentRect):
       
 21713 
       
 21714 2007-02-24  Adam Roben  <aroben@apple.com>
       
 21715 
       
 21716         Change #if to #ifdef to match style.
       
 21717 
       
 21718         * platform/win/PopupMenuWin.cpp:
       
 21719         (WebCore::PopupMenu::show):
       
 21720 
       
 21721 2007-02-24  Adam Roben  <aroben@apple.com>
       
 21722 
       
 21723         Reviewed by Steve.
       
 21724 
       
 21725         Fix <rdar://problem/5013502> REGRESSION: <select> menus are not
       
 21726         animating smoothly
       
 21727 
       
 21728         This was caused by making the menus partially transparent in r12250.
       
 21729 
       
 21730         * platform/win/PopupMenuWin.cpp:
       
 21731         (WebCore::PopupMenu::show): Disable animations.
       
 21732 
       
 21733 2007-02-23  Anders Carlsson  <acarlsson@apple.com>
       
 21734 
       
 21735         Reviewed by Adam.
       
 21736 
       
 21737         <rdar://problem/4761543>
       
 21738         nike.com doesn't finish loading if Flash plugin is installed.
       
 21739         
       
 21740         If a plugin requests a JavaScript URL with a non null frame target, execute the JavaScript expression. If the result 
       
 21741         is not "undefined", replace the contents of the frame with the result converted to a string.
       
 21742 
       
 21743         * plugins/win/PluginViewWin.cpp:
       
 21744         (WebCore::getString):
       
 21745         (WebCore::PluginViewWin::performRequest):
       
 21746         (WebCore::PluginViewWin::requestTimerFired):
       
 21747 
       
 21748 2007-02-22  Oliver Hunt  <oliver@apple.com>
       
 21749 
       
 21750         rs = adam
       
 21751         
       
 21752         Replacing radar numbers from previous patch with one
       
 21753         the isn't fictitious <rdar://problem/5018591>
       
 21754 
       
 21755         * platform/win/CursorWin.cpp:
       
 21756         (WebCore::columnResizeCursor):
       
 21757         (WebCore::rowResizeCursor):
       
 21758         (WebCore::verticalTextCursor):
       
 21759 
       
 21760 2007-02-22  Oliver Hunt  <oliver@apple.com>
       
 21761 
       
 21762         Reviewed by Ada.
       
 21763 
       
 21764         Implemented a couple more cursor methods
       
 21765 
       
 21766         * platform/win/CursorWin.cpp:
       
 21767         (WebCore::columnResizeCursor):
       
 21768         (WebCore::rowResizeCursor):
       
 21769         (WebCore::verticalTextCursor):
       
 21770           Added radar bug reference <rdar://problem/5018452>
       
 21771         (WebCore::progressCursor):
       
 21772         (WebCore::noDropCursor):
       
 21773         (WebCore::notAllowedCursor):
       
 21774           Making them return the correct cursor
       
 21775 
       
 21776 2007-02-22  Oliver Hunt  <oliver@apple.com>
       
 21777 
       
 21778         Reviewed by Anders.
       
 21779 
       
 21780         Removing accessive COMPtr use from ClipboardWin constructors
       
 21781         Adding data verification to ClipoardWin::SetData
       
 21782         Small amount code tidying, and allowing for failure when writing an URL
       
 21783 
       
 21784         * page/win/EventHandlerWin.cpp:
       
 21785         (WebCore::EventHandler::createDraggingClipboard):
       
 21786           Updated for new ClipboardWin constructor
       
 21787         * platform/win/ClipboardWin.cpp:
       
 21788         (WebCore::ClipboardWin::ClipboardWin):
       
 21789         (WebCore::writeURL):
       
 21790         (WebCore::ClipboardWin::getData):
       
 21791           Tidying code, and allowing failure
       
 21792         (WebCore::ClipboardWin::setData):
       
 21793           Verifying that we're writing a valid url
       
 21794                     
       
 21795         * platform/win/ClipboardWin.h:
       
 21796         * platform/win/EditorWin.cpp:
       
 21797         (WebCore::Editor::newGeneralClipboard):
       
 21798           Updated for new ClipboardWin constructor
       
 21799 
       
 21800 2007-02-22  Oliver Hunt  <oliver@apple.com>
       
 21801 
       
 21802         Reviewed by Ada, Lou, and Steve.
       
 21803 
       
 21804         Last of the major Drag and drop implementation 
       
 21805         patches for windows:
       
 21806         * Adds support for DOM Clipboard during drag operations
       
 21807         * Un-statics and refactors a few Pasteboard and DragData functions
       
 21808           to allow them to share implementation with ClipboardWin and other 
       
 21809           drag logic
       
 21810         * Moves COMPtr.h from WebKit to WebCore
       
 21811         * Adds WCDataObject, which is basically a direct copy of
       
 21812           SDataObject from the app, with a few modifications to support
       
 21813           DOM clipboard functionality.  Also includes a few suggestions
       
 21814           from Ada and Steve, mostly involving memory management :D
       
 21815         
       
 21816         This resolves 
       
 21817         <rdar://problem/4821407> Cannot drag link to bookmarks bar to create new link
       
 21818         <rdar://problem/4869496> User Interaction Essentials: Drag
       
 21819 
       
 21820         * WebCore.vcproj/WebCore.vcproj:
       
 21821           Adding new files
       
 21822           
       
 21823         * page/win/DragControllerWin.cpp:
       
 21824         (WebCore::DragController::maxDragImageSize):
       
 21825           Maximum size of drag image to allow sharp edges
       
 21826           is 208x208
       
 21827           
       
 21828         * page/win/EventHandlerWin.cpp:
       
 21829         (WebCore::EventHandler::createDraggingClipboard):
       
 21830           Properly implemented now
       
 21831           
       
 21832         * platform/win/ClipboardWin.cpp:
       
 21833         (WebCore::):
       
 21834         (WebCore::clipboardTypeFromMIMEType):
       
 21835         (WebCore::ClipboardWin::ClipboardWin):
       
 21836         (WebCore::ClipboardWin::~ClipboardWin):
       
 21837         (WebCore::writeURL):
       
 21838           Helper function to write a url to a WCDataObject
       
 21839         (WebCore::ClipboardWin::clearData):
       
 21840         (WebCore::ClipboardWin::clearAllData):
       
 21841         (WebCore::ClipboardWin::getData):
       
 21842         (WebCore::ClipboardWin::setData):
       
 21843         (WebCore::addMimeTypesForFormat):
       
 21844           Helper function for ClipboardWin::types
       
 21845         (WebCore::ClipboardWin::types):
       
 21846         (WebCore::ClipboardWin::setDragImage):
       
 21847         (WebCore::ClipboardWin::setDragImageElement):
       
 21848           General setters, match behaviour of WebKit/Mac
       
 21849         (WebCore::ClipboardWin::createDragImage):
       
 21850           Creates a drag image for a DOM specified Image is specified
       
 21851           can't currently generate an image for an arbitrary element
       
 21852         (WebCore::imageToMarkup):
       
 21853           Wraps a url in an img tag
       
 21854         (WebCore::ClipboardWin::declareAndWriteDragImage):
       
 21855         (WebCore::ClipboardWin::writeURL):
       
 21856         (WebCore::ClipboardWin::writeRange):
       
 21857         (WebCore::ClipboardWin::hasData):
       
 21858           Implement Clipboard required by DragController.
       
 21859           Provides read/write DOM Clipboard implementation for dragging,
       
 21860           read only when accessing system clipboard.
       
 21861           
       
 21862         * platform/win/ClipboardWin.h:
       
 21863         (WebCore::ClipboardWin::dataObject):
       
 21864           Provide an accessor for the dataObject
       
 21865           
       
 21866         * platform/win/DragDataWin.cpp:
       
 21867         (WebCore::urlWFormat):
       
 21868         (WebCore::urlFormat):
       
 21869         (WebCore::plainTextFormat):
       
 21870         (WebCore::plainTextWFormat):
       
 21871         (WebCore::texthtmlFormat):
       
 21872         (WebCore::htmlFormat):
       
 21873         (WebCore::getURL):
       
 21874         (WebCore::DragData::asURL):
       
 21875         (WebCore::getPlainText):
       
 21876         (WebCore::DragData::asPlainText):
       
 21877         (WebCore::DragData::asFragment):
       
 21878           Refactoring and removing of a few static modifiers to allow sharing with Clipboard
       
 21879           
       
 21880         * platform/win/DragImageWin.cpp:
       
 21881         (WebCore::dragImageSize):
       
 21882         (WebCore::deleteDragImage):
       
 21883         (WebCore::allocImage):
       
 21884         (WebCore::createCgContextFromBitmap):
       
 21885         (WebCore::scaleDragImage):
       
 21886         (WebCore::dissolveDragImageToFraction):
       
 21887         (WebCore::createDragImageFromImage):
       
 21888         (WebCore::createDragImageIconForCachedImage):
       
 21889           Implement DragImage functions
       
 21890           
       
 21891         * platform/win/EditorWin.cpp:
       
 21892         (WebCore::Editor::newGeneralClipboard):
       
 21893           Creating a Clipboard that wraps the system clipboard
       
 21894           
       
 21895         * platform/win/PasteboardWin.cpp:
       
 21896         (WebCore::createGlobalData):
       
 21897         (WebCore::markupToCF_HTML):
       
 21898         (WebCore::urlToMarkup):
       
 21899         (WebCore::replaceNBSP):
       
 21900           removing 'static'
       
 21901           
       
 21902         * platform/win/WCDataObject.cpp: Added.
       
 21903         (WebCore::WCEnumFormatEtc::WCEnumFormatEtc):
       
 21904         (WebCore::WCEnumFormatEtc::QueryInterface):
       
 21905         (WebCore::WCEnumFormatEtc::AddRef):
       
 21906         (WebCore::WCEnumFormatEtc::Release):
       
 21907         (WebCore::WCEnumFormatEtc::Next):
       
 21908         (WebCore::WCEnumFormatEtc::Skip):
       
 21909         (WebCore::WCEnumFormatEtc::Reset):
       
 21910         (WebCore::WCEnumFormatEtc::Clone):
       
 21911         (WebCore::WCDataObject::createInstance):
       
 21912         (WebCore::WCDataObject::WCDataObject):
       
 21913         (WebCore::WCDataObject::~WCDataObject):
       
 21914         (WebCore::WCDataObject::QueryInterface):
       
 21915         (WebCore::WCDataObject::AddRef):
       
 21916         (WebCore::WCDataObject::Release):
       
 21917         (WebCore::WCDataObject::GetData):
       
 21918         (WebCore::WCDataObject::GetDataHere):
       
 21919         (WebCore::WCDataObject::QueryGetData):
       
 21920         (WebCore::WCDataObject::GetCanonicalFormatEtc):
       
 21921         (WebCore::WCDataObject::SetData):
       
 21922         (WebCore::WCDataObject::CopyMedium):
       
 21923         (WebCore::WCDataObject::EnumFormatEtc):
       
 21924         (WebCore::WCDataObject::DAdvise):
       
 21925         (WebCore::WCDataObject::DUnadvise):
       
 21926         (WebCore::WCDataObject::EnumDAdvise):
       
 21927         (WebCore::WCDataObject::clearData):
       
 21928           Copied from SDataObject in the App createInstance and clearData
       
 21929           are the only new functions.  clearData removes any entries in the
       
 21930           object with a specified CLIPFORMAT.
       
 21931           Have also made a few error and memory handling changes suggested
       
 21932           by Steve and Ada
       
 21933         * platform/win/WCDataObject.h: Added.
       
 21934           Header for the above
       
 21935 
       
 21936 2007-02-22  Adam Roben  <aroben@apple.com>
       
 21937 
       
 21938         Reviewed by Adele.
       
 21939 
       
 21940         Make sure we always paint the right size search results icon.
       
 21941 
       
 21942         * rendering/RenderThemeSafari.cpp:
       
 21943         (WebCore::RenderThemeSafari::paintSearchFieldCancelButton): Removed unused parameter.
       
 21944         (WebCore::RenderThemeSafari::paintSearchFieldDecoration): Ditto.
       
 21945         (WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration): Base
       
 21946         the control size off of the search field rect to ensure that the icon
       
 21947         and the control are the same size.
       
 21948         (WebCore::RenderThemeSafari::paintSearchFieldResultsButton): Ditto.
       
 21949 
       
 21950 2007-02-21  Adam Roben  <aroben@apple.com>
       
 21951 
       
 21952         Reviewed by Adele.
       
 21953 
       
 21954         Updated for SafariTheme changes.
       
 21955 
       
 21956         * rendering/RenderThemeSafari.cpp:
       
 21957         (WebCore::RenderThemeSafari::paintMenuList): Use DropDownButtonPart.
       
 21958 
       
 21959 2007-02-20  Adele Peterson  <adele@apple.com>
       
 21960 
       
 21961         Reviewed by Darin.
       
 21962 
       
 21963         * WebCore.vcproj/WebCore.vcproj: Added JSHTMLSelectElementCustom.h
       
 21964 
       
 21965 2007-02-20  Beth Dakin  <bdakin@apple.com>
       
 21966 
       
 21967         Reviewed by Maciej.
       
 21968 
       
 21969         Some changes needed to match moving writeImage() to the Pasteboard 
       
 21970         on the Mac.
       
 21971 
       
 21972         * platform/win/PasteboardWin.cpp:
       
 21973         (WebCore::Pasteboard::writeURL): Now takes a bool indicating if the 
       
 21974         url if for an image.
       
 21975         (WebCore::Pasteboard::writeImage): This is just a stub for now. I 
       
 21976         am putting it here instead of on TemporaryLinkStubs because I plan 
       
 21977         on implementing it very soon.
       
 21978 
       
 21979 2007-02-20  Adam Roben  <aroben@apple.com>
       
 21980 
       
 21981         Reviewed by Darin and Anders.
       
 21982 
       
 21983         Fix <rdar://problem/5003318> App: Status bar text is more difficult to
       
 21984         read than Mac OS X Safari
       
 21985 
       
 21986         * WebCore.vcproj/WebCore.vcproj: Added new files.
       
 21987         * platform/win/FileChooserWin.cpp:
       
 21988         (WebCore::FileChooser::openFileChooser):
       
 21989         (WebCore::FileChooser::basenameForWidth): Added truncation.
       
 21990         * platform/win/WebCoreTextRenderer.cpp:
       
 21991         (WebCore::WebCoreDrawTextAtPoint): Added bottomAlign and centerTruncate parameters.
       
 21992         * platform/win/WebCoreTextRenderer.h: Ditto.
       
 21993 
       
 21994 2007-02-20  Alice Liu  <alice.liu@apple.com>
       
 21995 
       
 21996         Build fix
       
 21997 
       
 21998         * WebCore.vcproj/WebCore.vcproj:
       
 21999         Added PositionIterator.cpp & h
       
 22000 
       
 22001 2007-02-20  Steve Falkenburg  <sfalken@apple.com>
       
 22002 
       
 22003         Production build fix
       
 22004 
       
 22005         * WebCore.vcproj/WebCore.vcproj:
       
 22006 
       
 22007 2007-02-19  Geoffrey Garen  <ggaren@apple.com>
       
 22008 
       
 22009         Reviewed by Adam Roben.
       
 22010 
       
 22011         Fixed some leaks in RenderThemeSafari.
       
 22012         
       
 22013         I just merged some of the code I wrote for RenderThemeMac.
       
 22014         
       
 22015         * rendering/RenderThemeSafari.cpp:
       
 22016         (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
       
 22017         (WebCore::RenderThemeSafari::paintSliderTrack):
       
 22018 
       
 22019 2007-02-19  Anders Carlsson  <acarlsson@apple.com>
       
 22020 
       
 22021         Reviewed by Oliver.
       
 22022 
       
 22023         Fix build.
       
 22024 
       
 22025         * page/win/DragControllerWin.cpp:
       
 22026         (WebCore::DragController::maxDragImageSize):
       
 22027 
       
 22028 2007-02-19  Adele Peterson  <adele@apple.com>
       
 22029 
       
 22030         Reviewed by Adam.
       
 22031 
       
 22032         Fix for <rdar://problem/5006882> PlatformScrollbarSafari doesn't support small scroll bars
       
 22033 
       
 22034         * platform/win/PlatformScrollBar.h:
       
 22035         * platform/win/PlatformScrollBarSafari.cpp:
       
 22036         (WebCore::):
       
 22037         (WebCore::PlatformScrollbar::PlatformScrollbar):
       
 22038         (WebCore::trackRepaintRect):
       
 22039         (WebCore::buttonRepaintRect):
       
 22040         (WebCore::PlatformScrollbar::invalidateTrack):
       
 22041         (WebCore::PlatformScrollbar::invalidatePart):
       
 22042         (WebCore::PlatformScrollbar::backButtonRect):
       
 22043         (WebCore::PlatformScrollbar::forwardButtonRect):
       
 22044         (WebCore::PlatformScrollbar::trackRect):
       
 22045         (WebCore::PlatformScrollbar::splitTrack):
       
 22046         (WebCore::PlatformScrollbar::thumbLength):
       
 22047         (WebCore::PlatformScrollbar::paintButton):
       
 22048         (WebCore::PlatformScrollbar::paintTrack):
       
 22049         (WebCore::PlatformScrollbar::paintThumb):
       
 22050         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
       
 22051         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
       
 22052         * platform/win/PopupMenuWin.cpp:
       
 22053         (WebCore::PopupMenu::show):
       
 22054         (WebCore::PopupMenu::calculatePositionAndSize):
       
 22055 
       
 22056 2007-02-19  Anders Carlsson  <acarlsson@apple.com>
       
 22057 
       
 22058         Reviewed by Adam.
       
 22059 
       
 22060         <rdar://problem/5008424>
       
 22061         Regression: Crash loading mp3.com
       
 22062         
       
 22063         * platform/network/cf/ResourceErrorCF.cpp:
       
 22064         (WebCore::ResourceError::ResourceError):
       
 22065         Handle null resource errrors.
       
 22066 
       
 22067 2007-02-19  Adam Roben  <aroben@apple.com>
       
 22068 
       
 22069         Build fix.
       
 22070 
       
 22071         * bridge/win/FrameWin.cpp:
       
 22072         (WebCore::computePageRectsForFrame): This is no longer an instance
       
 22073         method of Frame.
       
 22074         * bridge/win/FrameWin.h:
       
 22075 
       
 22076 2007-02-18  Maciej Stachowiak  <mjs@apple.com>
       
 22077 
       
 22078         Reviewed by Oliver.
       
 22079 
       
 22080         - Adapt for Lars's patch to clean up Frame
       
 22081 
       
 22082         * bridge/win/FrameWin.cpp:
       
 22083         (WebCore::Frame::cleanupPlatformScriptObjects):
       
 22084         (WebCore::Frame::createScriptInstanceForWidget):
       
 22085         (WebCore::Frame::computePageRects):
       
 22086         (WebCore::drawRectIntoContext):
       
 22087         (WebCore::imageFromSelection):
       
 22088         (WebCore::Frame::isCharacterSmartReplaceExempt):
       
 22089         * bridge/win/FrameWin.h:
       
 22090         * page/win/EventHandlerWin.cpp:
       
 22091         * platform/win/ScrollViewWin.cpp:
       
 22092         (WebCore::ScrollView::windowResizerRect):
       
 22093         (WebCore::ScrollView::addToDirtyRegion):
       
 22094         (WebCore::ScrollView::scrollBackingStore):
       
 22095         (WebCore::ScrollView::updateBackingStore):
       
 22096         * platform/win/TemporaryLinkStubs.cpp:
       
 22097         (Frame::print):
       
 22098         (Frame::issueTransposeCommand):
       
 22099         (WebCore::Frame::respondToChangedSelection):
       
 22100         * plugins/win/PluginDatabaseWin.cpp:
       
 22101         (WebCore::PluginDatabaseWin::createPluginView):
       
 22102         * plugins/win/PluginDatabaseWin.h:
       
 22103         * plugins/win/PluginViewWin.cpp:
       
 22104         (WebCore::PluginViewWin::createNullPluginView):
       
 22105         (WebCore::PluginViewWin::PluginViewWin):
       
 22106         * plugins/win/PluginViewWin.h:
       
 22107 
       
 22108 2007-02-18  Ada Chan  <adachan@apple.com>
       
 22109 
       
 22110         Reviewed by Adam.
       
 22111 
       
 22112         Move app text controls to use WebView.
       
 22113         - added a method to let us render text using WebKit.
       
 22114 
       
 22115         * WebCore.vcproj/WebCore.vcproj:
       
 22116         * platform/win/WebCoreTextRenderer.cpp: Added.
       
 22117         (WebCore::WebCoreDrawTextAtPoint):
       
 22118         * platform/win/WebCoreTextRenderer.h: Added.
       
 22119 
       
 22120 2007-02-18  Adam Roben  <aroben@apple.com>
       
 22121 
       
 22122         Rubberstamped by Hyatt.
       
 22123 
       
 22124         Fix <rdar://problem/5006918> All selected text is black, even if it is
       
 22125         some other color when not selected
       
 22126 
       
 22127         * platform/win/PopupMenuWin.cpp:
       
 22128         (WebCore::PopupMenu::paint): Use the listbox colors for selected items.
       
 22129         * rendering/RenderThemeSafari.cpp: Removed platformActiveSelectionForegroundColor.
       
 22130         * rendering/RenderThemeSafari.h: Ditto.
       
 22131 
       
 22132 2007-02-18  Adam Roben  <aroben@apple.com>
       
 22133 
       
 22134         Reviewed by Hyatt.
       
 22135 
       
 22136         Fix <rdar://problem/5006872> <select> popups need Aqua scroll bars
       
 22137 
       
 22138         PopupMenuWin now uses a PlatformScrollbar.
       
 22139 
       
 22140         * platform/win/PlatformScrollBarSafari.cpp:
       
 22141         (WebCore::PlatformScrollbar::hitTest): Allow hit testing even when we
       
 22142         don't have a parent widget.
       
 22143         (WebCore::PlatformScrollbar::autoscrollPressedPart): Don't autoscroll
       
 22144         if nothing is pressed.
       
 22145         * platform/win/PopupMenuWin.cpp: m_scrollOffset is now measured in menu
       
 22146         items, not in pixels.
       
 22147         (WebCore::PopupMenu::PopupMenu): Initialize new member.
       
 22148         (WebCore::PopupMenu::show): Make popups partially transparent, don't
       
 22149         use Windows' built-in scroll bars, and create a PlatformScrollbar if
       
 22150         needed.
       
 22151         (WebCore::PopupMenu::calculatePositionAndSize): Get the scroll bar's
       
 22152         width from PlatformScrollbar instead of from Windows.
       
 22153         (WebCore::PopupMenu::visibleItems): Added.
       
 22154         (WebCore::PopupMenu::listIndexAtPoint): Definition moved here from header.
       
 22155         (WebCore::PopupMenu::invalidateItem): Update for m_scrollOffset change,
       
 22156         and shrink the damage rect to not invalidate the scroll bar unnecessarily.
       
 22157         (WebCore::PopupMenu::scrollToRevealSelection): Updated to use PlatformScrollbar.
       
 22158         (WebCore::PopupMenu::updateFromElement): Changed bool to BOOL.
       
 22159         (WebCore::PopupMenu::paint): Updated for m_scrollOffset change, and
       
 22160         paint the scroll bar at the end.
       
 22161         (WebCore::PopupMenu::valueChanged): Added. Code comes from the old scrollTo method.
       
 22162         (WebCore::PopupMenu::windowClipRect): Added.
       
 22163         (WebCore::PopupWndProc):
       
 22164             - Set up the scroll bar in WM_SIZE
       
 22165             - Send mouse events to the scroll bar when appropriate
       
 22166             - Get rid of handling of WM_VSCROLL events (we shouldn't receive these anymore)
       
 22167 
       
 22168 2007-02-18  Oliver Hunt  <oliver@apple.com>
       
 22169 
       
 22170         Reviewed by Adam.
       
 22171 
       
 22172         Updated to include stubs for drag and drop methods
       
 22173         Added DragImage[Win].cpp to project file
       
 22174         Now uses platform independent EventHandler::handleDrag
       
 22175 
       
 22176         * WebCore.vcproj/WebCore.vcproj:
       
 22177 
       
 22178         * bridge/win/FrameWin.cpp:
       
 22179         (WebCore::Frame::dragImageForSelection):
       
 22180           Just wrap the platform specific selectionImage method
       
 22181 
       
 22182         * page/win/DragControllerWin.cpp:
       
 22183           Defining constants for drag images -- basically copied the Mac definitions
       
 22184 
       
 22185         * page/win/EventHandlerWin.cpp:
       
 22186         (WebCore::EventHandler::createDraggingClipboard):
       
 22187           Basic implementation -- needs to create an IDataObject to be useful
       
 22188           but ClipboardWin is basically unimplemented anyway so not yet a problem
       
 22189 
       
 22190         * platform/win/ClipboardWin.cpp:
       
 22191         (WebCore::ClipboardWin::createDragImage):
       
 22192         (WebCore::ClipboardWin::declareAndWriteDragImage):
       
 22193         (WebCore::ClipboardWin::writeURL):
       
 22194         (WebCore::ClipboardWin::writeRange):
       
 22195         (WebCore::ClipboardWin::hasData):
       
 22196           Stubs
       
 22197 
       
 22198         * platform/win/ClipboardWin.h:
       
 22199           Updated interface
       
 22200 
       
 22201         * platform/win/DragImageWin.cpp: Added.
       
 22202         (WebCore::dragImageSize):
       
 22203         (WebCore::deleteDragImage):
       
 22204         (WebCore::scaleDragImage):
       
 22205         (WebCore::dissolveDragImageToFraction):
       
 22206         (WebCore::createDragImageFromImage):
       
 22207         (WebCore::createDragImageIconForCachedImage):
       
 22208           Stubs
       
 22209 
       
 22210 2007-02-17  Adam Roben  <aroben@apple.com>
       
 22211 
       
 22212         * WebCore.vcproj/WebCore.vcproj: Removed bogus single-file
       
 22213         configuration for MimeTypeRegistryWin.cpp.
       
 22214 
       
 22215 2007-02-17  David Hyatt  <hyatt@apple.com>
       
 22216 
       
 22217         Part of the OpenSource fix to make sure the fill color starts off as transparent.  Make sure our CG context
       
 22218         has its state properly in sync with the CGContext.
       
 22219 
       
 22220         Reviewed by aroben
       
 22221 
       
 22222         * platform/win/GraphicsContextWin.cpp:
       
 22223         (WebCore::GraphicsContext::GraphicsContext):
       
 22224 
       
 22225 2007-02-17  Adam Roben  <aroben@apple.com>
       
 22226 
       
 22227         Build fix.
       
 22228 
       
 22229         * platform/win/CursorWin.cpp:
       
 22230         (WebCore::notAllowedCursor):
       
 22231 
       
 22232 2007-02-17  Dave Hyatt <hyatt@apple.com>
       
 22233 
       
 22234         Change how resizers are invalidated to fix Radar bug #4976772.
       
 22235         
       
 22236         Reviewed by olliej
       
 22237 
       
 22238         * platform/win/GraphicsContextWin.cpp:
       
 22239         (WebCore::GraphicsContext::GraphicsContext):
       
 22240         * platform/win/ScrollViewWin.cpp:
       
 22241         (WebCore::ScrollView::suppressScrollbars):
       
 22242         (WebCore::ScrollView::paint):
       
 22243         (WebCore::ScrollView::adjustOverlappingScrollbarCount):
       
 22244         * platform/win/WidgetWin.cpp:
       
 22245         (WebCore::Widget::invalidateRect):
       
 22246 
       
 22247 2007-02-16  Dave Hyatt <hyatt@apple.com>
       
 22248 
       
 22249         Fix for Radar bug #4981074, RSS Scrollbar overlaps window resizer.  Teach all scrollbars how to
       
 22250         avoid the window resizer.
       
 22251         
       
 22252         Reviewed by aroben
       
 22253 
       
 22254         * platform/win/PlatformScrollBar.h:
       
 22255         * platform/win/PlatformScrollBarSafari.cpp:
       
 22256         (WebCore::PlatformScrollbar::PlatformScrollbar):
       
 22257         (WebCore::PlatformScrollbar::setRect):
       
 22258         (WebCore::PlatformScrollbar::setParent):
       
 22259         * platform/win/PlatformScrollBarWin.cpp:
       
 22260         (WebCore::PlatformScrollbar::PlatformScrollbar):
       
 22261         (WebCore::PlatformScrollbar::setRect):
       
 22262         (WebCore::PlatformScrollbar::setParent):
       
 22263         * platform/win/ScrollViewWin.cpp:
       
 22264         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
       
 22265         (WebCore::ScrollView::updateScrollbars):
       
 22266         (WebCore::ScrollView::resizerOverlapsContent):
       
 22267         (WebCore::ScrollView::adjustOverlappingScrollbarCount):
       
 22268         (WebCore::ScrollView::setParent):
       
 22269 
       
 22270 2007-02-16  Adam Roben  <aroben@apple.com>
       
 22271 
       
 22272         Rubberstamped by Anders.
       
 22273 
       
 22274         * platform/win/PlatformScrollBarSafari.cpp:
       
 22275         (WebCore::PlatformScrollbar::paint): Don't draw the arrows when we're disabled.
       
 22276 
       
 22277 2007-02-15  Dave Hyatt  <hyatt@apple.com>
       
 22278 
       
 22279         Reviewed by Adam.
       
 22280 
       
 22281         Fix for 4804657 and 4952931, scroll view gets confused and ends up at a bad scroll
       
 22282         offset.
       
 22283         
       
 22284         * platform/win/ScrollViewWin.cpp:
       
 22285         (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
       
 22286         (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore):
       
 22287         (WebCore::ScrollView::updateScrollbars):
       
 22288 
       
 22289 2007-02-16  Anders Carlsson  <acarlsson@apple.com>
       
 22290 
       
 22291         Reviewed by Adam.
       
 22292 
       
 22293         <rdar://problem/4993040>
       
 22294         Crash in plugin code watching yahoo news video
       
 22295         
       
 22296         Zero out the plugin function struct.
       
 22297         
       
 22298         * plugins/win/PluginPackageWin.cpp:
       
 22299         (WebCore::PluginPackageWin::load):
       
 22300 
       
 22301 2007-02-16  Anders Carlsson  <acarlsson@apple.com>
       
 22302 
       
 22303         Fix build.
       
 22304 
       
 22305         Use adoptCF instead of adopt.
       
 22306 
       
 22307         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 22308         (WebCore::ResourceHandle::start):
       
 22309         * platform/network/cf/ResourceRequestCFNet.cpp:
       
 22310         (WebCore::ResourceRequest::doUpdatePlatformRequest):
       
 22311 
       
 22312 2007-02-16  Adam Roben  <aroben@apple.com>
       
 22313 
       
 22314         Reviewed by Oliver.
       
 22315 
       
 22316         Implemented square button look.
       
 22317 
       
 22318         * rendering/RenderThemeSafari.cpp:
       
 22319         (WebCore::RenderThemeSafari::adjustRepaintRect): Only inflate the rect
       
 22320         if we have a pushbutton.
       
 22321         (WebCore::RenderThemeSafari::paintButton): Ditto.
       
 22322 
       
 22323 2007-02-15  Anders Carlsson  <acarlsson@apple.com>
       
 22324 
       
 22325         Reviewed by Adam.
       
 22326 
       
 22327         Add the default Flash plugin location to the list of plugin paths.
       
 22328 
       
 22329         * plugins/win/PluginDatabaseWin.cpp:
       
 22330         (WebCore::addFlashPluginPath):
       
 22331         (WebCore::PluginDatabaseWin::defaultPluginPaths):
       
 22332 
       
 22333 2007-02-15  Lou Amadio  <lamadio@apple.com>
       
 22334 
       
 22335         Reviewed by Steve.
       
 22336 
       
 22337         <rdar://problem/4945799> CGText: should use correct mechanism to set font smoothing style
       
 22338         
       
 22339         * platform/win/FontWin.cpp:
       
 22340         (WebCore::Font::drawGlyphs):
       
 22341 
       
 22342 2007-02-15  Anders Carlsson  <acarlsson@apple.com>
       
 22343 
       
 22344         Reviewed by Adam.
       
 22345 
       
 22346         <rdar://problem/4987529>
       
 22347         Regression: first clicks don't work at flash-based Nokia.com
       
 22348 
       
 22349         * plugins/win/PluginViewWin.cpp:
       
 22350         (WebCore::PluginViewWin::handleMouseEvent):
       
 22351         Don't set buttons for mouse move. Also, ignore unknown mouse events.
       
 22352 
       
 22353 2007-02-13  Brady Eidson  <beidson@apple.com>
       
 22354 
       
 22355         Reviewed by Adam
       
 22356 
       
 22357         Switch permanently from CFStreamError to CFErrorRef in ResourceHandleCF
       
 22358 
       
 22359         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 22360         (WebCore::didFail):
       
 22361         (WebCore::ResourceHandle::start):
       
 22362 
       
 22363 2007-02-13  Adam Roben  <aroben@apple.com>
       
 22364 
       
 22365         Build fix.
       
 22366 
       
 22367         * WebCore.vcproj/WebCore.vcproj: Remove SVGDOMImplementation.(cpp|h)
       
 22368 
       
 22369 2007-02-12  Ada Chan  <adachan@apple.com>
       
 22370 
       
 22371         Reviewed by Steve.
       
 22372 
       
 22373         <rdar://4952715> Events not being passed from WebCore/WebKit up through IWebForm::doCommandBySelector
       
 22374         Frame::doTextFieldCommandFromEvent()'s signature has changed from taking in a PlatformKeyboardEvent
       
 22375         to KeyboardEvent.  Match that in FrameWin.
       
 22376 
       
 22377         * bridge/win/FrameWin.cpp:
       
 22378         (WebCore::FrameWin::doTextFieldCommandFromEvent):
       
 22379         * bridge/win/FrameWin.h:
       
 22380 
       
 22381 2007-02-10  Adam Roben  <aroben@apple.com>
       
 22382 
       
 22383         Rubberstamped by Oliver.
       
 22384 
       
 22385         * rendering/RenderThemeSafari.cpp:
       
 22386         (WebCore::RenderThemeSafari::paintButton): Call controlSizeFromRect
       
 22387         instead of controlSizeForFont to determine the correct control size.
       
 22388 
       
 22389 2007-02-09  Alice Liu  <alice.liu@apple.com>
       
 22390 
       
 22391         Reviewed by Brady and Adam.
       
 22392 
       
 22393         Fixed <rdar://4986194> Typing in content editable body does not automatically scroll to reveal cursor
       
 22394 
       
 22395         * platform/win/ScrollViewWin.cpp:
       
 22396         (WebCore::ScrollView::updateScrollbars):
       
 22397         The scrollview's scrolloffset wasn't getting set in cases where there were no scrollbars
       
 22398         You can have a scrolloffset even if you don't have scrollbars
       
 22399 
       
 22400 2007-02-09  Darin Adler  <darin@apple.com>
       
 22401 
       
 22402         Reviewed by Adele.
       
 22403 
       
 22404         - Add TextEvent to the DOM (based on the proposed DOM level 3)
       
 22405           to be used to fix some international input bugs soon.
       
 22406           At this point, we don't send any text events.
       
 22407 
       
 22408         - Remove some obsolete files.
       
 22409 
       
 22410         * WebCore.vcproj/WebCore.vcproj: Add new files, remove obsolete files.
       
 22411 
       
 22412 2007-02-09  Anders Carlsson  <acarlsson@apple.com>
       
 22413 
       
 22414         Reviewed by Adam.
       
 22415 
       
 22416         * plugins/win/PluginViewWin.cpp:
       
 22417         (WebCore::PluginViewWin::performRequest):
       
 22418         Add the stream to the m_streams hash set.
       
 22419 
       
 22420 2007-02-08  Adele Peterson  <adele@apple.com>
       
 22421 
       
 22422         Reviewed by Brady.
       
 22423 
       
 22424         Fix for http://bugs.webkit.org/show_bug.cgi?id=12599
       
 22425         <rdar://problem/4973507> REGRESSION: When replying in Gmail, the caret disappears when you start to type (12599)
       
 22426 
       
 22427         This also fixes a bug where when you called window.focus() on a background window, it did not come to the front.
       
 22428 
       
 22429         * bridge/win/FrameWin.h: Removed focusWindow() and unfocusWindow() stubs since there are now implementations in the base class.
       
 22430         * platform/win/TemporaryLinkStubs.cpp:
       
 22431 
       
 22432 2007-02-08  Anders Carlsson  <acarlsson@apple.com>
       
 22433 
       
 22434         Reviewed by Geoff.
       
 22435 
       
 22436         <rdar://problem/4955068>
       
 22437         PluginViewWin leaks memory.
       
 22438         
       
 22439         Make streams ref-counted. Remove streams from the hash set once they're done loading.
       
 22440         
       
 22441         Don't try to paint if painting is disabled.
       
 22442         
       
 22443         * plugins/win/PluginStreamWin.cpp:
       
 22444         (WebCore::PluginStreamWin::PluginStreamWin):
       
 22445         (WebCore::PluginStreamWin::cancelAndDestroyStream):
       
 22446         (WebCore::PluginStreamWin::destroyStream):
       
 22447         * plugins/win/PluginStreamWin.h:
       
 22448         * plugins/win/PluginViewWin.cpp:
       
 22449         (WebCore::PluginViewWin::paint):
       
 22450         (WebCore::PluginViewWin::stop):
       
 22451         (WebCore::PluginViewWin::~PluginViewWin):
       
 22452         (WebCore::PluginViewWin::disconnectStream):
       
 22453         * plugins/win/PluginViewWin.h:
       
 22454 
       
 22455 2007-02-08  Adam Roben  <aroben@apple.com>
       
 22456 
       
 22457         Reviewed by Adele.
       
 22458 
       
 22459         Fix scrollbar painting.
       
 22460 
       
 22461         * platform/win/PlatformScrollBarSafari.cpp:
       
 22462         (WebCore::trackRepaintRect): Added.
       
 22463         (WebCore::buttonRepaintRect): Added.
       
 22464         (WebCore::PlatformScrollbar::invalidateTrack): Inavlidate the repaint
       
 22465         rect, not the rect used for hit testing.
       
 22466         (WebCore::PlatformScrollbar::invalidatePart): Ditto.
       
 22467         (WebCore::PlatformScrollbar::paint): Paint the track first, then the
       
 22468         buttons, then the thumb.
       
 22469         (WebCore::PlatformScrollbar::paintButton): Paint in the repaintRect,
       
 22470         not the rect used for hit testing.
       
 22471         (WebCore::PlatformScrollbar::paintTrack): Ditto.
       
 22472 
       
 22473 2007-02-08  Anders Carlsson  <acarlsson@apple.com>
       
 22474 
       
 22475         Remove unused stub.
       
 22476         
       
 22477         * platform/win/TemporaryLinkStubs.cpp:
       
 22478 
       
 22479 2007-02-08  Anders Carlsson  <acarlsson@apple.com>
       
 22480 
       
 22481         Reviewed by Brady.
       
 22482 
       
 22483         <rdar://problem/4888871>
       
 22484         Need to support synchronous XMLHttpRequest.
       
 22485 
       
 22486         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 22487         (WebCore::ResourceHandle::loadResourceSynchronously):
       
 22488 
       
 22489 2007-02-07  Adam Roben  <aroben@apple.com>
       
 22490 
       
 22491         Reviewed by Maciej.
       
 22492 
       
 22493         Fix mini search field painting.
       
 22494 
       
 22495         * rendering/RenderThemeSafari.cpp:
       
 22496         (WebCore::RenderThemeSafari::searchFieldSizes): Use the right height.
       
 22497 
       
 22498 2007-02-07  Adele Peterson  <adele@apple.com>
       
 22499 
       
 22500         Reviewed by Adam.
       
 22501 
       
 22502         Draw a single down arrow for styled menu lists.
       
 22503 
       
 22504         * rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButton):
       
 22505         * rendering/RenderThemeWin.cpp: Moved #ifndef USE_SAFARI_THEME to enclose the body of the file.
       
 22506 
       
 22507 2007-02-07  Brady Eidson  <beidson@apple.com>
       
 22508 
       
 22509         RS = Adam
       
 22510         
       
 22511         Touch these files to force it to recompile...
       
 22512 
       
 22513         * platform/win/PlatformScrollBarSafari.cpp:
       
 22514         * rendering/RenderThemeWin.cpp:
       
 22515 
       
 22516 2007-02-07  Adam Roben  <aroben@apple.com>
       
 22517 
       
 22518         Rubberstamped by Maciej.
       
 22519 
       
 22520         Turn on SafariTheme so we can try it out.
       
 22521 
       
 22522         * WebCore.vcproj/WebCore.vcproj:
       
 22523 
       
 22524 2007-02-07  Adam Roben  <aroben@apple.com>
       
 22525 
       
 22526         Reviewed by Adele.
       
 22527 
       
 22528         * rendering/RenderThemeSafari.cpp:
       
 22529         (WebCore::RenderThemeSafari::determineState): Pass focus information down to SafariTheme.
       
 22530 
       
 22531 2007-02-06  Adam Roben  <aroben@apple.com>
       
 22532 
       
 22533         Rubberstamped by Brady.
       
 22534 
       
 22535         Updated for log channel rename.
       
 22536 
       
 22537         * platform/win/GDIObjectCounter.cpp:
       
 22538         (WebCore::GDIObjectCounter::~GDIObjectCounter):
       
 22539 
       
 22540 2007-02-06  Adele Peterson  <adele@apple.com>
       
 22541 
       
 22542         Reviewed by Adam.
       
 22543 
       
 22544         Added support for radio buttons and checkboxes.
       
 22545 
       
 22546         * platform/win/PlatformScrollBarSafari.cpp:
       
 22547         (WebCore::PlatformScrollbar::paintButton):
       
 22548         (WebCore::PlatformScrollbar::paintTrack):
       
 22549         (WebCore::PlatformScrollbar::paintThumb):
       
 22550         * rendering/RenderThemeSafari.cpp:
       
 22551         (WebCore::RenderThemeSafari::determineState):
       
 22552         (WebCore::RenderThemeSafari::platformActiveSelectionForegroundColor):
       
 22553         (WebCore::RenderThemeSafari::adjustRepaintRect):
       
 22554         (WebCore::RenderThemeSafari::paintCheckbox):
       
 22555         (WebCore::RenderThemeSafari::checkboxMargins):
       
 22556         (WebCore::RenderThemeSafari::paintRadio):
       
 22557         (WebCore::RenderThemeSafari::radioMargins):
       
 22558         (WebCore::RenderThemeSafari::adjustMenuListStyle):
       
 22559         (WebCore::RenderThemeSafari::paintSliderThumb):
       
 22560         * rendering/RenderThemeSafari.h:
       
 22561 
       
 22562 2007-02-05  Adam Roben  <aroben@apple.com>
       
 22563 
       
 22564         Reviewed by Ada and Oliver.
       
 22565 
       
 22566         Add a GDIObjectCounter class that informs us of GDI leaks.
       
 22567 
       
 22568         * WebCore.vcproj/WebCore.vcproj: Added new files.
       
 22569         * platform/win/GDIObjectCounter.cpp: Added.
       
 22570         (WebCore::GDIObjectCounter::GDIObjectCounter):
       
 22571         (WebCore::GDIObjectCounter::init):
       
 22572         (WebCore::GDIObjectCounter::~GDIObjectCounter):
       
 22573         (WebCore::GDIObjectCounter::currentGDIObjectsInUse):
       
 22574         * platform/win/GDIObjectCounter.h: Added.
       
 22575 
       
 22576 2007-02-05  Adam Roben  <aroben@apple.com>
       
 22577 
       
 22578         Build fix.
       
 22579 
       
 22580         * WebCore.vcproj/WebCore.vcproj: Add new files.
       
 22581 
       
 22582 2007-02-04  Oliver Hunt  <oliver@apple.com>
       
 22583 
       
 22584         Reviewed by Adam.           
       
 22585 
       
 22586         Removed unimplemented EventHandler::handleMouseUp, 
       
 22587         as a platform independent version is available now.
       
 22588 
       
 22589         * page/win/EventHandlerWin.cpp:
       
 22590         (WebCore::EventHandler::eventActivatedView): 
       
 22591           Now we use this method, it needs to be implemented
       
 22592 
       
 22593 2007-02-02  Steve Falkenburg  <sfalken@apple.com>
       
 22594 
       
 22595         Fix build.
       
 22596 
       
 22597         * WebCore.vcproj/WebCore.vcproj:
       
 22598 
       
 22599 2007-02-02  Steve Falkenburg  <sfalken@apple.com>
       
 22600 
       
 22601         * platform/network/cf/FormDataStreamCFNet.cpp:
       
 22602 
       
 22603 2007-02-02  Adam Roben  <aroben@apple.com>
       
 22604 
       
 22605         Turn on Lucida Grande.
       
 22606 
       
 22607         * rendering/RenderThemeSafari.cpp:
       
 22608         (WebCore::RenderThemeSafari::systemFont):
       
 22609             Use Lucida Grande.
       
 22610         (WebCore::RenderThemeSafari::setFontFromControlSize):
       
 22611             Ditto.
       
 22612         (WebCore::RenderThemeSafari::controlSizeForSystemFont):
       
 22613             Implemented using font sizes from NSFont.m.
       
 22614         (WebCore::RenderThemeSafari::adjustRepaintRect):
       
 22615             Uncommented.
       
 22616         (WebCore::RenderThemeSafari::minimumMenuListSize):
       
 22617             Ditto.
       
 22618 
       
 22619 2007-02-02  Adam Roben  <aroben@apple.com>
       
 22620 
       
 22621         Reviewed by Maciej.
       
 22622 
       
 22623         Implemented menulist drawing.
       
 22624 
       
 22625         * rendering/RenderThemeSafari.cpp:
       
 22626         (WebCore::controlSizeFromRect):
       
 22627             Moved to top of file.
       
 22628         (WebCore::RenderThemeSafari::adjustRepaintRect):
       
 22629             Uncommented menulist case.
       
 22630         (WebCore::RenderThemeSafari::popupButtonMargins):
       
 22631             Added controlSize parameter, made margins match AppKit artwork.
       
 22632         (WebCore::RenderThemeSafari::paintMenuList):
       
 22633             Implemented.
       
 22634         * rendering/RenderThemeSafari.h:
       
 22635             Updated decalartion.
       
 22636 
       
 22637 2007-02-01  Anders Carlsson  <acarlsson@apple.com>
       
 22638 
       
 22639         Reviewed by Brady.
       
 22640 
       
 22641         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 22642         (WebCore::willSendRequest):
       
 22643         Make sure to always retain the request we return. (In practice, we were already doing this since
       
 22644         client can never be null).
       
 22645         
       
 22646         (WebCore::didReceiveResponse):
       
 22647         Remove client null check.
       
 22648 
       
 22649 2007-02-01  Steve Falkenburg  <sfalken@apple.com>
       
 22650 
       
 22651         Production build fix
       
 22652 
       
 22653         * WebCore.vcproj/WebCore.vcproj:
       
 22654 
       
 22655 2007-01-31  Oliver Hunt  <oliver@apple.com>
       
 22656 
       
 22657         Reviewed by Adam.
       
 22658 
       
 22659         Updating event handler logic to make use of methods migrated from 
       
 22660         WebKit to WebCore
       
 22661 
       
 22662         * page/win/EventHandlerWin.cpp:
       
 22663         (WebCore::EventHandler::handleDrag):   
       
 22664           Updating handleDrag to use methods that we've migrated to WebCore
       
 22665         * platform/win/PlatformMouseEventWin.cpp:
       
 22666         (WebCore::messageToEventType):                        
       
 22667         (WebCore::PlatformMouseEvent::PlatformMouseEvent):   
       
 22668           provide the type of mouse event
       
 22669           
       
 22670 
       
 22671 2007-01-31  Steve Falkenburg  <sfalken@apple.com>
       
 22672 
       
 22673         Reviewed by Ada.
       
 22674 
       
 22675         Fix BString bugs.
       
 22676 
       
 22677         * platform/win/BString.cpp:
       
 22678         (WebCore::BString::BString): Call SysAllocString instead of SysAllocStringLen
       
 22679         (WebCore::BString::operator=): Add proper null checks
       
 22680         (WebCore::operator ==): Add proper null checks
       
 22681 
       
 22682 2007-01-30  Anders Carlsson  <acarlsson@apple.com>
       
 22683 
       
 22684         Build fix.
       
 22685         
       
 22686         * platform/win/TemporaryLinkStubs.cpp:
       
 22687         (ResourceHandle::setDefersLoading):
       
 22688 
       
 22689 2007-01-30  Steve Falkenburg  <sfalken@apple.com>
       
 22690 
       
 22691         Production build fix
       
 22692 
       
 22693         * WebCore.vcproj/WebCore.vcproj:
       
 22694 
       
 22695 2007-01-29  Adam Roben  <aroben@apple.com>
       
 22696 
       
 22697         Build fix.
       
 22698 
       
 22699         * platform/win/TemporaryLinkStubs.cpp: Removed old stub.
       
 22700 
       
 22701 2007-01-29  Brady Eidson  <beidson@apple.com>
       
 22702 
       
 22703         Reviewed by Oliver
       
 22704 
       
 22705         All the downloads plumbing for if you have ToT CFNetwork + my changes
       
 22706         (or after they submit with my changes)
       
 22707 
       
 22708         * platform/network/cf/FormDataStreamCFNet.cpp: Reword the #ifdef for CFNetwork ToT for clarity
       
 22709         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 22710         (WebCore::didFail): Use a RetainPtr .get()
       
 22711         (WebCore::ResourceHandleInternal::~ResourceHandleInternal): Only cancel the connection if we hold the last ref
       
 22712         (WebCore::ResourceHandle::start): Use a RetainPtr - adopt and .get()
       
 22713         (WebCore::ResourceHandle::cancel): Use a RetainPtr .get()
       
 22714         (WebCore::ResourceHandle::receivedCredential):Use a RetainPtr .get()
       
 22715         (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): Use a RetainPtr .get()
       
 22716         (WebCore::ResourceHandle::connection): Use a RetainPtr .get()
       
 22717         * platform/network/cf/ResourceRequestCFNet.cpp:
       
 22718         (WebCore::ResourceRequest::doUpdatePlatformRequest): Prevent a crash if a null
       
 22719 
       
 22720 2007-01-29  Brady Eidson  <beidson@apple.com>
       
 22721 
       
 22722         Reviewed by Geoff
       
 22723 
       
 22724         Change LOG_NOTIMPL() to use a LOG() and its logging channel instead of LOG_ERROR()
       
 22725         so you can actually turn it off.
       
 22726         
       
 22727         * platform/win/NotImplemented.h:
       
 22728 
       
 22729 2007-01-29  Maciej Stachowiak  <mjs@apple.com>
       
 22730         
       
 22731         - fix build
       
 22732 
       
 22733         * platform/win/TemporaryLinkStubs.cpp:
       
 22734 
       
 22735 2007-01-29  Steve Falkenburg  <sfalken@apple.com>
       
 22736 
       
 22737         Fix build break from RootObject ownership change.
       
 22738 
       
 22739         * bridge/win/FrameWin.cpp:
       
 22740         (WebCore::FrameWin::createRootObject): Added
       
 22741         (WebCore::FrameWin::cleanupPluginObjects): change destroy to invalidate
       
 22742         (WebCore::FrameWin::bindingRootObject): change new RootObject to RootObject::create
       
 22743         * bridge/win/FrameWin.h: 
       
 22744         * plugins/win/PluginViewWin.cpp:
       
 22745         (WebCore::PluginViewWin::bindingInstance): change new RootObject to FrameWin::createRootObject.
       
 22746 
       
 22747 2007-01-26  Adam Roben  <aroben@apple.com>
       
 22748 
       
 22749         Reviewed by Oliver.
       
 22750 
       
 22751         Fix frequent failed assertions when painting scroll bars.
       
 22752 
       
 22753         * platform/win/PlatformScrollBarSafari.cpp:
       
 22754         (WebCore::PlatformScrollbar::paint): Check that painting is enabled
       
 22755         before painting.
       
 22756 
       
 22757 2007-01-26  Oliver Hunt <oliver@apple.com>
       
 22758 
       
 22759         Build fix.
       
 22760 
       
 22761         * WebCore.vcproj/WebCore.vcproj:
       
 22762 
       
 22763 2007-01-26  Beth Dakin  <bdakin@apple.com>
       
 22764 
       
 22765         Reviewed by Darin.
       
 22766 
       
 22767         Due to <rdar://problem/4956565> REGRESSION: After scrolling frame, 
       
 22768         hovering over link in this frame doesn't change cursor to pointing 
       
 22769         hand
       
 22770 
       
 22771         lastEventIsMouseUp() is a Mac-only issue. This patch makes it Mac-
       
 22772         only code, so we can remove the temporary link stub for it.
       
 22773 
       
 22774         * platform/win/TemporaryLinkStubs.cpp:
       
 22775 
       
 22776 2007-01-26  Oliver Hunt <oliver@apple.com>
       
 22777 
       
 22778         Build fix -- adding SVGInlineTextBox.{cpp,h} to project
       
 22779 
       
 22780         * WebCore.vcproj/WebCore.vcproj:
       
 22781 
       
 22782 2007-01-25  Oliver Hunt  <oliver@apple.com>
       
 22783 
       
 22784         Reviewed by Maciej.
       
 22785 
       
 22786         Fixed DragDataWin behaviour so that it will provide plain text
       
 22787         for a file dropped on the window.
       
 22788 
       
 22789         * platform/win/DragDataWin.cpp:
       
 22790         (WebCore::DragData::asPlainText):
       
 22791 
       
 22792 2007-01-25  Brady Eidson  <beidson@apple.com>
       
 22793 
       
 22794         Reviewed by Adam
       
 22795 
       
 22796         -Setup for new CFNetwork API for those using their ToT and their next submission
       
 22797         -Setup for new CoreFoundation API for those using their ToT and their next submission
       
 22798 
       
 22799         * platform/network/cf/FormDataStreamCFNet.cpp:
       
 22800         (WebCore::setHTTPBody): New callback format - will need to define USE_NEW_CFSTREAM_CALLBACKS 
       
 22801           to switch to the new API
       
 22802         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 22803         (WebCore::didFail):  This automagically works :)
       
 22804 
       
 22805 2007-01-25  Adele Peterson  <adele@apple.com>
       
 22806 
       
 22807         Reviewed by Adam. 
       
 22808 
       
 22809         Added support for slider.
       
 22810 
       
 22811         * rendering/RenderThemeSafari.cpp:
       
 22812         (WebCore::RenderThemeSafari::RenderThemeSafari):
       
 22813         (WebCore::RenderThemeSafari::inflateRect):
       
 22814         (WebCore::RenderThemeSafari::paintSliderTrack):
       
 22815         (WebCore::RenderThemeSafari::paintSliderThumb):
       
 22816         * rendering/RenderThemeSafari.h:
       
 22817 
       
 22818 2007-01-25  Steve Falkenburg  <sfalken@apple.com>
       
 22819 
       
 22820         Production build fix
       
 22821 
       
 22822         * WebCore.vcproj/WebCore.vcproj:
       
 22823 
       
 22824 2007-01-24  Adele Peterson  <adele@apple.com>
       
 22825 
       
 22826         Reviewed by Brady and Oliver.
       
 22827 
       
 22828         Moved keyEvent method from FrameWin to EventHandler and updated
       
 22829         call sites.  Now this method is shared with the mac.
       
 22830 
       
 22831         * bridge/win/FrameWin.cpp:
       
 22832         * bridge/win/FrameWin.h:
       
 22833 
       
 22834 2007-01-24  Steve Falkenburg  <sfalken@apple.com>
       
 22835 
       
 22836         Reviewed by Lou.
       
 22837 
       
 22838         * bridge/win/FrameWin.cpp:
       
 22839         (WebCore::regExpForLabels): Ported from FrameMac.mm
       
 22840         (WebCore::FrameWin::searchForLabelsAboveCell): Ported from FrameMac.mm
       
 22841         (WebCore::FrameWin::searchForLabelsBeforeElement): Ported from FrameMac.mm
       
 22842         (WebCore::FrameWin::matchLabelsAgainstElement): Ported from FrameMac.mm
       
 22843         * bridge/win/FrameWin.h:
       
 22844 
       
 22845 2007-01-24  Adam Roben  <aroben@apple.com>
       
 22846 
       
 22847         Reviewed by Adele.
       
 22848 
       
 22849         Added PlatformScrollBarSafari for Aqua scroll bars.
       
 22850 
       
 22851         * WebCore.vcproj/WebCore.vcproj: Added new file to project.
       
 22852         * platform/win/PlatformScrollBarSafari.cpp: Added. Copied from PlatformScrollBarWin.cpp.
       
 22853         (WebCore::PlatformScrollbar::PlatformScrollbar):
       
 22854         (WebCore::PlatformScrollbar::paint):
       
 22855         (WebCore::PlatformScrollbar::backButtonRect):
       
 22856         (WebCore::PlatformScrollbar::forwardButtonRect):
       
 22857         (WebCore::PlatformScrollbar::trackRect):
       
 22858         (WebCore::PlatformScrollbar::thumbLength):
       
 22859         (WebCore::PlatformScrollbar::paintButton):
       
 22860         (WebCore::PlatformScrollbar::paintTrack):
       
 22861         (WebCore::PlatformScrollbar::paintThumb):
       
 22862         (WebCore::PlatformScrollbar::paintGripper):
       
 22863         (WebCore::PlatformScrollbar::gripperRect):
       
 22864         (WebCore::PlatformScrollbar::themeChanged):
       
 22865         * platform/win/PlatformScrollBarWin.cpp: Added #ifndef USE_SAFARI_THEME.
       
 22866         * rendering/RenderThemeSafari.cpp: Updated for SafariTheme.h changes.
       
 22867         (WebCore::RenderThemeSafari::RenderThemeSafari):
       
 22868 
       
 22869 2007-01-23  Brady Eidson  <beidson@apple.com>
       
 22870 
       
 22871         Reviewed by Steve
       
 22872 
       
 22873         Initial hookup of Download support
       
 22874 
       
 22875         * platform/network/cf/ResourceErrorCF.cpp:
       
 22876         (WebCore::ResourceError::ResourceError):
       
 22877         (WebCore::ResourceError::operator CFStreamError):
       
 22878         
       
 22879         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 22880         (WebCore::ResourceHandle::loaderRunLoop): Accessor so downloads can run on the same 
       
 22881           runloop as connections
       
 22882         (WebCore::ResourceHandle::start):
       
 22883         (WebCore::ResourceHandle::connection):
       
 22884 
       
 22885         * platform/win/BString.cpp:
       
 22886         (WebCore::BString::BString): Ability to create BString from a CFStringRef
       
 22887         * platform/win/BString.h:
       
 22888 
       
 22889 2007-01-23  Anders Carlsson  <acarlsson@apple.com>
       
 22890 
       
 22891         Reviewed by Darin.
       
 22892 
       
 22893         <rdar://problem/4919754>
       
 22894         Boomer freezes after attempt to play video.
       
 22895         
       
 22896         * plugins/win/PluginStreamWin.cpp:
       
 22897         Change WebReasonNone to -2, some plugins return -1 to indicate error.
       
 22898         
       
 22899         (WebCore::PluginStreamWin::stop):
       
 22900         Just don't clear the loader, stop loading as well.
       
 22901         
       
 22902         (WebCore::PluginStreamWin::startStream):
       
 22903         Destroy the stream if newstream returns an error.
       
 22904         
       
 22905         * plugins/win/PluginViewWin.cpp:
       
 22906         (WebCore::PluginViewWin::performRequest):
       
 22907         If the call to toString throws an exception, clear it.
       
 22908 
       
 22909 2007-01-23  Steve Falkenburg  <sfalken@apple.com>
       
 22910 
       
 22911         Fix release build.
       
 22912 
       
 22913         * WebCore.vcproj/WebCore.vcproj:
       
 22914 
       
 22915 2007-01-23  Adele Peterson  <adele@apple.com>
       
 22916 
       
 22917         Reviewed by Adam. 
       
 22918 
       
 22919         Added call to paintThemeTextArea.
       
 22920 
       
 22921         * rendering/RenderThemeSafari.cpp:
       
 22922         (WebCore::RenderThemeSafari::paintTextArea):
       
 22923 
       
 22924 2007-01-23  Anders Carlsson  <acarlsson@apple.com>
       
 22925 
       
 22926         Build fixes.
       
 22927         
       
 22928         * WebCore.vcproj/WebCore.vcproj:
       
 22929         Copy plugin and JS headers.
       
 22930         
       
 22931         * loader/win/FrameLoaderWin.cpp:
       
 22932         Move functions to WebKitWin.
       
 22933 
       
 22934 2007-01-23  Oliver Hunt  <oliver@apple.com>
       
 22935 
       
 22936         Reviewed by Adam.
       
 22937 
       
 22938         * WebCore.vcproj/WebCore.vcproj:
       
 22939         * page/win/DragControllerWin.cpp: Added.
       
 22940         (WebCore::DragController::dragOperation):
       
 22941         (WebCore::DragController::isCopyKeyDown):
       
 22942           Platform specific implementation
       
 22943 
       
 22944         * platform/win/ClipboardWin.cpp:
       
 22945         (WebCore::ClipboardWin::ClipboardWin):
       
 22946         (WebCore::ClipboardWin::isForDragging):
       
 22947         * platform/win/ClipboardWin.h:
       
 22948           Migrated common Clipboard functionality from ClipboardMac/Win -> Clipboard
       
 22949 
       
 22950         * platform/win/DragDataWin.cpp: Added.
       
 22951         (WebCore::DragData::createClipboard):
       
 22952         (WebCore::urlWFormat):
       
 22953         (WebCore::urlFormat):
       
 22954         (WebCore::filenameWFormat):
       
 22955         (WebCore::filenameFormat):
       
 22956         (WebCore::plainTextFormat):
       
 22957         (WebCore::plainTextWFormat):
       
 22958         (WebCore::DragData::containsURL):
       
 22959         (WebCore::extractURL):
       
 22960         (WebCore::DragData::asURL):
       
 22961         (WebCore::DragData::containsPlainText):
       
 22962         (WebCore::DragData::asPlainText):
       
 22963         (WebCore::texthtmlFormat):
       
 22964         (WebCore::htmlFormat):
       
 22965         (WebCore::containsHTML):
       
 22966         (WebCore::fragmentFromHTML):
       
 22967         (WebCore::containsFilenames):
       
 22968         (WebCore::fragmentFromFilenames):
       
 22969         (WebCore::DragData::containsColor):
       
 22970         (WebCore::DragData::canSmartReplace):
       
 22971         (WebCore::DragData::containsCompatibleContent):
       
 22972         (WebCore::DragData::asFragment):
       
 22973         (WebCore::DragData::asColor):
       
 22974           Implementation of DragData accesor methods, and helper functions
       
 22975 
       
 22976         * platform/win/EditorWin.cpp:
       
 22977         (WebCore::Editor::newGeneralClipboard):
       
 22978           Updated for new ClipboardWin constructor
       
 22979 
       
 22980         * platform/win/PasteboardWin.cpp:
       
 22981         (WebCore::fragmentFromCF_HTML):
       
 22982         (WebCore::Pasteboard::documentFragment):
       
 22983           Pulled out CF_HTML parsing to a seperate function so logic 
       
 22984           can be shared with DragDataWin
       
 22985 
       
 22986 2007-01-22  Adam Roben  <aroben@apple.com>
       
 22987 
       
 22988         Reviewed by Adele.
       
 22989 
       
 22990         Implemented search field painting, and did some cleanup.
       
 22991 
       
 22992         * rendering/RenderThemeSafari.cpp:
       
 22993         (WebCore::RenderThemeSafari::RenderThemeSafari): Updated for changes to SafariTheme.
       
 22994         (WebCore::RenderThemeSafari::paintButton): Ditto.
       
 22995         (WebCore::RenderThemeSafari::paintTextField): Ditto.
       
 22996         (WebCore::controlSizeFromRect): New helper function.
       
 22997         (WebCore::RenderThemeSafari::paintSearchField): Implemented.
       
 22998         (WebCore::RenderThemeSafari::paintSearchFieldCancelButton): Ditto.
       
 22999         (WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration): Ditto.
       
 23000         (WebCore::RenderThemeSafari::paintSearchFieldResultsButton): Ditto.
       
 23001         (WebCore::RenderThemeSafari::setSearchFieldSize): Uncommented setSizeFromFont call.
       
 23002         (WebCore::RenderThemeSafari::adjustSearchFieldCancelButtonStyle): Ditto.
       
 23003         (WebCore::RenderThemeSafari::adjustSearchFieldDecorationStyle): Ditto.
       
 23004         (WebCore::RenderThemeSafari::adjustSearchFieldResultsDecorationStyle): Ditto.
       
 23005         (WebCore::RenderThemeSafari::adjustSearchFieldResultsButtonStyle): Ditto.
       
 23006 
       
 23007 2007-01-22  Anders Carlsson  <acarlsson@apple.com>
       
 23008 
       
 23009         Reviewed by Adam.
       
 23010         
       
 23011         <rdar://problem/4771115>
       
 23012         Windows Media Player plugin crashes.
       
 23013 
       
 23014         * WebCore.vcproj/WebCore.vcproj:
       
 23015         Formatting changes.
       
 23016         
       
 23017         * plugins/win/PluginDatabaseWin.cpp:
       
 23018         (WebCore::PluginDatabaseWin::defaultPluginPaths):
       
 23019         Add Windows Media Player path.
       
 23020         
       
 23021         * plugins/win/PluginStreamWin.cpp:
       
 23022         (WebCore::PluginStreamWin::sendJavaScriptStream):
       
 23023         * plugins/win/PluginStreamWin.h:
       
 23024         New function which sends a JavaScript result stream and handles any errors that the
       
 23025         plug-in returns.
       
 23026         
       
 23027         * plugins/win/PluginViewWin.cpp:
       
 23028         (WebCore::PluginViewWin::setFrameGeometry):
       
 23029         Always call NPP_SetWindow, some plugins (like WMP) relies on it.
       
 23030         
       
 23031         (WebCore::PluginViewWin::performRequest):
       
 23032         If a plug-in requests a javascript: URL that doesn't evaluate to a string, call toString on it.
       
 23033         The Windows Media Player plugin calls javascript:document.location and expects to get the location back.
       
 23034 
       
 23035 2007-01-23  Darin Adler  <darin@apple.com>
       
 23036 
       
 23037         - internal part of fix for http://bugs.webkit.org/show_bug.cgi?id=12273
       
 23038           REGRESSION: File input value invisible after removing and re-appending
       
 23039 
       
 23040         * WebCore.vcproj/WebCore.vcproj: Added FileChooser.cpp.
       
 23041 
       
 23042         * platform/win/FileChooserWin.cpp: Removed many now-unneeded functions.
       
 23043         (WebCore::FileChooser::FileChooser): Updated for changed parameters and members.
       
 23044         (WebCore::FileChooser::openFileChooser): Changed to take document parmaeter and
       
 23045         find the FrameView from that instead of the upload control.
       
 23046         (WebCore::FileChooser::basenameForWidth): Added ignored Font parameter.
       
 23047 
       
 23048 2007-01-22  Anders Carlsson  <acarlsson@apple.com>
       
 23049 
       
 23050         Reviewed by Adam.
       
 23051 
       
 23052         <rdar://problem/4903230>
       
 23053         Boomer crashes at Flickr website when "View as slideshow" is clicked.
       
 23054         
       
 23055         * plugins/win/PluginViewWin.cpp:
       
 23056         (WebCore::PluginViewWin::bindingInstance):
       
 23057         Return null if m_plugin is null (which it can be if the plugin failed to load).
       
 23058 
       
 23059 2007-01-22  Anders Carlsson  <acarlsson@apple.com>
       
 23060 
       
 23061         Build fix.
       
 23062         
       
 23063         * WebCore.vcproj/WebCore.vcproj:
       
 23064 
       
 23065 2007-01-22  Adam Roben  <aroben@apple.com>
       
 23066 
       
 23067         Moved ifdefs to match Darin's suggestion.
       
 23068 
       
 23069         * rendering/RenderThemeSafari.cpp:
       
 23070         * rendering/RenderThemeSafari.h:
       
 23071 
       
 23072 2007-01-22  Adam Roben  <aroben@apple.com>
       
 23073 
       
 23074         Build fix.
       
 23075 
       
 23076         * rendering/RenderThemeSafari.cpp:
       
 23077         (WebCore::theme):
       
 23078         * rendering/RenderThemeSafari.h:
       
 23079 
       
 23080 2007-01-21  Adam Roben  <aroben@apple.com>
       
 23081 
       
 23082         Reviewed by Maciej.
       
 23083 
       
 23084         Implemented drawing button states and control sizes.
       
 23085 
       
 23086         * WebCore.vcproj/WebCore.vcproj:
       
 23087         * rendering/RenderThemeSafari.cpp:
       
 23088         (WebCore::RenderThemeSafari::determineState): Added.
       
 23089         (WebCore::RenderThemeSafari::systemFont): Implemented rest of font sizes.
       
 23090         (WebCore::RenderThemeSafari::paintButton): Updated for SafariTheme changes.
       
 23091         (WebCore::RenderThemeSafari::paintTextField): Ditto.
       
 23092         * rendering/RenderThemeSafari.h: Added declaration.
       
 23093 
       
 23094 2007-01-21  Adam Roben  <aroben@apple.com>
       
 23095 
       
 23096         Reviewed by Maciej.
       
 23097 
       
 23098         * rendering/RenderThemeSafari.cpp: Updated declarations of SafariTheme calls.
       
 23099         (WebCore::systemFontSizeForControlSize): Added.
       
 23100         (WebCore::RenderThemeSafari::systemFont): Made it work in the small-control case.
       
 23101         (WebCore::RenderThemeSafari::adjustRepaintRect): Made it work for buttons and checkboxes.
       
 23102         (WebCore::RenderThemeSafari::setFontFromControlSize): Fixed to work on Windows.
       
 23103         (WebCore::RenderThemeSafari::checkboxMargins): Added controlSize parameter.
       
 23104         (WebCore::RenderThemeSafari::buttonMargins): Ditto.
       
 23105         (WebCore::RenderThemeSafari::paintButton): Fixed FIXME, added save/restore calls.
       
 23106         (WebCore::RenderThemeSafari::paintTextField): Added save/restore calls.
       
 23107         * rendering/RenderThemeSafari.h: Updated declarations.
       
 23108 
       
 23109 2007-01-21  Adele Peterson  <adele@apple.com>
       
 23110 
       
 23111         Reviewed by Adam. 
       
 23112 
       
 23113         Adding RenderThemeSafari.
       
 23114  
       
 23115         * WebCore.vcproj/WebCore.vcproj:
       
 23116         * rendering/RenderThemeSafari.cpp: Added.
       
 23117         (WebCore::):
       
 23118         (WebCore::theme):
       
 23119         (WebCore::RenderThemeSafari::RenderThemeSafari):
       
 23120         (WebCore::RenderThemeSafari::~RenderThemeSafari):
       
 23121         (WebCore::RenderThemeSafari::platformActiveSelectionBackgroundColor):
       
 23122         (WebCore::RenderThemeSafari::platformInactiveSelectionBackgroundColor):
       
 23123         (WebCore::RenderThemeSafari::activeListBoxSelectionBackgroundColor):
       
 23124         (WebCore::RenderThemeSafari::systemFont):
       
 23125         (WebCore::RenderThemeSafari::isControlStyled):
       
 23126         (WebCore::RenderThemeSafari::adjustRepaintRect):
       
 23127         (WebCore::RenderThemeSafari::inflateRect):
       
 23128         (WebCore::RenderThemeSafari::baselinePosition):
       
 23129         (WebCore::RenderThemeSafari::controlSupportsTints):
       
 23130         (WebCore::RenderThemeSafari::controlSizeForFont):
       
 23131         (WebCore::RenderThemeSafari::sizeForFont):
       
 23132         (WebCore::RenderThemeSafari::sizeForSystemFont):
       
 23133         (WebCore::RenderThemeSafari::setSizeFromFont):
       
 23134         (WebCore::RenderThemeSafari::setFontFromControlSize):
       
 23135         (WebCore::RenderThemeSafari::controlSizeForSystemFont):
       
 23136         (WebCore::RenderThemeSafari::paintCheckbox):
       
 23137         (WebCore::RenderThemeSafari::checkboxSizes):
       
 23138         (WebCore::RenderThemeSafari::checkboxMargins):
       
 23139         (WebCore::RenderThemeSafari::setCheckboxSize):
       
 23140         (WebCore::RenderThemeSafari::paintRadio):
       
 23141         (WebCore::RenderThemeSafari::radioSizes):
       
 23142         (WebCore::RenderThemeSafari::radioMargins):
       
 23143         (WebCore::RenderThemeSafari::setRadioSize):
       
 23144         (WebCore::RenderThemeSafari::setButtonPaddingFromControlSize):
       
 23145         (WebCore::RenderThemeSafari::adjustButtonStyle):
       
 23146         (WebCore::RenderThemeSafari::buttonSizes):
       
 23147         (WebCore::RenderThemeSafari::buttonMargins):
       
 23148         (WebCore::RenderThemeSafari::setButtonSize):
       
 23149         (WebCore::RenderThemeSafari::paintButton):
       
 23150         (WebCore::RenderThemeSafari::paintTextField):
       
 23151         (WebCore::RenderThemeSafari::adjustTextFieldStyle):
       
 23152         (WebCore::RenderThemeSafari::paintTextArea):
       
 23153         (WebCore::RenderThemeSafari::adjustTextAreaStyle):
       
 23154         (WebCore::RenderThemeSafari::popupButtonMargins):
       
 23155         (WebCore::RenderThemeSafari::popupButtonSizes):
       
 23156         (WebCore::RenderThemeSafari::popupButtonPadding):
       
 23157         (WebCore::RenderThemeSafari::setPopupPaddingFromControlSize):
       
 23158         (WebCore::RenderThemeSafari::paintMenuList):
       
 23159         (WebCore::TopGradientInterpolate):
       
 23160         (WebCore::BottomGradientInterpolate):
       
 23161         (WebCore::MainGradientInterpolate):
       
 23162         (WebCore::TrackGradientInterpolate):
       
 23163         (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
       
 23164         (WebCore::RenderThemeSafari::paintMenuListButton):
       
 23165         (WebCore::RenderThemeSafari::adjustMenuListStyle):
       
 23166         (WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
       
 23167         (WebCore::RenderThemeSafari::menuListSizes):
       
 23168         (WebCore::RenderThemeSafari::minimumMenuListSize):
       
 23169         (WebCore::RenderThemeSafari::paintSliderTrack):
       
 23170         (WebCore::RenderThemeSafari::paintSliderThumb):
       
 23171         (WebCore::RenderThemeSafari::adjustSliderThumbSize):
       
 23172         (WebCore::RenderThemeSafari::paintSearchField):
       
 23173         (WebCore::RenderThemeSafari::searchFieldSizes):
       
 23174         (WebCore::RenderThemeSafari::setSearchFieldSize):
       
 23175         (WebCore::RenderThemeSafari::adjustSearchFieldStyle):
       
 23176         (WebCore::RenderThemeSafari::paintSearchFieldCancelButton):
       
 23177         (WebCore::RenderThemeSafari::cancelButtonSizes):
       
 23178         (WebCore::RenderThemeSafari::adjustSearchFieldCancelButtonStyle):
       
 23179         (WebCore::RenderThemeSafari::resultsButtonSizes):
       
 23180         (WebCore::RenderThemeSafari::adjustSearchFieldDecorationStyle):
       
 23181         (WebCore::RenderThemeSafari::paintSearchFieldDecoration):
       
 23182         (WebCore::RenderThemeSafari::adjustSearchFieldResultsDecorationStyle):
       
 23183         (WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration):
       
 23184         (WebCore::RenderThemeSafari::adjustSearchFieldResultsButtonStyle):
       
 23185         (WebCore::RenderThemeSafari::paintSearchFieldResultsButton):
       
 23186         * rendering/RenderThemeSafari.h: Added.
       
 23187         (WebCore::RenderThemeSafari::supportsControlTints):
       
 23188         * rendering/RenderThemeWin.cpp:
       
 23189 
       
 23190 2007-01-21  Adam Roben  <aroben@apple.com>
       
 23191 
       
 23192         Build fix.
       
 23193 
       
 23194         * WebCore.vcproj/WebCore.vcproj: Added JSDocumentCustom.cpp.
       
 23195 
       
 23196 2007-01-19  Ada Chan  <adachan@apple.com>
       
 23197 
       
 23198         Build fix.
       
 23199 
       
 23200         * WebCore.vcproj/WebCore.vcproj:
       
 23201 
       
 23202 2007-01-19  Anders Carlsson  <acarlsson@apple.com>
       
 23203 
       
 23204         Build fix.
       
 23205 
       
 23206         * WebCore.vcproj/WebCore.vcproj:
       
 23207         Add SVG files.
       
 23208 
       
 23209 2007-01-19  Anders Carlsson  <acarlsson@apple.com>
       
 23210 
       
 23211         Build fix.
       
 23212         
       
 23213         * platform/win/ContextMenuItemWin.cpp:
       
 23214         (WebCore::ContextMenuItem::enabled):
       
 23215         Use correct class name.
       
 23216 
       
 23217 2007-01-18  Anders Carlsson  <acarlsson@apple.com>
       
 23218 
       
 23219         Reviewed by Adam.
       
 23220 
       
 23221         Remove some unused FrameWin functions.
       
 23222         
       
 23223         * bridge/win/FrameWin.cpp:
       
 23224         (WebCore::FrameWin::~FrameWin):
       
 23225         * bridge/win/FrameWin.h:
       
 23226         * plugins/win/PluginViewWin.cpp:
       
 23227         (WebCore::PluginViewWin::status):
       
 23228 
       
 23229 2007-01-18  Adam Roben  <aroben@apple.com>
       
 23230 
       
 23231         Build fix.
       
 23232 
       
 23233         * platform/win/ContextMenuItemWin.cpp:
       
 23234         (WebCore::ContextMenu::enabled): Implemented.
       
 23235 
       
 23236 2007-01-18  Anders Carlsson  <acarlsson@apple.com>
       
 23237 
       
 23238         Build fix.
       
 23239         
       
 23240         * WebCore.vcproj/WebCore.vcproj:
       
 23241         * platform/win/GlyphMapWin.cpp: Removed.
       
 23242         * platform/win/GlyphPageTreeNodeWin.cpp: Added.
       
 23243         (WebCore::GlyphPage::fill):
       
 23244 
       
 23245 2007-01-18  Anders Carlsson  <acarlsson@apple.com>
       
 23246 
       
 23247         Reviewed by Brady.
       
 23248 
       
 23249         Fix ownership handling of CFRequestRef. A ResourceRequest holds on to its CFRequestRef 
       
 23250         and doesn't ref it when returning it. Also, implement willCacheResponse.
       
 23251         
       
 23252         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 23253         (WebCore::willSendRequest):
       
 23254         (WebCore::willCacheResponse):
       
 23255         (WebCore::ResourceHandle::start):
       
 23256         * platform/network/cf/ResourceRequestCFNet.cpp:
       
 23257         (WebCore::ResourceRequest::doUpdatePlatformRequest):
       
 23258 
       
 23259 2007-01-17  Brady Eidson  <beidson@apple.com>
       
 23260 
       
 23261         Reviewed by Maciej
       
 23262 
       
 23263         Final hookup of HTTP Auth plumbing - have the ResourceHandle actually call into
       
 23264         CFNetwork for HTTP Auth.
       
 23265         
       
 23266         Also, deal with svn:eol-style issues on another batch of files that didn't have it set
       
 23267 
       
 23268         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 23269         (WebCore::ResourceHandle::receivedCredential):  Call into CFNetwork
       
 23270         (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):  Ditto
       
 23271         (WebCore::ResourceHandle::receivedCancellation):  Copy Mac behavior by calling cancel on the handle
       
 23272 
       
 23273 2007-01-16  Brady Eidson  <beidson@apple.com>
       
 23274 
       
 23275         Reviewed by Anders
       
 23276 
       
 23277         Futher improvements/bug fixes to BString
       
 23278 
       
 23279         * platform/win/BString.cpp:
       
 23280         (WebCore::BString::BString):
       
 23281         (WebCore::BString::operator=):
       
 23282         * platform/win/BString.h:
       
 23283 
       
 23284 2007-01-16  Brady Eidson  <beidson@apple.com>
       
 23285 
       
 23286         Reviewed by Ada, Adam, and Anders oh my!
       
 23287 
       
 23288         Add handle ==/!= operators to BString
       
 23289 
       
 23290         * platform/win/BString.cpp:
       
 23291         (WebCore::operator ==):
       
 23292         (WebCore::operator !=):
       
 23293         * platform/win/BString.h:
       
 23294 
       
 23295 2007-01-16  Beth Dakin  <bdakin@apple.com>
       
 23296 
       
 23297         Reviewed by Adam.
       
 23298 
       
 23299         Fix for <rdar://problem/4874565> Draw context menus using CG
       
 23300 
       
 23301         * platform/win/ContextMenuItemWin.cpp:
       
 23302         (WebCore::ContextMenuItem::type): Re-worked to be more forgiving.
       
 23303         * platform/win/ContextMenuWin.cpp: No need for show() and hide()
       
 23304         since WebKit takes care of this now.
       
 23305 
       
 23306 2007-01-15  Brady Eidson  <beidson@apple.com>
       
 23307 
       
 23308         Reviewed by Adam
       
 23309 
       
 23310         Hook up AuthenticationChallenge to CF network.  
       
 23311         Call up through appropriate client methods through to WebFrame (FrameLoaderClient) at
       
 23312         which point my upcoming implementation for the IWebURL<auth> classes will be used
       
 23313 
       
 23314         * WebCore.vcproj/WebCore.vcproj:
       
 23315         * platform/network/cf/AuthenticationCF.cpp: Added.
       
 23316         (WebCore::AuthenticationChallenge::AuthenticationChallenge):
       
 23317         (WebCore::createCF):
       
 23318         (WebCore::core):
       
 23319         * platform/network/cf/AuthenticationCF.h: Added.
       
 23320         * platform/network/cf/ResourceErrorCF.cpp: Added.
       
 23321         (WebCore::ResourceError::ResourceError):
       
 23322         (WebCore::ResourceError::operator CFStreamError):
       
 23323         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 23324         (WebCore::didReceiveChallenge):
       
 23325         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
       
 23326         (WebCore::ResourceHandle::receivedCredential):
       
 23327         (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
       
 23328         (WebCore::ResourceHandle::receivedCancellation):
       
 23329 
       
 23330 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
       
 23331 
       
 23332         Build fix.
       
 23333         
       
 23334         * WebCore.vcproj/WebCore.vcproj:
       
 23335         Add ProgressTracker.[cpp|h]
       
 23336 
       
 23337 2007-01-12  Anders Carlsson  <acarlsson@apple.com>
       
 23338 
       
 23339         Reviewed by Darin.
       
 23340 
       
 23341         * loader/win/FrameLoaderWin.cpp:
       
 23342         (WebCore::FrameLoader::didChangeTitle):
       
 23343         Copied here from FrameLoaderMac.mm
       
 23344         
       
 23345         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 23346         (WebCore::ResourceHandle::start):
       
 23347         Removed setting referrer and user-agend and added a check for null page.
       
 23348         
       
 23349         (WebCore::ResourceHandle::cancel):
       
 23350         Don't call didFail.
       
 23351         
       
 23352         * platform/win/TemporaryLinkStubs.cpp:
       
 23353         (FrameWin::getAppletInstanceForWidget):
       
 23354         Use LOG_NOIMPL here.
       
 23355 
       
 23356 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
       
 23357 
       
 23358         * platform/network/cf/ResourceResponseCFNet.cpp:
       
 23359         (WebCore::ResourceResponse::cfURLResponse):
       
 23360         Add getter that I forgot to commit.
       
 23361         
       
 23362 2007-01-11  Brady Eidson  <beidson@apple.com>
       
 23363 
       
 23364         Reviewed by NOBODY.
       
 23365 
       
 23366         Make it build after my HTTP Auth OpenSource checkin
       
 23367 
       
 23368         * WebCore.vcproj/WebCore.vcproj:
       
 23369 
       
 23370 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
       
 23371 
       
 23372         Build fix.
       
 23373 
       
 23374         * WebCore.vcproj/WebCore.vcproj:
       
 23375         * platform/win/TemporaryLinkStubs.cpp:
       
 23376         (WebCore::Editor::advanceToNextMisspelling):
       
 23377 
       
 23378 2007-01-10  Steve Falkenburg  <sfalken@apple.com>
       
 23379 
       
 23380         Reviewed by Lou.
       
 23381 
       
 23382         <rdar://problem/4818840> Crash occurs after selecting Print Preview from under the File menu if no printer is selected
       
 23383         
       
 23384         * bridge/win/FrameWin.cpp:
       
 23385         (WebCore::FrameWin::computePageRects): removed calls to setupRootForPrinting
       
 23386         * bridge/win/FrameWin.h: removed setupRootForPrinting
       
 23387 
       
 23388 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
       
 23389 
       
 23390         Yet another build fix.
       
 23391         
       
 23392         * platform/win/TemporaryLinkStubs.cpp:
       
 23393         (DocumentLoader::getResponseModifiedHeader):
       
 23394 
       
 23395 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
       
 23396 
       
 23397         Another build fix.
       
 23398         
       
 23399         * bridge/win/FrameWin.h:
       
 23400         * loader/win/FrameLoaderWin.cpp:
       
 23401 
       
 23402 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
       
 23403 
       
 23404         Build fix.
       
 23405         
       
 23406         * platform/win/TemporaryLinkStubs.cpp:
       
 23407         (ResourceHandle::setDefersLoading):
       
 23408 
       
 23409 2007-01-09  Steve Falkenburg  <sfalken@apple.com>
       
 23410 
       
 23411         Production build fix
       
 23412 
       
 23413         * WebCore.vcproj/WebCore.vcproj:
       
 23414 
       
 23415 2007-01-09  Anders Carlsson  <acarlsson@apple.com>
       
 23416 
       
 23417         Build fix.
       
 23418         
       
 23419         * platform/win/TextBoundariesWin.cpp:
       
 23420 
       
 23421 2007-01-08  Anders Carlsson  <acarlsson@apple.com>
       
 23422 
       
 23423         Remove FrameLoader functions that have been implemented.
       
 23424         
       
 23425         * platform/win/TemporaryLinkStubs.cpp:
       
 23426 
       
 23427 2007-01-08  Anders Carlsson  <acarlsson@apple.com>
       
 23428 
       
 23429         Build fix.
       
 23430         
       
 23431         * WebCore.vcproj/WebCore.vcproj:
       
 23432 
       
 23433 2007-01-05  Anders Carlsson  <acarlsson@apple.com>
       
 23434 
       
 23435         Reviewed by Adam.
       
 23436 
       
 23437         Update temporary link stubs.
       
 23438         
       
 23439         * platform/win/TemporaryLinkStubs.cpp:
       
 23440         (FrameLoader::referrer):
       
 23441         (FrameLoader::overrideMediaType):
       
 23442         (FrameLoader::checkLoadCompleteForThisFrame):
       
 23443         (DocumentLoader::getResponseRefreshAndModifiedHeaders):
       
 23444         (MainResourceLoader::create):
       
 23445         (ResourceLoader::cancel):
       
 23446         (ResourceLoader::load):
       
 23447         (ResourceLoader::releaseResources):
       
 23448         (ResourceLoader::addData):
       
 23449 
       
 23450 2007-01-05  Anders Carlsson  <acarlsson@apple.com>
       
 23451 
       
 23452         Fix build.
       
 23453         
       
 23454         * platform/win/TemporaryLinkStubs.cpp:
       
 23455         (ResourceLoader::cancel):
       
 23456         (FrameLoader::didChangeTitle):
       
 23457         (DocumentLoader::unreachableURL):
       
 23458 
       
 23459 2007-01-05  Anders Carlsson  <acarlsson@apple.com>
       
 23460 
       
 23461         Fix the build.
       
 23462         
       
 23463         * WebCore.vcproj/WebCore.vcproj:
       
 23464         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 23465         (WebCore::ResourceHandle::bufferedData):
       
 23466         (WebCore::ResourceHandle::supportsBufferedData):
       
 23467         * platform/win/TemporaryLinkStubs.cpp:
       
 23468         (WebCore::CheckCacheObjectStatus):
       
 23469 
       
 23470 2007-01-04  David Hyatt  <hyatt@apple.com>
       
 23471 
       
 23472         Always use 1.0 as the synthetic bold offset for now.  Fixes bug 9534.
       
 23473 
       
 23474         Reviewed by olliej
       
 23475 
       
 23476         * platform/win/FontDataWin.cpp:
       
 23477         (WebCore::FontData::platformInit):
       
 23478 
       
 23479 2007-01-03  Darin Adler  <darin@apple.com>
       
 23480 
       
 23481         Reviewed by Adele.
       
 23482 
       
 23483         - removed some obsolete source files
       
 23484 
       
 23485         * WebCore.vcproj/WebCore.vcproj: Removed obsolete files.
       
 23486 
       
 23487 2007-01-03  Beth Dakin  <bdakin@apple.com>
       
 23488 
       
 23489         Reviewed by John.
       
 23490 
       
 23491         Add stubs for all of the localized context menu item titles. The 
       
 23492         stubs just return English Strings until we have a localization 
       
 23493         solution in WebKit.
       
 23494 
       
 23495         * platform/win/TemporaryLinkStubs.cpp:
       
 23496         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
       
 23497         (WebCore::contextMenuItemTagDownloadLinkToDisk):
       
 23498         (WebCore::contextMenuItemTagCopyLinkToClipboard):
       
 23499         (WebCore::contextMenuItemTagOpenImageInNewWindow):
       
 23500         (WebCore::contextMenuItemTagDownloadImageToDisk):
       
 23501         (WebCore::contextMenuItemTagCopyImageToClipboard):
       
 23502         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
       
 23503         (WebCore::contextMenuItemTagCopy):
       
 23504         (WebCore::contextMenuItemTagGoBack):
       
 23505         (WebCore::contextMenuItemTagGoForward):
       
 23506         (WebCore::contextMenuItemTagStop):
       
 23507         (WebCore::contextMenuItemTagReload):
       
 23508         (WebCore::contextMenuItemTagCut):
       
 23509         (WebCore::contextMenuItemTagPaste):
       
 23510         (WebCore::contextMenuItemTagNoGuessesFound):
       
 23511         (WebCore::contextMenuItemTagIgnoreSpelling):
       
 23512         (WebCore::contextMenuItemTagLearnSpelling):
       
 23513         (WebCore::contextMenuItemTagSearchWeb):
       
 23514         (WebCore::contextMenuItemTagLookUpInDictionary):
       
 23515         (WebCore::contextMenuItemTagOpenLink):
       
 23516         (WebCore::contextMenuItemTagIgnoreGrammar):
       
 23517         (WebCore::contextMenuItemTagSpellingMenu):
       
 23518         (WebCore::contextMenuItemTagShowSpellingPanel):
       
 23519         (WebCore::contextMenuItemTagCheckSpelling):
       
 23520         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
       
 23521         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
       
 23522         (WebCore::contextMenuItemTagFontMenu):
       
 23523         (WebCore::contextMenuItemTagBold):
       
 23524         (WebCore::contextMenuItemTagItalic):
       
 23525         (WebCore::contextMenuItemTagUnderline):
       
 23526         (WebCore::contextMenuItemTagOutline):
       
 23527         (WebCore::contextMenuItemTagWritingDirectionMenu):
       
 23528         (WebCore::contextMenuItemTagDefaultDirection):
       
 23529         (WebCore::contextMenuItemTagLeftToRight):
       
 23530         (WebCore::contextMenuItemTagRightToLeft):
       
 23531 
       
 23532 2007-01-03  Anders Carlsson  <acarlsson@apple.com>
       
 23533 
       
 23534         Reviewed by Geoff.
       
 23535 
       
 23536         <rdar://problem/4857027>
       
 23537         ragnarok online misrenders (due to lack of support for windowless plugins)
       
 23538 
       
 23539         * plugins/win/PluginViewWin.cpp:
       
 23540         (WebCore::PluginViewWin::updateWindow):
       
 23541         Rename from updateHwnd since this now handles updating the clip rect for windowless plugins.
       
 23542         
       
 23543         (WebCore::PluginViewWin::paintMissingPluginIcon):
       
 23544         New function which paints the missing plugin icon.
       
 23545         
       
 23546         (WebCore::PluginViewWin::paint):
       
 23547         Do windowless painting here.
       
 23548         
       
 23549         (WebCore::PluginViewWin::handleKeyboardEvent):
       
 23550         (WebCore::PluginViewWin::handleMouseEvent):
       
 23551         (WebCore::PluginViewWin::handleEvent):
       
 23552         New functions for handling mouse and keyboard events, translating them and handing them to the plugin.
       
 23553         
       
 23554         (WebCore::PluginViewWin::setNPWindowRect):
       
 23555         Set correct window rect for windowless plugins.
       
 23556         
       
 23557         (WebCore::PluginViewWin::getValue):
       
 23558         Add variable for containing HWND.
       
 23559         
       
 23560         (WebCore::PluginViewWin::setValue):
       
 23561         Add windowless and transparent variables.
       
 23562         
       
 23563         (WebCore::PluginViewWin::invalidateRect):
       
 23564         (WebCore::PluginViewWin::invalidateRegion):
       
 23565         (WebCore::PluginViewWin::forceRedraw):
       
 23566         Implement these.
       
 23567         
       
 23568         (WebCore::PluginViewWin::determineQuirks):
       
 23569         Set quirks now that we support windowless flash.
       
 23570         
       
 23571         (WebCore::PluginViewWin::PluginViewWin):
       
 23572         Only create the window if the plugin isn't windowless.
       
 23573         
       
 23574         * plugins/win/PluginViewWin.h:
       
 23575         New declarations.
       
 23576         
       
 23577         * plugins/win/npapi.cpp:
       
 23578         (NPN_InvalidateRect):
       
 23579         (NPN_InvalidateRegion):
       
 23580         (NPN_ForceRedraw):
       
 23581         Implement these and forward them to the plugin view.
       
 23582 
       
 23583 2007-01-02  Brady Eidson  <beidson@apple.com>
       
 23584 
       
 23585         Reviewed by Lou
       
 23586 
       
 23587         Temporary Link Stub fix for Back/Forward cache landing in OpenSource
       
 23588 
       
 23589         * WebCore.vcproj/WebCore.vcproj:
       
 23590         * platform/win/TemporaryLinkStubs.cpp:
       
 23591         (DocumentLoader::request):
       
 23592         (DocumentLoader::originalRequest):
       
 23593         (DocumentLoader::title):
       
 23594         (DocumentLoader::unreachableURL):
       
 23595         (DocumentLoader::urlForHistory):
       
 23596         (DocumentLoader::setCommitted):
       
 23597         (DocumentLoader::prepareForLoadStart):
       
 23598         (DocumentLoader::replaceRequestURLForAnchorScroll):
       
 23599         (DocumentLoader::isClientRedirect):
       
 23600         (DocumentLoader::isLoading):
       
 23601         (DocumentLoader::getResponseRefreshAndModifiedHeaders):
       
 23602         (FrameLoader::applyUserAgent):
       
 23603         (FrameLoader::dataURLBaseFromRequest):
       
 23604         (FrameLoader::load):
       
 23605         (FrameLoader::opened):
       
 23606         (ResourceHandle::willLoadFromCache):
       
 23607         (WebCore::userIdleTime):
       
 23608         (PageCache::close):
       
 23609 
       
 23610 2007-01-02  Anders Carlsson  <acarlsson@apple.com>
       
 23611 
       
 23612         Build fix.
       
 23613         
       
 23614         * WebCore.vcproj/WebCore.vcproj:
       
 23615 
       
 23616 2006-12-29  Geoffrey Garen  <ggaren@apple.com>
       
 23617         
       
 23618         Build fix.
       
 23619 
       
 23620         * bridge/win/FrameWin.cpp:
       
 23621         (WebCore::FrameWin::bindingRootObject):
       
 23622         * plugins/win/PluginViewWin.cpp:
       
 23623         (WebCore::PluginViewWin::bindingInstance):
       
 23624 
       
 23625 2006-12-27  Oliver Hunt <oliver@apple.com>
       
 23626 
       
 23627         Build fix
       
 23628 
       
 23629         * WebCore.vcproj/WebCore.vcproj:
       
 23630         * platform/graphics/win/ImageWin.cpp:
       
 23631         (WebCore::BitmapImage::initPlatformData):
       
 23632         (WebCore::BitmapImage::invalidatePlatformData):
       
 23633         (WebCore::Image::loadPlatformResource):
       
 23634         (WebCore::BitmapImage::getHBITMAP):
       
 23635 
       
 23636 2006-12-25  Geoffrey Garen  <ggaren@apple.com>
       
 23637 
       
 23638         Fixed build. Tsk, tsk, Oliver.
       
 23639 
       
 23640         * WebCore.vcproj/WebCore.vcproj:
       
 23641 
       
 23642 2006-12-25  Geoffrey Garen  <ggaren@apple.com>
       
 23643 
       
 23644         Reviewed by Oliver Hunt.
       
 23645 
       
 23646         Removed WebCoreSettings, cleaned up WebCore::Settings.
       
 23647 
       
 23648         * WebCore.vcproj/WebCore.vcproj: Added Settings.cpp to the project.
       
 23649 
       
 23650         * bridge/win/FrameWin.cpp: Updated to use new preferences names.
       
 23651         (WebCore::FrameWin::bindingRootObject):
       
 23652         (WebCore::FrameWin::windowScriptNPObject):
       
 23653 
       
 23654         * loader/win/FrameLoaderWin.cpp: ditto.
       
 23655         (WebCore::FrameLoader::partClearedInBegin):
       
 23656 
       
 23657         * plugins/win/PluginViewWin.cpp: ditto.
       
 23658         (WebCore::PluginViewWin::load):
       
 23659 
       
 23660 2006-12-22  Ada Chan  <adachan@apple.com>
       
 23661 
       
 23662         Reviewed by Anders.
       
 23663 
       
 23664         Build fix.
       
 23665 
       
 23666         * WebCore.vcproj/WebCore.vcproj:
       
 23667 
       
 23668 2006-12-22  Anders Carlsson  <acarlsson@apple.com>
       
 23669 
       
 23670         Build fix.
       
 23671         
       
 23672         * WebCore.vcproj/WebCore.vcproj:
       
 23673 
       
 23674 2006-12-22  John Sullivan  <sullivan@apple.com>
       
 23675 
       
 23676         Reviewed by Kevin Decker
       
 23677 
       
 23678         Renamed stub method name to match change in WebCore
       
 23679 
       
 23680         * platform/win/TemporaryLinkStubs.cpp:
       
 23681         (WebCore::Editor::markMisspellingsAfterTypingToPosition):
       
 23682         renamed from markMisspellingsInAdjacentWords
       
 23683 
       
 23684 2006-12-20  Adam Roben  <aroben@apple.com>
       
 23685 
       
 23686         Reviewed by Hyatt.
       
 23687 
       
 23688         Fix: <rdar://4769797> REGRESSION: No focus rings
       
 23689 
       
 23690         * platform/win/GraphicsContextWin.cpp:
       
 23691         (WebCore::GraphicsContext::drawFocusRing):
       
 23692         * platform/win/TemporaryLinkStubs.cpp:
       
 23693         (WebCore::focusRingColor): Changed to match the Aqua focus ring color.
       
 23694 
       
 23695 2006-12-20  David Hyatt  <hyatt@apple.com>
       
 23696 
       
 23697         Remove line width setting in font rendering now that GraphicsContext sets
       
 23698         it for us.
       
 23699 
       
 23700         * platform/win/FontWin.cpp:
       
 23701         (WebCore::Font::drawGlyphs):
       
 23702 
       
 23703 2006-12-20  David Hyatt  <hyatt@apple.com>
       
 23704 
       
 23705         Add support for stroking and filling of text to CSS.  Boomer side.  Same code as in FontMac.
       
 23706 
       
 23707         * platform/win/FontWin.cpp:
       
 23708         (WebCore::Font::drawGlyphs):
       
 23709 
       
 23710 2006-12-19  Steve Falkenburg  <sfalken@apple.com>
       
 23711 
       
 23712         Remove non-existent header from vcproj
       
 23713 
       
 23714         * WebCore.vcproj/WebCore.vcproj:
       
 23715 
       
 23716 2006-12-19  Brady Eidson  <beidson@apple.com>
       
 23717 
       
 23718         Reviewed by Ada
       
 23719 
       
 23720         -Changed CFNetwork debugging output to use a logging channel
       
 23721         -Added the url to each logging message - the debugging output was quite crippled without this
       
 23722         
       
 23723         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 23724         (WebCore::willSendRequest):
       
 23725         (WebCore::didReceiveResponse):
       
 23726         (WebCore::didReceiveData):
       
 23727         (WebCore::didFinishLoading):
       
 23728         (WebCore::didFail):
       
 23729         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
       
 23730         (WebCore::ResourceHandle::~ResourceHandle):
       
 23731         (WebCore::ResourceHandle::start):
       
 23732 
       
 23733 2006-12-19  Anders Carlsson  <acarlsson@apple.com>
       
 23734 
       
 23735         Reviewed by Geoff.
       
 23736 
       
 23737         <rdar://problem/4876963>
       
 23738         Crash launching Boomer after all options deselected in pref->security
       
 23739         
       
 23740         * loader/win/FrameLoaderWin.cpp:
       
 23741         (WebCore::FrameLoader::partClearedInBegin):
       
 23742         Add check for JavaScript.
       
 23743 
       
 23744 2006-12-19  Anders Carlsson  <acarlsson@apple.com>
       
 23745 
       
 23746         Reviewed by Kevin Decker.
       
 23747 
       
 23748         Add (currently disabled) plugin quirks. This is necessary in order to get the Flash plugin
       
 23749         to request windowless plugins (which it only will do if it think it's running on a Mozilla browser).
       
 23750         
       
 23751         * plugins/win/PluginViewWin.cpp:
       
 23752         (WebCore::PluginViewWin::userAgent):
       
 23753         (WebCore::PluginViewWin::determineQuirks):
       
 23754         (WebCore::PluginViewWin::PluginViewWin):
       
 23755         * plugins/win/PluginViewWin.h:
       
 23756         (WebCore::):
       
 23757         * plugins/win/npapi.cpp:
       
 23758         (NPN_UserAgent):
       
 23759 
       
 23760 2006-12-19  Brady Eidson  <beidson@apple.com>
       
 23761 
       
 23762         Change by Lou, reviewed by Brady
       
 23763 
       
 23764         Scrolling caused Desktop flickering as well as other strange
       
 23765         flickering in the case of a missing plug-in
       
 23766 
       
 23767         * plugins/win/PluginViewWin.cpp:
       
 23768         (WebCore::PluginViewWin::updateHwnd):
       
 23769 
       
 23770 2006-12-19  Anders Carlsson  <acarlsson@apple.com>
       
 23771 
       
 23772         * WebCore.vcproj/WebCore.vcproj:
       
 23773         Update for SVG changes.
       
 23774 
       
 23775 2006-12-18  Ada Chan  <adachan@apple.com>
       
 23776 
       
 23777         Reviewed by Adam.
       
 23778 
       
 23779         Removed scheduleClose() from FrameWin.  The implementation has
       
 23780         been moved to Frame.cpp.                
       
 23781 
       
 23782         * bridge/win/FrameWin.h:
       
 23783         * platform/win/TemporaryLinkStubs.cpp:
       
 23784         (FrameWin::mimeTypeForFileName):
       
 23785 
       
 23786 2006-12-18  Anders Carlsson  <acarlsson@apple.com>
       
 23787 
       
 23788         Reviewed by Adam and Oliver.
       
 23789 
       
 23790         <rdar://problem/4856014> Target weekly ad doesn't work.
       
 23791         
       
 23792         Store the real base URL and use it for requests.
       
 23793         
       
 23794         * plugins/win/PluginViewWin.cpp:
       
 23795         (WebCore::PluginViewWin::getURLNotify):
       
 23796         (WebCore::PluginViewWin::getURL):
       
 23797         (WebCore::PluginViewWin::handlePost):
       
 23798         (WebCore::PluginViewWin::PluginViewWin):
       
 23799         * plugins/win/PluginViewWin.h:
       
 23800 
       
 23801 2006-12-19  Darin Adler  <darin@apple.com>
       
 23802 
       
 23803         * platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs): Fix build,
       
 23804         wrong variable name.
       
 23805 
       
 23806 2006-12-18  David Hyatt  <hyatt@apple.com>
       
 23807 
       
 23808         Boomer side of my changes for filling/stroking of text.
       
 23809 
       
 23810         Reviewed by olliej
       
 23811 
       
 23812         * platform/win/FontWin.cpp:
       
 23813         (WebCore::Font::drawGlyphs):
       
 23814 
       
 23815 2006-12-18  Alice Liu  <alice.liu@apple.com>
       
 23816 
       
 23817         Reviewed by Adam.
       
 23818 
       
 23819         <rdar://problem/4853363> hook up various deletion-related functions in WebView
       
 23820 
       
 23821         * WebCore.vcproj/WebCore.vcproj:
       
 23822         Added file EditorDeleteAction.h
       
 23823 
       
 23824 2006-12-18  Kevin McCullough  <KMcCullough@apple.com>
       
 23825 
       
 23826         Reviewed by Oliver.
       
 23827 
       
 23828         - Remove CG header includes in OpenSource files
       
 23829 
       
 23830         * config.h:
       
 23831         * platform/graphics/cg/GraphicsContextPlatformPrivate.h:
       
 23832 
       
 23833 2006-12-18  Adam Roben  <aroben@apple.com>
       
 23834 
       
 23835         Build fixes.
       
 23836 
       
 23837         * WebCore.vcproj/WebCore.vcproj: Removed deleted files.
       
 23838         * platform/win/CursorWin.cpp: Added missing method.
       
 23839         (WebCore::noneCursor):
       
 23840 
       
 23841 2006-12-16  Beth Dakin  <bdakin@apple.com>
       
 23842 
       
 23843         Reviewed by Adam (and partially Geoff).
       
 23844 
       
 23845         Boomer side of making WebCore Context Menus support state and
       
 23846         enabled/disabled, and re-architecture of ContextMenuItem.
       
 23847 
       
 23848         * platform/win/ContextMenuItemWin.cpp: ContextMenuItem class holds
       
 23849         the platformDescription as the sole member variable. Changes to
       
 23850         account for this.
       
 23851         (WebCore::ContextMenuItem::ContextMenuItem): Same.
       
 23852         (WebCore::ContextMenuItem::releasePlatformDescription): Same.
       
 23853         (WebCore::ContextMenuItem::type): Same
       
 23854         (WebCore::ContextMenuItem::platformSubMenu): Same.
       
 23855         (WebCore::ContextMenuItem::setType): Same.
       
 23856         (WebCore::ContextMenuItem::setTitle): Same.
       
 23857         (WebCore::ContextMenuItem::setSubMenu): Same.
       
 23858         (WebCore::ContextMenuItem::setChecked): Same.
       
 23859         (WebCore::ContextMenuItem::setEnabled): Same.
       
 23860         * platform/win/ContextMenuWin.cpp:
       
 23861         (WebCore::ContextMenu::insertItem): Takes ownership of the item by
       
 23862         calling releasePlatformDescription()
       
 23863         (WebCore::ContextMenu::appendItem): Same.
       
 23864         (WebCore::ContextMenu::itemWithAction): This is the new at(). Since
       
 23865         we are no longer using notifybypos, we instead need a way to find a
       
 23866         menu item by its action. (Its ID.)
       
 23867         (WebCore::ContextMenu::setPlatformDescription): No longer use
       
 23868         notifybypos.
       
 23869 
       
 23870 2006-12-16  Adele Peterson  <adele@apple.com>
       
 23871 
       
 23872         RS by Adam.
       
 23873 
       
 23874         Removed TextField, RenderLineEdit classes.
       
 23875 
       
 23876         * WebCore.vcproj/WebCore.vcproj:
       
 23877         * platform/win/TemporaryLinkStubs.cpp:
       
 23878 
       
 23879 2006-12-16  Adele Peterson  <adele@apple.com>
       
 23880 
       
 23881         Reviewed by Adam.
       
 23882 
       
 23883         Added PopupMenu and theme code for:
       
 23884         <rdar://problem/4463829> Switch to use new search field implementation for <input type="search"> 
       
 23885 
       
 23886         * WebCore.vcproj/WebCore.vcproj:
       
 23887         * platform/graphics/win/IconWin.cpp:
       
 23888         (WebCore::Icon::Icon):
       
 23889         * platform/win/PopupMenuWin.cpp:
       
 23890         (WebCore::PopupMenu::setFocusedIndex):
       
 23891         (WebCore::PopupWndProc):
       
 23892         * platform/win/SearchPopupMenuWin.cpp: Added.
       
 23893         (WebCore::SearchPopupMenu::SearchPopupMenu):
       
 23894         (WebCore::autosaveKey):
       
 23895         (WebCore::SearchPopupMenu::saveRecentSearches):
       
 23896         (WebCore::SearchPopupMenu::loadRecentSearches):
       
 23897         * rendering/RenderThemeWin.cpp:
       
 23898         (WebCore::RenderThemeWin::paintSearchField):
       
 23899         (WebCore::RenderThemeWin::adjustSearchFieldStyle):
       
 23900         (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
       
 23901         (WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
       
 23902         (WebCore::RenderThemeWin::adjustSearchFieldDecorationStyle):
       
 23903         (WebCore::RenderThemeWin::paintSearchFieldDecoration):
       
 23904         (WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle):
       
 23905         (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
       
 23906         (WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):
       
 23907         (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
       
 23908         * rendering/RenderThemeWin.h:
       
 23909 
       
 23910 2006-12-15  Anders Carlson  <acarlsson@apple.com>
       
 23911 
       
 23912         * platform/win/TemporaryLinkStubs.cpp:
       
 23913         Remove DocumentLoader::isStopped because it's now in DocumentLoader.cpp.
       
 23914         
       
 23915 2006-12-15  Geoffrey Garen  <ggaren@apple.com>
       
 23916 
       
 23917         I'm in ur prjct, fxng ur build.
       
 23918         
       
 23919         * WebCore.vcproj/WebCore.vcproj:
       
 23920         * platform/win/TemporaryLinkStubs.cpp:
       
 23921         (ResourceHandle::loadResourceSynchronously):
       
 23922 
       
 23923 2006-12-14  Geoffrey Garen  <ggaren@apple.com>
       
 23924 
       
 23925         Reviewed by Brady Eidson.
       
 23926         
       
 23927         Fixed <rdar://problem/4760682> Crash clicking nav links at left loading 
       
 23928         www.tivofaq.com
       
 23929         
       
 23930         The underlying problem is that we can't resize framesets. I've filed that
       
 23931         as <rdar://problem/4885227>.
       
 23932         
       
 23933         I've fixed the proximate problem: we were interpreting a click as a frameset
       
 23934         resize, because the subframe event handler was returning false. A Subframe 
       
 23935         event handler needs to return true to indicate that the subframe has handled 
       
 23936         the event. This is how the Mac works, despite the plethora of convoluted code 
       
 23937         suggesting otherwise.
       
 23938         
       
 23939         We should really remove these meaningless return values and unify Mac and 
       
 23940         Windows event handling, but that's beyond the scope of this patch.
       
 23941 
       
 23942         * page/win/EventHandlerWin.cpp:
       
 23943         (WebCore::EventHandler::passMousePressEventToSubframe):
       
 23944         (WebCore::EventHandler::passMouseMoveEventToSubframe):
       
 23945         (WebCore::EventHandler::passMouseReleaseEventToSubframe):
       
 23946         (WebCore::EventHandler::passWheelEventToSubframe):
       
 23947 
       
 23948 2006-12-14  Adele Peterson  <adele@apple.com>
       
 23949 
       
 23950         Reviewed by Adam. 
       
 23951 
       
 23952         Update PopupMenu code to use new PopupMenuClient instead of RenderMenuList.
       
 23953 
       
 23954         * platform/win/PopupMenuWin.cpp:
       
 23955         (WebCore::PopupMenu::PopupMenu):
       
 23956         (WebCore::PopupMenu::show):
       
 23957         (WebCore::PopupMenu::calculatePositionAndSize):
       
 23958         (WebCore::PopupMenu::setFocusedIndex):
       
 23959         (WebCore::PopupMenu::focusedIndex):
       
 23960         (WebCore::PopupMenu::focusFirst):
       
 23961         (WebCore::PopupMenu::focusLast):
       
 23962         (WebCore::PopupMenu::down):
       
 23963         (WebCore::PopupMenu::up):
       
 23964         (WebCore::PopupMenu::paint):
       
 23965         (WebCore::PopupWndProc):
       
 23966 
       
 23967 2006-12-14  Steve Falkenburg  <sfalken@apple.com>
       
 23968 
       
 23969         Build fix.
       
 23970 
       
 23971         * platform/win/TemporaryLinkStubs.cpp:
       
 23972         (SubresourceLoader::didCancel):
       
 23973 
       
 23974 2006-12-14  Steve Falkenburg  <sfalken@apple.com>
       
 23975 
       
 23976         Production build fix. Added JSSVGPODTypeWrapper.h to the vcproj.
       
 23977 
       
 23978         * WebCore.vcproj/WebCore.vcproj:
       
 23979 
       
 23980 2006-12-14  Adam Roben  <aroben@apple.com>
       
 23981 
       
 23982         Reviewed by Adele.
       
 23983 
       
 23984         Build fix.
       
 23985 
       
 23986         * platform/win/TemporaryLinkStubs.cpp:
       
 23987         (DocumentLoader::URL):
       
 23988         (ResourceHandle::loadResourceSynchronously):
       
 23989 
       
 23990 2006-12-14  Anders Carlsson  <acarlsson@apple.com>
       
 23991 
       
 23992         Fix the build.
       
 23993         
       
 23994         * platform/win/TemporaryLinkStubs.cpp:
       
 23995         (FrameLoader::loadResourceSynchronously):
       
 23996         (ResourceHandle::loadResourceSynchronously):
       
 23997 
       
 23998 2006-12-13  Anders Carlsson  <acarlsson@apple.com>
       
 23999 
       
 24000         Fix the build.
       
 24001         
       
 24002         * platform/win/TemporaryLinkStubs.cpp:
       
 24003         (PolicyCheck::call):
       
 24004         (DocumentLoader::URL):
       
 24005 
       
 24006 2006-12-13  Geoffrey Garen  <ggaren@apple.com>
       
 24007 
       
 24008         Reviewed by Darin Adler, Dave Hyatt.
       
 24009         
       
 24010         Fixed <rdar://problem/4840261> Frame::setIsActive not called when frames 
       
 24011         are focused/unfocused
       
 24012         
       
 24013         Minor problems remain with focus in frames, but basic editing / cursor
       
 24014         focus works.
       
 24015         
       
 24016         I moved tracking of the focused frame from the Widget hiearchy to Page's
       
 24017         FocusController. Not all widgets are frames, so this change cleaned up a 
       
 24018         dubious static cast. Also, the DOM needs to track frame focus because (1) 
       
 24019         it needs to respond to focus changes and (2) you can focus an element / 
       
 24020         frame even before it has a renderer / widget.
       
 24021 
       
 24022         * page/win/EventHandlerWin.cpp:
       
 24023         (WebCore::EventHandler::focusDocumentView): Implemented. This function is
       
 24024         poorly named, based on the Mac design.
       
 24025         (WebCore::PluginViewWin::hasFocus): Added for completeness. It's not really
       
 24026         used on Windows, though.
       
 24027 
       
 24028 2006-12-13  Steve Falkenburg  <sfalken@apple.com>
       
 24029 
       
 24030         Reviewed by Adam.
       
 24031 
       
 24032         Add missing ForwardingHeaders to project
       
 24033 
       
 24034         * WebCore.vcproj/WebCore.make: Fixed line endings
       
 24035         * WebCore.vcproj/WebCore.vcproj: Added missing headers
       
 24036 
       
 24037 2006-12-12  Steve Falkenburg  <sfalken@apple.com>
       
 24038 
       
 24039         Reviewed by Adam.
       
 24040 
       
 24041         Production build fix
       
 24042 
       
 24043         * WebCore.vcproj/build-generated-files.sh:
       
 24044 
       
 24045 2006-12-12  Alice Liu  <alice.liu@apple.com>
       
 24046 
       
 24047         Reviewed by Geoff.
       
 24048 
       
 24049         Fixed <rdar://problem/4853199> extra whitespace at beginning and end of pasted fragment into contenteditable region
       
 24050         
       
 24051         * WebCore.vcproj/WebCore.vcproj:
       
 24052         * platform/win/PasteboardWin.cpp:
       
 24053         (WebCore::Pasteboard::documentFragment):
       
 24054 
       
 24055 2006-12-12  Adam Roben  <aroben@apple.com>
       
 24056 
       
 24057         Reviewed by Anders.
       
 24058 
       
 24059         Fixed use of min/max macros (again).
       
 24060 
       
 24061         * WebCore.vcproj/WebCore.vcproj: Make sure we include ForwardingHeaders
       
 24062         before any include directories so that we get the newest versions
       
 24063         of our headers.
       
 24064         * config.h: Move the fake #defines of min/max out of #if
       
 24065         PLATFORM(WIN_OS) since this is useful in general.
       
 24066         * platform/win/BString.cpp: Include windows.h
       
 24067         * platform/win/BString.h: Forward-declare BSTR so we don't have to
       
 24068         include windows.h.
       
 24069 
       
 24070 2006-12-12  Geoffrey Garen  <ggaren@apple.com>
       
 24071 
       
 24072         Reviewed by Adam Roben, Dave Hyatt, Darin Adler.
       
 24073 
       
 24074         Added FocusController to project.
       
 24075 
       
 24076         * WebCore.vcproj/WebCore.vcproj:
       
 24077 
       
 24078 2006-12-12  Anders Carlsson  <acarlsson@apple.com>
       
 24079 
       
 24080         * loader/win/ResourceLoaderWin.cpp:
       
 24081         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 24082         (WebCore::ResourceHandle::start):
       
 24083         * platform/win/TemporaryLinkStubs.cpp:
       
 24084         (ResourceHandle::loadsBlocked):
       
 24085         Update for changes to ResourceHandle.
       
 24086 
       
 24087 2006-12-13  Darin Adler  <darin@apple.com>
       
 24088 
       
 24089         - fix build
       
 24090 
       
 24091         * WebCore.vcproj/WebCore.vcproj: Added missing files, removed obsolete files.
       
 24092 
       
 24093 2006-12-11  Adam Roben  <aroben@apple.com>
       
 24094 
       
 24095         Build fix.
       
 24096 
       
 24097         * WebCore.vcproj/WebCore.vcproj: Added missing files to project.
       
 24098 
       
 24099 2006-12-11  Steve Falkenburg  <sfalken@apple.com>
       
 24100 
       
 24101         Production build fix.
       
 24102         Remove platform/UChar.h from our vcproj, since it doesn't exist anymore.
       
 24103 
       
 24104         * WebCore.vcproj/WebCore.vcproj:
       
 24105 
       
 24106 2006-12-11  Alice Liu  <alice.liu@apple.com>
       
 24107 
       
 24108         Reviewed by ggaren.
       
 24109 
       
 24110         Fixed <rdar://problem/4854901> "Copy Link" and "Copy Image Address" context menu items don't work
       
 24111         And some cleanup of PlatformMouseEvent(Win)
       
 24112 
       
 24113         * page/win/EventHandlerWin.cpp:
       
 24114         (WebCore::EventHandler::handleDrag):
       
 24115         Removed unnecessary check for mouse event type
       
 24116         
       
 24117         * platform/win/PasteboardWin.cpp:
       
 24118         
       
 24119         (WebCore::PasteboardOwnerWndProc):
       
 24120         (WebCore::createGlobalData):
       
 24121         Added more overloaded implemtations and renamed from createHandle
       
 24122         
       
 24123         (WebCore::markupToCF_HTML):
       
 24124         Changed to handle less-specific input and renamed from createCF_HTML
       
 24125         
       
 24126         (WebCore::urlToMarkup):
       
 24127         (WebCore::Pasteboard::writeURL):
       
 24128         Added these. 
       
 24129         
       
 24130         (WebCore::replaceNBSP):
       
 24131         Moved out of Pasteboard class
       
 24132         
       
 24133         (WebCore::Pasteboard::clear):
       
 24134         Renamed from clearTypes.
       
 24135         
       
 24136         (WebCore::Pasteboard::writeSelection):
       
 24137         (WebCore::Pasteboard::canSmartReplace):
       
 24138         (WebCore::Pasteboard::plainText):
       
 24139         (WebCore::Pasteboard::documentFragment):
       
 24140         Trivial cleanup of these.
       
 24141         
       
 24142         * platform/win/PlatformMouseEventWin.cpp:
       
 24143         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
       
 24144         Removed anything having to do with unnecessary m_type
       
 24145 
       
 24146 2006-12-11  Darin Adler  <darin@apple.com>
       
 24147 
       
 24148         Reviewed by Brady.
       
 24149 
       
 24150         - http://bugs.webkit.org/show_bug.cgi?id=11794
       
 24151           fix lifetime problems affecting Frame's ownerElement pointer
       
 24152 
       
 24153         * WebCore.vcproj/WebCore.vcproj: Update for added files.
       
 24154 
       
 24155         * bridge/win/FrameWin.h:
       
 24156         * bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
       
 24157         * loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::createFrame):
       
 24158         Changed to use HTMLFrameOwnerElement.
       
 24159 
       
 24160         * platform/win/TemporaryLinkStubs.cpp: (FrameLoader::load):
       
 24161         Changed to use HTMLFormElement.
       
 24162 
       
 24163 2006-12-11  Beth Dakin  <bdakin@apple.com>
       
 24164 
       
 24165         Reviewed by Adam.
       
 24166 
       
 24167         Build fix from Nick Zimmerman's last check-in.
       
 24168 
       
 24169         * WebCore.vcproj/WebCore.vcproj:
       
 24170 
       
 24171 2006-12-09  Adam Roben  <aroben@apple.com>
       
 24172 
       
 24173         Reviewed by Hyatt.
       
 24174 
       
 24175         Use num-cpus to determine the number of jobs make should run
       
 24176         concurrently.
       
 24177 
       
 24178         * WebCore.vcproj/build-generated-files.sh:
       
 24179 
       
 24180 2006-12-09  Adam Roben  <aroben@apple.com>
       
 24181 
       
 24182         Reviewed by Hyatt.
       
 24183 
       
 24184         Fix: <rdar://problem/4860184> Can't select context menu items with the
       
 24185         right mouse button
       
 24186 
       
 24187         * platform/win/ContextMenuWin.cpp:
       
 24188         (WebCore::ContextMenu::show):
       
 24189 
       
 24190 2006-12-09  Adam Roben  <aroben@apple.com>
       
 24191 
       
 24192         Reviewed by Darin.
       
 24193 
       
 24194         Build fixes after OpenSource r18098 and r18106.
       
 24195 
       
 24196         * WebCore.vcproj/WebCore.vcproj:
       
 24197             - Changed include paths to reflect the now-flattened JSCore headers.
       
 24198             - Added missing files to project.
       
 24199             - Changed post-build step to also copy ForwardingHeaders.
       
 24200             - Removed unnecessary definition of WTF_PLATFORM_CF from project
       
 24201               file (it's already defined in config.h).
       
 24202         * platform/win/TextBoundariesWin.cpp: Fixed up includes and renamed
       
 24203         function calls.
       
 24204         (WebCore::findNextWordFromIndex):
       
 24205         (WebCore::findWordBoundary):
       
 24206 
       
 24207 2006-12-08  Adam Roben  <aroben@apple.com>
       
 24208 
       
 24209         Rubberstamped by Anders.
       
 24210 
       
 24211         * platform/win/FontPlatformDataWin.cpp:
       
 24212         (WebCore::FontPlatformData::FontPlatformData): Fix use of min().
       
 24213 
       
 24214 2006-12-08  Adam Roben  <aroben@apple.com>
       
 24215 
       
 24216         Build fix.
       
 24217 
       
 24218         * WebCore.vcproj/WebCore.vcproj:
       
 24219 
       
 24220 2006-12-07  Beth Dakin  <bdakin@apple.com>
       
 24221 
       
 24222         Reviewed by Maciej.
       
 24223 
       
 24224         Add a new member variable to ContectMenuItem to hold on to the sub-
       
 24225         menu. The new member variable is an OwnPtr<ContextMenu>. Not doing 
       
 24226         this breaks sub-menus on Boomer since the menu items are no longer 
       
 24227         static.
       
 24228 
       
 24229         * platform/win/ContextMenuItemWin.cpp:
       
 24230         (WebCore::ContextMenuItem::ContextMenuItem):
       
 24231         (WebCore::ContextMenuItem::platformSubMenu):
       
 24232         (WebCore::ContextMenuItem::setSubMenu):
       
 24233 
       
 24234 2006-12-07  Kevin McCullough  <kmccullough@apple.com>
       
 24235 
       
 24236         Reviewed by.
       
 24237 
       
 24238         Fixed previous comment
       
 24239 
       
 24240         * ChangeLog:
       
 24241 
       
 24242 2006-12-07  Kevin McCullough  <kmccullough@apple.com>
       
 24243 
       
 24244         Reviewed by Geof.
       
 24245 
       
 24246         - keyDown events must be followed by keyPressed events and before keyUp events.
       
 24247 
       
 24248         * bridge/win/FrameWin.cpp:
       
 24249         (WebCore::FrameWin::keyEvent):
       
 24250 
       
 24251 2006-12-07  Beth Dakin  <bdakin@apple.com>
       
 24252 
       
 24253         Reviewed by Brady.
       
 24254 
       
 24255         New link stub for load() function used by 
       
 24256         ContextMenuItemTagOpenLink action.
       
 24257 
       
 24258         * platform/win/TemporaryLinkStubs.cpp:
       
 24259         (FrameLoader::load):
       
 24260 
       
 24261 2006-12-07  Ada Chan  <adachan@apple.com>
       
 24262 
       
 24263         Reviewed by Steve and Anders.
       
 24264 
       
 24265         <rdar://4866288> Crash on boomer quit
       
 24266         - don't close the themes on termination, since uxtheme should do that anyway.
       
 24267 
       
 24268         * rendering/RenderThemeWin.cpp:
       
 24269         (WebCore::RenderThemeWin::~RenderThemeWin):
       
 24270 
       
 24271 2006-12-06  Ada Chan  <adachan@apple.com>
       
 24272 
       
 24273         Reviewed by Maciej.
       
 24274 
       
 24275         Fixed a couple of things while investigating <rdar://4866288> (note this doesn't fix the crash yet):
       
 24276         - we forgot to initialize m_sliderTheme
       
 24277         - we did the wrong null check when getting the slider theme.
       
 24278 
       
 24279         * rendering/RenderThemeWin.cpp:
       
 24280         (WebCore::RenderThemeWin::RenderThemeWin):
       
 24281         (WebCore::RenderThemeWin::sliderTheme):
       
 24282 
       
 24283 2006-12-06  Anders Carlsson  <acarlsson@apple.com>
       
 24284 
       
 24285         Fix the build.
       
 24286         
       
 24287         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 24288         (WebCore::didReceiveData):
       
 24289         (WebCore::didFail):
       
 24290         (WebCore::ResourceHandle::start):
       
 24291         (WebCore::ResourceHandle::cancel):
       
 24292 
       
 24293 2006-12-06  Anders Carlsson  <acarlsson@apple.com>
       
 24294 
       
 24295         Reviewed by Adam.
       
 24296 
       
 24297         Modify PluginStreamWin to use a SubresourceLoader instead of a ResourceHandle.
       
 24298 
       
 24299         * plugins/win/PluginStreamWin.cpp:
       
 24300         (WebCore::PluginStreamWin::PluginStreamWin):
       
 24301         (WebCore::PluginStreamWin::~PluginStreamWin):
       
 24302         (WebCore::PluginStreamWin::start):
       
 24303         (WebCore::PluginStreamWin::stop):
       
 24304         (WebCore::PluginStreamWin::deliverData):
       
 24305         (WebCore::PluginStreamWin::didReceiveResponse):
       
 24306         (WebCore::PluginStreamWin::didReceiveData):
       
 24307         (WebCore::PluginStreamWin::didFail):
       
 24308         (WebCore::PluginStreamWin::didFinishLoading):
       
 24309         * plugins/win/PluginStreamWin.h:
       
 24310         * plugins/win/PluginViewWin.cpp:
       
 24311         (WebCore::PluginViewWin::performRequest):
       
 24312         (WebCore::PluginViewWin::load):
       
 24313 
       
 24314 2006-12-06  Anders Carlsson  <acarlsson@apple.com>
       
 24315 
       
 24316         Build fixes.
       
 24317         
       
 24318         * WebCore.vcproj/WebCore.vcproj:
       
 24319         * platform/win/TemporaryLinkStubs.cpp:
       
 24320         (FrameWin::scheduleClose):
       
 24321 
       
 24322 2006-12-05  John Sullivan  <sullivan@apple.com>
       
 24323 
       
 24324         Try to keep the windows build happy with Frame -> Editor changes...
       
 24325 
       
 24326         * bridge/win/FrameWin.h:
       
 24327         removed declarations of spelling and grammar functions
       
 24328 
       
 24329         * platform/win/TemporaryLinkStubs.cpp:
       
 24330         changed spelling and grammar functions from FrameWin:: to Editor::
       
 24331         (WebCore::Editor::isSelectionMisspelled):
       
 24332         (WebCore::Editor::isSelectionUngrammatical):
       
 24333         (WebCore::Editor::guessesForMisspelledSelection):
       
 24334         (WebCore::Editor::guessesForUngrammaticalSelection):
       
 24335         (WebCore::Editor::markMisspellingsInAdjacentWords):
       
 24336         (WebCore::Editor::advanceToNextMisspelling):
       
 24337 
       
 24338 2006-12-05  Anders Carlsson  <acarlsson@apple.com>
       
 24339 
       
 24340         Reviewed by Maciej.
       
 24341 
       
 24342         Don't delete the internal pointer anymore since it's an OwnPtr now.
       
 24343         
       
 24344         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 24345         (WebCore::ResourceHandle::~ResourceHandle):
       
 24346 
       
 24347 2006-12-05  Steve Falkenburg  <sfalken@apple.com>
       
 24348 
       
 24349         Fix the build
       
 24350 
       
 24351         * platform/win/TemporaryLinkStubs.cpp:
       
 24352 
       
 24353 2006-12-05  Steve Falkenburg  <sfalken@apple.com>
       
 24354 
       
 24355         Production build fix.
       
 24356         ...and add ImageAnimationObserver.h into its new location.
       
 24357 
       
 24358         * WebCore.vcproj/WebCore.vcproj:
       
 24359 
       
 24360 2006-12-05  Steve Falkenburg  <sfalken@apple.com>
       
 24361 
       
 24362         Production build fix.
       
 24363         Remove ImageAnimationObserver.h from vcproj.
       
 24364 
       
 24365         * WebCore.vcproj/WebCore.vcproj:
       
 24366 
       
 24367 2006-12-05  John Sullivan  <sullivan@apple.com>
       
 24368 
       
 24369         Reviewed by Geoff Garen
       
 24370 
       
 24371         Changes to keep up with Frame -> Editor changes in WebCore
       
 24372 
       
 24373         * bridge/win/FrameWin.h:
       
 24374         remove ignoreSpelling() and learnSpelling()
       
 24375 
       
 24376         * platform/win/TemporaryLinkStubs.cpp:
       
 24377         (WebCore::Editor::ignoreSpelling):
       
 24378         moved from FrameWin to Editor
       
 24379         (WebCore::Editor::learnSpelling):
       
 24380         ditto
       
 24381 
       
 24382 2006-12-05  Alice Liu  <alice.liu@apple.com>
       
 24383 
       
 24384         Build fix.
       
 24385         
       
 24386         * platform/win/CursorWin.cpp:
       
 24387         (WebCore::copyCursor):
       
 24388 
       
 24389 2006-12-05  Alice Liu  <alice.liu@apple.com>
       
 24390 
       
 24391         Build fix.
       
 24392         
       
 24393         * bridge/win/FrameWin.h:
       
 24394         added missing declarations for the functions in John's checkin, below. 
       
 24395 
       
 24396 2006-12-05  John Sullivan  <sullivan@apple.com>
       
 24397 
       
 24398         * platform/win/TemporaryLinkStubs.cpp:
       
 24399         (WebCore::FrameWin::isSelectionUngrammatical):
       
 24400         (WebCore::FrameWin::guessesForUngrammaticalSelection):
       
 24401         added stubs to correspond to new Frame functions
       
 24402 
       
 24403 2006-12-04  Anders Carlsson  <acarlsson@apple.com>
       
 24404 
       
 24405         Reviewed by Darin.
       
 24406 
       
 24407         * WebCore.vcproj/WebCore.vcproj:
       
 24408         Add SubresourceClient.h
       
 24409         
       
 24410         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 24411         (WebCore::didReceiveResponse):
       
 24412         Get rid of the receivedResponse call.
       
 24413         
       
 24414         (WebCore::didFinishLoading):
       
 24415         Get rid of the receivedAllData call, that's handled by the subresource loader now.
       
 24416 
       
 24417 2006-12-04  Darin Adler  <darin@apple.com>
       
 24418 
       
 24419         Reviewed by Adele.
       
 24420 
       
 24421         * WebCore.vcproj/WebCore.vcproj: Update for new UIEventWithKeyState.cpp file.
       
 24422 
       
 24423 2006-12-04  Kevin McCullough  <KMcCullough@apple.com>
       
 24424 
       
 24425         Reviewed by Darin.
       
 24426 
       
 24427         - removed the guards for the "multiple forms submission" issue, which may not be
       
 24428           an issue anymore and the guards prevent perfectly legitimate websites from
       
 24429           working correctly.
       
 24430 
       
 24431         * bridge/win/FrameWin.cpp:
       
 24432         (WebCore::FrameWin::keyEvent):
       
 24433         * config.h:
       
 24434         * loader/win/FrameLoaderWin.cpp:
       
 24435         (WebCore::FrameLoader::submitForm):
       
 24436 
       
 24437 2006-12-04  Darin Adler  <darin@apple.com>
       
 24438 
       
 24439         Reviewed by Alice.
       
 24440 
       
 24441         * platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::generalPasteboard):
       
 24442         Got rid of s_generalPasteboard. Also removed definition of destructor.
       
 24443 
       
 24444 2006-12-04  Anders Carlsson  <acarlsson@apple.com>
       
 24445 
       
 24446         Reviewed by Darin, Geoff.
       
 24447 
       
 24448         Get rid of ref() in ResourceHandle::start() and remove all uses of kill().
       
 24449         
       
 24450         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 24451         (WebCore::didFinishLoading):
       
 24452         (WebCore::didFail):
       
 24453         (WebCore::ResourceHandle::start):
       
 24454         * plugins/win/PluginStreamWin.cpp:
       
 24455         (WebCore::PluginStreamWin::stop):
       
 24456 
       
 24457 2006-12-04  Alice Liu  <alice.liu@apple.com>
       
 24458 
       
 24459         Reviewed by Oliver.
       
 24460 
       
 24461         Fixed <rdar://problem/4822632> clicks don't work if you move mouse immediately
       
 24462         This bug was fixed by implementing EventHandler::handleDrag.  The part of that
       
 24463         function after the drag hysteresis is exceeded remains unimplemented until 
       
 24464         drag&drop is implemented. 
       
 24465 
       
 24466         * page/win/EventHandlerWin.cpp:
       
 24467         (WebCore::dragState):
       
 24468         (WebCore::EventHandler::dragHysteresisExceeded):
       
 24469         (WebCore::EventHandler::handleDrag):
       
 24470         (WebCore::EventHandler::handleMouseUp):
       
 24471         (WebCore::EventHandler::shouldDragAutoNode):
       
 24472         (WebCore::EventHandler::focusDocumentView):
       
 24473         (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
       
 24474         * platform/win/PlatformMouseEventWin.cpp:
       
 24475         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
       
 24476 
       
 24477 2006-12-01  Beth Dakin  <bdakin@apple.com>
       
 24478 
       
 24479         Reviewed by Adam.
       
 24480 
       
 24481         Support for sub-menus in WebCore context menus. Also some
       
 24482         adjustments to make ContextMenuItem class a wrapper for the
       
 24483         platformDescription. (In this case, a wrapper for LPMENUITEMINFO.)
       
 24484 
       
 24485         * WebCore.vcproj/WebCore.vcproj:
       
 24486         * platform/win/ContextMenuItemWin.cpp:
       
 24487         (WebCore::ContextMenuItem::ContextMenuItem):
       
 24488         (WebCore::ContextMenuItem::platformDescription):
       
 24489         (WebCore::ContextMenuItem::action):
       
 24490         (WebCore::ContextMenuItem::title):
       
 24491         (WebCore::ContextMenuItem::platformSubMenu):
       
 24492         (WebCore::ContextMenuItem::setAction):
       
 24493         (WebCore::ContextMenuItem::setTitle):
       
 24494         (WebCore::ContextMenuItem::setSubMenu):
       
 24495         * platform/win/ContextMenuWin.cpp:
       
 24496         (WebCore::ContextMenu::ContextMenu):
       
 24497         (WebCore::ContextMenu::insertItem):
       
 24498 
       
 24499 2006-11-30  Geoffrey Garen  <ggaren@apple.com>
       
 24500 
       
 24501         Rubber Stamped by Anders Carlsson.
       
 24502 
       
 24503         Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
       
 24504         suggested a command, and conflicted with a different meaning for 'focusNode'
       
 24505         in the Mozilla selection API.
       
 24506 
       
 24507         * bridge/win/FrameWin.cpp:
       
 24508         (WebCore::FrameWin::keyEvent):
       
 24509 
       
 24510 2006-11-30  Adam Roben  <aroben@apple.com>
       
 24511 
       
 24512         Lather, rinse, repeat.
       
 24513 
       
 24514         * platform/win/GraphicsContextWin.cpp:
       
 24515         (WebCore::contextForImage):
       
 24516 
       
 24517 2006-11-30  Adam Roben  <aroben@apple.com>
       
 24518 
       
 24519         Build fix.
       
 24520 
       
 24521         * platform/graphics/cg/GraphicsContextCG.cpp: Removed. This file was
       
 24522         un-forked a while ago.
       
 24523         * platform/win/ContextMenuWin.cpp:
       
 24524         (WebCore::ContextMenu::platformDescription):
       
 24525         * platform/win/GraphicsContextWin.cpp:
       
 24526         (WebCore::contextForImage):
       
 24527 
       
 24528 2006-11-30  Adam Roben  <aroben@apple.com>
       
 24529 
       
 24530         Build fix. 
       
 24531 
       
 24532 
       
 24533         * WebCore.vcproj/WebCore.vcproj:
       
 24534         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
       
 24535         (WebCore::SVGResourceFilter::prepareFilter):
       
 24536         (WebCore::SVGResourceFilter::applyFilter):
       
 24537         (WebCore::SVGResourceFilter::createFilterEffect):
       
 24538         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp:
       
 24539         (WebCore::SVGResourceMasker::applyMask):
       
 24540 
       
 24541 2006-11-30  Geoffrey Garen  <ggaren@apple.com>
       
 24542 
       
 24543         Reviewed by Beth Dakin.
       
 24544         
       
 24545         Fixed <rdar://problem/4844838> Whole document leak seen 
       
 24546         running HTML iBench
       
 24547 
       
 24548         * loader/win/FrameLoaderWin.cpp: Removed custom implementation
       
 24549         for detachFromParent, since FrameLoader has a cross-platform
       
 24550         version now.
       
 24551 
       
 24552 2006-11-30  Steve Falkenburg  <sfalken@apple.com>
       
 24553 
       
 24554         Production build fix.  Add missing header files to vcproj.
       
 24555 
       
 24556         * WebCore.vcproj/WebCore.vcproj:
       
 24557 
       
 24558 2006-11-29  Anders Carlsson  <acarlsson@apple.com>
       
 24559 
       
 24560         Build fix.
       
 24561         
       
 24562         * platform/win/TemporaryLinkStubs.cpp:
       
 24563         Remove unused function.
       
 24564 
       
 24565 2006-11-29  Anders Carlsson  <acarlsson@apple.com>
       
 24566 
       
 24567         Reviewed by Oliver.
       
 24568 
       
 24569         Fix fast/dom/xmlhttprequest-get layout test failure.
       
 24570 
       
 24571         * platform/network/cf/ResourceResponseCFNet.cpp:
       
 24572         (WebCore::ResourceResponse::doUpdateResourceResponse):
       
 24573         Initialize the status code to 0 for non-http responses.
       
 24574 
       
 24575 2006-11-29  Anders Carlsson  <acarlsson@apple.com>
       
 24576 
       
 24577         Reviewed by Darin.
       
 24578 
       
 24579         Have ResourceResponse hold on to the platform object and do lazy
       
 24580         initialization of the data members.
       
 24581         
       
 24582         * WebCore.vcproj/WebCore.vcproj:
       
 24583         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 24584         (WebCore::willSendRequest):
       
 24585         (WebCore::didReceiveResponse):
       
 24586         * platform/network/cf/ResourceRequestCFNet.h: Removed.
       
 24587         * platform/network/cf/ResourceResponseCFNet.cpp:
       
 24588         (WebCore::ResourceResponse::doUpdateResourceResponse):
       
 24589         * platform/network/cf/ResourceResponseCFNet.h: Removed.
       
 24590         * platform/win/MimeTypeRegistryWin.cpp:
       
 24591 
       
 24592 2006-11-28  Geoffrey Garen  <ggaren@apple.com>
       
 24593 
       
 24594         Reviewed by Beth Dakin.
       
 24595 
       
 24596         Fixed <rdar://problem/4844855> Should clarify when to create clients in 
       
 24597         the WebCore client API
       
 24598         
       
 24599         All clients must now be supplied as constructor arguments. This clarifies 
       
 24600         when you need to create clients, and also guarantees that objects can't 
       
 24601         (for the most part) be in a clientless state.
       
 24602 
       
 24603         Layout tests pass. No leaks reported.
       
 24604         
       
 24605         * bridge/win/FrameWin.cpp:
       
 24606         (WebCore::FrameWin::FrameWin):
       
 24607         * bridge/win/FrameWin.h:
       
 24608 
       
 24609 2006-11-28  Adam Roben  <aroben@apple.com>
       
 24610 
       
 24611         Reviewed by Ada.
       
 24612 
       
 24613         Add platform-specific constructor/destructor to ContextMenu so we can
       
 24614         properly dispose of the HMENU.
       
 24615 
       
 24616         * platform/win/ContextMenuWin.cpp:
       
 24617         (WebCore::ContextMenu::ContextMenu):
       
 24618         (WebCore::ContextMenu::~ContextMenu):
       
 24619         (WebCore::ContextMenu::itemCount):
       
 24620         (WebCore::ContextMenu::insertItem):
       
 24621         (WebCore::ContextMenu::at):
       
 24622         (WebCore::ContextMenu::setPlatformDescription):
       
 24623         (WebCore::ContextMenu::show):
       
 24624 
       
 24625 2006-11-28  Steve Falkenburg  <sfalken@apple.com>
       
 24626 
       
 24627         B&I build fix
       
 24628 
       
 24629         * WebCore.vcproj/WebCore.vcproj:
       
 24630 
       
 24631 2006-11-28  Anders Carlsson  <acarlsson@apple.com>
       
 24632 
       
 24633         Fix the build by doing the same changes that were done in the open source WebCore repo.
       
 24634         
       
 24635         * WebCore.vcproj/WebCore.vcproj:
       
 24636         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 24637         (WebCore::willSendRequest):
       
 24638         (WebCore::didReceiveResponse):
       
 24639         (WebCore::ResourceHandle::start):
       
 24640         * platform/network/cf/ResourceRequestCFNet.cpp:
       
 24641         (WebCore::ResourceRequest::cfURLRequest):
       
 24642         (WebCore::addHeadersFromHashMap):
       
 24643         (WebCore::ResourceRequest::doUpdatePlatformRequest):
       
 24644         (WebCore::ResourceRequest::doUpdateResourceRequest):
       
 24645         * platform/network/cf/ResourceRequestCFNet.h:
       
 24646 
       
 24647 2006-11-28  Adam Roben  <aroben@apple.com>
       
 24648 
       
 24649         Reviewed by Ada and Beth.
       
 24650 
       
 24651         Fix: <rdar://problem/4601523> Contextual Menus (in web content)
       
 24652 
       
 24653         * WebCore.vcproj/WebCore.vcproj: Defined WEBCORE_CONTEXT_MENUS to turn
       
 24654         on the context menus. Added new ContextMenuItem files.
       
 24655         * platform/win/ContextMenuItemWin.cpp: Added.
       
 24656         (WebCore::ContextMenuItem::ContextMenuItem):
       
 24657         * platform/win/ContextMenuWin.cpp:
       
 24658         (WebCore::ContextMenu::itemCount): Updated to match ContextMenu.h and
       
 24659         ContextMenuItem changes.
       
 24660         (WebCore::ContextMenu::insertItem): Ditto.
       
 24661         (WebCore::ContextMenu::appendItem): Ditto.
       
 24662         (WebCore::ContextMenu::at): New method, similar to Vector<T>::at.
       
 24663         (WebCore::ContextMenu::setPlatformDescription): Use MIM_APPLYTOSUBMENUS
       
 24664         to make sure all submenus get the MNS_NOTIFYBYPOS style.
       
 24665         (WebCore::ContextMenu::show): Implemented.
       
 24666 
       
 24667         Updates to match OpenSource changes.
       
 24668 
       
 24669         * loader/win/FrameLoaderWin.cpp: Added missing #include.
       
 24670         * page/win/EventHandlerWin.cpp: Return bools to signify whether the
       
 24671         event was handled.
       
 24672         (WebCore::EventHandler::passMousePressEventToSubframe):
       
 24673         (WebCore::EventHandler::passMouseMoveEventToSubframe):
       
 24674         (WebCore::EventHandler::passMouseReleaseEventToSubframe):
       
 24675         (WebCore::EventHandler::passWheelEventToSubframe):
       
 24676         (WebCore::EventHandler::passMousePressEventToScrollbar):
       
 24677         * platform/win/PlatformScrollBar.h: Ditto.
       
 24678         * platform/win/PlatformScrollBarWin.cpp: Ditto.
       
 24679         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
       
 24680         (WebCore::PlatformScrollbar::handleMouseOutEvent):
       
 24681         (WebCore::PlatformScrollbar::handleMousePressEvent):
       
 24682         (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
       
 24683 
       
 24684         Small fix inspired by WebView.cpp changes.
       
 24685 
       
 24686         * platform/win/PopupMenuWin.cpp:
       
 24687         (WebCore::PopupMenu::calculatePositionAndSize): Use ::ClientToScreen to
       
 24688         do coordinate conversion instead of doing it ourselves.
       
 24689 
       
 24690 2006-11-28  Anders Carlsson  <acarlsson@apple.com>
       
 24691 
       
 24692         Reviewed by Adam.
       
 24693         
       
 24694         <rdar://problem/4850883>
       
 24695         Crash loading pdf page (W4 form)
       
 24696         
       
 24697         * platform/win/TemporaryLinkStubs.cpp:
       
 24698         (FrameLoader::redirectDataToPlugin):
       
 24699         * loader/win/FrameLoaderWin.cpp:
       
 24700         (WebCore::FrameLoader::redirectDataToPlugin):
       
 24701         Move the function to FrameLoaderWin.cpp and get rid of STOP_NOIMPL() for now, 
       
 24702         we do things differently on Windows so this function doesn't need do do anything.
       
 24703         I've filed 4852889 about redoing this once the loader has been ported.
       
 24704 
       
 24705 2006-11-28  Alice Liu  <alice.liu@apple.com>
       
 24706 
       
 24707         Reviewed by Ada, Adam, and Lou.
       
 24708 
       
 24709         * WebCore.vcproj/WebCore.vcproj:
       
 24710         Added the files listed below
       
 24711         
       
 24712         * platform/win/ClipboardWin.h: Added.
       
 24713         * platform/win/ClipboardWin.cpp: Added.
       
 24714         Added the minimum stubs for the ClipboardWin class
       
 24715         (WebCore::ClipboardWin::isForDragging):
       
 24716         (WebCore::ClipboardWin::dropEffect):
       
 24717         (WebCore::ClipboardWin::setDropEffect):
       
 24718         (WebCore::ClipboardWin::effectAllowed):
       
 24719         (WebCore::ClipboardWin::setEffectAllowed):
       
 24720         (WebCore::ClipboardWin::clearData):
       
 24721         (WebCore::ClipboardWin::clearAllData):
       
 24722         (WebCore::ClipboardWin::getData):
       
 24723         (WebCore::ClipboardWin::setData):
       
 24724         (WebCore::ClipboardWin::types):
       
 24725         (WebCore::ClipboardWin::dragLocation):
       
 24726         (WebCore::ClipboardWin::dragImage):
       
 24727         (WebCore::ClipboardWin::setDragImage):
       
 24728         (WebCore::ClipboardWin::dragImageElement):
       
 24729         (WebCore::ClipboardWin::setDragImageElement):
       
 24730         (WebCore::ClipboardWin::setAccessPolicy):
       
 24731         (WebCore::ClipboardWin::~ClipboardWin):
       
 24732 
       
 24733         * platform/win/EditorWin.cpp: Added.
       
 24734         Added this to make dispatchCPPEvent happy. 
       
 24735         (WebCore::Editor::newGeneralClipboard):
       
 24736 
       
 24737         * platform/win/PasteboardWin.cpp: Added.
       
 24738         The pasteboard class follows a singleton pattern
       
 24739         Implemented the following to support CF_HTML, CF_UNICODE, and CF_TEXT
       
 24740         (WebCore::Pasteboard::generalPasteboard):
       
 24741         (WebCore::Pasteboard::Pasteboard):
       
 24742         (WebCore::Pasteboard::~Pasteboard):
       
 24743         (WebCore::Pasteboard::registerSelectionPasteboardTypes):
       
 24744         (WebCore::Pasteboard::clearTypes):
       
 24745         (WebCore::Pasteboard::writeSelection):
       
 24746         (WebCore::Pasteboard::createHandleFromString):
       
 24747         (WebCore::Pasteboard::createHandleFromCString):
       
 24748         (WebCore::Pasteboard::createCF_HTMLFromRange):
       
 24749         (WebCore::Pasteboard::replaceNBSP):
       
 24750         (WebCore::Pasteboard::canSmartReplace):
       
 24751         (WebCore::Pasteboard::plainText):
       
 24752         (WebCore::Pasteboard::documentFragment):
       
 24753         (WebCore::PasteboardOwnerWndProc):
       
 24754 
       
 24755 2006-11-28  Geoffrey Garen  <ggaren@apple.com>
       
 24756 
       
 24757         Reviewed by Anders Carlsson.
       
 24758 
       
 24759         Fixed <rdar://problem/4844863> REGRESSION: screen flashes when scrolling/
       
 24760         resizing page with plug-in (@ cnn.com, for example).
       
 24761 
       
 24762         LockWindowUpdate was to blame. It turns out that using LockWindowUpdate
       
 24763         was wrong to begin with. It's really only intended for use in drag-n-drop
       
 24764         operations, which explains why only one window can be locked at a time.
       
 24765         (See http://blogs.msdn.com/oldnewthing/archive/2004/06/10/152612.aspx.)
       
 24766         
       
 24767         The new solution I've implemented for avoiding plug-in fragments while scrolling
       
 24768         is simply to clip the plug-in to the zero rect before moving it, and
       
 24769         then to un-clip it when done.
       
 24770         
       
 24771         * plugins/win/PluginViewWin.cpp:
       
 24772         (WebCore::PluginViewWin::updateHwnd):
       
 24773 
       
 24774 2006-11-28  Geoffrey Garen  <ggaren@apple.com>
       
 24775 
       
 24776         Reviewed by Adam.
       
 24777 
       
 24778         Fixed <rdar://problem/4844848> REGRESSION: extra cross-library ref/deref 
       
 24779         calls cause .5% PLT regression.
       
 24780         
       
 24781         Changed ref/deref calls to a single 'xxxDestroyed' call. Moved EditorClient
       
 24782         from the Frame to the Page, since it's only responsible for
       
 24783         Webview-level delegate calls.
       
 24784         
       
 24785         I don't really love this design, but it fixes the regression and allows
       
 24786         a single WebKit object to implement multiple client interfaces.
       
 24787         
       
 24788         Layout tests pass.
       
 24789 
       
 24790 2006-11-27  Beth Dakin  <bdakin@apple.com>
       
 24791 
       
 24792         Reviewed by Adam.
       
 24793 
       
 24794         Stub out functions in order to remove FIXMEs from ContextMenu.cpp
       
 24795 
       
 24796         * bridge/win/FrameWin.h: Spell checker functions pushed down from 
       
 24797         WebKit.
       
 24798         * platform/win/TemporaryLinkStubs.cpp: Stubs for spelling 
       
 24799         functions.
       
 24800         (WebCore::FrameWin::isSelectionMisspelled):
       
 24801         (WebCore::FrameWin::guessesForMisspelledSelection):
       
 24802 
       
 24803 2006-11-27  Oliver Hunt  <oliver@apple.com>
       
 24804 
       
 24805         Reviewed by Adam.
       
 24806 
       
 24807         Fixes a crash in SVG caused by an attempt to 
       
 24808         perform css overflow clipping by preventing
       
 24809         the css overflow clip from being set in SVG.
       
 24810         
       
 24811         <rdar:/problems/4839568>
       
 24812 
       
 24813         * WebCore.vcproj/WebCore.vcproj:
       
 24814 
       
 24815 2006-11-27  Anders Carlsson  <acarlsson@apple.com>
       
 24816 
       
 24817         Remove addMessageToConsole from FrameWin.
       
 24818         * bridge/win/FrameWin.h:
       
 24819         * platform/win/TemporaryLinkStubs.cpp:
       
 24820         
       
 24821 2006-11-21  Anders Carlsson  <acarlsson@apple.com>
       
 24822 
       
 24823         Reviewed by Adam.
       
 24824 
       
 24825         Various fixes that make file upload possible.
       
 24826         
       
 24827         * bridge/win/FrameWin.h:
       
 24828         * loader/win/FrameLoaderWin.cpp:
       
 24829         (WebCore::FrameLoader::submitForm):
       
 24830         Change submitForm to take a FrameLoadRequest.
       
 24831         
       
 24832         * platform/network/cf/FormDataStreamCFNet.cpp:
       
 24833         (WebCore::advanceCurrentStream):
       
 24834         Pass kCFURLWindowsPathStyle to CFURLCreateWithFileSystemPath.
       
 24835         
       
 24836         * platform/network/cf/ResourceHandleCFNet.cpp:
       
 24837         (WebCore::willSendRequest):
       
 24838         Call the client method.
       
 24839 
       
 24840 2006-11-21  Anders Carlsson  <acarlsson@apple.com>
       
 24841 
       
 24842         Rubber-stamped by Maciej.
       
 24843 
       
 24844         Fork the CF loader.
       
 24845         
       
 24846         * WebCore.vcproj/WebCore.vcproj:
       
 24847         * platform/network/cf/FormDataStreamCFNet.cpp: Added.
       
 24848         (WebCore::getStreamFormDatas):
       
 24849         (WebCore::pairRetain):
       
 24850         (WebCore::pairRelease):
       
 24851         (WebCore::pairEqual):
       
 24852         (WebCore::pairHash):
       
 24853         (WebCore::closeCurrentStream):
       
 24854         (WebCore::scheduleWithPair):
       
 24855         (WebCore::advanceCurrentStream):
       
 24856         (WebCore::openNextStream):
       
 24857         (WebCore::formCreate):
       
 24858         (WebCore::formFinalize):
       
 24859         (WebCore::formOpen):
       
 24860         (WebCore::formRead):
       
 24861         (WebCore::formCanRead):
       
 24862         (WebCore::formClose):
       
 24863         (WebCore::formSchedule):
       
 24864         (WebCore::formUnschedule):
       
 24865         (WebCore::formEventCallback):
       
 24866         (WebCore::setHTTPBody):
       
 24867         (WebCore::httpBodyFromStream):
       
 24868         * platform/network/cf/FormDataStreamCFNet.h: Added.
       
 24869         * platform/network/cf/ResourceHandleCFNet.cpp: Added.
       
 24870         (WebCore::willSendRequest):
       
 24871         (WebCore::didReceiveResponse):
       
 24872         (WebCore::didReceiveData):
       
 24873         (WebCore::didFinishLoading):
       
 24874         (WebCore::didFail):
       
 24875         (WebCore::willCacheResponse):
       
 24876         (WebCore::didReceiveChallenge):
       
 24877         (WebCore::addHeadersFromHashMap):
       
 24878         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
       
 24879         (WebCore::ResourceHandle::~ResourceHandle):
       
 24880         (WebCore::arrayFromFormData):
       
 24881         (WebCore::emptyPerform):
       
 24882         (WebCore::runLoaderThread):
       
 24883         (WebCore::ResourceHandle::start):
       
 24884         (WebCore::ResourceHandle::cancel):
       
 24885         * platform/network/cf/ResourceRequestCFNet.cpp: Added.
       
 24886         (WebCore::getResourceRequest):
       
 24887         (WebCore::addHeadersFromHashMap):
       
 24888         (WebCore::cfURLRequest):
       
 24889         * platform/network/cf/ResourceRequestCFNet.h: Added.
       
 24890         * platform/network/cf/ResourceResponseCFNet.cpp: Added.
       
 24891         (WebCore::getResourceResponse):
       
 24892         * platform/network/cf/ResourceResponseCFNet.h: Added.
       
 24893 
       
 24894 2006-11-21  Anders Carlsson  <acarlsson@apple.com>
       
 24895 
       
 24896         Reviewed by Lou, Dave Hyatt.
       
 24897 
       
 24898         <rdar://problem/4761639>
       
 24899         Group label in list box doesn't appear as bold
       
 24900         
       
 24901         <rdar://problem/4805795>
       
 24902         <optgroup> labels should be bold in popup menus
       
 24903         
       
 24904         * platform/win/FontPlatformDataWin.cpp:
       
 24905         (WebCore::enumStylesCallback):
       
 24906         (WebCore::FontPlatformData::FontPlatformData):
       
 24907         Enumerate the existing font styles and decide what to synthesize
       
 24908         depending on what styles are available.
       
 24909 
       
 24910 2006-11-21  Anders Carlsson  <acarlsson@apple.com>
       
 24911 
       
 24912         Fix build.
       
 24913         
       
 24914         * WebCore.vcproj/WebCore.vcproj:
       
 24915 
       
 24916 2006-11-20  Anders Carlsson  <acarlsson@apple.com>
       
 24917 
       
 24918         Add the same include paths to the debug build.
       
 24919         
       
 24920         * WebCore.vcproj/WebCore.vcproj:
       
 24921 
       
 24922 2006-11-20  Anders Carlsson  <acarlsson@apple.com>
       
 24923 
       
 24924         Fix build.
       
 24925         
       
 24926         * WebCore.vcproj/WebCore.vcproj:
       
 24927         * kcanvas/device/quartz/KCanvasFilterQuartz.cpp: Removed.
       
 24928         * platform/graphics/svg/cg/SVGResourceFilterCg.cpp: Added.
       
 24929         (WebCore::SVGResourceFilter::SVGResourceFilter):
       
 24930         (WebCore::SVGResourceFilter::~SVGResourceFilter):
       
 24931         (WebCore::SVGResourceFilter::prepareFilter):
       
 24932         (WebCore::SVGResourceFilter::applyFilter):
       
 24933 
       
 24934 2006-11-19  Beth Dakin  <bdakin@apple.com>
       
 24935 
       
 24936         Reviewed by Adam.
       
 24937 
       
 24938         Boomer part of context menu actions.
       
 24939 
       
 24940         * bridge/win/FrameWin.h: New spelling functions on Frame.
       
 24941         * platform/win/ContextMenuWin.cpp:
       
 24942         (WebCore::ContextMenu::show):
       
 24943         (WebCore::ContextMenu::hide):
       
 24944         * platform/win/TemporaryLinkStubs.cpp: New stubs.
       
 24945         (FrameWin::ignoreSpelling):
       
 24946         (FrameWin::learnSpelling):
       
 24947         (FrameLoader::reload):
       
 24948 
       
 24949 2006-11-18  Adam Roben  <aroben@apple.com>
       
 24950 
       
 24951         Build fix from OpenSource r17841.
       
 24952 
       
 24953         * platform/win/CursorWin.cpp: New method stubs.
       
 24954         (WebCore::aliasCursor):
       
 24955         (WebCore::progressCursor):
       
 24956         (WebCore::noDropCursor):
       
 24957 
       
 24958 2006-11-17  Anders Carlsson  <acarlsson@apple.com>
       
 24959 
       
 24960         Reviewed by Adam.
       
 24961 
       
 24962         Add #defines in config.h to prevent the min and max macros from being used.
       
 24963 
       
 24964         * bridge/win/FrameWin.cpp:
       
 24965         * config.h:
       
 24966         * platform/win/FontCacheWin.cpp:
       
 24967         (WebCore::FontCache::createFontPlatformData):
       
 24968         * platform/win/PopupMenuWin.cpp:
       
 24969         * plugins/win/PluginStreamWin.cpp:
       
 24970         * plugins/win/PluginViewWin.cpp:
       
 24971         (WebCore::PluginViewWin::handlePost):
       
 24972 
       
 24973 2006-11-17  Kevin McCullough  <kmccullough@apple.com>
       
 24974 
       
 24975         Reviewed by Adam.
       
 24976 
       
 24977         - Fixes Targetted Form Submission to now work. Radar: 4762693
       
 24978 
       
 24979         * ChangeLog:
       
 24980         * loader/win/FrameLoaderWin.cpp:
       
 24981         (WebCore::FrameLoader::submitForm):
       
 24982 
       
 24983 2006-11-16  Adele Peterson  <adele@apple.com>
       
 24984 
       
 24985         Reviewed by Adam.
       
 24986 
       
 24987         Added theme for sider.
       
 24988 
       
 24989         * rendering/RenderThemeWin.cpp:
       
 24990         (WebCore::RenderThemeWin::sliderTheme):
       
 24991         (WebCore::RenderThemeWin::close):
       
 24992         (WebCore::RenderThemeWin::determineSliderThumbState):
       
 24993         (WebCore::RenderThemeWin::getClassicThemeData):
       
 24994         (WebCore::RenderThemeWin::getThemeData):
       
 24995         (WebCore::drawControl):
       
 24996         (WebCore::RenderThemeWin::paintSliderTrack):
       
 24997         (WebCore::RenderThemeWin::paintSliderThumb):
       
 24998         (WebCore::RenderThemeWin::adjustSliderThumbSize):
       
 24999         * rendering/RenderThemeWin.h:
       
 25000 
       
 25001 2006-11-15  Adam Roben  <aroben@apple.com>
       
 25002 
       
 25003         Reviewed by Anders.
       
 25004 
       
 25005         Added new ContextMenuClient and ContextMenuController classes.
       
 25006 
       
 25007         * WebCore.vcproj/WebCore.vcproj: Added new files.
       
 25008         * platform/win/ContextMenuWin.cpp: Added method implementations Beth
       
 25009         forgot to check in in r11129.
       
 25010         (WebCore::ContextMenu::itemCount):
       
 25011         (WebCore::ContextMenu::appendItem):
       
 25012 
       
 25013 2006-11-15  Geoffrey Garen  <ggaren@apple.com>
       
 25014 
       
 25015         Reviewed by Anders Carlsson.
       
 25016         
       
 25017         Fixed flash of plug-in content outside its containing iframe while 
       
 25018         scrolling the iframe.
       
 25019         
       
 25020         The problem was that the plug-in would draw between our call to MoveWindow
       
 25021         and our call to SetWindowRgn. The solution here is to lock all updates in 
       
 25022         the plug-in's HWND until we've called both MoveWindow and SetWindowRgn.
       
 25023         
       
 25024         Tested with Quicktime and Flash.
       
 25025         
       
 25026         * plugins/win/PluginViewWin.cpp:
       
 25027         (WebCore::PluginViewWin::updateHwnd):
       
 25028         (WebCore::PluginViewWin::setFrameGeometry):
       
 25029         (WebCore::PluginViewWin::geometryChanged):
       
 25030         * plugins/win/PluginViewWin.h: Removed bogus invalidate parameter to updateHwnd.
       
 25031 
       
 25032 2006-11-15  Adele Peterson  <adele@apple.com>
       
 25033 
       
 25034         Reviewed by Adam.
       
 25035 
       
 25036         Adding RenderSlider class, and removing DeprecatedSlider and Slider classes.
       
 25037 
       
 25038         * WebCore.vcproj/WebCore.vcproj:
       
 25039         * platform/win/TemporaryLinkStubs.cpp:
       
 25040 
       
 25041 2006-11-15  Beth Dakin  <bdakin@apple.com>
       
 25042         &   Adam Roben  <aroben@apple.com>
       
 25043 
       
 25044         Reviewed by Adam and Beth.
       
 25045 
       
 25046         Internal side of r17796.
       
 25047 
       
 25048         * WebCore.vcproj/WebCore.vcproj:
       
 25049         * platform/win/ContextMenuWin.cpp: Added.
       
 25050         (WebCore::ContextMenu::insertItem):
       
 25051         (WebCore::ContextMenu::setPlatformMenuDescription):
       
 25052 
       
 25053 2006-11-15  Anders Carlsson  <acarlsson@apple.com>
       
 25054 
       
 25055         Reviewed by Darin.
       
 25056     
       
 25057         Remove some (now) obsolete methods.
       
 25058         
       
 25059         * bridge/win/FrameWin.h:
       
 25060         * platform/win/TemporaryLinkStubs.cpp:
       
 25061         (FrameWin::unfocusWindow):
       
 25062         (FrameWin::getAppletInstanceForWidget):
       
 25063         (FrameWin::issuePasteCommand):
       
 25064         (FrameWin::respondToChangedSelection):
       
 25065 
       
 25066 2006-11-15  Steve Falkenburg  <sfalken@apple.com>
       
 25067 
       
 25068         Remove header from vcproj that no longer exists
       
 25069 
       
 25070         * WebCore.vcproj/WebCore.vcproj:
       
 25071 
       
 25072 2006-11-15  Steve Falkenburg  <sfalken@apple.com>
       
 25073 
       
 25074         Fix the B&I build
       
 25075 
       
 25076         * WebCore.vcproj/WebCore.vcproj:
       
 25077 
       
 25078 2006-11-14  Darin Adler  <darin@apple.com>
       
 25079 
       
 25080         Reviewed by Anders.
       
 25081 
       
 25082         - update for creation of EventHandler
       
 25083 
       
 25084         * WebCore.vcproj/WebCore.vcproj: Added EventHandler.cpp/h/Win.cpp.
       
 25085 
       
 25086         * bridge/win/FrameWin.h: Moved virtual functions lastEventIsMouseUp,
       
 25087         tabsToLinks, and tabsToAllControls to EventHandler.
       
 25088         * bridge/win/FrameWin.cpp: Ditto.
       
 25089 
       
 25090         * bridge/win/FrameViewWin.cpp: Moved passMousePressEventToSubframe and similar
       
 25091         functions to EventHandler.
       
 25092 
       
 25093         * page/win/EventHandlerWin.cpp: Added. Code from FrameViewWin and FrameWin.
       
 25094 
       
 25095         * platform/win/PlatformScrollBarWin.cpp:
       
 25096         (WebCore::PlatformScrollbar::handleMouseReleaseEvent): Call the setMousePressed
       
 25097         function in its new home in EventHandler.
       
 25098 
       
 25099         * platform/win/TemporaryLinkStubs.cpp: Moved lastEventIsMouseUp stub to EventHandler.
       
 25100 
       
 25101 2006-11-13  Brady Eidson  <beidson@apple.com>
       
 25102 
       
 25103         Rubberstamped by Maciej
       
 25104 
       
 25105         Windows half of 17755 - Make FormData shared
       
 25106 
       
 25107         * bridge/win/FrameWin.h:
       
 25108         * loader/win/FrameLoaderWin.cpp:
       
 25109         (WebCore::FrameLoader::submitForm):
       
 25110         * plugins/win/PluginViewWin.cpp:
       
 25111         (WebCore::PluginViewWin::handlePost):
       
 25112 
       
 25113 2006-11-13  Anders Carlsson  <acarlsson@apple.com>
       
 25114 
       
 25115         Reviewed by Adam.
       
 25116 
       
 25117         * platform/win/PopupMenuWin.cpp:
       
 25118         (WebCore::PopupWndProc):
       
 25119         Make sure to call valueChanged after hiding the popup so that change events will 
       
 25120         be delivered correctly.
       
 25121 
       
 25122 2006-11-13  Steve Falkenburg  <sfalken@apple.com>
       
 25123 
       
 25124         Reviewed by Anders, Lou.
       
 25125 
       
 25126         Fix merge script
       
 25127 
       
 25128         * WebCore.vcproj/merge-opensource.sh: Don't copy cairo, pixman
       
 25129 
       
 25130 2006-11-12  Geoffrey Garen  <ggaren@apple.com>
       
 25131 
       
 25132         Reviewed by Beth Dakin.
       
 25133         
       
 25134         Added project-wide setting to disable Microsoft's made-up deprecation 
       
 25135         warnings related to std:: functions. (Doesn't have any affect yet,
       
 25136         since we currently disable all deprecation warnings.)
       
 25137 
       
 25138         * WebCore.vcproj/WebCore.vcproj:
       
 25139 
       
 25140 2006-11-11  Anders Carlsson  <acarlsson@apple.com>
       
 25141 
       
 25142         Reviewed by Oliver.
       
 25143 
       
 25144         Rename keyPress to keyEvent, it's used for both key presses
       
 25145         and releases.
       
 25146         
       
 25147         * bridge/win/FrameWin.cpp:
       
 25148         (WebCore::FrameWin::keyEvent):
       
 25149         * bridge/win/FrameWin.h:
       
 25150 
       
 25151 2006-11-11  Adam Roben  <aroben@apple.com>
       
 25152 
       
 25153         Reviewed by Geoff.
       
 25154 
       
 25155         Move graphics-related files to platform/graphics to stay in sync with
       
 25156         changes from OpenSource r17727.
       
 25157 
       
 25158         Also, as discussed with Darin and Steve, we now copy all our headers to
       
 25159         a flat include/WebCore directory instead of copying the directory
       
 25160         structure of WebCore. This mirrors how Mac builds.
       
 25161 
       
 25162         * WebCore.vcproj/WebCore.vcproj:
       
 25163         * platform/cg/ColorCG.cpp: Removed.
       
 25164         * platform/cg/GraphicsContextCG.cpp: Removed.
       
 25165         * platform/cg/GraphicsContextPlatformPrivate.h: Removed.
       
 25166         * platform/win/IconWin.cpp: Removed.
       
 25167         * platform/win/ImageWin.cpp: Removed.
       
 25168 
       
 25169 2006-11-11  Darin Adler  <darin@apple.com>
       
 25170 
       
 25171         - blind attempt to fix the build
       
 25172 
       
 25173         * platform/win/CursorWin.cpp:
       
 25174         (WebCore::verticalTextCursor): Added. Just returns the pointer cursor.
       
 25175         (WebCore::cellCursor): Ditto.
       
 25176         (WebCore::contextMenuCursor): Ditto.
       
 25177 
       
 25178 2006-11-10  Steve Falkenburg  <sfalken@apple.com>
       
 25179 
       
 25180         Build fix for opensource/internal merge script.
       
 25181 
       
 25182         * WebCore.vcproj/WebCore.vcproj:
       
 25183 
       
 25184 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
       
 25185 
       
 25186         Reviewed by Oliver.
       
 25187 
       
 25188         Implement findNextWordFromIndex using ICU.
       
 25189 
       
 25190         * platform/win/TemporaryLinkStubs.cpp:
       
 25191         (WebCore::findSentenceBoundary):
       
 25192         * platform/win/TextBoundariesWin.cpp:
       
 25193         (WebCore::findNextWordFromIndex):
       
 25194 
       
 25195 2006-11-09  Oliver Hunt  <oliver@apple.com>
       
 25196 
       
 25197         Reviewed by Brady.
       
 25198 
       
 25199         Added Windows side of MIME Type registry, and updated 
       
 25200         objectContentType and ImageWin to make use of it
       
 25201         
       
 25202         This fixes <rdar://problem/4791483> 
       
 25203 
       
 25204         * WebCore.vcproj/WebCore.vcproj:
       
 25205         * loader/win/FrameLoaderWin.cpp:
       
 25206         (WebCore::FrameLoader::objectContentType):
       
 25207         * platform/win/ImageWin.cpp:
       
 25208         * platform/win/MimeTypeRegistryWin.cpp: Added.
       
 25209         (WebCore::getMIMETypeForUTI):
       
 25210         (WebCore::mimeTypeForExtension):
       
 25211         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
       
 25212 
       
 25213 2006-11-09  Lou Amadio  <lamadio@apple.com>
       
 25214 
       
 25215         Reviewed by mjs
       
 25216         Corrected positioning of text for find overlay on subframes
       
 25217 
       
 25218         * bridge/win/FrameWin.cpp:
       
 25219         (WebCore::FrameWin::imageFromRect):
       
 25220 
       
 25221 2006-11-08  Lou Amadio  <lamadio@apple.com>
       
 25222 
       
 25223         Reviewed by ggaren
       
 25224 
       
 25225         Moved CookieJar to OpenSourceWin
       
 25226         Ported CookieJar to CFNetwork
       
 25227         Corrected an uninitialized variable which crashed on Vista in the Wininet code
       
 25228 
       
 25229         * WebCore.vcproj/WebCore.vcproj:
       
 25230         * platform/network/win/CookieJarWin.cpp:
       
 25231         (WebCore::setCookies):
       
 25232         (WebCore::cookies):
       
 25233 
       
 25234 2006-11-08  Maciej Stachowiak  <mjs@apple.com>
       
 25235 
       
 25236         Reviewed by Geoff.
       
 25237 
       
 25238         - added ResourceError class and didFailWithError client method
       
 25239         
       
 25240         * plugins/win/PluginStreamWin.cpp:
       
 25241         (WebCore::PluginStreamWin::didFailLoadingWithError):
       
 25242         (WebCore::PluginStreamWin::didFinishLoading):
       
 25243         * plugins/win/PluginStreamWin.h:
       
 25244 
       
 25245 2006-11-08  Geoffrey Garen  <ggaren@apple.com>
       
 25246 
       
 25247         Reviewed by Anders Carlsson.
       
 25248 
       
 25249         Updated Windows to use the new platform abstraction for Screen.
       
 25250         
       
 25251         * WebCore.vcproj/WebCore.vcproj:
       
 25252         * platform/win/PopupMenuWin.cpp:
       
 25253         (WebCore::PopupMenu::calculatePositionAndSize):
       
 25254         * platform/win/ScreenWin.cpp:
       
 25255         (WebCore::monitorInfoForWidget):
       
 25256         (WebCore::deviceInfoForWidget):
       
 25257         (WebCore::screenDepth):
       
 25258         (WebCore::screenDepthPerComponent):
       
 25259         (WebCore::screenIsMonochrome):
       
 25260         (WebCore::screenRect):
       
 25261         (WebCore::screenAvailableRect):
       
 25262 
       
 25263 2006-11-09  Darin Adler  <darin@apple.com>
       
 25264 
       
 25265         - fix the build
       
 25266 
       
 25267         * bridge/win/FrameWin.h: Add a forward declaration of FormData.
       
 25268 
       
 25269         * bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyPress):
       
 25270         Call resetMultipleFormSubmissionProtection instead of prepareForUserAction.
       
 25271 
       
 25272         * platform/win/TemporaryLinkStubs.cpp: Remove the parameter from the
       
 25273         TextField constructor.
       
 25274 
       
 25275 2006-11-08  Steve Falkenburg  <sfalken@apple.com>
       
 25276 
       
 25277         Rubber stamped by Adam.
       
 25278 
       
 25279         Windows buildbot fix.
       
 25280         Remove /d from xcopy commands that merge opensource/internal components.
       
 25281         Sync debug and release post-build event.
       
 25282 
       
 25283         * WebCore.vcproj/WebCore.vcproj:
       
 25284 
       
 25285 2006-11-07  Ada Chan  <adachan@apple.com>
       
 25286 
       
 25287         Reviewed by Steve.
       
 25288 
       
 25289         Make the Slider implementation call LOG_NOIMPL() instead of STOP_NOIMPL() so the RSS feed page can load.
       
 25290 
       
 25291         * platform/win/TemporaryLinkStubs.cpp:
       
 25292         (Slider::Slider):
       
 25293         (Slider::sizeHint):
       
 25294         (Slider::setValue):
       
 25295         (Slider::setMaxValue):
       
 25296         (Slider::setMinValue):
       
 25297         (Slider::~Slider):
       
 25298         (Slider::setFont):
       
 25299         (Slider::value):
       
 25300 
       
 25301 2006-11-07  Lou Amadio  <lamadio@apple.com>
       
 25302 
       
 25303         Reviewed by sfalken, adam
       
 25304 
       
 25305          Implemented Find banner, overlay, bouncy.
       
 25306          plummed some find, search and marking in WebCore & WebKit
       
 25307          Added SDC - a DC wrapper with knowledge of CG
       
 25308          Added button element
       
 25309          Ported AppKit's oval button drawing code
       
 25310          Abstracted the high performance animations
       
 25311 
       
 25312         * bridge/win/FrameWin.cpp:
       
 25313         (WebCore::FrameWin::imageFromRect):
       
 25314         (WebCore::FrameWin::imageFromSelection):
       
 25315         * bridge/win/FrameWin.h:
       
 25316         * platform/win/GraphicsContextWin.cpp:
       
 25317         (WebCore::GraphicsContext::setCompositeOperation):
       
 25318         * platform/win/TemporaryLinkStubs.cpp:
       
 25319         (Frame::setNeedsReapplyStyles):
       
 25320 
       
 25321 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
       
 25322 
       
 25323         Build fixes.
       
 25324         
       
 25325         * WebCore.vcproj/WebCore.vcproj:
       
 25326         * platform/win/TemporaryLinkStubs.cpp:
       
 25327 
       
 25328 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
       
 25329 
       
 25330         * loader/win/FrameLoaderWin.cpp:
       
 25331         (WebCore::FrameLoader::partClearedInBegin):
       
 25332         Use m_frame instead of this, include the correct files.
       
 25333         
       
 25334 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
       
 25335 
       
 25336         (I'm not doing this to get commit 11000)
       
 25337         
       
 25338         * loader/win/FrameLoaderWin.cpp:
       
 25339         (WebCore::FrameLoader::partClearedInBegin):
       
 25340         It's m_frame, not frame. 
       
 25341         
       
 25342 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
       
 25343 
       
 25344         It's FrameLoader, not FrameWin.
       
 25345         
       
 25346         * loader/win/FrameLoaderWin.cpp:
       
 25347         (WebCore::FrameLoader::partClearedInBegin):
       
 25348 
       
 25349 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
       
 25350 
       
 25351         A blind attempt at fixing the build.
       
 25352         
       
 25353         * bridge/win/FrameWin.cpp:
       
 25354         * loader/win/FrameLoaderWin.cpp:
       
 25355         (WebCore::FrameWin::partClearedInBegin):
       
 25356         * platform/win/TemporaryLinkStubs.cpp:
       
 25357         (FrameLoader::restoreDocumentState):
       
 25358 
       
 25359 2006-11-07  Geoffrey Garen  <ggaren@apple.com>
       
 25360 
       
 25361         Reviewed by Anders.
       
 25362         
       
 25363         Removed ScreenClient. It was highly unpopular, risking my midterm re-election.
       
 25364         
       
 25365         None of Screen's responsibilities require up-calls to WebKit or delegates, 
       
 25366         so WebCore can handle it all.
       
 25367         
       
 25368         Moved Screen back from page/ to platform/ because it's a platform
       
 25369         abstraction again.
       
 25370         
       
 25371         Fixed bug where Screen would query the default screen instead of the screen
       
 25372         on which the active window was located. (The code is written in Klingon,
       
 25373         but that's cool.)
       
 25374         
       
 25375         Implemented some missing screen functionality on Win.
       
 25376         
       
 25377         I can't fully verify this code because I can't load files without crashing
       
 25378         in CFNetwork, but I exercised most of it with javascript: URLs and the
       
 25379         debugger reported reasonable values.
       
 25380 
       
 25381         * WebCore.vcproj/WebCore.vcproj:
       
 25382         * platform/win/ScreenWin.cpp: Added. Merged over from opensource tree.
       
 25383         (WebCore::getWindow):
       
 25384         (WebCore::getMonitorInfo):
       
 25385         (WebCore::getDeviceInfo):
       
 25386         (WebCore::Screen::depth):
       
 25387         (WebCore::Screen::depthPerComponent):
       
 25388         (WebCore::Screen::isMonochrome):
       
 25389         (WebCore::Screen::rect):
       
 25390         (WebCore::Screen::usableRect):
       
 25391 
       
 25392 2006-11-07  Darin Adler  <darin@apple.com>
       
 25393 
       
 25394         Reviewed by Geoff.
       
 25395 
       
 25396         - moved loader code from Frame/FrameMac to FrameLoader
       
 25397 
       
 25398         * WebCore.vcproj/WebCore.vcproj:
       
 25399         * bridge/win/FrameWin.cpp:
       
 25400         (WebCore::FrameWin::FrameWin):
       
 25401         (WebCore::FrameWin::~FrameWin):
       
 25402         * bridge/win/FrameWin.h:
       
 25403         * loader/win/FrameLoaderWin.cpp: Added.
       
 25404         (WebCore::FrameLoader::submitForm):
       
 25405         (WebCore::FrameLoader::urlSelected):
       
 25406         (WebCore::FrameLoader::originalRequestURL):
       
 25407         (WebCore::FrameLoader::didFirstLayout):
       
 25408         (WebCore::FrameLoader::objectContentType):
       
 25409         (WebCore::FrameLoader::createPlugin):
       
 25410         (WebCore::FrameLoader::createFrame):
       
 25411         (WebCore::FrameLoader::detachFromParent):
       
 25412         (WebCore::FrameLoader::createJavaAppletWidget):
       
 25413         (WebCore::FrameLoader::setTitle):
       
 25414         * platform/win/TemporaryLinkStubs.cpp:
       
 25415         (FrameWin::markMisspellings):
       
 25416         (FrameWin::respondToChangedSelection):
       
 25417         (FrameWin::clearUndoRedoOperations):
       
 25418         (IconLoader::notifyIconChanged):
       
 25419         (PolicyCheck::PolicyCheck):
       
 25420         (PolicyCheck::clear):
       
 25421         (PolicyCheck::call):
       
 25422         (PolicyCheck::clearRequest):
       
 25423         (FrameLoader::saveDocumentState):
       
 25424         (FrameLoader::restoreDocumentState):
       
 25425         (FrameLoader::partClearedInBegin):
       
 25426         (FrameLoader::goBackOrForward):
       
 25427         (FrameLoader::historyURL):
       
 25428         (FrameLoader::canGoBackOrForward):
       
 25429         (FrameLoader::getHistoryLength):
       
 25430         (DocumentLoader::setupForReplaceByMIMEType):
       
 25431         (ResourceLoader::cancel):
       
 25432         (DocumentLoader::stopLoading):
       
 25433         (DocumentLoader::setLoading):
       
 25434         (DocumentLoader::updateLoading):
       
 25435         (DocumentLoader::setFrame):
       
 25436         (DocumentLoader::stopRecordingResponses):
       
 25437         (DocumentLoader::isStopping):
       
 25438         (DocumentLoader::setPrimaryLoadComplete):
       
 25439         (DocumentLoader::finishedLoading):
       
 25440         (DocumentLoader::URL):
       
 25441         (DocumentLoader::isLoadingInAPISense):
       
 25442         (DocumentLoader::frameLoader):
       
 25443         (FrameLoader::overrideMediaType):
       
 25444         (FrameLoader::redirectDataToPlugin):
       
 25445         (FrameLoader::checkLoadCompleteForThisFrame):
       
 25446         (FrameLoader::loadEmptyDocumentSynchronously):
       
 25447         (FrameLoader::startLoading):
       
 25448         (FrameLoader::referrer):
       
 25449         * plugins/win/PluginViewWin.cpp:
       
 25450         (WebCore::PluginViewWin::performRequest):
       
 25451         (WebCore::PluginViewWin::userAgent):
       
 25452 
       
 25453 2006-11-07  Anders Carlsson  <acarlsson@apple.com>
       
 25454 
       
 25455         Reviewed by Oliver.
       
 25456 
       
 25457         Let the Frame client know when the window object is available.
       
 25458 
       
 25459         * bridge/win/FrameWin.cpp:
       
 25460         (WebCore::FrameWin::partClearedInBegin):
       
 25461         * bridge/win/FrameWin.h:
       
 25462         * platform/win/TemporaryLinkStubs.cpp:
       
 25463         (FrameWin::unfocusWindow):
       
 25464         (FrameWin::markMisspellings):
       
 25465         (FrameWin::restoreDocumentState):
       
 25466 
       
 25467 2006-11-07  Adam Roben  <aroben@apple.com>
       
 25468 
       
 25469         Build fix.
       
 25470 
       
 25471         * platform/win/TemporaryLinkStubs.cpp: Remove no-longer-needed stub.
       
 25472 
       
 25473 2006-11-07  Steve Falkenburg  <sfalken@apple.com>
       
 25474 
       
 25475         Fixes for B&I submission
       
 25476 
       
 25477         * WebCore.vcproj/WebCore.vcproj:
       
 25478         * WebCore.vcproj/merge-opensource.sh:
       
 25479 
       
 25480 2006-11-06  Kevin McCullough  <kmccullough@apple.com>
       
 25481 
       
 25482         -Fix test fields accepting text.
       
 25483 
       
 25484         * WebCore.vcproj/WebCore.vcproj:
       
 25485 
       
 25486 2006-11-06  Anders Carlsson  <acarlsson@apple.com>
       
 25487 
       
 25488         Reviewed by Dave Hyatt.
       
 25489 
       
 25490         <rdar://problem/4778180>
       
 25491         wikipedia.org crashes when loading
       
 25492         
       
 25493         * platform/win/GlyphMapWin.cpp:
       
 25494         (WebCore::GlyphMap::fillPage):
       
 25495         Don't call GetGlyphIndices on buffers larger than the page size. GetGlyphIndicies doesn't know anything about
       
 25496         Unicode supplementary characters and will overwrite the local buffer if the passed-in buffer is bigger than  the page size.
       
 25497 
       
 25498 2006-11-06  Anders Carlsson  <acarlsson@apple.com>
       
 25499 
       
 25500         Fork GlyphMapWin.cpp
       
 25501         
       
 25502         * platform/win/GlyphMapWin.cpp: Added.
       
 25503         (WebCore::GlyphMap::fillPage):
       
 25504 
       
 25505 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
       
 25506 
       
 25507         Reviewed by Darin.
       
 25508 
       
 25509         Hooked up the Chrome and Screen clients on Windows.
       
 25510         
       
 25511         * WebCore.vcproj/WebCore.vcproj:
       
 25512         * bridge/win/PageWin.cpp:
       
 25513         * platform/win/PopupMenuWin.cpp:
       
 25514         (WebCore::PopupMenu::calculatePositionAndSize):
       
 25515         * platform/win/TemporaryLinkStubs.cpp:
       
 25516 
       
 25517 2006-11-06  Anders Carlsson  <acarlsson@apple.com>
       
 25518 
       
 25519         Reviewed by Maciej.
       
 25520 
       
 25521         Copy npfunctions.h to WebKitOutputDir.
       
 25522         
       
 25523         * WebCore.vcproj/WebCore.vcproj:
       
 25524 
       
 25525 2006-11-06  Steve Falkenburg  <sfalken@apple.com>
       
 25526 
       
 25527         Fix double-include of FormData.cpp/.h.
       
 25528 
       
 25529         * WebCore.vcproj/WebCore.vcproj:
       
 25530 
       
 25531 2006-11-06  Maciej Stachowiak  <mjs@apple.com>
       
 25532         
       
 25533         - build fixes, adjusted for file move
       
 25534 
       
 25535         * WebCore.vcproj/WebCore.vcproj:
       
 25536 
       
 25537 2006-11-05  Beth Dakin  <bdakin@apple.com>
       
 25538 
       
 25539         Reviewed by Steve and Anders.
       
 25540 
       
 25541         Add client() fucntion to FrameWin to return the FrameClient.
       
 25542 
       
 25543         * bridge/win/FrameWin.h:
       
 25544         (WebCore::FrameWin::client):
       
 25545 
       
 25546 2006-11-05  Steve Falkenburg  <sfalken@apple.com>
       
 25547 
       
 25548         Fix build
       
 25549 
       
 25550         * WebCore.vcproj/WebCore.vcproj:
       
 25551 
       
 25552 2006-11-05  Steve Falkenburg  <sfalken@apple.com>
       
 25553 
       
 25554         Fix build breaks
       
 25555 
       
 25556         * bridge/win/FrameWin.cpp:
       
 25557         * bridge/win/PageWin.cpp:
       
 25558 
       
 25559 2006-11-04  Darin Adler  <darin@apple.com>
       
 25560 
       
 25561         Reviewed by Maciej.
       
 25562 
       
 25563         * bridge/win/FrameWin.h:
       
 25564         * bridge/win/FrameWin.cpp:
       
 25565         (WebCore::FrameWin::urlSelected): Updated for change of const Event* to Event*.
       
 25566         (WebCore::FrameWin::submitForm): Added Event* parameter.
       
 25567 
       
 25568 2006-11-03  Maciej Stachowiak  <mjs@apple.com>
       
 25569 
       
 25570         Reviewed by Adele.
       
 25571 
       
 25572         - replaced receivedRedirect with new willSendRequest delegate
       
 25573         - removed most mac-specific loader functions
       
 25574         - use ResourceResponse more in loader code
       
 25575 
       
 25576         * WebCore.vcproj/WebCore.vcproj: Added new files
       
 25577         * platform/win/TemporaryLinkStubs.cpp: Removed unneeded link stubs
       
 25578 
       
 25579 2006-11-03  Steve Falkenburg  <sfalken@apple.com>
       
 25580 
       
 25581         Fix build
       
 25582 
       
 25583         * config.h: Touched to cause re-build w/ SVG_SUPPORT enabled
       
 25584         * platform/win/TemporaryLinkStubs.cpp:
       
 25585         (WebCore::CachedResource::setResponse): Added
       
 25586 
       
 25587 2006-11-03  Adele Peterson  <adele@apple.com>
       
 25588 
       
 25589         Reviewed by Oliver.
       
 25590 
       
 25591         Removed DeprecatedRenderSelect and ListBox classes.
       
 25592 
       
 25593         * WebCore.vcproj/WebCore.vcproj:
       
 25594         * platform/win/TemporaryLinkStubs.cpp:
       
 25595 
       
 25596 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
       
 25597 
       
 25598         Remove SVGRenderAsText files from the project.
       
 25599         
       
 25600         * WebCore.vcproj/WebCore.vcproj:
       
 25601 
       
 25602 2006-11-03  Anders Carlsson  <acarlsson@apple.com>
       
 25603 
       
 25604         Build fix.
       
 25605         
       
 25606         * platform/win/TemporaryLinkStubs.cpp:
       
 25607         (WebCore::CachedResource::setPlatformResponse):
       
 25608 
       
 25609 2006-11-03  Geoffrey Garen  <ggaren@apple.com>
       
 25610 
       
 25611         Reviewed by Darin, Beth.
       
 25612 
       
 25613         Updated to use ChromeClient.
       
 25614         
       
 25615         * WebCore.vcproj/WebCore.vcproj:
       
 25616         * bridge/win/PageWin.cpp:
       
 25617         * loader/win/ResourceLoaderWin.cpp: Added.
       
 25618         (WebCore::ResourceLoader::loadsBlocked):
       
 25619         * platform/win/TemporaryLinkStubs.cpp:
       
 25620 
       
 25621 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
       
 25622 
       
 25623         Reviewed by Oliver.
       
 25624 
       
 25625         * WebCore.vcproj/WebCore.vcproj:
       
 25626         Use the forked CursorWin.cpp
       
 25627         
       
 25628         * platform/win/CursorWin.cpp:
       
 25629         (WebCore::moveCursor):
       
 25630         Implement this.
       
 25631         
       
 25632         * platform/win/TemporaryLinkStubs.cpp:
       
 25633         Get rid of it here.
       
 25634         
       
 25635 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
       
 25636 
       
 25637         Reviewed by Oliver.
       
 25638 
       
 25639         Add forked copy of CursorWin.cpp
       
 25640         
       
 25641         * platform/win/CursorWin.cpp: Added.
       
 25642 
       
 25643 2006-11-01  Oliver Hunt  <oliver@apple.com>
       
 25644 
       
 25645         Reviewed by Adam.
       
 25646 
       
 25647         Adding SVG_SUPPORT to Boomer.
       
 25648 
       
 25649         * WebCore.vcproj/WebCore.vcproj:
       
 25650         * WebCore.vcproj/build-generated-files.sh:
       
 25651         * kcanvas/device/quartz/KCanvasFilterQuartz.cpp: Added.
       
 25652         (WebCore::KCanvasFilterQuartz::KCanvasFilterQuartz):
       
 25653         (WebCore::KCanvasFilterQuartz::~KCanvasFilterQuartz):
       
 25654         (WebCore::KCanvasFilterQuartz::prepareFilter):
       
 25655         (WebCore::KCanvasFilterQuartz::applyFilter):
       
 25656         (WebCore::KCanvasFilterQuartz::imageForName):
       
 25657         (WebCore::KCanvasFilterQuartz::setImageForName):
       
 25658         (WebCore::KCanvasFilterQuartz::setOutputImage):
       
 25659         (WebCore::KCanvasFilterQuartz::inputImage):
       
 25660         * platform/graphics/svg/cg/SVGResourceMaskerCg.cpp: Added.
       
 25661         (WebCore::SVGResourceMasker::applyMask):
       
 25662 
       
 25663 2006-11-01  Beth Dakin  <bdakin@apple.com>
       
 25664 
       
 25665         Reviewed by Adam.
       
 25666 
       
 25667         Build fix from Sam Weinig's check-in. i.p in the PaintInfo is now 
       
 25668         i.context
       
 25669 
       
 25670         * rendering/RenderThemeWin.cpp:
       
 25671         (WebCore::RenderThemeWin::paintButton):
       
 25672         (WebCore::RenderThemeWin::paintTextField):
       
 25673         (WebCore::RenderThemeWin::paintMenuList):
       
 25674         (WebCore::RenderThemeWin::paintMenuListButton):
       
 25675 
       
 25676 2006-11-01  Anders Carlsson  <acarlsson@apple.com>
       
 25677 
       
 25678         Reviewed by Geoff.
       
 25679 
       
 25680         * bridge/win/FrameWin.cpp:
       
 25681         (WebCore::FrameWin::createJavaAppletWidget):
       
 25682         Ask the plugin database to create a java applet plugin.
       
 25683 
       
 25684         * platform/win/TemporaryLinkStubs.cpp:
       
 25685         Remove FrameWin::createJavaAppletWidget.
       
 25686         
       
 25687         * plugins/win/PluginDatabaseWin.cpp:
       
 25688         (WebCore::PluginDatabaseWin::defaultPluginPaths):
       
 25689         Don't look for the Sun Java plugin anymore.
       
 25690 
       
 25691 2006-11-01  Anders Carlsson  <acarlsson@apple.com>
       
 25692 
       
 25693         * plugins/win/PluginStreamWin.cpp:
       
 25694         (WebCore::PluginStreamWin::startStream):
       
 25695         Build fix.
       
 25696         
       
 25697 2006-11-01  Anders Carlsson  <acarlsson@apple.com>
       
 25698 
       
 25699         Reviewed by Adam.
       
 25700 
       
 25701         Convert plugin code over to using ResourceResponse.
       
 25702         
       
 25703         * plugins/win/PluginStreamWin.cpp:
       
 25704         (WebCore::PluginStreamWin::startStream):
       
 25705         (WebCore::PluginStreamWin::didReceiveResponse):
       
 25706         (WebCore::PluginStreamWin::didFinishLoading):
       
 25707         * plugins/win/PluginStreamWin.h:
       
 25708         * plugins/win/PluginViewWin.cpp:
       
 25709         (WebCore::PluginViewWin::performRequest):
       
 25710 
       
 25711 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
       
 25712 
       
 25713         Yet more B&I build fixes
       
 25714         Another missing .h file from the vcproj
       
 25715 
       
 25716         * WebCore.vcproj/WebCore.vcproj:
       
 25717 
       
 25718 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
       
 25719 
       
 25720         Another fix for B&I submission
       
 25721         (missing .h files from the WebCore vcproj prevents proper merging of OpenSource/Internal WebCore trees)
       
 25722 
       
 25723         * WebCore.vcproj/WebCore.vcproj:
       
 25724 
       
 25725 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
       
 25726 
       
 25727         Remove extra files I accidently added
       
 25728 
       
 25729         * WebCore.vcproj/WebCore.vcproj:
       
 25730 
       
 25731 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
       
 25732 
       
 25733         Build fixes for submission merge script
       
 25734 
       
 25735         * WebCore.vcproj/WebCore.vcproj:
       
 25736 
       
 25737 2006-10-31  Adam Roben  <aroben@apple.com>
       
 25738 
       
 25739         Build fixes.
       
 25740 
       
 25741         * WebCore.vcproj/WebCore.vcproj: Add new platform/graphics directory to
       
 25742         our include path, and copy headers from there for WebKit's benefit.
       
 25743         * bridge/win/FrameWin.cpp: Update accessors of FrameLoadRequest.
       
 25744         (WebCore::FrameWin::urlSelected):
       
 25745         (WebCore::FrameWin::submitForm):
       
 25746         * plugins/win/PluginViewWin.cpp: Ditto.
       
 25747         (WebCore::PluginViewWin::start):
       
 25748         (WebCore::PluginViewWin::performRequest):
       
 25749         (WebCore::PluginViewWin::load):
       
 25750         (WebCore::PluginViewWin::getURLNotify):
       
 25751         (WebCore::PluginViewWin::getURL):
       
 25752         (WebCore::PluginViewWin::handlePost):
       
 25753         * plugins/win/PluginViewWin.h: Correct forward declaration of
       
 25754         FrameLoadRequest.
       
 25755 
       
 25756 2006-10-30  Darin Adler  <darin@apple.com>
       
 25757 
       
 25758         Reviewed by Anders.
       
 25759 
       
 25760         - remove BrowserExtension
       
 25761 
       
 25762         * WebCore.vcproj/WebCore.vcproj:
       
 25763         * bridge/win/FrameWin.cpp:
       
 25764         (WebCore::FrameWin::FrameWin):
       
 25765         * platform/win/TemporaryLinkStubs.cpp:
       
 25766         * plugins/win/PluginViewWin.cpp:
       
 25767         (WebCore::PluginViewWin::performRequest):
       
 25768 
       
 25769 2006-10-30  Anders Carlsson  <acarlsson@apple.com>
       
 25770 
       
 25771         Reviewed by Adam.
       
 25772 
       
 25773         If there's no plug-in for a given mime type, or if the plug-in fails
       
 25774         to initialize, draw the "missing plug-in" icon.
       
 25775 
       
 25776         * plugins/win/PluginDatabaseWin.cpp:
       
 25777         (WebCore::PluginDatabaseWin::createPluginView):
       
 25778         If no plug-in can be found, create a null plugin view.
       
 25779         
       
 25780         * plugins/win/PluginViewWin.cpp:
       
 25781         (WebCore::PluginViewWin::paint):
       
 25782         If the plugin hasn't been started, paint the missing plugin image.
       
 25783         
       
 25784         (WebCore::PluginViewWin::setNPWindowSize):
       
 25785         Return early if the plugin hasn't been started.
       
 25786         
       
 25787         (WebCore::PluginViewWin::start):
       
 25788         Return if the plugin couldn't be created.
       
 25789         
       
 25790         (WebCore::PluginViewWin::createNullPluginView):
       
 25791         New function which just creates a plugin view and doesn't try to start its plugin
       
 25792         (because there is none).
       
 25793         
       
 25794         (WebCore::PluginViewWin::PluginViewWin):
       
 25795         New constructor for the null plugin view.
       
 25796         
       
 25797 2006-10-31  Darin Adler  <darin@apple.com>
       
 25798 
       
 25799         Reviewed by Adam.
       
 25800 
       
 25801         * WebCore.vcproj/WebCore.vcproj: Added new source files from the
       
 25802         loader directory.
       
 25803 
       
 25804 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
       
 25805 
       
 25806         Reviewed by Anders.
       
 25807 
       
 25808         - added ResourceResponse class and didReceiveResponse delegate call
       
 25809 
       
 25810         * WebCore.vcproj/WebCore.vcproj: Added new files.
       
 25811         * platform/win/TemporaryLinkStubs.cpp:
       
 25812         (WebCore::ServeSynchronousRequest): Changed prototype to match
       
 25813         new version.
       
 25814 
       
 25815 2006-10-29  Darin Adler  <darin@apple.com>
       
 25816 
       
 25817         - update for the WebCore renames
       
 25818 
       
 25819         * WebCore.vcproj/WebCore.vcproj:
       
 25820         * bridge/win/FrameWin.cpp:
       
 25821         (WebCore::FrameWin::bindingRootObject):
       
 25822         (WebCore::FrameWin::windowScriptNPObject):
       
 25823         * plugins/win/PluginViewWin.cpp:
       
 25824         (WebCore::PluginViewWin::load):
       
 25825         (WebCore::PluginViewWin::bindingInstance):
       
 25826 
       
 25827 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
       
 25828 
       
 25829         Rubber stamped by Darin.
       
 25830 
       
 25831         - renamed ResourceLoader to ResourceHandle (and same for related classes)
       
 25832 
       
 25833         * WebCore.vcproj/WebCore.vcproj:
       
 25834         * bridge/win/FrameWin.cpp:
       
 25835         * platform/network/win/ResourceHandleWin.cpp: Added.
       
 25836         (WebCore::):
       
 25837         (WebCore::addToOutstandingJobs):
       
 25838         (WebCore::lookupResourceHandle):
       
 25839         (WebCore::ResourceHandleWndProc):
       
 25840         (WebCore::ResourceHandle::onHandleCreated):
       
 25841         (WebCore::ResourceHandle::onRequestRedirected):
       
 25842         (WebCore::ResourceHandle::onRequestComplete):
       
 25843         (WebCore::initializeOffScreenResourceHandleWindow):
       
 25844         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
       
 25845         (WebCore::ResourceHandle::~ResourceHandle):
       
 25846         (WebCore::ResourceHandle::startHTTPRequest):
       
 25847         (WebCore::ResourceHandle::start):
       
 25848         (WebCore::ResourceHandle::fileLoadTimer):
       
 25849         (WebCore::ResourceHandle::cancel):
       
 25850         * platform/network/win/ResourceHandleWin.h: Added.
       
 25851         * platform/network/win/ResourceLoaderWin.cpp: Removed.
       
 25852         * platform/network/win/ResourceLoaderWin.h: Removed.
       
 25853         * platform/win/TemporaryLinkStubs.cpp:
       
 25854         (WebCore::ResourceHandle::assembleResponseHeaders):
       
 25855         (WebCore::ResourceHandle::retrieveResponseEncoding):
       
 25856         (IconLoader::receivedResponse):
       
 25857         * plugins/win/PluginStreamWin.cpp:
       
 25858         (WebCore::PluginStreamWin::start):
       
 25859         (WebCore::PluginStreamWin::deliverData):
       
 25860         (WebCore::PluginStreamWin::receivedResponse):
       
 25861         (WebCore::PluginStreamWin::didReceiveData):
       
 25862         (WebCore::PluginStreamWin::receivedAllData):
       
 25863         * plugins/win/PluginStreamWin.h:
       
 25864 
       
 25865 2006-10-28  Adam Roben  <aroben@apple.com>
       
 25866 
       
 25867         Build fix.
       
 25868 
       
 25869         * WebCore.vcproj/WebCore.vcproj: Adding new HitTestResult.{cpp,h}
       
 25870         files.
       
 25871 
       
 25872 2006-10-27  Anders Carlsson  <acarlsson@apple.com>
       
 25873 
       
 25874         Reviewed by Oliver.
       
 25875 
       
 25876         <rdar://problem/4730678> Plug-ins should be able to open URLs
       
 25877 
       
 25878         * plugins/win/PluginViewWin.cpp:
       
 25879         (WebCore::PluginViewWin::performRequest):
       
 25880 
       
 25881 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
       
 25882 
       
 25883         Reviewed by John Sullivan.
       
 25884 
       
 25885         <rdar://problem/4764502> PluginStreams should cancel their loader jobs on error
       
 25886 
       
 25887         * plugins/win/PluginStreamWin.cpp:
       
 25888         (WebCore::PluginStreamWin::receivedResponse):
       
 25889         (WebCore::PluginStreamWin::didReceiveData):
       
 25890         (WebCore::PluginStreamWin::receivedAllData):
       
 25891         Modify assertions. None of the above functions should be run after aborting the load.
       
 25892 
       
 25893 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
       
 25894 
       
 25895         Reviewed by Adam.
       
 25896 
       
 25897         * plugins/win/PluginDatabaseWin.cpp:
       
 25898         (WebCore::addPluginPath):
       
 25899         (WebCore::PluginDatabaseWin::defaultPluginPaths):
       
 25900         Look for plugins in a plugins directory which is relative to the executable directory.
       
 25901         
       
 25902         (WebCore::PluginDatabaseWin::createPluginView):
       
 25903         Use reverseFind instead of findRev here.
       
 25904         
       
 25905 2006-10-26  Adam Roben  <aroben@apple.com>
       
 25906 
       
 25907         Reviewed by Beth.
       
 25908 
       
 25909         Fix: <rdar://problem/4799084> Text and dropdown button too close
       
 25910         together in <select>s
       
 25911         Fix: <rdar://problem/4800493> Popup menus should be positioned so that
       
 25912         their text is horizontally aligned with the <select> control's text
       
 25913 
       
 25914         * platform/win/PopupMenuWin.cpp:
       
 25915         (WebCore::PopupMenu::calculatePositionAndSize): Switch alignment of LTR
       
 25916         vs. RTL popups, and add padding to align the text.
       
 25917         (WebCore::PopupMenu::paint): Add padding from the <select> control to
       
 25918         align the text with the <select> control's text.
       
 25919         * rendering/RenderThemeWin.cpp: Set svn:eol-style native.
       
 25920         (WebCore::RenderThemeWin::systemFont): Clean up line endings.
       
 25921         (WebCore::RenderThemeWin::adjustMenuListButtonStyle): Add some extra
       
 25922         padding between the dropdown button and text.
       
 25923         (WebCore::RenderThemeWin::paintMenuListButton): Clean up code a bit.
       
 25924 
       
 25925 2006-10-26  Adam Roben  <aroben@apple.com>
       
 25926 
       
 25927         Forgot to make the change to Release as well in my last checkin.
       
 25928 
       
 25929         * WebCore.vcproj/WebCore.vcproj:
       
 25930 
       
 25931 2006-10-26  Adam Roben  <aroben@apple.com>
       
 25932 
       
 25933         Rubberstamped by Steve.
       
 25934 
       
 25935         Add some missing '/d' flags to xcopy calls to only copy headers if
       
 25936         they've been modified.
       
 25937 
       
 25938         * WebCore.vcproj/WebCore.vcproj:
       
 25939 
       
 25940 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
       
 25941 
       
 25942         * platform/win/TemporaryLinkStubs.cpp:
       
 25943         (GraphicsContext::drawLineForMisspellingOrBadGrammar):
       
 25944         Build fix from Oliver.
       
 25945         
       
 25946 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
       
 25947 
       
 25948         Reviewed by Adam.
       
 25949 
       
 25950         Use FrameLoadRequest and ResourceRequest instead of passing around
       
 25951         the individual components.
       
 25952         
       
 25953         * plugins/win/PluginStreamWin.cpp:
       
 25954         (WebCore::PluginStreamWin::PluginStreamWin):
       
 25955         (WebCore::PluginStreamWin::start):
       
 25956         (WebCore::PluginStreamWin::destroyStream):
       
 25957         * plugins/win/PluginStreamWin.h:
       
 25958         * plugins/win/PluginViewWin.cpp:
       
 25959         (WebCore::PluginRequestWin::PluginRequestWin):
       
 25960         (WebCore::PluginRequestWin::frameLoadRequest):
       
 25961         (WebCore::PluginViewWin::start):
       
 25962         (WebCore::PluginViewWin::performRequest):
       
 25963         (WebCore::PluginViewWin::load):
       
 25964         (WebCore::PluginViewWin::getURLNotify):
       
 25965         (WebCore::PluginViewWin::getURL):
       
 25966         (WebCore::PluginViewWin::handlePost):
       
 25967         * plugins/win/PluginViewWin.h:
       
 25968 
       
 25969 2006-10-26  Adam Roben  <aroben@apple.com>
       
 25970 
       
 25971         Reviewed by Adele.
       
 25972 
       
 25973         Fix: <rdar://problem/4794162> Implement type-ahead find for popup menus
       
 25974         Fix: <rdar://problem/4800486> Pressing TAB while a popup is focused
       
 25975         should close the popup and move selection in the page
       
 25976 
       
 25977         * platform/win/PopupMenuWin.cpp:
       
 25978         (WebCore::PopupMenu::PopupMenu): Don't cache the focused index.
       
 25979         (WebCore::PopupMenu::focusedIndex): Always get the focused index from
       
 25980         the HTMLSelectElement.
       
 25981         (WebCore::PopupMenu::setFocusedIndex): Invalidate before calling
       
 25982         valueChanged(), as this will change the result of focusedIndex().
       
 25983         (WebCore::PopupMenu::scrollToRevealSelection):
       
 25984         (WebCore::PopupMenu::updateFromElement): New method to repaint/rescroll
       
 25985         the popup.
       
 25986         (WebCore::PopupWndProc): Send TAB keypresses and printable characters
       
 25987         back to the WebView for handling. Also omove handling of Return/Escape
       
 25988         into the WM_CHAR event, as this is recommended by MSDN.
       
 25989 
       
 25990 2006-10-25  Steve Falkenburg  <sfalken@apple.com>
       
 25991 
       
 25992         Reviewed by Darin.
       
 25993 
       
 25994         Checked in Luke's CG printing code
       
 25995 
       
 25996         * bridge/win/FrameWin.cpp:
       
 25997         (WebCore::FrameWin::setupRootForPrinting): Added
       
 25998         (WebCore::FrameWin::computePageRects): Added
       
 25999         * bridge/win/FrameWin.h: Added setupRootForPrinting, computePageRects
       
 26000 
       
 26001 2006-10-24  Maciej Stachowiak  <mjs@apple.com>
       
 26002 
       
 26003         Reviewed by Oliver.
       
 26004 
       
 26005         - updated for ResourceRequest changes.
       
 26006 
       
 26007         * plugins/win/PluginStreamWin.cpp:
       
 26008         (WebCore::PluginStreamWin::setRequestHeaders):
       
 26009         * plugins/win/PluginStreamWin.h:
       
 26010         * plugins/win/PluginViewWin.cpp:
       
 26011         (WebCore::PluginViewWin::loadURL):
       
 26012         (WebCore::parseRFC822HeaderFields):
       
 26013         (WebCore::PluginViewWin::handlePost):
       
 26014         * plugins/win/PluginViewWin.h:
       
 26015 
       
 26016 2006-10-24  Steve Falkenburg  <sfalken@apple.com>
       
 26017 
       
 26018         Build fix for official builds
       
 26019 
       
 26020         * WebCore.vcproj/WebCore.make:
       
 26021 
       
 26022 2006-10-24  Steve Falkenburg  <sfalken@apple.com>
       
 26023 
       
 26024         Fix build so it can be submitted.
       
 26025 
       
 26026         * WebCore.vcproj/WebCore.vcproj:
       
 26027         * WebCore.vcproj/merge-opensource.sh:
       
 26028         * rendering/RenderThemeWin.cpp:
       
 26029 
       
 26030 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
       
 26031 
       
 26032         Rolling back in, now fixed:
       
 26033         
       
 26034         Nixed a few more redundant loading functions in Frame.
       
 26035 
       
 26036         * bridge/win/FrameWin.h:
       
 26037         * platform/win/TemporaryLinkStubs.cpp:
       
 26038         (FrameWin::shouldInterruptJavaScript):
       
 26039         (FrameWin::lastEventIsMouseUp):
       
 26040 
       
 26041 2006-10-24  Maciej Stachowiak  <mjs@apple.com>
       
 26042 
       
 26043         Reviewed by Geoff.
       
 26044 
       
 26045         - update for ResourceLoader API changes
       
 26046 
       
 26047         * platform/win/TemporaryLinkStubs.cpp:
       
 26048         (WebCore::ServeSynchronousRequest):
       
 26049         * plugins/win/PluginStreamWin.cpp:
       
 26050         (WebCore::PluginStreamWin::start):
       
 26051         (WebCore::PluginStreamWin::receivedAllData):
       
 26052         * plugins/win/PluginStreamWin.h:
       
 26053         * plugins/win/PluginViewWin.cpp:
       
 26054         (WebCore::PluginViewWin::performRequest):
       
 26055 
       
 26056 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
       
 26057 
       
 26058         Rolling out my last change because it broke the world.
       
 26059         
       
 26060         * bridge/win/FrameWin.h:
       
 26061         * platform/win/TemporaryLinkStubs.cpp:
       
 26062         (FrameWin::openURL):
       
 26063 
       
 26064 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
       
 26065 
       
 26066         Reviewed by Adam.
       
 26067 
       
 26068         <rdar://problem/4760429> Crash in PluginStreamWin::~PluginStreamWin when 
       
 26069         navigating away from mcdonalds.com
       
 26070         
       
 26071         * plugins/win/PluginPackageWin.cpp:
       
 26072         (WebCore::PluginPackageWin::fetchInfo):
       
 26073         Use fastFree instead of free when memory is allocated by fastMalloc. 
       
 26074         If the plugin name or description is null, don't try to fetch info about the plugin.
       
 26075         
       
 26076         * plugins/win/PluginStreamWin.cpp:
       
 26077         (WebCore::PluginStreamWin::setRequestHeaders):
       
 26078         (WebCore::PluginStreamWin::start):
       
 26079         (WebCore::PluginStreamWin::stop):
       
 26080         * plugins/win/PluginStreamWin.h:
       
 26081         Change type of header map to ResourceRequest::HTTPHeaderMap. When a plugin is stopped,
       
 26082         set its state to StreamStopped.
       
 26083         
       
 26084         * plugins/win/PluginViewWin.cpp:
       
 26085         (WebCore::PluginViewWin::loadURL):
       
 26086         (WebCore::parseRFC822HeaderFields):
       
 26087         (WebCore::PluginViewWin::handlePost):
       
 26088         * plugins/win/PluginViewWin.h:
       
 26089         Update for type changes to the header map.
       
 26090 
       
 26091 2006-10-24  Geoffrey Garen  <ggaren@apple.com>
       
 26092 
       
 26093         Reviewed by Anders.
       
 26094         
       
 26095         Nixed a few more redundant loading functions in Frame.
       
 26096 
       
 26097         * bridge/win/FrameWin.h:
       
 26098         * platform/win/TemporaryLinkStubs.cpp:
       
 26099         (FrameWin::shouldInterruptJavaScript):
       
 26100         (FrameWin::lastEventIsMouseUp):
       
 26101 
       
 26102 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
       
 26103 
       
 26104         Reviewed by Bradee.
       
 26105 
       
 26106         Removed methods from BrowserExtension.
       
 26107 
       
 26108         * bridge/win/FrameWin.h:
       
 26109         * platform/win/TemporaryLinkStubs.cpp:
       
 26110         (FrameWin::canPaste):
       
 26111         (FrameWin::canGoBackOrForward):
       
 26112         (FrameWin::goBackOrForward):
       
 26113         (FrameWin::getHistoryLength):
       
 26114         (FrameWin::historyURL):
       
 26115         (Page::canRunModal):
       
 26116         (Page::canRunModalNow):
       
 26117         (Page::runModal):
       
 26118         (BrowserExtensionWin::BrowserExtensionWin):
       
 26119 
       
 26120 2006-10-23  Adam Roben  <aroben@apple.com>
       
 26121 
       
 26122         Reviewed by Adele.
       
 26123 
       
 26124         Fix: <rdar://problem/4796994> Styled <select>s should still use Windows
       
 26125         theme
       
 26126 
       
 26127         The fix is to do most of our drawing for menulists in
       
 26128         RenderThemeWin::paintMenuListButton (which is called for styled
       
 26129         <select>s), and then do any extra drawing for unstyled <select>s in
       
 26130         RenderThemeWin::paintMenuList.
       
 26131 
       
 26132         * rendering/RenderThemeWin.cpp:
       
 26133         (WebCore::RenderThemeWin::getThemeData): Case for
       
 26134         MenulistButtonAppearance should be the same as MenulistAppearance.
       
 26135         (WebCore::RenderThemeWin::paintMenuList): Draw the border, then defer
       
 26136         to paintMenuListButton to handle the rest of painting.
       
 26137         (WebCore::RenderThemeWin::adjustMenuListStyle): Reset the border so we
       
 26138         can draw our own, then defer to adjustMenuListStyle.
       
 26139         (WebCore::RenderThemeWin::adjustMenuListButtonStyle): Code moved from
       
 26140         adjustMenuListStyle, less the call to resetBorder().
       
 26141         (WebCore::RenderThemeWin::paintMenuListButton): Code moved from
       
 26142         paintMenuList, less the border-drawing code.
       
 26143         * rendering/RenderThemeWin.h:
       
 26144 
       
 26145 2006-10-23  Adam Roben  <aroben@apple.com>
       
 26146 
       
 26147         Reviewed by Adele.
       
 26148 
       
 26149         Fix: <rdar://problem/4786759> PageUp/PageDown/Home/End don't work in
       
 26150         <select> menus
       
 26151 
       
 26152         * platform/win/PopupMenuWin.cpp:
       
 26153         (WebCore::PopupMenu::setFocusedIndex): Only call ::UpdateWindow if we
       
 26154         didn't scroll, because scrolling will do the update for us.
       
 26155         (WebCore::PopupMenu::focusFirst): New method.
       
 26156         (WebCore::PopupMenu::focusLast): New method.
       
 26157         (WebCore::PopupMenu::down): Add a parameter to specify how far we
       
 26158         should try to move the selection.
       
 26159         (WebCore::PopupMenu::up): Ditto.
       
 26160         (WebCore::PopupMenu::invalidateItem): Cleanup code by using IntRect
       
 26161         instead of RECT.
       
 26162         (WebCore::PopupMenu::scrollTo): Return a boolean to say whether
       
 26163         scrolling actually happened.
       
 26164         (WebCore::PopupMenu::scrollToRevealSelection): Ditto.
       
 26165         (WebCore::PopupWndProc): Handle PageUp/PageDown/Home/End.
       
 26166 
       
 26167 2006-10-23  Adam Roben  <aroben@apple.com>
       
 26168 
       
 26169         Build fix.
       
 26170 
       
 26171         * WebCore.vcproj/WebCore.vcproj: Copy headers from new platform/network
       
 26172         directory and subdirectories.
       
 26173 
       
 26174 2006-10-23  Adam Roben  <aroben@apple.com>
       
 26175 
       
 26176         Build fix.
       
 26177 
       
 26178         * plugins/win/PluginStreamWin.h: Rename methods to match Maciej's
       
 26179         changes.
       
 26180 
       
 26181 2006-10-23  Adam Roben  <aroben@apple.com>
       
 26182 
       
 26183         Build fix.
       
 26184 
       
 26185         * WebCore.vcproj/WebCore.vcproj: Copied AdditionalIncludeDirectories
       
 26186         from Release to All Configurations.
       
 26187 
       
 26188 2006-10-23  Maciej Stachowiak  <mjs@apple.com>
       
 26189 
       
 26190         Rubber-stamped by Anders.
       
 26191 
       
 26192         - fixed for ResourceLoader refactoring.
       
 26193 
       
 26194         * platform/network/win/ResourceLoaderWin.cpp:
       
 26195         (WebCore::ResourceLoader::onRequestComplete):
       
 26196         (WebCore::ResourceLoader::fileLoadTimer):
       
 26197         (WebCore::ResourceLoader::cancel):
       
 26198         * plugins/win/PluginStreamWin.cpp:
       
 26199         (WebCore::PluginStreamWin::didReceiveData):
       
 26200         (WebCore::PluginStreamWin::didFinishLoading):
       
 26201         * plugins/win/PluginViewWin.cpp:
       
 26202         (WebCore::PluginViewWin::performRequest):
       
 26203 
       
 26204 2006-10-22  Maciej Stachowiak  <mjs@apple.com>
       
 26205 
       
 26206         Reviewed by Anders.
       
 26207 
       
 26208         - updated for new ResourceLoader file locations.
       
 26209 
       
 26210         * WebCore.vcproj/WebCore.vcproj: Updated file paths.
       
 26211         * platform/win/ResourceLoaderWin.cpp: Moved to platform/network/win
       
 26212         * platform/win/ResourceLoaderWin.h: ditto
       
 26213 
       
 26214 2006-10-22  Adam Roben  <aroben@apple.com>
       
 26215 
       
 26216         Reviewed by Steve.
       
 26217 
       
 26218         Fix some crashes caused by the <select> element being detached while
       
 26219         the popup is open.
       
 26220 
       
 26221         * platform/win/PopupMenuWin.cpp:
       
 26222         (WebCore::PopupWndProc):
       
 26223 
       
 26224 2006-10-21  Adam Roben  <aroben@apple.com>
       
 26225 
       
 26226         Reviewed by Anders.
       
 26227 
       
 26228         Fix: <rdar://problem/4794151> Popup should scroll to reveal selected
       
 26229         item, not just one line at a time
       
 26230         Fix: <rdar://problem/4794229> Popup hot-tracking should not change text
       
 26231         in <select> control
       
 26232 
       
 26233         * platform/win/PopupMenuWin.cpp:
       
 26234         (WebCore::PopupMenu::calculatePositionAndSize): Cleaned up code by
       
 26235         translating into screen coordinates right away.
       
 26236         (WebCore::PopupMenu::setFocusedIndex): Added parameter to specify
       
 26237         whether the text in the <select> control should be updated.
       
 26238         (WebCore::PopupMenu::scrollTo): Extracted scrolling code from
       
 26239         PopupWndProc to here.
       
 26240         (WebCore::PopupMenu::scrollToRevealSelection): New method.
       
 26241         (WebCore::PopupWndProc): Use scrollToRevealSelection() instead of
       
 26242         manually scrolling one line at a time. Fixed a bug in detecting a
       
 26243         mouse drag.  Pass in HDC from ::BeginPaint to PopupMenu::paint.
       
 26244 
       
 26245 2006-10-21  Adam Roben  <aroben@apple.com>
       
 26246 
       
 26247         Build fix.
       
 26248 
       
 26249         * WebCore.vcproj/WebCore.vcproj: Add new DeleteButton* files to
       
 26250         project.
       
 26251 
       
 26252 2006-10-20  Steve Falkenburg  <sfalken@apple.com>
       
 26253 
       
 26254         Reviewed by Anders.
       
 26255 
       
 26256         Turn on CFNetwork
       
 26257 
       
 26258         * config.h:
       
 26259 
       
 26260 2006-10-20  Steve Falkenburg  <sfalken@apple.com>
       
 26261 
       
 26262         Reviewed by Ada.
       
 26263 
       
 26264         <rdar://4778502> Boomer userAgent string needs to support pulling in proper build #, plus customization
       
 26265 
       
 26266         Useragent/versioning changes
       
 26267         
       
 26268         Stamp auto-generated version number into DLL and into user agent.
       
 26269         Generate a real user agent string instead of hardcoding one.
       
 26270         Support client supplying an application name for the user agent.
       
 26271         Support client overriding the useragent (for debug menu).
       
 26272         Support per-URL user agents (not used at least for now).
       
 26273 
       
 26274         * bridge/win/FrameWin.cpp:
       
 26275         (WebCore::FrameWin::userAgent): Now calls userAgentForURL
       
 26276         (WebCore::FrameWin::originalRequestURL): Implemented
       
 26277         * bridge/win/FrameWin.h: changed userAgent to userAgentForURL, added originalRequestURL
       
 26278         * platform/win/TemporaryLinkStubs.cpp: Removed originalRequestURL
       
 26279 
       
 26280 2006-10-20  Alice Liu  <alice.liu@apple.com>
       
 26281 
       
 26282         Reviewed by Steve.
       
 26283 
       
 26284         Adding knowledge of the Editor and EditorClient to Windows WebCore
       
 26285 
       
 26286         No layout tests needed
       
 26287         
       
 26288         * WebCore.vcproj/WebCore.vcproj:
       
 26289         added Sound.h, SoundWin.cpp, EditorClient.h, Editor.h&.cpp
       
 26290 
       
 26291         * bridge/win/FrameWin.cpp:
       
 26292         (WebCore::FrameWin::FrameWin):
       
 26293         added client to constructor params
       
 26294 
       
 26295         * bridge/win/FrameWin.h:
       
 26296         added client to constructor params
       
 26297 
       
 26298         * platform/win/SoundWin.cpp: Added.
       
 26299         (WebCore::systemBeep):
       
 26300         Calls windows system beep
       
 26301 
       
 26302 2006-10-19  Steve Falkenburg  <sfalken@apple.com>
       
 26303 
       
 26304         Reviewed by Adam.
       
 26305 
       
 26306         <rdar://4771958> Holding down Ctrl when a redirect happens opens the redirected page in a new tab
       
 26307         
       
 26308         Send triggering event to url selection.
       
 26309 
       
 26310         * bridge/win/FrameWin.cpp:
       
 26311         (WebCore::FrameWin::urlSelected): Add triggeringEvent parameter
       
 26312         * bridge/win/FrameWin.h: Add triggeringEvent parameter
       
 26313         * platform/win/PlatformMouseEventWin.cpp:
       
 26314         (WebCore::PlatformMouseEvent::PlatformMouseEvent): Call GetKeyState instead of GetAsyncKeyState
       
 26315         * platform/win/WheelEventWin.cpp:
       
 26316         (WebCore::PlatformWheelEvent::PlatformWheelEvent): Call GetKeyState instead of GetAsyncKeyState
       
 26317 
       
 26318 2006-10-19  Adam Roben  <aroben@apple.com>
       
 26319 
       
 26320         Reviewed by Ada.
       
 26321 
       
 26322         This is a partial reimplementation of PopupMenu for Windows. The old
       
 26323         implementation used the Win32 ListBox control, but as we needed to
       
 26324         customize the behavior more and more it began to make sense to roll our
       
 26325         own popup from scratch. That is what this patch accomplishes. And...
       
 26326 
       
 26327         Fix: <rdar://problem/4709416>
       
 26328         Implement mouse hot-tracking for <select> menus
       
 26329         Fix: <rdar://problem/4786763>
       
 26330         Can select disabled options in <select> menus using mouse
       
 26331         (It was easier to implement these than to leave them broken.)
       
 26332 
       
 26333         * WebCore.vcproj/WebCore.vcproj: Removed PopupMenu.cpp from project.
       
 26334         * platform/win/PopupMenuWin.cpp: Carnage. PopupMenu has gained a slew
       
 26335         of new private instance variables to maintain the window state.
       
 26336         m_container has been removed as it is no longer needed.
       
 26337         (WebCore::PopupMenu::PopupMenu): Initialize new variables.
       
 26338         (WebCore::PopupMenu::~PopupMenu): Clean up new variables.
       
 26339         (WebCore::PopupMenu::show): Now that we don't have m_container, m_popup
       
 26340         gets the WS_BORDER and WS_POPUP styles. Also moved code to animate the
       
 26341         window out of the old PopupMenu::setPositionAndSize() into this method
       
 26342         since it fits the purpose of this method better.
       
 26343         (WebCore::PopupMenu::hide):
       
 26344         (WebCore::PopupMenu::calculatePositionAndSize): Renamed from
       
 26345         setPositionAndSize(), as this method no longer actually sets the window
       
 26346         position and size, just calculates it. It also now makes sure the
       
 26347         window is sized to never show partial items, and takes into account the
       
 26348         window's border when calculating the size.
       
 26349         (WebCore::PopupMenu::setFocusedIndex): New method to handle setting the
       
 26350         selected index of the <select> and highlighting the item in the popup menu.
       
 26351         (WebCore::PopupMenu::down): Use setSelectedIndex() to do the dirty work.
       
 26352         (WebCore::PopupMenu::up): Ditto.
       
 26353         (WebCore::PopupMenu::invalidateItem): New method to invalidate the
       
 26354         rectangle in the popup menu for this item.
       
 26355         (WebCore::PopupMenu::clientRect): New method to calculate an IntRect
       
 26356         for the client area of the window.
       
 26357         (WebCore::PopupMenu::incrementWheelDelta): New method to add the wheel
       
 26358         delta obtained from a WM_MOUSEWHEEL message to any pre-existing delta.
       
 26359         (WebCore::PopupMenu::reduceWheelDelta): New method to reduce the
       
 26360         pre-existing wheel delta by a given amount towards 0.
       
 26361         (WebCore::PopupMenu::paint): Does the work that PopupMenu::drawItem
       
 26362         did, but for every item contained within the damageRect. Can also paint
       
 26363         into a passed-in HDC (needed for window animations and smooth-scrolling).
       
 26364         (WebCore::registerPopup): Changed a void* to a PopupMenu*, since that's
       
 26365         what it really is.
       
 26366         (WebCore::PopupWndProc): Added code to handle all the messages any
       
 26367         self-respecting window would handle, and removed messages only relevant
       
 26368         to the ListBox control.
       
 26369         * platform/win/TemporaryLinkStubs.cpp: Removed unneeded #include.
       
 26370 
       
 26371 2006-10-19  Adam Roben  <aroben@apple.com>
       
 26372 
       
 26373         Rubberstamped by Maciej.
       
 26374 
       
 26375         Build fix.
       
 26376 
       
 26377         * bridge/win/FrameWin.cpp:
       
 26378         (WebCore::FrameWin::submitForm):
       
 26379 
       
 26380 2006-10-19  Maciej Stachowiak  <mjs@apple.com>
       
 26381 
       
 26382         Reviewed by Steve.
       
 26383 
       
 26384         - speculative build fix for Windows for my recent changes.
       
 26385 
       
 26386         * bridge/win/FrameWin.cpp:
       
 26387         (WebCore::FrameWin::submitForm):
       
 26388 
       
 26389 2006-10-19  Anders Carlsson  <acarlsson@apple.com>
       
 26390 
       
 26391        * platform/win/TemporaryLinkStubs.cpp:
       
 26392         (WebCore::ResourceLoader::retrieveResponseEncoding):
       
 26393         Build fix.
       
 26394 
       
 26395 2006-10-18  Maciej Stachowiak  <mjs@apple.com>
       
 26396 
       
 26397         Reviewed by Geoff.
       
 26398 
       
 26399         - remove remnants of KXMLCore name.
       
 26400 
       
 26401         * WebCore.vcproj/WebCore.vcproj:
       
 26402         * config.h:
       
 26403 
       
 26404 2006-10-18  Steve Falkenburg  <sfalken@apple.com>
       
 26405 
       
 26406         Fix build
       
 26407 
       
 26408         * platform/win/TemporaryLinkStubs.cpp:
       
 26409         (BrowserExtensionWin::historyURL):
       
 26410         (BrowserExtensionWin::BrowserExtensionWin):
       
 26411 
       
 26412 2006-10-17  Steve Falkenburg  <sfalken@apple.com>
       
 26413 
       
 26414         Build fix
       
 26415 
       
 26416         * platform/win/TemporaryLinkStubs.cpp:
       
 26417         (BrowserExtensionWin::createNewWindow):
       
 26418 
       
 26419 2006-10-17  Geoffrey Garen  <ggaren@apple.com>
       
 26420 
       
 26421         Reviewed by Anders.
       
 26422         
       
 26423         Added WindowFeatures.h to the project.
       
 26424 
       
 26425         * WebCore.vcproj/WebCore.vcproj:
       
 26426 
       
 26427 2006-10-17  Steve Falkenburg  <sfalken@apple.com>
       
 26428 
       
 26429         Reviewed by Maciej.
       
 26430 
       
 26431         Turn off a very noisy warning (unknown pragma) caused by an Interfacer include
       
 26432 
       
 26433         * WebCore.vcproj/WebCore.vcproj:
       
 26434 
       
 26435 2006-10-17  Oliver Hunt  <oliver@apple.com>
       
 26436 
       
 26437         Reviewed by Brady.
       
 26438 
       
 26439         Fixed alpha in favicons, added composite operation conversion
       
 26440         for cg
       
 26441         
       
 26442         rdar://problem/4758934
       
 26443 
       
 26444         * platform/win/GraphicsContextWin.cpp:
       
 26445         (WebCore::GraphicsContext::setCompositeOperation):
       
 26446         * platform/win/ImageWin.cpp:
       
 26447         (WebCore::Image::getHBITMAP):
       
 26448         * platform/win/TemporaryLinkStubs.cpp:
       
 26449         (GraphicsContext::drawLineForMisspelling):
       
 26450 
       
 26451 2006-10-15  Geoffrey Garen  <ggaren@apple.com>
       
 26452 
       
 26453         Reviewed by Adam.
       
 26454 
       
 26455         Added HTMLFrameElementBase to the project.
       
 26456         
       
 26457         * WebCore.vcproj/WebCore.vcproj:
       
 26458 
       
 26459 2006-10-17  Adam Roben  <aroben@apple.com>
       
 26460 
       
 26461         Reviewed by Geoff.
       
 26462 
       
 26463         A couple of cleanups that Geoff suggested after my last checkin.
       
 26464 
       
 26465         * platform/win/PopupMenuWin.cpp:
       
 26466         (WebCore::PopupMenu::setPositionAndSize):
       
 26467 
       
 26468 2006-10-17  Adam Roben  <aroben@apple.com>
       
 26469 
       
 26470         Reviewed by Adele.
       
 26471 
       
 26472         Fix: <rdar://problem/4772506> <select> popup menu should not clip items
       
 26473         when width: is set.
       
 26474 
       
 26475         Popups are now sized and positioned as follows:
       
 26476         1. Popups are at least as wide as the <select> control on the page.
       
 26477         2. Popups for LTR <select>s are right-aligned with the <select>, popups
       
 26478            for RTL <select>s are left-aligned. This means the scrollbar in the
       
 26479            popup will always line up with the dropdown button in the <select>.
       
 26480         3. Popups try to be wide enough to fit their widest item, but will
       
 26481            shrink to ensure they don't extend off the screen.
       
 26482 
       
 26483         * platform/win/PopupMenuWin.cpp:
       
 26484         (WebCore::PopupMenu::setPositionAndSize):
       
 26485 
       
 26486 2006-10-16  Adam Roben  <aroben@apple.com>
       
 26487 
       
 26488         Reviewed by Kevin.
       
 26489 
       
 26490         Fix: <rdar://problem/4758923> <select> menu text doesn't draw right
       
 26491         aligned on right-to-left sites
       
 26492 
       
 26493         * platform/win/PopupMenuWin.cpp:
       
 26494         (WebCore::PopupMenu::show): Pass appropriate styles to CreateWindowEx
       
 26495         so that we get a left-aligned scrollbar in RTL popups.
       
 26496         (WebCore::PopupMenu::drawItem): Set text to be right-aligned and draw
       
 26497         RTL when direction:rtl is set.
       
 26498         (WebCore::PopupWndProc): Add 1px of vertical height to each menu item
       
 26499         to match RenderListBox.
       
 26500         * rendering/RenderThemeWin.cpp:
       
 26501         (WebCore::RenderThemeWin::paintMenuList): Draw the dropdown button on
       
 26502         the left when in RTL.
       
 26503         (WebCore::RenderThemeWin::adjustMenuListStyle): Set padding to allow
       
 26504         for the dropdown button being on the left in RTL.
       
 26505 
       
 26506 2006-10-16  Adam Roben  <aroben@apple.com>
       
 26507 
       
 26508         Reviewed by John.
       
 26509 
       
 26510         Forgot to save these changes John suggested before checking in.
       
 26511 
       
 26512         * platform/win/PopupMenuWin.cpp:
       
 26513         (WebCore::PopupMenu::drawItem):
       
 26514 
       
 26515 2006-10-16  Adam Roben  <aroben@apple.com>
       
 26516 
       
 26517         Reviewed by John.
       
 26518 
       
 26519         Fix: <rdar://problem/4709480> Implement option groups
       
 26520         Fix: <rdar://problem/4785693> Use CG to draw popup menu items
       
 26521         Fix: <rdar://problem/4709487> Implement separators in <select> popups
       
 26522         Fix: <rdar://problem/4709358> Move CreateWindowEx calls out of PopupMenu constructor
       
 26523 
       
 26524         * platform/win/PopupMenuWin.cpp: Added some now-required #includes,
       
 26525         moved some constants into the WebCore namespace.
       
 26526         (WebCore::PopupMenu::PopupMenu): Moved CreateWindowEx calls into PopupMenu::show().
       
 26527         (WebCore::PopupMenu::show): Pass LBS_OWNERDRAWFIXED to CreateWindowEx
       
 26528         to assume responsibility for drawing menu itesm. Removed call to set
       
 26529         the font on the popup menu, as CG will take care of this.
       
 26530         (WebCore::addString): Added to help with the PopupMenu::add* methods.
       
 26531         (WebCore::PopupMenu::addOption): Use addString.
       
 26532         (WebCore::PopupMenu::addGroupLabel): Ditto, and moved from TemporaryLinkStubs.cpp.
       
 26533         (WebCore::PopupMenu::addSeparator): Ditto.
       
 26534         (WebCore::PopupMenu::down): Skip items that are not enabled <option>
       
 26535         elements, and tell the popup menu to set the selection to the element
       
 26536         we end up on.
       
 26537         (WebCore::PopupMenu::up): Ditto.
       
 26538         (WebCore::PopupMenu::drawItem): Added. This is the method that is
       
 26539         called to draw each item in the menu.
       
 26540         (WebCore::PopupWndProc): Add cases for WM_MEASUREITEM and WM_DRAWITEM
       
 26541         messages (required now that we're drawing the menu items ourselves). In
       
 26542         the cases for arrow key presses, return -2 to signify that we're
       
 26543         handling all aspects of changing the selection.
       
 26544         * platform/win/TemporaryLinkStubs.cpp: Removed PopupMenu::addSeparator
       
 26545         and PopupMenu::addGroupLabel.
       
 26546 
       
 26547 2006-10-15  Adam Roben  <aroben@apple.com>
       
 26548 
       
 26549         Build fix.
       
 26550 
       
 26551         Merge OpenSource r17056 to TemporaryLinkStubs.cpp.
       
 26552 
       
 26553         * platform/win/TemporaryLinkStubs.cpp:
       
 26554         (WebCore::CacheObjectExpiresTime):
       
 26555         (WebCore::ResponseIsMultipart):
       
 26556         (WebCore::ResponseMIMEType):
       
 26557         (WebCore::IsResponseURLEqualToURL):
       
 26558         (WebCore::ResponseURL):
       
 26559         (WebCore::CachedResource::setResponse):
       
 26560         (WebCore::CachedResource::setAllData):
       
 26561 
       
 26562 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
       
 26563 
       
 26564         Reviewed by Darin.
       
 26565 
       
 26566         - split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool
       
 26567 
       
 26568         * WebCore.vcproj/WebCore.vcproj:
       
 26569         * bridge/win/FrameWin.cpp:
       
 26570         (WebCore::FrameWin::urlSelected):
       
 26571         (WebCore::FrameWin::submitForm):
       
 26572         * bridge/win/FrameWin.h:
       
 26573         * platform/win/TemporaryLinkStubs.cpp:
       
 26574         (BrowserExtensionWin::createNewWindow):
       
 26575         (IconLoader::notifyIconChanged):
       
 26576 
       
 26577 2006-10-13  Dave Hyatt  <hyatt@apple.com>
       
 26578 
       
 26579         Make form controls work inside transparency layers by having
       
 26580         them draw into bitmap that is then turned into a CGImageRef
       
 26581         and blended into the CG transparency layer.
       
 26582 
       
 26583         Reviewed by aroben
       
 26584 
       
 26585         * platform/cg/GraphicsContextPlatformPrivate.h:
       
 26586         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
       
 26587         (WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
       
 26588         (WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):
       
 26589         * platform/win/GraphicsContextWin.cpp:
       
 26590         (WebCore::GraphicsContext::getWindowsContext):
       
 26591         (WebCore::GraphicsContext::releaseWindowsContext):
       
 26592         * platform/win/IconWin.cpp:
       
 26593         (WebCore::Icon::paint):
       
 26594         * platform/win/PlatformScrollBar.h:
       
 26595         * platform/win/PlatformScrollBarWin.cpp:
       
 26596         (WebCore::PlatformScrollbar::PlatformScrollbar):
       
 26597         (WebCore::PlatformScrollbar::paint):
       
 26598         (WebCore::PlatformScrollbar::paintButton):
       
 26599         (WebCore::PlatformScrollbar::paintTrack):
       
 26600         (WebCore::PlatformScrollbar::paintThumb):
       
 26601         * rendering/RenderThemeWin.cpp:
       
 26602         (WebCore::RenderThemeWin::RenderThemeWin):
       
 26603         (WebCore::drawControl):
       
 26604 
       
 26605 2006-10-12  Dave Hyatt  <hyatt@apple.com>
       
 26606 
       
 26607         Voting Cairo off the island
       
 26608 
       
 26609         or
       
 26610 
       
 26611         Jeff Probst: "Cairo, the tribe has spoken.  It's time for you
       
 26612         to go."
       
 26613 
       
 26614         * WebCore.vcproj/WebCore.vcproj:
       
 26615         * platform/win/FontDataWin.cpp:
       
 26616         (WebCore::FontData::platformInit):
       
 26617         (WebCore::FontData::platformDestroy):
       
 26618         (WebCore::FontData::platformWidthForGlyph):
       
 26619         * platform/win/FontPlatformData.h:
       
 26620         (WebCore::FontPlatformData::FontPlatformData):
       
 26621         (WebCore::FontPlatformData::hfont):
       
 26622         (WebCore::FontPlatformData::cgFont):
       
 26623         (WebCore::FontPlatformData::operator==):
       
 26624         * platform/win/FontPlatformDataWin.cpp:
       
 26625         * platform/win/FontWin.cpp:
       
 26626         (WebCore::Font::drawGlyphs):
       
 26627         * platform/win/GraphicsContextWin.cpp:
       
 26628         * platform/win/IconWin.cpp:
       
 26629         * platform/win/ImageWin.cpp:
       
 26630         (WebCore::Image::loadPlatformResource):
       
 26631         * platform/win/TemporaryLinkStubs.cpp:
       
 26632         (GraphicsContextPlatformPrivate::clip):
       
 26633         (GraphicsContext::drawLineForMisspelling):
       
 26634 
       
 26635 2006-10-12  Adele Peterson  <adele@apple.com>
       
 26636 
       
 26637         RS by Geoff.
       
 26638 
       
 26639         Renamed uploadControlDetaching to disconnectUploadControl.
       
 26640 
       
 26641         * platform/win/FileChooserWin.cpp:
       
 26642         (WebCore::FileChooser::disconnectUploadControl):
       
 26643 
       
 26644 2006-10-12  Adele Peterson  <adele@apple.com>
       
 26645 
       
 26646         Reviewed by Alice. 
       
 26647 
       
 26648         Fixed a small oversight from the last checkin.  The populate method was calling itself, 
       
 26649         instead of the newly renamed addItems method.
       
 26650 
       
 26651         * platform/win/PopupMenuWin.cpp:
       
 26652         (WebCore::PopupMenu::populate):
       
 26653 
       
 26654 2006-10-12  Adam Roben  <aroben@apple.com>
       
 26655 
       
 26656         Reviewed by Adele.
       
 26657 
       
 26658         Move popup menu code out of rendering/ and into platform/.
       
 26659         RenderPopupMenu becomes PopupMenu, the
       
 26660         RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
       
 26661         virtual methods go away, RenderTheme gets to stop worrying about popup
       
 26662         menus, PopupMenu becomes ref-counted, and everyone becomes happy.
       
 26663 
       
 26664         Also fixes <rdar://problem/4710456> Get rid of RenderPopupMenu{Win,Mac}
       
 26665         classes.
       
 26666 
       
 26667         * WebCore.vcproj/WebCore.vcproj: Move files within project.
       
 26668         * platform/win/PopupMenuWin.cpp: Moved from
       
 26669         rendering/RenderPopupMenuWin.cpp. Rename RenderPopupMenuWin to
       
 26670         PopupMenu.
       
 26671         (WebCore::PopupMenu::PopupMenu):
       
 26672         (WebCore::PopupMenu::~PopupMenu):
       
 26673         (WebCore::PopupMenu::clear):
       
 26674         (WebCore::PopupMenu::populate):
       
 26675         (WebCore::PopupMenu::show):
       
 26676         (WebCore::PopupMenu::hide):
       
 26677         (WebCore::PopupMenu::setPositionAndSize):
       
 26678         (WebCore::PopupMenu::addOption):
       
 26679         (WebCore::PopupMenu::focusedIndex): New method to get the index of the
       
 26680         element that is currently highlighted. This won't always be the same as
       
 26681         the selectedIndex because of mouse hot-tracking.
       
 26682         (WebCore::PopupMenu::down):
       
 26683         (WebCore::PopupMenu::up):
       
 26684         (WebCore::registerPopup):
       
 26685         (WebCore::PopupWndProc): Use focusedIndex() instead of sending messages
       
 26686         to the popup window.
       
 26687         * platform/win/TemporaryLinkStubs.cpp: Rename RenderPopupMenuWin to PopupMenu.
       
 26688         (PopupMenu::addSeparator):
       
 26689         (PopupMenu::addGroupLabel):
       
 26690         * rendering/RenderPopupMenuWin.cpp: Removed.
       
 26691         * rendering/RenderPopupMenuWin.h: Removed.
       
 26692         * rendering/RenderThemeWin.cpp: Get rid of createPopupMenu() method.
       
 26693         * rendering/RenderThemeWin.h: Ditto.
       
 26694 
       
 26695 2006-10-12  Dave Hyatt  <hyatt@apple.com>
       
 26696 
       
 26697         Implement full-blown double buffering (keeping a bitmap in the WebView that holds the backing store for it).
       
 26698         
       
 26699         Reviewed by mjs
       
 26700 
       
 26701         * bridge/win/FrameWin.cpp:
       
 26702         (WebCore::FrameWin::addToDirtyRegion):
       
 26703         (WebCore::FrameWin::scrollBackingStore):
       
 26704         (WebCore::FrameWin::updateBackingStore):
       
 26705         * bridge/win/FrameWin.h:
       
 26706         * platform/win/PlatformScrollBar.h:
       
 26707         * platform/win/PlatformScrollBarWin.cpp:
       
 26708         (WebCore::PlatformScrollbar::windowClipRect):
       
 26709         * platform/win/ScrollViewWin.cpp:
       
 26710         (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
       
 26711         (WebCore::ScrollView::ScrollViewPrivate::windowClipRect):
       
 26712         (WebCore::ScrollView::updateContents):
       
 26713         (WebCore::ScrollView::updateScrollbars):
       
 26714         (WebCore::ScrollView::windowResizerRect):
       
 26715         (WebCore::ScrollView::addToDirtyRegion):
       
 26716         (WebCore::ScrollView::scrollBackingStore):
       
 26717         (WebCore::ScrollView::updateBackingStore):
       
 26718         * platform/win/WidgetWin.cpp:
       
 26719         (WebCore::Widget::suppressInvalidation):
       
 26720         (WebCore::Widget::invalidateRect):
       
 26721         * plugins/win/PluginViewWin.cpp:
       
 26722         (WebCore::PluginViewWin::windowClipRect):
       
 26723 
       
 26724 2006-10-11  Adam Roben  <aroben@apple.com>
       
 26725 
       
 26726         Rubberstamped by Brady.
       
 26727 
       
 26728         Clean up logic in Icon::newIconForFile.
       
 26729 
       
 26730         * platform/win/IconWin.cpp:
       
 26731         (WebCore::Icon::newIconForFile): Error case should return early.
       
 26732 
       
 26733 2006-10-11  Adam Roben  <aroben@apple.com>
       
 26734 
       
 26735         Reviewed by Steve.
       
 26736 
       
 26737         Fixes <rdar://problem/4777719>
       
 26738         Icons don't paint with CG
       
 26739 
       
 26740         * platform/win/IconWin.cpp:
       
 26741         (WebCore::Icon::paint): Remove Cairo-specific code now that we have
       
 26742         GraphicsContextWin.
       
 26743 
       
 26744 2006-10-11  Adam Roben  <aroben@apple.com>
       
 26745 
       
 26746         Rubberstamped by Anders.
       
 26747 
       
 26748         Clean up FileChooser::create, Icon::create.
       
 26749 
       
 26750         * platform/win/FileChooserWin.cpp:
       
 26751         (WebCore::FileChooser::create): Just return a FileChooser* and let the
       
 26752         implicit cast happen.
       
 26753         * platform/win/IconWin.cpp:
       
 26754         (WebCore::Icon::newIconForFile): Ditto for Icon*.
       
 26755 
       
 26756 2006-10-10  Adam Roben  <aroben@apple.com>
       
 26757 
       
 26758         Reviewed by Oliver.
       
 26759 
       
 26760         Fixes <rdar://problem/4731316>
       
 26761         Crash when <input type="file"> element removed while file chooser is open
       
 26762 
       
 26763         * platform/win/FileChooserWin.cpp: Make FileChooser ref-counted.
       
 26764         (WebCore::FileChooser::create):
       
 26765         (WebCore::FileChooser::openFileChooser): Add a protector RefPtr around
       
 26766         the call to GetOpenFileName so we don't get deleted while the file
       
 26767         chooser window is open.
       
 26768 
       
 26769 2006-10-10  Adam Roben  <aroben@apple.com>
       
 26770 
       
 26771         Reviewed by Anders.
       
 26772 
       
 26773         Fixes <rdar://problem/4772428>
       
 26774         <select> popup menus positioned incorrectly within frames
       
 26775 
       
 26776         * rendering/RenderPopupMenuWin.cpp:
       
 26777         (WebCore::RenderPopupMenuWin::setPositionAndSize): Use
       
 26778         contentsToWindow() instead of scrollOffset() to correct menu location.
       
 26779 
       
 26780 2006-10-10  Adam Roben  <aroben@apple.com>
       
 26781 
       
 26782         Reviewed by Adele.
       
 26783 
       
 26784         Fixes <rdar://problem/4763246>
       
 26785         Using arrow keys in <select> popup fires onChange event
       
 26786 
       
 26787         Also updates text shown in <select> element on page when using arrow
       
 26788         keys to change selection within the popup menu, and makes onChange fire
       
 26789         in the same cases as Firefox/IE.
       
 26790 
       
 26791         * rendering/RenderPopupMenuWin.cpp:
       
 26792         (WebCore::RenderPopupMenuWin::down): Update text of the <select>
       
 26793         control. Change call to valueChanged() so that onChange doesn't fire.
       
 26794         (WebCore::RenderPopupMenuWin::up): Ditto.
       
 26795         (WebCore::PopupWndProc): Don't fire onChange anytime selection changes.
       
 26796         Fire onChange when pressing Enter
       
 26797 
       
 26798 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
       
 26799 
       
 26800         Reviewed by Maciej.
       
 26801 
       
 26802         Fix <rdar://problem/4756255>
       
 26803         PDF/Acrobat Reader plugin don't work
       
 26804         
       
 26805         * bridge/win/FrameWin.cpp:
       
 26806         (WebCore::FrameWin::getObjectInstanceForWidget):
       
 26807         (WebCore::FrameWin::getEmbedInstanceForWidget):
       
 26808         Implement these, getting the instance from the plugin view.
       
 26809         
       
 26810         * platform/win/TemporaryLinkStubs.cpp:
       
 26811         Remove functions that are now implemented.
       
 26812         
       
 26813         * plugins/win/PlugInInfoStoreWin.cpp:
       
 26814         (WebCore::PlugInInfoStore::pluginCount):
       
 26815         (WebCore::PlugInInfoStore::supportsMIMEType):
       
 26816         Implement this, returning whether we a plugin exists for a given mime type.
       
 26817         
       
 26818         * plugins/win/PluginDatabaseWin.cpp:
       
 26819         (WebCore::parseVersionString):
       
 26820         (WebCore::compareVersions):
       
 26821         New functions for handling versions.
       
 26822         
       
 26823         (WebCore::addMozillaPluginPaths):
       
 26824         (WebCore::addWindowsMediaPlayerPluginPath):
       
 26825         (WebCore::addQuickTimePluginPath):
       
 26826         (WebCore::addJavaPluginPath):
       
 26827         (WebCore::addAdobeAcrobatPluginPath):
       
 26828         (WebCore::PluginDatabaseWin::defaultPluginPaths):
       
 26829         Factor out checks into separate functions, add checks for Java and Adobe Acrobat.
       
 26830 
       
 26831         (WebCore::PluginDatabaseWin::isMIMETypeRegistered):
       
 26832         Handle null MIME types.
       
 26833         
       
 26834         * plugins/win/PluginPackageWin.cpp:
       
 26835         (WebCore::PluginPackageWin::load):
       
 26836         Add some missing functions. Unload the library if the load failed.
       
 26837         
       
 26838         * plugins/win/PluginViewWin.cpp:
       
 26839         (WebCore::PluginViewWin::getValue):
       
 26840         Uncomment code for getting the element object.
       
 26841         
       
 26842         (WebCore::PluginViewWin::bindingInstance):
       
 26843         * plugins/win/PluginViewWin.h:
       
 26844         New function which fetches the plugin NPObject and wraps it in an instance.
       
 26845 
       
 26846 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
       
 26847 
       
 26848         Reviewed by Steve.
       
 26849 
       
 26850         Fix <rdar://problem/4773320>
       
 26851         Safari didn't pick up quicktime that was already installed
       
 26852         
       
 26853         * plugins/win/PluginDatabaseWin.cpp:
       
 26854         (WebCore::PluginDatabaseWin::defaultPluginPaths):
       
 26855         
       
 26856 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
       
 26857 
       
 26858         * WebCore.vcproj/WebCore.vcproj:
       
 26859         * bridge/win/FrameWin.h:
       
 26860         * platform/win/TemporaryLinkStubs.cpp:
       
 26861         (FrameWin::createJavaAppletWidget):
       
 26862         Fix build.
       
 26863 
       
 26864 2006-10-09  Adam Roben  <aroben@apple.com>
       
 26865 
       
 26866         Reviewed by Adele.
       
 26867 
       
 26868         Fixes <rdar://problem/4773142>
       
 26869         Crash in Settings::mediumFontSize() on ebay.com
       
 26870 
       
 26871         Call cancelAndClear() from ~FrameWin (just like Mac does) so we don't
       
 26872         end up calling the Frame::saveDocumentState, which is pure virtual.
       
 26873 
       
 26874         * bridge/win/FrameWin.cpp:
       
 26875         (WebCore::FrameWin::~FrameWin):
       
 26876 
       
 26877 2006-10-08  Adam Roben  <aroben@apple.com>
       
 26878 
       
 26879         Reviewed by Maciej.
       
 26880 
       
 26881         Port of OpenSource r16526, r16528
       
 26882 
       
 26883         Break up ResourceLoaderWndProc into callback functions.
       
 26884 
       
 26885         * platform/win/ResourceLoaderWin.cpp: Fix up #includes
       
 26886         (WebCore::): Remove loadStatusMessage, struct JobLoadStatus, add
       
 26887         messageHandlers array.
       
 26888         (WebCore::ResourceLoaderWndProc): Split handling of different messages
       
 26889         into callbacks.
       
 26890         (WebCore::ResourceLoader::onHandleCreated): New callback.
       
 26891         (WebCore::ResourceLoader::onRequestRedirected): New callback.
       
 26892         (WebCore::ResourceLoader::onRequestComplete): New callback.
       
 26893         (WebCore::initializeOffScreenResourceLoaderWindow): No need to register
       
 26894         loadStatusMessage anymore.
       
 26895         (WebCore::transferJobStatusCallback): Change how information is passed
       
 26896         into ResourceLoaderWndProc.
       
 26897 
       
 26898 2006-10-08  Dave Hyatt  <hyatt@apple.com>
       
 26899 
       
 26900         Add support for the Win2k/Classic theme for all controls.
       
 26901 
       
 26902         * rendering/RenderThemeWin.cpp:
       
 26903         (WebCore::RenderThemeWin::buttonTheme):
       
 26904         (WebCore::RenderThemeWin::textFieldTheme):
       
 26905         (WebCore::RenderThemeWin::menuListTheme):
       
 26906         (WebCore::RenderThemeWin::supportsHover):
       
 26907         (WebCore::RenderThemeWin::determineClassicState):
       
 26908         (WebCore::RenderThemeWin::getClassicThemeData):
       
 26909         (WebCore::RenderThemeWin::getThemeData):
       
 26910         (WebCore::drawControl):
       
 26911         (WebCore::RenderThemeWin::paintButton):
       
 26912         (WebCore::RenderThemeWin::paintTextField):
       
 26913         (WebCore::RenderThemeWin::paintMenuList):
       
 26914         * rendering/RenderThemeWin.h:
       
 26915         (WebCore::ThemeData::m_state):
       
 26916 
       
 26917 2006-10-07  Steve Falkenburg  <sfalken@apple.com>
       
 26918 
       
 26919         Reviewed by Adam.
       
 26920 
       
 26921         Fix <rdar://4772205> Regression (r10623): WinInet loader doesn't ever write to the cache.        
       
 26922 
       
 26923         * platform/win/ResourceLoaderWin.cpp:
       
 26924         (WebCore::ResourceLoaderWndProc): Apply POST related flags only for posts.
       
 26925         (WebCore::ResourceLoader::startHTTPRequest): Don't add no-cache-write flag to non-post transactions.
       
 26926 
       
 26927 2006-10-07  Dave Hyatt  <hyatt@apple.com>
       
 26928 
       
 26929         Add code to paint the Windows 2000 and "Windows Classic" theme look for scrollbars.
       
 26930 
       
 26931         * platform/win/PlatformScrollBarWin.cpp:
       
 26932         (WebCore::PlatformScrollbar::paintButton):
       
 26933         (WebCore::PlatformScrollbar::paintTrack):
       
 26934         (WebCore::PlatformScrollbar::paintThumb):
       
 26935         (WebCore::PlatformScrollbar::paintGripper):
       
 26936 
       
 26937 2006-10-07  Dave Hyatt  <hyatt@apple.com>
       
 26938 
       
 26939         Make sure frames and iframes honor scrolling="no" and
       
 26940         margins.
       
 26941 
       
 26942         * bridge/win/FrameWin.cpp:
       
 26943         (WebCore::FrameWin::createFrame):
       
 26944 
       
 26945 2006-10-07  Dave Hyatt  <hyatt@apple.com>
       
 26946 
       
 26947         Fix the resizer rect so that it is in the ScrollView's coordinate space and not in the document's coordinate space.
       
 26948         (Fixes all the layout errors with the scrollbar overlapping the resizer.)
       
 26949         
       
 26950         Fill scroll corners with white, since it matches Mac (and our chosen resizer look) and looks nicer anyway.
       
 26951         
       
 26952         * platform/win/ScrollViewWin.cpp:
       
 26953         (WebCore::ScrollView::updateScrollbars):
       
 26954         (WebCore::ScrollView::paint):
       
 26955 
       
 26956 2006-10-06  Dave Hyatt  <hyatt@apple.com>
       
 26957 
       
 26958         Make sure to update plugin clip regions when scrollbars come and go on a scrollview.
       
 26959        
       
 26960         * platform/win/ScrollViewWin.cpp:
       
 26961         (WebCore::ScrollView::updateScrollbars):
       
 26962 
       
 26963 2006-10-06  Dave Hyatt  <hyatt@apple.com>
       
 26964 
       
 26965         Revise the cached clip rect so that it is in the HWND's coordinate space.  This way SetWindowRgn
       
 26966         doesn't get wastefully called when the plugin is scrolled.
       
 26967        
       
 26968         * plugins/win/PluginViewWin.cpp:
       
 26969         (WebCore::PluginViewWin::updateHwnd):
       
 26970 
       
 26971 2006-10-06  Dave Hyatt  <hyatt@apple.com>
       
 26972 
       
 26973         Implement flawless clipping of windowed plugins, including
       
 26974         respecting nested frames, CSS overflow and CSS clip.  (This
       
 26975         puts Boomer way ahead of Mac as far as plugin clipping is
       
 26976         concerned).
       
 26977         
       
 26978         Implement support for correct blitting of scrolled subframes,
       
 26979         even when clipped by enclosing scrollviews.
       
 26980 
       
 26981         Fix a crash caused by focused children not being cleaned up
       
 26982         when they are removed from a scrollview.
       
 26983 
       
 26984         * platform/win/ScrollViewWin.cpp:
       
 26985         (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
       
 26986         (WebCore::ScrollView::setFrameGeometry):
       
 26987         (WebCore::ScrollView::addChild):
       
 26988         (WebCore::ScrollView::removeChild):
       
 26989         (WebCore::ScrollView::geometryChanged):
       
 26990         * plugins/win/PluginViewWin.cpp:
       
 26991         (WebCore::PluginViewWin::updateHwnd):
       
 26992         (WebCore::PluginViewWin::windowClipRect):
       
 26993         (WebCore::PluginViewWin::setFrameGeometry):
       
 26994         (WebCore::PluginViewWin::geometryChanged):
       
 26995         * plugins/win/PluginViewWin.h:
       
 26996 
       
 26997 2006-10-06  Geoffrey Garen  <ggaren@apple.com>
       
 26998 
       
 26999         Fixed <rdar://4768789> Crash on ebay.com in Frame::didOpenURL
       
 27000         
       
 27001         The issue was a resource loader making a callback to a
       
 27002         frame after the frame had been destroyed. This doesn't happen on Mac
       
 27003         because Mac WebKit cancels all loads before tearing down frames.
       
 27004         
       
 27005         The solution is to add a callback to Win WebKit to allow a frame
       
 27006         to cancel its main resource load. This is a temporary work-around.
       
 27007         It is temporary because it doesn't address pending subresource loads.
       
 27008         The long-term solution we anticipate is to have a legitimate loader
       
 27009         inside WebCore.
       
 27010 
       
 27011         * ChangeLog:
       
 27012         * bridge/win/FrameWin.cpp:
       
 27013         (WebCore::FrameWin::~FrameWin):
       
 27014         * bridge/win/FrameWin.h:
       
 27015 
       
 27016 2006-10-06  Steve Falkenburg  <sfalken@apple.com>
       
 27017 
       
 27018         Reviewed by Adam, Lou.
       
 27019 
       
 27020         Resizer fixes.
       
 27021         We now properly invalidate and draw overlapping contents or opaque.
       
 27022 
       
 27023         * platform/win/ScrollViewWin.cpp:
       
 27024         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
       
 27025         (WebCore::ScrollView::updateScrollbars):
       
 27026         (WebCore::ScrollView::resizerOverlapsContent):
       
 27027 
       
 27028 2006-10-06  Anders Carlsson  <acarlsson@apple.com>
       
 27029 
       
 27030         Reviewed by Adam.
       
 27031 
       
 27032         * plugins/win/PluginDatabaseWin.cpp:
       
 27033         (WebCore::PluginDatabaseWin::defaultPluginPaths):
       
 27034         Add (commented out) WMP plugin check.
       
 27035 
       
 27036 2006-10-06  Anders Carlsson  <acarlsson@apple.com>
       
 27037 
       
 27038         Reviewed by Brady and Geoff.
       
 27039 
       
 27040         <rdar://problems/4769023>
       
 27041         Crash on cnettv.com - PluginStreamWin::receivedResponse
       
 27042         
       
 27043         * platform/win/ResourceLoaderWin.cpp:
       
 27044         (WebCore::ResourceLoaderWndProc):
       
 27045         If the Content-Type header is missing, try to figure o ut the content type
       
 27046         from the file extension. Failing that, just use "application/octet-stream".
       
 27047 
       
 27048 2006-10-06  Adam Roben  <aroben@apple.com>
       
 27049 
       
 27050         Reviewed by Maciej.
       
 27051 
       
 27052         Some loader improvements, courtesy of Steve.
       
 27053 
       
 27054         Functionally, the improvements are these:
       
 27055         1. Support HTTP Authentication
       
 27056         2. Respect WinInet errors better
       
 27057 
       
 27058         There are also some general code cleanups, like extracting the creation
       
 27059         of an HTTP request into its own method.
       
 27060 
       
 27061         * platform/win/ResourceLoaderWin.cpp: Add dwError field to
       
 27062         JobLoadStatus to store WinInet error codes. Also removed the
       
 27063         globalInternetHandle() function as the global HINTERNET is now only
       
 27064         needed within startHTTPRequest.
       
 27065         (WebCore::ResourceLoaderWndProc): Respect error codes and add HTTP
       
 27066         Authentication support. Also, process HTTP status codes as ints instead
       
 27067         of strings.
       
 27068         (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): Cleanup
       
 27069         m_formData
       
 27070         (WebCore::transferJobStatusCallback): Cleanup the code, and set
       
 27071         dwError.
       
 27072         (WebCore::ResourceLoader::startHTTPRequest): New method to start a new
       
 27073         HTTP request.
       
 27074         (WebCore::ResourceLoader::start): Restructure code.
       
 27075 
       
 27076 2006-10-06  Dave Hyatt  <hyatt@apple.com>
       
 27077 
       
 27078         Fix the plugins on cnn.com.  Don't let the scroll view move child plugins around if it hasn't even been parented yet.
       
 27079         
       
 27080         Fix an assert in widget destructors caused by not unparenting a ScrollView's scrollbars in its destructor.
       
 27081         
       
 27082         * platform/win/ScrollViewWin.cpp:
       
 27083         (WebCore::ScrollView::ScrollViewPrivate::~ScrollViewPrivate):
       
 27084         (WebCore::ScrollView::setFrameGeometry):
       
 27085 
       
 27086 2006-10-06  Dave Hyatt  <hyatt@apple.com>
       
 27087 
       
 27088         Make sure that plugin windows get properly moved if an ancestor scrollview is shifted without changing its size (meaning
       
 27089         that layout doesn't get called on the scrollview to update the widget positions).
       
 27090         
       
 27091         Fixes the plugins on osnews.com.
       
 27092         
       
 27093         * platform/win/ScrollViewWin.cpp:
       
 27094         (WebCore::ScrollView::setFrameGeometry):
       
 27095 
       
 27096 2006-10-05  Steve Falkenburg  <sfalken@apple.com>
       
 27097 
       
 27098         Reviewed by aroben.
       
 27099 
       
 27100         Scrollbars now dodge resizing gripper.
       
 27101 
       
 27102         * bridge/win/FrameViewWin.cpp:
       
 27103         (WebCore::FrameView::windowResizerRect): added.
       
 27104         * bridge/win/FrameWin.cpp:
       
 27105         (WebCore::FrameWin::windowResizerRect): added.
       
 27106         * bridge/win/FrameWin.h:
       
 27107         * platform/win/ScrollViewWin.cpp:
       
 27108         (WebCore::ScrollView::updateScrollbars): Scrollbars now dodge resizing gripper.
       
 27109 
       
 27110 2006-10-05  Dave Hyatt  <hyatt@apple.com>
       
 27111 
       
 27112         Fix a bug where scrollbars would incorrectly show up for iframes when they weren't needed.
       
 27113         Change the flow of control to be more like Mac.
       
 27114 
       
 27115         * platform/win/ScrollViewWin.cpp:
       
 27116         (WebCore::ScrollView::resizeContents):
       
 27117         (WebCore::ScrollView::setFrameGeometry):
       
 27118 
       
 27119 2006-10-05  Dave Hyatt  <hyatt@apple.com>
       
 27120 
       
 27121         Fix clipping and transforms by making sure to propagate them as they happen on the CGContext over into the HDC.
       
 27122         
       
 27123         * platform/cg/GraphicsContextPlatformPrivate.h:
       
 27124         * platform/win/GraphicsContextWin.cpp:
       
 27125         (WebCore::CGContextWithHDC):
       
 27126         (WebCore::GraphicsContext::getWindowsContext):
       
 27127         (WebCore::GraphicsContext::releaseWindowsContext):
       
 27128         (WebCore::GraphicsContextPlatformPrivate::save):
       
 27129         (WebCore::GraphicsContextPlatformPrivate::restore):
       
 27130         (WebCore::GraphicsContextPlatformPrivate::clip):
       
 27131         (WebCore::GraphicsContextPlatformPrivate::scale):
       
 27132         (WebCore::GraphicsContextPlatformPrivate::rotate):
       
 27133         (WebCore::GraphicsContextPlatformPrivate::translate):
       
 27134         (WebCore::GraphicsContextPlatformPrivate::concatCTM):
       
 27135         * platform/win/TemporaryLinkStubs.cpp:
       
 27136         (GraphicsContextPlatformPrivate::clip):
       
 27137 
       
 27138 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
       
 27139 
       
 27140         build fix.
       
 27141         
       
 27142         * platform/win/WidgetWin.cpp:
       
 27143         (WebCore::Widget::~Widget):
       
 27144         (WebCore::Widget::setParent):
       
 27145         (WebCore::Widget::parent):
       
 27146         (WebCore::Widget::removeFromParent):
       
 27147 
       
 27148 2006-10-05  David Hyatt  <hyatt@apple.com>
       
 27149 
       
 27150         Stub out GraphicsContextPlatformPrivate methods so that the HDC can
       
 27151         be updated when clips/transforms are applied.
       
 27152 
       
 27153         Reviewed by darin
       
 27154 
       
 27155         * platform/cg/GraphicsContextPlatformPrivate.h:
       
 27156         (WebCore::GraphicsContextPlatformPrivate::save):
       
 27157         (WebCore::GraphicsContextPlatformPrivate::restore):
       
 27158         (WebCore::GraphicsContextPlatformPrivate::clip):
       
 27159         (WebCore::GraphicsContextPlatformPrivate::scale):
       
 27160         (WebCore::GraphicsContextPlatformPrivate::rotate):
       
 27161         (WebCore::GraphicsContextPlatformPrivate::translate):
       
 27162         (WebCore::GraphicsContextPlatformPrivate::concatCTM):
       
 27163 
       
 27164 2006-10-05  Adam Roben  <aroben@apple.com>
       
 27165 
       
 27166         Build fix.
       
 27167 
       
 27168         * platform/win/TemporaryLinkStubs.cpp:
       
 27169         (BrowserExtensionWin::BrowserExtensionWin): Change Frame* to FrameWin*
       
 27170 
       
 27171 2006-10-05  Adam Roben  <aroben@apple.com>
       
 27172 
       
 27173         Build fix. Remove RenderImageButton.{h,cpp}.
       
 27174 
       
 27175         * WebCore.vcproj/WebCore.vcproj:
       
 27176 
       
 27177 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
       
 27178 
       
 27179         Reviewed by Darin.
       
 27180         
       
 27181         Fixed <rdar://problem/4766987>
       
 27182         
       
 27183         - renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case
       
 27184         except for file names.
       
 27185         
       
 27186         - fixed RenderLayer to properly tear down scrollbars, removing them from
       
 27187         their parents.
       
 27188 
       
 27189         * bridge/win/FrameViewWin.cpp:
       
 27190         (WebCore::FrameView::passMousePressEventToScrollbar):
       
 27191         * platform/win/PlatformScrollBar.h:
       
 27192         (WebCore::):
       
 27193         * platform/win/PlatformScrollBarWin.cpp:
       
 27194         (WebCore::PlatformScrollbar::PlatformScrollbar):
       
 27195         (WebCore::PlatformScrollbar::~PlatformScrollbar):
       
 27196         (WebCore::PlatformScrollbar::updateThumbPosition):
       
 27197         (WebCore::PlatformScrollbar::updateThumbProportion):
       
 27198         (WebCore::PlatformScrollbar::invalidateTrack):
       
 27199         (WebCore::PlatformScrollbar::invalidatePart):
       
 27200         (WebCore::PlatformScrollbar::width):
       
 27201         (WebCore::PlatformScrollbar::height):
       
 27202         (WebCore::PlatformScrollbar::setRect):
       
 27203         (WebCore::PlatformScrollbar::setEnabled):
       
 27204         (WebCore::PlatformScrollbar::paint):
       
 27205         (WebCore::PlatformScrollbar::backButtonRect):
       
 27206         (WebCore::PlatformScrollbar::forwardButtonRect):
       
 27207         (WebCore::PlatformScrollbar::trackRect):
       
 27208         (WebCore::PlatformScrollbar::thumbRect):
       
 27209         (WebCore::PlatformScrollbar::gripperRect):
       
 27210         (WebCore::PlatformScrollbar::splitTrack):
       
 27211         (WebCore::PlatformScrollbar::thumbPosition):
       
 27212         (WebCore::PlatformScrollbar::thumbLength):
       
 27213         (WebCore::PlatformScrollbar::trackLength):
       
 27214         (WebCore::PlatformScrollbar::paintButton):
       
 27215         (WebCore::PlatformScrollbar::paintTrack):
       
 27216         (WebCore::PlatformScrollbar::paintThumb):
       
 27217         (WebCore::PlatformScrollbar::paintGripper):
       
 27218         (WebCore::PlatformScrollbar::hitTest):
       
 27219         (WebCore::PlatformScrollbar::handleMouseMoveEvent):
       
 27220         (WebCore::PlatformScrollbar::handleMouseOutEvent):
       
 27221         (WebCore::PlatformScrollbar::handleMousePressEvent):
       
 27222         (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
       
 27223         (WebCore::PlatformScrollbar::startTimerIfNeeded):
       
 27224         (WebCore::PlatformScrollbar::stopTimerIfNeeded):
       
 27225         (WebCore::PlatformScrollbar::autoscrollPressedPart):
       
 27226         (WebCore::PlatformScrollbar::autoscrollTimerFired):
       
 27227         (WebCore::PlatformScrollbar::pressedPartScrollDirection):
       
 27228         (WebCore::PlatformScrollbar::pressedPartScrollGranularity):
       
 27229         (WebCore::PlatformScrollbar::thumbUnderMouse):
       
 27230         (WebCore::PlatformScrollbar::themeChanged):
       
 27231         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
       
 27232         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
       
 27233         * platform/win/ScrollViewWin.cpp:
       
 27234         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
       
 27235         (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
       
 27236         (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
       
 27237         (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
       
 27238         (WebCore::ScrollView::resizeContents):
       
 27239         (WebCore::ScrollView::scrollBy):
       
 27240         (WebCore::ScrollView::hScrollbarMode):
       
 27241         (WebCore::ScrollView::vScrollbarMode):
       
 27242         (WebCore::ScrollView::suppressScrollbars):
       
 27243         (WebCore::ScrollView::setHScrollbarMode):
       
 27244         (WebCore::ScrollView::setVScrollbarMode):
       
 27245         (WebCore::ScrollView::setScrollbarsMode):
       
 27246         (WebCore::ScrollView::updateScrollbars):
       
 27247         (WebCore::ScrollView::scrollbarUnderMouse):
       
 27248         (WebCore::ScrollView::paint):
       
 27249         (WebCore::ScrollView::themeChanged):
       
 27250 
       
 27251 2006-10-05  Adam Roben  <aroben@apple.com>
       
 27252 
       
 27253         Reviewed by Maciej.
       
 27254 
       
 27255         Fixes <rdar://problem/4757387>
       
 27256         Unable to sign on to my.yahoo.com
       
 27257 
       
 27258         This patch fixes a number of bugs that all resulted in not being able
       
 27259         to log on to many websites. The problems were that we weren't allowing
       
 27260         redirects between HTTP and HTTPS sites and weren't correctly handling
       
 27261         redirects from POST requests to GET requests.
       
 27262 
       
 27263         * platform/win/ResourceLoaderWin.cpp:
       
 27264         (WebCore::globalInternetHandle): Move internetHandle and callbackHandle
       
 27265         into file scope, and add this function to initialize them.
       
 27266         (WebCore::logLastError): Add this debug logging function to give more
       
 27267         readable WinInet error messages.
       
 27268         (WebCore::ResourceLoaderWndProc): The most substantial change here is
       
 27269         to allow redirects from POST to GET to function correctly. To do this
       
 27270         we have to create a new HINTERNET for the GET. We also have to be sure
       
 27271         not to try to read from our now-invalid handles after the redirect.
       
 27272         (WebCore::transferJobStatusCallback): Rename timerId to jobId, since
       
 27273         that's what it is.
       
 27274         (WebCore::ResourceLoader::start): Call new static initializer, and pass
       
 27275         flags to allow HTTP<->HTTPS redirects. Also change a few delete calls
       
 27276         to kill().
       
 27277 
       
 27278 2006-10-05  Maciej Stachowiak  <mjs@apple.com>
       
 27279 
       
 27280         Reviewed by Adam.
       
 27281 
       
 27282         - changed ResourceLoader to be refcounted
       
 27283 
       
 27284         It keeps a ref on itself while loading as well. This makes
       
 27285         for a much saner memory management model than the previous.
       
 27286 
       
 27287         In addition, keep it ref'd across all of ResourceLoaderWndProc
       
 27288         to avoid sending messages to jobs that get deleted partway.
       
 27289 
       
 27290         This fixes <rdar://problem/4766859> Crash in ResourceLoaderWndProc - line 232 at televisionwithoutpity.com, washingtonpost.com
       
 27291 
       
 27292         * platform/win/ResourceLoaderWin.cpp:
       
 27293         (WebCore::ResourceLoaderWndProc):
       
 27294         (WebCore::ResourceLoader::start):
       
 27295         * plugins/win/PluginStreamWin.cpp:
       
 27296         (WebCore::PluginStreamWin::PluginStreamWin):
       
 27297         (WebCore::PluginStreamWin::start):
       
 27298         (WebCore::PluginStreamWin::stop):
       
 27299         * plugins/win/PluginStreamWin.h:
       
 27300 
       
 27301 2006-10-05  Dave Hyatt  <hyatt@apple.com>
       
 27302 
       
 27303         Make key events work with iframes.  Implement scrolling keyboard behavior.  Fix a bug with mouse wheeling that
       
 27304         made it fail on iframes nested within iframes.
       
 27305         
       
 27306         Reviewed by mjs
       
 27307 
       
 27308         * bridge/win/FrameViewWin.cpp:
       
 27309         (WebCore::FrameView::passWheelEventToSubframe):
       
 27310         * platform/win/ScrollViewWin.cpp:
       
 27311         (WebCore::ScrollView::scroll):
       
 27312         * platform/win/WidgetWin.cpp:
       
 27313         (WebCore::Widget::Widget):
       
 27314         (WebCore::Widget::capturingMouse):
       
 27315         (WebCore::Widget::setCapturingMouse):
       
 27316         (WebCore::Widget::capturingTarget):
       
 27317         (WebCore::Widget::setCapturingChild):
       
 27318         (WebCore::Widget::hasFocus):
       
 27319         (WebCore::Widget::setFocus):
       
 27320         (WebCore::Widget::clearFocus):
       
 27321         (WebCore::Widget::setFocused):
       
 27322         (WebCore::Widget::focusedTarget):
       
 27323         (WebCore::Widget::focusedChild):
       
 27324         (WebCore::Widget::setFocusedChild):
       
 27325         (WebCore::Widget::clearFocusFromDescendants):
       
 27326 
       
 27327 2006-10-05  Adam Roben  <aroben@apple.com>
       
 27328 
       
 27329         Reviewed by Maciej and Tim H.
       
 27330 
       
 27331         Fixes <rdar://problem/4760991>
       
 27332         Flash content doesn't go away when navigating to a new page
       
 27333 
       
 27334         Actually destroy subframes when detaching.
       
 27335 
       
 27336         * bridge/win/FrameWin.cpp:
       
 27337         (WebCore::FrameWin::frameDetached): 
       
 27338         * bridge/win/FrameWin.h:
       
 27339 
       
 27340 2006-10-05  Anders Carlsson  <acarlsson@apple.com>
       
 27341 
       
 27342         Reviewed by Maciej.
       
 27343         
       
 27344         <rdar://problem/4762998>
       
 27345         REGRESSION: dragging to select text does not work
       
 27346         
       
 27347         * platform/win/PlatformMouseEventWin.cpp:
       
 27348         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
       
 27349         Set the correct button for WM_MOUSEMOVE events.
       
 27350 
       
 27351 2006-10-05  Anders Carlsson  <acarlsson@apple.com>
       
 27352 
       
 27353         Reviewed by Adam.
       
 27354 
       
 27355         rdar://problem/4757081
       
 27356         Crashes/hangs when using Flash 8 plugin (Flash 9 works MUCH better)
       
 27357         
       
 27358         * plugins/win/PluginStreamWin.cpp:
       
 27359         (WebCore::PluginStreamWin::startStream):
       
 27360         Encode javascript URLs before passing them to the plugin.
       
 27361 
       
 27362 2006-10-05  Darin Adler  <darin@apple.com>
       
 27363 
       
 27364         Reviewed by Adam.
       
 27365 
       
 27366         * platform/win/NotImplemented.h: Changed implementation to use Assertions.h.
       
 27367         Also fixed both macros to be single-statement macros.
       
 27368 
       
 27369 2006-10-05  Darin Adler  <darin@apple.com>
       
 27370 
       
 27371         Reviewed by Adam.
       
 27372 
       
 27373         - fix <rdar://problem/4764253>
       
 27374           frame targeting not implemented.
       
 27375 
       
 27376         * bridge/win/FrameWin.h: Added new window boolean to openURL. Also changed
       
 27377         type from DeprecatedString to String.
       
 27378         * bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Added logic
       
 27379         to do frame targeting.
       
 27380 
       
 27381         * platform/win/BString.h: Added. Convenience for working with
       
 27382         BSTR and handling allocation/free.
       
 27383         * platform/win/BString.cpp: Added.
       
 27384         * WebCore.vcproj/WebCore.vcproj: Added new files.
       
 27385 
       
 27386 2006-10-03  Dave Hyatt  <hyatt@apple.com>
       
 27387 
       
 27388         Land the new ScrollView.
       
 27389         
       
 27390         Reviewed by anders
       
 27391 
       
 27392         * bridge/win/FrameViewWin.cpp:
       
 27393         (WebCore::FrameView::passMousePressEventToScrollbar):
       
 27394         * platform/win/PlatformScrollBar.h:
       
 27395         * platform/win/PlatformScrollBarWin.cpp:
       
 27396         (WebCore::PlatformScrollBar::thumbLength):
       
 27397         (WebCore::PlatformScrollBar::hitTest):
       
 27398         (WebCore::PlatformScrollBar::horizontalScrollBarHeight):
       
 27399         (WebCore::PlatformScrollBar::verticalScrollBarWidth):
       
 27400         * platform/win/ScrollViewWin.cpp:
       
 27401         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
       
 27402         (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollBar):
       
 27403         (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollBar):
       
 27404         (WebCore::ScrollView::ScrollViewPrivate::valueChanged):
       
 27405         (WebCore::ScrollView::ScrollView):
       
 27406         (WebCore::ScrollView::updateContents):
       
 27407         (WebCore::ScrollView::visibleWidth):
       
 27408         (WebCore::ScrollView::visibleHeight):
       
 27409         (WebCore::ScrollView::visibleContentRect):
       
 27410         (WebCore::ScrollView::resizeContents):
       
 27411         (WebCore::ScrollView::contentsWidth):
       
 27412         (WebCore::ScrollView::contentsHeight):
       
 27413         (WebCore::ScrollView::windowToContents):
       
 27414         (WebCore::ScrollView::contentsToWindow):
       
 27415         (WebCore::ScrollView::convertChildToSelf):
       
 27416         (WebCore::ScrollView::convertSelfToChild):
       
 27417         (WebCore::ScrollView::scrollOffset):
       
 27418         (WebCore::ScrollView::maximumScroll):
       
 27419         (WebCore::ScrollView::scrollBy):
       
 27420         (WebCore::ScrollView::scrollPointRecursively):
       
 27421         (WebCore::ScrollView::hScrollBarMode):
       
 27422         (WebCore::ScrollView::vScrollBarMode):
       
 27423         (WebCore::ScrollView::suppressScrollBars):
       
 27424         (WebCore::ScrollView::setHScrollBarMode):
       
 27425         (WebCore::ScrollView::setVScrollBarMode):
       
 27426         (WebCore::ScrollView::setScrollBarsMode):
       
 27427         (WebCore::ScrollView::setStaticBackground):
       
 27428         (WebCore::ScrollView::updateScrollBars):
       
 27429         (WebCore::ScrollView::scrollbarUnderMouse):
       
 27430         (WebCore::ScrollView::addChild):
       
 27431         (WebCore::ScrollView::removeChild):
       
 27432         (WebCore::ScrollView::paint):
       
 27433         (WebCore::ScrollView::scrolled):
       
 27434         * platform/win/WidgetWin.cpp:
       
 27435         (WebCore::Widget::Widget):
       
 27436         (WebCore::Widget::convertToContainingWindow):
       
 27437         (WebCore::Widget::convertFromContainingWindow):
       
 27438         (WebCore::Widget::convertChildToSelf):
       
 27439         (WebCore::Widget::convertSelfToChild):
       
 27440         (WebCore::Widget::setSuppressInvalidation):
       
 27441         (WebCore::Widget::invalidateRect):
       
 27442         * plugins/win/PluginViewWin.cpp:
       
 27443         (WebCore::PluginViewWndProc):
       
 27444         (WebCore::PluginViewWin::setFrameGeometry):
       
 27445         (WebCore::PluginViewWin::scrolled):
       
 27446         * plugins/win/PluginViewWin.h:
       
 27447 
       
 27448 2006-10-03  Adam Roben  <aroben@apple.com>
       
 27449 
       
 27450         Reviewed by Steve.
       
 27451 
       
 27452         Improvements to error handling in PluginStreamWin.
       
 27453 
       
 27454         * plugins/win/PluginStreamWin.cpp:
       
 27455         (WebCore::PluginStreamWin::deliverData): Fail quietly if called after
       
 27456         termination (due to bad error handling in ResourceLoaderWin), ASSERT if
       
 27457         called before stream has been started.
       
 27458         (WebCore::PluginStreamWin::receivedData): Ditto.
       
 27459         (WebCore::PluginStreamWin::receivedAllData): Ditto.
       
 27460 
       
 27461 2006-10-03  Adam Roben  <aroben@apple.com>
       
 27462 
       
 27463         Reviewed by Anders.
       
 27464 
       
 27465         Fixes <rdar://problem/4760963>
       
 27466         Failed ASSERT in PluginStreamWin::~PluginStreamWin at espn.com
       
 27467 
       
 27468         We now store the state of a stream as a tri-state enum in
       
 27469         m_streamState. This allows us to differentiate between before and after the
       
 27470         stream has been started.
       
 27471 
       
 27472         * plugins/win/PluginStreamWin.cpp:
       
 27473         (WebCore::PluginStreamWin::PluginStreamWin): Initialize members of
       
 27474         m_stream struct individually.
       
 27475         (WebCore::PluginStreamWin::~PluginStreamWin):
       
 27476         (WebCore::PluginStreamWin::startStream):
       
 27477         (WebCore::PluginStreamWin::destroyStream):
       
 27478         (WebCore::PluginStreamWin::deliverData): Return early if the stream
       
 27479         isn't started.
       
 27480         (WebCore::PluginStreamWin::receivedData): Ditto.
       
 27481         (WebCore::PluginStreamWin::receivedAllData): Ditto.
       
 27482         * plugins/win/PluginStreamWin.h:
       
 27483         (WebCore::): Add PluginStreamState enum.
       
 27484 
       
 27485 2006-10-03  Adam Roben  <aroben@apple.com>
       
 27486 
       
 27487         Reviewed by Darin.
       
 27488 
       
 27489         Fixes <rdar://problem/4603342>
       
 27490         Keyboard navigability
       
 27491 
       
 27492         Implement tabbing between form elements (in the single-frame case).
       
 27493 
       
 27494         * bridge/win/FrameWin.cpp: Add methods to determine tabbing
       
 27495         preferences.
       
 27496         (WebCore::FrameWin::tabsToLinks):
       
 27497         (WebCore::FrameWin::tabsToAllControls):
       
 27498         * bridge/win/FrameWin.h: Add tabsToLinks() to FrameWinClient
       
 27499         * platform/win/ScrollViewWin.cpp:
       
 27500         (WebCore::ScrollView::scrollPointRecursively): Implemented for
       
 27501         single-frame case.
       
 27502         * platform/win/TemporaryLinkStubs.cpp: Remove stub for now-implemented
       
 27503         ScrollView::scrollPointsRecursively
       
 27504 
       
 27505 2006-10-02  Adam Roben  <aroben@apple.com>
       
 27506 
       
 27507         Reviewed by Maciej.
       
 27508 
       
 27509         Fixes <rdar://problem/4743497>
       
 27510         Can't check checkboxes
       
 27511 
       
 27512         Let Windows determine which mouse button is pressed.
       
 27513 
       
 27514         * platform/win/PlatformMouseEventWin.cpp:
       
 27515         (WebCore::PlatformMouseEvent::PlatformMouseEvent): Use message
       
 27516         parameter to determine which mouse button is pressed.
       
 27517 
       
 27518 2006-10-02  Steve Falkenburg  <sfalken@apple.com>
       
 27519 
       
 27520         Reviewed by Hyatt.
       
 27521 
       
 27522         <rdar://4757387> (partial fix) Unable to sign on to my.yahoo.com
       
 27523         <rdar://4757405> (partial fix) Unable to log onto secure site (www.schwab.com)
       
 27524         <rdar://4757411> (partial fix) Unable to log onto any AppleConnect site (but using back and resubmiting works)
       
 27525 
       
 27526         WinInet fixes.
       
 27527         Don't post data using HTTP when HTTPS should be used.
       
 27528         Fix redirect from POST to GET case.
       
 27529         
       
 27530         There is a remaining bug with the way that we queue WinInet callbacks
       
 27531         still to be addressed.
       
 27532 
       
 27533         * platform/win/ResourceLoaderWin.cpp:
       
 27534         (WebCore::addToOutstandingJobs): Skip dwContext of 0 (rollover case).
       
 27535         (WebCore::ResourceLoaderWndProc): Call default wndproc properly.
       
 27536             Pass INTERNET_FLAG_SECURE when necessary for HTTPS.
       
 27537             Fix redirect code.
       
 27538             Initialize buffers struct.
       
 27539             Pass proper context in InternetReadFileExA
       
 27540         (WebCore::initializeOffScreenResourceLoaderWindow): Init a struct to {0} instead of using memset.
       
 27541         (WebCore::transferJobStatusCallback): Prevent future bugs by making an else a bit more explicit.
       
 27542         (WebCore::ResourceLoader::start): Pass proper port for HTTP vs. HTTPS.
       
 27543         (WebCore::ResourceLoader::cancel): Zero out handle when closing.
       
 27544 
       
 27545 2006-10-01  Dave Hyatt  <hyatt@apple.com>
       
 27546 
       
 27547         Finish the scrollbar.  Handle arrow and track scrolling.  Everything is finished now except for implementing a Win2k look.
       
 27548 
       
 27549         * platform/win/PlatformScrollBar.h:
       
 27550         * platform/win/PlatformScrollBarWin.cpp:
       
 27551         (WebCore::PlatformScrollBar::PlatformScrollBar):
       
 27552         (WebCore::PlatformScrollBar::~PlatformScrollBar):
       
 27553         (WebCore::PlatformScrollBar::thumbRect):
       
 27554         (WebCore::PlatformScrollBar::handleMouseMoveEvent):
       
 27555         (WebCore::PlatformScrollBar::handleMousePressEvent):
       
 27556         (WebCore::PlatformScrollBar::handleMouseReleaseEvent):
       
 27557         (WebCore::PlatformScrollBar::startTimerIfNeeded):
       
 27558         (WebCore::PlatformScrollBar::stopTimerIfNeeded):
       
 27559         (WebCore::PlatformScrollBar::autoscrollPressedPart):
       
 27560         (WebCore::PlatformScrollBar::autoscrollTimerFired):
       
 27561         (WebCore::PlatformScrollBar::pressedPartScrollDirection):
       
 27562         (WebCore::PlatformScrollBar::pressedPartScrollGranularity):
       
 27563         (WebCore::PlatformScrollBar::thumbUnderMouse):
       
 27564 
       
 27565 2006-10-01  Dave Hyatt  <hyatt@apple.com>
       
 27566         
       
 27567         Make thumb dragging work on the scrollbar.
       
 27568         
       
 27569         Fix mouse and wheel events to use GET_X_LPARAM and GET_Y_LPARAM so that negative coordinates work.
       
 27570         (This comes up when a widget is capturing events and the mouse moves outside the HWND.)
       
 27571         
       
 27572         * platform/win/PlatformMouseEventWin.cpp:
       
 27573         (WebCore::positionForEvent):
       
 27574         (WebCore::globalPositionForEvent):
       
 27575         * platform/win/PlatformScrollBar.h:
       
 27576         * platform/win/PlatformScrollBarWin.cpp:
       
 27577         (WebCore::PlatformScrollBar::PlatformScrollBar):
       
 27578         (WebCore::PlatformScrollBar::handleMouseMoveEvent):
       
 27579         (WebCore::PlatformScrollBar::handleMousePressEvent):
       
 27580         (WebCore::PlatformScrollBar::handleMouseReleaseEvent):
       
 27581         (WebCore::PlatformScrollBar::startTimerIfNeeded):
       
 27582         (WebCore::PlatformScrollBar::stopTimerIfNeeded):
       
 27583         * platform/win/WheelEventWin.cpp:
       
 27584         (WebCore::positionForEvent):
       
 27585         (WebCore::globalPositionForEvent):
       
 27586 
       
 27587 2006-10-01  Dave Hyatt  <hyatt@apple.com>
       
 27588 
       
 27589         Hook up the mouse capture architecture so that child widgets capture events while the mouse is pressed.
       
 27590         
       
 27591         Hook up tracking the pressed object on a scrollbar and proper painting of the scrollbar's
       
 27592         pressed state.
       
 27593         
       
 27594         * bridge/win/FrameViewWin.cpp:
       
 27595         (WebCore::FrameView::passMousePressEventToSubframe):
       
 27596         (WebCore::FrameView::passMousePressEventToScrollbar):
       
 27597         * platform/win/PlatformScrollBar.h:
       
 27598         * platform/win/PlatformScrollBarWin.cpp:
       
 27599         (WebCore::PlatformScrollBar::PlatformScrollBar):
       
 27600         (WebCore::PlatformScrollBar::paintButton):
       
 27601         (WebCore::PlatformScrollBar::paintTrack):
       
 27602         (WebCore::PlatformScrollBar::paintThumb):
       
 27603         (WebCore::PlatformScrollBar::paintGripper):
       
 27604         (WebCore::PlatformScrollBar::handleMouseMoveEvent):
       
 27605         (WebCore::PlatformScrollBar::handleMousePressEvent):
       
 27606         (WebCore::PlatformScrollBar::handleMouseReleaseEvent):
       
 27607         * platform/win/WidgetWin.cpp:
       
 27608         (WebCore::Widget::setCapturingChild):
       
 27609 
       
 27610 2006-09-30  Dave Hyatt  <hyatt@apple.com>
       
 27611 
       
 27612         This patch makes iframes and frames able to receive mouse events.  Down, up, click, selection
       
 27613         all work.  This patch also fixes bugs in scrolling and makes wheel events work on iframes.
       
 27614         A capturing system for routing events to the proper subwidget when the mouse has down
       
 27615         is also stubbed out (but not yet used).
       
 27616         
       
 27617         Reviewed by andersca
       
 27618 
       
 27619         * WebCore.vcproj/WebCore.vcproj:
       
 27620         * bridge/win/FrameViewWin.cpp: Added.
       
 27621         (WebCore::FrameView::passMousePressEventToSubframe):
       
 27622         (WebCore::FrameView::passMouseMoveEventToSubframe):
       
 27623         (WebCore::FrameView::passMouseReleaseEventToSubframe):
       
 27624         (WebCore::FrameView::passWheelEventToSubframe):
       
 27625         * bridge/win/FrameWin.cpp:
       
 27626         * bridge/win/FrameWin.h:
       
 27627         * platform/win/PlatformScrollBar.h:
       
 27628         * platform/win/PlatformScrollBarWin.cpp:
       
 27629         (WebCore::PlatformScrollBar::handleMouseMoveEvent):
       
 27630         (WebCore::PlatformScrollBar::handleMouseOutEvent):
       
 27631         (WebCore::PlatformScrollBar::handleMouseReleaseEvent):
       
 27632         * platform/win/ScrollViewWin.cpp:
       
 27633         (WebCore::ScrollView::visibleContentRect):
       
 27634         (WebCore::ScrollView::scrollBy):
       
 27635         (WebCore::ScrollView::removeChild):
       
 27636         * platform/win/TemporaryLinkStubs.cpp:
       
 27637         (FrameWin::print):
       
 27638         (FrameWin::lastEventIsMouseUp):
       
 27639         * platform/win/WidgetWin.cpp:
       
 27640         (WebCore::Widget::Widget):
       
 27641         (WebCore::Widget::capturingMouse):
       
 27642         (WebCore::Widget::setCapturingMouse):
       
 27643         (WebCore::Widget::capturingTarget):
       
 27644         (WebCore::Widget::capturingChild):
       
 27645         (WebCore::Widget::setCapturingChild):
       
 27646 
       
 27647 2006-09-29  Steve Falkenburg  <sfalken@apple.com>
       
 27648 
       
 27649         Fix the build.
       
 27650 
       
 27651         * platform/win/PlatformScrollBarWin.cpp:
       
 27652 
       
 27653 2006-09-29  Adele Peterson  <adele@apple.com>
       
 27654 
       
 27655         Adding RenderListBox files.
       
 27656 
       
 27657         * WebCore.vcproj/WebCore.vcproj:
       
 27658 
       
 27659 2006-09-29  Adele Peterson  <adele@apple.com>
       
 27660 
       
 27661         Reviewed by Adam.
       
 27662 
       
 27663         Updated constructor for PlatformScrollBar to include controlSize argument.
       
 27664 
       
 27665         * platform/win/PlatformScrollBar.h:
       
 27666         * platform/win/PlatformScrollBarWin.cpp:
       
 27667         (WebCore::PlatformScrollBar::PlatformScrollBar):
       
 27668 
       
 27669 2006-09-29  Adam Roben  <aroben@apple.com>
       
 27670 
       
 27671         Reviewed by hyatt.
       
 27672 
       
 27673         Add error logging to plugin code.
       
 27674 
       
 27675         * WebCore.vcproj/WebCore.vcproj: Added PluginDebug.h
       
 27676         * platform/win/NotImplemented.h: Add surrounding #ifndef/#endif
       
 27677         * plugins/win/PluginDebug.h: Added.
       
 27678         * plugins/win/PluginPackageWin.cpp: Add error logging
       
 27679         (WebCore::PluginPackageWin::load):
       
 27680         * plugins/win/PluginStreamWin.cpp: Ditto.
       
 27681         (WebCore::PluginStreamWin::startStream):
       
 27682         (WebCore::PluginStreamWin::destroyStream):
       
 27683         (WebCore::PluginStreamWin::deliverData):
       
 27684         (WebCore::PluginStreamWin::receivedAllData):
       
 27685         * plugins/win/PluginViewWin.cpp: Ditto.
       
 27686         (WebCore::PluginViewWin::start):
       
 27687         (WebCore::PluginViewWin::stop):
       
 27688         (WebCore::PluginViewWin::newStream):
       
 27689         (WebCore::PluginViewWin::write):
       
 27690         (WebCore::PluginViewWin::destroyStream):
       
 27691 
       
 27692 2006-09-29  Dave Hyatt  <hyatt@apple.com>
       
 27693 
       
 27694         Fork MouseEventWin.cpp into (the better-named) PlatformMouseEventWin.cpp.
       
 27695         
       
 27696         * WebCore.vcproj/WebCore.vcproj:
       
 27697         * platform/win/PlatformMouseEventWin.cpp: Added.
       
 27698 
       
 27699 2006-09-28  Dave Hyatt  <hyatt@apple.com>
       
 27700 
       
 27701         Make scrollbars scroll correctly when setValue is called.  Needed to do float math instead of integer
       
 27702         math (and also fix some buggy math when computing the thumb position).
       
 27703  
       
 27704         * platform/win/PlatformScrollBarWin.cpp:
       
 27705         (WebCore::PlatformScrollBar::thumbPosition):
       
 27706 
       
 27707 2006-09-28  Dave Hyatt  <hyatt@apple.com>
       
 27708 
       
 27709         Make scrollbars on Win32 respond to hover events.  The thumb and arrow buttons will now properly hover when
       
 27710         the mouse enters and exits them.
       
 27711         
       
 27712         * platform/win/PlatformScrollBar.h:
       
 27713         * platform/win/PlatformScrollBarWin.cpp:
       
 27714         (WebCore::PlatformScrollBar::invalidatePart):
       
 27715         (WebCore::PlatformScrollBar::paintButton):
       
 27716         (WebCore::PlatformScrollBar::paintTrack):
       
 27717         (WebCore::PlatformScrollBar::paintThumb):
       
 27718         (WebCore::PlatformScrollBar::paintGripper):
       
 27719         (WebCore::PlatformScrollBar::hitTest):
       
 27720         (WebCore::PlatformScrollBar::mouseMoved):
       
 27721         (WebCore::PlatformScrollBar::mouseExited):
       
 27722 
       
 27723 2006-09-28  Steve Falkenburg  <sfalken@apple.com>
       
 27724 
       
 27725         Reviewed by Maciej.
       
 27726 
       
 27727         Use $(ConfigSuffix) set via vsprops files to add _debug
       
 27728         to end of debug filenames.
       
 27729 
       
 27730         Update B&I build script.
       
 27731 
       
 27732         * WebCore.vcproj/WebCore.make:
       
 27733         * WebCore.vcproj/WebCore.vcproj:
       
 27734         * WebCore.vcproj/debug.vsprops: Added.
       
 27735         * WebCore.vcproj/release.vsprops: Added.
       
 27736 
       
 27737 2006-09-28  Adam Roben  <aroben@apple.com>
       
 27738 
       
 27739         Reviewed by Hyatt.
       
 27740 
       
 27741         Avoid creating LOGFONTs for bitmap fonts under CG, since we don't
       
 27742         support them anyway.
       
 27743 
       
 27744         * platform/win/FontCacheWin.cpp:
       
 27745         (WebCore::FontCache::createFontPlatformData): Set lfOutPrecision to
       
 27746         OUT_TT_ONLY_PRECIS to avoid bitmap fonts.
       
 27747         * platform/win/FontPlatformDataWin.cpp:
       
 27748         (WebCore::FontPlatformData::FontPlatformData): Change the LOG_ERROR
       
 27749         back to an ASSERT since we should never reach this condition now.
       
 27750 
       
 27751 2006-09-28  Dave Hyatt  <hyatt@apple.com>
       
 27752 
       
 27753         This patch eliminates viewportToContents/contentsToViewport in favor of convertTo/FromContainingWindow.
       
 27754         ScrollView now subclasses these methods to factor in its scrollOffset and to deal with the document
       
 27755         view.
       
 27756        
       
 27757         Reviewed by mjs (the convertTo/From changes), (I added the elimination of viewportToContents to
       
 27758         the patch after review, once I realized that these new functions essentially do the same thing.)
       
 27759 
       
 27760         * platform/win/ScrollViewWin.cpp:
       
 27761         (WebCore::ScrollView::updateContents):
       
 27762         (WebCore::ScrollView::convertToContainingWindow):
       
 27763         (WebCore::ScrollView::convertFromContainingWindow):
       
 27764         (WebCore::ScrollView::scrollBy):
       
 27765         * platform/win/WidgetWin.cpp:
       
 27766         (WebCore::Widget::convertToContainingWindow):
       
 27767         (WebCore::Widget::convertFromContainingWindow):
       
 27768 
       
 27769 2006-09-28  Adam Roben  <aroben@apple.com>
       
 27770 
       
 27771         Reviewed by Anders.
       
 27772 
       
 27773         Fail without crashing and log an error when CG encounters a bitmap
       
 27774         font.
       
 27775 
       
 27776         * platform/win/FontPlatformDataWin.cpp:
       
 27777         (WebCore::FontPlatformData::FontPlatformData): Trade LOG_ERROR for
       
 27778         ASSERT_WITH_MESSAGE
       
 27779 
       
 27780 2006-09-27  Alice Liu  <alice.liu@apple.com>
       
 27781 
       
 27782         Reviewed by Steve & Adam.
       
 27783 
       
 27784         * WebCore.vcproj/WebCore.vcproj:
       
 27785         Added files to the project file
       
 27786         * platform/win/TemporaryLinkStubs.cpp:
       
 27787         Removed stub for findWordBoundary
       
 27788         * platform/win/TextBoundariesWin.cpp: Added.
       
 27789         Implemented cross-platform findWordBoundary.  We're still keeping the mac one intact for now. 
       
 27790         (WebCore::findWordBoundary):
       
 27791 
       
 27792 2006-09-28  Adam Roben  <aroben@apple.com>
       
 27793 
       
 27794         Reviewed by Adele.
       
 27795 
       
 27796         Remove never-to-be-used PopUpButton
       
 27797 
       
 27798         * WebCore.vcproj/WebCore.vcproj: Remove PopUpButton.h
       
 27799         * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
       
 27800 
       
 27801 2006-09-28  Adam Roben  <aroben@apple.com>
       
 27802 
       
 27803         Reviewed by Alice.
       
 27804 
       
 27805         Replace notImplemented() with LOG_NOIMPL() and STOP_NOIMPL() macros
       
 27806         which generate debug output. STOP_NOIMPL() also generates a debug
       
 27807         break. Replace calls to notImplemented() with
       
 27808         LOG_NOIMPL()/STOP_NOIMPL() as appropriate. This should stop some unnecessary
       
 27809         crashes where notImplemented() was called from a method that can fail
       
 27810         safely.
       
 27811 
       
 27812         * WebCore.vcproj/WebCore.vcproj: Added NotImplemented.h
       
 27813         * platform/win/FontWin.cpp: Use LOG_NOIMPL() instead of notImplemented().
       
 27814         (WebCore::Font::selectionRectForComplexText):
       
 27815         (WebCore::Font::drawComplexText):
       
 27816         (WebCore::Font::floatWidthForComplexText):
       
 27817         (WebCore::Font::offsetForPositionForComplexText):
       
 27818         * platform/win/NotImplemented.h: Added. Contains new LOG_NOIMPL() and
       
 27819         STOP_NOIMPL() macros.
       
 27820         * platform/win/TemporaryLinkStubs.cpp: Use LOG_NOIMPL() and
       
 27821         STOP_NOIMPL() instead of notImplemented() or nothing.
       
 27822         (PopUpButton::focusPolicy):
       
 27823         (PopUpButton::populate):
       
 27824         (Widget::enableFlushDrawing):
       
 27825         (Widget::focusPolicy):
       
 27826         (Widget::disableFlushDrawing):
       
 27827         (Widget::lockDrawingFocus):
       
 27828         (Widget::unlockDrawingFocus):
       
 27829         (JavaAppletWidget::JavaAppletWidget):
       
 27830         (TextField::selectAll):
       
 27831         (TextField::addSearchResult):
       
 27832         (TextField::selectionStart):
       
 27833         (TextField::hasSelectedText):
       
 27834         (TextField::selectedText):
       
 27835         (TextField::setAutoSaveName):
       
 27836         (TextField::checksDescendantsForFocus):
       
 27837         (TextField::setSelection):
       
 27838         (TextField::setMaxResults):
       
 27839         (TextField::edited):
       
 27840         (Slider::Slider):
       
 27841         (Slider::sizeHint):
       
 27842         (Slider::setValue):
       
 27843         (Slider::setMaxValue):
       
 27844         (Slider::setMinValue):
       
 27845         (Slider::~Slider):
       
 27846         (Slider::setFont):
       
 27847         (Slider::value):
       
 27848         (ListBox::sizeForNumberOfLines):
       
 27849         (ListBox::isSelected):
       
 27850         (ListBox::checksDescendantsForFocus):
       
 27851         (Slider::focusPolicy):
       
 27852         (ListBox::focusPolicy):
       
 27853         (TextField::focusPolicy):
       
 27854         (Cursor::Cursor):
       
 27855         (PlatformMouseEvent::PlatformMouseEvent):
       
 27856         (WebCore::searchableIndexIntroduction):
       
 27857         (WebCore::findNextSentenceFromIndex):
       
 27858         (WebCore::findSentenceBoundary):
       
 27859         (WebCore::findNextWordFromIndex):
       
 27860         (WebCore::ServeSynchronousRequest):
       
 27861         (FrameWin::focusWindow):
       
 27862         (FrameWin::unfocusWindow):
       
 27863         (FrameWin::locationbarVisible):
       
 27864         (FrameWin::registerCommandForRedo):
       
 27865         (FrameWin::getObjectInstanceForWidget):
       
 27866         (FrameWin::getEmbedInstanceForWidget):
       
 27867         (FrameWin::getAppletInstanceForWidget):
       
 27868         (FrameWin::canRedo):
       
 27869         (FrameWin::canUndo):
       
 27870         (FrameWin::canPaste):
       
 27871         (FrameWin::canGoBackOrForward):
       
 27872         (FrameWin::shouldInterruptJavaScript):
       
 27873         (FrameWin::openURL):
       
 27874         (FrameWin::print):
       
 27875         (FrameWin::passMouseDownEventToWidget):
       
 27876         (FrameWin::issueCutCommand):
       
 27877         (FrameWin::issueCopyCommand):
       
 27878         (FrameWin::issuePasteCommand):
       
 27879         (FrameWin::issueUndoCommand):
       
 27880         (FrameWin::issueRedoCommand):
       
 27881         (FrameWin::issuePasteAndMatchStyleCommand):
       
 27882         (FrameWin::issueTransposeCommand):
       
 27883         (FrameWin::passWheelEventToChildWidget):
       
 27884         (FrameWin::mimeTypeForFileName):
       
 27885         (FrameWin::scheduleClose):
       
 27886         (FrameWin::markMisspellings):
       
 27887         (FrameWin::menubarVisible):
       
 27888         (FrameWin::personalbarVisible):
       
 27889         (FrameWin::statusbarVisible):
       
 27890         (FrameWin::toolbarVisible):
       
 27891         (FrameWin::originalRequestURL):
       
 27892         (FrameWin::isLoadTypeReload):
       
 27893         (BrowserExtensionWin::canRunModal):
       
 27894         (BrowserExtensionWin::createNewWindow):
       
 27895         (BrowserExtensionWin::canRunModalNow):
       
 27896         (BrowserExtensionWin::runModal):
       
 27897         (BrowserExtensionWin::goBackOrForward):
       
 27898         (BrowserExtensionWin::historyURL):
       
 27899         (GraphicsContext::addRoundedRectClip):
       
 27900         (GraphicsContext::addInnerRoundedRectClip):
       
 27901         (WebCore::screenDepthPerComponent):
       
 27902         (WebCore::screenIsMonochrome):
       
 27903         (WebCore::moveCursor):
       
 27904         (WebCore::inputElementAltText):
       
 27905         (WebCore::findWordBoundary):
       
 27906         (WebCore::ResourceLoader::assembleResponseHeaders):
       
 27907         (WebCore::ResourceLoader::retrieveCharset):
       
 27908         (FrameView::updateBorder):
       
 27909         (FrameWin::restoreDocumentState):
       
 27910         (FrameWin::partClearedInBegin):
       
 27911         (FrameWin::createEmptyDocument):
       
 27912         (FrameWin::overrideMediaType):
       
 27913         (FrameWin::markedTextRange):
       
 27914         (FrameWin::addMessageToConsole):
       
 27915         (FrameWin::shouldChangeSelection):
       
 27916         (FrameWin::respondToChangedSelection):
       
 27917         (FrameWin::saveDocumentState):
       
 27918         (FrameWin::registerCommandForUndo):
       
 27919         (FrameWin::clearUndoRedoOperations):
       
 27920         (FrameWin::incomingReferrer):
       
 27921         (FrameWin::markMisspellingsInAdjacentWords):
       
 27922         (FrameWin::respondToChangedContents):
       
 27923         (BrowserExtensionWin::BrowserExtensionWin):
       
 27924         (BrowserExtensionWin::setTypedIconURL):
       
 27925         (BrowserExtensionWin::setIconURL):
       
 27926         (BrowserExtensionWin::getHistoryLength):
       
 27927         (WebCore::CheckIfReloading):
       
 27928         (WebCore::CheckCacheObjectStatus):
       
 27929         (Widget::setIsSelected):
       
 27930         (ScrollView::inWindow):
       
 27931         (ScrollView::scrollPointRecursively):
       
 27932         (GraphicsContext::setShadow):
       
 27933         (GraphicsContext::clearShadow):
       
 27934         (GraphicsContext::beginTransparencyLayer):
       
 27935         (GraphicsContext::endTransparencyLayer):
       
 27936         (GraphicsContext::clearRect):
       
 27937         (GraphicsContext::strokeRect):
       
 27938         (GraphicsContext::setLineWidth):
       
 27939         (GraphicsContext::setLineCap):
       
 27940         (GraphicsContext::setLineJoin):
       
 27941         (GraphicsContext::setMiterLimit):
       
 27942         (GraphicsContext::setAlpha):
       
 27943         (GraphicsContext::clip):
       
 27944         (GraphicsContext::rotate):
       
 27945         (GraphicsContext::scale):
       
 27946         (Path::Path):
       
 27947         (Path::~Path):
       
 27948         (Path::contains):
       
 27949         (Path::translate):
       
 27950         (Path::boundingRect):
       
 27951         (Path::operator=):
       
 27952         (Path::clear):
       
 27953         (Path::moveTo):
       
 27954         (Path::addLineTo):
       
 27955         (Path::addQuadCurveTo):
       
 27956         (Path::addBezierCurveTo):
       
 27957         (Path::addArcTo):
       
 27958         (Path::closeSubpath):
       
 27959         (Path::addArc):
       
 27960         (Path::addRect):
       
 27961         (Path::addEllipse):
       
 27962         (GraphicsContext::drawFocusRing):
       
 27963         (GraphicsContext::drawLineForMisspelling):
       
 27964         (GraphicsContext::setCompositeOperation):
       
 27965         (TextField::TextField):
       
 27966         (TextField::~TextField):
       
 27967         (TextField::setFont):
       
 27968         (TextField::setAlignment):
       
 27969         (TextField::setWritingDirection):
       
 27970         (TextField::maxLength):
       
 27971         (TextField::setMaxLength):
       
 27972         (TextField::text):
       
 27973         (TextField::setText):
       
 27974         (TextField::cursorPosition):
       
 27975         (TextField::setCursorPosition):
       
 27976         (TextField::setEdited):
       
 27977         (TextField::setReadOnly):
       
 27978         (TextField::setPlaceholderString):
       
 27979         (TextField::setColors):
       
 27980         (TextField::sizeForCharacterWidth):
       
 27981         (TextField::baselinePosition):
       
 27982         (TextField::setLiveSearch):
       
 27983         (PopUpButton::PopUpButton):
       
 27984         (PopUpButton::~PopUpButton):
       
 27985         (PopUpButton::setFont):
       
 27986         (PopUpButton::baselinePosition):
       
 27987         (PopUpButton::setWritingDirection):
       
 27988         (PopUpButton::clear):
       
 27989         (PopUpButton::appendItem):
       
 27990         (PopUpButton::setCurrentItem):
       
 27991         (PopUpButton::sizeHint):
       
 27992         (PopUpButton::frameGeometry):
       
 27993         (PopUpButton::setFrameGeometry):
       
 27994         (ListBox::ListBox):
       
 27995         (ListBox::~ListBox):
       
 27996         (ListBox::setSelectionMode):
       
 27997         (ListBox::setFont):
       
 27998         (ListBox::setWritingDirection):
       
 27999         (ListBox::clear):
       
 28000         (ListBox::doneAppendingItems):
       
 28001         (ListBox::setEnabled):
       
 28002         (ListBox::appendItem):
       
 28003         (ListBox::setSelected):
       
 28004         (WebCore::focusRingColor):
       
 28005         (WebCore::setFocusRingColorChangeFunction):
       
 28006         (Frame::setNeedsReapplyStyles):
       
 28007         (Image::drawTiled):
       
 28008         (RenderPopupMenuWin::addSeparator):
       
 28009         (RenderPopupMenuWin::addGroupLabel):
       
 28010         (IconLoader::receivedResponse):
       
 28011         (IconLoader::notifyIconChanged):
       
 28012         * plugins/win/PluginViewWin.cpp:
       
 28013         (WebCore::PluginViewWin::setValue):
       
 28014 
       
 28015 2006-09-28  Adam Roben  <aroben@apple.com>
       
 28016 
       
 28017         Rubberstamped by sfalken.
       
 28018 
       
 28019         Remove calls to DebugBreak() from plugin code.
       
 28020 
       
 28021         * plugins/win/PluginViewWin.cpp:
       
 28022         (WebCore::PluginViewWin::getValue):
       
 28023         (WebCore::PluginViewWin::setValue):
       
 28024 
       
 28025 2006-09-28  Dave Hyatt  <hyatt@apple.com>
       
 28026 
       
 28027         Eliminate the use of MapWindowPoints on Win32. Just use the outermost HWND as the point of reference for events.  
       
 28028         
       
 28029         Stub out the mouse methods from the open source checkin and add a new member variable to track the current hovered scrollbar part.
       
 28030 
       
 28031         * platform/win/PlatformScrollBar.h:
       
 28032         (WebCore::):
       
 28033         * platform/win/PlatformScrollBarWin.cpp:
       
 28034         (WebCore::PlatformScrollBar::PlatformScrollBar):
       
 28035         (WebCore::PlatformScrollBar::mouseMoved):
       
 28036         (WebCore::PlatformScrollBar::mouseExited):
       
 28037         * platform/win/ScrollViewWin.cpp:
       
 28038         (WebCore::ScrollView::viewportToContents):
       
 28039         (WebCore::ScrollView::contentsToViewport):
       
 28040         * platform/win/WheelEventWin.cpp:
       
 28041         (WebCore::positionForEvent):
       
 28042 
       
 28043 2006-09-27  Steve Falkenburg  <sfalken@apple.com>
       
 28044 
       
 28045         Reviewed by Maciej.
       
 28046 
       
 28047         Prefer pulling project dependencies from WebKitOutputDir over
       
 28048         WebKitSDKDir.  Don't copy build output back over to WebKitSDKDir.
       
 28049 
       
 28050         * WebCore.vcproj/WebCore.vcproj:
       
 28051         * WebCore.vcproj/build-generated-files.sh:
       
 28052         * WebCore.vcproj/dstroot-to-sdk.cmd: Removed.
       
 28053 
       
 28054 2006-09-27  Steve Falkenburg  <sfalken@apple.com>
       
 28055 
       
 28056         B&I build fixes
       
 28057 
       
 28058         * WebCore.vcproj/WebCore.make:
       
 28059         * WebCore.vcproj/WebCore.vcproj:
       
 28060         * WebCore.vcproj/build-generated-files.sh:
       
 28061 
       
 28062 2006-09-27  Adam Roben  <aroben@apple.com>
       
 28063 
       
 28064         Reviewed by sfalken.
       
 28065 
       
 28066         Don't die when plugins try to open a new window.
       
 28067 
       
 28068         * plugins/win/PluginViewWin.cpp:
       
 28069         (WebCore::PluginViewWin::performRequest): Remove call to DebugBreak()
       
 28070 
       
 28071 2006-09-27  Steve Falkenburg  <sfalken@apple.com>
       
 28072 
       
 28073         B&I build script tweaks.
       
 28074 
       
 28075         * WebCore.vcproj/WebCore.make:
       
 28076 
       
 28077 2006-09-27  Steve Falkenburg  <sfalken@apple.com>
       
 28078 
       
 28079         Reviewed by Hyatt.
       
 28080 
       
 28081         Turn on CG
       
 28082 
       
 28083         * config.h:
       
 28084 
       
 28085 2006-09-27  Adam Roben  <aroben@apple.com>
       
 28086 
       
 28087         Reviewed by Lou.
       
 28088 
       
 28089         Fix crash in plugins due to Flash on nytimes.com
       
 28090 
       
 28091         * plugins/win/PluginStreamWin.cpp:
       
 28092         (WebCore::PluginStreamWin::PluginStreamWin): memset m_stream to 0
       
 28093 
       
 28094 2006-09-27  Adam Roben  <aroben@apple.com>
       
 28095 
       
 28096         Reviewed by sfalken.
       
 28097 
       
 28098         Scroll plugins (at least in some cases).
       
 28099 
       
 28100         * platform/win/ScrollViewWin.cpp:
       
 28101         (WebCore::ScrollView::scrollBy): Pass SW_SCROLLCHILDREN to ScrollWindowEx()
       
 28102 
       
 28103 2006-09-27  Steve Falkenburg  <sfalken@apple.com>
       
 28104 
       
 28105         Reviewed by Adam.
       
 28106 
       
 28107         Remove unimplemented from a temporary link stub.
       
 28108 
       
 28109         * platform/win/TemporaryLinkStubs.cpp:
       
 28110         (GraphicsContext::addInnerRoundedRectClip):
       
 28111 
       
 28112 2006-09-27  Sean Gies  <seangies@apple.com>
       
 28113 
       
 28114         Reviewed by Brady Eidson.
       
 28115 
       
 28116         * WebCore.vcproj/WebCore.vcproj: Added platform/win/WebCoreSystemInterface.h/cpp
       
 28117         * platform/win/WebCoreSystemInterface.cpp: Added.
       
 28118         * platform/win/WebCoreSystemInterface.h: Added.
       
 28119 
       
 28120 2006-09-26  Adam Roben  <aroben@apple.com>
       
 28121 
       
 28122         Reviewed by sfalken.
       
 28123 
       
 28124         Fixes <rdar://problem/4751600>
       
 28125         Hang on Amazon.com involving Flash
       
 28126 
       
 28127         * plugins/win/PluginStreamWin.cpp: Rename m_streamStarted to
       
 28128         m_isTerminated to match Mac code (m_isTerminated is the negation of
       
 28129         m_streamStarted)
       
 28130         (WebCore::PluginStreamWin::PluginStreamWin): Initialize m_isTerminated
       
 28131         to false to match Mac code.
       
 28132         (WebCore::PluginStreamWin::~PluginStreamWin): Rename and negate.
       
 28133         (WebCore::PluginStreamWin::stop): Remove assignment of m_streamStarted
       
 28134         to match Mac code.
       
 28135         (WebCore::PluginStreamWin::startStream): Rename and negate. Remove
       
 28136         now-unnecessary assignment of m_streamStarted to true because we set
       
 28137         m_isTerminated to false in the constructor.
       
 28138         (WebCore::PluginStreamWin::destroyStream): Rename and negate.
       
 28139         * plugins/win/PluginStreamWin.h: Rename m_streamStarted to
       
 28140         m_isTerminated.
       
 28141         * plugins/win/PluginViewWin.cpp:
       
 28142         (WebCore::PluginViewWin::performRequest): Send the correct response URL
       
 28143         to the plugin.
       
 28144 
       
 28145 2006-09-26  Steve Falkenburg  <sfalken@apple.com>
       
 28146 
       
 28147         More temporary link stubs moved.
       
 28148         Build tweaks.
       
 28149 
       
 28150         * ChangeLog:
       
 28151         * WebCore.vcproj/WebCore.make: Added.
       
 28152         * WebCore.vcproj/WebCore.vcproj:
       
 28153         * platform/win/TemporaryLinkStubs.cpp:
       
 28154         (ListBox::isSelected):
       
 28155         (ListBox::setWritingDirection):
       
 28156         (ListBox::clear):
       
 28157         (ListBox::doneAppendingItems):
       
 28158         (ListBox::setEnabled):
       
 28159         (ListBox::appendItem):
       
 28160         (ListBox::setSelected):
       
 28161 
       
 28162 2006-09-26  Sean Gies  <seangies@apple.com>
       
 28163 
       
 28164         Reviewed by Brady Eidson.
       
 28165 
       
 28166         * platform/win/GraphicsContextWin.cpp:
       
 28167         (WebCore::CGContextWithHDC):  Make a static function.
       
 28168         (WebCore::GraphicsContext::getWindowsContext): Assume flipped coordinates.
       
 28169 
       
 28170 2006-09-26  Brady Eidson  <beidson@apple.com>
       
 28171 
       
 28172         Nuked another notImplemented() that is getting hit
       
 28173 
       
 28174         * platform/win/TemporaryLinkStubs.cpp:
       
 28175         (GraphicsContext::addRoundedRectClip):
       
 28176 
       
 28177 2006-09-26  Sean Gies  <seangies@apple.com>
       
 28178 
       
 28179         Reviewed by Adam Roben.
       
 28180 
       
 28181         * WebCore.vcproj/WebCore.vcproj: Use Debug DLL C runtime for debug config.
       
 28182 
       
 28183 2006-09-26  Lou Amadio  <lamadio@apple.com>
       
 28184 
       
 28185         Reviewed by ggaren
       
 28186         Uninitialized variable caused a memory corruption on cnn.com
       
 28187 
       
 28188         WARNING: NO TEST CASES ADDED OR CHANGED
       
 28189 
       
 28190         * plugins/win/PlugInInfoStoreWin.cpp:
       
 28191         (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
       
 28192 
       
 28193 2006-09-26  Dave Hyatt  <hyatt@apple.com>
       
 28194 
       
 28195         Fix my buggy invalidateRect implementation for Win32 widgets.
       
 28196         
       
 28197         Clean up my rect computation code in scrollbar to use x() and y() instead of
       
 28198         frameGeometry().x()/y().
       
 28199         
       
 28200         Add a new invalidateTrack() method that invalidates the track (and handles
       
 28201         putting the rect into the right coordinate space for proper invalidation
       
 28202         now that I fixed invalidateRect).
       
 28203 
       
 28204         * platform/win/PlatformScrollBar.h:
       
 28205         * platform/win/PlatformScrollBarWin.cpp:
       
 28206         (WebCore::PlatformScrollBar::updateThumbPosition):
       
 28207         (WebCore::PlatformScrollBar::updateThumbProportion):
       
 28208         (WebCore::PlatformScrollBar::invalidateTrack):
       
 28209         (WebCore::PlatformScrollBar::backButtonRect):
       
 28210         (WebCore::PlatformScrollBar::forwardButtonRect):
       
 28211         (WebCore::PlatformScrollBar::trackRect):
       
 28212         * platform/win/WidgetWin.cpp:
       
 28213         (WebCore::Widget::invalidate):
       
 28214 
       
 28215 2006-09-26  Dave Hyatt  <hyatt@apple.com>
       
 28216 
       
 28217         Teach all our Win32 theme code (RenderTheme and PlatformScrollBar) how to respond correctly to OS theme changes.
       
 28218         
       
 28219         Implement painting of scrollbars using theme APIs.  The arrow buttons, track, thumb and gripper all paint properly
       
 28220         now.  Next up is hit testing and proper hover feedback.
       
 28221         
       
 28222         Reviewed by andersca
       
 28223         
       
 28224         * platform/win/PlatformScrollBar.h:
       
 28225         * platform/win/PlatformScrollBarWin.cpp:
       
 28226         (WebCore::PlatformScrollBar::PlatformScrollBar):
       
 28227         (WebCore::PlatformScrollBar::paint):
       
 28228         (WebCore::PlatformScrollBar::backButtonRect):
       
 28229         (WebCore::PlatformScrollBar::forwardButtonRect):
       
 28230         (WebCore::PlatformScrollBar::trackRect):
       
 28231         (WebCore::PlatformScrollBar::gripperRect):
       
 28232         (WebCore::PlatformScrollBar::splitTrack):
       
 28233         (WebCore::PlatformScrollBar::thumbPosition):
       
 28234         (WebCore::PlatformScrollBar::thumbLength):
       
 28235         (WebCore::PlatformScrollBar::paintButton):
       
 28236         (WebCore::PlatformScrollBar::paintTrack):
       
 28237         (WebCore::PlatformScrollBar::paintThumb):
       
 28238         (WebCore::PlatformScrollBar::paintGripper):
       
 28239         (WebCore::PlatformScrollBar::themeChanged):
       
 28240         * platform/win/ScrollViewWin.cpp:
       
 28241         (WebCore::ScrollView::themeChanged):
       
 28242         * platform/win/TemporaryLinkStubs.cpp:
       
 28243         (Widget::enableFlushDrawing):
       
 28244         * platform/win/WidgetWin.cpp:
       
 28245         (WebCore::Widget::isEnabled):
       
 28246         * rendering/RenderThemeWin.cpp:
       
 28247         (WebCore::RenderThemeWin::RenderThemeWin):
       
 28248         (WebCore::RenderThemeWin::openButtonTheme):
       
 28249         (WebCore::RenderThemeWin::openTextFieldTheme):
       
 28250         (WebCore::RenderThemeWin::openMenuListTheme):
       
 28251         (WebCore::RenderThemeWin::close):
       
 28252         (WebCore::RenderThemeWin::themeChanged):
       
 28253         * rendering/RenderThemeWin.h:
       
 28254 
       
 28255 2006-09-25  Adam Roben  <aroben@apple.com>
       
 28256 
       
 28257         Rubberstamped by sfalken.
       
 28258 
       
 28259         Set svn:eol-style to native and cleanup line endings on plugins files.
       
 28260 
       
 28261         * plugins/win/PluginStreamWin.cpp:
       
 28262         (WebCore::PluginStreamWin::PluginStreamWin):
       
 28263         (WebCore::PluginStreamWin::~PluginStreamWin):
       
 28264         (WebCore::PluginStreamWin::start):
       
 28265         (WebCore::PluginStreamWin::startStream):
       
 28266         (WebCore::PluginStreamWin::destroyStream):
       
 28267         (WebCore::PluginStreamWin::deliverData):
       
 28268         (WebCore::PluginStreamWin::receivedResponse):
       
 28269         (WebCore::PluginStreamWin::receivedData):
       
 28270         (WebCore::PluginStreamWin::receivedAllData):
       
 28271 
       
 28272 2006-09-25  Adam Roben  <aroben@apple.com>
       
 28273 
       
 28274         Reviewed by Brady.
       
 28275 
       
 28276         Fixes <rdar://problem/4749494>
       
 28277         Crash/ASSERT in plugins at Fark.com
       
 28278 
       
 28279         * platform/win/ResourceLoaderWin.cpp: Store whether a particular job
       
 28280         has received a response within the ResourceLoader object itself, since
       
 28281         it's possible that we will enter the InternetReadFileExA while loop
       
 28282         twice for the same job.
       
 28283         (WebCore::ResourceLoaderWndProc): Ask the job whether it has received a
       
 28284         response instead of assuming it hasn't.
       
 28285         (WebCore::ResourceLoader::setHasReceivedResponse): Added.
       
 28286         (WebCore::ResourceLoader::hasReceivedResponse): Added.
       
 28287 
       
 28288 2006-09-25  Adam Roben  <aroben@apple.com>
       
 28289 
       
 28290         Rubberstamped by sfalken.
       
 28291 
       
 28292         Continuing the removal of unnecessary notImplemented() calls.
       
 28293 
       
 28294         * platform/win/TemporaryLinkStubs.cpp:
       
 28295         (PlatformMouseEvent::PlatformMouseEvent):
       
 28296         (FrameWin::passWheelEventToChildWidget):
       
 28297 
       
 28298 2006-09-25  Adam Roben  <aroben@apple.com>
       
 28299 
       
 28300         Rubberstamped by sfalken.
       
 28301 
       
 28302         More notImplemented()-ectomy.
       
 28303 
       
 28304         * platform/win/TemporaryLinkStubs.cpp:
       
 28305         (RenderPopupMenuWin::addSeparator):
       
 28306         (RenderPopupMenuWin::addGroupLabel):
       
 28307 
       
 28308 2006-09-25  Adam Roben  <aroben@apple.com>
       
 28309 
       
 28310         Rubberstamped by sfalken.
       
 28311 
       
 28312         Remove calls to notImplemented() from functions that can fail safely.
       
 28313 
       
 28314         * platform/win/TemporaryLinkStubs.cpp:
       
 28315         (FrameWin::originalRequestURL):
       
 28316         (FrameWin::isLoadTypeReload):
       
 28317         (IconLoader::receivedResponse):
       
 28318         (IconLoader::notifyIconChanged):
       
 28319 
       
 28320 2006-09-25  Adam Roben  <aroben@apple.com>
       
 28321 
       
 28322         Rubberstamped by sfalken.
       
 28323 
       
 28324         Make notImplemented() crash even when not linked against the debug CRT.
       
 28325 
       
 28326         * platform/win/TemporaryLinkStubs.cpp:
       
 28327         (notImplemented): Change _CrtDbgBreak() to ASSERT(0)
       
 28328 
       
 28329 2006-09-24  Dave Hyatt  <hyatt@apple.com>
       
 28330 
       
 28331         Update the scrollbar API to match the changes in the public tree.
       
 28332         
       
 28333         Start implementing the Win32 scrollbar.  Add some scaffolding for grabbing uxtheme.dll info and also
       
 28334         add some utility functions for breaking the scrollbar into individual components.
       
 28335         
       
 28336         * platform/win/PlatformScrollBar.h:
       
 28337         * platform/win/PlatformScrollBarWin.cpp:
       
 28338         (WebCore::PlatformScrollBar::PlatformScrollBar):
       
 28339         (WebCore::PlatformScrollBar::updateThumbPosition):
       
 28340         (WebCore::PlatformScrollBar::updateThumbProportion):
       
 28341         (WebCore::PlatformScrollBar::paint):
       
 28342         (WebCore::PlatformScrollBar::backButtonRect):
       
 28343         (WebCore::PlatformScrollBar::forwardButtonRect):
       
 28344         (WebCore::PlatformScrollBar::trackRect):
       
 28345         (WebCore::PlatformScrollBar::splitTrack):
       
 28346 
       
 28347 2006-09-22  Steve Falkenburg  <sfalken@apple.com>
       
 28348 
       
 28349         Fix release build some more.
       
 28350 
       
 28351         * WebCore.vcproj/WebCore.vcproj:
       
 28352 
       
 28353 2006-09-22  Brady Eidson  <beidson@apple.com>
       
 28354 
       
 28355         Extremely urgent update to my last two patches (without it, many urls will fail to load)
       
 28356 
       
 28357         * platform/win/ResourceLoaderWin.cpp:
       
 28358         (WebCore::ResourceLoader::onRequestComplete):
       
 28359 
       
 28360 2006-09-22  Brady Eidson  <beidson@apple.com>
       
 28361 
       
 28362         Forgot some lines we needed to keep for the internal build in my last checkin
       
 28363 
       
 28364         * platform/win/ResourceLoaderWin.cpp:
       
 28365 
       
 28366 2006-09-22  Brady Eidson  <beidson@apple.com>
       
 28367 
       
 28368         Reviewed by Steve
       
 28369 
       
 28370         Landed from OpenSource - that version now supports Redirect like we need, and is a little cleaner design
       
 28371 
       
 28372         * platform/win/ResourceLoaderWin.cpp:
       
 28373         (WebCore::):
       
 28374         (WebCore::ResourceLoaderWndProc):
       
 28375         (WebCore::initializeOffScreenResourceLoaderWindow):
       
 28376         (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
       
 28377         (WebCore::ResourceLoader::onHandleCreated):
       
 28378         (WebCore::ResourceLoader::onRequestRedirected):
       
 28379         (WebCore::ResourceLoader::onRequestComplete):
       
 28380         (WebCore::transferJobStatusCallback):
       
 28381         (WebCore::ResourceLoader::start):
       
 28382         (WebCore::ResourceLoader::fileLoadTimer):
       
 28383         (WebCore::ResourceLoader::cancel):
       
 28384 
       
 28385 2006-09-22  Dave Hyatt <hyatt@apple.com>
       
 28386 
       
 28387         Implement support for CSS2 system fonts on Win32.  Implement support for our special control font so that controls now
       
 28388         pick up the correct font from the system.  This fixes the crazy form control font sizes on e.g., www.google.com.
       
 28389 
       
 28390         * platform/win/TemporaryLinkStubs.cpp:
       
 28391         * rendering/RenderThemeWin.cpp:
       
 28392         (WebCore::fillFontDescription):
       
 28393         (WebCore::RenderThemeWin::systemFont):
       
 28394 
       
 28395 2006-09-22  Dave Hyatt <hyatt@apple.com>
       
 28396 
       
 28397         Scrollbar preparation work.
       
 28398         
       
 28399         (1) Add support for enabling/disabling widgets.
       
 28400         (2) Add support for invalidation of part or all of a widget.
       
 28401         (3) Clean up some of the Win32 scrollbar code.  All that's left is painting
       
 28402         and event handling. (Oh, is that all...) :)
       
 28403 
       
 28404         Reviewed by anders
       
 28405 
       
 28406         * platform/win/PlatformScrollBarWin.cpp:
       
 28407         (WebCore::PlatformScrollBar::setScrollBarValue):
       
 28408         (WebCore::PlatformScrollBar::setKnobProportion):
       
 28409         (WebCore::PlatformScrollBar::setEnabled):
       
 28410         (WebCore::PlatformScrollBar::paint):
       
 28411         * platform/win/TemporaryLinkStubs.cpp:
       
 28412         * platform/win/WidgetWin.cpp:
       
 28413         (WebCore::Widget::Widget):
       
 28414         (WebCore::Widget::setEnabled):
       
 28415         (WebCore::Widget::invalidate):
       
 28416         (WebCore::Widget::invalidateRect):
       
 28417 
       
 28418 2006-09-21  Brady Eidson <beidson@apple.com>
       
 28419 
       
 28420         Build was broken for at least some, and I think my checkin that messed with 
       
 28421         #include orders was to blame (and it was messy, broken or not) - this cleans that up
       
 28422 
       
 28423         * platform/win/ResourceLoaderWin.cpp:
       
 28424 
       
 28425 2006-09-21  Alice Liu  <alice.liu@apple.com>
       
 28426 
       
 28427         Reviewed by Hyatt.
       
 28428 
       
 28429         windows build fix
       
 28430 
       
 28431         * platform/win/GraphicsContextWin.cpp:
       
 28432         wrapped a CG #include in #if PLATFORM(CG)
       
 28433 
       
 28434 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
       
 28435 
       
 28436         Reviewed by Maciej, Hyatt, Steve.
       
 28437     
       
 28438         frames!
       
 28439         
       
 28440         Prep work:
       
 28441             - moved ScrollViewWin into OpenSourceWin
       
 28442             - set eol-style:native on some files and corrected line endings
       
 28443             - updated the WebCore project so that you don't need cygwin in your Windows path
       
 28444               to build correctly.
       
 28445 
       
 28446         Real work:
       
 28447 
       
 28448             On Windows, Widgets are no longer interfaces to Windows UI tookit objects. They're 
       
 28449             just positioned objects.
       
 28450                 
       
 28451             Widgets position themselves relative to their parents. The top-level widget technically
       
 28452             has a position relative to the WebView, but that's academic, since it's always (0, 0).
       
 28453             All widgets draw inside a common containing window (the WebView window). ScrollView 
       
 28454             handles transformation, clipping, and dirty rect management.
       
 28455             
       
 28456             I've filed a bunch of bugs on remaining frames work. Most notably, closing a page with
       
 28457             a frame in it causes a crash because WebCore depends on WebKit to manage frame lifetime.
       
 28458             I'm going to fix that by integrating frame ownership into the DOM.
       
 28459             
       
 28460 2006-09-21  Steve Falkenburg  <sfalken@apple.com>
       
 28461 
       
 28462         Reviewed by Anders.
       
 28463         
       
 28464         <rdar://4516072>
       
 28465         <rdar://4601320>
       
 28466         
       
 28467         Implemented JavaScript alert/confirm/prompt inside app.
       
 28468         This is done via IWebUIDelegate.
       
 28469 
       
 28470         * bridge/win/FrameWin.cpp:
       
 28471         (WebCore::FrameWin::userAgent):
       
 28472         (WebCore::FrameWin::runJavaScriptAlert):
       
 28473         (WebCore::FrameWin::runJavaScriptConfirm):
       
 28474         (WebCore::FrameWin::runJavaScriptPrompt):
       
 28475         * bridge/win/FrameWin.h:
       
 28476         * platform/win/TemporaryLinkStubs.cpp:
       
 28477         (FrameWin::registerCommandForRedo):
       
 28478 
       
 28479 2006-09-21  Sean Gies  <seangies@apple.com>
       
 28480 
       
 28481         Reviewed by NOBODY.
       
 28482 
       
 28483         Unfork GraphicsContextCG.cpp.
       
 28484 
       
 28485         * WebCore.vcproj/WebCore.vcproj: Unfork GraphicsContextCG.cpp and add GraphicsContextWin.cpp
       
 28486         * platform/win/GraphicsContextWin.cpp: Added.
       
 28487 
       
 28488 2006-09-21  Luke Wallis  <wallis@apple.com>
       
 28489 
       
 28490         Rubber stamped by Steve.
       
 28491 
       
 28492         Added (commented out for now) defines for building on PLATFORM(CG).
       
 28493 
       
 28494         * config.h:
       
 28495 
       
 28496 2006-09-21  Luke Wallis <wallis@apple.com>
       
 28497 
       
 28498         Reviewed by Adam Roben.
       
 28499 
       
 28500         Fix build. Added #if PLATFORM(CG) around variable defined only for CG.
       
 28501 
       
 28502         * platform/win/FontDataWin.cpp:
       
 28503         (WebCore::FontData::platformInit):
       
 28504 
       
 28505 2006-09-21  Sean Gies  <seangies@apple.com>
       
 28506 
       
 28507         Reviewed by Adam Roben.
       
 28508 
       
 28509         Draw form controls when rendering with CG.
       
 28510 
       
 28511         * platform/cg/GraphicsContextCG.cpp:
       
 28512         (WebCore::CGContextWithHDC): New function to create CGContext given an HDC.
       
 28513         (WebCore::GraphicsContext::GraphicsContext): New constructor that takes an HDC.
       
 28514         (WebCore::GraphicsContext::getWindowsContext): Return underlying HDC to client.
       
 28515         (WebCore::GraphicsContext::releaseWindowsContext): Restore underlying HDC after client mucked with it.
       
 28516         * platform/cg/GraphicsContextPlatformPrivate.h: Add field to hold HDC.
       
 28517         * rendering/RenderThemeWin.cpp: Implement prepareForDrawing and doneDrawing for CG.
       
 28518 
       
 28519 2006-09-21  Anders Carlsson  <acarlsson@apple.com>
       
 28520 
       
 28521         Reviewed by Tim O.
       
 28522 
       
 28523         Support getting the plugin element as an NPObject.
       
 28524         
       
 28525         * plugins/win/PluginViewWin.cpp:
       
 28526         (WebCore::PluginViewWin::getValue):
       
 28527         (WebCore::PluginViewWin::PluginViewWin):
       
 28528         * plugins/win/PluginViewWin.h:
       
 28529 
       
 28530 2006-09-21  Sean Gies  <seangies@apple.com>
       
 28531 
       
 28532         Reviewed by Adam Roben.
       
 28533 
       
 28534         Forked GraphicsContextCG.cpp and GraphicsContextPlatformPrivate.h from open source #16504.
       
 28535 
       
 28536         * platform/cg/GraphicsContextCG.cpp: Added.
       
 28537         * platform/cg/GraphicsContextPlatformPrivate.h: Added.
       
 28538 
       
 28539 2006-09-21  Sean Gies  <seangies@apple.com>
       
 28540 
       
 28541         Reviewed by Adam Roben.
       
 28542 
       
 28543         Support synthetic bold and/or oblique with CG.
       
 28544 
       
 28545         * platform/win/FontCacheWin.cpp: Pass new arguments to updated FontPlatformData constructor.
       
 28546         * platform/win/FontDataWin.cpp:
       
 28547         (WebCore::FontData::platformInit): Choose synthetic bold offset.
       
 28548         (WebCore::FontData::platformWidthForGlyph): Take synthetic bold offset into account.
       
 28549         * platform/win/FontPlatformData.h: Add fields for synthetic styles.
       
 28550         * platform/win/FontPlatformDataWin.cpp: Ask HFONT if it supports bold or italics.
       
 28551         * platform/win/FontWin.cpp:
       
 28552         (WebCore::Font::drawGlyphs): Restore code for implementing synthetic stlyes.
       
 28553 
       
 28554 2006-09-21  Brady Eidson  <beidson@apple.com>
       
 28555 
       
 28556         Reviewed by Anders
       
 28557 
       
 28558         Fixed one definite bug and did alot of cleanup to make it resemble the unforked version of the file
       
 28559         in preparation for merging it back out
       
 28560 
       
 28561         * platform/win/ResourceLoaderWin.cpp:
       
 28562         (WebCore::ResourceLoaderWndProc):
       
 28563         (WebCore::transferJobStatusCallback): Fixed a bug here!  :)
       
 28564         (WebCore::ResourceLoader::start):
       
 28565         (WebCore::ResourceLoader::fileLoadTimer):
       
 28566         (WebCore::ResourceLoader::cancel):
       
 28567 
       
 28568 2006-09-21  2006-09-21  Dave Hyatt <hyatt@apple.com>
       
 28569 
       
 28570         Implement mouse wheel scrolling on Win32.  Also forked ScrollViewWin.cpp and fixed some bugs in it.
       
 28571 
       
 28572         * WebCore.vcproj/WebCore.vcproj:
       
 28573         * platform/win/ScrollViewWin.cpp: Added.
       
 28574         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
       
 28575         (WebCore::ScrollView::ScrollView):
       
 28576         (WebCore::ScrollView::~ScrollView):
       
 28577         (WebCore::ScrollView::updateContents):
       
 28578         (WebCore::ScrollView::visibleWidth):
       
 28579         (WebCore::ScrollView::visibleHeight):
       
 28580         (WebCore::ScrollView::visibleContentRect):
       
 28581         (WebCore::ScrollView::setContentsPos):
       
 28582         (WebCore::ScrollView::resizeContents):
       
 28583         (WebCore::ScrollView::contentsX):
       
 28584         (WebCore::ScrollView::contentsY):
       
 28585         (WebCore::ScrollView::contentsWidth):
       
 28586         (WebCore::ScrollView::contentsHeight):
       
 28587         (WebCore::ScrollView::viewportToContents):
       
 28588         (WebCore::ScrollView::contentsToViewport):
       
 28589         (WebCore::ScrollView::scrollOffset):
       
 28590         (WebCore::ScrollView::maximumScroll):
       
 28591         (WebCore::ScrollView::scrollBy):
       
 28592         (WebCore::ScrollView::hScrollBarMode):
       
 28593         (WebCore::ScrollView::vScrollBarMode):
       
 28594         (WebCore::ScrollView::suppressScrollBars):
       
 28595         (WebCore::ScrollView::setHScrollBarMode):
       
 28596         (WebCore::ScrollView::setVScrollBarMode):
       
 28597         (WebCore::ScrollView::setScrollBarsMode):
       
 28598         (WebCore::ScrollView::setStaticBackground):
       
 28599         (WebCore::ScrollView::updateScrollInfo):
       
 28600         (WebCore::ScrollView::updateScrollBars):
       
 28601         (WebCore::ScrollView::wheelEvent):
       
 28602         * platform/win/WheelEventWin.cpp: Added.
       
 28603         (WebCore::positionForEvent):
       
 28604         (WebCore::globalPositionForEvent):
       
 28605         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
       
 28606 
       
 28607 2006-09-20  Sean Gies  <seangies@apple.com>
       
 28608 
       
 28609         Reviewed by Adam Roben.
       
 28610 
       
 28611         Added platform/cg/ColorCG.cpp
       
 28612 
       
 28613         * WebCore.vcproj/WebCore.vcproj: Add ColorCG.cpp
       
 28614         * platform/cg/ColorCG.cpp: Added.
       
 28615 
       
 28616 2006-09-20  Sean Gies  <seangies@apple.com>
       
 28617 
       
 28618         Reviewed by Adam Roben.
       
 28619 
       
 28620         Fixed ugly text spacing issues with CG for Windows.
       
 28621 
       
 28622         * platform/win/FontDataWin.cpp: Reimplement platformWidthForGlyph using CG APIs.
       
 28623 
       
 28624 2006-09-19  Anders Carlsson  <acarlsson@apple.com>
       
 28625 
       
 28626         Reviewed by Dave Hyatt.
       
 28627         
       
 28628         <rdar://problem/4734743> Crash accessing YouTube.
       
 28629         
       
 28630         * config.h:
       
 28631         Enable some more of the JSC bindings code on Windows.
       
 28632         
       
 28633 2006-09-18  Brady Eidson  <beidson@apple.com>
       
 28634 
       
 28635         YABF, and merged a change from open source ResourceLoaderWin.cpp
       
 28636 
       
 28637         * bridge/win/FrameWin.h:
       
 28638         * platform/win/ResourceLoaderWin.cpp:
       
 28639         (WebCore::ResourceLoader::fileLoadTimer):
       
 28640         * platform/win/TemporaryLinkStubs.cpp:
       
 28641         (FrameWin::isLoadTypeReload):
       
 28642 
       
 28643 2006-09-18  Sean Gies  <seangies@apple.com>
       
 28644 
       
 28645         Reviewed by Adam Roben.
       
 28646 
       
 28647         Support bold & italics.
       
 28648 
       
 28649         * platform/win/FontPlatformDataWin.cpp: Use GetOutlineTextMetrics instead of GetTextFace to
       
 28650             query HFONT name.
       
 28651 
       
 28652 2006-09-18  Sean Gies  <seangies@apple.com>
       
 28653 
       
 28654         Reviewed by Adam Roben.
       
 28655 
       
 28656         Changes to bring up CoreGraphics on Windows.
       
 28657 
       
 28658         * WebCore.vcproj/WebCore.vcproj: Search platform/cg for headers.  Compile platform/cg/*.cpp.
       
 28659              Add AffineTransform.cpp to build.
       
 28660         * platform/win/FontDataWin.cpp: Include CG before using it.
       
 28661         * platform/win/FontPlatformDataWin.cpp: Fixed typo.
       
 28662         * platform/win/ImageWin.cpp: Include CG and winsock2.  Implement CG version of Image::getHBITMAP.
       
 28663              In Cairo version of Image::getHBITMAP, use correct bitmapInfo field and return true for success.
       
 28664              Fixed image loading bug.
       
 28665 
       
 28666 2006-09-18  Brady Eidson  <beidson@apple.com>
       
 28667 
       
 28668         Rubberstamp by Adam
       
 28669 
       
 28670         Build fix
       
 28671 
       
 28672         * bridge/win/FrameWin.h:
       
 28673         * platform/win/TemporaryLinkStubs.cpp:
       
 28674         (FrameWin::originalRequestURL):
       
 28675 
       
 28676 2006-09-18  Sean Gies  <seangies@apple.com>
       
 28677 
       
 28678         Reviewed by Adam Roben.
       
 28679 
       
 28680         Forked FontCacheWin.cpp from OpenSource tree r16421.
       
 28681 
       
 28682         * WebCore.vcproj/WebCore.vcproj: Point to Internal file.
       
 28683         * platform/win/FontCacheWin.cpp: Added.
       
 28684 
       
 28685 2006-09-15  Anders Carlsson  <acarlsson@apple.com>
       
 28686 
       
 28687         Reviewed by Steve.
       
 28688 
       
 28689         * WebCore.vcproj/WebCore.vcproj:
       
 28690         Add JavaScriptCore/ to include path.
       
 28691 
       
 28692 2006-09-15  Adam Roben  <aroben@apple.com>
       
 28693 
       
 28694         Reviewed by sfalken.
       
 28695 
       
 28696         Implement historyContains() on Windows (rdar://4733770)
       
 28697 
       
 28698         * WebCore.vcproj/WebCore.vcproj: Add
       
 28699         platform\win\WebCoreHistory.{cpp,h} and bridge\win\HistoryWin.cpp to
       
 28700         project.
       
 28701         * bridge/win/HistoryWin.cpp: Added.
       
 28702         (WebCore::historyContains):
       
 28703         * platform/win/TemporaryLinkStubs.cpp: Remove stub for
       
 28704         WebCore::historyContains()
       
 28705         * platform/win/WebCoreHistory.cpp: Added.
       
 28706         (WebCore::WebCoreHistory::setHistoryProvider):
       
 28707         (WebCore::WebCoreHistory::historyProvider):
       
 28708         * platform/win/WebCoreHistory.h: Added.
       
 28709 
       
 28710 2006-09-14  Steve Falkenburg  <sfalken@apple.com>
       
 28711 
       
 28712         Reviewed by Lou Amadio.
       
 28713 
       
 28714         iBench fix - fix WinInet form post code to not reference a stale pointer.
       
 28715         (found by Application Verifier)
       
 28716 
       
 28717         * platform/win/ResourceLoaderWin.cpp:
       
 28718         (WebCore::ResourceLoaderWndProc):
       
 28719 
       
 28720 2006-09-14  Adam Roben  <aroben@apple.com>
       
 28721 
       
 28722         Reviewed by sfalken.
       
 28723 
       
 28724         A little #include cleanup
       
 28725 
       
 28726         * WebCore.vcproj/WebCore.vcproj: Add loader/icon to
       
 28727         AdditionalIncludeDirectories
       
 28728         * platform/win/TemporaryLinkStubs.cpp: Remove "loader/icon" from
       
 28729         #include of IconLoader.h
       
 28730 
       
 28731 2006-09-14  Brady Eidson  <beidson@apple.com>
       
 28732 
       
 28733         Build Fix
       
 28734 
       
 28735         * WebCore.vcproj/WebCore.vcproj:
       
 28736         * platform/win/TemporaryLinkStubs.cpp:
       
 28737         (IconLoader::receivedResponse):
       
 28738         (IconLoader::notifyIconChanged):
       
 28739 
       
 28740 2006-09-13  Steve Falkenburg  <sfalken@apple.com>
       
 28741 
       
 28742         Fixes for submission of WebCore.  Doesn't affect build.
       
 28743 
       
 28744         * WebCore.vcproj/WebCore.vcproj:
       
 28745         * WebCore.vcproj/merge-opensource.sh:
       
 28746 
       
 28747 2006-09-12  Steve Falkenburg  <sfalken@apple.com>
       
 28748 
       
 28749         Rubber-stamped by Ada.
       
 28750 
       
 28751         Get Boomer ready for B&I submission.
       
 28752        
       
 28753         Projects can now all build independent of one another
       
 28754         without groping for headers or source across trees.
       
 28755 
       
 28756         * WebCore.vcproj/WebCore.sln: Fix standalone sln for use by B&I.
       
 28757         * WebCore.vcproj/WebCore.vcproj: Update to new obj layout.
       
 28758         * WebCore.vcproj/build-generated-files.sh: Build derived sources into obj, update to new obj layout.
       
 28759         * WebCore.vcproj/dstroot-to-sdk.cmd: Copy built bits back to WebKitSDKDir for dependent builds.
       
 28760 
       
 28761 2006-09-13  Adam Roben  <aroben@apple.com>
       
 28762 
       
 28763         Build fix
       
 28764 
       
 28765         * WebCore.vcproj/WebCore.vcproj: Rename KHTML_XSLT to XSLT_SUPPORT,
       
 28766         remove KHTML_NO_XBL
       
 28767         * config.h: Ditto.
       
 28768 
       
 28769 2006-09-13  Adam Roben  <aroben@apple.com>
       
 28770 
       
 28771         Reviewed by beidson.
       
 28772 
       
 28773         Initial implementation of Icon, FileChooser on Windows.
       
 28774 
       
 28775         * WebCore.vcproj/WebCore.vcproj: Added FileChooserWin.cpp, IconWin.cpp
       
 28776         * platform/win/FileChooserWin.cpp: Added.
       
 28777         (WebCore::FileChooser::FileChooser):
       
 28778         (WebCore::FileChooser::openFileChooser):
       
 28779         (WebCore::FileChooser::basenameForWidth):
       
 28780         (WebCore::FileChooser::uploadControlDetaching):
       
 28781         (WebCore::FileChooser::chooseFile):
       
 28782         * platform/win/IconWin.cpp: Added.
       
 28783         (WebCore::Icon::Icon):
       
 28784         (WebCore::Icon::~Icon):
       
 28785         (WebCore::Icon::newIconForFile):
       
 28786         (WebCore::Icon::paint):
       
 28787         * platform/win/TemporaryLinkStubs.cpp: Removed FileChooser, Icon stub
       
 28788         functions
       
 28789 
       
 28790 2006-09-13  Anders Carlsson  <acarlsson@apple.com>
       
 28791 
       
 28792         Reviewed by Tim O.
       
 28793 
       
 28794         Implement postURL and postURLNotify.
       
 28795 
       
 28796         * plugins/win/PluginStreamWin.cpp:
       
 28797         (WebCore::PluginStreamWin::~PluginStreamWin):
       
 28798         (WebCore::PluginStreamWin::start):
       
 28799         (WebCore::PluginStreamWin::startStream):
       
 28800         (WebCore::PluginStreamWin::cancelAndDestroyStream):
       
 28801         * plugins/win/PluginViewWin.cpp:
       
 28802         (WebCore::PluginViewWin::start):
       
 28803         (WebCore::PluginViewWin::loadURL):
       
 28804         (WebCore::PluginViewWin::getURLNotify):
       
 28805         (WebCore::PluginViewWin::getURL):
       
 28806         (WebCore::startsWithBlankLine):
       
 28807         (WebCore::locationAfterFirstBlankLine):
       
 28808         (WebCore::findEOL):
       
 28809         (WebCore::capitalizeRFC822HeaderFieldName):
       
 28810         (WebCore::parseRFC822HeaderFields):
       
 28811         (WebCore::PluginViewWin::handlePost):
       
 28812         (WebCore::PluginViewWin::postURLNotify):
       
 28813         (WebCore::PluginViewWin::postURL):
       
 28814         * plugins/win/PluginViewWin.h:
       
 28815 
       
 28816 2006-09-13  Lou Amadio  <lamadio@apple.com>
       
 28817 
       
 28818         Reviewed by sfalken
       
 28819 
       
 28820         * WebCore.vcproj/WebCore.vcproj:
       
 28821 
       
 28822 2006-09-13  Adam Roben  <aroben@apple.com>
       
 28823 
       
 28824         Build fix
       
 28825 
       
 28826         * WebCore.vcproj/build-generated-files.sh: Export SOURCE_ROOT which is
       
 28827         now used by CodeGenerator.pm
       
 28828 
       
 28829 2006-09-12  Anders Carlsson  <acarlsson@apple.com>
       
 28830 
       
 28831         Reviewed by Tim O.
       
 28832 
       
 28833         Add scripting support for plugins.
       
 28834         
       
 28835         * bridge/win/FrameWin.cpp:
       
 28836         (WebCore::FrameWin::FrameWin):
       
 28837         (WebCore::FrameWin::addPluginRootObject):
       
 28838         (WebCore::FrameWin::cleanupPluginObjects):
       
 28839         (WebCore::FrameWin::bindingRootObject):
       
 28840         (WebCore::FrameWin::windowScriptNPObject):
       
 28841         * bridge/win/FrameWin.h:
       
 28842         * plugins/win/PluginPackageWin.cpp:
       
 28843         (WebCore::PluginPackageWin::load):
       
 28844         * plugins/win/PluginViewWin.cpp:
       
 28845         (WebCore::PluginViewWin::getValue):
       
 28846         * plugins/win/npapi.cpp:
       
 28847         (NPN_RequestRead):
       
 28848         (NPN_InvalidateRect):
       
 28849         (NPN_InvalidateRegion):
       
 28850         (NPN_ForceRedraw):
       
 28851 
       
 28852 2006-09-12  Adam Roben  <aroben@apple.com>
       
 28853 
       
 28854         Reviewed many times by darin, hyatt.
       
 28855 
       
 28856         Add stubs for new engine-based file upload control implementation and
       
 28857         Icon class.
       
 28858 
       
 28859         * WebCore.vcproj/WebCore.vcproj: Add new engine-based files, remove old
       
 28860         widget-based files.
       
 28861         * platform/win/TemporaryLinkStubs.cpp: Add stubs for FileChooser and
       
 28862         Icon methods, and add two new LocalizedString methods.
       
 28863         (WebCore::fileButtonChooseFileLabel):
       
 28864         (WebCore::fileButtonNoFileSelectedLabel):
       
 28865         (FileChooser::FileChooser):
       
 28866         (FileChooser::~FileChooser):
       
 28867         (FileChooser::openFileChooser):
       
 28868         (FileChooser::basenameForWidth):
       
 28869         (FileChooser::uploadControlDetaching):
       
 28870         (Icon::~Icon):
       
 28871         (Icon::paint):
       
 28872 
       
 28873 2006-09-11  Anders Carlsson  <acarlsson@apple.com>
       
 28874 
       
 28875         Reviewed by Tim O.
       
 28876 
       
 28877         Add stream and URL handling to PluginViewWin. Include PluginStreamWin.cpp in the build.
       
 28878         Also fix a number of bugs discovered when loading various plugins.
       
 28879         
       
 28880         * WebCore.vcproj/WebCore.vcproj:
       
 28881         * plugins/win/PluginViewWin.cpp:
       
 28882         (WebCore::PluginRequestWin::PluginRequestWin):
       
 28883         (WebCore::PluginRequestWin::url):
       
 28884         (WebCore::PluginRequestWin::target):
       
 28885         (WebCore::PluginRequestWin::notifyData):
       
 28886         (WebCore::PluginRequestWin::sendNotification):
       
 28887         (WebCore::scriptStringIfJavaScriptURL):
       
 28888         (WebCore::registerPluginView):
       
 28889         (WebCore::PluginViewWndProc):
       
 28890         (WebCore::PluginViewWin::updateSize):
       
 28891         (WebCore::PluginViewWin::setFrameGeometry):
       
 28892         (WebCore::PluginViewWin::start):
       
 28893         (WebCore::PluginViewWin::stop):
       
 28894         (WebCore::createUTF8String):
       
 28895         (WebCore::PluginViewWin::performRequest):
       
 28896         (WebCore::PluginViewWin::requestTimerFired):
       
 28897         (WebCore::PluginViewWin::scheduleRequest):
       
 28898         (WebCore::PluginViewWin::loadURL):
       
 28899         (WebCore::makeURL):
       
 28900         (WebCore::PluginViewWin::getURLNotify):
       
 28901         (WebCore::PluginViewWin::getURL):
       
 28902         (WebCore::PluginViewWin::newStream):
       
 28903         (WebCore::PluginViewWin::write):
       
 28904         (WebCore::PluginViewWin::destroyStream):
       
 28905         (WebCore::PluginViewWin::userAgent):
       
 28906         (WebCore::PluginViewWin::~PluginViewWin):
       
 28907         (WebCore::PluginViewWin::PluginViewWin):
       
 28908         * plugins/win/PluginViewWin.h:
       
 28909 
       
 28910 2006-09-11  Anders Carlsson  <acarlsson@apple.com>
       
 28911 
       
 28912         * WebCore.vcproj/WebCore.vcproj:
       
 28913         Fix build.
       
 28914         
       
 28915 2006-09-11  Anders Carlsson  <acarlsson@apple.com>
       
 28916 
       
 28917         Reviewed by Tim O and Maciej.
       
 28918 
       
 28919         Add plugin stream object.
       
 28920         
       
 28921         * plugins/win/PluginStreamWin.cpp: Added.
       
 28922         (WebCore::PluginStreamWin::PluginStreamWin):
       
 28923         (WebCore::PluginStreamWin::~PluginStreamWin):
       
 28924         (WebCore::PluginStreamWin::setRequestHeaders):
       
 28925         (WebCore::PluginStreamWin::setPostData):
       
 28926         (WebCore::PluginStreamWin::start):
       
 28927         (WebCore::PluginStreamWin::stop):
       
 28928         (WebCore::PluginStreamWin::startStream):
       
 28929         (WebCore::PluginStreamWin::cancelAndDestroyStream):
       
 28930         (WebCore::PluginStreamWin::destroyStream):
       
 28931         (WebCore::PluginStreamWin::delayDeliveryTimerFired):
       
 28932         (WebCore::PluginStreamWin::deliverData):
       
 28933         (WebCore::PluginStreamWin::receivedResponse):
       
 28934         (WebCore::PluginStreamWin::receivedData):
       
 28935         (WebCore::PluginStreamWin::receivedAllData):
       
 28936         * plugins/win/PluginStreamWin.h: Added.
       
 28937 
       
 28938 2006-09-10  Brady Eidson  <beidson@apple.com>
       
 28939 
       
 28940         Reviewed by Steven Falkenburg
       
 28941 
       
 28942         Added IconDatabase related code and forked ImageWin for its HBITMAP blit
       
 28943 
       
 28944         * WebCore.vcproj/WebCore.vcproj: Added in all WebCore::IconDatabase stuffs
       
 28945         * platform/win/ImageWin.cpp: Added. (forked from OpenSource)
       
 28946         (WebCore::Image::initPlatformData):
       
 28947         (WebCore::Image::invalidatePlatformData):
       
 28948         (WebCore::Image::loadPlatformResource):
       
 28949         (WebCore::Image::supportsType):
       
 28950         (WebCore::Image::getHBITMAP): Added - blit the image to an HBITMAP 
       
 28951         
       
 28952 2006-09-10  David Hyatt  <hyatt@apple.com>
       
 28953 
       
 28954         Remove the addIntrinsicMargins code from the theme.  I did this
       
 28955         in the open source version but forgot to do it in the internal
       
 28956         version.
       
 28957 
       
 28958         * rendering/RenderThemeWin.cpp:
       
 28959         (WebCore::RenderThemeWin::adjustButtonStyle):
       
 28960         (WebCore::RenderThemeWin::adjustTextFieldStyle):
       
 28961         (WebCore::RenderThemeWin::adjustTextAreaStyle):
       
 28962         (WebCore::RenderThemeWin::adjustMenuListStyle):
       
 28963 
       
 28964 2006-09-10  Brady Eidson  <beidson@apple.com>
       
 28965 
       
 28966         Reviewed by YABF, and Adam's suggestive rubberstamp before he hopped offline
       
 28967 
       
 28968         Build fix + FIXME/Radar to reflect an OpenSource change to the Font.h header
       
 28969 
       
 28970         * platform/win/FontWin.cpp:
       
 28971         (WebCore::Font::drawGlyphs): Added the parameter and a FIXME 
       
 28972 
       
 28973 2006-09-10  Steve Falkenburg  <sfalken@apple.com>
       
 28974 
       
 28975         Rubber-stamp by aroben.
       
 28976         
       
 28977         * WebCore.vcproj/WebCore.vcproj:
       
 28978 
       
 28979 2006-09-09  Steve Falkenburg  <sfalken@apple.com>
       
 28980 
       
 28981         Reviewed by aroben.
       
 28982 
       
 28983         Added missing CF files to fix CFNetwork build variant
       
 28984 
       
 28985         * WebCore.vcproj/WebCore.vcproj: Use include paths, libs, DLLs from %SystemDrive%\AppleInternal
       
 28986         * WebCore.vcproj/build-generated-files.sh: Don't copy open source DLLs from WebKitLibraries
       
 28987 
       
 28988 2006-09-09  Adam Roben  <aroben@apple.com>
       
 28989 
       
 28990         Reviewed by hyatt.
       
 28991 
       
 28992         Remove unnecessary calls to setAffectedBy{Active,Hover}Rules
       
 28993 
       
 28994         * rendering/RenderThemeWin.cpp:
       
 28995         (WebCore::RenderThemeWin::adjustMenuListStyle): Remove unnecessary calls
       
 28996 
       
 28997 2006-09-06  Brady Eidson  <beidson@apple.com>
       
 28998 
       
 28999         YABF (Yet another build fix)
       
 29000 
       
 29001         * platform/win/FontDataWin.cpp: Added missing header
       
 29002 
       
 29003 2006-09-06  Brady Eidson  <beidson@apple.com>
       
 29004 
       
 29005         Reviewed by Steve's rubberstamp
       
 29006 
       
 29007         Three stubs were added this morning, however the methods were already implemented in
       
 29008         Internal/OpenSourceWin/WebCoreWin/bridge/win/FrameWin.cpp
       
 29009 
       
 29010         * platform/win/TemporaryLinkStubs.cpp: Nuked some repeat symbols
       
 29011 
       
 29012 2006-09-06  Adam Roben  <aroben@apple.com>
       
 29013 
       
 29014         Reviewed by Darin.
       
 29015 
       
 29016         Fixed various Windows build issues caused by previous checkins.
       
 29017 
       
 29018         * bridge/win/FrameWin.h: Added missing #include, updated Selection to SelectionController.
       
 29019         * platform/win/FontWin.cpp: Reorganized #includes.
       
 29020         (WebCore::Font::drawGlyphs): Used a const_cast hack to fix ultimately broken code.
       
 29021         * platform/win/ResourceLoaderWin.cpp: Added missing #include of CString.h and removed double #include of config.h.
       
 29022         (WebCore::ResourceLoaderWndProc): Removed use of String::ascii.
       
 29023         (WebCore::ResourceLoader::start): Ditto.
       
 29024         * platform/win/TemporaryLinkStubs.cpp: Added missing stubs.
       
 29025         (FrameWin::markMisspellings):
       
 29026         (FrameWin::shouldChangeSelection):
       
 29027         (FrameWin::respondToChangedSelection):
       
 29028         (FrameWin::respondToChangedContents):
       
 29029         (FrameWin::handledOnloadEvents):
       
 29030         (FrameWin::createPlugin):
       
 29031         (FrameWin::objectContentType):
       
 29032         * rendering/RenderPopupMenuWin.cpp: Added missing #include.
       
 29033 
       
 29034 2006-09-05  Darin Adler  <darin@apple.com>
       
 29035 
       
 29036         - build fix part of http://bugzilla.opendarwin.org/show_bug.cgi?id=10728
       
 29037           text encodings should work without a numeric ID
       
 29038 
       
 29039         * WebCore.vcproj/WebCore.vcproj: Update for new headers.
       
 29040 
       
 29041 2006-09-01  Steve Falkenburg  <sfalken@apple.com>
       
 29042 
       
 29043         Reviewed by adachan.
       
 29044 
       
 29045         Process redirects received in networking layer through to application.
       
 29046         With this change, the address bar url edit field shows the proper
       
 29047         redirected URL.
       
 29048 
       
 29049         * platform/win/ResourceLoaderWin.cpp:
       
 29050         (WebCore::ResourceLoaderWndProc):
       
 29051         (WebCore::transferJobStatusCallback):
       
 29052         (WebCore::ResourceLoader::start):
       
 29053 
       
 29054 2006-09-01  Ada Chan  <adachan@apple.com>
       
 29055 
       
 29056         Reviewed by lamadio.
       
 29057 
       
 29058         Fixed build break.
       
 29059 
       
 29060         * bridge/win/FrameWin.h:
       
 29061         * platform/win/TemporaryLinkStubs.cpp:
       
 29062         (FrameWin::respondToChangedContents):
       
 29063 
       
 29064 2006-08-31  Anders Carlsson  <acarlsson@apple.com>
       
 29065 
       
 29066         Reviewed by Steve.
       
 29067 
       
 29068         Add our own internal config.h so we can make changes to it.
       
 29069         
       
 29070         * WebCore.vcproj/WebCore.vcproj:
       
 29071         Add config.h to the file list, move the KXMLCORE_PLATFORM_CF to the new config.h file 
       
 29072                        
       
 29073         * config.h: Added.
       
 29074         
       
 29075         * platform/win/ResourceLoaderWin.cpp:
       
 29076         Include config.h        
       
 29077 
       
 29078 2006-08-31  Dave Hyatt <hyatt@apple.com>
       
 29079 
       
 29080         Add a platform scrollbar class for Windows.  It doesn't really work yet.
       
 29081 
       
 29082         * WebCore.vcproj/WebCore.vcproj:
       
 29083         * platform/win/TemporaryLinkStubs.cpp:
       
 29084         * platform/win/PlatformScrollBarWin.cpp
       
 29085 
       
 29086 2006-08-31  Anders Carlsson  <acarlsson@apple.com>
       
 29087 
       
 29088         Fix the build.
       
 29089 
       
 29090         * WebCore.vcproj/WebCore.vcproj:
       
 29091 
       
 29092 2006-08-30  Steve Falkenburg  <sfalken@apple.com>
       
 29093 
       
 29094         Reviewed by Ada Chan.
       
 29095 
       
 29096         * bridge/win/FrameWin.cpp:
       
 29097         (WebCore::FrameWin::submitForm): Pass form values to submit form delegate
       
 29098         * bridge/win/FrameWin.h: Pass form values to submit form delegate
       
 29099 
       
 29100 2006-08-29  David Hyatt  <hyatt@apple.com>
       
 29101 
       
 29102         Make project changes so that the forked Font files (and Cairo/JPG/PNG) are all used.
       
 29103 
       
 29104         * WebCore.vcproj/WebCore.vcproj:
       
 29105 
       
 29106 2006-08-29  David Hyatt  <hyatt@apple.com>
       
 29107 
       
 29108         This patch lands all the font changes.  It does not patch the project file
       
 29109         yet, since this was done on Mac.  Will switch to Win32 after landing this
       
 29110         and then fix any glitches.
       
 29111 
       
 29112         * platform/cairo/cairo-all.c: Added.
       
 29113         * platform/cairo/pixman-all.c: Added.
       
 29114         * platform/image-decoders/jpeg/jpeg-part1.c: Added.
       
 29115         * platform/image-decoders/jpeg/jpeg-part2.c: Added.
       
 29116         * platform/image-decoders/jpeg/jpeg-part3.c: Added.
       
 29117         * platform/image-decoders/png/png-part1.c: Added.
       
 29118         * platform/image-decoders/png/png-part2.c: Added.
       
 29119         * platform/win/FontDataWin.cpp:
       
 29120         (WebCore::FontData::platformInit):
       
 29121         (WebCore::FontData::platformDestroy):
       
 29122         (WebCore::FontData::platformWidthForGlyph):
       
 29123         * platform/win/FontPlatformData.h:
       
 29124         (WebCore::FontPlatformData::FontPlatformData):
       
 29125         (WebCore::FontPlatformData::cgFont):
       
 29126         (WebCore::FontPlatformData::operator==):
       
 29127         * platform/win/FontPlatformDataWin.cpp:
       
 29128         (WebCore::m_size):
       
 29129         * platform/win/FontWin.cpp:
       
 29130         (WebCore::Font::drawGlyphs):
       
 29131 
       
 29132 2006-08-29  David Hyatt  <hyatt@apple.com>
       
 29133 
       
 29134         Forking the font files in preparation for dropping in CG code.
       
 29135 
       
 29136         Reviewed by adam
       
 29137 
       
 29138         * WebCore.vcproj/WebCore.vcproj:
       
 29139         * platform/win/FontDataWin.cpp: Added.
       
 29140         (WebCore::FontData::platformInit):
       
 29141         (WebCore::FontData::platformDestroy):
       
 29142         (WebCore::FontData::smallCapsFontData):
       
 29143         (WebCore::FontData::containsCharacters):
       
 29144         (WebCore::FontData::determinePitch):
       
 29145         (WebCore::FontData::platformWidthForGlyph):
       
 29146         * platform/win/FontPlatformData.h: Added.
       
 29147         (WebCore::FontPlatformData::FontPlatformData):
       
 29148         (WebCore::FontPlatformData::hfont):
       
 29149         (WebCore::FontPlatformData::fontFace):
       
 29150         (WebCore::FontPlatformData::scaledFont):
       
 29151         (WebCore::FontPlatformData::size):
       
 29152         (WebCore::FontPlatformData::hash):
       
 29153         (WebCore::FontPlatformData::operator==):
       
 29154         * platform/win/FontPlatformDataWin.cpp: Added.
       
 29155         (WebCore::m_size):
       
 29156         (WebCore::FontPlatformData::~FontPlatformData):
       
 29157         * platform/win/FontWin.cpp: Added.
       
 29158         (WebCore::notImplemented):
       
 29159         (WebCore::Font::drawGlyphs):
       
 29160         (WebCore::Font::selectionRectForComplexText):
       
 29161         (WebCore::Font::drawComplexText):
       
 29162         (WebCore::Font::floatWidthForComplexText):
       
 29163         (WebCore::Font::offsetForPositionForComplexText):
       
 29164 
       
 29165 2006-08-28  Geoffrey Garen  <ggaren@apple.com>
       
 29166 
       
 29167         Reviewed by Maciej.
       
 29168 
       
 29169         Landed CFNetwork loader, off by default. To enable, define:
       
 29170             KXMLCORE_PLATFORM_CF
       
 29171             KXMLCORE_USE_CFNETWORK
       
 29172 
       
 29173         CFNetwork uses winsock2. If you do this, you need to make sure that winsock2.h
       
 29174         is included before windows.h in any translation unit in which it's used.
       
 29175         A lot of the jiggering in this patch is devoted to that.
       
 29176         
       
 29177         * WebCore.vcproj/WebCore.vcproj:
       
 29178         * platform/win/ResourceLoaderWin.cpp: Removed reliance on PlatformData
       
 29179         since it wasn't being used, and removing it made easy work of integrating
       
 29180         CFNetwork in a Windows-independent way.
       
 29181         (WebCore::ResourceLoaderWndProc):
       
 29182         (WebCore::ResourceLoader::fileLoadTimer):
       
 29183         (WebCore::ResourceLoader::cancel):
       
 29184         * platform/win/TemporaryLinkStubs.cpp:
       
 29185         (Path::contains):
       
 29186         * platform/win/WidgetWin.cpp:
       
 29187         * plugins/win/PluginDatabaseWin.cpp:
       
 29188         * plugins/win/PluginPackageWin.h:
       
 29189         * plugins/win/PluginViewWin.h:
       
 29190         * plugins/win/npapi.cpp:
       
 29191         * rendering/RenderPopupMenuWin.cpp:
       
 29192         * rendering/RenderPopupMenuWin.h:
       
 29193         * rendering/RenderThemeWin.cpp:
       
 29194 
       
 29195 2006-08-28  Ada Chan  <adachan@apple.com>
       
 29196 
       
 29197         Reviewed by ggaren.
       
 29198 
       
 29199         Fixed build.
       
 29200 
       
 29201         * platform/win/TemporaryLinkStubs.cpp:
       
 29202         (Path::contains):
       
 29203 
       
 29204 2006-08-25  David Hyatt  <hyatt@apple.com>
       
 29205 
       
 29206         Land CG/Cairo refactoring (and add some winsock2.h).  (I do not really
       
 29207         understand why the winsock2.h stuff would suddenly be needed.)
       
 29208 
       
 29209         * platform/win/ResourceLoaderWin.h:
       
 29210         * platform/win/TemporaryLinkStubs.cpp:
       
 29211         (GraphicsContext::setAlpha):
       
 29212         (GraphicsContext::drawFocusRing):
       
 29213         (GraphicsContext::drawLineForMisspelling):
       
 29214         (GraphicsContext::setCompositeOperation):
       
 29215         * plugins/win/PluginPackageWin.h:
       
 29216         * plugins/win/PluginViewWin.h:
       
 29217         * plugins/win/npapi.cpp:
       
 29218         * rendering/RenderThemeWin.cpp:
       
 29219         (WebCore::prepareForDrawing):
       
 29220         (WebCore::doneDrawing):
       
 29221 
       
 29222 2006-08-24  Geoffrey Garen  <ggaren@apple.com>
       
 29223 
       
 29224         Reviewed by Darin.
       
 29225 
       
 29226         Frame refactoring: changed FrameView clients so they no longer assume that
       
 29227         FrameViews are Widgets that can tell you things about the platform, in 
       
 29228         preparation for divorcing FrameViews from heavy-weight Widgets altogether.
       
 29229 
       
 29230         This patch makes Page, rather than Widget, responsible for holding the
       
 29231         page's HWND. Refactoring aside, I think this makes more sense.
       
 29232 
       
 29233 2006-08-24  Geoffrey Garen  <ggaren@apple.com>
       
 29234 
       
 29235         Reviewed by Hyatt.
       
 29236 
       
 29237         Branching PageWin.cpp from r15969.
       
 29238 
       
 29239         * WebCore.vcproj/WebCore.vcproj:
       
 29240         * bridge/win/PageWin.cpp: Added.
       
 29241         (WebCore::Page::Page):
       
 29242         (WebCore::Page::windowRect):
       
 29243         (WebCore::Page::setWindowRect):
       
 29244 
       
 29245 2006-08-23  Adam Roben  <aroben@apple.com>
       
 29246 
       
 29247         Reviewed by Ada.
       
 29248 
       
 29249         Fixed placement of popups when document is scrolled.
       
 29250 
       
 29251         * rendering/RenderPopupMenuWin.cpp:
       
 29252         (WebCore::RenderPopupMenuWin::setPositionAndSize):
       
 29253 
       
 29254 2006-08-23  Steve Falkenburg  <sfalken@apple.com>
       
 29255 
       
 29256         Build fix (many of our include paths were wrong!)
       
 29257 
       
 29258         * WebCore.vcproj/WebCore.vcproj:
       
 29259 
       
 29260 2006-08-23  Adam Roben  <aroben@apple.com>
       
 29261 
       
 29262         Reviewed by Darin, Lou, Adele.
       
 29263 
       
 29264         Initial implementation of <select> elements on Windows.
       
 29265 
       
 29266         * WebCore.vcproj/WebCore.vcproj:
       
 29267             Added RenderPopupMenuWin.cpp
       
 29268         * platform/win/TemporaryLinkStubs.cpp:
       
 29269         (RenderPopupMenuWin::addGroupLabel):
       
 29270         * rendering/RenderPopupMenuWin.cpp: Added.
       
 29271         (WebCore::RenderPopupMenuWin::RenderPopupMenuWin):
       
 29272         (WebCore::RenderPopupMenuWin::~RenderPopupMenuWin):
       
 29273         (WebCore::RenderPopupMenuWin::clear):
       
 29274         (WebCore::RenderPopupMenuWin::populate):
       
 29275         (WebCore::RenderPopupMenuWin::showPopup):
       
 29276         (WebCore::RenderPopupMenuWin::hidePopup):
       
 29277         (WebCore::RenderPopupMenuWin::setPositionAndSize):
       
 29278         (WebCore::RenderPopupMenuWin::addOption):
       
 29279         (WebCore::RenderPopupMenuWin::down):
       
 29280         (WebCore::RenderPopupMenuWin::up):
       
 29281         (WebCore::registerPopup):
       
 29282         (WebCore::PopupWndProc):
       
 29283         * rendering/RenderPopupMenuWin.h:
       
 29284             Added useful properties.
       
 29285         (WebCore::RenderPopupMenuWin::popupHandle):
       
 29286         (WebCore::RenderPopupMenuWin::containerHandle):
       
 29287         (WebCore::RenderPopupMenuWin::wasClicked):
       
 29288         (WebCore::RenderPopupMenuWin::setWasClicked):
       
 29289         * rendering/RenderThemeWin.cpp:
       
 29290         (WebCore::RenderThemeWin::RenderThemeWin):
       
 29291         (WebCore::RenderThemeWin::openButtonTheme):
       
 29292         (WebCore::RenderThemeWin::openTextFieldTheme):
       
 29293         (WebCore::RenderThemeWin::openMenuListTheme):
       
 29294         (WebCore::RenderThemeWin::close):
       
 29295         (WebCore::RenderThemeWin::supportsFocus):
       
 29296         (WebCore::RenderThemeWin::determineState):
       
 29297         (WebCore::RenderThemeWin::getThemeData):
       
 29298         (WebCore::RenderThemeWin::paintButton):
       
 29299         (WebCore::RenderThemeWin::paintTextField):
       
 29300             Refactored the above methods and added cases for
       
 29301             MenulistAppearance where appropriate.
       
 29302         (WebCore::RenderThemeWin::paintMenuList):
       
 29303         (WebCore::RenderThemeWin::adjustMenuListStyle):
       
 29304             Implemented the above methods.
       
 29305         * rendering/RenderThemeWin.h:
       
 29306 
       
 29307 2006-08-22  Geoffrey Garen  <ggaren@apple.com>
       
 29308 
       
 29309         My first Windows build fix.
       
 29310 
       
 29311         * WebCore.vcproj/WebCore.vcproj:
       
 29312             - Link against version.lib, since the new plug-in stuff requires it
       
 29313             - Sync the release and debug header search paths, so release
       
 29314               finds the JS bindings.
       
 29315 
       
 29316 2006-08-18  Anders Carlsson  <acarlsson@apple.com>
       
 29317 
       
 29318         * plugins/win/PluginViewWin.cpp:
       
 29319         (WebCore::PluginViewWin::write):
       
 29320         (WebCore::PluginViewWin::destroyStream):
       
 29321         Another attempt at fixing the build. Make these two functions into instance methods of PluginViewWin.
       
 29322 
       
 29323 2006-08-18  Anders Carlsson  <acarlsson@apple.com>
       
 29324 
       
 29325         * plugins/win/PluginViewWin.cpp:
       
 29326         (WebCore::write):
       
 29327         (WebCore::destroyStream):
       
 29328         * plugins/win/PluginViewWin.h:
       
 29329         Fix build by removing unneeded parameters.
       
 29330 
       
 29331 2006-08-18  Anders Carlsson  <acarlsson@apple.com>
       
 29332 
       
 29333         Reviewed by Adele.
       
 29334 
       
 29335         Have the NPN functions call into the plugin view. Implement some of the plugin view methods.
       
 29336 
       
 29337         * plugins/win/PluginViewWin.cpp:
       
 29338         (WebCore::PluginViewWin::start):
       
 29339         (WebCore::PluginViewWin::setCurrentPluginView):
       
 29340         (WebCore::PluginViewWin::currentPluginView):
       
 29341         (WebCore::PluginViewWin::getURLNotify):
       
 29342         (WebCore::PluginViewWin::getURL):
       
 29343         (WebCore::PluginViewWin::postURLNotify):
       
 29344         (WebCore::PluginViewWin::postURL):
       
 29345         (WebCore::PluginViewWin::newStream):
       
 29346         (WebCore::write):
       
 29347         (WebCore::destroyStream):
       
 29348         (WebCore::PluginViewWin::userAgent):
       
 29349         (WebCore::PluginViewWin::status):
       
 29350         (WebCore::PluginViewWin::getValue):
       
 29351         (WebCore::PluginViewWin::setValue):
       
 29352         (WebCore::PluginViewWin::~PluginViewWin):
       
 29353         (WebCore::PluginViewWin::PluginViewWin):
       
 29354         * plugins/win/PluginViewWin.h:
       
 29355         * plugins/win/npapi.cpp:
       
 29356         (pluginViewForInstance):
       
 29357         (NPN_ReloadPlugins):
       
 29358         (NPN_GetURLNotify):
       
 29359         (NPN_GetURL):
       
 29360         (NPN_PostURLNotify):
       
 29361         (NPN_PostURL):
       
 29362         (NPN_NewStream):
       
 29363         (NPN_Write):
       
 29364         (NPN_DestroyStream):
       
 29365         (NPN_UserAgent):
       
 29366         (NPN_Status):
       
 29367         (NPN_GetValue):
       
 29368         (NPN_SetValue):
       
 29369 
       
 29370 2006-08-17  Anders Carlsson  <acarlsson@apple.com>
       
 29371 
       
 29372         Reviewed by Steve and Maciej.
       
 29373 
       
 29374         Add initial implementation of plugin view.
       
 29375 
       
 29376         * WebCore.vcproj/WebCore.vcproj:
       
 29377         Add files.
       
 29378         
       
 29379         * bridge/win/FrameWin.cpp:
       
 29380         (WebCore::FrameWin::objectContentType):
       
 29381         (WebCore::FrameWin::createPlugin):
       
 29382         Implement these functions.
       
 29383         
       
 29384         * platform/win/TemporaryLinkStubs.cpp:
       
 29385         Remove implemented functions.
       
 29386         
       
 29387         * platform/win/WidgetWin.cpp: Add this file from the open source repo
       
 29388         (WebCore::Widget::~Widget):
       
 29389         Call DestroyWindow on the hWnd.
       
 29390         
       
 29391         * plugins/win/PluginDatabaseWin.cpp:
       
 29392         (WebCore::PluginDatabaseWin::createPluginView):
       
 29393         New function which creates a plugin view.
       
 29394         
       
 29395         * plugins/win/PluginDatabaseWin.h:
       
 29396         
       
 29397         * plugins/win/PluginPackageWin.cpp:
       
 29398         (WebCore::PluginPackageWin::load):
       
 29399         Assign the browser functions. They are just stubs for now.
       
 29400                
       
 29401         * plugins/win/PluginViewWin.cpp: Added.
       
 29402         (WebCore::registerPluginView):
       
 29403         (WebCore::PluginViewWndProc):
       
 29404         (WebCore::PluginViewWin::invokeSetWindow):
       
 29405         (WebCore::PluginViewWin::start):
       
 29406         (WebCore::PluginViewWin::stop):
       
 29407         (WebCore::createUTF8String):
       
 29408         (WebCore::createUTF8StringArray):
       
 29409         (WebCore::freeStringArray):
       
 29410         (WebCore::PluginViewWin::~PluginViewWin):
       
 29411         (WebCore::PluginViewWin::PluginViewWin):
       
 29412         * plugins/win/PluginViewWin.h: Added.
       
 29413         (WebCore::PluginViewWin::plugin):
       
 29414         (WebCore::PluginViewWin::instance):
       
 29415         * plugins/win/npapi.cpp: Added.
       
 29416         (NPN_MemAlloc):
       
 29417         (NPN_MemFree):
       
 29418         (NPN_MemFlush):
       
 29419         (NPN_ReloadPlugins):
       
 29420         (NPN_RequestRead):
       
 29421         (NPN_GetURLNotify):
       
 29422         (NPN_GetURL):
       
 29423         (NPN_PostURLNotify):
       
 29424         (NPN_PostURL):
       
 29425         (NPN_NewStream):
       
 29426         (NPN_Write):
       
 29427         (NPN_DestroyStream):
       
 29428         (NPN_UserAgent):
       
 29429         (NPN_Status):
       
 29430         (NPN_InvalidateRect):
       
 29431         (NPN_InvalidateRegion):
       
 29432         (NPN_ForceRedraw):
       
 29433         (NPN_GetValue):
       
 29434         (NPN_SetValue):
       
 29435         (NPN_GetJavaEnv):
       
 29436         (NPN_GetJavaPeer):
       
 29437 
       
 29438 2006-08-17  Anders Carlsson  <acarlsson@apple.com>
       
 29439 
       
 29440         Reviewed by Maciej.
       
 29441 
       
 29442         Add initial implementation of plugin database.
       
 29443         
       
 29444         * WebCore.vcproj/WebCore.vcproj:
       
 29445         Add new files.
       
 29446         
       
 29447         * platform/win/TemporaryLinkStubs.cpp:
       
 29448         Get rid of the PlugInInfoStore stubs.
       
 29449 
       
 29450         * plugins/win/PlugInInfoStoreWin.cpp: Added.
       
 29451         (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
       
 29452         (WebCore::PlugInInfoStore::pluginCount):
       
 29453         (WebCore::PlugInInfoStore::supportsMIMEType):
       
 29454         (WebCore::refreshPlugins):
       
 29455         * plugins/win/PluginDatabaseWin.cpp: Added.
       
 29456         (WebCore::PluginDatabaseWin::installedPlugins):
       
 29457         (WebCore::PluginDatabaseWin::refresh):
       
 29458         (WebCore::PluginDatabaseWin::plugins):
       
 29459         (WebCore::PluginDatabaseWin::getPluginsInPaths):
       
 29460         (WebCore::PluginDatabaseWin::defaultPluginPaths):
       
 29461         (WebCore::PluginDatabaseWin::isMIMETypeRegistered):
       
 29462         (WebCore::PluginDatabaseWin::pluginForMIMEType):
       
 29463         (WebCore::PluginDatabaseWin::pluginForExtension):
       
 29464         * plugins/win/PluginDatabaseWin.h: Added.
       
 29465         (WebCore::PluginDatabaseWin::setPluginPaths):
       
 29466         * plugins/win/PluginPackageWin.cpp: Added.
       
 29467         (WebCore::PluginPackageWin::~PluginPackageWin):
       
 29468         (WebCore::getVersionInfo):
       
 29469         (WebCore::splitString):
       
 29470         (WebCore::PluginPackageWin::PluginPackageWin):
       
 29471         (WebCore::PluginPackageWin::fetchInfo):
       
 29472         (WebCore::PluginPackageWin::load):
       
 29473         (WebCore::PluginPackageWin::unload):
       
 29474         (WebCore::PluginPackageWin::unloadWithoutShutdown):
       
 29475         (WebCore::PluginPackageWin::createPackage):
       
 29476         (WebCore::PluginPackageWin::hash):
       
 29477         (WebCore::PluginPackageWin::equal):
       
 29478         * plugins/win/PluginPackageWin.h: Added.
       
 29479         (WebCore::PluginPackageWin::name):
       
 29480         (WebCore::PluginPackageWin::description):
       
 29481         (WebCore::PluginPackageWin::fileName):
       
 29482         (WebCore::PluginPackageWin::mimeToDescriptions):
       
 29483         (WebCore::PluginPackageWin::mimeToExtensions):
       
 29484         (WebCore::PluginPackageWin::pluginFuncs):
       
 29485         (WebCore::PluginPackageWinHash::hash):
       
 29486         (WebCore::PluginPackageWinHash::equal):
       
 29487         (WTF::):
       
 29488         * plugins/win/npfunctions.h: Added.
       
 29489 
       
 29490 2006-08-17  Adam Roben  <aroben@apple.com>
       
 29491 
       
 29492         Removing this unintentionally added file.
       
 29493 
       
 29494         * rendering/RenderPopupMenuWin.cpp: Removed.
       
 29495 
       
 29496 2006-08-17  Adam Roben  <aroben@apple.com>
       
 29497 
       
 29498         Reviewed by Steve.
       
 29499 
       
 29500         Branching files from OpenSource tree r15924 to prepare for <select>
       
 29501         element implementation.
       
 29502 
       
 29503         * WebCore.vcproj/WebCore.vcproj:
       
 29504         * rendering/RenderPopupMenuWin.h: Added.
       
 29505         (WebCore::RenderPopupMenuWin::RenderPopupMenuWin):
       
 29506         * rendering/RenderThemeWin.cpp: Added.
       
 29507         (WebCore::theme):
       
 29508         (WebCore::m_textFieldTheme):
       
 29509         (WebCore::RenderThemeWin::~RenderThemeWin):
       
 29510         (WebCore::RenderThemeWin::close):
       
 29511         (WebCore::RenderThemeWin::platformActiveSelectionBackgroundColor):
       
 29512         (WebCore::RenderThemeWin::platformInactiveSelectionBackgroundColor):
       
 29513         (WebCore::RenderThemeWin::platformActiveSelectionForegroundColor):
       
 29514         (WebCore::RenderThemeWin::platformInactiveSelectionForegroundColor):
       
 29515         (WebCore::RenderThemeWin::addIntrinsicMargins):
       
 29516         (WebCore::RenderThemeWin::supportsFocus):
       
 29517         (WebCore::RenderThemeWin::determineState):
       
 29518         (WebCore::RenderThemeWin::getThemeData):
       
 29519         (WebCore::RenderThemeWin::adjustButtonStyle):
       
 29520         (WebCore::prepareForDrawing):
       
 29521         (WebCore::doneDrawing):
       
 29522         (WebCore::RenderThemeWin::paintButton):
       
 29523         (WebCore::RenderThemeWin::setCheckboxSize):
       
 29524         (WebCore::RenderThemeWin::setRadioSize):
       
 29525         (WebCore::RenderThemeWin::adjustTextFieldStyle):
       
 29526         (WebCore::RenderThemeWin::paintTextField):
       
 29527         (WebCore::RenderThemeWin::adjustTextAreaStyle):
       
 29528         (WebCore::RenderThemeWin::paintTextArea):
       
 29529         (WebCore::RenderThemeWin::createPopupMenu):
       
 29530         * rendering/RenderThemeWin.h: Added.
       
 29531         (WebCore::ThemeData::m_state):
       
 29532         (WebCore::RenderThemeWin::supportsHover):
       
 29533         (WebCore::RenderThemeWin::paintCheckbox):
       
 29534         (WebCore::RenderThemeWin::paintRadio):
       
 29535 
       
 29536 2006-08-15  Steve Falkenburg  <sfalken@apple.com>
       
 29537 
       
 29538         Pull TemporaryLinkStubs.cpp into internal tree to fix the build.
       
 29539 
       
 29540         * WebCore.vcproj/WebCore.vcproj:
       
 29541         * platform/win/TemporaryLinkStubs.cpp: Added.
       
 29542         (notImplemented):
       
 29543         (FrameView::updateBorder):
       
 29544         (FrameView::isFrameView):
       
 29545         (PopUpButton::focusPolicy):
       
 29546         (PopUpButton::populate):
       
 29547         (Widget::enableFlushDrawing):
       
 29548         (Widget::isEnabled):
       
 29549         (Widget::focusPolicy):
       
 29550         (Widget::disableFlushDrawing):
       
 29551         (Widget::lockDrawingFocus):
       
 29552         (Widget::unlockDrawingFocus):
       
 29553         (JavaAppletWidget::JavaAppletWidget):
       
 29554         (TextField::selectAll):
       
 29555         (TextField::addSearchResult):
       
 29556         (TextField::selectionStart):
       
 29557         (TextField::hasSelectedText):
       
 29558         (TextField::selectedText):
       
 29559         (TextField::setAutoSaveName):
       
 29560         (TextField::checksDescendantsForFocus):
       
 29561         (TextField::setSelection):
       
 29562         (TextField::setMaxResults):
       
 29563         (TextField::edited):
       
 29564         (Slider::Slider):
       
 29565         (Slider::sizeHint):
       
 29566         (Slider::setValue):
       
 29567         (Slider::setMaxValue):
       
 29568         (Slider::setMinValue):
       
 29569         (Slider::~Slider):
       
 29570         (Slider::setFont):
       
 29571         (Slider::value):
       
 29572         (ListBox::setSelected):
       
 29573         (ListBox::sizeForNumberOfLines):
       
 29574         (ListBox::isSelected):
       
 29575         (ListBox::appendItem):
       
 29576         (ListBox::doneAppendingItems):
       
 29577         (ListBox::setWritingDirection):
       
 29578         (ListBox::setEnabled):
       
 29579         (ListBox::clear):
       
 29580         (ListBox::checksDescendantsForFocus):
       
 29581         (FileButton::FileButton):
       
 29582         (FileButton::click):
       
 29583         (FileButton::sizeForCharacterWidth):
       
 29584         (FileButton::focusPolicy):
       
 29585         (FileButton::frameGeometry):
       
 29586         (FileButton::setFilename):
       
 29587         (FileButton::baselinePosition):
       
 29588         (FileButton::setFrameGeometry):
       
 29589         (FileButton::setDisabled):
       
 29590         (Slider::focusPolicy):
       
 29591         (ListBox::focusPolicy):
       
 29592         (TextField::focusPolicy):
       
 29593         (Cursor::Cursor):
       
 29594         (PlatformMouseEvent::PlatformMouseEvent):
       
 29595         (WebCore::searchableIndexIntroduction):
       
 29596         (WebCore::findNextSentenceFromIndex):
       
 29597         (WebCore::findSentenceBoundary):
       
 29598         (WebCore::findNextWordFromIndex):
       
 29599         (WebCore::ServeSynchronousRequest):
       
 29600         (FrameWin::focusWindow):
       
 29601         (FrameWin::unfocusWindow):
       
 29602         (FrameWin::locationbarVisible):
       
 29603         (FrameWin::issueRedoCommand):
       
 29604         (FrameWin::getObjectInstanceForWidget):
       
 29605         (FrameWin::getEmbedInstanceForWidget):
       
 29606         (FrameWin::canRedo):
       
 29607         (FrameWin::canUndo):
       
 29608         (FrameWin::registerCommandForRedo):
       
 29609         (FrameWin::runJavaScriptPrompt):
       
 29610         (FrameWin::shouldInterruptJavaScript):
       
 29611         (FrameWin::openURL):
       
 29612         (FrameWin::print):
       
 29613         (FrameWin::getAppletInstanceForWidget):
       
 29614         (FrameWin::passMouseDownEventToWidget):
       
 29615         (FrameWin::issueCutCommand):
       
 29616         (FrameWin::issueCopyCommand):
       
 29617         (FrameWin::passWheelEventToChildWidget):
       
 29618         (FrameWin::issueUndoCommand):
       
 29619         (FrameWin::mimeTypeForFileName):
       
 29620         (FrameWin::issuePasteCommand):
       
 29621         (FrameWin::scheduleClose):
       
 29622         (FrameWin::markMisspellings):
       
 29623         (FrameWin::menubarVisible):
       
 29624         (FrameWin::personalbarVisible):
       
 29625         (FrameWin::statusbarVisible):
       
 29626         (FrameWin::toolbarVisible):
       
 29627         (FrameWin::issueTransposeCommand):
       
 29628         (FrameWin::canPaste):
       
 29629         (FrameWin::objectContentType):
       
 29630         (FrameWin::canGoBackOrForward):
       
 29631         (FrameWin::issuePasteAndMatchStyleCommand):
       
 29632         (FrameWin::createPlugin):
       
 29633         (BrowserExtensionWin::canRunModal):
       
 29634         (BrowserExtensionWin::createNewWindow):
       
 29635         (BrowserExtensionWin::canRunModalNow):
       
 29636         (BrowserExtensionWin::runModal):
       
 29637         (BrowserExtensionWin::goBackOrForward):
       
 29638         (BrowserExtensionWin::historyURL):
       
 29639         (GraphicsContext::addRoundedRectClip):
       
 29640         (GraphicsContext::addInnerRoundedRectClip):
       
 29641         (WebCore::screenDepthPerComponent):
       
 29642         (WebCore::screenIsMonochrome):
       
 29643         (WebCore::moveCursor):
       
 29644         (WebCore::historyContains):
       
 29645         (WebCore::submitButtonDefaultLabel):
       
 29646         (WebCore::inputElementAltText):
       
 29647         (WebCore::resetButtonDefaultLabel):
       
 29648         (WebCore::defaultLanguage):
       
 29649         (WebCore::findWordBoundary):
       
 29650         (PlugInInfoStore::createPluginInfoForPluginAtIndex):
       
 29651         (PlugInInfoStore::pluginCount):
       
 29652         (WebCore::PlugInInfoStore::supportsMIMEType):
       
 29653         (WebCore::refreshPlugins):
       
 29654         (WebCore::ResourceLoader::assembleResponseHeaders):
       
 29655         (WebCore::ResourceLoader::retrieveCharset):
       
 29656         (FrameWin::restoreDocumentState):
       
 29657         (FrameWin::partClearedInBegin):
       
 29658         (FrameWin::createEmptyDocument):
       
 29659         (FrameWin::overrideMediaType):
       
 29660         (FrameWin::handledOnloadEvents):
       
 29661         (FrameWin::markedTextRange):
       
 29662         (FrameWin::passSubframeEventToSubframe):
       
 29663         (FrameWin::lastEventIsMouseUp):
       
 29664         (FrameWin::addMessageToConsole):
       
 29665         (FrameWin::shouldChangeSelection):
       
 29666         (FrameWin::respondToChangedSelection):
       
 29667         (FrameWin::createFrame):
       
 29668         (FrameWin::saveDocumentState):
       
 29669         (FrameWin::registerCommandForUndo):
       
 29670         (FrameWin::clearUndoRedoOperations):
       
 29671         (FrameWin::incomingReferrer):
       
 29672         (FrameWin::markMisspellingsInAdjacentWords):
       
 29673         (FrameWin::respondToChangedContents):
       
 29674         (BrowserExtensionWin::BrowserExtensionWin):
       
 29675         (BrowserExtensionWin::setTypedIconURL):
       
 29676         (BrowserExtensionWin::setIconURL):
       
 29677         (BrowserExtensionWin::getHistoryLength):
       
 29678         (WebCore::CheckIfReloading):
       
 29679         (WebCore::CheckCacheObjectStatus):
       
 29680         (Widget::setEnabled):
       
 29681         (Widget::paint):
       
 29682         (Widget::setIsSelected):
       
 29683         (ScrollView::addChild):
       
 29684         (ScrollView::removeChild):
       
 29685         (ScrollView::scrollPointRecursively):
       
 29686         (ScrollView::inWindow):
       
 29687         (GraphicsContext::setShadow):
       
 29688         (GraphicsContext::clearShadow):
       
 29689         (GraphicsContext::beginTransparencyLayer):
       
 29690         (GraphicsContext::endTransparencyLayer):
       
 29691         (GraphicsContext::clearRect):
       
 29692         (GraphicsContext::strokeRect):
       
 29693         (GraphicsContext::setLineWidth):
       
 29694         (GraphicsContext::setLineCap):
       
 29695         (GraphicsContext::setLineJoin):
       
 29696         (GraphicsContext::setMiterLimit):
       
 29697         (GraphicsContext::setAlpha):
       
 29698         (GraphicsContext::setCompositeOperation):
       
 29699         (GraphicsContext::clip):
       
 29700         (GraphicsContext::translate):
       
 29701         (GraphicsContext::rotate):
       
 29702         (GraphicsContext::scale):
       
 29703         (Path::Path):
       
 29704         (Path::~Path):
       
 29705         (Path::contains):
       
 29706         (Path::translate):
       
 29707         (Path::boundingRect):
       
 29708         (Path::operator=):
       
 29709         (Path::clear):
       
 29710         (Path::moveTo):
       
 29711         (Path::addLineTo):
       
 29712         (Path::addQuadCurveTo):
       
 29713         (Path::addBezierCurveTo):
       
 29714         (Path::addArcTo):
       
 29715         (Path::closeSubpath):
       
 29716         (Path::addArc):
       
 29717         (Path::addRect):
       
 29718         (Path::addEllipse):
       
 29719         (TextField::TextField):
       
 29720         (TextField::~TextField):
       
 29721         (TextField::setFont):
       
 29722         (TextField::setAlignment):
       
 29723         (TextField::setWritingDirection):
       
 29724         (TextField::maxLength):
       
 29725         (TextField::setMaxLength):
       
 29726         (TextField::text):
       
 29727         (TextField::setText):
       
 29728         (TextField::cursorPosition):
       
 29729         (TextField::setCursorPosition):
       
 29730         (TextField::setEdited):
       
 29731         (TextField::setReadOnly):
       
 29732         (TextField::setPlaceholderString):
       
 29733         (TextField::setColors):
       
 29734         (TextField::sizeForCharacterWidth):
       
 29735         (TextField::baselinePosition):
       
 29736         (TextField::setLiveSearch):
       
 29737         (PopUpButton::PopUpButton):
       
 29738         (PopUpButton::~PopUpButton):
       
 29739         (PopUpButton::setFont):
       
 29740         (PopUpButton::baselinePosition):
       
 29741         (PopUpButton::setWritingDirection):
       
 29742         (PopUpButton::clear):
       
 29743         (PopUpButton::appendItem):
       
 29744         (PopUpButton::setCurrentItem):
       
 29745         (PopUpButton::sizeHint):
       
 29746         (PopUpButton::frameGeometry):
       
 29747         (PopUpButton::setFrameGeometry):
       
 29748         (PlatformScrollBar::PlatformScrollBar):
       
 29749         (PlatformScrollBar::~PlatformScrollBar):
       
 29750         (PlatformScrollBar::width):
       
 29751         (PlatformScrollBar::height):
       
 29752         (PlatformScrollBar::setEnabled):
       
 29753         (PlatformScrollBar::paint):
       
 29754         (PlatformScrollBar::setScrollBarValue):
       
 29755         (PlatformScrollBar::setKnobProportion):
       
 29756         (PlatformScrollBar::setRect):
       
 29757         (ScrollBar::ScrollBar):
       
 29758         (ScrollBar::setSteps):
       
 29759         (ScrollBar::scroll):
       
 29760         (ScrollBar::setValue):
       
 29761         (ScrollBar::setKnobProportion):
       
 29762         (ListBox::ListBox):
       
 29763         (ListBox::~ListBox):
       
 29764         (ListBox::setSelectionMode):
       
 29765         (ListBox::setFont):
       
 29766         (WebCore::focusRingColor):
       
 29767         (WebCore::setFocusRingColorChangeFunction):
       
 29768         (Frame::setNeedsReapplyStyles):
       
 29769         (Image::drawTiled):
       
 29770         (RenderPopupMenuWin::~RenderPopupMenuWin):
       
 29771         (RenderPopupMenuWin::clear):
       
 29772         (RenderPopupMenuWin::populate):
       
 29773         (RenderPopupMenuWin::showPopup):
       
 29774         (RenderPopupMenuWin::addSeparator):
       
 29775         (RenderPopupMenuWin::addGroupLabel):
       
 29776         (RenderPopupMenuWin::addOption):
       
 29777         (RenderThemeWin::paintMenuList):
       
 29778         (RenderThemeWin::adjustMenuListStyle):
       
 29779         (RenderThemeWin::systemFont):
       
 29780 
       
 29781 2006-08-15  Steve Falkenburg  <sfalken@apple.com>
       
 29782 
       
 29783         Fix the build with TOT.
       
 29784 
       
 29785         * WebCore.vcproj/WebCore.vcproj:
       
 29786 
       
 29787 2006-08-15  Steve Falkenburg  <sfalken@apple.com>
       
 29788 
       
 29789         Get this building.
       
 29790 
       
 29791         * WebCore.vcproj/WebCore.sln:
       
 29792         * WebCore.vcproj/WebCore.vcproj:
       
 29793         * WebCore.vcproj/build-generated-files.sh:
       
 29794 
       
 29795 2006-08-15  Steve Falkenburg  <sfalken@apple.com>
       
 29796 
       
 29797         Initial check-in.
       
 29798 
       
 29799         * ChangeLog: Added.
       
 29800         * WebCore.vcproj/WebCore.sln: Added.
       
 29801         * WebCore.vcproj/WebCore.vcproj: Added.
       
 29802         * WebCore.vcproj/build-generated-files.sh: Added.
       
 29803         * bridge/win/FrameWin.cpp: Added.
       
 29804         (WebCore::FrameWin::FrameWin):
       
 29805         (WebCore::FrameWin::~FrameWin):
       
 29806         (WebCore::FrameWin::urlSelected):
       
 29807         (WebCore::FrameWin::submitForm):
       
 29808         (WebCore::FrameWin::userAgent):
       
 29809         (WebCore::FrameWin::runJavaScriptAlert):
       
 29810         (WebCore::FrameWin::runJavaScriptConfirm):
       
 29811         (WebCore::FrameWin::keyPress):
       
 29812         (WebCore::FrameWin::setTitle):
       
 29813         (WebCore::FrameWin::setStatusBarText):
       
 29814         (WebCore::FrameWin::textFieldDidBeginEditing):
       
 29815         (WebCore::FrameWin::textFieldDidEndEditing):
       
 29816         (WebCore::FrameWin::textDidChangeInTextField):
       
 29817         (WebCore::FrameWin::doTextFieldCommandFromEvent):
       
 29818         (WebCore::FrameWin::textWillBeDeletedInTextField):
       
 29819         (WebCore::FrameWin::textDidChangeInTextArea):
       
 29820         * bridge/win/FrameWin.h: Added.
       
 29821         (WebCore::Win):
       
 29822         * platform/win/ResourceLoaderWin.cpp: Added.
       
 29823         (WebCore::addToOutstandingJobs):
       
 29824         (WebCore::removeFromOutstandingJobs):
       
 29825         (WebCore::lookupResourceLoader):
       
 29826         (WebCore::ResourceLoaderWndProc):
       
 29827         (WebCore::initializeOffScreenResourceLoaderWindow):
       
 29828         (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
       
 29829         (WebCore::ResourceLoader::~ResourceLoader):
       
 29830         (WebCore::transferJobStatusCallback):
       
 29831         (WebCore::ResourceLoader::start):
       
 29832         (WebCore::ResourceLoader::fileLoadTimer):
       
 29833         (WebCore::ResourceLoader::cancel):
       
 29834         * platform/win/ResourceLoaderWin.h: Added.
       
 29835 
       
 29836 === End of merged changes from branches/WindowsMerge ===
       
 29837 
       
 29838 2007-06-10  Holger Hans Peter Freyther  <zecke@selfish.org>
       
 29839 
       
 29840          Reviewed by Maciej.
       
 29841  
       
 29842          Disable whole-view editing for the Gdk port in order to improve the browsing experience.
       
 29843  
       
 29844          * platform/gdk/EditorClientGdk.cpp:
       
 29845          (WebCore::EditorClientGdk::isEditable): Return false to disable whole-view editing
       
 29846  
       
 29847 2007-06-08  Sam Weinig  <sam@webkit.org>
       
 29848 
       
 29849         Reviewed by Oliver.
       
 29850 
       
 29851         Patch for http://bugs.webkit.org/show_bug.cgi?id=14044
       
 29852         Autogenerate the JS bindings for HTMLCollection
       
 29853 
       
 29854         - also moves JSHTMLAllCollection into it's own file.
       
 29855 
       
 29856         * DerivedSources.make:
       
 29857         * WebCore.pro:
       
 29858         * WebCore.xcodeproj/project.pbxproj:
       
 29859         * bindings/js/JSHTMLAllCollection.h: Added.
       
 29860         (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
       
 29861         (WebCore::JSHTMLAllCollection::toBoolean):
       
 29862         (WebCore::JSHTMLAllCollection::masqueradeAsUndefined):
       
 29863         * bindings/js/JSHTMLCollectionCustom.cpp: Added.
       
 29864         (WebCore::getNamedItems):
       
 29865         (WebCore::JSHTMLCollection::callAsFunction):
       
 29866         (WebCore::JSHTMLCollection::implementsCall):
       
 29867         (WebCore::JSHTMLCollection::canGetItemsForName):
       
 29868         (WebCore::JSHTMLCollection::nameGetter):
       
 29869         (WebCore::JSHTMLCollection::item):
       
 29870         (WebCore::JSHTMLCollection::namedItem):
       
 29871         (WebCore::toJS):
       
 29872         * bindings/js/JSHTMLDocumentCustom.cpp:
       
 29873         (WebCore::JSHTMLDocument::nameGetter):
       
 29874         (WebCore::JSHTMLDocument::all):
       
 29875         * bindings/js/JSXMLHttpRequest.cpp:
       
 29876         * bindings/js/kjs_html.cpp:
       
 29877         (WebCore::ImageConstructorImp::ImageConstructorImp):
       
 29878         (WebCore::ImageConstructorImp::construct):
       
 29879         * bindings/js/kjs_html.h:
       
 29880         (WebCore::ImageConstructorImp::implementsConstruct):
       
 29881         * bindings/js/kjs_window.cpp:
       
 29882         (KJS::Window::namedItemGetter):
       
 29883         * bindings/objc/DOMUtility.mm:
       
 29884         (KJS::createDOMWrapper):
       
 29885         * bindings/scripts/CodeGeneratorJS.pm:
       
 29886         * html/HTMLCollection.cpp:
       
 29887         (WebCore::HTMLCollection::tags):
       
 29888         * html/HTMLCollection.h:
       
 29889         (WebCore::HTMLCollection::collectionType):
       
 29890         * html/HTMLCollection.idl:
       
 29891         * html/HTMLOptionsCollection.idl:
       
 29892 
       
 29893 2007-06-08  Justin Garcia  <justin.garcia@apple.com>
       
 29894 
       
 29895         Reviewed by John.
       
 29896         
       
 29897         <rdar://problem/5232159> REGRESSION: Cannot select text in RSS view
       
 29898 
       
 29899         The selection is updated both on mouse movement and
       
 29900         when the autoscroll timer fires.  The autoscroll
       
 29901         code wasn't converting mouse coordinates to layer
       
 29902         coordinates correctly, and was then using those
       
 29903         coordinates to create a bad selection.
       
 29904 
       
 29905         * rendering/RenderLayer.cpp:
       
 29906         (WebCore::RenderLayer::autoscroll): Use convertToLayerCoordinates.
       
 29907 
       
 29908 2007-06-08  Anders Carlsson  <andersca@apple.com>
       
 29909 
       
 29910         Reviewed by Geoff.
       
 29911 
       
 29912         Store the root object in a hash set, keyed by the plugin view. This is in preparation for 
       
 29913         letting plugins invalidate the root object upon destruction
       
 29914 
       
 29915         * page/Frame.cpp:
       
 29916         (WebCore::Frame::createRootObject):
       
 29917         (WebCore::Frame::cleanupScriptObjects):
       
 29918         * page/FramePrivate.h:
       
 29919 
       
 29920 2007-06-08  Lars Knoll <lars@trolltech.com>
       
 29921 
       
 29922         Reviewed by Zack.
       
 29923 
       
 29924         Add qwebobjectpluginconnector to the build.
       
 29925 
       
 29926         * WebCore.pro:
       
 29927 
       
 29928 2007-06-07  Justin Garcia  <justin.garcia@apple.com>
       
 29929 
       
 29930         Reviewed by Tristan.
       
 29931         
       
 29932         <rdar://problem/5250997> A crash occurs when selecting Undo Typing for a page that has been closed in tab
       
 29933 
       
 29934         * WebCore.exp: Added clearUndoRedoOperations.
       
 29935         * page/Page.cpp:
       
 29936         (WebCore::Page::clearUndoRedoOperations): Added.
       
 29937         * page/Page.h:
       
 29938         
       
 29939 2007-06-07  David Hyatt  <hyatt@apple.com>
       
 29940 
       
 29941         Fix crash.  Null check layer.  Bug 13984.
       
 29942 
       
 29943         Reviewed by andersca
       
 29944 
       
 29945         * WebCore.xcodeproj/project.pbxproj:
       
 29946         * page/FrameView.cpp:
       
 29947         (WebCore::FrameView::windowClipRectForLayer):
       
 29948 
       
 29949 2007-06-07  Oliver Hunt  <oliver@apple.com>
       
 29950 
       
 29951         Reviewed by Justin.
       
 29952 
       
 29953         Remove incorrect assertions.
       
 29954         
       
 29955         These assertions were made on the assumption that 
       
 29956         TSM would always call with a range that was contained 
       
 29957         by an editable region.
       
 29958         
       
 29959         TSM may call -[WebHTMLView characterIndexForPoint:] on a mouse
       
 29960         event that is otherwise unrelated to editing, which may
       
 29961         be outside the current editing region, triggering these 
       
 29962         assertions.
       
 29963 
       
 29964         * page/mac/WebCoreFrameBridge.mm:
       
 29965         (-[WebCoreFrameBridge convertToNSRange:]):
       
 29966 
       
 29967 2007-06-07  Justin Garcia  <justin.garcia@apple.com>
       
 29968 
       
 29969         Reviewed by John.
       
 29970         
       
 29971         <rdar://problem/5237074> REGRESSION: editing/unsupported-content/table-delete-003 is failing (13931)
       
 29972         
       
 29973         * editing/DeleteSelectionCommand.cpp:
       
 29974         (WebCore::DeleteSelectionCommand::initializeStartEnd):
       
 29975         We wouldn't expand the selection to include a special element 
       
 29976         at the start of the selection unless the end of the selection 
       
 29977         was at the end of a special element. Avoid a special 
       
 29978         element at the start as long as it's fully selected. Ditto for 
       
 29979         the end.
       
 29980         * editing/htmlediting.cpp:
       
 29981         (WebCore::positionBeforeContainingSpecialElement):
       
 29982         (WebCore::positionAfterContainingSpecialElement):
       
 29983 
       
 29984 2007-06-07  Sam Weinig  <sam@webkit.org>
       
 29985 
       
 29986         Reviewed by Anders.
       
 29987 
       
 29988         Patch for  http://bugs.webkit.org/show_bug.cgi?id=14028
       
 29989         Finish autogenerating the JS bindings for Node
       
 29990 
       
 29991         * DerivedSources.make:
       
 29992         * WebCore.pro:
       
 29993         * WebCore.xcodeproj/project.pbxproj:
       
 29994         * bindings/js/JSHTMLElementWrapperFactory.cpp:
       
 29995         (WebCore::createJSHTMLWrapper):
       
 29996         * bindings/js/JSHTMLElementWrapperFactory.h:
       
 29997         * bindings/js/JSHTMLOptionElementConstructor.cpp:
       
 29998         * bindings/js/JSNamedNodeMapCustom.cpp:
       
 29999         * bindings/js/JSNodeCustom.cpp:
       
 30000         (WebCore::JSNode::insertBefore):
       
 30001         (WebCore::JSNode::replaceChild):
       
 30002         (WebCore::JSNode::removeChild):
       
 30003         (WebCore::JSNode::appendChild):
       
 30004         (WebCore::JSNode::mark):
       
 30005         (WebCore::toJS):
       
 30006         * bindings/js/JSSVGElementWrapperFactory.cpp:
       
 30007         (WebCore::createJSSVGWrapper):
       
 30008         * bindings/js/JSSVGElementWrapperFactory.h:
       
 30009         * bindings/js/JSXSLTProcessor.cpp:
       
 30010         (KJS::XSLTProcessorPrototypeFunction::callAsFunction):
       
 30011         * bindings/js/kjs_binding.cpp:
       
 30012         (KJS::ScriptInterpreter::getDOMNodeForDocument):
       
 30013         (KJS::ScriptInterpreter::putDOMNodeForDocument):
       
 30014         (KJS::ScriptInterpreter::markDOMNodesForDocument):
       
 30015         (KJS::ScriptInterpreter::updateDOMNodeDocument):
       
 30016         * bindings/js/kjs_binding.h:
       
 30017         * bindings/js/kjs_dom.cpp:
       
 30018         (WebCore::toAttr):
       
 30019         * bindings/js/kjs_dom.h:
       
 30020         * bindings/js/kjs_domnode.h: Removed.
       
 30021         * bindings/objc/DOMUtility.mm:
       
 30022         (KJS::createDOMWrapper):
       
 30023         * bindings/scripts/CodeGeneratorJS.pm:
       
 30024         * dom/Node.h:
       
 30025         (WebCore::Node::parentElement):
       
 30026         * dom/Node.idl:
       
 30027 
       
 30028 2007-06-07  Sam Weinig  <sam@webkit.org>
       
 30029 
       
 30030         Another Gdk and Qt build fix.
       
 30031 
       
 30032         * WebCore.pro:
       
 30033 
       
 30034 2007-06-07  Sam Weinig  <sam@webkit.org>
       
 30035 
       
 30036         Gdk and Qt build fix.
       
 30037 
       
 30038         * WebCore.pro:
       
 30039 
       
 30040 2007-06-06  Sam Weinig  <sam@webkit.org>
       
 30041 
       
 30042         Reviewed by Hyatt.
       
 30043 
       
 30044         Patch for http://bugs.webkit.org/show_bug.cgi?id=13973
       
 30045         Autogenerate most of the rest of kjs_dom.h/cpp
       
 30046 
       
 30047         - Autogenerate JSNodeList and JSNamedNodeMap.
       
 30048         - Move JSEventTargetNode, JSNamedNodesCollection, and JSDOMExceptionConstructor 
       
 30049           into their own files.
       
 30050         - Rename KJS::DOMEventTargeNode to WebCore::JSEventTargetNode to adhere
       
 30051           to convention and allow easier code generation.
       
 30052         - Add JS constructors for JSNodeList and JSNamedNodeMap.
       
 30053         - Moved more toJS methods into the correct (corresponding) header files.
       
 30054         - Cleaned up code in order for changes to work.
       
 30055 
       
 30056         * DerivedSources.make:
       
 30057         * WebCore.xcodeproj/project.pbxproj:
       
 30058         * bindings/js/JSDOMExceptionConstructor.cpp: Added.
       
 30059         (WebCore::):
       
 30060         (WebCore::JSDOMExceptionConstructor::JSDOMExceptionConstructor):
       
 30061         (WebCore::JSDOMExceptionConstructor::getOwnPropertySlot):
       
 30062         (WebCore::JSDOMExceptionConstructor::getValueProperty):
       
 30063         (WebCore::getDOMExceptionConstructor):
       
 30064         * bindings/js/JSDOMExceptionConstructor.h: Added.
       
 30065         (WebCore::JSDOMExceptionConstructor::classInfo):
       
 30066         * bindings/js/JSDOMWindowCustom.cpp: Added.
       
 30067         (WebCore::JSDOMWindow::customGetOwnPropertySlot):
       
 30068         * bindings/js/JSDocumentCustom.cpp:
       
 30069         (WebCore::JSDocument::mark):
       
 30070         (WebCore::toJS):
       
 30071         * bindings/js/JSEventTargetNode.cpp: Added.
       
 30072         (WebCore::JSEventTargetNode::JSEventTargetNode):
       
 30073         (WebCore::JSEventTargetNode::getOwnPropertySlot):
       
 30074         (WebCore::JSEventTargetNode::getValueProperty):
       
 30075         (WebCore::JSEventTargetNode::put):
       
 30076         (WebCore::JSEventTargetNode::putValueProperty):
       
 30077         (WebCore::JSEventTargetNode::setListener):
       
 30078         (WebCore::JSEventTargetNode::getListener):
       
 30079         (WebCore::JSEventTargetNode::pushEventHandlerScope):
       
 30080         (WebCore::JSEventTargetNodePrototypeFunction::callAsFunction):
       
 30081         (WebCore::toEventTargetNode):
       
 30082         * bindings/js/JSEventTargetNode.h: Added.
       
 30083         (WebCore::JSEventTargetNode::):
       
 30084         * bindings/js/JSHTMLElementCustom.cpp:
       
 30085         * bindings/js/JSHTMLFormElementCustom.cpp:
       
 30086         (WebCore::JSHTMLFormElement::nameGetter):
       
 30087         * bindings/js/JSHTMLOptionElementConstructor.cpp:
       
 30088         * bindings/js/JSNamedNodeMapCustom.cpp: Added.
       
 30089         (WebCore::JSNamedNodeMap::canGetItemsForName):
       
 30090         (WebCore::JSNamedNodeMap::nameGetter):
       
 30091         * bindings/js/JSNamedNodesCollection.cpp: Added.
       
 30092         (WebCore::):
       
 30093         (WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
       
 30094         (WebCore::JSNamedNodesCollection::lengthGetter):
       
 30095         (WebCore::JSNamedNodesCollection::indexGetter):
       
 30096         (WebCore::JSNamedNodesCollection::getOwnPropertySlot):
       
 30097         * bindings/js/JSNamedNodesCollection.h: Added.
       
 30098         (WebCore::JSNamedNodesCollection::classInfo):
       
 30099         * bindings/js/JSNodeCustom.cpp: Added.
       
 30100         (WebCore::toJS):
       
 30101         * bindings/js/JSNodeListCustom.cpp: Added.
       
 30102         (WebCore::JSNodeList::callAsFunction):
       
 30103         (WebCore::JSNodeList::implementsCall):
       
 30104         (WebCore::JSNodeList::canGetItemsForName):
       
 30105         (WebCore::JSNodeList::nameGetter):
       
 30106         * bindings/js/kjs_dom.cpp:
       
 30107         * bindings/js/kjs_dom.h:
       
 30108         * bindings/js/kjs_domnode.h:
       
 30109         * bindings/js/kjs_events.cpp:
       
 30110         (KJS::JSLazyEventListener::parseCode):
       
 30111         * bindings/js/kjs_html.cpp:
       
 30112         (KJS::JSHTMLCollection::getNamedItems):
       
 30113         * bindings/js/kjs_html.h:
       
 30114         * bindings/js/kjs_window.cpp:
       
 30115         (WebCore::toJS):
       
 30116         * bindings/js/kjs_window.h:
       
 30117         * bindings/objc/DOMInternal.mm:
       
 30118         (-[WebScriptObject _initializeScriptDOMNodeImp]):
       
 30119         * bindings/objc/DOMUtility.mm:
       
 30120         (KJS::createDOMWrapper):
       
 30121         * bindings/scripts/CodeGeneratorJS.pm:
       
 30122         * bridge/mac/WebCoreAXObject.mm:
       
 30123         * dom/Attr.idl:
       
 30124         * dom/CharacterData.idl:
       
 30125         * dom/Document.idl:
       
 30126         * dom/DocumentFragment.idl:
       
 30127         * dom/DocumentType.idl:
       
 30128         * dom/Element.idl:
       
 30129         * dom/NamedNodeMap.idl:
       
 30130         * dom/Node.idl:
       
 30131         * dom/NodeList.idl:
       
 30132         * page/DOMWindow.idl:
       
 30133 
       
 30134 2007-06-06  Justin Garcia  <justin.garcia@apple.com>
       
 30135 
       
 30136         Reviewed by Oliver.
       
 30137         
       
 30138         <rdar://problem/5245519> CrashTracer: [USER] 457 crashes in Mail at WebCore::CSSComputedStyleDeclaration::copyInheritableProperties()
       
 30139         
       
 30140         If the user pastes something into a region that ends up being
       
 30141         invisible, or if the pasted content contains style spans 
       
 30142         that are render-less, we'll crash when we try to remove
       
 30143         redundant styles from style spans.
       
 30144 
       
 30145         * css/CSSComputedStyleDeclaration.cpp:
       
 30146         (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties):
       
 30147         Add null checks.
       
 30148 
       
 30149 2007-06-06  Justin Garcia  <justin.garcia@apple.com>
       
 30150 
       
 30151         Reviewed by Harrison.
       
 30152 
       
 30153         <rdar://problem/4889598> Problems with moveDown: and moveUp: in Notes with ToDos
       
 30154         
       
 30155         The caret would disappear when moving from content above or below
       
 30156         a ToDo if that ToDo doesn't have any content in it with the same
       
 30157         x position as the caret. That's because closestLeafChildForXPos
       
 30158         would return non-editable leaves, and which turn into non-editable
       
 30159         VisiblePositions, which are invisible.
       
 30160 
       
 30161         * editing/visible_units.cpp:
       
 30162         (WebCore::previousLinePosition): Ask closestLeafForXPos to only
       
 30163         return editable leaves.
       
 30164         (WebCore::nextLinePosition): Ditto.
       
 30165         * rendering/RootInlineBox.cpp:
       
 30166         (WebCore::isEditableLeaf): Added.
       
 30167         (WebCore::RootInlineBox::closestLeafChildForXPos): If requested,
       
 30168         return the closest editable leaf. Removed an early return if the
       
 30169         position is before the first leaf, it's not really much of an
       
 30170         optimization.
       
 30171         * rendering/RootInlineBox.h:
       
 30172 
       
 30173 2007-06-06  Sam Weinig  <sam@webkit.org>
       
 30174 
       
 30175         Reviewed by Anders.
       
 30176 
       
 30177         Fix release build.
       
 30178 
       
 30179         * bindings/objc/DOM.mm:
       
 30180         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): Add missing null initialization.
       
 30181         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): Add missing null initialization.
       
 30182 
       
 30183 2007-06-06  Sam Weinig  <sam@webkit.org>
       
 30184 
       
 30185         Reviewed by Hyatt.
       
 30186 
       
 30187         Patch for http://bugs.webkit.org/show_bug.cgi?id=13947
       
 30188         Finish autogenerating the JS DOM traversal code
       
 30189 
       
 30190         - Completely generate JSNodeFilter.
       
 30191         - Move JSNodeFilterCondition into its own file
       
 30192 
       
 30193         * DerivedSources.make:
       
 30194         * WebCore.pro:
       
 30195         * WebCore.xcodeproj/project.pbxproj:
       
 30196         * bindings/js/JSNodeFilterCondition.cpp: Copied from WebCore/bindings/js/kjs_traversal.cpp.
       
 30197         (WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
       
 30198         (WebCore::JSNodeFilterCondition::mark):
       
 30199         (WebCore::JSNodeFilterCondition::acceptNode):
       
 30200         * bindings/js/JSNodeFilterCondition.h: Copied from WebCore/bindings/js/kjs_traversal.h.
       
 30201         * bindings/js/JSNodeFilterCustom.cpp: Added.
       
 30202         (WebCore::JSNodeFilter::mark):
       
 30203         (WebCore::toNodeFilter):
       
 30204         * bindings/js/kjs_dom.cpp:
       
 30205         * bindings/js/kjs_traversal.cpp: Removed.
       
 30206         * bindings/js/kjs_traversal.h: Removed.
       
 30207         * bindings/js/kjs_window.cpp:
       
 30208         * bindings/objc/DOM.mm:
       
 30209         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
       
 30210         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
       
 30211         * bindings/scripts/CodeGeneratorJS.pm:
       
 30212         * dom/Document.cpp:
       
 30213         (WebCore::Document::createNodeIterator):
       
 30214         (WebCore::Document::createTreeWalker):
       
 30215         * dom/Document.h:
       
 30216         * dom/NodeFilter.idl:
       
 30217 
       
 30218 2007-06-06  Alp Toker  <alp.toker@collabora.co.uk>
       
 30219 
       
 30220         Reviewed by Eric Seidel.
       
 30221 
       
 30222         http://bugs.webkit.org/show_bug.cgi?id=14017
       
 30223         Cairo: Unwanted gradient effect for small stretched images
       
 30224 
       
 30225         * platform/graphics/cairo/ImageCairo.cpp: Use CAIRO_FILTER_NEAREST to
       
 30226         work around the issue.
       
 30227         (WebCore::BitmapImage::draw):
       
 30228         (WebCore::Image::drawPattern):
       
 30229 
       
 30230 2007-06-06  Lars Knoll <lars@trolltech.com>
       
 30231 
       
 30232         Reviewed by Zack
       
 30233 
       
 30234         Add an API to create and load plugins.
       
 30235         Don't include moc files by hand anymore, rather let
       
 30236         qmake handle them.
       
 30237 
       
 30238         * WebCore.pro:
       
 30239         * platform/qt/MimeTypeRegistryQt.cpp:
       
 30240         (WebCore::):
       
 30241         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
       
 30242         * platform/qt/QWebPopup.cpp:
       
 30243         * platform/qt/SharedTimerQt.cpp:
       
 30244 
       
 30245 2007-06-06  Mark Rowe  <mrowe@apple.com>
       
 30246 
       
 30247         Qt build fix.
       
 30248 
       
 30249         * rendering/RenderTextControl.cpp: Fix case of #include filename.
       
 30250 
       
 30251 2007-06-06  Lars Knoll  <lars@trolltech.com>
       
 30252 
       
 30253         Reviewed by Maciej.
       
 30254 
       
 30255         Define WTF_USE_NPOBJECT for Qt. Fix includes
       
 30256         in HTMLPluginElement and add proper forwarding headers
       
 30257         from JavaScriptCore.
       
 30258 
       
 30259         * ForwardingHeaders/bindings/npruntime.h: Added.
       
 30260         * ForwardingHeaders/bindings/runtime.h: Added.
       
 30261         * config.h:
       
 30262         * html/HTMLPlugInElement.cpp:
       
 30263         * html/HTMLPlugInElement.h:
       
 30264 
       
 30265 2007-06-06  David Hyatt  <hyatt@apple.com>
       
 30266 
       
 30267         Bulletproof windowClipRect, since it can be called at crazy times.
       
 30268         Part of fix for 13972.
       
 30269 
       
 30270         Reviewed by olliej
       
 30271 
       
 30272         * bindings/objc/DOM.mm:
       
 30273         (-[DOMElement _windowClipRect]):
       
 30274 
       
 30275 2007-06-05  MorganL  <morganl.webkit@yahoo.com>
       
 30276 
       
 30277         Reviewed by Dave Hyatt.
       
 30278 
       
 30279         Fixes http://bugs.webkit.org/show_bug.cgi?id=14008
       
 30280 
       
 30281         * rendering/RenderTextControl.cpp:
       
 30282         (WebCore::RenderTextControl::calcHeight):
       
 30283         (WebCore::RenderTextControl::calcPrefWidths):
       
 30284 
       
 30285 2007-06-05  Kevin McCullough  <kmccullough@apple.com>
       
 30286 
       
 30287         - Respelling Oliver's name right.
       
 30288 
       
 30289 2007-06-05  Kevin McCullough  <kmccullough@apple.com>
       
 30290 
       
 30291         Reviewed by Mark and Oliver.
       
 30292 
       
 30293         - http://bugs.webkit.org/show_bug.cgi?id=13352  REGRESSION: Gmail hangs on send message.
       
 30294         - Now we don't hang, but we do so by avoiding certain legitimate characters, the evangelism bug for this is: <rdar://problem/5252577> gmail does not accept legal characters in the form boundary
       
 30295 
       
 30296         * html/HTMLFormElement.cpp:
       
 30297         (WebCore::getUniqueBoundaryString):
       
 30298 
       
 30299 2007-06-05  Anders Carlsson  <andersca@apple.com>
       
 30300 
       
 30301         Build fix.
       
 30302         
       
 30303         * xml/xmlhttprequest.cpp:
       
 30304         (WebCore::isValidToken):
       
 30305 
       
 30306 2007-06-05  Anders Carlsson  <andersca@apple.com>
       
 30307 
       
 30308         Reviewed by Geoff.
       
 30309 
       
 30310         <rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
       
 30311         <rdar://problem/5246208> HTTP injection in XMLHttpRequest.open method parameter
       
 30312         <rdar://problem/5246242> HTTP header injection in HXMLHttpRequest.setRequestHeader header parameter
       
 30313         
       
 30314         Check method names, header names and header values and throw exceptions if any of them are
       
 30315         invalid. This is what the new XMLHttpRequest spec states that we should do.
       
 30316         
       
 30317         * xml/xmlhttprequest.cpp:
       
 30318         (WebCore::isValidToken):
       
 30319         (WebCore::isValidHeaderValue):
       
 30320         (WebCore::XMLHttpRequest::open):
       
 30321         (WebCore::XMLHttpRequest::setRequestHeader):
       
 30322 
       
 30323 2007-06-05  Sam Weinig  <sam@webkit.org>
       
 30324 
       
 30325         Reviewed by Geoff.
       
 30326 
       
 30327         Optimize JSCSSStyleDeclaration after performance regression in r21854.
       
 30328 
       
 30329         - Check static table before name getter in JSCSSStyleDeclaration::getOwnPropertySlot()
       
 30330         - Get rid of a string allocation by keeping string as KJS::Identifier for canGetItemsForName()
       
 30331           functions.
       
 30332 
       
 30333         * WebCore.xcodeproj/project.pbxproj:
       
 30334         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
       
 30335         (WebCore::JSCSSStyleDeclaration::canGetItemsForName):
       
 30336         * bindings/js/JSHTMLAppletElementCustom.cpp:
       
 30337         (WebCore::JSHTMLAppletElement::canGetItemsForName):
       
 30338         * bindings/js/JSHTMLDocumentCustom.cpp:
       
 30339         (WebCore::JSHTMLDocument::canGetItemsForName):
       
 30340         * bindings/js/JSHTMLEmbedElementCustom.cpp:
       
 30341         (WebCore::JSHTMLEmbedElement::canGetItemsForName):
       
 30342         * bindings/js/JSHTMLFormElementCustom.cpp:
       
 30343         (WebCore::JSHTMLFormElement::canGetItemsForName):
       
 30344         * bindings/js/JSHTMLFrameSetElementCustom.cpp:
       
 30345         (WebCore::JSHTMLFrameSetElement::canGetItemsForName):
       
 30346         * bindings/js/JSHTMLObjectElementCustom.cpp:
       
 30347         (WebCore::JSHTMLObjectElement::canGetItemsForName):
       
 30348         * bindings/scripts/CodeGeneratorJS.pm:
       
 30349         * css/CSSStyleDeclaration.idl:
       
 30350 
       
 30351 2007-06-04  Sam Weinig  <sam@webkit.org>
       
 30352 
       
 30353         Reviewed, tweaked and landed by Anders.
       
 30354 
       
 30355         <rdar://problem/5247178> REGRESSION: With CSS Edit 2.5, a crash occurs at WebCore::DeprecatedString::DeprecatedString when page fails to be extracted
       
 30356         
       
 30357         Null check the provisional document loader. If an application stops the load 
       
 30358         inside of the didFailProvisionalLoad delegate method, the provisional document loader will be nulled out.
       
 30359 
       
 30360         * loader/FrameLoader.cpp:
       
 30361         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
       
 30362 
       
 30363 2007-06-04  Alp Toker  <alp.toker@collabora.co.uk>
       
 30364 
       
 30365         Reviewed by Anders.
       
 30366 
       
 30367         http://bugs.webkit.org/show_bug.cgi?id=13986
       
 30368         Cairo graphics fixes and cleanups
       
 30369 
       
 30370         * platform/graphics/ImageBuffer.h:
       
 30371         * platform/graphics/cairo/ImageBufferCairo.cpp:
       
 30372         (WebCore::ImageBuffer::surface): Provide surface() accessor.
       
 30373         * platform/graphics/cairo/AffineTransformCairo.cpp:
       
 30374         (WebCore::AffineTransform::rotate): Convert from degrees to radians to
       
 30375         fix rotation.
       
 30376         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
 30377         (WebCore::GraphicsContext::drawRect): Add save/restore.
       
 30378         (WebCore::GraphicsContext::rotate): Rename parameter to "radians" to
       
 30379         avoid further confusion.
       
 30380         * platform/graphics/cairo/PathCairo.cpp:
       
 30381         (WebCore::Path::boundingRect): The cairo_fill_extents() parameters do
       
 30382         not describe a point/size but rather the two control points of the
       
 30383         rectangular region.
       
 30384         (WebCore::Path::contains): Remove needless casts.
       
 30385 
       
 30386 2007-06-04  Sam Weinig  <sam@webkit.org>
       
 30387 
       
 30388         Reviewed by Adam Roben.
       
 30389 
       
 30390         Fix the buildbot.
       
 30391 
       
 30392         * rendering/RenderSVGContainer.cpp:
       
 30393         (WebCore::RenderSVGContainer::layout):
       
 30394 
       
 30395 2007-06-04  Justin Garcia  <justin.garcia@apple.com>
       
 30396 
       
 30397         Reviewed by Kimon Tsinteris.
       
 30398 
       
 30399         <rdar://problem/5241148> REGRESSION: ActivEdit can't perform operations on certain selections
       
 30400         
       
 30401         Return valid equivalents from these methods (no [img, 1] for 
       
 30402         example). ActivEdit was using positions returned from these
       
 30403         methods to create new DOM Ranges.
       
 30404         
       
 30405         * editing/SelectionController.cpp:
       
 30406         (WebCore::SelectionController::baseNode):
       
 30407         (WebCore::SelectionController::baseOffset):
       
 30408         (WebCore::SelectionController::extentNode):
       
 30409         (WebCore::SelectionController::extentOffset):
       
 30410         (WebCore::SelectionController::anchorNode):
       
 30411         (WebCore::SelectionController::anchorOffset):
       
 30412         (WebCore::SelectionController::focusNode):
       
 30413         (WebCore::SelectionController::focusOffset):
       
 30414         * editing/SelectionController.h:
       
 30415 
       
 30416 2007-06-04  Rob Buis  <buis@kde.org>
       
 30417 
       
 30418         Fix the svg experimental build.
       
 30419 
       
 30420         * ksvg2/svg/SVGFEFloodElement.cpp:
       
 30421 
       
 30422 2007-06-04  Rob Buis  <buis@kde.org>
       
 30423 
       
 30424         Reviewed by Hyatt.
       
 30425 
       
 30426         http://bugs.webkit.org/show_bug.cgi?id=6170
       
 30427         CSS1: Properties for :first-letter aren't recalculated on color change
       
 30428 
       
 30429         Mark styles with first-letter as unique.
       
 30430 
       
 30431         * css/cssstyleselector.cpp:
       
 30432         (WebCore::CSSStyleSelector::styleForElement):
       
 30433 
       
 30434 2007-06-01  Anders Carlsson  <acarlsson@apple.com>
       
 30435 
       
 30436         Reviewed by David Harrison.
       
 30437 
       
 30438         <rdar://problem/5236843> 
       
 30439         CrashTracer: [USER] 3 crashes in Mail at WebCore::Loader::didReceiveResponse(WebCore::SubresourceLoader*, WebCore::ResourceResponse const&)
       
 30440 
       
 30441         This is by no means the best solution for handling user style sheets. I've filed <rdar://problem/5244734> 
       
 30442         for tracking that.
       
 30443         
       
 30444         * loader/loader.cpp:
       
 30445         (WebCore::Loader::didReceiveResponse):
       
 30446         If a load starts while the frame is still in the provisional state 
       
 30447         (this can be the case when loading the user style sheet), committing the load then causes all
       
 30448         requests to be removed from the m_requestsLoading map. This means that req might be null here.
       
 30449         In that case we just return early. 
       
 30450         
       
 30451 2007-06-01  Mitz Pettel  <mitz@webkit.org>
       
 30452 
       
 30453         Reviewed by Adele.
       
 30454 
       
 30455         - fix http://bugs.webkit.org/show_bug.cgi?id=13958
       
 30456           REGRESSION: Form select menu in iframe destroys form select menu on page
       
 30457 
       
 30458         * page/mac/EventHandlerMac.mm:
       
 30459         (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking): Instead of calling
       
 30460         the event handler methods directly, post the fake event on the application event
       
 30461         queue. This ensures that the fake event is handled only after handling of the
       
 30462         initiating event has ended, and is seen by ancestor frames' event handlers.
       
 30463 
       
 30464 2007-06-01  George Staikos  <staikos@kde.org>
       
 30465 
       
 30466         Reviewed by bdash.
       
 30467 
       
 30468         Redo the build fix again after it was backed out
       
 30469 
       
 30470         * WebCore.pro: add an include guard around CSSGrammar.h
       
 30471 
       
 30472 2007-05-31  Geoffrey Garen  <ggaren@apple.com>
       
 30473 
       
 30474         Reviewed by Beth Dakin.
       
 30475 
       
 30476         Fixed <rdar://problem/5238177> Continuing after hitting breakpoint doesn't 
       
 30477         execute the next step.
       
 30478         
       
 30479         No test because the only code affected is the debugger, and none of the
       
 30480         relevant API is exported.
       
 30481         
       
 30482         Reverted an accidental change in 21324 that caused originRootObject for
       
 30483         the window object always to be 0. We could probably just remove the debugger's
       
 30484         dependency on originRootObject, but I wanted to be safe.
       
 30485 
       
 30486         * page/mac/FrameMac.mm:
       
 30487         (WebCore::Frame::windowScriptObject):
       
 30488 
       
 30489 2007-05-31  David Hyatt  <hyatt@apple.com>
       
 30490 
       
 30491         Fix for 11768, Flash plugin does not respect clips set via CSS.
       
 30492 
       
 30493         Reviewed by olliej
       
 30494 
       
 30495         * bindings/objc/DOM.mm:
       
 30496         (-[DOMElement _windowClipRect]):
       
 30497         * bindings/objc/DOMPrivate.h:
       
 30498         * page/FrameView.cpp:
       
 30499         (WebCore::FrameView::windowClipRect):
       
 30500         (WebCore::FrameView::windowClipRectForLayer):
       
 30501         * platform/ScrollView.h:
       
 30502         (WebCore::ScrollView::contentsToWindow):
       
 30503         (WebCore::ScrollView::windowToContents):
       
 30504         * platform/mac/ScrollViewMac.mm:
       
 30505         (WebCore::ScrollView::contentsToWindow):
       
 30506         (WebCore::ScrollView::windowToContents):
       
 30507 
       
 30508 2007-05-31  Sam Weinig  <sam@webkit.org>
       
 30509 
       
 30510         Reviewed by Adam.
       
 30511 
       
 30512         Fix build bot.
       
 30513 
       
 30514         * ksvg2/svg/SVGSVGElement.cpp:
       
 30515         (WebCore::SVGSVGElement::setCurrentScale):
       
 30516 
       
 30517 2007-05-31  Sam Weinig  <sam@webkit.org>
       
 30518 
       
 30519         Fix Qt and Gdk builds.
       
 30520 
       
 30521         * WebCore.pro: remove bindings/js/JSHTMLAnchorElementCustom.cpp
       
 30522 
       
 30523 2007-05-31  Sam Weinig  <sam@webkit.org>
       
 30524 
       
 30525         Reviewed by Geoff.
       
 30526 
       
 30527         Patch for http://bugs.webkit.org/show_bug.cgi?id=10782
       
 30528         Classes should not override JSObject::toString(ExecState *)
       
 30529 
       
 30530         Remove all overrides of JSObject::toString and JSObject::toPrimitive
       
 30531         which is a bad practice.  Instead, if an object, like the 
       
 30532         HTMLAnchorElement, needs to override to toString, it should add
       
 30533         a function to the JS object which will be called when needed.  This
       
 30534         also allows developers to override toString and valueOf from within JS.
       
 30535 
       
 30536         Test: fast/js/toString-and-valueOf-override.html
       
 30537 
       
 30538         * WebCore.xcodeproj/project.pbxproj:
       
 30539         * bindings/js/JSHTMLAnchorElementCustom.cpp: Removed.
       
 30540         * bindings/js/kjs_binding.cpp:
       
 30541         * bindings/js/kjs_binding.h:
       
 30542         * bindings/js/kjs_dom.cpp:
       
 30543         * bindings/js/kjs_dom.h:
       
 30544         * bindings/js/kjs_domnode.h:
       
 30545         * bindings/js/kjs_window.cpp:
       
 30546         (KJS::History::):
       
 30547         (KJS::LocationFunc::callAsFunction):
       
 30548         (KJS::SelectionFunc::callAsFunction):
       
 30549         * bindings/js/kjs_window.h:
       
 30550         * bindings/scripts/CodeGeneratorJS.pm:
       
 30551         * html/HTMLAnchorElement.cpp:
       
 30552         (WebCore::HTMLAnchorElement::toString):
       
 30553         * html/HTMLAnchorElement.h:
       
 30554         * html/HTMLAnchorElement.idl:
       
 30555 
       
 30556 2007-05-31  Rob Buis  <buis@kde.org>
       
 30557 
       
 30558         Reviewed by Darin.
       
 30559 
       
 30560         http://bugs.webkit.org/show_bug.cgi?id=11272
       
 30561         Implement currentScale(), setCurrentScale() and currentTranslate() in SVGSVGElement
       
 30562 
       
 30563         Allow zooming and panning, thereby implementing the above methods.
       
 30564 
       
 30565         * ksvg2/svg/SVGDocument.cpp:
       
 30566         (WebCore::SVGDocument::zoomEnabled):
       
 30567         (WebCore::SVGDocument::startPan):
       
 30568         (WebCore::SVGDocument::updatePan):
       
 30569         * ksvg2/svg/SVGDocument.h:
       
 30570         * ksvg2/svg/SVGSVGElement.cpp:
       
 30571         (WebCore::SVGSVGElement::currentScale):
       
 30572         (WebCore::SVGSVGElement::setCurrentScale):
       
 30573         (WebCore::SVGSVGElement::currentTranslate):
       
 30574         (WebCore::SVGSVGElement::setCurrentTranslate):
       
 30575         * ksvg2/svg/SVGSVGElement.h:
       
 30576         * page/EventHandler.cpp:
       
 30577         (WebCore::EventHandler::EventHandler):
       
 30578         (WebCore::EventHandler::handleMousePressEvent):
       
 30579         (WebCore::EventHandler::handleMouseMoveEvent):
       
 30580         (WebCore::EventHandler::handleMouseReleaseEvent):
       
 30581         * page/EventHandler.h:
       
 30582         * page/Frame.cpp:
       
 30583         (WebCore::Frame::setZoomFactor):
       
 30584         * rendering/RenderSVGContainer.cpp:
       
 30585         (WebCore::RenderSVGContainer::layout):
       
 30586         (WebCore::RenderSVGContainer::paint):
       
 30587         (WebCore::RenderSVGContainer::absoluteTransform):
       
 30588         * rendering/RenderSVGContainer.h:
       
 30589 
       
 30590 2007-05-31  Eric Seidel  <eric@webkit.org>
       
 30591 
       
 30592         Reviewed by Niko.
       
 30593 
       
 30594         Links are activated based on mouse down events instead of click events
       
 30595         http://bugs.webkit.org/show_bug.cgi?id=12570
       
 30596         
       
 30597         Test: svg/custom/prevent-default.svg
       
 30598 
       
 30599         * html/HTMLAnchorElement.cpp: use MiddleButton and RightButton instead of 1 and 2
       
 30600         (WebCore::HTMLAnchorElement::defaultEventHandler):
       
 30601         * ksvg2/svg/SVGAElement.cpp:
       
 30602         (WebCore::SVGAElement::defaultEventHandler): make it function more like the HTML side
       
 30603 
       
 30604 2007-05-30  Maciej Stachowiak  <mjs@apple.com>
       
 30605 
       
 30606         Reviewed by Hyatt.
       
 30607 
       
 30608         - fix layout test editing/style/table-selection.html
       
 30609         
       
 30610         This was broken by the change to keep whitespace text nodes in tables. They safely didn't render,
       
 30611         but the font delta style change command would wrap them in spans, creating extra anonymous table
       
 30612         cells.
       
 30613 
       
 30614         * editing/ApplyStyleCommand.cpp:
       
 30615         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Don't wrap in a span if the text node
       
 30616         is not rendered.
       
 30617 
       
 30618 2007-05-31  Alp Toker  <alp.toker@collabora.co.uk>
       
 30619 
       
 30620         Reviewed by Eric Seidel.
       
 30621 
       
 30622         http://bugs.webkit.org/show_bug.cgi?id=13941
       
 30623         Rename WebCore/platform/network/gdk to WebCore/platform/network/curl
       
 30624 
       
 30625         * WebCore.pro:
       
 30626 
       
 30627 2007-05-31  Alp Toker  <alp.toker@collabora.co.uk>
       
 30628 
       
 30629         Reviewed by Niko.
       
 30630 
       
 30631         Patch for http://bugs.webkit.org/show_bug.cgi?id=13945
       
 30632         GraphicsContextCairo enhancements necessary for SVG support
       
 30633 
       
 30634         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
 30635         (WebCore::GraphicsContext::concatCTM):
       
 30636         (WebCore::GraphicsContext::beginPath):
       
 30637         (WebCore::GraphicsContext::addPath):
       
 30638 
       
 30639 2007-05-31  Patti Hoa <patti@apple.com>
       
 30640 
       
 30641         Reviewed by Darin.
       
 30642         
       
 30643         <rdar://problem/5221920> AXLink is returning a CFString instead of a CFURL for AXURL
       
 30644 
       
 30645         * bridge/mac/WebCoreAXObject.mm:
       
 30646         (-[WebCoreAXObject accessibilityAttributeValue:]):
       
 30647         Convert the url string to an NSURL before returning as the AXURLAttribute
       
 30648 
       
 30649 2007-05-30  Sam Weinig  <sam@webkit.org>
       
 30650 
       
 30651         Reviewed by Oliver.
       
 30652 
       
 30653         Patch for http://bugs.webkit.org/show_bug.cgi?id=13943
       
 30654         Autogenerate the JS bindings for the CSSStyleSheet
       
 30655 
       
 30656         * DerivedSources.make:
       
 30657         * WebCore.pro:
       
 30658         * WebCore.xcodeproj/project.pbxproj:
       
 30659         * bindings/js/JSStyleSheetCustom.cpp:
       
 30660         (WebCore::toJS):
       
 30661         * bindings/js/kjs_css.cpp:
       
 30662         * bindings/js/kjs_css.h:
       
 30663         * bindings/scripts/CodeGeneratorJS.pm:
       
 30664         * css/CSSStyleSheet.cpp:
       
 30665         (WebCore::CSSStyleSheet::addRule):
       
 30666         (WebCore::CSSStyleSheet::cssRules):
       
 30667         * css/CSSStyleSheet.h:
       
 30668         (WebCore::CSSStyleSheet::rules):
       
 30669         (WebCore::CSSStyleSheet::removeRule):
       
 30670         * css/CSSStyleSheet.idl:
       
 30671         * page/DOMWindow.idl:
       
 30672 
       
 30673 2007-05-30  Sam Weinig  <sam@webkit.org>
       
 30674 
       
 30675         Reviewed by Oliver.
       
 30676 
       
 30677         Patch for http://bugs.webkit.org/show_bug.cgi?id=13937
       
 30678         Autogenerate the JS bindings for the CSSValue
       
 30679 
       
 30680         * WebCore.pro:
       
 30681         * WebCore.xcodeproj/project.pbxproj:
       
 30682         * bindings/js/JSCSSValueCustom.cpp: Added.
       
 30683         (WebCore::toJS):
       
 30684         * bindings/js/kjs_css.cpp:
       
 30685         * bindings/js/kjs_css.h:
       
 30686         * bindings/objc/DOMUtility.mm:
       
 30687         (KJS::createDOMWrapper):
       
 30688         * bindings/scripts/CodeGeneratorJS.pm:
       
 30689         * css/CSSValue.h:
       
 30690         (WebCore::CSSValue::setCssText):
       
 30691         * css/CSSValue.idl:
       
 30692 
       
 30693 2007-05-30  Sam Weinig  <sam@webkit.org>
       
 30694 
       
 30695         Reviewed by Oliver the Hun.
       
 30696 
       
 30697         Patch for http://bugs.webkit.org/show_bug.cgi?id=13944
       
 30698         Generate and add missing JS constructors
       
 30699 
       
 30700         * css/CSSRuleList.idl:
       
 30701         * css/CSSValueList.idl:
       
 30702         * css/Counter.idl:
       
 30703         * page/DOMWindow.idl:
       
 30704 
       
 30705 2007-05-30  Justin Garcia  <justin.garcia@apple.com>
       
 30706  
       
 30707         Reviewed by Darin.
       
 30708  
       
 30709         http://bugs.webkit.org/show_bug.cgi?id=13915
       
 30710         REGRESSION(r21687): editing/inserting/paragraph-separator-* failing pixel test (misspelling markers)
       
 30711 
       
 30712         After r21687, SimplifiedBackwardsTextIterator was no longer 
       
 30713         emitting a '\n' as it left the first block of a range ending 
       
 30714         at [block, 0]. So, foo<div>^<br></div> looked like foo^ to
       
 30715         spell checking (foo wasn't marked as misspelled).
       
 30716 
       
 30717         After r21687, SBTI stopped emitting '\n's in the above case 
       
 30718         because 1) we stopped incorrectly emitting '\n's for nodes as 
       
 30719         we entered them and 2) we were and still are incorrectly calling 
       
 30720         code that should only be called when entering nodes as we leave 
       
 30721         them and 3) we don't call exitNode(), which is responsible 
       
 30722         for emitting the '\n' in the above testcase, when we should.
       
 30723 
       
 30724         Before and after r21687, we'd call exitNode() for a node as 
       
 30725         we traversed in reverse pre-order from its first descendant 
       
 30726         out to its sibling or one of its ancestors' siblings.  We 
       
 30727         weren't calling it a) after we'd enter a node that could 
       
 30728         have children but had none and b) when leaving a container 
       
 30729         that contained the end of the range used to create the iterator.
       
 30730 
       
 30731         * editing/TextIterator.cpp:
       
 30732         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
       
 30733         (WebCore::SimplifiedBackwardsTextIterator::advance): Call exitNode() as we
       
 30734         leave a childless container node and a node where the range ended.
       
 30735         * editing/TextIterator.h: Track the end of the range used to create
       
 30736         the SimplifiedBackwardsTextIterator.
       
 30737 
       
 30738 2007-05-30  Alp Toker  <alp.toker@collabora.co.uk>
       
 30739 
       
 30740         Reviewed by Brady.
       
 30741 
       
 30742         Enable logging in the Gdk port.
       
 30743         http://bugs.webkit.org/show_bug.cgi?id=13936
       
 30744 
       
 30745         * WebCore.pro:
       
 30746         * platform/NotImplemented.h: Changed to use WTFLogVerbose.
       
 30747         * platform/gdk/LoggingGdk.cpp: Added.
       
 30748         (WebCore::InitializeLoggingChannelsIfNecessary):
       
 30749 
       
 30750 2007-05-30  Beth Dakin  <bdakin@apple.com>
       
 30751 
       
 30752         Reviewed by Hyatt.
       
 30753 
       
 30754         Fix for <rdar://problem/5198882> CrashTracer: [USER] 7 crashes in 
       
 30755         Safari at com.apple.WebCore: WebCore::RenderBlock::layoutBlock + 
       
 30756         2360
       
 30757 
       
 30758         The problem is that we are re-entering layout when we should not. 
       
 30759         http://trac.webkit.org/projects/webkit/changeset/21778 actually 
       
 30760         fixed this crash, but we have been inspired to add the same guard 
       
 30761         in two other possibly-dangerous places.
       
 30762 
       
 30763         * page/FrameView.cpp:
       
 30764         (WebCore::FrameView::layout): Add the guard in two more places.
       
 30765 
       
 30766 2007-05-30  Justin Garcia  <justin.garcia@apple.com>
       
 30767 
       
 30768         Reviewed by Oliver.
       
 30769 
       
 30770         <rdar://problem/5096134> VO gets stuck on Howto.apple.com
       
 30771         http://bugs.webkit.org/show_bug.cgi?id=8622
       
 30772         VisiblePositions aren't canonicalized in some cases
       
 30773         
       
 30774         No new test cases added: can't write automated tests 
       
 30775         for VO.
       
 30776 
       
 30777         * editing/IndentOutdentCommand.cpp:
       
 30778         (WebCore::IndentOutdentCommand::outdentParagraph):
       
 30779         VisiblePositions must be recomputed after nodes that
       
 30780         may have effected their canonicalization are removed.
       
 30781         * editing/VisiblePosition.cpp:
       
 30782         (WebCore::canonicalizeCandidate): Added.
       
 30783         (WebCore::VisiblePosition::canonicalPosition): Canonicalize
       
 30784         the candidates returned by next/previousCandidate before
       
 30785         returning them.
       
 30786         * editing/VisiblePosition.h:
       
 30787         (WebCore::operator==): Remove the workaround for 8622.
       
 30788         * editing/visible_units.cpp:
       
 30789         (WebCore::startOfParagraph): Ditto.
       
 30790 
       
 30791 2007-05-30  Sam Weinig  <sam@webkit.org>
       
 30792 
       
 30793         Reviewed by Dr. Harrison.
       
 30794 
       
 30795         Patch for http://bugs.webkit.org/show_bug.cgi?id=13868
       
 30796         REGRESSION: crash on accessing a new iframe's contentWindow property
       
 30797 
       
 30798         Adds a null check in for the contentWindow property for HTMLIFrameElement
       
 30799         and HTMLFrameElement.
       
 30800 
       
 30801         * bindings/scripts/CodeGeneratorJS.pm:
       
 30802         * html/HTMLFrameElement.idl:
       
 30803         * html/HTMLIFrameElement.idl:
       
 30804 
       
 30805 2007-05-30  Mitz Pettel  <mitz@webkit.org>
       
 30806 
       
 30807         Reviewed by Darin.
       
 30808 
       
 30809         - fix http://bugs.webkit.org/show_bug.cgi?id=13775
       
 30810           REGRESSION: Popup button text should use "natural" directionality to match the items in the popup menu
       
 30811 
       
 30812         Test: fast/forms/select-writing-direction-natural.html
       
 30813 
       
 30814         * platform/PopupMenu.h: Added the static method itemWritingDirectionIsNatural
       
 30815         which says whether items in the popup ignore the CSS text-align and direction
       
 30816         properties and instead are left-aligned and use natural writing direction.
       
 30817         * platform/gdk/PopupMenuGdk.cpp:
       
 30818         (WebCore::PopupMenu::itemWritingDirectionIsNatural):
       
 30819         * platform/mac/PopupMenuMac.mm:
       
 30820         (WebCore::PopupMenu::itemWritingDirectionIsNatural):
       
 30821         * platform/qt/PopupMenuQt.cpp:
       
 30822         (WebCore::PopupMenu::itemWritingDirectionIsNatural):
       
 30823         * platform/win/TemporaryLinkStubs.cpp:
       
 30824         (WebCore::PopupMenu::itemWritingDirectionIsNatural):
       
 30825         * platform/wx/TemporaryLinkStubs.cpp:
       
 30826         (PopupMenu::itemWritingDirectionIsNatural):
       
 30827         * rendering/RenderMenuList.cpp:
       
 30828         (WebCore::textDirectionForParagraph): Added this helper function that uses
       
 30829         the Unicode Bidi Algorithm rules P2 and P3 to determine the writing direction
       
 30830         of text.
       
 30831         (WebCore::RenderMenuList::adjustInnerStyle): Made the alignment and direction
       
 30832         adjustment conditional on the popup implementation.
       
 30833         (WebCore::RenderMenuList::setText): Added call to adjustInnerStyle() since
       
 30834         the style depends on the text when natural writing direction is used.
       
 30835 
       
 30836 2007-05-30  Timothy Hatcher  <timothy@apple.com>
       
 30837 
       
 30838         Reviewed by Darin.
       
 30839 
       
 30840         <rdar://problem/5200795> REGRESSION (r21057): lineBoxRects doesn't match actual text when wrapping occurs
       
 30841 
       
 30842         Use box->end() instead of box->len().
       
 30843 
       
 30844         * rendering/RenderText.cpp:
       
 30845         (WebCore::RenderText::addLineBoxRects):
       
 30846 
       
 30847 2007-05-30  Sam Weinig  <sam@webkit.org>
       
 30848 
       
 30849         Reviewed by Darin.
       
 30850 
       
 30851         Patch for http://bugs.webkit.org/show_bug.cgi?id=13919
       
 30852         Autogenerate the JS bindings for the CSSRule and its subclasses
       
 30853 
       
 30854         - subclasses generated are CSSCharsetRule, CSSFontFaceRule, CSSImportRule
       
 30855           CSSMediaRule, CSSPageRule and CSSStyleRule.
       
 30856 
       
 30857         * DerivedSources.make:
       
 30858         * WebCore.pro:
       
 30859         * WebCore.xcodeproj/project.pbxproj:
       
 30860         * bindings/js/JSCSSRuleCustom.cpp: Added.
       
 30861         (WebCore::toJS):
       
 30862         * bindings/js/kjs_css.cpp:
       
 30863         * bindings/js/kjs_css.h:
       
 30864         * bindings/objc/DOMUtility.mm:
       
 30865         (KJS::createDOMWrapper):
       
 30866         * bindings/scripts/CodeGeneratorJS.pm:
       
 30867         * css/CSSCharsetRule.h:
       
 30868         (WebCore::CSSCharsetRule::setEncoding):
       
 30869         * css/CSSCharsetRule.idl:
       
 30870         * css/CSSFontFaceRule.idl:
       
 30871         * css/CSSImportRule.idl:
       
 30872         * css/CSSMediaRule.idl:
       
 30873         * css/CSSPageRule.cpp:
       
 30874         (WebCore::CSSPageRule::setSelectorText):
       
 30875         * css/CSSPageRule.h:
       
 30876         * css/CSSPageRule.idl:
       
 30877         * css/CSSRule.cpp:
       
 30878         (WebCore::CSSRule::setCssText):
       
 30879         * css/CSSRule.h:
       
 30880         * css/CSSRule.idl:
       
 30881         * css/CSSStyleRule.cpp:
       
 30882         (WebCore::CSSStyleRule::setSelectorText):
       
 30883         * css/CSSStyleRule.h:
       
 30884         * css/CSSStyleRule.idl:
       
 30885         * page/DOMWindow.idl: add new constructors.
       
 30886 
       
 30887 2007-05-30  Mark Rowe  <mrowe@apple.com>
       
 30888 
       
 30889         Build fixes after r21889.  Add missing #includes.
       
 30890 
       
 30891         * ForwardingHeaders/kjs/function.h: Added.
       
 30892         * bindings/js/kjs_binding.h:
       
 30893         * bindings/js/kjs_dom.h:
       
 30894         * bindings/js/kjs_window.h:
       
 30895 
       
 30896 2007-05-30  Mark Rowe  <mrowe@apple.com>
       
 30897 
       
 30898         Gdk build fix.  Update WidgetGdk to use NotImplemented.h.
       
 30899 
       
 30900         * platform/gdk/WidgetGdk.cpp:
       
 30901         (WebCore::Widget::setEnabled):
       
 30902         (WebCore::Widget::isEnabled):
       
 30903         (WebCore::Widget::removeFromParent):
       
 30904         (WebCore::Widget::paint):
       
 30905         (WebCore::Widget::setIsSelected):
       
 30906 
       
 30907 2007-05-29  Holger Freyther  <zecke@selfish.org>
       
 30908 
       
 30909         Reviewed by Anders.
       
 30910 
       
 30911         Make ScrollView use a GtkLayout. This class matches QScrollView the most and promises
       
 30912         to ease the implementation of ScrollView::addChild. GtkLayout should be resource friendly
       
 30913         even with huge width and heights of frames.
       
 30914         Make Widget aware of GtkLayout to use the right GdkWindow as drawable. For GtkLayout one must
       
 30915         draw on the bin_window.
       
 30916         Remove the layer violation from FrameGdk.cpp and ScrollView. FrameGdk is no longer responsible to
       
 30917         implement scrolling on keyboard events. ScrollView is no longer required to know that it could be
       
 30918         a FrameView and handles scrolling of Frames magically.
       
 30919 
       
 30920         * platform/ScrollView.h:
       
 30921         * platform/gdk/FrameGdk.cpp:
       
 30922         (WebCore::FrameGdk::keyPress):
       
 30923         (WebCore::FrameGdk::handleGdkEvent):
       
 30924         * platform/gdk/ScrollViewGdk.cpp:
       
 30925         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
       
 30926         (WebCore::ScrollView::updateContents):
       
 30927         (WebCore::ScrollView::visibleWidth):
       
 30928         (WebCore::ScrollView::visibleHeight):
       
 30929         (WebCore::ScrollView::visibleContentRect):
       
 30930         (WebCore::ScrollView::resizeContents):
       
 30931         (WebCore::ScrollView::contentsX):
       
 30932         (WebCore::ScrollView::contentsY):
       
 30933         (WebCore::ScrollView::scrollOffset):
       
 30934         (WebCore::ScrollView::scrollBy):
       
 30935         (WebCore::ScrollView::setFrameGeometry):
       
 30936         (WebCore::ScrollView::updateGeometry):
       
 30937         (WebCore::ScrollView::setGtkWidget):
       
 30938         (WebCore::ScrollView::updateScrollbars):
       
 30939         (WebCore::ScrollView::windowToContents):
       
 30940         (WebCore::ScrollView::contentsToWindow):
       
 30941         (WebCore::ScrollView::scrollbarUnderMouse):
       
 30942         * platform/gdk/TemporaryLinkStubs.cpp: Move Widget methods to WidgetGdk.cpp
       
 30943         * platform/gdk/WidgetGdk.cpp:
       
 30944         (WebCore::Widget::setGtkWidget):
       
 30945         (WebCore::Widget::setFrameGeometry):
       
 30946         (WebCore::Widget::setEnabled):
       
 30947         (WebCore::Widget::isEnabled):
       
 30948         (WebCore::Widget::removeFromParent):
       
 30949         (WebCore::Widget::paint):
       
 30950         (WebCore::Widget::setIsSelected):
       
 30951         (WebCore::Widget::invalidate):
       
 30952         (WebCore::Widget::invalidateRect):
       
 30953 
       
 30954 2007-05-29  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 30955 
       
 30956         Reviewed by Maciej.
       
 30957 
       
 30958         Curl (linux/gdk) networking improvements: 
       
 30959         a) POST support
       
 30960         b) don't use CURL in a re-entrant way.
       
 30961         c) turn on curl's internal debugging support in a debug build if the DEBUG_CURL environment variable is set.
       
 30962 
       
 30963         * platform/network/ResourceHandleInternal.h:
       
 30964         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
       
 30965         * platform/network/gdk/ResourceHandleCurl.cpp:
       
 30966         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
       
 30967         * platform/network/gdk/ResourceHandleManager.cpp:
       
 30968         (WebCore::ResourceHandleManager::ResourceHandleManager):
       
 30969         (WebCore::writeCallback):
       
 30970         (WebCore::ResourceHandleManager::downloadTimerCallback):
       
 30971         (WebCore::ResourceHandleManager::setupPOST):
       
 30972         (WebCore::ResourceHandleManager::add):
       
 30973         (WebCore::ResourceHandleManager::removeScheduledJob):
       
 30974         (WebCore::ResourceHandleManager::startScheduledJobs):
       
 30975         (WebCore::ResourceHandleManager::startJob):
       
 30976         (WebCore::ResourceHandleManager::cancel):
       
 30977         * platform/network/gdk/ResourceHandleManager.h:
       
 30978         (WebCore::ResourceHandleList::ResourceHandleList):
       
 30979         (WebCore::ResourceHandleList::next):
       
 30980         (WebCore::ResourceHandleList::job):
       
 30981         (WebCore::ResourceHandleList::setRemoved):
       
 30982         (WebCore::ResourceHandleList::removed):
       
 30983 
       
 30984 2007-05-29  Sam Weinig  <sam@webkit.org>
       
 30985 
       
 30986         Fix the Qt and Gdk builds.
       
 30987 
       
 30988         * WebCore.pro:
       
 30989 
       
 30990 2007-05-29  Adele Peterson  <adele@apple.com>
       
 30991 
       
 30992         Reviewed by Adam.
       
 30993 
       
 30994         Fix for <rdar://problem/5109711> REGRESSION: Focus ring artifacts appear around a widget's search field at times (Address Book, Dictionary)
       
 30995 
       
 30996         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSearchField):
       
 30997           We only need this hack for drawing the search field focus ring on Tiger.  On Leopard, drawWithFrame correctly draws the cell's focus ring.
       
 30998 
       
 30999 2007-05-29  Alp Toker  <alp.toker@collabora.co.uk>
       
 31000 
       
 31001         Reviewed by Mitz.
       
 31002 
       
 31003         Patch for http://bugs.webkit.org/show_bug.cgi?id=13899
       
 31004 
       
 31005         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
 31006         (WebCore::GraphicsContext::strokeArc): Use cairo_arc_negative() to fix
       
 31007         CSS rounded borders.
       
 31008         (WebCore::GraphicsContext::beginTransparencyLayer):
       
 31009         (WebCore::GraphicsContext::endTransparencyLayer): save/restore is
       
 31010         redundant. push/pop group does this implicitly.
       
 31011 
       
 31012 2007-05-29  Sam Weinig  <sam@webkit.org>
       
 31013 
       
 31014         Reviewed by Oliver.
       
 31015 
       
 31016         Patch for http://bugs.webkit.org/show_bug.cgi?id=13912
       
 31017         Autogenerate the JS bindings for the MediaList
       
 31018 
       
 31019         * DerivedSources.make:
       
 31020         * WebCore.xcodeproj/project.pbxproj:
       
 31021         * bindings/js/kjs_css.cpp:
       
 31022         * bindings/js/kjs_css.h:
       
 31023         * bindings/objc/DOMUtility.mm:
       
 31024         (KJS::createDOMWrapper):
       
 31025         * bindings/scripts/CodeGeneratorJS.pm:
       
 31026         * css/MediaList.idl:
       
 31027         * page/DOMWindow.idl: Add constructor.
       
 31028 
       
 31029 2007-05-29  Matt Perry  <mpComplete@gmail.com>
       
 31030 
       
 31031         Reviewed by Maciej.
       
 31032 
       
 31033         Fixed some rendering issues for <select>s on Windows.
       
 31034 
       
 31035         * rendering/RenderThemeWin.cpp:
       
 31036         (WebCore::RenderThemeWin::adjustMenuListStyle):
       
 31037         (WebCore::RenderThemeWin::paintMenuList):
       
 31038         * rendering/RenderThemeWin.h:
       
 31039 
       
 31040 2007-05-29  David Hyatt  <hyatt@apple.com>
       
 31041 
       
 31042         Fold the invalidateVerticalPositions crawl into the bidi iteration.
       
 31043         This makes it more correct (since we won't drill into elements that
       
 31044         did not need to be reset) and cuts out an extra walk of all our children.
       
 31045         We're still O(n^2) as new content streams in, but this at least cuts
       
 31046         out one separate O(n^2) crawl.
       
 31047 
       
 31048         Reviewed by olliej
       
 31049 
       
 31050         * rendering/RenderObject.cpp:
       
 31051         * rendering/RenderObject.h:
       
 31052         (WebCore::RenderObject::invalidateVerticalPosition):
       
 31053         * rendering/bidi.cpp:
       
 31054         (WebCore::RenderBlock::layoutInlineChildren):
       
 31055 
       
 31056 2007-05-29  Sam Weinig  <sam@webkit.org>
       
 31057 
       
 31058         Reviewed by Oliver.
       
 31059 
       
 31060         Patch for http://bugs.webkit.org/show_bug.cgi?id=13908
       
 31061         Autogenerate the JS bindings for the StyleSheet
       
 31062 
       
 31063         * DerivedSources.make:
       
 31064         * WebCore.xcodeproj/project.pbxproj:
       
 31065         * bindings/js/JSStyleSheetCustom.cpp: Added.
       
 31066         (WebCore::toJS):
       
 31067         (WebCore::JSStyleSheet::toBoolean):
       
 31068         * bindings/js/kjs_css.cpp:
       
 31069         (KJS::):
       
 31070         (KJS::DOMCSSStyleSheet::DOMCSSStyleSheet):
       
 31071         (KJS::DOMCSSStyleSheet::getOwnPropertySlot):
       
 31072         * bindings/js/kjs_css.h:
       
 31073         * bindings/objc/DOMUtility.mm:
       
 31074         (KJS::createDOMWrapper):
       
 31075         * bindings/scripts/CodeGeneratorJS.pm:
       
 31076         * css/StyleSheet.idl:
       
 31077         * page/DOMWindow.idl: Add new constructor.
       
 31078 
       
 31079 2007-05-29  David Hyatt  <hyatt@apple.com>
       
 31080 
       
 31081         Make sure <embed> does not allow an end tag.
       
 31082 
       
 31083         Reviewed by olliej
       
 31084 
       
 31085         * html/HTMLEmbedElement.h:
       
 31086         (WebCore::HTMLEmbedElement::endTagRequirement):
       
 31087 
       
 31088 2007-05-29  Adele Peterson  <adele@apple.com>
       
 31089 
       
 31090         Reviewed by Brady.
       
 31091 
       
 31092         Fix for <rdar://problem/5213039> REGRESSION: Wells Fargo registration page returns blank
       
 31093 
       
 31094         Roll out updated fix for 11866 that tried to make reset work for hidden inputs.  Since
       
 31095         all browsers update the value attribute when setting the value, it doesn't really make sense to reset.
       
 31096         Its true that IE does support resetting these controls, but in this case, it doesn't really make sense to have
       
 31097         another place to store an alternate version of the value.
       
 31098 
       
 31099         * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::reset):
       
 31100         * html/HTMLInputElement.h:
       
 31101 
       
 31102 2007-05-29  Darin Adler  <darin@apple.com>
       
 31103 
       
 31104         Reviewed by Anders.
       
 31105 
       
 31106         - removed the general case optimization for innerHTML because some sites
       
 31107           rely on setting innerHTML to trigger loading plug-ins for example; we
       
 31108           could consider bringing it back some day, perhaps with a list of element
       
 31109           types to exclude
       
 31110 
       
 31111         * dom/CharacterData.cpp: (WebCore::CharacterData::setData):
       
 31112         Do nothing if the old data is identical to the new data.
       
 31113 
       
 31114         * html/HTMLElement.cpp:
       
 31115         (WebCore::replaceChildrenWithFragment): Remove childrenAreEqual optimization.
       
 31116         (WebCore::replaceChildrenWithText): Remove optimization for cases where the
       
 31117         text data is identical to the new data, since CharacterData handles that now.
       
 31118         (WebCore::HTMLElement::setOuterHTML): Remove childrenAreEqual optimization.
       
 31119 
       
 31120 2007-05-29  Mitz Pettel  <mitz@webkit.org>
       
 31121 
       
 31122         Reviewed by Maciej.
       
 31123 
       
 31124         - fix http://bugs.webkit.org/show_bug.cgi?id=13904
       
 31125           REGRESSION: Search fields with a results popup do not always draw the popup arrow
       
 31126 
       
 31127         Covered by fast/forms/box-shadow-override.html
       
 31128 
       
 31129         The search button draws a popup arrow depending on whether the
       
 31130         search menu template is set, rather than on the maximum number of recent
       
 31131         search strings.
       
 31132 
       
 31133         * rendering/RenderThemeMac.h:
       
 31134         * rendering/RenderThemeMac.mm:
       
 31135         (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): Removed the
       
 31136         call to -setMaxmiumRecents:.
       
 31137         (WebCore::RenderThemeMac::paintSearchFieldResultsButton): Replaced calling
       
 31138         -setMaximumRecents: with setting the search menu template.
       
 31139         (WebCore::RenderThemeMac::search): Removed initialization of the menu.
       
 31140         (WebCore::RenderThemeMac::searchMenuTemplate): Added. Returns an empty
       
 31141         NSMenu to be used as the search menu template.
       
 31142 
       
 31143 2007-05-29  David Hyatt  <hyatt@apple.com>
       
 31144 
       
 31145         Fix for bug 13907, <noscript> should be allowed inside <head> when
       
 31146         scripting is enabled.
       
 31147 
       
 31148         Reviewed by aroben
       
 31149 
       
 31150         * html/HTMLHeadElement.cpp:
       
 31151         (WebCore::HTMLHeadElement::checkDTD):
       
 31152         * html/HTMLParser.cpp:
       
 31153         (WebCore::HTMLParser::handleError):
       
 31154         * html/HTMLParserErrorCodes.cpp:
       
 31155         (WebCore::htmlParserErrorMessageTemplate):
       
 31156         * html/HTMLParserErrorCodes.h:
       
 31157 
       
 31158 2007-05-29  Mitz Pettel  <mitz@webkit.org>
       
 31159 
       
 31160         Reviewed by Maciej.
       
 31161 
       
 31162         - fix crash in http://bugs.webkit.org/show_bug.cgi?id=13792
       
 31163           REGRESSION: WebKit doesn't show this javascript screenshot page (and crashes after click on its "hidden link")
       
 31164 
       
 31165         Test: fast/frames/removal-before-attach-crash.html
       
 31166 
       
 31167         Delayed the queueing of the post-attach callback until attach().
       
 31168 
       
 31169         * html/HTMLFrameElementBase.cpp:
       
 31170         (WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
       
 31171         (WebCore::HTMLFrameElementBase::parseMappedAttribute): Replaced call to the
       
 31172         HTMLElement implementation with a call to the HTMLFrameOwnerElement
       
 31173         implementation, as the latter is the parent class.
       
 31174         (WebCore::HTMLFrameElementBase::insertedIntoDocument): Instead of queueing
       
 31175         the post-attach callback here, just set a flag telling us to do so
       
 31176         at the beginning of attach().
       
 31177         (WebCore::HTMLFrameElementBase::removedFromDocument): Reset the above flag.
       
 31178         (WebCore::HTMLFrameElementBase::attach): If this is the first attach() after
       
 31179         being inserted into the document, queue a post-attach callback to load the
       
 31180         frame.
       
 31181         (WebCore::HTMLFrameElementBase::willRemove): Changed to call up to the correct
       
 31182         parent class.
       
 31183         (WebCore::HTMLFrameElementBase::setFocus): Ditto.
       
 31184         * html/HTMLFrameElementBase.h:
       
 31185         * html/HTMLPlugInElement.cpp:
       
 31186         (WebCore::HTMLPlugInElement::mapToEntry): Replaced call to the HTMLElement
       
 31187         implementation with a call to the HTMLFrameOwnerElement implementation,
       
 31188         as the latter is the parent class.
       
 31189         (WebCore::HTMLPlugInElement::parseMappedAttribute): Ditto.
       
 31190         (WebCore::HTMLPlugInElement::checkDTD): Ditto.
       
 31191         (WebCore::HTMLPlugInElement::detach): Ditto.
       
 31192 
       
 31193 2007-05-29  Darin Adler  <darin@apple.com>
       
 31194 
       
 31195         Reviewed by Maciej.
       
 31196 
       
 31197         - fix http://bugs.webkit.org/show_bug.cgi?id=13602
       
 31198           Amazon product pages keep repainting over and over again
       
 31199 
       
 31200         - fix first-letter when the text of the affected text node is changed
       
 31201 
       
 31202         Optimize setInnerHTML, setOuterHTML, and setInnerText so they don't change the DOM at all
       
 31203         if they don't need to.
       
 31204 
       
 31205         Test: fast/dom/HTMLElement/set-inner-outer-optimization.html
       
 31206         Test: fast/css/first-letter-detach.html
       
 31207 
       
 31208         * html/HTMLElement.cpp:
       
 31209         (WebCore::equal): Added. Helper function that compares two Text nodes or two NamedAttrMap
       
 31210         attribute maps.
       
 31211         (WebCore::shallowEqual): Added. Helper function that compares two Element nodes or two
       
 31212         arbitrary nodes.
       
 31213         (WebCore::childrenAreEqual): Added. Helper functions that compare children of nodes.
       
 31214         (WebCore::hasOneChild): Added. Helper function.
       
 31215         (WebCore::hasOneTextChild): Added. Helper function.
       
 31216         (WebCore::replaceChildrenWithFragment): Added. Helper function used by setInnerHTML and
       
 31217         setInnerText. Optimizes the cases where all the nodes are the same, where both the current
       
 31218         and the new content are single text nodes, and where the current content is a single node
       
 31219         that can be replaced with replaceChild.
       
 31220         (WebCore::replaceChildrenWithText): Added. Helper function used by setInnerText. Optimizes
       
 31221         the case where the current content is a single text node or a single node that can be
       
 31222         replaced with replaceChild.
       
 31223         (WebCore::HTMLElement::setInnerHTML): Changed to call replaceChildrenWithFragment.
       
 31224         (WebCore::HTMLElement::setOuterHTML): Added special case to optimize when the new content
       
 31225         exactly matches the current node.
       
 31226         (WebCore::HTMLElement::setInnerText): Changed to call replaceChildrenWithText in a few
       
 31227         cases instead of doing removeChildren/appendChild. Changed code that was using
       
 31228         DeprecatedString to instead use String. Changed general case to use a document fragment
       
 31229         and replaceChildrenWithFragment.
       
 31230 
       
 31231         * dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
       
 31232         Fixed bug where we would not dispatch the DOMSubtreeModified event unless someone
       
 31233         was registered for the DOMCharacterDataModified event. Caused trouble in the test.
       
 31234 
       
 31235         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter): Set first-letter
       
 31236         after the setStyle call so calls to setTextInternal inside setStyle don't clear it.
       
 31237 
       
 31238         * rendering/RenderText.h: Made setTextInternal virtual so that RenderTextFragment can do
       
 31239         appropriate work when the text changes.
       
 31240 
       
 31241         * rendering/RenderTextFragment.h: Added an override of setTextInternal. Removed the
       
 31242         firstLetter parameter to the constructor and made it a separate setter. Also changed
       
 31243         m_generatedContentStr to m_contentString to match the getter function.
       
 31244         * rendering/RenderTextFragment.cpp:
       
 31245         (WebCore::RenderTextFragment::RenderTextFragment): Removed firstLetter parameter.
       
 31246         (WebCore::RenderTextFragment::setTextInternal): When the text changes, destroy the
       
 31247         first-letter node and reset the fragment values so that RenderBlock::updateFirstLetter,
       
 31248         which will run during layout, will create a new first-letter child. Otherwise we end up
       
 31249         with the first letter of the old text.
       
 31250 
       
 31251 2007-05-29  Sam Weinig  <sam@webkit.org>
       
 31252 
       
 31253         Fix Qt build.
       
 31254 
       
 31255         * platform/NotImplemented.h:
       
 31256 
       
 31257 2007-05-29  Sam Weinig  <sam@webkit.org>
       
 31258 
       
 31259         Reviewed by Adam Roben.
       
 31260 
       
 31261         Consolidate platform dependent notImplemented() macros
       
 31262         into one platform independent macro that uses WTFLog.
       
 31263 
       
 31264         * platform/NotImplemented.h:
       
 31265 
       
 31266 2007-05-29  Darin Adler  <darin@apple.com>
       
 31267 
       
 31268         Reviewed by Sam.
       
 31269 
       
 31270         - a clean-up pass on form-related aspects of the recent JSHTMLElement patch
       
 31271 
       
 31272         * bindings/js/JSHTMLElementCustom.cpp: (WebCore::JSHTMLElement::pushEventHandlerScope):
       
 31273         Replace the call to formForEventHandlerScope() with a call to the new form() function.
       
 31274         And removed the now-uneeded code to search for a form ancestor.
       
 31275 
       
 31276         * html/HTMLElement.h: Added a general-purpose form() function. The intent is to return
       
 31277         the form ancestor if any, but return the associated form for a form control, which isn't
       
 31278         always an ancestor of the control. To keep form() efficient for form controls, it's an
       
 31279         inline that calls a virtual, allowing a derived class to override it with an inline.
       
 31280         This replaces formForEventHandlerScope(). Also added findFormAncestor() to use here and
       
 31281         to replace the multiple loops found elsewhere to search for the nearest form ancestor.
       
 31282         * html/HTMLElement.cpp:
       
 31283         (WebCore::HTMLElement::findFormAncestor): Added.
       
 31284         (WebCore::HTMLElement::virtualForm): Added. Calls findFormAncestor().
       
 31285 
       
 31286         * html/HTMLGenericFormElement.h: Suggested name change to HTMLFormControlElement.
       
 31287         Removed the confusing getForm() function, which is superceded by findFormAncestor.
       
 31288         Removed the unused onSelect() function. Removed the override of formForEventHandlerScope(),
       
 31289         replacing it with an override of virtualForm().
       
 31290         * html/HTMLGenericFormElement.cpp:
       
 31291         (WebCore::HTMLGenericFormElement::HTMLGenericFormElement): Use findFormAncestor
       
 31292         instead of getForm.
       
 31293         (WebCore::HTMLGenericFormElement::insertedIntoTree): Ditto.
       
 31294         (WebCore::HTMLGenericFormElement::virtualForm): Added.
       
 31295 
       
 31296         * html/HTMLLabelElement.h: Removed now-unneeded form() and formForEventHandlerScope()
       
 31297         functions, since base class behavior is now good enough. Renamed formElement() to
       
 31298         correspondingControl(), since that's the terminology used elsewhere in the code,
       
 31299         and the old name was unnecessarily confusing.
       
 31300         * html/HTMLLabelElement.cpp:
       
 31301         (WebCore::HTMLLabelElement::correspondingControl): Renamed. Removed unnecessary
       
 31302         special case for empty ID, since getElementById already returns 0 for that case.
       
 31303         (WebCore::HTMLLabelElement::setActive): Updated for name change.
       
 31304         (WebCore::HTMLLabelElement::setHovered): Ditto.
       
 31305         (WebCore::HTMLLabelElement::defaultEventHandler): Ditto.
       
 31306         (WebCore::HTMLLabelElement::focus): Ditto.
       
 31307         (WebCore::HTMLLabelElement::accessKeyAction): Ditto.
       
 31308 
       
 31309         * html/HTMLObjectElement.h: Removed now-unneeded form() and formForEventHandlerScope()
       
 31310         functions, since base class behavior is now good enough. Also removed forward
       
 31311         declaration of KJS::Bindings::Instance -- since the type is the return value of a
       
 31312         function from the base class, it's guaranteed to be declared in the base class header.
       
 31313         * html/HTMLObjectElement.cpp: Ditto.
       
 31314 
       
 31315         * bridge/mac/WebCoreAXObject.mm: (labelForElement): Updated for name change.
       
 31316 
       
 31317 2007-05-29  Zack Rusin  <zrusin@trolltech.com>
       
 31318 
       
 31319         Reviewed by George and Niko
       
 31320 
       
 31321         Making the convenience method notImplemented convenient
       
 31322         for the Qt port.
       
 31323 
       
 31324         * platform/NotImplemented.h:
       
 31325 
       
 31326 2007-05-28  Sam Weinig  <sam@webkit.org>
       
 31327 
       
 31328         Reviewed by Geoff.
       
 31329 
       
 31330         - Patch for http://bugs.webkit.org/show_bug.cgi?id=13902
       
 31331           Autogenerate the JS bindings for the CSSStyleDeclaration
       
 31332 
       
 31333         * WebCore.pro:
       
 31334         * WebCore.xcodeproj/project.pbxproj:
       
 31335         * bindings/js/JSCSSStyleDeclarationCustom.cpp: Added.
       
 31336         (WebCore::cssPropertyName):
       
 31337         (WebCore::isCSSPropertyName):
       
 31338         (WebCore::JSCSSStyleDeclaration::canGetItemsForName):
       
 31339         (WebCore::JSCSSStyleDeclaration::nameGetter):
       
 31340         (WebCore::JSCSSStyleDeclaration::customPut):
       
 31341         * bindings/js/kjs_binding.h:
       
 31342         * bindings/js/kjs_css.cpp:
       
 31343         * bindings/js/kjs_css.h:
       
 31344         * bindings/objc/DOMUtility.mm:
       
 31345         (KJS::createDOMWrapper):
       
 31346         * bindings/scripts/CodeGeneratorJS.pm:
       
 31347         * css/CSSStyleDeclaration.idl:
       
 31348 
       
 31349 2007-05-28  Mitz Pettel  <mitz@webkit.org>
       
 31350 
       
 31351         Reviewed by Darin.
       
 31352 
       
 31353         - fix http://bugs.webkit.org/show_bug.cgi?id=13896
       
 31354           REGRESSION (NativePopup): Reproductible crasher on Google Coop control panel
       
 31355 
       
 31356         Test: fast/forms/select-display-none-style-resolve.html
       
 31357 
       
 31358         * html/HTMLOptGroupElement.cpp:
       
 31359         (WebCore::HTMLOptGroupElement::attach): Do not compute style if the parent
       
 31360         does not have style.
       
 31361         * html/HTMLOptionElement.cpp:
       
 31362         (WebCore::HTMLOptionElement::attach): Ditto.
       
 31363 
       
 31364 2007-05-28  Sam Weinig  <sam@webkit.org>
       
 31365 
       
 31366         Fix Gdk and Qt builds.
       
 31367 
       
 31368         * WebCore.pro:
       
 31369 
       
 31370 2007-05-28  Sam Weinig  <sam@webkit.org>
       
 31371 
       
 31372         Reviewed by Darin.
       
 31373 
       
 31374         Patch for http://bugs.webkit.org/show_bug.cgi?id=13894
       
 31375         Remove the legacy class KJS::JSHTMLElement
       
 31376 
       
 31377         - Now that all of the subclasses of JSHTMLElement are
       
 31378           autogenerated and no longer rely on the legacy parent,
       
 31379           we can remove it and update all the HTML idl files to
       
 31380           reflect so.
       
 31381 
       
 31382         - Also adds JSHTMLBlockquoteElement's JS constructor which
       
 31383           was mistakingly missing.
       
 31384 
       
 31385         * WebCore.xcodeproj/project.pbxproj:
       
 31386         * bindings/js/JSHTMLAnchorElementCustom.cpp:
       
 31387         (WebCore::JSHTMLAnchorElement::toString):
       
 31388         * bindings/js/JSHTMLElementCustom.cpp: Added.
       
 31389         (WebCore::JSHTMLElement::pushEventHandlerScope):
       
 31390         * bindings/js/JSHTMLElementWrapperFactory.cpp:
       
 31391         (WebCore::createJSHTMLWrapper):
       
 31392         * bindings/js/JSHTMLInputElementBase.cpp:
       
 31393         (WebCore::):
       
 31394         (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
       
 31395         (WebCore::JSHTMLInputElementBase::getOwnPropertySlot):
       
 31396         (WebCore::JSHTMLInputElementBase::put):
       
 31397         * bindings/js/JSHTMLInputElementBase.h:
       
 31398         * bindings/js/JSHTMLSelectElementCustom.cpp:
       
 31399         * bindings/js/kjs_html.cpp:
       
 31400         (KJS::runtimeObjectCustomGetOwnPropertySlot):
       
 31401         * bindings/js/kjs_html.h:
       
 31402         * bindings/scripts/CodeGeneratorJS.pm:
       
 31403         * html/HTMLAnchorElement.idl:
       
 31404         * html/HTMLAppletElement.idl:
       
 31405         * html/HTMLAreaElement.idl:
       
 31406         * html/HTMLBRElement.idl:
       
 31407         * html/HTMLBaseElement.idl:
       
 31408         * html/HTMLBaseFontElement.idl:
       
 31409         * html/HTMLBlockquoteElement.idl:
       
 31410         * html/HTMLBodyElement.idl:
       
 31411         * html/HTMLButtonElement.idl:
       
 31412         * html/HTMLCanvasElement.idl:
       
 31413         * html/HTMLDListElement.idl:
       
 31414         * html/HTMLDirectoryElement.idl:
       
 31415         * html/HTMLDivElement.idl:
       
 31416         * html/HTMLElement.cpp:
       
 31417         (WebCore::HTMLElement::formForEventHandlerScope):
       
 31418         * html/HTMLElement.h:
       
 31419         * html/HTMLElement.idl:
       
 31420         * html/HTMLEmbedElement.idl:
       
 31421         * html/HTMLFieldSetElement.idl:
       
 31422         * html/HTMLFontElement.idl:
       
 31423         * html/HTMLFormElement.idl:
       
 31424         * html/HTMLFrameElement.idl:
       
 31425         * html/HTMLFrameSetElement.idl:
       
 31426         * html/HTMLGenericFormElement.cpp:
       
 31427         (WebCore::HTMLGenericFormElement::formForEventHandlerScope):
       
 31428         * html/HTMLGenericFormElement.h:
       
 31429         * html/HTMLHRElement.idl:
       
 31430         * html/HTMLHeadElement.idl:
       
 31431         * html/HTMLHeadingElement.idl:
       
 31432         * html/HTMLHtmlElement.idl:
       
 31433         * html/HTMLIFrameElement.idl:
       
 31434         * html/HTMLImageElement.idl:
       
 31435         * html/HTMLIsIndexElement.idl:
       
 31436         * html/HTMLLIElement.idl:
       
 31437         * html/HTMLLabelElement.cpp:
       
 31438         (WebCore::HTMLLabelElement::form):
       
 31439         (WebCore::HTMLLabelElement::formForEventHandlerScope):
       
 31440         * html/HTMLLabelElement.h:
       
 31441         * html/HTMLLabelElement.idl:
       
 31442         * html/HTMLLegendElement.idl:
       
 31443         * html/HTMLLinkElement.idl:
       
 31444         * html/HTMLMapElement.idl:
       
 31445         * html/HTMLMarqueeElement.idl:
       
 31446         * html/HTMLMenuElement.idl:
       
 31447         * html/HTMLMetaElement.idl:
       
 31448         * html/HTMLModElement.idl:
       
 31449         * html/HTMLOListElement.idl:
       
 31450         * html/HTMLObjectElement.cpp:
       
 31451         (WebCore::HTMLObjectElement::formForEventHandlerScope):
       
 31452         * html/HTMLObjectElement.h:
       
 31453         * html/HTMLObjectElement.idl:
       
 31454         * html/HTMLOptGroupElement.idl:
       
 31455         * html/HTMLOptionElement.idl:
       
 31456         * html/HTMLParagraphElement.idl:
       
 31457         * html/HTMLParamElement.idl:
       
 31458         * html/HTMLPreElement.idl:
       
 31459         * html/HTMLQuoteElement.idl:
       
 31460         * html/HTMLScriptElement.idl:
       
 31461         * html/HTMLSelectElement.idl:
       
 31462         * html/HTMLStyleElement.idl:
       
 31463         * html/HTMLTableCaptionElement.idl:
       
 31464         * html/HTMLTableCellElement.idl:
       
 31465         * html/HTMLTableColElement.idl:
       
 31466         * html/HTMLTableElement.idl:
       
 31467         * html/HTMLTableRowElement.idl:
       
 31468         * html/HTMLTableSectionElement.idl:
       
 31469         * html/HTMLTextAreaElement.idl:
       
 31470         * html/HTMLTitleElement.idl:
       
 31471         * html/HTMLUListElement.idl:
       
 31472         * page/DOMWindow.idl:
       
 31473 
       
 31474 2007-05-28  Zack Rusin  <zrusin@trolltech.com>
       
 31475 
       
 31476         Reviewed by andersca
       
 31477 
       
 31478         Adding Qt related constructor/casting operators
       
 31479         to the AtomicString and updating the project
       
 31480         file for new Qt settings api using those.
       
 31481 
       
 31482         * WebCore.pro:
       
 31483         * platform/AtomicString.h:
       
 31484 
       
 31485 2007-05-27  Sam Weinig  <sam@webkit.org>
       
 31486 
       
 31487         Qt and Gdk build fix.
       
 31488 
       
 31489         * WebCore.pro:
       
 31490 
       
 31491 2007-05-27  Sam Weinig  <sam@webkit.org>
       
 31492 
       
 31493         Reviewed by Hyatt.
       
 31494 
       
 31495         Patch for http://bugs.webkit.org/show_bug.cgi?id=13893
       
 31496         Autogenerate the JS bindings for the HTMLObjectElement, 
       
 31497         HTMLEmbedElement and HTMLAppletElement
       
 31498 
       
 31499         * DerivedSources.make:
       
 31500         * WebCore.xcodeproj/project.pbxproj:
       
 31501         * bindings/js/JSHTMLAppletElementCustom.cpp: Added.
       
 31502         (WebCore::JSHTMLAppletElement::customGetOwnPropertySlot):
       
 31503         (WebCore::JSHTMLAppletElement::customPut):
       
 31504         (WebCore::JSHTMLAppletElement::implementsCall):
       
 31505         (WebCore::JSHTMLAppletElement::callAsFunction):
       
 31506         (WebCore::JSHTMLAppletElement::canGetItemsForName):
       
 31507         (WebCore::JSHTMLAppletElement::nameGetter):
       
 31508         * bindings/js/JSHTMLElementWrapperFactory.cpp:
       
 31509         * bindings/js/JSHTMLEmbedElementCustom.cpp: Added.
       
 31510         (WebCore::JSHTMLEmbedElement::customGetOwnPropertySlot):
       
 31511         (WebCore::JSHTMLEmbedElement::customPut):
       
 31512         (WebCore::JSHTMLEmbedElement::implementsCall):
       
 31513         (WebCore::JSHTMLEmbedElement::callAsFunction):
       
 31514         (WebCore::JSHTMLEmbedElement::canGetItemsForName):
       
 31515         (WebCore::JSHTMLEmbedElement::nameGetter):
       
 31516         * bindings/js/JSHTMLObjectElementCustom.cpp: Added.
       
 31517         (WebCore::JSHTMLObjectElement::customGetOwnPropertySlot):
       
 31518         (WebCore::JSHTMLObjectElement::customPut):
       
 31519         (WebCore::JSHTMLObjectElement::implementsCall):
       
 31520         (WebCore::JSHTMLObjectElement::callAsFunction):
       
 31521         (WebCore::JSHTMLObjectElement::canGetItemsForName):
       
 31522         (WebCore::JSHTMLObjectElement::nameGetter):
       
 31523         * bindings/js/kjs_html.cpp:
       
 31524         (KJS::):
       
 31525         (KJS::JSHTMLElement::toString):
       
 31526         (KJS::JSHTMLElement::pushEventHandlerScope):
       
 31527         (KJS::runtimeObjectGetter):
       
 31528         (KJS::runtimeObjectPropertyGetter):
       
 31529         (KJS::runtimeObjectCustomGetOwnPropertySlot):
       
 31530         (KJS::runtimeObjectCustomPut):
       
 31531         (KJS::runtimeObjectImplementsCall):
       
 31532         (KJS::runtimeObjectCallAsFunction):
       
 31533         * bindings/js/kjs_html.h:
       
 31534         (KJS::JSHTMLElement::classInfo):
       
 31535         * bindings/scripts/CodeGeneratorJS.pm: Add support for 
       
 31536         CustomGetOwnPropertySlot, CustomPutFunction, CustomCall,
       
 31537         and SVGCheckSecurityDocument properties.
       
 31538         * html/HTMLAppletElement.idl:
       
 31539         * html/HTMLEmbedElement.idl:
       
 31540         * html/HTMLObjectElement.idl:
       
 31541         * page/DOMWindow.idl: Uncomment constructors.
       
 31542 
       
 31543 2007-05-27  Sam Weinig  <sam@webkit.org>
       
 31544 
       
 31545         Reviewed by Oliver.
       
 31546 
       
 31547         Gdk build fix.
       
 31548 
       
 31549         * platform/graphics/Path.h:
       
 31550 
       
 31551 2007-05-27  Sam Weinig  <sam@webkit.org>
       
 31552 
       
 31553         Gdk build fix.  Forgot to update a few instances of notImplementedGdk() to notImplemented().
       
 31554 
       
 31555         * page/gdk/EventHandlerGdk.cpp:
       
 31556         (WebCore::EventHandler::passMousePressEventToScrollbar):
       
 31557         * platform/gdk/EditorClientGdk.cpp:
       
 31558         (WebCore::EditorClientGdk::ignoreWordInSpellDocument):
       
 31559         (WebCore::EditorClientGdk::learnWord):
       
 31560         (WebCore::EditorClientGdk::checkSpellingOfString):
       
 31561         (WebCore::EditorClientGdk::checkGrammarOfString):
       
 31562         (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString):
       
 31563         (WebCore::EditorClientGdk::updateSpellingUIWithMisspelledWord):
       
 31564         (WebCore::EditorClientGdk::showSpellingUI):
       
 31565         (WebCore::EditorClientGdk::spellingUIIsShowing):
       
 31566         (WebCore::EditorClientGdk::getGuessesForWord):
       
 31567         * platform/gdk/FrameGdk.cpp:
       
 31568         (WebCore::Frame::dashboardRegionsChanged):
       
 31569         * platform/gdk/PlatformScrollBarGdk.cpp:
       
 31570         (PlatformScrollbar::paint):
       
 31571         (PlatformScrollbar::updateThumbPosition):
       
 31572         (PlatformScrollbar::updateThumbProportion):
       
 31573         * platform/gdk/TemporaryLinkStubs.cpp:
       
 31574         (Widget::setEnabled):
       
 31575         (Widget::isEnabled):
       
 31576         (Widget::removeFromParent):
       
 31577         (Widget::paint):
       
 31578         (Widget::setIsSelected):
       
 31579         (Widget::invalidate):
       
 31580         (Widget::invalidateRect):
       
 31581 
       
 31582 2007-05-27  Alp Toker  <alp.toker@collabora.co.uk>
       
 31583 
       
 31584         Reviewed by Sam and Oliver.
       
 31585 
       
 31586         Implement PathCairo. This patch is based on changes in Mike Emmel's
       
 31587         WebKit fork with some additional clean-ups and updates.
       
 31588 
       
 31589         * platform/graphics/Path.h:
       
 31590         * platform/graphics/cairo/CairoPath.h: Added.
       
 31591         (CairoPath::CairoPath):
       
 31592         (CairoPath::~CairoPath):
       
 31593         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
 31594         (WebCore::GraphicsContext::clip):
       
 31595         * platform/graphics/cairo/PathCairo.cpp:
       
 31596         (WebCore::Path::Path):
       
 31597         (WebCore::Path::~Path):
       
 31598         (WebCore::Path::operator=):
       
 31599         (WebCore::Path::clear):
       
 31600         (WebCore::Path::isEmpty):
       
 31601         (WebCore::Path::translate):
       
 31602         (WebCore::Path::moveTo):
       
 31603         (WebCore::Path::addLineTo):
       
 31604         (WebCore::Path::addRect):
       
 31605         (WebCore::Path::addQuadCurveTo):
       
 31606         (WebCore::Path::addBezierCurveTo):
       
 31607         (WebCore::Path::addArc):
       
 31608         (WebCore::Path::addArcTo):
       
 31609         (WebCore::Path::addEllipse):
       
 31610         (WebCore::Path::closeSubpath):
       
 31611         (WebCore::Path::boundingRect):
       
 31612         (WebCore::Path::contains):
       
 31613         (WebCore::Path::apply):
       
 31614         (WebCore::Path::transform):
       
 31615         (WebCore::Path::debugString):
       
 31616 
       
 31617 2007-05-27  Kevin Ollivier  <kevino@theolliviers.com>
       
 31618 
       
 31619         Reviewed by Sam Weinig.
       
 31620 
       
 31621         Consolidate all notImplemented() macro definitions into
       
 31622         one header file for all platforms.
       
 31623 
       
 31624         * loader/gdk/DocumentLoaderGdk.cpp:
       
 31625         (WebCore::DocumentLoader::getResponseModifiedHeader):
       
 31626         * loader/gdk/FrameLoaderClientGdk.cpp:
       
 31627         (WebCore::FrameLoaderClientGdk::dispatchDidReceiveAuthenticationChallenge):
       
 31628         (WebCore::FrameLoaderClientGdk::dispatchDidCancelAuthenticationChallenge):
       
 31629         (WebCore::FrameLoaderClientGdk::dispatchWillSendRequest):
       
 31630         (WebCore::FrameLoaderClientGdk::assignIdentifierToInitialRequest):
       
 31631         (WebCore::FrameLoaderClientGdk::createPlugin):
       
 31632         (WebCore::FrameLoaderClientGdk::createFrame):
       
 31633         (WebCore::FrameLoaderClientGdk::redirectDataToPlugin):
       
 31634         (WebCore::FrameLoaderClientGdk::createJavaAppletWidget):
       
 31635         (WebCore::FrameLoaderClientGdk::objectContentType):
       
 31636         (WebCore::FrameLoaderClientGdk::overrideMediaType):
       
 31637         (WebCore::FrameLoaderClientGdk::windowObjectCleared):
       
 31638         (WebCore::FrameLoaderClientGdk::hasWebView):
       
 31639         (WebCore::FrameLoaderClientGdk::hasFrameView):
       
 31640         (WebCore::FrameLoaderClientGdk::frameLoadCompleted):
       
 31641         (WebCore::FrameLoaderClientGdk::saveViewStateToItem):
       
 31642         (WebCore::FrameLoaderClientGdk::restoreViewState):
       
 31643         (WebCore::FrameLoaderClientGdk::privateBrowsingEnabled):
       
 31644         (WebCore::FrameLoaderClientGdk::makeDocumentView):
       
 31645         (WebCore::FrameLoaderClientGdk::makeRepresentation):
       
 31646         (WebCore::FrameLoaderClientGdk::forceLayout):
       
 31647         (WebCore::FrameLoaderClientGdk::forceLayoutForNonHTML):
       
 31648         (WebCore::FrameLoaderClientGdk::setCopiesOnScroll):
       
 31649         (WebCore::FrameLoaderClientGdk::detachedFromParent1):
       
 31650         (WebCore::FrameLoaderClientGdk::detachedFromParent2):
       
 31651         (WebCore::FrameLoaderClientGdk::detachedFromParent3):
       
 31652         (WebCore::FrameLoaderClientGdk::detachedFromParent4):
       
 31653         (WebCore::FrameLoaderClientGdk::loadedFromCachedPage):
       
 31654         (WebCore::FrameLoaderClientGdk::dispatchDidHandleOnloadEvents):
       
 31655         (WebCore::FrameLoaderClientGdk::dispatchDidReceiveServerRedirectForProvisionalLoad):
       
 31656         (WebCore::FrameLoaderClientGdk::dispatchDidCancelClientRedirect):
       
 31657         (WebCore::FrameLoaderClientGdk::dispatchWillPerformClientRedirect):
       
 31658         (WebCore::FrameLoaderClientGdk::dispatchDidChangeLocationWithinPage):
       
 31659         (WebCore::FrameLoaderClientGdk::dispatchWillClose):
       
 31660         (WebCore::FrameLoaderClientGdk::dispatchDidReceiveIcon):
       
 31661         (WebCore::FrameLoaderClientGdk::dispatchDidStartProvisionalLoad):
       
 31662         (WebCore::FrameLoaderClientGdk::dispatchDidReceiveTitle):
       
 31663         (WebCore::FrameLoaderClientGdk::dispatchDidCommitLoad):
       
 31664         (WebCore::FrameLoaderClientGdk::dispatchDidFinishDocumentLoad):
       
 31665         (WebCore::FrameLoaderClientGdk::dispatchDidFirstLayout):
       
 31666         (WebCore::FrameLoaderClientGdk::dispatchShow):
       
 31667         (WebCore::FrameLoaderClientGdk::cancelPolicyCheck):
       
 31668         (WebCore::FrameLoaderClientGdk::dispatchDidLoadMainResource):
       
 31669         (WebCore::FrameLoaderClientGdk::revertToProvisionalState):
       
 31670         (WebCore::FrameLoaderClientGdk::clearUnarchivingState):
       
 31671         (WebCore::FrameLoaderClientGdk::willChangeTitle):
       
 31672         (WebCore::FrameLoaderClientGdk::finishedLoading):
       
 31673         (WebCore::FrameLoaderClientGdk::finalSetupForReplace):
       
 31674         (WebCore::FrameLoaderClientGdk::setDefersLoading):
       
 31675         (WebCore::FrameLoaderClientGdk::isArchiveLoadPending):
       
 31676         (WebCore::FrameLoaderClientGdk::cancelPendingArchiveLoad):
       
 31677         (WebCore::FrameLoaderClientGdk::clearArchivedResources):
       
 31678         (WebCore::FrameLoaderClientGdk::canHandleRequest):
       
 31679         (WebCore::FrameLoaderClientGdk::canShowMIMEType):
       
 31680         (WebCore::FrameLoaderClientGdk::representationExistsForURLScheme):
       
 31681         (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme):
       
 31682         (WebCore::FrameLoaderClientGdk::provisionalLoadStarted):
       
 31683         (WebCore::FrameLoaderClientGdk::didFinishLoad):
       
 31684         (WebCore::FrameLoaderClientGdk::prepareForDataSourceReplacement):
       
 31685         (WebCore::FrameLoaderClientGdk::setTitle):
       
 31686         (WebCore::FrameLoaderClientGdk::setDocumentViewFromCachedPage):
       
 31687         (WebCore::FrameLoaderClientGdk::dispatchDidReceiveContentLength):
       
 31688         (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading):
       
 31689         (WebCore::FrameLoaderClientGdk::dispatchDidFailLoading):
       
 31690         (WebCore::FrameLoaderClientGdk::dispatchDidLoadResourceFromMemoryCache):
       
 31691         (WebCore::FrameLoaderClientGdk::dispatchDidFailProvisionalLoad):
       
 31692         (WebCore::FrameLoaderClientGdk::dispatchDidFailLoad):
       
 31693         (WebCore::FrameLoaderClientGdk::download):
       
 31694         (WebCore::FrameLoaderClientGdk::cancelledError):
       
 31695         (WebCore::FrameLoaderClientGdk::blockedError):
       
 31696         (WebCore::FrameLoaderClientGdk::cannotShowURLError):
       
 31697         (WebCore::FrameLoaderClientGdk::interruptForPolicyChangeError):
       
 31698         (WebCore::FrameLoaderClientGdk::cannotShowMIMETypeError):
       
 31699         (WebCore::FrameLoaderClientGdk::fileDoesNotExistError):
       
 31700         (WebCore::FrameLoaderClientGdk::shouldFallBack):
       
 31701         (WebCore::FrameLoaderClientGdk::willUseArchive):
       
 31702         (WebCore::FrameLoaderClientGdk::saveDocumentViewToCachedPage):
       
 31703         (WebCore::FrameLoaderClientGdk::canCachePage):
       
 31704         (WebCore::FrameLoaderClientGdk::dispatchCreatePage):
       
 31705         (WebCore::FrameLoaderClientGdk::dispatchUnableToImplementPolicy):
       
 31706         (WebCore::FrameLoaderClientGdk::setMainDocumentError):
       
 31707         (WebCore::FrameLoaderClientGdk::startDownload):
       
 31708         (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForStandardLoad):
       
 31709         (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForReload):
       
 31710         * loader/qt/DocumentLoaderQt.cpp:
       
 31711         * page/gdk/ContextMenuClientGdk.cpp:
       
 31712         (WebCore::ContextMenuClientGdk::contextMenuDestroyed):
       
 31713         (WebCore::ContextMenuClientGdk::getCustomMenuFromDefaultItems):
       
 31714         (WebCore::ContextMenuClientGdk::contextMenuItemSelected):
       
 31715         (WebCore::ContextMenuClientGdk::downloadURL):
       
 31716         (WebCore::ContextMenuClientGdk::copyImageToClipboard):
       
 31717         (WebCore::ContextMenuClientGdk::searchWithGoogle):
       
 31718         (WebCore::ContextMenuClientGdk::lookUpInDictionary):
       
 31719         (WebCore::ContextMenuClientGdk::speak):
       
 31720         (WebCore::ContextMenuClientGdk::stopSpeaking):
       
 31721         * page/gdk/EventHandlerGdk.cpp:
       
 31722         (WebCore::EventHandler::passMouseDownEventToWidget):
       
 31723         (WebCore::EventHandler::eventActivatedView):
       
 31724         (WebCore::EventHandler::passSubframeEventToSubframe):
       
 31725         (WebCore::EventHandler::passWheelEventToWidget):
       
 31726         (WebCore::EventHandler::createDraggingClipboard):
       
 31727         * page/qt/EventHandlerQt.cpp:
       
 31728         * page/qt/FrameQt.cpp:
       
 31729         * platform/NotImplemented.h: Added.
       
 31730         * platform/gdk/CursorGdk.cpp:
       
 31731         (WebCore::Cursor::Cursor):
       
 31732         * platform/gdk/EditorClientGdk.cpp:
       
 31733         (WebCore::EditorClientGdk::shouldDeleteRange):
       
 31734         (WebCore::EditorClientGdk::isContinuousSpellCheckingEnabled):
       
 31735         (WebCore::EditorClientGdk::isGrammarCheckingEnabled):
       
 31736         (WebCore::EditorClientGdk::spellCheckerDocumentTag):
       
 31737         (WebCore::EditorClientGdk::shouldBeginEditing):
       
 31738         (WebCore::EditorClientGdk::shouldEndEditing):
       
 31739         (WebCore::EditorClientGdk::shouldInsertText):
       
 31740         (WebCore::EditorClientGdk::shouldChangeSelectedRange):
       
 31741         (WebCore::EditorClientGdk::shouldApplyStyle):
       
 31742         (WebCore::EditorClientGdk::didBeginEditing):
       
 31743         (WebCore::EditorClientGdk::respondToChangedContents):
       
 31744         (WebCore::EditorClientGdk::respondToChangedSelection):
       
 31745         (WebCore::EditorClientGdk::didEndEditing):
       
 31746         (WebCore::EditorClientGdk::didWriteSelectionToPasteboard):
       
 31747         (WebCore::EditorClientGdk::didSetSelectionTypesForPasteboard):
       
 31748         (WebCore::EditorClientGdk::selectWordBeforeMenuEvent):
       
 31749         (WebCore::EditorClientGdk::isEditable):
       
 31750         (WebCore::EditorClientGdk::registerCommandForUndo):
       
 31751         (WebCore::EditorClientGdk::registerCommandForRedo):
       
 31752         (WebCore::EditorClientGdk::clearUndoRedoOperations):
       
 31753         (WebCore::EditorClientGdk::canUndo):
       
 31754         (WebCore::EditorClientGdk::canRedo):
       
 31755         (WebCore::EditorClientGdk::undo):
       
 31756         (WebCore::EditorClientGdk::redo):
       
 31757         (WebCore::EditorClientGdk::shouldInsertNode):
       
 31758         (WebCore::EditorClientGdk::pageDestroyed):
       
 31759         (WebCore::EditorClientGdk::smartInsertDeleteEnabled):
       
 31760         (WebCore::EditorClientGdk::toggleContinuousSpellChecking):
       
 31761         (WebCore::EditorClientGdk::handleInputMethodKeypress):
       
 31762         (WebCore::EditorClientGdk::textFieldDidBeginEditing):
       
 31763         (WebCore::EditorClientGdk::textFieldDidEndEditing):
       
 31764         (WebCore::EditorClientGdk::textDidChangeInTextField):
       
 31765         (WebCore::EditorClientGdk::doTextFieldCommandFromEvent):
       
 31766         (WebCore::EditorClientGdk::textWillBeDeletedInTextField):
       
 31767         (WebCore::EditorClientGdk::textDidChangeInTextArea):
       
 31768         * platform/gdk/FrameGdk.cpp:
       
 31769         (WebCore::Frame::print):
       
 31770         (WebCore::Frame::issueTransposeCommand):
       
 31771         (WebCore::Frame::cleanupPlatformScriptObjects):
       
 31772         (WebCore::Frame::dragImageForSelection):
       
 31773         * platform/gdk/NotImplementedGdk.h: Removed.
       
 31774         * platform/gdk/PopupMenuGdk.cpp:
       
 31775         (WebCore::PopupMenu::PopupMenu):
       
 31776         (WebCore::PopupMenu::~PopupMenu):
       
 31777         (WebCore::PopupMenu::show):
       
 31778         (WebCore::PopupMenu::hide):
       
 31779         (WebCore::PopupMenu::updateFromElement):
       
 31780         * platform/gdk/RenderThemeGdk.cpp:
       
 31781         (WebCore::RenderThemeGdk::setCheckboxSize):
       
 31782         (WebCore::RenderThemeGdk::setRadioSize):
       
 31783         (WebCore::RenderThemeGdk::adjustTextFieldStyle):
       
 31784         * platform/gdk/ScreenGdk.cpp:
       
 31785         (WebCore::screenDepthPerComponent):
       
 31786         (WebCore::screenIsMonochrome):
       
 31787         (WebCore::screenRect):
       
 31788         (WebCore::screenAvailableRect):
       
 31789         * platform/gdk/ScrollViewGdk.cpp:
       
 31790         (WebCore::ScrollView::update):
       
 31791         (WebCore::ScrollView::addChild):
       
 31792         (WebCore::ScrollView::removeChild):
       
 31793         (WebCore::ScrollView::scrollRectIntoViewRecursively):
       
 31794         (WebCore::ScrollView::inWindow):
       
 31795         (WebCore::ScrollView::wheelEvent):
       
 31796         (WebCore::ScrollView::updateScrollbars):
       
 31797         (WebCore::ScrollView::updateScrollInfo):
       
 31798         (WebCore::ScrollView::windowToContents):
       
 31799         (WebCore::ScrollView::contentsToWindow):
       
 31800         (WebCore::ScrollView::scrollbarUnderMouse):
       
 31801         * platform/gdk/TemporaryLinkStubs.cpp:
       
 31802         (FrameView::updateBorder):
       
 31803         (WebCore::findNextWordFromIndex):
       
 31804         (WebCore::currentTextBreakLocaleID):
       
 31805         (ChromeClientGdk::chromeDestroyed):
       
 31806         (ChromeClientGdk::windowRect):
       
 31807         (ChromeClientGdk::setWindowRect):
       
 31808         (ChromeClientGdk::pageRect):
       
 31809         (ChromeClientGdk::scaleFactor):
       
 31810         (ChromeClientGdk::focus):
       
 31811         (ChromeClientGdk::unfocus):
       
 31812         (ChromeClientGdk::createWindow):
       
 31813         (ChromeClientGdk::createModalDialog):
       
 31814         (ChromeClientGdk::show):
       
 31815         (ChromeClientGdk::canRunModal):
       
 31816         (ChromeClientGdk::runModal):
       
 31817         (ChromeClientGdk::setToolbarsVisible):
       
 31818         (ChromeClientGdk::toolbarsVisible):
       
 31819         (ChromeClientGdk::setStatusbarVisible):
       
 31820         (ChromeClientGdk::statusbarVisible):
       
 31821         (ChromeClientGdk::setScrollbarsVisible):
       
 31822         (ChromeClientGdk::scrollbarsVisible):
       
 31823         (ChromeClientGdk::setMenubarVisible):
       
 31824         (ChromeClientGdk::menubarVisible):
       
 31825         (ChromeClientGdk::setResizable):
       
 31826         (ChromeClientGdk::closeWindowSoon):
       
 31827         (ChromeClientGdk::canTakeFocus):
       
 31828         (ChromeClientGdk::takeFocus):
       
 31829         (ChromeClientGdk::canRunBeforeUnloadConfirmPanel):
       
 31830         (ChromeClientGdk::addMessageToConsole):
       
 31831         (ChromeClientGdk::runBeforeUnloadConfirmPanel):
       
 31832         (ChromeClientGdk::runJavaScriptAlert):
       
 31833         (ChromeClientGdk::runJavaScriptConfirm):
       
 31834         (ChromeClientGdk::runJavaScriptPrompt):
       
 31835         (ChromeClientGdk::setStatusbarText):
       
 31836         (ChromeClientGdk::shouldInterruptJavaScript):
       
 31837         (ChromeClientGdk::tabsToLinks):
       
 31838         (ChromeClientGdk::windowResizerRect):
       
 31839         (ChromeClientGdk::addToDirtyRegion):
       
 31840         (ChromeClientGdk::scrollBackingStore):
       
 31841         (ChromeClientGdk::updateBackingStore):
       
 31842         (PlugInInfoStore::createPluginInfoForPluginAtIndex):
       
 31843         (PlugInInfoStore::pluginCount):
       
 31844         (WebCore::PlugInInfoStore::supportsMIMEType):
       
 31845         (WebCore::refreshPlugins):
       
 31846         (SearchPopupMenu::saveRecentSearches):
       
 31847         (SearchPopupMenu::loadRecentSearches):
       
 31848         (SearchPopupMenu::SearchPopupMenu):
       
 31849         (SearchPopupMenu::enabled):
       
 31850         (FileChooser::FileChooser):
       
 31851         (FileChooser::~FileChooser):
       
 31852         (FileChooser::openFileChooser):
       
 31853         (FileChooser::basenameForWidth):
       
 31854         (ResourceHandle::willLoadFromCache):
       
 31855         (ResourceHandle::loadsBlocked):
       
 31856         (ResourceHandle::loadResourceSynchronously):
       
 31857         (Icon::Icon):
       
 31858         (Icon::~Icon):
       
 31859         (Icon::newIconForFile):
       
 31860         (Icon::paint):
       
 31861         (Font::selectionRectForComplexText):
       
 31862         (Font::drawComplexText):
       
 31863         (Font::floatWidthForComplexText):
       
 31864         (Font::offsetForPositionForComplexText):
       
 31865         (CachedPage::close):
       
 31866         (Editor::newGeneralClipboard):
       
 31867         (Pasteboard::generalPasteboard):
       
 31868         (Pasteboard::writeSelection):
       
 31869         (Pasteboard::writeURL):
       
 31870         (Pasteboard::writeImage):
       
 31871         (Pasteboard::clear):
       
 31872         (Pasteboard::canSmartReplace):
       
 31873         (Pasteboard::documentFragment):
       
 31874         (Pasteboard::plainText):
       
 31875         (Pasteboard::Pasteboard):
       
 31876         (Pasteboard::~Pasteboard):
       
 31877         (ContextMenu::ContextMenu):
       
 31878         (ContextMenu::~ContextMenu):
       
 31879         (ContextMenu::appendItem):
       
 31880         (ContextMenuItem::ContextMenuItem):
       
 31881         (ContextMenuItem::~ContextMenuItem):
       
 31882         (ContextMenuItem::releasePlatformDescription):
       
 31883         (ContextMenuItem::type):
       
 31884         (ContextMenuItem::setType):
       
 31885         (ContextMenuItem::action):
       
 31886         (ContextMenuItem::setAction):
       
 31887         (ContextMenuItem::title):
       
 31888         (ContextMenuItem::setTitle):
       
 31889         (ContextMenuItem::platformSubMenu):
       
 31890         (ContextMenuItem::setSubMenu):
       
 31891         (ContextMenuItem::setChecked):
       
 31892         (ContextMenuItem::setEnabled):
       
 31893         (WebCore::supportedKeySizes):
       
 31894         (WebCore::systemBeep):
       
 31895         (WebCore::userIdleTime):
       
 31896         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
 31897         * platform/graphics/cairo/ImageBufferCairo.cpp:
       
 31898         * platform/graphics/cairo/PathCairo.cpp:
       
 31899         * platform/graphics/gdk/ImageGdk.cpp:
       
 31900         * platform/graphics/qt/GraphicsContextQt.cpp:
       
 31901         * platform/graphics/qt/IconQt.cpp:
       
 31902         * platform/graphics/qt/ImageQt.cpp:
       
 31903         * platform/network/gdk/ResourceHandleCurl.cpp:
       
 31904         (WebCore::ResourceHandle::setDefersLoading):
       
 31905         * platform/network/gdk/ResourceHandleManager.cpp:
       
 31906         (WebCore::ResourceHandleManager::setupPUT):
       
 31907         (WebCore::ResourceHandleManager::setupPOST):
       
 31908         * platform/network/qt/ResourceHandleQt.cpp:
       
 31909         * platform/qt/ClipboardQt.cpp:
       
 31910         * platform/qt/CursorQt.cpp:
       
 31911         * platform/qt/DragDataQt.cpp:
       
 31912         * platform/qt/FileChooserQt.cpp:
       
 31913         * platform/qt/MimeTypeRegistryQt.cpp:
       
 31914         * platform/qt/PasteboardQt.cpp:
       
 31915         * platform/qt/PlatformScrollBarQt.cpp:
       
 31916         * platform/qt/PopupMenuQt.cpp:
       
 31917         * platform/qt/ScrollViewQt.cpp:
       
 31918         * platform/qt/TemporaryLinkStubs.cpp:
       
 31919         * platform/qt/TextBoundaries.cpp:
       
 31920         * platform/qt/WidgetQt.cpp:
       
 31921         * platform/win/FontWin.cpp:
       
 31922         * platform/win/TemporaryLinkStubs.cpp:
       
 31923         * platform/wx/ClipboardWx.cpp:
       
 31924         * platform/wx/FontWx.cpp:
       
 31925         * platform/wx/ScrollViewWx.cpp:
       
 31926         * platform/wx/SharedTimerWx.cpp:
       
 31927         * platform/wx/TemporaryLinkStubs.cpp:
       
 31928 
       
 31929 2007-05-27  Rob Buis  <buis@kde.org>
       
 31930 
       
 31931         Reviewed by Oliver.
       
 31932 
       
 31933         http://bugs.webkit.org/show_bug.cgi?id=13828
       
 31934         x/y values on rootmost <svg> elements should be ignored
       
 31935 
       
 31936         Make sure that root-most <svg> elements do not take into account x/y.
       
 31937 
       
 31938         * ksvg2/svg/SVGSVGElement.cpp:
       
 31939         (WebCore::SVGSVGElement::viewport):
       
 31940         (WebCore::SVGSVGElement::getCTM):
       
 31941         (WebCore::SVGSVGElement::getScreenCTM):
       
 31942         * rendering/RenderSVGContainer.cpp:
       
 31943         (WebCore::RenderSVGContainer::calcViewport):
       
 31944 
       
 31945 2007-05-26  David Hyatt  <hyatt@apple.com>
       
 31946 
       
 31947         Fix for radar bug 5219562, PNG isn't displayed on SVG test suite.
       
 31948         Improve <object> error handling so that it recovers properly when
       
 31949         <td> is used inside it.
       
 31950 
       
 31951         Reviewed by olliej
       
 31952 
       
 31953         Added fast/invalid/td-inside-object.html
       
 31954 
       
 31955         * html/HTMLObjectElement.h:
       
 31956         (WebCore::HTMLObjectElement::tagPriority):
       
 31957         * html/HTMLParser.cpp:
       
 31958         (WebCore::HTMLParser::handleError):
       
 31959         * html/HTMLParserErrorCodes.cpp:
       
 31960         (WebCore::htmlParserErrorMessageTemplate):
       
 31961         * html/HTMLParserErrorCodes.h:
       
 31962 
       
 31963 2007-05-26  David Hyatt  <hyatt@apple.com>
       
 31964 
       
 31965         Don't compare the "isset" variables in background layers, since they
       
 31966         lead us to turn off the Aqua look incorrectly, even when the background
       
 31967         matches the default.
       
 31968 
       
 31969         Reviewed by olliej
       
 31970 
       
 31971         * rendering/RenderStyle.cpp:
       
 31972         (WebCore::BackgroundLayer::operator==):
       
 31973 
       
 31974 2007-05-26  David Hyatt  <hyatt@apple.com>
       
 31975 
       
 31976         Improve the </p> -> <p></p> error message to not spew two errors.
       
 31977         Fix a bug where errors reported inside document.write didn't get
       
 31978         reported as such because of a mistake in the notation of SegmentedString.
       
 31979 
       
 31980         Reviewed by aroben
       
 31981 
       
 31982         * html/HTMLParser.cpp:
       
 31983         (WebCore::HTMLParser::processCloseTag):
       
 31984         * platform/SegmentedString.h:
       
 31985         (WebCore::SegmentedSubstring::clear):
       
 31986 
       
 31987 2007-05-26  David Hyatt  <hyatt@apple.com>
       
 31988 
       
 31989         Fix for bug 13887, percentage height block not sized correctly inside
       
 31990         positioned percentage height containing block.
       
 31991 
       
 31992         Reviewed by mitz
       
 31993 
       
 31994         fast/block/positioning/complex-percentage-height.html
       
 31995 
       
 31996         * rendering/RenderBox.cpp:
       
 31997         (WebCore::RenderBox::calcPercentageHeight):
       
 31998 
       
 31999 2007-05-26  Mitz Pettel  <mitz@webkit.org>
       
 32000 
       
 32001         Reviewed by Oliver Hunt.
       
 32002 
       
 32003         - finish fixing http://bugs.webkit.org/show_bug.cgi?id=13871
       
 32004           Box shadow should not apply to Aqua-themed controls
       
 32005 
       
 32006         Covered by fast/forms/box-shadow-override.html
       
 32007 
       
 32008         I forgot to include adjustSliderThumbStyle in the previous patch and the
       
 32009         test didn't detect it because of a bug introduced in r21739.
       
 32010 
       
 32011         * rendering/RenderThemeMac.h:
       
 32012         * rendering/RenderThemeMac.mm:
       
 32013         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
       
 32014 
       
 32015 2007-05-26  Mitz Pettel  <mitz@webkit.org>
       
 32016 
       
 32017         Reviewed by Hyatt.
       
 32018 
       
 32019         - fix http://bugs.webkit.org/show_bug.cgi?id=13876
       
 32020           Box-Shadow disappears if shadow doesn't fit in the window size
       
 32021 
       
 32022         Tests: fast/repaint/box-shadow-h.html
       
 32023                fast/repaint/box-shadow-v.html
       
 32024 
       
 32025         * rendering/RenderTable.cpp:
       
 32026         (WebCore::RenderTable::layout):
       
 32027 
       
 32028 2007-05-26  Alexey Proskuryakov  <ap@webkit.org>
       
 32029 
       
 32030         Reviewed by Darin.
       
 32031 
       
 32032         http://bugs.webkit.org/show_bug.cgi?id=13605
       
 32033         REGRESSION: Browser crashes when switching Kotoeri input modes
       
 32034 
       
 32035         The problem could no longer be reproduced with Kotoeri thanks to
       
 32036         a fix in <http://trac.webkit.org/projects/webkit/changeset/21728>,
       
 32037         but we still need to protect from invalid ranges passed from
       
 32038         input methods.
       
 32039 
       
 32040         Test: editing/input/replace-invalid-range.html
       
 32041 
       
 32042         * page/mac/WebCoreFrameBridge.mm:
       
 32043         (-[WebCoreFrameBridge selectNSRange:]): Added a null check.
       
 32044 
       
 32045 2007-05-26  Darin Adler  <darin@apple.com>
       
 32046 
       
 32047         * platform/network/mac/ResourceResponseMac.mm:
       
 32048         (WebCore::ResourceResponse::doUpdateResourceResponse):
       
 32049         Alexey pointed out that I was wrong about object lifetime, so
       
 32050         rolling this change out.
       
 32051 
       
 32052 2007-05-26  Darin Adler  <darin@apple.com>
       
 32053 
       
 32054         Reviewed by Anders.
       
 32055 
       
 32056         * platform/network/mac/ResourceResponseMac.mm:
       
 32057         (WebCore::ResourceResponse::doUpdateResourceResponse):
       
 32058         Fixed code where a temporary String is used after destroyed.
       
 32059 
       
 32060 2007-05-26  Mitz Pettel  <mitz@webkit.org>
       
 32061 
       
 32062         Reviewed by Darin.
       
 32063 
       
 32064         - http://bugs.webkit.org/show_bug.cgi?id=13842
       
 32065           Simplify Color::light() and Color::dark()
       
 32066 
       
 32067         Not testable.
       
 32068 
       
 32069         * platform/graphics/Color.cpp:
       
 32070         (WebCore::Color::light):
       
 32071         (WebCore::Color::dark):
       
 32072 
       
 32073 2007-05-26  Mitz Pettel  <mitz@webkit.org>
       
 32074 
       
 32075         Reviewed by Darin.
       
 32076 
       
 32077         - fix http://bugs.webkit.org/show_bug.cgi?id=13870
       
 32078           RenderFrameSet should only allow frame and frameset children
       
 32079 
       
 32080         Covered by fast/frames/inline-object-inside-frameset.html
       
 32081 
       
 32082         * rendering/RenderFrame.h:
       
 32083         (WebCore::RenderFrame::isFrame): Added.
       
 32084         * rendering/RenderFrameSet.cpp:
       
 32085         (WebCore::RenderFrameSet::paint): Removed check for inline objects that is
       
 32086         no longer needed.
       
 32087         (WebCore::RenderFrameSet::isChildAllowed): Added. Allows the child only
       
 32088         if it is a frame or another frameset.
       
 32089         * rendering/RenderFrameSet.h:
       
 32090         * rendering/RenderObject.h:
       
 32091         (WebCore::RenderObject::isFrame): Added.
       
 32092 
       
 32093 2007-05-26  Mitz Pettel  <mitz@webkit.org>
       
 32094 
       
 32095         Reviewed by Darin.
       
 32096 
       
 32097         - http://bugs.webkit.org/show_bug.cgi?id=13871
       
 32098           Box shadow should not apply to Aqua-themed controls
       
 32099 
       
 32100         Test: fast/forms/box-shadow-override.html
       
 32101 
       
 32102         * rendering/RenderTheme.cpp:
       
 32103         (WebCore::RenderTheme::adjustCheckboxStyle):
       
 32104         (WebCore::RenderTheme::adjustRadioStyle):
       
 32105         * rendering/RenderThemeMac.h:
       
 32106         * rendering/RenderThemeMac.mm:
       
 32107         (WebCore::RenderThemeMac::adjustButtonStyle):
       
 32108         (WebCore::RenderThemeMac::adjustMenuListStyle):
       
 32109         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
       
 32110         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
       
 32111         (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
       
 32112         (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
       
 32113         (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
       
 32114         (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
       
 32115 
       
 32116 2007-05-26  Holger Freyther  <zecke@selfish.org>
       
 32117 
       
 32118         Reviewed by Anders.
       
 32119 
       
 32120         * platform/gdk/FrameGdk.cpp: Catch up to make it compile
       
 32121         (WebCore::FrameGdk::FrameGdk): The Settings is now owned by the Page
       
 32122 
       
 32123 2007-05-25  Sam Weinig  <sam@webkit.org>
       
 32124 
       
 32125         Reviewed by Oliver of the Hunt.
       
 32126 
       
 32127         Fixed <rdar://problem/5230247> at least 43 xhtml tests fail in 
       
 32128         Leopard because they are being interpreted as html
       
 32129 
       
 32130         Adds a work around for <rdar://problem/5230154> which explicitly
       
 32131         sets local .xhtml files to have the MIME type application/xhtml+xml.
       
 32132 
       
 32133         * platform/network/mac/ResourceResponseMac.mm:
       
 32134         (WebCore::ResourceResponse::doUpdateResourceResponse):
       
 32135 
       
 32136 2007-05-25  Geoffrey Garen  <ggaren@apple.com>
       
 32137 
       
 32138         Reviewed by Darin Adler.
       
 32139 
       
 32140         Fixed <rdar://problem/5055182> The page cache has no global cap.
       
 32141         
       
 32142         Beefed up the PageCache class to track which HistoryItems are 
       
 32143         cached, and decide how to evict old HistoryItems as new ones are
       
 32144         added.
       
 32145 
       
 32146         * history/BackForwardList.cpp: Removed support for managing the page cache
       
 32147         through the BackForwardList since this is deprecated in Mac's 
       
 32148         WebBackForwardList, and doesn't exist on other platforms.
       
 32149         
       
 32150         Added a Page* back pointer so that Mac WebBackForwardList can still support 
       
 32151         its deprecated API, using the new hotness. This isn't a big burden, since 
       
 32152         Page is responsible for calling BackForwardList::close upon destruction, 
       
 32153         anyway.
       
 32154 
       
 32155         * history/HistoryItem.cpp: Replaced CachedPage* with boolean that tells
       
 32156         you whether you're in the page cache. This prevents us from having more
       
 32157         than one persistent repository for cached pages.
       
 32158 
       
 32159         * history/PageCache.cpp: If you're playing along at home, this code is 
       
 32160         the reason for the patch.
       
 32161 
       
 32162         * loader/FrameLoader.cpp: If you're playing along at home, the minuses in
       
 32163         this file are the reason for the patch.
       
 32164         
       
 32165         Replaced call to FrameLoaderClient::loadedFromCachedPage with its one-line
       
 32166         implementation because WebCore calling itself through WebKit is uncivilized.
       
 32167 
       
 32168         * page/Settings.cpp: Added support for removing a Page's HistoryItems from
       
 32169         the page cache.
       
 32170 
       
 32171 2007-05-25  Mitz Pettel  <mitz@webkit.org>
       
 32172 
       
 32173         Reviewed by Darin.
       
 32174 
       
 32175         - fix http://bugs.webkit.org/show_bug.cgi?id=13869
       
 32176           Many leaks seen on buildbot after r21735
       
 32177 
       
 32178         - fix another regression from r21739: ::-webkit-slider-thumb style not
       
 32179           applied.
       
 32180 
       
 32181         Test: fast/forms/slider-thumb-stylability.html
       
 32182 
       
 32183         * rendering/RenderSlider.cpp:
       
 32184         (WebCore::RenderSlider::setStyle):
       
 32185         (WebCore::RenderSlider::createThumbStyle):
       
 32186 
       
 32187 2007-05-25  Justin Garcia  <justin.garcia@apple.com>
       
 32188 
       
 32189         Reviewed by Harrison.
       
 32190 
       
 32191         <rdar://problem/5228141> 
       
 32192         REGRESSION: Can't apply style to selection that ends after an image
       
 32193 
       
 32194         * editing/ApplyStyleCommand.cpp:
       
 32195         (WebCore::ApplyStyleCommand::applyInlineStyle):
       
 32196         Use range compliant equivalents when creating the Range
       
 32197         used to compute pastEndNode(), otherwise Range's constructor
       
 32198         ASSERTs and pastEndNode() returns null. Added a testcase.
       
 32199         If the incoming Range is collapsed at [br, 0], callers want
       
 32200         the style to be applied to the br, so expand the Range to include
       
 32201         it.  We got away without expanding before because pastEndNode
       
 32202         of a Range from [br, 0] to [br, 0] is the node after the br.
       
 32203         Using range compliant equivalents changed that. There's already
       
 32204         test coverage for this change.
       
 32205         Changed while loop termination for finding the end of a run 
       
 32206         so that we don't process pastEnd.  end.node() may now be 
       
 32207         non-atomic and we'd blow past it. There's already test
       
 32208         coverage for this change.
       
 32209 
       
 32210 2007-05-25  Beth Dakin  <bdakin@apple.com>
       
 32211 
       
 32212         Rubber stamped by Hyatt
       
 32213 
       
 32214         Adding an ASSERT for good measure.
       
 32215 
       
 32216         * page/FrameView.cpp:
       
 32217         (WebCore::FrameView::layout):
       
 32218 
       
 32219 2007-05-25  Kevin McCullough  <kmccullough@apple.com>
       
 32220  
       
 32221         Reviewed by Geoff.
       
 32222 
       
 32223         - <rdar://problem/5183523> REGRESSION: Excel: Worksheet tabs in spreadsheet saved as web page don't work 
       
 32224         - Change load to check the URL as well as the referrer since it is possilbe to have a referrer which limits a load even thought the URL would allow it.  There is a bug about how we need to re-evaluate the whole load architecture: <rdar://problem/5227992> Rethink canLoad() to have a consistent and comprehensive architecture.
       
 32225 
       
 32226         * loader/FrameLoader.cpp:
       
 32227         (WebCore::FrameLoader::loadSubframe):
       
 32228         (WebCore::FrameLoader::load):
       
 32229         (WebCore::FrameLoader::canLoad):
       
 32230         * loader/FrameLoader.h:
       
 32231 
       
 32232 2007-05-25  Anders Carlsson  <andersca@apple.com>
       
 32233 
       
 32234         Reviewed by Brady.
       
 32235 
       
 32236         <rdar://problem/5209536>
       
 32237         http://bugs.webkit.org/show_bug.cgi?id=13757
       
 32238         REGRESSION: Leaks seen on buildbot after r21497.
       
 32239         
       
 32240         Fix multipart data loading so it works like Tiger Safari. When one part of a multipart connection has been loaded,
       
 32241         move the subresource loader from the subresource loaders set and into a special multipart subresource loader set. This set 
       
 32242         is not considered when asking a document loader if it's currently loading. 
       
 32243                 
       
 32244         * loader/DocumentLoader.cpp:
       
 32245         (WebCore::DocumentLoader::stopLoading):
       
 32246         Always stop the multipart subresource loaders here.
       
 32247         
       
 32248         (WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart):
       
 32249         New function that moves the loader from m_subresourceLoaders to m_multipartSubresourceLoaders and updates the document loader's state.
       
 32250         
       
 32251         * loader/ProgressTracker.cpp:
       
 32252         (WebCore::ProgressTracker::incrementProgress):
       
 32253         If a progress item already exists, reuse it. This can happen in some rare circumstances when dealing with multipart data.
       
 32254         
       
 32255         * loader/SubresourceLoader.cpp:
       
 32256         (WebCore::SubresourceLoader::didReceiveResponse):
       
 32257         Call subresourceLoaderFinishedLoadingOnePart if the response is multipart.
       
 32258 
       
 32259 2007-05-25  Patti Hoa  <patti@apple.com>
       
 32260 
       
 32261         Reviewed by Tim Hatcher.
       
 32262 
       
 32263         <rdar://problem/4918397> Exception raise inspecting note contents in the background
       
 32264         
       
 32265         * bridge/mac/WebCoreAXObject.mm:
       
 32266         (-[WebCoreAXObject accessibilityDescription]):
       
 32267         Only allow asking the attachmentView for description if attachmentView supports this description attribute
       
 32268 
       
 32269 2007-05-25  Beth Dakin  <bdakin@apple.com>
       
 32270 
       
 32271         Reviewed by Oliver and Hyatt.
       
 32272 
       
 32273         Fix for <rdar://problem/5228363> REGRESSION: In Mail, attempting to 
       
 32274         create a To Do results in a crash
       
 32275 
       
 32276         This regressed with r21635. Now that -boundingBox updates layout if 
       
 32277         it is needed, we infinitely recurse when Mail draws a custom 
       
 32278         highlight. The fix is to put a guard around laying out the render 
       
 32279         tree.
       
 32280 
       
 32281         * page/FrameView.cpp:
       
 32282         (WebCore::FrameViewPrivate::reset):
       
 32283         (WebCore::FrameView::layout):
       
 32284 
       
 32285 2007-05-25  Patti Hoa <patti@apple.com>
       
 32286 
       
 32287         Reviewed by John Sullivan.
       
 32288         
       
 32289         <rdar://problem/5221986> selection in web areas doesn't seem to be working for text navigation
       
 32290         
       
 32291         * bridge/mac/WebCoreAXObject.mm:
       
 32292         (-[WebCoreAXObject accessibilityIsAttributeSettable:]):
       
 32293         Fixed up incorrect string comparison for AXSelectedTextMarkerRange ax attribute so 
       
 32294         this attribute can actually announce its settability. 
       
 32295 
       
 32296 2007-05-25  Darin Adler  <darin@apple.com>
       
 32297 
       
 32298         Reviewed by Alice.
       
 32299 
       
 32300         - fix <rdar://problem/5228048> REGRESSION: In a new Mail message, the caret isn't
       
 32301           immediately inserted when tabbing into or clicking in the message body
       
 32302 
       
 32303         This latent problem was uncovered by <http://trac.webkit.org/projects/webkit/changeset/21476>,
       
 32304         which removed some code that did extra work whenever setCaretVisible made the caret visible.
       
 32305 
       
 32306         * page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged): Call invalidateCaretRect
       
 32307         when turning the caret on. All other call sites that touched m_caretPaint were doing
       
 32308         this, but this was not.
       
 32309 
       
 32310 2007-05-25  Darin Adler  <darin@apple.com>
       
 32311 
       
 32312         Reviewed by Harrison.
       
 32313 
       
 32314         * DerivedSources.make: Tweaked spelling.
       
 32315 
       
 32316 2007-05-25  Mitz Pettel  <mitz@webkit.org>
       
 32317 
       
 32318         Reviewed by Darin.
       
 32319 
       
 32320         - fix http://bugs.webkit.org/show_bug.cgi?id=13872
       
 32321           REGRESSION: An empty search field can have a cancel button
       
 32322 
       
 32323         Test: fast/forms/search-cancel-button-style-sharing.html
       
 32324 
       
 32325         * rendering/RenderTextControl.cpp:
       
 32326         (WebCore::RenderTextControl::createCancelButtonStyle): Prevented sharing of
       
 32327         the cancel button style between search fields that share style, because
       
 32328         each search field mutates the style to show and hide the cancel button.
       
 32329 
       
 32330 2007-05-25  David Harrison  <harrison@apple.com>
       
 32331 
       
 32332         Reviewed by Kevin and Geoff.
       
 32333 
       
 32334         * DerivedSources.make:
       
 32335         Add an inclusion guard for CSSGrammar.h and XPathGrammar.h, because older versions of bison do not
       
 32336         
       
 32337         * css/maketokenizer:
       
 32338         Unconditionally define the flex basic types that are not part of newer versions of flex. Was
       
 32339         only needed on Linux. Now needed on Mac OS 10.5, and is OK to do on 10.4.9.
       
 32340 
       
 32341 2007-05-25  Geoffrey Garen  <ggaren@apple.com>
       
 32342 
       
 32343         Reviewed by Darin Adler.
       
 32344         
       
 32345         Moved JavaScriptCore-related pending public API to public API.
       
 32346 
       
 32347         Moved -JSObject
       
 32348 
       
 32349         * bindings/objc/WebScriptObjectPendingPublic.h: from here
       
 32350         * bindings/objc/WebScriptObject.h: to here
       
 32351         * bindings/objc/WebScriptObject.mm: and out of its temporary category
       
 32352 
       
 32353 2007-05-25  Mitz Pettel  <mitz@webkit.org>
       
 32354 
       
 32355         Reviewed by Darin.
       
 32356 
       
 32357         - fix http://bugs.webkit.org/show_bug.cgi?id=13767
       
 32358           REGRESSION: Multipart image documents are garbled
       
 32359 
       
 32360         Test: http/tests/multipart/invalid-image-data-standalone.html
       
 32361 
       
 32362         * loader/DocumentLoader.cpp:
       
 32363         (WebCore::DocumentLoader::isLoadingMultipartContent): Added.
       
 32364         * loader/DocumentLoader.h:
       
 32365         * loader/ImageDocument.cpp:
       
 32366         (WebCore::ImageTokenizer::finish): If the image is multipart, make a copy
       
 32367         of the current part instead of using the resource data, which is going to be
       
 32368         overwritten by the next part.
       
 32369         * loader/MainResourceLoader.h:
       
 32370         (WebCore::MainResourceLoader::isLoadingMultipartContent): Added.
       
 32371 
       
 32372 2007-05-25  Anders Carlsson  <andersca@apple.com>
       
 32373 
       
 32374         Fix no-svg build.
       
 32375         
       
 32376         * bindings/js/kjs_html.cpp:
       
 32377         (KJS::HTMLElementFunction::callAsFunction):
       
 32378 
       
 32379 2007-05-25  Anders Carlsson  <andersca@apple.com>
       
 32380 
       
 32381         Reviewed by Mitz.
       
 32382 
       
 32383         <rdar://problem/5226788> After resizing the window larger than the image, hovering over the image still shows magnify glass
       
 32384         
       
 32385         One part of the bug was already fixed by my previous commit. This fixes the case where the window is sized so the image fit
       
 32386         after it has been zoomed in.
       
 32387         
       
 32388         * loader/ImageDocument.cpp:
       
 32389         (WebCore::ImageDocument::windowSizeChanged):
       
 32390 
       
 32391 2007-05-25  John Sullivan  <sullivan@apple.com>
       
 32392 
       
 32393         Reviewed by Anders and Tim
       
 32394 
       
 32395         - WebCore change for: 
       
 32396           <rdar://problem/5226000> REGRESSION: In Gmail and Mail, a hang occurs when attempting to grammar/spellcheck a word in a reply 
       
 32397 
       
 32398         * editing/Editor.cpp:
       
 32399         (WebCore::findFirstBadGrammarInRange):
       
 32400         Use the more obvious way to check whether a range is empty. In this case the more obvious way
       
 32401         would also have caused no problem to occur. Also added an assertion. Though this change is
       
 32402         enough to fix the symptom of the bug, the real fix is in WebKit.
       
 32403 
       
 32404 2007-05-25  Anders Carlsson  <andersca@apple.com>
       
 32405 
       
 32406         Reviewed by Darin (Sorta).
       
 32407 
       
 32408         * loader/ImageDocument.cpp:
       
 32409         (WebCore::ImageDocument::restoreImageSize):
       
 32410         Use removeProperty here.
       
 32411 
       
 32412 2007-05-25  Geoffrey Garen  <ggaren@apple.com>
       
 32413 
       
 32414         Reviewed by Darin Adler.
       
 32415 
       
 32416         Some cleanup to Cache while Fixing <rdar://problem/5055182> The page cache 
       
 32417         has no global cap.
       
 32418         
       
 32419         * loader/Cache.cpp: Removed destructor to help identify this class as a
       
 32420         singleton.
       
 32421 
       
 32422         * loader/Cache.h: Made constructor and destructor private to match the
       
 32423         singleton model of PageCache.
       
 32424         
       
 32425         Put structs related to Cache inside its declaration to fix some namespace
       
 32426         conflicts I had while writing my patch. (They don't exist anymore, but
       
 32427         I figured this might help future development.)
       
 32428 
       
 32429 2007-05-24  Geoffrey Garen  <ggaren@apple.com>
       
 32430 
       
 32431         Reviewed by Darin Adler.
       
 32432 
       
 32433         Fixed a bug with Settings where a number of different objects held bare 
       
 32434         Settings* data members, even though the Page owns the Settings object and 
       
 32435         deletes it upon destruction.
       
 32436 
       
 32437         Added NULL checks since the Page can be deleted before the frame/document.
       
 32438 
       
 32439         * page/Settings.cpp: Removed reliance on setNeedsReapplyStylesForSettingsChange.
       
 32440 
       
 32441         * css/cssstyleselector.cpp: CSSStyleSelector was the worst offender. It 
       
 32442         held a number of back pointers that were not guaranteed. I removed the 
       
 32443         Settings*, Frame*, and FrameView* back pointers, but others could probably 
       
 32444         go, too. I replaced them with a single Document* pointer, which is guaranteed
       
 32445         because the Document owns the CSSStyleSelector.
       
 32446 
       
 32447         * page/Page.cpp: Removed setNeedsReapplyStylesForSettingsChange -- the 
       
 32448         Settings object is now a proper subcontroller of Page, so it doesn't need
       
 32449         to use a global table to find its page anymore. Also, this function
       
 32450         confusingly implied that the Frames in a page can have heterogeneous settings,
       
 32451         which is not true.
       
 32452 
       
 32453 2007-05-25  David Hyatt  <hyatt@apple.com>
       
 32454 
       
 32455         Make sure -webkit-border-fit accounts for padding as well as border.
       
 32456 
       
 32457         Reviewed by aroben
       
 32458 
       
 32459         * rendering/RenderBlock.cpp:
       
 32460         (WebCore::RenderBlock::borderFitAdjust):
       
 32461 
       
 32462 2007-05-25  David Hyatt  <hyatt@apple.com>
       
 32463 
       
 32464         Rework line numbering (again).  This time I finally think I have
       
 32465         it right for all the document.write insanity that can occur.
       
 32466 
       
 32467         Reviewed by aroben
       
 32468 
       
 32469         * html/HTMLParser.cpp:
       
 32470         (WebCore::HTMLParser::reportErrorToConsole):
       
 32471         * html/HTMLParserErrorCodes.cpp:
       
 32472         (WebCore::htmlParserDocumentWriteMessage):
       
 32473         * html/HTMLParserErrorCodes.h:
       
 32474         * html/HTMLTokenizer.cpp:
       
 32475         (WebCore::HTMLTokenizer::write):
       
 32476         * html/HTMLTokenizer.h:
       
 32477         (WebCore::HTMLTokenizer::lineNumberPtr):
       
 32478         (WebCore::HTMLTokenizer::processingContentWrittenByScript):
       
 32479         * platform/SegementedSring.cpp
       
 32480         (WebCore::SegmentedString::setExcludeLineNumbers):
       
 32481         * platform/SegmentedString.h:
       
 32482         (WebCore::SegmentedSubstring::SegmentedSubstring):
       
 32483         (WebCore::SegmentedSubstring::clear):
       
 32484         (WebCore::SegmentedSubstring::excludeLineNumbers):
       
 32485         (WebCore::SegmentedSubstring::setExcludeLineNumbers):
       
 32486         (WebCore::SegmentedString::excludeLineNumbers):
       
 32487         (WebCore::SegmentedString::advance):
       
 32488 
       
 32489 2007-05-24  Geoffrey Garen  <ggaren@apple.com>
       
 32490 
       
 32491         Reviewed by Adam Roben.
       
 32492 
       
 32493         Added a debug-only CachedPage counter. This helped me track down an SVG 
       
 32494         timer bug in my recent page cache work.
       
 32495                 
       
 32496         * history/CachedPage.cpp:
       
 32497 
       
 32498 2007-05-24  David Hyatt  <hyatt@apple.com>
       
 32499 
       
 32500         Improve <form> error reporting to catch <form>s inside table parts.
       
 32501         Tweak the wording of some of the error messages to be a bit better.
       
 32502 
       
 32503         Reviewed by olliej
       
 32504 
       
 32505         * html/HTMLParser.cpp:
       
 32506         (WebCore::HTMLParser::insertNode):
       
 32507         (WebCore::HTMLParser::processCloseTag):
       
 32508         (WebCore::HTMLParser::popBlock):
       
 32509         * html/HTMLParserErrorCodes.cpp:
       
 32510         (WebCore::htmlParserErrorMessageTemplate):
       
 32511         * html/HTMLParserErrorCodes.h:
       
 32512 
       
 32513 2007-05-24  Rob Buis  <buis@kde.org>
       
 32514 
       
 32515         Reviewed by Hyatt.
       
 32516 
       
 32517         http://bugs.webkit.org/show_bug.cgi?id=4104
       
 32518         first-letter not updating style with hover
       
 32519         http://bugs.webkit.org/show_bug.cgi?id=13169
       
 32520         css-formatted first letter won't hide dynamically
       
 32521 
       
 32522         Update first letter when RenderBlock::setStyle is called. 
       
 32523 
       
 32524         * css/cssstyleselector.cpp:
       
 32525         (WebCore::CSSStyleSelector::checkOneSelector):
       
 32526         * dom/Document.cpp:
       
 32527         (WebCore::Document::Document):
       
 32528         (WebCore::Document::createElement):
       
 32529         * dom/Document.h:
       
 32530         (WebCore::Document::usesFirstLetterRules):
       
 32531         (WebCore::Document::setUsesFirstLetterRules):
       
 32532         * rendering/RenderBlock.cpp:
       
 32533         (WebCore::RenderBlock::setStyle):
       
 32534         (WebCore::RenderBlock::updateFirstLetter):
       
 32535 
       
 32536 2007-05-24  Mitz Pettel  <mitz@webkit.org>
       
 32537 
       
 32538         Reviewed by Darin.
       
 32539 
       
 32540         - fix http://bugs.webkit.org/show_bug.cgi?id=13800
       
 32541           REGRESSION: Moving a slider moves another unrelated slider
       
 32542 
       
 32543         Test: fast/forms/slider-thumb-shared-style.html
       
 32544 
       
 32545         RenderSlider mutates the thumb's style, therefore it must not be shared
       
 32546         with another slider's thumb, a situation that could occur if the sliders
       
 32547         themselves shared style.
       
 32548 
       
 32549         * rendering/RenderSlider.cpp:
       
 32550         (WebCore::RenderSlider::createThumbStyle): Always use a private copy for
       
 32551         the thumb style.
       
 32552 
       
 32553 2007-05-24  Adele Peterson  <adele@apple.com>
       
 32554 
       
 32555         Reviewed by Darin.
       
 32556 
       
 32557         Fix for <rdar://problem/5211921> Form values sometimes get transposed (iGoogle)
       
 32558 
       
 32559         Test: fast/history/redirect-load-no-form-restoration.html
       
 32560 
       
 32561         * history/HistoryItem.cpp:
       
 32562         (WebCore::HistoryItem::setURL): Clear the document state when the url changes for a HistoryItem.
       
 32563         (WebCore::HistoryItem::isCurrentDocument): Added. Compares the HistoryItem url to the document's url.  This might not be the best way to do this, but it works for now.
       
 32564         * history/HistoryItem.h:
       
 32565         * loader/FrameLoader.cpp: (WebCore::FrameLoader::saveDocumentState): Only set the document (and form) state if the document is current for the history item.
       
 32566 
       
 32567 2007-05-24  Mitz Pettel  <mitz@webkit.org>
       
 32568 
       
 32569         Reviewed by Adele.
       
 32570 
       
 32571         - fix http://bugs.webkit.org/show_bug.cgi?id=13857
       
 32572           REGRESSION: onChange function applied to select element executes twice when focus is set
       
 32573 
       
 32574         Test: fast/forms/select-double-onchange.html
       
 32575 
       
 32576         * html/HTMLSelectElement.cpp:
       
 32577         (WebCore::HTMLSelectElement::menuListOnChange): Changed to update m_lastOnChangeIndex
       
 32578         before dispatching the change event to avoid reentrancy.
       
 32579 
       
 32580 2007-05-24  Darin Adler  <darin@apple.com>
       
 32581 
       
 32582         Reviewed by Hyatt.
       
 32583 
       
 32584         - fix <rdar://problem/5226451> REGRESSION (21618): Mail block quotes
       
 32585           are missing the lines on the side
       
 32586 
       
 32587         This patch fixes three problems:
       
 32588 
       
 32589         1) makes the "skip canLoad check" boolean also skip the check
       
 32590            that prevents any loads while the document is in provisional
       
 32591            state; this is the proximate cause of the bug
       
 32592 
       
 32593         * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
       
 32594         Don't check the frame's state if skipCanLoadCheck is true.
       
 32595 
       
 32596         2) moves the "skip canLoad check" boolean to the Request object;
       
 32597            the old implementation would cause that flag to affect the
       
 32598            new request we served, which might not be the resource with
       
 32599            that flag set
       
 32600 
       
 32601         3) fixes error-handling code path that would leak requests
       
 32602 
       
 32603         * html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
       
 32604         Pass false to the CachedImage constructor to indicate we are not making
       
 32605         this object for the cache.
       
 32606 
       
 32607         * loader/Cache.cpp:
       
 32608         (WebCore::createResource): Pass true to the CachedImage constructor to
       
 32609         indicate we are making this object for the cache.
       
 32610         (WebCore::Cache::requestResource): Add new code that assumes the object
       
 32611         will already have the inCache bit set, and that will delete the object
       
 32612         and return 0 if the cache is disabled and the load failed.
       
 32613 
       
 32614         * loader/CachedImage.h:
       
 32615         * loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage):
       
 32616         Added a forCache boolean parameter. Always false for the constructor
       
 32617         that's only used outside the cache code, and passed in as a boolean
       
 32618         for the constructor that's used both in cache and outside cache.
       
 32619 
       
 32620         * loader/CachedResource.h:
       
 32621         * loader/CachedResource.cpp:
       
 32622         (WebCore::CachedResource::CachedResource): Added a forCache boolean
       
 32623         parameter that determines the initial state of the m_inCache flag.
       
 32624         This is needed to prevent a resource from being destroyed if an
       
 32625         error occurs during the initial load.
       
 32626 
       
 32627         * loader/DocLoader.cpp:
       
 32628         (WebCore::DocLoader::requestCSSStyleSheet): Added FIXME.
       
 32629         (WebCore::DocLoader::setLoadInProgress): Added null check.
       
 32630 
       
 32631         * loader/Request.h:
       
 32632         * loader/Request.cpp: (WebCore::Request::Request):
       
 32633         Added a shouldSkipCanLoadCheck boolean here, since we need to track
       
 32634         this for each request.
       
 32635 
       
 32636         * loader/loader.h:
       
 32637         * loader/loader.cpp:
       
 32638         (WebCore::Loader::load): Pass the skipCanLoadCheck boolean to the
       
 32639         Request constructor rather than to the servePendingRequests function.
       
 32640         (WebCore::Loader::servePendingRequests): Add a loop so we can handle
       
 32641         cases where the request fails immediately without leaking the request
       
 32642         and thinking that we're loading forever.
       
 32643 
       
 32644 2007-05-24  David Hyatt  <hyatt@apple.com>
       
 32645 
       
 32646         Add error reporting for residual style.
       
 32647 
       
 32648         Reviewed by aroben
       
 32649 
       
 32650         * html/HTMLParser.cpp:
       
 32651         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
       
 32652         (WebCore::HTMLParser::reopenResidualStyleTags):
       
 32653         * html/HTMLParserErrorCodes.cpp:
       
 32654         (WebCore::htmlParserErrorMessageTemplate):
       
 32655         * html/HTMLParserErrorCodes.h:
       
 32656 
       
 32657 2007-05-24  David Hyatt  <hyatt@apple.com>
       
 32658 
       
 32659         Report <script/> as a warning instead of an error for now, since we
       
 32660         actually do close it.  (Sigh.)
       
 32661 
       
 32662         Reviewed by beth
       
 32663 
       
 32664         * html/HTMLParser.cpp:
       
 32665         (WebCore::HTMLParser::parseToken):
       
 32666         (WebCore::HTMLParser::reportErrorToConsole):
       
 32667         * html/HTMLParserErrorCodes.cpp:
       
 32668         (WebCore::htmlParserErrorMessageTemplate):
       
 32669         (WebCore::isWarning):
       
 32670         * html/HTMLParserErrorCodes.h:
       
 32671 
       
 32672 2007-05-24  David Hyatt  <hyatt@apple.com>
       
 32673 
       
 32674         Add error reporting for the </p> -> <p></p> quirk.
       
 32675 
       
 32676         Add error reporting when a stray close tag is encountered with no
       
 32677         corresponding open tag.
       
 32678 
       
 32679         Reviewed by adele
       
 32680 
       
 32681         * html/HTMLParser.cpp:
       
 32682         (WebCore::HTMLParser::HTMLParser):
       
 32683         (WebCore::HTMLParser::processCloseTag):
       
 32684         (WebCore::HTMLParser::popBlock):
       
 32685         * html/HTMLParser.h:
       
 32686         (WebCore::HTMLParser::popBlock):
       
 32687         * html/HTMLParserErrorCodes.cpp:
       
 32688         (WebCore::htmlParserErrorMessageTemplate):
       
 32689         * html/HTMLParserErrorCodes.h:
       
 32690 
       
 32691 2007-05-24  Kevin McCullough  <kmccullough@apple.com>
       
 32692 
       
 32693         Reviewed by.
       
 32694 
       
 32695         - Rolling back change to fix the build until I have a good fix for data: urls.
       
 32696 
       
 32697         * ChangeLog:
       
 32698         * loader/FrameLoader.cpp:
       
 32699         (WebCore::FrameLoader::load):
       
 32700         (WebCore::FrameLoader::open):
       
 32701         * platform/String.cpp:
       
 32702 
       
 32703 2007-05-24  David Hyatt  <hyatt@apple.com>
       
 32704 
       
 32705         Add two more error messages to the HTMLParser.
       
 32706 
       
 32707         Report when the </br> -> <br> quirk is triggered.
       
 32708 
       
 32709         Also report whenever the broken XML self-closing tag syntax is used on
       
 32710         tags that can actually have an end tag (either optional or required).
       
 32711 
       
 32712         Reviewed by aroben
       
 32713 
       
 32714         * html/HTMLParser.cpp:
       
 32715         (WebCore::HTMLParser::parseToken):
       
 32716         * html/HTMLParserErrorCodes.cpp:
       
 32717         (WebCore::htmlParserErrorMessageTemplate):
       
 32718         * html/HTMLParserErrorCodes.h:
       
 32719         (WebCore::):
       
 32720         * html/HTMLTokenizer.cpp:
       
 32721         (WebCore::HTMLTokenizer::parseTag):
       
 32722         * html/HTMLTokenizer.h:
       
 32723         (WebCore::Token::reset):
       
 32724 
       
 32725 2007-05-24  Sam Weinig  <sam@webkit.org>
       
 32726 
       
 32727         Reviewed by Anders.
       
 32728 
       
 32729         Rename JSHTMLFrameSetCustom.cpp to JSHTMLFrameSetElementCustom.cpp
       
 32730         for consistency.
       
 32731 
       
 32732         * WebCore.xcodeproj/project.pbxproj:
       
 32733         * bindings/js/JSHTMLFrameSetCustom.cpp: Removed.
       
 32734         * bindings/js/JSHTMLFrameSetElementCustom.cpp: Added.
       
 32735 
       
 32736 2007-05-24  David Hyatt  <hyatt@apple.com>
       
 32737 
       
 32738         Fix for <rdar://problem/5208440> (13753)
       
 32739 
       
 32740         REGRESSION: Raw text needs to be pulled outside of tables
       
 32741 
       
 32742         Reviewed by aroben
       
 32743 
       
 32744         * html/HTMLParser.cpp:
       
 32745         (WebCore::HTMLParser::handleError):
       
 32746         * html/HTMLTableColElement.cpp:
       
 32747         (WebCore::HTMLTableColElement::checkDTD):
       
 32748         * html/HTMLTableElement.cpp:
       
 32749         (WebCore::HTMLTableElement::checkDTD):
       
 32750         * html/HTMLTableRowElement.cpp:
       
 32751         (WebCore::HTMLTableRowElement::checkDTD):
       
 32752         * html/HTMLTableSectionElement.cpp:
       
 32753         (WebCore::HTMLTableSectionElement::checkDTD):
       
 32754 
       
 32755 2007-05-24  Mitz Pettel  <mitz@webkit.org>
       
 32756 
       
 32757         Reviewed by Darin.
       
 32758 
       
 32759         - fix http://bugs.webkit.org/show_bug.cgi?id=13837
       
 32760           Separator in new <select> widget disappears when block element with border is in document.
       
 32761 
       
 32762         Test: fast/forms/menulist-separator-painting.html
       
 32763 
       
 32764         * platform/graphics/cg/GraphicsContextCG.cpp:
       
 32765         (WebCore::GraphicsContext::drawConvexPolygon): Changed this function to
       
 32766         actually do both filling and stroking when needed, even though all existing
       
 32767         callers set the stroke to none.
       
 32768         * rendering/RenderThemeMac.mm:
       
 32769         (WebCore::RenderThemeMac::paintMenuListButton): Added calls to set the stroke
       
 32770         style and thickness when painting the arrows and the separator.
       
 32771 
       
 32772 2007-05-24  Timothy Hatcher  <timothy@apple.com>
       
 32773 
       
 32774         Reviewed by Sam Weinig.
       
 32775 
       
 32776         Remove the OBJC_NEW_PROPERTIES #ifdef and only export the new @property syntax.
       
 32777 
       
 32778         * bindings/objc/DOMObject.h:
       
 32779         * bindings/scripts/CodeGeneratorObjC.pm:
       
 32780 
       
 32781 2007-05-24  Sam Weinig  <sam@webkit.org>
       
 32782 
       
 32783         Reviewed by Anders.
       
 32784 
       
 32785         Uncomment HTMLFramesSetElement constructor now that it exists.
       
 32786 
       
 32787         * page/DOMWindow.idl:
       
 32788 
       
 32789 2007-05-24  Anders Carlsson  <andersca@apple.com>
       
 32790 
       
 32791         Try fixing the buildbot build.
       
 32792         
       
 32793         * loader/ImageDocument.cpp:
       
 32794         (WebCore::ImageDocument::resizeImageToFit):
       
 32795         (WebCore::ImageDocument::imageClicked):
       
 32796 
       
 32797 2007-05-24  Sam Weinig  <sam@webkit.org>
       
 32798 
       
 32799         Reviewed by Darin.
       
 32800 
       
 32801         Patch for http://bugs.webkit.org/show_bug.cgi?id=13853
       
 32802         Autogenerate the JS bindings for the HTMLFrameSetElement
       
 32803 
       
 32804         * DerivedSources.make:
       
 32805         * WebCore.pro:
       
 32806         * WebCore.xcodeproj/project.pbxproj:
       
 32807         * bindings/js/JSHTMLElementWrapperFactory.cpp:
       
 32808         * bindings/js/JSHTMLFrameSetCustom.cpp: Added.
       
 32809         (WebCore::JSHTMLFrameSetElement::canGetItemsForName):
       
 32810         (WebCore::JSHTMLFrameSetElement::nameGetter):
       
 32811         * bindings/js/kjs_html.cpp:
       
 32812         (KJS::):
       
 32813         (KJS::JSHTMLElement::classInfo):
       
 32814         (KJS::JSHTMLElement::accessors):
       
 32815         (KJS::JSHTMLElement::getOwnPropertySlot):
       
 32816         * bindings/js/kjs_html.h:
       
 32817         (KJS::JSHTMLElement::):
       
 32818         * html/HTMLFrameSetElement.idl:
       
 32819 
       
 32820 2007-05-24  Zack Rusin  <zrusin@trolltech.com>
       
 32821 
       
 32822         Reviewed by andersca
       
 32823 
       
 32824         Fixing check for incorrent font size - it should
       
 32825         check fixed not normal.
       
 32826 
       
 32827         * page/Settings.cpp:
       
 32828         (WebCore::Settings::setDefaultFixedFontSize):
       
 32829 
       
 32830 2007-05-24  Mitz Pettel  <mitz@webkit.org>
       
 32831 
       
 32832         Speculative buildbot build fix.
       
 32833 
       
 32834         * css/cssstyleselector.cpp:
       
 32835         (WebCore::CSSStyleSelector::applyProperty):
       
 32836 
       
 32837 2007-05-24  Adam Roben  <aroben@apple.com>
       
 32838 
       
 32839         Made Chrome::addMessageToConsole more flexible
       
 32840 
       
 32841         addMessageToConsole now takes two additional parameters to specify the
       
 32842         message source (HTML, JS, CSS, XML) and level (error, warning, log). To
       
 32843         maintain our old behavior, all current messages were given
       
 32844         JSMessageSource and ErrorMessageLevel parameters. Messages matching
       
 32845         these characteristics are passed up to the ChromeClient.
       
 32846 
       
 32847         Reviewed by Hyatt.
       
 32848 
       
 32849         * bindings/js/JSCustomXPathNSResolver.cpp:
       
 32850         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
       
 32851         * bindings/js/kjs_events.cpp:
       
 32852         (KJS::JSAbstractEventListener::handleEvent):
       
 32853         * bindings/js/kjs_proxy.cpp:
       
 32854         (WebCore::KJSProxy::evaluate):
       
 32855         * bindings/js/kjs_window.cpp:
       
 32856         (KJS::Window::isSafeScript):
       
 32857         (KJS::ScheduledAction::execute):
       
 32858         * html/HTMLParser.cpp:
       
 32859         (WebCore::HTMLParser::reportErrorToConsole):
       
 32860         * ksvg2/misc/SVGDocumentExtensions.cpp:
       
 32861         (WebCore::SVGDocumentExtensions::reportWarning):
       
 32862         (WebCore::SVGDocumentExtensions::reportError):
       
 32863         * loader/FrameLoader.cpp:
       
 32864         (WebCore::FrameLoader::reportLocalLoadFailed):
       
 32865         * page/Chrome.cpp:
       
 32866         (WebCore::Chrome::addMessageToConsole):
       
 32867         * page/Chrome.h:
       
 32868         (WebCore::):
       
 32869         * xml/xmlhttprequest.cpp:
       
 32870         (WebCore::XMLHttpRequest::setRequestHeader):
       
 32871 
       
 32872 2007-05-24  David Hyatt  <hyatt@apple.com>
       
 32873 
       
 32874         Rework how HTML handles line numbering so that it is not fooled by
       
 32875         \r without a following \n and so that document.write doesn't lead
       
 32876         to line numbering confusion.
       
 32877 
       
 32878         Reviewed by aroben
       
 32879 
       
 32880         * html/HTMLParser.cpp:
       
 32881         (WebCore::HTMLParser::reportErrorToConsole):
       
 32882         * html/HTMLTokenizer.cpp:
       
 32883         (WebCore::HTMLTokenizer::processListing):
       
 32884         (WebCore::HTMLTokenizer::parseSpecial):
       
 32885         (WebCore::HTMLTokenizer::parseComment):
       
 32886         (WebCore::HTMLTokenizer::parseServer):
       
 32887         (WebCore::HTMLTokenizer::parseProcessingInstruction):
       
 32888         (WebCore::HTMLTokenizer::parseText):
       
 32889         (WebCore::HTMLTokenizer::parseEntity):
       
 32890         (WebCore::HTMLTokenizer::parseTag):
       
 32891         (WebCore::HTMLTokenizer::write):
       
 32892         (WebCore::HTMLTokenizer::processToken):
       
 32893         (WebCore::HTMLTokenizer::setSrc):
       
 32894         * html/HTMLTokenizer.h:
       
 32895         (WebCore::HTMLTokenizer::lineNumberPtr):
       
 32896         * html/HTMLViewSourceDocument.cpp:
       
 32897         (WebCore::HTMLViewSourceDocument::addLine):
       
 32898         * loader/TextDocument.cpp:
       
 32899         (WebCore::TextTokenizer::write):
       
 32900         * platform/SegmentedString.cpp:
       
 32901         (WebCore::SegmentedString::SegmentedString):
       
 32902         (WebCore::SegmentedString::operator=):
       
 32903         (WebCore::SegmentedString::clear):
       
 32904         * platform/SegmentedString.h:
       
 32905         (WebCore::SegmentedString::SegmentedString):
       
 32906         (WebCore::SegmentedString::advance):
       
 32907         (WebCore::SegmentedString::escaped):
       
 32908 
       
 32909 2007-05-23  David Hyatt  <hyatt@apple.com>
       
 32910 
       
 32911         Make the delete/InsertRows/Cells methods as well as the rowIndex method
       
 32912         able to work properly even when whitespace or comment nodes are present.
       
 32913 
       
 32914         Reviewed by aroben
       
 32915 
       
 32916         fast/table/rowindex-comment-nodes.html
       
 32917 
       
 32918         * html/HTMLTableRowElement.cpp:
       
 32919         (WebCore::HTMLTableRowElement::rowIndex):
       
 32920         (WebCore::HTMLTableRowElement::insertCell):
       
 32921         (WebCore::HTMLTableRowElement::deleteCell):
       
 32922         * html/HTMLTableSectionElement.cpp:
       
 32923         (WebCore::HTMLTableSectionElement::insertRow):
       
 32924         (WebCore::HTMLTableSectionElement::deleteRow):
       
 32925 
       
 32926 2007-05-23  David Hyatt  <hyatt@apple.com>
       
 32927 
       
 32928         <optgroup> should allow <script> and text nodes inside it, just like
       
 32929         <select> does.
       
 32930 
       
 32931         Reviewed by aroben
       
 32932 
       
 32933         fast/forms/stuff-on-my-optgroup.html
       
 32934 
       
 32935         * html/HTMLOptGroupElement.cpp:
       
 32936         (WebCore::HTMLOptGroupElement::checkDTD):
       
 32937         * html/HTMLSelectElement.cpp:
       
 32938         (WebCore::HTMLSelectElement::checkDTD):
       
 32939 
       
 32940 2007-05-23  David Hyatt  <hyatt@apple.com>
       
 32941 
       
 32942         Framesets should allow whitespace text nodes as children.
       
 32943 
       
 32944         Reviewed by aroben
       
 32945 
       
 32946         * html/HTMLFrameSetElement.cpp:
       
 32947         (WebCore::HTMLFrameSetElement::checkDTD):
       
 32948 
       
 32949 2007-05-24  Mark Rowe  <mrowe@apple.com>
       
 32950 
       
 32951         Fix the Qt build after r21685.
       
 32952 
       
 32953         * platform/qt/CursorQt.cpp:
       
 32954         (WebCore::notAllowedCursor):
       
 32955         (WebCore::zoomInCursor):
       
 32956         (WebCore::zoomOutCursor):
       
 32957 
       
 32958 2007-05-23  Alp Toker  <alp.toker@collabora.co.uk>
       
 32959 
       
 32960         Reviewed by Adam.
       
 32961 
       
 32962         Fix the gdk build following changes in r21685.
       
 32963 
       
 32964         * platform/gdk/CursorGdk.cpp:
       
 32965         (WebCore::zoomInCursor):
       
 32966         (WebCore::zoomOutCursor):
       
 32967 
       
 32968 2007-05-23  David Hyatt  <hyatt@apple.com>
       
 32969 
       
 32970         Fix for <rdar://problem/5222611> REGRESSION: Paint ordering problems at
       
 32971         http://buymeasoda.com/dev/issues/image_onload/image_onload.html
       
 32972 
       
 32973         Clamp z-index so that values that exceed maxint (or that are below minint)
       
 32974         are clamped to those values.
       
 32975 
       
 32976         Reviewed by darin
       
 32977 
       
 32978         * css/cssstyleselector.cpp:
       
 32979         (WebCore::CSSStyleSelector::applyProperty):
       
 32980 
       
 32981 2007-05-23  Mitz Pettel  <mitz@webkit.org>
       
 32982 
       
 32983         Reviewed by David Hyatt.
       
 32984 
       
 32985         - fix http://bugs.webkit.org/show_bug.cgi?id=13563
       
 32986           REGRESSION: Crash loading message in Yahoo! Mail
       
 32987 
       
 32988         Tests: fast/css/stale-style-selector-crash-1.html
       
 32989                fast/css/stale-style-selector-crash-2.html
       
 32990 
       
 32991         * dom/Document.cpp:
       
 32992         (WebCore::Document::Document): Initialize the m_didCalculateStyleSelector
       
 32993         flag to 'false'.
       
 32994         (WebCore::Document::updateStyleSelector): Do not bail out if we have ever
       
 32995         calculated a non-trivial style selector, even if at the moment we are
       
 32996         pending style sheets. We could have calculated a non-trivial selector
       
 32997         already either because at some point there were no pending style sheets
       
 32998         (so the currently pending ones were added dynamically) or because we were
       
 32999         forced to do a layout ignoring pending style sheets. Either way, once
       
 33000         there is a style selector, we need to keep it up to date, otherwise we can
       
 33001         crash under recalcStyle() during updateRendering() or simply not recalculate
       
 33002         style correctly for dynamic changes.
       
 33003         (WebCore::Document::recalcStyleSelector): Set m_didCalculateStyleSelector
       
 33004         to 'true' when creating a new style selector.
       
 33005         * dom/Document.h:
       
 33006 
       
 33007 2007-05-23  Anders Carlsson  <andersca@apple.com>
       
 33008 
       
 33009         Reviewed by Adam.
       
 33010 
       
 33011         <rdar://problem/5224749> Show a zoom/unzoom cursor for resizable image documents
       
 33012         
       
 33013         * WebCore.xcodeproj/project.pbxproj:
       
 33014         Install the zoom cursors.
       
 33015         
       
 33016         * loader/ImageDocument.cpp:
       
 33017         (WebCore::ImageDocument::resizeImageToFit):
       
 33018         Set the cursor to the zoom in cursor.
       
 33019         
       
 33020         (WebCore::ImageDocument::restoreImageSize):
       
 33021         If the image fits, reset the cursor. Otherwise, set it to the zoom in cursor.
       
 33022 
       
 33023 2007-05-23  Darin Adler  <darin@apple.com>
       
 33024 
       
 33025         Reviewed by Hyatt.
       
 33026 
       
 33027         - fix problems where unrendered nodes were affecting on plain text serialization
       
 33028 
       
 33029         * editing/TextIterator.cpp:
       
 33030         (WebCore::TextIterator::advance): Don't call handleXXX functions or exitNode for
       
 33031         nodes without renderers.
       
 33032         (WebCore::shouldEmitNewlineAfterNode): Only consider rendered nodes when deciding
       
 33033         if this is the last node in the document.
       
 33034 
       
 33035 2007-05-23  Anders Carlsson  <andersca@apple.com>
       
 33036 
       
 33037         Reviewed by Geoff.
       
 33038 
       
 33039         <rdar://problem/3663808> Resize large images to fit in the browser window
       
 33040         
       
 33041         * WebCore.exp:
       
 33042         Add new settings method.
       
 33043         
       
 33044         * loader/ImageDocument.cpp:
       
 33045         (WebCore::ImageEventListener::ImageEventListener):
       
 33046         New class that handles resize events and click events and forwards them to the image document.
       
 33047         
       
 33048         (WebCore::ImageTokenizer::ImageTokenizer):
       
 33049         (WebCore::ImageTokenizer::writeRawData):
       
 33050         (WebCore::ImageTokenizer::finish):
       
 33051         (WebCore::ImageDocument::ImageDocument):
       
 33052         (WebCore::ImageDocument::createDocumentStructure):
       
 33053         (WebCore::ImageDocument::cachedImage):
       
 33054         Let the ImageDocument class keep track of its document structure.
       
 33055         
       
 33056         (WebCore::ImageDocument::scale):
       
 33057         Returns the scale that should be used when resizing the image.
       
 33058         
       
 33059         (WebCore::ImageDocument::resizeImage):
       
 33060         Update the image size.
       
 33061         
       
 33062         (WebCore::ImageDocument::imageClicked):
       
 33063         Toggle between resized and not resized. When restoring the size, scroll the image so that the area under
       
 33064         the mouse stays the same.
       
 33065         
       
 33066         (WebCore::ImageDocument::imageChanged):
       
 33067         When the image size is known, resize the image if needed.
       
 33068         
       
 33069         (WebCore::ImageDocument::restoreImageSize):
       
 33070         Restore the image size.
       
 33071         
       
 33072         (WebCore::ImageDocument::imageNeedsResizing):
       
 33073         Return whether the image is too big for its window or not.
       
 33074         
       
 33075         (WebCore::ImageDocument::windowSizeChanged):
       
 33076         Called when the window's size changes. Determine if the window fits or not and resize it if it doesn't fit.
       
 33077         
       
 33078         (WebCore::ImageEventListener::handleEvent):
       
 33079         Forward events to the image document.
       
 33080         
       
 33081         * page/Settings.cpp:
       
 33082         (WebCore::Settings::Settings):
       
 33083         (WebCore::Settings::setEnableAutomaticImageResizing):
       
 33084         * page/Settings.h:
       
 33085         (WebCore::Settings::enableAutomaticImageResizing):
       
 33086         Add new setting.
       
 33087         
       
 33088 2007-05-23  Anders Carlsson  <andersca@apple.com>
       
 33089 
       
 33090         Reviewed by Darin.
       
 33091 
       
 33092         Add -webkit-zoom-in and -webkit-zoom-out cursors.
       
 33093         
       
 33094         * Resources/zoomInCursor.png: Added.
       
 33095         * Resources/zoomOutCursor.png: Added.
       
 33096         * css/CSSComputedStyleDeclaration.cpp:
       
 33097         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 33098         * css/CSSValueKeywords.in:
       
 33099         * page/EventHandler.cpp:
       
 33100         (WebCore::selectCursor):
       
 33101         * platform/Cursor.h:
       
 33102         * platform/mac/CursorMac.mm:
       
 33103         (WebCore::zoomInCursor):
       
 33104         (WebCore::zoomOutCursor):
       
 33105         * rendering/RenderStyle.h:
       
 33106         (WebCore::):
       
 33107 
       
 33108 2007-05-23  Sam Weinig  <sam@webkit.org>
       
 33109 
       
 33110         Reviewed by Darin.
       
 33111 
       
 33112         Part one of patch for http://bugs.webkit.org/show_bug.cgi?id=13830
       
 33113         Auto-generate JS DOM bindings for HTMLDocument and most of the rest
       
 33114         of HTMLElement
       
 33115 
       
 33116         - Just the HTMLElement part.
       
 33117 
       
 33118         * bindings/js/kjs_html.cpp:
       
 33119         (KJS::JSHTMLElement::getValueProperty):
       
 33120         (KJS::JSHTMLElement::putValueProperty):
       
 33121         * bindings/js/kjs_html.h:
       
 33122         (KJS::JSHTMLElement::):
       
 33123         * html/HTMLElement.idl:
       
 33124 
       
 33125 2007-05-22  Kevin McCullough  <kmccullough@apple.com>
       
 33126 
       
 33127         Reviewed by Darin.
       
 33128 
       
 33129         - rdar://problem/5183523
       
 33130         - We now check the document's URL to see if it can load a resource in the case of a URL click, instead of checking the referrer, which is blank for local files.
       
 33131 
       
 33132         * loader/FrameLoader.cpp:
       
 33133         (WebCore::FrameLoader::load):
       
 33134         (WebCore::FrameLoader::open):
       
 33135         * platform/PlatformString.h:
       
 33136         (WebCore::debugPrintString):
       
 33137 
       
 33138 2007-05-23  Sam Weinig  <sam@webkit.org>
       
 33139 
       
 33140         Reviewed by Darin.
       
 33141 
       
 33142         Part two of patch for http://bugs.webkit.org/show_bug.cgi?id=13830
       
 33143         Auto-generate JS DOM bindings for HTMLDocument and most of the rest
       
 33144         of HTMLElement
       
 33145 
       
 33146         - Just the HTMLDocument part.
       
 33147 
       
 33148         * WebCore.pro:
       
 33149         * WebCore.xcodeproj/project.pbxproj:
       
 33150         * bindings/js/JSHTMLDocumentCustom.cpp: Added.
       
 33151         (WebCore::JSHTMLDocument::canGetItemsForName):
       
 33152         (WebCore::JSHTMLDocument::nameGetter):
       
 33153         (WebCore::JSHTMLDocument::all):
       
 33154         (WebCore::JSHTMLDocument::setAll):
       
 33155         (WebCore::JSHTMLDocument::location):
       
 33156         (WebCore::JSHTMLDocument::setLocation):
       
 33157         (WebCore::JSHTMLDocument::open):
       
 33158         (WebCore::writeHelper):
       
 33159         (WebCore::JSHTMLDocument::write):
       
 33160         (WebCore::JSHTMLDocument::writeln):
       
 33161         (WebCore::JSHTMLDocument::clear):
       
 33162         * bindings/js/kjs_dom.cpp:
       
 33163         (KJS::toJS):
       
 33164         * bindings/js/kjs_dom.h:
       
 33165         * bindings/js/kjs_html.cpp:
       
 33166         * bindings/js/kjs_html.h:
       
 33167         * bindings/objc/DOMPrivate.h:
       
 33168         * bindings/scripts/CodeGeneratorJS.pm: Add [Deletable] property
       
 33169         for Document.all and fix HasOverridingNameGetter to allow correct
       
 33170         prototype chain
       
 33171         * dom/Document.cpp:
       
 33172         (WebCore::Document::plugins): adds alias to embeds() for bindings
       
 33173         * dom/Document.h:
       
 33174         * html/HTMLDocument.cpp:
       
 33175         (WebCore::HTMLDocument::width):
       
 33176         (WebCore::HTMLDocument::height):
       
 33177         (WebCore::HTMLDocument::dir):
       
 33178         (WebCore::HTMLDocument::setDir):
       
 33179         (WebCore::HTMLDocument::designMode):
       
 33180         (WebCore::HTMLDocument::setDesignMode):
       
 33181         (WebCore::HTMLDocument::bgColor):
       
 33182         (WebCore::HTMLDocument::setBgColor):
       
 33183         (WebCore::HTMLDocument::fgColor):
       
 33184         (WebCore::HTMLDocument::setFgColor):
       
 33185         (WebCore::HTMLDocument::alinkColor):
       
 33186         (WebCore::HTMLDocument::setAlinkColor):
       
 33187         (WebCore::HTMLDocument::linkColor):
       
 33188         (WebCore::HTMLDocument::setLinkColor):
       
 33189         (WebCore::HTMLDocument::vlinkColor):
       
 33190         (WebCore::HTMLDocument::setVlinkColor):
       
 33191         (WebCore::HTMLDocument::captureEvents):
       
 33192         (WebCore::HTMLDocument::releaseEvents):
       
 33193         * html/HTMLDocument.h:
       
 33194         * html/HTMLDocument.idl:
       
 33195 
       
 33196 2007-05-23  David Hyatt  <hyatt@apple.com>
       
 33197 
       
 33198         Fix for <rdar://problem/5221838> REGRESSION (r21581): no content in idisk
       
 33199         window at mac.com.
       
 33200 
       
 33201         Back out the change to make self-closed <script/> into a Dashboard quirk
       
 33202         only.
       
 33203 
       
 33204         Reviewed by aroben
       
 33205 
       
 33206         * html/HTMLTokenizer.cpp:
       
 33207         (WebCore::HTMLTokenizer::parseTag):
       
 33208 
       
 33209 2007-05-23  Patti  <patti@apple.com>
       
 33210 
       
 33211         Reviewed by David Harrison.
       
 33212 
       
 33213         <rdar://problem/5078453> AXNext/PrevLineEndTextMarkerForTextMarker returns kAXErrorNoValue for attachment range
       
 33214         
       
 33215         Floating objects, such as aligned images, are not included as part of any line.  So when the given 
       
 33216         text marker is on the floating object, the returned line edge cannot be found and asserts are fired.
       
 33217         In addition, this paints an inconsistent text layout (in the accessibility sense) of where the floating 
       
 33218         object resides.  Character/word methods report floating object at the beginning of the text line(s).  Yet
       
 33219         line methods never present floating objects anywhere.  
       
 33220         To fix this, the ax line methods will now do more checking to ensure floating object nodes are included
       
 33221         when determining the line range/position. That way, assistive apps won't get stuck using the line methods 
       
 33222         to read line-by-line
       
 33223 
       
 33224         * bridge/mac/WebCoreAXObject.mm:
       
 33225         (updateAXLineStartForVisiblePosition):
       
 33226         Added a helper method to adjust line start position to account for floating objects
       
 33227         (-[WebCoreAXObject doAXLeftLineTextMarkerRangeForTextMarker:]):
       
 33228         (-[WebCoreAXObject doAXRightLineTextMarkerRangeForTextMarker:]):
       
 33229         (-[WebCoreAXObject doAXNextLineEndTextMarkerForTextMarker:]):
       
 33230         (-[WebCoreAXObject doAXPreviousLineStartTextMarkerForTextMarker:]):
       
 33231         Fixed up line routines to include floating object nodes in line position calculation.
       
 33232         startOfLine/endOLine may return null for position next to a floating position.  So now there's extra checks to prevent
       
 33233         returning null line position/ranges back to AX.
       
 33234 
       
 33235 
       
 33236 2007-05-23  Simon Hausmann  <hausmann@kde.org>
       
 33237 
       
 33238         Reviewed by Zack, discussed also with Lars.
       
 33239 
       
 33240         Make it possible to have per-QWebPage network interface
       
 33241         implementations.
       
 33242 
       
 33243         * platform/network/qt/ResourceHandleQt.cpp:
       
 33244         (WebCore::ResourceHandle::start): Pass the page's network interface to
       
 33245         the network manager.
       
 33246 
       
 33247 2007-05-23  Rob Buis  <buis@kde.org>
       
 33248 
       
 33249         Reviewed by Dave Hyatt.
       
 33250 
       
 33251         http://bugs.webkit.org/show_bug.cgi?id=13174
       
 33252         line-height in font shorthand does not override a previously stated line-height property
       
 33253 
       
 33254         Make sure line-height is calculated against definite font-size and
       
 33255         uses the last set line-height, ie. directly or through font shorthand.
       
 33256 
       
 33257         * css/cssstyleselector.cpp:
       
 33258         (WebCore::CSSStyleSelector::styleForElement):
       
 33259         (WebCore::CSSStyleSelector::pseudoStyleForElement):
       
 33260         (WebCore::CSSStyleSelector::applyDeclarations):
       
 33261         (WebCore::CSSStyleSelector::applyProperty):
       
 33262         * css/cssstyleselector.h:
       
 33263 
       
 33264 2007-05-23  Lars Knoll <lars@trolltech.com>
       
 33265 
       
 33266         Reviewed by Zack and Valgrind
       
 33267 
       
 33268         Initialize variable.
       
 33269 
       
 33270         * platform/qt/PlatformMouseEventQt.cpp:
       
 33271         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
       
 33272 
       
 33273 2007-05-23  Rob Buis  <buis@kde.org>
       
 33274 
       
 33275         Reviewed by Darin.
       
 33276 
       
 33277         http://bugs.webkit.org/show_bug.cgi?id=13784
       
 33278         REGRESSION (r13744-13750): Crash with empty gradient when drawing to canvas
       
 33279 
       
 33280         Fix crash by testing for zero stops, and returning transparent black
       
 33281         in this case.
       
 33282 
       
 33283         * html/CanvasGradient.cpp:
       
 33284         (WebCore::CanvasGradient::getColor):
       
 33285 
       
 33286 2007-05-23  Rob Buis  <buis@kde.org>
       
 33287 
       
 33288         Reviewed by Darin.
       
 33289 
       
 33290         http://bugs.webkit.org/show_bug.cgi?id=13801
       
 33291         Crash when loading nonexisting symbol
       
 33292 
       
 33293         Check for referenced element and when not found just return.
       
 33294 
       
 33295         * ksvg2/svg/SVGUseElement.cpp:
       
 33296         (WebCore::SVGUseElement::buildPendingResource):
       
 33297 
       
 33298 2007-05-22  Sam Weinig  <sam@webkit.org>
       
 33299 
       
 33300         Rubber stamped by Adam.
       
 33301 
       
 33302         Fix license.
       
 33303 
       
 33304         * bindings/js/JSHTMLAnchorElementCustom.cpp:
       
 33305 
       
 33306 2007-05-22  Sam Weinig  <sam@webkit.org>
       
 33307 
       
 33308         Reviewed by Adam.
       
 33309 
       
 33310         Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
       
 33311         Add ObjC DOM binding for HTMLMarqeeElement
       
 33312 
       
 33313         - Also adds missing DOMHTMLFramePrivate.
       
 33314 
       
 33315         * DerivedSources.make:
       
 33316         * WebCore.xcodeproj/project.pbxproj:
       
 33317         * bindings/objc/DOM.mm:
       
 33318         (WebCore::createElementClassMap):
       
 33319         * bindings/objc/DOMHTML.h:
       
 33320         * bindings/objc/DOMInternal.h:
       
 33321         * bindings/objc/DOMPrivate.h:
       
 33322         * bindings/objc/PublicDOMInterfaces.h:
       
 33323 
       
 33324 2007-05-22  Justin Garcia  <justin.garcia@apple.com>
       
 33325 
       
 33326         Reviewed by darin, who found the fix independently.
       
 33327 
       
 33328         http://bugs.webkit.org/show_bug.cgi?id=13804
       
 33329         REGRESSION(r21611): Several new layout test pixel failures (misspelling markers)
       
 33330         
       
 33331         r21611 exposed a bug in the way removeMarkers computes
       
 33332         the end of the range to remove markers from.  It also
       
 33333         introduced a bug: removeMarkers expects a startOffset
       
 33334         and a length, not a startOffset and an endOffset (added 
       
 33335         a layout test).
       
 33336 
       
 33337         * dom/Document.cpp:
       
 33338         (WebCore::Document::removeMarkers): The other removeMarkers
       
 33339         expects a startOffset and a length, not a startOffset and
       
 33340         an endOffset.
       
 33341         (WebCore::Document::removeMarkers): Fixed the endOffset
       
 33342         from length and startOffset calculation.
       
 33343 
       
 33344 2007-05-22  David Hyatt  <hyatt@apple.com>
       
 33345 
       
 33346         Fix for bug 13802, background colors can't be reset to default
       
 33347         color.  Fix the value cssText method to do the right thing for background
       
 33348         and background-position values.
       
 33349 
       
 33350         Reviewed by beth
       
 33351 
       
 33352         fast/dom/background-shorthand-csstext.html
       
 33353 
       
 33354         * css/CSSInitialValue.h:
       
 33355         (WebCore::CSSInitialValue:::m_implicit):
       
 33356         (WebCore::CSSInitialValue::isImplicitInitialValue):
       
 33357         * css/CSSMutableStyleDeclaration.cpp:
       
 33358         (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
       
 33359         (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
       
 33360         * css/CSSMutableStyleDeclaration.h:
       
 33361         * css/CSSValue.h:
       
 33362         (WebCore::CSSValue::isImplicitInitialValue):
       
 33363         * css/cssparser.cpp:
       
 33364         (WebCore::CSSParser::parseValue):
       
 33365         (WebCore::CSSParser::parseBackgroundShorthand):
       
 33366         (WebCore::CSSParser::parseShorthand):
       
 33367 
       
 33368 2007-05-22  Darin Adler  <darin@apple.com>
       
 33369 
       
 33370         Reviewed by Geoff.
       
 33371 
       
 33372         - fix <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong
       
 33373 
       
 33374         The code on ebay was looking for the "document" property on a iframe.
       
 33375         We changed that to be the ownerDocument rather than the contentDocument,
       
 33376         which was not what ebay was expecting. The best fix seems to be removing
       
 33377         the document property altogether.
       
 33378 
       
 33379         Test: fast/dom/iframe-document.html
       
 33380 
       
 33381         * bindings/js/kjs_html.h: Remove ElementDocument.
       
 33382         * bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::getValueProperty): Ditto.
       
 33383 
       
 33384 2007-05-22  Adele Peterson  <adele@apple.com>
       
 33385 
       
 33386         Reviewed by Darin.
       
 33387 
       
 33388         A little cleanup from my last checkin.
       
 33389 
       
 33390         * page/Chrome.h: Formatting change.
       
 33391         * page/mac/ChromeMac.mm: Fixed copyright.
       
 33392 
       
 33393 2007-05-22  Adele Peterson  <adele@apple.com>
       
 33394 
       
 33395         Reviewed by Darin.
       
 33396 
       
 33397         Fix for http://bugs.webkit.org/show_bug.cgi?id=13796
       
 33398         Crash in [NSInputContext currentInputContext] when you click on this map
       
 33399 
       
 33400         This is another case of <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts
       
 33401 
       
 33402         Test: fast/frames/frame-display-none-focus.html
       
 33403 
       
 33404         * WebCore.xcodeproj/project.pbxproj: Added ChromeMac.mm
       
 33405         * page/Chrome.h:
       
 33406         * page/mac/ChromeMac.mm: Added.
       
 33407         (WebCore::Chrome::focusNSView): Moved code from Widget::setFocus so it can be used whenever we need to make a view the first responder.
       
 33408         * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView): Calls focusNSView.
       
 33409         * platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus): Calls focusNSView.
       
 33410 
       
 33411 2007-05-22  Justin Garcia  <justin.garcia@apple.com>
       
 33412 
       
 33413         Reviewed by darin
       
 33414         
       
 33415         <rdar://problem/4875189> 
       
 33416         List is deleted when replacing contents with Chinese/Japanese characters
       
 33417 
       
 33418         * editing/htmlediting.cpp:
       
 33419         (WebCore::isSpecialElement): Lists are no longer special.
       
 33420         They can be removed by removing their content and then 
       
 33421         then hitting delete inside of the empty list item that's 
       
 33422         left over. Even when that list item is the first thing 
       
 33423         in the editable region.
       
 33424 
       
 33425 2007-05-22  Darin Adler  <darin@apple.com>
       
 33426 
       
 33427         Reviewed by Tim Hatcher.
       
 33428 
       
 33429         - fix <rdar://problem/5206089> REGRESSION: hovering over amazon.com "product categories"
       
 33430           tab makes page content disappear
       
 33431 
       
 33432         The contentWindow property was doing a cross-frame security check, but it shouldn't.
       
 33433         Window objects are responsible for protecting themselves from cross-frame activity.
       
 33434         Because contentWindow returned undefined, we then ended up setting visibility on the
       
 33435         body of the main frame to "hidden".
       
 33436 
       
 33437         No layout test yet. When we make cross-domain tests, we should include this one.
       
 33438 
       
 33439         * html/HTMLFrameElement.idl: Removed CheckFrameSecurity attribute from contentWindow.
       
 33440         * html/HTMLIFrameElement.idl: Ditto.
       
 33441 
       
 33442 2007-05-22  Justin Garcia  <justin.garcia@apple.com>
       
 33443 
       
 33444         Reviewed by oliver
       
 33445 
       
 33446         <rdar://problem/5213963>
       
 33447         REGRESSION(r21467): Active selection remains in text field after clicking on a button
       
 33448 
       
 33449         * page/EventHandler.cpp:
       
 33450         (WebCore::EventHandler::dispatchMouseEvent): Call
       
 33451         FocusController::setFocusedNode, because Document::setFocusedNode
       
 33452         no longer clears the selection.
       
 33453         Begin passing the new focused frame to 
       
 33454         FocusController::setFocusedNode, because when the 
       
 33455         new focus node is null, the selection should only be 
       
 33456         cleared if the focused frame isn't changing.
       
 33457         (WebCore::Element::focus): Begin passing the new focused
       
 33458         frame.
       
 33459         (WebCore::Element::blur): Ditto.
       
 33460         * html/HTMLInputElement.cpp:
       
 33461         (WebCore::HTMLInputElement::focus): Ditto.
       
 33462         * html/HTMLTextAreaElement.cpp:
       
 33463         (WebCore::HTMLTextAreaElement::focus): Ditto.
       
 33464         * page/Frame.cpp:
       
 33465         (WebCore::Frame::setFocusedNodeIfNeeded): Ditto.
       
 33466         * page/FocusController.cpp:
       
 33467         (WebCore::clearSelectionIfNeeded): Take in the new
       
 33468         focused frame.  If it's not changing, don't clear the
       
 33469         selection.
       
 33470         (WebCore::FocusController::setFocusedNode): Take
       
 33471         in the new focused frame.
       
 33472         * page/FocusController.h:
       
 33473 
       
 33474 2007-05-22  Marius Bugge Monsen  <mbm@trolltech.com>
       
 33475 
       
 33476         Reviewed by Zack.
       
 33477 
       
 33478         Implement some more functions in ClipboardQt.
       
 33479 
       
 33480         * platform/qt/ClipboardQt.cpp:
       
 33481         (WebCore::ClipboardQt::ClipboardQt):
       
 33482         (WebCore::ClipboardQt::getData):
       
 33483         (WebCore::ClipboardQt::setData):
       
 33484         (WebCore::ClipboardQt::types):
       
 33485 
       
 33486 2007-05-21  Oliver Hunt  <oliver@apple.com>
       
 33487 
       
 33488         Reviewed by Sam.
       
 33489         
       
 33490         Fix for http://bugs.webkit.org/show_bug.cgi?id=13789 
       
 33491         -- SVGLocatable::getScreenCTM() faulty
       
 33492         
       
 33493         Needed to update SVGLength to handle the case where the SVGElement is
       
 33494         not the root document element -- we do this by falling back on the 
       
 33495         renderer for the context.
       
 33496         
       
 33497         For <svg> elements embedded as mixed content in xhtml we consider the
       
 33498         absolutePosition of the parent to be the origin for the <svg> element.
       
 33499 
       
 33500         * ksvg2/svg/SVGLength.cpp:
       
 33501         (WebCore::SVGLength::PercentageOfViewport):
       
 33502         * ksvg2/svg/SVGSVGElement.cpp:
       
 33503         (WebCore::SVGSVGElement::getScreenCTM):
       
 33504 
       
 33505 2007-05-21  Timothy Hatcher  <timothy@apple.com>
       
 33506 
       
 33507         Reviewed by Adam.
       
 33508 
       
 33509         <rdar://problem/5084400> -[DOMRange lineBoxRects] returns an empty array when the DOM nodes have just been created
       
 33510 
       
 33511         Do a updateLayoutIgnorePendingStylesheets before asking the Node or Range for it's box rects.
       
 33512 
       
 33513         * bindings/objc/DOM.mm:
       
 33514         (-[DOMNode boundingBox]):
       
 33515         (-[DOMNode lineBoxRects]):
       
 33516         (-[DOMRange boundingBox]):
       
 33517         (-[DOMRange lineBoxRects]):
       
 33518 
       
 33519 2007-05-21  Sam Weinig  <sam@webkit.org>
       
 33520 
       
 33521         Reviewed by George Staikos.
       
 33522 
       
 33523         Fix Qt build.
       
 33524 
       
 33525         * WebCore.pro: add missing IDL files.
       
 33526 
       
 33527 2007-05-21  Sam Weinig  <sam@webkit.org>
       
 33528 
       
 33529         Reviewed by Darin.
       
 33530 
       
 33531         Patch for http://bugs.webkit.org/show_bug.cgi?id=13803
       
 33532         Autogenerate the JS bindings for the HTMLMarqueeElement.
       
 33533 
       
 33534         * DerivedSources.make:
       
 33535         * WebCore.xcodeproj/project.pbxproj:
       
 33536         * bindings/js/JSHTMLElementWrapperFactory.cpp:
       
 33537         * bindings/js/kjs_css.cpp:
       
 33538         (KJS::DOMCSSRule::getOwnPropertySlot): Fix possible null pointer issue.
       
 33539         (KJS::DOMCSSRule::put): Fix possible null pointer issue.
       
 33540         * bindings/js/kjs_html.cpp:
       
 33541         (KJS::):
       
 33542         (KJS::JSHTMLElement::classInfo):
       
 33543         (KJS::JSHTMLElement::accessors):
       
 33544         (KJS::JSHTMLElement::getOwnPropertySlot): Fix null pointer issue.
       
 33545         (KJS::HTMLElementFunction::callAsFunction):
       
 33546         (KJS::JSHTMLElement::put):
       
 33547         * bindings/js/kjs_html.h:
       
 33548         (KJS::JSHTMLElement::):
       
 33549         * html/HTMLMarqueeElement.cpp:
       
 33550         (WebCore::HTMLMarqueeElement::start):
       
 33551         (WebCore::HTMLMarqueeElement::stop):
       
 33552         * html/HTMLMarqueeElement.h: Add start() and stop() functions.
       
 33553         * html/HTMLMarqueeElement.idl: Added.
       
 33554         * page/DOMWindow.idl: Add marquee constructor.
       
 33555 
       
 33556 2007-05-21  Adele Peterson  <adele@apple.com>
       
 33557 
       
 33558         Fix by Darin, reviewed by me.
       
 33559 
       
 33560         Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts
       
 33561 
       
 33562         * platform/mac/WidgetMac.mm:
       
 33563         (WebCore::safeRemoveFromSuperview): Added. If the view is the window's first responder, then 
       
 33564          set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it.
       
 33565         (WebCore::Widget::setFocus): Don't attempt to focus the view if it has no window.
       
 33566         (WebCore::Widget::removeFromSuperview): Call safeRemoveFromSuperview.
       
 33567         (WebCore::Widget::afterMouseDown): ditto.
       
 33568 
       
 33569 2007-05-21  David Hyatt  <hyatt@apple.com>
       
 33570 
       
 33571         Make a line gutter backdrop so that tiny view source docs don't look
       
 33572         bad.
       
 33573 
       
 33574         Reviewed by aroben
       
 33575 
       
 33576         * css/view-source.css:
       
 33577         * html/HTMLViewSourceDocument.cpp:
       
 33578         (WebCore::HTMLViewSourceDocument::createContainingTable):
       
 33579 
       
 33580 2007-05-21  David Hyatt  <hyatt@apple.com>
       
 33581 
       
 33582         Make sure to distinguish between links to internal resources and
       
 33583         real links (anchors) in view source mode.
       
 33584 
       
 33585         Reviewed by aroben
       
 33586 
       
 33587         * css/view-source.css:
       
 33588         * html/HTMLViewSourceDocument.cpp:
       
 33589         (WebCore::HTMLViewSourceDocument::addViewSourceToken):
       
 33590         (WebCore::HTMLViewSourceDocument::addLink):
       
 33591         * html/HTMLViewSourceDocument.h:
       
 33592 
       
 33593 2007-05-21  Sam Weinig  <sam@webkit.org>
       
 33594 
       
 33595         Reviewed by Adam and Darin.
       
 33596 
       
 33597         Patch for http://bugs.webkit.org/show_bug.cgi?id=13791
       
 33598         Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement.
       
 33599 
       
 33600         * DerivedSources.make:
       
 33601         * WebCore.xcodeproj/project.pbxproj:
       
 33602         * bindings/js/JSHTMLAnchorElementCustom.cpp:
       
 33603         * bindings/js/JSHTMLElementWrapperFactory.cpp:
       
 33604         * bindings/js/kjs_html.cpp:
       
 33605         (KJS::):
       
 33606         (KJS::JSHTMLElement::classInfo):
       
 33607         (KJS::JSHTMLElement::accessors):
       
 33608         (KJS::HTMLElementFunction::callAsFunction):
       
 33609         * bindings/js/kjs_html.h:
       
 33610         (KJS::JSHTMLElement::):
       
 33611         * bindings/scripts/CodeGeneratorJS.pm:
       
 33612         * html/HTMLFrameElement.idl:
       
 33613         * html/HTMLFrameElementBase.cpp:
       
 33614         (WebCore::HTMLFrameElementBase::location):
       
 33615         * html/HTMLFrameElementBase.h:
       
 33616         * html/HTMLFrameOwnerElement.h:
       
 33617         (WebCore::HTMLFrameOwnerElement::contentWindow):
       
 33618         * html/HTMLIFrameElement.idl:
       
 33619         * page/DOMWindow.idl:
       
 33620 
       
 33621 2007-05-21  Lars Knoll <lars@trolltech.com>
       
 33622 
       
 33623         Reviewed by Zack.
       
 33624 
       
 33625         Remove the ResourceHandleManager class, it is now part of 
       
 33626         QWebNetworkInterface. Adapt ResourceHandle to the new way 
       
 33627         of things.
       
 33628 
       
 33629         * WebCore.pro:
       
 33630         * platform/network/ResourceHandleInternal.h:
       
 33631         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
       
 33632         * platform/network/qt/ResourceHandleManagerKDE.cpp: Removed.
       
 33633         * platform/network/qt/ResourceHandleManagerKDE.h: Removed.
       
 33634         * platform/network/qt/ResourceHandleManagerQt.cpp: Removed.
       
 33635         * platform/network/qt/ResourceHandleManagerQt.h: Removed.
       
 33636         * platform/network/qt/ResourceHandleQt.cpp:
       
 33637         (WebCore::ResourceHandle::~ResourceHandle):
       
 33638         (WebCore::ResourceHandle::start):
       
 33639         (WebCore::ResourceHandle::cancel):
       
 33640 
       
 33641 2007-05-21  David Hyatt  <hyatt@apple.com>
       
 33642 
       
 33643         Second half of fix for 13793, make sure rules=groups works properly with
       
 33644         spanning colgroups.
       
 33645 
       
 33646         Also make sure colgroups get an actual span of 1 (instead of incorrectly
       
 33647         giving them a span of 0).
       
 33648 
       
 33649         Reviewed by mitz
       
 33650 
       
 33651         fast/table/colgroup-spanning-groups-rules.html
       
 33652 
       
 33653         * html/HTMLTableColElement.cpp:
       
 33654         (WebCore::HTMLTableColElement::HTMLTableColElement):
       
 33655         * rendering/RenderTable.cpp:
       
 33656         (WebCore::RenderTable::colElement):
       
 33657         * rendering/RenderTable.h:
       
 33658         * rendering/RenderTableCell.cpp:
       
 33659         (WebCore::RenderTableCell::collapsedLeftBorder):
       
 33660         (WebCore::RenderTableCell::collapsedRightBorder):
       
 33661 
       
 33662 2007-05-20  David Hyatt  <hyatt@apple.com>
       
 33663 
       
 33664         Half of a fix for 13793, make sure rules=groups and border behave properly
       
 33665         together.
       
 33666 
       
 33667         Reviewed by mitz
       
 33668 
       
 33669         No tests added, two Mozilla table tests now pass that failed before.
       
 33670 
       
 33671         * html/HTMLTableElement.cpp:
       
 33672         (WebCore::HTMLTableElement::getSharedCellDecl):
       
 33673 
       
 33674 2007-05-20  Brady Eidson <beidson@apple.com>
       
 33675 
       
 33676         Reviewed by Geoose Garen
       
 33677 
       
 33678         <rdar://problem/4758919> - Incorrect favicon shown for URL after going back
       
 33679 
       
 33680         When restoring a cached page, we'd try to kick off the icon load for it, which ended up causing 
       
 33681         shenanigans with the icon url -> page url mapping.  
       
 33682 
       
 33683         * loader/FrameLoader.cpp:
       
 33684         (WebCore::FrameLoader::endIfNotLoading): Only try an icon load if we're not restoring from the page cache
       
 33685         (WebCore::FrameLoader::startIconLoader): Added helpful logging that helped me track this down
       
 33686         (WebCore::FrameLoader::commitIconURLToIconDatabase): Ditto (and fixed a comment typo)
       
 33687 
       
 33688         * loader/icon/IconLoader.cpp:
       
 33689         (WebCore::IconLoader::stopLoading): Don't null out the ResourceLoader here, as clearLoadingState() does that
       
 33690         (WebCore::IconLoader::finishLoading): Added helpful logging that helped me track this down
       
 33691 
       
 33692 
       
 33693 2007-05-20  Darin Adler  <darin@apple.com>
       
 33694 
       
 33695         Reviewed by Oliver Hunt.
       
 33696 
       
 33697         - fix <rdar://problem/5193416> REGRESSION: Selection on large pages extremely slow
       
 33698 
       
 33699         * dom/Document.cpp: (WebCore::Document::removeMarkers): Added an early exit for the common
       
 33700         case where there are no markers. Changed code to iterate over all the nodes in the range
       
 33701         instead of using TextIterator, which is more efficient.
       
 33702         
       
 33703         * page/Frame.cpp: (WebCore::Frame::respondToChangedSelection): Added checks for editable,
       
 33704         so we don't bother doing work related to spell checking and grammar checking when changing
       
 33705         the selection in non-editable text. Also rearranged the code so we only compute the old
       
 33706         word boundaries and sentence boundaries when actually needed, and don't do the sentence
       
 33707         range checks unless grammar checking is enabled.
       
 33708 
       
 33709         * platform/TextBreakIteratorICU.cpp:
       
 33710         (WebCore::setUpIterator): Don't take a locale parameter. Always pass in currentTextBreakLocaleID.
       
 33711         (WebCore::characterBreakIterator): Removed local parameter.
       
 33712         (WebCore::wordBreakIterator): Ditto.
       
 33713         (WebCore::lineBreakIterator): Ditto.
       
 33714         (WebCore::sentenceBreakIterator): Ditto.
       
 33715 
       
 33716         * platform/mac/TextBreakIteratorInternalICUMac.mm:
       
 33717         (WebCore::getTextBreakLocale): Broke out the code to actually get the locale.
       
 33718         (WebCore::currentTextBreakLocaleID): This function now handles only the caching and calls
       
 33719         getTextBreakLocale to actually figure it out.
       
 33720 
       
 33721         * editing/visible_units.cpp: Added lots of FIXME comments, but no code change.
       
 33722 
       
 33723 2007-05-20  Adam Treat  <adam@staikos.net>
       
 33724 
       
 33725         Add -f to cp to deal with some obscure build environments.
       
 33726 
       
 33727         Reviewed by George Staikos.
       
 33728 
       
 33729         * move-js-headers.sh:
       
 33730 
       
 33731 2007-05-20  Adam Treat  <adam@staikos.net>
       
 33732 
       
 33733         Add missing include for auto_ptr
       
 33734 
       
 33735         Reviewed by George Staikos.
       
 33736 
       
 33737         * platform/graphics/ImageBuffer.h:
       
 33738 
       
 33739 2007-05-19  David Hyatt  <hyatt@apple.com>
       
 33740 
       
 33741         Fix for bug 13785, O(n^2) counter creation.
       
 33742 
       
 33743         Reviewed by darin
       
 33744 
       
 33745         * rendering/RenderCounter.cpp:
       
 33746         (WebCore::findPlaceForCounter):
       
 33747         (WebCore::RenderCounter::originalText):
       
 33748 
       
 33749 2007-05-19  Mitz Pettel  <mitz@webkit.org>
       
 33750 
       
 33751         Reviewed by Dave Hyatt.
       
 33752 
       
 33753         - fix http://bugs.webkit.org/show_bug.cgi?id=12729
       
 33754           box-shadow disappears when scrolling a div that it falls on/under
       
 33755 
       
 33756         Tests: fast/repaint/box-shadow-dynamic.html
       
 33757                fast/repaint/box-shadow-h.html
       
 33758                fast/repaint/box-shadow-v.html
       
 33759 
       
 33760         * rendering/InlineFlowBox.cpp:
       
 33761         (WebCore::InlineFlowBox::placeBoxesHorizontally): Factor in box shadow.
       
 33762         (WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
       
 33763         (WebCore::InlineFlowBox::paint): Account for box shadow when checking if
       
 33764         the damage rect intersects.
       
 33765         * rendering/RenderBlock.cpp:
       
 33766         (WebCore::RenderBlock::overflowHeight): For overflow areas, when asked
       
 33767         for the "exterior" overflow, add box shadow overflow.
       
 33768         (WebCore::RenderBlock::overflowWidth): Ditto.
       
 33769         (WebCore::RenderBlock::overflowLeft): Ditto.
       
 33770         (WebCore::RenderBlock::overflowTop): Ditto.
       
 33771         (WebCore::RenderBlock::overflowRect): Ditto.
       
 33772         (WebCore::RenderBlock::layoutBlock): Factor box shadow into visual overflow.
       
 33773         * rendering/RenderFlexibleBox.cpp:
       
 33774         (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
       
 33775         * rendering/RenderFlow.cpp:
       
 33776         (WebCore::RenderFlow::lowestPosition): For overflow areas, when asked for
       
 33777         the "exterior" extreme position, add box shadow.
       
 33778         (WebCore::RenderFlow::rightmostPosition): Ditto.
       
 33779         (WebCore::RenderFlow::leftmostPosition): Ditto.
       
 33780         * rendering/RenderLayer.cpp:
       
 33781         (WebCore::RenderLayer::calculateRects): Avoid clipping out box shadow.
       
 33782         * rendering/RenderObject.cpp:
       
 33783         (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Make sure to paint
       
 33784         the box shadow when an edge with a shadow moves.
       
 33785         (WebCore::RenderObject::adjustRectForOutlineAndShadow): Helper function
       
 33786         that expands a given rectangle to encompass outline and box shadow.
       
 33787         (WebCore::RenderObject::absoluteOutlineBox): Changed to include box shadow.
       
 33788         * rendering/RenderObject.h:
       
 33789 
       
 33790 2007-05-19  Mitz Pettel  <mitz@webkit.org>
       
 33791 
       
 33792         Reviewed by Dave Hyatt.
       
 33793 
       
 33794         - fix http://bugs.webkit.org/show_bug.cgi?id=13783
       
 33795           REGRESSION (r21120): Frame resizers not repainted properly when dragged
       
 33796 
       
 33797         * rendering/RenderFrameSet.cpp:
       
 33798         (WebCore::RenderFrameSet::layout):
       
 33799 
       
 33800 2007-05-19  Mitz Pettel  <mitz@webkit.org>
       
 33801 
       
 33802         Reviewed by Darin.
       
 33803 
       
 33804         - fix http://bugs.webkit.org/show_bug.cgi?id=13774
       
 33805           REGRESSION: Crash emailing blog entry using Google Reader
       
 33806 
       
 33807         Test: fast/table/stale-grid-crash.html
       
 33808 
       
 33809         * rendering/RenderTable.cpp:
       
 33810         (WebCore::RenderTable::recalcSections): Made const and replaced
       
 33811         setNeedsLayout(true) with an assertion that the table is already
       
 33812         marked for layout.
       
 33813         (WebCore::RenderTable::sectionAbove): Added call to recalcSectionsIfNeeded().
       
 33814         (WebCore::RenderTable::sectionBelow): Ditto.
       
 33815         (WebCore::RenderTable::cellAbove): Ditto.
       
 33816         (WebCore::RenderTable::cellBelow): Ditto.
       
 33817         (WebCore::RenderTable::cellBefore): Ditto.
       
 33818         (WebCore::RenderTable::cellAfter): Ditto.
       
 33819         * rendering/RenderTable.h:
       
 33820         Made some private member variables which are used in section recalc mutable.
       
 33821         (WebCore::RenderTable::setNeedsSectionRecalc): Moved the call to
       
 33822         setNeedsLayout() from recalcSections() into here, because I made
       
 33823         recalcSections() const.
       
 33824         (WebCore::RenderTable::recalcSectionsIfNeeded): Made const.
       
 33825 
       
 33826 2007-05-19  Mitz Pettel  <mitz@webkit.org>
       
 33827 
       
 33828         Reviewed by Darin.
       
 33829 
       
 33830         - http://bugs.webkit.org/show_bug.cgi?id=13320
       
 33831           rounded corners with drop shadows are really slow
       
 33832 
       
 33833         Test for a rendering bug fixed by this patch:
       
 33834             fast/box-shadow/border-radius-big.html
       
 33835 
       
 33836         No test for the performance ingredient.
       
 33837 
       
 33838         * platform/graphics/GraphicsContext.cpp:
       
 33839         (WebCore::GraphicsContext::addRoundedRectClip): Made cross-platform.
       
 33840         Changed to use a single clipping path. If all the radii cannot be
       
 33841         accommodated, clips to a rect.
       
 33842         (WebCore::GraphicsContext::clipOutRoundedRect): Changed to use a single
       
 33843         clipping path. If all the radii cannot be accommodated, clips out a rect.
       
 33844         * platform/graphics/GraphicsContext.h: Added clipOut(const Path&).
       
 33845         * platform/graphics/Path.cpp:
       
 33846         (WebCore::Path::createRoundedRectangle): Added. Returns a rounded rectangle
       
 33847         with the specified radii. If all the radii cannot be accommodated, returns
       
 33848         a rectangular path.
       
 33849         * platform/graphics/Path.h:
       
 33850         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
 33851         (WebCore::GraphicsContext::clipOut): Added.
       
 33852         * platform/graphics/cg/GraphicsContextCG.cpp:
       
 33853         (WebCore::GraphicsContext::fillRoundedRect): Changed to use a single path.
       
 33854         (WebCore::GraphicsContext::clipOut): Added.
       
 33855         * platform/graphics/qt/GraphicsContextQt.cpp:
       
 33856         (WebCore::GraphicsContext::clipOut): Added.
       
 33857 
       
 33858 2007-05-19  Anders Carlsson  <andersca@apple.com>
       
 33859 
       
 33860         Reviewed by Mitz.
       
 33861 
       
 33862         Test: fast/frames/inline-object-inside-frameset.html
       
 33863         
       
 33864         http://bugs.webkit.org/show_bug.cgi?id=13771
       
 33865         Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester
       
 33866 
       
 33867         Don't paint inline objects.
       
 33868         
       
 33869         * rendering/RenderFrameSet.cpp:
       
 33870         (WebCore::RenderFrameSet::paint):
       
 33871 
       
 33872 2007-05-19  David Hyatt  <hyatt@apple.com>
       
 33873 
       
 33874         Add support for plain text MIME types (CSS/JS/TXT) to view source mode.
       
 33875         CSS/JS will eventually tokenize via their own special tokenizers so that
       
 33876         they can also be syntax-highlighted, but for now just treat them as
       
 33877         plain text.
       
 33878 
       
 33879         Reviewed by aroben
       
 33880 
       
 33881         * dom/DOMImplementation.cpp:
       
 33882         (WebCore::DOMImplementation::createDocument):
       
 33883         * html/HTMLViewSourceDocument.cpp:
       
 33884         (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
       
 33885         (WebCore::HTMLViewSourceDocument::createTokenizer):
       
 33886         (WebCore::HTMLViewSourceDocument::createContainingTable):
       
 33887         (WebCore::HTMLViewSourceDocument::addViewSourceText):
       
 33888         (WebCore::HTMLViewSourceDocument::addViewSourceToken):
       
 33889         * html/HTMLViewSourceDocument.h:
       
 33890         * loader/TextDocument.cpp:
       
 33891         (WebCore::TextTokenizer::TextTokenizer):
       
 33892         (WebCore::TextTokenizer::write):
       
 33893         * loader/TextDocument.h:
       
 33894         (WebCore::TextTokenizer::checkBuffer):
       
 33895 
       
 33896 2007-05-18  David Hyatt  <hyatt@apple.com>
       
 33897 
       
 33898         Fix a glitch in view source mode attribute names.
       
 33899 
       
 33900         * html/HTMLViewSourceDocument.cpp:
       
 33901         (WebCore::HTMLViewSourceDocument::addViewSourceToken):
       
 33902 
       
 33903 2007-05-18  David Hyatt  <hyatt@apple.com>
       
 33904 
       
 33905         "Linkify" view source mode links.
       
 33906 
       
 33907         Reviewed by andersca
       
 33908 
       
 33909         * css/view-source.css:
       
 33910         * html/HTMLViewSourceDocument.cpp:
       
 33911         (WebCore::HTMLViewSourceDocument::addViewSourceToken):
       
 33912         (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
       
 33913         (WebCore::HTMLViewSourceDocument::addLink):
       
 33914         * html/HTMLViewSourceDocument.h:
       
 33915 
       
 33916 2007-05-18  Oliver Hunt  <oliver@apple.com>
       
 33917 
       
 33918         Reviewed by Sam
       
 33919 
       
 33920         No longer need to pass HTMLImageElement and HTMLImageLoader on to WebKit
       
 33921         Need to expose CachedResourceClient constructor
       
 33922 
       
 33923         * WebCore.exp:
       
 33924         * WebCore.xcodeproj/project.pbxproj:
       
 33925 
       
 33926 2007-05-18  David Hyatt  <hyatt@apple.com>
       
 33927 
       
 33928         Fix for <rdar://problem/5214338> REGRESSION: / mishandled in 
       
 33929         HTML tokenization (13780).
       
 33930 
       
 33931         Reviewed by ggaren
       
 33932 
       
 33933         * html/HTMLTokenizer.cpp:
       
 33934         (WebCore::Token::addAttribute):
       
 33935         (WebCore::HTMLTokenizer::parseTag):
       
 33936 
       
 33937 2007-05-18  Brady Eidson  <beidson@apple.com>
       
 33938 
       
 33939         Reviewed by Maciej
       
 33940 
       
 33941         http://bugs.webkit.org/show_bug.cgi?id=12681 and
       
 33942         <rdar://problem/5166149> - window.open() causes server to be hit twice
       
 33943 
       
 33944         This regressed in http://trac.webkit.org/projects/webkit/changeset/14637
       
 33945         That patch was to fix broken behavior when opening an already existant window.
       
 33946         The unfortunate side effect was to cause the server to be hit twice.  
       
 33947         Once during the call to frame->loader()->createWindow(), and again via a 
       
 33948         scheduled redirection.
       
 33949 
       
 33950         I decided to restore the original de-facto behavior by making the new window
       
 33951         open via a scheduled redirection - there is a FIXME that was already here that
       
 33952         explains the reason why we have to do it this way for now.
       
 33953 
       
 33954         Additionally, there were two distinct places that had their own logic to open
       
 33955         a new window - the logic for window.open() and the logic for 
       
 33956         window.showModalDialog().  The logic was almost identical so I condensed them
       
 33957         into one utility function that takes a flag to handle the slight difference.
       
 33958 
       
 33959         A layout test is not possible at this time since it would involve capturing 
       
 33960         server logs (the 1st connection does not exist long enough to result in any
       
 33961         delegate callbacks).  That task is documented in 
       
 33962         http://bugs.webkit.org/show_bug.cgi?id=13769
       
 33963 
       
 33964         * bindings/js/kjs_window.cpp:
       
 33965         (KJS::createWindow): Merged the two slightly different versions of "creating a window" 
       
 33966           logic here.  For the modal dialog case the load is an immediate call to changeLocation(),
       
 33967           which is triggered by the "immediate" flag, and the other cases load via scheduleLocationChange()
       
 33968         (KJS::showModalDialog): Call createWindow()
       
 33969         (KJS::WindowFunc::callAsFunction): Handle frame targets of _top or _parent immediately and call 
       
 33970           createWindow() for all others
       
 33971 
       
 33972 2007-05-18  Sam Weinig  <sam@webkit.org>
       
 33973 
       
 33974         Reviewed by Geoff.
       
 33975 
       
 33976         Autogenerate the JS bindings for the HTMLTableElement, HTMLTableCaptionElement,
       
 33977         HTMLTableCellElement, HTMLTableColElement, HTMLTableRowElement, HTMLTableSectionElement.
       
 33978 
       
 33979         * DerivedSources.make:
       
 33980         * WebCore.pro:
       
 33981         * WebCore.xcodeproj/project.pbxproj:
       
 33982         * bindings/js/JSHTMLElementWrapperFactory.cpp:
       
 33983         (WebCore::createJSHTMLWrapper):
       
 33984         * bindings/js/kjs_html.cpp:
       
 33985         (KJS::):
       
 33986         (KJS::JSHTMLElement::classInfo):
       
 33987         (KJS::JSHTMLElement::accessors):
       
 33988         (KJS::HTMLElementFunction::callAsFunction):
       
 33989         * bindings/js/kjs_html.h:
       
 33990         (KJS::JSHTMLElement::):
       
 33991         * html/HTMLTableCaptionElement.idl:
       
 33992         * html/HTMLTableCellElement.idl:
       
 33993         * html/HTMLTableColElement.idl:
       
 33994         * html/HTMLTableElement.idl:
       
 33995         * html/HTMLTableRowElement.idl:
       
 33996         * html/HTMLTableSectionElement.idl:
       
 33997         * page/DOMWindow.idl:
       
 33998 
       
 33999 2007-05-18  Oliver Hunt  <oliver@apple.com>
       
 34000 
       
 34001         Reviewed by Sam.
       
 34002 
       
 34003         Fix for <rdar://problem/5211122> DRT crash below
       
 34004         SVGTimer::applyAnimations when page cache is enabled 
       
 34005         (SVG animation timers do not properly cancel themselves)
       
 34006 
       
 34007         There were still a few paths in the SVG Animation code
       
 34008         that could cause timers to be created and used.  This 
       
 34009         patch inserts addition SVG_EXPERIMENTAL blocks to prevent
       
 34010         these timers from being used.
       
 34011 
       
 34012         * ksvg2/misc/SVGDocumentExtensions.cpp:
       
 34013         (WebCore::SVGDocumentExtensions::startAnimations):
       
 34014         * ksvg2/misc/SVGTimer.cpp:
       
 34015         (WebCore::SVGTimer::animationsByElement):
       
 34016         (WebCore::SVGTimer::applyAnimations):
       
 34017         (WebCore::SVGTimer::notifyAll):
       
 34018         (WebCore::SVGTimer::addNotify):
       
 34019         (WebCore::SVGTimer::removeNotify):
       
 34020         * ksvg2/misc/TimeScheduler.cpp:
       
 34021         (WebCore::TimeScheduler::addTimer):
       
 34022         (WebCore::TimeScheduler::connectIntervalTimer):
       
 34023         (WebCore::TimeScheduler::disconnectIntervalTimer):
       
 34024         (WebCore::TimeScheduler::startAnimations):
       
 34025         (WebCore::TimeScheduler::toggleAnimations):
       
 34026         (WebCore::TimeScheduler::timerFired):
       
 34027         * ksvg2/svg/SVGAnimationElement.h:
       
 34028 
       
 34029 2007-05-18  Marius Bugge Monsen <mbm@trolltech.com>
       
 34030 
       
 34031         Reviewed by Zack Rusin. 
       
 34032 
       
 34033         Return a valid pointer to a Clipboard object
       
 34034         from newGeneralClipboard. 
       
 34035 
       
 34036         * editing/qt/EditorQt.cpp:
       
 34037         (WebCore::Editor::newGeneralClipboard):
       
 34038 
       
 34039 2007-05-18  Mark Rowe  <mrowe@apple.com>
       
 34040 
       
 34041         Attempt to fix the Gdk build after r21562.
       
 34042 
       
 34043         * platform/gdk/TemporaryLinkStubs.cpp:
       
 34044         (Widget::isEnabled):
       
 34045         * platform/gdk/WidgetGdk.cpp:
       
 34046 
       
 34047 2007-05-18  Adam Treat <treat@kde.org>
       
 34048 
       
 34049         Reviewed by Lars
       
 34050 
       
 34051         Remove dead code.
       
 34052 
       
 34053         * platform/Widget.h:
       
 34054         * platform/mac/WidgetMac.mm:
       
 34055         * platform/qt/WidgetQt.cpp:
       
 34056 
       
 34057 2007-05-18  Holger Freyther  <zecke@selfish.org>
       
 34058 
       
 34059         Reviewed by Maciej.
       
 34060 
       
 34061         Return true to make loading of pages working again
       
 34062 
       
 34063         * loader/gdk/FrameLoaderClientGdk.cpp:
       
 34064         (WebCore::FrameLoaderClientGdk::canHandleRequest):
       
 34065 
       
 34066 2007-05-18  Holger Freyther  <zecke@selfish.org>
       
 34067 
       
 34068         Reviewed by Maciej.
       
 34069 
       
 34070         Make WebCore::Widget use GtkWidget to fix focus handling.
       
 34071 
       
 34072         * WebCore.pro: Add PlatformScrollBar
       
 34073         * platform/ScrollView.h: Gtk stuff
       
 34074         * platform/Widget.h: Take a GtkWidget
       
 34075         * platform/gdk/PlatformScrollBarGdk.cpp: Added.
       
 34076         (PlatformScrollbar::PlatformScrollbar):
       
 34077         (PlatformScrollbar::~PlatformScrollbar):
       
 34078         (PlatformScrollbar::width):
       
 34079         (PlatformScrollbar::height):
       
 34080         (PlatformScrollbar::setEnabled):
       
 34081         (PlatformScrollbar::paint):
       
 34082         (PlatformScrollbar::updateThumbPosition):
       
 34083         (PlatformScrollbar::updateThumbProportion):
       
 34084         (PlatformScrollbar::setRect):
       
 34085         * platform/gdk/ScreenGdk.cpp: Implement depth handling
       
 34086         (WebCore::screenDepth):
       
 34087         * platform/gdk/ScrollViewGdk.cpp: use setGtkWidget, not setDrawable
       
 34088         (WebCore::ScrollView::setGtkWidget):
       
 34089         * platform/gdk/TemporaryLinkStubs.cpp:
       
 34090         * platform/gdk/WidgetGdk.cpp:
       
 34091         (WebCore::Widget::Widget):
       
 34092         (WebCore::Widget::gtkWidget):
       
 34093         (WebCore::Widget::setGtkWidget):
       
 34094         (WebCore::Widget::hasFocus):
       
 34095         (WebCore::Widget::setFocus):
       
 34096 
       
 34097 2007-05-18  Lars Knoll  <lars@trolltech.com>
       
 34098 
       
 34099         Reviewed by Zack
       
 34100 
       
 34101         Correctly implement initialiseSupportedImageMIMETypes.
       
 34102 
       
 34103         * platform/MimeTypeRegistry.cpp:
       
 34104         (WebCore::initialiseSupportedImageMIMETypes):
       
 34105         * platform/qt/MimeTypeRegistryQt.cpp:
       
 34106         (WebCore::):
       
 34107 
       
 34108 2007-05-18  Holger Hans Peter Freyther  <zecke@selfish.org>
       
 34109 
       
 34110         Reviewed by Maciej.
       
 34111 
       
 34112         Build fix for non-Qt and non-Mac ports.
       
 34113 
       
 34114         * html/HTMLCanvasElement.h:
       
 34115 
       
 34116 2007-05-18  Holger Hans Peter Freyther  <zecke@selfish.org>
       
 34117 
       
 34118         Reviewed by Mark Rowe.
       
 34119 
       
 34120         No test added as this is hard to time.
       
 34121 
       
 34122         * platform/gdk/FrameGdk.cpp: Use needsLayout() to decide if layout()
       
 34123         is needed.
       
 34124 
       
 34125         (WebCore::FrameGdk::dumpRenderTree):
       
 34126         (WebCore::FrameGdk::handleGdkEvent):
       
 34127 
       
 34128 2007-05-18  Simon Hausmann  <hausmann@kde.org>
       
 34129 
       
 34130         Reviewed by Lars.
       
 34131 
       
 34132         * WebCore.pro: Create a pkg-config file to make it easier to locate
       
 34133         and use WebKitQt.
       
 34134 
       
 34135 2007-05-18  Lars Knoll <lars@trolltech.com>
       
 34136 
       
 34137         Reviewed by Hyatt.
       
 34138 
       
 34139         Remove unused handleMouseEvent methods in the Widget
       
 34140         and derived classes.
       
 34141 
       
 34142         * page/EventHandler.cpp:
       
 34143         (WebCore::EventHandler::handleMouseMoveEvent):
       
 34144         * page/FrameView.cpp:
       
 34145         * page/FrameView.h:
       
 34146         * page/mac/EventHandlerMac.mm:
       
 34147         (WebCore::EventHandler::mouseDragged):
       
 34148         (WebCore::EventHandler::mouseMoved):
       
 34149         * platform/ScrollBar.h:
       
 34150         * platform/Widget.h:
       
 34151         * platform/win/PlatformScrollBar.h:
       
 34152         * platform/win/TemporaryLinkStubs.cpp:
       
 34153         (WebCore::PlatformScrollbar::setRect):
       
 34154         * platform/wx/PlatformScrollBar.h:
       
 34155 
       
 34156 2007-05-18  George Staikos  <staikos@kde.org>
       
 34157 
       
 34158         Reviewed by Lars.
       
 34159 
       
 34160         Use the proper clipping algorithm.  Might be a bit slow but we
       
 34161         can optimize it later.
       
 34162 
       
 34163         * platform/graphics/qt/GraphicsContextQt.cpp:
       
 34164         (WebCore::GraphicsContext::clip):
       
 34165 
       
 34166 2007-05-17  Sam Weinig  <sam@webkit.org>
       
 34167 
       
 34168         Reviewed by George Staikos.
       
 34169 
       
 34170         Fix Qt build after adding JSHTMLAnchorElementCustom.cpp. 
       
 34171 
       
 34172         * WebCore.pro:
       
 34173 
       
 34174 2007-05-17  George Staikos  <staikos@kde.org>
       
 34175 
       
 34176         Reviewed by hyatt.
       
 34177 
       
 34178         Fix preprocessor logic for CG/QT
       
 34179 
       
 34180         * html/HTMLCanvasElement.cpp:
       
 34181         (WebCore::HTMLCanvasElement::reset):
       
 34182 
       
 34183 2007-05-17  David Hyatt  <hyatt@apple.com>
       
 34184 
       
 34185         Add a line gutter to view source mode.  The gutter uses counters, and this exposed the fact
       
 34186         that pseudoStyleForElement was not walking all UA rules properly.
       
 34187 
       
 34188         Reviewed by aroben
       
 34189 
       
 34190         * css/cssstyleselector.cpp:
       
 34191         (WebCore::CSSStyleSelector::pseudoStyleForElement):
       
 34192         * css/view-source.css:
       
 34193         * html/HTMLViewSourceDocument.cpp:
       
 34194         (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
       
 34195         (WebCore::HTMLViewSourceDocument::addViewSourceToken):
       
 34196         (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
       
 34197         (WebCore::HTMLViewSourceDocument::addLine):
       
 34198         (WebCore::HTMLViewSourceDocument::addText):
       
 34199         * html/HTMLViewSourceDocument.h:
       
 34200 
       
 34201 2007-05-17  Justin Garcia  <justin.garcia@apple.com>
       
 34202 
       
 34203         Reviewed by ggaren
       
 34204 
       
 34205         <rdar://problem/5209984> REGRESSION: Crash on click after clearing Facebook status
       
 34206         
       
 34207         comparePositions() expects non-null positions.  It's 
       
 34208         given a null position by contains() if the current 
       
 34209         selection is a range selection but contains only invisible 
       
 34210         content *and* visible positions cannot be created from its 
       
 34211         end points.  This can happen when there is a range selection 
       
 34212         inside shadow content (like that inside text fields) that 
       
 34213         is made invisible.
       
 34214 
       
 34215         * editing/SelectionController.cpp:
       
 34216         (WebCore::SelectionController::contains): Check for
       
 34217         invisible end points.
       
 34218 
       
 34219 2007-05-17  Sam Weinig  <sam@webkit.org>
       
 34220 
       
 34221         Reviewed by Adam.
       
 34222 
       
 34223         Fix for <rdar://problem/5201423> REGRESSION: Links in 
       
 34224         sidebar don't work on Honda website
       
 34225 
       
 34226         Anchor elements need to have the same behavior for implicit and 
       
 34227         explicit toString() calls.
       
 34228 
       
 34229         Test: fast/dom/anchor-toString.html
       
 34230 
       
 34231         * WebCore.xcodeproj/project.pbxproj:
       
 34232         * bindings/js/JSHTMLAnchorElementCustom.cpp: Added.
       
 34233         (WebCore::JSHTMLAnchorElement::toString):
       
 34234         * html/HTMLAnchorElement.idl:
       
 34235 
       
 34236 2007-05-17  Geoffrey Garen  <ggaren@apple.com>
       
 34237         
       
 34238         Build fix.
       
 34239 
       
 34240 2007-05-17  Adele Peterson  <adele@apple.com>
       
 34241 
       
 34242         Reviewed by Hyatt.
       
 34243 
       
 34244         Update RenderMenuList PopupClient methods to consider style of inner block.
       
 34245 
       
 34246         * rendering/RenderMenuList.cpp:
       
 34247         (WebCore::RenderMenuList::itemStyle):
       
 34248         (WebCore::RenderMenuList::clientStyle):
       
 34249 
       
 34250 2007-05-17  Maciej Stachowiak  <mjs@apple.com>
       
 34251 
       
 34252         Not reviewed, emergency test fix.
       
 34253 
       
 34254         - avoid crash on layout tests.
       
 34255         
       
 34256         Patched up my last change so that  widgets don't crash.
       
 34257 
       
 34258         * loader/FrameLoader.cpp:
       
 34259         (WebCore::FrameLoader::mainReceivedCompleteError):
       
 34260 
       
 34261 2007-05-17  Antti Koivisto  <antti@apple.com>
       
 34262 
       
 34263         Reviewed by Darin.
       
 34264 
       
 34265         Fix for http://bugs.webkit.org/show_bug.cgi?id=13727
       
 34266         REGRESSION: Reproducible hang setting the selection's extent offset to -1
       
 34267         <rdar://problem/5206890>
       
 34268         
       
 34269         Rise INDEX_SIZE_ERR if used selection index is negative. This matches HTML5 for
       
 34270         getRangeAt() and collapse() which are part of the spec (FF throws NS_ERROR_FAILURE). 
       
 34271         
       
 34272         Not throwing exceptions yet for too high offsets (except getRangeAt()) as it is
       
 34273         unclear if WebCore's definition of offsets is the same as other browsers.
       
 34274 
       
 34275         * bindings/js/kjs_window.cpp:
       
 34276         * WebCore/editing/SelectionController.cpp:
       
 34277         * WebCore/editing/SelectionController.h:
       
 34278         * WebCore/editing/VisiblePosition.cpp:
       
 34279         
       
 34280 2007-05-17  Adele Peterson  <adele@apple.com>
       
 34281 
       
 34282         Reviewed by Mitz.
       
 34283 
       
 34284         Fix for <rdar://problem/5096035> REGRESSION: rtl text should be left-aligned in <select>s
       
 34285 
       
 34286         Test: fast/text/international/bidi-menulist.html
       
 34287 
       
 34288         * rendering/RenderMenuList.cpp:
       
 34289         (WebCore::RenderMenuList::adjustInnerStyle): Set the inner block style to direction: ltr, and text-align: left.  This means that
       
 34290          we will ignore those settings in the button to match the way the text is displayed in the popup menu.
       
 34291         (WebCore::RenderMenuList::createInnerBlock): Call adjustInnerStyle.
       
 34292         (WebCore::RenderMenuList::setStyle): ditto.
       
 34293         * rendering/RenderMenuList.h: Added adjustInnerStyle.
       
 34294 
       
 34295 2007-05-17  Justin Garcia  <justin.garcia@apple.com>
       
 34296 
       
 34297         Reviewed by harrison
       
 34298 
       
 34299         <rdar://problem/4924441> List becomes nested when changing its type
       
 34300         <rdar://problem/5210032> Content before a list is placed at the end of the list when its made into a list item
       
 34301         <rdar://problem/5207369> Crash when removing ordering from a nested list
       
 34302 
       
 34303         * editing/InsertListCommand.cpp:
       
 34304         (WebCore::InsertListCommand::doApply):
       
 34305         The outermostEnclosingList of the position before the start isn't
       
 34306         the previousList if it contains the start.
       
 34307         Ditto for the position after the end and the nextList.
       
 34308         If we're putting the newly created list item into the next list,
       
 34309         insert it at the start of that list, not the end (don't append).
       
 34310         Avoid nesting newly created lists inside list items.
       
 34311         
       
 34312 2007-05-17  Patti Hoa  <patti@apple.com>
       
 34313 
       
 34314         Reviewed by Darin.
       
 34315         
       
 34316         <rdar://problem/4775672> AXTextMarkerRangeForUnorderedTextMarkers returns incorrect order
       
 34317         
       
 34318         * bridge/mac/WebCoreAXObject.mm:
       
 34319         (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
       
 34320         A selection's m_start is not guranteed to equal m_base since m_start can actually be m_base's downstream().
       
 34321         A more accurate way to determine the order from selection is to ask directly for isBaseFirst().
       
 34322         In addition, if the two visible positions given are the same position but different affinity, we need to 
       
 34323         handle it here rather than depend on the selection. This is because selection does not retain the
       
 34324         affinity of both selection start/end visible positions as part of the selection validation. 
       
 34325 
       
 34326 2007-05-17  Mitz Pettel  <mitz@webkit.org>
       
 34327 
       
 34328         Reviewed by Brady
       
 34329 
       
 34330         - fix http://bugs.webkit.org/show_bug.cgi?id=13759
       
 34331           REGRESSION (r20182-r20184): Incorrect rendering of multipart images
       
 34332 
       
 34333         Test: http/tests/multipart/invalid-image-data.html
       
 34334 
       
 34335         * loader/loader.cpp:
       
 34336         (WebCore::Loader::didReceiveData): Make a copy of the current part's data
       
 34337         instead of using the resource data, because the latter is going to be
       
 34338         overwritten by the new part being received.
       
 34339 
       
 34340 2007-05-17  Oliver Hunt  <oliver@apple.com>
       
 34341 
       
 34342         Reviewed by Justin.
       
 34343 
       
 34344         Fix for <rdar://problem/4244861> Safari fails to create image file
       
 34345         after releasing dragged image that has changed on source page
       
 34346 
       
 34347         Tell xcode to copy HTMLImageElement.h and HTMLImageLoader.h headers
       
 34348         across to WebKit as private headers.
       
 34349 
       
 34350         * WebCore.xcodeproj/project.pbxproj:
       
 34351 
       
 34352 2007-05-17  Justin Garcia  <justin.garcia@apple.com>
       
 34353 
       
 34354         Reviewed by harrison
       
 34355 
       
 34356         <rdar://problem/5190926> 
       
 34357         Gmail Editor: Crash when removing list style from underlined, multi-item list
       
 34358         
       
 34359         The user underlined some text, then created a list.
       
 34360         The list was placed inside the inline element carrying 
       
 34361         the underline style, so, that element surrounded the 
       
 34362         list instead of being at the lowest level (just above 
       
 34363         text nodes). This kind of markup is more difficult to 
       
 34364         edit. Filed 5192089 and added a workaround so that we 
       
 34365         don't produce this kind of markup.
       
 34366 
       
 34367         * editing/InsertListCommand.cpp:
       
 34368         (WebCore::InsertListCommand::doApply): Avoid inline
       
 34369         elements when inserting the new list.
       
 34370 
       
 34371 2007-05-17  David Hyatt  <hyatt@apple.com>
       
 34372 
       
 34373         Allow redundant attributes with the same name in view source mode.
       
 34374 
       
 34375         Reviewed by aroben
       
 34376 
       
 34377         * dom/NamedAttrMap.h:
       
 34378         (WebCore::NamedAttrMap::insertAttribute):
       
 34379         * html/HTMLTokenizer.cpp:
       
 34380         (WebCore::Token::addAttribute):
       
 34381 
       
 34382 2007-05-17  George Staikos  <staikos@kde.org>
       
 34383 
       
 34384         - Back out last patch based on discussion with Zack.
       
 34385 
       
 34386         * platform/qt/WidgetQt.cpp:
       
 34387         (WebCore::Widget::paint):
       
 34388 
       
 34389 2007-05-16  Anders Carlsson  <andersca@apple.com>
       
 34390 
       
 34391         Reviewed by Darin.
       
 34392 
       
 34393         <rdar://problem/5207156> Hamachi test tool causes assertion in FormCompletionController in Safari
       
 34394 
       
 34395         This happens because the form delegate gets passed the wrong source frame during the second submit().
       
 34396         If a frame with the given name is found, FrameLoader::load is called with the same parameters on the found frame.
       
 34397         This causes the found frame to be used as the source frame, which is wrong.
       
 34398         
       
 34399         The fix is to create the form state object before checking what frame to load the new request in. 
       
 34400         
       
 34401         * WebCore.exp:
       
 34402         * loader/FrameLoader.cpp:
       
 34403         (WebCore::FrameLoader::load):
       
 34404         (WebCore::FrameLoader::checkNavigationPolicy):
       
 34405         (WebCore::FrameLoader::continueAfterNavigationPolicy):
       
 34406         * loader/FrameLoader.h:
       
 34407         * manual-tests/submit-form-with-target-twice.html: Added.
       
 34408 
       
 34409 2007-05-16  Maciej Stachowiak  <mjs@apple.com>
       
 34410 
       
 34411         Reviewed by Oliver.
       
 34412 
       
 34413         <rdar://problem/5205914> REGRESSION: PLT stops after loading first page due to r21479
       
 34414         
       
 34415         * loader/FrameLoader.cpp:
       
 34416         (WebCore::FrameLoader::frameHasLoaded):
       
 34417 
       
 34418 2007-05-16  David Hyatt  <hyatt@apple.com>
       
 34419 
       
 34420         Improve the syntax-highlighted view source mode.  It now preserves all whitespace properly
       
 34421         and highlights doctypes and comments (in addition to all the stuff it could highlight before).
       
 34422 
       
 34423         Reviewed by aroben
       
 34424 
       
 34425         * html/HTMLTokenizer.cpp:
       
 34426         (WebCore::Token::addAttribute):
       
 34427         (WebCore::HTMLTokenizer::parseTag):
       
 34428         * html/HTMLTokenizer.h:
       
 34429         (WebCore::Token::Token):
       
 34430         (WebCore::Token::~Token):
       
 34431         (WebCore::Token::reset):
       
 34432         (WebCore::Token::addViewSourceChar):
       
 34433         * html/HTMLViewSourceDocument.cpp:
       
 34434         (WebCore::HTMLViewSourceDocument::addViewSourceToken):
       
 34435         * html/HTMLViewSourceDocument.h:
       
 34436 
       
 34437 2007-05-16  Maciej Stachowiak  <mjs@apple.com>
       
 34438 
       
 34439         Reviewed by Adam.
       
 34440 
       
 34441         <rdar://problem/5191024> Page never loads completely (emonome.vodpod.com)
       
 34442         <rdar://problem/5205162> REGRESSION (r21367): In the Address URL field, typing a site name doesn't redirect to site after pressing return
       
 34443         http://bugs.webkit.org/show_bug.cgi?id=13683
       
 34444         <rdar://problem/5208951> REGRESSION: Progress bar never completes on link click that downloads (13694)
       
 34445         http://bugs.webkit.org/show_bug.cgi?id=13694
       
 34446         <rdar://problem/5201598> REGRESSION: After uploading file to iDisk at mac.com, "loading" status remains and file does not appear in the list
       
 34447         
       
 34448         * loader/FrameLoader.cpp:
       
 34449         (WebCore::FrameLoader::mainReceivedCompleteError): Make sure to always check whether the overall
       
 34450         load completed, even if we think the current frame load is already complete.
       
 34451 
       
 34452 2007-05-16  Beth Dakin  <bdakin@apple.com>
       
 34453 
       
 34454         Reviewed by Hyatt.
       
 34455 
       
 34456         Fix for <rdar://problem/5204107> REGRESSION: CSS web forum site 
       
 34457         layout not displaying properly in latest WebKit
       
 34458 
       
 34459         Hyatt's http://trac.webkit.org/projects/webkit/changeset/21428 
       
 34460         exposed this bug. We were not handling error cases with <caption> 
       
 34461         correctly. This patch makes them do the same thing as colgroup.
       
 34462 
       
 34463         * html/HTMLParser.cpp:
       
 34464         (WebCore::HTMLParser::handleError):
       
 34465         * html/HTMLParserErrorCodes.cpp: No need any more for caption-
       
 34466         specific errors.
       
 34467         (WebCore::htmlParserErrorMessageTemplate):
       
 34468         * html/HTMLParserErrorCodes.h:
       
 34469         (WebCore::):
       
 34470 
       
 34471 2007-05-16  Kevin McCullough  <kmccullough@apple.com>
       
 34472 
       
 34473         Reviewed by Darin and Geoff.
       
 34474 
       
 34475         - rdar://problem/4981886
       
 34476         - Now windows opened by the DOM can be closed by JS.
       
 34477 
       
 34478         * bindings/js/kjs_window.cpp:
       
 34479         (KJS::createNewWindow):
       
 34480         (KJS::WindowFunc::callAsFunction):
       
 34481         * loader/FrameLoader.cpp:
       
 34482         (WebCore::FrameLoader::FrameLoader):
       
 34483         (WebCore::FrameLoader::openedByDOM):
       
 34484         (WebCore::FrameLoader::setOpenedByDOM):
       
 34485         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
       
 34486         * loader/FrameLoader.h:
       
 34487 
       
 34488 2007-05-16  Darin Adler  <darin@apple.com>
       
 34489 
       
 34490         Reviewed by Hyatt.
       
 34491 
       
 34492         - fix <rdar://problem/4928671> Crash due to runaway recursion when fieldset has display: table-row (12066)
       
 34493 
       
 34494         Test: fast/css/fieldset-display-row.html
       
 34495 
       
 34496         * rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild):
       
 34497         Change all decision making about special handling for new children to use
       
 34498         the class of the render object instead of the style, except for the cases
       
 34499         where the style is the only way to tell (TABLE_COLUMN_GROUP and TABLE_CAPTION).
       
 34500         Thus a RenderFieldset with table-row style won't get handled as if it was
       
 34501         a table row.
       
 34502 
       
 34503         * rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Same thing.
       
 34504         Except that here the styles that we ahave to look at are TABLE_CAPTION,
       
 34505         TABLE_HEADER_GROUP, TABLE_FOOTER_GROUP, and TABLE_ROW_GROUP.
       
 34506 
       
 34507 2007-05-16  Zack Rusin  <zrusin@trolltech.com>
       
 34508 
       
 34509         Reviewed by Lars.
       
 34510 
       
 34511         Implement bigger parts of the Canvas element in the
       
 34512         Qt port. Gradients and patterns are missing.
       
 34513 
       
 34514         * WebCore/html/CanvasRenderingContext2D.cpp:
       
 34515         * WebCore/html/CanvasStyle.cpp:
       
 34516         * WebCore/html/HTMLCanvasElement.cpp:
       
 34517         * WebCore/html/HTMLCanvasElement:
       
 34518 
       
 34519 2007-05-16  Zack Rusin  <zrusin@trolltech.com>
       
 34520 
       
 34521         Reviewed by Lars
       
 34522 
       
 34523         Fix shared timers, make them use miliseconds. Based
       
 34524         on a patch from George.
       
 34525 
       
 34526         * WebCore/platform/qt/SharedTimerQt.cpp:
       
 34527        (WebCore::setSharedTimerFireTime):
       
 34528 
       
 34529 2007-05-16  David Hyatt  <hyatt@apple.com>
       
 34530 
       
 34531         Add rudimentary error reporting to the HTML parser.  This is disabled
       
 34532         for now until it gets beefed up a bit more (and until we work out how
       
 34533         best to pass the messages up without hurting perf).
       
 34534 
       
 34535         Clean up and remove dead error handling code and incorrect error handling
       
 34536         code as well.
       
 34537 
       
 34538         Reviewed by mjs
       
 34539 
       
 34540         * WebCore.xcodeproj/project.pbxproj:
       
 34541         * html/HTMLParser.cpp:
       
 34542         (WebCore::HTMLParser::HTMLParser):
       
 34543         (WebCore::HTMLParser::handleError):
       
 34544         (WebCore::HTMLParser::headCreateErrorCheck):
       
 34545         (WebCore::HTMLParser::reportErrorToConsole):
       
 34546         * html/HTMLParser.h:
       
 34547         (WebCore::HTMLParser::reportError):
       
 34548         * html/HTMLParserErrorCodes.cpp: Added.
       
 34549         (WebCore::htmlParserErrorMessageTemplate):
       
 34550         * html/HTMLParserErrorCodes.h: Added.
       
 34551         (WebCore::):
       
 34552         * html/HTMLTokenizer.h:
       
 34553         (WebCore::HTMLTokenizer::tagStartLineNumber):
       
 34554 
       
 34555 2007-05-15  David Hyatt  <hyatt@apple.com>
       
 34556 
       
 34557         Make FrameLoader write "<html><body>" instead of just "<body>".
       
 34558 
       
 34559         Reviewed by aroben
       
 34560 
       
 34561         * loader/FrameLoader.cpp:
       
 34562         (WebCore::FrameLoader::init):
       
 34563 
       
 34564 2007-05-15  George Staikos  <staikos@kde.org>
       
 34565 
       
 34566         Reviewed by Adam Roben.
       
 34567 
       
 34568         - Pass cookies through from the loader.
       
 34569 
       
 34570         * platform/network/qt/ResourceHandleManagerQt.cpp:
       
 34571         (WebCore::ResourceHandleManager::receivedResponse):
       
 34572 
       
 34573 2007-05-15  Adam Treat  <adam@staikos.net>
       
 34574 
       
 34575         Reviewed by George Staikos.
       
 34576 
       
 34577         - Implement drawArc with proper units.
       
 34578 
       
 34579         * platform/graphics/qt/GraphicsContextQt.cpp:
       
 34580         (WebCore::GraphicsContext::strokeArc):
       
 34581 
       
 34582 2007-05-15  Adam Treat  <adam@staikos.net>
       
 34583 
       
 34584         Reviewed by George Staikos.
       
 34585 
       
 34586         - Add missing paint for nested subframes.
       
 34587 
       
 34588         * platform/qt/WidgetQt.cpp:
       
 34589         (WebCore::Widget::paint):
       
 34590 
       
 34591 2007-05-15  Sam Weinig  <sam@webkit.org>
       
 34592 
       
 34593         Reviewed by Oliver.
       
 34594 
       
 34595         - Patch for http://bugs.webkit.org/show_bug.cgi?id=13722
       
 34596           Finish testing and fixing the setting of DOM attributes to JS null
       
 34597 
       
 34598           Convert JS null to null string for SVG attributes.
       
 34599 
       
 34600         Test: fast/dom/svg-element-attribute-js-null.xhtml
       
 34601 
       
 34602         * ksvg2/svg/SVGAngle.idl:
       
 34603         * ksvg2/svg/SVGElement.idl:
       
 34604         * ksvg2/svg/SVGLength.idl:
       
 34605         * ksvg2/svg/SVGScriptElement.idl:
       
 34606 
       
 34607 2007-05-15  Sam Weinig  <sam@webkit.org>
       
 34608 
       
 34609         Reviewed by Oliver.
       
 34610 
       
 34611         - Patch for http://bugs.webkit.org/show_bug.cgi?id=13722
       
 34612           Finish testing and fixing the setting of DOM attributes to JS null
       
 34613 
       
 34614           Convert JS null to null string for CanvasRenderingContext2D attributes.
       
 34615 
       
 34616         Test: fast/dom/canvasContext2d-element-attribute-js-null.html
       
 34617 
       
 34618         * html/CanvasRenderingContext2D.idl:
       
 34619 
       
 34620 2007-05-15  Oliver Hunt  <oliver@apple.com>
       
 34621 
       
 34622         Reviewed by Sam and Geoff.
       
 34623 
       
 34624         Removing dead code left behind from drag and drop refactoring.
       
 34625 
       
 34626         * page/mac/WebCoreFrameBridge.h:
       
 34627 
       
 34628 2007-05-15  Sam Weinig  <sam@webkit.org>
       
 34629 
       
 34630         Reviewed by Oliver.
       
 34631 
       
 34632         - Second Patch for http://bugs.webkit.org/show_bug.cgi?id=13722
       
 34633           Finish testing and fixing the setting of DOM attributes to JS null
       
 34634 
       
 34635           Convert JS null to null string for remaining CSSOM attributes.
       
 34636 
       
 34637         Test: fast/dom/css-element-attribute-js-null.html
       
 34638 
       
 34639         * bindings/js/kjs_css.cpp:
       
 34640         (KJS::DOMCSSStyleDeclaration::put):
       
 34641         (KJS::DOMMediaList::put):
       
 34642         (KJS::DOMCSSRule::putValueProperty):
       
 34643         (KJS::DOMCSSValue::put):
       
 34644         * css/CSSPageRule.idl:
       
 34645         * css/CSSRule.idl:
       
 34646         * css/CSSStyleDeclaration.idl:
       
 34647         * css/CSSStyleRule.idl:
       
 34648         * css/CSSValue.idl:
       
 34649         * css/MediaList.idl:
       
 34650 
       
 34651 2007-05-15  Darin Adler  <darin@apple.com>
       
 34652 
       
 34653         Reviewed by Hyatt.
       
 34654 
       
 34655         * css/html4.css: Remove wbr style rule -- not needed any more.
       
 34656 
       
 34657 2007-05-15  Mitz Pettel  <mitz@webkit.org>
       
 34658 
       
 34659         Reviewed by Brady
       
 34660 
       
 34661         - fix http://bugs.webkit.org/show_bug.cgi?id=13360
       
 34662           REGRESSION: Crash closing live web cam viewer page
       
 34663 
       
 34664         Test: http/tests/misc/multipart.html
       
 34665 
       
 34666         * loader/ResourceLoader.cpp:
       
 34667         (WebCore::ResourceLoader::didFail): Avoid calling didFailToLoad() if
       
 34668         didFinishLoad() has already been called (when the first part of a
       
 34669         multipart resource arrived).
       
 34670         (WebCore::ResourceLoader::didCancel): Ditto.
       
 34671 
       
 34672 2007-05-15  Sam Weinig  <sam@webkit.org>
       
 34673 
       
 34674         Reviewed by Darin.
       
 34675 
       
 34676         - Patch for http://bugs.webkit.org/show_bug.cgi?id=13722
       
 34677           Finish testing and fixing the setting of DOM attributes to JS null
       
 34678 
       
 34679           Convert JS null to null string for remaining Core DOM attributes.
       
 34680 
       
 34681         Test: fast/dom/coreDOM-element-attribute-js-null.xhtml
       
 34682 
       
 34683         * dom/Attr.cpp:
       
 34684         (WebCore::Attr::setValue): Don't throw an expection for null values as this
       
 34685         is not in the spec and Firefox does not do it either.
       
 34686         * dom/Attr.idl:
       
 34687         * dom/CharacterData.idl:
       
 34688         * dom/ProcessingInstruction.idl:
       
 34689 
       
 34690 2007-05-15  Mitz Pettel  <mitz@webkit.org>
       
 34691 
       
 34692         Reviewed by Hyatt.
       
 34693 
       
 34694         - fix http://bugs.webkit.org/show_bug.cgi?id=13718
       
 34695           REGRESSION (r21093): editing/execCommand/5136770.html failing pixel test
       
 34696 
       
 34697         * rendering/RenderContainer.cpp:
       
 34698         (WebCore::RenderContainer::removeChildNode): Moved the code that clears the
       
 34699         selection when moving a selection border into the fast path.
       
 34700 
       
 34701 2007-05-15  Rob Buis  <buis@kde.org>
       
 34702 
       
 34703         Reviewed by Hyatt.
       
 34704 
       
 34705         http://bugs.webkit.org/show_bug.cgi?id=6487
       
 34706         "Make Text Bigger/Smaller" affects SVGs when it probably shouldn't
       
 34707 
       
 34708         Ignore Make Text Bigger/Smaller for SVG text.
       
 34709 
       
 34710         * css/svg.css:
       
 34711 
       
 34712 2007-05-15  Anders Carlsson  <andersca@apple.com>
       
 34713 
       
 34714         Reviewed by Maciej.
       
 34715 
       
 34716         <rdar://problem/5183685>
       
 34717         http://bugs.webkit.org/show_bug.cgi?id=13301
       
 34718         ASSERT or null value when trying to use a getter defined on a window object
       
 34719 
       
 34720         Handle the case where the value returned is a getter/setter object.
       
 34721         
       
 34722         * bindings/js/kjs_window.cpp:
       
 34723         (KJS::Window::getOverridePropertySlot):
       
 34724 
       
 34725 2007-05-14  Anders Carlsson  <andersca@apple.com>
       
 34726 
       
 34727         Reviewed by Geoff.
       
 34728 
       
 34729         <rdar://problem/5200816>
       
 34730         REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )
       
 34731         
       
 34732         Shiira under some circumstances passes nil as the request to -[WebFrame loadRequest:]. ToT WebKit doesn't call any policy
       
 34733         delegate methods in this case, which means that the page is actually being loaded. 
       
 34734         
       
 34735         This patch makes ToT WebKit behave in the same way as Tiger WebKit when the request is nil.
       
 34736         
       
 34737         * loader/FrameLoader.cpp:
       
 34738         (WebCore::FrameLoader::checkNavigationPolicy):
       
 34739         Don't continue without calling the navigation policy method if the request is null.
       
 34740         
       
 34741         (WebCore::FrameLoader::continueAfterNavigationPolicy):
       
 34742         If the request can't be handled, don't continue the load.
       
 34743         
       
 34744         * platform/network/mac/ResourceRequestMac.mm:
       
 34745         (WebCore::ResourceRequest::doUpdatePlatformRequest):
       
 34746         Don't create an NSURLRequest object if the request is null.
       
 34747 
       
 34748 2007-05-15  Maciej Stachowiak  <mjs@apple.com>
       
 34749 
       
 34750         Reviewed by Hyatt and Lars.
       
 34751 
       
 34752         - fixed <rdar://problem/5201758> REGRESSION: Stop button enabled and other problems caused by [WebView currentURL] returning non-nil for empty window
       
 34753 
       
 34754         * WebCore.exp: export new symbol
       
 34755         * loader/FrameLoader.cpp:
       
 34756         (WebCore::FrameLoader::begin): move marker that we committed a real doc load from here...
       
 34757         (WebCore::FrameLoader::transitionToCommitted): ...to here
       
 34758         (WebCore::FrameLoader::frameHasLoaded): check that we have at least started loading something
       
 34759         besides the initial empty doc.
       
 34760         * loader/FrameLoader.h:
       
 34761 
       
 34762 2007-05-14  Justin Garcia  <justin.garcia@apple.com>
       
 34763 
       
 34764         Reviewed by ggaren
       
 34765         
       
 34766         <http://bugs.webkit.org/show_bug.cgi?id=13716>
       
 34767         REGRESSION: Three new layout test failures
       
 34768         
       
 34769         Two failures are correct.  Updated their expected results.
       
 34770         
       
 34771         In fast/events/frame-tab-focus.html, as we advance
       
 34772         through focusable nodes, we descend into a subframe
       
 34773         to focus a node and then ascend out of it into the
       
 34774         main frame to focus the next.  When we focus the main 
       
 34775         frame, the node in that frame that was previously 
       
 34776         focused and contains an inactive selection is focused 
       
 34777         momentarily because setCaretVisible tries to focus the 
       
 34778         node containing the caret.
       
 34779 
       
 34780         * page/Frame.cpp:
       
 34781         (WebCore::Frame::setCaretVisible): Don't focus the
       
 34782         node containing the caret. FocusController will focus
       
 34783         the previously focused node (which will contain the
       
 34784         caret) if necessary when the frame gains focus.
       
 34785         
       
 34786 2007-05-14  Maciej Stachowiak  <mjs@apple.com>
       
 34787 
       
 34788         Reviewed by Brady.
       
 34789 
       
 34790         - fixed <rdar://problem/5203036> REGRESSION: Assertion failure in WebCore::FrameLoader::restoreScrollPositionAndViewState() going back from fark.com Photoshop contest (13684)
       
 34791 
       
 34792         Test: http/tests/navigation/back-to-slow-frame.html
       
 34793         
       
 34794         * loader/FrameLoader.cpp:
       
 34795         (WebCore::FrameLoader::restoreScrollPositionAndViewState): Add needed early return.
       
 34796 
       
 34797 2007-05-14  Mitz Pettel  <mitz@webkit.org>
       
 34798 
       
 34799         Reviewed by Dave Hyatt.
       
 34800 
       
 34801         - fix http://bugs.webkit.org/show_bug.cgi?id=13603
       
 34802           style leaks in washingtonpost.com
       
 34803           also known as http://bugs.webkit.org/show_bug.cgi?id=8750
       
 34804           w3c.org: incorrect recovery from unclosed <a> elements
       
 34805           also known as http://bugs.webkit.org/show_bug.cgi?id=12808
       
 34806           Handling of misnested tags results in entire page appearing as link
       
 34807           also known as http://bugs.webkit.org/show_bug.cgi?id=12861
       
 34808           Post text renders as link
       
 34809 
       
 34810         Test: fast/parser/residual-style-close-across-n-blocks.html
       
 34811 
       
 34812         * html/HTMLParser.cpp:
       
 34813         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Changed to
       
 34814         deal with multiple block crossings instead of bailing out, by doing multiple
       
 34815         reparenting passes, starting from the outermost block.
       
 34816 
       
 34817 2007-05-14  Mitz Pettel  <mitz@webkit.org>
       
 34818 
       
 34819         Reviewed by Darin.
       
 34820 
       
 34821         - fix http://bugs.webkit.org/show_bug.cgi?id=13711
       
 34822           REGRESSION - Bookmark Bar text rendering changed
       
 34823 
       
 34824         No test possible since this patch affects only Safari chrome.
       
 34825 
       
 34826         * platform/Font.cpp:
       
 34827         (WebCore::Font::Font): Initialize m_isPlatformFont according to whether
       
 34828         the Font object is derived from a FontPlatformData or not.
       
 34829         * platform/Font.h:
       
 34830         (WebCore::Font::isPlatformFont): Added. Returns whether this Font was
       
 34831         derived from a platform font.
       
 34832         * platform/mac/FontCacheMac.mm:
       
 34833         (WebCore::FontCache::getFontDataForCharacters): Changed to not enable
       
 34834         synthetic bold and italic in the fallback fonts if the original font
       
 34835         was derived from a platform font.
       
 34836 
       
 34837 2007-05-14  Sam Weinig  <sam@webkit.org>
       
 34838 
       
 34839         Reviewed by Alice!
       
 34840 
       
 34841         - Patch for http://bugs.webkit.org/show_bug.cgi?id=13541
       
 34842           REGRESSION: Setting a DOMString attribute to JS null in the 
       
 34843           JS bindings should default to converting to the empty string
       
 34844 
       
 34845           Convert JS null to the empty string when passing it to an attribute that takes
       
 34846           a DOMString.
       
 34847 
       
 34848         Test: fast/dom/document-attribute-js-null.html
       
 34849         Test: fast/dom/element-attribute-js-null.html
       
 34850 
       
 34851         * bindings/js/kjs_dom.cpp:
       
 34852         (KJS::DOMNode::putValueProperty):
       
 34853         * bindings/js/kjs_html.cpp:
       
 34854         (KJS::JSHTMLDocument::putValueProperty):
       
 34855         (KJS::JSHTMLElement::objectSetter):
       
 34856         (KJS::JSHTMLElement::embedSetter):
       
 34857         (KJS::JSHTMLElement::tableSetter):
       
 34858         (KJS::JSHTMLElement::tableCaptionSetter):
       
 34859         (KJS::JSHTMLElement::tableColSetter):
       
 34860         (KJS::JSHTMLElement::tableSectionSetter):
       
 34861         (KJS::JSHTMLElement::tableRowSetter):
       
 34862         (KJS::JSHTMLElement::tableCellSetter):
       
 34863         (KJS::JSHTMLElement::frameSetSetter):
       
 34864         (KJS::JSHTMLElement::frameSetter):
       
 34865         (KJS::JSHTMLElement::iFrameSetter):
       
 34866         (KJS::JSHTMLElement::marqueeSetter):
       
 34867         (KJS::JSHTMLElement::putValueProperty):
       
 34868         * bindings/js/kjs_html.h:
       
 34869         * dom/Document.idl:
       
 34870         * dom/Node.idl:
       
 34871         * html/HTMLAnchorElement.idl:
       
 34872         * html/HTMLAppletElement.idl:
       
 34873         * html/HTMLAreaElement.idl:
       
 34874         * html/HTMLBRElement.idl:
       
 34875         * html/HTMLBaseElement.idl:
       
 34876         * html/HTMLBaseFontElement.idl:
       
 34877         * html/HTMLBlockquoteElement.idl:
       
 34878         * html/HTMLBodyElement.idl:
       
 34879         * html/HTMLButtonElement.idl:
       
 34880         * html/HTMLDivElement.idl:
       
 34881         * html/HTMLDocument.idl:
       
 34882         * html/HTMLElement.idl:
       
 34883         * html/HTMLEmbedElement.idl:
       
 34884         * html/HTMLFontElement.idl:
       
 34885         * html/HTMLFormElement.idl:
       
 34886         * html/HTMLFrameElement.idl:
       
 34887         * html/HTMLFrameSetElement.idl:
       
 34888         * html/HTMLHRElement.idl:
       
 34889         * html/HTMLHeadElement.idl:
       
 34890         * html/HTMLHeadingElement.idl:
       
 34891         * html/HTMLHtmlElement.idl:
       
 34892         * html/HTMLIFrameElement.idl:
       
 34893         * html/HTMLImageElement.idl:
       
 34894         * html/HTMLInputElement.idl:
       
 34895         * html/HTMLIsIndexElement.idl:
       
 34896         * html/HTMLLIElement.idl:
       
 34897         * html/HTMLLabelElement.idl:
       
 34898         * html/HTMLLegendElement.idl:
       
 34899         * html/HTMLLinkElement.idl:
       
 34900         * html/HTMLMapElement.idl:
       
 34901         * html/HTMLMetaElement.idl:
       
 34902         * html/HTMLModElement.idl:
       
 34903         * html/HTMLOListElement.idl:
       
 34904         * html/HTMLObjectElement.idl:
       
 34905         * html/HTMLOptGroupElement.idl:
       
 34906         * html/HTMLOptionElement.idl:
       
 34907         * html/HTMLParagraphElement.idl:
       
 34908         * html/HTMLParamElement.idl:
       
 34909         * html/HTMLQuoteElement.idl:
       
 34910         * html/HTMLScriptElement.idl:
       
 34911         * html/HTMLSelectElement.idl:
       
 34912         * html/HTMLStyleElement.idl:
       
 34913         * html/HTMLTableCaptionElement.idl:
       
 34914         * html/HTMLTableCellElement.idl:
       
 34915         * html/HTMLTableColElement.idl:
       
 34916         * html/HTMLTableElement.idl:
       
 34917         * html/HTMLTableRowElement.idl:
       
 34918         * html/HTMLTableSectionElement.idl:
       
 34919         * html/HTMLTextAreaElement.idl:
       
 34920         * html/HTMLTitleElement.idl:
       
 34921         * html/HTMLUListElement.idl:
       
 34922 
       
 34923 2007-05-14  Geoffrey Garen  <ggaren@apple.com>
       
 34924 
       
 34925         Trying to fix the Qt build.
       
 34926 
       
 34927         * WebCore.pro:
       
 34928 
       
 34929 2007-05-14  Geoffrey Garen  <ggaren@apple.com>
       
 34930 
       
 34931         Reviewed by Oliver Hunt.
       
 34932         
       
 34933         Some improvements on my last patch, suggested by Darin.
       
 34934 
       
 34935         * history/PageCache.cpp:
       
 34936         (WebCore::PageCache::autoreleaseNow): Swap with an empty set instead of 
       
 34937         building up an array and then calling clear(). This is slightly more 
       
 34938         efficient and the code is cleaner.
       
 34939 
       
 34940 2007-05-14  Justin Garcia  <justin.garcia@apple.com>
       
 34941 
       
 34942         Reviewed by darin
       
 34943         
       
 34944         <rdar://problem/5136696> Selection is removed when focusing a node in another frame
       
 34945         <rdar://problem/5192388> WordPress: Can't insert links/images
       
 34946         
       
 34947         Don't clear a selection when changing focus if the new
       
 34948         focus node is in a different frame than the old selection.
       
 34949 
       
 34950         * dom/Document.cpp:
       
 34951         (WebCore::Document::setFocusedNode): Moved code to clear 
       
 34952         selections to the FocusController, since it is Page level 
       
 34953         and will know about the frame/document that contained the 
       
 34954         old selection. Moved code to call shouldEndEditing to the 
       
 34955         FocusController because selections are now cleared before
       
 34956         calling Document::setFocusedNode and shouldEndEditing must
       
 34957         be called before selections are cleared.
       
 34958         * dom/Element.cpp:
       
 34959         (WebCore::Element::blur): Call FocusController::setFocusNode
       
 34960         instead of Document::setFocusNode, if possible.
       
 34961         * page/EventHandler.cpp:
       
 34962         (WebCore::EventHandler::dispatchMouseEvent): Ditto.
       
 34963         * page/FocusController.cpp:
       
 34964         (WebCore::relinquishesEditingFocus): Moved from Document.cpp.
       
 34965         (WebCore::clearSelectionIfNeeded): Ditto.  Don't clear if
       
 34966         the old selection is in a frame that's different than the 
       
 34967         one that contains the new focus node.
       
 34968         (WebCore::FocusController::setFocusedNode): Moved code
       
 34969         here from Document::setFocusedNode.
       
 34970         * page/Frame.cpp:
       
 34971         (WebCore::Frame::setFocusedNodeIfNeeded): Call
       
 34972         FocusController::setFocusNode.
       
 34973 
       
 34974 2007-05-14  Geoffrey Garen  <ggaren@apple.com>
       
 34975 
       
 34976         Reviewed by Darin Adler.
       
 34977         
       
 34978         Next step toward fixing <rdar://problem/5055182> The back cache has no 
       
 34979         global cap.
       
 34980         
       
 34981         Created a PageCache singleton. Right now, it only handles the timer-based
       
 34982         deallocation of cached pages. I plan to add HistoryItem->CachedPage tracking
       
 34983         and eviction logic in later patches.
       
 34984 
       
 34985         Updated for renames and file changes:
       
 34986 
       
 34987         * WebCore.exp:
       
 34988         * WebCore.xcodeproj/project.pbxproj:
       
 34989         * history/BackForwardList.cpp:
       
 34990         (WebCore::BackForwardList::setPageCacheSize):
       
 34991         (WebCore::BackForwardList::clearPageCache):
       
 34992 
       
 34993         Removed global timed release code, moved into new PageCache class, since
       
 34994         it's eventually going to be in charge of deciding when things are released:
       
 34995         
       
 34996         * history/HistoryItem.cpp:
       
 34997         (WebCore::HistoryItem::setCachedPage):
       
 34998         * history/HistoryItem.h:
       
 34999 
       
 35000         Folded into PageCache:
       
 35001         
       
 35002         * history/HistoryItemTimer.cpp: Removed.
       
 35003         * history/HistoryItemTimer.h: Removed.
       
 35004 
       
 35005         New singleton. Right now, it just handles timed release of cached pages:
       
 35006         
       
 35007         * history/PageCache.cpp: Added.
       
 35008         (WebCore::pageCache):
       
 35009         (WebCore::PageCache::PageCache):
       
 35010         (WebCore::PageCache::autoreleaseNowOrReschedule):
       
 35011         (WebCore::PageCache::autoreleaseNow):
       
 35012         (WebCore::PageCache::autorelease):
       
 35013         * history/PageCache.h: Added.
       
 35014 
       
 35015 2007-05-14  Adele Peterson  <adele@apple.com>
       
 35016 
       
 35017         Reviewed by Darin.
       
 35018 
       
 35019         Fix for <rdar://problem/5200081> Repro crash in PopupMenu::show clicking popup menu button after reload
       
 35020 
       
 35021         * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added call to dismissPopup so the cell gets unattached properly.
       
 35022 
       
 35023 2007-05-14  Adele Peterson  <adele@apple.com>
       
 35024 
       
 35025         Reviewed by Darin.
       
 35026 
       
 35027         Remove incorrect assertion.
       
 35028 
       
 35029         * page/FrameView.cpp: (WebCore::FrameView::setContentsPos):
       
 35030 
       
 35031 2007-05-14  Anders Carlsson  <andersca@apple.com>
       
 35032 
       
 35033         Reviewed by Geoff.
       
 35034 
       
 35035         <rdar://problem/5172056> Regression: cannot open txt file, get broken image
       
 35036 
       
 35037         Never let plug-ins override text/plain.
       
 35038         
       
 35039         * dom/DOMImplementation.cpp:
       
 35040         (WebCore::DOMImplementation::createDocument):
       
 35041 
       
 35042 2007-05-14  Zack Rusin  <zrusin@trolltech.com>
       
 35043 
       
 35044         Reviewed by Simon.
       
 35045 
       
 35046         Do some magic to get better dependency tracking for header
       
 35047         files in the qmake project files.
       
 35048 
       
 35049         * ChangeLog:
       
 35050 
       
 35051 2007-05-14  Lars Knoll <lars@trolltech.com>
       
 35052 
       
 35053         Reviewed by Zack
       
 35054 
       
 35055         Required updates after Maciej's frame change.
       
 35056 
       
 35057         * loader/FrameLoader.cpp:
       
 35058         (WebCore::FrameLoader::mainReceivedCompleteError):
       
 35059               Call checkLoadCompleted() at the end of the method. Without it
       
 35060               we never get the loadDone() signal on the Qt port.
       
 35061         * platform/network/qt/ResourceHandleManagerQt.cpp:
       
 35062         (WebCore::ResourceHandleManager::receivedFinished):
       
 35063               Don't pass a null error to didFail().
       
 35064 
       
 35065 2007-05-14  Darin Adler  <darin@apple.com>
       
 35066 
       
 35067         Reviewed by Antti.
       
 35068 
       
 35069         - fix <rdar://problem/3109180> VIP: after go back, page jumps after loading even if I scrolled while loading
       
 35070 
       
 35071         * history/CachedPage.cpp: (WebCore::CachedPage::clear): Call clearFrame rather than
       
 35072         clearPart -- the "part" term was leftover prehistoric terminology.
       
 35073 
       
 35074         * loader/FrameLoader.cpp:
       
 35075         (WebCore::FrameLoader::open): Call setWasScrolledByUser(false) on the page, so that we
       
 35076         can detect any user scrolling that happens during the "go back" process.
       
 35077         (WebCore::FrameLoader::restoreScrollPositionAndViewState): Don't scroll if the view's
       
 35078         wasScrolledByUser flag is set.
       
 35079         (WebCore::FrameLoader::loadItem): Call setWasScrolledByUser(false) false when we do
       
 35080         a new "load" (actually just a scroll) using the same frame. Also moved the line of code that
       
 35081         sets m_currentHistoryItem to make this code path mroe similar to recursiveGoToItem.
       
 35082         (WebCore::FrameLoader::recursiveGoToItem): Ditto.
       
 35083 
       
 35084         * page/Frame.cpp:
       
 35085         (WebCore::Frame::~Frame): Call clearFrame rather than stting m_frame directly.
       
 35086         (WebCore::Frame::sendScrollEvent): Call setWasScrolledByUser(true) on FrameView. The FrameView
       
 35087         itself knows to ignore this if the scrolling is being done programmatically instead of by the user.
       
 35088 
       
 35089         * page/FrameView.h: Added wasScrolledByUser and setWasScrolledByUser. Also removed unneeded
       
 35090         include and class forward declarations, renamed clearPart to clearFrame, removed uneeded function
       
 35091         haveDelayedLayoutScheduled, and removed unneeded friend declarations.
       
 35092         * page/FrameView.cpp:
       
 35093         (WebCore::FrameViewPrivate::FrameViewPrivate): Added m_inProgrammaticScroll and m_wasScrolledByUser.
       
 35094         (WebCore::FrameViewPrivate::reset): Set m_wasScrolledByUser to false.
       
 35095         (WebCore::FrameView::clearFrame): Renamed from clearPart.
       
 35096         (WebCore::FrameView::scrollRectIntoViewRecursively): Added code to set the m_inProgrammaticScroll flag.
       
 35097         (WebCore::FrameView::setContentsPos): Ditto.
       
 35098         (WebCore::FrameView::wasScrolledByUser): Added.
       
 35099         (WebCore::FrameView::setWasScrolledByUser): Added. Does nothing if called when m_inProgrammaticScroll
       
 35100         is true.
       
 35101 
       
 35102 2007-05-14  Darin Adler  <darin@apple.com>
       
 35103 
       
 35104         Reviewed by Antti.
       
 35105 
       
 35106         - <rdar://problem/4865655> REGRESSION: find function does not work for the character ß
       
 35107 
       
 35108         The trick was to fold case consistently in the CircularSearchBuffer class.
       
 35109 
       
 35110         The problem was that we were folding the search target string with full case folding and
       
 35111         the characters of the text we were searching with simple case folding. We now use full
       
 35112         case folding in both cases.
       
 35113 
       
 35114         * editing/TextIterator.cpp:
       
 35115         (WebCore::CircularSearchBuffer::CircularSearchBuffer): Changed the buffer to be a
       
 35116         Vector<UChar>. Added a Vector<bool> to record which characters were starts of characters
       
 35117         in the text we are searching. Changed the cursor to be an int rather than a pointer.
       
 35118         (WebCore::CircularSearchBuffer::append): New function that knows how to append multiple
       
 35119         characters when folding case turns one character into many -- uses the full foldCase
       
 35120         rather than the simplified single-character foldCase. Also removed the append function
       
 35121         that did multiple characters at once; that was part of an optimization we don't need.
       
 35122         (WebCore::CircularSearchBuffer::isMatch): Instead of asserting that the buffer is full,
       
 35123         changed this to return false if it's not full, which lets us fill up the buffer with
       
 35124         the normal loop. Also return false if the start of the buffer is half-way through a
       
 35125         case-folded character and updated this since m_cursor is now an integer.
       
 35126         (WebCore::CircularSearchBuffer::length): This returns the length in non-case-folded
       
 35127         characters of the characters that were appended, which may not be the same as the length
       
 35128         of the original target string. To do that we have to total up the character start
       
 35129         booleans for the current state of the circular buffer.
       
 35130         (WebCore::findPlainText): Streamlined the logic in a few ways: 1) Moved more of the
       
 35131         return value setup to the top of the function so it could be shared with the early
       
 35132         error exit. 2) Removed the separate "fill the buffer" logic, which allowed me to
       
 35133         remove some of the functions from CircularSearchBuffer and eliminated the need for
       
 35134         two nested loops. 3) Replaced the CharacterIterator and bool that were used to record
       
 35135         the location we found with integers matchStart and matchLength. 4) Got rid of the use
       
 35136         of goto since we don't have two nested loops any more.
       
 35137 
       
 35138 2007-05-14  Andrew Wellington  <proton@wiretapped.net>
       
 35139 
       
 35140         Reviewed by Darin.
       
 35141 
       
 35142         Fix http://bugs.webkit.org/show_bug.cgi?id=13275
       
 35143         Safari crashed when trying to login using the windows live contact control
       
 35144 
       
 35145         Check for cleared windowObj in JSAbstractEventListener::handleEvent
       
 35146 
       
 35147         * bindings/js/kjs_events.cpp:
       
 35148         (KJS::JSAbstractEventListener::handleEvent):
       
 35149 
       
 35150 2007-05-13  Alexey Proskuryakov  <ap@webkit.org>
       
 35151 
       
 35152         Reviewed by Darin.
       
 35153 
       
 35154         http://bugs.webkit.org/show_bug.cgi?id=13690
       
 35155         JavaScript Form Validation issue on Banco do Brasil site
       
 35156 
       
 35157         Test: fast/forms/input-setvalue-selection.html
       
 35158 
       
 35159         * html/HTMLInputElement.cpp:
       
 35160         (WebCore::HTMLInputElement::setValue): In other browsers, changing textInput.value
       
 35161         always moves the insertion point past the text. In 10.4.9 WebKit, this only worked
       
 35162         for inactive controls, and it never worked in ToT.
       
 35163 
       
 35164 2007-05-13  Brady Eidson  <beidson@apple.com>
       
 35165 
       
 35166         Reviewed by Mitz
       
 35167 
       
 35168         http://bugs.webkit.org/show_bug.cgi?id=13701
       
 35169 
       
 35170         Since HTMLInputElements register themselves with their Document for special handling, if their document
       
 35171         ever changes then bad things can happen.
       
 35172 
       
 35173         Unfortunately, with adoptNode, the document can change.  This has been a long standing crasher with all 
       
 35174         input fields but was given recent high visibility by r21430
       
 35175 
       
 35176         The solution is to add functionality for a Node to react to its owner document changing via a pair of 
       
 35177         virtual callbacks.  Then we can tap into those callbacks in HTMLInputElement.
       
 35178 
       
 35179         No layout test possible until http://bugs.webkit.org/show_bug.cgi?id=13672 is resolved
       
 35180 
       
 35181         * dom/Node.cpp:
       
 35182         (WebCore::Node::setDocument): Call willMoveToNewOwnerDocument and didMoveToNewOwnerDocument
       
 35183 
       
 35184         * dom/Node.h:
       
 35185         (WebCore::Node::willMoveToNewOwnerDocument): Virtual callback to a node for before an owner document change
       
 35186         (WebCore::Node::didMoveToNewOwnerDocument): Virtual callback to a node for after an owner document change
       
 35187 
       
 35188         * html/HTMLInputElement.cpp:
       
 35189         (WebCore::HTMLInputElement::~HTMLInputElement): Unconditionally unregister both for both form state
       
 35190           and the cache restoration callback
       
 35191         (WebCore::HTMLInputElement::setInputType): Change registration with the document only if we're in one
       
 35192         (WebCore::HTMLInputElement::attach): Don't bother registering for the callback here - that will be
       
 35193           handled by setInputType() or by a change in owner document
       
 35194         (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Unregister with the old owner document
       
 35195         (WebCore::HTMLInputElement::didMoveToNewOwnerDocument): Register with the new owner document
       
 35196         * html/HTMLInputElement.h:
       
 35197 
       
 35198 2007-05-13  Darin Adler  <darin@apple.com>
       
 35199 
       
 35200         * platform/mac/TextBreakIteratorInternalICUMac.mm: Fix comment typo.
       
 35201 
       
 35202 2007-05-13  Rob Buis  <buis@kde.org>
       
 35203 
       
 35204         Reviewed by Darin.
       
 35205 
       
 35206         http://bugs.webkit.org/show_bug.cgi?id=13529
       
 35207         DOM3 keyIdentifier text is incorrect
       
 35208 
       
 35209         Use 4 digits for the Unicode based key identifiers.
       
 35210 
       
 35211         * html/HTMLButtonElement.cpp:
       
 35212         (WebCore::HTMLButtonElement::defaultEventHandler):
       
 35213         * html/HTMLInputElement.cpp:
       
 35214         (WebCore::HTMLInputElement::defaultEventHandler):
       
 35215         * html/HTMLSelectElement.cpp:
       
 35216         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
       
 35217         * page/EventHandler.cpp:
       
 35218         (WebCore::EventHandler::defaultKeyboardEventHandler):
       
 35219         * page/gdk/EventHandlerGdk.cpp:
       
 35220         (WebCore::isKeyboardOptionTab):
       
 35221         * page/mac/EventHandlerMac.mm:
       
 35222         (WebCore::isKeyboardOptionTab):
       
 35223         * page/qt/EventHandlerQt.cpp:
       
 35224         (WebCore::isKeyboardOptionTab):
       
 35225         * platform/gdk/KeyEventGdk.cpp:
       
 35226         (WebCore::keyIdentifierForGdkKeyCode):
       
 35227         * platform/mac/KeyEventMac.mm:
       
 35228         (WebCore::keyIdentifierForKeyEvent):
       
 35229         * platform/qt/PlatformKeyboardEventQt.cpp:
       
 35230         (WebCore::keyIdentifierForQtKeyCode):
       
 35231         * platform/win/KeyEventWin.cpp:
       
 35232         (WebCore::keyIdentifierForWindowsKeyCode):
       
 35233         * platform/wx/KeyEventWin.cpp:
       
 35234         (WebCore::keyIdentifierForWindowsKeyCode):
       
 35235         * platform/wx/KeyboardEventWx.cpp:
       
 35236         (WebCore::keyIdentifierForWxKeyCode):
       
 35237 
       
 35238 2007-05-12  Darin Adler  <darin@apple.com>
       
 35239 
       
 35240         Reviewed by Antti.
       
 35241 
       
 35242         - fix <rdar://problem/5174903> Safari crashes opening the attached webarchive (made by OmniWeb)
       
 35243 
       
 35244         * loader/icon/IconLoader.cpp:
       
 35245         (WebCore::IconLoader::didReceiveResponse): Check ResourceHandle for nil before calling url() on it.
       
 35246         (WebCore::IconLoader::didFail): Ditto.
       
 35247         (WebCore::IconLoader::didFinishLoading): Ditto.
       
 35248 
       
 35249 2007-05-12  Rob Buis  <buis@kde.org>
       
 35250 
       
 35251         Reviewed by Oliver.
       
 35252 
       
 35253         Cleanup, get rid of the SVGStyledElement::view() call.
       
 35254 
       
 35255         * ksvg2/svg/SVGClipPathElement.cpp:
       
 35256         (WebCore::SVGClipPathElement::canvasResource):
       
 35257         * ksvg2/svg/SVGFEFloodElement.cpp:
       
 35258         (WebCore::SVGFEFloodElement::filterEffect):
       
 35259         * ksvg2/svg/SVGGradientElement.cpp:
       
 35260         (WebCore::SVGGradientElement::buildStops):
       
 35261         * ksvg2/svg/SVGStyledElement.cpp:
       
 35262         * ksvg2/svg/SVGStyledElement.h:
       
 35263 
       
 35264 2007-05-12  Mitz Pettel  <mitz@webkit.org>
       
 35265 
       
 35266         Reviewed by Hyatt.
       
 35267 
       
 35268         - fix http://bugs.webkit.org/show_bug.cgi?id=13680
       
 35269           Incomplete repaint of focus ring around continuation
       
 35270 
       
 35271         Test: fast/repaint/continuation-after-outline.html
       
 35272 
       
 35273         * rendering/RenderFlow.cpp:
       
 35274         (WebCore::RenderFlow::absoluteClippedOverflowRect):
       
 35275 
       
 35276 2007-05-12  Oliver Hunt  <oliver@apple.com>
       
 35277 
       
 35278         Reviewed by Hyatt.
       
 35279 
       
 35280         <rdar://problem/4728842> Can't drag-and-drop files onto <input type="file">
       
 35281         
       
 35282         This patch allows a file to be dropped on to a file input field.  There
       
 35283         are a few changes for data handling and a  few to allow the data to be
       
 35284         threaded to the appropriate places.
       
 35285 
       
 35286         * page/DragController.cpp:
       
 35287         (WebCore::asFileInput):
       
 35288            When dropping a file onto a file input we may mouse over either 
       
 35289            the element itself, or the contained button element.  This method
       
 35290            returns the base element for the file input in either of these
       
 35291            cases.
       
 35292         (WebCore::DragController::tryDocumentDrag):
       
 35293            Don't try to set the drag caret to a file input.
       
 35294         (WebCore::DragController::concludeDrag):
       
 35295            Handle dropping onto a file input element.
       
 35296         (WebCore::DragController::canProcessDrag):
       
 35297            We can now process a file being dragged onto a file input element.
       
 35298            
       
 35299         * platform/DragData.h:
       
 35300            New accessors
       
 35301            
       
 35302         * platform/gdk/DragDataGdk.cpp:
       
 35303         (WebCore::DragData::containsFiles):
       
 35304         (WebCore::DragData::asFilenames):
       
 35305            Link stubs.
       
 35306            
       
 35307         * platform/mac/DragDataMac.mm:
       
 35308         (WebCore::DragData::containsFiles):
       
 35309         (WebCore::DragData::asFilenames):
       
 35310            Implement new accessors
       
 35311         (WebCore::DragData::containsCompatibleContent):
       
 35312            Update containsCompatibleContent to allow standalone files.
       
 35313           
       
 35314         * platform/qt/DragDataQt.cpp:
       
 35315         (WebCore::DragData::containsFiles):
       
 35316         (WebCore::DragData::asFilenames):
       
 35317            Link stubs
       
 35318                       
       
 35319         * rendering/RenderFileUploadControl.cpp:
       
 35320         (WebCore::RenderFileUploadControl::receiveDroppedFile):
       
 35321         * rendering/RenderFileUploadControl.h:
       
 35322            For security reasons we don't have an api to allow us to set 
       
 35323            a value directly on a file input -- attempts to do so are
       
 35324            blocked.  By adding a method to set the target through the 
       
 35325            render we bypass such restrictions, and ensure the renderer
       
 35326            is updated correctly.
       
 35327 
       
 35328 2007-05-12  Mitz Pettel  <mitz@webkit.org>
       
 35329 
       
 35330         Reviewed by Hyatt.
       
 35331 
       
 35332         - fix http://bugs.webkit.org/show_bug.cgi?id=13695
       
 35333           REGRESSION (r21387): Replaced elements' highlight rects are wrongly positioned
       
 35334 
       
 35335         Test: fast/replaced/selection-rect.html
       
 35336 
       
 35337         Also fixes the same problem with list markers, covered by existing test
       
 35338         fast/lists/markers-in-selection.html.
       
 35339 
       
 35340         * rendering/RenderListMarker.cpp:
       
 35341         (WebCore::RenderListMarker::selectionRect):
       
 35342         * rendering/RenderReplaced.cpp:
       
 35343         (WebCore::RenderReplaced::selectionRect):
       
 35344 
       
 35345 2007-05-12  Mitz Pettel  <mitz@webkit.org>
       
 35346 
       
 35347         Reviewed by Darin.
       
 35348 
       
 35349         - fix http://bugs.webkit.org/show_bug.cgi?id=13685
       
 35350           REGRESSION (r21368-r21388): Highlighting text in scrolled textareas behaves oddly
       
 35351 
       
 35352         Test: fast/repaint/text-selection-rect-in-overflow.html
       
 35353 
       
 35354         * rendering/RenderText.cpp:
       
 35355         (WebCore::RenderText::selectionRect):
       
 35356 
       
 35357 2007-05-12  Brady Eidson  <beidson@apple.com>
       
 35358 
       
 35359         Rubber stamped by Mitz
       
 35360 
       
 35361         * html/HTMLInputElement.cpp:
       
 35362         (WebCore::HTMLInputElement::attach): unregister->register - I screwed this one up in last minute renaming
       
 35363           before committing  :(
       
 35364 
       
 35365 2007-05-11  Brady Eidson  <beidson@apple.com>
       
 35366 
       
 35367         Reviewed by Darin and Geoff
       
 35368 
       
 35369         Fix for http://bugs.webkit.org/show_bug.cgi?id=13630
       
 35370         and
       
 35371         <rdar://problem/4873628>
       
 35372 
       
 35373         Back/Forward cache should work with pages with login fields.
       
 35374 
       
 35375         First change is to relocate the "useSecureKeyboardEntry" flag to the document.  This lets
       
 35376         it persist through page cache transitions and it is truly a per-document concept more than
       
 35377         per-frame anyways since its the document that has a password field, not the frame.
       
 35378 
       
 35379         Second change is to introduce the concept of an Element getting a "didRestoreFromCache()" callback.
       
 35380         The idea is for elements to register with the document if they need work to be done when the
       
 35381         page comes out of the back/forward cache.  Currently the only client of this service is 
       
 35382         HTMLInputElements that are input type == PASSWORD.  Such an element's implementation for this
       
 35383         method is to call reset()
       
 35384 
       
 35385         Finally, after a page is restored from the cache we have the document send the didRestoreFromCache()
       
 35386         callback to its registered Elements.  The whole design is to clear the password fields after 
       
 35387         restoring the page instead of when caching the page because we want to defer work for the common
       
 35388         case - there shouldn't be extra work here just to navigate away from a page when the common case
       
 35389         is that you'll never go back!
       
 35390 
       
 35391         No layout tests possible until http://bugs.webkit.org/show_bug.cgi?id=13672 is resolved
       
 35392 
       
 35393         * dom/Document.cpp:
       
 35394         (WebCore::Document::Document):
       
 35395         (WebCore::Document::registerForDidRestoreFromCacheCallback): Add an Element to the special page-restoration callback list
       
 35396         (WebCore::Document::unregisterForDidRestoreFromCacheCallback): Remove such an element
       
 35397         (WebCore::Document::didRestoreFromCache): Called by FrameLoader - dispatch to all the registered elements
       
 35398         (WebCore::Document::setUseSecureKeyboardEntryWhenActive): Set the local flag and call updateSecureKeyboardEntryIfActive
       
 35399           on the Frame
       
 35400         (WebCore::Document::useSecureKeyboardEntryWhenActive): Return the flag
       
 35401 
       
 35402         * dom/Document.h:
       
 35403         (WebCore::Document::unregisterFormElementWithState): Renamed
       
 35404 
       
 35405         * dom/Element.h:
       
 35406         (WebCore::Element::didRestoreFromCache): Added virtual base method
       
 35407 
       
 35408         * html/HTMLInputElement.cpp:
       
 35409         (WebCore::HTMLInputElement::~HTMLInputElement): Deregister from the document if inputType == PASSWORD
       
 35410         (WebCore::HTMLInputElement::dispatchFocusEvent): Set the flag on the document, not the frame
       
 35411         (WebCore::HTMLInputElement::dispatchBlurEvent): Ditto
       
 35412         (WebCore::HTMLInputElement::setInputType): If changing to/from PASSWORD, register/deregister in the document accordingly
       
 35413         (WebCore::HTMLInputElement::attach): Call registerForDidRestoreFromCacheCallback(this) instead of passwordFieldAdded()
       
 35414         (WebCore::HTMLInputElement::didRestoreFromCache): Call reset();
       
 35415         * html/HTMLInputElement.h:
       
 35416 
       
 35417         * html/HTMLSelectElement.cpp:
       
 35418         (WebCore::HTMLSelectElement::~HTMLSelectElement): Renamed deregisterFormElementWithState to unregisterFormElementWithState
       
 35419         * html/HTMLTextAreaElement.cpp:
       
 35420         (WebCore::HTMLTextAreaElement::~HTMLTextAreaElement): Ditto
       
 35421 
       
 35422         * loader/FrameLoader.cpp:
       
 35423         (WebCore::FrameLoader::canCachePage): Remove the check for password fields - they're allowed now!
       
 35424         (WebCore::FrameLoader::opened): Tell the document to dispatch to the registered elements
       
 35425         (WebCore::FrameLoader::saveDocumentState): Remove the check for password fields.  Turns out that when we grab a copy a the
       
 35426           form state we're only copying the state of form elements that are registered with the Document - and that set 
       
 35427           explicitly excludes Password elements
       
 35428 
       
 35429         * page/Frame.cpp:
       
 35430         (WebCore::Frame::setDocument): If the frame is active, set the setUseSecureKeyboardEntry based on the setting contained
       
 35431           in the new document
       
 35432         (WebCore::Frame::updateSecureKeyboardEntryIfActive): Notification for the secure entry flag changing - if the Frame is
       
 35433           active, then update to the new setting from the document
       
 35434         (WebCore::Frame::setIsActive): Grab the useSecureKeyboardEntry flag from the document instead of FramePrivate
       
 35435         (WebCore::FramePrivate::FramePrivate):
       
 35436         * page/Frame.h:
       
 35437         * page/FramePrivate.h:
       
 35438 
       
 35439 2007-05-12  David Hyatt  <hyatt@apple.com>
       
 35440 
       
 35441         FIx for 13696.  Rework residual style to be much more aggressive about reopening.  Added
       
 35442         a comprehensive test case of HTML tags to guarantee we match Firefox.  We now have an exclusion
       
 35443         set rather than an inclusion set, so unknown future tags will also participate in residual style.
       
 35444 
       
 35445         Reviewed by olliej
       
 35446 
       
 35447         fast/invalid/residual-style.html
       
 35448 
       
 35449 2007-05-12  David Hyatt  <hyatt@apple.com>
       
 35450 
       
 35451         Fix for bug 12740, bmw.com doesn't work.  We were missing a rule that is covered by the HTML5
       
 35452         parsing spec.  A <table> encountered while inside stray table content should close up the
       
 35453         table responsible for the stray content and start the new table as a sibling of the first.
       
 35454 
       
 35455         Reviewed by mjs
       
 35456 
       
 35457         fast/invalid/table-inside-stray-table-content.html
       
 35458 
       
 35459 2007-05-12  Eric Seidel  <eric@webkit.org>
       
 35460 
       
 35461         Reviewed by mjs.
       
 35462 
       
 35463         Crash starting Safari with JavaScript disabled.
       
 35464         http://bugs.webkit.org/show_bug.cgi?id=13691
       
 35465         
       
 35466         Test: none possible.
       
 35467 
       
 35468         * page/mac/FrameMac.mm:
       
 35469         (WebCore::Frame::cleanupPlatformScriptObjects): NULL check d->m_script
       
 35470 
       
 35471 2007-05-11  David Hyatt  <hyatt@apple.com>
       
 35472 
       
 35473         Fix for http://bugs.webkit.org/show_bug.cgi?id=13688, Colloquy is broken!
       
 35474 
       
 35475         Make sure to adjust the baseline of a percentage height table cell's row if the
       
 35476         cell flexes (and lowers the baseline).
       
 35477 
       
 35478         Reviewed by olliej
       
 35479 
       
 35480         fast/tables/vertical-align-baseline-readjust.html
       
 35481 
       
 35482         (WebCore::RenderTableSection::calcRowHeight):
       
 35483         (WebCore::RenderTableSection::layoutRows):
       
 35484         * rendering/RenderTableSection.h:
       
 35485         (WebCore::RenderTableSection::getBaseline):
       
 35486         
       
 35487 2007-05-11  David Hyatt  <hyatt@apple.com>
       
 35488 
       
 35489         Make sure focus rings are always using the exterior style, regardless
       
 35490         of what the OS default is.
       
 35491 
       
 35492         Reviewed by beth
       
 35493 
       
 35494         * rendering/RenderThemeMac.mm:
       
 35495         (WebCore::RenderThemeMac::checkbox):
       
 35496         (WebCore::RenderThemeMac::radio):
       
 35497         (WebCore::RenderThemeMac::popupButton):
       
 35498         (WebCore::RenderThemeMac::search):
       
 35499         (WebCore::RenderThemeMac::sliderThumbHorizontal):
       
 35500         (WebCore::RenderThemeMac::sliderThumbVertical):
       
 35501 
       
 35502 2007-05-11  Oliver Hunt  <oliver@apple.com>
       
 35503 
       
 35504         Reviewed by Hyatt.
       
 35505         
       
 35506         <rdar://problem/5195473> REGRESSION: "Curly quote" fails to 
       
 35507         be displayed correctly even when META tag specifies charset=x-mac-roman
       
 35508 
       
 35509 
       
 35510         * platform/TextCodecICU.cpp:
       
 35511         (WebCore::TextCodecICU::registerExtendedEncodingNames):
       
 35512         Register the xmacroman encoding
       
 35513 
       
 35514 2007-05-11  Maciej Stachowiak  <mjs@apple.com>
       
 35515 
       
 35516         Reviewed by Hyatt.
       
 35517 
       
 35518         REGRESSION (r21367): Crash due to null document deref when closing bookmarks
       
 35519         http://bugs.webkit.org/show_bug.cgi?id=13662
       
 35520 
       
 35521         * loader/FrameLoader.cpp:
       
 35522         (WebCore::FrameLoader::provisionalLoadStarted): Remove some useless and now harmful
       
 35523         code - there's no need to clear in this case.
       
 35524 
       
 35525 2007-05-11  Oliver Hunt  <oliver@apple.com>
       
 35526 
       
 35527         GDK Build fix
       
 35528 
       
 35529         * ChangeLog:
       
 35530         * dom/Document.cpp:
       
 35531         (WebCore::Document::importNode):
       
 35532 
       
 35533 2007-05-11  Maciej Stachowiak  <mjs@apple.com>
       
 35534 
       
 35535         Reviewed by Geoff.
       
 35536         
       
 35537         - fixed <rdar://problem/5197621> closing second window crashed webkit (13660)
       
 35538         http://bugs.webkit.org/show_bug.cgi?id=13660
       
 35539 
       
 35540         No test case; not testable.
       
 35541 
       
 35542         * page/mac/FrameMac.mm:
       
 35543         (WebCore::Frame::cleanupPlatformScriptObjects): Check if the interpreter is null;
       
 35544         if so, we don't want to do work that may lazily create it while the Frame is being
       
 35545         destroyed.
       
 35546 
       
 35547 2007-05-11  Oliver Hunt  <oliver@apple.com>
       
 35548 
       
 35549         Reviewed by Brady.
       
 35550         
       
 35551         <rdar://problem/5017375> WebKit should disable SVG in Dashboard
       
 35552         
       
 35553         Prevents an SVG document or element from being created when in
       
 35554         dashboard compatibility mode.
       
 35555         
       
 35556         Manually parsing, or using XHR to created a document removes our 
       
 35557         ability to detect Dashboard compatibility mode, so we also perform
       
 35558         the check when importing nodes from one document into another.
       
 35559 
       
 35560         * dom/DOMImplementation.cpp:
       
 35561         (WebCore::DOMImplementation::createDocument):
       
 35562           Don't create an SVGDocument if we're in dashboard compatibility mode
       
 35563           
       
 35564         * dom/Document.cpp:
       
 35565         (WebCore::Document::importNode):
       
 35566           Don't import SVG nodes if we're in dashboard compatibility mode
       
 35567           
       
 35568         * ksvg2/scripts/make_names.pl:
       
 35569           Don't create SVG elements for documents that are in dashboard
       
 35570           compatibility mode
       
 35571 
       
 35572 2007-05-11  Holger Hans Peter Freyther  <zecke@selfish.org>
       
 35573 
       
 35574         Reviewed by Maciej.
       
 35575 
       
 35576         Bug 13676: [cairo/gdk] Provide implementation for ImageBufferCairo
       
 35577         http://bugs.webkit.org/show_bug.cgi?id=13676
       
 35578 
       
 35579         There are no test cases that explicitly cover platform/graphics at present.
       
 35580 
       
 35581         * platform/graphics/ImageBuffer.h: Add cairo bits
       
 35582         * platform/graphics/cairo/ImageBufferCairo.cpp: Untested implementation of the ImagerBuffer using the image_surface
       
 35583         (WebCore::ImageBuffer::create): Create a reasonable sized surface
       
 35584         (WebCore::ImageBuffer::ImageBuffer): Use a cairo_surface and create a GraphicsContext. GraphicsContext takes the cairo_t ownership
       
 35585         (WebCore::ImageBuffer::~ImageBuffer): Unref the surface
       
 35586         (WebCore::ImageBuffer::context): simply return the GraphicsContext, it should be possible to directly draw on it.
       
 35587 
       
 35588 2007-05-11  Mitz Pettel  <mitz@webkit.org>
       
 35589 
       
 35590         Release build fix.
       
 35591 
       
 35592         * platform/mac/ShapeArabic.c:
       
 35593         (shapeArabic):
       
 35594 
       
 35595 2007-05-11  Geoffrey Garen  <ggaren@apple.com>
       
 35596 
       
 35597         Reviewed by Darin Adler.
       
 35598 
       
 35599         Removed +[WebScriptObject scriptObjectForJSObject:frame:] because the
       
 35600         WebScriptObject API has some serious limitations that make it not ready
       
 35601         to be used everywhere the C API is used. Hopefully we can add a good
       
 35602         ObjC API in the future that doesn't suffer from this problem.
       
 35603         
       
 35604         Preliminary notes about these limitations are in <rdar://problem/4876466>.
       
 35605 
       
 35606         * bindings/objc/WebScriptObject.mm:
       
 35607         * bindings/objc/WebScriptObjectPendingPublic.h:
       
 35608 
       
 35609 2007-05-11  Mitz Pettel  <mitz@webkit.org>
       
 35610 
       
 35611         Reviewed by Darin.
       
 35612 
       
 35613         - fix http://bugs.webkit.org/show_bug.cgi?id=13635
       
 35614           REGRESSION: Cannot log in to webmail.co.za account
       
 35615 
       
 35616         Test: fast/dom/HTMLOptionElement/option-text.html
       
 35617 
       
 35618         Despite the specification that the 'text' attribute of HTMLOptionElement
       
 35619         is "the text contained within the option element", other browsers return
       
 35620         the text as displayed in the list box or popup, which is without leading,
       
 35621         trailing and collapsible whitespace.
       
 35622 
       
 35623         * html/HTMLOptionElement.cpp:
       
 35624         (WebCore::HTMLOptionElement::text): Moved the code to trim and collapse
       
 35625         whitespace and replace backslashes with the currency symbol into this
       
 35626         function.
       
 35627         (WebCore::HTMLOptionElement::optionText): Left only the code that adds
       
 35628         the leading spaces for grouped options. Removed code that, in quirks mode,
       
 35629         displayed the label if the option element contained no text. That behavior
       
 35630         did not match WinIE and the description of the expected behavior in
       
 35631         fast/forms/HTMLOptionElement_label06.html.
       
 35632 
       
 35633 2007-05-11  Mitz Pettel  <mitz@webkit.org>
       
 35634 
       
 35635         Reviewed by Darin.
       
 35636 
       
 35637         - fix http://bugs.webkit.org/show_bug.cgi?id=13572
       
 35638           Arabic characters are not correctly joined when using Arial
       
 35639 
       
 35640         No tests added because standard fonts do not use the character-based shaping
       
 35641         code path.
       
 35642 
       
 35643         Added shapeArabic(), a private version of u_shapeArabic() from ICU,
       
 35644         patched to shape Arabic characters used in Persian, Urdu, Sindhi, etc.
       
 35645         (whose contextual forms belong to the Arabic Presentation Forms-A block).
       
 35646 
       
 35647         * WebCore.xcodeproj/project.pbxproj: Added ShapeArabic.{c,h}.
       
 35648         * platform/mac/FontMac.mm:
       
 35649         (WebCore::shapeArabic): Changed to call shapeArabic() instead of u_shapeArabic().
       
 35650         * platform/mac/ShapeArabic.c: Added. Based on ushape.c from ICU, with
       
 35651         additional shaping data and logic for Arabic Presentation Forms-A. Removed
       
 35652         many options that are not used in WebKit and code that malloc()ed a temporary
       
 35653         buffer and reversed the string.
       
 35654         (changeLamAlef):
       
 35655         (specialChar):
       
 35656         (getLink):
       
 35657         (isTashkeelChar):
       
 35658         (shapeUnicode):
       
 35659         (shapeArabic):
       
 35660         * platform/mac/ShapeArabic.h: Added.
       
 35661 
       
 35662 2007-05-11  Darin Adler  <darin@apple.com>
       
 35663 
       
 35664         Reviewed by Mitz.
       
 35665 
       
 35666         - fix http://bugs.webkit.org/show_bug.cgi?id=7452
       
 35667           <rdar://problem/3211749> line breaks ignored after <wbr> in <pre> block (affects livejournal.com)
       
 35668 
       
 35669         - fix http://bugs.webkit.org/show_bug.cgi?id=10657
       
 35670           <rdar://problem/4274588> <wbr> tags are ignored
       
 35671 
       
 35672         - fix http://bugs.webkit.org/show_bug.cgi?id=12689
       
 35673           <wbr> :before/:after content causes line break
       
 35674 
       
 35675         - fix <rdar://problem/5127366> DOM tree isn't correct when parsing with <wbr>
       
 35676 
       
 35677         Test: fast/text/wbr-pre.html
       
 35678         Test: fast/text/wbr.html
       
 35679         Test: fast/css-generated-content/wbr-with-before-content.html
       
 35680         Test: fast/parser/parse-wbr.html
       
 35681 
       
 35682         * html/HTMLElement.h:
       
 35683         * html/HTMLElement.cpp:
       
 35684         (WebCore::HTMLElement::endTagRequirement): Use the same end tag requirement for a <wbr>
       
 35685         element as for a <br> element, TagStatusForbidden.
       
 35686         (WebCore::HTMLElement::tagPriority): Use the same priority for a <wbr> element as for a
       
 35687         <br> element, 0.
       
 35688         (WebCore::HTMLElement::createRenderer): Added. Create a RenderWordBreak to trigger the
       
 35689         new rendering code paths.
       
 35690 
       
 35691         * rendering/RenderFlow.h: Add a virtual isWordBreak so we can detect RenderWordBreak.
       
 35692 
       
 35693         * rendering/RenderWordBreak.h: Added.
       
 35694         * rendering/RenderWordBreak.cpp: Added.
       
 35695 
       
 35696         * WebCore.pro: Added new files.
       
 35697         * WebCore.xcodeproj/project.pbxproj: Added new files.
       
 35698         * WebCoreSources.bkl: Added new files.
       
 35699 
       
 35700         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths): Reset the
       
 35701         line when we hit a <wbr>.
       
 35702         * rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Add a line break when
       
 35703         we hit a <wbr>.
       
 35704 
       
 35705         * dom/Node.cpp: (Node::createRendererIfNeeded): Fix a null check for the case where
       
 35706         createRenderer returns 0 even though rendererIsNeeded returned true. I can't reproduce
       
 35707         it on demand, but while running layout tests I hit this once. Since there was already
       
 35708         a null check here, I rearranged it so it guards all the code that uses the renderer.
       
 35709         Later we might want to figure out under exactly what circumstances rendererIsNeeded
       
 35710         will return true but createRenderer return 0 and consider eliminating them.
       
 35711 
       
 35712 2007-05-11  David Hyatt  <hyatt@apple.com>
       
 35713 
       
 35714         Fix for bug 13675, focus rings don't repaint properly on editable
       
 35715         continuations.
       
 35716 
       
 35717         Reviewed by olliej
       
 35718 
       
 35719         (WebCore::InlineFlowBox::paint):
       
 35720         * rendering/RenderBlock.cpp:
       
 35721         (WebCore::RenderBlock::paintObject):
       
 35722         (WebCore::continuationOutlineTable):
       
 35723         (WebCore::RenderBlock::addContinuationWithOutline):
       
 35724         (WebCore::RenderBlock::paintContinuationOutlines):
       
 35725         * rendering/RenderBlock.h:
       
 35726         * rendering/RenderBox.cpp:
       
 35727         (WebCore::RenderBox::absoluteClippedOverflowRect):
       
 35728         * rendering/RenderObject.cpp:
       
 35729         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
       
 35730         (WebCore::RenderObject::absoluteOutlineBox):
       
 35731 
       
 35732 2007-05-11  Rob Buis  <buis@kde.org>
       
 35733 
       
 35734         Reviewed by Oliver.
       
 35735 
       
 35736         Cleanups mostly inspired by Coverage results.
       
 35737 
       
 35738         * ksvg2/css/SVGCSSParser.cpp:
       
 35739         (WebCore::CSSParser::parseSVGValue):
       
 35740         (WebCore::CSSParser::parseSVGStrokeDasharray):
       
 35741         * ksvg2/css/SVGRenderStyleDefs.cpp:
       
 35742         (StyleFillData::operator==):
       
 35743         * ksvg2/svg/SVGColor.cpp:
       
 35744         (WebCore::SVGColor::colorFromRGBColorString):
       
 35745 
       
 35746 2007-05-11  Holger Freyther <freyther@kde.org>
       
 35747 
       
 35748         Reviewed by Mark Rowe.
       
 35749 
       
 35750         Move libcurl configuration into WebKit.pri so it will be used by GdkLauncher.
       
 35751 
       
 35752         * WebCore.pro:
       
 35753 
       
 35754 2007-05-10  David Hyatt  <hyatt@apple.com>
       
 35755 
       
 35756         <rdar://problem/5015522> Bounds rectangle of unloaded images is 
       
 35757         drawn briefly while loading
       
 35758         
       
 35759         When the image is null and has no size, don't draw the grey
       
 35760         rectangles or alt text any more.  Wait for an actual error to
       
 35761         occur with the image before we start showing alt text and borders.
       
 35762 
       
 35763         (Images with no source set at all will continue to show alt text and
       
 35764         borders immediately.)
       
 35765 
       
 35766         Reviewed by bradee-oh
       
 35767 
       
 35768         * rendering/RenderImage.cpp:
       
 35769         (WebCore::RenderImage::paint):
       
 35770 
       
 35771 2007-05-10  Mitz Pettel  <mitz@webkit.org>
       
 35772 
       
 35773         Reviewed by Darin.
       
 35774 
       
 35775         - fix http://bugs.webkit.org/show_bug.cgi?id=13655
       
 35776           Incomplete repaint when text-shadow is used in a render layer with explicit height
       
 35777 
       
 35778         Test: fast/repaint/layer-full-repaint.html
       
 35779 
       
 35780         Removed custom repaint logic from RenderLayer. repaintAfterLayoutIfNeeded()
       
 35781         knows how to do everything we need now. The only catch is that we cannot
       
 35782         rely on its "do a full repaint if the object needs layout" behavior, since
       
 35783         by the time we call it, the needs layout flag has been reset. The solution
       
 35784         is to cache the need for a full repaint in the layer.
       
 35785 
       
 35786         * page/FrameView.cpp:
       
 35787         (WebCore::FrameView::layout): Removed call to checkForRepaintOnResize().
       
 35788         * rendering/RenderLayer.cpp:
       
 35789         (WebCore::RenderLayer::checkForRepaintOnResize): Removed.
       
 35790         (WebCore::RenderLayer::RenderLayer): Replaced the m_repaintOverflowOnResize
       
 35791         flag with a m_needsFullRepaint flag, which indicates that the layer needs
       
 35792         to do a full repaint in the next call to updateLayerPositions().
       
 35793         (WebCore::RenderLayer::updateLayerPositions): Simplified the repaint logic.
       
 35794         Either call repaintAfterLayoutIfNeeded() or do a full repaint, depending on
       
 35795         m_needsFullRepaint.
       
 35796         * rendering/RenderLayer.h:
       
 35797         (WebCore::RenderLayer::setNeedsFullRepaint):
       
 35798         * rendering/RenderObject.cpp:
       
 35799         (WebCore::RenderObject::setNeedsLayout): Mark the layer for full repaint.
       
 35800 
       
 35801 2007-05-10  Justin Garcia  <justin.garcia@apple.com>
       
 35802 
       
 35803         Reviewed by ggaren
       
 35804 
       
 35805         <rdar://problem/5195166> Incorrect proposedRange DOMRange passed to WebViewEditing delegate
       
 35806         
       
 35807         In setModifyBias, we must cache the start and the end 
       
 35808         because the calls to setBase and setExtent can modify 
       
 35809         them (added a testcase).
       
 35810         The temporary SelectionController that we use in modify() to
       
 35811         produce the proposed range that will be passed to 
       
 35812         shouldChangeSelectedDOMRange must have the same m_modifyBias
       
 35813         as the original SelectionController, or else when the 
       
 35814         modification is performed, setModifyBias can swap the base 
       
 35815         and the extent incorrectly (added a testcase).
       
 35816         Renamed m_modifyBias to m_lastChangeWasHorizontalExtension.
       
 35817         Renamed setModifyBias to willBeModified.
       
 35818 
       
 35819         * editing/SelectionController.cpp:
       
 35820         (WebCore::SelectionController::SelectionController):
       
 35821         (WebCore::SelectionController::setSelection):
       
 35822         (WebCore::SelectionController::willBeModified):
       
 35823         (WebCore::SelectionController::modify):
       
 35824         * editing/SelectionController.h:
       
 35825         (WebCore::SelectionController::setLastChangeWasHorizontalExtension):
       
 35826         * page/EventHandler.cpp:
       
 35827         (WebCore::EventHandler::handleMousePressEventSingleClick):
       
 35828         (WebCore::EventHandler::updateSelectionForMouseDragOverPosition):
       
 35829 
       
 35830 2007-05-10  Geoffrey Garen  <ggaren@apple.com>
       
 35831 
       
 35832         Reviewed by Darin Adler.
       
 35833 
       
 35834         "IconDatabase::sharedIconDatabase()" => "iconDatabase()" for terseness,
       
 35835         in the style of WebCore::cache().
       
 35836 
       
 35837         * WebCore.exp:
       
 35838         * history/HistoryItem.cpp: Removed retainIconInDatabase because calling
       
 35839         "retain" in order to release something is really confusing and, now that
       
 35840         iconDatabase() is more terse, we don't need this helper to shorten the
       
 35841         syntax. (The isEmpty() check is also done by the database, so we don't 
       
 35842         need it either.)
       
 35843 
       
 35844         (WebCore::IconDatabase::~IconDatabase): ASSERT that our destructor isn't
       
 35845         called. We're a singleton, so it's confusing to have tear-down code.
       
 35846 
       
 35847 2007-05-10  Adele Peterson  <adele@apple.com>
       
 35848 
       
 35849         Reviewed by Hyatt.
       
 35850 
       
 35851         WebCore part of fix for <rdar://problem/4100616> Doing a "find" in RSS doesn't scroll to result
       
 35852 
       
 35853         Test: fast/overflow/scroll-nested-positioned-layer-in-overflow.html
       
 35854 
       
 35855         Merged visibleSelectionRect into selectionRect.  selectionRect() now takes an argument to determine
       
 35856         whether or not to return a rect that clips to the visible content.  This change makes all of the implementations of selectionRect
       
 35857         consistent by having them all consider the repaint rect when clipping to visible content.
       
 35858 
       
 35859         * page/Frame.cpp:
       
 35860         (WebCore::Frame::revealSelection): Call selectionRect with clipToVisibleContent = false, so we can get a rect that's not visible to reveal.
       
 35861         (WebCore::Frame::selectionRect): Added clipToVisibleContent argument, and merged visibleSelectionRect into this method.
       
 35862         (WebCore::Frame::setIsActive): Use selectionRect instead of visibleSelectionRect.
       
 35863         * page/Frame.h:
       
 35864         * page/mac/FrameMac.mm: (WebCore::Frame::selectionImage): Update layout before creating the image.  Use selectionRect instead of visibleSelectionRect.
       
 35865         * page/DragController.cpp: (WebCore::dragLocForSelectionDrag): Use selectionRect instead of visibleSelectionRect.
       
 35866 
       
 35867         * rendering/RenderBR.h: (WebCore::RenderBR::selectionRect): Updated argument.
       
 35868         * rendering/RenderBlock.h: (WebCore::RenderBlock::selectionRect): ditto.
       
 35869         * rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::selectionRect): ditto.
       
 35870         * rendering/RenderSVGInlineText.h: ditto.
       
 35871         * rendering/RenderObject.h: 
       
 35872         (WebCore::RenderObject::selectionRect): ditto.
       
 35873         (WebCore::RenderObject::SelectionInfo::SelectionInfo): ditto.
       
 35874         * rendering/RenderView.cpp:
       
 35875         (WebCore::RenderView::selectionRect): ditto.
       
 35876         (WebCore::RenderView::setSelection): ditto.
       
 35877         * rendering/RenderView.h:
       
 35878 
       
 35879         * rendering/RenderText.h:
       
 35880         * rendering/RenderText.cpp: (WebCore::RenderText::selectionRect): Only call computeAbsoluteRepaintRect when clipping to visible content.
       
 35881         Otherwise, just adjust the rect to the correct position.
       
 35882         * rendering/RenderListMarker.h:
       
 35883         * rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::selectionRect):
       
 35884           To match what we do in RenderText, if we're trying to clip to visible content, just call computeAbsoluteRepaintRect.
       
 35885         * rendering/RenderReplaced.h:
       
 35886         * rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRect): ditto.
       
 35887 
       
 35888         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Check for a parent layer at the beginning, so we can try to scroll all of our parent layers 
       
 35889           first, before trying to scroll the top level view.  Also, don't try to scroll overflow layers that have -webkit-line-clamp restricting the height.
       
 35890           This will prevent us from revealing text hidden by the slider in Safari RSS.
       
 35891 
       
 35892         * WebCore.exp: Update symbols for WebKit.
       
 35893 
       
 35894 2007-05-10  David Hyatt  <hyatt@apple.com>
       
 35895 
       
 35896         Fix for:
       
 35897 
       
 35898         <rdar://problem/5195272> REGRESSION: broke outline rings for continuations 
       
 35899         with empty inline containers
       
 35900         
       
 35901         http://bugs.webkit.org/show_bug.cgi?id=13667
       
 35902 
       
 35903         Make sure to only include collapsed top/bottom margins of the block portion
       
 35904         of the continuation if we know for sure that we have inline line boxes before
       
 35905         and after that would prevent the collapse from going further.
       
 35906 
       
 35907         In plain English: the focus rings were too tall. :)
       
 35908 
       
 35909         Reviewed by beth
       
 35910 
       
 35911         * rendering/RenderFlow.cpp:
       
 35912         (WebCore::RenderFlow::addFocusRingRects):
       
 35913 
       
 35914 2007-05-10  David Hyatt  <hyatt@apple.com>
       
 35915 
       
 35916         Fix for:
       
 35917 
       
 35918         <rdar://problem/5067235> REGRESSION: Excessively wide table, impossible to resize
       
 35919 
       
 35920         The table used white-space: pre-wrap, which is supported only by WebKit.  There
       
 35921         was a bug with the computation of min pref width for pre-wrap text.
       
 35922 
       
 35923         Reviewed by mitzpettel
       
 35924 
       
 35925         fast/text/white-space/pre-wrap-line-test.html
       
 35926 
       
 35927         * rendering/RenderText.cpp:
       
 35928         (WebCore::RenderText::calcPrefWidths):
       
 35929 
       
 35930 2007-05-10  Brady Eidson  <beidson@apple.com>
       
 35931 
       
 35932         Reviewed by Oliver
       
 35933 
       
 35934         Cleanup from my earlier Java Applet patch.  We should keep a central location to query if 
       
 35935         a mime type counts as a Java Applet
       
 35936 
       
 35937         * html/HTMLObjectElement.cpp:
       
 35938         (WebCore::HTMLObjectElement::containsJavaApplet): Query MimeTypeRegistry on the type
       
 35939 
       
 35940         * platform/MimeTypeRegistry.cpp:
       
 35941         (WebCore::MimeTypeRegistry::isSupportedImageMIMEType): Update style
       
 35942         (WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType): Ditto
       
 35943         (WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType): Ditto
       
 35944         (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Perform the Java Applet check
       
 35945         * platform/MimeTypeRegistry.h:
       
 35946 
       
 35947         * rendering/RenderPartObject.cpp:
       
 35948         (WebCore::RenderPartObject::updateWidget): Query MimeTypeRegistry on the type
       
 35949 
       
 35950 2007-05-10  Patti Hoa  <patti@apple.com>
       
 35951 
       
 35952         Reviewed by Darin.
       
 35953         
       
 35954         <rdar://problem/4720109> Sentence textMarker methods do not work well with empty lines
       
 35955         
       
 35956         * bridge/mac/WebCoreAXObject.mm:
       
 35957         (-[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]):
       
 35958         (-[WebCoreAXObject doAXPreviousSentenceStartTextMarkerForTextMarker:]):
       
 35959         When a marker position is given, the sentence ax methods automatically shift position by one to make sure
       
 35960         not to ask for the current sentence again.  This is generally fine except when the position
       
 35961         shift over an empty line break, which is should be considered a separate sentence. In this case, 
       
 35962         if we used the shifted position to ask for sentence boundary, ICU parser is not given the text data
       
 35963         containing the newline to correctly determine the sentence boundary.  Since the ax sentence method is 
       
 35964         explicitly shifting the position to ask for sentence boundary, it should make sure not to skip over important
       
 35965         character that can be a standalone sentence.
       
 35966         * editing/visible_units.cpp:
       
 35967         (WebCore::nextBoundary):
       
 35968         When determining boundary, don't stop on a collapsed range, such as newline.  
       
 35969         Just pick the next valid position to use as boundary.
       
 35970 
       
 35971 2007-05-10  Maciej Stachowiak  <mjs@apple.com>
       
 35972 
       
 35973         Reviewed by Oliver.
       
 35974 
       
 35975         - WebCore part of fix for:
       
 35976         <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load)
       
 35977         <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)
       
 35978 
       
 35979         The basic approach is to have Frames start out containing an empty document instead of absolutely nothing,
       
 35980         so there is no need to initialize them on demand. Various side effects of that cause both of these bugs.
       
 35981         
       
 35982         However, this caused many regressions so I had to fix the fallout.
       
 35983         
       
 35984         * WebCore.exp: fix symbol exports
       
 35985         * bindings/js/kjs_window.cpp:
       
 35986         (KJS::createNewWindow): useless "created" bool (we don't need it here)
       
 35987         (KJS::WindowFunc::callAsFunction): detect if we created a new frame, because if so,
       
 35988         we need to initialize the domain (can't count on it not having a document), also
       
 35989         don't try to make a new document for it.
       
 35990         Also, stop properly.
       
 35991         * css/cssstyleselector.cpp:
       
 35992         (WebCore::CSSStyleSelector::CSSStyleSelector): don't count on document having a view here
       
 35993         * html/HTMLObjectElement.cpp:
       
 35994         (WebCore::HTMLObjectElement::isImageType): Ask client, to match how other <object> renderer
       
 35995         decisions are made.
       
 35996         * loader/FrameLoader.cpp:
       
 35997         (WebCore::FrameLoader::FrameLoader): Initialize new data members
       
 35998         (WebCore::FrameLoader::init): Do the slightly tricky sequence of steps to properly make
       
 35999         an empty document with everything hooked up.
       
 36000         (WebCore::FrameLoader::createWindow): Added "created" bool.
       
 36001         (WebCore::FrameLoader::stopLoading): (whitespace change)
       
 36002         (WebCore::FrameLoader::begin): Don't try to create an empty document.
       
 36003         (WebCore::FrameLoader::finishedParsing): If creating an initial empty document, don't
       
 36004         do any of this work.
       
 36005         (WebCore::FrameLoader::checkCompleted): Do checkLoadComplete() as well.
       
 36006         (WebCore::FrameLoader::baseURL): don't check for null document
       
 36007         (WebCore::FrameLoader::baseTarget): ditto
       
 36008         (WebCore::FrameLoader::completeURL): ditto
       
 36009         (WebCore::FrameLoader::didTellBridgeAboutLoad): ditto
       
 36010         (WebCore::FrameLoader::scheduleLocationChange): determine duringLoad differently; doc won't
       
 36011         be null.
       
 36012         (WebCore::FrameLoader::gotoAnchor): don't check for null document
       
 36013         (WebCore::FrameLoader::canTarget): don't check for null document
       
 36014         (WebCore::FrameLoader::stopForUserCancel): new method for explicit stops like window.stop().
       
 36015         (WebCore::FrameLoader::transitionToCommitted): check for pre-loaded state properly
       
 36016         (WebCore::FrameLoader::createEmptyDocument): removed
       
 36017         (WebCore::FrameLoader::checkLoadCompleteForThisFrame): don't send delegate callbacks when making initial
       
 36018         doc.
       
 36019         (WebCore::FrameLoader::tokenizerProcessedData): Assume document; just checkCompleted now that it
       
 36020         does checkLoadComplete.
       
 36021         (WebCore::FrameLoader::receivedMainResourceError): assume document
       
 36022         (WebCore::FrameLoader::saveDocumentState): Assume there's a document except during initial load
       
 36023         (WebCore::FrameLoader::mainReceivedCompleteError): do checkCompleted, not checkLoadComplete
       
 36024         (WebCore::FrameLoader::continueLoadWithData): assume document
       
 36025         * loader/FrameLoader.h:
       
 36026         * loader/MainResourceLoader.cpp:
       
 36027         (WebCore::MainResourceLoader::receivedError): Add more ref protection and do things in a slightly
       
 36028         different order.
       
 36029         * page/DOMWindow.cpp:
       
 36030         (WebCore::DOMWindow::document): don't force document creation, just assert there is one.
       
 36031         * page/Frame.cpp:
       
 36032         (WebCore::Frame::init): Added init method.
       
 36033         (WebCore::Frame::pageDestroyed): when a frame is removed, make sure to check if the parent is
       
 36034         done loading.
       
 36035         * page/Frame.h:
       
 36036         * page/mac/WebCoreFrameBridge.mm:
       
 36037         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): No need to force
       
 36038         document.
       
 36039         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]): ditto
       
 36040         * platform/graphics/svg/SVGImage.cpp:
       
 36041         (WebCore::SVGImage::dataChanged): init the frame
       
 36042         * rendering/RenderPart.cpp:
       
 36043         (WebCore::RenderPart::updateWidgetPosition): If a subframe needs layout, then lay it out even
       
 36044         if the bounds did not change; the content size might be wrong.
       
 36045         * rendering/RenderTreeAsText.cpp:
       
 36046         (WebCore::externalRepresentation): Don't crash if the frame lacks a view.
       
 36047 
       
 36048 2007-05-10  David Hyatt  <hyatt@apple.com>
       
 36049 
       
 36050         Fix for:
       
 36051 
       
 36052         <rdar://problem/5146757> REGRESSION: div that wrapped to screen width in 
       
 36053         tiger no longer wraps
       
 36054         
       
 36055         http://bugs.webkit.org/show_bug.cgi?id=13654
       
 36056 
       
 36057         Reviewed by mitz
       
 36058 
       
 36059         fast/text/whitespace/normal-after-nowrap-breaking.html
       
 36060 
       
 36061         * rendering/RenderBlock.cpp:
       
 36062         (WebCore::RenderBlock::calcInlinePrefWidths):
       
 36063 
       
 36064 2007-05-10  David Hyatt  <hyatt@apple.com>
       
 36065 
       
 36066         Fix for:
       
 36067 
       
 36068         <rdar://problem/4778099> Links with nested continuations fail to 
       
 36069         paint their outlines (11255)
       
 36070         
       
 36071         http://bugs.webkit.org/show_bug.cgi?id=11255
       
 36072 
       
 36073         Fix multiple bugs with outline painting of continuations to ensure that
       
 36074         all combos work (empty/full inline - block with/without margins - 
       
 36075         empty/full inline).
       
 36076 
       
 36077         Reviewed by mitz
       
 36078 
       
 36079         fast/inline/continuation-outlines.html
       
 36080 
       
 36081         * rendering/RenderBlock.cpp:
       
 36082         (WebCore::RenderBlock::paintObject):
       
 36083         * rendering/RenderFlow.cpp:
       
 36084         (WebCore::RenderFlow::addFocusRingRects):
       
 36085 
       
 36086 2007-05-10  David Hyatt  <hyatt@apple.com>
       
 36087 
       
 36088         Fix for:
       
 36089 
       
 36090         <rdar://problem/5193529> REGRESSION: RTL Overflows scrollbar not showing 
       
 36091         when they should be
       
 36092         
       
 36093         Fallout from fix for bug 11926.  Make sure to restrict the fix to the
       
 36094         RenderView for now, since the full-blown overflow case is pretty involved.
       
 36095 
       
 36096         Reviewed by mitzpettel
       
 36097 
       
 36098         fast/overflow/unreachable-content-bug-rtl.html
       
 36099 
       
 36100         * rendering/RenderBlock.cpp:
       
 36101         (WebCore::RenderBlock::lowestPosition):
       
 36102         (WebCore::RenderBlock::rightmostPosition):
       
 36103         (WebCore::RenderBlock::leftmostPosition):
       
 36104 
       
 36105 2007-05-10  Brady Eidson <beidson@apple.com>
       
 36106 
       
 36107         Reviewed by Oliver
       
 36108 
       
 36109         Fix for http://bugs.webkit.org/show_bug.cgi?id=13636 and <rdar://problem/5190816>
       
 36110 
       
 36111         When creating the applets collection, be sure to only count Objects if they contain
       
 36112         a java applet
       
 36113 
       
 36114         * html/HTMLCollection.cpp:
       
 36115         (WebCore::HTMLCollection::traverseNextItem): Add the qualifier for Objects that 
       
 36116           containsJavaApplet() must be true
       
 36117 
       
 36118         * html/HTMLObjectElement.cpp:
       
 36119         (WebCore::HTMLObjectElement::containsJavaApplet): Check this Object element and inner
       
 36120           nodes for any Java applets
       
 36121         * html/HTMLObjectElement.h: 
       
 36122 
       
 36123 2007-05-10  David Hyatt  <hyatt@apple.com>
       
 36124 
       
 36125         Fix for:
       
 36126 
       
 36127         <rdar://problem/4694859> SAP: HTML tags with overflow:hidden consume
       
 36128         space on page, do not consume space in Firefox (11926)
       
 36129 
       
 36130         http://bugs.webkit.org/show_bug.cgi?id=11926
       
 36131 
       
 36132         Make sure that unreachable objects along one axis (e.g., top/left) do not
       
 36133         contribute to the scrollable area in the opposite axis (e.g., right/bottom).
       
 36134 
       
 36135         Reviewed by olliej
       
 36136 
       
 36137         fast/overflow/unreachable-content-test.html
       
 36138 
       
 36139         * rendering/RenderBlock.cpp:
       
 36140         (WebCore::RenderBlock::lowestPosition):
       
 36141         (WebCore::RenderBlock::rightmostPosition):
       
 36142         (WebCore::RenderBlock::leftmostPosition):
       
 36143 
       
 36144 2007-05-10  David Hyatt  <hyatt@apple.com>
       
 36145 
       
 36146         Fix for:
       
 36147 
       
 36148         <rdar://problem/4656825> REGRESSION: Japanese TV time table widget:
       
 36149         part of the number in background has been cut off.
       
 36150 
       
 36151         Now that opacity uses a tight bounding box to clip, we need to make sure
       
 36152         to factor spillout caused by negative letter spacing into our right
       
 36153         overflow.  Latch on to the code that does this already for text-stroke
       
 36154         and text-shadow.
       
 36155 
       
 36156         Reviewed by olliej
       
 36157 
       
 36158         fast/text/letter-spacing-negative-opacity.html
       
 36159 
       
 36160        * rendering/InlineFlowBox.cpp:
       
 36161         (WebCore::InlineFlowBox::placeBoxesHorizontally):
       
 36162 
       
 36163 2007-05-10  Geoffrey Garen  <ggaren@apple.com>
       
 36164 
       
 36165         Reviewed by Maciej Stachowiak.
       
 36166         
       
 36167         More fix-ups to the WebScriptObject/WebScripting APIs, related to
       
 36168         <rdar://problem/5140447> API for fetching JSGlobalContextRef from WebView 
       
 36169         or WebFrame
       
 36170 
       
 36171         * bindings/objc/WebScriptObject.h: Fully specified the surprising rules for
       
 36172         type conversion between JavaScript and ObjC.
       
 36173         * bindings/objc/WebScriptObject.mm: Added up-call accessor to WebFrame.
       
 36174         This is kind of stinky, but I'm OK with it because eventually all of this
       
 36175         code should move up into WebKit.
       
 36176         (+[WebScriptObject scriptObjectForJSObject:frame:]):
       
 36177         (-[WebScriptObject valueForKey:]):
       
 36178         (-[WebScriptObject JSObject]): 
       
 36179             - Added _rootObject check because if _rootObject returns NULL it means 
       
 36180             that _imp is no longer GC protected, so it's not safe to use. 
       
 36181             - Added _isSafeScript check because that's what WebScriptObject methods
       
 36182             typically do, even though the value of doing so isn't clear to me.
       
 36183         * bindings/objc/WebScriptObjectPendingPublic.h: Added WebFrame* parameter
       
 36184         to -scriptObjectForJSObject:. This is required to wrap JS objects that
       
 36185         are not already in the wrapper cache. It would be nice to remove this
       
 36186         limitation of WebScriptObject some day.
       
 36187         * page/mac/FrameMac.mm:
       
 36188         (WebCore::Frame::cleanupPlatformScriptObjects): Force removal of m_windowScriptObject
       
 36189         from the cache, to avoid retrieving the m_windowScriptObject from the previous
       
 36190         page on a new page load. (It would be non-functional in that case.)
       
 36191 
       
 36192 2007-05-10  David Hyatt  <hyatt@apple.com>
       
 36193 
       
 36194         Fix for <rdar://problem/5183697>.
       
 36195 
       
 36196         http://bugs.webkit.org/show_bug.cgi?id=13576
       
 36197 
       
 36198         Make sure verticalPositionHint is not called on an inline-block from
       
 36199         content inside the inline-block (like text).
       
 36200 
       
 36201         Reviewed by olliej
       
 36202 
       
 36203         fast/inline-block/inline-block-vertical-align.html
       
 36204 
       
 36205         * rendering/RenderObject.cpp:
       
 36206         (WebCore::RenderObject::verticalPositionHint):
       
 36207         * rendering/RenderText.cpp:
       
 36208         (WebCore::RenderText::verticalPositionHint):
       
 36209         * rendering/RenderThemeMac.mm:
       
 36210         (WebCore::RenderThemeMac::setFontFromControlSize):
       
 36211 
       
 36212 2007-05-09  Holger Freyther <zecke@selfish.org>
       
 36213 
       
 36214         Reviewed by Mark Rowe.
       
 36215 
       
 36216         Gdk build fix with SVG enabled.  Stub out ImageBufferCairo.
       
 36217 
       
 36218         * WebCore.pro: Build ImageBufferCairo.cpp
       
 36219         * platform/graphics/cairo/ImageBufferCairo.cpp: Added.
       
 36220         (WebCore::ImageBuffer::create):
       
 36221         (WebCore::ImageBuffer::~ImageBuffer):
       
 36222         (WebCore::ImageBuffer::context):
       
 36223 
       
 36224 2007-05-08  Justin Garcia  <justin.garcia@apple.com>
       
 36225 
       
 36226         Reviewed by darin
       
 36227         
       
 36228         <rdar://problem/5017613> Style changes don't effect fully selected ToDo content
       
 36229 
       
 36230         * editing/ApplyStyleCommand.cpp:
       
 36231         (WebCore::ApplyStyleCommand::applyInlineStyle):
       
 36232         Use a for loop instead of while(1).
       
 36233         Simplify loop termination using Range::pastEndNode.
       
 36234         Don't handle the start.node() == end.node() case 
       
 36235         specially, it's unnecessary.
       
 36236         Apply the style change to fully selected plaintext-only
       
 36237         regions, not with wrapper spans inside the region, but 
       
 36238         by changing the element's inline style declaration.
       
 36239         Don't descend into nodes whose children we should ignore.
       
 36240 
       
 36241 2007-05-09  Adele Peterson  <adele@apple.com>
       
 36242 
       
 36243         Reviewed by Hyatt.
       
 36244 
       
 36245         Fix for <rdar://problem/5113578> REGRESSION: textfields that set the height but not the font 
       
 36246         look different from IE & FF because the font is small
       
 36247 
       
 36248         For plain text fields, don't stretch the inner text box.  Center it vertically in the field.
       
 36249 
       
 36250         * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::layout):
       
 36251 
       
 36252 2007-05-09  Atul Mehrotra  <atul.mehrotra@celunite.com>
       
 36253 
       
 36254         Gdk build fix.
       
 36255 
       
 36256         * platform/gdk/TemporaryLinkStubs.cpp:
       
 36257         (Editor::newGeneralClipboard):
       
 36258 
       
 36259 2007-05-09  Mitz Pettel  <mitz@webkit.org>
       
 36260 
       
 36261         Reviewed by Dave Hyatt.
       
 36262 
       
 36263         - fix http://bugs.webkit.org/show_bug.cgi?id=13037
       
 36264           REGRESSION: Copy-on-scroll not reset properly after back/forward navigation
       
 36265 
       
 36266         * page/FrameView.cpp:
       
 36267         (WebCore::FrameViewPrivate::FrameViewPrivate): Moved initialization of
       
 36268         m_slowRepaintObjectCount here.
       
 36269         (WebCore::FrameViewPrivate::reset): Do not reset the slow repaint object
       
 36270         count here.
       
 36271         (WebCore::FrameView::useSlowRepaints):
       
 36272         (WebCore::FrameView::addSlowRepaintObject):
       
 36273         (WebCore::FrameView::removeSlowRepaintObject): Added an assertion that the
       
 36274         object count is positive.
       
 36275         * rendering/RenderObject.cpp:
       
 36276         (WebCore::RenderObject::setStyle): Corrected a mix up between old and new
       
 36277         style, which caused the object count to be decremented when it was supposed
       
 36278         to be incremented and vice versa.
       
 36279 
       
 36280 2007-05-09  Peter Müller <pm@one.com>
       
 36281 
       
 36282         Reviewed by Dave Hyatt.
       
 36283 
       
 36284         Changed the hardcoded colors that are used for CSS 2.1 system colors.
       
 36285         Previous colors had numerous conflicts in semantic pairs, which
       
 36286         made text invisible in highlight, info and menu colored areas.
       
 36287         The new hardcoded colors are inspired by Aqua.
       
 36288 
       
 36289         Ideally these colors should be fetched through AppKit instead,
       
 36290         though I am not sure if it is possible to make a 1:1 mapping
       
 36291         between CSS2.1 system colors and Mac OS X.
       
 36292 
       
 36293         * css/cssstyleselector.cpp:
       
 36294         (WebCore::):
       
 36295 
       
 36296 2007-05-09  Lars Knoll <lars@trolltech.com>
       
 36297 
       
 36298         Fix the Qt build.
       
 36299 
       
 36300         * editing/qt/EditorQt.cpp:
       
 36301 
       
 36302 2007-05-08  Geoffrey Garen  <ggaren@apple.com>
       
 36303 
       
 36304         Reviewed by Darin Adler.
       
 36305         
       
 36306         More fix-ups to the WebScriptObject/WebScripting APIs, related to
       
 36307         <rdar://problem/5140447> API for fetching JSGlobalContextRef from WebView 
       
 36308         or WebFrame
       
 36309         
       
 36310         1. Added -scriptObjectForJSObject: SPI so you can bridge back from JavaScriptCore
       
 36311         to WebScriptObject.
       
 36312         
       
 36313         2. Fixed WebScriptObject bridging so that you always get the same WebScriptObject
       
 36314         for a JSObject (like in the DOM). This makes -scriptObjectForJSObject: a
       
 36315         lot more coherent as an API.
       
 36316 
       
 36317         * bindings/objc/DOMInternal.mm: Renamed wrapperCache to DOMWrapperCache
       
 36318         to distinguish from the JSWrapperCache. Added typedef for readability.
       
 36319         (WebCore::getDOMWrapper):
       
 36320         (WebCore::addDOMWrapper):
       
 36321         (WebCore::removeDOMWrapper):
       
 36322         * bindings/objc/WebScriptObject.mm: Added JSWrapperCache, which works just
       
 36323         like the DOMWrapperCache.
       
 36324         (WebCore::getJSWrapper):
       
 36325         (WebCore::addJSWrapper):
       
 36326         (WebCore::removeJSWrapper):
       
 36327         (WebCore::createJSWrapper):
       
 36328         (+[WebScriptObject scriptObjectForJSObject:]): This is the new API. It attempts
       
 36329         to return a specific DOM wrapper object, or, barring that, it returns a 
       
 36330         generic WebScriptObject.
       
 36331         (+[WebScriptObject scriptObjectForJSObject:originRootObject:rootObject:]):
       
 36332         Added this method to support our old WebScriptObject security and leak 
       
 36333         checking model, even though it doesn't work very well. 
       
 36334         (-[WebScriptObject _setImp:originRootObject:rootObject:]):
       
 36335         (-[WebScriptObject dealloc]):
       
 36336         (-[WebScriptObject finalize]):
       
 36337         (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
       
 36338         * bindings/objc/WebScriptObjectPendingPublic.h:
       
 36339         * bindings/objc/WebScriptObjectPrivate.h:
       
 36340         * page/mac/FrameMac.mm:
       
 36341         (WebCore::Frame::windowScriptObject): Changed to use the new API. This
       
 36342         fixes a bug where the object sent to -windowScriptObjectAvailable: and returned
       
 36343         from -windowScriptObject could not be round-tripped.
       
 36344 
       
 36345 2007-05-09  Mark Rowe  <mrowe@apple.com>
       
 36346 
       
 36347         Build fix.
       
 36348 
       
 36349         * editing/Editor.cpp:
       
 36350         (WebCore::findFirstGrammarDetailInRange): Use unsigned rather than int.
       
 36351         (WebCore::findFirstBadGrammarInRange): Cast to unsigned in assertion.
       
 36352         (WebCore::isRangeUngrammatical): Remove unused variables.
       
 36353 
       
 36354 2007-05-08  Oliver Hunt  <oliver@apple.com>
       
 36355 
       
 36356         Reviewed by Darin.
       
 36357         
       
 36358         Fix <rdar://problem/5188938> arc method on Canvas causes hang or crash
       
 36359         
       
 36360         Workaround bad behaviour of CGPathAddArc when passed inf as start or
       
 36361         end angles.
       
 36362 
       
 36363         * platform/graphics/cg/PathCG.cpp:
       
 36364         (WebCore::Path::addArc):
       
 36365 
       
 36366 2007-05-08  Darin Adler  <darin@apple.com>
       
 36367 
       
 36368         Reviewed by Hyatt and Hatcher.
       
 36369 
       
 36370         - fix auto-activation code path so Tiger and Leopard aren't different
       
 36371 
       
 36372         * platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]):
       
 36373         Do the auto-activation dance first before doing anything else, and ignore the
       
 36374         font that it returns.
       
 36375 
       
 36376 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
       
 36377 
       
 36378         Reviewed by Darin.
       
 36379 
       
 36380         Moved most spelling/grammar logic to C++.  Now calls through to
       
 36381         WebKit to actually invoke NSSpellChecker.
       
 36382 
       
 36383         * editing/Editor.cpp:
       
 36384         (WebCore::Editor::ignoreSpelling): Added (ported from EditorMac).
       
 36385         (WebCore::Editor::learnSpelling): Added (ported from EditorMac).
       
 36386         (WebCore::findFirstMisspellingInRange): Added (ported from EditorMac).
       
 36387         (WebCore::paragraphAlignedRangeForRange): Added (ported from EditorMac).
       
 36388         (WebCore::findFirstGrammarDetailInRange): Added (ported from EditorMac).
       
 36389         (WebCore::findFirstBadGrammarInRange): Added (ported from EditorMac).
       
 36390         (WebCore::Editor::advanceToNextMisspelling): Added (ported from EditorMac).
       
 36391         (WebCore::Editor::isSelectionMisspelled): Added (ported from EditorMac).
       
 36392         (WebCore::isRangeUngrammatical): Added (ported from EditorMac).
       
 36393         (WebCore::Editor::isSelectionUngrammatical): Added (ported from EditorMac).
       
 36394         (WebCore::Editor::guessesForUngrammaticalSelection): Added (ported from EditorMac).
       
 36395         (WebCore::Editor::guessesForMisspelledSelection): Added (ported from EditorMac).
       
 36396         (WebCore::Editor::showSpellingGuessPanel): Added (ported from EditorMac).
       
 36397         (WebCore::Editor::spellingPanelIsShowing): Added (ported from EditorMac).
       
 36398         (WebCore::Editor::markMisspellingsAfterTypingToPosition): Added (ported from EditorMac).
       
 36399         (WebCore::markAllMisspellingsInRange): Added (ported from EditorMac).
       
 36400         (WebCore::markAllBadGrammarInRange): Added (ported from EditorMac).
       
 36401         (WebCore::markMisspellingsOrBadGrammar): Added (ported from EditorMac).
       
 36402         (WebCore::Editor::markMisspellings): Added (ported from EditorMac).
       
 36403         (WebCore::Editor::markBadGrammar): Added (ported from EditorMac).
       
 36404         * editing/mac/EditorMac.mm: Removed Objective C version of spelling/grammar calls.
       
 36405 
       
 36406 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
       
 36407 
       
 36408         Reviewed by Ada.
       
 36409 
       
 36410         Slight modification to last editor method fix.
       
 36411 
       
 36412         * bridge/EditorClient.h:
       
 36413         * platform/gdk/EditorClientGdk.cpp:
       
 36414         (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString):
       
 36415         * platform/gdk/EditorClientGdk.h:
       
 36416         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 36417         (WebCore::SVGEmptyEditorClient::updateSpellingUIWithGrammarString):
       
 36418 
       
 36419 2007-05-08  Alexey Proskuryakov  <ap@webkit.org>
       
 36420 
       
 36421         Reviewed by Hyatt.
       
 36422 
       
 36423         http://bugs.webkit.org/show_bug.cgi?id=13480
       
 36424         window.Attr is undefined
       
 36425 
       
 36426         Test: fast/dom/Window/attr-constructor.html
       
 36427 
       
 36428         * dom/Attr.idl:
       
 36429         * dom/CDATASection.idl:
       
 36430         * dom/CharacterData.idl:
       
 36431         * dom/Comment.idl:
       
 36432         * dom/DOMImplementation.idl:
       
 36433         * dom/DocumentType.idl:
       
 36434         * dom/Entity.idl:
       
 36435         * dom/EntityReference.idl:
       
 36436         * dom/Notation.idl:
       
 36437         * dom/ProcessingInstruction.idl:
       
 36438         * dom/Text.idl:
       
 36439         Added GenerateConstructor.
       
 36440 
       
 36441         * page/DOMWindow.idl: Added constructor properties for DOM interfaces.
       
 36442 
       
 36443 2007-05-07  Geoffrey Garen  <ggaren@apple.com>
       
 36444 
       
 36445         Reviewed by Maciej Stachowiak.
       
 36446 
       
 36447         Fixed <rdar://problem/5140447> API for fetching JSGlobalContextRef from 
       
 36448         WebView or WebFrame
       
 36449         
       
 36450         Added support for new -[WebScriptObject JSObject] and -[WebFrame globalContext]
       
 36451         APIs.
       
 36452         
       
 36453         Also fixed some more cases of <rdar://problem/4395622> API: 
       
 36454         WebScriptObject.h incorrectly reports that -isSelectorExcludedFromWebScript 
       
 36455         returns NO by default, and generally cleaned up that documentation.
       
 36456 
       
 36457         * WebCore.exp: A lot of the diff here is from sorting.
       
 36458         * WebCore.xcodeproj/project.pbxproj:
       
 36459         * bindings/objc/WebScriptObject.h:
       
 36460         * bindings/objc/WebScriptObject.mm:
       
 36461         (-[WebScriptObject JSObject]):
       
 36462         * bindings/objc/WebScriptObjectPendingPublic.h: Added.
       
 36463 
       
 36464 2007-05-08  Lars Knoll <lars@trolltech.com>
       
 36465 
       
 36466         Reviewed by Hyatt.
       
 36467 
       
 36468         Fix valgrind reported uninitialized memory read.
       
 36469 
       
 36470         * rendering/RenderText.cpp:
       
 36471         (WebCore::RenderText::RenderText):
       
 36472 
       
 36473 2007-05-07  Justin Garcia  <justin.garcia@apple.com>
       
 36474 
       
 36475         Reviewed by oliver
       
 36476 
       
 36477         <rdar://problem/4895428> Can't drag selected ToDo
       
 36478         
       
 36479         The user tries to drag a selection by mousing down
       
 36480         on the editable part of a ToDo, which is focusable,
       
 36481         since it is an editable node within non-editable 
       
 36482         content.  But we focus focusable elements on mouse 
       
 36483         down, and focusing the editable piece blows away 
       
 36484         the selection and prevents the drag. This is how 
       
 36485         IE behaves, but content seems generally difficult 
       
 36486         to drag in IE, so this doesn't make it any worse.
       
 36487         
       
 36488         Since focus doesn't appear to be cancelable, either
       
 36489         with a DOM event or an editing delegate, I fixed this
       
 36490         by delaying the focus of focusable nodes that are 
       
 36491         selected and inside an already focused node.  The 
       
 36492         node will be focused if the user mouses up without 
       
 36493         doing any dragging because the mouse up sets a
       
 36494         selection, which calls setFocusNodeIfNeeded.
       
 36495 
       
 36496         * page/EventHandler.cpp:
       
 36497         (WebCore::EventHandler::dispatchMouseEvent):
       
 36498 
       
 36499 2007-05-07  Atul Mehrotra <atul.mehrotra@celunite.com>
       
 36500 
       
 36501         Reviewed by Maciej.
       
 36502 
       
 36503         GDK Build fix
       
 36504 
       
 36505         * platform/gdk/TemporaryLinkStubs.cpp:
       
 36506 
       
 36507 2007-05-07  Oliver Hunt  <oliver@apple.com>
       
 36508 
       
 36509         Reviewed by Maciej.
       
 36510 
       
 36511         Correcting comparisons to handle NaN in the same manner
       
 36512         as other Canvas methods.
       
 36513 
       
 36514         * html/CanvasRenderingContext2D.cpp:
       
 36515         (WebCore::CanvasRenderingContext2D::arcTo):
       
 36516         (WebCore::CanvasRenderingContext2D::arc):
       
 36517           Correcting arc/arcTo to match the WHAT WG draft.
       
 36518         (WebCore::CanvasRenderingContext2D::rect):
       
 36519         (WebCore::CanvasRenderingContext2D::clearRect):
       
 36520         (WebCore::CanvasRenderingContext2D::fillRect):
       
 36521         (WebCore::CanvasRenderingContext2D::strokeRect):
       
 36522 
       
 36523 2007-05-07  David Hyatt  <hyatt@apple.com>
       
 36524 
       
 36525         Add some comments to the glyph/font code (patch from MarvinD, tweaked by
       
 36526         me to correct a few bits and to make it forward-compatible with the work
       
 36527         going on in 3315.
       
 36528 
       
 36529         Reviewed by me
       
 36530 
       
 36531         * ChangeLog:
       
 36532         * platform/Font.cpp:
       
 36533         (WebCore::Font::glyphDataForCharacter):
       
 36534         * platform/GlyphPageTreeNode.cpp:
       
 36535         (WebCore::GlyphPageTreeNode::initializePage):
       
 36536         * platform/GlyphPageTreeNode.h:
       
 36537 
       
 36538 2007-05-07  Justin Garcia  <justin.garcia@apple.com>
       
 36539 
       
 36540         Fix layout test failures.
       
 36541 
       
 36542         * editing/SelectionController.cpp:
       
 36543         (WebCore::SelectionController::contains): Use comparePositions
       
 36544         instead of Range::comparePoint, because comparePositions can
       
 36545         handle positions inside shadow trees.
       
 36546 
       
 36547 2007-05-07  Justin Garcia  <justin.garcia@apple.com>
       
 36548 
       
 36549         Reviewed by darin
       
 36550         
       
 36551         <rdar://problem/4895428> Can't drag selected To Do if it is not showing a due date
       
 36552         
       
 36553         The code in SelectionController::contains returned false 
       
 36554         incorrectly if the selection end just after a table 
       
 36555         and the position was inside that table.
       
 36556 
       
 36557         * editing/SelectionController.cpp:
       
 36558         (WebCore::SelectionController::contains): Compare the position with the
       
 36559         ends of the selection and then use Range::comparePoint.
       
 36560 
       
 36561 2007-05-07  Darin Adler  <darin@apple.com>
       
 36562 
       
 36563         - rolling out setInnerHTML optimization until I can figure out why tests are failing
       
 36564 
       
 36565 2007-05-07  Darin Adler  <darin@apple.com>
       
 36566 
       
 36567         Reviewed by Hyatt.
       
 36568 
       
 36569         - fix http://bugs.webkit.org/show_bug.cgi?id=13602
       
 36570           Amazon product pages keep repainting over and over again
       
 36571 
       
 36572         Optimize setInnerHTML, setOuterHTML, and setInnerText so they don't change the DOM at all
       
 36573         if they don't need to.
       
 36574 
       
 36575         Test: fast/dom/HTMLElement/set-inner-outer-optimization.html
       
 36576 
       
 36577         * html/HTMLElement.cpp:
       
 36578         (WebCore::equal): Added. Helper function that compares two Text nodes or two NamedAttrMap
       
 36579         attribute maps.
       
 36580         (WebCore::shallowEqual): Added. Helper function that compares two Element nodes or two
       
 36581         arbitrary nodes.
       
 36582         (WebCore::replaceChildrenWithFragment): Added. Helper function used by setInnerHTML and
       
 36583         setInnerText. Optimizes the cases where all the nodes are the same, where both the current
       
 36584         and the new content are single text nodes, and where the current content is a single node
       
 36585         that can be replaced with replaceChild.
       
 36586         (WebCore::replaceChildrenWithText): Added. Helper function used by setInnerText. Optimizes
       
 36587         the case where the current content is a single text node or a single node that can be
       
 36588         replaced with replaceChild.
       
 36589         (WebCore::HTMLElement::setInnerHTML): Changed to call replaceChildrenWithFragment.
       
 36590         (WebCore::HTMLElement::setOuterHTML): Added special case to optimize when the new content
       
 36591         exactly matches the current node.
       
 36592         (WebCore::HTMLElement::setInnerText): Changed to call replaceChildrenWithText in a few
       
 36593         cases instead of doing removeChildren/appendChild. Changed code that was using
       
 36594         DeprecatedString to instead use String. Changed general case to use a document fragment
       
 36595         and replaceChildrenWithFragment.
       
 36596 
       
 36597         * dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
       
 36598         Fixed bug where we would not dispatch the DOMSubtreeModified event unless someone
       
 36599         was registered for the DOMCharacterDataModified event. Caused trouble in the test.
       
 36600 
       
 36601 2007-05-06  Darin Adler  <darin@apple.com>
       
 36602 
       
 36603         - blind try at fixing the Qt build
       
 36604 
       
 36605         * platform/qt/TextBreakIteratorQt.cpp: (WebCore::sentenceBreakIterator):
       
 36606         Added a placeholder.
       
 36607 
       
 36608 2007-05-06  Darin Adler  <darin@apple.com>
       
 36609 
       
 36610         Reviewed by Hyatt.
       
 36611 
       
 36612         - fix http://bugs.webkit.org/show_bug.cgi?id=13537
       
 36613           Canvex example starts rendering strangely after a while
       
 36614 
       
 36615         * html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
       
 36616         Don't raise an exception if the source or destination rectangle is empty.
       
 36617 
       
 36618 2007-05-06  Darin Adler  <darin@apple.com>
       
 36619 
       
 36620         Reviewed by Hyatt.
       
 36621 
       
 36622         - fix <rdar://problem/4585593> REGRESSION: Some 2-byte characters in printed page
       
 36623           header are drawn with too-large font and clipped
       
 36624 
       
 36625         Doesn't affect text within web pages, so no layout test.
       
 36626 
       
 36627         * platform/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters):
       
 36628         Base the substitute font on the FontPlatformData rather than the FontDescription.
       
 36629         Before, it was a mix of both. This works properly for fonts where we have no
       
 36630         FontDescription and is also more internally consistent.
       
 36631 
       
 36632 2007-05-06  Darin Adler  <darin@apple.com>
       
 36633 
       
 36634         Reviewed by Hyatt.
       
 36635 
       
 36636         - http://bugs.webkit.org/show_bug.cgi?id=13606
       
 36637           some functions are virtual that don't need to be
       
 36638 
       
 36639         * dom/Node.h: Made first/lastChild be inline functions that call virtual functions.
       
 36640         This lets us hide the functions with another inline function in a derived class,
       
 36641         yet still override the behavior here in the base class by overriding the virtual
       
 36642         functions too.
       
 36643         * dom/Node.cpp:
       
 36644         (WebCore::Node::virtualFirstChild): Renamed virtual functions. There are now
       
 36645         non-virtual inline functions that call these virtual functions.
       
 36646         (WebCore::Node::virtualLastChild): Ditto.
       
 36647 
       
 36648         * dom/ContainerNode.h: Added non-virtual first/lastChild functions that hide the ones
       
 36649         inherited from the Node class; these also replace the fastFirst/LastChild functions,
       
 36650         and transparently give callers the faster form if they have a pointer of the right
       
 36651         type. But still override the virtual functions named virtualFirst/LastChild, because
       
 36652         those can still be called through a Node*. Removed the "fast" from the names of
       
 36653         fastSetFirst/LastChild.
       
 36654         * dom/ContainerNode.cpp:
       
 36655         (WebCore::ContainerNode::virtualFirstChild): Renamed virtual functions. There are now
       
 36656         also non-virtual inline versions.
       
 36657         (WebCore::ContainerNode::virtualLastChild): Ditto.
       
 36658 
       
 36659         * dom/CharacterData.cpp: Removed implementations of data and length functons.
       
 36660         * dom/CharacterData.h: Made data, setData, length, substringData, appendData,
       
 36661         insertData, deleteData, and replaceData all non-virtual, and made data and length
       
 36662         both be inline.
       
 36663 
       
 36664         * dom/NamedAttrMap.h: (WebCore::NamedAttrMap::attributeItem): Removed a null check
       
 36665         from this function. If the length of the map is known to be greater than 0, then
       
 36666         the null check isn't needed. But if the length of the map hasn't been checked at all,
       
 36667         then it's unsafe to call this function since it doesn't range check the array
       
 36668         index. Thus the null check is never needed. I also looked at all callers.
       
 36669 
       
 36670         * dom/Attr.cpp: (WebCore::Attr::createTextChild):
       
 36671         * dom/Document.cpp: (WebCore::Document::recalcStyle):
       
 36672         * dom/Element.cpp: (WebCore::Element::recalcStyle):
       
 36673         * ksvg2/svg/SVGElement.cpp:
       
 36674         (WebCore::SVGElement::haveLoadedRequiredResources):
       
 36675         Removed "fast" prefix from calls to fastFirst/LastChild and fastSetFirst/LastChlld.
       
 36676         It's not needed any more -- you still get fast behavior if the pointer has a type
       
 36677         that's ContainerNode or derived from it.
       
 36678 
       
 36679 2007-05-06  Mitz Pettel  <mitz@webkit.org>
       
 36680 
       
 36681         Reviewed by Hyatt.
       
 36682 
       
 36683         - fix http://bugs.webkit.org/show_bug.cgi?id=13557
       
 36684           Crash when dragging selection over absolutely positioned generated content on block element
       
 36685 
       
 36686         Test: fast/css-generated-content/positioned-background-hit-test-crash.html
       
 36687 
       
 36688         * rendering/RenderLayer.cpp:
       
 36689         (WebCore::RenderLayer::enclosingElement): Added. Factored out of hitTestLayer().
       
 36690         (WebCore::RenderLayer::hitTestLayer): Implemented the fix for <rdar://problem/3552346>
       
 36691         from r6106 to the self hit test as well, namely: return the enclosing element
       
 36692         for generated positioned content.
       
 36693         * rendering/RenderLayer.h:
       
 36694 
       
 36695 2007-05-06  Alexey Proskuryakov  <ap@webkit.org>
       
 36696 
       
 36697         Reviewed by Darin.
       
 36698 
       
 36699         http://bugs.webkit.org/show_bug.cgi?id=13584
       
 36700         <script> code wrongly assumes requests can't fail
       
 36701 
       
 36702         Test: fast/loader/unloadable-script.html
       
 36703 
       
 36704         * html/HTMLScriptElement.cpp:
       
 36705         (WebCore::HTMLScriptElement::parseMappedAttribute):
       
 36706         (WebCore::HTMLScriptElement::insertedIntoDocument):
       
 36707         Check the return value of requestScript().
       
 36708 
       
 36709 2007-05-06  Alexey Proskuryakov  <ap@webkit.org>
       
 36710 
       
 36711         Reviewed by Darin.
       
 36712 
       
 36713         http://bugs.webkit.org/show_bug.cgi?id=13304
       
 36714         REGRESSION(14784): WebKit doesn't dynamically reflect changes to the highlight color in System Preferences
       
 36715 
       
 36716         Implemented a notification observer that invalidates cached system colors.
       
 36717 
       
 36718         No automated test possible.
       
 36719 
       
 36720         * rendering/RenderTheme.cpp:
       
 36721         (WebCore::RenderTheme::activeSelectionBackgroundColor):
       
 36722         (WebCore::RenderTheme::inactiveSelectionBackgroundColor):
       
 36723         (WebCore::RenderTheme::platformColorsDidChange):
       
 36724         * rendering/RenderTheme.h:
       
 36725         * rendering/RenderThemeMac.h:
       
 36726         * rendering/RenderThemeMac.mm:
       
 36727         (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
       
 36728         (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]):
       
 36729         (WebCore::theme):
       
 36730         (WebCore::RenderThemeMac::RenderThemeMac):
       
 36731         (WebCore::RenderThemeMac::~RenderThemeMac):
       
 36732         (WebCore::RenderThemeMac::checkbox):
       
 36733         (WebCore::RenderThemeMac::radio):
       
 36734         (WebCore::RenderThemeMac::button):
       
 36735         (WebCore::RenderThemeMac::popupButton):
       
 36736         (WebCore::RenderThemeMac::search):
       
 36737         (WebCore::RenderThemeMac::sliderThumbHorizontal):
       
 36738         (WebCore::RenderThemeMac::sliderThumbVertical):
       
 36739 
       
 36740 2007-05-05  Rob Buis  <buis@kde.org>
       
 36741 
       
 36742         Reviewed by Oliver.
       
 36743 
       
 36744         http://bugs.webkit.org/show_bug.cgi?id=13592
       
 36745         parseMappedAttribute inconsistency
       
 36746 
       
 36747         Do not use local vars in parseMappedAttribute for attr name and value.
       
 36748 
       
 36749         * ksvg2/svg/SVGAnimateMotionElement.cpp:
       
 36750         (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
       
 36751         * ksvg2/svg/SVGAnimateTransformElement.cpp:
       
 36752         (WebCore::SVGAnimateTransformElement::parseMappedAttribute):
       
 36753         * ksvg2/svg/SVGAnimationElement.cpp:
       
 36754         (WebCore::SVGAnimationElement::parseMappedAttribute):
       
 36755         * ksvg2/svg/SVGCircleElement.cpp:
       
 36756         (WebCore::SVGCircleElement::parseMappedAttribute):
       
 36757         * ksvg2/svg/SVGClipPathElement.cpp:
       
 36758         (WebCore::SVGClipPathElement::parseMappedAttribute):
       
 36759         * ksvg2/svg/SVGCursorElement.cpp:
       
 36760         (WebCore::SVGCursorElement::parseMappedAttribute):
       
 36761         * ksvg2/svg/SVGEllipseElement.cpp:
       
 36762         (WebCore::SVGEllipseElement::parseMappedAttribute):
       
 36763         * ksvg2/svg/SVGExternalResourcesRequired.cpp:
       
 36764         (WebCore::SVGExternalResourcesRequired::parseMappedAttribute):
       
 36765         * ksvg2/svg/SVGGradientElement.cpp:
       
 36766         (WebCore::SVGGradientElement::parseMappedAttribute):
       
 36767         * ksvg2/svg/SVGImageElement.cpp:
       
 36768         (WebCore::SVGImageElement::parseMappedAttribute):
       
 36769         * ksvg2/svg/SVGLineElement.cpp:
       
 36770         (WebCore::SVGLineElement::parseMappedAttribute):
       
 36771         * ksvg2/svg/SVGLinearGradientElement.cpp:
       
 36772         (WebCore::SVGLinearGradientElement::parseMappedAttribute):
       
 36773         * ksvg2/svg/SVGMarkerElement.cpp:
       
 36774         (WebCore::SVGMarkerElement::parseMappedAttribute):
       
 36775         * ksvg2/svg/SVGMaskElement.cpp:
       
 36776         (WebCore::SVGMaskElement::parseMappedAttribute):
       
 36777         * ksvg2/svg/SVGPathElement.cpp:
       
 36778         (WebCore::SVGPathElement::parseMappedAttribute):
       
 36779         * ksvg2/svg/SVGPatternElement.cpp:
       
 36780         (WebCore::SVGPatternElement::parseMappedAttribute):
       
 36781         * ksvg2/svg/SVGRadialGradientElement.cpp:
       
 36782         (WebCore::SVGRadialGradientElement::parseMappedAttribute):
       
 36783         * ksvg2/svg/SVGRectElement.cpp:
       
 36784         (WebCore::SVGRectElement::parseMappedAttribute):
       
 36785         * ksvg2/svg/SVGSVGElement.cpp:
       
 36786         (WebCore::SVGSVGElement::parseMappedAttribute):
       
 36787         * ksvg2/svg/SVGScriptElement.cpp:
       
 36788         (WebCore::SVGScriptElement::parseMappedAttribute):
       
 36789         * ksvg2/svg/SVGStopElement.cpp:
       
 36790         (WebCore::SVGStopElement::parseMappedAttribute):
       
 36791         * ksvg2/svg/SVGTests.cpp:
       
 36792         (WebCore::SVGTests::parseMappedAttribute):
       
 36793         * ksvg2/svg/SVGTextContentElement.cpp:
       
 36794         (WebCore::SVGTextContentElement::parseMappedAttribute):
       
 36795         * ksvg2/svg/SVGTextPositioningElement.cpp:
       
 36796         (WebCore::SVGTextPositioningElement::parseMappedAttribute):
       
 36797         * ksvg2/svg/SVGUseElement.cpp:
       
 36798         (WebCore::SVGUseElement::parseMappedAttribute):
       
 36799         * ksvg2/svg/SVGViewElement.cpp:
       
 36800         (WebCore::SVGViewElement::parseMappedAttribute):
       
 36801         * ksvg2/svg/SVGZoomAndPan.cpp:
       
 36802         (WebCore::SVGZoomAndPan::parseMappedAttribute):
       
 36803 
       
 36804 2007-05-05  Oliver Hunt  <oliver@apple.com>
       
 36805 
       
 36806         Reviewed by Hyatt.
       
 36807 
       
 36808         Initialise default fill with Color::black rather than parsing
       
 36809         the string "black"
       
 36810 
       
 36811         * ksvg2/svg/SVGPaint.cpp:
       
 36812         (WebCore::SVGPaint::defaultFill):
       
 36813 
       
 36814 2007-05-04  Steve Falkenburg  <sfalken@apple.com>
       
 36815 
       
 36816         Reviewed by Oliver.
       
 36817 
       
 36818         Use TextBreakIterator for sentence breaking instead of TextBoundaries.
       
 36819 
       
 36820         * WebCore.xcodeproj/project.pbxproj: Added TextBreakIeratorInternalICUMac.mm
       
 36821         * editing/visible_units.cpp:
       
 36822         (WebCore::startSentenceBoundary): Call TextBreakIterator instead of TextBoundaries.
       
 36823         (WebCore::endSentenceBoundary): Call TextBreakIterator instead of TextBoundaries.
       
 36824         (WebCore::previousSentencePositionBoundary): Call TextBreakIterator instead of TextBoundaries.
       
 36825         (WebCore::nextSentencePositionBoundary): Call TextBreakIterator instead of TextBoundaries.
       
 36826         * platform/TextBoundaries.h: Removed findSentenceBoundary, findNextSentenceFromIndex.
       
 36827         * platform/TextBreakIterator.h: Added sentenceBreakIterator.
       
 36828         * platform/TextBreakIteratorICU.cpp:
       
 36829         (WebCore::setUpIterator): Add locale parameter (needed to maintain functionality that TextBoundaries code had).
       
 36830         (WebCore::characterBreakIterator): Pass en_us for locale (same as old code).
       
 36831         (WebCore::wordBreakIterator): Pass en_us for locale (same as old code).
       
 36832         (WebCore::lineBreakIterator): Pass en_us for locale (same as old code).
       
 36833         (WebCore::sentenceBreakIterator): Added.
       
 36834         * platform/TextBreakIteratorInternalICU.h: Added.
       
 36835         * platform/gdk/TemporaryLinkStubs.cpp: Removed findNextSentenceFromIndex, findSentenceBoundary.
       
 36836         (WebCore::currentTextBreakLocaleID): Added stub.
       
 36837         * platform/mac/TextBoundaries.mm: Removed currentTextBreakLocaleID, findSentenceBoundary, findNextSentenceFromIndex.
       
 36838         * platform/mac/TextBreakIteratorInternalICUMac.mm: Added.
       
 36839         (WebCore::currentTextBreakLocaleID): Moved from TextBoundaries.mm
       
 36840         * platform/qt/TextBoundaries.cpp: Removed findNextSentenceFromIndex, findSentenceBoundary.
       
 36841 
       
 36842 2007-05-04  Adele Peterson  <adele@apple.com>
       
 36843 
       
 36844         Reviewed by Hyatt.
       
 36845 
       
 36846         Fix for <rdar://problem/5116871> REGRESSION: Can't select options in widget's listbox
       
 36847 
       
 36848         Don't use user-select to determine whether or not options can be selected in listboxes.
       
 36849         This will match Firefox behavior for -moz-user-select.
       
 36850 
       
 36851         * html/HTMLSelectElement.cpp:
       
 36852         (WebCore::HTMLSelectElement::canSelectAll):
       
 36853         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
       
 36854 
       
 36855 2007-05-04  Geoffrey Garen  <ggaren@apple.com>
       
 36856 
       
 36857         Reviewed by Tim Hatcher.
       
 36858 
       
 36859         First step in fixing <rdar://problem/5055182> The back cache has no global cap
       
 36860 
       
 36861         Stop giving SnapBack infinite cache-ability. Instead, make SnapBack rely
       
 36862         on the underlying back cache.
       
 36863 
       
 36864         * WebCore.exp:
       
 36865         * history/HistoryItem.cpp:
       
 36866         (WebCore::HistoryItem::HistoryItem):
       
 36867         * history/HistoryItem.h:
       
 36868         * loader/FrameLoader.cpp:
       
 36869         (WebCore::FrameLoader::purgePageCache):
       
 36870 
       
 36871 2007-05-04  Geoffrey Garen  <ggaren@apple.com>
       
 36872 
       
 36873         Reviewed by Brady Eidson.
       
 36874         
       
 36875         Removed export of clearPageCache(), since it was unused externally. I plan
       
 36876         to remove its use from WebCore eventually, too.
       
 36877 
       
 36878         Removed usesPageCache(), since it was unused and it duplicated pageCacheSize().
       
 36879 
       
 36880         * WebCore.exp:
       
 36881         * history/BackForwardList.cpp:
       
 36882         * history/BackForwardList.h: Moved statics to the top of the class definition.
       
 36883         * loader/FrameLoader.cpp:
       
 36884         (WebCore::FrameLoader::canCachePage):
       
 36885 
       
 36886 2007-05-04  Anders Carlsson  <andersca@apple.com>
       
 36887 
       
 36888         Reviewed by Antti.
       
 36889 
       
 36890         <rdar://problem/5179977> Use the correct URLs when dispatching delegate methods for data loads.
       
 36891 
       
 36892         Restore behavior to matching release WebKit by adding a response URL to SubstituteData. If a nil base URL is
       
 36893         passed, set the _request_ URL to "about:blank", but the response URL to a generated "applewebdata" URL.
       
 36894 
       
 36895         * loader/FrameLoader.cpp:
       
 36896         (WebCore::FrameLoader::commitProvisionalLoad):
       
 36897         First, check for the SubstituteData's response URL.
       
 36898 
       
 36899         (WebCore::FrameLoader::continueAfterNavigationPolicy):
       
 36900         No need to special case applewebdata URLs here, they're only used in the response.
       
 36901 
       
 36902         * loader/MainResourceLoader.cpp:
       
 36903         (WebCore::MainResourceLoader::handleDataLoadNow):
       
 36904         If the substitute data has a response URL, use it.
       
 36905 
       
 36906         (WebCore::MainResourceLoader::loadNow):
       
 36907         Only load "about:blank" as an empty document if there's no substitute data.
       
 36908 
       
 36909         * loader/SubstituteData.h:
       
 36910         (WebCore::SubstituteData::SubstituteData):
       
 36911         (WebCore::SubstituteData::responseURL):
       
 36912         Add responseURL member to SubstituteData.
       
 36913 
       
 36914 2007-05-03  Steve Falkenburg  <sfalken@apple.com>
       
 36915 
       
 36916         Reviewed by Oliver.
       
 36917 
       
 36918         Add missing user description parameter to spelling-related editor client method.
       
 36919 
       
 36920         * bridge/EditorClient.h:
       
 36921         * platform/gdk/EditorClientGdk.cpp:
       
 36922         (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString):
       
 36923         * platform/gdk/EditorClientGdk.h:
       
 36924         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 36925         (WebCore::SVGEmptyEditorClient::updateSpellingUIWithGrammarString):
       
 36926 
       
 36927 2007-05-03  Brady Eidson  <beidson@apple.com>
       
 36928 
       
 36929         Reviewed by Oliver
       
 36930 
       
 36931         Resolve an outstanding FIXME in Loader::numRequests()
       
 36932 
       
 36933         Before, numRequests() would iterate through the list of requests pending load and the list of currently
       
 36934         loading requests and tally up a count matching the current DocLoader.
       
 36935 
       
 36936         I noticed while studying and cleaning up the loader code that numRequests() is potentially very hot!
       
 36937         Indeed load a complex site with many resources and multiple frames, and this method gets called very often,
       
 36938         tallying up this number every time.
       
 36939 
       
 36940         The FIXME was to keep a collection of Requests mapped to each DocLoader.  In reality, since this map would
       
 36941         simply be used for retrieving a count, that was overkill.  Keeping a request count in the DocLoader itself
       
 36942         along with maintaining that count in Loader as requests come and go is a much better way to do this.
       
 36943 
       
 36944         * loader/DocLoader.cpp:
       
 36945         (WebCore::DocLoader::DocLoader):
       
 36946         (WebCore::DocLoader::incrementRequestCount):
       
 36947         (WebCore::DocLoader::decrementRequestCount):
       
 36948         (WebCore::DocLoader::requestCount): Emulate the defunct Loader::numRequests()
       
 36949         * loader/DocLoader.h:
       
 36950 
       
 36951         * loader/FrameLoader.cpp:
       
 36952         (WebCore::numRequests): Call DocLoader::requestCount() directly
       
 36953         (WebCore::FrameLoader::checkCompleted): Use numRequests()
       
 36954 
       
 36955         * loader/loader.cpp:
       
 36956         (WebCore::Loader::load): Increment the DocLoader's request count
       
 36957         (WebCore::Loader::servePendingRequests): If the SubresourceLoader failed to create, decrement the count
       
 36958         (WebCore::Loader::didFinishLoading): If the Request is not Multipart, decrement the count
       
 36959         (WebCore::Loader::didFail): If the Request is not Multipart, decrement the count
       
 36960         (WebCore::Loader::didReceiveResponse): If the Request becomes Multipart, decrement the count
       
 36961         (WebCore::Loader::cancelRequests): Decrement the count for the pending requests being tossed, and ASSERT the
       
 36962           count is zero after all requests have been cancelled
       
 36963         * loader/loader.h:
       
 36964 
       
 36965 2007-05-03  Geoffrey Garen  <ggaren@apple.com>
       
 36966 
       
 36967         Reviewed by Brady Eidson.
       
 36968         
       
 36969         Some cleanup in preparation for fixing <rdar://problem/5055182> The 
       
 36970         back/forward cache has no global cap
       
 36971 
       
 36972         * loader/FrameLoader.cpp:
       
 36973         (WebCore::FrameLoader::provisionalLoadStarted): Moved "Can I cache this
       
 36974         page?" logic to canCachePage(). Moved "I am caching this page" logic to
       
 36975         cachePageToHistoryItem().
       
 36976         (WebCore::FrameLoader::canCachePage): Moved above logic here.
       
 36977         (WebCore::FrameLoader::cachePageToHistoryItem): Removed bogus NULL check
       
 36978         and failure return value. Moved above logic here. Don't call setCachedPage()
       
 36979         until the CachedPage is fully constructed.
       
 36980         (WebCore::FrameLoader::purgePageCache): Removed comment that duplicated
       
 36981         the function name.
       
 36982         * loader/FrameLoader.h:
       
 36983 
       
 36984 2007-05-03  Justin Garcia  <justin.garcia@apple.com>
       
 36985 
       
 36986         Reviewed by harrison.
       
 36987 
       
 36988         <rdar://problem/5120281> CrashTracer: [USER] 1 crash in Mail at WebCore::CSSComputedStyleDeclaration::copyInheritableProperties() const
       
 36989 
       
 36990         Problem is that checkAncestor and lastClosed can be nil when createMarkup is called unrendered nodes, and that was not checked for.
       
 36991         
       
 36992         * editing/markup.cpp:
       
 36993         (WebCore::createMarkup):
       
 36994         Nil-check checkAncestor and lastClosed.
       
 36995 
       
 36996 2007-05-03  Timothy Hatcher  <timothy@apple.com>
       
 36997 
       
 36998         Reviewed by Kevin.
       
 36999 
       
 37000         <rdar://problem/5016318> Contextual menu item for opening links is missing in compose windows but present in viewer
       
 37001 
       
 37002         Add the Open Link, Open Link in New Window, Download Linked File and Copy Link menu
       
 37003         items to the content editable context menu.
       
 37004 
       
 37005         * platform/ContextMenu.cpp:
       
 37006         (WebCore::ContextMenu::populate):
       
 37007 
       
 37008 2007-05-03  Holger Freyther <freyther@kde.org>
       
 37009 
       
 37010         Reviewed by Zack, landed by Simon.
       
 37011         This is bugzilla bug 13499.
       
 37012 
       
 37013         * WebCore.pro: Place the Qt port into the qt-port scope, add the Gdk port
       
 37014 
       
 37015 2007-05-03  Adele Peterson  <adele@apple.com>
       
 37016 
       
 37017         Use BUILDING_ON_TIGER.
       
 37018 
       
 37019         * page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry):
       
 37020 
       
 37021 2007-05-03  Brady Eidson  <beidson@apple.com>
       
 37022 
       
 37023         Reviewed by Darin
       
 37024 
       
 37025         Some more minor cleanup that resolves a FIXME and ditches another pointless method
       
 37026 
       
 37027         No change in functionality == no layout test
       
 37028 
       
 37029         * loader/FrameLoader.cpp:
       
 37030         (WebCore::FrameLoader::commitProvisionalLoad):  Updated a comment
       
 37031         (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Folded startLoading() into this method
       
 37032         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): continueAfterWillSubmitForm becomes continueLoadAfterWillSubmitForm
       
 37033         * loader/FrameLoader.h: Removed startLoading()
       
 37034 
       
 37035 2007-05-03  Adele Peterson  <adele@apple.com>
       
 37036 
       
 37037         Reviewed by Tim Hatcher.
       
 37038 
       
 37039         Fix for <rdar://problem/4727607> REGRESSION: KeyScript is deprecated, need a new solution for forcing Roman input for password fields on Leopard
       
 37040 
       
 37041         * page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry):
       
 37042         Use TSMSetDocumentProperty and TSMRemoveDocumentProperty on Leopard disable and enable non-ascii input sources.
       
 37043 
       
 37044 2007-05-03  Brady Eidson  <beidson@apple.com>
       
 37045 
       
 37046         Reviewed by Anders
       
 37047 
       
 37048         commitProvisionalLoad() was the name of two methods.
       
 37049         One of them was private and only called from one other private place.
       
 37050         This was driving me crazy.  I had to change that.
       
 37051 
       
 37052         No change in functionality == no layout test
       
 37053 
       
 37054         * loader/FrameLoader.cpp:
       
 37055         (WebCore::FrameLoader::transitionToCommitted): roll commitProvisionalLoad() into this method
       
 37056         * loader/FrameLoader.h: Removed commitProvisionalLoad()
       
 37057 
       
 37058 2007-05-03  Darin Adler  <darin@apple.com>
       
 37059 
       
 37060         Reviewed by Anders.
       
 37061 
       
 37062         - make ICU initialization lazy to speed up application start-up time
       
 37063           (when it includes an initial webpage load)
       
 37064 
       
 37065         * platform/TextCodecICU.h: Replaced registerEncodingNames and
       
 37066         registerCodecs with registerBaseEncodingNames, registerBaseCodecs,
       
 37067         registerExtendedEncodingNames, and registerExtendedCodecs.
       
 37068         * platform/TextCodecICU.cpp:
       
 37069         (WebCore::newTextCodecICU): Moved up to the top of the file.
       
 37070         (WebCore::TextCodecICU::registerBaseEncodingNames): Added. Registers
       
 37071         just UTF-8.
       
 37072         (WebCore::TextCodecICU::registerBaseCodecs): Ditto.
       
 37073         (WebCore::TextCodecICU::registerExtendedEncodingNames): Renamed.
       
 37074         (WebCore::TextCodecICU::registerExtendedCodecs): Ditto.
       
 37075         (WebCore::TextCodecICU::createICUConverter): Compare with the name
       
 37076         "GBK" in a way that does not require extending the maps.
       
 37077 
       
 37078         * platform/TextEncoding.cpp:
       
 37079         (WebCore::TextEncoding::usesVisualOrdering): Added code so this will
       
 37080         just return false if we haven't used any extended encoding names yet.
       
 37081         The result will be correct, and we won't ask for an encoding name that
       
 37082         will require registering the extended encoding names.
       
 37083         (WebCore::TextEncoding::isJapanese): Ditto.
       
 37084         (WebCore::TextEncoding::backslashAsCurrencySymbol): Ditto, but return
       
 37085         a backslash instead of false.
       
 37086 
       
 37087         * platform/TextEncodingRegistry.h: Added a new function named
       
 37088          noExtendedTextEncodingNameUsed.
       
 37089         * platform/TextEncodingRegistry.cpp:
       
 37090         (WebCore::buildBaseTextCodecMaps): Added. Registers the base encodings,
       
 37091         including Latin-1 because it's the default, and the UTF encodings.
       
 37092         (WebCore::extendTextCodecMaps): Added. Registers all the other encodings.
       
 37093         (WebCore::newTextCodec): Removed the all to buildTextCodecMap because
       
 37094         we always build the map when making the canonical encoding name.
       
 37095         (WebCore::atomicCanonicalTextEncodingName): Changed code to build only
       
 37096         the base maps at first, then extend the maps the first time we run into
       
 37097         a name we don't know.
       
 37098         (WebCore::noExtendedTextEncodingNameUsed): Added.
       
 37099 
       
 37100 2007-05-03  Mark Rowe  <mrowe@apple.com>
       
 37101 
       
 37102         Qt build fix.  In r21185 the Qt version of WebCore::scaleDragImage was
       
 37103         updated to have the incorrect signature.
       
 37104 
       
 37105         * platform/qt/DragImageQt.cpp:
       
 37106         (WebCore::scaleDragImage):
       
 37107 
       
 37108 2007-05-02  Beth Dakin  <bdakin@apple.com>
       
 37109 
       
 37110         * dom/Node.h: Just fixing a variable name because it's driving me 
       
 37111         mad.
       
 37112 
       
 37113 2007-05-02  Beth Dakin  <bdakin@apple.com>
       
 37114 
       
 37115         Reviewed by Hyatt.
       
 37116 
       
 37117         Fix for <rdar://problem/4513966> Never-ending identical repaint @ 
       
 37118         orbitz.com (Safari eating 85% CPU)
       
 37119 
       
 37120         We need to be a little bit more savvy about when we do a FULL style 
       
 37121         recalc since it can be unnecessary and expensive.
       
 37122 
       
 37123         * css/CSSMutableStyleDeclaration.cpp:
       
 37124         (WebCore::CSSMutableStyleDeclaration::setChanged): Now takes a 
       
 37125         StyleChangeType as a parameter.
       
 37126         (WebCore::CSSMutableStyleDeclaration::setProperty): Send 
       
 37127         InlineStyleChange as the paramter. This is the optimization!
       
 37128         * css/CSSMutableStyleDeclaration.h: setChanged takes a 
       
 37129         StyleChangeType as a parameter.
       
 37130         * dom/Document.cpp: setChanged now takes a StyleChangeType instead 
       
 37131         of a bool.
       
 37132         (WebCore::Document::recalcStyle): Same.
       
 37133         * dom/Element.cpp: 
       
 37134         (WebCore::Element::recalcStyle): This is the fix!! Only set change 
       
 37135         to Force is we use descendant rules AND it's a FullStyleChange.
       
 37136         * dom/Node.cpp: m_hasStyle was an unused bit on Node, so this patch 
       
 37137         gets rid of it and uses that extra bit for m_changed to be a 
       
 37138         StyleChangeType instead of a bool.
       
 37139         (WebCore::Node::Node):
       
 37140         (WebCore::Node::setChanged):
       
 37141         (WebCore::Node::dump):
       
 37142         * dom/Node.h: Same.
       
 37143         (WebCore::): Define the StyleChangeType enum.
       
 37144         (WebCore::Node::hasClass):
       
 37145         (WebCore::Node::changed):
       
 37146         (WebCore::Node::styleChangeType):
       
 37147         (WebCore::Node::setHasClass):
       
 37148         * dom/StyledElement.cpp:
       
 37149         (WebCore::StyledElement::parseMappedAttribute): Don't bother 
       
 37150         calling setHasStyle() since m_hasStyle is gone now. It was never 
       
 37151         used, and this was the only place it was set.
       
 37152         * dom/Text.cpp:
       
 37153         (WebCore::Text::recalcStyle): setChanged now takes a 
       
 37154         StyleChangeType instead of a bool.
       
 37155         * html/HTMLFrameSetElement.cpp:
       
 37156         (WebCore::HTMLFrameSetElement::recalcStyle): Same.
       
 37157         * html/HTMLSelectElement.cpp:
       
 37158         (WebCore::HTMLSelectElement::restoreState): Same.
       
 37159         (WebCore::HTMLSelectElement::reset): Same.
       
 37160         * html/HTMLTextAreaElement.cpp:
       
 37161         (WebCore::HTMLTextAreaElement::setValue): Same.
       
 37162         * ksvg2/misc/SVGTimer.cpp:
       
 37163         (WebCore::SVGTimer::applyAnimations): Same.
       
 37164         * ksvg2/svg/SVGUseElement.cpp:
       
 37165         (WebCore::SVGUseElement::recalcStyle): Same.
       
 37166         * platform/graphics/svg/SVGResource.cpp:
       
 37167         (WebCore::SVGResource::repaintClients): Same.
       
 37168 
       
 37169 2007-05-02  David Harrison  <harrison@apple.com>
       
 37170 
       
 37171         Reviewed by Antti.
       
 37172 
       
 37173         <rdar://problem/4859132> Grammar must always be checked in entire-sentence chunks, and shouldn't show markers for current sentence
       
 37174 
       
 37175         Restore the remainder of the original fix now that blocking bug rdar://5174862 is addressed.
       
 37176 
       
 37177         John made the original patch on 2007-04-10, but this fell prey to rdar://5157329.
       
 37178         Justin backed out the whole patch on 2007-04-30 to avoid the crash.
       
 37179         Justin then restored most of the original patch, but used word granularity instead, to keep the build working.
       
 37180         I just addressed the root cause of rdar://5157329 in rdar://5174862.
       
 37181         This patch switches the temp uses of word granularity back to sentence granularity.
       
 37182         
       
 37183         * editing/mac/EditorMac.mm:
       
 37184         (WebCore::Editor::markMisspellingsAfterTypingToPosition):
       
 37185         * page/Frame.cpp:
       
 37186         (WebCore::Frame::respondToChangedSelection):
       
 37187 
       
 37188 2007-05-02  David Harrison  <harrison@apple.com>
       
 37189 
       
 37190         Reviewed by Antti.
       
 37191 
       
 37192         <rdar://problem/5174862> Crash resulting from DeprecatedString::insert()
       
 37193         
       
 37194         Test added: editing/selection/move-by-sentence-001.html
       
 37195 
       
 37196         * editing/visible_units.cpp:
       
 37197         (WebCore::previousBoundary):
       
 37198         (WebCore::nextBoundary):
       
 37199         Use a UChar Vector instead of DeprecatedString.
       
 37200         Avoid creating an extra string for secure bullet replacement unless it is actually needed.
       
 37201         
       
 37202         * platform/DeprecatedString.cpp:
       
 37203         (WebCore::DeprecatedString::insert):
       
 37204         Call forceUnicode() before setLength(), so that only the unicode buffer is resized.
       
 37205 
       
 37206        (WebCore::DeprecatedString::setLength):
       
 37207         Adjust the unicode buffer even if the ascii buffer is valid.
       
 37208         
       
 37209 2007-05-02  Mitz Pettel  <mitz@webkit.org>
       
 37210 
       
 37211         Reviewed by Brady.
       
 37212 
       
 37213         - http://bugs.webkit.org/show_bug.cgi?id=13564
       
 37214           Remove friend class FrameLoader from Frame
       
 37215 
       
 37216         No test added since there is no change in functionality.
       
 37217 
       
 37218         * loader/FrameLoader.cpp:
       
 37219         (WebCore::FrameLoader::didOpenURL):
       
 37220         (WebCore::FrameLoader::begin):
       
 37221         (WebCore::FrameLoader::open):
       
 37222         * loader/FrameLoader.h: Made clear() private.
       
 37223         * page/Frame.cpp:
       
 37224         (WebCore::Frame::setDocument): Changed the argument into a PassRefPtr.
       
 37225         * page/Frame.h:
       
 37226         * xml/XSLTProcessor.cpp:
       
 37227         (WebCore::XSLTProcessor::createDocumentFromSource):
       
 37228 
       
 37229 2007-05-02  Mitz Pettel  <mitz@webkit.org>
       
 37230 
       
 37231         Reviewed by Dave Hyatt.
       
 37232 
       
 37233         - fix http://bugs.webkit.org/show_bug.cgi?id=9276
       
 37234           Quirksmode: Image swap resize bug
       
 37235 
       
 37236         Test: fast/replaced/image-resize-width.html
       
 37237 
       
 37238         * rendering/RenderImage.cpp:
       
 37239         (WebCore::RenderImage::imageChanged): Moved the call to dirtyPrefWidths()
       
 37240         before the call to calcWidth().
       
 37241 
       
 37242 2007-05-02  David Hyatt  <hyatt@apple.com>
       
 37243 
       
 37244         Fix for bug 13566, broken Dashboard widgets.  setPrefWidthsDirty did
       
 37245         the wrong thing for text children of a positioned element.
       
 37246 
       
 37247         Reviewed by mitz
       
 37248 
       
 37249         fast/block/positioning/pref-width-change.html
       
 37250 
       
 37251         * rendering/RenderObject.cpp:
       
 37252         (WebCore::RenderObject::setPrefWidthsDirty):
       
 37253 
       
 37254 2007-05-01  Darin Adler  <darin@apple.com>
       
 37255 
       
 37256         * rendering/RenderReplaced.cpp: Fix typo in a comment.
       
 37257 
       
 37258 2007-05-01  David Hyatt  <hyatt@apple.com>
       
 37259 
       
 37260         Fix for 13558, crash when using absolutely positioned generated content
       
 37261         inside an inline.
       
 37262 
       
 37263         Reviewed by darin
       
 37264 
       
 37265         fast/css-generated-content/absolute-position-inside-inline.html
       
 37266 
       
 37267         * rendering/RenderContainer.cpp:
       
 37268         (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
       
 37269 
       
 37270 2007-05-01  Justin Garcia  <justin.garcia@apple.com>
       
 37271 
       
 37272         Reviewed by darin
       
 37273 
       
 37274         <rdar://problem/5002441> 
       
 37275         Pressing space key does nothing above quoted content or a signature
       
 37276         
       
 37277         Inserting a space under these circumstances inserts a single 
       
 37278         text node containing a regular space and then does a layout. 
       
 37279         That space isn't rendered (which is correct).  Whitespace 
       
 37280         rebalancing is supposed to correct it but failed.  It replaces 
       
 37281         the space with a non-breaking space, but that change doesn't 
       
 37282         dirty line boxes (9441) and so the space isn't rendered.
       
 37283         
       
 37284         This workaround turns all incoming spaces into non-breaking 
       
 37285         spaces before they're inserted (they're rebalanced after 
       
 37286         insertion and turned back into regular spaces if possible).
       
 37287 
       
 37288         * editing/InsertTextCommand.cpp:
       
 37289         (WebCore::InsertTextCommand::prepareForTextInsertion): Removed
       
 37290         an old irrelevant FIXME.
       
 37291         (WebCore::InsertTextCommand::input): Turn incoming spaces into
       
 37292         non breaking spaces before inserting them.
       
 37293         
       
 37294 2007-05-01  Darin Adler  <darin@apple.com>
       
 37295 
       
 37296         Reviewed by Hyatt.
       
 37297 
       
 37298         - fix http://bugs.webkit.org/show_bug.cgi?id=13559
       
 37299           REGRESSION: Canvas aspect ratio is incorrect
       
 37300 
       
 37301         - remove intrinsicWidth/Height functions from RenderObject
       
 37302 
       
 37303         Test: fast/canvas/canvas-size-change-after-layout.html
       
 37304 
       
 37305         * html/HTMLCanvasElement.cpp:
       
 37306         (WebCore::HTMLCanvasElement::createRenderer): Removed code to set
       
 37307         the intrinsic size, because the renderer now takes care of this
       
 37308         in its constructor.
       
 37309         (WebCore::HTMLCanvasElement::reset): Instead of calling the
       
 37310         setIntrinsicWidth/Height functions, call canvasSizeChanged, which
       
 37311         takes care of layout, but only if the size actually changed. Also
       
 37312         call repaint if the contents of the canvas changed.
       
 37313 
       
 37314         * rendering/RenderApplet.h:
       
 37315         * rendering/RenderApplet.cpp: (WebCore::RenderApplet::intrinsicSize):
       
 37316         Override the new intrinsicSize function. This override still doesn't
       
 37317         make sense, so left a FIXME in here.
       
 37318 
       
 37319         * rendering/RenderBox.h: Added an intrinsicSize function here to replace
       
 37320         the intrinsicWidth/Height functions removed from RenderObject.
       
 37321         * rendering/RenderBox.cpp:
       
 37322         (WebCore::RenderBox::calcReplacedWidthUsing): Use intrinsicSize instead
       
 37323         of intrinsicWidth.
       
 37324         (WebCore::RenderBox::calcReplacedHeightUsing): Ditto, but for height.
       
 37325 
       
 37326         * rendering/RenderHTMLCanvas.h: Changed the constructor parameter to be
       
 37327         an HTMLCanvasElement* instead of Node*. Also added a canvasSizeChanged
       
 37328         function.
       
 37329         * rendering/RenderHTMLCanvas.cpp:
       
 37330         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas): Pass an initial intrinsic
       
 37331         size based on the current size of the canvas element. This is now the
       
 37332         responsibility of the renderer and the DOM element calls the canvasSizeChanged
       
 37333         function when the size changes.
       
 37334         (WebCore::RenderHTMLCanvas::paint): Removed checks of the type of the element,
       
 37335         and used the node() function because we don't have to worry about the anonymous
       
 37336         case in this class.
       
 37337         (WebCore::RenderHTMLCanvas::canvasSizeChanged): Added. Changes the size and
       
 37338         then calls setNeedsLayout and setPrefWidthsDirty as needed. I based the logic
       
 37339         here on careful reading of RenderImage::imageChanged.
       
 37340 
       
 37341         * rendering/RenderImage.cpp:
       
 37342         (WebCore::RenderImage::RenderImage): Pass a default intrinsic size of 0,0
       
 37343         instead of calling setIntrinsicWidth/Height.
       
 37344         (WebCore::RenderImage::setImageSizeForAltText): Call the new intrinsic size
       
 37345         functions instead of the width/height ones. Simplifies the logic since we
       
 37346         handle both dimensions at once.
       
 37347         (WebCore::RenderImage::imageChanged): Ditto.
       
 37348         (WebCore::RenderImage::layout): Ditto.
       
 37349         (WebCore::RenderImage::calcAspectRatioWidth): Ditto.
       
 37350         (WebCore::RenderImage::calcAspectRatioHeight): Ditto.
       
 37351 
       
 37352         * rendering/RenderObject.h: Removed intrinsicWidth/Height virtual functions.
       
 37353 
       
 37354         * rendering/RenderReplaced.h: Replaced intrinsicWidth, intrinsicHeight,
       
 37355         setIntrinsicWidth, setIntrinsicHeight, m_intrinsicWidth, and m_intrinsicHeight
       
 37356         with intrinsicSize, setIntrinsicSize, and m_intrinsicSize.
       
 37357         * rendering/RenderReplaced.cpp:
       
 37358         (WebCore::RenderReplaced::RenderReplaced): Added a second contructor that takes
       
 37359         an intrinsic size parameter. Also updated constructor since the intrinsic size
       
 37360         is now an IntSize instead of two integers.
       
 37361         (WebCore::RenderReplaced::intrinsicSize): Added. No point in making this inline
       
 37362         because it's a virtual function.
       
 37363         (WebCore::RenderReplaced::setIntrinsicSize): Added. Didn't make this inline,
       
 37364         partly because in the future we might want this to be more than just a simple
       
 37365         setter function, factoring in common code used in both RenderImage and
       
 37366         RenderHTMLCanvas.
       
 37367 
       
 37368         * rendering/RenderWidget.h: Removed a stray using declaration that wasn't needed.
       
 37369 
       
 37370 2007-05-01  David Hyatt  <hyatt@apple.com>
       
 37371 
       
 37372         Fix for hang when incorrectly trying to add before/after content to
       
 37373         a <select>.  Disallow generated content in all selects and also turn it
       
 37374         off for <input> buttons.
       
 37375 
       
 37376         Reviewed by aroben
       
 37377 
       
 37378         * rendering/RenderBlock.cpp:
       
 37379         (WebCore::RenderBlock::setStyle):
       
 37380         * rendering/RenderButton.cpp:
       
 37381         (WebCore::RenderButton::canHaveChildren):
       
 37382         * rendering/RenderButton.h:
       
 37383 
       
 37384 2007-05-01  Darin Adler  <darin@apple.com>
       
 37385 
       
 37386         Reviewed by Hyatt.
       
 37387 
       
 37388         - removed the m_implicit bit from Node, freeing up a bit
       
 37389 
       
 37390         - fixed <rdar://problem/5172607> XML parser is creating implicit tbody elements
       
 37391         - fixed <rdar://problem/5172596> HTML-parser-created tbody elements are being
       
 37392           ignored when processing CSS child rules
       
 37393 
       
 37394         Test: fast/css/child-selector-implicit-tbody.html
       
 37395 
       
 37396         * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkSelector):
       
 37397         Removed code that used to look at implicitNode(), which no longer exists.
       
 37398 
       
 37399         * css/html4.css: Added a style rule to handle cases where we have a tr
       
 37400         inside a table with no intervening table section.
       
 37401 
       
 37402         * dom/Node.h: Removed the bit.
       
 37403         * dom/Node.cpp:
       
 37404         (WebCore::Node::Node): Don't initialize the bit.
       
 37405         (WebCore::Node::dump): Don't dump the bit.
       
 37406 
       
 37407         * dom/XMLTokenizer.cpp:
       
 37408         (WebCore::XMLTokenizer::startElementNs): Remove the code that made a
       
 37409         table body element. This is handled in the render tree, the DOM tree
       
 37410         should not be mangled.
       
 37411         (WebCore::XMLTokenizer::endElementNs): Removed code that used to look at
       
 37412         implicitNode(), which no longer exists.
       
 37413 
       
 37414         * html/HTMLElementFactory.cpp: (WebCore::tableSectionConstructor):
       
 37415         Removed boolean parameter that was passed to the HTMLTableSectionElement
       
 37416         constructor.
       
 37417         * html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Ditto.
       
 37418         * html/HTMLTableElement.cpp:
       
 37419         (WebCore::HTMLTableElement::createTHead): Ditto.
       
 37420         (WebCore::HTMLTableElement::createTFoot): Ditto.
       
 37421         (WebCore::HTMLTableElement::insertRow): Changed to return a PassRefPtr,
       
 37422         because it's possible the row could be removed from the table by JavaScript
       
 37423         code responding to DOM mutation events before the function returns. Just
       
 37424         something I noticed by code inspection.
       
 37425 
       
 37426         * html/HTMLTableSectionElement.cpp:
       
 37427         (WebCore::HTMLTableSectionElement::HTMLTableSectionElement): Removed
       
 37428         boolean "implicit" parameter to the constructor.
       
 37429         (WebCore::HTMLTableSectionElement::insertRow): Changed to return a
       
 37430         PassRefPtr for the same reason cited above.
       
 37431 
       
 37432         * html/HTMLTableElement.h: Changed the return value of insertRow to be
       
 37433         a PassRefPtr.
       
 37434         * html/HTMLTableSectionElement.h: Ditto.
       
 37435 
       
 37436 2007-04-30  David Hyatt  <hyatt@apple.com>
       
 37437 
       
 37438         Fix for bug 12691, generated content and display: table-cell duplicates
       
 37439         content on a size change.  Make sure that the code to update before/after
       
 37440         content is smart enough to drill into anonymous containers to find the
       
 37441         old child.
       
 37442 
       
 37443         Reviewed by olliej
       
 37444 
       
 37445         Added fast/css-generated-content/table-cell-before-content.html
       
 37446 
       
 37447         * rendering/RenderBlock.cpp:
       
 37448         (WebCore::RenderBlock::setStyle):
       
 37449         * rendering/RenderButton.cpp:
       
 37450         (WebCore::RenderButton::updateBeforeAfterContent):
       
 37451         * rendering/RenderButton.h:
       
 37452         * rendering/RenderContainer.cpp:
       
 37453         (WebCore::RenderContainer::beforeAfterContainer):
       
 37454         (WebCore::RenderContainer::updateBeforeAfterContent):
       
 37455         (WebCore::RenderContainer::updateBeforeAfterContentForObject):
       
 37456         * rendering/RenderContainer.h:
       
 37457         * rendering/RenderInline.cpp:
       
 37458         (WebCore::RenderInline::setStyle):
       
 37459         (WebCore::RenderInline::addChildToFlow):
       
 37460         (WebCore::RenderInline::splitInlines):
       
 37461 
       
 37462 2007-04-30  Jungshik Shin <jungshik.shin@gmail.com>
       
 37463 
       
 37464         Reviewed by justin
       
 37465         
       
 37466         <http://bugs.webkit.org/show_bug.cgi?id=13552>
       
 37467         comment to Range::comparePoint in dom/Range.cpp has 
       
 37468         '0xD0' in place of '-': leading to a compiler warning
       
 37469 
       
 37470         * dom/Range.cpp:
       
 37471         (WebCore::Range::comparePoint):
       
 37472 
       
 37473 2007-04-30  Justin Garcia  <justin.garcia@apple.com>
       
 37474 
       
 37475         Reviewed by darin
       
 37476 
       
 37477         <rdar://problem/4875189> List gets deleted when replacing contents
       
 37478 
       
 37479         * editing/ReplaceSelectionCommand.cpp:
       
 37480         (WebCore::ReplaceSelectionCommand::doApply): Don't expand
       
 37481         to include elements, like lists, when deleting a selection 
       
 37482         to replace it.
       
 37483 
       
 37484 2007-04-30  Justin Garcia  <justin.garcia@apple.com>
       
 37485 
       
 37486         Reviewed by ggaren
       
 37487         
       
 37488         Buildfix.  Leave in grammar checking machinery to 
       
 37489         keep WebKit building on other platforms but don't
       
 37490         operate on sentence sized chunks so that we don't
       
 37491         re-introduce 5157329.
       
 37492 
       
 37493         * editing/Editor.h:
       
 37494         * editing/mac/EditorMac.mm:
       
 37495         (WebCore::Editor::markMisspellingsAfterTypingToPosition):
       
 37496         (WebCore::markMisspellingsOrBadGrammar):
       
 37497         (WebCore::Editor::markMisspellings):
       
 37498         (WebCore::Editor::markBadGrammar):
       
 37499         * page/Frame.cpp:
       
 37500         (WebCore::Frame::respondToChangedSelection):
       
 37501 
       
 37502 2007-04-30  Justin Garcia  <justin.garcia@apple.com>
       
 37503 
       
 37504         Reviewed by darin
       
 37505 
       
 37506         <rdar://problem/5168598> 
       
 37507         Crash when deleting a link inside an input field
       
 37508         
       
 37509         Deletion code tries to update one of its positions to keep 
       
 37510         it valid and nullifies it.  Later in mergeParagraphs we try 
       
 37511         to find out if it's valid by checking to see if it's still in 
       
 37512         the document and crash.
       
 37513         
       
 37514         The fix is just to not bother keeping the position, 
       
 37515         m_upstreamStart, valid, since after the point in the code 
       
 37516         under examination, it doesn't need to be valid anymore.  
       
 37517         Besides, code to update DeleteSelectionCommand's positions 
       
 37518         should go in the functions that handle the content removal 
       
 37519         that might invalid them (there are already FIXMEs about this).
       
 37520         
       
 37521         Also, users shouldn't be able to insert links (or any rich content)
       
 37522         into plaintext-only regions like text fields, even if those
       
 37523         text fields are inside richly editable regions.  This is a 
       
 37524         separate bug and is filed as 5171552.
       
 37525 
       
 37526         * editing/DeleteSelectionCommand.cpp:
       
 37527         (WebCore::DeleteSelectionCommand::handleGeneralDelete): Don't
       
 37528         bother updating m_upstreamStart.
       
 37529 
       
 37530 2007-04-30  Patti Hoa  <patti@apple.com>
       
 37531 
       
 37532         Reviewed by Dave Hyatt.
       
 37533         
       
 37534         <rdar://problem/5108546> REGRESSION: Zoom follows keyboard focus does not work
       
 37535 
       
 37536         * WebCore.xcodeproj/project.pbxproj:
       
 37537         Add new file SelectionControllerMac.mm
       
 37538         * dom/Document.cpp:
       
 37539         (WebCore::Document::updateSelection):
       
 37540         Move the code to fire off AXSelectedTextChanged notification to a new method notifyAccessibilityForSelectionChange in SelectionControllerMac.mm
       
 37541         * editing/SelectionController.cpp:
       
 37542         (WebCore::SelectionController::setSelection):
       
 37543         call notifyAccessibilityForSelectionChange to handle firing of accessibility notification and zoomFocusChange
       
 37544         * editing/SelectionController.h:
       
 37545         Add notifyAccessibilityForSelectionChange method for Mac platform
       
 37546         * platform/Widget.h:
       
 37547         * platform/mac/WidgetMac.mm:
       
 37548         (WebCore::Widget::convertToScreenCoordinate):
       
 37549         Add a helper routine that takes IntPoint in local coordinate and convert that to screen coordinate
       
 37550 
       
 37551 2007-04-30  Justin Garcia  <justin.garcia@apple.com>
       
 37552 
       
 37553         Reviewed by harrison
       
 37554 
       
 37555         <rdar://problem/5157329> 
       
 37556         REGRESSION: Crash at WTF::fastFree() when arrowing or deleting backward through editable text (13493)
       
 37557         
       
 37558         Backing out the changes for 4859132.
       
 37559 
       
 37560         * editing/Editor.h:
       
 37561         * editing/mac/EditorMac.mm:
       
 37562         (WebCore::Editor::markMisspellingsAfterTypingToPosition):
       
 37563         (WebCore::Editor::markMisspellings):
       
 37564         * page/Frame.cpp:
       
 37565         (WebCore::Frame::respondToChangedSelection):
       
 37566 
       
 37567 2007-04-29  Antti Koivisto  <antti@apple.com>
       
 37568 
       
 37569         Reviewed by Oliver.
       
 37570 
       
 37571         Fix <rdar://problem/5169261>
       
 37572         REGRESSION: Google Maps zooming too sensitive when using two fingers on trackpad
       
 37573         
       
 37574         Use line based delta values when generating DOM wheel events, use pixel deltas
       
 37575         for scrolling only.
       
 37576         
       
 37577         No test case, requires user interaction and specific hardware.
       
 37578 
       
 37579         * page/EventHandler.cpp:
       
 37580         (WebCore::EventHandler::handleWheelEvent):
       
 37581         * platform/PlatformWheelEvent.h:
       
 37582         (WebCore::PlatformWheelEvent::continuousDeltaX):
       
 37583         (WebCore::PlatformWheelEvent::continuousDeltaY):
       
 37584         * platform/mac/WheelEventMac.mm:
       
 37585         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
       
 37586 
       
 37587 2007-04-29  Oliver Hunt  <oliver@apple.com>
       
 37588 
       
 37589         Reviewed by Brady.
       
 37590 
       
 37591         Build fix for experimental features build
       
 37592 
       
 37593         * rendering/RenderForeignObject.cpp:
       
 37594 
       
 37595 2007-04-29  Mitz Pettel  <mitz@webkit.org>
       
 37596 
       
 37597         Reviewed by Dave Hyatt.
       
 37598 
       
 37599         - fix http://bugs.webkit.org/show_bug.cgi?id=13544
       
 37600           REGRESSION (r21120): Member profile frame not erased at Yahoo! Answers
       
 37601 
       
 37602         Test: fast/repaint/layer-hide-when-needs-layout.html
       
 37603 
       
 37604         * rendering/RenderObject.cpp:
       
 37605         (WebCore::RenderObject::setStyle): If we get a layout hint, we count on
       
 37606         layout() or updateLayerPositions() to repaint. In the case of a layer
       
 37607         going invisible, however, we need to repaint here since neither of the
       
 37608         above will do it.
       
 37609 
       
 37610 2007-04-29  Oliver Hunt  <oliver@apple.com>
       
 37611 
       
 37612         Reviewed by Steve.
       
 37613 
       
 37614         Fix for <rdar://problem/5126393> REGRESSION (r19672-19697): Safari drag image drags at original size (13261)
       
 37615 
       
 37616         Added logic to ensure that when we create the drag image
       
 37617         we're looking at the rendered image size.
       
 37618 
       
 37619         * page/DragController.cpp:
       
 37620         (WebCore::DragController::doImageDrag):
       
 37621           Pass the rendered image size to fitDragImageToMaxSize
       
 37622 
       
 37623         * platform/DragImage.cpp:
       
 37624         (WebCore::fitDragImageToMaxSize):
       
 37625            Need to do scaling relative to rendered image size
       
 37626 
       
 37627         * platform/DragImage.h:
       
 37628            scaleDragImage needs x and y scales to allow for them to be
       
 37629            scaled seperately on a page
       
 37630 
       
 37631         * platform/gdk/DragImageGdk.cpp:
       
 37632         (WebCore::scaleDragImage):
       
 37633            Prevent build bustage
       
 37634 
       
 37635         * platform/mac/DragImageMac.mm:
       
 37636         (WebCore::scaleDragImage):
       
 37637            scale width and height independently
       
 37638 
       
 37639         * platform/qt/DragImageQt.cpp:
       
 37640         (WebCore::scaleDragImage):
       
 37641            Prevent build bustage
       
 37642 
       
 37643 2007-04-29  Darin Adler  <darin@apple.com>
       
 37644 
       
 37645         Reviewed by Adele.
       
 37646 
       
 37647         - fix the Gmail part of http://bugs.webkit.org/show_bug.cgi?id=12798
       
 37648           and <rdar://problem/4118559>
       
 37649 
       
 37650         This patch changes things so that resizing can make things larger than their
       
 37651         initial size, but not smaller. I believe this resolves the problem for Gmail,
       
 37652         but you can still get strange behavior if you have a small right-aligned <textarea>.
       
 37653 
       
 37654         * rendering/RenderLayer.cpp:
       
 37655         (WebCore::RenderLayer::resize): Rewrote to use more IntPoint and IntSize and add
       
 37656         in a new minimum-size algorithm. This function now has the side effect of storing
       
 37657         a new minimumSizeForResizing in the element being resized, and respects any existing
       
 37658         minimum as well.
       
 37659         (WebCore::RenderLayer::offsetFromResizeCorner): Reversed this so it converts the
       
 37660         point into coordinates relative to the resize corner, hence negative numbers mean
       
 37661         the point is above and to the left. This is used only in the algorithm above.
       
 37662 
       
 37663         * dom/Element.h: Removed unneeded include of Attr.h, and added forward declarations
       
 37664         as needed. Removed all friend declarations; there was no need for any of them.
       
 37665         Tweaked formatting of various declarations and removed unneeded parameter names.
       
 37666         Made as much as possible private, and a couple things public to avoid the need for
       
 37667         friend classes. Added minimumSizeForResizing, setMinimumSizeForResizing, rareData,
       
 37668         and createRareData functions.
       
 37669 
       
 37670         * dom/Element.cpp:
       
 37671         (WebCore::rareDataMap): Added. Function to return the single global map.
       
 37672         (WebCore::rareDataFromMap): Added. For use by inlined functions to get the
       
 37673         data from the map in the case where it's present.
       
 37674         (WebCore::ElementRareData::ElementRareData): Added.
       
 37675         (WebCore::Element::~Element): Added code to delete the element from the rare
       
 37676         data map when appropriate.
       
 37677         (WebCore::Element::rareData): Added.
       
 37678         (WebCore::Element::createRareData): Added.
       
 37679         (WebCore::Element::setAttributeNodeNS): Got rid of the old inline version of this,
       
 37680         since it was the sole reason we had to include Attr.h in Element.h.
       
 37681         (WebCore::Element::minimumSizeForResizing): Added. Accesses rare data.
       
 37682         (WebCore::Element::setMinimumSizeForResizing): Ditto.
       
 37683 
       
 37684         * dom/Node.h: Renamed the m_specified bit since it's now used for two purposes.
       
 37685         Its new long name is m_attrWasSpecifiedOrElementHasRareData.
       
 37686 
       
 37687         * dom/Attr.cpp: (WebCore::Attr::Attr): Updated for bit name change.
       
 37688         * dom/Attr.h:
       
 37689         (WebCore::Attr::specified): Ditto.
       
 37690         (WebCore::Attr::setSpecified): Added, since setting the bit directly is pretty ugly now.
       
 37691         * dom/Document.cpp: (WebCore::Document::adoptNode): Updated for bit name change.
       
 37692         * dom/Node.cpp:
       
 37693         (WebCore::Node::Node): Ditto.
       
 37694         (WebCore::Node::dump): Ditto.
       
 37695 
       
 37696         * dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::isReadOnlyNode): Moved out of line,
       
 37697         since this was the sole reason we had to include Element.h in NamedAttrMap.h.
       
 37698 
       
 37699         * html/HTMLElement.cpp:
       
 37700         (WebCore::HTMLElement::nodeName): Changed to use tagQName() since that's a public
       
 37701         way to do something that's now private.
       
 37702         (WebCore::HTMLElement::cloneNode): Ditto.
       
 37703 
       
 37704         * dom/Attribute.cpp:
       
 37705         * dom/NamedAttrMap.h:
       
 37706         * dom/NamedMappedAttrMap.cpp:
       
 37707         * dom/StyledElement.h:
       
 37708         * html/HTMLTokenizer.h:
       
 37709         * xml/XPathFunctions.cpp:
       
 37710         * xml/XPathStep.cpp:
       
 37711         Updated includes, and other administrivia.
       
 37712 
       
 37713 2007-04-29  Mitz Pettel  <mitz@webkit.org>
       
 37714 
       
 37715         Reviewed by Darin and Hyatt.
       
 37716 
       
 37717         - http://bugs.webkit.org/show_bug.cgi?id=13487
       
 37718           Implement O(1) absoluteClippedOverflowRect and absoluteOutlineBox during layout for a possible speed gain
       
 37719 
       
 37720         Test for a bug fixed by this patch: fast/repaint/intermediate-layout-position-clip.html
       
 37721 
       
 37722         By keeping track of the total translation and clip during layout, absolutePosition and
       
 37723         computeAbsoluteRepaintRect become O(1).
       
 37724 
       
 37725         * WebCore.pro: Added LayoutState.cpp
       
 37726         * WebCore.vcproj/WebCore/WebCore.vcproj: Added LayoutState.{cpp,h}
       
 37727         * WebCore.xcodeproj/project.pbxproj: Added LayoutState.{cpp,h}
       
 37728         * WebCoreSources.bkl: Added LayoutState.cpp
       
 37729         * page/FrameView.cpp:
       
 37730         (WebCore::FrameView::layout): When doing subtree layout, push an initial layout state for the
       
 37731         layout root.
       
 37732         * rendering/LayoutState.cpp: Added. A LayoutState corresponding to a box consists of the origin of
       
 37733         its coordinate system in view coordinates and possibly the clip rect, in view coordinates, which
       
 37734         applies to its children.
       
 37735         (WebCore::LayoutState::LayoutState):
       
 37736         (WebCore::LayoutState::destroy):
       
 37737         (WebCore::throw):
       
 37738         (WebCore::LayoutState::operator delete):
       
 37739         * rendering/LayoutState.h: Added.
       
 37740         (WebCore::LayoutState::LayoutState):
       
 37741         * rendering/RenderBlock.cpp:
       
 37742         (WebCore::RenderBlock::layoutBlock): Factored out the "only positioned objects" case into
       
 37743         layoutOnlyPositionedObjects(). Added code to push/pop LayoutState, unless we have columns, in
       
 37744         which case we disable/enable LayoutState. Removed the translation by the layout delta
       
 37745         of the old absolute rects, since that is now integral to absoluteClippedOverflowRect() and
       
 37746         absoluteOutlineBox().
       
 37747         (WebCore::RenderBlock::layoutOnlyPositionedObjects): Added this helper function that checks for
       
 37748         and handles the case where only positioned objects need layout. Returns true in that case.
       
 37749         (WebCore::RenderBlock::repaintOverhangingFloats): Disabled LayoutState when repainting floats, since
       
 37750         they may belong to other containers.
       
 37751         (WebCore::RenderBlock::updateFirstLetter): Disabled LayoutState when adding and removing from the
       
 37752         first letter container, since it may be different than ourselves.
       
 37753         * rendering/RenderBlock.h:
       
 37754         * rendering/RenderBox.cpp:
       
 37755         (WebCore::RenderBox::setStyle): Minor cleanup: changed element()->document() to the equivalent document().
       
 37756         (WebCore::RenderBox::offsetForPositionedInContainer): Added. Factored out common code from
       
 37757         absolutePosition, computeAbsoluteRepaintRect and RenderLayer::updateLayerPosition into this function.
       
 37758         (WebCore::RenderBox::absolutePosition): Added an O(1) code path when this function is called during
       
 37759         layout (and LayoutState has not been disabled). Factored out some code into
       
 37760         offsetForPositionedInContainer.
       
 37761         (WebCore::RenderBox::absoluteClippedOverflowRect): Added the layout delta here, so callers don't need
       
 37762         to.
       
 37763         (WebCore::RenderBox::computeAbsoluteRepaintRect): Added an O(1) code path when this function is called
       
 37764         during layout (and LayoutState has not been disabled). Factored out some code into
       
 37765         offsetForPositionedInContainer.
       
 37766         * rendering/RenderContainer.cpp:
       
 37767         (WebCore::RenderContainer::layout): Added LayoutState push/pop.
       
 37768         * rendering/RenderFlexibleBox.cpp:
       
 37769         (WebCore::RenderFlexibleBox::layoutBlock): Factored out the "only positioned objects" case into
       
 37770         layoutOnlyPositionedObjects(). Added LayoutState push/pop. Removed the translation by the layout delta
       
 37771         of the old absolute rects, since that is now integral to absoluteClippedOverflowRect() and
       
 37772         absoluteOutlineBox().
       
 37773         * rendering/RenderFlow.cpp:
       
 37774         (WebCore::RenderFlow::absoluteClippedOverflowRect): Added an ASSERT.
       
 37775         * rendering/RenderForeignObject.cpp:
       
 37776         (WebCore::RenderForeignObject::layout): Disabled LayoutState because it is incompatible with arbitrary
       
 37777         affine transforms.
       
 37778         * rendering/RenderHTMLCanvas.cpp:
       
 37779         (WebCore::RenderHTMLCanvas::layout): Removed the translation by the layout delta of the old absolute
       
 37780         rects, since that is now integral to absoluteClippedOverflowRect() and absoluteOutlineBox().
       
 37781         * rendering/RenderImage.cpp:
       
 37782         (WebCore::RenderImage::layout): Ditto.
       
 37783         * rendering/RenderLayer.cpp:
       
 37784         (WebCore::RenderLayer::updateLayerPositions): Added ASSERTs. Factored out some code into
       
 37785         RenderBox::offsetForPositionedInContainer.
       
 37786         (WebCore::RenderLayer::updateScrollInfoAfterLayout): Disabled LayoutState around the call to
       
 37787         scrollToOffset.
       
 37788         * rendering/RenderListItem.cpp:
       
 37789         (WebCore::RenderListItem::updateMarkerLocation): Disabled LayoutState when moving the list marker, since
       
 37790         it can trigger repainting in other containers.
       
 37791         * rendering/RenderObject.cpp:
       
 37792         (WebCore::RenderObject::isRoot): Minor cleanup: changed element()->document() to the equivalent
       
 37793         document().
       
 37794         (WebCore::RenderObject::computeAbsoluteRepaintRect): Removed 'return' at the end of the function.
       
 37795         (WebCore::RenderObject::container): Reordered to avoid calling isText() twice.
       
 37796         (WebCore::RenderObject::absoluteOutlineBox): Added the layout delta here, so callers don't need to.
       
 37797         * rendering/RenderSVGContainer.cpp:
       
 37798         (WebCore::RenderSVGContainer::layout): Disabled LayoutState because it is incompatible with arbitrary
       
 37799         affine transforms.
       
 37800         * rendering/RenderTable.cpp:
       
 37801         (WebCore::RenderTable::layout):  Factored out the "only positioned objects" case into
       
 37802         layoutOnlyPositionedObjects(). Added LayoutState push/pop. Removed the translation by the layout delta
       
 37803         of the old absolute rects, since that is now integral to absoluteClippedOverflowRect() and
       
 37804         absoluteOutlineBox().
       
 37805         * rendering/RenderTableCell.cpp:
       
 37806         (WebCore::RenderTableCell::absoluteClippedOverflowRect): Added the layout delta here, so callers
       
 37807         don't need to.
       
 37808         (WebCore::RenderTableCell::computeAbsoluteRepaintRect): For the O(1) code path, skipped the correction
       
 37809         for the parent row, because RenderTableRow doesn't push a translation into LayoutState.
       
 37810         (WebCore::RenderTableCell::absolutePosition): Ditto.
       
 37811         * rendering/RenderTableRow.cpp:
       
 37812         (WebCore::RenderTableRow::layout): Added LayoutState push/pop.
       
 37813         * rendering/RenderTableSection.cpp:
       
 37814         (WebCore::RenderTableSection::setCellWidths): Added LayoutState push/pop if cells are repainted or
       
 37815         receive layout.
       
 37816         (WebCore::RenderTableSection::calcRowHeight): Ditto.
       
 37817         (WebCore::RenderTableSection::layoutRows): Added LayoutState push/pop.
       
 37818         * rendering/RenderView.cpp:
       
 37819         (WebCore::RenderView::RenderView):
       
 37820         (WebCore::RenderView::layout): Added initial LayoutState setup for the layout.
       
 37821         (WebCore::RenderView::paintBoxDecorations): Minor cleanup: changed element()->document() to the
       
 37822         equivalent document().
       
 37823         (WebCore::RenderView::repaintViewRectangle): Ditto.
       
 37824         (WebCore::RenderView::pushLayoutState): Added. Pushes initial layout state for subtree layout.
       
 37825         * rendering/RenderView.h:
       
 37826         (WebCore::RenderView::pushLayoutState):
       
 37827         (WebCore::RenderView::popLayoutState):
       
 37828         (WebCore::RenderView::layoutState):
       
 37829         (WebCore::RenderView::disableLayoutState):
       
 37830         (WebCore::RenderView::enableLayoutState):
       
 37831 
       
 37832 2007-04-29  David Hyatt  <hyatt@apple.com>
       
 37833 
       
 37834         Fix for bugzilla 13535, regression from positioning cleanup a while
       
 37835         back.  Some code got added to compute available width for a relpositioned
       
 37836         inline, only the code meant to be used for inline flows and not inline blocks.
       
 37837 
       
 37838         Reviewed by mjs
       
 37839 
       
 37840         fast/block/positioning/inline-block-relposition.html
       
 37841 
       
 37842         * rendering/RenderBox.cpp:
       
 37843         (WebCore::RenderBox::containingBlockWidthForPositioned):
       
 37844 
       
 37845 2007-04-29  Oliver Hunt  <oliver@apple.com>
       
 37846 
       
 37847         Reviewed by Zack.
       
 37848 
       
 37849         Implement basic drag and drop support for qt
       
 37850         this allows content and link dragging but does not
       
 37851         provide the DOM data access methods.
       
 37852 
       
 37853         * platform/DragData.h:
       
 37854         * platform/qt/ClipboardQt.cpp:
       
 37855         (WebCore::ClipboardQt::ClipboardQt):
       
 37856         (WebCore::ClipboardQt::~ClipboardQt):
       
 37857         (WebCore::ClipboardQt::clearData):
       
 37858         (WebCore::ClipboardQt::clearAllData):
       
 37859         (WebCore::ClipboardQt::setData):
       
 37860         (WebCore::ClipboardQt::declareAndWriteDragImage):
       
 37861         (WebCore::ClipboardQt::writeURL):
       
 37862         (WebCore::ClipboardQt::writeRange):
       
 37863         (WebCore::ClipboardQt::hasData):
       
 37864         * platform/qt/ClipboardQt.h:
       
 37865         (WebCore::ClipboardQt::clipboardData):
       
 37866         (WebCore::ClipboardQt::invalidateWritableData):
       
 37867         * platform/qt/DragDataQt.cpp:
       
 37868         (WebCore::DragData::canSmartReplace):
       
 37869         (WebCore::DragData::containsPlainText):
       
 37870         (WebCore::DragData::asPlainText):
       
 37871         (WebCore::DragData::createClipboard):
       
 37872         (WebCore::DragData::containsCompatibleContent):
       
 37873         (WebCore::DragData::containsURL):
       
 37874         (WebCore::DragData::asURL):
       
 37875         (WebCore::DragData::asFragment):
       
 37876 
       
 37877 2007-04-28  Maciej Stachowiak  <mjs@apple.com>
       
 37878 
       
 37879         Reviewed by Darin and Oliver.
       
 37880 
       
 37881         - change Document to hold onto Frame* instead of FrameView*
       
 37882         
       
 37883         This is an architectural cleanup and a prerequisite to fixing citibank login
       
 37884         in an architecturally sound way.
       
 37885 
       
 37886         Some fixups for the page cache:
       
 37887         
       
 37888         * history/CachedPage.cpp:
       
 37889         (WebCore::CachedPage::restore): Add an assert that the document's view
       
 37890         matches the cached page's view - this needs to be true by the time this
       
 37891         function is called.
       
 37892         (WebCore::CachedPage::clear): Change assert to require frame matching, not
       
 37893         view matching.
       
 37894         * history/CachedPage.h:
       
 37895         (WebCore::CachedPage::view): Add a way to get the view out.
       
 37896         * loader/FrameLoader.cpp:
       
 37897         (WebCore::FrameLoader::begin): pass Frame, not FrameView, when creating document
       
 37898         (WebCore::FrameLoader::open): restore view based on CachedPage, not Document. 
       
 37899 
       
 37900         Remaining changes are just straightforward updates based on which
       
 37901         pointer is held or passed:
       
 37902         
       
 37903         * dom/DOMImplementation.cpp:
       
 37904         (WebCore::DOMImplementation::createDocument):
       
 37905         (WebCore::DOMImplementation::createHTMLDocument):
       
 37906         * dom/DOMImplementation.h:
       
 37907         * dom/Document.cpp:
       
 37908         (WebCore::Document::Document):
       
 37909         (WebCore::Document::view):
       
 37910         (WebCore::Document::frame):
       
 37911         (WebCore::Document::recalcStyle):
       
 37912         (WebCore::Document::updateLayout):
       
 37913         (WebCore::Document::attach):
       
 37914         (WebCore::Document::detach):
       
 37915         (WebCore::Document::createTokenizer):
       
 37916         (WebCore::Document::recalcStyleSelector):
       
 37917         (WebCore::Document::setInPageCache):
       
 37918         (WebCore::Document::applyXSLTransform):
       
 37919         * dom/Document.h:
       
 37920         * html/HTMLDocument.cpp:
       
 37921         (WebCore::HTMLDocument::HTMLDocument):
       
 37922         * html/HTMLDocument.h:
       
 37923         * html/HTMLViewSourceDocument.cpp:
       
 37924         (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
       
 37925         * html/HTMLViewSourceDocument.h:
       
 37926         * ksvg2/svg/SVGDocument.cpp:
       
 37927         (WebCore::SVGDocument::SVGDocument):
       
 37928         * ksvg2/svg/SVGDocument.h:
       
 37929         * loader/ImageDocument.cpp:
       
 37930         (WebCore::ImageDocument::ImageDocument):
       
 37931         * loader/ImageDocument.h:
       
 37932         * loader/PluginDocument.cpp:
       
 37933         (WebCore::PluginDocument::PluginDocument):
       
 37934         * loader/PluginDocument.h:
       
 37935         * loader/TextDocument.cpp:
       
 37936         (WebCore::TextDocument::TextDocument):
       
 37937         * loader/TextDocument.h:
       
 37938         * xml/XSLTProcessor.cpp:
       
 37939         (WebCore::XSLTProcessor::createDocumentFromSource):
       
 37940         (WebCore::XSLTProcessor::transformToDocument):
       
 37941         * xml/XSLTProcessor.h:
       
 37942 
       
 37943 2007-04-28  Adele Peterson  <adele@apple.com>
       
 37944 
       
 37945         RS by Darin.
       
 37946 
       
 37947         Update to fix for <rdar://problem/5152299>
       
 37948 
       
 37949         Test: fast/events/no-blur-on-enter-button.html
       
 37950 
       
 37951         * html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler):
       
 37952         Don't blur the button when handling the enter key.  This matches our new behavior for input elements.
       
 37953 
       
 37954 2007-04-28  Adele Peterson  <adele@apple.com>
       
 37955 
       
 37956         Fix by Darin, reviewed by me.
       
 37957 
       
 37958         Fix for <rdar://problem/5152299> REGRESSION: <button> elements do not respond to space and return key as similar <input> elements do
       
 37959 
       
 37960         Tests:
       
 37961         fast/forms/button-spacebar-click.html
       
 37962         fast/forms/button-enter-click.html
       
 37963 
       
 37964         * html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::): Made type enum private.
       
 37965         Removed unnecessary m_value and m_currValue, and unused m_dirty.
       
 37966         * html/HTMLButtonElement.cpp:
       
 37967         (WebCore::HTMLButtonElement::HTMLButtonElement): Removed initialization of m_dirty.
       
 37968         (WebCore::HTMLButtonElement::parseMappedAttribute): Removed case to parse value and accesskey attributes, which don't do anything.
       
 37969         (WebCore::HTMLButtonElement::defaultEventHandler): Removed unnecessary check for button type.
       
 37970          Added cases to handle spacebar and enter keys in the same way that they're handled for <input type=button/reset/submit> buttons.
       
 37971         (WebCore::HTMLButtonElement::isSuccessfulSubmitButton): Shortened comment.
       
 37972         (WebCore::HTMLButtonElement::appendFormData): Use value() instead of m_currValue.  Renamed encoding argument to formData.
       
 37973 
       
 37974 2007-04-28  Mitz Pettel  <mitz@webkit.org>
       
 37975 
       
 37976         Reviewed by Darin.
       
 37977 
       
 37978         - fix http://bugs.webkit.org/show_bug.cgi?id=13501
       
 37979           REGRESSION (r21093): Pasting into text field fails and makes the caret disappear
       
 37980 
       
 37981         Test: fast/dynamic/anonymous-block-layer-lost.html
       
 37982 
       
 37983         * rendering/RenderBlock.cpp:
       
 37984         (WebCore::RenderBlock::removeChild): Avoid cutting off layers when removing
       
 37985         the anonymous block.
       
 37986 
       
 37987 2007-04-28  Mitz Pettel  <mitz@webkit.org>
       
 37988 
       
 37989         Reviewed by Darin.
       
 37990 
       
 37991         - fix http://bugs.webkit.org/show_bug.cgi?id=13471
       
 37992           REGRESSION (r21045): Secure keyboard entry mode remains in effect after leaving a password field by submitting
       
 37993 
       
 37994         * loader/FrameLoader.cpp:
       
 37995         (WebCore::FrameLoader::clear): Replaced direct access to Frame's d->m_doc
       
 37996         with a call to Frame::setDocument.
       
 37997         (WebCore::FrameLoader::begin): Ditto.
       
 37998         (WebCore::FrameLoader::open): Ditto.
       
 37999         (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady): Ditto.
       
 38000         (WebCore::FrameLoader::canCachePage): Added a comment.
       
 38001         * manual-tests/secure-keyboard-enabled-after-submit.html: Added.
       
 38002         * page/Frame.cpp:
       
 38003         (WebCore::Frame::setDocument): Reset secure keyboard entry, in case the
       
 38004         old document's focused node has set it.
       
 38005 
       
 38006 2007-04-28  Mitz Pettel  <mitz@webkit.org>
       
 38007 
       
 38008         Reviewed by Adele.
       
 38009 
       
 38010         - fix http://bugs.webkit.org/show_bug.cgi?id=13379
       
 38011           REGRESSION: Cannot add an option to a selected popup
       
 38012 
       
 38013         * manual-tests/update-empty-popup.html: Added.
       
 38014         * platform/mac/PopupMenuMac.mm:
       
 38015         (WebCore::PopupMenu::show): Added a call to the client's hidePopup()
       
 38016         callback before returning in the case that the menu is empty. Otherwise
       
 38017         the client thinks that the menu stayed open.
       
 38018 
       
 38019 2007-04-28  Adele Peterson  <adele@apple.com>
       
 38020 
       
 38021         Reviewed by Darin.
       
 38022 
       
 38023         Fix for <rdar://problem/4806988> REGRESSION: history.go(0) doesn't reload page (affects buttons at facebook.com)
       
 38024 
       
 38025         Test: fast/history/history_reload.html
       
 38026 
       
 38027         * loader/FrameLoader.cpp: (WebCore::FrameLoader::scheduleHistoryNavigation):
       
 38028         We avoid doing a redirection when going to the same url in a history navigation, but we have to still
       
 38029         schedule a redirection when the number of steps is zero so we can force a reload.
       
 38030 
       
 38031 2007-04-28  Alexey Proskuryakov  <ap@webkit.org>
       
 38032 
       
 38033         Reviewed by Darin.
       
 38034 
       
 38035         http://bugs.webkit.org/show_bug.cgi?id=13514
       
 38036         REGRESSION (r20997-21003): Crash in WebCore::Node::document
       
 38037 
       
 38038         Test: fast/dom/NodeList/childNodes-reset-cache.html
       
 38039 
       
 38040         * dom/Node.cpp:
       
 38041         (WebCore::Node::notifyLocalNodeListsChildrenChanged): Reset the common caches for child node
       
 38042         lists. We cannot rely on notifications, since there may be no list objects left around.
       
 38043 
       
 38044         * dom/ChildNodeList.cpp:
       
 38045         (WebCore::ChildNodeList::rootNodeChildrenChanged):
       
 38046         * dom/ChildNodeList.h:
       
 38047         Override rootNodeChildrenChanged() with an empty implementation, now that caches are reset
       
 38048         in Node::notifyLocalNodeListsChildrenChanged().
       
 38049 
       
 38050 2007-04-28  Mark Rowe  <mrowe@apple.com>
       
 38051 
       
 38052         Build fix.  Change use of nil to 0 in C++ source file.
       
 38053 
       
 38054         * editing/Editor.cpp:
       
 38055         (WebCore::Editor::increaseSelectionListLevel):
       
 38056         (WebCore::Editor::increaseSelectionListLevelOrdered):
       
 38057         (WebCore::Editor::increaseSelectionListLevelUnordered):
       
 38058 
       
 38059 2007-04-28  Darin Adler  <darin@apple.com>
       
 38060 
       
 38061         Reviewed by Adele.
       
 38062 
       
 38063         - fix http://bugs.webkit.org/show_bug.cgi?id=6216
       
 38064           REGRESSION: getElementsByTagNameNS with empty namespace doesn't work
       
 38065 
       
 38066         * dom/Node.cpp:
       
 38067         (WebCore::TagNodeList::TagNodeList): Changed parameter to PassRefPtr, tweaked formatting.
       
 38068         (WebCore::TagNodeList::item): Tweaked formatting.
       
 38069         (WebCore::TagNodeList::nodeMatches): Tweaked formatting.
       
 38070         (WebCore::Node::setPrefix): Tweaked formatting.
       
 38071         (WebCore::Node::getElementsByTagNameNS): Added special case to turn empty namespaces into
       
 38072         null namespaces.
       
 38073 
       
 38074 2007-04-28  Darin Adler  <darin@apple.com>
       
 38075 
       
 38076         Reviewed by Kevin Decker.
       
 38077 
       
 38078         - fix <rdar://problem/5148271> Chinese numbers are incorrect in numbered lists
       
 38079           (including pasting from TextEdit to Mail)
       
 38080 
       
 38081         Covered by an existing regression test, which had wrong results checked in.
       
 38082 
       
 38083         Hyatt told me not to use the algorithm in the CSS 3 specification, but I didn't listen!
       
 38084         This corrects mistakes there and makes our results match current Firefox.
       
 38085 
       
 38086         * rendering/RenderListMarker.cpp:
       
 38087         (WebCore::toCJKIdeographic): Added code to strip off trailing zero digits.
       
 38088         Added special case for zero, since that's the one case where we don't want
       
 38089         to strip off trailing zero digits. Fixed mixed-up logic that would put the
       
 38090         digits in each group backwards.
       
 38091         (WebCore::listMarkerText): Corrected character values for the CJK_IDEOGRAPHIC case.
       
 38092 
       
 38093 2007-04-28  Darin Adler  <darin@apple.com>
       
 38094 
       
 38095         Reviewed by Oliver.
       
 38096 
       
 38097         - fix <rdar://problem/5138250> REGRESSION (r18245): Changing any one aspect
       
 38098           of a font applies all the aspects to selected text
       
 38099 
       
 38100         Since this bug is only visible with the font panel, I don't
       
 38101         think there's any way to make a DumpRenderTree-driven test.
       
 38102 
       
 38103         * editing/Editor.cpp: (WebCore::Editor::fontForSelection):
       
 38104         Set hasMultipleFonts properly. The old code had an early exit
       
 38105         that was left over from when hasMultipleFonts was a pointer.
       
 38106 
       
 38107 2007-04-27  Mitz Pettel  <mitz@webkit.org>
       
 38108 
       
 38109         Reviewed by Dave Hyatt.
       
 38110 
       
 38111         - fix http://bugs.webkit.org/show_bug.cgi?id=13525
       
 38112           Repainting a listbox schedules a relayout
       
 38113 
       
 38114         No test possible as there is no change to functionality.
       
 38115 
       
 38116         - fix the root cause of http://bugs.webkit.org/show_bug.cgi?id=10862
       
 38117           REGRESSION: Collapsing form input on www.myspace.com
       
 38118 
       
 38119         No test possible since text fields are no longer implemented as flexboxes.
       
 38120 
       
 38121         * rendering/RenderObject.cpp:
       
 38122         (WebCore::RenderObject::scheduleRelayout): Added a check that the subtree
       
 38123         root is in the tree and not free-floating.
       
 38124         * rendering/bidi.cpp:
       
 38125         (WebCore::RenderBlock::bidiReorderCharacters): Changed addChild and removeChild
       
 38126         to appendChildNode and removeChildNode to save some unnecessary overhead.
       
 38127         These calls still mark the tree for relayout, but the change in scheduleRelayout 
       
 38128         ensures that a layout won't be scheduled.
       
 38129 
       
 38130 2007-04-27  Patti Hoa  <patti@apple.com>
       
 38131 
       
 38132         Reviewed by Darin.
       
 38133         
       
 38134         <rdar://problem/5153017> REPRODUCIBLE ASSERT: range != nil in WebViewFactory.mm:415 -[WebViewFactory startOfTextMarkerRange:] (13354)
       
 38135         
       
 38136         * bridge/mac/WebCoreAXObject.mm:
       
 38137         (-[WebCoreAXObject textMarkerRangeForRange:]):
       
 38138         Fix the range length check.  It was incorrectly assuming that the max range requested cannot be equal
       
 38139         to the length of the string.  Since NSRange location is index based, it's perfectly valid to have the max
       
 38140         range equal to the the text length.
       
 38141 
       
 38142 2007-04-27  David Harrison  <harrison@apple.com>
       
 38143 
       
 38144         Reviewed by Darin.
       
 38145 
       
 38146         <rdar://problem/5160627> Export JS list creation support as ObjC SPI for Mail
       
 38147 
       
 38148         * WebCore.exp:
       
 38149         * editing/Editor.h:
       
 38150         * editing/Editor.cpp:
       
 38151         (WebCore::Editor::insertOrderedList):
       
 38152         (WebCore::Editor::insertUnorderedList):
       
 38153         (WebCore::Editor::canIncreaseSelectionListLevel):
       
 38154         (WebCore::Editor::canDecreaseSelectionListLevel):
       
 38155         (WebCore::Editor::increaseSelectionListLevel):
       
 38156         (WebCore::Editor::increaseSelectionListLevelOrdered):
       
 38157         (WebCore::Editor::increaseSelectionListLevelUnordered):
       
 38158         (WebCore::Editor::decreaseSelectionListLevel):
       
 38159         Add insertOrderedList() and insertUnorderedList().
       
 38160         Move existing list management functions from WebCoreFrameBridge.
       
 38161         The level increasing functions now return a PassRefPtr<Node> instead of Node.
       
 38162         Add check for canEditRichly.
       
 38163         
       
 38164         - in many other functions, condense the check for nil client().
       
 38165         
       
 38166         * editing/InsertListCommand.h:
       
 38167         * editing/InsertListCommand.cpp:
       
 38168         (WebCore::InsertListCommand::insertList):
       
 38169         (WebCore::InsertListCommand::fixOrphanedListChild):
       
 38170         (WebCore::InsertListCommand::doApply):
       
 38171         Add insertList(), which returns the new list element.
       
 38172         Don't set the list element's ID if the specified ID was an empty string.
       
 38173                 
       
 38174         * editing/ModifySelectionListLevel.h:
       
 38175         * editing/ModifySelectionListLevel.cpp:
       
 38176         (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType):
       
 38177         (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel):
       
 38178         (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelOrdered):
       
 38179         (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelUnordered):
       
 38180         Return PassRefPtr<Node> instead of Node.
       
 38181 
       
 38182         * page/mac/WebCoreFrameBridge.h:
       
 38183         * page/mac/WebCoreFrameBridge.mm:
       
 38184         Move list management functions to Editor.h and Editor.cpp.
       
 38185 
       
 38186 
       
 38187 2007-04-27  David Hyatt  <hyatt@apple.com>
       
 38188 
       
 38189         Fix for <rdar://problem/5134254>, toolbar buttons don't work in gmail after double-click.  Make sure
       
 38190         to clear out the capturing frame, since you don't get a second up when a double-click happens.
       
 38191 
       
 38192         Reviewed by mjs
       
 38193 
       
 38194         * page/EventHandler.cpp:
       
 38195         (WebCore::EventHandler::handleMouseDoubleClickEvent):
       
 38196 
       
 38197 2007-04-27  Justin Garcia  <justin.garcia@apple.com>
       
 38198 
       
 38199         Reviewed by oliver
       
 38200 
       
 38201         <rdar://problem/5164796> 
       
 38202         Enable execCommand("CreateLink", ...) for caret selections
       
 38203 
       
 38204         * editing/CreateLinkCommand.cpp:
       
 38205         (WebCore::CreateLinkCommand::doApply): For a caret
       
 38206         selection, insert a link at the caret position
       
 38207         with the url as the link text.
       
 38208         * editing/JSEditor.cpp: Enable CreateLink for caret 
       
 38209         selections.
       
 38210 
       
 38211 2007-04-27  Antti Koivisto  <antti@apple.com>
       
 38212 
       
 38213         Reviewed by Darin, Hyatt.
       
 38214         
       
 38215         Fix http://bugs.webkit.org/show_bug.cgi?id=13081
       
 38216         Empty table cells not handled correctly
       
 38217         <rdar://problem/5067926>
       
 38218         
       
 38219         To match Firefox and IE, empty table cells with variable width need to be
       
 38220         treated as special case. They generally get zero width.
       
 38221 
       
 38222         * rendering/AutoTableLayout.cpp:
       
 38223         (WebCore::AutoTableLayout::recalcColumn):
       
 38224         (WebCore::AutoTableLayout::calcEffectiveWidth):
       
 38225         (WebCore::AutoTableLayout::layout):
       
 38226         * rendering/AutoTableLayout.h:
       
 38227         (WebCore::AutoTableLayout::Layout::Layout):
       
 38228         * rendering/RenderStyle.h:
       
 38229         (WebCore::RenderStyle::hasPadding):
       
 38230 
       
 38231 2007-04-27  Rob Buis  <buis@kde.org>
       
 38232 
       
 38233         Reviewed by Oliver.
       
 38234 
       
 38235         http://bugs.webkit.org/show_bug.cgi?id=13052
       
 38236         Text not rendered in a second inline SVG element
       
 38237 
       
 38238         Correct the rendering of svg text when embedded in non-svg container.
       
 38239 
       
 38240         * rendering/RenderSVGText.cpp:
       
 38241         (WebCore::RenderSVGText::paint):
       
 38242 
       
 38243 2007-04-27  Mark Rowe  <mrowe@apple.com>
       
 38244 
       
 38245         Reviewed by Maciej.
       
 38246 
       
 38247         * WebCore.pro: Remove non-existent paths from qmake files.
       
 38248 
       
 38249 2007-04-25  Lars Naesbye Christensen <lars@naesbye.dk>
       
 38250 
       
 38251         Reviewed by Timothy Hatcher.
       
 38252 
       
 38253         http://bugs.webkit.org/show_bug.cgi?id=13477
       
 38254         Bug 13477: Help and context menu cursors need dropshadows.
       
 38255 
       
 38256         * Resources/cellCursor.png:
       
 38257         * Resources/contextMenuCursor.png:
       
 38258         * Resources/helpCursor.png:
       
 38259         * platform/mac/CursorMac.mm:
       
 38260         (WebCore::contextMenuCursor):
       
 38261         (WebCore::copyCursor):
       
 38262         (WebCore::progressCursor):
       
 38263         (WebCore::noDropCursor):
       
 38264 
       
 38265 2007-04-27  Holger Freyther <freyther@kde.org>
       
 38266 
       
 38267         Reviewed by Maciej.
       
 38268 
       
 38269         Remove unmaintained CMake build system.
       
 38270 
       
 38271         * CMakeLists.txt: Removed.
       
 38272 
       
 38273 2007-04-26  Matt Perry  <mpComplete@gmail.com>
       
 38274 
       
 38275         Reviewed by Maciej.
       
 38276 
       
 38277         Added a version check to hackAroundLibXMLEntityBug, since that bug has
       
 38278         been fixed in recent versions of libxml2.
       
 38279 
       
 38280         * dom/XMLTokenizer.cpp:
       
 38281         (WebCore::hackAroundLibXMLEntityBug):
       
 38282 
       
 38283 2007-04-26  Christopher Brichford  <chrisb@adobe.com>
       
 38284 
       
 38285         Reviewed by Timothy Hatcher.
       
 38286 
       
 38287         - Fix for Bug 13204: Submit initial version of mac project files for apollo
       
 38288           port of WebCore
       
 38289           http://bugs.webkit.org/show_bug.cgi?id=13204
       
 38290 
       
 38291         * WebCore.apolloproj/mac/WebCore.Debug.xcconfig: Added.
       
 38292         * WebCore.apolloproj/mac/WebCore.Release.xcconfig: Added.
       
 38293         * WebCore.apolloproj/mac/WebCore.xcconfig: Added.
       
 38294         * WebCore.apolloproj/mac/WebCore.xcodeproj/project.pbxproj: Added.
       
 38295 
       
 38296 2007-04-26  Alp Toker  <alp@atoker.com>
       
 38297 
       
 38298         Reviewed by Maciej.
       
 38299 
       
 38300         http://bugs.webkit.org/show_bug.cgi?id=13505
       
 38301         Cast loses precision on x86_64
       
 38302 
       
 38303         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
 38304         (WebCore::GraphicsContext::beginTransparencyLayer):
       
 38305         (WebCore::GraphicsContext::endTransparencyLayer):
       
 38306         Use a stack of opacity values instead of Cairo user data.
       
 38307 
       
 38308 2007-04-26  Mitz Pettel  <mitz@webkit.org>
       
 38309 
       
 38310         Reviewed by Darin.
       
 38311 
       
 38312         - fix http://bugs.webkit.org/show_bug.cgi?id=13500
       
 38313           REGRESSION: Listbox scrollbar does not reflect actual scrolled position when selected option is added after layout
       
 38314 
       
 38315         Test: fast/forms/listbox-scrollbar-incremental-load.html
       
 38316 
       
 38317         The scroller position was not updated correctly during insertion, since
       
 38318         scrollbar proportions are updated only during layout
       
 38319 
       
 38320         * rendering/RenderListBox.cpp:
       
 38321         (WebCore::RenderListBox::selectionChanged): Delay scrolling to reveal the
       
 38322         selection until after layout if m_optionsChanged is set. Layout is
       
 38323         guaranteed to happen soon when the flag is set.
       
 38324 
       
 38325 2007-04-26  David Hyatt  <hyatt@apple.com>
       
 38326 
       
 38327         Fix for 13511, crash on a counters page.  Make sure that RenderTexts
       
 38328         never get a null StringImpl.  I would have added an assert that the length
       
 38329         had to be nonzero also, but unfortunately editing creates empty RenderTexts
       
 38330         because of its EditingText DOM subclass that always forces renderers to be
       
 38331         made.  I suppose there is a good reason for this...
       
 38332 
       
 38333         Reviewed by aroben
       
 38334 
       
 38335         * dom/CharacterData.cpp:
       
 38336         (WebCore::CharacterData::setData):
       
 38337         (WebCore::CharacterData::appendData):
       
 38338         (WebCore::CharacterData::insertData):
       
 38339         (WebCore::CharacterData::deleteData):
       
 38340         (WebCore::CharacterData::replaceData):
       
 38341         * rendering/RenderCounter.cpp:
       
 38342         (WebCore::RenderCounter::RenderCounter):
       
 38343         * rendering/RenderText.cpp:
       
 38344         (WebCore::RenderText::RenderText):
       
 38345         (WebCore::RenderText::trimmedPrefWidths):
       
 38346         (WebCore::RenderText::setTextWithOffset):
       
 38347         (WebCore::RenderText::setTextInternal):
       
 38348         (WebCore::RenderText::setText):
       
 38349 
       
 38350 2007-04-26  Alice Liu  <alice.liu@apple.com>
       
 38351 
       
 38352         Reviewed by Oliver.
       
 38353 
       
 38354         * editing/SelectionController.cpp:
       
 38355         (WebCore::SelectionController::selectAll):
       
 38356         adding null check
       
 38357 
       
 38358 2007-04-26  Justin Garcia  <justin.garcia@apple.com>
       
 38359 
       
 38360         Reviewed by oliver
       
 38361 
       
 38362         <rdar://problem/5120591> 
       
 38363         Crash when creating a link in Leopard wiki server
       
 38364 
       
 38365         * editing/CreateLinkCommand.cpp:
       
 38366         (WebCore::CreateLinkCommand::doApply): Use a RefPtr,
       
 38367         setting the anchor's href can destroy it if there is
       
 38368         an ancestor with a subtree modified event listener.
       
 38369 
       
 38370 2007-04-26  Mitz Pettel  <mitz@webkit.org>
       
 38371 
       
 38372         Reviewed by hyatt
       
 38373 
       
 38374         - http://bugs.webkit.org/show_bug.cgi?id=13496
       
 38375           Eliminate repaintObjectsBeforeLayout
       
 38376 
       
 38377         No tests added since there is no change to functionality. Several
       
 38378         tests in fast/repaint test repainting of objects that move during layout.
       
 38379 
       
 38380         * page/FrameView.cpp:
       
 38381         (WebCore::FrameView::layout):
       
 38382         * rendering/RenderBlock.cpp:
       
 38383         (WebCore::RenderBlock::layoutBlockChildren): Removed an early
       
 38384         setNeedsLayout(false). Resetting the bit here prevents the full repaint
       
 38385         that we rely on when we decide not to repaint children that move.
       
 38386         * rendering/RenderBlock.h:
       
 38387         * rendering/RenderObject.cpp:
       
 38388         * rendering/RenderObject.h:
       
 38389         * rendering/RenderTableSection.cpp:
       
 38390         (WebCore::RenderTableSection::setCellWidths): Replaced the call to
       
 38391         repaintObjectsBeforeLayout() if the cell didn't need layout with
       
 38392         an unconditional repaint(). We don't bother with repainting only the
       
 38393         delta between the old and new widths, since by marking the cell for
       
 38394         layout results in a full repaint with the new width anyway.
       
 38395 
       
 38396 2007-04-26  David Hyatt  <hyatt@apple.com>
       
 38397 
       
 38398         Fix for 13509.  Don't recur to parent inline flows if they have been
       
 38399         marked as needing layout themselves.
       
 38400 
       
 38401         Reviewed by adele
       
 38402 
       
 38403         * rendering/RenderFlow.cpp:
       
 38404         (WebCore::RenderFlow::dirtyLinesFromChangedChild):
       
 38405 
       
 38406 2007-04-26  Matt Perry  <mpComplete@gmail.com>
       
 38407 
       
 38408         Reviewed and landed by Alexey.
       
 38409 
       
 38410         http://bugs.webkit.org/show_bug.cgi?id=13495
       
 38411         Crash when referencing an undefined entity in an XHTML document
       
 38412 
       
 38413         Test: fast/parser/badentity.xhtml
       
 38414 
       
 38415         * dom/XMLTokenizer.cpp:
       
 38416         (WebCore::getEntityHandler): Check for a NULL returned from getXHTMLEntity
       
 38417 
       
 38418 2007-04-26  Anders Carlsson  <andersca@apple.com>
       
 38419 
       
 38420         Reviewed by Hyatt.
       
 38421 
       
 38422         <rdar://problem/4851944>
       
 38423         REGRESSION: With TOT, BMP images can no longer be opened in the browser window
       
 38424         
       
 38425         On Tiger, the MIME type for the com.microsoft.bmp UTI isn't in the registry, so add it manually.
       
 38426         
       
 38427         * platform/MimeTypeRegistry.cpp:
       
 38428         (WebCore::initialiseSupportedImageMIMETypes):
       
 38429 
       
 38430 2007-04-26  David Hyatt  <hyatt@apple.com>
       
 38431 
       
 38432         Fix for bug 13503, invalidateContainingBlockPrefWidths is 15% of the
       
 38433         nesting PLT.  Avoid O(n^2) behavior by including inlines in the minmax
       
 38434         dirty chain.
       
 38435 
       
 38436         Reviewed by kevin
       
 38437 
       
 38438         * rendering/RenderBlock.cpp:
       
 38439         (WebCore::RenderBlock::calcInlinePrefWidths):
       
 38440         * rendering/RenderObject.cpp:
       
 38441         (WebCore::RenderObject::setPrefWidthsDirty):
       
 38442         (WebCore::RenderObject::invalidateContainerPrefWidths):
       
 38443         * rendering/RenderObject.h:
       
 38444 
       
 38445 2007-04-26  Anders Carlsson  <andersca@apple.com>
       
 38446 
       
 38447         Reviewed by Darin.
       
 38448 
       
 38449         <rdar://problem/5067925>
       
 38450         Reproducible crash (infinite recursion) with a layout test that submits on unload (13078)
       
 38451         
       
 38452         Ask the document loader whether it's loading the main resource, since there are cases where the frame 
       
 38453         loader's variable isn't updated correctly.
       
 38454         
       
 38455         In the distant future, the frame loader shouldn't have an instance variable but this is the least intrusive fix for now.
       
 38456         
       
 38457         I couldn't come up with a good test case for this since it requires running three tests in a row and scheduleLoad didn't work. Also,
       
 38458         calling submit in the onunload prevents any new tests from loading!
       
 38459         
       
 38460         * loader/FrameLoader.cpp:
       
 38461         (WebCore::FrameLoader::isLoading):
       
 38462 
       
 38463 2007-04-26  Anders Carlsson  <andersca@apple.com>
       
 38464 
       
 38465         ... and fix the build.
       
 38466         
       
 38467         * loader/FrameLoader.cpp:
       
 38468         (WebCore::FrameLoader::continueAfterNavigationPolicy):
       
 38469 
       
 38470 2007-04-26  Anders Carlsson  <andersca@apple.com>
       
 38471 
       
 38472         Revert the previous change - activeDocumentLoader never returns the policy document loader.
       
 38473         Instead, add a null check for the policy document loader.
       
 38474         
       
 38475         * loader/FrameLoader.cpp:
       
 38476         (WebCore::FrameLoader::continueAfterNavigationPolicy):
       
 38477 
       
 38478 2007-04-26  Anders Carlsson  <andersca@apple.com>
       
 38479 
       
 38480         Use the active document loader instead of the policy document loader.
       
 38481         
       
 38482         * loader/FrameLoader.cpp:
       
 38483         (WebCore::FrameLoader::continueAfterNavigationPolicy):
       
 38484 
       
 38485 2007-04-26  Anders Carlsson  <andersca@apple.com>
       
 38486 
       
 38487         Reviewed by Maciej.
       
 38488 
       
 38489         <rdar://problem/5049099> documents no longer have a default base URL
       
 38490 
       
 38491         Don't call canHandleRequest if we have valid substitute data and the protocol is "applewebdata".
       
 38492         
       
 38493         * loader/FrameLoader.cpp:
       
 38494         (WebCore::FrameLoader::continueAfterNavigationPolicy):
       
 38495 
       
 38496 2007-04-25  Stephanie Lewis <slewis@apple.com>
       
 38497 
       
 38498         Reviewed by Darin.
       
 38499 
       
 38500         Fix the build for platforms that overload the abs function.        
       
 38501 
       
 38502         * dom/ChildNodeList.cpp:
       
 38503         (WebCore::ChildNodeList::item):
       
 38504 
       
 38505 2007-04-25  David Hyatt  <hyatt@apple.com>
       
 38506 
       
 38507         Fix for bug 13373, make sure to invalidate the pref widths for objects
       
 38508         with percentage padding.
       
 38509 
       
 38510         Reviewed by beth
       
 38511 
       
 38512         * rendering/RenderBlock.cpp:
       
 38513         (WebCore::RenderBlock::layoutBlockChildren):
       
 38514         (WebCore::RenderBlock::layoutPositionedObjects):
       
 38515         * rendering/bidi.cpp:
       
 38516         (WebCore::RenderBlock::layoutInlineChildren):
       
 38517 
       
 38518 2007-04-25  David Harrison  <harrison@apple.com>
       
 38519 
       
 38520         Comment change. Correct the header name in the endif comment.
       
 38521         
       
 38522         * editing/FormatBlockCommand.h:
       
 38523         Change InsertListCommand_h to FormatBlockCommand_h.
       
 38524 
       
 38525 2007-04-25  Darin Adler  <darin@apple.com>
       
 38526 
       
 38527         Reviewed by Hyatt.
       
 38528 
       
 38529         * platform/AtomicString.cpp: (WebCore::AtomicString::add):
       
 38530         Removed unnecessary use of strlen to check if a string is empty.
       
 38531 
       
 38532 2007-04-25  Mitz Pettel  <mitz@webkit.org>
       
 38533 
       
 38534         Build fix.
       
 38535 
       
 38536         * rendering/RenderListMarker.h: Undeleted the m_text member.
       
 38537 
       
 38538 2007-04-25  David Hyatt  <hyatt@apple.com>
       
 38539 
       
 38540         Rearchitect calcPrefWidths.  The calculation is now done lazily only when minPrefWidth
       
 38541         or maxPrefWidth are asked for.  The result of the calculation is cached.
       
 38542 
       
 38543         The new invalidation scheme for pref width invalidation follows the
       
 38544         containing block hierarchy and knows to halt at positioned objects, since
       
 38545         they cannot influence the size of their containers.
       
 38546 
       
 38547         Reviewed by darin
       
 38548 
       
 38549         * css/cssstyleselector.cpp:
       
 38550         (WebCore::CSSStyleSelector::init):
       
 38551         (WebCore::CSSStyleSelector::initForStyleResolve):
       
 38552         * page/FrameView.cpp:
       
 38553         (WebCore::FrameView::layout):
       
 38554         * rendering/RenderApplet.cpp:
       
 38555         (WebCore::RenderApplet::layout):
       
 38556         * rendering/RenderBlock.cpp:
       
 38557         (WebCore::RenderBlock::makeChildrenNonInline):
       
 38558         (WebCore::RenderBlock::removeChild):
       
 38559         (WebCore::RenderBlock::layout):
       
 38560         (WebCore::RenderBlock::layoutBlock):
       
 38561         (WebCore::RenderBlock::calcPrefWidths):
       
 38562         (WebCore::InlineMinMaxIterator::endOfInline):
       
 38563         (WebCore::shouldGrowTableCellForImage):
       
 38564         (WebCore::RenderBlock::calcInlinePrefWidths):
       
 38565         (WebCore::RenderBlock::calcBlockPrefWidths):
       
 38566         * rendering/RenderBlock.h:
       
 38567         * rendering/RenderBox.cpp:
       
 38568         (WebCore::RenderBox::setStyle):
       
 38569         (WebCore::RenderBox::minPrefWidth):
       
 38570         (WebCore::RenderBox::maxPrefWidth):
       
 38571         (WebCore::RenderBox::calcWidth):
       
 38572         (WebCore::RenderBox::calcWidthUsing):
       
 38573         (WebCore::RenderBox::calcAbsoluteHorizontal):
       
 38574         (WebCore::RenderBox::calcAbsoluteHorizontalValues):
       
 38575         * rendering/RenderBox.h:
       
 38576         * rendering/RenderContainer.cpp:
       
 38577         (WebCore::RenderContainer::removeChildNode):
       
 38578         (WebCore::RenderContainer::appendChildNode):
       
 38579         (WebCore::RenderContainer::insertChildNode):
       
 38580         (WebCore::RenderContainer::layout):
       
 38581         * rendering/RenderContainer.h:
       
 38582         (WebCore::RenderContainer::moveChildNode):
       
 38583         * rendering/RenderCounter.cpp:
       
 38584         (WebCore::RenderCounter::dirtyLineBoxes):
       
 38585         (WebCore::RenderCounter::calcPrefWidths):
       
 38586         * rendering/RenderCounter.h:
       
 38587         * rendering/RenderFileUploadControl.cpp:
       
 38588         (WebCore::RenderFileUploadControl::calcPrefWidths):
       
 38589         * rendering/RenderFlexibleBox.cpp:
       
 38590         (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
       
 38591         (WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
       
 38592         (WebCore::RenderFlexibleBox::calcPrefWidths):
       
 38593         (WebCore::RenderFlexibleBox::layoutBlock):
       
 38594         * rendering/RenderForeignObject.cpp:
       
 38595         (WebCore::RenderForeignObject::layout):
       
 38596         * rendering/RenderFrameSet.cpp:
       
 38597         (WebCore::RenderFrameSet::layout):
       
 38598         * rendering/RenderHTMLCanvas.cpp:
       
 38599         (WebCore::RenderHTMLCanvas::layout):
       
 38600         * rendering/RenderImage.cpp:
       
 38601         (WebCore::RenderImage::layout):
       
 38602         * rendering/RenderInline.cpp:
       
 38603         * rendering/RenderInline.h:
       
 38604         * rendering/RenderListBox.cpp:
       
 38605         (WebCore::RenderListBox::updateFromElement):
       
 38606         (WebCore::RenderListBox::calcPrefWidths):
       
 38607         * rendering/RenderListItem.cpp:
       
 38608         (WebCore::firstNonMarkerChild):
       
 38609         (WebCore::RenderListItem::updateMarkerLocation):
       
 38610         (WebCore::RenderListItem::calcPrefWidths):
       
 38611         (WebCore::RenderListItem::layout):
       
 38612         * rendering/RenderListMarker.cpp:
       
 38613         (WebCore::RenderListMarker::layout):
       
 38614         (WebCore::RenderListMarker::calcPrefWidths):
       
 38615         (WebCore::RenderListMarker::updateMargins):
       
 38616         * rendering/RenderListMarker.h:
       
 38617         * rendering/RenderObject.cpp:
       
 38618         (WebCore::RenderObject::RenderObject):
       
 38619         (WebCore::RenderObject::removeChildNode):
       
 38620         (WebCore::RenderObject::moveChildNode):
       
 38621         (WebCore::RenderObject::appendChildNode):
       
 38622         (WebCore::RenderObject::insertChildNode):
       
 38623         (WebCore::RenderObject::setPrefWidthsDirty):
       
 38624         (WebCore::RenderObject::invalidateContainingBlockPrefWidths):
       
 38625         (WebCore::RenderObject::information):
       
 38626         (WebCore::RenderObject::setStyle):
       
 38627         * rendering/RenderObject.h:
       
 38628         (WebCore::RenderObject::layer):
       
 38629         (WebCore::RenderObject::hasLayer):
       
 38630         (WebCore::RenderObject::prefWidthsDirty):
       
 38631         (WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc):
       
 38632         (WebCore::RenderObject::setHasLayer):
       
 38633         * rendering/RenderPartObject.cpp:
       
 38634         (WebCore::RenderPartObject::layout):
       
 38635         * rendering/RenderSVGContainer.cpp:
       
 38636         (WebCore::RenderSVGContainer::layout):
       
 38637         * rendering/RenderSVGContainer.h:
       
 38638         * rendering/RenderSVGHiddenContainer.cpp:
       
 38639         * rendering/RenderSVGHiddenContainer.h:
       
 38640         * rendering/RenderSVGText.cpp:
       
 38641         (WebCore::RenderSVGText::layout):
       
 38642         * rendering/RenderTable.cpp:
       
 38643         (WebCore::RenderTable::calcWidth):
       
 38644         (WebCore::RenderTable::layout):
       
 38645         (WebCore::RenderTable::removeChildNode):
       
 38646         * rendering/RenderTable.h:
       
 38647         * rendering/RenderTableRow.cpp:
       
 38648         (WebCore::RenderTableRow::layout):
       
 38649         * rendering/RenderTableSection.cpp:
       
 38650         (WebCore::RenderTableSection::removeChildNode):
       
 38651         * rendering/RenderTableSection.h:
       
 38652         * rendering/RenderText.cpp:
       
 38653         (WebCore::RenderText::trimmedPrefWidths):
       
 38654         (WebCore::isSpaceAccordingToStyle):
       
 38655         (WebCore::RenderText::minPrefWidth):
       
 38656         (WebCore::RenderText::maxPrefWidth):
       
 38657         (WebCore::RenderText::calcPrefWidths):
       
 38658         (WebCore::RenderText::width):
       
 38659         * rendering/RenderText.h:
       
 38660         * rendering/RenderView.cpp:
       
 38661         (WebCore::RenderView::RenderView):
       
 38662         (WebCore::RenderView::calcPrefWidths):
       
 38663         (WebCore::RenderView::layout):
       
 38664         * rendering/RenderWidget.cpp:
       
 38665         (WebCore::RenderWidget::layout):
       
 38666 
       
 38667 2007-04-25  Steve Falkenburg  <sfalken@apple.com>
       
 38668 
       
 38669         Reviewed by Adam.
       
 38670 
       
 38671         Fix spelling error in spelling method name.
       
 38672         Expose new spelling callback methods to all platforms.
       
 38673 
       
 38674         * bridge/EditorClient.h:
       
 38675         * platform/gdk/EditorClientGdk.cpp:
       
 38676         (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString):
       
 38677         * platform/gdk/EditorClientGdk.h:
       
 38678         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 38679         (WebCore::SVGEmptyEditorClient::updateSpellingUIWithGrammarString):
       
 38680         (WebCore::SVGEmptyEditorClient::getGuessesForWord):
       
 38681 
       
 38682 2007-04-24  Geoffrey Garen  <ggaren@apple.com>
       
 38683 
       
 38684         Reviewed by Darin Adler, Tim Hatcher.
       
 38685 
       
 38686         Fixed a few NSAutoreleasePool issues I noticed while reviewing Brady's patch.
       
 38687 
       
 38688         * platform/graphics/mac/GraphicsContextMac.mm:
       
 38689         (WebCore::GraphicsContext::setCompositeOperation): Call -drain instead of 
       
 38690         -release, since -release is a no-op in a GC world.
       
 38691 
       
 38692 2007-04-25  Alexey Proskuryakov  <ap@webkit.org>
       
 38693 
       
 38694         Reviewed by Darin.
       
 38695 
       
 38696         http://bugs.webkit.org/show_bug.cgi?id=13445
       
 38697         NodeList access by index is slow
       
 38698 
       
 38699         * dom/ChildNodeList.cpp:
       
 38700         (WebCore::ChildNodeList::item): Support iterating backwards from the last accessed node
       
 38701         or from the last child.
       
 38702         * dom/NodeList.h: Make cachedLength unsigned.
       
 38703 
       
 38704 2007-04-26  Mark Rowe  <mrowe@apple.com>
       
 38705 
       
 38706         Gdk build fix.  Add missing stub.
       
 38707 
       
 38708         * platform/gdk/TemporaryLinkStubs.cpp:
       
 38709         (Editor::advanceToNextMisspelling):
       
 38710 
       
 38711 2007-04-25  Rob Buis  <buis@kde.org>
       
 38712 
       
 38713         Reviewed by Darin.
       
 38714 
       
 38715         http://bugs.webkit.org/show_bug.cgi?id=12163
       
 38716         SVG text does not appear in a scrolling <div>
       
 38717 
       
 38718         Make sure SVG text is painted when scrolling by taking into account the relative offset of the non-SVG parent in the paintInfo rect.
       
 38719 
       
 38720         * rendering/RenderSVGContainer.cpp:
       
 38721         (WebCore::RenderSVGContainer::paint):
       
 38722 
       
 38723 2007-04-26  Mark Rowe  <mrowe@apple.com>
       
 38724 
       
 38725         Fix non-Mac builds after r21081.
       
 38726 
       
 38727         Stub out new Editor methods for Qt and Gdk, and new SVGEmptyEditorClient methods
       
 38728         for all non-Mac builds.
       
 38729 
       
 38730         * editing/qt/EditorQt.cpp:
       
 38731         (WebCore::Editor::showSpellingGuessPanel):
       
 38732         (WebCore::Editor::spellingPanelIsShowing):
       
 38733         * page/qt/EventHandlerQt.cpp:
       
 38734         (WebCore::EventHandler::passWheelEventToWidget):
       
 38735         (WebCore::EventHandler::passMousePressEventToScrollbar):
       
 38736         * platform/gdk/TemporaryLinkStubs.cpp:
       
 38737         (Editor::showSpellingGuessPanel):
       
 38738         (Editor::spellingPanelIsShowing):
       
 38739         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 38740         (WebCore::SVGEmptyEditorClient::ignoreWordInSpellDocument):
       
 38741         (WebCore::SVGEmptyEditorClient::learnWord):
       
 38742         (WebCore::SVGEmptyEditorClient::checkSpellingOfString):
       
 38743         (WebCore::SVGEmptyEditorClient::checkGrammarOfString):
       
 38744         (WebCore::SVGEmptyEditorClient::udpateSpellingUIWithGrammarString):
       
 38745         (WebCore::SVGEmptyEditorClient::updateSpellingUIWithMisspelledWord):
       
 38746         (WebCore::SVGEmptyEditorClient::showSpellingUI):
       
 38747         (WebCore::SVGEmptyEditorClient::spellingUIIsShowing):
       
 38748         (WebCore::SVGEmptyEditorClient::getGuessesForWord):
       
 38749 
       
 38750 2007-04-25  Anders Carlsson  <andersca@apple.com>
       
 38751 
       
 38752         Reviewed by Ada.
       
 38753 
       
 38754         <rdar://problem/5122153>
       
 38755         Crash occurs at WebCore::Frame::loader() when switching to Bookmarks view while loading standalone image
       
 38756 
       
 38757         Don't call writeRawData if the data length is 0. (This is checked by the decoder for the non-raw case).
       
 38758 
       
 38759         * loader/FrameLoader.cpp:
       
 38760         (WebCore::FrameLoader::write):
       
 38761 
       
 38762 2007-04-26  Mark Rowe  <mrowe@apple.com>
       
 38763 
       
 38764         Gdk build fix courtesy of Alp Toker.
       
 38765 
       
 38766         * make-generated-sources.sh:  Remove conditional logic to ensure the
       
 38767         script exits with the correct exit code.
       
 38768 
       
 38769 2007-04-24  Anders Carlsson  <andersca@apple.com>
       
 38770 
       
 38771         Reviewed by Mitz.
       
 38772 
       
 38773         <rdar://problem/4869095> 
       
 38774         default content type for XMLHttpRequest POSTs changed (breaks Flickrator 0.1 widget)
       
 38775         
       
 38776         Use the right MIME type.
       
 38777         
       
 38778         * xml/xmlhttprequest.cpp:
       
 38779         (WebCore::XMLHttpRequest::send):
       
 38780 
       
 38781 2007-04-24  Darin Adler  <darin@apple.com>
       
 38782 
       
 38783         Reviewed by Maciej.
       
 38784 
       
 38785         - second round of preparation for Hyatt's "lazy minMaxWidth" change
       
 38786           http://bugs.webkit.org/show_bug.cgi?id=13431
       
 38787 
       
 38788         These are small changes that are either safe to do first, or unrelated to the main
       
 38789         change in Hyatt's patch.
       
 38790 
       
 38791         - Preallocate 4 entries each in m_layoutStruct and m_spanCells to save allocation
       
 38792           in AutoTableLayout.
       
 38793         - Add an early exit to RenderFlow::dirtyLinesFromChangedChild.
       
 38794         - Change InlineBox::hasTextChildren() to use a bit directly and never a virtual function.
       
 38795         - Save a virtual function call by using a local bool variable for isTableCell().
       
 38796 
       
 38797         - Fix containingBlock() so it returns 0 for table cells with no parent.
       
 38798 
       
 38799         - Change all callers who are getting at layer() as a boolean to use hasLayer().
       
 38800         - Change if statements to max() function calls (only the ones Hyatt had in his patch).
       
 38801         - Remove some old kdDebug calls.
       
 38802         - Tweak formatting of some code.
       
 38803         - Add const in one place.
       
 38804 
       
 38805         * bindings/js/kjs_html.cpp:
       
 38806         (KJS::HTMLElementFunction::callAsFunction):
       
 38807         * page/EventHandler.cpp:
       
 38808         (WebCore::EventHandler::eventMayStartDrag):
       
 38809         * page/Frame.cpp:
       
 38810         (WebCore::Frame::clearTimers):
       
 38811         * rendering/AutoTableLayout.cpp:
       
 38812         (WebCore::AutoTableLayout::recalcColumn):
       
 38813         * rendering/AutoTableLayout.h:
       
 38814         * rendering/InlineBox.h:
       
 38815         (WebCore::InlineBox::InlineBox):
       
 38816         (WebCore::InlineBox::hasTextChildren):
       
 38817         * rendering/InlineFlowBox.cpp:
       
 38818         (WebCore::InlineFlowBox::nodeAtPoint):
       
 38819         * rendering/InlineFlowBox.h:
       
 38820         (WebCore::InlineFlowBox::InlineFlowBox):
       
 38821         * rendering/RenderBlock.cpp:
       
 38822         (WebCore::RenderBlock::layoutBlock):
       
 38823         (WebCore::RenderBlock::repaintOverhangingFloats):
       
 38824         (WebCore::RenderBlock::paintChildren):
       
 38825         (WebCore::RenderBlock::paintFloats):
       
 38826         (WebCore::RenderBlock::fillBlockSelectionGaps):
       
 38827         (WebCore::RenderBlock::insertFloatingObject):
       
 38828         (WebCore::RenderBlock::floatRect):
       
 38829         (WebCore::RenderBlock::lowestPosition):
       
 38830         (WebCore::RenderBlock::rightmostPosition):
       
 38831         (WebCore::RenderBlock::leftmostPosition):
       
 38832         (WebCore::RenderBlock::addOverhangingFloats):
       
 38833         (WebCore::RenderBlock::nodeAtPoint):
       
 38834         (WebCore::RenderBlock::hitTestContents):
       
 38835         (WebCore::RenderBlock::calcPrefWidths):
       
 38836         (WebCore::InlineMinMaxIterator::next):
       
 38837         (WebCore::getBorderPaddingMargin):
       
 38838         (WebCore::RenderBlock::calcInlinePrefWidths):
       
 38839         (WebCore::RenderBlock::calcBlockPrefWidths):
       
 38840         * rendering/RenderContainer.cpp:
       
 38841         (WebCore::RenderContainer::appendChildNode):
       
 38842         (WebCore::RenderContainer::insertChildNode):
       
 38843         * rendering/RenderFlexibleBox.cpp:
       
 38844         (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
       
 38845         (WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
       
 38846         * rendering/RenderFlow.cpp:
       
 38847         (WebCore::RenderFlow::dirtyLinesFromChangedChild):
       
 38848         * rendering/RenderLayer.cpp:
       
 38849         (WebCore::RenderLayer::updateVisibilityStatus):
       
 38850         (WebCore::RenderLayer::updateLayerPosition):
       
 38851         * rendering/RenderObject.cpp:
       
 38852         (WebCore::RenderObject::containingBlock):
       
 38853         * rendering/RenderTable.cpp:
       
 38854         (WebCore::RenderTable::paint):
       
 38855         * rendering/RenderTableCell.cpp:
       
 38856         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
       
 38857         * rendering/RenderTableRow.cpp:
       
 38858         (WebCore::RenderTableRow::nodeAtPoint):
       
 38859         (WebCore::RenderTableRow::paint):
       
 38860         * rendering/RenderTableSection.cpp:
       
 38861         (WebCore::RenderTableSection::nodeAtPoint):
       
 38862         * rendering/RenderTreeAsText.cpp:
       
 38863         (WebCore::write):
       
 38864 
       
 38865 2007-04-24  Steve Falkenburg  <sfalken@apple.com>
       
 38866 
       
 38867         Reviewed by Darin, Oliver.
       
 38868 
       
 38869         Refactor spelling codepaths
       
 38870 
       
 38871         * bridge/EditorClient.h:
       
 38872         * page/ContextMenuController.cpp:
       
 38873         (WebCore::ContextMenuController::contextMenuItemSelected):
       
 38874         * platform/ContextMenu.cpp:
       
 38875         (WebCore::ContextMenu::populate):
       
 38876         (WebCore::ContextMenu::checkOrEnableIfNeeded):
       
 38877         * platform/gdk/EditorClientGdk.cpp:
       
 38878         (WebCore::EditorClientGdk::ignoreWordInSpellDocument):
       
 38879         (WebCore::EditorClientGdk::learnWord):
       
 38880         (WebCore::EditorClientGdk::checkSpellingOfString):
       
 38881         (WebCore::EditorClientGdk::checkGrammarOfString):
       
 38882         (WebCore::EditorClientGdk::udpateSpellingUIWithGrammarString):
       
 38883         (WebCore::EditorClientGdk::updateSpellingUIWithMisspelledWord):
       
 38884         (WebCore::EditorClientGdk::showSpellingUI):
       
 38885         (WebCore::EditorClientGdk::spellingUIIsShowing):
       
 38886         (WebCore::EditorClientGdk::getGuessesForWord):
       
 38887         * platform/gdk/EditorClientGdk.h:
       
 38888 
       
 38889 2007-04-24  Darin Adler  <darin@apple.com>
       
 38890 
       
 38891         Reviewed by Adele.
       
 38892 
       
 38893         - first round of preparation for Hyatt's "lazy minMaxWidth" change
       
 38894           http://bugs.webkit.org/show_bug.cgi?id=13431
       
 38895 
       
 38896         This patch limits itself to renaming and making other super-simple
       
 38897         changes so that the above change will be smaller and easier to review
       
 38898         and understand.
       
 38899 
       
 38900         Rename:
       
 38901 
       
 38902             calcHorizontalMinMaxWidth -> calcHorizontalPrefWidths
       
 38903             calcMinMaxWidth -> calcPrefWidths
       
 38904             calcMinMaxWidthInternal -> calcPrefWidthsInternal
       
 38905             calcVerticalMinMaxWidth -> calcVerticalPrefWidths
       
 38906             setNeedsLayoutAndMinMaxRecalc -> setNeedsLayoutAndPrefWidthsRecalc
       
 38907             trimmedMinMaxWidth -> trimmedPrefWidths
       
 38908 
       
 38909             RenderObject::m_maxWidth -> RenderObject::m_maxPrefWidth
       
 38910             RenderObject::m_minWidth -> RenderObject::m_minPrefWidth
       
 38911             RenderObject::maxWidth() -> RenderObject::maxPrefWidth()
       
 38912             RenderObject::minWidth() -> RenderObject::minPrefWidth()
       
 38913 
       
 38914         Replace m_minMaxKnown, minMaxKnown(), and setMinMaxKnown() with
       
 38915         m_prefWidthsDirty, prefWidthsDirty(), and setPrefWidthsDirty(),
       
 38916         a boolean with the opposite sense.
       
 38917 
       
 38918         Convert some uses of if statements into "max".
       
 38919 
       
 38920         Change many uses of layer() to hasLayer(). For now it's just a boolean
       
 38921         version of layer(), but Hyatt's patch makes it faster by using a bit.
       
 38922 
       
 38923         Added a guard to use of axObjectCache() to make RenderObject destruction
       
 38924         a little faster for the normal case.
       
 38925 
       
 38926         Removed some assertions that will be removed in Hyatt's patch.
       
 38927 
       
 38928         Made some functions const that will be const in Hyatt's patch.
       
 38929 
       
 38930         Put in some revised comments from Hyatt's patch.
       
 38931 
       
 38932         Removed an unneeded nil check from RenderListMarker::setStyle.
       
 38933 
       
 38934         Moved RootInlineBox::setHorizontalOverflowPositions and
       
 38935         RootInlineBox::setVerticalSelectionPositions to the RootInlineBox.h
       
 38936         header and marked them inline.
       
 38937 
       
 38938         * dom/Document.cpp:
       
 38939         (WebCore::Document::updateStyleSelector):
       
 38940         * html/HTMLTextAreaElement.cpp:
       
 38941         (WebCore::HTMLTextAreaElement::parseMappedAttribute):
       
 38942         * page/Frame.cpp:
       
 38943         (WebCore::Frame::forceLayoutWithPageWidthRange):
       
 38944         * rendering/AutoTableLayout.cpp:
       
 38945         (WebCore::AutoTableLayout::recalcColumn):
       
 38946         (WebCore::AutoTableLayout::calcPrefWidths):
       
 38947         (WebCore::AutoTableLayout::calcEffectiveWidth):
       
 38948         * rendering/AutoTableLayout.h:
       
 38949         * rendering/CounterNode.cpp:
       
 38950         (WebCore::CounterNode::recount):
       
 38951         * rendering/FixedTableLayout.cpp:
       
 38952         (WebCore::FixedTableLayout::calcPrefWidths):
       
 38953         * rendering/FixedTableLayout.h:
       
 38954         * rendering/InlineFlowBox.cpp:
       
 38955         (WebCore::InlineFlowBox::paint):
       
 38956         * rendering/RenderApplet.cpp:
       
 38957         (WebCore::RenderApplet::layout):
       
 38958         * rendering/RenderBlock.cpp:
       
 38959         (WebCore::RenderBlock::removeChild):
       
 38960         (WebCore::RenderBlock::layoutBlock):
       
 38961         (WebCore::RenderBlock::handleCompactChild):
       
 38962         (WebCore::RenderBlock::getClearDelta):
       
 38963         (WebCore::RenderBlock::calcPrefWidths):
       
 38964         (WebCore::RenderBlock::calcInlinePrefWidths):
       
 38965         (WebCore::RenderBlock::calcBlockPrefWidths):
       
 38966         * rendering/RenderBlock.h:
       
 38967         * rendering/RenderBox.cpp:
       
 38968         (WebCore::RenderBox::RenderBox):
       
 38969         (WebCore::RenderBox::nodeAtPoint):
       
 38970         (WebCore::RenderBox::calcWidth):
       
 38971         (WebCore::RenderBox::calcWidthUsing):
       
 38972         (WebCore::RenderBox::calcAbsoluteHorizontal):
       
 38973         (WebCore::RenderBox::calcAbsoluteHorizontalValues):
       
 38974         * rendering/RenderBox.h:
       
 38975         (WebCore::RenderBox::minPrefWidth):
       
 38976         (WebCore::RenderBox::maxPrefWidth):
       
 38977         * rendering/RenderContainer.cpp:
       
 38978         (WebCore::RenderContainer::removeChildNode):
       
 38979         (WebCore::RenderContainer::appendChildNode):
       
 38980         (WebCore::RenderContainer::insertChildNode):
       
 38981         (WebCore::RenderContainer::layout):
       
 38982         * rendering/RenderContainer.h:
       
 38983         (WebCore::RenderContainer::calcPrefWidths):
       
 38984         * rendering/RenderCounter.cpp:
       
 38985         (WebCore::RenderCounter::calcPrefWidths):
       
 38986         * rendering/RenderCounter.h:
       
 38987         * rendering/RenderFieldset.cpp:
       
 38988         (WebCore::RenderFieldset::calcPrefWidths):
       
 38989         * rendering/RenderFieldset.h:
       
 38990         * rendering/RenderFileUploadControl.cpp:
       
 38991         (WebCore::RenderFileUploadControl::calcPrefWidths):
       
 38992         * rendering/RenderFileUploadControl.h:
       
 38993         * rendering/RenderFlexibleBox.cpp:
       
 38994         (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
       
 38995         (WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
       
 38996         (WebCore::RenderFlexibleBox::calcPrefWidths):
       
 38997         (WebCore::RenderFlexibleBox::layoutBlock):
       
 38998         (WebCore::RenderFlexibleBox::allowedChildFlex):
       
 38999         * rendering/RenderFlexibleBox.h:
       
 39000         (WebCore::RenderFlexibleBox::hasMultipleLines):
       
 39001         (WebCore::RenderFlexibleBox::isVertical):
       
 39002         (WebCore::RenderFlexibleBox::isHorizontal):
       
 39003         * rendering/RenderFlow.cpp:
       
 39004         (WebCore::RenderFlow::absoluteClippedOverflowRect):
       
 39005         * rendering/RenderForeignObject.cpp:
       
 39006         (WebCore::RenderForeignObject::layout):
       
 39007         * rendering/RenderFrameSet.cpp:
       
 39008         (WebCore::RenderFrameSet::layout):
       
 39009         * rendering/RenderHTMLCanvas.cpp:
       
 39010         (WebCore::RenderHTMLCanvas::layout):
       
 39011         * rendering/RenderImage.cpp:
       
 39012         (WebCore::RenderImage::imageChanged):
       
 39013         (WebCore::RenderImage::layout):
       
 39014         (WebCore::RenderImage::calcPrefWidths):
       
 39015         * rendering/RenderImage.h:
       
 39016         * rendering/RenderInline.cpp:
       
 39017         (WebCore::RenderInline::addChildToFlow):
       
 39018         (WebCore::RenderInline::splitInlines):
       
 39019         (WebCore::RenderInline::splitFlow):
       
 39020         (WebCore::RenderInline::calcPrefWidths):
       
 39021         * rendering/RenderInline.h:
       
 39022         * rendering/RenderListBox.cpp:
       
 39023         (WebCore::RenderListBox::updateFromElement):
       
 39024         (WebCore::RenderListBox::calcPrefWidths):
       
 39025         * rendering/RenderListBox.h:
       
 39026         * rendering/RenderListItem.cpp:
       
 39027         (WebCore::RenderListItem::updateValue):
       
 39028         (WebCore::RenderListItem::updateMarkerLocation):
       
 39029         (WebCore::RenderListItem::calcPrefWidths):
       
 39030         (WebCore::RenderListItem::layout):
       
 39031         (WebCore::RenderListItem::explicitValueChanged):
       
 39032         * rendering/RenderListItem.h:
       
 39033         * rendering/RenderListMarker.cpp:
       
 39034         (WebCore::RenderListMarker::setStyle):
       
 39035         (WebCore::RenderListMarker::layout):
       
 39036         (WebCore::RenderListMarker::imageChanged):
       
 39037         (WebCore::RenderListMarker::calcPrefWidths):
       
 39038         (WebCore::RenderListMarker::calcWidth):
       
 39039         * rendering/RenderListMarker.h:
       
 39040         * rendering/RenderMenuList.cpp:
       
 39041         (WebCore::RenderMenuList::updateOptionsWidth):
       
 39042         (WebCore::RenderMenuList::calcPrefWidths):
       
 39043         * rendering/RenderMenuList.h:
       
 39044         * rendering/RenderObject.cpp:
       
 39045         (WebCore::RenderObject::RenderObject):
       
 39046         (WebCore::addLayers):
       
 39047         (WebCore::RenderObject::removeLayers):
       
 39048         (WebCore::RenderObject::moveLayers):
       
 39049         (WebCore::RenderObject::addAbsoluteRectForLayer):
       
 39050         (WebCore::RenderObject::checkForRepaintDuringLayout):
       
 39051         (WebCore::RenderObject::dump):
       
 39052         (WebCore::RenderObject::setStyle):
       
 39053         (WebCore::RenderObject::destroy):
       
 39054         (WebCore::RenderObject::recalcMinMaxWidths):
       
 39055         * rendering/RenderObject.h:
       
 39056         (WebCore::RenderObject::hasLayer):
       
 39057         (WebCore::RenderObject::prefWidthsDirty):
       
 39058         (WebCore::RenderObject::setPrefWidthsDirty):
       
 39059         (WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc):
       
 39060         (WebCore::RenderObject::calcPrefWidths):
       
 39061         (WebCore::RenderObject::minPrefWidth):
       
 39062         (WebCore::RenderObject::maxPrefWidth):
       
 39063         * rendering/RenderPart.cpp:
       
 39064         (WebCore::RenderPart::setWidget):
       
 39065         * rendering/RenderPartObject.cpp:
       
 39066         (WebCore::RenderPartObject::updateWidget):
       
 39067         (WebCore::RenderPartObject::layout):
       
 39068         * rendering/RenderReplaced.cpp:
       
 39069         (WebCore::RenderReplaced::calcPrefWidths):
       
 39070         * rendering/RenderReplaced.h:
       
 39071         * rendering/RenderSVGContainer.cpp:
       
 39072         (WebCore::RenderSVGContainer::calcPrefWidths):
       
 39073         (WebCore::RenderSVGContainer::layout):
       
 39074         * rendering/RenderSVGContainer.h:
       
 39075         * rendering/RenderSVGHiddenContainer.cpp:
       
 39076         (WebCore::RenderSVGHiddenContainer::calcPrefWidths):
       
 39077         * rendering/RenderSVGHiddenContainer.h:
       
 39078         * rendering/RenderSVGText.cpp:
       
 39079         (WebCore::RenderSVGText::layout):
       
 39080         * rendering/RenderSlider.cpp:
       
 39081         (WebCore::RenderSlider::calcPrefWidths):
       
 39082         * rendering/RenderSlider.h:
       
 39083         * rendering/RenderTable.cpp:
       
 39084         (WebCore::RenderTable::calcWidth):
       
 39085         (WebCore::RenderTable::layout):
       
 39086         (WebCore::RenderTable::calcPrefWidths):
       
 39087         (WebCore::RenderTable::splitColumn):
       
 39088         (WebCore::RenderTable::appendColumn):
       
 39089         * rendering/RenderTable.h:
       
 39090         * rendering/RenderTableCell.cpp:
       
 39091         (WebCore::RenderTableCell::updateFromElement):
       
 39092         (WebCore::RenderTableCell::styleOrColWidth):
       
 39093         (WebCore::RenderTableCell::calcPrefWidths):
       
 39094         * rendering/RenderTableCell.h:
       
 39095         * rendering/RenderTableCol.cpp:
       
 39096         (WebCore::RenderTableCol::updateFromElement):
       
 39097         * rendering/RenderTableRow.cpp:
       
 39098         (WebCore::RenderTableRow::layout):
       
 39099         * rendering/RenderTableSection.cpp:
       
 39100         (WebCore::RenderTableSection::paint):
       
 39101         * rendering/RenderText.cpp:
       
 39102         (WebCore::RenderText::trimmedPrefWidths):
       
 39103         (WebCore::RenderText::calcPrefWidths):
       
 39104         (WebCore::RenderText::calcPrefWidthsInternal):
       
 39105         (WebCore::RenderText::setText):
       
 39106         * rendering/RenderText.h:
       
 39107         (WebCore::RenderText::minPrefWidth):
       
 39108         (WebCore::RenderText::maxPrefWidth):
       
 39109         * rendering/RenderTextControl.cpp:
       
 39110         (WebCore::RenderTextControl::calcPrefWidths):
       
 39111         * rendering/RenderTextControl.h:
       
 39112         * rendering/RenderView.cpp:
       
 39113         (WebCore::RenderView::RenderView):
       
 39114         (WebCore::RenderView::calcPrefWidths):
       
 39115         (WebCore::RenderView::layout):
       
 39116         * rendering/RenderView.h:
       
 39117         * rendering/RenderWidget.cpp:
       
 39118         (WebCore::RenderWidget::layout):
       
 39119         * rendering/RootInlineBox.cpp:
       
 39120         * rendering/RootInlineBox.h:
       
 39121         (WebCore::RootInlineBox::setHorizontalOverflowPositions):
       
 39122         (WebCore::RootInlineBox::setVerticalSelectionPositions):
       
 39123         * rendering/TableLayout.h:
       
 39124 
       
 39125 2007-04-24  Justin Garcia  <justin.garcia@apple.com>
       
 39126 
       
 39127         Reviewed by oliver
       
 39128         
       
 39129         <rdar://problem/5156401> 
       
 39130         Crash when dragging text into a link inside a table cell
       
 39131 
       
 39132         * editing/CompositeEditCommand.cpp:
       
 39133         (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
       
 39134         Don't avoid the anchor if doing so would skip over a line break, that
       
 39135         would put content in the wrong paragraph, which can throw ReplaceSelectionCommand,
       
 39136         which relies on moveParagraphs into infinite recursion.
       
 39137         Renamed the input position.
       
 39138         Don't need to re-fetch the enclosing anchor when preparing to push it down,
       
 39139         since it hasn't changed since the top of the function.
       
 39140 
       
 39141 2007-04-24  Timothy Hatcher  <timothy@apple.com>
       
 39142 
       
 39143         Reviewed by Adam.
       
 39144 
       
 39145         <rdar://problem/5133011> 64-bit: Attempting to paste copied text in a input field results in a crash at WebCore::Range::startPosition()
       
 39146 
       
 39147         Change a couple incorrect uses of LONG_MAX to INT_MAX to match the variable type they are used in.
       
 39148         The LONG_MAX on 64-bit was overflowing the int variables, causing this crash on paste.
       
 39149 
       
 39150         * bridge/mac/WebCoreAXObject.mm:
       
 39151         (-[WebCoreAXObject value]):
       
 39152         * editing/TextIterator.cpp:
       
 39153         (WebCore::TextIterator::handleTextNode):
       
 39154         (WebCore::TextIterator::handleTextBox):
       
 39155 
       
 39156 2007-04-24  Timothy Hatcher  <timothy@apple.com>
       
 39157 
       
 39158         Reviewed by Adam.
       
 39159 
       
 39160         <rdar://problem/4966982> 64-bit: In a unordered list, TYPE=DISC and TYPE=CIRCLE attribute values are ignored
       
 39161 
       
 39162         We need to draw our full-circle arcs counter-clockwise, since a clockwise arc from 0 to 2π is no arc at all!
       
 39163         This only worked on 32-bit due to a rounding error in CoreGraphics, causing it to draw a full circle anyway.
       
 39164 
       
 39165         * platform/graphics/cg/GraphicsContextCG.cpp:
       
 39166         (WebCore::GraphicsContext::drawEllipse):
       
 39167 
       
 39168 2007-04-24  Brady Eidson  <beidson@apple.com>
       
 39169 
       
 39170         Reviewed by Beth, Hyatt, Ada, and Darin
       
 39171 
       
 39172         <rdar://problem/5011477> and <rdar://problem/5011514>
       
 39173         Provide support for the icon.db to be moved to a different directory from the old WebKit-style
       
 39174         icons, and remove the old directory if that is the case
       
 39175 
       
 39176         Support for this starts in WebCore, where we can use the metadata table in the icon.db to track
       
 39177         whether or not we've ever done the import
       
 39178 
       
 39179         * WebCore.exp:
       
 39180         * loader/icon/IconDatabase.cpp:
       
 39181         (WebCore::IconDatabase::defaultDatabaseFilename): Changed to "Icons.db"
       
 39182         (WebCore::IconDatabase::IconDatabase):
       
 39183         (WebCore::IconDatabase::deleteAllPreparedStatements): Delete the new statements added
       
 39184         (WebCore::IconDatabase::imported): Grab this flag from the DB or return the cached flag
       
 39185         (WebCore::IconDatabase::setImported): Store this flag into the DB
       
 39186         (WebCore::IconDatabase::importedQuery): Actually do the DB query for this save
       
 39187         (WebCore::IconDatabase::setImportedQuery): Actually do the DB query for this retrieval
       
 39188         * loader/icon/IconDatabase.h:
       
 39189 
       
 39190 2007-04-24  Darin Adler  <darin@apple.com>
       
 39191 
       
 39192         Reviewed by Justin.
       
 39193 
       
 39194         - fix <rdar://problem/4356361> Selection after multiple delete
       
 39195           keypresses and undo selects only the last deleted character
       
 39196 
       
 39197         Test: editing/undo/undo-combined-delete-boundary.html
       
 39198         Test: editing/undo/undo-combined-delete.html
       
 39199         Test: editing/undo/undo-delete-boundary.html
       
 39200         Test: editing/undo/undo-delete.html
       
 39201         Test: editing/undo/undo-forward-delete-boundary.html
       
 39202         Test: editing/undo/undo-forward-delete.html
       
 39203 
       
 39204         * editing/TypingCommand.cpp:
       
 39205         (WebCore::TypingCommand::insertText): Fix obviously-wrong code where there were missing
       
 39206         braces. I couldn't find any real symptom of this, but I think the fix should go in anyway.
       
 39207         All layout tests still pass.
       
 39208         (WebCore::TypingCommand::deleteKeyPressed): Added code to compute a selection that goes
       
 39209         back to the beginning of the composite editing operation.
       
 39210         (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
       
 39211 
       
 39212         * editing/Selection.h:
       
 39213         * editing/Selection.cpp: (WebCore::Selection::setWithoutValidation):
       
 39214         Added. Back door to allow setting the ends of a selection without revalidating,
       
 39215         because we need to use it on a selection where the endpoints may no longer be
       
 39216         valid due to mutations done by earlier pieces of the editing operation.
       
 39217 
       
 39218         * editing/EditCommand.h:
       
 39219         (WebCore::EditCommand::startingSelection): Return a const& for speed.
       
 39220         (WebCore::EditCommand::endingSelection): Ditto.
       
 39221 
       
 39222 2007-04-24  Sam Weinig  <sam@webkit.org>
       
 39223 
       
 39224         Reviewed by Mitz.
       
 39225 
       
 39226         - fix for http://bugs.webkit.org/show_bug.cgi?id=13448
       
 39227           REGRESSION: setting an input element's value to JavaScript null gives "null"
       
 39228 
       
 39229         Test: fast/forms/input-null.html
       
 39230 
       
 39231         * html/HTMLInputElement.idl: Convert JS null to the empty string on setting
       
 39232         DOMString attributes.
       
 39233 
       
 39234 2007-04-24  Mitz Pettel  <mitz@webkit.org>
       
 39235 
       
 39236         Reviewed by Dave Hyatt.
       
 39237 
       
 39238         - fix http://bugs.webkit.org/show_bug.cgi?id=13453
       
 39239           Control clip isn't applied to children's backgrounds, outlines and floats
       
 39240 
       
 39241         Test: fast/forms/control-clip.html
       
 39242 
       
 39243         * rendering/RenderBlock.cpp:
       
 39244         (WebCore::RenderBlock::paint): Apply the clip in all phases that paint
       
 39245         children. Split PaintPhaseOutline and PaintPhaseChildBlockBackground into
       
 39246         two phases each, applying the clip only to the children.
       
 39247         * rendering/RenderListBox.cpp:
       
 39248         (WebCore::RenderListBox::paintObject): Treat the scrollbar as part of the
       
 39249         background rather than as a child's background, now that children are
       
 39250         clipped out.
       
 39251 
       
 39252 2007-04-24  Benjamin Otte  <otte@gnome.org>
       
 39253 
       
 39254         Reviewed by Mark Rowe.
       
 39255 
       
 39256         Gdk build system improvements.
       
 39257 
       
 39258         * make-generated-sources.sh: Exit with failure status if make fails.
       
 39259 
       
 39260 2007-04-24  Benjamin Otte  <otte@gnome.org>
       
 39261 
       
 39262         Reviewed by Mark Rowe.
       
 39263 
       
 39264         Gdk build system improvements.
       
 39265 
       
 39266         * Projects/gdk/webcore-gdk.bkl:
       
 39267         fail if running any of the commands failed. In particular
       
 39268         make-generated-sources.sh
       
 39269 
       
 39270 2007-04-23  Beth Dakin  <bdakin@apple.com>
       
 39271 
       
 39272         Reviewed by Adam.
       
 39273 
       
 39274         Fix for <rdar://problem/5155507> REGRESSION: Crash in 
       
 39275         RenderLayer::setHasVisibleContent()
       
 39276 
       
 39277         * rendering/RenderContainer.cpp:
       
 39278         (WebCore::RenderContainer::appendChildNode): Must null-check 
       
 39279         enclosingLayer()
       
 39280         (WebCore::RenderContainer::insertChildNode): Same.
       
 39281 
       
 39282 2007-04-23  David Hyatt  <hyatt@apple.com>
       
 39283 
       
 39284         Fix for bug 13337, deep tag nesting is slow.  This patch fixes a number of O(n^2) issues as well as making
       
 39285         a few performance optimizations based off profiling.  Details next to each change below.
       
 39286 
       
 39287         Note that calcMinMaxWidth being slow is a critical separate piece of this puzzle.  Until bug 13430 is fixed,
       
 39288         render tree construction will be O(n^2) (because of the minmaxrecalc bit setting being stupid enough to
       
 39289         always crawl to the root of the tree) and calcMinMaxWidth will waste tons of unnecessary time.
       
 39290 
       
 39291         When these fixes are combined with the calcMinMaxWidth fix in 13430, the penguin page specified in 13337
       
 39292         loads in < 2 seconds (down from an infinite hang before).
       
 39293 
       
 39294         Reviewed by aroben, ollie
       
 39295 
       
 39296         * css/cssstyleselector.cpp:
       
 39297         (WebCore::CSSStyleSelector::locateCousinList):
       
 39298         (WebCore::CSSStyleSelector::locateSharedStyle):
       
 39299         * css/csstyleselector.h
       
 39300         Cap the depth of cousin searching on the shared style optimization.  We will be willing to (at most) crawl
       
 39301         up the tree the same distance that we were willing to crawl backwards through sibling lists.  Leaving it
       
 39302         uncapped resulted in pathological style resolution for the case of an infinitely nested chain of singletons.
       
 39303 
       
 39304         * html/HTMLParser.cpp:
       
 39305         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
       
 39306         (WebCore::HTMLParser::popBlock):
       
 39307         Cap the number of residual style tags that we are willing to reopen.  We will reopen at most 200
       
 39308         residual style tags, since the assumption is that once that many tags are on the stack, you're probably already
       
 39309         every kind of bold, italic, and color of the rainbow.
       
 39310 
       
 39311         * rendering/RenderFlow.cpp:
       
 39312         (WebCore::RenderFlow::absoluteClippedOverflowRect):
       
 39313         absoluteClippedOverflowRect can just return the empty rect when the inline flow has no line boxes instead of
       
 39314         doing a bunch of work (and calling containingBlock()) for no reason.
       
 39315 
       
 39316         * rendering/RenderInline.cpp:
       
 39317         (WebCore::RenderInline::addChildToFlow):
       
 39318         Remove the useless containingBlock() check from addChildToFlow.  Obviously every inline's containing block
       
 39319         is a block flow.
       
 39320 
       
 39321         * rendering/bidi.cpp:
       
 39322         (WebCore::inlineWidth):
       
 39323         (WebCore::RenderBlock::createLineBoxes):
       
 39324         Cap the depth of individual line trees to 200.  Again the assumption is that once that many open inlines exist
       
 39325         all on one line that there's no way this would be intentional.
       
 39326 
       
 39327 2007-04-23  David Hyatt  <hyatt@apple.com>
       
 39328 
       
 39329         Fix for bug 13430, cap inline splitting for continuations to a maximum depth of 200.
       
 39330 
       
 39331         Reviewed by olliej, antti
       
 39332 
       
 39333         * rendering/RenderInline.cpp:
       
 39334         (WebCore::RenderInline::splitInlines):
       
 39335 
       
 39336 2007-04-23  Alp Toker  <alp@atoker.com>
       
 39337 
       
 39338         Gdk build fix. Track EventHandler change made in r21042.
       
 39339 
       
 39340         * page/gdk/EventHandlerGdk.cpp:
       
 39341         (WebCore::EventHandler::passWheelEventToWidget):
       
 39342         (WebCore::EventHandler::passMousePressEventToScrollbar):
       
 39343 
       
 39344 2007-04-23  Timothy Hatcher  <timothy@apple.com>
       
 39345 
       
 39346         Reviewed by Darin.
       
 39347 
       
 39348         <rdar://problem/5024945> -[DOMRange lineBoxRects] doesn't include start and end nodes that have offsets
       
 39349 
       
 39350         * rendering/RenderText.cpp:
       
 39351         (WebCore::RenderText::addLineBoxRects): Use min(box->len(), end) instead of special-casing UINT_MAX.
       
 39352 
       
 39353 2007-04-23  Adele Peterson  <adele@apple.com>
       
 39354 
       
 39355         Fix by Darin, reviewed by me.
       
 39356 
       
 39357         Fix for REGRESSION: Can't upload attachments to bugzilla since the file upload control is reset immediately 
       
 39358         http://bugs.webkit.org/show_bug.cgi?id=13461
       
 39359 
       
 39360         * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::updateFromElement):
       
 39361         Only clear the FileChooser if the value is empty *and* (not or) the filename is empty.
       
 39362 
       
 39363 2007-04-23  Adele Peterson  <adele@apple.com>
       
 39364 
       
 39365         Reviewed by Adam.
       
 39366 
       
 39367         Updated fix for <rdar://problem/4887426> Set a reasonable maximum number of recent searches for search menu
       
 39368 
       
 39369         * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Use a const int maxSavedResults instead of magic number 256.
       
 39370 
       
 39371 2007-04-23  Timothy Hatcher  <timothy@apple.com>
       
 39372 
       
 39373         Reviewed by Hyatt.
       
 39374 
       
 39375         <rdar://problem/5024945> -[DOMRange lineBoxRects] doesn't include start and end nodes that have offsets
       
 39376 
       
 39377         Don't call selectionRect with a -1 end position, instead use the text length.
       
 39378 
       
 39379         * rendering/RenderText.cpp:
       
 39380         (WebCore::RenderText::addLineBoxRects):
       
 39381 
       
 39382 2007-04-23  Adele Peterson  <adele@apple.com>
       
 39383 
       
 39384         Fixed and reviewed by Darin, Adele, and Oliver.
       
 39385 
       
 39386         WebCore part of fix for <rdar://problem/5107538> REGRESSION: Page scroll when selecting characters from inline input candidate window by arrow buttons
       
 39387         http://bugs.webkit.org/show_bug.cgi?id=13263
       
 39388 
       
 39389         * dom/KeyboardEvent.h: (WebCore::KeypressCommand::isEmpty): Added helper method.
       
 39390 
       
 39391 2007-04-23  Patti Hoa  <patti@apple.com>
       
 39392         
       
 39393         <rdar://problem/4938364> Attachment button has different string length between attributeStringForRange and stringForRange
       
 39394         <rdar://problem/4939536> AXLengthForTextMarkerRange returns zero length for the range of an attachment
       
 39395         
       
 39396         Reviewed by Darin.
       
 39397 
       
 39398         * bridge/mac/WebCoreAXObject.mm:
       
 39399         (nsStringForReplacedNode):
       
 39400         Added helper routine to check if the replaced node should be exposed as an attachment character in string representation.
       
 39401         Added an additional check to make sure that text node is not considered a replaced node.
       
 39402         Removed helper routine AXAttributedStringAppendReplaced since half of the functions are now taken care by nsStringForReplacedNode.
       
 39403         The other half is directly used in the doAXAttributedStringForTextMarkerRange method.
       
 39404         (-[WebCoreAXObject doAXStringForTextMarkerRange:]):
       
 39405         (-[WebCoreAXObject doAXAttributedStringForTextMarkerRange:]):
       
 39406         Both string and AttrbributedString methods will now utilize the helper routine nsStringForReplacedNode to return replacement
       
 39407         characters for range occupied by attachment.
       
 39408         
       
 39409 2007-04-23  Adele Peterson  <adele@apple.com>
       
 39410 
       
 39411         Reviewed by Oliver.
       
 39412 
       
 39413         Fix for <rdar://problem/4887426> Set a reasonable maximum number of recent searches for search menu
       
 39414 
       
 39415         * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
       
 39416         Enforce a maximum of 256 saved results for the search field.
       
 39417 
       
 39418 2007-04-23  Adele Peterson  <adele@apple.com>
       
 39419 
       
 39420         Reviewed by Hyatt & Adam.
       
 39421 
       
 39422         Fix for <rdar://problem/4807799> REGRESSION: calling select() in onSearch handler doesn't work if you hit enter to trigger the event
       
 39423         Fix for <rdar://problem/5153970> onChange doesn't fire when focusing a popup, using type-ahead to select, and leaving
       
 39424 
       
 39425         This previous behavior to blur controls when hitting enter was added to achieve the result of firing the change event.  Firefox does not
       
 39426         fire blur- just the change event, so this fix will match Firefox behavior.
       
 39427 
       
 39428         This also fixes a bug where we didn't fire the change event when using type-ahead selection with the popup menu.
       
 39429 
       
 39430         * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Fire change event instead of blur event when hitting enter.
       
 39431 
       
 39432         * html/HTMLSelectElement.cpp:
       
 39433         (WebCore::HTMLSelectElement::dispatchFocusEvent): Now that we have type-ahead selection for popups that can be opened with the arrow keys,
       
 39434          we should always save the last selection when a popup gets focus, so it can be compared to the current selection when it loses focus.
       
 39435         (WebCore::HTMLSelectElement::dispatchBlurEvent): For the same reasons as above, we should fire onChange for all popups on blur.
       
 39436 
       
 39437         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Fire change event instead of blur event when hitting enter.  Removed an unnecessary
       
 39438          check for form() before calling menuListOnChange().  Removed an unnecessary check for renderer() and usesMenuList().
       
 39439         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Remove call to blur.  Since list boxes fire the change event immediately after an
       
 39440          action is taken, we don't need to fire anything after hitting enter.
       
 39441         (WebCore::HTMLSelectElement::menuListOnChange): Reset m_lastOnChangeIndex after firing the change event.
       
 39442 
       
 39443 2007-04-23  Anders Carlsson  <andersca@apple.com>
       
 39444 
       
 39445         Reviewed by Ada.
       
 39446 
       
 39447         <rdar://problem/5061022>
       
 39448         REGRESSION: Acrobat 8 plug-in fails to scroll with trackpad two-finger scroll or mouse wheel (12995)
       
 39449         
       
 39450         Pass wheel events to all widgets.
       
 39451         
       
 39452         * page/EventHandler.cpp:
       
 39453         (WebCore::EventHandler::handleWheelEvent):
       
 39454         * page/EventHandler.h:
       
 39455         * page/mac/EventHandlerMac.mm:
       
 39456         (WebCore::EventHandler::passWheelEventToWidget):
       
 39457 
       
 39458 2007-04-23  Alp Toker  <alp@atoker.com>
       
 39459 
       
 39460         Reviewed by Mark.
       
 39461 
       
 39462         Save and restore the context state when beginning and ending a transparency layer.
       
 39463 
       
 39464         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
 39465         (WebCore::GraphicsContext::beginTransparencyLayer):
       
 39466         (WebCore::GraphicsContext::endTransparencyLayer):
       
 39467 
       
 39468 2007-04-23  Alp Toker  <alp@atoker.com>
       
 39469 
       
 39470         Reviewed by Mark.
       
 39471 
       
 39472         Further implementation and checks. The opacity layer code is not so beautiful
       
 39473         but gets the job done with fewer complications than maintaining our own stack.
       
 39474 
       
 39475         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
 39476         (WebCore::GraphicsContext::translate):
       
 39477         (WebCore::GraphicsContext::setPlatformStrokeThickness):
       
 39478         (WebCore::GraphicsContext::beginTransparencyLayer):
       
 39479         (WebCore::GraphicsContext::endTransparencyLayer):
       
 39480         (WebCore::GraphicsContext::setCompositeOperation):
       
 39481         (WebCore::GraphicsContext::rotate):
       
 39482         (WebCore::GraphicsContext::scale):
       
 39483 
       
 39484 2007-04-23  Darin Adler  <darin@apple.com>
       
 39485 
       
 39486         Reviewed by Hyatt.
       
 39487 
       
 39488         - rename box-sizing to -webkit-box-sizing
       
 39489           because of <rdar://problem/4667227> REGRESSION: Shifted table on page at
       
 39490           https://us.etrade.com/e/t/home (due to box-sizing)
       
 39491 
       
 39492         * css/CSSComputedStyleDeclaration.cpp:
       
 39493         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Rename.
       
 39494         * css/CSSPropertyNames.in: Ditto.
       
 39495         * css/cssparser.cpp: (WebCore::CSSParser::parseValue): Rename and take out comment
       
 39496         explaining why we aren't prefacing with -webkit.
       
 39497         * css/cssstyleselector.cpp:
       
 39498         (WebCore::CSSStyleSelector::applyProperty): Rename.
       
 39499         * css/html4.css: Rename.
       
 39500         * css/quirks.css: Rename.
       
 39501 
       
 39502 2007-04-23  Alp Toker  <alp@atoker.com>
       
 39503 
       
 39504         Reviewed by Hyatt.
       
 39505 
       
 39506         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
 39507         (WebCore::GraphicsContext::drawEllipse):
       
 39508         (WebCore::GraphicsContext::drawConvexPolygon):
       
 39509         Fix stroking and filling of ellipses and polygons.
       
 39510         * platform/graphics/cairo/ImageCairo.cpp:
       
 39511         (WebCore::BitmapImage::draw): Make use of a new GraphicsContext
       
 39512         function to simplify the code.
       
 39513         (WebCore::Image::drawPattern): Now implemented. This makes content
       
 39514         with tiled patterns (eg. CSS repeat) render correctly.
       
 39515         * platform/graphics/gdk/ImageGdk.cpp:
       
 39516         (WebCore::Image::drawPattern): Remove old stub.
       
 39517 
       
 39518 2007-04-22  Lars Naesbye Christensen  <lars@naesbye.dk>
       
 39519 
       
 39520         Reviewed by Tim Hatcher.
       
 39521 
       
 39522         Prettier, more modern 'cell' cursor
       
 39523         http://bugs.webkit.org/show_bug.cgi?id=13441
       
 39524         Also updates past ChangeLog entries to new email address
       
 39525 
       
 39526         * ChangeLog:
       
 39527         * ChangeLog-2006-12-31:
       
 39528         * Resources/cellCursor.png:
       
 39529 
       
 39530 2007-04-23  Mark Rowe  <mrowe@apple.com>
       
 39531 
       
 39532         Rubber-stamped by Hyatt.
       
 39533 
       
 39534         Rename cMaxPenderingSourceLengthInLowBandwidthDisplay to cMaxPendingSourceLengthInLowBandwidthDisplay.
       
 39535 
       
 39536         * loader/FrameLoader.cpp:
       
 39537         (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
       
 39538 
       
 39539 2007-04-22  Maciej Stachowiak  <mjs@apple.com>
       
 39540 
       
 39541         Reviewed by Darin and Geoff.
       
 39542 
       
 39543         - move most of Window's data members into a separate private object, to avoid needing
       
 39544         to use the oversize allocator for it
       
 39545         http://bugs.webkit.org/show_bug.cgi?id=13381
       
 39546         
       
 39547         It was the only remaining JSObject subclass to use the oversize
       
 39548         allocator on 32-bit platforms, and having oversize objects around
       
 39549         makes garbage collection slower so this would hurt performance
       
 39550         with many tabs/windows open.
       
 39551         
       
 39552         No significant effect on JS iBench.
       
 39553 
       
 39554         * bindings/js/kjs_events.cpp:
       
 39555         (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener):
       
 39556         (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener):
       
 39557         (KJS::JSEventListener::JSEventListener):
       
 39558         (KJS::JSEventListener::~JSEventListener):
       
 39559         (KJS::JSLazyEventListener::parseCode):
       
 39560         * bindings/js/kjs_window.cpp:
       
 39561         (KJS::WindowPrivate::WindowPrivate):
       
 39562         (KJS::Window::Window):
       
 39563         (KJS::Window::~Window):
       
 39564         (KJS::Window::location):
       
 39565         (KJS::Window::selection):
       
 39566         (KJS::Window::locationbar):
       
 39567         (KJS::Window::menubar):
       
 39568         (KJS::Window::personalbar):
       
 39569         (KJS::Window::statusbar):
       
 39570         (KJS::Window::toolbar):
       
 39571         (KJS::Window::scrollbars):
       
 39572         (KJS::Window::mark):
       
 39573         (KJS::Window::getValueProperty):
       
 39574         (KJS::Window::findJSEventListener):
       
 39575         (KJS::Window::findJSUnprotectedEventListener):
       
 39576         (KJS::Window::clearHelperObjectProperties):
       
 39577         (KJS::Window::clear):
       
 39578         (KJS::Window::setCurrentEvent):
       
 39579         (KJS::Window::setReturnValueSlot):
       
 39580         (KJS::Window::clearAllTimeouts):
       
 39581         (KJS::Window::installTimeout):
       
 39582         (KJS::Window::pauseTimeouts):
       
 39583         (KJS::Window::resumeTimeouts):
       
 39584         (KJS::Window::clearTimeout):
       
 39585         (KJS::Window::timerFired):
       
 39586         (KJS::Window::disconnectFrame):
       
 39587         (KJS::Window::jsEventListeners):
       
 39588         (KJS::Window::jsHTMLEventListeners):
       
 39589         (KJS::Window::jsUnprotectedEventListeners):
       
 39590         (KJS::Window::jsUnprotectedHTMLEventListeners):
       
 39591         * bindings/js/kjs_window.h:
       
 39592 
       
 39593 2007-04-22  David Hyatt  <hyatt@apple.com>
       
 39594 
       
 39595         Fix 1% regression on the PLT.  Make sure roundToDevicePixels does no
       
 39596         work when no scale is in effect.
       
 39597 
       
 39598         Reviewed by mjs
       
 39599 
       
 39600 2007-04-22  Darin Adler  <darin@apple.com>
       
 39601 
       
 39602         Reviewed by Oliver.
       
 39603 
       
 39604         - fix small things noticed while looking into a font subsitution bug
       
 39605 
       
 39606         * platform/Font.h: (WebCore::Font::operator==): Corrected a misleading comment.
       
 39607 
       
 39608         * platform/Font.cpp:
       
 39609         (WebCore::Font::Font): Initialize m_pageZero to 0 in the empty constructor instead
       
 39610         of leaving it uninitialized. Initialize m_fontList for tighter code. Remove unneeded
       
 39611         initialization of RefPtr members to 0. Changed the copy constructor to use initialization
       
 39612         for tighter code.
       
 39613         (WebCore::Font::operator=): Sorted to match the order from the header and the copy
       
 39614         constructor, and removed the uneeded self-assignment check.
       
 39615 
       
 39616 2007-04-22  Darin Adler  <darin@apple.com>
       
 39617 
       
 39618         Reviewed by Maciej.
       
 39619 
       
 39620         - fix http://bugs.webkit.org/show_bug.cgi?id=5196
       
 39621           <rdar://problem/4537384> input type=file fields with style=display:none do not post
       
 39622           their values (5196)
       
 39623 
       
 39624         - fix http://bugs.webkit.org/show_bug.cgi?id=8248
       
 39625           Can not clear file input field
       
 39626 
       
 39627         * manual-tests/clear-input-file.html: Added.
       
 39628 
       
 39629         * html/HTMLInputElement.cpp:
       
 39630         (WebCore::HTMLInputElement::appendFormData): Remove check that prevents submission of
       
 39631         form data when there is no renderer or the renderer is invisible. While well-intentioned,
       
 39632         the rule does not match the behavior of other web browsers.
       
 39633         (WebCore::HTMLInputElement::setValue): Instead of disallowing all value changes for file
       
 39634         type, allow changes to the empty string.
       
 39635         (WebCore::HTMLInputElement::storesValueSeparateFromAttribute): Made file type return true
       
 39636         for this. 1) The file type does store its value separate from the value attribute.
       
 39637         2) The code in setInputType() should do the right thing given this new value, according to
       
 39638         my inspection of the code. 3) The code in both reset() and setValue() will work properly
       
 39639         if this is true, which was the motivation for changing it.
       
 39640 
       
 39641         * platform/FileChooser.h: Added a clear function.
       
 39642         * platform/FileChooser.cpp: (WebCore::FileChooser::clear): Clear the filename and the icon.
       
 39643 
       
 39644         * rendering/RenderFileUploadControl.cpp:
       
 39645         (WebCore::RenderFileUploadControl::valueChanged): Used a local variable to make the code
       
 39646         a little bit more readable (and match the change below).
       
 39647         (WebCore::RenderFileUploadControl::updateFromElement): Used local variables a bit more in
       
 39648         the old code. Added code that will call clear on the FileChooser and repaint if the DOM
       
 39649         element has an empty value and the FileChooser does not.
       
 39650 
       
 39651 2007-04-22  Grace Kloba  <klobag@gmail.com>
       
 39652 
       
 39653         Reviewed by Hyatt.
       
 39654 
       
 39655         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12279
       
 39656         Implemented two pass loading. Enabled by WTF_USE_LOW_BANDWIDTH_DISPLAY flag.
       
 39657 
       
 39658         * dom/Document.cpp:
       
 39659         (WebCore::Document::Document): initialize member variable m_inLowBandwidthDisplay
       
 39660 
       
 39661         * dom/Document.h:
       
 39662         (WebCore::Document::haveStylesheetsLoaded): while in low bandwidth display mode, ignore pending style sheets
       
 39663         (WebCore::Document::setDocLoader):
       
 39664         (WebCore::Document::inLowBandwidthDisplay):
       
 39665         (WebCore::Document::setLowBandwidthDisplay):
       
 39666         * html/HTMLTokenizer.cpp:
       
 39667         (WebCore::HTMLTokenizer::scriptHandler): while in low bandwidth display mode, don't execute JavaScript
       
 39668 
       
 39669         * loader/Cache.cpp:
       
 39670         (WebCore::Cache::requestResource): while in low bandwidth display mode, don't let style sheet and JavaScript block
       
 39671 
       
 39672         * loader/CachedCSSStyleSheet.cpp:
       
 39673         (WebCore::CachedCSSStyleSheet::checkNotify): add notifyFinished() as client may need "this" pointer
       
 39674 
       
 39675         * loader/DocLoader.h:
       
 39676         (WebCore::DocLoader::replaceDocument):
       
 39677         * loader/FrameLoader.cpp:
       
 39678         (WebCore::FrameLoader::FrameLoader):
       
 39679         (WebCore::FrameLoader::requestFrame): while in low bandwidth display mode, don't load sub-frame
       
 39680         (WebCore::FrameLoader::stopLoading):
       
 39681         (WebCore::FrameLoader::begin): set to low bandwidth display mode if the top frame is HTML document
       
 39682         (WebCore::FrameLoader::write):
       
 39683         (WebCore::FrameLoader::endIfNotLoading):
       
 39684         (WebCore::FrameLoader::checkCompleted): while in low bandwidth display mode, don't set complete
       
 39685         (WebCore::FrameLoader::requestObject): while in low bandwidth display mode, don't care Object
       
 39686         (WebCore::FrameLoader::addLowBandwidthDisplayRequest):
       
 39687         (WebCore::FrameLoader::removeAllLowbandwidthDisplayRequests):
       
 39688         (WebCore::FrameLoader::notifyFinished):
       
 39689         (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
       
 39690         * loader/FrameLoader.h:
       
 39691         (WebCore::FrameLoader::FrameLoader::needToSwitchOutLowBandwidthDisplay):
       
 39692         (WebCore::FrameLoader::FrameLoader::setUseLowBandwidthDisplay):
       
 39693         (WebCore::FrameLoader::FrameLoader::useLowBandwidthDisplay):
       
 39694 
       
 39695 2007-04-22  Darin Adler  <darin@apple.com>
       
 39696 
       
 39697         Reviewed by Tim Hatcher.
       
 39698 
       
 39699         - fix http://bugs.webkit.org/show_bug.cgi?id=13439
       
 39700           4 problems found in dashboard-region parser and serializer
       
 39701 
       
 39702         Test: fast/css/dashboard-region-parser.html
       
 39703 
       
 39704         * css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
       
 39705         Fix code that overwrote each additional region with the previous one to
       
 39706         instead build a space-separated list. Check for the case of an identifier
       
 39707         that's invalid, since that's (accidentally) how we represent a region
       
 39708         value that doesn't have explicit top/right/bottom/left values. The old code
       
 39709         would end up writing out four spaces after the region type.
       
 39710 
       
 39711         * css/cssparser.cpp: (WebCore::CSSParser::parseDashboardRegions):
       
 39712         Fail to parse if there is something after the "none" identifier or after
       
 39713         the arguments inside the dashboard-region "function". Also replaced code
       
 39714         that produced a identifier with CSS_VAL_INVALID in a roundabout way with
       
 39715         code that does it explicitly.
       
 39716 
       
 39717 2007-04-22  Darin Adler  <darin@apple.com>
       
 39718 
       
 39719         Reviewed by Adele.
       
 39720 
       
 39721         - support for fix for <rdar://problem/5100240> REGRESSION: Control-O broken
       
 39722 
       
 39723         * dom/KeyboardEvent.h: Include a vector of command names in the KeypressCommand object
       
 39724         instead of a single command name.
       
 39725 
       
 39726 2007-04-22  Alexey Proskuryakov  <ap@webkit.org>
       
 39727 
       
 39728         Reviewed by Darin.
       
 39729 
       
 39730         http://bugs.webkit.org/show_bug.cgi?id=13115
       
 39731         REGRESSION: 1000% performance regression in DOM access by index, which was already slow
       
 39732 
       
 39733         * dom/NodeList.h: Move cached data into a separate class, so it can be shared.
       
 39734 
       
 39735         * dom/Node.h: Replace the set of registered NodeLists with a struct that also
       
 39736         contains a shared NodeList::Caches (so the size of Node doesn't change).
       
 39737 
       
 39738         * dom/NodeList.cpp:
       
 39739         (WebCore::NodeList::NodeList):
       
 39740         (WebCore::NodeList::~NodeList):
       
 39741         (WebCore::NodeList::recursiveLength):
       
 39742         (WebCore::NodeList::itemForwardsFromCurrent):
       
 39743         (WebCore::NodeList::itemBackwardsFromCurrent):
       
 39744         (WebCore::NodeList::recursiveItem):
       
 39745         (WebCore::NodeList::itemWithName):
       
 39746         (WebCore::NodeList::rootNodeChildrenChanged):
       
 39747         (WebCore::NodeList::NodeListInfo::NodeListInfo):
       
 39748         (WebCore::NodeList::NodeListInfo::reset):
       
 39749         * dom/ChildNodeList.cpp:
       
 39750         (WebCore::ChildNodeList::ChildNodeList):
       
 39751         (WebCore::ChildNodeList::length):
       
 39752         (WebCore::ChildNodeList::item):
       
 39753         (WebCore::ChildNodeList::nodeMatches):
       
 39754         * dom/ChildNodeList.h:
       
 39755         * dom/Node.cpp:
       
 39756         (WebCore::Node::childNodes):
       
 39757         (WebCore::Node::registerNodeList):
       
 39758         (WebCore::Node::unregisterNodeList):
       
 39759         (WebCore::Node::notifyLocalNodeListsAttributeChanged):
       
 39760         (WebCore::Node::notifyLocalNodeListsChildrenChanged):
       
 39761         Adjust for the above changes.
       
 39762 
       
 39763 2007-04-21  Mitz Pettel  <mitz@webkit.org>
       
 39764 
       
 39765         Reviewed by Darin.
       
 39766 
       
 39767         - fix http://bugs.webkit.org/show_bug.cgi?id=13391
       
 39768           REGRESSION (r18819): Incomplete repaint of button text
       
 39769 
       
 39770         Test: fast/repaint/control-clip.html
       
 39771 
       
 39772         Ignore controls' lightweight clip in repaint rect computation for now.
       
 39773 
       
 39774         * rendering/RenderBox.cpp:
       
 39775         (WebCore::RenderBox::computeAbsoluteRepaintRect):
       
 39776 
       
 39777 2007-04-21  Darin Adler  <darin@apple.com>
       
 39778 
       
 39779         Reviewed by Adam.
       
 39780 
       
 39781         - fix <rdar://problem/4816343> :-khtml-drag CSS pseudo-class changed to :-webkit-drag, need alias
       
 39782 
       
 39783         * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
       
 39784         Since Apple documentation claims "-khtml-drag" works, we need to keep it working,
       
 39785         so add it back as an alias.
       
 39786 
       
 39787 2007-04-21  Darin Adler  <darin@apple.com>
       
 39788 
       
 39789         Reviewed by Oliver.
       
 39790 
       
 39791         - fix <rdar://problem/4782422> REGRESSION: -[stringByEvaluatingJavaScriptFromString]
       
 39792           returns an empty string instead of nil for non-string results
       
 39793 
       
 39794         * page/mac/WebCoreFrameBridge.mm:
       
 39795         (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
       
 39796         Added a call to nsStringNilIfEmpty to restore the old behavior. It might be nice to
       
 39797         distinguish the empty string from a non-string result, but there's no obvious way
       
 39798         to do that, and for compatibility it's probably best to just restore the old
       
 39799         behavior instead.
       
 39800 
       
 39801 2007-04-21  David Hyatt  <hyatt@apple.com>
       
 39802 
       
 39803         Fix for bug 13432, determineFlowSpacing is O(n^2).
       
 39804 
       
 39805         Reviewed by aroben
       
 39806 
       
 39807         * rendering/InlineBox.cpp:
       
 39808         (WebCore::InlineBox::nextOnLineExists):
       
 39809         (WebCore::InlineBox::prevOnLineExists):
       
 39810         * rendering/InlineBox.h:
       
 39811         (WebCore::InlineBox::InlineBox):
       
 39812 
       
 39813 2007-04-21  Lamar Goddard <lamargoddard@gmail.com>
       
 39814 
       
 39815         Reviewed by Darin.
       
 39816 
       
 39817         Fix for http://bugs.webkit.org/show_bug.cgi?id=5262
       
 39818         <rdar://problem/5018778>
       
 39819         XMLSerializer drops Namespace information
       
 39820 
       
 39821         Updated WebCore::markup to output namespace information for elements/attributes whose namespace information
       
 39822         doesn't appear in its scope in the output.
       
 39823 
       
 39824         Added test case: fast/dom/serialize-nodes.xhtml
       
 39825 
       
 39826         * WebCore/editing/markup.cpp:
       
 39827         (WebCore::createMarkup(const Node*, ...)): Changed call to WebCore::markup to match parameters
       
 39828         (WebCore::markup): Changed recursive call to match tree structure, removed ASSERT and no longer needed includeSiblings parameter.
       
 39829         (WebCore::startMarkup): Added optional parameter to track namespaces in the current scope.
       
 39830         (WebCore::addNamespace): Function to add namespace information to markup.
       
 39831         (WebCore::shouldAddNamespaceAttr):
       
 39832         (WebCore::shouldAddNamespaceElem): Functions that test whether namespace information should be added for a given node.
       
 39833         * WebCore/dom/Document.idl:
       
 39834         (createElementNS):
       
 39835         (createAttributeNS):
       
 39836         (getElementsByTagNameNS): Added [ConvertNullToNullString] to namespaceURI parameter.
       
 39837         * WebCore/dom/Node.cpp:
       
 39838         (Node::getElementsByTagNameNS): removed test for namespaceURI being null as null can be a valid namespace.
       
 39839 
       
 39840 2007-04-21  Alexey Proskuryakov  <ap@webkit.org>
       
 39841 
       
 39842         Reviewed by Darin.
       
 39843 
       
 39844         http://bugs.webkit.org/show_bug.cgi?id=13300
       
 39845         Reproducible crash opening anekdot.ru
       
 39846 
       
 39847         * html/HTMLParser.cpp:
       
 39848         (WebCore::HTMLParser::HTMLParser):
       
 39849         (WebCore::HTMLParser::getNode):
       
 39850         (WebCore::HTMLParser::handleIsindex):
       
 39851         * html/HTMLParser.h:
       
 39852         Made HTMLParser::form a RefPtr, and renamed it to m_currentFormElement.
       
 39853         Made m_currentMapElement a RefPtr.
       
 39854 
       
 39855 2007-04-21  Mitz Pettel  <mitz@webkit.org>
       
 39856 
       
 39857         Reviewed by Darin.
       
 39858 
       
 39859         - fix http://bugs.webkit.org/show_bug.cgi?id=13353
       
 39860           REGRESSION (r20754-20766): Textarea does not resize when scrollbar is present
       
 39861 
       
 39862         Test: fast/overflow/hit-test-overflow-controls.html
       
 39863 
       
 39864         * page/EventHandler.cpp:
       
 39865         (WebCore::EventHandler::handleMouseMoveEvent): Avoid activating scrollbars
       
 39866         during layer resize.
       
 39867         * rendering/RenderBlock.cpp:
       
 39868         (WebCore::RenderBlock::isPointInOverflowControl): Renamed isPointInScrollbar
       
 39869         to this, to reflect that it returns true for points in the resize corner
       
 39870         as well. Changed it to call the layer to do the actual work.
       
 39871         (WebCore::RenderBlock::nodeAtPoint): Updated for the above rename.
       
 39872         * rendering/RenderBlock.h:
       
 39873         * rendering/RenderLayer.cpp:
       
 39874         (WebCore::RenderLayer::horizontalScrollbarWidget): Fixed typo in this function's
       
 39875         name (it was horizontaScrollbarWidget).
       
 39876         (WebCore::RenderLayer::hitTestOverflowControls): Added. Returns whether the
       
 39877         hit point is in one of the scrollbars or the resize corner, and updates the
       
 39878         platform scrollbar in the hit test result if a scrollbar was hit.
       
 39879         * rendering/RenderLayer.h:
       
 39880         * rendering/RenderListBox.cpp:
       
 39881         (WebCore::RenderListBox::isPointInOverflowControl): Rename.
       
 39882         * rendering/RenderListBox.h:
       
 39883 
       
 39884 2007-04-21  Mitz Pettel  <mitz@webkit.org>
       
 39885 
       
 39886         Reviewed by Darin.
       
 39887 
       
 39888         - fix http://bugs.webkit.org/show_bug.cgi?id=13417
       
 39889           Repro crash when the first argument to getMatchedCSSRules is not an element
       
 39890 
       
 39891         Test: fast/dom/Window/getMatchedCSSRules-null-crash.html
       
 39892 
       
 39893         * css/cssstyleselector.cpp:
       
 39894         (WebCore::CSSStyleSelector::styleRulesForElement): Added null check.
       
 39895 
       
 39896 2007-04-21  Mitz Pettel  <mitz@webkit.org>
       
 39897 
       
 39898         Reviewed by Darin.
       
 39899 
       
 39900         - fix http://bugs.webkit.org/show_bug.cgi?id=13416
       
 39901           Repro crash after referencing the user stylesheet from JavaScript
       
 39902 
       
 39903         No test included because DumpRenderTree does not support setting the user stylesheet.
       
 39904 
       
 39905         * css/cssstyleselector.cpp:
       
 39906         (WebCore::CSSStyleSelector::CSSStyleSelector):
       
 39907         (WebCore::CSSStyleSelector::~CSSStyleSelector):
       
 39908         * css/cssstyleselector.h: Made m_userSheet a RefPtr.
       
 39909 
       
 39910 2007-04-21  MorganL  <morganl.webkit@yahoo.com>
       
 39911 
       
 39912         Reviewed by Adam.
       
 39913 
       
 39914         NPObject should be forward declared using 'struct' instead of 'class'
       
 39915 
       
 39916         * page/Frame.h:
       
 39917 
       
 39918 2007-04-21  Alp Toker  <alp@atoker.com>
       
 39919 
       
 39920         Gdk build fix.
       
 39921 
       
 39922         * platform/gdk/FontPlatformDataGdk.cpp:
       
 39923         (WebCore::FontPlatformData::FontPlatformData): Use the correct casts.
       
 39924 
       
 39925 2007-04-20  Brady Eidson  <beidson@apple.com>
       
 39926 
       
 39927         Reviewed by Oliver (Black Sheep)
       
 39928 
       
 39929         <rdar://problem/3559794>
       
 39930         [WebView setMaintainsBackForwardList:] doesn't actually flush out the current page caches
       
 39931 
       
 39932         * WebCore.exp:
       
 39933         * history/BackForwardList.cpp:
       
 39934         (WebCore::BackForwardList::BackForwardList): Set the flag to true by default
       
 39935         (WebCore::BackForwardList::addItem): Check the flag and bail if its false
       
 39936         (WebCore::BackForwardList::setCapacity): More correct if it set the m_current to 
       
 39937           NoCurrentItemIndex if we're setting capacity to 0
       
 39938         (WebCore::BackForwardList::enabled): 
       
 39939         (WebCore::BackForwardList::setEnabled): If we're disabling, cycle capacity to 0 and 
       
 39940           back to flush things out
       
 39941         * history/BackForwardList.h: Add enabled(), setEnabled(bool), and m_enabled
       
 39942 
       
 39943 2007-04-20  David Hyatt  <hyatt@apple.com>
       
 39944 
       
 39945         Bug 13424, firstLineStyle and verticalPositionHint together take
       
 39946         33% of the time on the new tag nesting PLT.  Don't waste time even
       
 39947         looking for first-line styles if no stylesheet used them.
       
 39948 
       
 39949         Reviewed by beth
       
 39950 
       
 39951         * css/CSSGrammar.y:
       
 39952         * dom/Document.cpp:
       
 39953         (WebCore::Document::Document):
       
 39954         * dom/Document.h:
       
 39955         (WebCore::Document::usesFirstLineRules):
       
 39956         (WebCore::Document::setUsesFirstLineRules):
       
 39957         * rendering/RenderObject.cpp:
       
 39958         (WebCore::RenderObject::verticalPositionHint):
       
 39959         (WebCore::RenderObject::firstLineStyle):
       
 39960 
       
 39961 2007-04-20  Peter Kasting  <pkasting@google.com>
       
 39962 
       
 39963         Reviewed by Oliver.
       
 39964 
       
 39965         - fix http://bugs.webkit.org/show_bug.cgi?id=13420
       
 39966 
       
 39967         * platform/TextEncodingRegistry.cpp:
       
 39968         (WebCore::addToTextEncodingNameMap): Change a pointer comparison to a
       
 39969         strcmp(), since the strings here are not necessarily
       
 39970         pointer-equivalent.
       
 39971 
       
 39972 2007-04-20  Darin Adler  <darin@apple.com>
       
 39973 
       
 39974         Reviewed by Geoff Garen and John Sullivan.
       
 39975 
       
 39976         - fix <rdar://problem/4671964> document property on <iframe> elements causes problems for SAP application
       
 39977 
       
 39978         Test: fast/dom/iframe-document.html
       
 39979 
       
 39980         * bindings/js/kjs_html.h: Removed IFrameDocument.
       
 39981         * bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::iFrameGetter): Ditto.
       
 39982 
       
 39983 2007-04-19  Alp Toker  <alp@atoker.com>
       
 39984 
       
 39985         Reviewed by Mark.
       
 39986 
       
 39987         * platform/gdk/FontGdk.cpp:
       
 39988         (WebCore::Font::drawGlyphs):
       
 39989         * platform/gdk/FontPlatformDataGdk.cpp:
       
 39990         (WebCore::FontPlatformData::FontPlatformData): Fix font support in Gdk port.
       
 39991 
       
 39992 2007-04-19  David Hyatt  <hyatt@apple.com>
       
 39993 
       
 39994         Fix for bug 13208, implement word-break.  This patch produces a partial
       
 39995         implementation of word-break.  word-break: break-all is implemented.  In
       
 39996         addition, a custom value, word-break: break-word is added that is a hybrid
       
 39997         of word-wrap: break-word and word-break: break-all (and more useful than
       
 39998         either).
       
 39999 
       
 40000         Reviewed by beth
       
 40001 
       
 40002         Added fast/text/word-break.html
       
 40003 
       
 40004         * css/CSSComputedStyleDeclaration.cpp:
       
 40005         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 40006         * css/CSSPropertyNames.in:
       
 40007         * css/CSSValueKeywords.in:
       
 40008         * css/cssparser.cpp:
       
 40009         (WebCore::CSSParser::parseValue):
       
 40010         * css/cssstyleselector.cpp:
       
 40011         (WebCore::CSSStyleSelector::applyProperty):
       
 40012         * rendering/RenderStyle.cpp:
       
 40013         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
       
 40014         (WebCore::StyleRareInheritedData::operator==):
       
 40015         (WebCore::RenderStyle::diff):
       
 40016         * rendering/RenderStyle.h:
       
 40017         (WebCore::):
       
 40018         (WebCore::RenderStyle::breakWords):
       
 40019         (WebCore::RenderStyle::wordBreak):
       
 40020         (WebCore::RenderStyle::setWordBreak):
       
 40021         (WebCore::RenderStyle::initialWordBreak):
       
 40022         (WebCore::RenderStyle::initialWordWrap):
       
 40023         * rendering/RenderText.cpp:
       
 40024         (WebCore::RenderText::calcMinMaxWidthInternal):
       
 40025         * rendering/RenderTextControl.cpp:
       
 40026         (WebCore::RenderTextControl::createInnerTextStyle):
       
 40027         (WebCore::RenderTextControl::calcHeight):
       
 40028         * rendering/bidi.cpp:
       
 40029         (WebCore::RenderBlock::findNextLineBreak):
       
 40030 
       
 40031 2007-04-20  Mark Rowe  <mrowe@apple.com>
       
 40032 
       
 40033         Qt build fix for FreeBSD.
       
 40034 
       
 40035         * WebCore.pro: FreeBSD needs HAVE_PTHREAD_NP_H defined.
       
 40036 
       
 40037 2007-04-19  Mitz Pettel  <mitz@webkit.org>
       
 40038 
       
 40039         Reviewed by Darin.
       
 40040 
       
 40041         - fix http://bugs.webkit.org/show_bug.cgi?id=13403
       
 40042           REGRESSION (r18875-r18899): Can no longer type into search form field after searching and then clicking "back"
       
 40043 
       
 40044         The problem was that the page was loaded from the page cache with a subtree
       
 40045         marked for layout and the layout timer stopped (having been stopped when the
       
 40046         page entered the page cache). FrameView::needsLayout() was returning false
       
 40047         which prevented the pending layout from completing.
       
 40048 
       
 40049         * page/FrameView.cpp:
       
 40050         (WebCore::FrameView::clear): Removed the call to stop the layout timer, since
       
 40051         reset() does that already.
       
 40052         (WebCore::FrameView::needsLayout): Changed to return true if there's a subtree
       
 40053         pending relayout.
       
 40054 
       
 40055 2007-04-19  Justin Garcia  <justin.garcia@apple.com>
       
 40056 
       
 40057         Reviewed by harrison
       
 40058         
       
 40059         <rdar://problem/5144139> 
       
 40060         On delete, <BR> inserted into non-editable ToDo <TABLE> element
       
 40061         
       
 40062         The fact that the br was being inserted at a bad position 
       
 40063         (a non-editable position and one inside a table instead of 
       
 40064         before it) was fixed in the previous checkin. This change 
       
 40065         stops us from inserting a br at all, to fix the bug.
       
 40066         
       
 40067         After a delete, we need a placeholder if the selection
       
 40068         started at the start of a paragraph and ended at the end 
       
 40069         of a paragraph. But not if it starts just before a table 
       
 40070         and ends inside that table.  We need placeholders to hold 
       
 40071         open emptied out table cells, but that is handled separately.
       
 40072         
       
 40073         Also, moved lineBreakExistsAtPosition to htmlediting.cpp 
       
 40074         so that it can be used in more places.
       
 40075 
       
 40076         * editing/CompositeEditCommand.cpp:
       
 40077         (WebCore::CompositeEditCommand::removePlaceholderAt):
       
 40078         (WebCore::CompositeEditCommand::moveParagraphs):
       
 40079         * editing/DeleteSelectionCommand.cpp:
       
 40080         (WebCore::DeleteSelectionCommand::doApply):
       
 40081         * editing/InsertLineBreakCommand.cpp:
       
 40082         * editing/InsertParagraphSeparatorCommand.cpp:
       
 40083         (WebCore::InsertParagraphSeparatorCommand::doApply):
       
 40084         * editing/htmlediting.cpp:
       
 40085         (WebCore::lineBreakExistsAtPosition):
       
 40086         * editing/htmlediting.h:
       
 40087 
       
 40088 2007-04-19  Justin Garcia  <justin.garcia@apple.com>
       
 40089 
       
 40090         Reviewed by harrison
       
 40091         
       
 40092         Fixes some issues found while investigating:
       
 40093         <rdar://problem/5144139> On delete, <BR> inserted into non-editable ToDo <TABLE> element
       
 40094         
       
 40095         Move the code to handle inserting content before/after
       
 40096         tables for [table, 0/max] to insertNodeAt, so that
       
 40097         all insertions get it, not just some.
       
 40098         Changed insertNodeAt to take in a position instead of a
       
 40099         node and an offset.
       
 40100 
       
 40101         * editing/CompositeEditCommand.cpp:
       
 40102         (WebCore::CompositeEditCommand::insertNodeAt):
       
 40103         (WebCore::CompositeEditCommand::insertNodeAtTabSpanPosition):
       
 40104         (WebCore::CompositeEditCommand::insertBlockPlaceholder):
       
 40105         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
       
 40106         If paragrahStart.node() is an atomic node, insertNodeAt can handle
       
 40107         insertion, we don't need to special case it.
       
 40108         (WebCore::CompositeEditCommand::moveParagraphs):
       
 40109         (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
       
 40110         * editing/CompositeEditCommand.h:
       
 40111         * editing/DeleteSelectionCommand.cpp:
       
 40112         (WebCore::DeleteSelectionCommand::mergeParagraphs):
       
 40113         (WebCore::DeleteSelectionCommand::doApply):
       
 40114         * editing/FormatBlockCommand.cpp:
       
 40115         (WebCore::FormatBlockCommand::doApply):
       
 40116         * editing/IndentOutdentCommand.cpp:
       
 40117         (WebCore::IndentOutdentCommand::indentRegion):
       
 40118         (WebCore::IndentOutdentCommand::outdentParagraph):
       
 40119         * editing/InsertLineBreakCommand.cpp:
       
 40120         (WebCore::InsertLineBreakCommand::doApply):
       
 40121         * editing/InsertListCommand.cpp:
       
 40122         (WebCore::InsertListCommand::doApply):
       
 40123         * editing/InsertParagraphSeparatorCommand.cpp:
       
 40124         (WebCore::InsertParagraphSeparatorCommand::doApply):
       
 40125         * editing/InsertTextCommand.cpp:
       
 40126         (WebCore::InsertTextCommand::prepareForTextInsertion): Removed some
       
 40127         dead code that handled insertion at non-editable positions.
       
 40128         (WebCore::InsertTextCommand::insertTab):
       
 40129         * editing/ReplaceSelectionCommand.cpp:
       
 40130         (WebCore::ReplaceSelectionCommand::doApply):
       
 40131         (WebCore::ReplaceSelectionCommand::insertNodeAtAndUpdateNodesInserted):
       
 40132         * editing/ReplaceSelectionCommand.h:
       
 40133 
       
 40134 2007-04-19  Mitz Pettel  <mitz@webkit.org>
       
 40135 
       
 40136         Reviewed by Darin.
       
 40137 
       
 40138         - fix http://bugs.webkit.org/show_bug.cgi?id=13336
       
 40139           REGRESSION (r20646): editing/execCommand/hilitecolor.html crashes under guardMalloc
       
 40140 
       
 40141         Avoid calling selectionRect() and selectionGapRects() on a renderer that needs
       
 40142         layout.
       
 40143 
       
 40144         * rendering/RenderBlock.cpp:
       
 40145         (WebCore::RenderBlock::selectionGapRects):
       
 40146         * rendering/RenderBlock.h:
       
 40147         (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
       
 40148         * rendering/RenderListMarker.cpp:
       
 40149         (WebCore::RenderListMarker::selectionRect):
       
 40150         * rendering/RenderObject.h:
       
 40151         (WebCore::RenderObject::SelectionInfo::SelectionInfo):
       
 40152         * rendering/RenderReplaced.cpp:
       
 40153         (WebCore::RenderReplaced::selectionRect):
       
 40154         * rendering/RenderText.cpp:
       
 40155         (WebCore::RenderText::selectionRect):
       
 40156 
       
 40157 2007-04-19  Justin Garcia  <justin.garcia@apple.com>
       
 40158 
       
 40159         Reviewed by darin
       
 40160 
       
 40161         <rdar://problem/5142012> 
       
 40162         GoogleDocs: Crash at WebCore::Range::startPosition() when creating a list from a link
       
 40163         
       
 40164         List creation uses moveParagraphs to push content into list items.
       
 40165         Its fragment creation (using createMarkup) incorrectly uses regular
       
 40166         spaces instead of nbsps for spaces that were rendered (11475), which 
       
 40167         causes spaces to be collapsed during the move operation.  This results 
       
 40168         in a call to rangeFromLocationAndLength with a location past the end
       
 40169         of the document.  We use the result from rangeFromLocationAndLength
       
 40170         (null) and crash.
       
 40171         
       
 40172         Also when moveParagraphs tries to push content into a list item surrounded
       
 40173         by an anchor, it fails because positionAvoidingSpecialElementBoundary avoids 
       
 40174         the anchor, which also avoids the list item.  This was fixed by pushing
       
 40175         down anchors before avoiding them.
       
 40176         
       
 40177         * editing/CompositeEditCommand.cpp:
       
 40178         (WebCore::CompositeEditCommand::pushAnchorElementDown): Remove the
       
 40179         old anchor after we push down clones of it, this is what callers
       
 40180         expect.
       
 40181         (WebCore::CompositeEditCommand::pushPartiallySelectedAnchorElementsDown):
       
 40182         Call the new enclosingAnchorElement, that takes in a position instead
       
 40183         of a node.
       
 40184         (WebCore::CompositeEditCommand::moveParagraphs): If spaces collapsed
       
 40185         as a result of the move, rangeFromLocationAndLength can return null,
       
 40186         bail and don't try to preserve the selection in that case.
       
 40187         (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
       
 40188         Moved from htmlediting.cpp.
       
 40189         Make sure anchors are pushed down before avoiding them so that we don't
       
 40190         also avoid structural elements like lists and blocks.
       
 40191         * editing/CompositeEditCommand.h:
       
 40192         * editing/TypingCommand.cpp: Moved isFirst/LastPositionBefore/AfterTable
       
 40193         to htmlediting.cpp.
       
 40194         * editing/htmlediting.cpp:
       
 40195         Moved positionAvoidingSpecialElementBoundary so that it could call
       
 40196         pushAnchorElementDown.
       
 40197         (WebCore::isFirstPositionAfterTable): Moved here.
       
 40198         (WebCore::isLastPositionBeforeTable): Moved here.
       
 40199         (WebCore::enclosingAnchorElement): Moved here.
       
 40200         (WebCore::enclosingListChild): Removed an extraneous space.
       
 40201         * editing/htmlediting.h:
       
 40202 
       
 40203 2007-04-19  Beth Dakin  <bdakin@apple.com>
       
 40204 
       
 40205         Reviewed by Hyatt.
       
 40206 
       
 40207         Fix for <rdar://problem/5120889> Sized table cells w/borders not 
       
 40208         drawn to correct size
       
 40209 
       
 40210         When table cells have children with %-height, the cells were 
       
 40211         incorrectly shrinking down to be the size of the child. This 
       
 40212         exposed another problem with replaced children and sizing.
       
 40213 
       
 40214         * rendering/RenderBox.cpp:
       
 40215         (WebCore::RenderBox::calcReplacedHeightUsing): The exposed problem. 
       
 40216         Subtract our borders and padding in the auto or percent table cell 
       
 40217         containing block case.
       
 40218         * rendering/RenderTableSection.cpp:
       
 40219         (WebCore::RenderTableSection::layoutRows): When our children can 
       
 40220         flex, do not always set the cellTopExtra and cellBottomExtra to 0! 
       
 40221         That is bad! We should do the same as the non-flex case.
       
 40222 
       
 40223 2007-04-19  Anders Carlsson  <andersca@apple.com>
       
 40224 
       
 40225         Reviewed by Geoff.
       
 40226 
       
 40227         http://bugs.webkit.org/show_bug.cgi?id=13333
       
 40228         Support naturalWidth/naturalHeight on image elements
       
 40229 
       
 40230         * html/HTMLImageElement.cpp:
       
 40231         (WebCore::HTMLImageElement::naturalWidth):
       
 40232         (WebCore::HTMLImageElement::naturalHeight):
       
 40233         * html/HTMLImageElement.h:
       
 40234         * html/HTMLImageElement.idl:
       
 40235 
       
 40236 2007-04-19  Patti Hoa  <patti@apple.com>
       
 40237 
       
 40238         Reviewed by Darin.
       
 40239         - review suggestion for rdar://5145011 code change
       
 40240         
       
 40241         * bridge/mac/WebCoreAXObject.mm:
       
 40242         (-[WebCoreAXObject value]):
       
 40243         return early if value attribute is not supported by the attachment view.
       
 40244 
       
 40245 2007-04-19  Patti Hoa  <patti@apple.com>
       
 40246 
       
 40247         Reviewed by Darin.
       
 40248 
       
 40249         <rdar://problem/5145011> Allow attachment view of web object to handle accessibility actions
       
 40250         
       
 40251         * bridge/mac/WebCoreAXObject.mm:
       
 40252         (-[WebCoreAXObject value]):
       
 40253         Only allow asking the attachmentView for value if attachmentView supports this value attribute 
       
 40254         (-[WebCoreAXObject title]):
       
 40255         (-[WebCoreAXObject accessibilityAttributeNames]):
       
 40256         Should not return that long list of unrelated attributes for attachmentView.
       
 40257         (-[WebCoreAXObject accessibilityActionNames]):
       
 40258         (-[WebCoreAXObject accessibilityPerformAction:]):
       
 40259         Allow attachmentView a chance to handle actions.
       
 40260         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
       
 40261         Should not return that long list of unrelated attributes for attachmentView.
       
 40262         
       
 40263 2007-04-19  Mitz Pettel  <mitz@webkit.org>
       
 40264 
       
 40265         Reviewed by Hyatt.
       
 40266 
       
 40267         - fix http://bugs.webkit.org/show_bug.cgi?id=13291
       
 40268           REGRESSION (r19595): WebViewDidBeginEditingNotification not posted when focusing with the mouse
       
 40269 
       
 40270         Covered by editing tests.
       
 40271 
       
 40272         * dom/Document.cpp:
       
 40273         (WebCore::Document::setFocusedNode): Moved the call to Editor::didBeginEditing()
       
 40274         back into here.
       
 40275         * dom/Element.cpp:
       
 40276         (WebCore::Element::updateFocusAppearance): Removed the call to didBeginEditing().
       
 40277         * html/HTMLInputElement.cpp:
       
 40278         (WebCore::HTMLInputElement::updateFocusAppearance): Ditto.
       
 40279 
       
 40280 2007-04-19  Sam Weinig  <sam@webkit.org>
       
 40281 
       
 40282         Reviewed by Darin.
       
 40283 
       
 40284         - Patch for http://bugs.webkit.org/show_bug.cgi?id=12249
       
 40285           FCKeditor: <hr>, <ul> and <ol> have id="undefined"
       
 40286 
       
 40287         Convert undefined and null to a null string for third argument of
       
 40288         execCommand(); 
       
 40289 
       
 40290         Test: editing/execCommand/arguments-combinations.html
       
 40291 
       
 40292         * WebCore.xcodeproj/project.pbxproj:
       
 40293         * bindings/js/kjs_binding.cpp:
       
 40294         (KJS::valueToStringWithUndefinedOrNullCheck):
       
 40295         * bindings/js/kjs_binding.h:
       
 40296         * bindings/scripts/CodeGeneratorJS.pm:
       
 40297         * dom/Document.idl:
       
 40298 
       
 40299 2007-04-19  Alp Toker  <alp@atoker.com>
       
 40300 
       
 40301         Reviewed by hyatt.
       
 40302 
       
 40303         * WebCoreSources.bkl: Remove obsolete source file from build.
       
 40304 
       
 40305 2007-04-18  Alp Toker  <alp@atoker.com>
       
 40306 
       
 40307         Gdk build fix.  Reviewed by Sam Weinig.
       
 40308 
       
 40309         Track changes to make GdkLauncher work again.
       
 40310 
       
 40311         * WebCoreSources.bkl:
       
 40312         * platform/gdk/ChromeClientGdk.h:
       
 40313         * platform/gdk/TemporaryLinkStubs.cpp:
       
 40314         (ChromeClientGdk::createWindow):
       
 40315         (ChromeClientGdk::createModalDialog):
       
 40316         (Editor::markBadGrammar):
       
 40317 
       
 40318 2007-04-17  Brady Eidson  <beidson@apple.com>
       
 40319 
       
 40320         Reviewed by Tim
       
 40321 
       
 40322         <rdar://problem/5008925>
       
 40323         Expose the NSURLConnection delegate willCacheResponse API to WebResourceLoadDelegate
       
 40324 
       
 40325         * WebCore.xcodeproj/project.pbxproj: Added ResourceLoaderMac.mm
       
 40326 
       
 40327         * loader/FrameLoaderClient.h: Add the willCacheResponse SPI for WebKit to implement
       
 40328 
       
 40329         * loader/ResourceLoader.h:
       
 40330         * loader/mac/ResourceLoaderMac.mm: Added.
       
 40331         (WebCore::ResourceLoader::willCacheResponse): Return the new cachedResponse from the client
       
 40332 
       
 40333         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 40334         (WebCore::SVGEmptyFrameLoaderClient::willCacheResponse): Stub
       
 40335 
       
 40336         * platform/network/ResourceHandleClient.h:
       
 40337         (WebCore::ResourceHandleClient::willCacheResponse):  Return the new cachedResponse from the client
       
 40338 
       
 40339         * platform/network/mac/ResourceHandleMac.mm:
       
 40340         (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Call to get the new 
       
 40341           cachedURLResponse before calling for the cache policy
       
 40342 
       
 40343 2007-04-18  Darin Adler  <darin@apple.com>
       
 40344 
       
 40345         Reviewed by Hyatt.
       
 40346 
       
 40347         - fix http://bugs.webkit.org/show_bug.cgi?id=13375
       
 40348           REGRESSION (r20901): failing fast/overflow/scrollRevealButton.html
       
 40349 
       
 40350         * dom/Document.cpp: (WebCore::Document::updateLayout):
       
 40351         If we have a parent frame, update its layout too.
       
 40352 
       
 40353 2007-04-18  Alp Toker  <alp@atoker.com>
       
 40354 
       
 40355         Gdk build fix.  Reviewed by Mark.
       
 40356 
       
 40357         * loader/gdk/FrameLoaderClientGdk.cpp:
       
 40358         (WebCore::FrameLoaderClientGdk::loadedFromCachedPage):
       
 40359         (WebCore::FrameLoaderClientGdk::setDocumentViewFromCachedPage):
       
 40360         (WebCore::FrameLoaderClientGdk::saveDocumentViewToCachedPage):
       
 40361         * loader/gdk/FrameLoaderClientGdk.h:
       
 40362         * platform/gdk/TemporaryLinkStubs.cpp:
       
 40363         (CachedPage::close): Track PageCache to CachedPage refactoring.
       
 40364 
       
 40365 2007-04-17  Mitz Pettel  <mitz@webkit.org>
       
 40366 
       
 40367         Reviewed by Darin.
       
 40368 
       
 40369         - fix http://bugs.webkit.org/show_bug.cgi?id=13369
       
 40370           REGRESSION (r13366): Invisible table cell background is painted
       
 40371 
       
 40372         Test: fast/table/invisible-cell-background.html
       
 40373 
       
 40374         * rendering/RenderTableCell.cpp:
       
 40375         (WebCore::RenderTableCell::paintBackgroundsBehindCell): Don't paint any
       
 40376         background if the cell is not visible. This behavior matches WinIE and Opera.
       
 40377 
       
 40378 2007-04-17  Justin Garcia  <justin.garcia@apple.com>
       
 40379 
       
 40380         Reviewed by harrison
       
 40381 
       
 40382         <rdar://problem/5119244> 
       
 40383         Crash when indenting a selected ToDo
       
 40384         
       
 40385         indentRegion() was using the old (incorrect) editable root 
       
 40386         getter, which returned null for a valid, editable position, 
       
 40387         causing the crash.
       
 40388 
       
 40389         * editing/IndentOutdentCommand.cpp:
       
 40390         (WebCore::IndentOutdentCommand::indentRegion):
       
 40391         The editable root for a position is editableRootForPosition(p),
       
 40392         not p.node()->rootEditableElement(), because of VisiblePositions 
       
 40393         before/after tables, replaced elements and others.
       
 40394 
       
 40395 2007-04-17  Justin Garcia  <justin.garcia@apple.com>
       
 40396 
       
 40397         Reviewed by hyatt
       
 40398 
       
 40399         <rdar://problem/5138441> 
       
 40400         GoogleDocs: Indented text looks like text that's been Quoted
       
 40401         
       
 40402         GoogleDocs uses FormatBlock, blockquotes and a style rule
       
 40403         for blockquotes to implement a "Quote Text" feature.  Styles
       
 40404         intended only for those blockquotes were added to the 
       
 40405         blockquotes that we use for indenting.
       
 40406 
       
 40407         * css/html4.css: Removed the webkit-indent-blockquote class rule.
       
 40408         * editing/IndentOutdentCommand.cpp:
       
 40409         (WebCore::createIndentBlockquoteElement): Use custom margins
       
 40410         and turn off border and padding to override author rules for
       
 40411         blockquotes.
       
 40412 
       
 40413 2007-04-17  Justin Garcia  <justin.garcia@apple.com>
       
 40414 
       
 40415         Reviewed by darin
       
 40416 
       
 40417         <rdar://problem/5136770> 
       
 40418         Gmail Editor: Hang when turning a particular multi-line selection into a list
       
 40419         
       
 40420         When InsertListCommand pushes content into list items, 
       
 40421         it creates an empty list item and then calls moveParagraphs.  
       
 40422         But moveParagraphs' selection preservation code fails when 
       
 40423         it encounters empty list items (list items w/o placeholders).
       
 40424         This causes InsertListCommand to lose track of where it has 
       
 40425         already been performed, which causes the hang.
       
 40426 
       
 40427         * editing/InsertListCommand.cpp:
       
 40428         (WebCore::InsertListCommand::doApply): Use brs to hold open 
       
 40429         empty list items.
       
 40430 
       
 40431 2007-04-17  Darin Adler  <darin@apple.com>
       
 40432 
       
 40433         Oops, rolled that last change out. I'll redo it again later after making
       
 40434         som additional refinments.
       
 40435 
       
 40436 2007-04-17  Darin Adler  <darin@apple.com>
       
 40437 
       
 40438         Reviewed by Brady.
       
 40439 
       
 40440         - a few baby steps to try to make lockHistory and userGesture less confusing
       
 40441 
       
 40442         * page/FrameLoadRequest.h:
       
 40443         (WebCore::FrameLoadRequest::FrameLoadRequest): Add initialization of m_isUserGesture
       
 40444         to true.
       
 40445         (WebCore::FrameLoadRequest::shouldLockHistory): Renamed from lockHistory to avoid having
       
 40446         a getter that sounds like a verb phrase.
       
 40447         (WebCore::FrameLoadRequest::setShouldLockHistory): Ditto.
       
 40448         (WebCore::FrameLoadRequest::isUserGesture): Added.
       
 40449         (WebCore::FrameLoadRequest::setIsUserGesture): Ditto.
       
 40450 
       
 40451         * loader/FrameLoader.h: Remove userGesture parameter from load that takes
       
 40452         FrameLoadRequest. Remove default values for lockHistory and userGesture parameters,
       
 40453         since that just makes it more likely we'll forget to pass them in. Remove one of
       
 40454         the overloads of urlSelected, since it's only called one place.
       
 40455 
       
 40456         * loader/FrameLoader.cpp:
       
 40457         (WebCore::FrameLoader::createWindow): Remove userGesture parameter, relying on
       
 40458         the true default in FrameLoadRequest.
       
 40459         (WebCore::FrameLoader::urlSelected): Call setShouldLockHistory and setIsUserGesture
       
 40460         on the FrameLoadRequest, and call load directly; also eliminate the other urlSelected
       
 40461         overload since this was the only place it was called.
       
 40462         (WebCore::FrameLoader::load): Remove userGesture parameter, relying on the true
       
 40463         default in FrameLoadRequest. In the other overload, clean up logic to eliminate the
       
 40464         argsReferrer variable and get rid of the userGesture parameter, using the value from
       
 40465         FrameLoadRequest.
       
 40466         (WebCore::FrameLoader::submitForm): Remove userGesture parameter, relying on the value
       
 40467         in the FrameLoadRequest. This actually changes behavior.
       
 40468 
       
 40469         * bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::putValueProperty): Pass
       
 40470         false for userGesture explicitly instead of relying on default argument.
       
 40471 
       
 40472         * page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
       
 40473         Remove userGesture parameter, relying on the true default in FrameLoadRequest.
       
 40474 
       
 40475 2007-04-16  David Kilzer  <ddkilzer@webkit.org>
       
 40476 
       
 40477         Reviewed by NOBODY (fixed misspelling).
       
 40478 
       
 40479         * manual-tests/containing-block-position-chage.html: Removed.
       
 40480         * manual-tests/containing-block-position-change.html: Added.
       
 40481 
       
 40482 2007-04-16  Justin Garcia  <justin.garcia@apple.com>
       
 40483 
       
 40484         Reviewed by darin
       
 40485 
       
 40486         <rdar://problem/5134759> 
       
 40487         GMail Editor: Hang after pasting underlined text multiple times
       
 40488         
       
 40489         The moveParagraphs call that ReplaceSelectionCommand
       
 40490         performs must receive only inline content from createMarkup, 
       
 40491         or else it will result in another call to moveParagraphs 
       
 40492         when it performs the move, resulting in infinite recursion.
       
 40493 
       
 40494         * editing/markup.cpp:
       
 40495         (WebCore::startMarkup): We were only converting a block to
       
 40496         an inline if it had an inline style declaration or styles 
       
 40497         coming from matched rules.  Cleaned up this code a bit by 
       
 40498         handling an element's style separately from its other 
       
 40499         attributes.
       
 40500 
       
 40501 2007-04-16  Darin Adler  <darin@apple.com>
       
 40502 
       
 40503         - get layout tests going again
       
 40504 
       
 40505         * page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry):
       
 40506         Replace assertion with a runtime check. We can consider changing it back to
       
 40507         an assertion some day, but it's not important.
       
 40508 
       
 40509 2007-04-16  Darin Adler  <darin@apple.com>
       
 40510 
       
 40511         Reviewed by John Sullivan.
       
 40512 
       
 40513         - fix http://bugs.webkit.org/show_bug.cgi?id=13303
       
 40514           <rdar://problem/5126341> REGRESSION: controls in a background Safari window
       
 40515           maintain active appearance if the address bar has focus (13303)
       
 40516 
       
 40517         - fix a related problem where elements could look focused in non-active windows
       
 40518 
       
 40519         - simplify secure keyboard entry logic in Frame::setIsActive
       
 40520 
       
 40521         * WebCore.exp: Add two new symbols for use by WebKit.
       
 40522 
       
 40523         * html/HTMLInputElement.cpp:
       
 40524         (WebCore::HTMLInputElement::dispatchFocusEvent): Call setUseSecureKeyboardEntryWhenActive
       
 40525         rather than calling setSecureKeyboardEntry directly -- does nothing if the frame is not active.
       
 40526         (WebCore::HTMLInputElement::dispatchBlurEvent): Ditto.
       
 40527 
       
 40528         * page/Frame.cpp:
       
 40529         (WebCore::Frame::setUseSecureKeyboardEntryWhenActive): Added. Calls
       
 40530         setUseSecureKeyboardEntry only if the frame is active, but also stores away the state,
       
 40531         so that the setIsActive function doesn't have to recompute it.
       
 40532         (WebCore::Frame::setIsActive): Rewrote all the comments in the function. Removed the code
       
 40533         to manage control tints, which are not based on the whether the frame is active but rather
       
 40534         on AppKit's concept of whether the window should have "key appearance". Simplified the
       
 40535         logic about when to call setUseSecureKeyboardEntry by using the value of
       
 40536         m_useSecureKeyboardEntryWhenActive.
       
 40537         (WebCore::FramePrivate::FramePrivate): Initialize m_useSecureKeyboardEntryWhenActive.
       
 40538         * page/Frame.h: Made setSecureKeyboardEntry private and renamed it to
       
 40539         setUseSecureKeyboardEntry, removed isSecureKeyboardEntry, and
       
 40540         added a public setUseSecureKeyboardEntryWhenActive.
       
 40541         * page/FramePrivate.h: Added m_useSecureKeyboardEntryWhenActive.
       
 40542         * page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Added an assertion,
       
 40543         and removed isSecureKeyboardEntry().
       
 40544 
       
 40545         * page/FrameView.h: Added updateControlTints.
       
 40546         * page/FrameView.cpp: (WebCore::FrameView::updateControlTints): Added. Code was moved
       
 40547         here from setIsActive for two reasons: (1) it makes more sense in the view class, and
       
 40548         (2) it needs to be called at the appropriate time for AppKit, not when active changes.
       
 40549 
       
 40550         * rendering/RenderTheme.cpp: (WebCore::RenderTheme::isFocused): Added an isActive
       
 40551         check here to match the logic in the implementation of the CSS pseudo-state.
       
 40552         * rendering/RenderThemeMac.mm:
       
 40553         (WebCore::RenderThemeMac::updateFocusedState): Use the isFocused function instead of
       
 40554         repeating the logic here. Removed the "need to add a key window test here" comment.
       
 40555         (WebCore::RenderThemeMac::controlSupportsTints): Added a comment about the NSCell
       
 40556         SPI that's related to the _windowChangedKeyState method we now use in WebHTMLView.
       
 40557 
       
 40558 2007-04-16  Darin Adler  <darin@apple.com>
       
 40559 
       
 40560         Reviewed by John Sullivan.
       
 40561 
       
 40562         - fix http://bugs.webkit.org/show_bug.cgi?id=13227
       
 40563           StringImpl::isLower incorrectly assumes islower returns 1 (it can return any non-0)
       
 40564 
       
 40565         * platform/StringImpl.cpp:
       
 40566         (WebCore::StringImpl::isLower): Based on test application results, changed to use &&
       
 40567         instead of trying to use & to avoid branches. Use U16_NEXT so we can handle characters
       
 40568         outside the BMP. Improved comments.
       
 40569         (WebCore::StringImpl::lower): Improved comments.
       
 40570         (WebCore::equalIgnoringCase): Changed to use && instead of trying to use & to avoid
       
 40571         branches. Improved comments. Added an assertion about the assumption we're
       
 40572         making that characters in the char* are all ASCII.
       
 40573 
       
 40574 2007-04-13  David Kilzer  <ddkilzer@webkit.org>
       
 40575 
       
 40576         Patch and review by hyatt.  Testing and landing by ddkilzer.
       
 40577 
       
 40578         <rdar://problem/5078866>
       
 40579         tables don't inherit text-align (in strict mode; they're not supposed to in quirks mode)
       
 40580 
       
 40581         Test: fast/css/table-text-align-quirk.html
       
 40582               fast/css/table-text-align-strict.html
       
 40583 
       
 40584         Previous commit (r20731) removed the wrong property from WebCore/css/html4.css.  However,
       
 40585         when the correct property was removed, it caused tables to inherit alignment properties
       
 40586         from tags like <center> and <div align="center">.  This is fixed in
       
 40587         WebCore::CSSStyleSelector::adjustRenderStyle() by special-casing tables to reset the
       
 40588         text-align property.
       
 40589 
       
 40590         * css/CSSComputedStyleDeclaration.cpp:
       
 40591         (WebCore::valueForTextAlign): Renamed KHTML_CENTER, KHTML_LEFT and KHTML_RIGHT to
       
 40592         WEBKIT_CENTER, WEBKIT_LEFT and WEBKIT_RIGHT.
       
 40593         * css/cssparser.cpp:
       
 40594         (WebCore::CSSParser::parseValue): Ditto.
       
 40595         * css/cssstyleselector.cpp:
       
 40596         (WebCore::CSSStyleSelector::adjustRenderStyle): Tables should not support -webkit-center,
       
 40597         -webkit-left or -webkit-right values for text-align, so reset them back to auto.
       
 40598         * css/html4.css: Removed "text-align: -webkit-auto;" property from tables selector.  It
       
 40599         was previously added to css/quirks.css in r20731.
       
 40600         * rendering/RenderBlock.cpp:
       
 40601         (WebCore::RenderBlock::determineHorizontalPosition): Renamed KHTML_* to WEBKIT_*.
       
 40602         * rendering/RenderBox.cpp:
       
 40603         (WebCore::RenderBox::calcHorizontalMargins): Ditto.
       
 40604         * rendering/RenderFlow.cpp:
       
 40605         (WebCore::RenderFlow::caretRect): Ditto.
       
 40606         * rendering/RenderStyle.h: Ditto.
       
 40607         (WebCore::):
       
 40608         * rendering/bidi.cpp:
       
 40609         (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto.
       
 40610 
       
 40611 2007-04-12  Brady Eidson  <beidson@apple.com>
       
 40612 
       
 40613         Reviewed by Black Sheep
       
 40614 
       
 40615         <rdar://problem/4664154> and http://bugs.webkit.org/show_bug.cgi?id=3546
       
 40616 
       
 40617         When you click on a link that opens in a new window from within gmail, they first create a new window 
       
 40618         with an empty URL, then immediately document.write() into the window to schedule a redirect.
       
 40619 
       
 40620         Since the initial page doesn't have a URL associated with it, a history item never gets created.  The 
       
 40621         reasonable solution?  To actually create the history item after the redirect (in updateHistoryForInternalLoad)
       
 40622 
       
 40623         * loader/FrameLoader.cpp:
       
 40624         (WebCore::FrameLoader::addHistoryForCurrentLocation): Updates global and B/F history with a new history item
       
 40625         (WebCore::FrameLoader::updateHistoryForStandardLoad): Call addHistoryForCurrentLocation
       
 40626         (WebCore::FrameLoader::updateHistoryForInternalLoad): Call addHistoryForCurrentLocation if there is not already
       
 40627           a current history item
       
 40628         * loader/FrameLoader.h:
       
 40629 
       
 40630 2007-04-12  Oliver Hunt  <oliver@apple.com>
       
 40631 
       
 40632         Reviewed by Adam.
       
 40633 
       
 40634         This fixes <rdar://problem/5060766> -- Frameset with 
       
 40635         an empty frame crashes due to null document.  Debug
       
 40636         builds hit the frame->document() assertion in 
       
 40637         EventHandler::prepareMouseEvent
       
 40638 
       
 40639         This null check seems necessary now, having run through 
       
 40640         all the logic on the path to this crash it appears that
       
 40641         we can't avoid this null check.  
       
 40642 
       
 40643         * page/EventHandler.cpp:
       
 40644         (WebCore::EventHandler::updateDragAndDrop):
       
 40645 
       
 40646 2007-04-12  Justin Garcia  <justin.garcia@apple.com>
       
 40647 
       
 40648         Reviewed by darin
       
 40649         
       
 40650         <rdar://problem/5131716> 
       
 40651         Clicking just before a ToDo doesn't put the caret before the ToDo
       
 40652         
       
 40653         * rendering/RenderBlock.cpp:
       
 40654         (WebCore::RenderBlock::positionForCoordinates):
       
 40655         Consider clicks inside the blocks padding, instead of
       
 40656         incorrectly sending them to the position before the block.
       
 40657 
       
 40658 2007-04-12  John Sullivan  <sullivan@apple.com>
       
 40659 
       
 40660         Reviewed by Anders
       
 40661 
       
 40662         - WebCore part of fix for:
       
 40663         <rdar://problem/5128697> REGRESSION: At least one PDF context menu item isn't appearing on Leopard
       
 40664 
       
 40665         * platform/ContextMenuItem.h:
       
 40666         (WebCore::):
       
 40667         add two PDF-related context menu items to enum to keep it in sync with WebKit
       
 40668 
       
 40669         * platform/ContextMenu.cpp:
       
 40670         (WebCore::ContextMenu::checkOrEnableIfNeeded):
       
 40671         add the new context menu items to the do-nothing case of a big switch statement
       
 40672 
       
 40673 2007-04-12  Simon Hausmann  <hausmann@kde.org>
       
 40674 
       
 40675         Reviewed by Zack.
       
 40676 
       
 40677         Fixed drawing of justified text in the Qt port.
       
 40678 
       
 40679         * platform/qt/FontQt.cpp:
       
 40680         (Font::drawGlyphs):
       
 40681 
       
 40682 2007-04-11  Oliver Hunt  <oliver@apple.com>
       
 40683 
       
 40684         Reviewed by Maciej.
       
 40685 
       
 40686         Adding RetainPtr to the many global obj-c pointers we use in
       
 40687         C/C++ methods.  This is necessary to prevent GC from collecting
       
 40688         globals we want to keep around.
       
 40689 
       
 40690         We use RetainPtr in obj-c++ and c++ files, and CFRetain/Release in pure
       
 40691         obj-c.
       
 40692 
       
 40693         Also made the Pasteboard::m_pasteboard a RetainPtr although it
       
 40694         shouldn't be necessary as the only NSPasteboard instances that 
       
 40695         should ever be inserted are the system clipboard and dragging 
       
 40696         pasteboard.  Neither of which should ever be collected.
       
 40697 
       
 40698         * page/mac/WebCoreFrameBridge.mm:
       
 40699         (_getPreSmartSet):
       
 40700         (_getPostSmartSet):
       
 40701         * platform/Pasteboard.h:
       
 40702         * platform/graphics/mac/ColorMac.mm:
       
 40703         (WebCore::nsColor):
       
 40704         * platform/graphics/mac/GraphicsContextMac.mm:
       
 40705         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
       
 40706         * platform/mac/FontDataMac.mm:
       
 40707         (WebCore::webFallbackFontFamily):
       
 40708         * platform/mac/PasteboardMac.mm:
       
 40709         (WebCore::writableTypesForURL):
       
 40710         (WebCore::writableTypesForImage):
       
 40711         (WebCore::Pasteboard::clear):
       
 40712         (WebCore::Pasteboard::writeSelection):
       
 40713         (WebCore::Pasteboard::writeURL):
       
 40714         (WebCore::Pasteboard::writeFileWrapperAsRTFDAttachment):
       
 40715         (WebCore::Pasteboard::writeImage):
       
 40716         (WebCore::Pasteboard::canSmartReplace):
       
 40717         (WebCore::Pasteboard::plainText):
       
 40718         (WebCore::Pasteboard::documentFragment):
       
 40719 
       
 40720 2007-04-11  Mitz Pettel  <mitz@webkit.org>
       
 40721 
       
 40722         Reviewed by Dave Hyatt.
       
 40723 
       
 40724         - fix http://bugs.webkit.org/show_bug.cgi?id=11362
       
 40725           Native popup with size="1" wraps options
       
 40726 
       
 40727         Test: fast/forms/menulist-option-wrap.html
       
 40728 
       
 40729         * css/html4.css: Added white-space declaration for select[size="0"] and
       
 40730         select[size="1"]. Added border-radius declaration for select.
       
 40731 
       
 40732 2007-04-11  MorganL  <morganl.webkit@yahoo.com>
       
 40733 
       
 40734         Reviewed by Maciej.
       
 40735 
       
 40736         Add a Frame pointer to ChromeClient methods:
       
 40737         http://bugs.webkit.org/show_bug.cgi?id=13127
       
 40738 
       
 40739         * loader/FrameLoader.cpp:
       
 40740         (WebCore::FrameLoader::createWindow):
       
 40741         * page/Chrome.cpp:
       
 40742         (WebCore::Chrome::createWindow):
       
 40743         (WebCore::Chrome::createModalDialog):
       
 40744         * page/Chrome.h:
       
 40745         * page/ChromeClient.h:
       
 40746         * page/ContextMenuController.cpp:
       
 40747         (WebCore::openNewWindow):
       
 40748         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 40749         (WebCore::SVGEmptyChromeClient::createWindow):
       
 40750         (WebCore::SVGEmptyChromeClient::createModalDialog):
       
 40751 
       
 40752 2007-04-11  Brady Eidson  <beidson@apple.com>
       
 40753 
       
 40754         Reviewed by Ada
       
 40755 
       
 40756         <rdar://problem/5080987> - Crash in DocumentLoader::frameLoader() const
       
 40757 
       
 40758         This was free nil checking lost during the ObjC -> C++ conversion
       
 40759 
       
 40760         * loader/FrameLoader.cpp:
       
 40761         (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Null check the DocumentLoader
       
 40762 
       
 40763 2007-04-11  Justin Garcia  <justin.garcia@apple.com>
       
 40764 
       
 40765         Reviewed by harrison
       
 40766 
       
 40767         <rdar://problem/5126166> 
       
 40768         Deleting selection starting at before ToDo checkbox to end of line, inserts a BR in the subsequent ToDo
       
 40769         
       
 40770         If a selection ends in a table cell, we shouldn't perform
       
 40771         a merge after deleting that selection.  We have code in
       
 40772         place to prevent those merges, but it failed here.
       
 40773         
       
 40774         It fails because the end of the selection was [tableCell, 0],
       
 40775         (normally not a valid VisiblePosition, but valid here
       
 40776         because the table cell is empty).  We prevent the merge
       
 40777         if the node of the position at the end of the selection 
       
 40778         has an enclosingTableCell.  Even though [tableCell, 0] has 
       
 40779         an enclosing table cell, the node tableCell doesn't, so 
       
 40780         the check fails.
       
 40781         
       
 40782         Fixed this by changing enclosingTableCell to take in
       
 40783         a position, instead of a node.  The other enclosing element
       
 40784         getters should be changed in this way as well.
       
 40785 
       
 40786         * editing/DeleteSelectionCommand.cpp:
       
 40787         (WebCore::DeleteSelectionCommand::initializePositionData):
       
 40788         Call the new enclosingTableCell.
       
 40789         * editing/ReplaceSelectionCommand.cpp:
       
 40790         (WebCore::ReplaceSelectionCommand::shouldMerge): Ditto.
       
 40791         * editing/htmlediting.cpp:
       
 40792         (WebCore::enclosingTableCell): Take in a position instead
       
 40793         of a node.
       
 40794         * editing/htmlediting.h:
       
 40795 
       
 40796 2007-04-12  Mark Rowe  <mrowe@apple.com>
       
 40797 
       
 40798         Qt build fix.
       
 40799 
       
 40800         * WebCore.pro:
       
 40801         * editing/qt/EditorQt.cpp:
       
 40802         (WebCore::Editor::markBadGrammar):
       
 40803         * history/qt/CachedPageQt.cpp: Added.
       
 40804         (WebCore::CachedPage::close):
       
 40805         * history/qt/PageCacheQt.cpp: Removed.
       
 40806 
       
 40807 2007-04-11  Brady Eidson  <beidson@apple.com>
       
 40808 
       
 40809         Reviewed by Antti
       
 40810 
       
 40811         <rdar://problem/5125648> and http://bugs.webkit.org/show_bug.cgi?id=13326
       
 40812 
       
 40813         Crash opening a link in a new window from Gmail
       
 40814 
       
 40815         Problem here is that the currentHistoryItem in the new window is null.  This *shouldn't* be the case, 
       
 40816         and is the cause of a very long standing bug - 
       
 40817         http://bugs.webkit.org/show_bug.cgi?id=3546 - Can't go back to first page in new window opened from gmail
       
 40818 
       
 40819         For now, adding a null check prevents this crash and restores the original, long standing regression
       
 40820  
       
 40821         * loader/FrameLoader.cpp:
       
 40822         (WebCore::FrameLoader::updateHistoryForInternalLoad): NULL check
       
 40823 
       
 40824 2007-04-11  Adam Roben  <aroben@apple.com>
       
 40825 
       
 40826         Reviewed by Anders.
       
 40827 
       
 40828         Made image document copying more cross-platform.
       
 40829 
       
 40830         All layout tests pass.
       
 40831 
       
 40832         * editing/Editor.cpp:
       
 40833         (WebCore::imageNodeFromImageDocument): Added.
       
 40834         (WebCore::Editor::canCopy): Called imageNodeFromImageDocument.
       
 40835         (WebCore::Editor::copy): Ditto.
       
 40836         (WebCore::Editor::copyImage): Updated for changes to Pasteboard.
       
 40837         * platform/Pasteboard.h: Made writeImage more general, which allowed
       
 40838         getting rid of its second incarnation.
       
 40839         * platform/gdk/TemporaryLinkStubs.cpp:
       
 40840         * platform/mac/PasteboardMac.mm:
       
 40841         (WebCore::Pasteboard::writeImage): Collapsed logic from the two
       
 40842         writeImage methods into one.
       
 40843         (Pasteboard::writeImage): Updated for Pasteboard changes.
       
 40844         * platform/qt/PasteboardQt.cpp:
       
 40845         (WebCore::Pasteboard::writeImage): Ditto.
       
 40846 
       
 40847 2007-04-11  Darin Adler  <darin@apple.com>
       
 40848 
       
 40849         * css/CSSValueKeywords.in: Fix a comment.
       
 40850 
       
 40851 2007-04-09  Justin Garcia  <justin.garcia@apple.com>
       
 40852 
       
 40853         Reviewed by harrison
       
 40854         
       
 40855         <rdar://problem/4932260> 
       
 40856         Invalid attributed string for attachment range obtained via AXPreviousWordStartTextMarkerForTextMarker
       
 40857         
       
 40858         By default, text iterators don't emit anything for replaced 
       
 40859         elements.  Boundary finding code works around this but has 
       
 40860         bugs: replaced elements act as sentence boundaries and the 
       
 40861         above bug, where previousBoundary moves past the start of a 
       
 40862         word if there is a replaced element just before it. This 
       
 40863         patch fixes these issues by treating replaced elements as 
       
 40864         punctuation for boundary finding.
       
 40865 
       
 40866         * editing/TextIterator.cpp:
       
 40867         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
       
 40868         Set m_pastStartNode, the node after (in a reverse pre-order traversal) the 
       
 40869         last one that should be processed.
       
 40870         (WebCore::SimplifiedBackwardsTextIterator::advance):
       
 40871         Stop at m_pastStartNode.
       
 40872         Iterate over nodes in reverse pre-order (TextIterator traverses in 
       
 40873         pre-orer). This makes knowing when to emit characters after nodes vs. when
       
 40874         to emit characters before nodes easier.
       
 40875         Remove the special case for entering a new block, emitting characters 
       
 40876         after nodes can now be handled generally, in handleNonTextNode(), because
       
 40877         of the way we traverse.
       
 40878         Set m_handledChildren to false every iteration since we now do traverse in 
       
 40879         reverse pre-order.
       
 40880         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
       
 40881         Emit a comma for replaced elements.  We only use this kind of iterator 
       
 40882         for finding boundaries, so we can do this unconditionally.
       
 40883         (WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
       
 40884         Don't use emitNewline, instead specify where the newline should be positioned.
       
 40885         A node is handled before its children, so characters emitted here should 
       
 40886         be positioned after the node, not before it.
       
 40887         (WebCore::SimplifiedBackwardsTextIterator::exitNode): 
       
 40888         Don't use emitNewline, instead specify where the newline should be positioned.
       
 40889         (WebCore::CharacterIterator::CharacterIterator): 
       
 40890         Create a TextIterator that emits content for replaced elements, if requested.
       
 40891         * editing/TextIterator.h:
       
 40892         * editing/visible_units.cpp:
       
 40893         (WebCore::previousBoundary): 
       
 40894         Removed replaced element handling code.
       
 40895         If the start of the chunk that contained the boundary was in a non-text
       
 40896         node, then the boundary is not necessarily in that node.  Particularly
       
 40897         because it is only the end of the chunk that is guaranteed to be a valid
       
 40898         position in those cases.  We must iterate backwards by character from 
       
 40899         the end of the chunk to find the boundary.
       
 40900         (WebCore::nextBoundary): Removed replaced element handling code.
       
 40901 
       
 40902 2007-04-10  Brady Eidson  <beidson@apple.com>
       
 40903 
       
 40904         Reviewed by Darin
       
 40905 
       
 40906         <rdar://problem/4887095> - PageCache and PageState should be combined
       
 40907 
       
 40908         These two objects are a relic of when the PageCache was split between WebCore and WebKit
       
 40909         It just makes good sense to combine them now, and the new object is more appropriately
       
 40910         called "CachedPage"
       
 40911 
       
 40912         This patch is vast in scope, but simple in depth - anywhere a PageCache or PageState object 
       
 40913         was used has been adjusted to use a CachedPage object instead.  The most notable change is
       
 40914         that HistoryItem - which always used to have a PageCache object which may or may not have 
       
 40915         had a PageState - now may or may not have a CachedPage.  This actually simplifies the 
       
 40916         HistoryItem code a bit while making the role of CachedPage much more clear.
       
 40917 
       
 40918         * WebCore.exp:
       
 40919         * WebCore.xcodeproj/project.pbxproj:
       
 40920 
       
 40921         * history/BackForwardList.cpp:
       
 40922         (WebCore::BackForwardList::addItem):
       
 40923         (WebCore::BackForwardList::setCapacity):
       
 40924         (WebCore::BackForwardList::setPageCacheSize):
       
 40925         (WebCore::BackForwardList::clearPageCache):
       
 40926         (WebCore::BackForwardList::close):
       
 40927 
       
 40928         * history/PageCache.cpp: Removed.
       
 40929         * history/PageCache.h: Removed.
       
 40930         * page/PageState.cpp: Removed.
       
 40931         * page/PageState.h: Removed.
       
 40932         * history/CachedPage.cpp: Added.
       
 40933         (WebCore::CachedPage::create):
       
 40934         (WebCore::CachedPage::CachedPage):
       
 40935         (WebCore::CachedPage::~CachedPage):
       
 40936         (WebCore::CachedPage::restore):
       
 40937         (WebCore::CachedPage::clear):
       
 40938         (WebCore::CachedPage::setDocumentLoader):
       
 40939         (WebCore::CachedPage::documentLoader):
       
 40940         (WebCore::CachedPage::setTimeStamp):
       
 40941         (WebCore::CachedPage::setTimeStampToNow):
       
 40942         (WebCore::CachedPage::timeStamp):
       
 40943         * history/CachedPage.h: Added.
       
 40944         (WebCore::CachedPage::document):
       
 40945         (WebCore::CachedPage::mousePressNode):
       
 40946         (WebCore::CachedPage::URL):
       
 40947 
       
 40948         * history/HistoryItem.cpp:
       
 40949         (WebCore::HistoryItem::HistoryItem):
       
 40950         (WebCore::HistoryItem::setCachedPage):
       
 40951         (WebCore::HistoryItem::setURL):
       
 40952         (WebCore::HistoryItem::alwaysAttemptToUseCachedPage):
       
 40953         (WebCore::HistoryItem::setAlwaysAttemptToUseCachedPage):
       
 40954         (WebCore::HistoryItem::cachedPage):
       
 40955         (WebCore::cachedPagesPendingRelease):
       
 40956         (WebCore::HistoryItem::releaseCachedPagesOrReschedule):
       
 40957         (WebCore::HistoryItem::releaseAllPendingCachedPages):
       
 40958         (WebCore::HistoryItem::scheduleCachedPageForRelease):
       
 40959         * history/HistoryItem.h:
       
 40960         * history/mac/HistoryItemMac.mm:
       
 40961 
       
 40962         * history/HistoryItemTimer.cpp:
       
 40963         (WebCore::HistoryItemTimer::HistoryItemTimer):
       
 40964         (WebCore::HistoryItemTimer::callReleaseCachedPagesOrReschedule):
       
 40965         * history/HistoryItemTimer.h:
       
 40966 
       
 40967         * history/mac/PageCacheMac.mm: Removed.
       
 40968         * history/mac/CachedPageMac.mm: Added.
       
 40969         (WebCore::CachedPage::close):
       
 40970         (WebCore::CachedPage::setDocumentView):
       
 40971         (WebCore::CachedPage::documentView):
       
 40972 
       
 40973         * loader/DocumentLoader.cpp:
       
 40974         (WebCore::DocumentLoader::DocumentLoader):
       
 40975         (WebCore::DocumentLoader::loadFromCachedPage):
       
 40976         (WebCore::DocumentLoader::setLoadingFromCachedPage):
       
 40977         (WebCore::DocumentLoader::isLoadingFromCachedPage):
       
 40978         * loader/DocumentLoader.h:
       
 40979 
       
 40980         * loader/FrameLoader.cpp:
       
 40981         (WebCore::FrameLoader::provisionalLoadStarted):
       
 40982         (WebCore::FrameLoader::commitProvisionalLoad):
       
 40983         (WebCore::FrameLoader::transitionToCommitted):
       
 40984         (WebCore::FrameLoader::open):
       
 40985         (WebCore::FrameLoader::startLoading):
       
 40986         (WebCore::FrameLoader::receivedMainResourceError):
       
 40987         (WebCore::FrameLoader::opened):
       
 40988         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
       
 40989         (WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
       
 40990         (WebCore::FrameLoader::cachePageToHistoryItem):
       
 40991         (WebCore::FrameLoader::createHistoryItem):
       
 40992         (WebCore::FrameLoader::purgePageCache):
       
 40993         (WebCore::FrameLoader::invalidateCurrentItemCachedPage):
       
 40994         (WebCore::FrameLoader::loadItem):
       
 40995         (WebCore::FrameLoader::updateHistoryForStandardLoad):
       
 40996         (WebCore::FrameLoader::updateHistoryForClientRedirect):
       
 40997         (WebCore::FrameLoader::updateHistoryForBackForwardNavigation):
       
 40998         (WebCore::FrameLoader::updateHistoryForReload):
       
 40999         (WebCore::FrameLoader::updateHistoryForInternalLoad):
       
 41000         (WebCore::FrameLoader::updateHistoryForCommit):
       
 41001         * loader/FrameLoader.h:
       
 41002         * loader/FrameLoaderClient.h:
       
 41003 
       
 41004         * page/mac/WebCoreFrameBridge.h: Got rid of unused WebCorePageCacheStateKey
       
 41005         * page/mac/WebCoreFrameBridge.mm: Ditto
       
 41006 
       
 41007         * platform/graphics/svg/SVGImage.cpp:
       
 41008         * platform/graphics/svg/SVGImageEmptyClients.h: Update to reflect the new names
       
 41009         (WebCore::SVGEmptyFrameLoaderClient::loadProvisionalItemFromCachedPage):
       
 41010         (WebCore::SVGEmptyFrameLoaderClient::invalidateCurrentItemCachedPage):
       
 41011         (WebCore::SVGEmptyFrameLoaderClient::loadedFromCachedPage):
       
 41012         (WebCore::SVGEmptyFrameLoaderClient::clearLoadingFromCachedPage):
       
 41013         (WebCore::SVGEmptyFrameLoaderClient::isLoadingFromCachedPage):
       
 41014         (WebCore::SVGEmptyFrameLoaderClient::setDocumentViewFromCachedPage):
       
 41015         (WebCore::SVGEmptyFrameLoaderClient::saveDocumentViewToCachedPage):
       
 41016 
       
 41017 2007-04-10  Antti Koivisto  <antti@apple.com>
       
 41018 
       
 41019         Reviewed by Hyatt.
       
 41020 
       
 41021         Fix <rdar://5057686> 
       
 41022         Flex box layout example hangs in WebCore::RenderFlexibleBox::allowedChildFlex
       
 41023         
       
 41024         Forcibly distribute remaining pixels if the algorithm is not advancing.
       
 41025 
       
 41026         * rendering/RenderFlexibleBox.cpp:
       
 41027         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
       
 41028         (WebCore::RenderFlexibleBox::layoutVerticalBox):
       
 41029 
       
 41030 2007-04-11  Mark Rowe  <mrowe@apple.com>
       
 41031 
       
 41032         Build fix.
       
 41033 
       
 41034         * bridge/mac/WebCoreAXObject.mm:
       
 41035         (-[WebCoreAXObject accessibilityDescription]):
       
 41036 
       
 41037 2007-04-10  Patti Hoa <patti@apple.com>
       
 41038 
       
 41039         Reviewed by Justin Garcia.
       
 41040 
       
 41041         <rdar://problem/5122276> Allow focused frame to fire off notification
       
 41042         Improve accessibility support for Mail WebView embedded Notes.
       
 41043 
       
 41044         * bridge/mac/AXObjectCacheMac.mm:
       
 41045         (WebCore::AXObjectCache::postNotification):
       
 41046         The focused document with the selection change should fire the selection changed notification, not the top level document
       
 41047         * bridge/mac/WebCoreAXObject.mm:
       
 41048         (-[WebCoreAXObject accessibilityDescription]):
       
 41049         Allow the name attribute of the html body to be used as the accessibility description
       
 41050 
       
 41051 2007-04-09  Geoffrey Garen  <ggaren@apple.com>
       
 41052 
       
 41053         Reviewed by Maciej Stachowiak.
       
 41054         
       
 41055         Support for fixing fast/forms/textarea-paste-newline.html.
       
 41056         
       
 41057         Changed clients to use new preference specifying whether a Page should 
       
 41058         allow pasting through the DOM API, instead of a global flag.
       
 41059 
       
 41060         Removed old behavior of always allowing DOM paste in debug builds. In 
       
 41061         light of the new preference-based API, that behavior makes no sense anymore. 
       
 41062         Instead, developers who want to test paste inside Safari can set the 
       
 41063         preference for themselves.
       
 41064 
       
 41065         * WebCore.exp:
       
 41066         * editing/CommandByName.cpp: Removed crazy hack to keep an identically 
       
 41067         named but invalid copy of the global "pate allowed" flag in this file.
       
 41068         (WebCore::Frame::enabledPaste):
       
 41069         * editing/JSEditor.cpp: Removed "always allow" behavior for debug builds.
       
 41070         (WebCore::JSEditor::queryCommandSupported):
       
 41071         * editing/JSEditor.h:
       
 41072         * page/Settings.cpp:
       
 41073         (WebCore::Settings::setDOMPasteAllowed):
       
 41074         * page/Settings.h:
       
 41075         (WebCore::Settings::isDOMPasteAllowed):
       
 41076         * rendering/RenderTreeAsText.cpp:
       
 41077         (WebCore::externalRepresentation): Removed crazy hack to allow DOM paste
       
 41078         after this function has been called.
       
 41079 
       
 41080 2007-04-10  John Sullivan  <sullivan@apple.com>
       
 41081 
       
 41082         Reviewed by Tim Hatcher
       
 41083 
       
 41084         - fixed <rdar://problem/4859132> Grammar must always be checked in entire-sentence chunks, 
       
 41085           and shouldn't show markers for current sentence
       
 41086 
       
 41087         * editing/Editor.h:
       
 41088         add markBadGrammar, now distinct from markMisspellings
       
 41089 
       
 41090         * editing/mac/EditorMac.mm:
       
 41091         (WebCore::Editor::markMisspellingsAfterTypingToPosition):
       
 41092         call markMisspellings on one word, and markBadGrammar on entire sentence
       
 41093         (WebCore::markMisspellingsOrBadGrammar):
       
 41094         new static function, extracted from markMisspellings
       
 41095         (WebCore::Editor::markMisspellings):
       
 41096         now calls extracted function
       
 41097         (WebCore::Editor::markBadGrammar):
       
 41098         new method, calls extracted function
       
 41099 
       
 41100         * page/Frame.cpp:
       
 41101         (WebCore::Frame::respondToChangedSelection):
       
 41102         update grammar markers for entire new and old sentences
       
 41103 
       
 41104 2007-04-09  Anders Carlsson  <andersca@apple.com>
       
 41105 
       
 41106         Reviewed by John.
       
 41107 
       
 41108         * WebCore.exp:
       
 41109         Add __ZNK7WebCore11FrameLoader10isCompleteEv.
       
 41110         
       
 41111 2007-04-09  Brady Eidson  <beidson@apple.com>
       
 41112 
       
 41113         Reviewed by Darin
       
 41114 
       
 41115         Fixes <rdar://4921797> and http://bugs.webkit.org/show_bug.cgi?id=12005
       
 41116 
       
 41117         The original regression was to claim that more loads were the result of a "user gesture" than really
       
 41118         were.  A lot of the ways a frame load could be kicked off didn't properly set up this flag, and it 
       
 41119         wasn't properly propagated and respected where it should've been.
       
 41120 
       
 41121         This patch cleans much of that up.  One loose end is the "treatAsUserGesture" flag which is a stop
       
 41122         gap measure to keep "slow redirects" working to create a new history item.  In the future, we need
       
 41123         to cleanup the meaning and use of "userGesture" and "lockHistory."  This includes integrating them 
       
 41124         in to FrameLoadRequest and being very clear of what their meaning actually is at different stages of
       
 41125         the Frame load process.
       
 41126 
       
 41127         * dom/Document.cpp:
       
 41128         (WebCore::Document::processHttpEquiv): Pass only the delay for the redirect
       
 41129 
       
 41130         * html/HTMLAnchorElement.cpp:
       
 41131         (WebCore::HTMLAnchorElement::defaultEventHandler): Pass "lockHistory" false, "userGesture" true
       
 41132 
       
 41133         * ksvg2/svg/SVGAElement.cpp:
       
 41134         (WebCore::SVGAElement::defaultEventHandler): Pass "lockHistory" false, "userGesture" true
       
 41135 
       
 41136         * loader/FrameLoader.cpp:
       
 41137         (WebCore::ScheduledRedirection::ScheduledRedirection): Figure "lockHistory" and "userGesture" from the 
       
 41138           delay here, instead of at 3 other different sites that call this method
       
 41139         (WebCore::FrameLoader::changeLocation): Set userGesture correctly
       
 41140         (WebCore::FrameLoader::urlSelected): Propagate userGesture down
       
 41141         (WebCore::FrameLoader::requestFrame): 
       
 41142         (WebCore::FrameLoader::receivedFirstData):
       
 41143         (WebCore::FrameLoader::scheduleRedirection): Pass only the delay here
       
 41144         (WebCore::FrameLoader::redirectionTimerFired): Set userGesture correctly
       
 41145         (WebCore::FrameLoader::load):
       
 41146         (WebCore::FrameLoader::updateHistoryForInternalLoad): Insteading of asserting we aren't a redirect,
       
 41147           handle the case where we *are* a redirect by updating the previous history item
       
 41148         * loader/FrameLoader.h:
       
 41149 
       
 41150 2007-04-09  Anders Carlsson  <andersca@apple.com>
       
 41151 
       
 41152         Reviewed by Darin.
       
 41153 
       
 41154         <rdar://problem/5120801> 
       
 41155         http://bugs.webkit.org/show_bug.cgi?id=13247
       
 41156         Closing a page during slow cloning causes crash in setJSStatusBarText (13247)
       
 41157 
       
 41158         * bindings/js/kjs_window.cpp:
       
 41159         (KJS::Window::put):
       
 41160         Return early if m_frame is null. A closed window only has one property, "closed" 
       
 41161         so no properties should be settable in that case.
       
 41162 
       
 41163 2007-04-09  Andrew Wellington  <proton@wiretapped.net>
       
 41164 
       
 41165         Reviewed by Justin Garcia.
       
 41166         
       
 41167         Fix for http://bugs.webkit.org/show_bug.cgi?id=12959
       
 41168         "REGRESSION: Edit -> Copy not enabled on standalone images"
       
 41169 
       
 41170         * dom/Document.h: Add support for determining if a document is an image
       
 41171         (WebCore::Document::isImageDocument):
       
 41172         * editing/Editor.cpp:
       
 41173         (WebCore::Editor::canCopy): Image documents are copyable
       
 41174         (WebCore::Editor::copy): If copying an image document, call appropriate pasteboard methods
       
 41175         * loader/ImageDocument.h:
       
 41176         (WebCore::ImageDocument::isImageDocument): Override to return true for image documents
       
 41177         * platform/Pasteboard.h: Add new writeImage function to pasteboard
       
 41178         * platform/mac/PasteboardMac.mm:
       
 41179         (WebCore::Pasteboard::writeImage): Add writeImage implementation that takes Node and URL
       
 41180         * platform/qt/PasteboardQt.cpp:
       
 41181         (WebCore::Pasteboard::writeImage): Stub for Qt implementation of pasteboard
       
 41182 
       
 41183 2007-04-08  Oliver Hunt  <oliver@apple.com>
       
 41184 
       
 41185         rs=Adam.
       
 41186 
       
 41187         Add ASSERT(selectedRange) to previous change
       
 41188 
       
 41189         * platform/mac/PasteboardMac.mm:
       
 41190         (WebCore::Pasteboard::writeSelection):
       
 41191 
       
 41192 2007-04-08  Oliver Hunt  <oliver@apple.com>
       
 41193 
       
 41194         rs=Adam.
       
 41195 
       
 41196         Fix minor error when writing selection to pasteboard.
       
 41197         This shouldn't have an effect as selectedRange should be the
       
 41198         selected range from source frame, however this is safer.
       
 41199 
       
 41200         * platform/mac/PasteboardMac.mm:
       
 41201         (WebCore::Pasteboard::writeSelection):
       
 41202 
       
 41203 2007-04-08  David Hyatt  <hyatt@apple.com>
       
 41204 
       
 41205         Fix mouseover/out failing layout tests.
       
 41206 
       
 41207         Reviewed by aroben
       
 41208 
       
 41209         * page/EventHandler.cpp:
       
 41210         (WebCore::EventHandler::handleMouseMoveEvent):
       
 41211         (WebCore::EventHandler::updateMouseEventTargetNode):
       
 41212         (WebCore::EventHandler::dispatchMouseEvent):
       
 41213         * page/EventHandler.h:
       
 41214 
       
 41215 2007-04-08  Oliver Hunt  <oliver@apple.com>
       
 41216 
       
 41217         Reviewed by Adam.
       
 41218 
       
 41219         Fix for <rdar://problem/5113621> REGRESSION: Dragging PDF as image does not give any feedback
       
 41220 
       
 41221         If we fail when attempting to create a drag image for a dragged
       
 41222         image, we fall back to the appropriate icon.
       
 41223 
       
 41224         * page/DragController.cpp:
       
 41225         (WebCore::DragController::doImageDrag):
       
 41226 
       
 41227 2007-04-08  Adam Roben  <aroben@apple.com>
       
 41228 
       
 41229         Reviewed by Oliver.
       
 41230 
       
 41231         Bestowed the gift of -webkit-dashboard-region upon all platforms, since
       
 41232         there's nothing Mac-specific about it other than the name. This also
       
 41233         allowed me to get rid of FrameViewMac.mm.
       
 41234 
       
 41235         Removed a lot of #if PLATFORM(MAC):
       
 41236 
       
 41237         * css/CSSComputedStyleDeclaration.cpp:
       
 41238         (WebCore::):
       
 41239         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 41240         * css/CSSPrimitiveValue.cpp:
       
 41241         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
       
 41242         (WebCore::CSSPrimitiveValue::cleanup):
       
 41243         (WebCore::CSSPrimitiveValue::cssText):
       
 41244         * css/CSSPrimitiveValue.h:
       
 41245         (WebCore::CSSPrimitiveValue::getDashboardRegionValue):
       
 41246         (WebCore::CSSPrimitiveValue::):
       
 41247         * css/cssparser.cpp:
       
 41248         (WebCore::CSSParser::parseValue):
       
 41249         (WebCore::CSSParser::parseDashboardRegions):
       
 41250         * css/cssparser.h:
       
 41251         * css/cssstyleselector.cpp:
       
 41252         (WebCore::CSSStyleSelector::applyProperty):
       
 41253         * dom/Document.cpp:
       
 41254         (WebCore::Document::Document):
       
 41255         * dom/Document.h:
       
 41256         * page/Frame.cpp:
       
 41257         (WebCore::Frame::paint):
       
 41258         * page/Frame.h:
       
 41259         * page/FrameView.cpp:
       
 41260         (WebCore::FrameView::layout):
       
 41261         (WebCore::FrameView::updateDashboardRegions): Moved from FrameViewMac.mm.
       
 41262         * page/FrameView.h:
       
 41263         * page/qt/FrameQt.cpp:
       
 41264         (WebCore::Frame::dashboardRegionsChanged): Stubbed out.
       
 41265         * platform/gdk/FrameGdk.cpp:
       
 41266         (WebCore::Frame::dashboardRegionsChanged): Ditto.
       
 41267         * rendering/RenderLayer.cpp:
       
 41268         (WebCore::RenderLayer::scrollToOffset):
       
 41269         (WebCore::RenderLayer::setHasHorizontalScrollbar):
       
 41270         (WebCore::RenderLayer::setHasVerticalScrollbar):
       
 41271         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
       
 41272         * rendering/RenderObject.cpp:
       
 41273         (WebCore::RenderObject::setStyle):
       
 41274 
       
 41275         * WebCore.xcodeproj/project.pbxproj: Removed FrameViewMac.mm.
       
 41276         * bridge/mac/FrameViewMac.mm: Removed.
       
 41277 
       
 41278 2007-04-08  Mark Rowe  <mrowe@apple.com>
       
 41279 
       
 41280         Qt build fix.
       
 41281 
       
 41282         * platform/qt/TemporaryLinkStubs.cpp:
       
 41283 
       
 41284 2007-04-06  Geoffrey Garen  <ggaren@apple.com>
       
 41285 
       
 41286         Reviewed by Beth Dakin.
       
 41287         
       
 41288         Fixed one more case of <rdar://problem/5112273> REGRESSION(TOT): 
       
 41289         Reproducible crash loading an old version of amazon.com as a web archive
       
 41290 
       
 41291         * bindings/js/JSXMLHttpRequest.cpp:
       
 41292         (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
       
 41293 
       
 41294 2007-04-06  Oliver Hunt  <oliver@apple.com>
       
 41295 
       
 41296         Reviewed by Adam.
       
 41297 
       
 41298         Fix MouseEvent so it's possible to distinguish between
       
 41299         a MouseMouseEvent with NoButton down, and a move with
       
 41300         LeftButton down.  It would be nice if the DOM allowed 
       
 41301         for NoButton to exist, but it doesn't so this is necessary.
       
 41302 
       
 41303         * dom/EventTargetNode.cpp:
       
 41304         (WebCore::EventTargetNode::dispatchMouseEvent):
       
 41305         * dom/MouseEvent.cpp:
       
 41306         (WebCore::MouseEvent::MouseEvent):
       
 41307         (WebCore::MouseEvent::initMouseEvent):
       
 41308         * dom/MouseEvent.h:
       
 41309         (WebCore::MouseEvent::noButton):
       
 41310 
       
 41311 2007-04-06  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 41312 
       
 41313         Not reviewed - gdk build fix.
       
 41314 
       
 41315         * platform/gdk/MouseEventGdk.cpp:
       
 41316 
       
 41317 2007-04-06  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 41318 
       
 41319         Reviewed by darin.
       
 41320 
       
 41321         Coverity fix. Coverity says:
       
 41322         "Event var_deref_op: Variable "info_ptr" tracked as NULL was dereferenced."
       
 41323 
       
 41324         * platform/image-decoders/png/pngrutil.c:
       
 41325         (png_handle_gAMA):
       
 41326 
       
 41327 2007-04-06  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 41328 
       
 41329         Reviewed by darin.
       
 41330 
       
 41331         Coverity fix. Coverity says:
       
 41332         "Event var_deref_model: Variable "(this)->clientptr" tracked as NULL was passed to a function that dereferences it."
       
 41333 
       
 41334         * platform/image-decoders/gif/GIFImageReader.cpp:
       
 41335         (GIFImageReader::read):
       
 41336 
       
 41337 2007-04-06  David Hyatt  <hyatt@apple.com>
       
 41338 
       
 41339         Fix more of the layout test failures caused by fixing the slider layout test failure (sigh).  clear()
       
 41340         needs to null out the capturingMouseEventsNode in the case where a mousedown or move while captured
       
 41341         causes a navigation to another page.
       
 41342 
       
 41343         * page/EventHandler.cpp:
       
 41344         (WebCore::EventHandler::clear):
       
 41345         (WebCore::EventHandler::handleMouseReleaseEvent):
       
 41346 
       
 41347 2007-04-06  David Hyatt  <hyatt@apple.com>
       
 41348 
       
 41349         Fix failing slider layout test.  Don't clear the subframe capture unless we really were capturing on a
       
 41350         subframe.
       
 41351 
       
 41352         Reviewed by adele, darin
       
 41353 
       
 41354         * page/EventHandler.cpp:
       
 41355         (WebCore::EventHandler::handleMouseReleaseEvent):
       
 41356 
       
 41357 2007-04-06  Beth Dakin  <bdakin@apple.com>
       
 41358 
       
 41359         Reviewed by Geoff and Darin.
       
 41360 
       
 41361         Fix for <rdar://problem/4875433> WebView underlines are too thick 
       
 41362         when scaled small
       
 41363 
       
 41364         When we have a small scale factor, we should follow the line-
       
 41365         drawing code as if we were printing. Meaning, specifically, that we 
       
 41366         should not round to device pixels and we should antialias.
       
 41367 
       
 41368         * platform/graphics/cg/GraphicsContextCG.cpp:
       
 41369         (WebCore::GraphicsContext::drawLineForText):
       
 41370 
       
 41371 2007-04-06  Geoffrey Garen  <ggaren@apple.com>
       
 41372 
       
 41373         Reviewed by Beth Dakin.
       
 41374         
       
 41375         Fixed <rdar://problem/5112273> REGRESSION(TOT): Reproducible crash loading 
       
 41376         an old version of amazon.com as a web archive
       
 41377         
       
 41378         The problem was JavaScript executing inside a frame with a NULL document.
       
 41379         It's probably a bug that the document was NULL, but we don't want a minor
       
 41380         bug to be a crasher, and we don't want the DOM to depend on the implementation
       
 41381         details of the JS bindings, so I added NULL checks.
       
 41382 
       
 41383         * bindings/js/kjs_window.cpp: Call FrameLoader::completeURL instead of
       
 41384         Document::completeURL, since FrameLoader::completeURL is safe against a
       
 41385         NULL document.
       
 41386         (KJS::Window::put):
       
 41387         (KJS::WindowFunc::callAsFunction):
       
 41388         (KJS::Location::put):
       
 41389         (KJS::LocationFunc::callAsFunction):
       
 41390 
       
 41391 2007-04-06  David Hyatt  <hyatt@apple.com>
       
 41392 
       
 41393         Fix for bug 13274.  Rework mouse events so that subframe capturing works again.  Make sure
       
 41394         everything just comes down through the top FrameView even when capturing is in effect.  Update
       
 41395         scrollbar handling logic so that scrollbars receive events correctly while capturing is in
       
 41396         effect.  Eliminate the notion of widget capture.  Fix mouse moves so that they only fire
       
 41397         on the innermost hit frame.
       
 41398 
       
 41399         Reviewed by olliej
       
 41400 
       
 41401         * page/EventHandler.cpp:
       
 41402         (WebCore::EventHandler::handleMouseDraggedEvent):
       
 41403         (WebCore::subframeForTargetNode):
       
 41404         (WebCore::EventHandler::handleMousePressEvent):
       
 41405         (WebCore::EventHandler::handleMouseMoveEvent):
       
 41406         (WebCore::EventHandler::handleMouseReleaseEvent):
       
 41407         * page/EventHandler.h:
       
 41408         * platform/PopupMenu.h:
       
 41409         (WebCore::PopupMenu::scrollbarCapturingMouse):
       
 41410         (WebCore::PopupMenu::setScrollbarCapturingMouse):
       
 41411         * platform/ScrollBar.h:
       
 41412         (WebCore::Scrollbar::handleMouseReleaseEvent):
       
 41413         * platform/Widget.h:
       
 41414         (WebCore::Widget::geometryChanged):
       
 41415 
       
 41416 2007-04-06  Justin Garcia  <justin.garcia@apple.com>
       
 41417 
       
 41418         Reviewed by john
       
 41419 
       
 41420         <rdar://problem/5115601> 
       
 41421         REGRESSION: Crash deleting a selection that starts in an editable table cell
       
 41422         
       
 41423         The selection starts at the start of an editable 
       
 41424         root that's embedded in a non-editable ToDo (table).  
       
 41425         Removing the selection removes all editable 
       
 41426         VisiblePositions from the root.  Then, the creation 
       
 41427         of mergeDestination fails, and using it causes a crash.
       
 41428 
       
 41429         * editing/DeleteSelectionCommand.cpp:
       
 41430         (WebCore::DeleteSelectionCommand::mergeParagraphs):
       
 41431         Nil-check mergeDestination to avoid crashing and
       
 41432         also insert a break in that case at m_upstreamStart, 
       
 41433         so that we can create a valid mergeDestination and
       
 41434         perform the merge.
       
 41435         
       
 41436         
       
 41437 2007-04-06  Mitz Pettel  <mitz@webkit.org>
       
 41438 
       
 41439         Reviewed by Oliver.
       
 41440 
       
 41441         Eliminate PlatformMouseEvent::currentEvent.
       
 41442 
       
 41443         No test possible (no change to functionality).
       
 41444 
       
 41445         * page/EventHandler.cpp:
       
 41446         (WebCore::EventHandler::handleDrag):
       
 41447         * platform/PlatformMouseEvent.h:
       
 41448         * platform/gdk/TemporaryLinkStubs.cpp:
       
 41449         * platform/mac/PlatformMouseEventMac.mm:
       
 41450         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
       
 41451         * platform/qt/PlatformMouseEventQt.cpp:
       
 41452         * platform/win/TemporaryLinkStubs.cpp:
       
 41453 
       
 41454 2007-04-05  Oliver Hunt  <oliver@apple.com>
       
 41455 
       
 41456         Reviewed by Maciej.
       
 41457 
       
 41458         Fix for rdar://problem/4849948 -- JSCanvasRenderingContext2D::drawImage
       
 41459         crashes when given invalid arguments.
       
 41460 
       
 41461         JSCanvasRenderingContext2D frequently casts from JSValue* to JSObject*
       
 41462         and then checks isObject *after* the cast.  JSObject::isObject is unsafe 
       
 41463         if applied to a JSImmediate value (null, undefined, etc).  This patch 
       
 41464         corrects the logic in a number of places by performing the isObject check
       
 41465         before casting to JSObject.
       
 41466 
       
 41467         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
       
 41468         (WebCore::JSCanvasRenderingContext2D::drawImage):
       
 41469         (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
       
 41470         (WebCore::JSCanvasRenderingContext2D::createPattern):
       
 41471 
       
 41472 2007-04-05  Adele Peterson  <adele@apple.com>
       
 41473 
       
 41474         Reviewed by Oliver.
       
 41475 
       
 41476         Fix for <rdar://problem/4965597> REGRESSION: mouseup doesn't fire for slider (causes it to always default to max)
       
 41477 
       
 41478         Test: fast/forms/slider-mouse-events.html
       
 41479 
       
 41480         * page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent):
       
 41481         Since the actual target node of the event can't be a shadow node, set the target node to the capturing node before adjusting it.
       
 41482 
       
 41483 2007-04-05  Kevin McCullough  <kmccullough@apple.com>
       
 41484 
       
 41485         Reviewed by Darin.
       
 41486 
       
 41487         - Added reportLocalLoadFailed to FrameLoader to send an error to the console when
       
 41488         calls to canLoad fail. 
       
 41489 
       
 41490         * loader/Cache.cpp:
       
 41491         (WebCore::Cache::requestResource):
       
 41492         * loader/FrameLoader.cpp:
       
 41493         (WebCore::FrameLoader::loadSubframe):
       
 41494         (WebCore::FrameLoader::loadPlugin):
       
 41495         (WebCore::FrameLoader::load):
       
 41496         (WebCore::FrameLoader::reportLocalLoadFailed):
       
 41497         * loader/FrameLoader.h:
       
 41498         * loader/SubresourceLoader.cpp:
       
 41499         (WebCore::SubresourceLoader::create):
       
 41500 
       
 41501 2007-04-05  Adele Peterson  <adele@apple.com>
       
 41502 
       
 41503         Reviewed by Maciej.
       
 41504 
       
 41505         Add text-align: -webkit-auto for form controls.  Buttons already override this property to center their text.
       
 41506 
       
 41507         * css/html4.css:
       
 41508 
       
 41509 2007-04-05  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 41510 
       
 41511         Reviewed by rwlbuis.
       
 41512 
       
 41513         Coverity fix. Coverity says:
       
 41514         "Event var_deref_model: Variable "page" tracked as NULL was passed to a function that dereferences it."
       
 41515 
       
 41516         * platform/Font.cpp:
       
 41517         (WebCore::Font::glyphDataForCharacter):
       
 41518 
       
 41519 2007-04-05  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 41520 
       
 41521         Reviewed by darin.
       
 41522 
       
 41523         Coverity fix. Coverity says:
       
 41524         "Event var_deref_model: Variable "unicode" tracked as NULL was passed to a 
       
 41525         function that dereferences it."
       
 41526 
       
 41527         * platform/DeprecatedString.cpp:
       
 41528         (WebCore::DeprecatedString::DeprecatedString):
       
 41529 
       
 41530 2007-04-05  Adele Peterson  <adele@apple.com>
       
 41531 
       
 41532         Reviewed by Hyatt.
       
 41533 
       
 41534         Fix for <rdar://problem/5113593> REGRESSION: Search fields in RSS pages don't show ibeam cursor
       
 41535 
       
 41536         * css/html4.css: Set the cursor values explicitly for input, textarea (to auto), & select (to default).
       
 41537 
       
 41538 2007-04-05  David Hyatt  <hyatt@apple.com>
       
 41539 
       
 41540         Fix for <rdar://problem/5078866> tables should only reset text-align
       
 41541         in quirks mode.
       
 41542 
       
 41543         Reviewed by beth
       
 41544 
       
 41545         * css/html4.css:
       
 41546         * css/quirks.css:
       
 41547 
       
 41548 2007-04-05  Adele Peterson  <adele@apple.com>
       
 41549 
       
 41550         Fixing typo that's crashing.
       
 41551 
       
 41552         * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
       
 41553           Use evt instead of null variable k.
       
 41554 
       
 41555 2007-04-05  Adele Peterson  <adele@apple.com>
       
 41556 
       
 41557         Reviewed by Hyatt.
       
 41558 
       
 41559         Fix for <rdar://problem/5021500> Cursor should stay as pointer when slider is being dragged
       
 41560 
       
 41561         Don't set the selection ibeam cursor when there's a node that's capturing mouse events.
       
 41562 
       
 41563         * page/EventHandler.cpp:
       
 41564         (WebCore::selectCursor):
       
 41565         (WebCore::EventHandler::handleMouseMoveEvent):
       
 41566 
       
 41567 2007-04-05  Geoffrey Garen  <ggaren@apple.com>
       
 41568 
       
 41569         Reviewed by Beth Dakin.
       
 41570 
       
 41571         More clean-up while fixing <rdar://problem/5112273> REGRESSION(TOT): 
       
 41572         Reproducible crash loading an old version of amazon.com as a web archive
       
 41573         
       
 41574         Layout tests pass.
       
 41575         
       
 41576         Removed more superfluous document NULL checks. (Node::document() never 
       
 41577         returns NULL, and it asserts as much.)
       
 41578         
       
 41579         Merged some duplicate editing code into a static inline function.
       
 41580         
       
 41581         * page/mac/WebCoreFrameBridge.mm:
       
 41582         (updateRenderingForBindings): Removed superfluous static_cast.
       
 41583 
       
 41584 2007-04-05  Adele Peterson  <adele@apple.com>
       
 41585 
       
 41586         Reviewed by Darin.
       
 41587 
       
 41588         A little cleanup from my last checkin.  Always check if an Event is really a MouseEvent or a KeyboardEvent
       
 41589         before casting it.
       
 41590 
       
 41591         * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
       
 41592         * html/HTMLSelectElement.cpp:
       
 41593         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
       
 41594         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
       
 41595         * html/HTMLTextFieldInnerElement.cpp:
       
 41596         (WebCore::HTMLSearchFieldResultsButtonElement::defaultEventHandler):
       
 41597         (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
       
 41598         * ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
       
 41599         * page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent):
       
 41600         * rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
       
 41601         * rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler):
       
 41602 
       
 41603 2007-04-05  Geoffrey Garen  <ggaren@apple.com>
       
 41604 
       
 41605         Reviewed by Beth Dakin.
       
 41606         
       
 41607         Some clean-up while fixing <rdar://problem/5112273> REGRESSION(TOT): 
       
 41608         Reproducible crash loading an old version of amazon.com as a web archive
       
 41609         
       
 41610         Removed superfluous document NULL checks. (Node::document() never returns
       
 41611         NULL, and it asserts as much.)
       
 41612         
       
 41613         Removed duplicate implementation of displayString.
       
 41614         
       
 41615         Layout tests pass.
       
 41616 
       
 41617         * bindings/objc/DOMInternal.h:
       
 41618         * bindings/objc/DOMInternal.mm:
       
 41619         * html/HTMLGenericFormElement.cpp:
       
 41620         (WebCore::HTMLGenericFormElement::supportsFocus):
       
 41621         * html/HTMLPlugInElement.cpp:
       
 41622         (WebCore::HTMLPlugInElement::createNPObject):
       
 41623         * platform/ContextMenu.cpp:
       
 41624         (WebCore::ContextMenu::checkOrEnableIfNeeded):
       
 41625         * rendering/HitTestResult.cpp:
       
 41626         (WebCore::displayString):
       
 41627         * rendering/HitTestResult.h:
       
 41628         * rendering/RenderLayer.cpp:
       
 41629         (WebCore::RenderLayer::updateHoverActiveState):
       
 41630 
       
 41631 === Safari-5522.6 ===
       
 41632 
       
 41633 2007-04-05  Oliver Hunt  <oliver@apple.com>
       
 41634 
       
 41635         Reviewed by Adam.
       
 41636 
       
 41637         Fix rdar://problem/5030934 -- landscape PDFs embedded as an image are cut off
       
 41638         also fixes scaling of pdf images
       
 41639 
       
 41640         PDFDocumentImage was not accounting for page rotation in a number of places
       
 41641 
       
 41642         * platform/graphics/cg/PDFDocumentImage.cpp:
       
 41643         (WebCore::PDFDocumentImage::size):
       
 41644           we need to account for rotation of the pdf image effecting our bounds
       
 41645         (WebCore::PDFDocumentImage::draw):
       
 41646           When compensating for flipped coords we need to use the correct rect for the 
       
 41647           coordinate space.  We can't pass size() to CGContextDrawPDFDocument as it
       
 41648           returns the rotated bounds now -- this is also save the old 
       
 41649           FloatSize -> IntSize -> FloatSize conversions.
       
 41650           
       
 41651 2007-04-04  Alexey Proskuryakov  <ap@webkit.org>
       
 41652 
       
 41653         Reviewed by Darin.
       
 41654 
       
 41655         http://bugs.webkit.org/show_bug.cgi?id=13278
       
 41656         REGRESSION: cannot change SELECT option
       
 41657 
       
 41658         Test: fast/forms/option-change-single-selected.html
       
 41659 
       
 41660         * html/HTMLSelectElement.cpp:
       
 41661         (WebCore::HTMLSelectElement::setSelectedIndex): If multiple selection is not allowed, 
       
 41662         be sure to deselect the previous option.
       
 41663 
       
 41664 2007-04-04  Adele Peterson  <adele@apple.com>
       
 41665 
       
 41666         Reviewed by Oliver.
       
 41667 
       
 41668         Fix for <rdar://5105009> Prepare for fix to send mousedown and mouseup (but not click) events when right-clicking
       
 41669 
       
 41670         * page/EventHandler.cpp: Don't ever send click events for right-clicks.
       
 41671         (WebCore::EventHandler::handleMouseDoubleClickEvent):
       
 41672         (WebCore::EventHandler::handleMouseReleaseEvent):
       
 41673         
       
 41674         Check that the mousedown and mouseup are not with the right button before performing default behavior.
       
 41675         * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
       
 41676         * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
       
 41677         * html/HTMLSelectElement.cpp:
       
 41678         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
       
 41679         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
       
 41680         * html/HTMLTextFieldInnerElement.cpp:
       
 41681         (WebCore::HTMLSearchFieldResultsButtonElement::defaultEventHandler):
       
 41682         (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
       
 41683         * ksvg2/svg/SVGAElement.cpp:(WebCore::SVGAElement::defaultEventHandler):
       
 41684         * rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
       
 41685         * rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler):
       
 41686 
       
 41687 2007-04-03  Justin Garcia  <justin.garcia@apple.com>
       
 41688 
       
 41689         Reviewed by darin
       
 41690         
       
 41691         <rdar://problem/5026848> Can cut/delete ToDo subunits
       
 41692         
       
 41693         We were removing non-editable content during a delete.
       
 41694 
       
 41695         * editing/DeleteSelectionCommand.cpp: 
       
 41696         (WebCore::DeleteSelectionCommand::initializePositionData): 
       
 41697         Set m_startRoot and m_endRoot.
       
 41698         (WebCore::DeleteSelectionCommand::removeNode): If a node
       
 41699         is not inside both the start and end roots, remove it only
       
 41700         if it is in editable content.
       
 41701         * editing/DeleteSelectionCommand.h: Added m_startRoot and 
       
 41702         m_endRoot, the editable roots that contain the start and end
       
 41703         of the selection, respectively.  We consult these every
       
 41704         time we remove a node, and don't want to recompute them 
       
 41705         on every call to removeNode().
       
 41706 
       
 41707 2007-04-03  David Hyatt  <hyatt@apple.com>
       
 41708 
       
 41709         Fix for <rdar://problem/5108896>, make sure the assert for setEncodedSize
       
 41710         deals with the error case.
       
 41711 
       
 41712         Reviewed by andersca
       
 41713 
       
 41714         * loader/CachedResource.cpp:
       
 41715         (WebCore::CachedResource::setEncodedSize):
       
 41716 
       
 41717 2007-04-03  Anders Carlsson  <andersca@apple.com>
       
 41718 
       
 41719         Reviewed by Dave Hyatt.
       
 41720 
       
 41721         * loader/ImageDocument.cpp:
       
 41722         Don't call error() in stopParsing.
       
 41723 
       
 41724 2007-04-03  Justin Garcia  <justin.garcia@apple.com>
       
 41725 
       
 41726         Reviewed by darin
       
 41727         
       
 41728         <rdar://problem/5107422> 
       
 41729         TOT REGRESSION: Delete key fails to delete text, and cursor disappears in Mail.app
       
 41730         <rdar://problem/5107413> 
       
 41731         TOT REGRESSION: Crash deleting text in email (infinite recursion in shouldInsertNode)
       
 41732 
       
 41733         * editing/CompositeEditCommand.cpp:
       
 41734         (WebCore::CompositeEditCommand::moveParagraphs):
       
 41735         Back out the call to shouldInsert until we
       
 41736         add WebViewInsertActionMoved, because Mail returns
       
 41737         NO from shouldInsert for WebViewInsertActionPasted
       
 41738         to override our Paste operation.
       
 41739 
       
 41740 2007-04-03  Anders Carlsson  <andersca@apple.com>
       
 41741 
       
 41742         Reviewed by Mitz.
       
 41743 
       
 41744         Make window.innerWidth/innerHeight include the size of any present scrollbar to match Firefox.
       
 41745         
       
 41746         Make document.body.clientWidth/clientHeight return the width/height of the visible content when in
       
 41747         quirks mode to match WinIE.
       
 41748         
       
 41749         * bindings/js/kjs_window.cpp:
       
 41750         (KJS::Window::getValueProperty):
       
 41751         Return the width and height of the scroll view, not the visible width and height.
       
 41752         
       
 41753         * dom/Element.cpp:
       
 41754         (WebCore::Element::clientWidth):        
       
 41755         (WebCore::Element::clientHeight):
       
 41756         Return the visible size if the element is the body element and we're in quirks mode.
       
 41757 
       
 41758 2007-04-03  Adele Peterson  <adele@apple.com>
       
 41759 
       
 41760         Reviewed by Darin.
       
 41761 
       
 41762         Updated fix for <rdar://problem/5107095> REGRESSION: disabled text color calculations are slowing down launchtime measurements
       
 41763 
       
 41764         * platform/graphics/Color.cpp: Moved optimization for lightening black and darkening white into the Color class.
       
 41765         (WebCore::Color::light):
       
 41766         (WebCore::Color::dark):
       
 41767         * rendering/RenderTextControl.cpp: (WebCore::disabledTextColor): Skip the difference calculation for black text, which will always be lightened.
       
 41768 
       
 41769 2007-04-03  Anders Carlsson  <andersca@apple.com>
       
 41770 
       
 41771         Reviewed by Tim.
       
 41772 
       
 41773         <rdar://problem/4649516> 
       
 41774         Turn off slow script dialog or crank up time that makes it come up
       
 41775         
       
 41776         * bindings/js/kjs_binding.cpp:
       
 41777         (KJS::ScriptInterpreter::ScriptInterpreter):
       
 41778         Increase the timeout to 10 seconds to match Firefox.
       
 41779 
       
 41780 2007-04-03  Mitz Pettel  <mitz@webkit.org>
       
 41781 
       
 41782         Reviewed by Darin.
       
 41783 
       
 41784         - fix http://bugs.webkit.org/show_bug.cgi?id=13251
       
 41785           editing/style/fontsize-1.html fails intermittently when run multiple times on Intel, generates incorrect DOM
       
 41786 
       
 41787         Covered by existing editing tests.
       
 41788 
       
 41789         * css/CSSPrimitiveValue.cpp:
       
 41790         (WebCore::CSSPrimitiveValue::getFloatValue): Added ASSERTs that the requested conversion
       
 41791         is from a scalar type to a scalar type. The intermittent failures in the test were
       
 41792         the result of trying to convert an identifier type to a scalar type.
       
 41793         * editing/ApplyStyleCommand.cpp:
       
 41794         (WebCore::StyleChange::checkForLegacyHTMLStyleChange): Added a check that the
       
 41795         font-size property value is an absolute length. If it is not (such as in the case
       
 41796         of relative units or keywords like "x-large"), then no corresponding 'size' attribute
       
 41797         will be generated for legacy HTML.
       
 41798 
       
 41799 2007-04-03  Mitz Pettel  <mitz@webkit.org>
       
 41800 
       
 41801         Reviewed by Darin.
       
 41802 
       
 41803         - fix http://bugs.webkit.org/show_bug.cgi?id=13218
       
 41804           <rdar://problem/5095977>
       
 41805           Reproducible crash after call to window.close()
       
 41806 
       
 41807         * manual-tests/stale-currentEvent.html: Added.
       
 41808         * page/EventHandler.cpp:
       
 41809         (WebCore::EventHandler::hoverTimerFired): Instead of faking a mouse event,
       
 41810         just hit-test the last mouse event coordinates and update for hover state
       
 41811         changes. This eliminates the use of currentEvent, which can be a non-mouse
       
 41812         event or even a stale event.
       
 41813 
       
 41814 2007-04-02  Adele Peterson  <adele@apple.com>
       
 41815 
       
 41816         Reviewed by Maciej.
       
 41817 
       
 41818         Fix for <rdar://problem/5107095> REGRESSION: disabled text color calculations are slowing down launchtime measurements
       
 41819 
       
 41820         Hardcode disabled text colors for the most common cases- black and white.
       
 41821 
       
 41822         * rendering/RenderTextControl.cpp: (WebCore::disabledTextColor):
       
 41823 
       
 41824 2007-04-02  David Hyatt  <hyatt@apple.com>
       
 41825 
       
 41826         Fix for <rdar://problem/5105784>, assertion failure in cache.  Encoded sizes were being set to
       
 41827         garbage by accident because of a mismatch between derived class and base class constructors.  This
       
 41828         patch cleans all of this up and gets rid of expiration date as a concept separate from the response.
       
 41829 
       
 41830         Reviewed by anders
       
 41831 
       
 41832         * dom/Document.cpp:
       
 41833         (WebCore::Document::processHttpEquiv):
       
 41834         * html/HTMLImageLoader.cpp:
       
 41835         (WebCore::HTMLImageLoader::updateFromElement):
       
 41836         * loader/Cache.cpp:
       
 41837         (WebCore::createResource):
       
 41838         (WebCore::Cache::requestResource):
       
 41839         * loader/Cache.h:
       
 41840         * loader/CachedCSSStyleSheet.cpp:
       
 41841         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
       
 41842         * loader/CachedCSSStyleSheet.h:
       
 41843         * loader/CachedImage.cpp:
       
 41844         (WebCore::CachedImage::CachedImage):
       
 41845         * loader/CachedImage.h:
       
 41846         * loader/CachedResource.cpp:
       
 41847         (WebCore::CachedResource::CachedResource):
       
 41848         (WebCore::CachedResource::finish):
       
 41849         * loader/CachedResource.h:
       
 41850         * loader/CachedScript.cpp:
       
 41851         (WebCore::CachedScript::CachedScript):
       
 41852         * loader/CachedScript.h:
       
 41853         * loader/CachedXBLDocument.cpp:
       
 41854         (WebCore::CachedXBLDocument::CachedXBLDocument):
       
 41855         * loader/CachedXBLDocument.h:
       
 41856         * loader/CachedXSLStyleSheet.cpp:
       
 41857         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
       
 41858         * loader/CachedXSLStyleSheet.h:
       
 41859         * loader/DocLoader.cpp:
       
 41860         (WebCore::DocLoader::DocLoader):
       
 41861         (WebCore::DocLoader::requestResource):
       
 41862         * loader/DocLoader.h:
       
 41863 
       
 41864 2007-04-03  Antti Koivisto  <antti@apple.com>
       
 41865 
       
 41866         Reviewed by Hyatt.
       
 41867 
       
 41868         Render tree memory savings, part 3
       
 41869         
       
 41870         These changes shrink all RenderBlocks by additional 28 bytes. Together with parts 1 and 2
       
 41871         RenderBlock goes from 172 bytes to 128 bytes, a saving of 26%.
       
 41872         
       
 41873         - Pack bitfields together in RenderFlow
       
 41874         - Move top/bottom min/max margin values to a struct that is only allocated in case these
       
 41875           variables have non default values. Usually this is <5% of all blocks. 
       
 41876         - Move rarely used column variables to hash
       
 41877 
       
 41878         * rendering/RenderBlock.cpp:
       
 41879         (WebCore::ColumnInfo::ColumnInfo):
       
 41880         (WebCore::RenderBlock::RenderBlock):
       
 41881         (WebCore::RenderBlock::~RenderBlock):
       
 41882         (WebCore::RenderBlock::layoutBlock):
       
 41883         (WebCore::RenderBlock::collapseMargins):
       
 41884         (WebCore::RenderBlock::clearFloatsIfNeeded):
       
 41885         (WebCore::RenderBlock::setCollapsedBottomMargin):
       
 41886         (WebCore::RenderBlock::layoutBlockChildren):
       
 41887         (WebCore::RenderBlock::paintColumns):
       
 41888         (WebCore::RenderBlock::paintObject):
       
 41889         (WebCore::RenderBlock::fillSelectionGaps):
       
 41890         (WebCore::RenderBlock::lowestPosition):
       
 41891         (WebCore::RenderBlock::rightmostPosition):
       
 41892         (WebCore::RenderBlock::leftmostPosition):
       
 41893         (WebCore::RenderBlock::nodeAtPoint):
       
 41894         (WebCore::RenderBlock::hitTestColumns):
       
 41895         (WebCore::RenderBlock::positionForCoordinates):
       
 41896         (WebCore::RenderBlock::availableWidth):
       
 41897         (WebCore::RenderBlock::calcColumnWidth):
       
 41898         (WebCore::RenderBlock::setDesiredColumnCountAndWidth):
       
 41899         (WebCore::RenderBlock::desiredColumnWidth):
       
 41900         (WebCore::RenderBlock::desiredColumnCount):
       
 41901         (WebCore::RenderBlock::columnRects):
       
 41902         (WebCore::RenderBlock::layoutColumns):
       
 41903         (WebCore::RenderBlock::adjustPointToColumnContents):
       
 41904         (WebCore::RenderBlock::adjustRectForColumns):
       
 41905         (WebCore::RenderBlock::setMaxTopMargins):
       
 41906         (WebCore::RenderBlock::setMaxBottomMargins):
       
 41907         * rendering/RenderBlock.h:
       
 41908         (WebCore::RenderBlock::maxTopMargin):
       
 41909         (WebCore::RenderBlock::maxBottomMargin):
       
 41910         (WebCore::RenderBlock::maxTopPosMargin):
       
 41911         (WebCore::RenderBlock::maxTopNegMargin):
       
 41912         (WebCore::RenderBlock::maxBottomPosMargin):
       
 41913         (WebCore::RenderBlock::maxBottomNegMargin):
       
 41914         (WebCore::RenderBlock::initMaxMarginValues):
       
 41915         (WebCore::RenderBlock::MaxMargin::MaxMargin):
       
 41916         (WebCore::RenderBlock::MaxMargin::topPosDefault):
       
 41917         (WebCore::RenderBlock::MaxMargin::topNegDefault):
       
 41918         (WebCore::RenderBlock::MaxMargin::bottomPosDefault):
       
 41919         (WebCore::RenderBlock::MaxMargin::bottomNegDefault):
       
 41920         * rendering/RenderFlexibleBox.cpp:
       
 41921         (WebCore::RenderFlexibleBox::layoutBlock):
       
 41922         * rendering/RenderFlow.h:
       
 41923         (WebCore::RenderFlow::RenderFlow):
       
 41924         (WebCore::RenderFlow::hasColumns):
       
 41925         * rendering/RenderInline.cpp:
       
 41926         (WebCore::RenderInline::RenderInline):
       
 41927         * rendering/RenderInline.h:
       
 41928 
       
 41929 2007-04-03  Antti Koivisto  <antti@apple.com>
       
 41930 
       
 41931         Reviewed by Hyatt.
       
 41932 
       
 41933         Fix asserts, these may also be called for rel positioned elements
       
 41934 
       
 41935         * rendering/RenderBox.cpp:
       
 41936         (WebCore::RenderBox::setStaticX):
       
 41937         (WebCore::RenderBox::setStaticY):
       
 41938 
       
 41939 2007-04-02  David Hyatt  <hyatt@apple.com>
       
 41940 
       
 41941         Throw in an assert to try to track down a problem where an image is being set to a smaller encoded
       
 41942         size.
       
 41943 
       
 41944         * loader/CachedResource.cpp:
       
 41945         (WebCore::CachedResource::setEncodedSize):
       
 41946 
       
 41947 2007-04-02  Ada Chan  <adachan@apple.com>
       
 41948 
       
 41949         Reviewed by Adele.
       
 41950 
       
 41951         <rdar://5105331> Missing null check in Editor::execCommand
       
 41952         Added null check.
       
 41953 
       
 41954         * editing/Editor.cpp:
       
 41955         (WebCore::Editor::execCommand):
       
 41956 
       
 41957 2007-04-02  Justin Garcia  <justin.garcia@apple.com>
       
 41958 
       
 41959         Reviewed by darin
       
 41960 
       
 41961         <rdar://problem/5058163> 
       
 41962         Hitting return inserts a new line between two To Dos, but caret is position after second ToDo
       
 41963 
       
 41964         * editing/InsertParagraphSeparatorCommand.cpp:
       
 41965         (WebCore::InsertParagraphSeparatorCommand::doApply):
       
 41966         Removed refPos, it was unused.
       
 41967         Don't assume that upstream() moves to a different
       
 41968         node.  This assumption caused the line break to
       
 41969         be inserted *after* the caret and a bad position
       
 41970         to be set (added a testcase).
       
 41971         Use isStartOfParagraph instead of checking
       
 41972         for the existence of a br because the line might 
       
 41973         be broken by a newline character in text that 
       
 41974         preserves newlines.  Paragraphs that are created 
       
 41975         in other ways, like with blocks, are handled 
       
 41976         above (added a testcase).
       
 41977 
       
 41978  2007-04-02  David Harrison  <harrison@apple.com>
       
 41979 
       
 41980         Reviewed by Darin.
       
 41981 
       
 41982         <rdar://problem/4906488> text attributes are not working for frame based web page
       
 41983 
       
 41984         Attribute handling now treats each WebArea as its own world, rather than sometimes
       
 41985         referring back up to the top WebArea. e.g. getting/setting the selection now
       
 41986         operates on the WebArea containing the WebCoreAXObject that is being messaged (self).
       
 41987         The methods that sit above this and are able to go into arbitrary WebAreas
       
 41988         are accessibilityFocusedUIElement and doAXTextMarkerForPosition, allowing VoiceOver
       
 41989         to navigate between frames.
       
 41990         
       
 41991         * bridge/mac/WebCoreAXObject.mm:
       
 41992         (-[WebCoreAXObject topRenderer]):
       
 41993         (-[WebCoreAXObject frameView]):
       
 41994         (-[WebCoreAXObject topFrameView]):
       
 41995         Removed topDocument, renamed topView to topFrameView, added frameView.
       
 41996         
       
 41997         (-[WebCoreAXObject accessibilityAttributeValue:]):
       
 41998         AXSelectedTextMarkerRange, AXStartTextMarker, and AXEndTextMarker now use
       
 41999         self's WebArea, rather than the top WebArea.
       
 42000         
       
 42001         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
       
 42002         Use self's WebArea, rather than the top WebArea.
       
 42003 
       
 42004         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
       
 42005         Use renamed methods for accessing top WebArea.
       
 42006          
       
 42007         (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
       
 42008         Use renamed methods for accessing self's WebArea.
       
 42009 
       
 42010         (AXAttributeStringSetColor):
       
 42011         (AXAttributeStringSetNumber):
       
 42012         (AXAttributeStringSetFont):
       
 42013         (AXAttributeStringSetStyle):
       
 42014         (AXAttributeStringSetElement):
       
 42015         (-[WebCoreAXObject rendererForView:]):
       
 42016         Clean up uses of nil and NULL.
       
 42017         
       
 42018         (-[WebCoreAXObject accessibilityFocusedUIElement]):
       
 42019         Find the focused node on the whole page. If there is no focused node,
       
 42020         return the WebArea for the focused document.
       
 42021         
       
 42022         (-[WebCoreAXObject doSetAXSelectedTextMarkerRange:]):
       
 42023         Use self's WebArea, rather than the top WebArea.
       
 42024 
       
 42025 2007-04-02  Antti Koivisto  <antti@apple.com>
       
 42026 
       
 42027         Fix build. This one was not supposed to be checked in.
       
 42028 
       
 42029         * rendering/RenderFlexibleBox.cpp:
       
 42030         (WebCore::RenderFlexibleBox::layoutBlock):
       
 42031 
       
 42032 2007-03-30  Antti Koivisto  <antti@apple.com>
       
 42033 
       
 42034         Reviewed by Hyatt.
       
 42035 
       
 42036         Render tree memory savings, part 2
       
 42037         
       
 42038         - Move staticX and staticY variables to RenderLayer since they are only
       
 42039           applicable to positioned objects
       
 42040         - Move very rarely used overrideSize variable to hash
       
 42041         
       
 42042         These changes shrink all box types by 12 bytes
       
 42043 
       
 42044         * rendering/RenderBox.cpp:
       
 42045         (WebCore::RenderBox::RenderBox):
       
 42046         (WebCore::RenderBox::destroy):
       
 42047         (WebCore::RenderBox::overrideSize):
       
 42048         (WebCore::RenderBox::setOverrideSize):
       
 42049         (WebCore::RenderBox::overrideWidth):
       
 42050         (WebCore::RenderBox::overrideHeight):
       
 42051         (WebCore::RenderBox::position):
       
 42052         (WebCore::RenderBox::calcWidth):
       
 42053         (WebCore::RenderBox::calcHeight):
       
 42054         (WebCore::RenderBox::staticX):
       
 42055         (WebCore::RenderBox::staticY):
       
 42056         (WebCore::RenderBox::setStaticX):
       
 42057         (WebCore::RenderBox::setStaticY):
       
 42058         (WebCore::RenderBox::calcAbsoluteHorizontal):
       
 42059         (WebCore::RenderBox::calcAbsoluteVertical):
       
 42060         (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
       
 42061         (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
       
 42062         * rendering/RenderBox.h:
       
 42063         * rendering/RenderLayer.cpp:
       
 42064         (WebCore::RenderLayer::RenderLayer):
       
 42065         * rendering/RenderLayer.h:
       
 42066         (WebCore::RenderLayer::staticX):
       
 42067         (WebCore::RenderLayer::staticY):
       
 42068         (WebCore::RenderLayer::setStaticX):
       
 42069         (WebCore::RenderLayer::setStaticY):
       
 42070         * rendering/RenderObject.cpp:
       
 42071         (WebCore::RenderObject::RenderObject):
       
 42072         * rendering/RenderObject.h:
       
 42073         (WebCore::):
       
 42074         (WebCore::RenderObject::hasOverrideSize):
       
 42075         (WebCore::RenderObject::setHasOverrideSize):
       
 42076         * rendering/RenderWidget.cpp:
       
 42077         (WebCore::RenderWidget::destroy):
       
 42078 
       
 42079 2007-03-31  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 42080 
       
 42081         Not reviewed - gdk build fix.
       
 42082 
       
 42083         * platform/gdk/TemporaryLinkStubs.cpp:
       
 42084         (Font::selectionRectForComplexText):
       
 42085         (Font::drawComplexText):
       
 42086 
       
 42087 2007-03-31  Alexey Proskuryakov  <ap@webkit.org>
       
 42088 
       
 42089         Reviewed by Darin.
       
 42090 
       
 42091         http://bugs.webkit.org/show_bug.cgi?id=12778
       
 42092         REGRESSION: Nightly won't load Curl plugin for full page use
       
 42093 
       
 42094         * dom/DOMImplementation.cpp:
       
 42095         (WebCore::DOMImplementation::createDocument): Re-order cases to give more priority to plugins.
       
 42096         This also fixes Adobe SVG Viewer and any plugins that register XML MIME types.
       
 42097         Added a case for XHTML to avoid enumerating plugins.
       
 42098 
       
 42099 2007-03-31  David Hyatt  <hyatt@apple.com>
       
 42100 
       
 42101         Fix for bug 13234, layout of selected justified text is broken.  Rework TextRuns to avoid having
       
 42102         from/to members.  Let those be passed in only by the functions that need them (drawing and selection rect).
       
 42103 
       
 42104         Reviewed by mitz
       
 42105 
       
 42106         fast/text/justified-selection-at-edge.html
       
 42107 
       
 42108         * platform/Font.cpp:
       
 42109         (WebCore::WidthIterator::WidthIterator):
       
 42110         (WebCore::WidthIterator::advance):
       
 42111         (WebCore::Font::canUseGlyphCache):
       
 42112         (WebCore::Font::drawSimpleText):
       
 42113         (WebCore::Font::drawText):
       
 42114         (WebCore::Font::floatWidth):
       
 42115         (WebCore::Font::floatWidthForSimpleText):
       
 42116         (WebCore::Font::selectionRectForText):
       
 42117         (WebCore::Font::selectionRectForSimpleText):
       
 42118         (WebCore::Font::offsetForPositionForSimpleText):
       
 42119         * platform/Font.h:
       
 42120         (WebCore::TextRun::m_len):
       
 42121         * platform/graphics/GraphicsContext.cpp:
       
 42122         (WebCore::GraphicsContext::drawText):
       
 42123         (WebCore::GraphicsContext::drawHighlightForText):
       
 42124         * platform/graphics/GraphicsContext.h:
       
 42125         * platform/mac/FontMac.mm:
       
 42126         (WebCore::addDirectionalOverride):
       
 42127         (WebCore::overrideLayoutOperation):
       
 42128         (WebCore::ATSULayoutParameters::initialize):
       
 42129         (WebCore::Font::selectionRectForComplexText):
       
 42130         (WebCore::Font::drawComplexText):
       
 42131         (WebCore::Font::floatWidthForComplexText):
       
 42132         (WebCore::Font::offsetForPositionForComplexText):
       
 42133         * platform/qt/FontQt.cpp:
       
 42134         (WebCore::Font::drawComplexText):
       
 42135         (WebCore::Font::floatWidthForComplexText):
       
 42136         * platform/qt/TemporaryLinkStubs.cpp:
       
 42137         (Font::selectionRectForComplexText):
       
 42138         * rendering/EllipsisBox.cpp:
       
 42139         (WebCore::EllipsisBox::paint):
       
 42140         * rendering/InlineTextBox.cpp:
       
 42141         (WebCore::InlineTextBox::selectionRect):
       
 42142         (WebCore::InlineTextBox::paint):
       
 42143         (WebCore::InlineTextBox::paintSelection):
       
 42144         (WebCore::InlineTextBox::paintMarkedTextBackground):
       
 42145         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
       
 42146         (WebCore::InlineTextBox::paintTextMatchMarker):
       
 42147         (WebCore::InlineTextBox::offsetForPosition):
       
 42148         (WebCore::InlineTextBox::positionForOffset):
       
 42149         * rendering/RenderListMarker.cpp:
       
 42150         (WebCore::RenderListMarker::paint):
       
 42151         (WebCore::RenderListMarker::calcMinMaxWidth):
       
 42152         (WebCore::RenderListMarker::getRelativeMarkerRect):
       
 42153         * rendering/RenderMenuList.cpp:
       
 42154         (WebCore::RenderMenuList::updateOptionsWidth):
       
 42155         * rendering/RenderText.cpp:
       
 42156         (WebCore::RenderText::widthFromCache):
       
 42157         (WebCore::RenderText::width):
       
 42158 
       
 42159 2007-03-31  Mitz Pettel  <mitz@webkit.org>
       
 42160 
       
 42161         Reviewed by Darin.
       
 42162 
       
 42163         - fix http://bugs.webkit.org/show_bug.cgi?id=13243
       
 42164               <rdar://problem/5103226>
       
 42165           REGRESSION (r20506): Repro crash/assert when using scroll wheel on a list box taller than its contents
       
 42166 
       
 42167         * platform/ScrollBar.cpp:
       
 42168         (WebCore::Scrollbar::setValue): Cleaned up a little.
       
 42169         (WebCore::Scrollbar::scroll): Changed to apply the minimum and maximum constraints
       
 42170         in the right order, and cleaned up a little.
       
 42171 
       
 42172 2007-03-31  Mitz Pettel  <mitz@webkit.org>
       
 42173 
       
 42174         Reviewed by Darin.
       
 42175 
       
 42176         - fix http://bugs.webkit.org/show_bug.cgi?id=13242
       
 42177           REGRESSION: Repro crash when specifying the content property for an image
       
 42178 
       
 42179         Test: fast/images/text-content-crash.html
       
 42180 
       
 42181         * html/HTMLImageElement.cpp:
       
 42182         (WebCore::HTMLImageElement::parseMappedAttribute): Added a check that the
       
 42183         renderer is an image.
       
 42184         (WebCore::HTMLImageElement::attach): Ditto.
       
 42185 
       
 42186 2007-03-31  Mark Rowe  <mrowe@apple.com>
       
 42187 
       
 42188         Reviewed by Darin.
       
 42189 
       
 42190         A more correct fix for http://bugs.webkit.org/show_bug.cgi?id=13129
       
 42191         Bug 13129: Democracy Player dies in NSException from WebScriptObject on startup
       
 42192 
       
 42193         The previous attempt at a fix in r20343 attempted to conditionally expose the 'count'
       
 42194         method.  It did not work which resulted in 'count' always being hidden.  This change
       
 42195         disables -[WebScriptObject count] completely until it can be determined whether it is
       
 42196         needed and how to support it without breaking third-party applications.
       
 42197 
       
 42198         * bindings/objc/WebScriptObject.mm:
       
 42199         (-[WebScriptObject count]):
       
 42200         * bindings/objc/WebScriptObjectPrivate.h:
       
 42201 
       
 42202 2007-03-31  Nicholas Shanks  <webkit@nickshanks.com>
       
 42203 
       
 42204         Reviewed by Adele.
       
 42205 
       
 42206         http://bugs.webkit.org/show_bug.cgi?id=13184
       
 42207         HTMLImageElement longdesc should be complete resolved URL
       
 42208 
       
 42209         Test: fast/dom/HTMLImageElement/image-longdesc-absolute-url.html
       
 42210 
       
 42211         * html/HTMLImageElement.cpp:
       
 42212         (WebCore::HTMLImageElement::longDesc): Return absolute URL.
       
 42213         Behaviour now matches Firefox and Opera.
       
 42214 
       
 42215 2007-03-31  Mitz Pettel  <mitz@webkit.org>
       
 42216 
       
 42217         Reviewed by Hyatt.
       
 42218 
       
 42219         - fix http://bugs.webkit.org/show_bug.cgi?id=13209
       
 42220           REGRESSION (r18756-18765): Incomplete list marker repaint when resizing list item
       
 42221 
       
 42222         Test: fast/repaint/list-marker-2.html
       
 42223 
       
 42224         A list marker can increase the horizontal overflow after layoutInlineChildren(),
       
 42225         so made that function return only the vertical bounds of the repaint rect. As the
       
 42226         horizontal bounds, made layoutBlock() just use the overflow bounds after layout.
       
 42227 
       
 42228         * rendering/RenderBlock.cpp:
       
 42229         (WebCore::RenderBlock::layoutBlock):
       
 42230         * rendering/RenderBlock.h:
       
 42231         * rendering/bidi.cpp:
       
 42232         (WebCore::RenderBlock::layoutInlineChildren):
       
 42233 
       
 42234 2007-03-31  Mitz Pettel  <mitz@webkit.org>
       
 42235 
       
 42236         Reviewed by Hyatt.
       
 42237 
       
 42238         - http://bugs.webkit.org/show_bug.cgi?id=13178
       
 42239           Helvetica zero-width space has non-zero width
       
 42240 
       
 42241         Test: fast/text/wide-zero-width-space.html
       
 42242 
       
 42243         * platform/FontData.cpp:
       
 42244         (WebCore::FontData::FontData): Force the ZERO WIDTH SPACE glyph to have width
       
 42245         0, unless the SPACE character maps to the same glyph.
       
 42246 
       
 42247 2007-03-31  Mitz Pettel  <mitz@webkit.org>
       
 42248 
       
 42249         Reviewed by Darin.
       
 42250 
       
 42251         - fix http://bugs.webkit.org/show_bug.cgi?id=8016
       
 42252           REPRO: Safari hangs loading 18 MB page (deeply nested DOM tree)
       
 42253 
       
 42254         Test: fast/tokenizer/lessthan-terminates-tags-and-attrs.html
       
 42255 
       
 42256         * html/HTMLTokenizer.cpp:
       
 42257         (WebCore::HTMLTokenizer::parseTag): Made "<" terminate tag and attribute
       
 42258         names. This matches Firefox.
       
 42259 
       
 42260 2007-03-31  Alexey Proskuryakov  <ap@webkit.org>
       
 42261 
       
 42262         Debug build fix.
       
 42263 
       
 42264         * xml/XPathValue.cpp:
       
 42265         (WebCore::XPath::): Define Value::adopt.
       
 42266 
       
 42267 2007-03-30  Alexey Proskuryakov  <ap@webkit.org>
       
 42268 
       
 42269         Reviewed by Darin.
       
 42270 
       
 42271         http://bugs.webkit.org/show_bug.cgi?id=13021
       
 42272         XPath can be very slow
       
 42273 
       
 42274         This patch finally makes us faster than Firefox 2.0 on this test case.
       
 42275 
       
 42276         * xml/XPathFunctions.cpp:
       
 42277         (WebCore::XPath::FunConcat::evaluate): Use a Vector buffer for faster appending.
       
 42278         (WebCore::XPath::FunId::evaluate): Move the result NodeSet into Value instead of copying it.
       
 42279         (WebCore::XPath::FunLocalName::evaluate): Cosmetic changes.
       
 42280         (WebCore::XPath::FunNamespaceURI::evaluate): Ditto.
       
 42281         (WebCore::XPath::FunName::evaluate): Ditto.
       
 42282         (WebCore::XPath::FunNormalizeSpace::evaluate): Ditto.
       
 42283 
       
 42284         * xml/XPathValue.cpp:
       
 42285         (WebCore::XPath::Value::toNodeSet):
       
 42286         (WebCore::XPath::Value::modifiableNodeSet):
       
 42287         (WebCore::XPath::Value::toBoolean):
       
 42288         (WebCore::XPath::Value::toNumber):
       
 42289         (WebCore::XPath::Value::toString):
       
 42290         * xml/XPathValue.h:
       
 42291         (WebCore::XPath::ValueData::ValueData):
       
 42292         (WebCore::XPath::Value::Value):
       
 42293         Made Value copying faster by putting large data members into a separate refcounted ValueData class.
       
 42294         Added provisions for moving a NodeSet in and out of Value without copying.
       
 42295         Made construction safer by moving bool version to a template constructor.
       
 42296         Removed an (almost) unused default constructor.
       
 42297 
       
 42298         * xml/XPathPredicate.h: Store a Value for literal string and number expressions to avoid 
       
 42299         constructing one each time.
       
 42300 
       
 42301         * xml/XPathPath.cpp:
       
 42302         (WebCore::XPath::Filter::evaluate):
       
 42303         (WebCore::XPath::LocationPath::evaluate):
       
 42304         (WebCore::XPath::Path::evaluate):
       
 42305         * xml/XPathPath.h:
       
 42306         * xml/XPathPredicate.cpp:
       
 42307         (WebCore::XPath::NumericOp::evaluate):
       
 42308         (WebCore::XPath::Union::evaluate):
       
 42309         * xml/XPathResult.cpp:
       
 42310         (WebCore::XPathResult::snapshotItem):
       
 42311         * xml/XPathStep.cpp:
       
 42312         (WebCore::XPath::Step::evaluate):
       
 42313         (WebCore::XPath::Step::nodesInAxis):
       
 42314         * xml/XPathStep.h:
       
 42315         Got rid of unnecessary NodeSet copying in many cases.
       
 42316 
       
 42317 2007-03-30  Justin Garcia  <justin.garcia@apple.com>
       
 42318 
       
 42319         Reviewed by john
       
 42320 
       
 42321         <rdar://problem/5076323> Only one To Do can be created by a selection in a message
       
 42322 
       
 42323         When Mail's ToDoify operation called moveToEndOfDocument: 
       
 42324         with a selection that started just before a ToDo, we'd 
       
 42325         move them to the end of the document, not to the end
       
 42326         of the editable root, because we incorrectly checked
       
 42327         for the editability of positions before ToDos.  Then Mail
       
 42328         would refuse to create a ToDo because the selection was 
       
 42329         outside of the region where they allowed editing.
       
 42330 
       
 42331         * editing/SelectionController.cpp:
       
 42332         (WebCore::SelectionController::modifyExtendingRightForward):
       
 42333         Check the position for editability, not the position's node,
       
 42334         since there are editable positions of the form [node, offset]
       
 42335         where node is contenteditable=false.
       
 42336         Re-use pos.  Nothing that happens after it's created can invalidate
       
 42337         it or the position and affinity used to create it.
       
 42338         (WebCore::SelectionController::modifyMovingRightForward): Ditto.
       
 42339         (WebCore::SelectionController::modifyExtendingLeftBackward): Ditto.
       
 42340         (WebCore::SelectionController::modifyMovingLeftBackward): Ditto.
       
 42341         * rendering/RenderBlock.cpp:
       
 42342         (WebCore::RenderBlock::paintCaret): Ditto.
       
 42343 
       
 42344 2007-03-30  Adele Peterson  <adele@apple.com>
       
 42345 
       
 42346         Reviewed by Darin.
       
 42347 
       
 42348         Added DeleteWordBackward and DeleteWordForward to execCommand.
       
 42349 
       
 42350         * editing/Editor.cpp:
       
 42351         (WebCore::execDeleteWordBackward):
       
 42352         (WebCore::execDeleteWordForward):
       
 42353         (WebCore::CommandEntry::):
       
 42354 
       
 42355 2007-03-30  Simon Hausmann  <hausmann@kde.org>
       
 42356 
       
 42357         Reviewed by Zack
       
 42358 
       
 42359         * WebCore.pro: Fix release Qt builds.
       
 42360 
       
 42361 2007-03-30  Antti Koivisto  <antti@apple.com>
       
 42362 
       
 42363         Reviewed by bdash.
       
 42364 
       
 42365         Spotted an int that should be float in previous patch.
       
 42366 
       
 42367         * platform/Font.cpp:
       
 42368         (WebCore::WidthIterator::advance):
       
 42369 
       
 42370 2007-03-30  Antti Koivisto  <antti@apple.com>
       
 42371 
       
 42372         Reviewed by Hyatt.
       
 42373 
       
 42374         Render tree memory savings, part 1
       
 42375         
       
 42376         - Eliminate caching of monospace char width from RenderText. This optimization is not needed
       
 42377           anymore since Font already caches space width (RenderText -4 bytes)
       
 42378         - Eliminate caching of tab width from RenderBlock. Similary this optimization has become
       
 42379           obsolete (RenderBlock -4 bytes)
       
 42380 
       
 42381         * platform/Font.cpp:
       
 42382         (WebCore::WidthIterator::advance):
       
 42383         (WebCore::Font::spaceWidth):
       
 42384         * platform/Font.h:
       
 42385         (WebCore::Font::tabWidth):
       
 42386         * platform/TextStyle.h:
       
 42387         (WebCore::TextStyle::TextStyle):
       
 42388         (WebCore::TextStyle::allowTabs):
       
 42389         * rendering/InlineTextBox.cpp:
       
 42390         (WebCore::InlineTextBox::selectionRect):
       
 42391         (WebCore::InlineTextBox::paint):
       
 42392         (WebCore::InlineTextBox::paintSelection):
       
 42393         (WebCore::InlineTextBox::paintMarkedTextBackground):
       
 42394         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
       
 42395         (WebCore::InlineTextBox::paintTextMatchMarker):
       
 42396         (WebCore::InlineTextBox::offsetForPosition):
       
 42397         (WebCore::InlineTextBox::positionForOffset):
       
 42398         * rendering/RenderBlock.cpp:
       
 42399         (WebCore:::RenderFlow):
       
 42400         (WebCore::RenderBlock::setStyle):
       
 42401         * rendering/RenderBlock.h:
       
 42402         * rendering/RenderObject.cpp:
       
 42403         * rendering/RenderObject.h:
       
 42404         * rendering/RenderText.cpp:
       
 42405         (WebCore::RenderText::RenderText):
       
 42406         (WebCore::RenderText::setStyle):
       
 42407         (WebCore::RenderText::widthFromCache):
       
 42408         (WebCore::RenderText::trimmedMinMaxWidth):
       
 42409         (WebCore::RenderText::calcMinMaxWidthInternal):
       
 42410         (WebCore::RenderText::setTextInternal):
       
 42411         (WebCore::RenderText::width):
       
 42412         * rendering/RenderText.h:
       
 42413         (WebCore::RenderText::allowTabs):
       
 42414         * rendering/bidi.cpp:
       
 42415 
       
 42416 2007-03-30  David Hyatt  <hyatt@apple.com>
       
 42417 
       
 42418         Fix (take 2) for bug 4334, flickering when floating elements gain/lose transparency.
       
 42419 
       
 42420         Reviewed by mitz
       
 42421 
       
 42422         * rendering/RenderBlock.cpp:
       
 42423         * rendering/RenderBlock.h:
       
 42424         * rendering/RenderBox.cpp:
       
 42425         (WebCore::RenderBox::setStyle):
       
 42426 
       
 42427 2007-03-29  Mitz Pettel  <mitz@webkit.org>
       
 42428 
       
 42429         Reviewed by Darin.
       
 42430 
       
 42431         - fix http://bugs.webkit.org/show_bug.cgi?id=13166
       
 42432           REGRESSION (2005-10-16 - 2005-10-19): Ampersands showing up in the last column of the Gmail contacts table
       
 42433 
       
 42434         Test: fast/tokenizer/write-partial-entity.html
       
 42435 
       
 42436         * html/HTMLTokenizer.cpp:
       
 42437         (WebCore::HTMLTokenizer::parseTag): Reordered to avoid resetting the buffer position
       
 42438         after script execution which can write to the buffer.
       
 42439 
       
 42440 2007-03-29  Justin Garcia  <justin.garcia@apple.com>
       
 42441 
       
 42442         Reviewed by john
       
 42443 
       
 42444         <rdar://problem/5099303> Deleting after a ToDo puts the caret in the wrong position
       
 42445         
       
 42446         We were failing to create the correct selection 
       
 42447         for DeleteSelectionCommand because the selection extension 
       
 42448         operations don't skip over non-editable content for editable 
       
 42449         selections.
       
 42450 
       
 42451         * editing/SelectionController.cpp:
       
 42452         (WebCore::SelectionController::modifyExtendingRightForward):
       
 42453         When extending an editable selection, don't extend into
       
 42454         non-editable content.
       
 42455         (WebCore::SelectionController::modifyExtendingLeftBackward):
       
 42456         Ditto.
       
 42457 
       
 42458 2007-03-29  Patti Hoa  <patti@apple.com>
       
 42459 
       
 42460         Reviewed by harrison.
       
 42461 
       
 42462         <rdar://problem/4918397> Exception raise inspecting note contents in the background
       
 42463         * WebCore.xcodeproj/project.pbxproj:
       
 42464         * bridge/mac/WebCoreAXObject.mm:
       
 42465         (-[WebCoreAXObject subrole]):
       
 42466         (-[WebCoreAXObject title]):
       
 42467         Check that attachment supports the attribute before requesting it.
       
 42468 
       
 42469 2007-03-29  Justin Garcia  <justin.garcia@apple.com>
       
 42470 
       
 42471         Reviewed by john
       
 42472 
       
 42473         <rdar://problem/5032066> Delete should work between ToDos
       
 42474         
       
 42475         Stop selecting the table when the user attempts to delete
       
 42476         the line break just after it, instead, extend the selection
       
 42477         into the last table cell.
       
 42478         Let deletion merge content into table cells (as long as 
       
 42479         its not from another table cell).  
       
 42480         Start calling shouldInsertNode:replacingDOMRange:givenAction: 
       
 42481         when moving content with moveParagraphs, so that Mail can 
       
 42482         modify content before it is moved into a ToDo during a delete.
       
 42483 
       
 42484         * editing/CompositeEditCommand.cpp:
       
 42485         (WebCore::CompositeEditCommand::moveParagraphs): Ask the
       
 42486         delegate before performing the move.  This will let Mail
       
 42487         prevent styles from entering a ToDo.
       
 42488         Added a FIXME about adding a new WebViewInsertAction
       
 42489         * editing/DeleteSelectionCommand.cpp:
       
 42490         (WebCore::DeleteSelectionCommand::initializePositionData):
       
 42491         Allow merging into table cells from content not in a table.
       
 42492         * editing/SelectionController.cpp:
       
 42493         (WebCore::SelectionController::modifyExtendingRightForward):
       
 42494         Don't select the table when extending by character/word from
       
 42495         just before it.  This code was here to make it easier to select
       
 42496         tables in order to delete them, but the deletion UI makes it 
       
 42497         largely unnecessary.
       
 42498         (WebCore::SelectionController::modifyExtendingLeftBackward):
       
 42499         Ditto.
       
 42500         * editing/TypingCommand.cpp:
       
 42501         (WebCore::isFirstPositionAfterTable): Added.
       
 42502         (WebCore::isLastPositionBeforeTable): Ditto.
       
 42503         (WebCore::TypingCommand::deleteKeyPressed): When pressing
       
 42504         the delete key with a caret at the beginning of a paragraph
       
 42505         just after a table, move the paragraph into the last table
       
 42506         cell.
       
 42507         Do not do this if it would mean moving a block table.
       
 42508         Removed some old irrelevant comments.
       
 42509         * editing/htmlediting.cpp: Removed unused functions.
       
 42510         * editing/htmlediting.h:
       
 42511 
       
 42512 2007-03-29  Adam Treat  <adam@staikos.net>
       
 42513 
       
 42514         Reviewed and committed by George Staikos.
       
 42515 
       
 42516         Remove redundant line.
       
 42517 
       
 42518         * platform/qt/FontDataQt.cpp:
       
 42519         (WebCore::FontData::platformInit):
       
 42520 
       
 42521 2007-03-29  Adam Treat  <adam@staikos.net>
       
 42522 
       
 42523         Reviewed by David Hyatt, committed by George Staikos.
       
 42524 
       
 42525         Test: fast/text/justified-selection.html
       
 42526 
       
 42527         Take into account the entire run length to get a proper selection.
       
 42528 
       
 42529         * platform/Font.cpp:
       
 42530         (WebCore::WidthIterator::WidthIterator):
       
 42531 
       
 42532 2007-03-29  David Hyatt  <hyatt@apple.com>
       
 42533 
       
 42534         Fix for <rdar://problem/4545060>, technorati and arstechnica fail because of getComputedStyle not
       
 42535         reporting display:none properly when it is set.  This is bugzilla bug 13103.
       
 42536 
       
 42537         Reviewed by mitz
       
 42538 
       
 42539         * css/CSSComputedStyleDeclaration.cpp:
       
 42540         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 42541 
       
 42542 2007-03-28  Oliver Hunt  <oliver@apple.com>
       
 42543 
       
 42544         Reviewed by Hyatt.
       
 42545 
       
 42546         Rename DocLoader::setPasteInProgress, etc to more generic 
       
 42547         setAllowStaleResources, etc
       
 42548 
       
 42549         * editing/Editor.cpp:
       
 42550         (WebCore::Editor::paste):
       
 42551         * loader/DocLoader.cpp:
       
 42552         (WebCore::DocLoader::DocLoader):
       
 42553         (WebCore::DocLoader::checkForReload):
       
 42554         * loader/DocLoader.h:
       
 42555         (WebCore::DocLoader::setAllowStaleResources):
       
 42556         * page/DragController.cpp:
       
 42557         (WebCore::DragController::concludeDrag):
       
 42558 
       
 42559 2007-03-28  Oliver Hunt  <oliver@apple.com>
       
 42560 
       
 42561         Reviewed by Anders and Steve.
       
 42562 
       
 42563         Add a flag to DocLoader to prevent it from reloading 
       
 42564         when performing a paste or drop operation.
       
 42565         
       
 42566         Remove m_cachePolicy from CachedResource as it is never used
       
 42567         
       
 42568         Fixes rdar://problem/5044366 : REGRESSION: Repro ASSERT failures 
       
 42569         dragging image into GMail message in _web_writeImage and 
       
 42570         documentFragmentFromDragData
       
 42571 
       
 42572         * editing/Editor.cpp:
       
 42573         (WebCore::Editor::paste):
       
 42574           prevent the docloader from reloading resources on paste
       
 42575         * html/HTMLImageLoader.cpp:
       
 42576         (WebCore::HTMLImageLoader::updateFromElement):
       
 42577         * loader/Cache.cpp:
       
 42578         (WebCore::createResource):
       
 42579         * loader/CachedCSSStyleSheet.cpp:
       
 42580         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
       
 42581         * loader/CachedCSSStyleSheet.h:
       
 42582         * loader/CachedImage.cpp:
       
 42583         (WebCore::CachedImage::CachedImage):
       
 42584         * loader/CachedImage.h:
       
 42585         * loader/CachedResource.cpp:
       
 42586         (WebCore::CachedResource::CachedResource):
       
 42587         * loader/CachedResource.h:
       
 42588         * loader/CachedScript.cpp:
       
 42589         (WebCore::CachedScript::CachedScript):
       
 42590         * loader/CachedScript.h:
       
 42591         * loader/CachedXBLDocument.cpp:
       
 42592         (WebCore::CachedXBLDocument::CachedXBLDocument):
       
 42593         * loader/CachedXBLDocument.h:
       
 42594         * loader/CachedXSLStyleSheet.cpp:
       
 42595         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
       
 42596         * loader/CachedXSLStyleSheet.h:
       
 42597         * loader/DocLoader.cpp:
       
 42598         (WebCore::DocLoader::DocLoader):
       
 42599            Tidy up constructor initialise new field
       
 42600         (WebCore::DocLoader::checkForReload):
       
 42601            Prevent reload when pasting
       
 42602         * loader/DocLoader.h:
       
 42603         (WebCore::DocLoader::setPasteInProgress):
       
 42604           new field and setter
       
 42605         * page/DragController.cpp:
       
 42606         (WebCore::DragController::concludeDrag):
       
 42607           prevent the docloader from reloading resources on drop
       
 42608 
       
 42609 2007-03-27  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 42610 
       
 42611         Not reviewed - fix typo in gdk build.
       
 42612 
       
 42613         * platform/gdk/ScrollViewGdk.cpp:
       
 42614         (WebCore::ScrollView::contentsToWindow):
       
 42615 
       
 42616 2007-03-28  Maciej Stachowiak  <mjs@apple.com>
       
 42617         
       
 42618         Reviewed by Darin.
       
 42619         
       
 42620         - fixed <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
       
 42621                 
       
 42622         Handle scrolling external scrollviews around the webview during
       
 42623         autoscroll or when scrolling into view.
       
 42624         
       
 42625         This should also restore performance on BenchJS test 6 lost due to Tim's partial fix.
       
 42626 
       
 42627         * page/FrameView.cpp:
       
 42628         (WebCore::FrameView::scrollRectIntoViewRecursively):
       
 42629         * page/FrameView.h:
       
 42630         * platform/ScrollView.h:
       
 42631         * platform/gdk/ScrollViewGdk.cpp:
       
 42632         (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
       
 42633         (WebCore::ScrollView::scrollRectIntoViewRecursively):
       
 42634         * platform/mac/ScrollViewMac.mm:
       
 42635         (WebCore::ScrollView::visibleContentRect):
       
 42636         (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
       
 42637         (WebCore::ScrollView::scrollRectIntoViewRecursively):
       
 42638         (WebCore::ScrollView::updateContents):
       
 42639         * platform/qt/ScrollViewQt.cpp:
       
 42640         (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
       
 42641         (WebCore::ScrollView::scrollRectIntoViewRecursively):
       
 42642         * platform/win/ScrollViewWin.cpp:
       
 42643         (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
       
 42644         * platform/win/TemporaryLinkStubs.cpp:
       
 42645         (WebCore::ScrollView::scrollRectIntoViewRecursively):
       
 42646         * rendering/RenderLayer.cpp:
       
 42647         (WebCore::RenderLayer::scrollRectToVisible):
       
 42648        
       
 42649 2007-03-28  Jungshik Shin  <jungshik.shin@gmail.com>
       
 42650 
       
 42651         Reviewed  and landed by Darin
       
 42652 
       
 42653         Get rid of some misuses of |islower| and |tolower| for non-ASCII characters.
       
 42654         http://bugs.webkit.org/show_bug.cgi?id=13138
       
 42655 
       
 42656         * platform/StringImpl.cpp:
       
 42657         (WebCore::StringImpl::isLower):
       
 42658         (WebCore::StringImpl::lower):
       
 42659         (WebCore::StringImpl::equalIgnoringCase):
       
 42660 
       
 42661 2007-03-28  Antti Koivisto  <antti@apple.com>
       
 42662 
       
 42663         Reviewed by Hyatt.
       
 42664 
       
 42665         Fix <rdar://problem/5092653>
       
 42666         REGRESSION: Image decoding making scrolling slow
       
 42667         
       
 42668         If decoder gave back a null frame (which I think happens regularly if you don't have full frame 
       
 42669         data yet for image that does not decode incrementally) m_decodedSize was incremented anyway. This
       
 42670         led to massive growth in calculated image size and eventually made cache prune constantly. 
       
 42671         
       
 42672         No test, I don't know how to make one for this.
       
 42673 
       
 42674         * platform/graphics/BitmapImage.cpp:
       
 42675         (WebCore::BitmapImage::cacheFrame):
       
 42676 
       
 42677 2007-03-28  Adele Peterson  <adele@apple.com>
       
 42678 
       
 42679         Reviewed by Kevin M.
       
 42680 
       
 42681         WebCore part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString
       
 42682 
       
 42683         * page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
       
 42684         Convert return value to a string.  This matches the behavior in Safari 2.0.
       
 42685 
       
 42686 2007-03-28  Alexey Proskuryakov  <ap@webkit.org>
       
 42687 
       
 42688         Reviewed by Darin.
       
 42689 
       
 42690         http://bugs.webkit.org/show_bug.cgi?id=13190
       
 42691         XPath incorrectly handles namespaces on attributes
       
 42692 
       
 42693         * xml/XPathStep.cpp:
       
 42694         (WebCore::XPath::Step::nodesInAxis): Added a special case for faster attribute lookup; gives a slight but 
       
 42695         measurable performance improvement for bug 13021.
       
 42696         (WebCore::XPath::Step::nodeMatches): Fixed NameTest for attribute nodes.
       
 42697 
       
 42698         * xml/XPathStep.h:
       
 42699         (WebCore::XPath::Step::NodeTest::NodeTest):
       
 42700         (WebCore::XPath::Step::NodeTest::namespaceURI):
       
 42701         (WebCore::XPath::Step::nodeTest):
       
 42702         (WebCore::XPath::Step::setNodeTest):
       
 42703         Move m_namespaceURI to NodeTest, where it belongs. Removed unused m_nodeTestData (oops!).
       
 42704 
       
 42705         * xml/XPathGrammar.y:
       
 42706         * xml/XPathPath.cpp:
       
 42707         (WebCore::XPath::LocationPath::optimizeStepPair):
       
 42708         Accounted for the above change.
       
 42709 
       
 42710 2007-03-28  Oliver Hunt  <oliver@apple.com>
       
 42711 
       
 42712         rs=Hyatt.
       
 42713 
       
 42714         Rollout local changes :-/
       
 42715 
       
 42716         * loader/Cache.cpp:
       
 42717         (WebCore::Cache::pruneAllResources):
       
 42718         (WebCore::Cache::remove):
       
 42719 
       
 42720 2007-03-28  Oliver Hunt  <oliver@apple.com>
       
 42721 
       
 42722         Reviewed by Hyatt.
       
 42723 
       
 42724         Roll out r20511 due to incredible badness
       
 42725 
       
 42726         * loader/Cache.cpp:
       
 42727         (WebCore::Cache::pruneAllResources):
       
 42728         (WebCore::Cache::remove):
       
 42729 
       
 42730 2007-03-27  Oliver Hunt  <oliver@apple.com>
       
 42731 
       
 42732         Reviewed by Adam.
       
 42733 
       
 42734         Don't enforce text-selection drag delay when we are
       
 42735         going to drag an image anyway.
       
 42736 
       
 42737         Fixes rdar://problem/4668935
       
 42738 
       
 42739         * page/EventHandler.cpp:
       
 42740         (WebCore::EventHandler::handleDrag):
       
 42741 
       
 42742 2007-03-27  Justin Garcia  <justin.garcia@apple.com>
       
 42743 
       
 42744         Build fix
       
 42745         
       
 42746         * editing/markup.cpp:
       
 42747         (WebCore::startMarkup):
       
 42748 
       
 42749 2007-03-27  Justin Garcia  <justin.garcia@apple.com>
       
 42750 
       
 42751         Reviewed by darin
       
 42752         
       
 42753         <rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family
       
 42754         
       
 42755         createMarkup skipped elements if they were blocks
       
 42756         when called from moveParagraphs (because that function 
       
 42757         must receive only inline content).  This patch adds 
       
 42758         code to inline these blocks instead of skipping them 
       
 42759         so that we don't lose any of the style that they 
       
 42760         contribute to the copied markup.
       
 42761 
       
 42762         * editing/markup.cpp:
       
 42763         (WebCore::startMarkup): Add an inlineBlocks option.
       
 42764         Make sure to overwrite display:block coming from
       
 42765         a style sheet or the inline style declaration.
       
 42766         (WebCore::createMarkup): Don't refuse to include a 
       
 42767         specialCommonAncestor that's a block if we were asked 
       
 42768         to include only inline content, since we can now inline 
       
 42769         block elements in startMarkup.
       
 42770 
       
 42771 2007-03-27  Adele Peterson  <adele@apple.com>
       
 42772 
       
 42773         Reviewed by Hyatt.
       
 42774 
       
 42775         Fix for <rdar://problem/5026141> REGRESSION: Aperture Viewer Flashes when switching from Index Page to Detail page in Web Gallery
       
 42776 
       
 42777         This disables the paint that occurs after WebCore finishes loading the document.  We should reenable this when we
       
 42778         move the dispatchDidFinishLoad delegate callback to happen around the same time as the JS onload call.  See <rdar://problem/5092361>.
       
 42779 
       
 42780         * dom/Document.cpp: (WebCore::Document::implicitClose):
       
 42781 
       
 42782 2007-03-26  Justin Garcia  <justin.garcia@apple.com>
       
 42783 
       
 42784         Reviewed by darin
       
 42785         
       
 42786         <rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
       
 42787         <rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
       
 42788         <rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
       
 42789         <rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented
       
 42790 
       
 42791         * css/CSSComputedStyleDeclaration.cpp:
       
 42792         (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties):
       
 42793         If a node's text fill color is invalid, then its children use 
       
 42794         their font-color as their text fill color (they don't inherit 
       
 42795         it).  Likewise for stroke color.
       
 42796 
       
 42797 2007-03-27  Anders Carlsson  <acarlsson@apple.com>
       
 42798 
       
 42799         * platform/ScrollBar.h:
       
 42800         Use wtf/MathExtras.h instead of math.h
       
 42801 
       
 42802 2007-03-27  Zack Rusin  <zrusin@trolltech.com>
       
 42803 
       
 42804         Fix the compile - when using math.h functions
       
 42805         actually include the header with them.
       
 42806 
       
 42807         * platform/ScrollBar.h:
       
 42808 
       
 42809 2007-03-27  Oliver Hunt  <oliver@apple.com>
       
 42810 
       
 42811         Reviewed by Maciej.
       
 42812 
       
 42813         The WebArchiver needs all the subresources of a document to be accessible
       
 42814         through the DocLoader, so we can't remove a CachedResource simultaneously
       
 42815         from the global Cache and all DocLoaders, just because it needs to be 
       
 42816         reloaded in one.
       
 42817 
       
 42818         Fixes rdar://problem/5044366
       
 42819 
       
 42820         * loader/Cache.cpp:
       
 42821         (WebCore::Cache::remove):
       
 42822            Don't evict the resource from all DocLoaders
       
 42823         * manual-tests/test-iframes-loading-the-same-resource.html: Added.
       
 42824            Alas it wasn't possible to make a nice layout test, even this manual test
       
 42825            is not entirely deterministic
       
 42826 
       
 42827 2007-03-27  Mark Rowe  <mrowe@apple.com>
       
 42828 
       
 42829         Build fix.
       
 42830 
       
 42831         * platform/GlyphBuffer.h:
       
 42832         (WebCore::GlyphBuffer::clear):
       
 42833 
       
 42834 2007-03-27  Dave Hyatt  <hyatt@apple.com>
       
 42835 
       
 42836         Add support for glyph offsets to the GlyphBuffer.
       
 42837        
       
 42838         Reviewed by olliej
       
 42839 
       
 42840         * platform/Font.cpp:
       
 42841         (WebCore::Font::drawGlyphBuffer):
       
 42842         * platform/GlyphBuffer.h:
       
 42843         (WebCore::GlyphBuffer::clear):
       
 42844         (WebCore::GlyphBuffer::swap):
       
 42845         (WebCore::GlyphBuffer::offsetAt):
       
 42846         (WebCore::GlyphBuffer::add):
       
 42847 
       
 42848 2007-03-27  Antti Koivisto  <antti@apple.com>
       
 42849 
       
 42850         Keep buildbot happy.
       
 42851 
       
 42852         * platform/mac/PlatformScrollBarMac.mm:
       
 42853         (WebCore::PlatformScrollbar::scrollbarHit):
       
 42854 
       
 42855 2007-03-26  Antti Koivisto  <antti@apple.com>
       
 42856 
       
 42857         Reviewed by Darin.
       
 42858         
       
 42859         On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse.
       
 42860         http://bugs.webkit.org/show_bug.cgi?id=13134
       
 42861         <rdar://problem/5076249?
       
 42862 
       
 42863         * WebCore.exp:
       
 42864             Export _wkGetWheelEventDeltas
       
 42865         * page/EventHandler.cpp:
       
 42866         (WebCore::EventHandler::handleWheelEvent):
       
 42867             Remove (0, 0) scroll event hack, it is not needed anymore.
       
 42868             Do per-pixel scrolling for fine grained events.
       
 42869         * platform/PlatformWheelEvent.h:
       
 42870         (WebCore::PlatformWheelEvent::isContinuous):
       
 42871             Add new m_isContinuous boolean to indicate fine grained wheel events.
       
 42872         * platform/ScrollBar.cpp:
       
 42873         (WebCore::Scrollbar::Scrollbar):
       
 42874         (WebCore::Scrollbar::setValue):
       
 42875         (WebCore::Scrollbar::setSteps):
       
 42876         (WebCore::Scrollbar::scroll):
       
 42877         * platform/ScrollBar.h:
       
 42878         (WebCore::Scrollbar::value):
       
 42879             Use float to represent current position to support finer grained scrolling.
       
 42880             Add ScrollByPixel, remove ScrollByWheel (which was same as ScrollByLine anyway)
       
 42881         * platform/ScrollTypes.h:
       
 42882         (WebCore::):
       
 42883         * platform/gdk/WheelEventGdk.cpp:
       
 42884         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
       
 42885             Initalize m_isContinuous
       
 42886         * platform/mac/WebCoreSystemInterface.h:
       
 42887         * platform/mac/WebCoreSystemInterface.mm:
       
 42888             Add wkGetWheelEventDeltas for getting fine grained wheel events
       
 42889         * platform/mac/WheelEventMac.mm:
       
 42890         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
       
 42891             Get the wheel deltas using new wkGetWheelEventDeltas interface
       
 42892         * platform/qt/WheelEventQt.cpp:
       
 42893         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
       
 42894             Initalize m_isContinuous
       
 42895         * rendering/RenderListBox.cpp:
       
 42896         (WebCore::RenderListBox::calcHeight):
       
 42897             Pass item height to scrollbar
       
 42898 
       
 42899 2007-03-26  Geoffrey Garen  <ggaren@apple.com>
       
 42900 
       
 42901         Reviewed by Darin Adler.
       
 42902 
       
 42903         Fixed <rdar://problem/5088234> REGRESSION: Crash occurs at WebCore::Node::
       
 42904         createRendererIfNeeded() when changing map views with MS Virtual Earth 
       
 42905         (http://www.ziprealty.com/)
       
 42906         
       
 42907         The cause of the crash was the insertion of a <script> element whose
       
 42908         script removed it from the document. The <script> element would then be 
       
 42909         garbage when the insertion routine went on to attach() it.
       
 42910         
       
 42911         The solution here is to check that an element is still your child before
       
 42912         trying to attach() it. This matches the style of checks we do elsewhere
       
 42913         in the node insertion and removal code.
       
 42914 
       
 42915         * dom/ContainerNode.cpp:
       
 42916         (WebCore::ContainerNode::insertBefore):
       
 42917         (WebCore::ContainerNode::replaceChild):
       
 42918         (WebCore::ContainerNode::appendChild):
       
 42919 
       
 42920 2007-03-26  David Carson  <dacarson@gmail.com>
       
 42921 
       
 42922         Reviewed by Darin, landed by Anders.
       
 42923 
       
 42924         Manual test case for: REGRESSION (r19559): Java applet crash
       
 42925         http://bugs.webkit.org/show_bug.cgi?id=13142
       
 42926         <rdar://problem/5080340>
       
 42927 
       
 42928         * manual-tests/liveconnect-applet-get-boolean.html: Added.
       
 42929         * manual-tests/resources/CheckerApplet.class: Added.
       
 42930         * manual-tests/resources/CheckerApplet.java: Added.
       
 42931 
       
 42932 2007-03-26  Mitz Pettel  <mitz@webkit.org>
       
 42933 
       
 42934         Reviewed and landed by Darin.
       
 42935 
       
 42936         - fix http://bugs.webkit.org/show_bug.cgi?id=13194
       
 42937           <rdar://problem/5087738>
       
 42938           REGRESSION: Selection rects are wrong for images in search results from images.google.com
       
 42939 
       
 42940         Test: fast/replaced/selection-rect-in-table-cell.html
       
 42941 
       
 42942         * rendering/RenderReplaced.cpp:
       
 42943         (WebCore::RenderReplaced::selectionRect):
       
 42944 
       
 42945 2007-03-26  Geoffrey Garen  <ggaren@apple.com>
       
 42946 
       
 42947         Removed now-stale #includes of <assert.h>.
       
 42948         
       
 42949         * WebCorePrefix.h:
       
 42950         * config.h:
       
 42951         * css/CSSGrammar.y:
       
 42952         * platform/Arena.cpp:
       
 42953         * platform/KURL.cpp:
       
 42954         * platform/SegmentedString.h:
       
 42955         * rendering/DataRef.h:
       
 42956         * rendering/RenderArena.cpp:
       
 42957 
       
 42958 2007-03-26  Geoffrey Garen  <ggaren@apple.com>
       
 42959 
       
 42960         Reviewed by Kevin McCulough.
       
 42961 
       
 42962         Global replace of "assert(" with "ASSERT(" to assist debugging. Removed
       
 42963         one instance of commented-out code containing "assert(" instead of replacing it.
       
 42964 
       
 42965 2007-03-25  Antti Koivisto  <antti@apple.com>
       
 42966 
       
 42967         Reviewed by Adam.
       
 42968 
       
 42969         Fix <rdar://problem/5049842>
       
 42970         Gmail Editor: Dragging message text in the message body results in a crash at WebCore::Frame::eventHandler()
       
 42971 
       
 42972         Null check frame in m_dragTarget, it might be gone already.
       
 42973 
       
 42974         * page/EventHandler.cpp:
       
 42975         (WebCore::EventHandler::updateDragAndDrop):
       
 42976         (WebCore::EventHandler::cancelDragAndDrop):
       
 42977         (WebCore::EventHandler::performDragAndDrop):
       
 42978 
       
 42979 2007-03-25  Alexey Proskuryakov  <ap@webkit.org>
       
 42980 
       
 42981         Reviewed by Darin.
       
 42982 
       
 42983         A partial fix for http://bugs.webkit.org/show_bug.cgi?id=13021
       
 42984         XPath can be very slow
       
 42985 
       
 42986         * xml/XPathExpression.cpp:
       
 42987         (WebCore::XPathExpression::evaluate): Reset a reference to the context node, as this may prevent the whole document
       
 42988         from being destroyed in time.
       
 42989 
       
 42990         * dom/Attr.cpp:
       
 42991         (WebCore::Attr::createTextChild): Instead of calling appendChild(), just do the few operations it really needs to perform.
       
 42992         * dom/ContainerNode.h:
       
 42993         (WebCore::ContainerNode::fastSetFirstChild):
       
 42994         (WebCore::ContainerNode::fastSetLastChild):
       
 42995         Added operations that let Attr hack internal ContainerNode data (evil, but fast!).
       
 42996 
       
 42997         * xml/XPathStep.cpp:
       
 42998         (WebCore::XPath::Step::evaluate):
       
 42999         (WebCore::XPath::Step::nodesInAxis):
       
 43000         (WebCore::XPath::Step::nodeMatches):
       
 43001         * xml/XPathStep.h:
       
 43002         Merged node testing into axis enumeration. This saves a lot of Vector resizing and passing, and is necessary for future 
       
 43003         optimizations (sometimes, we can just pick the single result node instead of enumerating and filtering the whole axis).
       
 43004 
       
 43005 2007-03-24  Mitz Pettel  <mitz@webkit.org>
       
 43006 
       
 43007         Reviewed by Darin.
       
 43008 
       
 43009         - fix http://bugs.webkit.org/show_bug.cgi?id=13156
       
 43010           REGRESSION (r19621): Pasting breakable content where wrapped line is too long to fit in a textarea fails to draw a horizontal scrollbar
       
 43011 
       
 43012         Test: fast/text/midword-break-after-breakable-char.html
       
 43013 
       
 43014         Breaking in the middle of the word
       
 43015         is allowed only if no breaking opportunity between words has occurred yet. The
       
 43016         first position on the line should not be considered "between words" even if
       
 43017         it is a breaking opportunity.
       
 43018         
       
 43019         * rendering/bidi.cpp:
       
 43020         (WebCore::RenderBlock::findNextLineBreak): Changed according to the above. Also
       
 43021         cleaned up a couple of lines.
       
 43022 
       
 43023 2007-03-24  David Hyatt  <hyatt@apple.com>
       
 43024 
       
 43025         Fix for bugzilla bug 13187, place a hard limit on the amount of decoded data that WebCore will keep
       
 43026         around even on live pages (pages being displayed in tabs/windows or in the back/forward cache).
       
 43027         Images will decode to paint and once the decoded data exceeds the cache size, the decoded data will be
       
 43028         tossed.
       
 43029 
       
 43030         Refine the flushing algorithm to apply the two-pass decode/evict model to each LRU-SP queue individually, rather
       
 43031         than to all the lists at once.  This allows the cache to evict large encoded resources before flushing small
       
 43032         or frequently accessed decoded onces.
       
 43033 
       
 43034         Added information on live/decoded data to the cache statistics.
       
 43035 
       
 43036         Reviewed by darin
       
 43037 
       
 43038         * loader/Cache.cpp:
       
 43039         (WebCore::Cache::Cache):
       
 43040         (WebCore::Cache::pruneLiveResources):
       
 43041         (WebCore::Cache::pruneAllResources):
       
 43042         (WebCore::Cache::setMaximumSize):
       
 43043         (WebCore::Cache::remove):
       
 43044         (WebCore::Cache::lruListFor):
       
 43045         (WebCore::Cache::removeFromLRUList):
       
 43046         (WebCore::Cache::insertInLRUList):
       
 43047         (WebCore::Cache::liveLRUListFor):
       
 43048         (WebCore::Cache::removeFromLiveResourcesList):
       
 43049         (WebCore::Cache::insertInLiveResourcesList):
       
 43050         (WebCore::Cache::addToLiveResourcesSize):
       
 43051         (WebCore::Cache::removeFromLiveResourcesSize):
       
 43052         (WebCore::Cache::adjustSize):
       
 43053         (WebCore::Cache::getStatistics):
       
 43054         * loader/Cache.h:
       
 43055         (WebCore::Cache::TypeStatistic::TypeStatistic):
       
 43056         * loader/CachedImage.cpp:
       
 43057         (WebCore::CachedImage::decodedSizeWillChange):
       
 43058         (WebCore::CachedImage::decodedSizeChanged):
       
 43059         * loader/CachedImage.h:
       
 43060         * loader/CachedResource.cpp:
       
 43061         (WebCore::CachedResource::CachedResource):
       
 43062         (WebCore::CachedResource::ref):
       
 43063         (WebCore::CachedResource::deref):
       
 43064         (WebCore::CachedResource::setEncodedSize):
       
 43065         (WebCore::CachedResource::liveResourceAccessed):
       
 43066         * loader/CachedResource.h:
       
 43067         (WebCore::CachedResource::liveAccessCount):
       
 43068         (WebCore::CachedResource::resetLiveAccessCount):
       
 43069         (WebCore::CachedResource::increaseLiveAccessCount):
       
 43070         * platform/graphics/BitmapImage.cpp:
       
 43071         (WebCore::BitmapImage::destroyDecodedData):
       
 43072         (WebCore::BitmapImage::cacheFrame):
       
 43073         * platform/graphics/ImageObserver.h:
       
 43074         * rendering/RenderBox.cpp:
       
 43075         (WebCore::RenderBox::paintBackgroundExtended):
       
 43076         * rendering/RenderImage.cpp:
       
 43077         (WebCore::RenderImage::paint):
       
 43078         * rendering/RenderListMarker.cpp:
       
 43079         (WebCore::RenderListMarker::paint):
       
 43080         * rendering/RenderObject.cpp:
       
 43081         (WebCore::RenderObject::paintBorderImage):
       
 43082 
       
 43083 2007-03-24  Darin Adler  <darin@apple.com>
       
 43084 
       
 43085         Reviewed by Mitz.
       
 43086 
       
 43087         - fix http://bugs.webkit.org/show_bug.cgi?id=13123
       
 43088           CSS selectors that use :lang, :not, and namespaces do not serialize correctly
       
 43089 
       
 43090         Test: fast/css/css-selector-text.html
       
 43091 
       
 43092         * css/CSSSelector.cpp: (WebCore::CSSSelector::selectorText): Add the namespace
       
 43093         prefix for tag or attribute names, the sub-selector for :not, and the argument
       
 43094         for :lang.
       
 43095 
       
 43096 2007-03-24  Brady Eidson  <beidson@apple.com>
       
 43097 
       
 43098         Reviewed by Adam
       
 43099 
       
 43100         <rdar://problem/5086210> - Move RetainPtr to WTF
       
 43101 
       
 43102         * ForwardingHeaders/wtf/RetainPtr.h: Added.
       
 43103         * WebCore.xcodeproj/project.pbxproj: Removed WebCore/RetainPtr.h
       
 43104         
       
 43105         * history/HistoryItem.h: Changed #include to <wtf/RetainPtr.h>
       
 43106         * history/PageCache.h: Ditto
       
 43107         * page/mac/WebCoreFrameBridge.mm: Ditto
       
 43108         * platform/ContextMenu.h: Ditto
       
 43109         * platform/ContextMenuItem.h: Ditto
       
 43110         * platform/DragImage.h: Ditto
       
 43111         * platform/FileChooser.h: Ditto
       
 43112         * platform/PlatformKeyboardEvent.h: Ditto
       
 43113         * platform/PopupMenu.h: Ditto
       
 43114         * platform/SharedBuffer.h: Ditto
       
 43115         * platform/cf/RetainPtr.h: Removed.
       
 43116         * platform/graphics/Icon.h: Changed #include
       
 43117         * platform/mac/ClipboardMac.h: Ditto
       
 43118         * platform/mac/PasteboardMac.mm: Ditto
       
 43119         * platform/mac/WidgetMac.mm: Ditto
       
 43120         * platform/network/AuthenticationChallenge.h: Ditto
       
 43121         * platform/network/ResourceError.h: Ditto
       
 43122         * platform/network/ResourceHandle.h: Ditto
       
 43123         * platform/network/ResourceRequest.h: Ditto
       
 43124         * platform/network/ResourceResponse.h: Ditto
       
 43125         * rendering/RenderThemeMac.mm: Ditto
       
 43126 
       
 43127 2007-03-24  Mitz Pettel  <mitz@webkit.org>
       
 43128 
       
 43129         Fix for <rdar://problem/5086797>, layoutPending is now reporting incorrect results, which will lead
       
 43130         to all sorts of layout issues.  This is in bugzilla as 13179.
       
 43131 
       
 43132         Reviewed by hyatt
       
 43133 
       
 43134         - fix http://bugs.webkit.org/show_bug.cgi?id=13179
       
 43135           REGRESSION (r20410): In debug builds, loading a certain page is suspended until redisplay is forced
       
 43136 
       
 43137         Moved the root->needsLayout() check from layoutPending() to needsLayout()
       
 43138         to restore the behavior before r20324.
       
 43139 
       
 43140         * page/FrameView.cpp:
       
 43141         (WebCore::FrameView::layoutPending):
       
 43142         (WebCore::FrameView::needsLayout):
       
 43143 
       
 43144 2007-03-24  Mitz Pettel  <mitz@webkit.org>
       
 43145 
       
 43146         Reviewed by Adele.
       
 43147 
       
 43148         - fix http://bugs.webkit.org/show_bug.cgi?id=13180
       
 43149               <rdar://problem/5084478>
       
 43150           Another debug build crash from ASSERTION FAILED: !needsLayout()
       
 43151 
       
 43152         No test possible because updateRendering() is always called after script
       
 43153         execution.
       
 43154 
       
 43155         * page/FrameView.cpp:
       
 43156         (WebCore::FrameView::layout): Get the layout root after calling recalcStyle()
       
 43157         since a style recalc may result in needing to do start layout at the root.
       
 43158 
       
 43159 2007-03-24  Nikolas Zimmermann  <zimmermann@kde.org>
       
 43160 
       
 43161         Not reviewed. Build fix.
       
 43162 
       
 43163         Fix FloatRect vs. IntRect confusion.
       
 43164 
       
 43165         * rendering/RenderSVGImage.cpp:
       
 43166         (WebCore::RenderSVGImage::nodeAtPoint):
       
 43167 
       
 43168 2007-03-25  Mark Rowe  <mrowe@apple.com>
       
 43169 
       
 43170         Fix incorrect radar number.
       
 43171 
       
 43172         * platform/network/mac/ResourceHandleMac.mm:
       
 43173         (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
       
 43174 
       
 43175 2007-03-23  Nikolas Zimmermann  <zimmermann@kde.org>
       
 43176 
       
 43177         Reviewed by Oliver.
       
 43178 
       
 43179         Fix all known RenderSVGImage problems.
       
 43180 
       
 43181         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12126 (RenderSVGImage seems to suffer from integer overflow)
       
 43182         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12442 (raster images disappearing during script execution (SVG))
       
 43183         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12572 (WebKit does not properly invalidate image region after image load)
       
 43184 
       
 43185         Added test: svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html
       
 43186 
       
 43187         In RenderSVGImage::paint, do not call shouldPaint() as this will never work properly for SVG renderers, as shouldPaint
       
 43188         doesn't take into account any special SVG transformation (localTransform/absoluteTransform). Just remove the call.
       
 43189 
       
 43190         Fix hit detection on RenderSVGImage - it didn't work properly at all. No idea why I didn't notice before.
       
 43191         Thanks Andreas Neumann once again for writing excellent bug reports and pointing me to them :-)
       
 43192 
       
 43193         The carto.net navigation tools work as expected now, and also the "dock like" image effect example.
       
 43194 
       
 43195         * rendering/RenderSVGImage.cpp:
       
 43196         (WebCore::RenderSVGImage::paint):
       
 43197         (WebCore::RenderSVGImage::nodeAtPoint):
       
 43198 
       
 43199 2007-03-24  Mitz Pettel  <mitz@webkit.org>
       
 43200 
       
 43201         Reviewed by Dave Hyatt.
       
 43202 
       
 43203         - http://bugs.webkit.org/show_bug.cgi?id=13177
       
 43204           Suppress control characters in the ATSUI code path
       
 43205 
       
 43206         * platform/mac/FontMac.mm:
       
 43207         (WebCore::overrideLayoutOperation):
       
 43208         (WebCore::ATSULayoutParameters::initialize):
       
 43209 
       
 43210 2007-03-24  David Hyatt  <hyatt@apple.com>
       
 43211 
       
 43212         Fix for <rdar://problem/5086400>, images scrolled offscreen continue to animate.  Safari 2 would
       
 43213         halt animations when images were no longer visible.
       
 43214 
       
 43215         Reviewed by mjs, olliej
       
 43216 
       
 43217         * platform/graphics/BitmapImage.cpp:
       
 43218         (WebCore::BitmapImage::advanceAnimation):
       
 43219 
       
 43220 2007-03-24  David Hyatt  <hyatt@apple.com>
       
 43221 
       
 43222         Fix for <rdar://problem/508328>, sluggish text entry in search field.  Make sure
       
 43223         our size actually changed before we decide to do a full repaint because of background/border
       
 43224         complexities.
       
 43225 
       
 43226         Reviewed by aroben
       
 43227 
       
 43228         * rendering/RenderObject.cpp:
       
 43229         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
       
 43230 
       
 43231 2007-03-23  Dave Hyatt  <hyatt@apple.com>
       
 43232 
       
 43233         Fix for <rdar://problem/5048219>, spurious glyphs in gmail.   This is bugzilla bug 13136, which
       
 43234         will remain open to cover patching the complex text path.
       
 43235         
       
 43236         Reviewed by aroben
       
 43237 
       
 43238         * platform/Font.cpp:
       
 43239         (WebCore::Font::glyphDataForCharacter):
       
 43240         * platform/Font.h:
       
 43241         (WebCore::Font::treatAsZeroWidthSpace):
       
 43242         * platform/GlyphPageTreeNode.cpp:
       
 43243         (WebCore::GlyphPageTreeNode::initializePage):
       
 43244 
       
 43245 2007-03-23  Mitz Pettel  <mitz@webkit.org>
       
 43246 
       
 43247         Reviewed by Adele.
       
 43248 
       
 43249         - fix http://bugs.webkit.org/show_bug.cgi?id=13153
       
 43250           REGRESSION: Visual highlighting of pre-populated blank line in textarea is broken
       
 43251 
       
 43252         - fix a bug where selecting across a soft line break did not highlight to
       
 43253           the end of the first line if it contained skipped whitespace
       
 43254 
       
 43255         Test: fast/text/selection-hard-linebreak.html
       
 43256 
       
 43257         * rendering/InlineTextBox.cpp:
       
 43258         (WebCore::InlineTextBox::selectionState): Changed to treat a selection that ends on the
       
 43259         end of a hard line break as if it ends after the line break. Fixed the case of a selection
       
 43260         that starts and ends in the same text object as the box but does not intersect it
       
 43261         to return SelectionNone instead of selectionBoth.
       
 43262 
       
 43263 2007-03-23  Mitz Pettel  <mitz@webkit.org>
       
 43264 
       
 43265         Reviewed by Adele.
       
 43266 
       
 43267         - fix http://bugs.webkit.org/show_bug.cgi?id=13124
       
 43268           REGRESSION: Reproducible crash in Widget::getView
       
 43269 
       
 43270         Test: fast/frames/hover-timer-crash.html
       
 43271 
       
 43272         * page/Frame.cpp:
       
 43273         (WebCore::Frame::setView): Added a call to EventHandler::clear().
       
 43274 
       
 43275 2007-03-23  Justin Garcia  <justin.garcia@apple.com>
       
 43276 
       
 43277         Reviewed by adele
       
 43278 
       
 43279         <rdar://problem/5078739> 
       
 43280         Crash in in ReplaceSelectionCommand if the fragment contains only a style span
       
 43281 
       
 43282         * editing/ReplaceSelectionCommand.cpp:
       
 43283         (WebCore::ReplaceSelectionCommand::doApply): Check 
       
 43284         for an empty fragment after removing a redundant
       
 43285         style span instead of before.
       
 43286 
       
 43287 2007-03-23  David Hyatt  <hyatt@apple.com>
       
 43288 
       
 43289         <rdar://problem/5085063>
       
 43290 
       
 43291         Fix non-looping animation on cuteoverload.com. Just always flush
       
 43292         decoded data for large animated images to avoid our cache getting
       
 43293         out of sync with the image source.
       
 43294 
       
 43295         Reviewed by ggaren
       
 43296 
       
 43297         * platform/graphics/BitmapImage.cpp:
       
 43298         (WebCore::BitmapImage::advanceAnimation):
       
 43299 
       
 43300 2007-03-23  Adele Peterson  <adele@apple.com>
       
 43301 
       
 43302         Reviewed by Darin.
       
 43303 
       
 43304         Fix for <rdar://problem/5061024> REGRESSION: Returning false from onkeypress event on Input is ignored when key is Tab
       
 43305         http://bugs.webkit.org/show_bug.cgi?id= 13020
       
 43306 
       
 43307         No known way to add a layout test for this.  We would need a way to know exactly how the event was consumed.
       
 43308 
       
 43309         * page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler):
       
 43310           If the keypress event has its default behavior prevented, then we should consider the keydown event handled.
       
 43311 
       
 43312 2007-03-23  Justin Garcia  <justin.garcia@apple.com>
       
 43313 
       
 43314         Reviewed by darin
       
 43315 
       
 43316         <rdar://problem/5080333> 
       
 43317         REGRESSION: Selection changes when changing the alignment of an image
       
 43318         
       
 43319         Regression occurred when we started using moveParagraphs
       
 43320         to move content in applyBlockStyle.  moveParagraphs 
       
 43321         moves by copying, deleting and reinserting content, and
       
 43322         so must be accompanied by selection preservation code.
       
 43323         That code uses rangeFromLocationAndLength and rangeLength,
       
 43324         which use TextIterators, which don't emit anything for images 
       
 43325         and other replaced elements, causing this bug.
       
 43326 
       
 43327         * editing/ApplyStyleCommand.cpp:
       
 43328         (WebCore::ApplyStyleCommand::applyBlockStyle): Ask rangeLength 
       
 43329         and rangeFromLocationAndLength to request that their
       
 43330         TextIterators emit spaces for replaced elements.
       
 43331         Use rangeCompliantEquivalent()s when creating a Range from
       
 43332         VisiblePositions, since some VisiblePositions have illegal
       
 43333         deepEquivalent()s.
       
 43334         * editing/CompositeEditCommand.cpp:
       
 43335         (WebCore::CompositeEditCommand::moveParagraphs): Ditto.
       
 43336         * editing/TextIterator.cpp:
       
 43337         (WebCore::TextIterator::TextIterator):
       
 43338         (WebCore::TextIterator::handleReplacedElement): Emit
       
 43339         a space if requested.
       
 43340         (WebCore::TextIterator::representNodeOffsetZero): Emit
       
 43341         ranges before m_node, not around m_lastTextNode.  These
       
 43342         ranges should represent the part of the document associated
       
 43343         with the emitted character. 
       
 43344         (WebCore::TextIterator::rangeLength): Take in the new bool.
       
 43345         (WebCore::TextIterator::rangeFromLocationAndLength): Ditto.
       
 43346         Also, don't loop an extra time after finding the end of the
       
 43347         range when we're looking for zero length ranges.  This appeared
       
 43348         to be a workaround for the bugs fixed in representNodeOffsetZero
       
 43349         in this patch.
       
 43350         * editing/TextIterator.h:
       
 43351 
       
 43352 2007-03-24  Mark Rowe  <mrowe@apple.com>
       
 43353 
       
 43354         Rubber-stamped by Darin.
       
 43355 
       
 43356         * Configurations/WebCore.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.
       
 43357 
       
 43358 2007-03-23  Darin Adler  <darin@apple.com>
       
 43359 
       
 43360         * html/HTMLBodyElement.cpp: Fix comment typo.
       
 43361 
       
 43362 2007-03-23  Adam Treat  <adam@staikos.net>
       
 43363 
       
 43364         Reviewed and committed by George.
       
 43365 
       
 43366         Patch from Adam Treat to make the Qt build work without SVG and XSLT.
       
 43367         XMLNames is required in any case.
       
 43368 
       
 43369         * WebCore.pro:
       
 43370 
       
 43371 2007-03-23  Darin Adler  <darin@apple.com>
       
 43372 
       
 43373         Reviewed by Hyatt.
       
 43374 
       
 43375         - <rdar://problem/5074439> handle margins on frame and iframe elements
       
 43376           without involving FrameView, FrameLoader, etc.
       
 43377 
       
 43378         * html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::insertedIntoDocument):
       
 43379         Grab the margin from the frame directly here. There was no real benefit
       
 43380         to doing this via FrameView. Later we can delete quite a bit of unneeded code
       
 43381         here and in WebKit that exists only to set up the margin values in FrameView,
       
 43382         which are now unused.
       
 43383 
       
 43384 2007-03-23  Adele Peterson  <adele@apple.com>
       
 43385 
       
 43386         Reviewed by Darin.
       
 43387 
       
 43388         Fix for <rdar://problem/5080428> REGRESSION: getting value for hidden input element fails after the fix for Bug 11866
       
 43389         http://bugs.webkit.org/show_bug.cgi?id=13121
       
 43390 
       
 43391         Rolled out the change for 11866 that made hidden input elements store the value separately from the value attribute.
       
 43392         Added an m_originalValue field that gets set when the element is done being parsed (in closeRenderer).  In reset,
       
 43393         use the m_originalValue for hidden input elements.
       
 43394 
       
 43395         * html/HTMLInputElement.cpp:
       
 43396         (WebCore::HTMLInputElement::closeRenderer):
       
 43397         (WebCore::HTMLInputElement::reset):
       
 43398         (WebCore::HTMLInputElement::setValue):
       
 43399         (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
       
 43400         * html/HTMLInputElement.h:
       
 43401 
       
 43402 2007-03-23  Mitz Pettel  <mitz@webkit.org>
       
 43403 
       
 43404         Reviewed by Dave Hyatt.
       
 43405 
       
 43406         - fix http://bugs.webkit.org/show_bug.cgi?id=13157
       
 43407               <rdar://problem/5083995>
       
 43408           List markers positioned incorrectly and don't repaint properly on Oxford homepage
       
 43409 
       
 43410         Test: fast/lists/marker-image-error.html
       
 43411 
       
 43412         * rendering/RenderListMarker.cpp:
       
 43413         (WebCore::RenderListMarker::imageChanged): Mark ourselves for relayout if
       
 43414         the image failed to load, since that means we will use a bullet instead.
       
 43415 
       
 43416 2007-03-23  Zack Rusin  <zrusin@trolltech.com>
       
 43417 
       
 43418         Fix the compile.
       
 43419 
       
 43420         * platform/graphics/qt/ImageSourceQt.cpp:
       
 43421 
       
 43422 2007-03-22  Dave Hyatt  <hyatt@apple.com>
       
 43423 
       
 43424         Fix for <rdar://problem/5083072>.
       
 43425 
       
 43426         * page/Frame.cpp:
       
 43427         (WebCore::Frame::setPrinting):
       
 43428         (WebCore::Frame::forceLayoutWithPageWidthRange):
       
 43429         * page/Frame.h:
       
 43430         * page/mac/WebCoreFrameBridge.mm:
       
 43431         (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
       
 43432 
       
 43433 2007-03-22  Anders Carlsson  <acarlsson@apple.com>
       
 43434 
       
 43435         Reviewed by Ada.
       
 43436 
       
 43437         <rdar://problem/5074974>
       
 43438         CrashTracer: [USER] repro crash in Safari at com.apple.WebCore: WebCore::FrameLoader::activeDocumentLoader const + 6
       
 43439         
       
 43440         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
       
 43441         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
       
 43442         Don't use ResourceResponse:isHTTP here since that only looks at the protocol instead of if the response came from a 
       
 43443         HTTP server (and not a web archive).
       
 43444 
       
 43445 2007-03-22  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 43446 
       
 43447         Not reviewed - gdk build fix.
       
 43448 
       
 43449         * platform/graphics/cairo/ImageSourceCairo.cpp:
       
 43450 
       
 43451 2007-03-22  Dave Hyatt  <hyatt@apple.com>
       
 43452 
       
 43453         Fix for <rdar://problem/5083473>.  Make sure wheeling still forwards to the frame view even
       
 43454         when no node is hit.  Technically not ever hitting a node is a regression from the RenderView
       
 43455         size changes (making it be the size of the initial containing block according to CSS2.1), but
       
 43456         we should still handle this case gracefully in case it comes up again.
       
 43457        
       
 43458         Reviewed by olliej
       
 43459 
       
 43460         * page/EventHandler.cpp:
       
 43461         (WebCore::EventHandler::handleWheelEvent):
       
 43462 
       
 43463 2007-03-22  Justin Garcia  <justin.garcia@apple.com>
       
 43464 
       
 43465         Reviewed by kevin
       
 43466 
       
 43467         <rdar://problem/5081257> 
       
 43468         REGRESSION: New Mail signatures start out empty
       
 43469 
       
 43470         * editing/VisiblePosition.cpp:
       
 43471         (WebCore::VisiblePosition::canonicalPosition): Allow
       
 43472         descent from positions inside the document into an 
       
 43473         editable body.
       
 43474 
       
 43475 2007-03-22  Brady Eidson  <beidson@apple.com>
       
 43476 
       
 43477         Reviewed by Adele and John
       
 43478 
       
 43479         <rdar://5043528> - Prepare for new API
       
 43480         
       
 43481         * platform/network/ResourceHandle.cpp:
       
 43482         (WebCore::ResourceHandle::clearAuthentication): Clear CF type
       
 43483 
       
 43484 2007-03-22  Beth Dakin  <bdakin@apple.com>
       
 43485 
       
 43486         Patch by Hyatt, reviewed and committed by me.
       
 43487 
       
 43488         Does not reproduce consistently, so a layout test does not seem 
       
 43489         possible.
       
 43490 
       
 43491         Fix for <rdar://problem/5082421> Constantly hitting ASSERT(!
       
 43492         needsLayout()) in RenderView::paint()
       
 43493 
       
 43494         * page/FrameView.cpp:
       
 43495         (WebCore::FrameView::layoutPending): It is not enough to ask if the 
       
 43496         layout timer is active. There may be times that we don't have a 
       
 43497         body yet so we cannot schedule layout yet, but the root still needs 
       
 43498         layout.  
       
 43499 
       
 43500 2007-03-22  John Sullivan  <sullivan@apple.com>
       
 43501 
       
 43502         Reviewed by Darin
       
 43503         
       
 43504         Followup for recent fix to 5079700, found by assertion added to Safari.
       
 43505 
       
 43506         * page/mac/FrameMac.mm:
       
 43507         (WebCore::Frame::searchForLabelsBeforeElement):
       
 43508         Fixed another place in this method where an empty NSString was being returned instead of nil.
       
 43509         Cleaned up the style a little too.
       
 43510 
       
 43511 2007-03-22  David Hyatt  <hyatt@apple.com>
       
 43512 
       
 43513         Remove unnecessary destroyFrameAtIndex call.  Now that we throw away
       
 43514         the image source, it is no longer needed.
       
 43515 
       
 43516         Reviewed by beth
       
 43517 
       
 43518         * platform/graphics/BitmapImage.cpp:
       
 43519         (WebCore::BitmapImage::destroyDecodedData):
       
 43520 
       
 43521 2007-03-22  David Harrison  <harrison@apple.com>
       
 43522 
       
 43523         Reviewed by Geoff, Darin.
       
 43524 
       
 43525         <rdar://problem/5077892> In RapidWeaver 3.5.1, a crash occurs when attempting to load Safari Bookmarks in iMedia Browser
       
 43526         
       
 43527         * platform/mac/ThreadCheck.mm:
       
 43528         (WebCore::_WebCoreThreadViolationCheck):
       
 43529         Change default on Tiger to NSLog rather than raise an exception.
       
 43530 
       
 43531 2007-03-22  Darin Adler  <darin@apple.com>
       
 43532 
       
 43533         Reviewed by Brady.
       
 43534 
       
 43535         - use binary_search instead of hash table; slightly better performance and
       
 43536           less memory use
       
 43537 
       
 43538         * platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::portAllowed):
       
 43539         Use binary_search.
       
 43540 
       
 43541 2007-03-22  Darin Adler  <darin@apple.com>
       
 43542 
       
 43543         Reviewed by Adele.
       
 43544 
       
 43545         - fix <rdar://problem/5074630> detachChildren call should move from WebKit to WebCore
       
 43546 
       
 43547         * loader/FrameLoader.cpp: (WebCore::FrameLoader::setDocumentLoader):
       
 43548         Add a call to detachChildren() after the call to prepareForDataSourceReplacement().
       
 43549         There was no reason for this crucial loading step to be left to the client.
       
 43550 
       
 43551 2007-03-22  David Hyatt  <hyatt@apple.com>
       
 43552 
       
 43553         Minor refactoring and cleanup of the bridge calls that want to control layout settings on the RenderView.
       
 43554         Have the bridge talk through the FrameView instead of just asking for the RenderView directly.
       
 43555 
       
 43556         Add an assert to help catch situations where the RenderView needs layout at paint time, since this is a known
       
 43557         catastrophic scenario that will (much of the time) result in a crash in RenderTableSection::paint.
       
 43558 
       
 43559         Reviewed by aroben
       
 43560 
       
 43561         * page/FrameView.cpp:
       
 43562         (WebCore::FrameView::adjustViewSize):
       
 43563         (WebCore::FrameView::needsLayout):
       
 43564         (WebCore::FrameView::setNeedsLayout):
       
 43565         * page/FrameView.h:
       
 43566         * page/mac/WebCoreFrameBridge.mm:
       
 43567         (-[WebCoreFrameBridge needsLayout]):
       
 43568         (-[WebCoreFrameBridge setNeedsLayout]):
       
 43569         * rendering/RenderView.cpp:
       
 43570         (WebCore::RenderView::paint):
       
 43571 
       
 43572 2007-03-21  Geoffrey Garen  <ggaren@apple.com>
       
 43573 
       
 43574         Reviewed by Beth Dakin.
       
 43575         
       
 43576         Re-worked the fix in r20375. 'M' and 'm' are not the only commands that
       
 43577         accept "extra" coordinates -- virtually all commands accept them.
       
 43578 
       
 43579         * ksvg2/svg/SVGParserUtilities.cpp:
       
 43580         (WebCore::SVGPathParser::parseSVG):
       
 43581 
       
 43582 2007-03-21  David Harrison  <harrison@apple.com>
       
 43583 
       
 43584         Reviewed by hyatt.
       
 43585 
       
 43586         <rdar://problem/5072460> CrashTracer: [USER] 1 crashes in Xcode at com.apple.ImageIO.framework: getBandProcPNG + 168
       
 43587 
       
 43588         An NSData object was being alloc/init'd, then returned callers who cast the pointer as a
       
 43589         CFDataRef, including calling CFRelease on it. The problem is that under garbage collection, the NS
       
 43590         retain count is ignored (it's always 0), but the CFRetain and CFRelease are not ignored. This
       
 43591         caused the object to be over-released. The solution that works in both GC and non-GC is to "transfer"
       
 43592         the initial NS retain count to the CF retain count, using HardRetainWithNSRelease.
       
 43593         
       
 43594         The creator of the NSData was SharedBuffer::createNSData. The callers were PDFDocumentImage::dataChanged()
       
 43595         and ImageSource::setData(). This particular crash involved the ImageSource::setData() case.
       
 43596 
       
 43597         * platform/SharedBuffer.h:
       
 43598         Declare createCFData().
       
 43599         
       
 43600         * platform/graphics/cg/ImageSourceCG.cpp:
       
 43601         (WebCore::ImageSource::setData):
       
 43602         Call createCFData instead of createNSData.
       
 43603         
       
 43604         * platform/graphics/cg/PDFDocumentImage.cpp:
       
 43605         (WebCore::PDFDocumentImage::dataChanged):
       
 43606         Call createCFData instead of createNSData.
       
 43607         
       
 43608        * platform/mac/SharedBufferMac.mm:
       
 43609         (WebCore::SharedBuffer::createCFData):
       
 43610         Implement createCFData(). Use HardRetainWithNSRelease for gc safety.
       
 43611         
       
 43612 2007-03-21  Mitz Pettel  <mitz@webkit.org>
       
 43613 
       
 43614         Reviewed by Darin.
       
 43615 
       
 43616         - fix http://bugs.webkit.org/show_bug.cgi?id=13145
       
 43617           Regression: Scrollbar not resizing after display none
       
 43618 
       
 43619         Test: fast/dynamic/view-overflow.html
       
 43620 
       
 43621         * rendering/RenderView.cpp:
       
 43622         (WebCore::RenderView::layout): Reset overflowHeight() and overflowWidth()
       
 43623         before calling docHeight() and docWidth(), since the former act as a lower
       
 43624         bound for the latter.
       
 43625 
       
 43626 2007-03-21  Geoffrey Garen  <ggaren@apple.com>
       
 43627 
       
 43628         Reviewed by Beth Dakin.
       
 43629         
       
 43630         A little cleanup based work I've been doing on the SVG parsers.
       
 43631 
       
 43632         * ksvg2/svg/SVGParserUtilities.h:
       
 43633         (WebCore::skipString):
       
 43634         * ksvg2/svg/SVGPreserveAspectRatio.cpp: Moved checkString into
       
 43635         SVGParserUtilities.h, so it could be with all its friends. Renamed 
       
 43636         "checkString" to "skipString" to match the rest of the code and to be 
       
 43637         clear about which functions move the buffer pointer.
       
 43638         (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
       
 43639         * ksvg2/svg/SVGTransformable.cpp:
       
 43640         (WebCore::SVGTransformable::parseTransformAttribute): Changed gotos into 
       
 43641         returns. Removed unnecessary magic number.
       
 43642 
       
 43643 2007-03-21  Geoffrey Garen  <ggaren@apple.com>
       
 43644 
       
 43645         Reviewed by Beth Dakin.
       
 43646         
       
 43647         Fixed <rdar://problem/5078471> SVG rgb color parser runs past end of 
       
 43648         buffer when running fuzzing test
       
 43649 
       
 43650         * ksvg2/svg/SVGColor.cpp:
       
 43651         (WebCore::parseNumberOrPercent): Check for past the end condition.
       
 43652         (WebCore::SVGColor::colorFromRGBColorString): Reversed "read past end
       
 43653         of buffer, then check if you're past the end" logic.
       
 43654 
       
 43655 2007-03-21  Geoffrey Garen  <ggaren@apple.com>
       
 43656 
       
 43657         Reviewed by Beth Dakin.
       
 43658         
       
 43659         Fixed <rdar://problem/5079410> SVG path parser hangs, exhausts memory when 
       
 43660         running fuzzer test
       
 43661 
       
 43662         * ksvg2/svg/SVGParserUtilities.cpp:
       
 43663         (WebCore::SVGPathParser::parseSVG): Don't assume that extra digits are
       
 43664         always preceded by an 'M' or an 'm'.
       
 43665 
       
 43666 2007-03-21  John Sullivan  <sullivan@apple.com>
       
 43667 
       
 43668         Reviewed by Adam
       
 43669         
       
 43670         - fixed <rdar://problem/5079700> REGRESSION (r19702): Name/password aren't autofilled 
       
 43671           or saved for .Mac homepage login
       
 43672 
       
 43673         * page/mac/FrameMac.mm:
       
 43674         (WebCore::Frame::searchForLabelsBeforeElement):
       
 43675         don't count empty strings as valid results
       
 43676 
       
 43677 2007-03-21  Justin Garcia  <justin.garcia@apple.com>
       
 43678 
       
 43679         Reviewed by darin
       
 43680 
       
 43681         * editing/markup.cpp:
       
 43682         (WebCore::styleFromMatchedRulesAndInlineDecl): 
       
 43683         Release the RefPtr to avoid increasing/decreasing
       
 43684         the refcount unnecessarily.
       
 43685         (WebCore::propertyMissingOrEqualToNone): Added and used
       
 43686         instead of converting values to strings.
       
 43687         (WebCore::elementHasTextDecorationProperty): 
       
 43688         (WebCore::createMarkup):
       
 43689 
       
 43690 2007-03-21  Justin Garcia  <justin.garcia@apple.com>
       
 43691 
       
 43692         Reviewed by oliver
       
 43693 
       
 43694         <rdar://problem/5075944> 
       
 43695         REGRESSION: Partially selected underlined content pastes as plain text
       
 43696         
       
 43697         We stopped adding markup for all the ancestors
       
 43698         of lastClosed up to the commonAncestorBlock
       
 43699         because it was adding a lot of unnecessary markup.
       
 43700         This caused us to lose underlining when copying a 
       
 43701         partially selected underlined element (even though 
       
 43702         we put all styles that the copied markup inherits 
       
 43703         into a style span, because the text-decoration 
       
 43704         isn't inheritable).
       
 43705 
       
 43706         * editing/markup.cpp:
       
 43707         (WebCore::styleFromMatchedRulesAndInlineDecl): Moved
       
 43708         code here.
       
 43709         (WebCore::elementHasTextDecorationProperty): Added.
       
 43710         (WebCore::createMarkup): If the copied markup has a
       
 43711         text-decoration because some common ancestor has
       
 43712         a text-decoration property set, include that ancestor
       
 43713         and all its descendants in the copied markup.
       
 43714 
       
 43715 2007-03-21  Oliver Hunt  <oliver@apple.com>
       
 43716 
       
 43717         Reviewed by Antti.
       
 43718 
       
 43719         Update a few SVG attribute parsers to be more defensive against
       
 43720         reading beyond the end of input. 
       
 43721 
       
 43722         Fixes rdar://problem/5077218 -- SVG transform parser runs past
       
 43723         end of buffer when running fuzzing test
       
 43724 
       
 43725         * ksvg2/svg/SVGParserUtilities.cpp:
       
 43726         (WebCore::SVGPathParser::parseSVG):
       
 43727         * ksvg2/svg/SVGParserUtilities.h:
       
 43728         (WebCore::skipOptionalSpacesOrDelimiter):
       
 43729         * ksvg2/svg/SVGTransformable.cpp:
       
 43730         (WebCore::parseTransformParamList):
       
 43731         (WebCore::SVGTransformable::parseTransformAttribute):
       
 43732 
       
 43733 2007-03-21  Alexey Proskuryakov  <ap@webkit.org>
       
 43734 
       
 43735         Reviewed by Mitz.
       
 43736 
       
 43737         http://bugs.webkit.org/show_bug.cgi?id=13140
       
 43738         Crash after loading SVG fragment with XMLHttpRequest (Yosemite Map Geology Layer)
       
 43739 
       
 43740         Test: svg/carto.net/frameless-svg-parse-error.html
       
 43741 
       
 43742         * ksvg2/misc/SVGDocumentExtensions.cpp:
       
 43743         (WebCore::SVGDocumentExtensions::reportError): Added a null check.
       
 43744         (WebCore::SVGDocumentExtensions::reportWarning): Ditto.
       
 43745 
       
 43746 2007-03-21  Beth Dakin  <bdakin@apple.com>
       
 43747 
       
 43748         Reviewed by Geoff.
       
 43749 
       
 43750         Fix for <rdar://problem/5072678> Crash in
       
 43751         RenderLayer::scrollRectToVisible with MallocScribble enabled
       
 43752 
       
 43753         I tried to fix this earlier today but my fix caused a regression
       
 43754         scrolling through RSS pages. It turns out that sometimes scroll
       
 43755         events need to propagate immediately, and sometimes they must be
       
 43756         delayed or they risk deleting objects that are expected to be
       
 43757         around after the event has propagated. Mitz's original fix made
       
 43758         sheduleEvent() only delay events that happen during layout. This
       
 43759         fix marks two other places in addition to layout where events also
       
 43760         need to be delayed. These two places are places that were marked
       
 43761         with FIXMEs that Mitz removed in his original patch. (There was a
       
 43762         third FIXME in RenderLayer::updateScrollInfoAfterLayout() but that
       
 43763         case is only called through layout and is covered by Mitz's
       
 43764         original patch.)
       
 43765 
       
 43766         * page/FrameView.cpp:
       
 43767         (WebCore::FrameView::~FrameView): Added assertion.
       
 43768         (WebCore::FrameView::layout): Call new functions to increment and 
       
 43769         decrement the queued events count.
       
 43770         (WebCore::FrameView::pauseScheduledEvents):
       
 43771         (WebCore::FrameView::resumeScheduledEvents): Decrement queued 
       
 43772         events count and dispatch events if the count has zeroed.
       
 43773         * page/FrameView.h:
       
 43774         * rendering/RenderLayer.cpp:
       
 43775         (WebCore::RenderLayer::scrollRectToVisible):
       
 43776         (WebCore::Marquee::start):
       
 43777 
       
 43778 2007-03-21  Mitz Pettel  <mitz@webkit.org>
       
 43779 
       
 43780         Reviewed by John Sullivan.
       
 43781 
       
 43782         - fix http://bugs.webkit.org/show_bug.cgi?id=13130
       
 43783           REGRESSION: Sometimes a frame resizer keeps following the mouse after mouseup
       
 43784 
       
 43785         * rendering/RenderFrameSet.cpp:
       
 43786         (WebCore::RenderFrameSet::userResize): Reordered the code to allow resizing
       
 43787         to be terminated by a mouseup event regardless of whether the frameset needs
       
 43788         layout.
       
 43789 
       
 43790 2007-03-20  Anders Carlsson  <acarlsson@apple.com>
       
 43791 
       
 43792         Reviewed by Oliver.
       
 43793 
       
 43794         <rdar://problem/5077252> 
       
 43795         In NetNewsWire 2.1.1 and 3.0d62, a crash occurs after triple-clicking a link on the page
       
 43796         
       
 43797         * loader/FrameLoader.cpp:
       
 43798         (WebCore::FrameLoader::load):
       
 43799         Move the m_inStopAllLoaders check to the load function that's common for loading a request or substitute data.
       
 43800 
       
 43801 2007-03-20  Brady Eidson  <beidson@apple.com>
       
 43802 
       
 43803         Reviewed by Anders.
       
 43804 
       
 43805         <rdar://problem/5073391> and http://bugs.webkit.org/show_bug.cgi?id=13137
       
 43806 
       
 43807         Crash in IconDatabase when private browsing is enabled.
       
 43808 
       
 43809         The problem was caused by http://trac.webkit.org/projects/webkit/changeset/20182 
       
 43810         which changed many uses of char[] and Vector<char> to SharedBuffer.  The patch
       
 43811         tended to literally replace a Vector<char> with RefPtr<SharedBuffers> but forgot
       
 43812         to enforce the concept that Vector<char>'s always exist, whereas RefPtr<SharedBuffers>
       
 43813         can be null.  This led to derefs.
       
 43814 
       
 43815         I took the opportunity to rework the iconDB functions to live in a SharedBuffer 
       
 43816         world, as that didn't exist when they were originally written - now they just return
       
 43817         SharedBuffers instead of taking a Vector<char>& as a parameter
       
 43818 
       
 43819         * loader/icon/IconDatabase.cpp:
       
 43820         (WebCore::IconDatabase::imageDataForIconURL): Return a SharedBuffer
       
 43821         (WebCore::IconDatabase::iconForPageURL): Null check the SharedBuffer before asking
       
 43822           it if it's empty
       
 43823         (WebCore::IconDatabase::imageDataForIconURLQuery): Return a new SharedBuffer
       
 43824 
       
 43825         * loader/icon/IconDatabase.h: Return SharedBuffer's instead of taking Vector<char>&'s
       
 43826 
       
 43827 2007-03-20  Adam Roben  <aroben@apple.com>
       
 43828 
       
 43829         Rubberstamped by Adele.
       
 43830 
       
 43831         Roll out r20348 because it was causing crashes.
       
 43832 
       
 43833         * page/FrameView.cpp:
       
 43834         (WebCore::FrameViewPrivate::FrameViewPrivate):
       
 43835         (WebCore::FrameView::layout):
       
 43836         (WebCore::FrameView::scheduleEvent):
       
 43837 
       
 43838 2007-03-20  Timothy Hatcher  <timothy@apple.com>
       
 43839 
       
 43840         Reviewed by Kevin Decker.
       
 43841 
       
 43842         Rolling out part of r19828 that caused a scrolling regression in Mail.
       
 43843 
       
 43844         <rdar://problem/4820817> Message jumps around when trying to select text
       
 43845 
       
 43846         * platform/mac/ScrollViewMac.mm:
       
 43847         (WebCore::ScrollView::visibleContentRect):
       
 43848         (WebCore::ScrollView::updateContents):
       
 43849 
       
 43850 2007-03-20  Brady Eidson  <beidson@apple.com>
       
 43851 
       
 43852         Reviewed by John
       
 43853 
       
 43854         <rdar://5071341> - Crash in IconLoader::finishLoading()
       
 43855         
       
 43856         Though the reproducibility of the crash is still elusive, there's been a crasher likely uncovered 
       
 43857         Hyatt's recent caching changings to the IconLoader.  This crash tends to hit on sites without favicons,
       
 43858         that serve up complex 404 pages, often when the load is cancelled or redirected.  Occasionally, it *seems*
       
 43859         the IconLoader is getting failed/cancelled twice.
       
 43860         
       
 43861         This patch adds some assertions and a "fail gracefully in a release build" check that will have to
       
 43862         serve us until we know more about the cause.
       
 43863 
       
 43864         * loader/icon/IconLoader.cpp:
       
 43865         (WebCore::IconLoader::didFail): Add an assertion to catch this case
       
 43866         (WebCore::IconLoader::finishLoading): Add an assertion to catch the case, and fail
       
 43867           gracefully in debug builds.  Also add an efficiency check to not commit to the DB if there is no
       
 43868           IconURL
       
 43869 
       
 43870 2007-03-20  Antti Koivisto  <antti@apple.com>
       
 43871 
       
 43872         Reviewed by Darin.
       
 43873 
       
 43874         - fix http://bugs.webkit.org/show_bug.cgi?id=10747
       
 43875         REGRESSION: Using two fingers on a trackpad to scroll inside a text area makes the whole page move
       
 43876         <rdar://problem/5045710>
       
 43877         
       
 43878         Eat smooth scroll events in WebCore if pointer is over scrollable area. Not
       
 43879         really a good fix, smooth scrolling should be supported properly. It should do for now.
       
 43880 
       
 43881         * page/EventHandler.cpp:
       
 43882         (WebCore::EventHandler::handleWheelEvent):
       
 43883         * rendering/RenderListBox.cpp:
       
 43884         (WebCore::RenderListBox::isScrollable):
       
 43885         * rendering/RenderListBox.h:
       
 43886         * rendering/RenderObject.cpp:
       
 43887         (WebCore::RenderObject::isScrollable):
       
 43888         * rendering/RenderObject.h:
       
 43889         * rendering/RenderTextControl.cpp:
       
 43890         (WebCore::RenderTextControl::isScrollable):
       
 43891         * rendering/RenderTextControl.h:
       
 43892 
       
 43893 2007-03-20  Beth Dakin  <bdakin@apple.com>
       
 43894 
       
 43895         Reviewed by Geoff.
       
 43896 
       
 43897         Covered by existing test case.
       
 43898 
       
 43899         Fix for <rdar://problem/5072678> Crash in 
       
 43900         RenderLayer::scrollRectToVisible with MallocScribble enabled
       
 43901 
       
 43902         This removes some code that was added with http://bugs.webkit.org/
       
 43903         show_bug.cgi?id=8360. This code was not needed to fix that bug, but 
       
 43904         the idea behind it was that there are times when it is safe for 
       
 43905         scheduleEvent() to propagate the event immediately. The 
       
 43906         MallocScribble crash revealed that this assumption was a bit too 
       
 43907         broad; the cause of the crash was that we were propagating events 
       
 43908         immediately when it was not safe. Mitz and I discussed this online 
       
 43909         and we agree that the safest solution is to revert to the old 
       
 43910         behavior here, and always delay the propagation of the event. 
       
 43911 
       
 43912         * page/FrameView.cpp:
       
 43913         (WebCore::FrameViewPrivate::FrameViewPrivate):
       
 43914         (WebCore::FrameView::layout):
       
 43915         (WebCore::FrameView::scheduleEvent):
       
 43916 
       
 43917 2007-03-20  Brady Eidson  <beidson@apple.com>
       
 43918 
       
 43919         Reviewed by John Sullivan
       
 43920 
       
 43921         Add some very helpful logging to the IconLoader's SubresourceLoaderClient impl.
       
 43922 
       
 43923         * loader/icon/IconLoader.cpp:
       
 43924         (WebCore::IconLoader::didReceiveResponse):
       
 43925         (WebCore::IconLoader::didReceiveData):
       
 43926         (WebCore::IconLoader::didFail):
       
 43927         (WebCore::IconLoader::didFinishLoading):
       
 43928 
       
 43929 2007-03-20  Justin Garcia  <justin.garcia@apple.com>
       
 43930 
       
 43931         Reviewed by darin
       
 43932 
       
 43933         <rdar://problem/5071074> 
       
 43934         REGRESSION: Links are pasted as plain text at certain positions
       
 43935         
       
 43936         moveParagraphs calls createMarkup without annotation, which leaves
       
 43937         out anchor elements that aren't fully selected.
       
 43938 
       
 43939         * editing/CompositeEditCommand.cpp:
       
 43940         (WebCore::CompositeEditCommand::moveParagraphs): We don't want 
       
 43941         createMarkup to do full annotation here.  Doing so could include 
       
 43942         special ancestor blocks, which would prevent the copied content 
       
 43943         from appearing in the destination paragraph when it's re-inserted.  
       
 43944         Annotation would also inline styles from style sheets,  which is 
       
 43945         unnecessary because the content is being moved to the same 
       
 43946         document it's being moved from.
       
 43947         Added a new bool to createMarkup that when true allows markup for 
       
 43948         special ancestors as long as they are inline when annotation is off.
       
 43949         * editing/markup.cpp:
       
 43950         (WebCore::createMarkup): Don't set specialCommonAncestor if annotation
       
 43951         is off, unless it's inline and we've been told it's ok to include such
       
 43952         elements.
       
 43953         * editing/markup.h:
       
 43954 
       
 43955 2007-03-20  Alexey Proskuryakov  <ap@webkit.org>
       
 43956 
       
 43957         Reviewed by Darin.
       
 43958 
       
 43959         http://bugs.webkit.org/show_bug.cgi?id=12497
       
 43960         Implement XPath result ordering.
       
 43961 
       
 43962         XPath::NodeVector typedef is replaced with a real XPath::NodeSet class that knows how 
       
 43963         to sort itself, and can remember whether it has been already sorted.
       
 43964 
       
 43965         * CMakeLists.txt:
       
 43966         * WebCore.pro:
       
 43967         * WebCore.xcodeproj/project.pbxproj:
       
 43968         * WebCoreSources.bkl:
       
 43969         Added XPathNodeSet files.
       
 43970 
       
 43971         * xml/XPathExpression.cpp: Fixed includes.
       
 43972 
       
 43973         * xml/XPathFunctions.cpp:
       
 43974         (WebCore::XPath::FunId::evaluate): Mark the resulting node-set as unsorted.
       
 43975         (WebCore::XPath::FunLocalName::evaluate): Replacing NodeVector with NodeSet.
       
 43976         (WebCore::XPath::FunNamespaceURI::evaluate): Ditto.
       
 43977         (WebCore::XPath::FunName::evaluate): Ditto.
       
 43978         (WebCore::XPath::FunCount::evaluate): Ditto.
       
 43979         (WebCore::XPath::FunSum::evaluate): Ditto.
       
 43980 
       
 43981         * xml/XPathNodeSet.cpp: Added.
       
 43982         (WebCore::XPath::parentWithDepth):
       
 43983         (WebCore::XPath::sortBlock):
       
 43984         (WebCore::XPath::NodeSet::sort): Sort the node-set in document order.
       
 43985         (WebCore::XPath::NodeSet::reverse): Reverse the order (useful for making axes such as 
       
 43986         parent or ancestor sorted).
       
 43987         (WebCore::XPath::NodeSet::firstNode): Returns the first node in document order; currently
       
 43988         implemented via fully sorting the node-set, but this can obviously be optimized.
       
 43989         (WebCore::XPath::NodeSet::anyNode): Added for symmetry with firstNode().
       
 43990         
       
 43991         * xml/XPathNodeSet.h: Added.
       
 43992         (WebCore::XPath::NodeSet::NodeSet):
       
 43993         (WebCore::XPath::NodeSet::operator=):
       
 43994         (WebCore::XPath::NodeSet::size):
       
 43995         (WebCore::XPath::NodeSet::isEmpty):
       
 43996         (WebCore::XPath::NodeSet::operator[]):
       
 43997         (WebCore::XPath::NodeSet::reserveCapacity):
       
 43998         (WebCore::XPath::NodeSet::clear):
       
 43999         (WebCore::XPath::NodeSet::swap):
       
 44000         (WebCore::XPath::NodeSet::append):
       
 44001         (WebCore::XPath::NodeSet::markSorted):
       
 44002         (WebCore::XPath::NodeSet::isSorted):
       
 44003         Most of these methods just call Vector counterparts. 
       
 44004 
       
 44005         * xml/XPathParser.cpp: Updated the copyright notice.
       
 44006 
       
 44007         * xml/XPathPath.cpp:
       
 44008         (WebCore::XPath::Filter::evaluate): Replacing NodeVector with NodeSet.
       
 44009         (WebCore::XPath::Path::evaluate): Ditto.
       
 44010         (WebCore::XPath::LocationPath::evaluate): Replacing NodeVector with NodeSet. This function
       
 44011         always marks the result as unsorted, because it is hard to tell whether a step breaks node order.
       
 44012         Identifying and implementing special cases when it is not necessary to do so is an important
       
 44013         future optimization.
       
 44014 
       
 44015         * xml/XPathPath.h: Replacing NodeVector with NodeSet.
       
 44016         * xml/XPathPredicate.cpp:
       
 44017         (WebCore::XPath::EqTestOp::compare): Replacing NodeVector with NodeSet.
       
 44018         (WebCore::XPath::Union::evaluate): Replacing NodeVector with NodeSet. Currently, Union just
       
 44019         marks the result as unordered; we can consider using merge sort to avoid this.
       
 44020 
       
 44021         * xml/XPathResult.cpp:
       
 44022         (WebCore::XPathResult::XPathResult): Replacing NodeVector with NodeSet.
       
 44023         (WebCore::XPathResult::singleNodeValue): Ditto.
       
 44024         (WebCore::XPathResult::snapshotLength): Ditto.
       
 44025         (WebCore::XPathResult::iterateNext): Ditto.
       
 44026         (WebCore::XPathResult::snapshotItem): Ditto.
       
 44027         (WebCore::XPathResult::convertTo): Ditto. Sort the result when requested to.
       
 44028 
       
 44029         * xml/XPathResult.h: Replacing NodeVector with NodeSet.
       
 44030 
       
 44031         * xml/XPathStep.cpp:
       
 44032         (WebCore::XPath::Step::evaluate): If the input is not sorted, mark the output as such, too.
       
 44033         (WebCore::XPath::Step::nodesInAxis): Fixed a number of bugs when enumerating with an
       
 44034         attribute context node.
       
 44035         (WebCore::XPath::Step::nodeTestMatches): Replacing NodeVector with NodeSet.
       
 44036         * xml/XPathStep.h: Ditto.
       
 44037 
       
 44038         * xml/XPathUtil.cpp:
       
 44039         (WebCore::XPath::isValidContextNode): XPath data model doesn't put attribute data into child
       
 44040         nodes, so passing such node as a context could cause problems.
       
 44041 
       
 44042         * xml/XPathUtil.h: Removed NodeVector typedef.
       
 44043 
       
 44044         * xml/XPathValue.cpp:
       
 44045         (WebCore::XPath::Value::Value):
       
 44046         (WebCore::XPath::Value::toNodeSet):
       
 44047         (WebCore::XPath::Value::toBoolean):
       
 44048         (WebCore::XPath::Value::toNumber):
       
 44049         (WebCore::XPath::Value::toString):
       
 44050         * xml/XPathValue.h:
       
 44051         (WebCore::XPath::Value::):
       
 44052         (WebCore::XPath::Value::isNodeSet):
       
 44053         Replacing NodeVector with NodeSet.
       
 44054 
       
 44055 2007-03-21  Mark Rowe  <mrowe@apple.com>
       
 44056 
       
 44057         Build fix.
       
 44058 
       
 44059         * bindings/objc/WebScriptObject.mm:
       
 44060         (-[WebScriptObject methodForSelector:]):
       
 44061         (-[WebScriptObject respondsToSelector:]):
       
 44062 
       
 44063 2007-03-21  Mark Rowe  <mrowe@apple.com>
       
 44064 
       
 44065         Reviewed by Tim Hatcher.
       
 44066 
       
 44067         Fix for http://bugs.webkit.org/show_bug.cgi?id=13129.
       
 44068         Bug 13129: Democracy Player dies in NSException from WebScriptObject on startup.
       
 44069 
       
 44070         Some cross-language scripting bridges use the presence of -(int)count to determine
       
 44071         whether to treat objects as sequence-like.  All WebScriptObject's exposed this method
       
 44072         which lead to non-collection WebScriptObject's being mishandled by PyObjC.  We now
       
 44073         expose -count only when the object we wrap looks like a collection from a JavaScript
       
 44074         point of view (eg, it has a length property).
       
 44075 
       
 44076         * bindings/objc/WebScriptObject.mm:
       
 44077         (-[WebScriptObject _shouldRespondToCount]):
       
 44078         (-[WebScriptObject methodForSelector:]):
       
 44079         (-[WebScriptObject respondsToSelector:]):
       
 44080         (-[WebScriptObject _count]):
       
 44081         * bindings/objc/WebScriptObjectPrivate.h:
       
 44082 
       
 44083 2007-03-20  Darin Adler  <darin@apple.com>
       
 44084 
       
 44085         * page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent):
       
 44086         Fix obvious typo in the change from last night -- forgot to assign to the variable.
       
 44087 
       
 44088 2007-03-20  Dave Hyatt  <hyatt@apple.com>
       
 44089 
       
 44090         Refactor fonts a bit for portability.
       
 44091        
       
 44092         Reviewed by aroben
       
 44093 
       
 44094         * platform/Font.cpp:
       
 44095         (WebCore::Font::drawSimpleText):
       
 44096         (WebCore::Font::drawGlyphBuffer):
       
 44097         (WebCore::Font::floatWidthForSimpleText):
       
 44098         * platform/Font.h:
       
 44099         * platform/FontData.h:
       
 44100         (WebCore::FontData::isSystemFont):
       
 44101         (WebCore::FontData::scriptCache):
       
 44102         * platform/GlyphBuffer.h:
       
 44103         (WebCore::GlyphBuffer::add):
       
 44104 
       
 44105 2007-03-20  Anders Carlsson  <acarlsson@apple.com>
       
 44106 
       
 44107         Reviewed by Adam.
       
 44108 
       
 44109         Stub out a couple of CFNetwork backend functions.
       
 44110         
       
 44111         * platform/network/ResourceHandle.h:
       
 44112 
       
 44113 2007-03-19  Oliver Hunt  <oliver@apple.com>
       
 44114 
       
 44115         Reviewed by Ada.
       
 44116 
       
 44117         Protect against possibility of JS detaching a frame (and losing its view)
       
 44118         midway through a mouse move.
       
 44119 
       
 44120         * page/EventHandler.cpp:
       
 44121         (WebCore::EventHandler::handleMouseMoveEvent):
       
 44122 
       
 44123 2007-03-19  Alexey Proskuryakov  <ap@webkit.org>
       
 44124 
       
 44125         Reviewed by Darin.
       
 44126 
       
 44127         http://bugs.webkit.org/show_bug.cgi?id=13107
       
 44128         XPath should raise an exception when trying to parse an unknown function
       
 44129 
       
 44130         Test: fast/xpath/invalid-functions.html
       
 44131 
       
 44132         * xml/XPathFunctions.cpp:
       
 44133         (WebCore::XPath::createFunction): Return 0 if the function couldn't be created.
       
 44134         * xml/XPathGrammar.y: Handle nulls returned from createFunction().
       
 44135 
       
 44136 2007-03-19  Adele Peterson  <adele@apple.com>
       
 44137 
       
 44138         Reviewed by Beth.
       
 44139 
       
 44140         Fix for http://bugs.webkit.org/show_bug.cgi?id=13087
       
 44141         <rdar://problem/5064316> REGRESSION: Allow setting the checked attribute in js and in markup for unnamed radio buttons (dominos.com)
       
 44142 
       
 44143         Test: fast/forms/radio_checked_name.html
       
 44144 
       
 44145         We were matching a WinIE quirk that does not allow a user to check and uncheck an unnamed radio button.  But they still
       
 44146         allow the checked attribute to be set in html, and changed in javascript.  So this change matches that behavior.
       
 44147 
       
 44148         * html/HTMLInputElement.cpp:
       
 44149         (WebCore::HTMLInputElement::parseMappedAttribute): We no longer need a special call to setChecked when parsing the name
       
 44150          attribute, since we setChecked will now work with unnamed radio buttons.
       
 44151         (WebCore::HTMLInputElement::preDispatchEventHandler): Added comment.
       
 44152         (WebCore::HTMLInputElement::setChecked): Don't check for the unnamed radio button case here.
       
 44153         (WebCore::HTMLInputElement::postDispatchEventHandler): Don't call setChecked for unnamed radio buttons.
       
 44154         (WebCore::HTMLInputElement::defaultEventHandler): ditto.
       
 44155 
       
 44156 2007-03-19  Adam Roben  <aroben@apple.com>
       
 44157 
       
 44158         Rubberstamped by Oliver.
       
 44159 
       
 44160         * bridge/JavaScriptStatistics.cpp: Added missing header for
       
 44161         correctness.
       
 44162 
       
 44163 2007-03-19  Andrew Wellington  <proton@wiretapped.net>
       
 44164 
       
 44165         Reviewed by Maciej.
       
 44166 
       
 44167         Really set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)
       
 44168 
       
 44169         * WebCore.xcodeproj/project.pbxproj:
       
 44170 
       
 44171 2007-03-19  Justin Garcia  <justin.garcia@apple.com>
       
 44172 
       
 44173         Reviewed by darin
       
 44174         
       
 44175         <rdar://problem/5071074> 
       
 44176         REGRESSION: Links that aren't fully selected copy and paste as only text
       
 44177         
       
 44178         We stopped adding markup for all commonAncestorBlocks
       
 44179         and the ancestors of lastClosed up to them because it 
       
 44180         was adding a lot of unnecessary markup.
       
 44181 
       
 44182         * editing/markup.cpp:
       
 44183         (WebCore::createMarkup): Also include markup for nodes
       
 44184         up to an enclosing anchor.  Cleaned up the code for
       
 44185         including special common ancestors a bit.
       
 44186 
       
 44187 2007-03-19  Nikolas Zimmermann  <zimmermann@kde.org>
       
 44188 
       
 44189         Reviewed by Lars Knoll.
       
 44190 
       
 44191         Fix crash when opening a SVG document which contains SVG elements, but no <svg> root element.
       
 44192         Moving the mouse was crashing WebKit. Fixes svg/hixie/dynamic/006.xml.
       
 44193 
       
 44194         * rendering/RenderObject.cpp:
       
 44195         (WebCore::RenderObject::updateHitTestResult):
       
 44196 
       
 44197 2007-03-19  Mitz Pettel  <mitz@webkit.org>
       
 44198 
       
 44199         Reviewed by Hyatt.
       
 44200 
       
 44201         - fix http://bugs.webkit.org/show_bug.cgi?id=13117
       
 44202         REGRESSION (r14658): Flickering text fields when updating via javascript
       
 44203 
       
 44204         * page/Frame.cpp:
       
 44205         (WebCore::Frame::forceLayout): Added a flag to allow partial relayout.
       
 44206         * page/Frame.h:
       
 44207         * page/mac/WebCoreFrameBridge.mm:
       
 44208         (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]): Allow partial relayout
       
 44209         if not adjusting view size.
       
 44210         (-[WebCoreFrameBridge needsLayout]): Changed to check for pending subtree
       
 44211         layout instead of just whether the root needs layout.
       
 44212 
       
 44213 2007-03-18  Nikolas Zimmermann  <zimmermann@kde.org>
       
 44214 
       
 44215         Reviewed by Maciej.
       
 44216 
       
 44217         Make JS function calls on POD-types (ie. SVGLength) take effect.
       
 44218         Calling ie. newValueInSpecifiedUnits on SVGLength works as expected.
       
 44219 
       
 44220         This worked fine before we switched to SVGLength POD type, so this
       
 44221         can be considered as P1 regression fix.
       
 44222 
       
 44223         Partly fix svg/hixie/dynamic/005-broken.svg. We match Opera now though
       
 44224         it's not yet completly fixed. Setting baseVal attribute on SVGAnimatedString
       
 44225         doesn't work as expected - needs a seperated fix.
       
 44226 
       
 44227         * bindings/scripts/CodeGeneratorJS.pm:
       
 44228 
       
 44229 2007-03-19  Adele Peterson  <adele@apple.com>
       
 44230 
       
 44231         Reviewed by Adam.
       
 44232 
       
 44233         Adding comments and a little cleanup from my last checkin.
       
 44234 
       
 44235         * html/HTMLSelectElement.cpp:
       
 44236         (WebCore::HTMLSelectElement::setSelectedIndex): Removed commented out assert.  Added comment about how we use onChange.
       
 44237         (WebCore::HTMLSelectElement::selectAll): Added comment about how we use saveLastSelection and onChange.
       
 44238         (WebCore::HTMLSelectElement::dispatchFocusEvent): ditto.
       
 44239         (WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
       
 44240         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
       
 44241         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
       
 44242         (WebCore::HTMLSelectElement::menuListOnChange): Added assert that usesMenuList() is true.
       
 44243         (WebCore::HTMLSelectElement::listBoxOnChange): Added assert that usesMenuList() is false.
       
 44244         (WebCore::HTMLSelectElement::saveLastSelection): Added early return for menu lists.
       
 44245 
       
 44246 2007-03-19  Mitz Pettel  <mitz@webkit.org>
       
 44247 
       
 44248         Reviewed by Tim Hatcher.
       
 44249 
       
 44250         - fix http://bugs.webkit.org/show_bug.cgi?id=13091
       
 44251           REGRESSION (r20075): Wrong text style and pixel break in Apple Store Locator HUD
       
 44252 
       
 44253         Test: fast/innerHTML/additional-inline-style.html
       
 44254 
       
 44255         * editing/markup.cpp:
       
 44256         (WebCore::startMarkup): Changed to add inline style based on CSS rules only
       
 44257         in AnnotateForInterchange mode.
       
 44258 
       
 44259 2007-03-19  Zack Rusin  <zrusin@trolltech.com>
       
 44260 
       
 44261         Compile fix.
       
 44262 
       
 44263         * platform/qt/ScrollViewQt.cpp:
       
 44264         (WebCore::ScrollView::update):
       
 44265 
       
 44266 2007-03-19  Adam Roben  <aroben@apple.com>
       
 44267 
       
 44268         Reviewed by Hyatt and Maciej.
       
 44269 
       
 44270         Renamed WebCoreJavaScript to JavaScriptStatistics and made it C++ as
       
 44271         part of <rdar://problem/5071653>.
       
 44272 
       
 44273         All layout tests pass.
       
 44274 
       
 44275         * WebCore.exp: Updated.
       
 44276         * WebCore.xcodeproj/project.pbxproj: Updated.
       
 44277         * bridge/JavaScriptStatistics.cpp: Moved from
       
 44278         bridge/mac/WebCoreJavaScript.mm, and converted to C++.
       
 44279         (WebCore::collect):
       
 44280         (WebCore::JavaScriptStatistics::objectCount):
       
 44281         (WebCore::JavaScriptStatistics::interpreterCount):
       
 44282         (WebCore::JavaScriptStatistics::protectedObjectCount):
       
 44283         (WebCore::JavaScriptStatistics::rootObjectTypeCounts):
       
 44284         (WebCore::JavaScriptStatistics::garbageCollect):
       
 44285         (WebCore::JavaScriptStatistics::garbageCollectOnAlternateThread):
       
 44286         (WebCore::JavaScriptStatistics::shouldPrintExceptions):
       
 44287         (WebCore::JavaScriptStatistics::setShouldPrintExceptions):
       
 44288         * bridge/JavaScriptStatistics.h: Added.
       
 44289         * bridge/mac/WebCoreJavaScript.h: Removed.
       
 44290         * bridge/mac/WebCoreJavaScript.mm: Removed.
       
 44291 
       
 44292 2007-03-18  Maciej Stachowiak  <mjs@apple.com>
       
 44293 
       
 44294         Reviewed by Mark.
       
 44295 
       
 44296         - avoid static construction (and global variable access) in a smarter, more portable way,
       
 44297         to later enable MUTLI_THREAD mode to work on other platforms and compilers.
       
 44298         
       
 44299         * bindings/js/JSCustomXPathNSResolver.cpp:
       
 44300         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
       
 44301         * bindings/js/JSHTMLInputElementBase.cpp:
       
 44302         (WebCore::JSHTMLInputElementBaseFunction::JSHTMLInputElementBaseFunction):
       
 44303         * bindings/js/JSHTMLOptionElementConstructor.cpp:
       
 44304         (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
       
 44305         * bindings/js/JSXMLHttpRequest.cpp:
       
 44306         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
       
 44307         * bindings/js/JSXSLTProcessor.cpp:
       
 44308         (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
       
 44309         * bindings/js/kjs_dom.cpp:
       
 44310         (KJS::DOMNamedNodeMap::getOwnPropertySlot):
       
 44311         (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
       
 44312         * bindings/js/kjs_events.cpp:
       
 44313         (KJS::JSAbstractEventListener::handleEvent):
       
 44314         * bindings/js/kjs_html.cpp:
       
 44315         (KJS::HTMLElementFunction::HTMLElementFunction):
       
 44316         (KJS::JSHTMLCollection::getOwnPropertySlot):
       
 44317         * bindings/js/kjs_window.cpp:
       
 44318         (KJS::ScheduledAction::execute):
       
 44319         * bindings/objc/WebScriptObject.mm:
       
 44320         * bindings/scripts/CodeGeneratorJS.pm:
       
 44321 
       
 44322 2007-03-18  Andrew Wellington  <proton@wiretapped.net>
       
 44323 
       
 44324         Reviewed by Mark Rowe
       
 44325 
       
 44326         Set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)
       
 44327 
       
 44328         * WebCore.xcodeproj/project.pbxproj:
       
 44329 
       
 44330 2007-03-18  David Hyatt  <hyatt@apple.com>
       
 44331 
       
 44332         Fix for REGRESSION bug 13108, frame borders being painted when they shouldn't be.  Rework both frame borders
       
 44333         and resizing to be more like other browsers.
       
 44334 
       
 44335         Reviewed by ggaren
       
 44336 
       
 44337         fast/frames/no-frame-borders.html
       
 44338 
       
 44339         * html/HTMLFrameElement.cpp:
       
 44340         (WebCore::HTMLFrameElement::HTMLFrameElement):
       
 44341         (WebCore::HTMLFrameElement::attach):
       
 44342         (WebCore::HTMLFrameElement::parseMappedAttribute):
       
 44343         * html/HTMLFrameElement.h:
       
 44344         (WebCore::HTMLFrameElement::hasFrameBorder):
       
 44345         * html/HTMLFrameElementBase.cpp:
       
 44346         (WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
       
 44347         (WebCore::HTMLFrameElementBase::parseMappedAttribute):
       
 44348         * html/HTMLFrameElementBase.h:
       
 44349         * html/HTMLFrameSetElement.cpp:
       
 44350         (WebCore::HTMLFrameSetElement::attach):
       
 44351         * html/HTMLFrameSetElement.h:
       
 44352         (WebCore::HTMLFrameSetElement::hasFrameBorder):
       
 44353         * html/HTMLIFrameElement.cpp:
       
 44354         (WebCore::HTMLIFrameElement::HTMLIFrameElement):
       
 44355         * rendering/RenderFrame.cpp:
       
 44356         (WebCore::RenderFrame::edgeInfo):
       
 44357         * rendering/RenderFrame.h:
       
 44358         * rendering/RenderFrameSet.cpp:
       
 44359         (WebCore::RenderFrameSet::paint):
       
 44360         (WebCore::RenderFrameSet::GridAxis::resize):
       
 44361         (WebCore::RenderFrameSet::fillFromEdgeInfo):
       
 44362         (WebCore::RenderFrameSet::computeEdgeInfo):
       
 44363         (WebCore::RenderFrameSet::edgeInfo):
       
 44364         (WebCore::RenderFrameSet::layout):
       
 44365         (WebCore::RenderFrameSet::startResizing):
       
 44366         (WebCore::RenderFrameSet::continueResizing):
       
 44367         (WebCore::RenderFrameSet::canResizeRow):
       
 44368         (WebCore::RenderFrameSet::canResizeColumn):
       
 44369         (WebCore::RenderFrameSet::splitPosition):
       
 44370         (WebCore::RenderFrameSet::hitTestSplit):
       
 44371         (WebCore::RenderFrameSet::dump):
       
 44372         * rendering/RenderFrameSet.h:
       
 44373         (WebCore::):
       
 44374         (WebCore::FrameEdgeInfo::FrameEdgeInfo):
       
 44375         (WebCore::FrameEdgeInfo::preventResize):
       
 44376         (WebCore::FrameEdgeInfo::allowBorder):
       
 44377         (WebCore::FrameEdgeInfo::setPreventResize):
       
 44378         (WebCore::FrameEdgeInfo::setAllowBorder):
       
 44379 
       
 44380 2007-03-19  Mark Rowe  <mrowe@apple.com>
       
 44381 
       
 44382         Rubber-stamped by Brady.
       
 44383 
       
 44384         Update references to bugzilla.opendarwin.org with bugs.webkit.org.
       
 44385 
       
 44386         * ChangeLog:
       
 44387         * WebCore.vcproj/WebCore/build-generated-files.sh:
       
 44388         * manual-tests/ATSU-bad-layout.html:
       
 44389         * manual-tests/accidental-strict-mode.html:
       
 44390         * manual-tests/applet-param-no-name.html:
       
 44391         * manual-tests/bidi-parens.html:
       
 44392         * manual-tests/bugzilla-3855.html:
       
 44393         * manual-tests/bugzilla-4840.html:
       
 44394         * manual-tests/bugzilla-6821.html:
       
 44395         * manual-tests/containing-block-position-chage.html:
       
 44396         * manual-tests/contenteditable-link.html:
       
 44397         * manual-tests/css3-cursor-fallback-quirks.html:
       
 44398         * manual-tests/css3-cursor-fallback-strict.html:
       
 44399         * manual-tests/custom-cursors.html:
       
 44400         * manual-tests/dictionary-scrolled-iframe.html:
       
 44401         * manual-tests/dom-manipulation-on-resize.html:
       
 44402         * manual-tests/drag-image-to-address-bar.html:
       
 44403         * manual-tests/empty-link-target.html:
       
 44404         * manual-tests/empty-title-popup.html:
       
 44405         * manual-tests/first-line-style-crash.html:
       
 44406         * manual-tests/invalid-mouse-event.html:
       
 44407         * manual-tests/left-overflow-repaint.html:
       
 44408         * manual-tests/linkjump-3.html:
       
 44409         * manual-tests/log-keypress-events.html:
       
 44410         * manual-tests/named-window-blank-target.html:
       
 44411         * manual-tests/plain-text-paste.html:
       
 44412         * manual-tests/plugin-controller-datasource.html:
       
 44413         * manual-tests/pre-tab-selection-rect.html:
       
 44414         * manual-tests/redirection-target.html:
       
 44415         * manual-tests/redraw-page-cache-visited-links.html:
       
 44416         * manual-tests/reset-initiatedDrag.html:
       
 44417         * manual-tests/resources/named-window-blank-target-step2.html:
       
 44418         * manual-tests/resources/named-window-blank-target-step3.html:
       
 44419         * manual-tests/resources/named-window-blank-target-step4.html:
       
 44420         * manual-tests/resources/redraw-page-cache-visited-links-2.html:
       
 44421         * manual-tests/scrollbar-hittest.html:
       
 44422         * manual-tests/scrollbar-hittest2.html:
       
 44423         * manual-tests/subview-click-assertion.html:
       
 44424         * manual-tests/tabbing-input-google.html:
       
 44425         * manual-tests/text-field-autoscroll.html:
       
 44426         * manual-tests/textarea-after-stylesheet-link.html:
       
 44427         * manual-tests/textarea-focus.html:
       
 44428         * manual-tests/whitespace-pre-affinity.html:
       
 44429 
       
 44430 2007-03-18  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 44431 
       
 44432         Not reviewed - gdk build fix.
       
 44433 
       
 44434         * platform/gdk/ScrollViewGdk.cpp:
       
 44435         (WebCore::ScrollView::update): add a stub
       
 44436 
       
 44437 2007-03-18  Brady Eidson  <beidson@apple.com>
       
 44438 
       
 44439         Reviewed by Hyatt
       
 44440 
       
 44441         http://bugs.webkit.org/show_bug.cgi?id=13111
       
 44442         When stopped a load before it completes, partial images become the 
       
 44443         broken image icon
       
 44444 
       
 44445         * loader/loader.cpp:
       
 44446         (WebCore::Loader::didFail): Split off into a method that knows the 
       
 44447           difference between failed and cancelled.  If a load is cancelled,
       
 44448           don't call error() on the object - only remove it from the cache
       
 44449         (WebCore::Loader::cancelRequests): Call didFail(loader, true)
       
 44450         * loader/loader.h: Added didFail(SubresourceLoader*, bool cancelled)
       
 44451 
       
 44452 2007-03-18  Mitz Pettel  <mitz@webkit.org>
       
 44453 
       
 44454         Reviewed by Adele.
       
 44455 
       
 44456         - fix http://bugs.webkit.org/show_bug.cgi?id=13101
       
 44457           REGRESSION (NativeTextField): Specifying word-wrap:break-word makes text field wrap
       
 44458 
       
 44459         Test: fast/forms/input-text-word-wrap.html
       
 44460 
       
 44461         * rendering/RenderTextControl.cpp:
       
 44462         (WebCore::RenderTextControl::createInnerTextStyle): Force the inner block to
       
 44463         'word-wrap:normal'.
       
 44464 
       
 44465 2007-03-18  Dan Waylonis  <waylonis@mac.com>
       
 44466 
       
 44467         Reviewed by Tim Hatcher.
       
 44468 
       
 44469         Fix http://bugs.webkit.org/show_bug.cgi?id=13005
       
 44470         Bug 13005: WebScriptObject +throwException needs NULL check.
       
 44471 
       
 44472         Add checking for NULL interpreter before throwing exception.
       
 44473 
       
 44474         * bindings/objc/WebScriptObject.mm:
       
 44475         (+[WebScriptObject throwException:]):
       
 44476 
       
 44477 2007-03-18  Geoffrey Garen  <ggaren@apple.com>
       
 44478 
       
 44479         Reviewed by Oliver Hunt.
       
 44480         
       
 44481         Fixed http://bugs.webkit.org/show_bug.cgi?id=13106
       
 44482         REGRESSION: Incomplete document.all implementation breaks abtelectronics.com 
       
 44483         (Style Change Through JavaScript Blanks Content)
       
 44484         
       
 44485         When indexing into collections, treat the empty string as an invalid argument,
       
 44486         instead of the number 0.
       
 44487 
       
 44488         * bindings/js/kjs_html.cpp:
       
 44489         (KJS::JSHTMLCollection::getOwnPropertySlot):
       
 44490         (KJS::JSHTMLCollection::callAsFunction):
       
 44491         (KJS::JSHTMLCollectionPrototypeFunction::callAsFunction):
       
 44492 
       
 44493 2007-03-18  David Hyatt  <hyatt@apple.com>
       
 44494 
       
 44495         Use fillRect instead of drawLine, since drawLine has some odd behavior (it's only used for borders).
       
 44496 
       
 44497         Reviewed by aroben
       
 44498 
       
 44499         * platform/graphics/IntRect.h:
       
 44500         * rendering/RenderFrameSet.cpp:
       
 44501         (WebCore::RenderFrameSet::paintColumnBorder):
       
 44502         (WebCore::RenderFrameSet::paintRowBorder):
       
 44503 
       
 44504 2007-03-18  David Hyatt  <hyatt@apple.com>
       
 44505 
       
 44506         Change the frameborder color to be light gray for framesets.
       
 44507 
       
 44508         Reviewed by aroben
       
 44509 
       
 44510         * rendering/RenderFrameSet.cpp:
       
 44511         (WebCore::borderFillColor):
       
 44512         (WebCore::RenderFrameSet::paintColumnBorder):
       
 44513         (WebCore::RenderFrameSet::paintRowBorder):
       
 44514 
       
 44515 2007-03-18  David Hyatt  <hyatt@apple.com>
       
 44516 
       
 44517         Make iframes work properly with frameborder="0".
       
 44518 
       
 44519         Reviewed by aroben
       
 44520 
       
 44521         * html/HTMLIFrameElement.cpp:
       
 44522         (WebCore::HTMLIFrameElement::mapToEntry):
       
 44523         (WebCore::HTMLIFrameElement::parseMappedAttribute):
       
 44524 
       
 44525 2007-03-18  David Hyatt  <hyatt@apple.com>
       
 44526 
       
 44527         Add a 2px border by default to <iframe>s for compatibility with other browsers.
       
 44528 
       
 44529         Reviewed by aroben
       
 44530 
       
 44531         * css/html4.css:
       
 44532 
       
 44533 2007-03-18  David Hyatt  <hyatt@apple.com>
       
 44534 
       
 44535         Move frame borders out of WebKit and into WebCore.
       
 44536 
       
 44537         Reviewed by aroben, olliej
       
 44538 
       
 44539         * bridge/mac/FrameViewMac.mm:
       
 44540         * css/html4.css:
       
 44541         * html/HTMLFrameSetElement.cpp:
       
 44542         (WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
       
 44543         (WebCore::HTMLFrameSetElement::mapToEntry):
       
 44544         (WebCore::HTMLFrameSetElement::parseMappedAttribute):
       
 44545         (WebCore::HTMLFrameSetElement::attach):
       
 44546         * html/HTMLFrameSetElement.h:
       
 44547         (WebCore::HTMLFrameSetElement::hasBorderColor):
       
 44548         * page/FrameView.cpp:
       
 44549         (WebCore::FrameViewPrivate::FrameViewPrivate):
       
 44550         * page/FrameView.h:
       
 44551         * page/mac/WebCoreFrameBridge.h:
       
 44552         * platform/graphics/IntRect.h:
       
 44553         (WebCore::IntRect::topLeft):
       
 44554         (WebCore::IntRect::topRight):
       
 44555         (WebCore::IntRect::bottomLeft):
       
 44556         (WebCore::IntRect::bottomRight):
       
 44557         * rendering/RenderFrame.cpp:
       
 44558         (WebCore::RenderFrame::viewCleared):
       
 44559         * rendering/RenderFrameSet.cpp:
       
 44560         (WebCore::borderStartEdgeColor):
       
 44561         (WebCore::borderEndEdgeColor):
       
 44562         (WebCore::RenderFrameSet::paintColumnBorder):
       
 44563         (WebCore::RenderFrameSet::paintRowBorder):
       
 44564         (WebCore::RenderFrameSet::paint):
       
 44565         * rendering/RenderFrameSet.h:
       
 44566         * rendering/RenderPartObject.cpp:
       
 44567         (WebCore::RenderPartObject::viewCleared):
       
 44568         * rendering/RenderView.cpp:
       
 44569         (WebCore::RenderView::repaintViewRectangle):
       
 44570 
       
 44571 2007-03-17  David Hyatt  <hyatt@apple.com>
       
 44572 
       
 44573         Make onload do an explicit paint when a top-level document is ready (to ensure that a first paint always
       
 44574         happens before any timers set by the onload can fire).
       
 44575 
       
 44576         Reviewed by aroben
       
 44577 
       
 44578         * dom/Document.cpp:
       
 44579         (WebCore::Document::implicitClose):
       
 44580         * platform/ScrollView.h:
       
 44581         * platform/mac/ScrollViewMac.mm:
       
 44582         (WebCore::ScrollView::update):
       
 44583 
       
 44584 2007-03-17  Dave Hyatt  <hyatt@apple.com>
       
 44585 
       
 44586         Prevent starvation of user input and painting when processing timers.
       
 44587         If we are already in the processing of a custom timer message, don't allow that
       
 44588         processing to do another PostMessage.  Force SetTimer to be used instead.
       
 44589       
       
 44590         Reviewed by ggaren
       
 44591 
       
 44592        * platform/win/SharedTimerWin.cpp:
       
 44593         (WebCore::TimerWindowWndProc):
       
 44594         (WebCore::setSharedTimerFireTime):
       
 44595 
       
 44596 2007-03-17  Geoffrey Garen  <ggaren@apple.com>
       
 44597 
       
 44598         Reviewed by Beth Dakin.
       
 44599 
       
 44600         Fixed <rdar://problem/5070967> REGRESSION (r20211): Repro crash when 
       
 44601         closing View Source window
       
 44602         
       
 44603         I award myself 0 points, and may God have mercy on my soul.
       
 44604 
       
 44605         * bindings/js/kjs_proxy.cpp:
       
 44606         (WebCore::KJSProxy::~KJSProxy):
       
 44607 
       
 44608 2007-03-17  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 44609 
       
 44610         Not reviewed - gdk build fix.
       
 44611 
       
 44612         * platform/gdk/TemporaryLinkStubs.cpp:
       
 44613         (Pasteboard::writeURL):
       
 44614 
       
 44615 2007-03-17  David Hyatt  <hyatt@apple.com>
       
 44616 
       
 44617         Fix tiny PLT regression.  Don't examine the border/background data for RenderImage when images change
       
 44618         unless we actually have a border/background.
       
 44619 
       
 44620         Reviewed by Brady
       
 44621 
       
 44622         * rendering/RenderImage.cpp:
       
 44623         (WebCore::RenderImage::imageChanged):
       
 44624 
       
 44625 2007-03-17  Nikolas Zimmermann  <zimmermann@kde.org>
       
 44626 
       
 44627         Reviewed by Sam Weinig.
       
 44628 
       
 44629         Fixes: http://bugs.webkit.org/show_bug.cgi?id=13046 (CSS styles on hover and focus are broken for <use>)
       
 44630         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12838 (SVG <use> CSS styles broken)
       
 44631         Added test: svg/custom/use-css-events.svg
       
 44632 
       
 44633         In general this fixes the peepo.co.uk website.
       
 44634 
       
 44635         Forgot to pass the actual StyleChange to the recalcStyle() function,
       
 44636         when calling it on the shadow tree root element.
       
 44637 
       
 44638         * ksvg2/svg/SVGUseElement.cpp:
       
 44639         (WebCore::SVGUseElement::recalcStyle):
       
 44640 
       
 44641 2007-03-17  Timothy Hatcher  <timothy@apple.com>
       
 44642 
       
 44643         Reviewed by Mark Rowe.
       
 44644 
       
 44645         Made Version.xcconfig smarter when building for different configurations.
       
 44646         Now uses the 522+ OpenSource version for Debug and Release, while using the
       
 44647         full 522.4 version for Production builds. The system prefix is also computed
       
 44648         based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.
       
 44649 
       
 44650         * Configurations/Version.xcconfig:
       
 44651         * Configurations/WebCore.xcconfig:
       
 44652 
       
 44653 2007-03-17  Antti Koivisto  <antti@apple.com>
       
 44654 
       
 44655         Reviewed by Adele.
       
 44656 
       
 44657         Fix http://bugs.webkit.org/show_bug.cgi?id=12595
       
 44658         REGRESSION: Can't add item to cart at lnt.com (JS type error)
       
 44659         <rdar://problem/4722863>
       
 44660         
       
 44661         Emulate Firefox behavior where form elements accessed by a name
       
 44662         can be accessed with that name later even if the name changes or
       
 44663         even if element is removed from the document.
       
 44664         
       
 44665         This is loosely based on Darin's earlier patch for the same problem but
       
 44666         is much less expansive. It takes somewhat different approach to more closely
       
 44667         mimic Firefox behavior. Includes expanded test case.
       
 44668 
       
 44669         * bindings/js/JSHTMLFormElementCustom.cpp:
       
 44670         (WebCore::JSHTMLFormElement::canGetItemsForName):
       
 44671             Use new the HTMLFormElement::getNamedElements() method
       
 44672         (WebCore::JSHTMLFormElement::nameGetter):
       
 44673             Use new the HTMLFormElement::getNamedElements() method
       
 44674         * html/HTMLFormElement.cpp:
       
 44675         (WebCore::HTMLFormElement::HTMLFormElement):
       
 44676         (WebCore::HTMLFormElement::~HTMLFormElement):
       
 44677         (WebCore::HTMLFormElement::elementForAlias):
       
 44678         (WebCore::HTMLFormElement::addElementAlias):
       
 44679             Maintain a map of known element aliases
       
 44680         (WebCore::HTMLFormElement::getNamedElements):
       
 44681             Get a list of elements matching the name, based both their
       
 44682             current names and known aliases (earlier names).
       
 44683             Keep the alias list in sync.
       
 44684         * html/HTMLFormElement.h:
       
 44685 
       
 44686 2007-03-17  Adele Peterson  <adele@apple.com>
       
 44687 
       
 44688         Reviewed by Hyatt.
       
 44689 
       
 44690         Fix for <rdar://problem/4990050> REGRESSION: onchange gets fired when clicking on a programmatically selected element in a listbox
       
 44691         http://bugs.webkit.org/show_bug.cgi?id=12725
       
 44692 
       
 44693         Test: updated fast/forms/listbox-onchange.html
       
 44694 
       
 44695         Added HTMLSelectElement::saveLastSelection that is called before changing a selection that could result
       
 44696         in onChange being called.  m_lastOnChangeIndex and m_lastOnChangeSelection no longer have to be up-to date all the time, 
       
 44697         they just have to be up-to-date before we execute an action that may trigger onChange.
       
 44698 
       
 44699         * html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setSelectedState): Added.
       
 44700           The HTMLSelectElement will only set an option's selected state with this method.  This ensures
       
 44701           that notifyOptionSelected won't get called when the call originates from the select element.
       
 44702         * html/HTMLOptionElement.h:
       
 44703 
       
 44704         * html/HTMLSelectElement.cpp:
       
 44705         (WebCore::HTMLSelectElement::deselectItems): Calls setSelectedState.
       
 44706         (WebCore::HTMLSelectElement::setSelectedIndex): ditto. Don't update the last selection variables here.  Scroll to the new selection.
       
 44707          The scrolling call used to only be in notifyOptionSelected.  There's no reason we shouldn't scroll when the selection is set through
       
 44708          the HTMLSelectElement.
       
 44709         (WebCore::HTMLSelectElement::setValue): Call setSelectedIndex to update all options selected state.
       
 44710         (WebCore::HTMLSelectElement::restoreState): Call setSelectedState.
       
 44711         (WebCore::HTMLSelectElement::selectAll): Call saveLastSelection before making the selection, and calling onChange.
       
 44712         (WebCore::HTMLSelectElement::recalcListItems): Call setSelectedState.  Don't need to save selection here anymore, 
       
 44713          since it will get saved before we call onChange.
       
 44714         (WebCore::HTMLSelectElement::reset): ditto.
       
 44715         (WebCore::HTMLSelectElement::dispatchFocusEvent): Added. Call saveLastSelection for menu lists, since onChange can be fired
       
 44716          on blur.
       
 44717         (WebCore::HTMLSelectElement::dispatchBlurEvent): Call menuListOnChange.
       
 44718         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Call saveLastSelection before showing the popup window.
       
 44719         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):  Call saveLastSelection during mousedown (to prepare for an 
       
 44720          onchange during mouseup, or after autoscroll).
       
 44721         (WebCore::HTMLSelectElement::updateListBoxSelection): Call setSelectedState.
       
 44722 
       
 44723         (WebCore::HTMLSelectElement::menuListOnChange): Added. Compares the m_lastOnChangeIndex to the selectedIndex().
       
 44724         (WebCore::HTMLSelectElement::listBoxOnChange): Move the m_lastOnChangeSelection creation to saveLastSelection.
       
 44725         (WebCore::HTMLSelectElement::saveLastSelection): Added. Sets m_lastOnChangeIndex or m_lastOnChangeSelection.
       
 44726         * html/HTMLSelectElement.h:
       
 44727         * platform/PopupMenu.h:
       
 44728 
       
 44729 2007-03-16  Oliver Hunt  <oliver@apple.com>
       
 44730 
       
 44731         Reviewed by Hyatt.
       
 44732 
       
 44733         The old canSaveAsWebArchive call was necessary as stand alone
       
 44734         images used to be rendered by ImageDocument.
       
 44735 
       
 44736         Fixes rdar://problem/5061252
       
 44737 
       
 44738         * dom/Clipboard.cpp:
       
 44739         * dom/Clipboard.h:
       
 44740         (WebCore::Clipboard::setDragHasStarted):
       
 44741         * page/DragClient.h:
       
 44742         (WebCore::DragClient::declareAndWriteDragImage):
       
 44743         * platform/mac/ClipboardMac.mm:
       
 44744         (WebCore::ClipboardMac::declareAndWriteDragImage):
       
 44745 
       
 44746 2007-03-16  Anders Carlsson  <acarlsson@apple.com>
       
 44747 
       
 44748         Reviewed by Maciej.
       
 44749 
       
 44750         <rdar://problem/4869095>
       
 44751         default content type changed for XMLHttpRequest POSTs changed (breaks Flickrator 0.1 widget)
       
 44752         
       
 44753         * xml/xmlhttprequest.cpp:
       
 44754         (WebCore::XMLHttpRequest::send):
       
 44755 
       
 44756 2007-03-16  Brady Eidson  <beidson@apple.com>
       
 44757 
       
 44758         Rubberstamped by Tim Hatcher
       
 44759 
       
 44760         Update the hash table header for Window object properties
       
 44761 
       
 44762         * bindings/js/kjs_window.cpp:
       
 44763 
       
 44764 2007-03-16  Brady Eidson  <beidson@apple.com>
       
 44765 
       
 44766         Reviewed by Anders
       
 44767 
       
 44768         <rdar://problem/5061826> and
       
 44769         http://bugs.webkit.org/show_bug.cgi?id=12863
       
 44770         Implement window.stop()
       
 44771 
       
 44772         * bindings/js/kjs_window.cpp:
       
 44773         (KJS::WindowFunc::callAsFunction): Add case Window::Stop
       
 44774         * bindings/js/kjs_window.h:
       
 44775         (KJS::Window::): Add "Stop"
       
 44776 
       
 44777 2007-03-16  Geoffrey Garen  <ggaren@apple.com>
       
 44778 
       
 44779         Reviewed by Brady Eidson.
       
 44780 
       
 44781         Fixed dir creation to account for already existing dirs and missing leading
       
 44782         dirs in path.
       
 44783         
       
 44784         * loader/icon/IconDatabase.cpp:
       
 44785         (WebCore::makeAllDirectories):
       
 44786 
       
 44787 2007-03-16  David Hyatt  <hyatt@apple.com>
       
 44788 
       
 44789         Fix for 13084, assertion failure in the Cache.  Convert the client list
       
 44790         to a HashCountedSet so that multiple refs and derefs are allowed.
       
 44791 
       
 44792         Fix RenderImage so that if it has the same image used as a background/border
       
 44793         and as the foreground that it will repaint properly (can be tested using
       
 44794         border-image and a foreground image).
       
 44795 
       
 44796         Optimize list marker so that it doesn't waste time in the base class method,
       
 44797         since list markers don't support background or border images.
       
 44798 
       
 44799         Reviewed by andersca
       
 44800 
       
 44801         * ChangeLog:
       
 44802         * loader/CachedResource.cpp:
       
 44803         (WebCore::CachedResource::ref):
       
 44804         * loader/CachedResource.h:
       
 44805         * loader/CachedResourceClientWalker.cpp:
       
 44806         (WebCore::CachedResourceClientWalker::CachedResourceClientWalker):
       
 44807         * loader/CachedResourceClientWalker.h:
       
 44808         * rendering/RenderImage.cpp:
       
 44809         (WebCore::RenderImage::imageChanged):
       
 44810         * rendering/RenderListMarker.cpp:
       
 44811         (WebCore::RenderListMarker::imageChanged):
       
 44812 
       
 44813 2007-03-16  Geoffrey Garen  <ggaren@apple.com>
       
 44814 
       
 44815         Reviewed by Anders Carlsson.
       
 44816         
       
 44817         Fixed <rdar://problem/5065399> REGRESSION: leaks in Frame::bindingRootObject 
       
 44818         seen on buildbot
       
 44819 
       
 44820         The problem was that we were initializing the same WebScriptObject twice.
       
 44821         This caused it to leak its original set of ivars.
       
 44822         
       
 44823         I think some refactoring could prevent this situation from arising in the
       
 44824         first place, but I'm just adding a check at the call site for now, to do 
       
 44825         the simplest thing.
       
 44826 
       
 44827         * bindings/objc/WebScriptObject.mm:
       
 44828         (-[WebScriptObject _setImp:originRootObject:rootObject:]): Added ASSERTs
       
 44829         against multiple calls.
       
 44830 
       
 44831         * bindings/objc/WebScriptObjectPrivate.h: Renamed _initializeWithObjectImp
       
 44832         to setImp because "init" vs "initialize" was a too subtle indication that
       
 44833         one was a Cocoa initializer and one was not.
       
 44834 
       
 44835 2007-03-16  Lars Knoll <lars@trolltech.com>
       
 44836 
       
 44837         don't use #import in .cpp files.
       
 44838 
       
 44839         * editing/qt/EditorQt.cpp:
       
 44840 
       
 44841 2007-03-16  Lars Knoll <lars@trolltech.com>
       
 44842 
       
 44843         Fix the Qt build once again.
       
 44844 
       
 44845         * platform/qt/PasteboardQt.cpp:
       
 44846         (WebCore::Pasteboard::Pasteboard):
       
 44847         (WebCore::Pasteboard::writeSelection):
       
 44848         (WebCore::Pasteboard::plainText):
       
 44849         (WebCore::Pasteboard::documentFragment):
       
 44850         (WebCore::Pasteboard::writeURL):
       
 44851         (WebCore::Pasteboard::writeImage):
       
 44852         (WebCore::Pasteboard::clear):
       
 44853 
       
 44854 2007-03-15  Shrikant Gangoda  <shrikant.gangoda@celunite.com>
       
 44855 
       
 44856         Gdk build fix.
       
 44857 
       
 44858         * loader/gdk/FrameLoaderClientGdk.cpp:
       
 44859         (WebCore::FrameLoaderClientGdk::blockedError):
       
 44860         * loader/gdk/FrameLoaderClientGdk.h:
       
 44861 
       
 44862 2007-03-15  Beth Dakin  <bdakin@apple.com>
       
 44863 
       
 44864         Reviewed by Geoff.
       
 44865 
       
 44866         Fix for http://bugs.webkit.org/show_bug.cgi?id=13088 REGRESSION
       
 44867         (r19761-19779): Copy image no longer includes image address 
       
 44868         (rdar://5067927)
       
 44869 
       
 44870         writeURL() does not need an isImage parameter. Now that it accepts 
       
 44871         the types as a parameter, we can just declare the appropriate image 
       
 44872         types within writeImage and send them to writeURL(). Also, 
       
 44873         declaring the types twice is what broke this.
       
 44874 
       
 44875         * platform/Pasteboard.h:
       
 44876         * platform/mac/PasteboardMac.mm:
       
 44877         (WebCore::Pasteboard::writeURL):
       
 44878         (WebCore::Pasteboard::writeImage):
       
 44879 
       
 44880 2007-03-15  Adele Peterson  <adele@apple.com>
       
 44881 
       
 44882         Reviewed by Kevin Decker.
       
 44883 
       
 44884         Fix for <rdar://problem/4926179> Text in menulist control should never update if menu is open
       
 44885 
       
 44886         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement):
       
 44887           Only setTextFromOption if the menu isn't visible.
       
 44888 
       
 44889 2007-03-15  Brady Eidson  <beidson@apple.com>
       
 44890 
       
 44891         Reviewed by Oliver
       
 44892 
       
 44893         A few platform specific tweaks
       
 44894 
       
 44895         * platform/cf/RetainPtr.h:
       
 44896         (WebCore::RetainPtr::releaseRef): Fixed releaseRef to work with CF
       
 44897         
       
 44898         * platform/network/ResourceHandle.h: Added a "releaseRef" style call
       
 44899 
       
 44900 2007-03-15  Maciej Stachowiak  <mjs@apple.com>
       
 44901 
       
 44902         Reviewed by Geoff and Steve.
       
 44903 
       
 44904         * config.h: Remove unneeded hack.
       
 44905 
       
 44906 2007-03-15  Justin Garcia  <justin.garcia@apple.com>
       
 44907 
       
 44908         Reviewed by john
       
 44909         
       
 44910         <rdar://problem/5062376> 
       
 44911         REGRESSION: In Mail and Gmail, can't change alignment to text after it has been applied
       
 44912         
       
 44913         Bring back the remove step in applyBlockStyle.  It's 
       
 44914         necessary because addBlockStyleIfNeeded assumes that 
       
 44915         the properties it adds aren't already on the block that 
       
 44916         it adds them to.
       
 44917 
       
 44918         * editing/ApplyStyleCommand.cpp:
       
 44919         (WebCore::ApplyStyleCommand::applyBlockStyle): 
       
 44920         Bring back the remove step (added a testcase).
       
 44921         Don't do the add step if m_removeOnly is true (no testcase
       
 44922         because there aren't any clients using removeOnly functionality
       
 44923         to remove styles yet, only styled elemets).
       
 44924         Moved the code for creating new blocks up one level
       
 44925         to this function so that we can pass blocks to removeCSSStyle.
       
 44926         When converting VisiblePositions to indices and vice versa,
       
 44927         use the highest node in the shadow tree if we're in one as
       
 44928         the scope (working on a testcase).
       
 44929         (WebCore::ApplyStyleCommand::addBlockStyle): Moved code to
       
 44930         applyBlockStyle.
       
 44931         * editing/ApplyStyleCommand.h: 
       
 44932 
       
 44933 2007-03-15  Brady Eidson  <beidson@apple.com>
       
 44934 
       
 44935         Reviewed by Maciej
       
 44936 
       
 44937         <rdar://problem/4429701>
       
 44938         Implements a port blocking black list that matches Firefox's
       
 44939 
       
 44940         * loader/FrameLoader.cpp:
       
 44941         (WebCore::FrameLoader::blockedError): Call through to the client for blockedError 
       
 44942         * loader/FrameLoader.h:
       
 44943 
       
 44944         * loader/FrameLoaderClient.h: Get the "port blocked" error for the current platform
       
 44945 
       
 44946         * loader/ResourceLoader.cpp:
       
 44947         (WebCore::ResourceLoader::wasBlocked): ResourceHandleClient method to pass on the didFail(error)
       
 44948         (WebCore::ResourceLoader::blockedError): Following the pattern of "CancelledError()", get the 
       
 44949           error to fail with for the didFail() call
       
 44950         * loader/ResourceLoader.h:
       
 44951 
       
 44952         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 44953         (WebCore::SVGEmptyFrameLoaderClient::blockedError): Added stub
       
 44954 
       
 44955         * platform/network/ResourceHandle.cpp:
       
 44956         (WebCore::ResourceHandle::create): If the port is blocked, create the handle but schedule it for
       
 44957           deferred failure on a timer
       
 44958         (WebCore::ResourceHandle::scheduleBlockedFailure): Do the timer scheduling
       
 44959         (WebCore::ResourceHandle::fireBlockedFailure): Fire the timer here
       
 44960         (WebCore::ResourceHandle::portAllowed): Implements checking of Mozilla's
       
 44961         * platform/network/ResourceHandle.h:
       
 44962         * platform/network/ResourceHandleClient.h:
       
 44963         (WebCore::ResourceHandleClient::wasBlocked): Virtual for clients to get the "blocked" message
       
 44964 
       
 44965 2007-03-15  Beth Dakin  <bdakin@apple.com>
       
 44966 
       
 44967         Reviewed by Hyatt.
       
 44968 
       
 44969         Fix for <rdar://problem/5065396> REGRESSION: leaks in 
       
 44970         RenderBlock::layoutInlineChildren seen on buildbot
       
 44971 
       
 44972         This leak appeared after http://trac.webkit.org/projects/webkit/
       
 44973         changeset/20188. This change shifted line boxes around in 
       
 44974         removeChild(). But since removeChild() calls 
       
 44975         setNeedsLayoutAndMinMaxRecalc(), all of the line boxes will be 
       
 44976         removed once we actually lay out anyway. So this patch fixes the 
       
 44977         leak by deleting the line boxes instead of shifting them around. 
       
 44978 
       
 44979         * editing/IndentOutdentCommand.cpp:
       
 44980         (WebCore::IndentOutdentCommand::outdentParagraph): Call into 
       
 44981         updateLayout(). This fixes an assertion I got in editing/
       
 44982         execCommand/4976800.html This is very similar to the line box fix I 
       
 44983         made recently (http://trac.webkit.org/projects/webkit/changeset/
       
 44984         20177). We need to update layout before relying on VisiblePositions 
       
 44985         after removing a node.
       
 44986         * rendering/RenderBlock.cpp:
       
 44987         (WebCore::RenderBlock::deleteLinesForBlock): New helper function 
       
 44988         since this functionality is needed in three places now.
       
 44989         (WebCore::RenderBlock::makeChildrenNonInline): Call into new 
       
 44990         deleteLinesForBlock().
       
 44991         (WebCore::RenderBlock::removeChild): Same.
       
 44992         * rendering/RenderBlock.h:
       
 44993 
       
 44994 2007-03-15  Timothy Hatcher  <timothy@apple.com>
       
 44995 
       
 44996         Reviewed by John.
       
 44997 
       
 44998         * Factored out most of our common build settings into .xcconfig files. Anything that was common in
       
 44999           each build configuration was factored out into the shared .xcconfig file.
       
 45000         * Adds a Version.xcconfig file to define the current framework version, to be used in other places.
       
 45001         * Use the new $(BUNDLE_VERSION) (defined in Version.xcconfig) in the preprocessed Info.plist.
       
 45002         * Use the versions defined in Version.xcconfig to set $(DYLIB_CURRENT_VERSION).
       
 45003 
       
 45004         * Configurations/Base.xcconfig: Added.
       
 45005         * Configurations/DebugRelease.xcconfig: Added.
       
 45006         * Configurations/Version.xcconfig: Added.
       
 45007         * Configurations/WebCore.xcconfig: Added.
       
 45008         * Info.plist:
       
 45009         * WebCore.xcodeproj/project.pbxproj:
       
 45010 
       
 45011 2007-03-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 45012 
       
 45013         Not reviewed - gdk build fixes.
       
 45014 
       
 45015         * platform/gdk/EditorClientGdk.cpp:
       
 45016         (WebCore::EditorClientGdk::handleKeypress):
       
 45017         * platform/graphics/cairo/ImageSourceCairo.cpp:
       
 45018         (WebCore::ImageSource::setData):
       
 45019         * platform/graphics/gdk/ImageGdk.cpp:
       
 45020         (WebCore::Image::loadPlatformResource):
       
 45021 
       
 45022 2007-03-14  Justin Garcia  <justin.garcia@apple.com>
       
 45023 
       
 45024         Reviewed by john
       
 45025         
       
 45026         ~2x speed up of 5k rich text paste:
       
 45027         http://shakespeare.mit.edu/hamlet/full.html        
       
 45028 
       
 45029         * editing/ReplaceSelectionCommand.cpp:
       
 45030         (WebCore::ReplaceSelectionCommand::doApply): Remove the top 
       
 45031         level style span if it's unnecessary before inserting
       
 45032         into the document, it's faster than doing it after.
       
 45033         * editing/ReplaceSelectionCommand.h: Exposed 
       
 45034         ReplacementFragment::removeNodePreservingChildren so that
       
 45035         the style span can be removed using non-undoable removes,
       
 45036         like the rest of the removes done on the ReplacementFragment.
       
 45037         * editing/markup.cpp:
       
 45038         (WebCore::createMarkup): Make the style span the top level
       
 45039         element, otherwise it's useless.  This also facilitates the
       
 45040         optimization mentioned above.
       
 45041         When including markup for a fully selected root, include markup
       
 45042         for all the nodes beneath that fully selected root, to preserve 
       
 45043         the structure and appearance of the copied markup.  Did this
       
 45044         by merging with the code for adding markup for descendants of
       
 45045         special commonAncestorBlocks.
       
 45046 
       
 45047 2007-03-15  Beth Dakin  <bdakin@apple.com>
       
 45048 
       
 45049         Rubber-stamped by Adele.
       
 45050 
       
 45051         Rolling out http://trac.webkit.org/projects/webkit/changeset/20148 
       
 45052         (which is a fix for http://bugs.webkit.org/show_bug.cgi?id=12595 
       
 45053         and rdar://4722863) because it causes a horrible memory-trasher. 
       
 45054 
       
 45055         * bindings/js/JSHTMLFormElementCustom.cpp:
       
 45056         (WebCore::JSHTMLFormElement::canGetItemsForName):
       
 45057         (WebCore::JSHTMLFormElement::nameGetter):
       
 45058         * bindings/js/kjs_dom.cpp:
       
 45059         (KJS::):
       
 45060         (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection):
       
 45061         (KJS::DOMNamedNodesCollection::lengthGetter):
       
 45062         (KJS::DOMNamedNodesCollection::indexGetter):
       
 45063         (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
       
 45064         * bindings/js/kjs_dom.h:
       
 45065         (KJS::DOMNamedNodesCollection::classInfo):
       
 45066         * bindings/js/kjs_html.cpp:
       
 45067         (KJS::JSHTMLCollection::getNamedItems):
       
 45068         * dom/ChildNodeList.cpp:
       
 45069         (WebCore::ChildNodeList::ChildNodeList):
       
 45070         (WebCore::ChildNodeList::length):
       
 45071         (WebCore::ChildNodeList::item):
       
 45072         (WebCore::ChildNodeList::nodeMatches):
       
 45073         * dom/ChildNodeList.h:
       
 45074         * dom/NameNodeList.cpp:
       
 45075         (WebCore::NameNodeList::NameNodeList):
       
 45076         (WebCore::NameNodeList::item):
       
 45077         (WebCore::NameNodeList::nodeMatches):
       
 45078         * dom/NameNodeList.h:
       
 45079         (WebCore::NameNodeList::rootNodeAttributeChanged):
       
 45080         * dom/Node.cpp:
       
 45081         (WebCore::TagNodeList::TagNodeList):
       
 45082         (WebCore::TagNodeList::nodeMatches):
       
 45083         (WebCore::Node::registerNodeList):
       
 45084         (WebCore::Node::unregisterNodeList):
       
 45085         * dom/Node.h:
       
 45086         * dom/NodeList.cpp:
       
 45087         (WebCore::NodeList::NodeList):
       
 45088         (WebCore::NodeList::~NodeList):
       
 45089         (WebCore::NodeList::recursiveLength):
       
 45090         (WebCore::NodeList::itemForwardsFromCurrent):
       
 45091         (WebCore::NodeList::itemBackwardsFromCurrent):
       
 45092         (WebCore::NodeList::recursiveItem):
       
 45093         (WebCore::NodeList::itemWithName):
       
 45094         (WebCore::NodeList::rootNodeChildrenChanged):
       
 45095         * dom/NodeList.h:
       
 45096         (WebCore::NodeList::rootNodeAttributeChanged):
       
 45097         * html/HTMLFormElement.cpp:
       
 45098         (WebCore::HTMLFormElement::HTMLFormElement):
       
 45099         (WebCore::HTMLFormElement::~HTMLFormElement):
       
 45100         (WebCore::HTMLFormElement::formData):
       
 45101         (WebCore::HTMLFormElement::parseMappedAttribute):
       
 45102         (WebCore::HTMLFormElement::removeFormElement):
       
 45103         * html/HTMLFormElement.h:
       
 45104         * html/HTMLGenericFormElement.cpp:
       
 45105         (WebCore::HTMLGenericFormElement::parseMappedAttribute):
       
 45106         (WebCore::HTMLGenericFormElement::insertedIntoTree):
       
 45107         * html/HTMLGenericFormElement.h:
       
 45108         * html/HTMLInputElement.cpp:
       
 45109         (WebCore::HTMLInputElement::parseMappedAttribute):
       
 45110 
       
 45111 2007-03-15  Geoffrey Garen  <ggaren@apple.com>
       
 45112 
       
 45113         Added an assert to help catch a bug. Hopefully someone will hit it!
       
 45114         
       
 45115         * bindings/js/kjs_proxy.cpp:
       
 45116         (WebCore::KJSProxy::~KJSProxy):
       
 45117 
       
 45118 2007-03-14  Oliver Hunt  <oliver@apple.com>
       
 45119 
       
 45120         Reviewed by Adele.
       
 45121 
       
 45122         Fix for rdar://problem/5061737.
       
 45123         
       
 45124         This was a regression from the original Objective-C -> C++ conversion
       
 45125         for the drag logic.  We don't need to call Range::startNode as we just
       
 45126         need the document that contains the range.   
       
 45127 
       
 45128         * page/DragController.cpp:
       
 45129         (WebCore::documentFragmentFromDragData):
       
 45130 
       
 45131 2007-03-14  Mitz Pettel  <mitz@webkit.org>
       
 45132 
       
 45133         Reviewed by Hyatt.
       
 45134 
       
 45135         - http://bugs.webkit.org/show_bug.cgi?id=13071
       
 45136           REGRESSION: Plain text files no longer wrap lines longer than the width of the browser window
       
 45137 
       
 45138         Test: fast/loader/text-document-wrapping.html
       
 45139 
       
 45140         * loader/TextDocument.cpp:
       
 45141         (WebCore::TextTokenizer::write): Specified word-wrap:break-word for the <pre> element.
       
 45142 
       
 45143 2007-03-14  Mitz Pettel  <mitz@webkit.org>
       
 45144 
       
 45145         Reviewed by Hyatt.
       
 45146 
       
 45147         - fix http://bugs.webkit.org/show_bug.cgi?id=13072
       
 45148           REGRESSION (r15617): white-space: pre-wrap breaks off the last character of a wide word
       
 45149 
       
 45150         Test: fast/text/whitespace/pre-wrap-last-char.html
       
 45151 
       
 45152         * rendering/bidi.cpp:
       
 45153         (WebCore::RenderBlock::findNextLineBreak): Undid the change from r15617.
       
 45154 
       
 45155 2007-03-14  David Hyatt  <hyatt@apple.com>
       
 45156 
       
 45157         Add asserts to help catch double refs and double derefs of CachedResources.
       
 45158 
       
 45159         Reviewed by mjs
       
 45160 
       
 45161         * loader/CachedResource.cpp:
       
 45162         (WebCore::CachedResource::ref):
       
 45163         (WebCore::CachedResource::deref):
       
 45164 
       
 45165 2007-03-14  Alice Liu  <alice.liu@apple.com>
       
 45166 
       
 45167         Rubber-stamped by Hyatt.
       
 45168 
       
 45169         Adding null check to prevent the crash that happens on 2nd run of iBench HTML load test
       
 45170 
       
 45171         * loader/icon/IconDataCache.cpp:
       
 45172         (WebCore::IconDataCache::writeToDatabase):
       
 45173 
       
 45174 === Safari-5522.4 ===
       
 45175 
       
 45176 2007-03-14  Adele Peterson  <adele@apple.com>
       
 45177 
       
 45178         Reviewed by Adam.
       
 45179 
       
 45180         Fix for <rdar://problem/5062898> REGRESSION: autocomplete window in text fields doesn't come up
       
 45181 
       
 45182         When we moved the initialization of a bunch of variables in the HTMLFormElement constructor, m_autocomplete accidently got initialized to false.
       
 45183 
       
 45184         * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement):
       
 45185 
       
 45186 2007-03-14  Steve Falkenburg  <sfalken@apple.com>
       
 45187 
       
 45188         Reviewed by Adam.
       
 45189 
       
 45190         Added missing null check in case this is called on a subframe
       
 45191         that hasn't started loading.
       
 45192 
       
 45193         * page/Frame.cpp:
       
 45194         (WebCore::Frame::setMarkedTextMatchesAreHighlighted): Check for a null document.
       
 45195 
       
 45196 2007-03-14  Antti Koivisto  <antti@apple.com>
       
 45197 
       
 45198         Reviewed by Geoff.
       
 45199 
       
 45200         Fix http://bugs.webkit.org/show_bug.cgi?id=13060
       
 45201         REGRESSION: Repro ASSERT failure in Cache::adjustSize running layout tests
       
 45202         <rdar://5060208>
       
 45203         
       
 45204         Script evaluation may have dereffed the CachedScript object already, causing double deref and
       
 45205         eventually m_liveResourcesSize underflow.
       
 45206 
       
 45207         * html/HTMLScriptElement.cpp:
       
 45208         (WebCore::HTMLScriptElement::notifyFinished):
       
 45209 
       
 45210 2007-03-14  Adele Peterson  <adele@apple.com>
       
 45211 
       
 45212         Reviewed by Darin.
       
 45213 
       
 45214         Added InsertTab, InsertBacktab, InsertLineBreak, and InsertNewline to the editing command table.
       
 45215         Added Event parameter to execCommand, and to all of the enabled and exec functions.  Right now,
       
 45216         the event is only used by the newly added commands.  But in the future, many (and possibly all) of
       
 45217         these editing commands will need to consider the event so they are applied to the correct selection.
       
 45218 
       
 45219         * WebCore.exp:
       
 45220         * editing/Editor.cpp:
       
 45221         (WebCore::execCopy):
       
 45222         (WebCore::execCut):
       
 45223         (WebCore::execDelete):
       
 45224         (WebCore::execBackwardDelete):
       
 45225         (WebCore::execForwardDelete):
       
 45226         (WebCore::execMoveBackward):
       
 45227         (WebCore::execMoveBackwardAndModifySelection):
       
 45228         (WebCore::execMoveUpByPageAndModifyCaret):
       
 45229         (WebCore::execMoveDown):
       
 45230         (WebCore::execMoveDownAndModifySelection):
       
 45231         (WebCore::execMoveForward):
       
 45232         (WebCore::execMoveForwardAndModifySelection):
       
 45233         (WebCore::execMoveDownByPageAndModifyCaret):
       
 45234         (WebCore::execMoveLeft):
       
 45235         (WebCore::execMoveLeftAndModifySelection):
       
 45236         (WebCore::execMoveRight):
       
 45237         (WebCore::execMoveRightAndModifySelection):
       
 45238         (WebCore::execMoveToBeginningOfDocument):
       
 45239         (WebCore::execMoveToBeginningOfDocumentAndModifySelection):
       
 45240         (WebCore::execMoveToBeginningOfSentence):
       
 45241         (WebCore::execMoveToBeginningOfSentenceAndModifySelection):
       
 45242         (WebCore::execMoveToBeginningOfLine):
       
 45243         (WebCore::execMoveToBeginningOfLineAndModifySelection):
       
 45244         (WebCore::execMoveToBeginningOfParagraph):
       
 45245         (WebCore::execMoveToBeginningOfParagraphAndModifySelection):
       
 45246         (WebCore::execMoveToEndOfDocument):
       
 45247         (WebCore::execMoveToEndOfDocumentAndModifySelection):
       
 45248         (WebCore::execMoveToEndOfSentence):
       
 45249         (WebCore::execMoveToEndOfSentenceAndModifySelection):
       
 45250         (WebCore::execMoveToEndOfLine):
       
 45251         (WebCore::execMoveToEndOfLineAndModifySelection):
       
 45252         (WebCore::execMoveToEndOfParagraph):
       
 45253         (WebCore::execMoveToEndOfParagraphAndModifySelection):
       
 45254         (WebCore::execMoveParagraphBackwardAndModifySelection):
       
 45255         (WebCore::execMoveParagraphForwardAndModifySelection):
       
 45256         (WebCore::execMoveUp):
       
 45257         (WebCore::execMoveUpAndModifySelection):
       
 45258         (WebCore::execMoveWordBackward):
       
 45259         (WebCore::execMoveWordBackwardAndModifySelection):
       
 45260         (WebCore::execMoveWordForward):
       
 45261         (WebCore::execMoveWordForwardAndModifySelection):
       
 45262         (WebCore::execMoveWordLeft):
       
 45263         (WebCore::execMoveWordLeftAndModifySelection):
       
 45264         (WebCore::execMoveWordRight):
       
 45265         (WebCore::execMoveWordRightAndModifySelection):
       
 45266         (WebCore::execPaste):
       
 45267         (WebCore::execSelectAll):
       
 45268         (WebCore::execToggleBold):
       
 45269         (WebCore::execToggleItalic):
       
 45270         (WebCore::execRedo):
       
 45271         (WebCore::execUndo):
       
 45272         (WebCore::execInsertTab):
       
 45273         (WebCore::execInsertBacktab):
       
 45274         (WebCore::execInsertNewline):
       
 45275         (WebCore::execInsertLineBreak):
       
 45276         (WebCore::enabled):
       
 45277         (WebCore::canPaste):
       
 45278         (WebCore::hasEditableSelection):
       
 45279         (WebCore::hasEditableRangeSelection):
       
 45280         (WebCore::hasRangeSelection):
       
 45281         (WebCore::hasRichlyEditableSelection):
       
 45282         (WebCore::canRedo):
       
 45283         (WebCore::canUndo):
       
 45284         (WebCore::CommandEntry::):
       
 45285         (WebCore::Editor::toggleBold):
       
 45286 
       
 45287         (WebCore::Editor::execCommand): Added optional event parameter.
       
 45288         (WebCore::Editor::insertText): Added.  Calls handleTextInputEvent.
       
 45289         (WebCore::Editor::insertTextWithoutSendingTextEvent): Renamed from insertText.
       
 45290          Performs the actual insertion without dispatching any event.
       
 45291         * editing/Editor.h:
       
 45292         * page/EventHandler.cpp: (WebCore::EventHandler::defaultTextInputEventHandler):
       
 45293           Call insertTextWithoutSendingTextEvent.
       
 45294 
       
 45295 2007-03-14  Justin Garcia  <justin.garcia@apple.com>
       
 45296 
       
 45297         Reviewed by darin
       
 45298         
       
 45299         ~3x speedup pasting 5k lines of rich text:
       
 45300         http://shakespeare.mit.edu/hamlet/full.html
       
 45301         ~2x speedup pasting 10k lines of plain text
       
 45302         
       
 45303         * css/CSSComputedStyleDeclaration.cpp:
       
 45304         (WebCore::computedStyle): Added for convenience.
       
 45305         * css/CSSComputedStyleDeclaration.h:
       
 45306         * editing/ReplaceSelectionCommand.cpp:
       
 45307         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
       
 45308         The code that pushed down the top level style span had
       
 45309         a bug in it that made it do unnecessary work.  Instead of
       
 45310         fixing the bug I removed the code because it was used to 
       
 45311         help see more redundancies in second level style spans, but 
       
 45312         createMarkup now *only* creates a top level style span.
       
 45313         Only remove redundant styles from style spans and only remove
       
 45314         unstyled elements if they are style spans.  FF doesn't
       
 45315         remove redundant styles from elements, or remove redundant 
       
 45316         font tags on copy/paste.  We could offer this functionality 
       
 45317         through a separate "cleanup" command.
       
 45318         * editing/markup.cpp:
       
 45319         (WebCore::createMarkup): Only add markup for ancestors of 
       
 45320         lastClosed if we're including markup for acommonAncestorBlock 
       
 45321         (we do this for commonAncestorBlocks like tables and lists),
       
 45322         otherwise it's unnecessary/redundant.
       
 45323 
       
 45324 2007-03-14  Anders Carlsson  <acarlsson@apple.com>
       
 45325 
       
 45326         Reviewed by Ada.
       
 45327 
       
 45328         Make sure to call ResourceLoader::didReceiveData to ensure that there's a shared buffer with the resource
       
 45329         data, since SubresourceLoaderClients now make use of that buffer.
       
 45330         
       
 45331         * loader/SubresourceLoader.cpp:
       
 45332         (WebCore::SubresourceLoader::didReceiveData):
       
 45333 
       
 45334 2007-03-14  Administrator  <acarlsson@apple.com>
       
 45335 
       
 45336         Get the size from the shared buffer.
       
 45337         
       
 45338         * platform/graphics/cg/ImageSourceCG.cpp:
       
 45339         (WebCore::ImageSource::setData):
       
 45340         * platform/graphics/cg/PDFDocumentImage.cpp:
       
 45341         (WebCore::PDFDocumentImage::dataChanged):
       
 45342 
       
 45343 2007-03-14  Mitz Pettel  <mitz@webkit.org>
       
 45344 
       
 45345         Reviewed by Hyatt, thumbs up by Darin.
       
 45346 
       
 45347         - fix http://bugs.webkit.org/show_bug.cgi?id=12782
       
 45348           Reproducible crash in BidiContext::deref
       
 45349 
       
 45350         Test: fast/dynamic/anonymous-block-orphaned-lines.html
       
 45351 
       
 45352         * rendering/InlineBox.cpp:
       
 45353         (WebCore::InlineBox::root): Added an assertion that we return a root inline box.
       
 45354         * rendering/RenderBlock.cpp:
       
 45355         (WebCore::RenderBlock::removeChild): Added code to adopt the line boxes of
       
 45356         anonymous blocks being destroyed instead of leaving them orphaned, which
       
 45357         is what caused this crash. The boxes will be deleted on the next layout, but
       
 45358         this ensures consistency in the mean time.
       
 45359 
       
 45360 2007-03-14  Lars Knoll <lars@trolltech.com>
       
 45361 
       
 45362         Reviewed by Antti.
       
 45363 
       
 45364         Fix the Qt build.
       
 45365         Add a getter to SharedBuffer that returns a reference to the internal
       
 45366         Vector to avoid an extra copy of the data.
       
 45367 
       
 45368         * platform/SharedBuffer.h:
       
 45369         (WebCore::SharedBuffer::buffer):
       
 45370         * platform/graphics/qt/ImageQt.cpp:
       
 45371         (WebCore::Image::loadPlatformResource):
       
 45372         * platform/graphics/qt/ImageSourceQt.cpp:
       
 45373         (WebCore::detectImageFormat):
       
 45374         (WebCore::createDecoder):
       
 45375         (WebCore::ImageSource::setData):
       
 45376 
       
 45377 2007-03-14  Antti Koivisto  <antti@apple.com>
       
 45378 
       
 45379         Reviewed by Mitz.
       
 45380         
       
 45381         Fix <rdar://problem/5058774>
       
 45382         REGRESSION: In Mail, caret appears oversized when typing in a To Do note
       
 45383         
       
 45384         Horizontal and vertical were switched. Was regression from
       
 45385         http://trac.webkit.org/projects/webkit/changeset/20103
       
 45386 
       
 45387         * rendering/RootInlineBox.cpp:
       
 45388         (WebCore::RootInlineBox::addHighlightOverflow):
       
 45389 
       
 45390 2007-03-14  David Hyatt  <hyatt@apple.com>
       
 45391 
       
 45392         Tweak the data() functions of stylesheets and scripts to be internally consistent.
       
 45393 
       
 45394         * loader/CachedCSSStyleSheet.cpp:
       
 45395         (WebCore::CachedCSSStyleSheet::data):
       
 45396         * loader/CachedScript.cpp:
       
 45397         (WebCore::CachedScript::data):
       
 45398         * loader/CachedXSLStyleSheet.cpp:
       
 45399         (WebCore::CachedXSLStyleSheet::data):
       
 45400 
       
 45401 2007-03-14  David Hyatt  <hyatt@apple.com>
       
 45402 
       
 45403         Fix Radar 5050688.  
       
 45404 
       
 45405         For large animated GIFs, destroy and recreate the source for every animation frame.  This keeps
       
 45406         the memory consumption down while giant images are animating.
       
 45407 
       
 45408         Reviewed by andersca
       
 45409 
       
 45410         * platform/graphics/BitmapImage.cpp:
       
 45411         (WebCore::BitmapImage::BitmapImage):
       
 45412         (WebCore::BitmapImage::destroyDecodedData):
       
 45413         (WebCore::BitmapImage::dataChanged):
       
 45414         (WebCore::BitmapImage::advanceAnimation):
       
 45415         * platform/graphics/BitmapImage.h:
       
 45416 
       
 45417 2007-03-14  David Hyatt  <hyatt@apple.com>
       
 45418 
       
 45419         Make sure to use CFDataCreateWithBytesNoCopy where we can.
       
 45420 
       
 45421         Reviewed by andersca
       
 45422 
       
 45423         * platform/graphics/cg/ImageSourceCG.cpp:
       
 45424         (WebCore::ImageSource::setData):
       
 45425         * platform/graphics/cg/PDFDocumentImage.cpp:
       
 45426         (WebCore::PDFDocumentImage::dataChanged):
       
 45427 
       
 45428 2007-03-13  David Hyatt  <hyatt@apple.com>
       
 45429 
       
 45430         Fix for bugzilla bug 13050 and also radar p1 5050645.
       
 45431 
       
 45432         This patch reworks resource loading to avoid having redundant buffers in the icon database and in cached
       
 45433         images in the WebCore cache.  It also avoids overcopying in top-level image documents and in the icon
       
 45434         database.
       
 45435 
       
 45436         There is now only one SharedBuffer for a resource and everybody observes that buffer now instead of ever
       
 45437         making their own.  Even ImageIO uses the SharedBuffer while decoding.
       
 45438 
       
 45439         The page in 13050 dropped from 145mb down to 45mb of memory use with this change for a stunning savings
       
 45440         of 100mb.
       
 45441 
       
 45442         Reviewed by olliej, mjs
       
 45443 
       
 45444         * WebCore.exp:
       
 45445         * loader/CachedCSSStyleSheet.cpp:
       
 45446         (WebCore::CachedCSSStyleSheet::data):
       
 45447         * loader/CachedCSSStyleSheet.h:
       
 45448         * loader/CachedImage.cpp:
       
 45449         (WebCore::CachedImage::data):
       
 45450         * loader/CachedImage.h:
       
 45451         * loader/CachedResource.cpp:
       
 45452         (WebCore::CachedResource::CachedResource):
       
 45453         (WebCore::CachedResource::~CachedResource):
       
 45454         * loader/CachedResource.h:
       
 45455         (WebCore::CachedResource::data):
       
 45456         * loader/CachedScript.cpp:
       
 45457         (WebCore::CachedScript::data):
       
 45458         * loader/CachedScript.h:
       
 45459         * loader/CachedXSLStyleSheet.cpp:
       
 45460         (WebCore::CachedXSLStyleSheet::data):
       
 45461         * loader/CachedXSLStyleSheet.h:
       
 45462         * loader/DocLoader.cpp:
       
 45463         (WebCore::DocLoader::checkCacheObjectStatus):
       
 45464         * loader/ImageDocument.cpp:
       
 45465         (WebCore::ImageTokenizer::writeRawData):
       
 45466         (WebCore::ImageTokenizer::finish):
       
 45467         * loader/icon/IconDataCache.cpp:
       
 45468         (WebCore::IconDataCache::setImageData):
       
 45469         (WebCore::IconDataCache::writeToDatabase):
       
 45470         * loader/icon/IconDataCache.h:
       
 45471         * loader/icon/IconDatabase.cpp:
       
 45472         (WebCore::IconDatabase::imageDataForIconURL):
       
 45473         (WebCore::IconDatabase::iconForPageURL):
       
 45474         (WebCore::IconDatabase::setIconDataForIconURL):
       
 45475         (WebCore::IconDatabase::setHaveNoIconForIconURL):
       
 45476         (WebCore::IconDatabase::imageDataForIconURLQuery):
       
 45477         * loader/icon/IconDatabase.h:
       
 45478         * loader/icon/IconLoader.cpp:
       
 45479         (WebCore::IconLoader::startLoading):
       
 45480         (WebCore::IconLoader::didReceiveResponse):
       
 45481         (WebCore::IconLoader::didReceiveData):
       
 45482         (WebCore::IconLoader::didFail):
       
 45483         (WebCore::IconLoader::finishLoading):
       
 45484         (WebCore::IconLoader::clearLoadingState):
       
 45485         * loader/icon/IconLoader.h:
       
 45486         * loader/icon/SQLStatement.cpp:
       
 45487         (WebCore::SQLStatement::getColumnBlobAsVector):
       
 45488         (WebCore::SQLStatement::isExpired):
       
 45489         * loader/icon/SQLStatement.h:
       
 45490         * loader/loader.cpp:
       
 45491         (WebCore::Loader::didFinishLoading):
       
 45492         (WebCore::Loader::didReceiveData):
       
 45493         * page/mac/WebCoreFrameBridge.mm:
       
 45494         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
       
 45495         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
       
 45496         * platform/SharedBuffer.h:
       
 45497         (WebCore::SharedBuffer::isEmpty):
       
 45498         * platform/graphics/BitmapImage.cpp:
       
 45499         (WebCore::BitmapImage::destroyDecodedData):
       
 45500         (WebCore::BitmapImage::dataChanged):
       
 45501         * platform/graphics/BitmapImage.h:
       
 45502         * platform/graphics/Image.cpp:
       
 45503         (WebCore::Image::setData):
       
 45504         * platform/graphics/Image.h:
       
 45505         (WebCore::Image::dataChanged):
       
 45506         (WebCore::Image::data):
       
 45507         * platform/graphics/ImageSource.h:
       
 45508         * platform/graphics/cg/ImageSourceCG.cpp:
       
 45509         (WebCore::ImageSource::setData):
       
 45510         * platform/graphics/cg/PDFDocumentImage.cpp:
       
 45511         (WebCore::PDFDocumentImage::dataChanged):
       
 45512         * platform/graphics/cg/PDFDocumentImage.h:
       
 45513         * platform/graphics/mac/ImageMac.mm:
       
 45514         (WebCore::Image::loadPlatformResource):
       
 45515         * platform/graphics/svg/SVGImage.cpp:
       
 45516         (WebCore::SVGImage::setData):
       
 45517         * platform/mac/PasteboardMac.mm:
       
 45518         (WebCore::fileWrapperForImage):
       
 45519 
       
 45520 2007-03-13  Justin Garcia  <justin.garcia@apple.com>
       
 45521 
       
 45522         Reviewed by darin
       
 45523         
       
 45524         <rdar://problem/5046875> 
       
 45525         Gmail Editor: Applying alignment to selected text in message also applies alignment to signature
       
 45526 
       
 45527         * editing/ApplyStyleCommand.cpp:
       
 45528         (WebCore::ApplyStyleCommand::doApply): Don't call applyBlockStyle unless
       
 45529         there is a block style to apply.
       
 45530         (WebCore::ApplyStyleCommand::applyBlockStyle): Don't do the remove step.
       
 45531         It was unnecessary and removed properties from blocks that could contain 
       
 45532         content outside the range being operated on (added a testcase).
       
 45533         (WebCore::ApplyStyleCommand::addBlockStyleIfNeeded): Used an early return
       
 45534         instead of if-nesting.
       
 45535         * editing/ApplyStyleCommand.h:
       
 45536         * editing/CompositeEditCommand.cpp:
       
 45537         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
       
 45538         Return the new block, if one was created.  Use moveParagraphs to move
       
 45539         paragraphs into the new block, instead of moving nodes.  The old code moved
       
 45540         too much (added a testcase).
       
 45541         * editing/CompositeEditCommand.h:
       
 45542 
       
 45543 2007-03-13  Oliver Hunt  <oliver@apple.com>
       
 45544 
       
 45545         Reviewed by Brady.
       
 45546 
       
 45547         To fix <rdar://problem/5044366> we now pass a NSString
       
 45548         representation of the URL extracted with _web_originalDataAsString
       
 45549         instead of relying on [NSURL absoluteString] in the bridge
       
 45550 
       
 45551         * page/mac/WebCoreFrameBridge.h:
       
 45552         * page/mac/WebCoreFrameBridge.mm:
       
 45553         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
       
 45554 
       
 45555 2007-03-13  Brady Eidson  <beidson@apple.com>
       
 45556 
       
 45557         Reviewed by Anders
       
 45558 
       
 45559         <rdar://problem/5048818> - REGRESSION: Incompletely loaded resources being saved to the object cache
       
 45560 
       
 45561         Due to a subtle change in loader behavior back in 10904, we would stop all loaders before calling 
       
 45562         didFail() on them in the Cache loader.  As a result, we basically cleared all of the Subresource Loaders 
       
 45563         out of the Cache loader before more properly failing them as errored out.  The result?  Partially loaded
       
 45564         resources being cached.
       
 45565         
       
 45566         Since Loader::didFail() both calls error() on the object *and* removes the loader, the solution is to call 
       
 45567         didFail() for all cancelled loaders instead of *only* removing them from the set of active loaders.
       
 45568         
       
 45569         In addition, pages that didn't completely load were being saved to the back/forward cache.  To fix that,
       
 45570         I added a null check on the DocumentLoader's error to see if the page ended in an error, or did indeed 
       
 45571         completely load.
       
 45572 
       
 45573         Note that the layout test for this - if possible - will require other enhancements including possibly adding
       
 45574         support for window.stop().  That task is documented in <rdar://problem/5061826>
       
 45575 
       
 45576         * loader/FrameLoader.cpp:
       
 45577         (WebCore::FrameLoader::provisionalLoadStarted): Fixed a few bugs relating to my original BFCache rewrite to
       
 45578           more perfectly restore the original behavior - including only caching HTML documents via the 
       
 45579           m_client->canCachePage() call
       
 45580         (WebCore::FrameLoader::canCachePage): Don't make the call to m_client->canCachePage() as that serves a different
       
 45581           purpose
       
 45582           - Check the mainDocumentError to see if the load ended in error as a further criteria in determining the 
       
 45583           cachability of a page
       
 45584 
       
 45585         * loader/loader.cpp:
       
 45586         (WebCore::Loader::cancelRequests): Call didFail(cancelledError()) instead of just removing the loaders from the 
       
 45587           loaders-in-progress set.  This adds the effect of properly cleaning up the cached object.
       
 45588 
       
 45589 2007-03-13  Beth Dakin  <bdakin@apple.com>
       
 45590 
       
 45591         Rendering part reviewed by Hyatt. Editing part consulted with and 
       
 45592         rubber stamped by Justin and Harrison.
       
 45593 
       
 45594         Fix for <rdar://problem/5025925> A hang occurs in Safari when 
       
 45595         attempting to print page at http://www.pcadvisor.co.uk
       
 45596 
       
 45597         * rendering/RenderBlock.cpp:
       
 45598         (WebCore::RenderBlock::makeChildrenNonInline): 
       
 45599         RenderBlock::makeChildrenNonInline() takes a block's inline 
       
 45600         children and turns them into block children. If the children had 
       
 45601         line boxes, those boxes were being leaked. In the layout test I 
       
 45602         added with the change (and at pcadvisor.co.uk during printing) 
       
 45603         children were being made non-inline, and then they were being made 
       
 45604         inline again. This meant that some of the children ended up 
       
 45605         pointing to totally stale line boxes that are normally just leaked. 
       
 45606         This caused an infinite loop in RenderFlow::destroy(). This patch 
       
 45607         simply deletes everyone's line boxes in 
       
 45608         RenderBlock::makeChildrenNonInline()
       
 45609 
       
 45610         * editing/InsertParagraphSeparatorCommand.cpp:
       
 45611         (WebCore::InsertParagraphSeparatorCommand::doApply): The other part 
       
 45612         of this fix is that I added a call to updateLayout in 
       
 45613         InsertParagraphSeparatorCommand::doApply(). One layout test 
       
 45614         (editing/spelling/spelling.html) was changed by my patch to 
       
 45615         RenderBlock. doApply() inserts a node into the render tree. In at 
       
 45616         least one case in spelling.html, that caused some line boxes to be 
       
 45617         deleted. Back in doApply() this meant that the RenderTree was out-
       
 45618         of-date, and we mistakenly thought we were at the end of the 
       
 45619         paragraph. This caused us to insert a RenderBR() at the end of the 
       
 45620         tree instead of an empty RenderText(). No one seems to know exactly 
       
 45621         why we insert either, or if the change is necessarily a problem. It 
       
 45622         is clear, though, that the RenderTree in doApply() is out-of-date 
       
 45623         after inserting the node and deleting some line boxes, so it seems 
       
 45624         prudent to call into updateLayout().
       
 45625 
       
 45626 2007-03-13  Adam Roben  <aroben@apple.com>
       
 45627 
       
 45628         Reviewed by Anders.
       
 45629 
       
 45630         * platform/FontData.h: Added m_isSystemFont parameter to match NSFont.
       
 45631 
       
 45632 2007-03-13  Beth Dakin  <bdakin@apple.com>
       
 45633 
       
 45634         Reviewed by Maciej.
       
 45635 
       
 45636         Export DocumentLoader::setFrame(). Part of fix for <rdar://
       
 45637         problem/4277074> 8F32: Help Viewer crashed on clicking link - 
       
 45638         KHTMLView::viewportMouseReleaseEvent (12647)
       
 45639 
       
 45640         * WebCore.exp:
       
 45641 
       
 45642 2007-03-13  Darin Adler  <darin@apple.com>
       
 45643 
       
 45644         Reviewed by Maciej.
       
 45645 
       
 45646         - fix http://bugs.webkit.org/show_bug.cgi?id=12794
       
 45647           <rdar://problem/5028154> REGRESSION: TripTik planner at aaa.com never
       
 45648           finishes loading due to unclosed canvas tag (12794)
       
 45649 
       
 45650         Change <canvas> elements so that their contents are parsed normally,
       
 45651         but not rendered. This change fixes the bug, because normal parsing
       
 45652         rules close the <canvas> element in that case. The special parser
       
 45653         stuff was just getting in the way.
       
 45654 
       
 45655         Also do some basic cleanup to the HTML parser. This was motivated by
       
 45656         an earlier version of this patch that made even more changes to the
       
 45657         parser, but the cleanup is still worth landing.
       
 45658 
       
 45659         Test: fast/canvas/canvas-hides-fallback.html
       
 45660         Test: fast/canvas/script-inside-canvas-fallback.html
       
 45661         Test: fast/canvas/unclosed-canvas-1.html
       
 45662         Test: fast/canvas/unclosed-canvas-2.html
       
 45663         Test: fast/canvas/unclosed-canvas-3.html
       
 45664         Test: fast/canvas/unclosed-canvas-4.html
       
 45665 
       
 45666         * html/HTMLCanvasElement.h: Added a data member to keep track of whether the
       
 45667         renderer is a RenderHTMLCanvas or not.
       
 45668         * html/HTMLCanvasElement.cpp:
       
 45669         (WebCore::HTMLCanvasElement::createRenderer): If JavaScript is enabled, create
       
 45670         a RenderHTMLCanvas. If it's not, let the default code create the default type
       
 45671         of renderer, which will result in fallback content being visible. The
       
 45672         RenderHTMLCanvas class already hides all of its children. Set the m_rendererIsCanvas
       
 45673         boolean accordingly. Since the actual storage for the canvas is allocated lazily
       
 45674         when you actually get a drawing context, we don't need to do anything special
       
 45675         to prevent it when JavaScript is disabled; the relevant functions won't be called.
       
 45676         (WebCore::HTMLCanvasElement::reset): Protect the code that manipulates the
       
 45677         RenderHTMLCanvas with a check of m_rendererIsCanvas. This is the only code inside
       
 45678         the DOM element that relies on the renderer type.
       
 45679 
       
 45680         * html/HTMLParser.h: Removed unneeded includes. Marked HTMLParser as
       
 45681         Noncopyable. Changed the Document parameter to the constructor to instead
       
 45682         be HTMLDocument. Renamed discard_until to m_skipModeTag for clarity.
       
 45683         Removed unused noSpaces function and unneeded public doc() function.
       
 45684         Moved data members all down to the end so you can see them together in order.
       
 45685         Renamed map to m_currentMapElement and isindex to m_isindexElement.
       
 45686         Removed unused end and headLoaded data members.  Renamed m_fragment to
       
 45687         m_isParsingFragment to make it clearer that it's a boolean, not a fragment.
       
 45688 
       
 45689         * html/HTMLParser.cpp:
       
 45690         (WebCore::HTMLParser::HTMLParser): Changed to use member construction
       
 45691         syntax instead of calling reset(). This is especially helpful in the
       
 45692         fragment case, where calling reset() later on is illegal, so not using
       
 45693         it in the constructor lets us assert.
       
 45694         (WebCore::HTMLParser::~HTMLParser): Did an explicit deref instead of
       
 45695         calling setCurrent for its side effect.
       
 45696         (WebCore::HTMLParser::reset): Updated for member name changes and removal
       
 45697         and to use document instead of doc().
       
 45698         (WebCore::HTMLParser::setCurrent): Use document instead of doc().
       
 45699         (WebCore::HTMLParser::setSkipMode): Added. No longer inline. Now sets the
       
 45700         m_inCanvasBeforeFirstOpenTag data member to false.
       
 45701         (WebCore::HTMLParser::parseToken): Tightened up the skip mode logic at the
       
 45702         top of the function, and added a FIXME about the strange case there where
       
 45703         we don't skip yet stay in skip mode. Updated for renaming and doc().
       
 45704         (WebCore::HTMLParser::insertNode): Updated for renaming and doc().
       
 45705         (WebCore::HTMLParser::handleError): Ditto.
       
 45706         (WebCore::HTMLParser::framesetCreateErrorCheck): Ditto.
       
 45707         (WebCore::HTMLParser::isindexCreateErrorCheck): Changed to use RefPtr.
       
 45708         (WebCore::HTMLParser::noscriptCreateErrorCheck): Updated for renaming and doc().
       
 45709         (WebCore::HTMLParser::mapCreateErrorCheck): Ditto.
       
 45710         (WebCore::HTMLParser::getNode): Removed the special case for canvas here.
       
 45711         Canvas fallback is now handled in the DOM, not the parser. Updated for
       
 45712         renaming and doc().
       
 45713         (WebCore::HTMLParser::allowNestedRedundantTag): Changed a #define into a C++
       
 45714         constant.
       
 45715         (WebCore::HTMLParser::processCloseTag): Updated for renaming and doc().
       
 45716         (WebCore::HTMLParser::isInline): Ditto.
       
 45717         (WebCore::HTMLParser::tagIsOnStack): Added. Used by new canvas logic.
       
 45718         (WebCore::HTMLParser::popBlock): Updated for renaming and doc(). Also renamed
       
 45719         the local variable Elem to elem.
       
 45720         (WebCore::HTMLParser::createHead): Ditto.
       
 45721         (WebCore::HTMLParser::handleIsindex): Changed to use RefPtr.
       
 45722         (WebCore::HTMLParser::startBody): Updated for renaming and doc().
       
 45723         (WebCore::HTMLParser::finished): Ditto.
       
 45724 
       
 45725 2007-03-13  David Hyatt  <hyatt@apple.com>
       
 45726 
       
 45727         Two more cleanup fixes to the cache.  Don't call destroyDecodedData in the BitmapImage destructor, since
       
 45728         clearing the image source and calling setData on it again causes it to do an extra copy of the encoded
       
 45729         data.  Since we're about to be destroyed this is just wasteful.
       
 45730 
       
 45731         When the cache prunes, don't allow it to destroy the decoded data of an image that is still actively loading,
       
 45732         since we've established that ImageIO can actually crash if you yank the rug out from under it like that.
       
 45733 
       
 45734         Reviewed by ggaren
       
 45735 
       
 45736         * loader/Cache.cpp:
       
 45737         (WebCore::Cache::prune):
       
 45738         * platform/graphics/BitmapImage.cpp:
       
 45739         (WebCore::BitmapImage::~BitmapImage):
       
 45740 
       
 45741 2007-03-13  Anders Carlsson  <acarlsson@apple.com>
       
 45742 
       
 45743         Try fixing the Qt build.
       
 45744         
       
 45745         * editing/Editor.h:
       
 45746         (WebCore::Editor::setStartNewKillRingSequence):
       
 45747 
       
 45748 2007-03-13  David Harrison  <harrison@apple.com>
       
 45749 
       
 45750         Reviewed by Justin.
       
 45751 
       
 45752         <rdar://problem/5031181> cntl-k at end of paragraph adds nothing to the kill ring
       
 45753         <rdar://problem/5031189> REGRESSION: cntl-y yanks only the most recently killed content
       
 45754 
       
 45755         For rdar://5031181, properly extend the selection before the killring handling, and
       
 45756         make sure plainText of that selection returns a linefeed.
       
 45757         
       
 45758         For rdar://5031189, restore Editor::deleteRange() code that continued current killring,
       
 45759         even though the range deletion implicitly stopped it via changing the selection.
       
 45760         
       
 45761         A byproduct of this change is the elimination of RUNDFINDER vs CONTENT TextIterator. The
       
 45762         only difference between the two was whether to emit a newline when the range started
       
 45763         with a blockflow element. No callers actually need that any more.
       
 45764 
       
 45765         Tests added:
       
 45766         * editing/pasteboard/emacs-ctrl-k-y-001-expected.checksum: Added.
       
 45767         * editing/pasteboard/emacs-ctrl-k-y-001-expected.png: Added.
       
 45768         * editing/pasteboard/emacs-ctrl-k-y-001-expected.txt: Added.
       
 45769         * editing/pasteboard/emacs-ctrl-k-y-001.html: Added.
       
 45770 
       
 45771         * editing/Editor.cpp:
       
 45772         (WebCore::Editor::deleteRange):
       
 45773         Clear the "start new kill ring sequence" setting, because it was set to true
       
 45774         when the selection was updated by deleting the range.
       
 45775         
       
 45776         (WebCore::Editor::deleteWithDirection):
       
 45777         If extending the selection to the end of paragraph resulted in a caret selection,
       
 45778         extend by character, to handle the case when the selection started as a caret at
       
 45779         the end of paragraph.
       
 45780         
       
 45781         * editing/TextIterator.cpp:
       
 45782         (WebCore::TextIterator::TextIterator):
       
 45783         Initialize new member variables for tracking handling of the beginning of the range.
       
 45784         
       
 45785         (WebCore::TextIterator::advance):
       
 45786         Call representNodeOffsetZero on the m_endContainer.
       
 45787         Move visibility checks into handleTextNode and handleReplacedElement.
       
 45788         
       
 45789         (WebCore::TextIterator::handleTextNode):
       
 45790         (WebCore::TextIterator::handleTextBox):
       
 45791         Call emitText.
       
 45792         
       
 45793         (WebCore::TextIterator::handleReplacedElement):
       
 45794         Moved visibility check into here.
       
 45795         
       
 45796         (WebCore::shouldEmitNewlinesBeforeAndAfterNode):
       
 45797         
       
 45798         (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
       
 45799         (WebCore::TextIterator::representNodeOffsetZero):
       
 45800         New. Emits proper sequence when encountering offset 0 of a node, including the
       
 45801         m_endContainer. Started with code from handleNonTextNode.
       
 45802         
       
 45803         (WebCore::TextIterator::handleNonTextNode):
       
 45804         Call representNodeOffsetZero.
       
 45805         
       
 45806         (WebCore::TextIterator::exitNode):
       
 45807         Similar to shouldRepresentNodeOffsetZero, do not emit the newline if the node
       
 45808         was collapsed, and before any other emitted content.
       
 45809         
       
 45810         (WebCore::TextIterator::emitCharacter):
       
 45811         
       
 45812         (WebCore::TextIterator::emitText):
       
 45813         New. Consolidates code used by handleText and handleTextBox.
       
 45814         
       
 45815         (WebCore::CharacterIterator::CharacterIterator):
       
 45816         Removed RUNFINDER.
       
 45817 
       
 45818         (WebCore::WordAwareIterator::WordAwareIterator):
       
 45819         Removed RUNFINDER.
       
 45820         
       
 45821         (WebCore::WordAwareIterator::advance):
       
 45822         Formatting.
       
 45823 
       
 45824         (WebCore::TextIterator::rangeLength):
       
 45825         Formatting.
       
 45826         
       
 45827         * editing/TextIterator.h:
       
 45828         Added member variables for tracking handling of the beginning of the range.
       
 45829         Eliminated concept of RUNDFINDER vs CONTENT TextIterator.
       
 45830         
       
 45831         * editing/visible_units.cpp:
       
 45832         (WebCore::nextBoundary):
       
 45833         Eliminated concept of RUNDFINDER vs CONTENT TextIterator.
       
 45834 
       
 45835 2007-03-13  David Hyatt  <hyatt@apple.com>
       
 45836 
       
 45837         Clean up the null image case in CachedImage::data to make sure the size totals will stay accurate.
       
 45838         I'm not convinced this case can even be hit, but I'm cleaning it up just in case.
       
 45839 
       
 45840         * loader/CachedImage.cpp:
       
 45841         (WebCore::CachedImage::data):
       
 45842 
       
 45843 2007-03-13  David Hyatt  <hyatt@apple.com>
       
 45844 
       
 45845         Reorder the call to allReferencesRemoved, since otherwise the live object size will become
       
 45846         incorrect.
       
 45847 
       
 45848         * loader/CachedResource.cpp:
       
 45849         (WebCore::CachedResource::deref):
       
 45850 
       
 45851 2007-03-13  Antti Koivisto  <antti@apple.com>
       
 45852 
       
 45853         Reviewed by Darin.
       
 45854         
       
 45855         Fix http://bugs.webkit.org/show_bug.cgi?id=11083
       
 45856         REGRESSION: Typing tab key fails to insert a tab character in Google Docs editable area
       
 45857         <rdar://problem/4757650>
       
 45858         
       
 45859         Allow inserting tabs in designMode. Backtab behaves like before (matches FF).
       
 45860 
       
 45861         * page/EventHandler.cpp:
       
 45862         (WebCore::EventHandler::defaultTabEventHandler):
       
 45863 
       
 45864 2007-03-13  David Hyatt  <hyatt@apple.com>
       
 45865 
       
 45866         Fix two counting errors in the decoded size of objects in the WebCore cache.  We need to explicitly
       
 45867         destroy decoded data when clearing out a partially loaded image that had an error, since the destructor
       
 45868         (although it does destroy the data) disconnects the observer so that the notification doesn't happen.
       
 45869 
       
 45870         Some CachedImages aren't in the cache (like image documents).  When the decoded size of such an image
       
 45871         changes we should not notify the cache, since - newsflash - we aren't actually in it.
       
 45872 
       
 45873         Reviewed by ggaren
       
 45874 
       
 45875         * loader/CachedImage.cpp:
       
 45876         (WebCore::CachedImage::clear):
       
 45877         (WebCore::CachedImage::decodedSizeChanged):
       
 45878 
       
 45879 2007-03-13  Darin Adler  <darin@apple.com>
       
 45880 
       
 45881         Reviewed by Tim Hatcher and John Sullivan.
       
 45882 
       
 45883         - fix <rdar://problem/4915303> CrashTracer: 36 crashes in Safari at
       
 45884           com.apple.AppKit: -[NSView getRectsBeingDrawn:count:] + 502
       
 45885 
       
 45886         * page/mac/FrameMac.mm: (WebCore::Frame::imageFromRect):
       
 45887         This was calling drawRect: directly, but NSView's getRectsBeingDrawn:count:
       
 45888         method was never really safe to call unless it was AppKit that called your
       
 45889         drawRect: method. Changed it to call drawSingleRect: instead. A little ugly,
       
 45890         but seems to work and will almost certainly fix the bug.
       
 45891 
       
 45892 2007-03-13  Nikolas Zimmermann  <zimmermann@kde.org>
       
 45893 
       
 45894         Reviewed by Maciej.
       
 45895 
       
 45896         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12974
       
 45897 
       
 45898         Call forgetGenericContext in JSSVGPathSeg destructor, otherwhise
       
 45899         we'll hit an ASSERT in a debug build, when running svg/custom/js-update-path-changes.svg
       
 45900         a few dozen times in a single WebKit instance. The ASSERT is good and just warns that
       
 45901         there was already a generic context pointer registered, and the new "to be registered"
       
 45902         object already exists, but pointing to a different object. That's because garbage collection
       
 45903         calls the JSSVGPathSeg destructor, but that didn't cleanup the generic context map.
       
 45904 
       
 45905         Only JSSVGPathSeg is hit by this problem, as it's the only non SVGAnimated* type
       
 45906         using the generic context system while using a custom JSSVGPathSegList implementation.
       
 45907 
       
 45908         Also cleanup JSSVGPathSegListCustom code to call the static forgetGenericContext
       
 45909         method instead of doing the same using custom code.
       
 45910 
       
 45911         * bindings/js/JSSVGPathSegListCustom.cpp:
       
 45912         (WebCore::removeFromPathSegContextMap):
       
 45913         (WebCore::JSSVGPathSegList::clear):
       
 45914         (WebCore::JSSVGPathSegList::removeItem):
       
 45915         * bindings/scripts/CodeGeneratorJS.pm:
       
 45916 
       
 45917 2007-03-13  Darin Adler  <darin@apple.com>
       
 45918 
       
 45919         Reviewed by Adele.
       
 45920 
       
 45921         - fix http://bugs.webkit.org/show_bug.cgi?id=12595
       
 45922           <rdar://problem/4722863> REGRESSION: Can't add item to cart at lnt.com
       
 45923           (JS type error) (12595)
       
 45924 
       
 45925         Test: fast/forms/old-names.html
       
 45926 
       
 45927         * bindings/js/JSHTMLFormElementCustom.cpp:
       
 45928         (WebCore::JSHTMLFormElement::canGetItemsForName): If the form collection has
       
 45929         nothing for a given name, try the form's oldNamedElement function.
       
 45930         (WebCore::JSHTMLFormElement::nameGetter): Ditto.
       
 45931 
       
 45932         * bindings/js/kjs_dom.h: Removed the DOMNamedNodesCollection. Instead we will use
       
 45933         a class derived from NodeList.
       
 45934         * bindings/js/kjs_dom.cpp: Ditto.
       
 45935 
       
 45936         * bindings/js/kjs_html.cpp:
       
 45937         (KJS::VectorNodeList::VectorNodeList): Added. Constructor for a new class derived
       
 45938         from NodeList to be used for the named items result from a collection -- uses a
       
 45939         vector of node pointers.
       
 45940         (KJS::VectorNodeList::length): Added.
       
 45941         (KJS::VectorNodeList::item): Added.
       
 45942         (KJS::JSHTMLCollection::getNamedItems): Use VectorNodeList and the existing wrapper
       
 45943         for NodeList rather than a custom JavaScript class, DOMNamedNodesCollection.
       
 45944 
       
 45945         * dom/ChildNodeList.h:
       
 45946         * dom/ChildNodeList.cpp:
       
 45947         (WebCore::ChildNodeList::ChildNodeList): Updated to derive from TreeNodeList,
       
 45948         since NodeList is now a simpler class.
       
 45949         (WebCore::ChildNodeList::elementMatches): Updated for name and parameter change.
       
 45950 
       
 45951         * dom/NameNodeList.h:
       
 45952         * dom/NameNodeList.cpp:
       
 45953         (WebCore::NameNodeList::NameNodeList): Updated to derive from TreeNodeList,
       
 45954         since NodeList is now a simpler class.
       
 45955         (WebCore::NameNodeList::rootNodeAttributeChanged): Updated for name and
       
 45956         parameter change.
       
 45957 
       
 45958         * dom/Node.h: Change register/unregister functions to take TreeNodeList.
       
 45959         * dom/Node.cpp:
       
 45960         (WebCore::TagNodeList::TagNodeList): Updated to derive from TreeNodeList,
       
 45961         since NodeList is now a simpler abstract class.
       
 45962         (WebCore::TagNodeList::elementMatches): Updated for name and parameter change.
       
 45963         (WebCore::Node::registerNodeList): Changed type from NodeList to TreeNodeList.
       
 45964         (WebCore::Node::unregisterNodeList): Ditto.
       
 45965 
       
 45966         * dom/NodeList.h: Broke NodeList into a simpler base class and a derived class
       
 45967         with the machinery for iterating a tree, called TreeNodeList.
       
 45968         * dom/NodeList.cpp:
       
 45969         (WebCore::NodeList::~NodeList): Added.
       
 45970         (WebCore::NodeList::itemWithName): Factored out of the old itemWithName.
       
 45971         (WebCore::TreeNodeList::TreeNodeList): Renamed from NodeList.
       
 45972         (WebCore::TreeNodeList::~TreeNodeList): Ditto.
       
 45973         (WebCore::TreeNodeList::recursiveLength): Ditto.
       
 45974         (WebCore::TreeNodeList::itemForwardsFromCurrent): Ditto.
       
 45975         (WebCore::TreeNodeList::itemBackwardsFromCurrent): Ditto.
       
 45976         (WebCore::TreeNodeList::recursiveItem): Ditto.
       
 45977         (WebCore::TreeNodeList::itemWithName): Factored half of this into this function,
       
 45978         the other half in NodeList::itemWithName.
       
 45979         (WebCore::TreeNodeList::rootNodeAttributeChanged): Added. No longer inline.
       
 45980         (WebCore::TreeNodeList::rootNodeChildrenChanged): Renamed from NodeList.
       
 45981 
       
 45982         * html/HTMLFormElement.h: Added formElementNameChanged and oldNamedElement
       
 45983         fucntions, and a map called m_oldNames. Also removed m_boundary, which I
       
 45984         thought I had already done.
       
 45985         * html/HTMLFormElement.cpp:
       
 45986         (WebCore::HTMLFormElement::HTMLFormElement): Initialize m_oldNames to 0.
       
 45987         Switched the rest of the members to initialization syntax.
       
 45988         (WebCore::HTMLFormElement::~HTMLFormElement): Delete m_oldNames.
       
 45989         (WebCore::HTMLFormElement::formElementNameChanged): Added. Stores a reference
       
 45990         to one element under each of its old names.
       
 45991         (WebCore::HTMLFormElement::oldNamedElement): Added. Returns the old element
       
 45992         that once had a given name.
       
 45993 
       
 45994         * html/HTMLGenericFormElement.h:
       
 45995         * html/HTMLGenericFormElement.cpp:
       
 45996         (WebCore::HTMLGenericFormElement::parseMappedAttribute): When the name
       
 45997         attribute changes, tell the form about the old name.
       
 45998         (WebCore::HTMLGenericFormElement::insertedIntoTree): When telling a form
       
 45999         about an element, also store away the old name so that we can use it
       
 46000         when the name changes later.
       
 46001 
       
 46002         * html/HTMLInputElement.cpp:
       
 46003         (WebCore::HTMLInputElement::parseMappedAttribute): Added a call to the
       
 46004         base class in the nameAttr case, so the code in HTMLGenericFormElement
       
 46005         above will get called in the input element case.
       
 46006 
       
 46007 2007-03-13  Antti Koivisto  <antti@apple.com>
       
 46008 
       
 46009         Reviewed by Alexey.
       
 46010 
       
 46011         Alexey spotted a DOS by using string of 64k unbreakable character in
       
 46012         fix for http://bugs.webkit.org/show_bug.cgi?id=12833
       
 46013 
       
 46014         * dom/Text.cpp:
       
 46015         (WebCore::Text::createWithLengthLimit):
       
 46016 
       
 46017 2007-03-13  Lars Knoll <lars@trolltech.com>
       
 46018 
       
 46019         Fix the Qt build
       
 46020 
       
 46021         * WebCore.pro:
       
 46022 
       
 46023 2007-03-13  Rob Buis  <buis@kde.org>
       
 46024 
       
 46025         Reviewed by Darin.
       
 46026 
       
 46027         http://bugs.webkit.org/show_bug.cgi?id=12576
       
 46028         WebKit does not support xlink:show attributes
       
 46029 
       
 46030         Make an exception for non-empty targets, these should be opened
       
 46031         in a new window, unless the value is _self.
       
 46032 
       
 46033         * ksvg2/svg/SVGAElement.cpp:
       
 46034         (WebCore::SVGAElement::defaultEventHandler):
       
 46035 
       
 46036 2007-03-13  David Hyatt  <hyatt@apple.com>
       
 46037 
       
 46038         - fix cache issues seen in http://bugs.webkit.org/show_bug.cgi?id=13050
       
 46039           6 objects and ~200MB leaked after opening then closing tab
       
 46040           <rdar://problem/5058714>
       
 46041 
       
 46042         Double the encoded size of images for now.  We do this to account for a bug in ImageIO where they hold
       
 46043         a separate copy of image data.  See <rdar://problem/5050645>.
       
 46044 
       
 46045         Reviewed by aroben.
       
 46046 
       
 46047         * loader/CachedImage.cpp:
       
 46048         (WebCore::CachedImage::data):
       
 46049 
       
 46050 2007-03-12  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 46051 
       
 46052         Not reviewed - gdk build fix.
       
 46053 
       
 46054         * platform/gdk/TemporaryLinkStubs.cpp:
       
 46055         (SearchPopupMenu::enabled): add missing stub.
       
 46056 
       
 46057 2007-03-12  David Kilzer  <ddkilzer@kilzer.net>
       
 46058 
       
 46059         Reviewed by Darin.
       
 46060 
       
 46061         - fix http://bugs.webkit.org/show_bug.cgi?id=13045
       
 46062           REGRESSION: Blackboard CourseWare Error with Nightlies after Mar 8
       
 46063 
       
 46064         * html/HTMLFormElement.cpp:
       
 46065         (WebCore::getUniqueBoundaryString): Speculative fix: remove dashes from
       
 46066         the boundary prefix that appear after non-dash characters.
       
 46067 
       
 46068 2007-03-12  Mitz Pettel  <mitz@webkit.org>
       
 46069 
       
 46070         Reviewed by Anders.
       
 46071 
       
 46072         - fix http://bugs.webkit.org/show_bug.cgi?id=13015
       
 46073           REGRESSION (r17233-r17241): Repro crash when leaving a page whose unload handler submits a form
       
 46074 
       
 46075         Test: fast/loader/onunload-form-submit-crash-2.html
       
 46076 
       
 46077         * loader/DocumentLoader.cpp:
       
 46078         (WebCore::DocumentLoader::finishedLoading): Added null check.
       
 46079 
       
 46080 2007-03-12  Anders Carlsson  <acarlsson@apple.com>
       
 46081 
       
 46082         Reviewed by Darin.
       
 46083 
       
 46084         <rdar://problem/4900071>
       
 46085         http://bugs.webkit.org/show_bug.cgi?id=6454
       
 46086         ASSERTION: Navigating 'back' in frameset: !_private->previousItem (6454)
       
 46087 
       
 46088         Change back the behavior of checkLoadComplete to traverse the entire frame tree instead of
       
 46089         just the parent frames of the current frame. This is needed in order to reset the previous history item
       
 46090         for all frames when doing a frame navigation. (This was changed in revision 11819)
       
 46091         
       
 46092         * loader/FrameLoader.cpp:
       
 46093         (WebCore::FrameLoader::recursiveCheckLoadComplete):
       
 46094         (WebCore::FrameLoader::checkLoadComplete):
       
 46095         * loader/FrameLoader.h:
       
 46096 
       
 46097 2007-03-12  Justin Garcia  <justin.garcia@apple.com>
       
 46098 
       
 46099         Reviewed by darin
       
 46100         
       
 46101         <rdar://problem/5056619> 
       
 46102         REGRESSION: Gmail Editor: Dragging text into Reply (textarea) field results in a crash at WebCore::InsertNodeBeforeCommand::doApply()
       
 46103         
       
 46104         * editing/SelectionController.cpp:
       
 46105         (WebCore::removingNodeRemovesPosition): Added.
       
 46106         (WebCore::SelectionController::nodeWillBeRemoved): Clear the
       
 46107         selection if it's inside a shadow tree.
       
 46108         * page/DragController.cpp:
       
 46109         (WebCore::setSelectionToDragCaret): Return false to signal to
       
 46110         clients that a drop shouldn't be performed if the second attempt
       
 46111         to set a selection ends up in non-editable content.
       
 46112 
       
 46113 2007-03-12  Darin Adler  <darin@apple.com>
       
 46114 
       
 46115         Reviewed by Tim Hatcher.
       
 46116 
       
 46117         - fixed JavaScript wrapper classes to be correct for a variety of cases
       
 46118           that a new test uncovered: was broken for at least 5 classes
       
 46119 
       
 46120         - fixed Objective-C wrapper classes to be correct for a variety of cases
       
 46121           that a test case uncovered: was broken for ast least 50 classes
       
 46122 
       
 46123         - added missing DOM API for creating OverflowEvent and WheelEvent instances
       
 46124 
       
 46125         Test: fast/dom/wrapper-classes.html
       
 46126 
       
 46127         * DerivedSources.make: Added missing bindings: HTMLCanvasElement for ObjC,
       
 46128         CDATASection, Comment, and EntityReference for JavaScript.
       
 46129         * WebCore.xcodeproj/project.pbxproj: Added those new generated files.
       
 46130 
       
 46131         * bindings/js/JSHTMLElementWrapperFactory.cpp:
       
 46132         (WebCore::createJSHTMLWrapper): Corrected the wrapper classes for <keygen>,
       
 46133         which needs an HTMLSelectElement wrapper, and <xmp>, which needs an
       
 46134         HTMLPreElement wrapper.
       
 46135 
       
 46136         * bindings/objc/DOMInternal.h: Updated for new naming scheme.
       
 46137         Also moved createDOMWrapper from the KJS namespace to the WebCore namespace.
       
 46138         * bindings/objc/DOMUtility.mm:
       
 46139         (KJS::createDOMWrapper): Broke the core function into a separate one, and
       
 46140         left it in the KJS namespace because Objective-C++ rules make it impossible
       
 46141         for it to work in the WebCore namespace. Used a macro-based implementation
       
 46142         to cut down on repeated code, and added missing cases for Counter,
       
 46143         HTMLOptionsCollection, Range, XPathExpression, XPathResult, Event, RGBColor,
       
 46144         Rect, Window, DOMImplementation, NodeIterator, TreeWalker, and HTMLCollection.
       
 46145         (WebCore::createDOMWrapper): The other half of the function.
       
 46146 
       
 46147         * bindings/objc/DOM.mm:
       
 46148         (WebCore::createElementClassMap): Corrected the wrapper classes for
       
 46149         <canvas>, which needs a DOMHTMLCanvasElement wrapper, <del>, which needs
       
 46150         a DOMHTMLModElement wrapper, <embed>, which needs a DOMHTMLEmbedElement
       
 46151         wrapper, <ins>, which needs a DOMHTMLModElement wrapper, <th>, which needs
       
 46152         a DOMHTMLTableCellElement wrapper, and <xmp>, which needs an
       
 46153         DOMHTMLPreElement wrapper.
       
 46154         (+[DOMNode _wrapNode:]): Updated for new naming scheme.
       
 46155         (+[DOMNode _wrapEventTarget:]): Ditto.
       
 46156         (+[DOMNodeFilter _wrapNodeFilter:]): Ditto.
       
 46157         (ObjCNodeFilterCondition::acceptNode): Ditto.
       
 46158         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): Ditto.
       
 46159         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): Ditto.
       
 46160         (WebCore::ObjCEventListener::handleEvent): Ditto.
       
 46161 
       
 46162         * dom/Document.cpp: (WebCore::Document::createEvent):
       
 46163         Added cases for OverflowEvent and WheelEvent.
       
 46164 
       
 46165         * dom/OverflowEvent.h: Added empty constructor and initOverflowEvent.
       
 46166         * dom/OverflowEvent.cpp:
       
 46167         (WebCore::OverflowEvent::OverflowEvent): Added.
       
 46168         (WebCore::OverflowEvent::initOverflowEvent): Added.
       
 46169         * dom/OverflowEvent.idl: Added initOverflowEvent.
       
 46170 
       
 46171         * bindings/objc/PublicDOMInterfaces.h: Added initOverflowEvent.
       
 46172 
       
 46173         * bindings/objc/DOMCSS.mm:
       
 46174         (+[DOMStyleSheet _wrapStyleSheet:]): Updated for new naming scheme.
       
 46175         (+[DOMCSSRule _wrapCSSRule:]): Corrected wrapper for CSSUnknownRule.
       
 46176         (+[DOMCSSValue _wrapCSSValue:]): Updated for new naming scheme.
       
 46177 
       
 46178         * bindings/js/kjs_css.h:
       
 46179         (KJS::DOMRGBColor::impl): Added. Used when making an ObjC wrapper.
       
 46180         (KJS::DOMRect::impl): Ditto.
       
 46181 
       
 46182         * bindings/js/kjs_dom.cpp: (KJS::toJS): Corrected the wrapper classes for
       
 46183         CDATASection, Comment, and EntityReference.
       
 46184 
       
 46185         * bindings/js/kjs_html.cpp: Corrected the class name for HTMLElement
       
 46186         (was "DOMHTMLElement") and HTMLCollection (was "Collection").
       
 46187 
       
 46188         * bindings/objc/DOMImplementationFront.h:
       
 46189         * bindings/objc/DOMImplementationFront.cpp:
       
 46190         (WebCore::implementationFront): Added new overload that returns a front given
       
 46191         a JavaScript wrapper. Needed by the code that makes the Objective-C wrapper.
       
 46192 
       
 46193         * bindings/objc/WebScriptObject.mm:
       
 46194         (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
       
 46195         Updated since createDOMWrapper is now in the WebCore namespace.
       
 46196 
       
 46197         * bindings/scripts/CodeGeneratorObjC.pm: Update the naming scheme for the
       
 46198         wrapper creation functions to use _wrapElement: rather then _elementWith:
       
 46199         style. Removed now-unneeded special cases for things that needed to stay
       
 46200         upper-case, since we don't have to do the whole lcfirst thing.
       
 46201 
       
 46202         * html/HTMLCanvasElement.idl: Added #if so we can successfully generate the
       
 46203         Objective-C wrapper for this class, even though we can't yet handle the
       
 46204         DOMObject return type.
       
 46205 
       
 46206         * html/HTMLOptionsCollection.idl: Added GenerateNativeConverter so we get
       
 46207         an appropriate toJS function.
       
 46208 
       
 46209         * bindings/objc/DOMEvents.mm:
       
 46210         (+[DOMEvent _wrapEvent:]):
       
 46211         * bindings/objc/DOMHTML.mm:
       
 46212         (-[DOMHTMLDocument createDocumentFragmentWithMarkupString:baseURL:]):
       
 46213         (-[DOMHTMLDocument createDocumentFragmentWithText:]):
       
 46214         * bindings/objc/DOMObject.mm:
       
 46215         (-[DOMObject sheet]):
       
 46216         * bindings/objc/DOMRGBColor.mm:
       
 46217         (-[DOMRGBColor red]):
       
 46218         (-[DOMRGBColor green]):
       
 46219         (-[DOMRGBColor blue]):
       
 46220         (-[DOMRGBColor alpha]):
       
 46221         (+[DOMRGBColor _wrapRGBColor:]):
       
 46222         * bindings/objc/DOMSVGPathSegInternal.mm:
       
 46223         (+[DOMSVGPathSeg _wrapSVGPathSeg:]):
       
 46224         * bindings/objc/DOMXPath.mm:
       
 46225         (+[DOMNativeXPathNSResolver _wrapXPathNSResolver:]):
       
 46226         * page/mac/WebCoreFrameBridge.mm:
       
 46227         (-[WebCoreFrameBridge nodesFromList:]):
       
 46228         (-[WebCoreFrameBridge elementWithName:inForm:]):
       
 46229         (-[WebCoreFrameBridge formForElement:]):
       
 46230         (-[WebCoreFrameBridge currentForm]):
       
 46231         (-[WebCoreFrameBridge controlsInForm:]):
       
 46232         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
       
 46233         (-[WebCoreFrameBridge convertNSRangeToDOMRange:]):
       
 46234         (-[WebCoreFrameBridge markDOMRange]):
       
 46235         (-[WebCoreFrameBridge markedTextDOMRange]):
       
 46236         (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]):
       
 46237         (-[WebCoreFrameBridge documentFragmentWithMarkupString:baseURLString:]):
       
 46238         (-[WebCoreFrameBridge documentFragmentWithText:inContext:]):
       
 46239         (-[WebCoreFrameBridge documentFragmentWithNodesAsParagraphs:]):
       
 46240         (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
       
 46241         (-[WebCoreFrameBridge replaceSelectionWithText:selectReplacement:smartReplace:]):
       
 46242         (-[WebCoreFrameBridge increaseSelectionListLevel]):
       
 46243         (-[WebCoreFrameBridge increaseSelectionListLevelOrdered]):
       
 46244         (-[WebCoreFrameBridge increaseSelectionListLevelUnordered]):
       
 46245         (-[WebCoreFrameBridge dragCaretDOMRange]):
       
 46246         (-[WebCoreFrameBridge editableDOMRangeForPoint:]):
       
 46247         (-[WebCoreFrameBridge characterRangeAtPoint:]):
       
 46248         (-[WebCoreFrameBridge typingStyle]):
       
 46249         (-[WebCoreFrameBridge rangeOfCharactersAroundCaret]):
       
 46250         * platform/mac/ClipboardMac.mm:
       
 46251         (WebCore::ClipboardMac::declareAndWriteDragImage):
       
 46252         * platform/mac/PasteboardMac.mm:
       
 46253         (WebCore::Pasteboard::writeSelection):
       
 46254         Updated for new naming scheme.
       
 46255 
       
 46256 2007-03-12  Timothy Hatcher  <timothy@apple.com>
       
 46257 
       
 46258         Reviewed by Darin.
       
 46259 
       
 46260         <rdar://problem/4990691> REGRESSION: Selecting text in Adium's Messages field causes horizontal shift
       
 46261 
       
 46262         Corrected the recursive point conversion and scrolling done in scrollPointRecursively to use the
       
 46263         document view of each NSClipView.
       
 46264 
       
 46265         * platform/mac/ScrollViewMac.mm:
       
 46266         (WebCore::ScrollView::scrollPointRecursively): Call convertPoint:fromView: on the document views,
       
 46267         not the clip views as we encounter them. Then call constrainScrollPoint: on the converted point to
       
 46268         constrain to the document view bounds. And finally call scrollPoint: on the document view, not the clip view.
       
 46269 
       
 46270 2007-03-12  Antti Koivisto  <antti@apple.com>
       
 46271 
       
 46272         Reviewed by Alexey.
       
 46273 
       
 46274         Fix http://bugs.webkit.org/show_bug.cgi?id=12833
       
 46275         REGRESSION: Selecting text in 6.6MB txt file is sluggish as of the Feb 19th nightly
       
 46276         <rdar://problem/5028159>
       
 46277         
       
 46278         Divide large text blocks (>64kB) over multiple text nodes. This limits linebox searches to
       
 46279         a manageable subset.
       
 46280         
       
 46281         * dom/Text.cpp:
       
 46282         (WebCore::Text::createWithLengthLimit):
       
 46283         * dom/Text.h:
       
 46284         * html/HTMLParser.cpp:
       
 46285         (WebCore::HTMLParser::parseToken):
       
 46286         * loader/TextDocument.cpp:
       
 46287         (WebCore::TextTokenizer::write):
       
 46288 
       
 46289 2007-03-12  David Hyatt  <hyatt@apple.com>
       
 46290 
       
 46291         Fix a regression in printing.  Printer fonts need to be part of the
       
 46292         font cache key, since printer fonts have different glyph widths.
       
 46293         (Integer antialiasing is used for screen fonts but not for printer fonts.)
       
 46294 
       
 46295         Reviewed by aroben
       
 46296 
       
 46297         * platform/FontCache.cpp:
       
 46298         (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
       
 46299         (WebCore::FontPlatformDataCacheKey::operator==):
       
 46300         (WebCore::computeHash):
       
 46301         (WebCore::FontCache::getCachedFontPlatformData):
       
 46302 
       
 46303 2007-03-12  Lars Knoll <lars@trolltech.com>
       
 46304 
       
 46305         add missing symbol to fix the Qt build again.
       
 46306 
       
 46307         * platform/qt/SearchPopupMenuQt.cpp:
       
 46308         (WebCore::SearchPopupMenu::enabled):
       
 46309 
       
 46310 2007-03-12  Adele Peterson  <adele@apple.com>
       
 46311 
       
 46312         Reviewed by Oliver.
       
 46313 
       
 46314         Adding the ability to enable or disable a SearchPopupMenu.
       
 46315 
       
 46316         * platform/SearchPopupMenu.h:
       
 46317         * platform/mac/SearchPopupMenuMac.mm: (WebCore::SearchPopupMenu::enabled):
       
 46318         * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::showPopup):
       
 46319 
       
 46320 2007-03-12  Rob Buis  <buis@kde.org>
       
 46321 
       
 46322         Reviewed by Nikolas Zimmermann.
       
 46323 
       
 46324         http://bugs.webkit.org/show_bug.cgi?id=12500
       
 46325         SVG fails to correctly handle all link style selectors
       
 46326         http://bugs.webkit.org/show_bug.cgi?id=12567
       
 46327         <text> elements ignore <a> children
       
 46328 
       
 46329         Allow <a> inside svg text and handle xlink:show.
       
 46330 
       
 46331         * ksvg2/svg/SVGAElement.cpp:
       
 46332         (WebCore::SVGAElement::createRenderer):
       
 46333         (WebCore::SVGAElement::defaultEventHandler):
       
 46334         (WebCore::SVGAElement::childShouldCreateRenderer):
       
 46335         * ksvg2/svg/SVGAElement.h:
       
 46336         * ksvg2/svg/SVGElement.h:
       
 46337         (WebCore::SVGElement::isTextContent):
       
 46338         * ksvg2/svg/SVGTextContentElement.h:
       
 46339         (WebCore::SVGTextContentElement::isTextContent):
       
 46340         * ksvg2/svg/SVGTextElement.cpp:
       
 46341         (WebCore::SVGTextElement::childShouldCreateRenderer):
       
 46342         * rendering/SVGInlineFlowBox.cpp:
       
 46343         (WebCore::translateBox):
       
 46344         (WebCore::placePositionedBoxesHorizontally):
       
 46345         (WebCore::placeBoxesVerticallyWithAbsBaseline):
       
 46346 
       
 46347 2007-03-12  Adele Peterson  <adele@apple.com>
       
 46348 
       
 46349         Reviewed by Oliver.
       
 46350 
       
 46351         Add a missing parameter to the constructor.
       
 46352 
       
 46353         * platform/PlatformKeyboardEvent.h:
       
 46354         * platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
       
 46355 
       
 46356 2007-03-12  Lars Knoll <lars@trolltech.com>
       
 46357 
       
 46358         Fix the Qt build. I still get crashes though :/
       
 46359 
       
 46360         * platform/graphics/qt/ImageDecoderQt.cpp:
       
 46361         (WebCore::ImageDecoderQt::clearFrame):
       
 46362         * platform/graphics/qt/ImageDecoderQt.h:
       
 46363         * platform/graphics/qt/ImageSourceQt.cpp:
       
 46364         (WebCore::ImageSource::setData):
       
 46365         (WebCore::ImageSource::frameIsCompleteAtIndex):
       
 46366         (WebCore::ImageSource::clear):
       
 46367         (WebCore::ImageSource::destroyFrameAtIndex):
       
 46368         * platform/qt/ClipboardQt.cpp:
       
 46369         (WebCore::ClipboardQt::ClipboardQt):
       
 46370         * platform/qt/ClipboardQt.h:
       
 46371         * platform/qt/DragDataQt.cpp:
       
 46372         (WebCore::DragData::createClipboard):
       
 46373 
       
 46374 2007-03-11  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 46375 
       
 46376         Not reviewed - gdk build fixes.
       
 46377 
       
 46378         * platform/gdk/EditorClientGdk.cpp:
       
 46379         (WebCore::EditorClientGdk::respondToChangedSelection): add stub
       
 46380         * platform/gdk/EditorClientGdk.h:
       
 46381         * platform/gdk/FrameGdk.cpp:
       
 46382         * platform/gdk/TemporaryLinkStubs.cpp:
       
 46383         (Editor::markMisspellings): add stub
       
 46384 
       
 46385 2007-03-11  Alexey Proskuryakov  <ap@webkit.org>
       
 46386 
       
 46387         Reviewed by Adele.
       
 46388 
       
 46389         http://bugs.webkit.org/show_bug.cgi?id=12560
       
 46390         W3C XPath test Text_Nodes.svg fails
       
 46391 
       
 46392         * xml/XPathStep.cpp:
       
 46393         (WebCore::XPath::Step::nodeTestMatches): Revert the fix, as the behavior doesn't appear 
       
 46394         all that desirable as it did at first glance.
       
 46395 
       
 46396 2007-03-11  Oliver Hunt  <oliver@apple.com>
       
 46397 
       
 46398         Reviewed by hyatt.
       
 46399 
       
 46400         Fix for <rdar://problem/5055690> ASSERTION failure on drop into 
       
 46401         editable element with content changed on drop 
       
 46402 
       
 46403         After setting the selection for a drop into an editable region 
       
 46404         we make sure the we succeeded.  If we didn't we assume a focus handler
       
 46405         or similar altered the element contents and try again, if the second
       
 46406         attempt fails we bail out.
       
 46407 
       
 46408         * page/DragController.cpp:
       
 46409         (WebCore::setSelectionToDragCaret):
       
 46410         (WebCore::DragController::concludeDrag):
       
 46411 
       
 46412 2007-03-11  Oliver Hunt  <oliver@apple.com>
       
 46413 
       
 46414         Reviewed by Adele.
       
 46415 
       
 46416         Moving Frame{Mac}::respondToChangedSelection to Frame.cpp
       
 46417         Added new EditorClient method to handle old bridge function
       
 46418         
       
 46419         * bridge/EditorClient.h:
       
 46420            Added respondToChangedSelection to replace old bridge function
       
 46421         * editing/Editor.cpp:
       
 46422         (WebCore::Editor::respondToChangedSelection):
       
 46423            Add client call to replace old bridge call from Frame::respondToChangedSelection
       
 46424         * editing/SelectionController.cpp:
       
 46425         (WebCore::SelectionController::setSelection):
       
 46426            No longer directly call Editor as Frame::respondToChangedSelection
       
 46427            makes the call
       
 46428         * page/Frame.cpp:
       
 46429         (WebCore::Frame::respondToChangedSelection):
       
 46430            Moved from FrameMac, replaced bridge call with call to Editor
       
 46431         * page/mac/FrameMac.mm:
       
 46432            Moved respondToChangedSelection to Frame.cpp
       
 46433         * page/mac/WebCoreFrameBridge.h:
       
 46434            Removed respondToChangedSelection from bridge
       
 46435         * page/qt/FrameQt.cpp:
       
 46436            Remove stub method for respondToChangedSelection
       
 46437 
       
 46438 2007-03-11  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 46439 
       
 46440         Reviewed by Brady Eidson.
       
 46441 
       
 46442         Linux/gdk fix.
       
 46443 
       
 46444         * loader/gdk/FrameLoaderClientGdk.cpp:
       
 46445         (WebCore::FrameLoaderClientGdk::shouldGoToHistoryItem): return true so
       
 46446         that FrameLoader:goBackOrForwards() works.
       
 46447 
       
 46448 2007-03-10  Geoffrey Garen  <ggaren@apple.com>
       
 46449 
       
 46450         Reviewed by Darin Adler.
       
 46451 
       
 46452         Fixed <rdar://problem/4587763> PAC file: lock inversion between QT and 
       
 46453         JSCore causes a hang @ www.panoramas.dk
       
 46454         
       
 46455         See JavaScriptCore ChangeLog for details.
       
 46456         
       
 46457         * bindings/objc/WebScriptObject.mm:
       
 46458         (_didExecute): Added helpful ASSERT.
       
 46459         (+[WebScriptObject throwException:]): Added missing JSLock.
       
 46460 
       
 46461 2007-03-11  Antti Koivisto  <antti@apple.com>
       
 46462 
       
 46463         Reviewed by Hyatt.
       
 46464 
       
 46465         Optimize linebox memory consumption:
       
 46466         - move all bitfields to baseclass compacting them
       
 46467         - make InlineTextBox::m_truncation unsigned short and make it relative to m_start
       
 46468         - remove extremely rarely used EllipsisBox pointer from RootInlineBox and instead
       
 46469           use a global hashmap to store it if needed
       
 46470         - use minimum required number of bits to store BidiStatus enum variables in RootInlineBox
       
 46471         - move overflow variables in RootInlineBox to a separate struct that is instantiated
       
 46472           only if any of the variables is set to a value that can't trivially be derived from 
       
 46473           box x, y, width and height
       
 46474           
       
 46475         As a result line box objects shrink:
       
 46476             InlineBox: 44 -> 44 bytes
       
 46477             InlineTextBox: 68 -> 60 bytes
       
 46478             InlineFlowBox: 68 -> 64 bytes
       
 46479             RootInlineBox: 128 -> 88 bytes
       
 46480             
       
 46481         The optimizations possiblity was noticed when debugging http://bugs.webkit.org/show_bug.cgi?id=12833
       
 46482         Bug 12833: REGRESSION: Selecting text in 6.6MB txt file is sluggish as of the Feb 19th nightly
       
 46483         <rdar://problem/5028159>
       
 46484         
       
 46485         On that page the patch saves 11.5MB or some 21% of linebox memory consumption. It also
       
 46486         actually improves selection performance somewhat by improving memory locality.
       
 46487 
       
 46488         * rendering/InlineBox.h:
       
 46489         (WebCore::InlineBox::InlineBox):
       
 46490         * rendering/InlineFlowBox.h:
       
 46491         (WebCore::InlineFlowBox::InlineFlowBox):
       
 46492         * rendering/InlineTextBox.cpp:
       
 46493         (WebCore::InlineTextBox::placeEllipsisBox):
       
 46494         (WebCore::InlineTextBox::nodeAtPoint):
       
 46495         (WebCore::InlineTextBox::paint):
       
 46496         (WebCore::InlineTextBox::paintDecoration):
       
 46497         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
       
 46498         (WebCore::InlineTextBox::paintMarkedTextUnderline):
       
 46499         * rendering/InlineTextBox.h:
       
 46500         (WebCore::InlineTextBox::InlineTextBox):
       
 46501         * rendering/RootInlineBox.cpp:
       
 46502         (WebCore::throw):
       
 46503         (WebCore::RootInlineBox::Overflow::operator delete):
       
 46504         (WebCore::RootInlineBox::Overflow::destroy):
       
 46505         (WebCore::RootInlineBox::destroy):
       
 46506         (WebCore::RootInlineBox::detachEllipsisBox):
       
 46507         (WebCore::RootInlineBox::clearTruncation):
       
 46508         (WebCore::RootInlineBox::placeEllipsis):
       
 46509         (WebCore::RootInlineBox::paintEllipsisBox):
       
 46510         (WebCore::RootInlineBox::addHighlightOverflow):
       
 46511         (WebCore::RootInlineBox::nodeAtPoint):
       
 46512         (WebCore::RootInlineBox::adjustPosition):
       
 46513         (WebCore::RootInlineBox::selectionTop):
       
 46514         (WebCore::RootInlineBox::setLineBreakInfo):
       
 46515         (WebCore::RootInlineBox::ellipsisBox):
       
 46516         (WebCore::RootInlineBox::setVerticalOverflowPositions):
       
 46517         (WebCore::RootInlineBox::setHorizontalOverflowPositions):
       
 46518         (WebCore::RootInlineBox::setVerticalSelectionPositions):
       
 46519         * rendering/RootInlineBox.h:
       
 46520         (WebCore::RootInlineBox::RootInlineBox):
       
 46521         (WebCore::RootInlineBox::topOverflow):
       
 46522         (WebCore::RootInlineBox::bottomOverflow):
       
 46523         (WebCore::RootInlineBox::leftOverflow):
       
 46524         (WebCore::RootInlineBox::rightOverflow):
       
 46525         (WebCore::RootInlineBox::lineBreakBidiStatus):
       
 46526         (WebCore::RootInlineBox::selectionBottom):
       
 46527         (WebCore::RootInlineBox::Overflow::Overflow):
       
 46528 
       
 46529 2007-03-11  Alexey Proskuryakov  <ap@webkit.org>
       
 46530 
       
 46531         Reviewed by Darin.
       
 46532 
       
 46533         A partial fix for http://bugs.webkit.org/show_bug.cgi?id=13021
       
 46534         XPath can be very slow
       
 46535 
       
 46536         * xml/XPathExpression.cpp:
       
 46537         (WebCore::XPathExpression::evaluate): Cache evaluationContext in a local variable.
       
 46538 
       
 46539         * xml/XPathExpressionNode.cpp:
       
 46540         (WebCore::XPath::Expression::evaluationContext):
       
 46541         * xml/XPathExpressionNode.h:
       
 46542         (WebCore::XPath::Expression::addSubExpression):
       
 46543         (WebCore::XPath::Expression::subExprCount):
       
 46544         (WebCore::XPath::Expression::subExpr):
       
 46545         * xml/XPathFunctions.cpp:
       
 46546         * xml/XPathFunctions.h:
       
 46547         (WebCore::XPath::Function::setName):
       
 46548         (WebCore::XPath::Function::arg):
       
 46549         (WebCore::XPath::Function::argCount):
       
 46550         (WebCore::XPath::Function::name):
       
 46551         Made one-liners critical for performance inline.
       
 46552 
       
 46553         * xml/XPathGrammar.y: Fully parse NodeTests, so that strings are no longer passed for what is
       
 46554         essentially an enum. Use LocationPath accessors to add steps, instead of directly manipulating
       
 46555         internal data members.
       
 46556 
       
 46557         * xml/XPathParser.cpp:
       
 46558         (WebCore::XPath::Parser::parseStatement):
       
 46559         (WebCore::XPath::Parser::registerNodeTest):
       
 46560         (WebCore::XPath::Parser::deleteNodeTest):
       
 46561         * xml/XPathParser.h:
       
 46562         Added support methods for changes in XPathGrammar.y.
       
 46563 
       
 46564         * xml/XPathPath.cpp:
       
 46565         (WebCore::XPath::Filter::evaluate): Cache evaluationContext in a local variable. Use swap() to avoid
       
 46566         performing vector assignments.
       
 46567         (WebCore::XPath::LocationPath::evaluate): Use swap() to avoid performing vector assignments.
       
 46568         (WebCore::XPath::LocationPath::optimizeStepPair): This new method is called during LocationPath construction, 
       
 46569         to simplify the path as it's being built. Currently, the only optimized case is "//*" - it is a basis for
       
 46570         important operations that cannot be efficiently written in XPath 1.0, but can be optimized with a little bit
       
 46571         of XPath 2.0.
       
 46572         (WebCore::XPath::LocationPath::appendStep): A new accessor that modifies m_steps and calls optimizeStepPair().
       
 46573         (WebCore::XPath::LocationPath::insertFirstStep): Ditto.
       
 46574         * xml/XPathPath.h:
       
 46575         (WebCore::XPath::LocationPath::setAbsolute): A new accessor.
       
 46576 
       
 46577         * xml/XPathStep.h:
       
 46578         (WebCore::XPath::Step::NodeTest::):
       
 46579         (WebCore::XPath::Step::NodeTest::NodeTest):
       
 46580         (WebCore::XPath::Step::NodeTest::kind):
       
 46581         (WebCore::XPath::Step::NodeTest::data):
       
 46582         Step::NodeTest is a new sub-class that represents a fully parsed NodeTest.
       
 46583         (WebCore::XPath::Step::axis):
       
 46584         (WebCore::XPath::Step::nodeTest):
       
 46585         (WebCore::XPath::Step::nodeTestData):
       
 46586         (WebCore::XPath::Step::namespaceURI):
       
 46587         (WebCore::XPath::Step::predicates):
       
 46588         (WebCore::XPath::Step::setAxis):
       
 46589         (WebCore::XPath::Step::setNodeTest):
       
 46590         (WebCore::XPath::Step::setNodeTestData):
       
 46591         (WebCore::XPath::Step::setNamespaceURI):
       
 46592         (WebCore::XPath::Step::setPredicates):
       
 46593         New accessors that let optimizeStepPair() manipulate Step data.
       
 46594 
       
 46595         * xml/XPathStep.cpp:
       
 46596         (WebCore::XPath::Step::Step): Use the new NodeTest class.
       
 46597         (WebCore::XPath::Step::evaluate): Cache evaluationContext in a local variable. Use swap() to avoid
       
 46598         performing unneeded vector assignments.
       
 46599         (WebCore::XPath::Step::nodesInAxis): Cosmetic changes.
       
 46600         (WebCore::XPath::Step::nodeTestMatches): Use NodeTest instead of parsing the test from string each time.
       
 46601         Added a partial implementation of XPath 2.0 element() node test.
       
 46602 
       
 46603 2007-03-10  Alexey Proskuryakov  <ap@webkit.org>
       
 46604 
       
 46605         Reviewed by Darin.
       
 46606 
       
 46607         http://bugs.webkit.org/show_bug.cgi?id=12249
       
 46608         FCKeditor: <hr>, <ul> and <ol> have id="undefined"
       
 46609 
       
 46610         This fixes the attached reduction, but not the original issue.
       
 46611 
       
 46612         Test: editing/execCommand/default-parameters.html
       
 46613 
       
 46614         * dom/Document.h:
       
 46615         * dom/Document.idl:
       
 46616         Make second and third execCommand() parameters optional.
       
 46617 
       
 46618 2007-03-10  Adele Peterson  <adele@apple.com>
       
 46619 
       
 46620         Reviewed by Maciej.
       
 46621 
       
 46622         Fix for http://bugs.webkit.org/show_bug.cgi?id=13028
       
 46623         REGRESSION: textField:doCommandBySelector:inFrame: not being called properly
       
 46624 
       
 46625         * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
       
 46626           Before calling the base class defaultEventHandler, which will call handleKeypress, call doTextFieldCommandFromEvent.        
       
 46627 
       
 46628 2007-03-10  Mitz Pettel  <mitz@webkit.org>
       
 46629 
       
 46630         Reviewed by Darin.
       
 46631 
       
 46632         - fix http://bugs.webkit.org/show_bug.cgi?id=13013
       
 46633           REGRESSION: Selection box does not scroll to where the focus jumps when pressing an alphanumeric key
       
 46634 
       
 46635         Test: fast/forms/listbox-typeahead-scroll.html
       
 46636 
       
 46637         * html/HTMLSelectElement.cpp:
       
 46638         (WebCore::HTMLSelectElement::setSelectedIndex): Reordered to set the active selection's
       
 46639         anchor and end before selecting the option, since the active selection is used to
       
 46640         decide where to scroll when the selection is made.
       
 46641         (WebCore::HTMLSelectElement::defaultEventHandler): Removed redundant check.
       
 46642 
       
 46643 2007-03-10  Mitz Pettel  <mitz@webkit.org>
       
 46644 
       
 46645         Reviewed by Darin.
       
 46646 
       
 46647         - fix http://bugs.webkit.org/show_bug.cgi?id=12973
       
 46648           REGRESSION: Reproducible assert while loading this test file if css is already in the cache
       
 46649 
       
 46650         Test: fast/dom/css-cached-import-rule.html
       
 46651 
       
 46652         Replaced some direct calls to document->stylesheetLoaded() with calls to
       
 46653         the sheet's checkLoaded(). The latter calls back to the element's sheetLoaded() --
       
 46654         which notifies the document of the load -- and then updates the sheet's
       
 46655         loadCompleted() flag, ensuring that it stays in sync with whether the stylesheet
       
 46656         is still considered pending by the document.
       
 46657 
       
 46658         * dom/ProcessingInstruction.cpp:
       
 46659         (WebCore::ProcessingInstruction::parseStyleSheet):
       
 46660         * dom/StyleElement.cpp:
       
 46661         (WebCore::StyleElement::childrenChanged):
       
 46662         * html/HTMLLinkElement.cpp:
       
 46663         (WebCore::HTMLLinkElement::process):
       
 46664         (WebCore::HTMLLinkElement::setCSSStyleSheet):
       
 46665         * ksvg2/svg/SVGStyleElement.cpp:
       
 46666         (WebCore::SVGStyleElement::sheetLoaded):
       
 46667         * ksvg2/svg/SVGStyleElement.h:
       
 46668 
       
 46669 2007-03-10  David Kilzer  <ddkilzer@webkit.org>
       
 46670 
       
 46671         Reviewed by Darin.
       
 46672 
       
 46673         - fix http://bugs.webkit.org/show_bug.cgi?id=9609
       
 46674           REGRESSION: Missing image icon needs to be moved back to WebKit
       
 46675 
       
 46676         * WebCore.exp: Export WebCore::Image::loadPlatformResource(const char*) for use in
       
 46677         [WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:].
       
 46678 
       
 46679 2007-03-09  Darin Adler  <darin@apple.com>
       
 46680 
       
 46681         Reviewed by Justin.
       
 46682 
       
 46683         - fix http://bugs.webkit.org/show_bug.cgi?id=8928
       
 46684           <rdar://problem/5045708> REPRODUCIBLE ASSERT: Cannot paste HTML into a
       
 46685           contenteditable region in an XHTML document (8928)
       
 46686 
       
 46687         Test: editing/pasteboard/paste-xml.xhtml
       
 46688 
       
 46689         * editing/markup.cpp: (WebCore::createFragmentFromMarkup): Added a check for 0
       
 46690         here, since createContextualFragment can return 0 for XML documents that fail
       
 46691         to parse. In my testing, callers all seem equipped to handle 0.
       
 46692 
       
 46693 2007-03-09  Mitz Pettel  <mitz@webkit.org>
       
 46694 
       
 46695         Reviewed by Darin.
       
 46696 
       
 46697         - fix http://bugs.webkit.org/show_bug.cgi?id=9929
       
 46698           REGRESSION: crash on logging in on mijnpostbank.nl
       
 46699 
       
 46700         Test: http/tests/misc/onload-remove-iframe-crash-2.html
       
 46701 
       
 46702         The resulted from an iframe's load event handler removing the iframe
       
 46703         from the document.
       
 46704 
       
 46705         * dom/Document.cpp:
       
 46706         (WebCore::Document::implicitClose): Bail out early if an event handler
       
 46707         removed the frame.
       
 46708         * loader/FrameLoader.cpp:
       
 46709         (WebCore::FrameLoader::FrameLoader):
       
 46710         (WebCore::FrameLoader::clear):
       
 46711         (WebCore::FrameLoader::checkCompleted): Protect the frame from deletion
       
 46712         by event handlers.
       
 46713         (WebCore::FrameLoader::checkCompletedTimerFired):
       
 46714         (WebCore::FrameLoader::scheduleCheckCompleted):
       
 46715         (WebCore::FrameLoader::detachFromParent): Schedule a completion check
       
 46716         on the parent (in case the child is what has been keeping it from completing).
       
 46717         * loader/FrameLoader.h:
       
 46718 
       
 46719 2007-03-08  David Kilzer  <ddkilzer@webkit.org>
       
 46720 
       
 46721         Reviewed by Beth.
       
 46722 
       
 46723         - fix http://bugs.webkit.org/show_bug.cgi?id=13019
       
 46724           REGRESSION (r20074): Forms don't submit on a variety of websites
       
 46725 
       
 46726         No tests added since LayoutTests/fast/forms/document-write.html was timing out
       
 46727         and causing a layout test failure.
       
 46728 
       
 46729         * html/HTMLFormElement.cpp:
       
 46730         (WebCore::HTMLFormElement::submit): Removed stray code.
       
 46731 
       
 46732 2007-03-08  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 46733 
       
 46734         Not reviewed - gdk build fix.
       
 46735 
       
 46736         * platform/graphics/cairo/ImageSourceCairo.cpp:
       
 46737         (WebCore::ImageSource::frameIsCompleteAtIndex): add empty stub
       
 46738 
       
 46739 2007-03-08  Justin Garcia  <justin.garcia@apple.com>
       
 46740 
       
 46741         Reviewed by harrison
       
 46742         
       
 46743         <rdar://problem/4903193> 
       
 46744         On particular page, Copy is so slow it seems like a hang
       
 46745         
       
 46746         ~2x speedup copying:
       
 46747         http://shakespeare.mit.edu/henryviii/full.html 
       
 46748         Also produces less bloated markup.
       
 46749 
       
 46750         * editing/markup.cpp:
       
 46751         (WebCore::startMarkup): Don't wrap text nodes in style spans.
       
 46752         For Elements, don't inline styles inherited from ancestors.
       
 46753         (WebCore::createMarkup): No longer necessary to find 
       
 46754         the root's default style and pass it to startMarkup.
       
 46755         Add a wrapper span around the markup with the styles
       
 46756         that all nodes in the markup inherit (the inheritable 
       
 46757         styles from the common ancestor container's computed style).
       
 46758         Added a FIXME about unecessary markup for inline ancestors 
       
 46759         up to the commonAncestorBlock.
       
 46760 
       
 46761 2007-03-08  Darin Adler  <darin@apple.com>
       
 46762 
       
 46763         Reviewed by Adele.
       
 46764 
       
 46765         - <rdar://problem/4470381> multipart/form-data boundary security vulnerability
       
 46766 
       
 46767         By making the form data boundary a string with some random data in it, we reduce
       
 46768         the possibility that anyone could take advantage of it by creating a file that
       
 46769         intentionally has the boundary string in it.
       
 46770 
       
 46771         * html/HTMLFormElement.h: Removed boundary(), setBoundary(), and m_boundary.
       
 46772         Marked a lot more stuff private.
       
 46773         * html/HTMLFormElement.cpp:
       
 46774         (WebCore::HTMLFormElement::HTMLFormElement): Removed code to initialize
       
 46775         m_boundary.
       
 46776         (WebCore::randomNumber): Added. Function that returns a random number, including
       
 46777         seeding the random number generator the first time it's called. For now, usees the more
       
 46778         random function random() on Mac OS X and the more-standard rand() on other platforms.
       
 46779         (WebCore::HTMLFormElement::formData): Take a parameter with the form boundary string,
       
 46780         and use that instead of m_boundary.
       
 46781         (WebCore::getUniqueBoundaryString): Added. Makes a boundary string using random numbers
       
 46782         and base 64 encoding.
       
 46783         (WebCore::HTMLFormElement::submit): Call getUniqueBoundaryString and pass the boundary
       
 46784         string into formData for multipart form posts.
       
 46785 
       
 46786 2007-03-08  Maciej Stachowiak  <mjs@apple.com>
       
 46787 
       
 46788         Reviewed by Adele.
       
 46789         
       
 46790         <rdar://problem/4646563> REGRESSION: Unable to send text message from Verizon text message website: vtext.com (12588)
       
 46791         http://bugs.webkit.org/show_bug.cgi?id=12588
       
 46792 
       
 46793         Carefully revised which focus operations restore previous selection, which clear it, and which
       
 46794         select the whole control contents.
       
 46795         
       
 46796         Tests:
       
 46797         fast/forms/focus-selection-input.html
       
 46798         fast/forms/focus-selection-textarea.html
       
 46799         
       
 46800         * dom/Element.cpp:
       
 46801         (WebCore::Element::focus):
       
 46802         * dom/Element.h:
       
 46803         * html/HTMLInputElement.cpp:
       
 46804         (WebCore::HTMLInputElement::focus):
       
 46805         (WebCore::HTMLInputElement::accessKeyAction):
       
 46806         * html/HTMLInputElement.h:
       
 46807         * html/HTMLLabelElement.cpp:
       
 46808         (WebCore::HTMLLabelElement::focus):
       
 46809         (WebCore::HTMLLabelElement::accessKeyAction):
       
 46810         * html/HTMLLabelElement.h:
       
 46811         * html/HTMLLegendElement.cpp:
       
 46812         (WebCore::HTMLLegendElement::focus):
       
 46813         * html/HTMLLegendElement.h:
       
 46814         * html/HTMLTextAreaElement.cpp:
       
 46815         (WebCore::HTMLTextAreaElement::focus):
       
 46816         * html/HTMLTextAreaElement.h:
       
 46817         * page/FocusController.cpp:
       
 46818         (WebCore::FocusController::advanceFocus):
       
 46819 
       
 46820 2007-03-08  Justin Garcia  <justin.garcia@apple.com>
       
 46821 
       
 46822         Reviewed by harrison
       
 46823 
       
 46824         <http://bugs.webkit.org/show_bug.cgi?id=12244>
       
 46825         FCKeditor: Find dialog doesn't work
       
 46826 
       
 46827         * bindings/js/kjs_window.cpp:
       
 46828         (KJS::Window::find): Added.  This function doesn't yet 
       
 46829         support whole word searches, searching in subframes, or
       
 46830         opening the find dialog.
       
 46831         (KJS::WindowFunc::callAsFunction):
       
 46832         * bindings/js/kjs_window.h:
       
 46833         (KJS::Window::):
       
 46834 
       
 46835 2007-03-08  David Hyatt  <hyatt@apple.com>
       
 46836 
       
 46837         Fix regression from throwing away frames of large animated images.  Alter
       
 46838         animated images so that they refuse to advance the animation until the
       
 46839         current displayed frame has been fully decoded.
       
 46840 
       
 46841         Reviewed by ggaren
       
 46842 
       
 46843         * platform/graphics/BitmapImage.cpp:
       
 46844         (WebCore::BitmapImage::startAnimation):
       
 46845         (WebCore::BitmapImage::advanceAnimation):
       
 46846         * platform/graphics/ImageSource.h:
       
 46847         * platform/graphics/cg/ImageSourceCG.cpp:
       
 46848         (WebCore::ImageSource::frameIsCompleteAtIndex):
       
 46849 
       
 46850 2007-03-08  David Hyatt  <hyatt@apple.com>
       
 46851 
       
 46852         Fix 2% performance regression on the PLT.  Increase the large animated
       
 46853         image cutoff from 1MB to 5MB.
       
 46854 
       
 46855         In addition when pruning we will aggressively discard image sources.
       
 46856 
       
 46857         Reviewed by ggaren
       
 46858 
       
 46859         * platform/graphics/BitmapImage.cpp:
       
 46860         (WebCore::BitmapImage::destroyDecodedData):
       
 46861 
       
 46862 2007-03-08  Timothy Hatcher  <timothy@apple.com>
       
 46863 
       
 46864         Reviewed by John.
       
 46865 
       
 46866         <rdar://problem/4664697> highlighter SPI needs a node parameter to give more context
       
 46867 
       
 46868         Pass the RenderObject's node to customHighlightLineRect and paintCustomHighlight.
       
 46869 
       
 46870         * page/Frame.h:
       
 46871         * page/mac/FrameMac.mm:
       
 46872         (WebCore::Frame::customHighlightLineRect):
       
 46873         (WebCore::Frame::paintCustomHighlight):
       
 46874         * page/mac/WebCoreFrameBridge.h:
       
 46875         * rendering/InlineTextBox.cpp:
       
 46876         (WebCore::InlineTextBox::paintCustomHighlight):
       
 46877         * rendering/RenderBox.cpp:
       
 46878         (WebCore::RenderBox::paintCustomHighlight):
       
 46879         * rendering/RootInlineBox.cpp:
       
 46880         (WebCore::RootInlineBox::addHighlightOverflow):
       
 46881         (WebCore::RootInlineBox::paintCustomHighlight):
       
 46882 
       
 46883 2007-03-08  Justin Garcia  <justin.garcia@apple.com>
       
 46884 
       
 46885         Reviewed by harrison
       
 46886         
       
 46887         <http://bugs.webkit.org/show_bug.cgi?id=13000>
       
 46888         Range.createContextualFragment is not supported
       
 46889 
       
 46890         * dom/Range.cpp:
       
 46891         (WebCore::Range::createContextualFragment): The
       
 46892         "startContainer" may not be a container, if the
       
 46893         range starts inside text.  In that case, look
       
 46894         to the parent of the start node for an HTMLElement.
       
 46895 
       
 46896 2007-03-08  Justin Garcia  <justin.garcia@apple.com>
       
 46897 
       
 46898         Reviewed by harrison
       
 46899         
       
 46900         <rdar://problem/5049671>
       
 46901         Gmail Editor: With linked text, Remove Formatting doesn't always remove underline
       
 46902 
       
 46903         * editing/Editor.cpp:
       
 46904         (WebCore::Editor::removeFormattingAndStyle): Clear removed
       
 46905         anchors after the deletion.
       
 46906 
       
 46907 2007-03-08  David Kilzer  <ddkilzer@webkit.org>
       
 46908 
       
 46909         Reviewed by NOBODY (build fix).
       
 46910 
       
 46911         Added missing file for r20059:
       
 46912         <rdar://problem/4708689> -- REGRESSION: Some symbols with 2-byte display as garbage in Hotmail.
       
 46913 
       
 46914         File was taken from this svn repository which contained versions of ucnv.h and ucnv_err.h
       
 46915         that were identical to ours:
       
 46916         http://source.icu-project.org/repos/icu/icu/tags/release-3-2/source/common/unicode/ucnv_cb.h
       
 46917 
       
 46918         * icu/unicode/ucnv_cb.h: Added.
       
 46919 
       
 46920 2007-03-08  Shrikant Gangoda  <shrikant.gangoda@celunite.com>
       
 46921 
       
 46922         Gdk build fix.
       
 46923 
       
 46924         * platform/graphics/cairo/ImageSourceCairo.cpp:
       
 46925         (WebCore::ImageSource::~ImageSource):
       
 46926         (WebCore::ImageSource::clear):
       
 46927 
       
 46928 2007-03-08  Oliver Hunt  <oliver@apple.com>
       
 46929 
       
 46930         Reviewed by Adam.
       
 46931 
       
 46932         To match old TEC behaviour when using ICU we need to use 
       
 46933         a few manual fallback encodings for the GBK/EUC-CN charsets
       
 46934 
       
 46935         <rdar://problem/4708689> -- REGRESSION: Some symbols with 2-byte display as garbage in Hotmail.
       
 46936 
       
 46937         * platform/TextCodecICU.cpp:
       
 46938         (WebCore::TextCodecICU::TextCodecICU):
       
 46939         (WebCore::TextCodecICU::createICUConverter):
       
 46940         (WebCore::gbkEscapes):
       
 46941         (WebCore::gbkCallbackEscape):
       
 46942         (WebCore::gbkCallbackSubstitute):
       
 46943         (WebCore::TextCodecICU::encode):
       
 46944         * platform/TextCodecICU.h:
       
 46945         (WebCore::TextCodecICU::needsGBKFallbacks):
       
 46946         (WebCore::TextCodecICU::setNeedsGBKFallbacks):
       
 46947 
       
 46948 2007-03-08  Alexey Proskuryakov  <ap@webkit.org>
       
 46949 
       
 46950         Build fix.
       
 46951 
       
 46952         * xml/XPathUtil.cpp:
       
 46953         (WebCore::XPath::stringValue):
       
 46954 
       
 46955 2007-03-08  David Hyatt  <hyatt@apple.com>
       
 46956 
       
 46957         This patch dramatically reduces the memory consumed by animated images.  For large animated GIFs (defined for
       
 46958         now as >1mb in terms of decoded frame buffer size), we will now aggressively flush previous frames of the
       
 46959         animated GIF and just re-decode them on the fly if the animation loops.
       
 46960 
       
 46961         Whenever a large animated GIF has its animation reset, we will also just throw out everything and start
       
 46962         the animation over (in order to get rid of any cached detritus held in the ImageSource).
       
 46963 
       
 46964         With this patch and the sample GIF used to test, WebKit's memory consumption went from 160MB down to 16MB.
       
 46965 
       
 46966         Reviewed by mjs
       
 46967 
       
 46968         * platform/graphics/BitmapImage.cpp:
       
 46969         (WebCore::BitmapImage::destroyDecodedData):
       
 46970         (WebCore::BitmapImage::resetAnimation):
       
 46971         (WebCore::BitmapImage::advanceAnimation):
       
 46972         * platform/graphics/ImageSource.h:
       
 46973         * platform/graphics/cg/ImageSourceCG.cpp:
       
 46974         (WebCore::ImageSource::~ImageSource):
       
 46975         (WebCore::ImageSource::clear):
       
 46976 
       
 46977 2007-03-08  Alexey Proskuryakov  <ap@webkit.org>
       
 46978 
       
 46979         Reviewed by Darin.
       
 46980 
       
 46981         http://bugs.webkit.org/show_bug.cgi?id=13006
       
 46982         XPath string-value is broken for some node types
       
 46983 
       
 46984         Test: fast/xpath/string-value.html
       
 46985 
       
 46986         * xml/XPathUtil.cpp:
       
 46987         (WebCore::XPath::stringValue): Fix it :-)
       
 46988 
       
 46989 2007-03-07  Anders Carlsson  <acarlsson@apple.com>
       
 46990 
       
 46991         Reviewed by Adam.
       
 46992 
       
 46993         <rdar://problem/4981000> 
       
 46994         http://bugs.webkit.org/show_bug.cgi?id=12634
       
 46995         REGRESSION: crash loading web archive (12634)
       
 46996         
       
 46997         The reason this bug wasn't always reproducible is that it involved sending an event to a plugin while 
       
 46998         the page was loading. Before we send the event to the plugin we defer loads. The problem was that
       
 46999         MainResourceLoader::setDefersLoad would not work with data loads.
       
 47000         
       
 47001         * loader/DocumentLoader.cpp:
       
 47002         (WebCore::DocumentLoader::setRequest):
       
 47003         Only set m_committed to false if we also have a valid unreachable URL.
       
 47004         
       
 47005         * loader/MainResourceLoader.cpp:
       
 47006         (WebCore::MainResourceLoader::setDefersLoading):
       
 47007         Make sure to stop and start data loads.
       
 47008 
       
 47009 2007-03-07  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 47010 
       
 47011         Not reviewed.
       
 47012 
       
 47013         Gdk build fixes.
       
 47014 
       
 47015         * platform/gdk/EditorClientGdk.cpp:
       
 47016         (WebCore::EditorClientGdk::handleKeypress): renamed
       
 47017         (WebCore::EditorClientGdk::handleInputMethodKeypress): add a stub
       
 47018         * platform/gdk/EditorClientGdk.h:
       
 47019         * platform/graphics/cairo/ImageSourceCairo.cpp:
       
 47020         (WebCore::ImageSource::destroyFrameAtIndex): add a stub
       
 47021 
       
 47022 2007-03-07  Alexey Proskuryakov  <ap@webkit.org>
       
 47023 
       
 47024         Reviewed by Darin.
       
 47025 
       
 47026         http://bugs.webkit.org/show_bug.cgi?id=13004
       
 47027         Repeatedly calling XPathExpression.evaluate() causes crashes or memory leaks
       
 47028 
       
 47029         Removed XPath::Expression::optimize() and related methods, since they were buggy and almost useless.
       
 47030         Merged doEvaluate() into evaluate(), since this was all evaluate() was doing after the above changes.
       
 47031 
       
 47032         Test: fast/xpath/evaluate-twice.html
       
 47033 
       
 47034         * xml/XPathExpression.cpp:
       
 47035         (WebCore::XPathExpression::evaluate):
       
 47036         * xml/XPathExpressionNode.cpp:
       
 47037         (WebCore::XPath::Expression::Expression):
       
 47038         (WebCore::XPath::Expression::~Expression):
       
 47039         * xml/XPathExpressionNode.h:
       
 47040         * xml/XPathFunctions.cpp:
       
 47041         (WebCore::XPath::FunLast::evaluate):
       
 47042         (WebCore::XPath::FunPosition::evaluate):
       
 47043         (WebCore::XPath::FunId::evaluate):
       
 47044         (WebCore::XPath::FunLocalName::evaluate):
       
 47045         (WebCore::XPath::FunNamespaceURI::evaluate):
       
 47046         (WebCore::XPath::FunName::evaluate):
       
 47047         (WebCore::XPath::FunCount::evaluate):
       
 47048         (WebCore::XPath::FunString::evaluate):
       
 47049         (WebCore::XPath::FunConcat::evaluate):
       
 47050         (WebCore::XPath::FunStartsWith::evaluate):
       
 47051         (WebCore::XPath::FunContains::evaluate):
       
 47052         (WebCore::XPath::FunSubstringBefore::evaluate):
       
 47053         (WebCore::XPath::FunSubstringAfter::evaluate):
       
 47054         (WebCore::XPath::FunSubstring::evaluate):
       
 47055         (WebCore::XPath::FunStringLength::evaluate):
       
 47056         (WebCore::XPath::FunNormalizeSpace::evaluate):
       
 47057         (WebCore::XPath::FunTranslate::evaluate):
       
 47058         (WebCore::XPath::FunBoolean::evaluate):
       
 47059         (WebCore::XPath::FunNot::evaluate):
       
 47060         (WebCore::XPath::FunTrue::evaluate):
       
 47061         (WebCore::XPath::FunLang::evaluate):
       
 47062         (WebCore::XPath::FunFalse::evaluate):
       
 47063         (WebCore::XPath::FunNumber::evaluate):
       
 47064         (WebCore::XPath::FunSum::evaluate):
       
 47065         (WebCore::XPath::FunFloor::evaluate):
       
 47066         (WebCore::XPath::FunCeiling::evaluate):
       
 47067         (WebCore::XPath::FunRound::evaluate):
       
 47068         * xml/XPathPath.cpp:
       
 47069         (WebCore::XPath::Filter::evaluate):
       
 47070         (WebCore::XPath::LocationPath::evaluate):
       
 47071         (WebCore::XPath::Path::evaluate):
       
 47072         * xml/XPathPath.h:
       
 47073         * xml/XPathPredicate.cpp:
       
 47074         (WebCore::XPath::Number::evaluate):
       
 47075         (WebCore::XPath::StringExpression::evaluate):
       
 47076         (WebCore::XPath::Negative::evaluate):
       
 47077         (WebCore::XPath::NumericOp::evaluate):
       
 47078         (WebCore::XPath::EqTestOp::evaluate):
       
 47079         (WebCore::XPath::LogicalOp::evaluate):
       
 47080         (WebCore::XPath::Union::evaluate):
       
 47081         * xml/XPathPredicate.h:
       
 47082         * xml/XPathStep.cpp:
       
 47083         * xml/XPathStep.h:
       
 47084         * xml/XPathVariableReference.cpp:
       
 47085         (WebCore::XPath::VariableReference::evaluate):
       
 47086         * xml/XPathVariableReference.h:
       
 47087 
       
 47088 2007-03-07  Sam Weinig  <sam@webkit.org>
       
 47089 
       
 47090         Reviewed by Tim H.
       
 47091 
       
 47092         Remove unused #import from Objective-C bindings and cleanup the order of #imports.
       
 47093 
       
 47094         * bindings/scripts/CodeGeneratorObjC.pm:
       
 47095 
       
 47096 2007-03-07  Sam Weinig  <sam@webkit.org>
       
 47097 
       
 47098         Reviewed by Tim H.
       
 47099 
       
 47100         Make sure the baseURI attribute generates for private Objective-C bindings.
       
 47101 
       
 47102         * dom/Node.idl:
       
 47103 
       
 47104 2007-03-07  Anders Carlsson  <acarlsson@apple.com>
       
 47105 
       
 47106         Reviewed by Maciej.
       
 47107 
       
 47108         <rdar://problem/4874059>
       
 47109         REGRESSION: Painter IX:register - Crash in WebCore:: ResourceLoader::willSendRequest()
       
 47110 
       
 47111         If a load is done from inside of an error delegate method that is called because we cancel another load, 
       
 47112         the first load should be ignored since this is what shipping WebKit does. 
       
 47113         
       
 47114         (Actually, it does load the page in the data source but doesn't do anything with it since the data source
       
 47115         won't have a web frame).
       
 47116         
       
 47117         * loader/FrameLoader.cpp:
       
 47118         (WebCore::FrameLoader::load):
       
 47119         Just bail out if m_isStoppingLoad is true.
       
 47120 
       
 47121 2007-03-07  David Hyatt  <hyatt@apple.com>
       
 47122 
       
 47123         Use CGImageRelease instead of CFRelease.
       
 47124 
       
 47125         Reviewed by aroben
       
 47126 
       
 47127         * platform/graphics/cg/ImageCG.cpp:
       
 47128         (WebCore::FrameData::clear):
       
 47129         * platform/graphics/cg/ImageSourceCG.cpp:
       
 47130         (WebCore::ImageSource::destroyFrameAtIndex):
       
 47131 
       
 47132 2007-03-07  David Hyatt  <hyatt@apple.com>
       
 47133 
       
 47134         Fix a regression where the cache size overflows because of a double
       
 47135         subtraction per resource when they got removed from the cache.  Add an
       
 47136         assert to adjustSize to detect this case in the future.
       
 47137 
       
 47138         Fix ImageSourceCG so that when we flush decoded data from our cache that
       
 47139         we also flush it from the ImageSource.
       
 47140 
       
 47141         Reviewed by mjs
       
 47142 
       
 47143         * loader/Cache.cpp:
       
 47144         (WebCore::Cache::adjustSize):
       
 47145         * platform/graphics/BitmapImage.cpp:
       
 47146         (WebCore::BitmapImage::~BitmapImage):
       
 47147         (WebCore::BitmapImage::destroyDecodedData):
       
 47148         * platform/graphics/Image.h:
       
 47149         * platform/graphics/ImageSource.h:
       
 47150         * platform/graphics/cg/ImageSourceCG.cpp:
       
 47151         (WebCore::ImageSource::setData):
       
 47152         (WebCore::ImageSource::destroyFrameAtIndex):
       
 47153 
       
 47154 2007-03-07  Mitz Pettel  <mitz@webkit.org>
       
 47155 
       
 47156         Reviewed by Darin.
       
 47157 
       
 47158         - fix http://bugs.webkit.org/show_bug.cgi?id=13002
       
 47159           Incomplete repaint of inset outlines
       
 47160 
       
 47161         Test: fast/repaint/outline-inset.html
       
 47162 
       
 47163         * rendering/RenderObject.cpp:
       
 47164         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
       
 47165 
       
 47166 2007-03-07  Oliver Hunt  <oliver@apple.com>
       
 47167 
       
 47168         Reviewed by Antti.
       
 47169 
       
 47170         Reset mouse down/drag state variables on mouse button release
       
 47171         
       
 47172         Fixes <rdar://problem/5044654>: Drag out of some QuickTime plug-ins converting into image drag
       
 47173 
       
 47174         * page/EventHandler.cpp:
       
 47175         (WebCore::EventHandler::handleMouseReleaseEvent):
       
 47176 
       
 47177 2007-03-07  Adele Peterson  <adele@apple.com>
       
 47178 
       
 47179         Reviewed by Darin.
       
 47180 
       
 47181         WebCore part of fix for:
       
 47182         http://bugs.webkit.org/show_bug.cgi?id=10871
       
 47183         http://bugs.webkit.org/show_bug.cgi?id=12677
       
 47184         <rdar://problem/4823129> REGRESSION: IME key events different in nightly
       
 47185         <rdar://problem/4759563> REGRESSION: Return key is always sent when you confirm a clause in kotoeri
       
 47186 
       
 47187         * page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): Call handleInputMethodKeypress before actually dispatching the keypress event
       
 47188           so that input methods have a chance to handle the event.  
       
 47189           If the input method handles the event (by marking or unmarking text), then we don't need to send the keypress event.
       
 47190           If an input method doesn't handle the event, then we'll save the data we need to perform the correct action (like what text to insert or what selector to use) 
       
 47191           when we dispatch the keypress event.
       
 47192 
       
 47193         * dom/KeyboardEvent.h: Added Mac-specific KeypressCommand struct, so we can store command info during handleInputMethodKeypress, and use it during handleKeypress.
       
 47194         (WebCore::KeyboardEvent::keypressCommand):
       
 47195         (WebCore::KeyboardEvent::setKeypressCommand):
       
 47196 
       
 47197         * bridge/EditorClient.h:
       
 47198         * editing/Editor.cpp:
       
 47199         (WebCore::Editor::handleKeypress): Changed handleKeyPress to handleKeypress.
       
 47200         (WebCore::Editor::handleInputMethodKeypress): Added.
       
 47201         * editing/Editor.h:
       
 47202 
       
 47203         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 47204         (WebCore::SVGEmptyEditorClient::handleKeypress): Changed handleKeyPress to handleKeypress.
       
 47205         (WebCore::SVGEmptyEditorClient::handleInputMethodKeypress): Added.
       
 47206 
       
 47207 2007-03-07  Rob Buis  <buis@kde.org>
       
 47208 
       
 47209         Reviewed by Darin.
       
 47210 
       
 47211         http://bugs.webkit.org/show_bug.cgi?id=12579
       
 47212         WebKit fails SVG xml:base test
       
 47213 
       
 47214         Implement DOM3 properties baseURI and documentURI to fix
       
 47215         the testcase in bug 12579.
       
 47216 
       
 47217         * bindings/js/kjs_dom.cpp:
       
 47218         (KJS::DOMNode::getValueProperty):
       
 47219         * bindings/js/kjs_domnode.h:
       
 47220         (KJS::DOMNode::):
       
 47221         * dom/Document.cpp:
       
 47222         (WebCore::Document::documentURI):
       
 47223         (WebCore::Document::setDocumentURI):
       
 47224         (WebCore::Document::baseURI):
       
 47225         * dom/Document.h:
       
 47226         * dom/Document.idl:
       
 47227         * dom/DocumentType.cpp:
       
 47228         (WebCore::DocumentType::baseURI):
       
 47229         * dom/DocumentType.h:
       
 47230         * dom/Element.cpp:
       
 47231         (WebCore::Element::baseURI):
       
 47232         * dom/Element.h:
       
 47233         * dom/Node.cpp:
       
 47234         (WebCore::Node::baseURI):
       
 47235         * dom/Node.h:
       
 47236         * ksvg2/misc/SVGImageLoader.cpp:
       
 47237         (WebCore::SVGImageLoader::updateFromElement):
       
 47238         * ksvg2/svg/SVGImageElement.cpp:
       
 47239         (WebCore::SVGImageElement::parseMappedAttribute):
       
 47240         (WebCore::SVGImageElement::attach):
       
 47241 
       
 47242 2007-03-07  Anders Carlsson  <acarlsson@apple.com>
       
 47243 
       
 47244         Reviewed by Brady.
       
 47245 
       
 47246         Remove some methods in FrameLoader that just calls down to the active document loader. Since each
       
 47247         resource loader now has a pointer to its document loader, we can just call directly to the
       
 47248         document loader.
       
 47249 
       
 47250         * WebCore.exp:
       
 47251         * loader/FrameLoader.cpp:
       
 47252         * loader/FrameLoader.h:
       
 47253         * loader/MainResourceLoader.cpp:
       
 47254         (WebCore::MainResourceLoader::willSendRequest):
       
 47255         (WebCore::MainResourceLoader::didReceiveResponse):
       
 47256         * loader/SubresourceLoader.cpp:
       
 47257         (WebCore::SubresourceLoader::SubresourceLoader):
       
 47258         (WebCore::SubresourceLoader::didFinishLoading):
       
 47259         (WebCore::SubresourceLoader::didFail):
       
 47260         (WebCore::SubresourceLoader::didCancel):
       
 47261         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
       
 47262         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
       
 47263         (WebCore::NetscapePlugInStreamLoader::didFail):
       
 47264         (WebCore::NetscapePlugInStreamLoader::didCancel):
       
 47265 
       
 47266 2007-03-06  Geoffrey Garen  <ggaren@apple.com>
       
 47267 
       
 47268         Reviewed by Maciej Stachowiak.
       
 47269         
       
 47270         Fixed <rdar://problem/4576242> | http://bugs.webkit.org/show_bug.cgi?id=12586
       
 47271         PAC file: malloc deadlock sometimes causes a hang @ www.apple.com/pro/profiles/ (12586)
       
 47272         
       
 47273         No test because this is very difficult to repro, and the new ASSERTs in 
       
 47274         JavaScriptCore catch the underlying cause while running normal layout tests.
       
 47275         
       
 47276         This is a modified version of r14752 on the branch.
       
 47277         
       
 47278         The fix is to use a bit inside each node, instead of a hash table, to track 
       
 47279         which node subtrees are in the process of being marked. This avoids a call 
       
 47280         to malloc inside mark().
       
 47281         
       
 47282         * bindings/js/kjs_binding.cpp:
       
 47283         (KJS::domObjects):
       
 47284         (KJS::domNodesPerDocument):
       
 47285         * bindings/js/kjs_dom.cpp:
       
 47286         (KJS::DOMNode::mark):
       
 47287         * dom/Node.cpp:
       
 47288         (WebCore::Node::Node):
       
 47289         * dom/Node.h:
       
 47290 
       
 47291 2007-03-06  David Hyatt  <hyatt@apple.com>
       
 47292 
       
 47293         This patch reworks the WebCore memory cache to significantly reduce the amount of memory consumed by
       
 47294         images in the cache and to enhance the accuracy of the cache size as an absolute bound for the objects
       
 47295         contained within it.  WebCore's memory use over time should significantly improve as a result of these
       
 47296         changes.
       
 47297 
       
 47298         Cached resources now have both an encoded size (the original data stream) and a decoded size (an estimate of
       
 47299         the amount of memory consumed by an expanded version of that resource, e.g., the decoded frames of an image).
       
 47300         Both sizes now count towards the total size of the object and towards the allowed memory cache total.
       
 47301 
       
 47302         By including both totals the reported size of resources will now be larger, and the cache will therefore become
       
 47303         much more aggressive about flushing.
       
 47304 
       
 47305         Objects are stored in size-adjusted and popularity-aware LRU lists as before, but encoded size is now always
       
 47306         used when determining the correct LRU list.
       
 47307 
       
 47308         The flush algorithm for the memory cache has been rewritten to first destroy decoded data before evicting
       
 47309         resources.  By being able to compact its resources without evicting them, the memory cache can now hold many more
       
 47310         unique resources (encoded) in the same amount of space.  Depending on how much of a hit we want to take from
       
 47311         re-decoding images, the memory cache could in theory have its size significantly reduced now while still holding
       
 47312         more resources than it did at the larger size!
       
 47313 
       
 47314         Reviewed by mjs
       
 47315 
       
 47316         * WebCore.xcodeproj/project.pbxproj:
       
 47317         * loader/Cache.cpp:
       
 47318         (WebCore::Cache::requestResource):
       
 47319         (WebCore::Cache::prune):
       
 47320         (WebCore::Cache::remove):
       
 47321         (WebCore::Cache::lruListFor):
       
 47322         (WebCore::Cache::adjustSize):
       
 47323         * loader/Cache.h:
       
 47324         * loader/CachedCSSStyleSheet.cpp:
       
 47325         (WebCore::CachedCSSStyleSheet::data):
       
 47326         * loader/CachedImage.cpp:
       
 47327         (WebCore::CachedImage::CachedImage):
       
 47328         (WebCore::CachedImage::allReferencesRemoved):
       
 47329         (WebCore::CachedImage::clear):
       
 47330         (WebCore::CachedImage::data):
       
 47331         (WebCore::CachedImage::destroyDecodedData):
       
 47332         (WebCore::CachedImage::decodedSize):
       
 47333         (WebCore::CachedImage::decodedSizeChanged):
       
 47334         (WebCore::CachedImage::shouldPauseAnimation):
       
 47335         * loader/CachedImage.h:
       
 47336         * loader/CachedResource.cpp:
       
 47337         (WebCore::CachedResource::CachedResource):
       
 47338         (WebCore::CachedResource::deref):
       
 47339         (WebCore::CachedResource::setEncodedSize):
       
 47340         * loader/CachedResource.h:
       
 47341         (WebCore::CachedResource::allReferencesRemoved):
       
 47342         (WebCore::CachedResource::size):
       
 47343         (WebCore::CachedResource::encodedSize):
       
 47344         (WebCore::CachedResource::decodedSize):
       
 47345         (WebCore::CachedResource::destroyDecodedData):
       
 47346         * loader/CachedScript.cpp:
       
 47347         (WebCore::CachedScript::data):
       
 47348         * loader/CachedXSLStyleSheet.cpp:
       
 47349         (WebCore::CachedXSLStyleSheet::data):
       
 47350         * platform/graphics/BitmapImage.cpp:
       
 47351         (WebCore::BitmapImage::BitmapImage):
       
 47352         (WebCore::BitmapImage::~BitmapImage):
       
 47353         (WebCore::BitmapImage::destroyDecodedData):
       
 47354         (WebCore::BitmapImage::pruneDecodedDataIfNeeded):
       
 47355         (WebCore::BitmapImage::cacheFrame):
       
 47356         (WebCore::BitmapImage::setNativeData):
       
 47357         (WebCore::BitmapImage::shouldAnimate):
       
 47358         (WebCore::BitmapImage::advanceAnimation):
       
 47359         * platform/graphics/BitmapImage.h:
       
 47360         (WebCore::BitmapImage::decodedSize):
       
 47361         * platform/graphics/Image.cpp:
       
 47362         (WebCore::Image::Image):
       
 47363         * platform/graphics/Image.h:
       
 47364         (WebCore::Image::destroyDecodedData):
       
 47365         (WebCore::Image::decodedSize):
       
 47366         (WebCore::Image::imageObserver):
       
 47367         * platform/graphics/ImageAnimationObserver.h: Removed.
       
 47368         * platform/graphics/ImageObserver.h: Added.
       
 47369         (WebCore::ImageObserver::~ImageObserver):
       
 47370         * platform/graphics/svg/SVGImage.cpp:
       
 47371         (WebCore::SVGImage::SVGImage):
       
 47372         * platform/graphics/svg/SVGImage.h:
       
 47373 
       
 47374 2007-03-06  Alexey Proskuryakov  <ap@webkit.org>
       
 47375 
       
 47376         Reviewed by Sam Weinig.
       
 47377 
       
 47378         http://bugs.webkit.org/show_bug.cgi?id=12987
       
 47379         Fix and import 4XPath test_numeric_expr.html
       
 47380 
       
 47381         * xml/XPathPredicate.cpp:
       
 47382         (WebCore::XPath::Negative::doEvaluate): Convert the argument to number.
       
 47383         (WebCore::XPath::NumericOp::doEvaluate): Convert the arguments to numbers. Use a correct operation for mod.
       
 47384         * xml/XPathStep.cpp:
       
 47385         (WebCore::XPath::Step::nodesInAxis): Do not append parent node if there is none.
       
 47386         * xml/XPathValue.cpp:
       
 47387         (WebCore::XPath::Value::toNumber): Do not convert to DeprecatedString just to trim whitespace and to convert to double.
       
 47388         * platform/DeprecatedString.cpp:
       
 47389         (WebCore::DeprecatedStringData::makeAscii): Added a FIXME about unreliable makeAscii() behavior.
       
 47390 
       
 47391 2007-03-06  Maciej Stachowiak  <mjs@apple.com>
       
 47392 
       
 47393         Reviewed by Adele.
       
 47394 
       
 47395         <rdar://problem/4619663> REGRESSION (NativePopup): Popup menu doesn't draw at the correct vertical position (9816)
       
 47396         
       
 47397         * platform/mac/PopupMenuMac.mm:
       
 47398         (WebCore::PopupMenu::show): Make a temporary dummy view with the
       
 47399         passed in rect, since AppKit will use the view bounds to determine
       
 47400         what area to exclude when popping up a menu moved to the top of
       
 47401         the screen.
       
 47402 
       
 47403 2007-03-06  Geoffrey Garen  <ggaren@apple.com>
       
 47404 
       
 47405         Reviewed by Maciej Stachowiak.
       
 47406 
       
 47407         Fixed all known crashers exposed by run-webkit-tests --threaded [*]. See 
       
 47408         JavaScriptCore ChangeLog for more details.
       
 47409 
       
 47410         * bindings/js/kjs_binding.cpp:
       
 47411         (KJS::domNodesPerDocument): Added thread safety ASSERT.
       
 47412         (KJS::ScriptInterpreter::mark): Removed obsolete logic for marking unsafe
       
 47413         objects when collecting on a secondary thread. The Collector takes care
       
 47414         of this now.
       
 47415 
       
 47416         * bindings/js/kjs_binding.h:
       
 47417         (KJS::DOMObject::DOMObject): Used new API for specifying that WebCore
       
 47418         objects should be garbage collected on the main thread only.
       
 47419 
       
 47420         * bindings/js/kjs_window.cpp:
       
 47421         (KJS::ScheduledAction::execute): Moved JSLock to cover implementedsCall() call,
       
 47422         which, for some subclasses, ends up allocating garbage collected objects.
       
 47423         (This fix was speculative. I didn't actually see a crash from this.)
       
 47424         (KJS::Window::timerFired): Added JSLock around ScheduleAction destruction,
       
 47425         since it destroys a KJS::List.
       
 47426 
       
 47427         * bindings/objc/WebScriptObject.mm:
       
 47428         (-[WebScriptObject setException:]): Added JSLock. (This fix was speculative. 
       
 47429         I didn't actually see a crash from this.)
       
 47430 
       
 47431         * bridge/mac/WebCoreScriptDebugger.mm:
       
 47432         (-[WebCoreScriptCallFrame evaluateWebScript:]): Added JSLock. (This fix 
       
 47433         was speculative. I didn't actually see a crash from this.)
       
 47434 
       
 47435         * dom/Document.cpp:
       
 47436         (WebCore::Document::~Document): Added JSLock around modification to 
       
 47437         domNodesPerDocument(), which can be accessed concurrently during garbage 
       
 47438         collection.
       
 47439         * dom/Node.cpp:
       
 47440         (WebCore::Node::setDocument): ditto.
       
 47441         
       
 47442         [*] fast/js/toString-stack-overflow.html is an exception. --threaded mode
       
 47443         crashes this test because it causes the garbage collector to run frequently,
       
 47444         and this test crashes if you happen to garbage collect while it's running.
       
 47445         This is a known issue with stack overflow during the mark phase. It's
       
 47446         not related to threading.
       
 47447 
       
 47448 2007-03-06  Mark Rowe  <mrowe@apple.com>
       
 47449 
       
 47450         Reviewed by Sam Weinig.
       
 47451 
       
 47452         Fix http://bugs.webkit.org/show_bug.cgi?id=12942
       
 47453         Bug 12942: ASSERTION FAILURE: qantas.com.au changing selected item in <select> via JS
       
 47454 
       
 47455         Test: fast/dom/select-selectedIndex-bug-12942.html.
       
 47456 
       
 47457         * html/HTMLSelectElement.cpp:
       
 47458         (WebCore::HTMLSelectElement::recalcListItems): Reset m_lastOnChangeIndex when recalculating list items.
       
 47459         * html/HTMLSelectElement.h:
       
 47460 
       
 47461 2007-03-06  Brady Eidson  <beidson@apple.com>
       
 47462 
       
 47463         Rubberstamped by Kevin Decker
       
 47464 
       
 47465         20,000!
       
 47466 
       
 47467         * ChangeLog: Point out revision 20,000
       
 47468 
       
 47469 2007-03-06  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 47470 
       
 47471         Not reviewed.
       
 47472 
       
 47473         Gdk build fix.
       
 47474 
       
 47475         * loader/gdk/FrameLoaderClientGdk.cpp: update userAgent() signature.
       
 47476         (WebCore::FrameLoaderClientGdk::userAgent):
       
 47477         * loader/gdk/FrameLoaderClientGdk.h: ditto.
       
 47478 
       
 47479 2007-03-06  Mitz Pettel  <mitz@webkit.org>
       
 47480 
       
 47481         Reviewed by Adele.
       
 47482 
       
 47483         - fix http://bugs.webkit.org/show_bug.cgi?id=12986
       
 47484           REGRESSION(NativeListBox): Listboxes not updated when resized dynamically
       
 47485 
       
 47486         Test: fast/forms/select-change-listbox-size.html
       
 47487 
       
 47488         * html/HTMLSelectElement.cpp:
       
 47489         (WebCore::HTMLSelectElement::parseMappedAttribute): Reattach on list box size change.
       
 47490 
       
 47491 2007-03-06  Mitz Pettel  <mitz@webkit.org>
       
 47492 
       
 47493         Reviewed by Dave Hyatt.
       
 47494 
       
 47495         - fix http://bugs.webkit.org/show_bug.cgi?id=12885
       
 47496           REGRESSION (r19696): Incomplete background repaint
       
 47497 
       
 47498         Tests: fast/repaint/content-into-overflow.html
       
 47499                fast/repaint/overflow-into-content.html
       
 47500 
       
 47501         Changed repaintAfterLayoutIfNeeded() to take, in addition to the clipped overflow
       
 47502         rect, the unclipped border box plus outline, and to repaint any areas that
       
 47503         were added or removed from that box, in addition to any areas added or removed
       
 47504         from the clipped overflow rect.
       
 47505 
       
 47506         * platform/graphics/svg/SVGResourceMarker.cpp:
       
 47507         (WebCore::SVGResourceMarker::draw):
       
 47508         * rendering/RenderBlock.cpp:
       
 47509         (WebCore::RenderBlock::layoutBlock):
       
 47510         * rendering/RenderBox.cpp:
       
 47511         (WebCore::RenderBox::absoluteClippedOverflowRect): Renamed getAbsoluteRepaintRect() to
       
 47512         this.
       
 47513         * rendering/RenderBox.h:
       
 47514         * rendering/RenderFlexibleBox.cpp:
       
 47515         (WebCore::RenderFlexibleBox::layoutBlock):
       
 47516         * rendering/RenderFlow.cpp:
       
 47517         (WebCore::RenderFlow::absoluteClippedOverflowRect):
       
 47518         * rendering/RenderFlow.h:
       
 47519         * rendering/RenderForeignObject.cpp:
       
 47520         (WebCore::RenderForeignObject::layout):
       
 47521         * rendering/RenderHTMLCanvas.cpp:
       
 47522         (WebCore::RenderHTMLCanvas::layout):
       
 47523         * rendering/RenderImage.cpp:
       
 47524         (WebCore::RenderImage::layout):
       
 47525         * rendering/RenderLayer.cpp:
       
 47526         (WebCore::RenderLayer::RenderLayer):
       
 47527         (WebCore::RenderLayer::checkForRepaintOnResize):
       
 47528         (WebCore::RenderLayer::updateLayerPositions):
       
 47529         * rendering/RenderLayer.h:
       
 47530         * rendering/RenderObject.cpp:
       
 47531         (WebCore::RenderObject::repaint):
       
 47532         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
       
 47533         (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
       
 47534         (WebCore::RenderObject::absoluteClippedOverflowRect):
       
 47535         (WebCore::RenderObject::absoluteOutlineBox):
       
 47536         * rendering/RenderObject.h:
       
 47537         * rendering/RenderPath.cpp:
       
 47538         (WebCore::RenderPath::layout):
       
 47539         (WebCore::RenderPath::absoluteClippedOverflowRect):
       
 47540         (WebCore::RenderPath::absoluteRects):
       
 47541         (WebCore::RenderPath::drawMarkersIfNeeded):
       
 47542         * rendering/RenderPath.h:
       
 47543         * rendering/RenderSVGContainer.cpp:
       
 47544         (WebCore::RenderSVGContainer::layout):
       
 47545         (WebCore::RenderSVGContainer::absoluteClippedOverflowRect):
       
 47546         (WebCore::RenderSVGContainer::absoluteRects):
       
 47547         * rendering/RenderSVGContainer.h:
       
 47548         * rendering/RenderSVGHiddenContainer.cpp:
       
 47549         (WebCore::RenderSVGHiddenContainer::absoluteClippedOverflowRect):
       
 47550         * rendering/RenderSVGHiddenContainer.h:
       
 47551         * rendering/RenderSVGImage.cpp:
       
 47552         (WebCore::RenderSVGImage::imageChanged):
       
 47553         (WebCore::RenderSVGImage::absoluteClippedOverflowRect):
       
 47554         (WebCore::RenderSVGImage::absoluteRects):
       
 47555         * rendering/RenderSVGImage.h:
       
 47556         * rendering/RenderSVGText.cpp:
       
 47557         (WebCore::RenderSVGText::absoluteClippedOverflowRect):
       
 47558         (WebCore::RenderSVGText::layout):
       
 47559         (WebCore::RenderSVGText::absoluteRects):
       
 47560         * rendering/RenderSVGText.h:
       
 47561         * rendering/RenderTable.cpp:
       
 47562         (WebCore::RenderTable::layout):
       
 47563         * rendering/RenderTableCell.cpp:
       
 47564         (WebCore::RenderTableCell::absoluteClippedOverflowRect):
       
 47565         * rendering/RenderTableCell.h:
       
 47566         * rendering/RenderTableCol.cpp:
       
 47567         (WebCore::RenderTableCol::absoluteClippedOverflowRect):
       
 47568         * rendering/RenderTableCol.h:
       
 47569         * rendering/RenderTableRow.cpp:
       
 47570         (WebCore::RenderTableRow::absoluteClippedOverflowRect):
       
 47571         * rendering/RenderTableRow.h:
       
 47572         * rendering/RenderText.cpp:
       
 47573         (WebCore::RenderText::absoluteClippedOverflowRect):
       
 47574         * rendering/RenderText.h:
       
 47575 
       
 47576 2007-03-06  Ian Eng <ian.eng.webkit@gmail.com>
       
 47577 
       
 47578         Reviewed by Maciej.
       
 47579 
       
 47580         - fixed http://bugs.webkit.org/show_bug.cgi?id=12720
       
 47581         Bug 12720: Re-defining window.location.toString function keeps re-loading forever
       
 47582 
       
 47583         * bindings/js/kjs_window.cpp:
       
 47584         Disallow replacing functions in LocationTable, and return early without updating URL.
       
 47585 
       
 47586 2007-03-06  Kevin McCullough  <kmccullough@apple.com>
       
 47587 
       
 47588         Reviewed by Darin.
       
 47589 
       
 47590         <http://bugs.webkit.org/show_bug.cgi?id=12686>
       
 47591         REGRESSION: Bloglines.com Feeds tab cannot expand folders in TOT
       
 47592         - Now all class constructors implement implementsHasInstance.
       
 47593 
       
 47594         * bindings/scripts/CodeGeneratorJS.pm:
       
 47595 
       
 47596 2007-03-07  Nikolas Zimmermann  <zimmermann@kde.org>
       
 47597 
       
 47598         Reviewed by Rob & Oliver.
       
 47599 
       
 47600         Preparations for the new SVG text engine.
       
 47601 
       
 47602         Handle baseline-shift / kerning css values correctly.
       
 47603         Recognize missing svg presentation attribute "font-size-adjust".
       
 47604         Add all missing svg<->css property mappings in mapToEntry().
       
 47605 
       
 47606         Doesn't affect any layout test (as these properties are not used w/o my text patch).
       
 47607         While I'm at it, unify the macro names (RS_ -> SVG_RS_) & cleanup style a bit.
       
 47608 
       
 47609         * ksvg2/css/CSSPropertyNames.in:
       
 47610         * ksvg2/css/SVGCSSParser.cpp:
       
 47611         (WebCore::CSSParser::parseSVGValue):
       
 47612         * ksvg2/css/SVGCSSStyleSelector.cpp:
       
 47613         (WebCore::CSSStyleSelector::applySVGProperty):
       
 47614         * ksvg2/css/SVGRenderStyle.cpp:
       
 47615         (WebCore::SVGRenderStyle::SVGRenderStyle):
       
 47616         (WebCore::SVGRenderStyle::operator==):
       
 47617         (WebCore::SVGRenderStyle::inheritedNotEqual):
       
 47618         (WebCore::SVGRenderStyle::inheritFrom):
       
 47619         * ksvg2/css/SVGRenderStyle.h:
       
 47620         (WebCore::SVGRenderStyle::NonInheritedFlags::):
       
 47621         (WebCore::SVGRenderStyle::setBitDefaults):
       
 47622         * ksvg2/css/SVGRenderStyleDefs.cpp:
       
 47623         (StyleTextData::StyleTextData):
       
 47624         (StyleTextData::operator==):
       
 47625         (StyleMiscData::StyleMiscData):
       
 47626         (StyleMiscData::operator==):
       
 47627         * ksvg2/css/SVGRenderStyleDefs.h:
       
 47628         (WebCore::):
       
 47629         (WebCore::StyleTextData::operator!=):
       
 47630         * ksvg2/svg/SVGStyledElement.cpp:
       
 47631         (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
       
 47632 
       
 47633 2007-03-06  Justin Garcia  <justin.garcia@apple.com>
       
 47634 
       
 47635         Reviewed by kevin
       
 47636         
       
 47637         <http://bugs.webkit.org/show_bug.cgi?id=12245>
       
 47638         FCKeditor: Remove Format sometimes doesn't work
       
 47639         <rdar://problem/4786404>
       
 47640         Underline style is not removed from selection after performing Remove Format
       
 47641 
       
 47642         * editing/Editor.cpp:
       
 47643         (WebCore::Editor::removeFormattingAndStyle): Re-wrote this.
       
 47644 
       
 47645 2007-03-07  Nikolas Zimmermann  <zimmermann@kde.org>
       
 47646 
       
 47647         Reviewed by Oliver.
       
 47648 
       
 47649         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12979
       
 47650         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12981
       
 47651 
       
 47652         Guard against registering pending resources with empty id.
       
 47653         Be careful with calling recalcStyle() in SVGUseElement, when change is "Detach" we
       
 47654         have to use special code, as calling attach() on the shadow tree root element will crash,
       
 47655         because it has no (direct) parent node, only a shadow parent node element.
       
 47656 
       
 47657         * ksvg2/misc/SVGDocumentExtensions.cpp:
       
 47658         (WebCore::SVGDocumentExtensions::addPendingResource):
       
 47659         * ksvg2/svg/SVGUseElement.cpp:
       
 47660         (WebCore::SVGUseElement::recalcStyle):
       
 47661 
       
 47662 2007-03-06  Kevin Decker  <kdecker@apple.com>
       
 47663 
       
 47664         Reviewed by Adele.
       
 47665 
       
 47666         Fixed: <rdar://problem/5041660> REGRESSION: <keygen> element broken, prevents users from signing up for Thawte email certs
       
 47667         
       
 47668         * bindings/objc/DOM.mm:
       
 47669         (WebCore::createElementClassMap): Added <keygen> to the DOM bindings so it can be accessed from Objective-C.
       
 47670         * css/html4.css: Apply the look of the <select> element to <keygen>.
       
 47671         * html/HTMLElementFactory.cpp:
       
 47672         (WebCore::keygenConstructor): Added. 
       
 47673         (WebCore::createFunctionMap): Added keygen.
       
 47674         * html/HTMLSelectElement.cpp: Made const typeAheadTimeout variable static const. 
       
 47675         (WebCore::HTMLSelectElement::HTMLSelectElement):  Fix both HTMLSelectElement constructors to initialize the
       
 47676          same number of member variables. The fact that some fields were not initialized could (and would) crash the
       
 47677          keygen element when selecting different items. Also removed m_typedString(String()) from the constructor
       
 47678          initialization because this is not needed.
       
 47679 
       
 47680 2007-03-06  Kevin McCullough  <kmccullough@apple.com>
       
 47681 
       
 47682         Reviewed by Darin.
       
 47683 
       
 47684         - Rename a function to clarify its purpose.
       
 47685 
       
 47686         * WebCore.exp:
       
 47687         * loader/FrameLoader.cpp:
       
 47688         (WebCore::FrameLoader::registerURLSchemeAsLocal):
       
 47689         * loader/FrameLoader.h:
       
 47690 
       
 47691 2007-03-06  Adam Roben  <aroben@apple.com>
       
 47692 
       
 47693         Build fix.
       
 47694 
       
 47695         * WebCore.exp: Updated symbols.
       
 47696 
       
 47697 2007-03-06  Adam Roben  <aroben@apple.com>
       
 47698 
       
 47699         Reviewed by Anders.
       
 47700 
       
 47701         Added a parameter to all StringTruncator methods to specify whether
       
 47702         rounding hacks should be on or off.
       
 47703 
       
 47704         No layout test possible.
       
 47705 
       
 47706         * platform/StringTruncator.cpp:
       
 47707         (WebCore::stringWidth): Added disableRoundingHacks parameter.
       
 47708         (WebCore::truncateString): Ditto.
       
 47709         (WebCore::StringTruncator::centerTruncate): Ditto.
       
 47710         (WebCore::StringTruncator::rightTruncate): Ditto.
       
 47711         (WebCore::StringTruncator::width): Ditto.
       
 47712         * platform/StringTruncator.h: Ditto.
       
 47713         * platform/mac/FileChooserMac.mm:
       
 47714         (WebCore::FileChooser::basenameForWidth): Pass in false to
       
 47715         centerTruncate so that the truncation matches the way the text will be
       
 47716         rendered.
       
 47717 
       
 47718 2007-03-06  Anders Carlsson  <acarlsson@apple.com>
       
 47719 
       
 47720         Reviewed by Maciej.
       
 47721 
       
 47722         <rdar://problem/5035045>
       
 47723         REGRESSION: WebKit browser doesn't display image at http://www.metoffice.gov.uk/weather/satellite/index.html
       
 47724         
       
 47725         It turns out WinIE does allow you to access images by their id as special document properties. However, this is only
       
 47726         allowed when the element also has a name attribute. The value of the name attribute is ignored and can even be empty!
       
 47727         
       
 47728         * bindings/js/kjs_html.cpp:
       
 47729         (KJS::JSHTMLDocument::namedItemGetter):
       
 47730         Return jsUndefined() if the collection is empty.
       
 47731         
       
 47732         * html/HTMLImageElement.cpp:
       
 47733         (WebCore::HTMLImageElement::parseMappedAttribute):
       
 47734         (WebCore::HTMLImageElement::insertedIntoDocument):
       
 47735         (WebCore::HTMLImageElement::removedFromDocument):
       
 47736         * html/HTMLImageElement.h:
       
 47737         Add the id attribute value to the extra named item map.
       
 47738         
       
 47739         * html/HTMLNameCollection.cpp:
       
 47740         (WebCore::HTMLNameCollection::traverseNextItem):
       
 47741         Check for images with name attributes that match, as well as elements with id attributes that match where
       
 47742         the element also has a name attribute.
       
 47743 
       
 47744 2007-03-06  Anders Carlsson  <acarlsson@apple.com>
       
 47745 
       
 47746         Reviewed by Adam.
       
 47747 
       
 47748         WebCore part of patch to make it possible to have different user agents for different URLs.
       
 47749 
       
 47750         * bindings/js/kjs_navigator.cpp:
       
 47751         (KJS::Navigator::getValueProperty):
       
 47752         * bindings/js/kjs_proxy.cpp:
       
 47753         (WebCore::KJSProxy::initScriptIfNeeded):
       
 47754         * loader/DocumentLoader.cpp:
       
 47755         (WebCore::DocumentLoader::setLoading):
       
 47756         * loader/FrameLoader.cpp:
       
 47757         (WebCore::FrameLoader::userAgent):
       
 47758         (WebCore::FrameLoader::loadResourceSynchronously):
       
 47759         (WebCore::FrameLoader::applyUserAgent):
       
 47760         * loader/FrameLoader.h:
       
 47761         * loader/FrameLoaderClient.h:
       
 47762         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 47763         (WebCore::SVGEmptyFrameLoaderClient::userAgent):
       
 47764 
       
 47765 2007-03-05  Kevin McCullough  <kmccullough@apple.com>
       
 47766 
       
 47767         Reviewed by Mark and Dave H.
       
 47768 
       
 47769         - rdar://problem/5038491
       
 47770         An oversight of the security fix that prevented remote from loading local is that it
       
 47771         prevents user style sheets when the site is remote.  This fixes that.
       
 47772 
       
 47773         * loader/Cache.cpp: Propogate and check user style sheet flag.
       
 47774         (WebCore::createResource):
       
 47775         (WebCore::Cache::requestResource):
       
 47776         * loader/Cache.h: Propogate user style sheet flag.
       
 47777         * loader/CachedCSSStyleSheet.cpp: Propogate user style sheet flag.
       
 47778         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
       
 47779         * loader/CachedCSSStyleSheet.h: Propogate user style sheet flag.
       
 47780         * loader/DocLoader.cpp: Propogate user style sheet flag.
       
 47781         (WebCore::DocLoader::requestResource):
       
 47782         * loader/SubresourceLoader.cpp: Propogate and check user style sheet flag.
       
 47783         (WebCore::SubresourceLoader::create):
       
 47784         * loader/SubresourceLoader.h: Add check for user style sheet flag.
       
 47785         * loader/loader.cpp: Propogate user style sheet flag.
       
 47786         (WebCore::Loader::load):
       
 47787         (WebCore::Loader::servePendingRequests):
       
 47788         * loader/loader.h: Propogate user style sheet flag.
       
 47789 
       
 47790 2007-03-06  Nikolas Zimmermann  <zimmermann@kde.org>
       
 47791 
       
 47792         Reviewed by Darin.
       
 47793 
       
 47794         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12936 (Master bug used to track all current use problems.)
       
 47795 
       
 47796         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12926 (transform attribute not respected in nested <use> elements)
       
 47797         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12267 (getElementById broken for <use>)
       
 47798         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12916 (use instance in symbol definition does not work)
       
 47799         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12917 (mouseout event does not occur after scaling use instance)
       
 47800         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12838 (SVG <use> DOM broken for script)
       
 47801 
       
 47802         Added test: svg/custom/use-nested-transform.svg
       
 47803         Added test: svg/custom/struct-use-09-b.svg (not yet official W3C-SVG-1.1 testcase)
       
 47804         Fixes test: svg/custom/use-elementInstance-event-target.svg (rectangle now turns green on first click)
       
 47805 
       
 47806         Fix all (except one) known <use> bug. The remaining bug (12630) is not crucical at all.
       
 47807         Enable <use> again as default SVG feature, as discussed on webkit-dev.
       
 47808 
       
 47809         dom/Element.cpp needed following tweak: set hasParentStyle to true, if there is no parentNode
       
 47810         available - which happens for <use> nodes, as it's a shadow node. This fixes recalcStyle behaviour.
       
 47811         Override recalcStyle() in SVGUseElement, and properly forward the call to the shadow tree root element.
       
 47812         The shadow tree now receives proper style updates (without having to recreate the whole tree!).
       
 47813 
       
 47814         Override attributeChanged() in SVGUseElement and only call notifyAttributeChange if one of x/y/width/height/xlink:href
       
 47815         attribute changed - otherwhise we'll end up recreating the tree for every transform/style/(non-existing-attribute) change.
       
 47816 
       
 47817         Do not override transform in nested use situations, but correctly append (right-sided) the translation of the <use> element.
       
 47818         Some cosmetic fixes: don't add transform="translate(0 0)" attributes if both x/y values are null in the shadow tree.
       
 47819 
       
 47820         Factor out logic for replacing symbol/svg tags in the shadow tree, and also invoke it during expandUseElementsInShadowTree -
       
 47821         otherwhise <symbol><use xlink:href="#someOtherSymbol"></symbol> the <use> gets expanded to a <symbol>. Though no one expands
       
 47822         the <symbol> element - and we're end up in hitting an assertion. Avoid that.
       
 47823 
       
 47824         * bindings/js/JSSVGElementWrapperFactory.cpp:
       
 47825         * bindings/js/kjs_dom.cpp:
       
 47826         (KJS::toJS):
       
 47827         * bindings/objc/DOM.mm:
       
 47828         (WebCore::createElementClassMap):
       
 47829         * dom/Element.cpp:
       
 47830         (WebCore::Element::recalcStyle):
       
 47831         * ksvg2/svg/SVGElement.cpp:
       
 47832         (WebCore::shadowTreeParentElementForShadowTreeElement):
       
 47833         (WebCore::SVGElement::dispatchEvent):
       
 47834         * ksvg2/svg/SVGElementInstance.cpp:
       
 47835         * ksvg2/svg/SVGElementInstance.h:
       
 47836         * ksvg2/svg/SVGElementInstance.idl:
       
 47837         * ksvg2/svg/SVGElementInstanceList.cpp:
       
 47838         * ksvg2/svg/SVGElementInstanceList.h:
       
 47839         * ksvg2/svg/SVGElementInstanceList.idl:
       
 47840         * ksvg2/svg/SVGStyledElement.cpp:
       
 47841         (WebCore::SVGStyledElement::notifyAttributeChange):
       
 47842         (WebCore::SVGStyledElement::updateElementInstance):
       
 47843         * ksvg2/svg/SVGStyledElement.h:
       
 47844         * ksvg2/svg/SVGUseElement.cpp:
       
 47845         (WebCore::SVGUseElement::attributeChanged):
       
 47846         (WebCore::SVGUseElement::notifyAttributeChange):
       
 47847         (WebCore::SVGUseElement::recalcStyle):
       
 47848         (WebCore::SVGUseElement::buildPendingResource):
       
 47849         (WebCore::SVGUseElement::buildShadowTreeForSymbolTag):
       
 47850         (WebCore::SVGUseElement::alterShadowTreeForSVGTag):
       
 47851         (WebCore::SVGUseElement::buildShadowTree):
       
 47852         (WebCore::SVGUseElement::expandUseElementsInShadowTree):
       
 47853         (WebCore::SVGUseElement::attachShadowTree):
       
 47854         * ksvg2/svg/SVGUseElement.h:
       
 47855         * ksvg2/svg/SVGUseElement.idl:
       
 47856         * ksvg2/svg/svgtags.in:
       
 47857 
       
 47858 2007-03-05  Brady Eidson  <beidson@apple.com>
       
 47859 
       
 47860         Reviewed by John
       
 47861 
       
 47862         Fixes <rdar://problem/4974258>
       
 47863         Adds some key null checking
       
 47864 
       
 47865         * bindings/js/kjs_html.cpp:
       
 47866         (KJS::JSHTMLElement::implementsCall): Null check doc/frame
       
 47867         * bindings/objc/DOMInternal.mm:
       
 47868         (-[WebScriptObject _initializeScriptDOMNodeImp]): Null check doc/frame
       
 47869 
       
 47870 2007-03-06  Nikolas Zimmermann  <zimmermann@kde.org>
       
 47871 
       
 47872         Reviewed by Darin.
       
 47873 
       
 47874         Path::normalAngleAtLength() / Path::pointAtLength() don't work correctly.
       
 47875         pointAtLength() was not implemented, basically and normalAngleAtLength()
       
 47876         had a bug in the tangent slope calculation.
       
 47877 
       
 47878         The normalAngleAtLength() stuff can only be tested with my local textPath support.
       
 47879         New LayoutTest: svg/custom/path-textPath-simulation.svg
       
 47880 
       
 47881         * platform/graphics/Path.cpp:
       
 47882         (WebCore::pathLengthApplierFunction):
       
 47883         * platform/graphics/PathTraversalState.cpp:
       
 47884         (WebCore::PathTraversalState::quadraticBezierTo):
       
 47885         (WebCore::PathTraversalState::cubicBezierTo):
       
 47886         * platform/graphics/PathTraversalState.h:
       
 47887         (WebCore::PathTraversalState::):
       
 47888 
       
 47889 2007-03-05  Alexey Proskuryakov  <ap@webkit.org>
       
 47890 
       
 47891         Reviewed by Darin.
       
 47892 
       
 47893         http://bugs.webkit.org/show_bug.cgi?id=12970
       
 47894         Fix and import 4XPath test_core_functions.html test
       
 47895 
       
 47896         * xml/XPathExpression.cpp:
       
 47897         (WebCore::XPathExpression::evaluate): Fully initialize the evaluation context.
       
 47898 
       
 47899         * xml/XPathFunctions.cpp:
       
 47900         (WebCore::XPath::FunSubstring::doEvaluate): Fixed handling of edge cases.
       
 47901         (WebCore::XPath::FunRound::round): Reimplemented to match the spec; exposed FunRound::round() to be used in
       
 47902         other functions.
       
 47903 
       
 47904 2007-03-05  Alexey Proskuryakov  <ap@webkit.org>
       
 47905 
       
 47906         Reviewed by Darin.
       
 47907 
       
 47908         http://bugs.webkit.org/show_bug.cgi?id=12954
       
 47909         XPath relative operations are implemented incorrectly
       
 47910 
       
 47911         * xml/XPathPredicate.cpp:
       
 47912         (WebCore::XPath::NumericOp::doEvaluate):
       
 47913         (WebCore::XPath::EqTestOp::compare):
       
 47914         (WebCore::XPath::EqTestOp::doEvaluate):
       
 47915         Reimplemented relative equality operations to match the spec.
       
 47916 
       
 47917         * xml/XPathPredicate.h:
       
 47918         (WebCore::XPath::NumericOp::):
       
 47919         (WebCore::XPath::EqTestOp::):
       
 47920         Moved relative operations to EqTestOp.
       
 47921 
       
 47922         * xml/XPathGrammar.y:
       
 47923         * xml/XPathParser.cpp:
       
 47924         (WebCore::XPath::Parser::nextTokenInternal):
       
 47925         (WebCore::XPath::Parser::lex):
       
 47926         Adapted for the above changes.
       
 47927 
       
 47928 2007-03-05  Mark Rowe  <mrowe@apple.com>
       
 47929 
       
 47930         Reviewed by Lars.
       
 47931 
       
 47932         Fix http://bugs.webkit.org/show_bug.cgi?id=12947
       
 47933         Bug 12947: REGRESSION: ASSERTION FAILED: maxWidth >= 0 in StringTruncator.cpp:109 in WebCore::truncateString()
       
 47934 
       
 47935         Handle nil window correctly in toUserSpace and toDeviceSpace.  On Intel Macs a message to nil that returns a
       
 47936         float will return 0.0.  We use this as the divisor in calculating a scale factor, which results in NaN being
       
 47937         introduced into our rect.
       
 47938 
       
 47939         * platform/mac/ScreenMac.mm:
       
 47940         (WebCore::toUserSpace):
       
 47941         (WebCore::toDeviceSpace):
       
 47942 
       
 47943 2007-03-05  Rob Buis  <buis@kde.org>
       
 47944 
       
 47945         Reviewed by Darin.
       
 47946 
       
 47947         http://bugs.webkit.org/show_bug.cgi?id=12868
       
 47948         parts of the CSS classes in this simple SVG example are not applied
       
 47949 
       
 47950         Make sure the xml stylesheets are parsed in strict mode.
       
 47951 
       
 47952         * dom/ProcessingInstruction.cpp:
       
 47953         (WebCore::ProcessingInstruction::parseStyleSheet):
       
 47954 
       
 47955 2007-03-04  Adele Peterson  <adele@apple.com>
       
 47956 
       
 47957         Reviewed by Darin.
       
 47958 
       
 47959         Change to dispatch the keypress event during the defaultEventHandler for keydown events.  This matches IE behavior.
       
 47960         This is preparation for fixing event dispatch with input methods (http://bugs.webkit.org/show_bug.cgi?id=10871)
       
 47961 
       
 47962         Test: fast/events/keydown-keypress-preventDefault.html
       
 47963 
       
 47964         * dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Call the defaultKeyboardEventHandler for keydown events.
       
 47965         * page/EventHandler.cpp:
       
 47966         (WebCore::eventTargetNodeForDocument): Return 0 instead of false since the return type in EventTargetNode.
       
 47967         (WebCore::EventHandler::keyEvent): Removed dispatch of keypress event, since this is now done in the default event handler.
       
 47968         (WebCore::EventHandler::defaultKeyboardEventHandler): For keydown events, create and dispatch a keypress event.
       
 47969 
       
 47970 2007-03-04  Alexey Proskuryakov  <ap@webkit.org>
       
 47971 
       
 47972         Reviewed by Nikolas Zimmermann (yay!).
       
 47973 
       
 47974         http://bugs.webkit.org/show_bug.cgi?id=12962
       
 47975         4XPath tests crash on lang() function
       
 47976 
       
 47977         Covered by 4XPath tests, to be landed later.
       
 47978 
       
 47979         * platform/StringImpl.cpp:
       
 47980         (WebCore::StringImpl::reverseFind): Do not crash with empty strings.
       
 47981         * xml/XPathFunctions.cpp:
       
 47982         (WebCore::XPath::FunLang::doEvaluate): Do not crash when an element has no
       
 47983         attributes. Use a proper namespace for xml:lang (not sure where "xms" came from).
       
 47984         Rewrote the algorithm for suffix removing to match the spec.
       
 47985 
       
 47986 2007-03-02  Anders Carlsson  <acarlsson@apple.com>
       
 47987 
       
 47988         Reviewed by Darin.
       
 47989 
       
 47990         <rdar://problem/5028165> 
       
 47991         http://bugs.webkit.org/show_bug.cgi?id=12915
       
 47992         REGRESSION: XMLHttpRequest.abort() does not stop loading (12915)
       
 47993         
       
 47994         * loader/DocumentLoader.cpp:
       
 47995         (WebCore::DocumentLoader::stopLoading):
       
 47996         Save the value of m_loading since calling FrameLoader::stopLoading could set it to false.
       
 47997         
       
 47998         * loader/SubresourceLoader.cpp:
       
 47999         (WebCore::SubresourceLoader::didCancel):
       
 48000         * loader/SubresourceLoader.h:
       
 48001         Get rid of didCancel now, it's not needed anymore.
       
 48002         
       
 48003         * xml/xmlhttprequest.cpp:
       
 48004         (WebCore::XMLHttpRequest::abort):
       
 48005         Call cancel() instead of stopLoading(). Also, set m_aborted to true so the XMLHttpRequest object
       
 48006         won't be dereferenced in didFail when aborting.
       
 48007 
       
 48008 2007-03-04  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 48009 
       
 48010         Reviewed by Nikolas Zimmermann.
       
 48011 
       
 48012         Move ScrollView stubs to ScrollViewGdk.cpp
       
 48013 
       
 48014         * platform/gdk/FrameGdk.h: remove comment that no longer makes sense
       
 48015         * platform/gdk/ScrollViewGdk.cpp:
       
 48016         (WebCore::ScrollView::addChild):
       
 48017         (WebCore::ScrollView::removeChild):
       
 48018         (WebCore::ScrollView::scrollPointRecursively):
       
 48019         (WebCore::ScrollView::inWindow):
       
 48020         (WebCore::ScrollView::wheelEvent):
       
 48021         (WebCore::ScrollView::updateScrollbars):
       
 48022         (WebCore::ScrollView::updateScrollInfo):
       
 48023         (WebCore::ScrollView::windowToContents):
       
 48024         (WebCore::ScrollView::contentsToWindow):
       
 48025         (WebCore::ScrollView::scrollbarUnderMouse):
       
 48026         * platform/gdk/TemporaryLinkStubs.cpp:
       
 48027 
       
 48028 2007-03-02  Kevin McCullough  <kmccullough@apple.com>
       
 48029 
       
 48030         Reviewed by Geoff.
       
 48031 
       
 48032         - rdar://problem/4922454
       
 48033         - This fixes a security issue by making remote referrers not able to access local
       
 48034         resources, unless they register their schemes to be treated as local. The result is
       
 48035         that those schemes can access local resources and cannot be accessed by remote
       
 48036         referrers.
       
 48037         Because this behavior is new a link-on-or-after check is made to determine if the
       
 48038         app should use the older, less safe, behavior.
       
 48039 
       
 48040         * WebCore.exp: added exported functions
       
 48041         * bindings/objc/DOM.mm: consolodated function to base class
       
 48042         (-[DOMElement image]):
       
 48043         (-[DOMElement _imageTIFFRepresentation]):
       
 48044         * dom/Document.cpp: Cache the document's ability to load local resources.
       
 48045         (WebCore::Document::Document):
       
 48046         (WebCore::Document::setURL):
       
 48047         (WebCore::Document::shouldBeAllowedToLoadLocalResources):
       
 48048         (WebCore::Document::stylesheetLoaded):
       
 48049         * dom/Document.h: Cache the docuent's ability to load local resources.
       
 48050         (WebCore::Document::getPendingSheet):
       
 48051         (WebCore::Document::isAllowedToLoadLocalResources):
       
 48052         * html/HTMLImageLoader.cpp: Moved functionality into base class.
       
 48053         (WebCore::HTMLImageLoader::updateFromElement):
       
 48054         (WebCore::HTMLImageLoader::dispatchLoadEvent):
       
 48055         * html/HTMLLinkElement.cpp: Handles null returns correctly now.
       
 48056         * html/HTMLTokenizer.cpp: Moved functionality into base class.
       
 48057         (WebCore::HTMLTokenizer::notifyFinished):
       
 48058         * ksvg2/misc/SVGImageLoader.cpp: Moved functionality into base class.
       
 48059         (WebCore::SVGImageLoader::dispatchLoadEvent):
       
 48060         * loader/Cache.cpp: Checks if the cached resource can be loaded.
       
 48061         (WebCore::Cache::requestResource):
       
 48062         * loader/CachedCSSStyleSheet.cpp: Moved functionality into base class.
       
 48063         (WebCore::CachedCSSStyleSheet::ref):
       
 48064         (WebCore::CachedCSSStyleSheet::error):
       
 48065         * loader/CachedImage.cpp: Moved functionality into base class.
       
 48066         (WebCore::CachedImage::CachedImage):
       
 48067         * loader/CachedImage.h: Moved functionality into base class.
       
 48068         (WebCore::CachedImage::canRender):
       
 48069         * loader/CachedResource.cpp: Cache if the CachedResource should be treated as local
       
 48070         (WebCore::CachedResource::CachedResource):
       
 48071         * loader/CachedResource.h: Moved functionality into base class.
       
 48072         (WebCore::CachedResource::errorOccurred):
       
 48073         (WebCore::CachedResource::shouldTreatAsLocal):
       
 48074         * loader/CachedScript.cpp: Moved functionality into base class.
       
 48075         (WebCore::CachedScript::CachedScript):
       
 48076         * loader/CachedScript.h: Moved functionality into base class.
       
 48077         (WebCore::CachedScript::schedule):
       
 48078         * loader/CachedXBLDocument.cpp: Moved functionality into base class.
       
 48079         (WebCore::CachedXBLDocument::error):
       
 48080         * loader/CachedXSLStyleSheet.cpp: Moved functionality into base class.
       
 48081         (WebCore::CachedXSLStyleSheet::error):
       
 48082         * loader/FrameLoader.cpp: See comments for each function below.
       
 48083         (WebCore::FrameLoader::loadSubframe): Use new canLoad.
       
 48084         (WebCore::FrameLoader::restrictAccessToLocal): return value of linked-on-or-after check.
       
 48085         (WebCore::FrameLoader::setRestrictAccessToLocal): set value for linked-on-or-after check.
       
 48086         (WebCore::localSchemes): Return set of schemes that are to be treated as local.
       
 48087         (WebCore::FrameLoader::loadPlugin): Use new canLoad.
       
 48088         (WebCore::FrameLoader::canLoad): Now multiple functions that each do the same work but some can take advantage of the cached values, if they were computed previously.
       
 48089         (WebCore::FrameLoader::shouldHideReferrer): Extracted out the logic to determine if the referrer should be hidden so it is only calculated when needed.
       
 48090         (WebCore::FrameLoader::loadResourceSynchronously): No longer calls canLoad to get hideReferrer info.
       
 48091         (WebCore::FrameLoader::registerSchemeAsLocal): Functionality to register a scheme to be treated as local.
       
 48092         (WebCore::FrameLoader::treatURLAsLocal): Given a URL this function determines if it should be treated as local.
       
 48093         * loader/FrameLoader.h: Declared functions for this security fix.  See above.
       
 48094         * loader/MainResourceLoader.cpp: Optized order of bools to regain performance.
       
 48095         (WebCore::MainResourceLoader::continueAfterContentPolicy):
       
 48096         * loader/SubresourceLoader.cpp: Now restricts remote from loading local resources.
       
 48097         (WebCore::SubresourceLoader::create):
       
 48098         * page/EventHandler.cpp: Moved functionality into base class.
       
 48099         (WebCore::selectCursor):
       
 48100         * platform/KURL.cpp: KURLs need to check all the registered schemes now.
       
 48101         (WebCore::KURL::isLocalFile):
       
 48102         * rendering/HitTestResult.cpp: Moved functionality into base class.
       
 48103         (WebCore::HitTestResult::image):
       
 48104         * rendering/RenderImage.cpp: Moved functionality into base class.
       
 48105         (WebCore::RenderImage::setCachedImage):
       
 48106         (WebCore::RenderImage::imageChanged):
       
 48107         (WebCore::RenderImage::paint):
       
 48108         (WebCore::RenderImage::layout):
       
 48109         (WebCore::RenderImage::calcAspectRatioWidth):
       
 48110         (WebCore::RenderImage::calcAspectRatioHeight):
       
 48111         * rendering/RenderImage.h: Moved functionality into base class.
       
 48112         (WebCore::RenderImage::errorOccurred):
       
 48113         * rendering/RenderListItem.cpp: Moved functionality into base class.
       
 48114         (WebCore::RenderListItem::setStyle):
       
 48115         * rendering/RenderListMarker.cpp: Moved functionality into base class.
       
 48116         (WebCore::RenderListMarker::isImage):
       
 48117         * xml/xmlhttprequest.cpp: Check doc's cached value instead of determining independently.
       
 48118         (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
       
 48119 
       
 48120 2007-03-02  Justin Garcia  <justin.garcia@apple.com>
       
 48121 
       
 48122         Reviewed by kevin
       
 48123         
       
 48124         <rdar://problem/5028447>
       
 48125         REGRESSION: Gmail Editor: Copied message text pastes at the wrong font size
       
 48126 
       
 48127         * editing/markup.cpp:
       
 48128         (WebCore::createMarkup): The style of the div that holds
       
 48129         a fully selected body's styles didn't include styles inherited
       
 48130         from the body's ancestors.
       
 48131         
       
 48132 2007-03-02  Justin Garcia  <justin.garcia@apple.com>
       
 48133 
       
 48134         Reviewed by harrison
       
 48135 
       
 48136         <rdar://problem/4545040>
       
 48137         innerHTML does not HTML-escape text nodes inside PRE elements
       
 48138         <rdar://problem/5027857>
       
 48139         Pasting into Mail from Safari's view-source window renders the HTML
       
 48140 
       
 48141         * editing/HTMLInterchange.cpp:
       
 48142         (WebCore::convertHTMLTextToInterchangeFormat): Send this function
       
 48143         the node that the text comes from as a parameter.  It shouldn't convert
       
 48144         '\n's to spaces/nbsps if the text is coming from text where newlines are
       
 48145         preserved.
       
 48146         * editing/HTMLInterchange.h:
       
 48147         * editing/markup.cpp:
       
 48148         (WebCore::startMarkup): Escape text inside the children of PREs.
       
 48149 
       
 48150 2007-03-02  Sam Weinig  <sam@webkit.org>
       
 48151 
       
 48152         Reviewed by Anders.
       
 48153 
       
 48154         Try to fix the Qt build.
       
 48155 
       
 48156         * platform/qt/TemporaryLinkStubs.cpp: Add stubs.
       
 48157         (WebCore::searchMenuNoRecentSearchesText):
       
 48158         (WebCore::searchMenuRecentSearchesText):
       
 48159         (WebCore::searchMenuClearRecentSearchesText):
       
 48160         (WebCore::AXWebAreaText):
       
 48161         (WebCore::AXLinkText):
       
 48162         (WebCore::AXListMarkerText):
       
 48163         (WebCore::AXImageMapText):
       
 48164         (WebCore::AXHeadingText):
       
 48165 
       
 48166 2007-03-02  David Harrison  <harrison@apple.com>
       
 48167 
       
 48168         Suggested by Darin.
       
 48169 
       
 48170         A more efficient solution to rdar://4961431.
       
 48171 
       
 48172         * bridge/mac/WebCoreAXObject.mm:
       
 48173         (-[WebCoreAXObject accessibilityIsIgnored]):
       
 48174 
       
 48175 2007-03-01  Justin Garcia  <justin.garcia@apple.com>
       
 48176 
       
 48177         Reviewed by john
       
 48178         
       
 48179         <rdar://problem/5032095>
       
 48180         Gmail Editor: Copied text pastes on a new line instead of current line
       
 48181         
       
 48182         Start merge failed to occur because positionAtStartOfInsertedContent
       
 48183         had a bug.
       
 48184 
       
 48185         * editing/ReplaceSelectionCommand.cpp:
       
 48186         (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent):
       
 48187         Was failing when inserting <span><div>foo/div></span>. Return the 
       
 48188         inserted content's first VisiblePosition.
       
 48189 
       
 48190 2007-03-02  Dave Hyatt  <hyatt@apple.com>
       
 48191 
       
 48192         Fix crasher in glyph map code (buffer overrun).
       
 48193 
       
 48194         Reviewed by darin
       
 48195 
       
 48196         * platform/win/GlyphPageTreeNodeWin.cpp:
       
 48197         (WebCore::GlyphPage::fill):
       
 48198 
       
 48199 2007-03-01  Antti Koivisto  <antti@apple.com>
       
 48200 
       
 48201         Reviewed by Maciej.
       
 48202 
       
 48203         Fix for http://bugs.webkit.org/show_bug.cgi?id=12895
       
 48204         REGRESSION: imagemap: pointer cursor is shown everywhere
       
 48205         <rdar://problem/5028163>
       
 48206  
       
 48207         Image with imagemap should never itself be URLElement in hit test results. 
       
 48208                
       
 48209         No layout test, cursor state can't be captured.
       
 48210 
       
 48211         * rendering/RenderLayer.cpp:
       
 48212         (WebCore::RenderLayer::hitTest):
       
 48213 
       
 48214 2007-03-01  Antti Koivisto  <antti@apple.com>
       
 48215 
       
 48216         Reviewed by Maciej.
       
 48217         
       
 48218         Fix http://bugs.webkit.org/show_bug.cgi?id=12690
       
 48219         REGRESSION: can not log in to bank of america with TOT webkit
       
 48220         <rdar://problem/4990044>
       
 48221         
       
 48222         and http://bugs.webkit.org/show_bug.cgi?id=12604
       
 48223         REGRESSION: After closing the "Would you like to save password" sheet, the form fails 
       
 48224         to submit automatically at http://www.mac.com/WebObjects/HomePage.woa
       
 48225         <rdar://problem/4871752>
       
 48226         
       
 48227         and http://bugs.webkit.org/show_bug.cgi?id=12020
       
 48228         REGRESSION: Flickr uploading broken
       
 48229         <rdar://problem/4928662>
       
 48230         
       
 48231         Turn protection against multiple forms submission back on. This approach is buggy 
       
 48232         but it is way better than not having it at all. Not protecting against this
       
 48233         breaks number of major sites.
       
 48234         
       
 48235         * bridge/mac/WebCoreAXObject.mm:
       
 48236         (-[WebCoreAXObject accessibilityPerformAction:]):
       
 48237         * loader/FrameLoader.cpp:
       
 48238         (WebCore::FrameLoader::resetMultipleFormSubmissionProtection):
       
 48239         (WebCore::FrameLoader::submitForm):
       
 48240         (WebCore::FrameLoader::receivedMainResourceError):
       
 48241         * loader/FrameLoader.h:
       
 48242         * page/EventHandler.cpp:
       
 48243         (WebCore::EventHandler::keyEvent):
       
 48244         * page/Frame.cpp:
       
 48245         (WebCore::Frame::setView):
       
 48246         * page/mac/EventHandlerMac.mm:
       
 48247         (WebCore::EventHandler::mouseDown):
       
 48248 
       
 48249 2007-03-01  Kevin McCullough  <kmccullough@apple.com>
       
 48250 
       
 48251         Reviewed by Adam.
       
 48252 
       
 48253         - Added the test case: external-script-URL-location.html
       
 48254         - Fix an issue where the url of a document is null after an open if the document
       
 48255         has no parent.
       
 48256 
       
 48257         * dom/Document.cpp:
       
 48258         (WebCore::Document::open):
       
 48259 
       
 48260 2007-03-01  Anders Carlsson  <acarlsson@apple.com>
       
 48261 
       
 48262         Reviewed by Darin.
       
 48263 
       
 48264         <rdar://problem/4960250> 
       
 48265         http://bugs.webkit.org/show_bug.cgi?id=11627
       
 48266         REGRESSION: Reproducible crash at IMDb in WebCore::FrameLoader::stopLoadingSubframes
       
 48267         
       
 48268         In rare cases, we could end up calling checkLoadComplete twice for the same frame. This would cause the 
       
 48269         didFailProvisionalLoad delegate method to be called twice for the same frame, and also cause the provisional document loader
       
 48270         to be reset to null when other code wasn't expecting it.
       
 48271         
       
 48272         This regressed in revision 10904 with the fix for <rdar://problem/4184719>. The fix is to only call stopLoading on the frame
       
 48273         if either the document loader is loading, or the document is still being parsed. I've verified that the bug is still fixed and
       
 48274         that no leaks occur.
       
 48275         
       
 48276         * loader/DocumentLoader.cpp:
       
 48277         (WebCore::DocumentLoader::stopLoading):
       
 48278 
       
 48279 2007-03-01  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 48280 
       
 48281         Reviewed by Darin.
       
 48282 
       
 48283         Fix ARM crash due to accessing non-4-byte-aligned memory
       
 48284         as 32-bit values.
       
 48285 
       
 48286         * platform/AtomicString.cpp:
       
 48287         (WebCore::UCharBufferTranslator::equal):
       
 48288 
       
 48289 2007-03-01  David Harrison  <harrison@apple.com>
       
 48290 
       
 48291         Reviewed by Darin.
       
 48292 
       
 48293         <rdar://problem/5033905> Have the DOM secondary thread check raise an exception by default
       
 48294 
       
 48295         * platform/mac/ThreadCheck.mm:
       
 48296         (WebCore::_WebCoreThreadViolationCheck):
       
 48297         Initialize threadViolationIsException to true.
       
 48298 
       
 48299 2007-03-01  Brady Eidson  <beidson@apple.com>
       
 48300 
       
 48301         Reviewed by Darin
       
 48302 
       
 48303         <rdar://problem/5030628> - Crash opening a new window with the
       
 48304         "New windows open to the same page" pref set
       
 48305 
       
 48306         * history/HistoryItem.cpp:
       
 48307         (WebCore::HistoryItem::HistoryItem): Set the m_subItems vector capacity correctly
       
 48308 
       
 48309 2007-03-01  Alexey Proskuryakov  <ap@webkit.org>
       
 48310 
       
 48311         Reviewed by Maciej.
       
 48312 
       
 48313         http://bugs.webkit.org/show_bug.cgi?id=12801
       
 48314         Assertion failure in createMarkup() (root) when doing Select All, Copy in an SVG document
       
 48315 
       
 48316         Test: editing/pasteboard/createMarkup-assert.xml
       
 48317 
       
 48318         * editing/markup.cpp:
       
 48319         (WebCore::createMarkup): Removed the assertion, because it's wrong in a non-HTML world.
       
 48320 
       
 48321 2007-02-28  Adam Roben  <aroben@apple.com>
       
 48322 
       
 48323         Reviewed by Oliver and Hyatt.
       
 48324 
       
 48325         Fix <rdar://problem/5024233> Crash while using Find on empty document
       
 48326 
       
 48327         No layout test possible, as this involves a null document.
       
 48328 
       
 48329         * dom/Range.cpp:
       
 48330         (WebCore::rangeOfContents): Added an ASSERT.
       
 48331         * page/Frame.cpp:
       
 48332         (WebCore::Frame::findString): Added a null-check for document().
       
 48333         (WebCore::Frame::markAllMatchesForText): Ditto.
       
 48334 
       
 48335 2007-02-28  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 48336 
       
 48337         Not reviewed - simple gdk build fix.
       
 48338 
       
 48339         Add stubs for newly introduced localized strings.
       
 48340 
       
 48341         * platform/gdk/TemporaryLinkStubs.cpp:
       
 48342         (WebCore::searchMenuNoRecentSearchesText):
       
 48343         (WebCore::searchMenuRecentSearchesText):
       
 48344         (WebCore::searchMenuClearRecentSearchesText):
       
 48345 
       
 48346 2007-02-28  Brady Eidson  <beidson@apple.com>
       
 48347 
       
 48348         Reviewed by Beth
       
 48349 
       
 48350         Move the Thread Safety Check functions into their own header for export to WebKit
       
 48351 
       
 48352         * WebCore.exp: Export the function
       
 48353         * WebCore.xcodeproj/project.pbxproj: 
       
 48354         * bindings/scripts/CodeGeneratorObjC.pm: Include the new header
       
 48355         * platform/Logging.h: Move stuff to ThreadCheck.h
       
 48356         * platform/ThreadCheck.h: Added.
       
 48357         * platform/mac/LoggingMac.mm: Move stuff to ThreadCheck.mm
       
 48358         * platform/mac/ThreadCheck.mm: Added.
       
 48359         (WebCore::_WebCoreThreadViolationCheck):
       
 48360         (WebCoreReportThreadViolation):
       
 48361 
       
 48362 2007-02-28  Beth Dakin  <bdakin@apple.com>
       
 48363 
       
 48364         Reviewed by Brady.
       
 48365 
       
 48366         Fix for http://bugs.webkit.org/show_bug.cgi?id=12923 REGRESSION: 
       
 48367         Assertion failure copying standalone image
       
 48368 
       
 48369         * platform/mac/PasteboardMac.mm:
       
 48370         (WebCore::Pasteboard::writeImage): Use the CachedImage as the 
       
 48371         resource. This makes more sense anyway. There is no need to null-
       
 48372         check the renderer or the CachedImage since we return early if 
       
 48373         there is no Image* and the HitTestResult::image() function checks 
       
 48374         for these things.
       
 48375 
       
 48376 2007-02-28  Adele Peterson  <adele@apple.com>
       
 48377 
       
 48378         Reviewed by Beth.
       
 48379 
       
 48380         Fix for <rdar://problem/4887423> REGRESSION: search results popup menu strings are not localized
       
 48381         and <rdar://problem/3517227> accessibility-related strings in WebCore are not localized
       
 48382 
       
 48383         Use localized strings from WebKit instead of hard coded strings.
       
 48384 
       
 48385         * bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject roleDescription]):
       
 48386         * page/mac/WebCoreViewFactory.h:
       
 48387         * platform/LocalizedStrings.h:
       
 48388         * platform/mac/LocalizedStringsMac.mm:
       
 48389         (WebCore::searchMenuNoRecentSearchesText):
       
 48390         (WebCore::searchMenuRecentSearchesText):
       
 48391         (WebCore::searchMenuClearRecentSearchesText):
       
 48392         (WebCore::AXWebAreaText):
       
 48393         (WebCore::AXLinkText):
       
 48394         (WebCore::AXListMarkerText):
       
 48395         (WebCore::AXImageMapText):
       
 48396         (WebCore::AXHeadingText):
       
 48397         * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::itemText):
       
 48398 
       
 48399 2007-02-27  Antti Koivisto  <antti@apple.com>
       
 48400 
       
 48401         Reviewed by Maciej.
       
 48402 
       
 48403         - fix http://bugs.webkit.org/show_bug.cgi?id=12911
       
 48404         GoogleDocs: Ordered lists don't update immediately when start attribute changed
       
 48405         
       
 48406         Update list marker value when start attribute changes.
       
 48407 
       
 48408         * html/HTMLOListElement.cpp:
       
 48409         (WebCore::HTMLOListElement::parseMappedAttribute):
       
 48410 
       
 48411 2007-02-28  Nikolas Zimmermann  <zimmermann@kde.org>
       
 48412 
       
 48413         Reviewed by Maciej.
       
 48414 
       
 48415         Corrected the use of the new ENABLE() macros in some ksvg2/svg files.
       
 48416         Add new build-webkit flags "--(no-)xpath" / "--(no-)xslt", to be able
       
 48417         to switch off build features easily. Also add "--(no-)svg-experimental-features"
       
 48418         flag, to be able to test filters/animations/use/foreignObject easily.
       
 48419 
       
 48420         * DerivedSources.make:
       
 48421         * ksvg2/scripts/make_names.pl:
       
 48422         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
       
 48423         * ksvg2/svg/SVGStyledElement.cpp:
       
 48424         * ksvg2/svg/SVGUseElement.cpp:
       
 48425 
       
 48426 2007-02-28  Rob Buis  <buis@kde.org>
       
 48427 
       
 48428         Reviewed by Maciej.
       
 48429 
       
 48430         http://bugs.webkit.org/show_bug.cgi?id=12609
       
 48431         Any SVG element will create renderers even when children of HTML elements
       
 48432 
       
 48433         Allow creation of svg renderers only when parent is SVG, except for
       
 48434         the <svg> element.
       
 48435 
       
 48436         * ksvg2/svg/SVGAElement.h:
       
 48437         * ksvg2/svg/SVGAnimationElement.h:
       
 48438         * ksvg2/svg/SVGCircleElement.h:
       
 48439         * ksvg2/svg/SVGClipPathElement.h:
       
 48440         (WebCore::SVGClipPathElement::rendererIsNeeded):
       
 48441         * ksvg2/svg/SVGDefsElement.cpp:
       
 48442         * ksvg2/svg/SVGDefsElement.h:
       
 48443         * ksvg2/svg/SVGDescElement.h:
       
 48444         (WebCore::SVGDescElement::rendererIsNeeded):
       
 48445         * ksvg2/svg/SVGElement.cpp:
       
 48446         * ksvg2/svg/SVGEllipseElement.h:
       
 48447         * ksvg2/svg/SVGFilterElement.h:
       
 48448         (WebCore::SVGFilterElement::rendererIsNeeded):
       
 48449         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
       
 48450         (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
       
 48451         * ksvg2/svg/SVGForeignObjectElement.h:
       
 48452         * ksvg2/svg/SVGGElement.h:
       
 48453         * ksvg2/svg/SVGGradientElement.h:
       
 48454         * ksvg2/svg/SVGImageElement.h:
       
 48455         * ksvg2/svg/SVGLineElement.h:
       
 48456         * ksvg2/svg/SVGMarkerElement.h:
       
 48457         * ksvg2/svg/SVGMaskElement.h:
       
 48458         * ksvg2/svg/SVGPathElement.h:
       
 48459         * ksvg2/svg/SVGPatternElement.h:
       
 48460         * ksvg2/svg/SVGPolyElement.h:
       
 48461         * ksvg2/svg/SVGRectElement.h:
       
 48462         * ksvg2/svg/SVGStopElement.h:
       
 48463         * ksvg2/svg/SVGStyledElement.cpp:
       
 48464         (WebCore::SVGStyledElement::rendererIsNeeded):
       
 48465         * ksvg2/svg/SVGStyledElement.h:
       
 48466         * ksvg2/svg/SVGSwitchElement.h:
       
 48467         * ksvg2/svg/SVGSymbolElement.h:
       
 48468         (WebCore::SVGSymbolElement::rendererIsNeeded):
       
 48469         * ksvg2/svg/SVGTRefElement.h:
       
 48470         * ksvg2/svg/SVGTSpanElement.h:
       
 48471         * ksvg2/svg/SVGTextElement.h:
       
 48472         * ksvg2/svg/SVGTitleElement.h:
       
 48473         (WebCore::SVGTitleElement::rendererIsNeeded):
       
 48474         * ksvg2/svg/SVGUseElement.h:
       
 48475         * ksvg2/svg/SVGViewElement.h:
       
 48476         (WebCore::SVGViewElement::rendererIsNeeded):
       
 48477 
       
 48478 2007-02-28  Rob Buis  <buis@kde.org>
       
 48479 
       
 48480         Reviewed by Maciej.
       
 48481 
       
 48482         http://bugs.webkit.org/show_bug.cgi?id=12913
       
 48483         Markers do not render in webkit when it misses markerWidth or markerHeight attribute
       
 48484 
       
 48485         Set defaults for markerWidth/markerHeight so markers that do not specify them render.
       
 48486 
       
 48487         * ksvg2/svg/SVGMarkerElement.cpp:
       
 48488         (WebCore::SVGMarkerElement::SVGMarkerElement):
       
 48489 
       
 48490 2007-02-27  Anders Carlsson  <acarlsson@apple.com>
       
 48491 
       
 48492         * loader/ResourceLoader.cpp:
       
 48493         (WebCore::ResourceLoader::~ResourceLoader):
       
 48494         Remove comment.
       
 48495 
       
 48496 2007-02-27  Justin Garcia  <justin.garcia@apple.com>
       
 48497 
       
 48498         Reviewed by oliver
       
 48499 
       
 48500         <rdar://problem/5027300>
       
 48501         REGRESSION: Images inserted with align left/right are lost
       
 48502 
       
 48503         * editing/ReplaceSelectionCommand.cpp:
       
 48504         (WebCore::ReplaceSelectionCommand::shouldMerge):
       
 48505         Don't attempt to merge to or from a position before 
       
 48506         or after a block because it will be a no-op and
       
 48507         lead to infinite recursion.
       
 48508         In this case it instead resulted in content loss because 
       
 48509         of bugs in start/endOfParagraph (5027702).
       
 48510         * editing/visible_units.cpp: Added two FIXMEs for
       
 48511         the problems with start/endOfParagraph.
       
 48512 
       
 48513 2007-02-27  Anders Carlsson  <acarlsson@apple.com>
       
 48514 
       
 48515         Reviewed by Geoff.
       
 48516 
       
 48517         Make resource load delegate methods pass the right document loader.
       
 48518         
       
 48519         * loader/FrameLoader.cpp:
       
 48520         (WebCore::FrameLoader::willSendRequest):
       
 48521         (WebCore::FrameLoader::didReceiveResponse):
       
 48522         (WebCore::FrameLoader::didReceiveData):
       
 48523         (WebCore::FrameLoader::didFailToLoad):
       
 48524         (WebCore::FrameLoader::didFinishLoad):
       
 48525         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
       
 48526         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
       
 48527         Use the resource loader's document loader instead of the active one.
       
 48528         
       
 48529         * loader/MainResourceLoader.cpp:
       
 48530         (WebCore::MainResourceLoader::receivedError):
       
 48531         Make it so we send the frame load delegate method before the resource load delegate method.
       
 48532         This was a regression from 2.0 and was caused by the fix to rdar://problem/4609195. Because the way the loader
       
 48533         now works, both delegate methods will be called.
       
 48534         
       
 48535         * loader/ResourceLoader.cpp:
       
 48536         (WebCore::ResourceLoader::ResourceLoader):
       
 48537         * loader/ResourceLoader.h:
       
 48538         (WebCore::ResourceLoader::documentLoader):
       
 48539         Add document loader pointer to ResourceLoader.
       
 48540 
       
 48541 2007-02-27  Mitz Pettel  <mitz@webkit.org>
       
 48542 
       
 48543         Reviewed by Hyatt.
       
 48544 
       
 48545         - fix http://bugs.webkit.org/show_bug.cgi?id=12910
       
 48546           REGRESSION (r18756-r18765): list-bullet doesn't redraw properly when changing the list's content using JavaScript
       
 48547 
       
 48548         Test: fast/repaint/list-marker.html
       
 48549 
       
 48550         * rendering/RenderListItem.cpp:
       
 48551         (WebCore::RenderListItem::positionListMarker): Add the marker to the visual
       
 48552         overflow of all its ancestor blocks up to the list item. This needs to be
       
 48553         done here since the marker is positioned only after those blocks have been
       
 48554         laid out.
       
 48555 
       
 48556 2007-02-27  Antti Koivisto  <antti@apple.com>
       
 48557 
       
 48558         Reviewed by Hyatt.
       
 48559         
       
 48560         - fix http://bugs.webkit.org/show_bug.cgi?id=12918
       
 48561         REGRESSION: Google Finance dropdown Flickers
       
 48562         <rdar://4988039>
       
 48563         
       
 48564         If a node dies while mouse is over it, it is still supposed to receive
       
 48565         mouseout event (wasn't case in Tiger webkit). However this event should 
       
 48566         not propagate to any other nodes. This patch matches Firefox behavior in
       
 48567         this respect.
       
 48568 
       
 48569         * dom/EventTargetNode.cpp:
       
 48570         (WebCore::EventTargetNode::dispatchGenericEvent):
       
 48571 
       
 48572 2007-02-27  Geoffrey Garen  <ggaren@apple.com>
       
 48573 
       
 48574         Reviewed by Maciej Stachowiak.
       
 48575         
       
 48576         Fixed http://bugs.webkit.org/show_bug.cgi?id=12659 | <rdar://problem/4954306>
       
 48577         JS objects not collected after closing window @ ebay.com/maps.google.com
       
 48578 
       
 48579         Garbage collect in the KJSProxy destructor, after clearing our reference
       
 48580         to the interpreter, because that's when the interpreter has torn down fully.
       
 48581 
       
 48582         (Technically speaking, we can't *prove* that we have the only reference to 
       
 48583         our interpreter, but that's how it works in practice, and manual garbage 
       
 48584         collection is just an opportunistic optimization, so it's OK for it to 
       
 48585         work in practice even if it can't be proven in theory.)
       
 48586         
       
 48587         Layout tests pass. No leaks reported.
       
 48588 
       
 48589         * bindings/js/kjs_proxy.cpp:
       
 48590         (WebCore::KJSProxy::~KJSProxy):
       
 48591         * bindings/js/kjs_proxy.h:
       
 48592         * page/Page.cpp:
       
 48593         (WebCore::Page::~Page): Merged pageDestroyed() calls. Moved debug-only
       
 48594         code to the bottom.
       
 48595         * page/Frame.cpp:
       
 48596         (WebCore::Frame::~Frame): Don't call getObject() because globalObject()
       
 48597         returns a JSObject* already, and the call can leave a pointer to the Window
       
 48598         object on the stack. Don't check for NULL because it is an invariant of
       
 48599         JavaScriptCore that no JSObject* can be NULL. Do use a volatile pointer
       
 48600         for w because the 'w = 0' assignment just screams to the compiler, "Don't
       
 48601         generate any code for me!"
       
 48602 
       
 48603 2007-02-27  Rob Buis  <buis@kde.org>
       
 48604 
       
 48605         Reviewed by David Hyatt.
       
 48606 
       
 48607         http://bugs.webkit.org/show_bug.cgi?id=4128
       
 48608         !important is ignored in inline styling.
       
 48609 
       
 48610         Handle properties with !important flag better in inline
       
 48611         style declarations.
       
 48612 
       
 48613         * css/CSSMutableStyleDeclaration.cpp:
       
 48614         (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
       
 48615 
       
 48616 2007-02-27  David Hyatt  <hyatt@apple.com>
       
 48617 
       
 48618         Bug 11435.  Make sure RenderViews always paintBoxDecorations.  They used to before I removed RenderView's
       
 48619         paint method.  This fix restores the original behavior.
       
 48620 
       
 48621         Reviewed by mitz
       
 48622 
       
 48623         * rendering/RenderBox.cpp:
       
 48624         (WebCore::RenderBox::setStyle):
       
 48625 
       
 48626 2007-02-27  David Hyatt  <hyatt@apple.com>
       
 48627 
       
 48628         Fix for bug 12094, make sure setMinMaxKnown starts off false for the weird/rare case of empty
       
 48629         plaintext documents (which really are buggy and should be fixed to generate root elements).
       
 48630 
       
 48631         Reviewed by mitz
       
 48632 
       
 48633         * rendering/RenderView.cpp:
       
 48634         (WebCore::RenderView::RenderView):
       
 48635 
       
 48636 2007-02-27  Dex Deacon  <occupant4@gmail.com>
       
 48637 
       
 48638         Reviewed by Darin.
       
 48639 
       
 48640         Fixed the case where a BackForwardList of capacity==1 would grow without bound.
       
 48641 
       
 48642         * history/BackForwardList.cpp:
       
 48643         (WebCore::BackForwardList::addItem):
       
 48644 
       
 48645 2007-02-22  Lars Naesbye Christensen  <lars@naesbye.dk>
       
 48646 
       
 48647         Reviewed by Maciej.
       
 48648 
       
 48649         http://bugs.webkit.org/show_bug.cgi?id=12848
       
 48650         Help cursor should have a white outline
       
 48651 
       
 48652         * Resources/helpCursor.png:
       
 48653 
       
 48654 2007-02-27  Alexey Proskuryakov  <ap@webkit.org>
       
 48655 
       
 48656         Reviewed by Maciej.
       
 48657 
       
 48658         http://bugs.webkit.org/show_bug.cgi?id=12594
       
 48659         REGRESSION: Strange highlight in active input area
       
 48660 
       
 48661         No automated test possible.
       
 48662 
       
 48663         * rendering/InlineTextBox.cpp:
       
 48664         (WebCore::InlineTextBox::paint): Restore a check lost in r12792.
       
 48665 
       
 48666 2007-02-27  Darin Adler  <darin@apple.com>
       
 48667 
       
 48668         Reviewed by Mitz.
       
 48669 
       
 48670         - fix http://bugs.webkit.org/show_bug.cgi?id=12908
       
 48671           crash in http/tests/incremental/frame-focus-before-load.html
       
 48672 
       
 48673         * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView):
       
 48674         Add null checks.
       
 48675 
       
 48676 2007-02-27  Darin Adler  <darin@apple.com>
       
 48677 
       
 48678         Reviewed by Alexey.
       
 48679 
       
 48680         - fix http://bugs.webkit.org/show_bug.cgi?id=12909
       
 48681           should use ICU, not TEC, for MacRoman decoding
       
 48682 
       
 48683         * platform/TextCodecICU.cpp: (WebCore::TextCodecICU::registerEncodingNames):
       
 48684         Add "macroman" as an alias for "macintosh". We have seen that in use in mail,
       
 48685         although I'm not sure it's used on the web.
       
 48686 
       
 48687         * platform/mac/mac-encodings.txt: Remove MacRoman line, which was added back
       
 48688         as part of the patch for bug 4971226. But by adding it to this file rather
       
 48689         than the ICU codec, we get it only on Mac OS X. And long term we are trying to
       
 48690         get rid of the use of TEC entirely, so we want this file to be as empty as
       
 48691         possible.
       
 48692 
       
 48693 2007-02-27  Rob Buis  <buis@kde.org>
       
 48694 
       
 48695         Reviewed by Maciej.
       
 48696 
       
 48697         http://bugs.webkit.org/show_bug.cgi?id=12905
       
 48698         Not all svg shapes should support markers
       
 48699 
       
 48700         Restrict marker usage to svg shapes polyline, polygon, line and path.
       
 48701 
       
 48702         * ksvg2/svg/SVGLineElement.h:
       
 48703         (WebCore::SVGLineElement::supportsMarkers):
       
 48704         * ksvg2/svg/SVGPathElement.h:
       
 48705         (WebCore::SVGPathElement::supportsMarkers):
       
 48706         * ksvg2/svg/SVGPolyElement.h:
       
 48707         (WebCore::SVGPolyElement::supportsMarkers):
       
 48708         * ksvg2/svg/SVGStyledElement.h:
       
 48709         (WebCore::SVGStyledElement::supportsMarkers):
       
 48710         * rendering/RenderPath.cpp:
       
 48711         (WebCore::RenderPath::paint):
       
 48712 
       
 48713 2007-02-26  Adele Peterson  <adele@apple.com>
       
 48714 
       
 48715         Reviewed by Lars.
       
 48716 
       
 48717         Fix for http://bugs.webkit.org/show_bug.cgi?id=12902
       
 48718         <rdar://problem/5012679> REGRESSION: Pressing return key doesn't 
       
 48719         move caret to next line after applying a font color in GMail
       
 48720 
       
 48721         Test: fast/frames/iframe-window-focus-2.html
       
 48722 
       
 48723         * page/EventHandler.h: Make focusDocumentView public.
       
 48724         * page/Frame.cpp: (WebCore::Frame::focusWindow): Instead of just setting the focused frame,
       
 48725           we should set also focus the document view.  The bug here was that since the subframe view
       
 48726           wasn't the first responder, the key down event was going to the wrong frame.
       
 48727 
       
 48728 2007-02-26  Maciej Stachowiak  <mjs@apple.com>
       
 48729 
       
 48730         Reviewed by Oliver.
       
 48731 
       
 48732         - fixed <rdar://problem/4946881> Recursive loop with <marker> not caught, crashes in WebCore::SVGPaintServer::draw (11244)
       
 48733         http://bugs.webkit.org/show_bug.cgi?id=11244
       
 48734 
       
 48735         * platform/graphics/svg/SVGResourceMarker.cpp:
       
 48736         (WebCore::SVGResourceMarker::draw): Use a HashSet to guard against
       
 48737         reference cycles.
       
 48738 
       
 48739 2007-02-26  Maciej Stachowiak  <mjs@apple.com>
       
 48740 
       
 48741         Reviewed by Kevin McCullough.
       
 48742 
       
 48743         - fix Qt build for earlier SVG changes.
       
 48744 
       
 48745         * platform/graphics/svg/qt/SVGResourceFilterQt.cpp:
       
 48746 
       
 48747 2007-02-26  Oliver Hunt  <oliver@apple.com>
       
 48748 
       
 48749         Reviewed by Maciej.
       
 48750 
       
 48751         Fix for <rdar://problem/4827378>: Canvas with large height 
       
 48752         uses lots of memory, computer almost stops responding
       
 48753          
       
 48754         Put cap on maximum area of canvas, size is similar too the 
       
 48755         maximum size allowed by firefox (firefox seems to to cut off 
       
 48756         at area == 32767 * 9358). 
       
 48757 
       
 48758         Also protect renderer against the possibility of a null context
       
 48759         (this was triggering a CG warning)
       
 48760 
       
 48761         * html/HTMLCanvasElement.cpp:
       
 48762         (WebCore::HTMLCanvasElement::createDrawingContext):
       
 48763            Apply maximum canvas area
       
 48764         (WebCore::HTMLCanvasElement::createPlatformImage):
       
 48765            Protect against null CG Context
       
 48766 
       
 48767 2007-02-26  Mitz Pettel  <mitz@webkit.org>
       
 48768 
       
 48769         Reviewed by Antti Koivisto.
       
 48770 
       
 48771         - fix http://bugs.webkit.org/show_bug.cgi?id=12899
       
 48772           Ordered lists not updating dynamically with new styles
       
 48773 
       
 48774         Test: fast/lists/list-style-type-dynamic-change.html
       
 48775 
       
 48776         * rendering/RenderListMarker.cpp:
       
 48777         (WebCore::RenderListMarker::setStyle): Made changing the marker type trigger
       
 48778         updating of the marker.
       
 48779 
       
 48780 2007-02-26  Adele Peterson  <adele@apple.com>
       
 48781 
       
 48782         Reviewed by Maciej.
       
 48783 
       
 48784         Fix for <rdar://problem/5012761> REGRESSION: form submit invokes wrong event handler
       
 48785 
       
 48786         Test: fast/events/submit-reset-nested-bubble.html
       
 48787 
       
 48788         * dom/EventTargetNode.h: Made handleLocalEvents virtual.
       
 48789         * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::handleLocalEvents): If we're
       
 48790           not in the capture phase, and the target is a different form, and we're handling
       
 48791           the submitEvent or the resetEvent, then stop propagation of the event.  This matches
       
 48792           Firefox behavior.  You can only get in this situation if misnested tags cause
       
 48793           forms to be nested.
       
 48794         * html/HTMLFormElement.h: Added handleLocalEvents.
       
 48795 
       
 48796 2007-02-26  Darin Adler  <darin@apple.com>
       
 48797 
       
 48798         Reviewed by Oliver Hunt.
       
 48799 
       
 48800         - <rdar://problem/5021555> TextCodecICU does not use fallback mappings; it should
       
 48801 
       
 48802         * platform/TextCodecICU.cpp: (WebCore::TextCodecICU::createICUConverter):
       
 48803         Added a call to ucnv_setFallback(TRUE).
       
 48804 
       
 48805 2007-02-26  Oliver Hunt  <oliver@apple.com>
       
 48806 
       
 48807         Reviewed by Adam.
       
 48808 
       
 48809         Fix for rdar://problem/5021127 
       
 48810 
       
 48811         Need to add null check to node -- original Obj-C didn't need 
       
 48812         the null check due to the Obj-C null messaging semantics
       
 48813 
       
 48814         * editing/Editor.cpp:
       
 48815         (WebCore::Editor::shouldInsertFragment):
       
 48816 
       
 48817 2007-02-26  David Hyatt  <hyatt@apple.com>
       
 48818 
       
 48819         Make text files render using white-space: pre-wrap instead of white-space: pre.
       
 48820         
       
 48821         Reviewed by aroben
       
 48822 
       
 48823         * loader/TextDocument.cpp:
       
 48824         (WebCore::TextTokenizer::write):
       
 48825 
       
 48826 2007-02-26  David Hyatt  <hyatt@apple.com>
       
 48827 
       
 48828         Back out the change to add fullyClippedContentRect.  The layout test
       
 48829         was actually showing more correct results.
       
 48830 
       
 48831         * page/Frame.cpp:
       
 48832         (WebCore::Frame::visibleSelectionRect):
       
 48833         (WebCore::Frame::setIsActive):
       
 48834         (WebCore::Frame::markAllMatchesForText):
       
 48835         * platform/ScrollView.h:
       
 48836         * platform/mac/ScrollViewMac.mm:
       
 48837         * rendering/RenderLayer.cpp:
       
 48838         (WebCore::RenderLayer::scrollRectToVisible):
       
 48839 
       
 48840 2007-02-26  David Hyatt  <hyatt@apple.com>
       
 48841 
       
 48842         Add support for a new property called -webkit-border-fit.  This property
       
 48843         has two values: border and lines.  The "border" value means the border and
       
 48844         background paint normally at the border box level.  The "lines" value indicates
       
 48845         that the border and background should shrink dynamically to snugly hug the
       
 48846         line boxes of normal flow descendants.
       
 48847 
       
 48848         Reviewed by darin
       
 48849 
       
 48850         fast/borders/border-fit.html
       
 48851 
       
 48852         * WebCore.xcodeproj/project.pbxproj:
       
 48853         * css/CSSComputedStyleDeclaration.cpp:
       
 48854         (WebCore::):
       
 48855         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 48856         * css/CSSPropertyNames.in:
       
 48857         * css/CSSValueKeywords.in:
       
 48858         * css/cssparser.cpp:
       
 48859         (WebCore::CSSParser::parseValue):
       
 48860         * css/cssstyleselector.cpp:
       
 48861         (WebCore::CSSStyleSelector::applyProperty):
       
 48862         * rendering/RenderBlock.cpp:
       
 48863         (WebCore::RenderBlock::adjustForBorderFit):
       
 48864         (WebCore::RenderBlock::borderFitAdjust):
       
 48865         * rendering/RenderBlock.h:
       
 48866         * rendering/RenderBox.cpp:
       
 48867         (WebCore::RenderBox::paintBoxDecorations):
       
 48868         * rendering/RenderBox.h:
       
 48869         (WebCore::RenderBox::borderFitAdjust):
       
 48870         * rendering/RenderStyle.cpp:
       
 48871         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
       
 48872         (WebCore::StyleRareNonInheritedData::operator==):
       
 48873         (WebCore::RenderStyle::diff):
       
 48874         * rendering/RenderStyle.h:
       
 48875         (WebCore::):
       
 48876         (WebCore::RenderStyle::borderFit):
       
 48877         (WebCore::RenderStyle::setBorderFit):
       
 48878         (WebCore::RenderStyle::initialBorderFit):
       
 48879 
       
 48880 2007-02-26  Adam Roben  <aroben@apple.com>
       
 48881 
       
 48882         Reviewed by Darin.
       
 48883 
       
 48884         Build fix.
       
 48885 
       
 48886         * rendering/RenderTreeAsText.cpp: Can't use #ifndef with ENABLE() macro.
       
 48887 
       
 48888 2007-02-26  Adele Peterson  <adele@apple.com>
       
 48889 
       
 48890         Reviewed by Adam.
       
 48891 
       
 48892         Fix for <rdar://problem/4990700> Safari always crashes when attempting to edit/view 
       
 48893         Yahoo pipes in WebCore::HTMLSelectElement::optionToListIndex
       
 48894 
       
 48895         Test: fast/forms/select-out-of-bounds-index.html
       
 48896 
       
 48897         * html/HTMLSelectElement.cpp:
       
 48898         (WebCore::HTMLSelectElement::setSelectedIndex): If we're about to deselect all options, then set m_lastOnChangeIndex to -1.
       
 48899         (WebCore::HTMLSelectElement::optionToListIndex): Moved listSize to a local variable.  Rewrote using a simpler for-loop to prevent out-of-bounds errors.
       
 48900 
       
 48901 2007-02-26  Anders Carlsson  <acarlsson@apple.com>
       
 48902 
       
 48903         Reviewed by Geoff.
       
 48904 
       
 48905         <rdar://problem/4816376>
       
 48906         REGRESSION: NetNewsWire 3.0 - Crashes in WebDocumentLoaderMac::attachToFrame() (12674)
       
 48907         
       
 48908         * loader/FrameLoader.cpp:
       
 48909         (WebCore::FrameLoader::reload):
       
 48910         Remove call to setPolicyDocumentLoader here, it's set by the ::load function that we end up calling.
       
 48911 
       
 48912 2007-02-26  Maciej Stachowiak  <mjs@apple.com>
       
 48913 
       
 48914         Reviewed by Lars.
       
 48915 
       
 48916         - fixed <rdar://problem/5021698> Disable experimental SVG features (12883)
       
 48917         
       
 48918         I added an ENABLE_SVG_EXPERIMENTAL_FEATURES define to guard all use of the experimental
       
 48919         features, and used it to guard relevant tag names, elements, JS bindings and renderers.
       
 48920         
       
 48921         I also converted all the existing optional feature defines to
       
 48922         ENABLE_FOO instead of FOO_SUPPORT since that is the more standard
       
 48923         way to do it in open source projects and works with the handy new
       
 48924         ENABLE() macro.
       
 48925 
       
 48926         * CMakeLists.txt:
       
 48927         * DerivedSources.make:
       
 48928         * Projects/gdk/webcore-gdk.bkl:
       
 48929         * WebCore.pro:
       
 48930         * WebCore.vcproj/WebCore/WebCore.vcproj:
       
 48931         * WebCore.vcproj/WebCore/build-generated-files.sh:
       
 48932         * WebCore.xcodeproj/project.pbxproj:
       
 48933         * bindings/js/JSCustomXPathNSResolver.cpp:
       
 48934         * bindings/js/JSCustomXPathNSResolver.h:
       
 48935         * bindings/js/JSSVGElementWrapperFactory.cpp:
       
 48936         * bindings/js/JSSVGElementWrapperFactory.h:
       
 48937         * bindings/js/JSSVGMatrixCustom.cpp:
       
 48938         * bindings/js/JSSVGPODTypeWrapper.h:
       
 48939         * bindings/js/JSSVGPathSegCustom.cpp:
       
 48940         * bindings/js/JSSVGPathSegListCustom.cpp:
       
 48941         * bindings/js/JSSVGPointListCustom.cpp:
       
 48942         * bindings/js/JSXSLTProcessor.cpp:
       
 48943         * bindings/js/JSXSLTProcessor.h:
       
 48944         * bindings/js/kjs_binding.cpp:
       
 48945         (KJS::setDOMException):
       
 48946         * bindings/js/kjs_css.cpp:
       
 48947         (KJS::toJS):
       
 48948         * bindings/js/kjs_dom.cpp:
       
 48949         (KJS::toJS):
       
 48950         * bindings/js/kjs_html.cpp:
       
 48951         (KJS::HTMLElementFunction::callAsFunction):
       
 48952         * bindings/js/kjs_proxy.cpp:
       
 48953         * bindings/js/kjs_proxy.h:
       
 48954         * bindings/js/kjs_window.cpp:
       
 48955         (KJS::Window::getValueProperty):
       
 48956         * bindings/objc/DOM.mm:
       
 48957         (WebCore::createElementClassMap):
       
 48958         (+[DOMNode _nodeWith:]):
       
 48959         * bindings/objc/DOMCSS.mm:
       
 48960         (+[DOMCSSValue _CSSValueWith:]):
       
 48961         * bindings/objc/DOMCustomXPathNSResolver.h:
       
 48962         * bindings/objc/DOMCustomXPathNSResolver.mm:
       
 48963         * bindings/objc/DOMEvents.mm:
       
 48964         (+[DOMEvent _eventWith:]):
       
 48965         * bindings/objc/DOMInternal.h:
       
 48966         * bindings/objc/DOMSVGPathSegInternal.mm:
       
 48967         * bindings/objc/DOMXPath.mm:
       
 48968         * bindings/objc/ExceptionHandlers.mm:
       
 48969         (WebCore::raiseDOMException):
       
 48970         * bindings/objc/PublicDOMInterfaces.h:
       
 48971         * bindings/scripts/CodeGeneratorJS.pm:
       
 48972         * bindings/scripts/CodeGeneratorObjC.pm:
       
 48973         * config.h:
       
 48974         * css/CSSGrammar.y:
       
 48975         * css/CSSStyleDeclaration.cpp:
       
 48976         (WebCore::propertyID):
       
 48977         * css/StyleBase.h:
       
 48978         * css/cssparser.cpp:
       
 48979         (WebCore::CSSParser::parseValue):
       
 48980         * css/cssparser.h:
       
 48981         * css/cssstyleselector.cpp:
       
 48982         (WebCore::CSSStyleSelector::loadDefaultStyle):
       
 48983         (WebCore::CSSStyleSelector::initForStyleResolve):
       
 48984         (WebCore::checkPseudoState):
       
 48985         (WebCore::CSSStyleSelector::adjustRenderStyle):
       
 48986         (WebCore::CSSStyleSelector::applyProperty):
       
 48987         * css/cssstyleselector.h:
       
 48988         * dom/DOMImplementation.cpp:
       
 48989         (WebCore::DOMImplementation::hasFeature):
       
 48990         (WebCore::DOMImplementation::createDocument):
       
 48991         * dom/Document.cpp:
       
 48992         (WebCore::Document::Document):
       
 48993         (WebCore::Document::~Document):
       
 48994         (WebCore::Document::createElement):
       
 48995         (WebCore::Document::implicitClose):
       
 48996         (WebCore::Document::recalcStyleSelector):
       
 48997         (WebCore::Document::createEvent):
       
 48998         * dom/Document.h:
       
 48999         * dom/Document.idl:
       
 49000         * dom/Event.cpp:
       
 49001         * dom/Event.h:
       
 49002         * dom/EventTarget.cpp:
       
 49003         * dom/EventTarget.h:
       
 49004         * dom/MappedAttributeEntry.h:
       
 49005         (WebCore::):
       
 49006         * dom/Node.cpp:
       
 49007         (WebCore::Node::createRendererIfNeeded):
       
 49008         (WebCore::Node::shadowAncestorNode):
       
 49009         * dom/Node.h:
       
 49010         * dom/ProcessingInstruction.cpp:
       
 49011         (WebCore::ProcessingInstruction::ProcessingInstruction):
       
 49012         (WebCore::ProcessingInstruction::checkStyleSheet):
       
 49013         (WebCore::ProcessingInstruction::setCSSStyleSheet):
       
 49014         * dom/ProcessingInstruction.h:
       
 49015         * dom/Text.cpp:
       
 49016         (WebCore::Text::createRenderer):
       
 49017         * dom/XMLTokenizer.cpp:
       
 49018         (WebCore::XMLTokenizer::startElementNs):
       
 49019         (WebCore::XMLTokenizer::endElementNs):
       
 49020         (WebCore::XMLTokenizer::processingInstruction):
       
 49021         (WebCore::XMLTokenizer::end):
       
 49022         (WebCore::XMLTokenizer::insertErrorMessageBlock):
       
 49023         * dom/XMLTokenizer.h:
       
 49024         * html/HTMLEmbedElement.cpp:
       
 49025         * html/HTMLEmbedElement.h:
       
 49026         * html/HTMLObjectElement.cpp:
       
 49027         * html/HTMLObjectElement.h:
       
 49028         * ksvg2/css/SVGCSSParser.cpp:
       
 49029         * ksvg2/css/SVGCSSStyleSelector.cpp:
       
 49030         * ksvg2/css/SVGRenderStyle.cpp:
       
 49031         * ksvg2/css/SVGRenderStyle.h:
       
 49032         * ksvg2/css/SVGRenderStyleDefs.cpp:
       
 49033         * ksvg2/css/SVGRenderStyleDefs.h:
       
 49034         * ksvg2/events/JSSVGLazyEventListener.cpp:
       
 49035         * ksvg2/events/JSSVGLazyEventListener.h:
       
 49036         * ksvg2/events/SVGZoomEvent.cpp:
       
 49037         * ksvg2/events/SVGZoomEvent.h:
       
 49038         * ksvg2/misc/KCanvasRenderingStyle.cpp:
       
 49039         * ksvg2/misc/KCanvasRenderingStyle.h:
       
 49040         * ksvg2/misc/PointerEventsHitRules.cpp:
       
 49041         * ksvg2/misc/PointerEventsHitRules.h:
       
 49042         * ksvg2/misc/SVGDocumentExtensions.cpp:
       
 49043         * ksvg2/misc/SVGDocumentExtensions.h:
       
 49044         * ksvg2/misc/SVGImageLoader.cpp:
       
 49045         * ksvg2/misc/SVGImageLoader.h:
       
 49046         * ksvg2/misc/SVGTimer.cpp:
       
 49047         * ksvg2/misc/SVGTimer.h:
       
 49048         * ksvg2/misc/TimeScheduler.cpp:
       
 49049         * ksvg2/misc/TimeScheduler.h:
       
 49050         * ksvg2/scripts/make_names.pl:
       
 49051         * ksvg2/svg/ColorDistance.cpp:
       
 49052         * ksvg2/svg/ColorDistance.h:
       
 49053         * ksvg2/svg/GradientAttributes.h:
       
 49054         * ksvg2/svg/LinearGradientAttributes.h:
       
 49055         * ksvg2/svg/PatternAttributes.h:
       
 49056         * ksvg2/svg/RadialGradientAttributes.h:
       
 49057         * ksvg2/svg/SVGAElement.cpp:
       
 49058         * ksvg2/svg/SVGAElement.h:
       
 49059         * ksvg2/svg/SVGAngle.cpp:
       
 49060         * ksvg2/svg/SVGAngle.h:
       
 49061         * ksvg2/svg/SVGAnimateColorElement.cpp:
       
 49062         * ksvg2/svg/SVGAnimateColorElement.h:
       
 49063         * ksvg2/svg/SVGAnimateElement.cpp:
       
 49064         * ksvg2/svg/SVGAnimateElement.h:
       
 49065         * ksvg2/svg/SVGAnimateElement.idl:
       
 49066         * ksvg2/svg/SVGAnimateMotionElement.cpp:
       
 49067         * ksvg2/svg/SVGAnimateMotionElement.h:
       
 49068         * ksvg2/svg/SVGAnimateTransformElement.cpp:
       
 49069         * ksvg2/svg/SVGAnimateTransformElement.h:
       
 49070         * ksvg2/svg/SVGAnimateTransformElement.idl:
       
 49071         * ksvg2/svg/SVGAnimatedPathData.cpp:
       
 49072         * ksvg2/svg/SVGAnimatedPathData.h:
       
 49073         * ksvg2/svg/SVGAnimatedPoints.cpp:
       
 49074         * ksvg2/svg/SVGAnimatedPoints.h:
       
 49075         * ksvg2/svg/SVGAnimatedTemplate.h:
       
 49076         * ksvg2/svg/SVGAnimationElement.cpp:
       
 49077         * ksvg2/svg/SVGAnimationElement.h:
       
 49078         * ksvg2/svg/SVGCircleElement.cpp:
       
 49079         * ksvg2/svg/SVGCircleElement.h:
       
 49080         * ksvg2/svg/SVGClipPathElement.cpp:
       
 49081         * ksvg2/svg/SVGClipPathElement.h:
       
 49082         * ksvg2/svg/SVGColor.cpp:
       
 49083         * ksvg2/svg/SVGColor.h:
       
 49084         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
       
 49085         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
       
 49086         * ksvg2/svg/SVGCursorElement.cpp:
       
 49087         * ksvg2/svg/SVGCursorElement.h:
       
 49088         * ksvg2/svg/SVGDefsElement.cpp:
       
 49089         * ksvg2/svg/SVGDefsElement.h:
       
 49090         * ksvg2/svg/SVGDescElement.cpp:
       
 49091         * ksvg2/svg/SVGDescElement.h:
       
 49092         * ksvg2/svg/SVGDocument.cpp:
       
 49093         * ksvg2/svg/SVGDocument.h:
       
 49094         * ksvg2/svg/SVGElement.cpp:
       
 49095         (WebCore::SVGElement::dispatchEvent):
       
 49096         * ksvg2/svg/SVGElement.h:
       
 49097         * ksvg2/svg/SVGElementInstance.cpp:
       
 49098         * ksvg2/svg/SVGElementInstance.h:
       
 49099         * ksvg2/svg/SVGElementInstance.idl:
       
 49100         * ksvg2/svg/SVGElementInstanceList.cpp:
       
 49101         * ksvg2/svg/SVGElementInstanceList.h:
       
 49102         * ksvg2/svg/SVGElementInstanceList.idl:
       
 49103         * ksvg2/svg/SVGEllipseElement.cpp:
       
 49104         * ksvg2/svg/SVGEllipseElement.h:
       
 49105         * ksvg2/svg/SVGException.h:
       
 49106         * ksvg2/svg/SVGExternalResourcesRequired.cpp:
       
 49107         * ksvg2/svg/SVGExternalResourcesRequired.h:
       
 49108         * ksvg2/svg/SVGFEBlendElement.cpp:
       
 49109         * ksvg2/svg/SVGFEBlendElement.h:
       
 49110         * ksvg2/svg/SVGFEBlendElement.idl:
       
 49111         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
       
 49112         * ksvg2/svg/SVGFEColorMatrixElement.h:
       
 49113         * ksvg2/svg/SVGFEColorMatrixElement.idl:
       
 49114         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
       
 49115         * ksvg2/svg/SVGFEComponentTransferElement.h:
       
 49116         * ksvg2/svg/SVGFEComponentTransferElement.idl:
       
 49117         * ksvg2/svg/SVGFECompositeElement.cpp:
       
 49118         * ksvg2/svg/SVGFECompositeElement.h:
       
 49119         * ksvg2/svg/SVGFECompositeElement.idl:
       
 49120         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
       
 49121         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
       
 49122         * ksvg2/svg/SVGFEDiffuseLightingElement.idl:
       
 49123         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
       
 49124         * ksvg2/svg/SVGFEDisplacementMapElement.h:
       
 49125         * ksvg2/svg/SVGFEDisplacementMapElement.idl:
       
 49126         * ksvg2/svg/SVGFEDistantLightElement.cpp:
       
 49127         * ksvg2/svg/SVGFEDistantLightElement.h:
       
 49128         * ksvg2/svg/SVGFEDistantLightElement.idl:
       
 49129         * ksvg2/svg/SVGFEFloodElement.cpp:
       
 49130         * ksvg2/svg/SVGFEFloodElement.h:
       
 49131         * ksvg2/svg/SVGFEFloodElement.idl:
       
 49132         * ksvg2/svg/SVGFEFuncAElement.cpp:
       
 49133         * ksvg2/svg/SVGFEFuncAElement.h:
       
 49134         * ksvg2/svg/SVGFEFuncAElement.idl:
       
 49135         * ksvg2/svg/SVGFEFuncBElement.cpp:
       
 49136         * ksvg2/svg/SVGFEFuncBElement.h:
       
 49137         * ksvg2/svg/SVGFEFuncBElement.idl:
       
 49138         * ksvg2/svg/SVGFEFuncGElement.cpp:
       
 49139         * ksvg2/svg/SVGFEFuncGElement.h:
       
 49140         * ksvg2/svg/SVGFEFuncGElement.idl:
       
 49141         * ksvg2/svg/SVGFEFuncRElement.cpp:
       
 49142         * ksvg2/svg/SVGFEFuncRElement.h:
       
 49143         * ksvg2/svg/SVGFEFuncRElement.idl:
       
 49144         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
       
 49145         * ksvg2/svg/SVGFEGaussianBlurElement.h:
       
 49146         * ksvg2/svg/SVGFEGaussianBlurElement.idl:
       
 49147         * ksvg2/svg/SVGFEImageElement.cpp:
       
 49148         * ksvg2/svg/SVGFEImageElement.h:
       
 49149         * ksvg2/svg/SVGFEImageElement.idl:
       
 49150         * ksvg2/svg/SVGFELightElement.cpp:
       
 49151         * ksvg2/svg/SVGFELightElement.h:
       
 49152         * ksvg2/svg/SVGFEMergeElement.cpp:
       
 49153         * ksvg2/svg/SVGFEMergeElement.h:
       
 49154         * ksvg2/svg/SVGFEMergeElement.idl:
       
 49155         * ksvg2/svg/SVGFEMergeNodeElement.cpp:
       
 49156         * ksvg2/svg/SVGFEMergeNodeElement.h:
       
 49157         * ksvg2/svg/SVGFEMergeNodeElement.idl:
       
 49158         * ksvg2/svg/SVGFEOffsetElement.cpp:
       
 49159         * ksvg2/svg/SVGFEOffsetElement.h:
       
 49160         * ksvg2/svg/SVGFEOffsetElement.idl:
       
 49161         * ksvg2/svg/SVGFEPointLightElement.cpp:
       
 49162         * ksvg2/svg/SVGFEPointLightElement.h:
       
 49163         * ksvg2/svg/SVGFEPointLightElement.idl:
       
 49164         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
       
 49165         * ksvg2/svg/SVGFESpecularLightingElement.h:
       
 49166         * ksvg2/svg/SVGFESpecularLightingElement.idl:
       
 49167         * ksvg2/svg/SVGFESpotLightElement.cpp:
       
 49168         * ksvg2/svg/SVGFESpotLightElement.h:
       
 49169         * ksvg2/svg/SVGFESpotLightElement.idl:
       
 49170         * ksvg2/svg/SVGFETileElement.cpp:
       
 49171         * ksvg2/svg/SVGFETileElement.h:
       
 49172         * ksvg2/svg/SVGFETileElement.idl:
       
 49173         * ksvg2/svg/SVGFETurbulenceElement.cpp:
       
 49174         * ksvg2/svg/SVGFETurbulenceElement.h:
       
 49175         * ksvg2/svg/SVGFETurbulenceElement.idl:
       
 49176         * ksvg2/svg/SVGFilterElement.cpp:
       
 49177         * ksvg2/svg/SVGFilterElement.h:
       
 49178         * ksvg2/svg/SVGFilterElement.idl:
       
 49179         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
       
 49180         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
       
 49181         * ksvg2/svg/SVGFitToViewBox.cpp:
       
 49182         * ksvg2/svg/SVGFitToViewBox.h:
       
 49183         * ksvg2/svg/SVGForeignObjectElement.cpp:
       
 49184         * ksvg2/svg/SVGForeignObjectElement.h:
       
 49185         * ksvg2/svg/SVGForeignObjectElement.idl:
       
 49186         * ksvg2/svg/SVGGElement.cpp:
       
 49187         * ksvg2/svg/SVGGElement.h:
       
 49188         * ksvg2/svg/SVGGradientElement.cpp:
       
 49189         * ksvg2/svg/SVGGradientElement.h:
       
 49190         * ksvg2/svg/SVGImageElement.cpp:
       
 49191         * ksvg2/svg/SVGImageElement.h:
       
 49192         * ksvg2/svg/SVGLangSpace.cpp:
       
 49193         * ksvg2/svg/SVGLangSpace.h:
       
 49194         * ksvg2/svg/SVGLength.cpp:
       
 49195         * ksvg2/svg/SVGLength.h:
       
 49196         * ksvg2/svg/SVGLengthList.cpp:
       
 49197         * ksvg2/svg/SVGLengthList.h:
       
 49198         * ksvg2/svg/SVGLineElement.cpp:
       
 49199         * ksvg2/svg/SVGLineElement.h:
       
 49200         * ksvg2/svg/SVGLinearGradientElement.cpp:
       
 49201         * ksvg2/svg/SVGLinearGradientElement.h:
       
 49202         * ksvg2/svg/SVGList.h:
       
 49203         * ksvg2/svg/SVGListTraits.h:
       
 49204         * ksvg2/svg/SVGLocatable.cpp:
       
 49205         (WebCore::SVGLocatable::nearestViewportElement):
       
 49206         (WebCore::SVGLocatable::farthestViewportElement):
       
 49207         * ksvg2/svg/SVGLocatable.h:
       
 49208         * ksvg2/svg/SVGMPathElement.cpp:
       
 49209         * ksvg2/svg/SVGMPathElement.h:
       
 49210         * ksvg2/svg/SVGMarkerElement.cpp:
       
 49211         * ksvg2/svg/SVGMarkerElement.h:
       
 49212         * ksvg2/svg/SVGMaskElement.cpp:
       
 49213         * ksvg2/svg/SVGMaskElement.h:
       
 49214         * ksvg2/svg/SVGMetadataElement.cpp:
       
 49215         * ksvg2/svg/SVGMetadataElement.h:
       
 49216         * ksvg2/svg/SVGNumberList.cpp:
       
 49217         * ksvg2/svg/SVGNumberList.h:
       
 49218         * ksvg2/svg/SVGPaint.cpp:
       
 49219         * ksvg2/svg/SVGPaint.h:
       
 49220         * ksvg2/svg/SVGParserUtilities.cpp:
       
 49221         * ksvg2/svg/SVGParserUtilities.h:
       
 49222         * ksvg2/svg/SVGPathElement.cpp:
       
 49223         * ksvg2/svg/SVGPathElement.h:
       
 49224         * ksvg2/svg/SVGPathSeg.h:
       
 49225         * ksvg2/svg/SVGPathSegArc.cpp:
       
 49226         * ksvg2/svg/SVGPathSegArc.h:
       
 49227         * ksvg2/svg/SVGPathSegClosePath.cpp:
       
 49228         * ksvg2/svg/SVGPathSegClosePath.h:
       
 49229         * ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
       
 49230         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
       
 49231         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
       
 49232         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
       
 49233         * ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
       
 49234         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
       
 49235         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
       
 49236         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
       
 49237         * ksvg2/svg/SVGPathSegLineto.cpp:
       
 49238         * ksvg2/svg/SVGPathSegLineto.h:
       
 49239         * ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
       
 49240         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
       
 49241         * ksvg2/svg/SVGPathSegLinetoVertical.cpp:
       
 49242         * ksvg2/svg/SVGPathSegLinetoVertical.h:
       
 49243         * ksvg2/svg/SVGPathSegList.cpp:
       
 49244         * ksvg2/svg/SVGPathSegList.h:
       
 49245         * ksvg2/svg/SVGPathSegMoveto.cpp:
       
 49246         * ksvg2/svg/SVGPathSegMoveto.h:
       
 49247         * ksvg2/svg/SVGPatternElement.cpp:
       
 49248         * ksvg2/svg/SVGPatternElement.h:
       
 49249         * ksvg2/svg/SVGPointList.cpp:
       
 49250         * ksvg2/svg/SVGPointList.h:
       
 49251         * ksvg2/svg/SVGPolyElement.cpp:
       
 49252         * ksvg2/svg/SVGPolyElement.h:
       
 49253         * ksvg2/svg/SVGPolygonElement.cpp:
       
 49254         * ksvg2/svg/SVGPolygonElement.h:
       
 49255         * ksvg2/svg/SVGPolylineElement.cpp:
       
 49256         * ksvg2/svg/SVGPolylineElement.h:
       
 49257         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
       
 49258         * ksvg2/svg/SVGPreserveAspectRatio.h:
       
 49259         * ksvg2/svg/SVGRadialGradientElement.cpp:
       
 49260         * ksvg2/svg/SVGRadialGradientElement.h:
       
 49261         * ksvg2/svg/SVGRectElement.cpp:
       
 49262         * ksvg2/svg/SVGRectElement.h:
       
 49263         * ksvg2/svg/SVGRenderingIntent.h:
       
 49264         * ksvg2/svg/SVGSVGElement.cpp:
       
 49265         * ksvg2/svg/SVGSVGElement.h:
       
 49266         * ksvg2/svg/SVGScriptElement.cpp:
       
 49267         * ksvg2/svg/SVGScriptElement.h:
       
 49268         * ksvg2/svg/SVGSetElement.cpp:
       
 49269         * ksvg2/svg/SVGSetElement.h:
       
 49270         * ksvg2/svg/SVGStopElement.cpp:
       
 49271         * ksvg2/svg/SVGStopElement.h:
       
 49272         * ksvg2/svg/SVGStringList.cpp:
       
 49273         * ksvg2/svg/SVGStringList.h:
       
 49274         * ksvg2/svg/SVGStylable.cpp:
       
 49275         * ksvg2/svg/SVGStylable.h:
       
 49276         * ksvg2/svg/SVGStyleElement.cpp:
       
 49277         * ksvg2/svg/SVGStyleElement.h:
       
 49278         * ksvg2/svg/SVGStyledElement.cpp:
       
 49279         (WebCore::SVGStyledElement::notifyAttributeChange):
       
 49280         * ksvg2/svg/SVGStyledElement.h:
       
 49281         * ksvg2/svg/SVGStyledLocatableElement.cpp:
       
 49282         * ksvg2/svg/SVGStyledLocatableElement.h:
       
 49283         * ksvg2/svg/SVGStyledTransformableElement.cpp:
       
 49284         * ksvg2/svg/SVGStyledTransformableElement.h:
       
 49285         * ksvg2/svg/SVGSwitchElement.cpp:
       
 49286         * ksvg2/svg/SVGSwitchElement.h:
       
 49287         * ksvg2/svg/SVGSymbolElement.cpp:
       
 49288         * ksvg2/svg/SVGSymbolElement.h:
       
 49289         * ksvg2/svg/SVGTRefElement.cpp:
       
 49290         * ksvg2/svg/SVGTRefElement.h:
       
 49291         * ksvg2/svg/SVGTSpanElement.cpp:
       
 49292         * ksvg2/svg/SVGTSpanElement.h:
       
 49293         * ksvg2/svg/SVGTests.cpp:
       
 49294         * ksvg2/svg/SVGTests.h:
       
 49295         * ksvg2/svg/SVGTextContentElement.cpp:
       
 49296         * ksvg2/svg/SVGTextContentElement.h:
       
 49297         * ksvg2/svg/SVGTextElement.cpp:
       
 49298         * ksvg2/svg/SVGTextElement.h:
       
 49299         * ksvg2/svg/SVGTextPositioningElement.cpp:
       
 49300         * ksvg2/svg/SVGTextPositioningElement.h:
       
 49301         * ksvg2/svg/SVGTitleElement.cpp:
       
 49302         * ksvg2/svg/SVGTitleElement.h:
       
 49303         * ksvg2/svg/SVGTransform.cpp:
       
 49304         * ksvg2/svg/SVGTransform.h:
       
 49305         * ksvg2/svg/SVGTransformDistance.cpp:
       
 49306         * ksvg2/svg/SVGTransformDistance.h:
       
 49307         * ksvg2/svg/SVGTransformList.cpp:
       
 49308         * ksvg2/svg/SVGTransformList.h:
       
 49309         * ksvg2/svg/SVGTransformable.cpp:
       
 49310         * ksvg2/svg/SVGTransformable.h:
       
 49311         * ksvg2/svg/SVGURIReference.cpp:
       
 49312         * ksvg2/svg/SVGURIReference.h:
       
 49313         * ksvg2/svg/SVGUnitTypes.h:
       
 49314         * ksvg2/svg/SVGUseElement.cpp:
       
 49315         * ksvg2/svg/SVGUseElement.h:
       
 49316         * ksvg2/svg/SVGUseElement.idl:
       
 49317         * ksvg2/svg/SVGViewElement.cpp:
       
 49318         * ksvg2/svg/SVGViewElement.h:
       
 49319         * ksvg2/svg/SVGZoomAndPan.cpp:
       
 49320         * ksvg2/svg/SVGZoomAndPan.h:
       
 49321         * ksvg2/svg/svgtags.in:
       
 49322         * loader/Cache.cpp:
       
 49323         (WebCore::createResource):
       
 49324         (WebCore::Cache::getStatistics):
       
 49325         * loader/Cache.h:
       
 49326         * loader/CachedImage.cpp:
       
 49327         (WebCore::CachedImage::createImage):
       
 49328         * loader/CachedResource.h:
       
 49329         (WebCore::CachedResource::):
       
 49330         * loader/CachedResourceClient.h:
       
 49331         * loader/CachedXBLDocument.cpp:
       
 49332         * loader/CachedXBLDocument.h:
       
 49333         * loader/CachedXSLStyleSheet.cpp:
       
 49334         * loader/CachedXSLStyleSheet.h:
       
 49335         * loader/DocLoader.cpp:
       
 49336         * loader/DocLoader.h:
       
 49337         * page/DOMWindow.idl:
       
 49338         * page/EventHandler.cpp:
       
 49339         (WebCore::EventHandler::handleMouseMoveEvent):
       
 49340         (WebCore::selectCursor):
       
 49341         * page/Frame.cpp:
       
 49342         (WebCore::Frame::Frame):
       
 49343         * page/PageState.cpp:
       
 49344         (WebCore::PageState::PageState):
       
 49345         (WebCore::PageState::restore):
       
 49346         * platform/MimeTypeRegistry.cpp:
       
 49347         (WebCore::initialiseSupportedNonImageMimeTypes):
       
 49348         * platform/graphics/FloatPoint3D.cpp:
       
 49349         * platform/graphics/FloatPoint3D.h:
       
 49350         * platform/graphics/ImageBuffer.cpp:
       
 49351         (WebCore::ImageBuffer::renderSubtreeToImage):
       
 49352         * platform/graphics/svg/SVGImage.cpp:
       
 49353         * platform/graphics/svg/SVGImage.h:
       
 49354         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 49355         * platform/graphics/svg/SVGPaintServer.cpp:
       
 49356         * platform/graphics/svg/SVGPaintServer.h:
       
 49357         * platform/graphics/svg/SVGPaintServerGradient.cpp:
       
 49358         * platform/graphics/svg/SVGPaintServerGradient.h:
       
 49359         * platform/graphics/svg/SVGPaintServerLinearGradient.cpp:
       
 49360         * platform/graphics/svg/SVGPaintServerLinearGradient.h:
       
 49361         * platform/graphics/svg/SVGPaintServerPattern.cpp:
       
 49362         * platform/graphics/svg/SVGPaintServerPattern.h:
       
 49363         * platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
       
 49364         * platform/graphics/svg/SVGPaintServerRadialGradient.h:
       
 49365         * platform/graphics/svg/SVGPaintServerSolid.cpp:
       
 49366         * platform/graphics/svg/SVGPaintServerSolid.h:
       
 49367         * platform/graphics/svg/SVGResource.cpp:
       
 49368         * platform/graphics/svg/SVGResource.h:
       
 49369         * platform/graphics/svg/SVGResourceClipper.cpp:
       
 49370         * platform/graphics/svg/SVGResourceClipper.h:
       
 49371         * platform/graphics/svg/SVGResourceFilter.cpp:
       
 49372         * platform/graphics/svg/SVGResourceFilter.h:
       
 49373         * platform/graphics/svg/SVGResourceMarker.cpp:
       
 49374         * platform/graphics/svg/SVGResourceMarker.h:
       
 49375         * platform/graphics/svg/SVGResourceMasker.cpp:
       
 49376         * platform/graphics/svg/SVGResourceMasker.h:
       
 49377         * platform/graphics/svg/cg/CgSupport.cpp:
       
 49378         * platform/graphics/svg/cg/CgSupport.h:
       
 49379         * platform/graphics/svg/cg/RenderPathCg.cpp:
       
 49380         * platform/graphics/svg/cg/SVGPaintServerCg.cpp:
       
 49381         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
       
 49382         * platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp:
       
 49383         * platform/graphics/svg/cg/SVGPaintServerSolidCg.cpp:
       
 49384         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp:
       
 49385         * platform/graphics/svg/cg/SVGResourceFilterCg.mm:
       
 49386         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
       
 49387         * platform/graphics/svg/filters/SVGDistantLightSource.h:
       
 49388         * platform/graphics/svg/filters/SVGFEBlend.cpp:
       
 49389         * platform/graphics/svg/filters/SVGFEBlend.h:
       
 49390         * platform/graphics/svg/filters/SVGFEColorMatrix.cpp:
       
 49391         * platform/graphics/svg/filters/SVGFEColorMatrix.h:
       
 49392         * platform/graphics/svg/filters/SVGFEComponentTransfer.cpp:
       
 49393         * platform/graphics/svg/filters/SVGFEComponentTransfer.h:
       
 49394         * platform/graphics/svg/filters/SVGFEComposite.cpp:
       
 49395         * platform/graphics/svg/filters/SVGFEComposite.h:
       
 49396         * platform/graphics/svg/filters/SVGFEConvolveMatrix.cpp:
       
 49397         * platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
       
 49398         * platform/graphics/svg/filters/SVGFEDiffuseLighting.cpp:
       
 49399         * platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
       
 49400         * platform/graphics/svg/filters/SVGFEDisplacementMap.cpp:
       
 49401         * platform/graphics/svg/filters/SVGFEDisplacementMap.h:
       
 49402         * platform/graphics/svg/filters/SVGFEFlood.cpp:
       
 49403         * platform/graphics/svg/filters/SVGFEFlood.h:
       
 49404         * platform/graphics/svg/filters/SVGFEGaussianBlur.cpp:
       
 49405         * platform/graphics/svg/filters/SVGFEGaussianBlur.h:
       
 49406         * platform/graphics/svg/filters/SVGFEImage.cpp:
       
 49407         * platform/graphics/svg/filters/SVGFEImage.h:
       
 49408         * platform/graphics/svg/filters/SVGFEMerge.cpp:
       
 49409         * platform/graphics/svg/filters/SVGFEMerge.h:
       
 49410         * platform/graphics/svg/filters/SVGFEMorphology.cpp:
       
 49411         * platform/graphics/svg/filters/SVGFEMorphology.h:
       
 49412         * platform/graphics/svg/filters/SVGFEOffset.cpp:
       
 49413         * platform/graphics/svg/filters/SVGFEOffset.h:
       
 49414         * platform/graphics/svg/filters/SVGFESpecularLighting.cpp:
       
 49415         * platform/graphics/svg/filters/SVGFESpecularLighting.h:
       
 49416         * platform/graphics/svg/filters/SVGFETile.h:
       
 49417         * platform/graphics/svg/filters/SVGFETurbulence.cpp:
       
 49418         * platform/graphics/svg/filters/SVGFETurbulence.h:
       
 49419         * platform/graphics/svg/filters/SVGFilterEffect.cpp:
       
 49420         * platform/graphics/svg/filters/SVGFilterEffect.h:
       
 49421         * platform/graphics/svg/filters/SVGLightSource.cpp:
       
 49422         * platform/graphics/svg/filters/SVGLightSource.h:
       
 49423         * platform/graphics/svg/filters/SVGPointLightSource.h:
       
 49424         * platform/graphics/svg/filters/SVGSpotLightSource.h:
       
 49425         * platform/graphics/svg/filters/cg/SVGFEBlendCg.mm:
       
 49426         * platform/graphics/svg/filters/cg/SVGFEColorMatrixCg.mm:
       
 49427         * platform/graphics/svg/filters/cg/SVGFEComponentTransferCg.mm:
       
 49428         * platform/graphics/svg/filters/cg/SVGFECompositeCg.mm:
       
 49429         * platform/graphics/svg/filters/cg/SVGFEDiffuseLightingCg.mm:
       
 49430         * platform/graphics/svg/filters/cg/SVGFEDisplacementMapCg.mm:
       
 49431         * platform/graphics/svg/filters/cg/SVGFEFloodCg.mm:
       
 49432         * platform/graphics/svg/filters/cg/SVGFEGaussianBlurCg.mm:
       
 49433         * platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
       
 49434         * platform/graphics/svg/filters/cg/SVGFEHelpersCg.mm:
       
 49435         * platform/graphics/svg/filters/cg/SVGFEImageCg.mm:
       
 49436         * platform/graphics/svg/filters/cg/SVGFEMergeCg.mm:
       
 49437         * platform/graphics/svg/filters/cg/SVGFEOffsetCg.mm:
       
 49438         * platform/graphics/svg/filters/cg/SVGFESpecularLightingCg.mm:
       
 49439         * platform/graphics/svg/filters/cg/SVGFETileCg.mm:
       
 49440         * platform/graphics/svg/filters/cg/SVGFilterEffectCg.mm:
       
 49441         * platform/graphics/svg/qt/SVGPaintServerGradientQt.cpp:
       
 49442         * platform/graphics/svg/qt/SVGPaintServerLinearGradientQt.cpp:
       
 49443         * platform/graphics/svg/qt/SVGPaintServerPatternQt.cpp:
       
 49444         * platform/graphics/svg/qt/SVGPaintServerQt.cpp:
       
 49445         * platform/graphics/svg/qt/SVGPaintServerRadialGradientQt.cpp:
       
 49446         * platform/graphics/svg/qt/SVGPaintServerSolidQt.cpp:
       
 49447         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
       
 49448         * platform/graphics/svg/qt/SVGResourceFilterQt.cpp:
       
 49449         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
       
 49450         * rendering/HitTestResult.cpp:
       
 49451         (WebCore::HitTestResult::absoluteImageURL):
       
 49452         (WebCore::HitTestResult::absoluteLinkURL):
       
 49453         (WebCore::HitTestResult::isLiveLink):
       
 49454         * rendering/RenderForeignObject.cpp:
       
 49455         * rendering/RenderForeignObject.h:
       
 49456         * rendering/RenderLayer.cpp:
       
 49457         (WebCore::RenderLayer::isTransparent):
       
 49458         * rendering/RenderObject.cpp:
       
 49459         (WebCore::RenderObject::containingBlock):
       
 49460         * rendering/RenderObject.h:
       
 49461         * rendering/RenderPath.cpp:
       
 49462         * rendering/RenderPath.h:
       
 49463         * rendering/RenderSVGBlock.cpp:
       
 49464         * rendering/RenderSVGBlock.h:
       
 49465         * rendering/RenderSVGContainer.cpp:
       
 49466         * rendering/RenderSVGContainer.h:
       
 49467         * rendering/RenderSVGGradientStop.cpp:
       
 49468         * rendering/RenderSVGGradientStop.h:
       
 49469         * rendering/RenderSVGHiddenContainer.cpp:
       
 49470         * rendering/RenderSVGHiddenContainer.h:
       
 49471         * rendering/RenderSVGImage.cpp:
       
 49472         * rendering/RenderSVGImage.h:
       
 49473         * rendering/RenderSVGInline.cpp:
       
 49474         * rendering/RenderSVGInline.h:
       
 49475         * rendering/RenderSVGInlineText.cpp:
       
 49476         * rendering/RenderSVGInlineText.h:
       
 49477         * rendering/RenderSVGTSpan.cpp:
       
 49478         * rendering/RenderSVGTSpan.h:
       
 49479         * rendering/RenderSVGText.cpp:
       
 49480         * rendering/RenderSVGText.h:
       
 49481         * rendering/RenderStyle.cpp:
       
 49482         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
       
 49483         (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData):
       
 49484         (WebCore::StyleRareNonInheritedData::operator==):
       
 49485         (WebCore::RenderStyle::RenderStyle):
       
 49486         (WebCore::RenderStyle::inheritFrom):
       
 49487         (WebCore::RenderStyle::operator==):
       
 49488         (WebCore::RenderStyle::inheritedNotEqual):
       
 49489         (WebCore::RenderStyle::diff):
       
 49490         * rendering/RenderStyle.h:
       
 49491         * rendering/RenderText.cpp:
       
 49492         (WebCore::RenderText::setStyle):
       
 49493         (WebCore::RenderText::setTextInternal):
       
 49494         * rendering/RenderTreeAsText.cpp:
       
 49495         (WebCore::write):
       
 49496         (WebCore::externalRepresentation):
       
 49497         * rendering/SVGInlineFlowBox.cpp:
       
 49498         * rendering/SVGInlineFlowBox.h:
       
 49499         * rendering/SVGRenderTreeAsText.cpp:
       
 49500         * rendering/SVGRenderTreeAsText.h:
       
 49501         * rendering/SVGRootInlineBox.cpp:
       
 49502         * rendering/SVGRootInlineBox.h:
       
 49503         * rendering/bidi.cpp:
       
 49504         (WebCore::shouldPreserveNewline):
       
 49505         (WebCore::RenderBlock::findNextLineBreak):
       
 49506         * webcore-base.bkl:
       
 49507         * xml/NativeXPathNSResolver.cpp:
       
 49508         * xml/NativeXPathNSResolver.h:
       
 49509         * xml/XPathEvaluator.cpp:
       
 49510         * xml/XPathEvaluator.h:
       
 49511         * xml/XPathExpression.cpp:
       
 49512         * xml/XPathExpression.h:
       
 49513         * xml/XPathExpressionNode.cpp:
       
 49514         * xml/XPathExpressionNode.h:
       
 49515         * xml/XPathFunctions.cpp:
       
 49516         * xml/XPathFunctions.h:
       
 49517         * xml/XPathGrammar.y:
       
 49518         * xml/XPathNSResolver.cpp:
       
 49519         * xml/XPathNSResolver.h:
       
 49520         * xml/XPathNamespace.cpp:
       
 49521         * xml/XPathNamespace.h:
       
 49522         * xml/XPathParser.cpp:
       
 49523         * xml/XPathParser.h:
       
 49524         * xml/XPathPath.cpp:
       
 49525         * xml/XPathPath.h:
       
 49526         * xml/XPathPredicate.cpp:
       
 49527         * xml/XPathPredicate.h:
       
 49528         * xml/XPathResult.cpp:
       
 49529         * xml/XPathResult.h:
       
 49530         * xml/XPathStep.cpp:
       
 49531         * xml/XPathStep.h:
       
 49532         * xml/XPathUtil.cpp:
       
 49533         * xml/XPathUtil.h:
       
 49534         * xml/XPathValue.cpp:
       
 49535         * xml/XPathValue.h:
       
 49536         * xml/XPathVariableReference.cpp:
       
 49537         * xml/XPathVariableReference.h:
       
 49538         * xml/XSLImportRule.cpp:
       
 49539         * xml/XSLImportRule.h:
       
 49540         * xml/XSLStyleSheet.cpp:
       
 49541         * xml/XSLStyleSheet.h:
       
 49542         * xml/XSLTProcessor.cpp:
       
 49543         * xml/XSLTProcessor.h:
       
 49544 
       
 49545 2007-02-25  Mitz Pettel  <mitz@webkit.org>
       
 49546 
       
 49547         Reviewed by David Hyatt.
       
 49548 
       
 49549         - fix http://bugs.webkit.org/show_bug.cgi?id=12886
       
 49550           Crash with Scriptalicious javascript library
       
 49551 
       
 49552         Test: fast/dynamic/float-withdrawal.html
       
 49553 
       
 49554         * rendering/RenderBlock.cpp:
       
 49555         (WebCore::RenderBlock::layoutBlockChildren): Detect when a child block had
       
 49556         intruding floats in a previous layout, and in that case force it to relayout.
       
 49557 
       
 49558 2007-02-25  David Hyatt  <hyatt@apple.com>
       
 49559 
       
 49560         Revert my change to the default fill color.  Just set the color to transparent explicitly when
       
 49561         drawing textarea resizer frames.
       
 49562 
       
 49563         * platform/graphics/GraphicsContext.cpp:
       
 49564         (WebCore::GraphicsContextState::GraphicsContextState):
       
 49565         * rendering/RenderLayer.cpp:
       
 49566         (WebCore::RenderLayer::paintOverflowControls):
       
 49567 
       
 49568 2007-02-25  Sam Weinig  <sam@webkit.org>
       
 49569 
       
 49570         Update forgotten files.
       
 49571 
       
 49572         * rendering/RenderLayer.cpp:
       
 49573         (WebCore::RenderLayer::updateLayerPosition):
       
 49574 
       
 49575 2007-02-25  David Hyatt  <hyatt@apple.com>
       
 49576 
       
 49577         Fix for regression caused by changing the containing block of positioned elements with no positioned ancestor
       
 49578         to be the initial containing block (represented in our tree by the RenderView).  Rework RenderView's layout
       
 49579         to have very few special cases.   Now it will just relayout its children when the width/height of the
       
 49580         view actually changes.  Positioned elements no longer get a special additional layout, since width/height
       
 49581         adjustments are caught by the base class already anyway.
       
 49582 
       
 49583         Reviewed by mjs, darin
       
 49584 
       
 49585         * rendering/RenderBlock.cpp:
       
 49586         (WebCore::RenderBlock::layoutBlock):
       
 49587         * rendering/RenderFlexibleBox.cpp:
       
 49588         (WebCore::RenderFlexibleBox::layoutBlock):
       
 49589         (WebCore::RenderFlexibleBox::layoutVerticalBox):
       
 49590         * rendering/RenderView.cpp:
       
 49591         (WebCore::RenderView::RenderView):
       
 49592         (WebCore::RenderView::layout):
       
 49593         * rendering/RenderView.h:
       
 49594 
       
 49595 2007-02-25  Maciej Stachowiak  <mjs@apple.com>
       
 49596 
       
 49597         Not reviewed, build fix.
       
 49598 
       
 49599         - fix build breakage
       
 49600 
       
 49601         * platform/gdk/ScrollViewGdk.cpp:
       
 49602         (WebCore::ScrollView::fullyClippedContentRect):
       
 49603         * platform/qt/ScrollViewQt.cpp:
       
 49604         (WebCore::ScrollView::fullyClippedContentRect):
       
 49605 
       
 49606 2007-02-24  Maciej Stachowiak  <mjs@apple.com>
       
 49607 
       
 49608         Reviewed by Adam.
       
 49609 
       
 49610         - fixed layout test failure in fast/overflow/scrollRevealButton
       
 49611         
       
 49612         I added a new ScrollView method, fullyClippedContentRect, that vies the content rect
       
 49613         as clipped by all ancestor scroll views, not just this one. Currently it only works
       
 49614         correctly on mac however. visibleContentRect, only accounting for the clipping from
       
 49615         this particular scroll view, is sufficient for most purposes.
       
 49616 
       
 49617         * page/Frame.cpp:
       
 49618         (WebCore::Frame::visibleSelectionRect):
       
 49619         (WebCore::Frame::setIsActive):
       
 49620         (WebCore::Frame::markAllMatchesForText):
       
 49621         * platform/ScrollView.h:
       
 49622         * platform/gdk/ScrollViewGdk.cpp:
       
 49623         (WebCore::ScrolView::fullyClippedContentRect):
       
 49624         * platform/mac/ScrollViewMac.mm:
       
 49625         (WebCore::ScrollView::fullyClippedContentRect):
       
 49626         * platform/qt/ScrollViewQt.cpp:
       
 49627         (WebCore::ScrolView::fullyClippedContentRect):
       
 49628         * rendering/RenderLayer.cpp:
       
 49629         (WebCore::RenderLayer::scrollRectToVisible):
       
 49630 
       
 49631 2007-02-24  Adam Roben  <aroben@apple.com>
       
 49632 
       
 49633         Reviewed by Steve.
       
 49634 
       
 49635         "Look Up in Dictionary" context menu item should be Mac-only for now,
       
 49636         since it's only implemented on that platform (<rdar://problem/5021468>)
       
 49637 
       
 49638         * platform/ContextMenu.cpp:
       
 49639         (WebCore::ContextMenu::populate): Wrap all instances of the dictionary
       
 49640         menu item in #if PLATFORM(MAC).
       
 49641 
       
 49642 2007-02-24  Geoffrey Garen  <ggaren@apple.com>
       
 49643 
       
 49644         Reviewed by Darin Adler.
       
 49645         
       
 49646         Fixed <rdar://problem/4987649> leaks in BidiRun::operator new seen while 
       
 49647         running WebKit unit tests
       
 49648         
       
 49649         In bidi.cpp, some functions allocate BidiRuns and put them in a global data
       
 49650         structure, while others uses the BidiRuns in the global data structure. 
       
 49651         The caller is responsible for knowing which functions may allocate runs
       
 49652         and which may use them, and calling deleteBidiRuns() at the appropriate time.
       
 49653 
       
 49654         The fix is to add some calls to deleteBidiRuns() where they were missing.
       
 49655         
       
 49656         I also added a BidiRun counter because these two leaks were introduced by
       
 49657         our two bidi.cpp experts, so the odds that leaks will creep in again
       
 49658         in the future seem pretty high.
       
 49659 
       
 49660         * rendering/bidi.cpp:
       
 49661         (WebCore::RenderBlock::bidiReorderCharacters): Added  missing call to
       
 49662         deleteBidiRuns().
       
 49663         (WebCore::BidiRunCounter::~BidiRunCounter):
       
 49664         (WebCore::BidiRun::operator delete):
       
 49665         (WebCore::RenderBlock::layoutInlineChildren): Added missing call to
       
 49666         deleteBidiRuns(). Moved call to deleteBidiRuns() to same scope as call to
       
 49667         bidiReorderLine(), to emphasize that they go together like new/delete.
       
 49668         In theory, the old code was just as good, but I didn't want to rely on
       
 49669         theory.
       
 49670 
       
 49671 2007-02-24  David Harrison  <harrison@apple.com>
       
 49672 
       
 49673         Reviewed by Kevin.
       
 49674 
       
 49675         <rdar://problem/4961431> Image with empty string alt tag should be ignored
       
 49676 
       
 49677         * bridge/mac/WebCoreAXObject.mm:
       
 49678         (-[WebCoreAXObject accessibilityIsIgnored]):
       
 49679         Ignore img element that has an alt attribute, but that string is empty.
       
 49680 
       
 49681 2007-02-24  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 49682 
       
 49683         Reviewed by Adam Roben.
       
 49684 
       
 49685         Gdk improvements.
       
 49686 
       
 49687         * platform/gdk/FrameGdk.cpp: only scroll on keydown, not both keydown and keyup.
       
 49688         (WebCore::FrameGdk::keyPress):
       
 49689         (WebCore::FrameGdk::handleGdkEvent):
       
 49690         (WebCore::Frame::print):
       
 49691         (WebCore::Frame::issueTransposeCommand):
       
 49692         (WebCore::Frame::respondToChangedSelection):
       
 49693         (WebCore::Frame::cleanupPlatformScriptObjects):
       
 49694         (WebCore::Frame::dragImageForSelection):
       
 49695         * platform/network/gdk/ResourceHandleManager.cpp: don't free memory that
       
 49696         doesn't belong to us.
       
 49697         (WebCore::ResourceHandleManager::downloadTimerCallback):
       
 49698 
       
 49699 2007-02-23  Kevin Decker <kdecker@apple.com>
       
 49700 
       
 49701         Reviewed by Anders.
       
 49702 
       
 49703         Fixed: <rdar://problem/4971226> REGRESSION: Replying to closed HTML mail message does not quote original body (12503)
       
 49704         
       
 49705         There were two problems here:
       
 49706         
       
 49707         * page/mac/WebCoreFrameBridge.mm:
       
 49708         (+[WebCoreFrameBridge stringWithData:textEncodingName:]): The old code said  "if there is no text encoding name than
       
 49709          assume WindowsLatin1 (iso-8859-1) and try to decode that". That's not sufficient because it doesn't handle the fallback
       
 49710          case for unknown encodings. This method will now attempt to decode using WindowsLatin1 for unknown encoding types.
       
 49711         * platform/mac/mac-encodings.txt: Added the missing "macroman" encoding type. 
       
 49712 
       
 49713 2007-02-23  Mitz Pettel  <mitz@webkit.org>
       
 49714 
       
 49715         Reviewed by Maciej.
       
 49716 
       
 49717         - fix http://bugs.webkit.org/show_bug.cgi?id=12856
       
 49718           REGRESSION (r13685): Canceling the suggestion popup does not revert the change
       
 49719 
       
 49720         * editing/ReplaceSelectionCommand.cpp:
       
 49721         (WebCore::ReplaceSelectionCommand::doApply): If the fragment to be inserted
       
 49722         is empty, first delete the selection, and only then bail out. 
       
 49723 
       
 49724 2007-02-23  Anders Carlsson  <acarlsson@apple.com>
       
 49725 
       
 49726         Reviewed by Adam.
       
 49727 
       
 49728         <rdar://problem/5001923> 
       
 49729         REGRESSION: Crash when navigating forward from an error page in WebFrameLoaderClient::dispatchDidReceiveContentLength
       
 49730 
       
 49731         Fix an error that was introduced in revision r18541. We should check if the provisional document loader 
       
 49732         has an unreachable URL, not the actual document loader.
       
 49733         
       
 49734         * loader/FrameLoader.cpp:
       
 49735         (WebCore::FrameLoader::updateHistoryForCommit):
       
 49736 
       
 49737 2007-02-23  Mitz Pettel  <mitz@webkit.org>
       
 49738 
       
 49739         Reviewed by Darin.
       
 49740 
       
 49741         - fix http://bugs.webkit.org/show_bug.cgi?id=12823
       
 49742           REGRESSION(r16968-16977): unable to prevent selection by cancelling "selectstart" event
       
 49743 
       
 49744         Test: fast/events/selectstart-during-autoscroll.html
       
 49745 
       
 49746         * rendering/RenderLayer.cpp:
       
 49747         (WebCore::RenderLayer::autoscroll): Invoke the renderer's shouldSelect() --
       
 49748         which dispatches the selection DOM event and gives it a chance to cancel
       
 49749         the selection -- before updating the selection during autoscroll.
       
 49750 
       
 49751 2007-02-23  Oliver Hunt  <oliver@apple.com>
       
 49752 
       
 49753         Reviewed by Adam.
       
 49754 
       
 49755         Fix for http://bugs.webkit.org/show_bug.cgi?id=12870
       
 49756 
       
 49757         It turns out short circuiting DragData::containsURL() was bad
       
 49758  
       
 49759         * manual-tests/directory-drop-on-view.html: Added.
       
 49760         * platform/mac/DragDataMac.mm:
       
 49761         (WebCore::DragData::containsURL):
       
 49762 
       
 49763 2007-02-23  Maciej Stachowiak  <mjs@apple.com>
       
 49764 
       
 49765         Reviewed by Mitz.
       
 49766 
       
 49767         - 12.5% speedup on BenchJS test 6
       
 49768         Partial fix for http://bugs.webkit.org/show_bug.cgi?id=12866
       
 49769         
       
 49770         It turns out that calling documentVisibleRect on an NSScrollView is pretty expensive,
       
 49771         and calling visibleRect even more so. Take measures to call them less often.
       
 49772 
       
 49773         * platform/mac/ScrollViewMac.mm:
       
 49774         (WebCore::ScrollView::visibleContentRect): Use documentVisibleRect when possible.
       
 49775         (WebCore::ScrollView::updateContents): Use visibleContentRect to be able to use
       
 49776         documentVisibleRect when possible.
       
 49777         * rendering/RenderView.cpp:
       
 49778         (WebCore::RenderView::repaintViewRectangle): Don't get or intersect with viewRect
       
 49779         if we don't have a parent frame, since the ScrollView will do that anyway. Also,
       
 49780         don't get contentX and contentY separately since they are in the viewRect already.
       
 49781         (WebCore::RenderView::viewRect): Use visibleContentRect instead of getting each
       
 49782         coordinate individually, to avoid calling documentVisibleRect repeatedly.
       
 49783 
       
 49784 2007-02-23  Maciej Stachowiak  <mjs@apple.com>
       
 49785 
       
 49786         Reviewed by Mitz.
       
 49787 
       
 49788         - 2% speedup on BenchJS test 6
       
 49789         Partial fix for http://bugs.webkit.org/show_bug.cgi?id=12866
       
 49790 
       
 49791         * css/CSSPrimitiveValue.cpp:
       
 49792         (WebCore::CSSPrimitiveValue::cssText): Use format() instead of
       
 49793         number() followed by append of a constant string.
       
 49794 
       
 49795 2007-02-22  George Staikos  <staikos@kde.org>
       
 49796 
       
 49797         Fix the Qt build.
       
 49798 
       
 49799         * platform/qt/ClipboardQt.cpp:
       
 49800         (WebCore::ClipboardQt::ClipboardQt):
       
 49801 
       
 49802 2007-02-22  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 49803 
       
 49804         Reviewed by Adam Roben, who never sleeps.
       
 49805 
       
 49806         To avoid code duplication, move notImplementedGdk() macro to a separate
       
 49807         header file. Remove existing notImplementedGdk() macros and replace
       
 49808         remaining notImplemented() to notImplementedGdk() in gdk code.
       
 49809 
       
 49810         * loader/gdk/DocumentLoaderGdk.cpp:
       
 49811         (WebCore::DocumentLoader::getResponseModifiedHeader):
       
 49812         * loader/gdk/FrameLoaderClientGdk.cpp:
       
 49813         (WebCore::FrameLoaderClientGdk::hasWebView):
       
 49814         (WebCore::FrameLoaderClientGdk::hasFrameView):
       
 49815         * page/gdk/ContextMenuClientGdk.cpp:
       
 49816         (WebCore::ContextMenuClientGdk::contextMenuDestroyed):
       
 49817         (WebCore::ContextMenuClientGdk::getCustomMenuFromDefaultItems):
       
 49818         (WebCore::ContextMenuClientGdk::contextMenuItemSelected):
       
 49819         (WebCore::ContextMenuClientGdk::downloadURL):
       
 49820         (WebCore::ContextMenuClientGdk::copyImageToClipboard):
       
 49821         (WebCore::ContextMenuClientGdk::searchWithGoogle):
       
 49822         (WebCore::ContextMenuClientGdk::lookUpInDictionary):
       
 49823         (WebCore::ContextMenuClientGdk::speak):
       
 49824         (WebCore::ContextMenuClientGdk::stopSpeaking):
       
 49825         * page/gdk/EventHandlerGdk.cpp:
       
 49826         * platform/gdk/CursorGdk.cpp:
       
 49827         (WebCore::Cursor::Cursor):
       
 49828         * platform/gdk/EditorClientGdk.cpp:
       
 49829         * platform/gdk/NotImplementedGdk.h: Added.
       
 49830         * platform/gdk/PopupMenuGdk.cpp:
       
 49831         (WebCore::PopupMenu::PopupMenu):
       
 49832         (WebCore::PopupMenu::~PopupMenu):
       
 49833         (WebCore::PopupMenu::show):
       
 49834         (WebCore::PopupMenu::hide):
       
 49835         (WebCore::PopupMenu::updateFromElement):
       
 49836         * platform/gdk/RenderThemeGdk.cpp:
       
 49837         * platform/gdk/ScreenGdk.cpp:
       
 49838         (WebCore::screenDepth):
       
 49839         (WebCore::screenDepthPerComponent):
       
 49840         (WebCore::screenIsMonochrome):
       
 49841         (WebCore::screenRect):
       
 49842         (WebCore::screenAvailableRect):
       
 49843         * platform/gdk/TemporaryLinkStubs.cpp:
       
 49844         * platform/graphics/gdk/ImageGdk.cpp:
       
 49845         (WebCore::Image::drawPattern):
       
 49846         * platform/network/gdk/ResourceHandleCurl.cpp:
       
 49847         (WebCore::ResourceHandle::setDefersLoading):
       
 49848         * platform/network/gdk/ResourceHandleManager.cpp:
       
 49849         (WebCore::ResourceHandleManager::setupPUT):
       
 49850         (WebCore::ResourceHandleManager::setupPOST):
       
 49851 
       
 49852 2007-02-22  Ian Eng  <ian.eng.webkit@gmail.com>
       
 49853 
       
 49854         Reviewed by Maciej.
       
 49855 
       
 49856         - Patch for http://bugs.webkit.org/show_bug.cgi?id=12850
       
 49857           Leaks >10k objects
       
 49858 
       
 49859         and
       
 49860 
       
 49861         - http://bugs.webkit.org/show_bug.cgi?id=12853
       
 49862           add a EventListener leak counter
       
 49863 
       
 49864         Problem: RemoveEventListener leaks memory if the listener is not
       
 49865         registered.
       
 49866         Fix: Added Window::findJSEventListener function w/o creating a 
       
 49867         JSEventListener; Renamed getJSEventListener to findOrCreateJSEventListener;
       
 49868 
       
 49869         As an enhancement, added a leak counter for EventListeners.
       
 49870 
       
 49871         Added a test case, LayoutTests/fast/events/remove-event-listener.html.
       
 49872 
       
 49873         * WebCore/bindings/js/kjs_dom.cpp:
       
 49874         * WebCore/bindings/js/kjs_window.h:
       
 49875         * WebCore/bindings/js/kjs_window.cpp:
       
 49876         * WebCore/bindings/js/kjs_event.cpp: Add a leak counter.
       
 49877         * WebCore/bindings/js/JSXMLHttpRequest.cpp:
       
 49878         * LayoutTests/fast/events/remove-event-listener.html:
       
 49879 
       
 49880 2007-02-22  Anders Carlsson  <acarlsson@apple.com>
       
 49881 
       
 49882         Reviewed by Geoff.
       
 49883 
       
 49884         <rdar://problem/4998203> 
       
 49885         REGRESSION: Back-forward list gets messed up when navigating to error pages with back-forward cache turned off
       
 49886         
       
 49887         * loader/FrameLoader.cpp:
       
 49888         (WebCore::FrameLoader::load):
       
 49889         Remove call to setPolicyDocumentLoader(), the policy document loader is set immediately after, and setting it before 
       
 49890         calling shouldReloadToHandleUnreachableURL causes us to get the wrong URL.
       
 49891         
       
 49892         (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
       
 49893         Check if the unreachable URL is equal to the document loader's request.
       
 49894         
       
 49895         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
       
 49896         Check the provisional document loader's unreachable URL.
       
 49897 
       
 49898 2007-02-22  Justin Garcia  <justin.garcia@apple.com>
       
 49899 
       
 49900         Reviewed by darin
       
 49901         
       
 49902         <rdar://problem/5007143>
       
 49903         REGRESSION: WebKit doesn't remember horizontal position of caret when moving forward by line
       
 49904 
       
 49905         * editing/SelectionController.cpp:
       
 49906         (WebCore::SelectionController::SelectionController): Initialize 
       
 49907         m_xPosForVerticalArrowNavigation.
       
 49908         (WebCore::SelectionController::setSelection): Call the new setter.
       
 49909         (WebCore::SelectionController::modifyMovingRightForward): For line
       
 49910         and paragraph granularities, use the saved xPosForVerticalArrowNavigation 
       
 49911         even if the old selection was a range. Use the x position of the 
       
 49912         *start*, not the end of the selection if there is no saved 
       
 49913         xPosForVerticalArrowNavigation.  This matches TextEdit's behavior.
       
 49914         (WebCore::SelectionController::modifyMovingLeftBackward): For line
       
 49915         and paragraph granularities, use the saved xPosForVerticalArrowNavigation 
       
 49916         even if the old selection was a range.
       
 49917         (WebCore::SelectionController::modify): Preserve the xPosForVerticalArrowNavigation
       
 49918         for line and paragraph granularities.
       
 49919         (WebCore::SelectionController::xPosForVerticalArrowNavigation): Removed
       
 49920         the recalc bool because it is now always false.
       
 49921         (WebCore::SelectionController::setXPosForVerticalArrowNavigation): Added.
       
 49922         * editing/SelectionController.h: Moved m_xPosForVerticalArrowNavigation
       
 49923         from Frame.
       
 49924         * page/Frame.cpp: Moved m_xPosForVerticalArrowNavigation to SelectionController.
       
 49925         * page/Frame.h: Ditto.
       
 49926         * page/FramePrivate.h: Ditto.
       
 49927 
       
 49928 2007-02-22  Beth Dakin  <bdakin@apple.com>
       
 49929 
       
 49930         Reviewed by Adam. Manual test added.
       
 49931 
       
 49932         Fix for http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION: 
       
 49933         Unable to prevent default context menu from appearing. <rdar://
       
 49934         problem/5017416>
       
 49935 
       
 49936         This problem appeared because of two facets of the current context 
       
 49937         menu design. First, all context menu events are now considered to 
       
 49938         be "swallowed" since we take care of building up the regular 
       
 49939         context menu through the defaultEventHandler(). Second, the context 
       
 49940         menu controller holds onto it's context menu until a new one is 
       
 49941         created. There would be logistical problems changing this since 
       
 49942         AppKit relies on the menu being around for as long as it is
       
 49943         visible on the screen and we don't get any notification once the 
       
 49944         menu is popped-down.
       
 49945 
       
 49946         This patch fixes the problem by giving WebKit a way to clear the 
       
 49947         controller's context menu. WebKit now clears the menu before it 
       
 49948         propagates a new context menu event through the DOM.
       
 49949 
       
 49950         * WebCore.exp:
       
 49951         * manual-tests/DOMContextMenuEvent.html: Added.
       
 49952         * page/ContextMenuController.cpp:
       
 49953         (WebCore::ContextMenuController::clearContextMenu):
       
 49954         * page/ContextMenuController.h:
       
 49955 
       
 49956 2007-02-22  John Sullivan  <sullivan@apple.com>
       
 49957 
       
 49958         Reviewed by Kevin and Adele
       
 49959         
       
 49960         - fixed <rdar://problem/4129417> Need final art for textarea's resize corner
       
 49961         
       
 49962         This probably broke some layout pixel tests since the image changed. I'm going to
       
 49963         track those down in a moment (non-trivial since there are a bunch failing for other
       
 49964         reasons).
       
 49965 
       
 49966         * Resources/textAreaResizeCorner.tiff:
       
 49967         new art
       
 49968 
       
 49969         * Resources/deleteButton.tiff:
       
 49970         * Resources/deleteButtonPressed.tiff:
       
 49971         these got smaller when I ran compress-tiffs on this directory
       
 49972         
       
 49973 2007-02-22  Oliver Hunt  <oliver@apple.com>
       
 49974 
       
 49975         Reviewed by Ada, Lou and Steve.
       
 49976 
       
 49977         Moving basic components of ClipboardMac to Clipboard, 
       
 49978         last of the basic common code merge will come later (namely setting the 
       
 49979         drag element/image).
       
 49980         
       
 49981         Tidying up in DragController including a few bad PassRefPtr uses and
       
 49982         removing unnecessary accessors.  Also initialise fields properly to
       
 49983         fix <rdar:/problems/5014889>
       
 49984 
       
 49985         * dom/Clipboard.cpp:
       
 49986         (WebCore::Clipboard::Clipboard):
       
 49987           New constructor
       
 49988           
       
 49989         * dom/Clipboard.h:
       
 49990         (WebCore::Clipboard::isForDragging):
       
 49991         (WebCore::Clipboard::dragLocation):
       
 49992         (WebCore::Clipboard::dragImage):
       
 49993         (WebCore::Clipboard::dragImageElement):
       
 49994           Exposing common data
       
 49995           
       
 49996         * page/DragController.cpp:
       
 49997         (WebCore::DragController::DragController):
       
 49998           Initialise m_isHandlingDrag (oops)
       
 49999         (WebCore::documentFragmentFromDragData):
       
 50000         (WebCore::DragController::tryDocumentDrag):
       
 50001           Fixing PassRefPtr misuse
       
 50002         (WebCore::DragController::canProcessDrag):
       
 50003         (WebCore::DragController::startDrag):
       
 50004         (WebCore::DragController::doSystemDrag):
       
 50005           Make sure we're using the correct coordinate space
       
 50006           
       
 50007         * page/EventHandler.cpp:
       
 50008         (WebCore::EventHandler::handleDrag):
       
 50009           Reset drag source correctly
       
 50010           
       
 50011         * platform/mac/ClipboardMac.h:
       
 50012         * platform/mac/ClipboardMac.mm:
       
 50013         (WebCore::ClipboardMac::ClipboardMac):
       
 50014           update constructor to use new Clipboard constructor
       
 50015 
       
 50016 2007-02-22  Adele Peterson  <adele@apple.com>
       
 50017 
       
 50018         Reviewed by Darin.
       
 50019 
       
 50020         Fix for <rdar://problem/5014970> 9A374: Tabs don't work in the message body
       
 50021 
       
 50022         Test: fast/events/keypress-insert-tab.html
       
 50023 
       
 50024         * page/EventHandler.cpp: (WebCore::EventHandler::defaultTextInputEventHandler):
       
 50025           If the defaultTabEventHandler doesn't handle the event, then go on to the insertText case.
       
 50026 
       
 50027 2007-02-22  Timothy Hatcher  <timothy@apple.com>
       
 50028 
       
 50029         Reviewed by Darin.
       
 50030 
       
 50031         <rdar://problem/4948887> REGRESSION: Correct differences in public DOM API that inadvertently changed in Leopard
       
 50032 
       
 50033         * bindings/objc/PublicDOMInterfaces.h: Changes return types for two size properties, adds deprecated DOMEventTarget methods.
       
 50034         * bindings/scripts/CodeGeneratorObjC.pm: Fixed public API checking for protocols, adds support for ConvertToString.
       
 50035         * dom/EventTarget.idl: Marks addEventListener and removeEventListener with the OldStyleObjC attribute.
       
 50036         * html/HTMLBaseFontElement.idl: Changes the size property to a DOMString for ObjC only.
       
 50037         * html/HTMLInputElement.idl: Changes the size property to a DOMString for ObjC only.
       
 50038         * html/HTMLOptionsCollection.idl: Changes the length property to be unsigned.
       
 50039 
       
 50040 2007-02-22  Adele Peterson  <adele@apple.com>
       
 50041 
       
 50042         Reviewed by John.
       
 50043 
       
 50044         Fix <rdar://problem/5016969> REGRESSION: "Check Spelling As You Type" context menu item is never checked
       
 50045 
       
 50046         * platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): Set shouldCheck for ContextMenuItemTagCheckSpellingWhileTyping.
       
 50047 
       
 50048 2007-02-22  Antti Koivisto  <antti@apple.com>
       
 50049 
       
 50050         Reviewed by Darin.
       
 50051 
       
 50052         - fix http://bugs.webkit.org/show_bug.cgi?id=11447
       
 50053         REGRESSION(NativeListBox): List not scrolled to preselected option
       
 50054         <rdar://problem/4957463>
       
 50055         
       
 50056         Initiate scroll when selected <option> is added to <select>.
       
 50057 
       
 50058         * html/HTMLOptionElement.cpp:
       
 50059         (WebCore::HTMLOptionElement::insertedIntoDocument):
       
 50060         * html/HTMLOptionElement.h:
       
 50061         * html/HTMLSelectElement.cpp:
       
 50062         (WebCore::HTMLSelectElement::notifyOptionSelected):
       
 50063         (WebCore::HTMLSelectElement::updateListBoxSelection):
       
 50064         (WebCore::HTMLSelectElement::scrollToSelection):
       
 50065         * html/HTMLSelectElement.h:
       
 50066 
       
 50067 2007-02-22  Zack Rusin  <zrusin@trolltech.com>
       
 50068 
       
 50069         Reviewed by Lars
       
 50070 
       
 50071         Fix sites with fixed positioned backgrounds.
       
 50072 
       
 50073         * platform/qt/ScrollViewQt.cpp:
       
 50074         (WebCore::ScrollView::setStaticBackground):
       
 50075 
       
 50076 2007-02-22  Zack Rusin  <zrusin@trolltech.com>
       
 50077 
       
 50078         Reviewed by Lars
       
 50079 
       
 50080         Properly implement canvas/scrollview's. Get
       
 50081         rid of ScrollViewCanvas and replace it with
       
 50082         a tailor abstractscrollview (now in qwebframe).
       
 50083         Scrolling of pages is finally completely smooth.
       
 50084 
       
 50085         * WebCore.pro:
       
 50086         * platform/ScrollView.h:
       
 50087         * platform/qt/ScrollViewCanvasQt.cpp: Removed.
       
 50088         * platform/qt/ScrollViewCanvasQt.h: Removed.
       
 50089         * platform/qt/ScrollViewQt.cpp:
       
 50090         (WebCore::ScrollView::ScrollView):
       
 50091         (WebCore::ScrollView::setScrollArea):
       
 50092         (WebCore::ScrollView::updateContents):
       
 50093         (WebCore::ScrollView::resizeContents):
       
 50094         (WebCore::ScrollView::contentsWidth):
       
 50095         (WebCore::ScrollView::contentsHeight):
       
 50096         (WebCore::ScrollView::contentsToWindow):
       
 50097         (WebCore::ScrollView::windowToContents):
       
 50098         (WebCore::ScrollView::addChild):
       
 50099         * platform/qt/WidgetQt.cpp:
       
 50100         (WebCore::WidgetPrivate::canvas):
       
 50101         (WebCore::WidgetPrivate::parentScroll):
       
 50102         (WebCore::WidgetPrivate::setGeometry):
       
 50103         (WebCore::WidgetPrivate::geometry):
       
 50104         (WebCore::Widget::frameGeometry):
       
 50105         (WebCore::Widget::setQWidget):
       
 50106         (WebCore::Widget::setFrameGeometry):
       
 50107 
       
 50108 2007-02-21  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 50109 
       
 50110         Reviewed by Adam Roben.
       
 50111 
       
 50112         Improve notImplemented() macro for gdk. Rename to notImplementedGdk() to
       
 50113         give it a unique name (so that it doesn't clash with notImplemented()
       
 50114         for other platforms).
       
 50115         Make it print a given warning only once, so that frequently called
       
 50116         functions don't clutter the output.
       
 50117         Don't print the warning if DISABLE_NI_WARNING env variable is set.
       
 50118 
       
 50119         * loader/gdk/FrameLoaderClientGdk.cpp:
       
 50120         (WebCore::FrameLoaderClientGdk::dispatchDidReceiveAuthenticationChallenge):
       
 50121         (WebCore::FrameLoaderClientGdk::dispatchDidCancelAuthenticationChallenge):
       
 50122         (WebCore::FrameLoaderClientGdk::dispatchWillSendRequest):
       
 50123         (WebCore::FrameLoaderClientGdk::assignIdentifierToInitialRequest):
       
 50124         (WebCore::FrameLoaderClientGdk::createPlugin):
       
 50125         (WebCore::FrameLoaderClientGdk::createFrame):
       
 50126         (WebCore::FrameLoaderClientGdk::redirectDataToPlugin):
       
 50127         (WebCore::FrameLoaderClientGdk::createJavaAppletWidget):
       
 50128         (WebCore::FrameLoaderClientGdk::objectContentType):
       
 50129         (WebCore::FrameLoaderClientGdk::overrideMediaType):
       
 50130         (WebCore::FrameLoaderClientGdk::windowObjectCleared):
       
 50131         (WebCore::FrameLoaderClientGdk::hasWebView):
       
 50132         (WebCore::FrameLoaderClientGdk::hasFrameView):
       
 50133         (WebCore::FrameLoaderClientGdk::frameLoadCompleted):
       
 50134         (WebCore::FrameLoaderClientGdk::saveViewStateToItem):
       
 50135         (WebCore::FrameLoaderClientGdk::restoreViewState):
       
 50136         (WebCore::FrameLoaderClientGdk::privateBrowsingEnabled):
       
 50137         (WebCore::FrameLoaderClientGdk::makeDocumentView):
       
 50138         (WebCore::FrameLoaderClientGdk::makeRepresentation):
       
 50139         (WebCore::FrameLoaderClientGdk::forceLayout):
       
 50140         (WebCore::FrameLoaderClientGdk::forceLayoutForNonHTML):
       
 50141         (WebCore::FrameLoaderClientGdk::setCopiesOnScroll):
       
 50142         (WebCore::FrameLoaderClientGdk::detachedFromParent1):
       
 50143         (WebCore::FrameLoaderClientGdk::detachedFromParent2):
       
 50144         (WebCore::FrameLoaderClientGdk::detachedFromParent3):
       
 50145         (WebCore::FrameLoaderClientGdk::detachedFromParent4):
       
 50146         (WebCore::FrameLoaderClientGdk::loadedFromPageCache):
       
 50147         (WebCore::FrameLoaderClientGdk::dispatchDidHandleOnloadEvents):
       
 50148         (WebCore::FrameLoaderClientGdk::dispatchDidReceiveServerRedirectForProvisionalLoad):
       
 50149         (WebCore::FrameLoaderClientGdk::dispatchDidCancelClientRedirect):
       
 50150         (WebCore::FrameLoaderClientGdk::dispatchWillPerformClientRedirect):
       
 50151         (WebCore::FrameLoaderClientGdk::dispatchDidChangeLocationWithinPage):
       
 50152         (WebCore::FrameLoaderClientGdk::dispatchWillClose):
       
 50153         (WebCore::FrameLoaderClientGdk::dispatchDidReceiveIcon):
       
 50154         (WebCore::FrameLoaderClientGdk::dispatchDidStartProvisionalLoad):
       
 50155         (WebCore::FrameLoaderClientGdk::dispatchDidReceiveTitle):
       
 50156         (WebCore::FrameLoaderClientGdk::dispatchDidCommitLoad):
       
 50157         (WebCore::FrameLoaderClientGdk::dispatchDidFinishDocumentLoad):
       
 50158         (WebCore::FrameLoaderClientGdk::dispatchDidFirstLayout):
       
 50159         (WebCore::FrameLoaderClientGdk::dispatchShow):
       
 50160         (WebCore::FrameLoaderClientGdk::cancelPolicyCheck):
       
 50161         (WebCore::FrameLoaderClientGdk::dispatchDidLoadMainResource):
       
 50162         (WebCore::FrameLoaderClientGdk::revertToProvisionalState):
       
 50163         (WebCore::FrameLoaderClientGdk::clearUnarchivingState):
       
 50164         (WebCore::FrameLoaderClientGdk::willChangeTitle):
       
 50165         (WebCore::FrameLoaderClientGdk::finishedLoading):
       
 50166         (WebCore::FrameLoaderClientGdk::finalSetupForReplace):
       
 50167         (WebCore::FrameLoaderClientGdk::setDefersLoading):
       
 50168         (WebCore::FrameLoaderClientGdk::isArchiveLoadPending):
       
 50169         (WebCore::FrameLoaderClientGdk::cancelPendingArchiveLoad):
       
 50170         (WebCore::FrameLoaderClientGdk::clearArchivedResources):
       
 50171         (WebCore::FrameLoaderClientGdk::canHandleRequest):
       
 50172         (WebCore::FrameLoaderClientGdk::canShowMIMEType):
       
 50173         (WebCore::FrameLoaderClientGdk::representationExistsForURLScheme):
       
 50174         (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme):
       
 50175         (WebCore::FrameLoaderClientGdk::provisionalLoadStarted):
       
 50176         (WebCore::FrameLoaderClientGdk::didFinishLoad):
       
 50177         (WebCore::FrameLoaderClientGdk::prepareForDataSourceReplacement):
       
 50178         (WebCore::FrameLoaderClientGdk::setTitle):
       
 50179         (WebCore::FrameLoaderClientGdk::setDocumentViewFromPageCache):
       
 50180         (WebCore::FrameLoaderClientGdk::dispatchDidReceiveContentLength):
       
 50181         (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading):
       
 50182         (WebCore::FrameLoaderClientGdk::dispatchDidFailLoading):
       
 50183         (WebCore::FrameLoaderClientGdk::dispatchDidLoadResourceFromMemoryCache):
       
 50184         (WebCore::FrameLoaderClientGdk::dispatchDidFailProvisionalLoad):
       
 50185         (WebCore::FrameLoaderClientGdk::dispatchDidFailLoad):
       
 50186         (WebCore::FrameLoaderClientGdk::download):
       
 50187         (WebCore::FrameLoaderClientGdk::cancelledError):
       
 50188         (WebCore::FrameLoaderClientGdk::cannotShowURLError):
       
 50189         (WebCore::FrameLoaderClientGdk::interruptForPolicyChangeError):
       
 50190         (WebCore::FrameLoaderClientGdk::cannotShowMIMETypeError):
       
 50191         (WebCore::FrameLoaderClientGdk::fileDoesNotExistError):
       
 50192         (WebCore::FrameLoaderClientGdk::shouldFallBack):
       
 50193         (WebCore::FrameLoaderClientGdk::willUseArchive):
       
 50194         (WebCore::FrameLoaderClientGdk::saveDocumentViewToPageCache):
       
 50195         (WebCore::FrameLoaderClientGdk::canCachePage):
       
 50196         (WebCore::FrameLoaderClientGdk::dispatchCreatePage):
       
 50197         (WebCore::FrameLoaderClientGdk::dispatchUnableToImplementPolicy):
       
 50198         (WebCore::FrameLoaderClientGdk::setMainDocumentError):
       
 50199         (WebCore::FrameLoaderClientGdk::startDownload):
       
 50200         (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForStandardLoad):
       
 50201         (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForReload):
       
 50202         (WebCore::FrameLoaderClientGdk::shouldGoToHistoryItem):
       
 50203         * page/gdk/EventHandlerGdk.cpp:
       
 50204         (WebCore::EventHandler::passMouseDownEventToWidget):
       
 50205         (WebCore::EventHandler::eventActivatedView):
       
 50206         (WebCore::EventHandler::passSubframeEventToSubframe):
       
 50207         (WebCore::EventHandler::passWheelEventToWidget):
       
 50208         (WebCore::EventHandler::createDraggingClipboard):
       
 50209         * platform/gdk/EditorClientGdk.cpp:
       
 50210         (WebCore::EditorClientGdk::shouldDeleteRange):
       
 50211         (WebCore::EditorClientGdk::isContinuousSpellCheckingEnabled):
       
 50212         (WebCore::EditorClientGdk::isGrammarCheckingEnabled):
       
 50213         (WebCore::EditorClientGdk::spellCheckerDocumentTag):
       
 50214         (WebCore::EditorClientGdk::shouldBeginEditing):
       
 50215         (WebCore::EditorClientGdk::shouldEndEditing):
       
 50216         (WebCore::EditorClientGdk::shouldInsertText):
       
 50217         (WebCore::EditorClientGdk::shouldChangeSelectedRange):
       
 50218         (WebCore::EditorClientGdk::shouldApplyStyle):
       
 50219         (WebCore::EditorClientGdk::didBeginEditing):
       
 50220         (WebCore::EditorClientGdk::respondToChangedContents):
       
 50221         (WebCore::EditorClientGdk::didEndEditing):
       
 50222         (WebCore::EditorClientGdk::didWriteSelectionToPasteboard):
       
 50223         (WebCore::EditorClientGdk::didSetSelectionTypesForPasteboard):
       
 50224         (WebCore::EditorClientGdk::selectWordBeforeMenuEvent):
       
 50225         (WebCore::EditorClientGdk::isEditable):
       
 50226         (WebCore::EditorClientGdk::registerCommandForUndo):
       
 50227         (WebCore::EditorClientGdk::registerCommandForRedo):
       
 50228         (WebCore::EditorClientGdk::clearUndoRedoOperations):
       
 50229         (WebCore::EditorClientGdk::canUndo):
       
 50230         (WebCore::EditorClientGdk::canRedo):
       
 50231         (WebCore::EditorClientGdk::undo):
       
 50232         (WebCore::EditorClientGdk::redo):
       
 50233         (WebCore::EditorClientGdk::shouldInsertNode):
       
 50234         (WebCore::EditorClientGdk::pageDestroyed):
       
 50235         (WebCore::EditorClientGdk::smartInsertDeleteEnabled):
       
 50236         (WebCore::EditorClientGdk::toggleContinuousSpellChecking):
       
 50237         (WebCore::EditorClientGdk::textFieldDidBeginEditing):
       
 50238         (WebCore::EditorClientGdk::textFieldDidEndEditing):
       
 50239         (WebCore::EditorClientGdk::textDidChangeInTextField):
       
 50240         (WebCore::EditorClientGdk::doTextFieldCommandFromEvent):
       
 50241         (WebCore::EditorClientGdk::textWillBeDeletedInTextField):
       
 50242         (WebCore::EditorClientGdk::textDidChangeInTextArea):
       
 50243         * platform/gdk/RenderThemeGdk.cpp:
       
 50244         (WebCore::RenderThemeGdk::setCheckboxSize):
       
 50245         (WebCore::RenderThemeGdk::setRadioSize):
       
 50246         (WebCore::RenderThemeGdk::adjustTextFieldStyle):
       
 50247         * platform/gdk/TemporaryLinkStubs.cpp:
       
 50248         (FrameView::updateBorder):
       
 50249         (Widget::setEnabled):
       
 50250         (Widget::isEnabled):
       
 50251         (Widget::focusPolicy):
       
 50252         (Widget::enableFlushDrawing):
       
 50253         (Widget::disableFlushDrawing):
       
 50254         (Widget::lockDrawingFocus):
       
 50255         (Widget::unlockDrawingFocus):
       
 50256         (Widget::removeFromParent):
       
 50257         (Widget::paint):
       
 50258         (Widget::setIsSelected):
       
 50259         (Widget::invalidate):
       
 50260         (Widget::invalidateRect):
       
 50261         (PlatformMouseEvent::PlatformMouseEvent):
       
 50262         (WebCore::findNextSentenceFromIndex):
       
 50263         (WebCore::findSentenceBoundary):
       
 50264         (WebCore::findNextWordFromIndex):
       
 50265         (ChromeClientGdk::chromeDestroyed):
       
 50266         (ChromeClientGdk::windowRect):
       
 50267         (ChromeClientGdk::setWindowRect):
       
 50268         (ChromeClientGdk::pageRect):
       
 50269         (ChromeClientGdk::scaleFactor):
       
 50270         (ChromeClientGdk::focus):
       
 50271         (ChromeClientGdk::unfocus):
       
 50272         (ChromeClientGdk::createWindow):
       
 50273         (ChromeClientGdk::createModalDialog):
       
 50274         (ChromeClientGdk::show):
       
 50275         (ChromeClientGdk::canRunModal):
       
 50276         (ChromeClientGdk::runModal):
       
 50277         (ChromeClientGdk::setToolbarsVisible):
       
 50278         (ChromeClientGdk::toolbarsVisible):
       
 50279         (ChromeClientGdk::setStatusbarVisible):
       
 50280         (ChromeClientGdk::statusbarVisible):
       
 50281         (ChromeClientGdk::setScrollbarsVisible):
       
 50282         (ChromeClientGdk::scrollbarsVisible):
       
 50283         (ChromeClientGdk::setMenubarVisible):
       
 50284         (ChromeClientGdk::menubarVisible):
       
 50285         (ChromeClientGdk::setResizable):
       
 50286         (ChromeClientGdk::closeWindowSoon):
       
 50287         (ChromeClientGdk::canTakeFocus):
       
 50288         (ChromeClientGdk::takeFocus):
       
 50289         (ChromeClientGdk::canRunBeforeUnloadConfirmPanel):
       
 50290         (ChromeClientGdk::addMessageToConsole):
       
 50291         (ChromeClientGdk::runBeforeUnloadConfirmPanel):
       
 50292         (ChromeClientGdk::runJavaScriptAlert):
       
 50293         (ChromeClientGdk::runJavaScriptConfirm):
       
 50294         (ChromeClientGdk::runJavaScriptPrompt):
       
 50295         (ChromeClientGdk::setStatusbarText):
       
 50296         (ChromeClientGdk::shouldInterruptJavaScript):
       
 50297         (ChromeClientGdk::tabsToLinks):
       
 50298         (ChromeClientGdk::windowResizerRect):
       
 50299         (ChromeClientGdk::addToDirtyRegion):
       
 50300         (ChromeClientGdk::scrollBackingStore):
       
 50301         (ChromeClientGdk::updateBackingStore):
       
 50302         (PlugInInfoStore::createPluginInfoForPluginAtIndex):
       
 50303         (PlugInInfoStore::pluginCount):
       
 50304         (WebCore::PlugInInfoStore::supportsMIMEType):
       
 50305         (WebCore::refreshPlugins):
       
 50306         (SearchPopupMenu::saveRecentSearches):
       
 50307         (SearchPopupMenu::loadRecentSearches):
       
 50308         (SearchPopupMenu::SearchPopupMenu):
       
 50309         (PlatformScrollbar::PlatformScrollbar):
       
 50310         (PlatformScrollbar::~PlatformScrollbar):
       
 50311         (PlatformScrollbar::setEnabled):
       
 50312         (PlatformScrollbar::paint):
       
 50313         (PlatformScrollbar::updateThumbPosition):
       
 50314         (PlatformScrollbar::updateThumbProportion):
       
 50315         (PlatformScrollbar::setRect):
       
 50316         (FileChooser::FileChooser):
       
 50317         (FileChooser::~FileChooser):
       
 50318         (FileChooser::openFileChooser):
       
 50319         (FileChooser::basenameForWidth):
       
 50320         (ResourceHandle::willLoadFromCache):
       
 50321         (ResourceHandle::loadsBlocked):
       
 50322         (ResourceHandle::loadResourceSynchronously):
       
 50323         (Icon::Icon):
       
 50324         (Icon::~Icon):
       
 50325         (Icon::newIconForFile):
       
 50326         (Icon::paint):
       
 50327         (Font::drawComplexText):
       
 50328         (Font::floatWidthForComplexText):
       
 50329         (Font::offsetForPositionForComplexText):
       
 50330         (PageCache::close):
       
 50331         (Editor::ignoreSpelling):
       
 50332         (Editor::learnSpelling):
       
 50333         (Editor::isSelectionUngrammatical):
       
 50334         (Editor::isSelectionMisspelled):
       
 50335         (Editor::guessesForMisspelledSelection):
       
 50336         (Editor::guessesForUngrammaticalSelection):
       
 50337         (Editor::markMisspellingsAfterTypingToPosition):
       
 50338         (Editor::newGeneralClipboard):
       
 50339         (Pasteboard::generalPasteboard):
       
 50340         (Pasteboard::writeSelection):
       
 50341         (Pasteboard::writeURL):
       
 50342         (Pasteboard::writeImage):
       
 50343         (Pasteboard::clear):
       
 50344         (Pasteboard::canSmartReplace):
       
 50345         (Pasteboard::documentFragment):
       
 50346         (Pasteboard::plainText):
       
 50347         (Pasteboard::Pasteboard):
       
 50348         (Pasteboard::~Pasteboard):
       
 50349         (ContextMenu::ContextMenu):
       
 50350         (ContextMenu::~ContextMenu):
       
 50351         (ContextMenu::appendItem):
       
 50352         (ContextMenuItem::ContextMenuItem):
       
 50353         (ContextMenuItem::~ContextMenuItem):
       
 50354         (ContextMenuItem::releasePlatformDescription):
       
 50355         (ContextMenuItem::type):
       
 50356         (ContextMenuItem::setType):
       
 50357         (ContextMenuItem::action):
       
 50358         (ContextMenuItem::setAction):
       
 50359         (ContextMenuItem::title):
       
 50360         (ContextMenuItem::setTitle):
       
 50361         (ContextMenuItem::platformSubMenu):
       
 50362         (ContextMenuItem::setSubMenu):
       
 50363         (ContextMenuItem::setChecked):
       
 50364         (ContextMenuItem::setEnabled):
       
 50365         (WebCore::supportedKeySizes):
       
 50366         (WebCore::systemBeep):
       
 50367         (WebCore::userIdleTime):
       
 50368 
       
 50369 2007-02-21  Antti Koivisto  <antti@apple.com>
       
 50370 
       
 50371         Reviewed by Hyatt.
       
 50372 
       
 50373         - fix http://bugs.webkit.org/show_bug.cgi?id=12820
       
 50374         REGRESSION (r19706): Caret not painted after popup, failing editing/pasteboard/4641033
       
 50375 
       
 50376         Yet another attempt to figure out exactly who should paint the caret.
       
 50377 
       
 50378         * editing/SelectionController.cpp:
       
 50379         (WebCore::SelectionController::isInsideNode):
       
 50380         * editing/SelectionController.h:
       
 50381         * rendering/RenderBlock.cpp:
       
 50382         (WebCore::RenderBlock::paintCaret):
       
 50383 
       
 50384 2007-02-21  Mitz Pettel  <mitz@webkit.org>
       
 50385 
       
 50386         Reviewed by Hyatt.
       
 50387 
       
 50388         - fix http://bugs.webkit.org/show_bug.cgi?id=12818
       
 50389           REGRESSION (r19148): shacknews.com does not render completely
       
 50390 
       
 50391         Test: fast/dynamic/staticY-marking-parents-regression.html
       
 50392 
       
 50393         Changed calls to setChildNeedsLayout(true) during layout to
       
 50394         setChildNeedsLayout(true, false). Prior to r19148, the default behavior
       
 50395         of marking containers did not matter because the caller was the container
       
 50396         and was already marked, but r19148 added marking of the parent of
       
 50397         objects with static Y, which can be different from the caller and not
       
 50398         necessarily marked already.
       
 50399 
       
 50400         * rendering/RenderBlock.cpp:
       
 50401         (WebCore::RenderBlock::collapseMargins):
       
 50402         (WebCore::RenderBlock::clearFloatsIfNeeded):
       
 50403         (WebCore::RenderBlock::layoutBlockChildren):
       
 50404         * rendering/RenderBox.cpp:
       
 50405         (WebCore::RenderBox::setStaticY):
       
 50406         * rendering/RenderFlexibleBox.cpp:
       
 50407         (WebCore::RenderFlexibleBox::layoutVerticalBox):
       
 50408 
       
 50409 2007-02-21  Brady Eidson  <beidson@apple.com>
       
 50410 
       
 50411         Reviewed by Dave Harrison
       
 50412 
       
 50413         <rdar://problem/5014313> - Crash in FrameLoader::restoreScrollPositionAndViewState() 
       
 50414         after regaining network connection
       
 50415 
       
 50416         * loader/FrameLoader.cpp:
       
 50417         (WebCore::FrameLoader::restoreScrollPositionAndViewState):  Leave an assertion for debug
       
 50418         build exploration, but gracefully handle the release build case
       
 50419 
       
 50420 2007-02-21  Timothy Hatcher  <timothy@apple.com>
       
 50421 
       
 50422         Rubber-stamped by Darin.
       
 50423 
       
 50424         * bindings/objc/PublicDOMInterfaces.h: Add missing classes that are really public.
       
 50425         Also adds the deprecated selector for getComputedStyle: on DOMDocument.
       
 50426 
       
 50427 2007-02-21  Justin Garcia  <justin.garcia@apple.com>
       
 50428 
       
 50429         Reviewed by john
       
 50430         
       
 50431         <rdar://problem/5012665>
       
 50432         Removing indent from list moves the caret to the line below
       
 50433 
       
 50434         Selection preservation during indent, outdent and list 
       
 50435         operations uses rangeFromLocationAndLength.  Ranges returned 
       
 50436         by rangeFromLocationAndLength were incorrect for locations 
       
 50437         just before the line breaks that are emitted after blocks.  
       
 50438         This is because TextIterator emitted bad ranges for these line 
       
 50439         breaks (ranges that started and ended *after* the block).  
       
 50440         The fix corrects the start but not the end.  This is acceptible 
       
 50441         because there is code in rangeFromLocationAndLength that corrects 
       
 50442         the ends of runs using the start of the run and VisiblePosition 
       
 50443         creation.
       
 50444         
       
 50445         * editing/TextIterator.cpp:
       
 50446         (WebCore::TextIterator::exitNode): Emit a position *inside* 
       
 50447         the block, after its contents.
       
 50448 
       
 50449 2007-02-21  Adele Peterson  <adele@apple.com>
       
 50450 
       
 50451         Reviewed by Darin.
       
 50452 
       
 50453         Fix for <rdar://problem/4999030> Indexing into select element to get to items in the options collection is broken
       
 50454 
       
 50455         Test: fast/forms/select-index-setter.html
       
 50456 
       
 50457         Added indexSetter for HTMLSelectElement.
       
 50458 
       
 50459         * WebCore.xcodeproj/project.pbxproj: Added JSHTMLSelectElementCustom.h
       
 50460 
       
 50461         * bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::indexSetter):
       
 50462           Moved code to selectIndexSetter so it can be shared between these classes.
       
 50463         * bindings/js/JSHTMLSelectElementCustom.cpp:
       
 50464         (WebCore::selectIndexSetter): Added.  Moved from JSHTMLOptionsCollection::indexSetter.
       
 50465         (WebCore::JSHTMLSelectElement::indexSetter): Calls selectIndexSetter.
       
 50466         * bindings/js/JSHTMLSelectElementCustom.h: Added.
       
 50467         * html/HTMLSelectElement.idl: Added HasCustomIndexSetter keyword.
       
 50468 
       
 50469         * bindings/scripts/CodeGeneratorJS.pm: When generating "put" methods, if the propertyName is a number, call the indexSetter first,
       
 50470           and then call the version of lookupPut that will also try to use the parent's lookup table.  This matches the order of our
       
 50471           old code, before we autogenerated the JSHTMLSelectElement class.
       
 50472 
       
 50473 2007-02-21  George Staikos  <staikos@kde.org>
       
 50474 
       
 50475         Reviewed by Zack.
       
 50476 
       
 50477         Add files to the build.
       
 50478 
       
 50479         * WebCore.pro:
       
 50480 
       
 50481 2007-02-21  Zack Rusin  <zrusin@trolltech.com>
       
 50482 
       
 50483         Reviewed by Lars
       
 50484 
       
 50485         Implementing popups for the Qt platform.
       
 50486 
       
 50487         * WebCore.pro:
       
 50488         * platform/PopupMenu.h:
       
 50489         * platform/Widget.h:
       
 50490         * platform/qt/PopupMenuQt.cpp:
       
 50491         (WebCore::PopupMenu::PopupMenu):
       
 50492         (WebCore::PopupMenu::clear):
       
 50493         (WebCore::PopupMenu::populate):
       
 50494         (WebCore::PopupMenu::show):
       
 50495         (WebCore::PopupMenu::hide):
       
 50496         * platform/qt/QWebPopup.cpp: Added.
       
 50497         (WebCore::QWebPopup::QWebPopup):
       
 50498         (WebCore::QWebPopup::exec):
       
 50499         (WebCore::QWebPopup::hideEvent):
       
 50500         (WebCore::QWebPopup::activeChanged):
       
 50501         * platform/qt/QWebPopup.h: Added.
       
 50502         * platform/qt/WidgetQt.cpp:
       
 50503         (WebCore::Widget::canvas):
       
 50504 
       
 50505 2007-02-21  George Staikos  <staikos@kde.org>
       
 50506 
       
 50507         Reviewed by Zack.
       
 50508 
       
 50509         Remove unneeded hack now.
       
 50510 
       
 50511         * platform/qt/RenderThemeQt.cpp:
       
 50512         (WebCore::RenderThemeQt::setCheckboxSize):
       
 50513 
       
 50514 2007-02-21  Zack Rusin  <zrusin@trolltech.com>
       
 50515 
       
 50516         Reviewed by Lars
       
 50517 
       
 50518         Fix rendering of lineedits and remove the spurious
       
 50519         padding on push-buttons.
       
 50520 
       
 50521         * platform/qt/RenderThemeQt.cpp:
       
 50522         (WebCore::RenderThemeQt::baselinePosition):
       
 50523         (WebCore::RenderThemeQt::adjustTextFieldStyle):
       
 50524         (WebCore::RenderThemeQt::sizeForFont):
       
 50525         (WebCore::RenderThemeQt::setButtonPadding):
       
 50526 
       
 50527 2007-02-21  Zack Rusin  <zrusin@trolltech.com>
       
 50528 
       
 50529         Fix compilation.
       
 50530 
       
 50531         * platform/qt/PasteboardQt.cpp:
       
 50532         (WebCore::Pasteboard::writeURL):
       
 50533         (WebCore::Pasteboard::writeImage):
       
 50534 
       
 50535 2007-02-20  Adam Roben  <aroben@apple.com>
       
 50536 
       
 50537         Preemptive build fix.
       
 50538 
       
 50539         * platform/mac/FontCacheMac.mm: Remove unused (and non-existent) header.
       
 50540 
       
 50541 2007-02-20  Adam Roben  <aroben@apple.com>
       
 50542 
       
 50543         Fix the build the right way.
       
 50544 
       
 50545         * platform/StringTruncator.cpp:
       
 50546         (WebCore::truncateString): Keep all widths as floats.
       
 50547 
       
 50548 2007-02-20  Beth Dakin  <bdakin@apple.com>
       
 50549 
       
 50550         Reviewed by Maciej.
       
 50551 
       
 50552         Implement writeImage() on Pasteboard so that the context menus can 
       
 50553         call into the editor for the "Copy image" command instead of 
       
 50554         calling across the clients.
       
 50555 
       
 50556         * WebCore.exp:
       
 50557         * WebCore.xcodeproj/project.pbxproj:
       
 50558         * editing/Editor.cpp:
       
 50559         (WebCore::Editor::copyImage): Call into the Pasteboard.
       
 50560         * editing/Editor.h:
       
 50561         * loader/mac/LoaderNSURLExtras.h: A new NSURL extra needed inside 
       
 50562         WebCore.
       
 50563         * loader/mac/LoaderNSURLExtras.m: Made this file Objective-C++ 
       
 50564         (from Objective-C) since the call into the MIMETypeRegistry will 
       
 50565         return a Vector.
       
 50566         (urlByRemovingComponent): Cast to build as Obj-C++
       
 50567         (urlWithDataRelativeToURL): Same.
       
 50568         (vectorContainsString): Helper.
       
 50569         (suggestedFilenameWithMIMEType): New function.
       
 50570         * page/ContextMenuClient.h: Remove copyImageToClipboard()
       
 50571         * page/ContextMenuController.cpp:
       
 50572         (WebCore::ContextMenuController::contextMenuItemSelected): Call 
       
 50573         into the editor instead of the client.
       
 50574         * page/mac/WebCoreViewFactory.h: New localized String.
       
 50575         * platform/LocalizedStrings.h: Same.
       
 50576         * platform/MimeTypeRegistry.h: Expose two additional functions for 
       
 50577         MIMEType information from WebCore System Interface.
       
 50578         * platform/Pasteboard.h:
       
 50579         * platform/SharedBuffer.h: Make platformData() and platformDataSize
       
 50580         () public since they are needed to write the image to the 
       
 50581         pasteboard.
       
 50582         * platform/mac/LocalizedStringsMac.mm: New localized string.
       
 50583         (WebCore::copyImageUnknownFileLabel):
       
 50584         * platform/mac/MimeTypeRegistryMac.mm:
       
 50585         (WebCore::MimeTypeRegistry::getExtensionsForMIMEType):
       
 50586         (WebCore::MimeTypeRegistry::getPreferredExtensionForMIMEType):
       
 50587         * platform/mac/PasteboardMac.mm:
       
 50588         (WebCore::writableTypesForImage):
       
 50589         (WebCore::Pasteboard::writeURL): Write the correct types if the url 
       
 50590         is for an image.
       
 50591         (WebCore::fileWrapperForImage):
       
 50592         (WebCore::Pasteboard::writeFileWrapperAsRTFDAttachment):
       
 50593         (WebCore::Pasteboard::writeImage):
       
 50594         * platform/mac/WebCoreNSStringExtras.h: Added. Some the the 
       
 50595         NSStringExtras that were in WebKit are now needed by WebCore. To 
       
 50596         avoid having two copies of these functions, I just moved the 
       
 50597         implementations to WebCore. The WebKit functions just call into 
       
 50598         WebCore.
       
 50599         * platform/mac/WebCoreNSStringExtras.mm: Added.
       
 50600         (hasCaseInsensitiveSuffix):
       
 50601         (hasCaseInsensitiveSubstring):
       
 50602         (filenameByFixingIllegalCharacters):
       
 50603         * platform/mac/WebCoreSystemInterface.h: 
       
 50604         wkGetPreferredExtensionForMIMEType and wkGetExtensionsForMIMEType 
       
 50605         are now needed in WebCore as well as WebKit.
       
 50606         * platform/mac/WebCoreSystemInterface.mm:
       
 50607 
       
 50608 2007-02-20  Adam Roben  <aroben@apple.com>
       
 50609 
       
 50610         Build fix.
       
 50611 
       
 50612         * platform/StringTruncator.cpp:
       
 50613         (WebCore::truncateString): Added explicit casts.
       
 50614 
       
 50615 2007-02-20  Adam Roben  <aroben@apple.com>
       
 50616 
       
 50617         Reviewed by Darin and Anders.
       
 50618 
       
 50619         Fix <rdar://problem/4736215> Make WebCoreStringTruncator use WebCore types
       
 50620 
       
 50621         * WebCore.exp: Updated symbols.
       
 50622         * WebCore.xcodeproj/project.pbxproj: Updated file names.
       
 50623         * bridge/mac/WebCoreStringTruncator.h: Removed.
       
 50624         * bridge/mac/WebCoreStringTruncator.mm: Removed.
       
 50625         * platform/StringTruncator.cpp: Added. Moved from bridge/mac/WebCoreStringTruncator.mm.
       
 50626         (WebCore::textBreakAtOrPreceding): Added.
       
 50627         (WebCore::boundedTextBreakFollowing): Added.
       
 50628         (WebCore::centerTruncateToBuffer):
       
 50629         (WebCore::rightTruncateToBuffer):
       
 50630         (WebCore::stringWidth): Now takes a const Font& instead of a Font*.
       
 50631         (WebCore::truncateString):
       
 50632         (WebCore::StringTruncator::centerTruncate):
       
 50633         (WebCore::StringTruncator::rightTruncate):
       
 50634         (WebCore::StringTruncator::width):
       
 50635         * platform/StringTruncator.h: Added.
       
 50636         * platform/TextBreakIterator.h: Added isTextBreak declaration.
       
 50637         * platform/TextBreakIteratorICU.cpp:
       
 50638         (WebCore::isTextBreak): Implemented.
       
 50639         * platform/mac/FileChooserMac.mm:
       
 50640         (WebCore::FileChooser::basenameForWidth): Updated for changes to WebCoreStringTruncator.
       
 50641         * platform/qt/TextBreakIteratorQt.cpp:
       
 50642         (WebCore::isTextBreak): Stubbed out.
       
 50643 
       
 50644 2007-02-20  Justin Garcia  <justin.garcia@apple.com>
       
 50645 
       
 50646         Reviewed by harrison
       
 50647 
       
 50648         <rdar://problem/5006779>
       
 50649         REGRESSION: Paste and Match Style of quoted text onto empty line yields quoted text
       
 50650         
       
 50651         We decided to change the copy/paste behavior in both
       
 50652         the Paste and the Paste and Match Style cases.
       
 50653 
       
 50654         * editing/markup.cpp:
       
 50655         (WebCore::createMarkup): Don't add mail blockquote wrappers
       
 50656         unless the user selected one or more paragraphs.
       
 50657 
       
 50658 2007-02-20  Timothy Hatcher  <timothy@apple.com>
       
 50659 
       
 50660         Reviewed by Mark Rowe.
       
 50661 
       
 50662         <rdar://problem/4912899> WebCore project ObjC @property cleanup
       
 50663 
       
 50664         * bindings/objc/DOMObject.h: Add the new style @property
       
 50665         * bindings/objc/PublicDOMInterfaces.h: Update to the new style @property
       
 50666         * bindings/scripts/CodeGeneratorObjC.pm: Export both new and old style @properties
       
 50667 
       
 50668 2007-02-20  Timothy Hatcher  <timothy@apple.com>
       
 50669 
       
 50670         Reviewed by Sam Weinig.
       
 50671 
       
 50672         <rdar://problem/5007248> need to export symbols for DOM exception constants
       
 50673 
       
 50674         * WebCore.exp: Adds DOMEventException, DOMException, DOMRangeException, DOMXPathException
       
 50675 
       
 50676 2007-02-20  Timothy Hatcher  <timothy@apple.com>
       
 50677 
       
 50678         Reviewed by Darin.
       
 50679 
       
 50680         <rdar://problem/4900579> WebKit -finalize methods are not thread-safe; design change needed
       
 50681 
       
 50682         Call WebCoreObjCFinalizeOnMainThread from the initialize method of all the classes
       
 50683         that have a finalizer that needs called on the main thread.
       
 50684 
       
 50685         * WebCore.exp:
       
 50686         * WebCore.xcodeproj/project.pbxproj:
       
 50687         * bindings/objc/WebScriptObject.mm:
       
 50688         (+[WebScriptObject initialize]):
       
 50689         * bridge/mac/WebCoreScriptDebugger.mm:
       
 50690         (+[WebCoreScriptDebugger initialize]):
       
 50691         * platform/mac/SharedBufferMac.mm:
       
 50692         (+[SharedBufferData initialize]):
       
 50693         * platform/mac/WebCoreObjCExtras.c: Added.
       
 50694         (WebCoreObjCFinalizeOnMainThread):
       
 50695         * platform/mac/WebCoreObjCExtras.h: Added.
       
 50696 
       
 50697 2007-02-20  Geoffrey Garen  <ggaren@apple.com>
       
 50698 
       
 50699         Not not reviewed by Mitz Pettel.
       
 50700 
       
 50701         Fixed http://bugs.webkit.org/show_bug.cgi?id=12827 | <rdar://problem/5006671> 
       
 50702         REGRESSION: -[DOMCSSStyleDeclaration setValue:forKey:] doesn't have an 
       
 50703         immediate effect
       
 50704         
       
 50705         Let's just pretend this never happened.
       
 50706         
       
 50707         I attempted a layout test but I couldn't get the old code to fail because 
       
 50708         there's no obvious way to isolate the ObjC bindings in a test that's 
       
 50709         controlled by JS.
       
 50710         
       
 50711         * bindings/objc/WebScriptObject.mm:
       
 50712         (_didExecute):
       
 50713 
       
 50714 2007-02-20  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 50715 
       
 50716         Reviewed by Maciej S.
       
 50717 
       
 50718         Gdk build fixes for recent refactorings.
       
 50719 
       
 50720         * Projects/gdk/webcore-gdk.bkl:
       
 50721         * WebCoreSources.bkl:
       
 50722         * page/gdk/DragControllerGdk.cpp:
       
 50723         (WebCore::DragController::dragOperation):
       
 50724         (WebCore::DragController::maxDragImageSize):
       
 50725         * page/gdk/EventHandlerGdk.cpp:
       
 50726         (WebCore::EventHandler::createDraggingClipboard):
       
 50727         * platform/DragImage.h:
       
 50728         * platform/gdk/ChromeClientGdk.h:
       
 50729         * platform/gdk/CursorGdk.cpp:
       
 50730         (WebCore::verticalTextCursor):
       
 50731         (WebCore::cellCursor):
       
 50732         (WebCore::contextMenuCursor):
       
 50733         (WebCore::noDropCursor):
       
 50734         (WebCore::copyCursor):
       
 50735         (WebCore::progressCursor):
       
 50736         (WebCore::aliasCursor):
       
 50737         (WebCore::noneCursor):
       
 50738         (WebCore::notAllowedCursor):
       
 50739         * platform/gdk/EditorClientGdk.cpp:
       
 50740         (WebCore::EditorClientGdk::shouldChangeSelectedRange):
       
 50741         (WebCore::EditorClientGdk::isEditable):
       
 50742         (WebCore::EditorClientGdk::textFieldDidBeginEditing):
       
 50743         (WebCore::EditorClientGdk::textFieldDidEndEditing):
       
 50744         (WebCore::EditorClientGdk::textDidChangeInTextField):
       
 50745         (WebCore::EditorClientGdk::doTextFieldCommandFromEvent):
       
 50746         (WebCore::EditorClientGdk::textWillBeDeletedInTextField):
       
 50747         (WebCore::EditorClientGdk::textDidChangeInTextArea):
       
 50748         * platform/gdk/EditorClientGdk.h:
       
 50749         * platform/gdk/FrameGdk.cpp:
       
 50750         (WebCore::Frame::print):
       
 50751         (WebCore::Frame::issueTransposeCommand):
       
 50752         (WebCore::Frame::respondToChangedSelection):
       
 50753         (WebCore::Frame::cleanupPlatformScriptObjects):
       
 50754         (WebCore::Frame::isCharacterSmartReplaceExempt):
       
 50755         (WebCore::Frame::dragImageForSelection):
       
 50756         * platform/gdk/FrameGdk.h:
       
 50757         * platform/gdk/MimeTypeRegistryGdk.cpp: Added.
       
 50758         * platform/gdk/TemporaryLinkStubs.cpp:
       
 50759         (ChromeClientGdk::tabsToLinks):
       
 50760         (ChromeClientGdk::windowResizerRect):
       
 50761         (ChromeClientGdk::addToDirtyRegion):
       
 50762         (ChromeClientGdk::scrollBackingStore):
       
 50763         (ChromeClientGdk::updateBackingStore):
       
 50764         * webcore-base.bkl:
       
 50765 
       
 50766 2007-02-20  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 50767 
       
 50768         Reviewed by Darin.
       
 50769 
       
 50770         Allow over-writting Product, ProductSub, Vendor and VendorSub
       
 50771         js properties via #define WEBCORE_NAVIGATOR_*
       
 50772 
       
 50773         * bindings/js/kjs_navigator.cpp:
       
 50774         (KJS::Navigator::getValueProperty):
       
 50775 
       
 50776 2007-02-20  Darin Adler  <darin@apple.com>
       
 50777 
       
 50778         Reviewed by Anders.
       
 50779 
       
 50780         - prepare to fix some "stop loading" bugs by moving state from the
       
 50781           FrameLoader class to the DocumentLoader class
       
 50782 
       
 50783         * WebCore.exp: Update since cancelMainResourceLoad is now on the document loader.
       
 50784 
       
 50785         * html/HTMLDocument.h:
       
 50786         * html/HTMLDocument.cpp:
       
 50787         (WebCore::HTMLDocument::HTMLDocument): Removed unused bodyElement and htmlElement
       
 50788         data members.
       
 50789         (WebCore::HTMLDocument::lastModified): Call getResponseModifiedHeader directly on
       
 50790         the document loader.
       
 50791 
       
 50792         * loader/DocumentLoader.h: Moved m_mainResourceLoader, m_subresourceLoaders, and
       
 50793         m_plugInStreamLoaders here.
       
 50794         * loader/DocumentLoader.cpp:
       
 50795         (WebCore::cancelAll): Moved here from FrameLoader.
       
 50796         (WebCore::setAllDefersLoading): Ditto.
       
 50797         (WebCore::DocumentLoader::mainResourceData): Moved the body of FrameLoader's
       
 50798         mainResourceData function here.
       
 50799         (WebCore::DocumentLoader::stopLoading): Replaced calls to hasMainResourceLoader
       
 50800         and cancelMainResourceLoad with code that works directly on m_mainResourceLoader.
       
 50801         Call the stop functions moved from FrameLoader here on ourselves.
       
 50802         (WebCore::DocumentLoader::setupForReplaceByMIMEType): Ditto.
       
 50803         (WebCore::DocumentLoader::setPrimaryLoadComplete): Moved the code to store the
       
 50804         main resource data here; it doesn't require separate functions.
       
 50805         (WebCore::DocumentLoader::isLoadingInAPISense): Removed call to isLoadingSubresources
       
 50806         and instead just check if the m_subresourceLoaders set is empty.
       
 50807         (WebCore::DocumentLoader::setDefersLoading): Moved code here from FrameLoader.
       
 50808         (WebCore::DocumentLoader::stopLoadingPlugIns): Ditto.
       
 50809         (WebCore::DocumentLoader::stopLoadingSubresources): Ditto.
       
 50810         (WebCore::DocumentLoader::addSubresourceLoader): Ditto.
       
 50811         (WebCore::DocumentLoader::removeSubresourceLoader): Ditto.
       
 50812         (WebCore::DocumentLoader::addPlugInStreamLoader): Ditto.
       
 50813         (WebCore::DocumentLoader::removePlugInStreamLoader): Ditto.
       
 50814         (WebCore::DocumentLoader::isLoadingSubresources): Ditto.
       
 50815         (WebCore::DocumentLoader::isLoadingPlugIns): Ditto.
       
 50816         (WebCore::DocumentLoader::startLoadingMainResource): Ditto.
       
 50817         (WebCore::DocumentLoader::cancelMainResourceLoad): Ditto.
       
 50818 
       
 50819         * loader/FrameLoader.h: Removed stopLoadingPlugIns, stopLoadingSubresources,
       
 50820         cancelMainResourceLoad, hasMainResourceLoader, isLoadingSubresources,
       
 50821         mainResourceData, releaseMainResourceLoader, lastModified, startLoadingMainResource,
       
 50822         isLoadingPlugIns, m_mainResourceLoader, m_subresourceLoaders, m_plugInStreamLoaders,
       
 50823         m_responseRefreshHeader, and m_responseModifiedHeader.
       
 50824         * loader/FrameLoader.cpp:
       
 50825         (WebCore::FrameLoader::setDefersLoading): Call setDefersLoading on all the document
       
 50826         loaders.
       
 50827         (WebCore::FrameLoader::stopLoading): Get rid of code to set m_responseRefreshHeader
       
 50828         and m_responseModifiedHeader.
       
 50829         (WebCore::FrameLoader::receivedFirstData): Call httpHeaderField on the response
       
 50830         here to get the Refresh, instead of storing it in a data member.
       
 50831         (WebCore::FrameLoader::addPlugInStreamLoader): Change to just call this on the
       
 50832         document loader.
       
 50833         (WebCore::FrameLoader::removePlugInStreamLoader): Ditto.
       
 50834         (WebCore::FrameLoader::isLoading): Change to call isLoadingSubresources and
       
 50835         isLoadingPlugIns on the document loader.
       
 50836         (WebCore::FrameLoader::addSubresourceLoader): Change to just call this on the
       
 50837         document loader.
       
 50838         (WebCore::FrameLoader::removeSubresourceLoader): Ditto.
       
 50839         (WebCore::FrameLoader::commitProvisionalLoad): Call stopLoadingSubresources and
       
 50840         stopLoadingPlugIns on the document loader. Removed code to set
       
 50841         m_responseModifiedHeader.
       
 50842         (WebCore::FrameLoader::startLoading): Call isLoadingMainResource and
       
 50843         startLoadingMainResource on the document loader.
       
 50844 
       
 50845         * loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish): Call
       
 50846         mainResourceData() on the document loader instead of the frame loader.
       
 50847 
       
 50848         - other changes
       
 50849 
       
 50850         * loader/DocLoader.cpp:
       
 50851         (WebCore::DocLoader::checkCacheObjectStatus): Fixed indentation.
       
 50852 
       
 50853 2007-02-20  Zack Rusin  <zrusin@trolltech.com>
       
 50854 
       
 50855         Reviewed by Lars
       
 50856 
       
 50857         Fix focus handling and make the forms
       
 50858         work as expected.
       
 50859 
       
 50860         * platform/qt/ScrollViewQt.cpp:
       
 50861         (WebCore::ScrollView::setScrollArea):
       
 50862         * platform/qt/WidgetQt.cpp:
       
 50863         (WebCore::WidgetPrivate::WidgetPrivate):
       
 50864         (WebCore::WidgetPrivate::canvas):
       
 50865         (WebCore::Widget::hasFocus):
       
 50866         (WebCore::Widget::setFocus):
       
 50867         (WebCore::Widget::clearFocus):
       
 50868         (WebCore::Widget::setFont):
       
 50869         (WebCore::Widget::setQWidget):
       
 50870         (WebCore::Widget::focusPolicy):
       
 50871 
       
 50872 2007-02-20  Mitz Pettel  <mitz@webkit.org>
       
 50873 
       
 50874         Reviewed by Darin and then Sam.
       
 50875 
       
 50876         - fix http://bugs.webkit.org/show_bug.cgi?id=10735
       
 50877           Clicking in SVG results causes WebKit to consume 100% CPU for several minutes
       
 50878 
       
 50879         No test since there is no change in functionality.
       
 50880 
       
 50881         * CMakeLists.txt:
       
 50882         * WebCore.pro:
       
 50883         * WebCore.xcodeproj/project.pbxproj: Added PositionIterator.{cpp,h}.
       
 50884         * WebCoreSources.bkl:
       
 50885         * dom/Position.cpp:
       
 50886         (WebCore::Position::Position): Added converting constructor from
       
 50887         PositionIterator.
       
 50888         (WebCore::Position::previous): Changed assert() to ASSERT().
       
 50889         (WebCore::Position::next): Ditto.
       
 50890         (WebCore::isStreamer): Changed the argument to a PositionIterator.
       
 50891         (WebCore::Position::upstream): Changed to use PositionIterator.
       
 50892         (WebCore::Position::downstream): Ditto.
       
 50893         (WebCore::Position::inRenderedText): Made public.
       
 50894         (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): Changed
       
 50895         into a static member function.
       
 50896         (WebCore::Position::nodeIsUserSelectNone): Ditto.
       
 50897         * dom/Position.h:
       
 50898         * dom/PositionIterator.cpp: Added. A Position iterator with constant-time
       
 50899         increment, decrement, and several predicates on the Position it is at.
       
 50900         Conversion to/from Position is O(n) in the offset.
       
 50901         (WebCore::PositionIterator::increment):
       
 50902         (WebCore::PositionIterator::decrement):
       
 50903         (WebCore::PositionIterator::atStart):
       
 50904         (WebCore::PositionIterator::atEnd):
       
 50905         (WebCore::PositionIterator::atStartOfNode):
       
 50906         (WebCore::PositionIterator::atEndOfNode):
       
 50907         (WebCore::PositionIterator::isCandidate):
       
 50908         * dom/PositionIterator.h: Added.
       
 50909         (WebCore::PositionIterator::PositionIterator):
       
 50910         (WebCore::PositionIterator::node):
       
 50911         (WebCore::PositionIterator::offsetInLeafNode):
       
 50912         * editing/htmlediting.cpp:
       
 50913         (WebCore::nextCandidate): Changed to use PositionIterator.
       
 50914         (WebCore::previousCandidate): Changed to use PositionIterator.
       
 50915 
       
 50916 2007-02-20  Rob Buis  <buis@kde.org>
       
 50917 
       
 50918         Reviewed by Darin.
       
 50919 
       
 50920         http://bugs.webkit.org/show_bug.cgi?id=12439
       
 50921         SVG parser complains about points attribute in polygon and polyline element
       
 50922 
       
 50923         Return true when the parsed points specification is valid.
       
 50924 
       
 50925         * ksvg2/svg/SVGParserUtilities.cpp:
       
 50926         (WebCore::parseNumber):
       
 50927         (WebCore::SVGPolyParser::parsePoints):
       
 50928         * ksvg2/svg/SVGPolyElement.cpp:
       
 50929         (WebCore::SVGPolyElement::parseMappedAttribute):
       
 50930 
       
 50931 2007-02-20  Zack Rusin  <zrusin@trolltech.com>
       
 50932 
       
 50933         Reviewed by Lars
       
 50934 
       
 50935         Make editing of forms work plus make sure that non-void methods
       
 50936         always return something.
       
 50937 
       
 50938         * WebCore.pro:
       
 50939         * loader/qt/DocumentLoaderQt.cpp:
       
 50940         (WebCore::DocumentLoader::getResponseModifiedHeader):
       
 50941         * platform/qt/ClipboardQt.cpp:
       
 50942         (WebCore::ClipboardQt::setData):
       
 50943 
       
 50944 2007-02-20  Zack Rusin  <zrusin@trolltech.com>
       
 50945 
       
 50946         Reviewed by Lars
       
 50947 
       
 50948         Refactor and fix the implementation of theming of
       
 50949         form elements on the Qt platform.
       
 50950 
       
 50951         * platform/qt/RenderThemeQt.cpp:
       
 50952         (WebCore::theme):
       
 50953         (WebCore::RenderThemeQt::RenderThemeQt):
       
 50954         (WebCore::RenderThemeQt::supportsHover):
       
 50955         (WebCore::RenderThemeQt::supportsFocusRing):
       
 50956         (WebCore::RenderThemeQt::baselinePosition):
       
 50957         (WebCore::RenderThemeQt::controlSupportsTints):
       
 50958         (WebCore::RenderThemeQt::supportsControlTints):
       
 50959         (WebCore::RenderThemeQt::adjustRepaintRect):
       
 50960         (WebCore::RenderThemeQt::paintResizeControl):
       
 50961         (WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor):
       
 50962         (WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor):
       
 50963         (WebCore::RenderThemeQt::platformActiveSelectionForegroundColor):
       
 50964         (WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor):
       
 50965         (WebCore::RenderThemeQt::systemFont):
       
 50966         (WebCore::RenderThemeQt::minimumMenuListSize):
       
 50967         (WebCore::RenderThemeQt::adjustSliderThumbSize):
       
 50968         (WebCore::RenderThemeQt::paintCheckbox):
       
 50969         (WebCore::RenderThemeQt::paintRadio):
       
 50970         (WebCore::RenderThemeQt::setRadioSize):
       
 50971         (WebCore::RenderThemeQt::adjustButtonStyle):
       
 50972         (WebCore::RenderThemeQt::setButtonSize):
       
 50973         (WebCore::RenderThemeQt::adjustTextFieldStyle):
       
 50974         (WebCore::RenderThemeQt::adjustMenuListStyle):
       
 50975         (WebCore::RenderThemeQt::paintMenuList):
       
 50976         (WebCore::RenderThemeQt::paintMenuListButton):
       
 50977         (WebCore::RenderThemeQt::adjustMenuListButtonStyle):
       
 50978         (WebCore::RenderThemeQt::paintSliderTrack):
       
 50979         (WebCore::RenderThemeQt::paintSliderThumb):
       
 50980         (WebCore::RenderThemeQt::paintSearchField):
       
 50981         (WebCore::RenderThemeQt::adjustSearchFieldStyle):
       
 50982         (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
       
 50983         (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
       
 50984         (WebCore::RenderThemeQt::adjustSearchFieldDecorationStyle):
       
 50985         (WebCore::RenderThemeQt::paintSearchFieldDecoration):
       
 50986         (WebCore::RenderThemeQt::adjustSearchFieldResultsDecorationStyle):
       
 50987         (WebCore::RenderThemeQt::paintSearchFieldResultsDecoration):
       
 50988         (WebCore::RenderThemeQt::supportsFocus):
       
 50989         (WebCore::RenderThemeQt::getStylePainterAndWidgetFromPaintInfo):
       
 50990         (WebCore::RenderThemeQt::applyTheme):
       
 50991         (WebCore::RenderThemeQt::setSizeFromFont):
       
 50992         (WebCore::RenderThemeQt::sizeForFont):
       
 50993         (WebCore::RenderThemeQt::setButtonPadding):
       
 50994         (WebCore::RenderThemeQt::setPopupPadding):
       
 50995         (WebCore::RenderThemeQt::setPrimitiveSize):
       
 50996         * platform/qt/RenderThemeQt.h: Added.
       
 50997 
       
 50998 2007-02-19  Lars Naesbye Christensen <lars@naesbye.dk>
       
 50999 
       
 51000         Reviewed by Maciej.
       
 51001 
       
 51002         http://bugs.webkit.org/show_bug.cgi?id=12815
       
 51003         Two image files not included in project file
       
 51004 
       
 51005         * WebCore.xcodeproj/project.pbxproj: Added crossHairCursor.png and
       
 51006         notAllowedCursor.png.
       
 51007 
       
 51008 2007-02-19  Geoffrey Garen  <ggaren@apple.com>
       
 51009 
       
 51010         Reviewed by Adam Roben.
       
 51011 
       
 51012         Fixed some leaks in RenderThemeMac.
       
 51013         
       
 51014         No test case because 'leaks' can't detect these leaks inside DRT, even if
       
 51015         DRT forces the WebView to paint. ('leaks' can detect these leaks inside
       
 51016         Safari. Weird.)
       
 51017         
       
 51018         * rendering/RenderThemeMac.h:
       
 51019             - Renamed data members to m_*, to match our style guidelines.
       
 51020             - Renamed *Is* to is**, to match our style guidelines.
       
 51021             - Removed a few unnecessary data members.
       
 51022             - Made cached values like m_checkbox mutable, since they can change
       
 51023             inside functions that don't change the logical state of a RenderTheme
       
 51024             object. (The alternative was to make some const functions non-const.)
       
 51025 
       
 51026         (WebCore::RenderThemeMac::paintMenuList): Took CFType pointers that just 
       
 51027         used to leak and placed them in RetainPtrs.
       
 51028         (WebCore::RenderThemeMac::paintMenuListButtonGradients): ditto
       
 51029 
       
 51030         Factored inline implementations of lazy initialization into these accessor
       
 51031         functions, for better encapsulation:
       
 51032         
       
 51033         (WebCore::RenderThemeMac::checkbox):
       
 51034         (WebCore::RenderThemeMac::radio):
       
 51035         (WebCore::RenderThemeMac::button):
       
 51036         (WebCore::RenderThemeMac::popupButton):
       
 51037         (WebCore::RenderThemeMac::search):
       
 51038         (WebCore::RenderThemeMac::sliderThumbHorizontal): The inline version of
       
 51039         this initialization used to confuse the retained data member with a local
       
 51040         stack value, causing both a leak and a failure to initialize. Fixed now.
       
 51041         (WebCore::RenderThemeMac::sliderThumbVertical): ditto
       
 51042         (WebCore::RenderThemeMac::resizeCornerImage):
       
 51043 
       
 51044 2007-02-19  Mitz Pettel  <mitz@webkit.org>
       
 51045 
       
 51046         Reviewed by Hyatt.
       
 51047 
       
 51048         - fix http://bugs.webkit.org/show_bug.cgi?id=12817
       
 51049           REGRESSION (r18634): Table border-collapse problems with right margin
       
 51050 
       
 51051         Test: fast/repaint/table-outer-border.html
       
 51052 
       
 51053         * rendering/RenderTable.cpp:
       
 51054         (WebCore::RenderTable::layout): Reordered to initialize horizontal overflow
       
 51055         after table sections have computed their outer horizontal borders.
       
 51056 
       
 51057 2007-02-19  John Sullivan  <sullivan@apple.com>
       
 51058 
       
 51059         Reviewed by Darin
       
 51060         
       
 51061         - fixed <rdar://problem/4613701> REGRESSION: A line break in the source HTML of a link becomes visible after drag & drop
       
 51062 
       
 51063         * page/DragController.cpp:
       
 51064         (WebCore::DragController::startDrag):
       
 51065         Call simplifyWhiteSpace() on the proposed link title to match what's displayed on the web page, instead of using the
       
 51066         raw source HTML text.
       
 51067 
       
 51068 2007-02-19  David Hyatt  <hyatt@apple.com>
       
 51069 
       
 51070         Fix for Radar 4981605, regression where button grows randomly when a select is
       
 51071         opened.  With the new form controls, the WinIE quirk for using line width
       
 51072         ended up being used for them more.
       
 51073 
       
 51074         This patch removes the quirk after verifying that Firefox doesn't implement
       
 51075         the quirk at all.  usesLineWidth is being renamed to shrinksToAvoidFloats to
       
 51076         make it clear that the new method only applies to block objects that avoid floats
       
 51077         and that have auto width.
       
 51078 
       
 51079         Also fixed a regression where whitespace after a floating <select> at the start
       
 51080         of a block got incorrectly rendered.  Make sure skipWhitespace always skips
       
 51081         through floating/positioned elements regardless of the whitespace setting (this
       
 51082         way the white-space:pre value on floating <select>s doesn't cause trouble).
       
 51083 
       
 51084         Reviewed by darin
       
 51085 
       
 51086         fast/block/float/float-avoidance.html
       
 51087 
       
 51088         * rendering/RenderBlock.cpp:
       
 51089         (WebCore::RenderBlock::collapseMargins):
       
 51090         (WebCore::RenderBlock::clearFloatsIfNeeded):
       
 51091         (WebCore::RenderBlock::layoutBlockChildren):
       
 51092         (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
       
 51093         * rendering/RenderBox.cpp:
       
 51094         (WebCore::RenderBox::containingBlockWidth):
       
 51095         * rendering/RenderObject.cpp:
       
 51096         (WebCore::RenderObject::shrinkToAvoidFloats):
       
 51097         * rendering/RenderObject.h:
       
 51098         * rendering/bidi.cpp:
       
 51099         (WebCore::RenderBlock::skipWhitespace):
       
 51100 
       
 51101 2007-02-19  Zalan Bujtas  <zbujtas@gmail.com>
       
 51102 
       
 51103         Reviewed by Darin.
       
 51104 
       
 51105         Update stylesheet href, when document's baseUrl changes. It needs
       
 51106         update when the stylesheet is constructed before the parser hits the base tag.
       
 51107         http://bugs.webkit.org/show_bug.cgi?id=12214
       
 51108 
       
 51109         * css/StyleSheet.h:
       
 51110         (WebCore::StyleSheet::setHref):
       
 51111         * dom/Document.cpp:
       
 51112         (WebCore::Document::setBaseURL):
       
 51113         * dom/Document.h:
       
 51114 
       
 51115 2007-02-19  Mitz Pettel  <mitz@webkit.org>
       
 51116 
       
 51117         Reviewed by Adam.
       
 51118 
       
 51119         - fix http://bugs.webkit.org/show_bug.cgi?id=11518
       
 51120           REGRESSION (r14376): View Source not available after Back navigation from a non-HTML page
       
 51121 
       
 51122         The FrameLoader's responseMIMEType was not being updated when a page was
       
 51123         brought back from the page cache.
       
 51124         
       
 51125         Moved the line that updates the MIME type from commitProvisionalLoad() to
       
 51126         transitionToCommitted().
       
 51127 
       
 51128         * loader/FrameLoader.cpp:
       
 51129         (WebCore::FrameLoader::commitProvisionalLoad):
       
 51130         (WebCore::FrameLoader::transitionToCommitted):
       
 51131 
       
 51132 2007-02-19  Anders Carlsson  <acarlsson@apple.com>
       
 51133 
       
 51134         Reviewed by Oliver.
       
 51135 
       
 51136         Make DragController::maxDragImageSize a function to get rid of the global initializer.
       
 51137         
       
 51138         * page/DragController.cpp:
       
 51139         (WebCore::DragController::doImageDrag):
       
 51140         * page/DragController.h:
       
 51141         * page/mac/DragControllerMac.mm:
       
 51142         (WebCore::DragController::maxDragImageSize):
       
 51143         * page/qt/DragControllerQt.cpp:
       
 51144         (WebCore::DragController::maxDragImageSize):
       
 51145 
       
 51146 2007-02-19  Darin Adler  <darin@apple.com>
       
 51147 
       
 51148         Reviewed by Hyatt.
       
 51149 
       
 51150         - <rdar://problem/5006414> REGRESSION: Crash occurs at WebCore::Frame::loader()
       
 51151           when loading AFL Ladder widget
       
 51152 
       
 51153         * html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL):
       
 51154         Add missing null check so this fails without crashing when called on an element
       
 51155         that's no longer in a frame.
       
 51156 
       
 51157 2007-02-19  Antti Koivisto  <antti@apple.com>
       
 51158 
       
 51159         Reviewed by Mitz.
       
 51160 
       
 51161         - fix for http://bugs.webkit.org/show_bug.cgi?id=10990
       
 51162           REGRESSION: Pressing a pop-up's access key doesn't focus it
       
 51163           <rdar://problem/4823138>
       
 51164           
       
 51165         Focus the select element too in accessKeyAction.
       
 51166 
       
 51167         * html/HTMLSelectElement.cpp:
       
 51168         (WebCore::HTMLSelectElement::accessKeyAction):
       
 51169 
       
 51170 2007-02-18  Antti Koivisto  <antti@apple.com>
       
 51171 
       
 51172         Reviewed by Hyatt.
       
 51173 
       
 51174         - really fix http://bugs.webkit.org/show_bug.cgi?id=11974
       
 51175         REGRESSION: Caret drawn over input when smaller than font size on initial focus
       
 51176         <rdar://problem/4960258>
       
 51177         
       
 51178         Avoid double painting caret when it is on a block element.
       
 51179         
       
 51180         Layout test for this already went in previous try (it only fails in pixel mode) in r19626.
       
 51181 
       
 51182         * rendering/RenderBlock.cpp:
       
 51183         (WebCore::RenderBlock::paintCaret):
       
 51184 
       
 51185 2007-02-19  Lars Knoll <lars@trolltech.com>
       
 51186 
       
 51187         Added a one line patch from Olliej to create the
       
 51188         clipboard on demand (to stop things from crashing), 
       
 51189         and added lots of notImplemented() warnings all 
       
 51190         over the place.
       
 51191 
       
 51192         * platform/qt/ClipboardQt.cpp:
       
 51193         (WebCore::ClipboardQt::ClipboardQt):
       
 51194         (WebCore::ClipboardQt::clearData):
       
 51195         (WebCore::ClipboardQt::clearAllData):
       
 51196         (WebCore::ClipboardQt::getData):
       
 51197         (WebCore::ClipboardQt::setData):
       
 51198         (WebCore::ClipboardQt::types):
       
 51199         (WebCore::ClipboardQt::dragLocation):
       
 51200         (WebCore::ClipboardQt::dragImage):
       
 51201         (WebCore::ClipboardQt::setDragImage):
       
 51202         (WebCore::ClipboardQt::dragImageElement):
       
 51203         (WebCore::ClipboardQt::setDragImageElement):
       
 51204         (WebCore::ClipboardQt::createDragImage):
       
 51205         (WebCore::ClipboardQt::declareAndWriteDragImage):
       
 51206         (WebCore::ClipboardQt::writeURL):
       
 51207         (WebCore::ClipboardQt::writeRange):
       
 51208         (WebCore::ClipboardQt::hasData):
       
 51209         * platform/qt/DragDataQt.cpp:
       
 51210         (WebCore::DragData::canSmartReplace):
       
 51211         (WebCore::DragData::containsColor):
       
 51212         (WebCore::DragData::containsPlainText):
       
 51213         (WebCore::DragData::asPlainText):
       
 51214         (WebCore::DragData::asColor):
       
 51215         (WebCore::DragData::createClipboard):
       
 51216         (WebCore::DragData::containsCompatibleContent):
       
 51217         (WebCore::DragData::containsURL):
       
 51218         (WebCore::DragData::asURL):
       
 51219         (WebCore::DragData::asFragment):
       
 51220 
       
 51221 2007-02-19  Lars Knoll <lars@trolltech.com>
       
 51222 
       
 51223         Compile again.
       
 51224 
       
 51225         * platform/qt/ClipboardQt.cpp:
       
 51226         (WebCore::ClipboardQt::types):
       
 51227 
       
 51228 2007-02-17  Lars Knoll <lars@trolltech.com>
       
 51229 
       
 51230         Reviewed by Maciej.
       
 51231         
       
 51232         Additional coding by Maciej, additional review by Oliver.
       
 51233 
       
 51234         Get rid of the FrameMac and FrameQt classes. Instead
       
 51235         move all methods into Frame directly, and implement
       
 51236         some platform specific methods in foo/FrameFoo.cpp.
       
 51237 
       
 51238         Some general cleanup in Frame:
       
 51239         * Move some methods out of Frame, to the place where they 
       
 51240         belong.
       
 51241         * Unify the different ways of creating the JavaScript wrappers
       
 51242         for <object>, <embed> and <applet>
       
 51243         * Some cleanup of the WebCoreFrameBridge
       
 51244 
       
 51245         * ForwardingHeaders/bindings/NP_jsobject.h: Added.
       
 51246         * ForwardingHeaders/bindings/npruntime_impl.h: Added.
       
 51247         * ForwardingHeaders/bindings/runtime_root.h: Added.
       
 51248         * WebCore.exp:
       
 51249         * WebCore.xcodeproj/project.pbxproj:
       
 51250         * bindings/js/kjs_binding.cpp:
       
 51251         (KJS::ScriptInterpreter::shouldInterruptScript):
       
 51252         * bindings/objc/DOM.mm:
       
 51253         (-[DOMNode KJS::Bindings::]):
       
 51254         * bindings/objc/DOMInternal.mm:
       
 51255         (-[WebScriptObject _initializeScriptDOMNodeImp]):
       
 51256         * bridge/EditorClient.h:
       
 51257         * bridge/mac/FrameViewMac.mm:
       
 51258         (WebCore::FrameView::updateBorder):
       
 51259         (WebCore::FrameView::updateDashboardRegions):
       
 51260         * bridge/mac/WebCoreAXObject.mm:
       
 51261         (-[WebCoreAXObject rendererForView:]):
       
 51262         * dom/Position.cpp:
       
 51263         (WebCore::Position::next):
       
 51264         * editing/CommandByName.cpp:
       
 51265         (WebCore::Frame::execCopy):
       
 51266         (WebCore::Frame::execCut):
       
 51267         (WebCore::Frame::execPaste):
       
 51268         * editing/Editor.cpp:
       
 51269         (WebCore::Editor::canEdit):
       
 51270         (WebCore::Editor::pasteWithPasteboard):
       
 51271         (WebCore::Editor::paste):
       
 51272         (WebCore::Editor::pasteAsPlainText):
       
 51273         * editing/Editor.h:
       
 51274         * editing/JSEditor.cpp:
       
 51275         * html/HTMLAppletElement.cpp:
       
 51276         (WebCore::HTMLAppletElement::getInstance):
       
 51277         * html/HTMLEmbedElement.cpp:
       
 51278         (WebCore::HTMLEmbedElement::getInstance):
       
 51279         * html/HTMLFormElement.cpp:
       
 51280         (WebCore::HTMLFormElement::formData):
       
 51281         * html/HTMLObjectElement.cpp:
       
 51282         (WebCore::HTMLObjectElement::getInstance):
       
 51283         * loader/FrameLoader.cpp:
       
 51284         (WebCore::FrameLoader::clear):
       
 51285         (WebCore::FrameLoader::detachFromParent):
       
 51286         * loader/mac/ImageDocumentMac.mm:
       
 51287         (WebCore::finishImageLoad):
       
 51288         * loader/qt/DocumentLoaderQt.cpp:
       
 51289         * page/Chrome.cpp:
       
 51290         (WebCore::Chrome::shouldInterruptJavaScript):
       
 51291         * page/Chrome.h:
       
 51292         * page/ChromeClient.h:
       
 51293         * page/Frame.cpp:
       
 51294         (WebCore::Frame::~Frame):
       
 51295         (WebCore::Frame::markedTextRange):
       
 51296         (WebCore::Frame::shouldChangeSelection):
       
 51297         (WebCore::Frame::shouldDeleteSelection):
       
 51298         (WebCore::Frame::isContentEditable):
       
 51299         (WebCore::Frame::setSecureKeyboardEntry):
       
 51300         (WebCore::Frame::isSecureKeyboardEntry):
       
 51301         (WebCore::Frame::bindingRootObject):
       
 51302         (WebCore::Frame::createRootObject):
       
 51303         (WebCore::Frame::windowScriptNPObject):
       
 51304         (WebCore::Frame::cleanupScriptObjects):
       
 51305         (WebCore::FramePrivate::FramePrivate):
       
 51306         * page/Frame.h:
       
 51307         * page/FramePrivate.h:
       
 51308         * page/FrameView.h:
       
 51309         * page/mac/EventHandlerMac.mm:
       
 51310         (WebCore::EventHandler::tabsToLinks):
       
 51311         (WebCore::EventHandler::tabsToAllControls):
       
 51312         (WebCore::EventHandler::focusDocumentView):
       
 51313         (WebCore::EventHandler::passMouseDownEventToWidget):
       
 51314         (WebCore::EventHandler::handleDrag):
       
 51315         (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
       
 51316         (WebCore::EventHandler::keyboardUIMode):
       
 51317         * page/mac/FrameMac.h: Removed.
       
 51318         * page/mac/FrameMac.mm:
       
 51319         (WebCore::Frame::setBridge):
       
 51320         (WebCore::Frame::bridge):
       
 51321         (WebCore::Frame::searchForLabelsAboveCell):
       
 51322         (WebCore::Frame::searchForLabelsBeforeElement):
       
 51323         (WebCore::Frame::matchLabelsAgainstElement):
       
 51324         (WebCore::Frame::focusWindow):
       
 51325         (WebCore::Frame::unfocusWindow):
       
 51326         (WebCore::Frame::imageFromRect):
       
 51327         (WebCore::Frame::selectionImage):
       
 51328         (WebCore::Frame::snapshotDragImage):
       
 51329         (WebCore::Frame::fontAttributesForSelectionStart):
       
 51330         (WebCore::Frame::baseWritingDirectionForSelectionStart):
       
 51331         (WebCore::Frame::print):
       
 51332         (WebCore::Frame::issuePasteCommand):
       
 51333         (WebCore::Frame::issueTransposeCommand):
       
 51334         (WebCore::Frame::respondToChangedSelection):
       
 51335         (WebCore::Frame::textFieldDidBeginEditing):
       
 51336         (WebCore::Frame::textFieldDidEndEditing):
       
 51337         (WebCore::Frame::textDidChangeInTextField):
       
 51338         (WebCore::Frame::textDidChangeInTextArea):
       
 51339         (WebCore::Frame::doTextFieldCommandFromEvent):
       
 51340         (WebCore::Frame::textWillBeDeletedInTextField):
       
 51341         (WebCore::Frame::setSecureKeyboardEntry):
       
 51342         (WebCore::Frame::isSecureKeyboardEntry):
       
 51343         (WebCore::Frame::setMarkedTextRange):
       
 51344         (WebCore::Frame::dashboardRegionsDictionary):
       
 51345         (WebCore::Frame::dashboardRegionsChanged):
       
 51346         (WebCore::Frame::willPopupMenu):
       
 51347         (WebCore::Frame::isCharacterSmartReplaceExempt):
       
 51348         (WebCore::Frame::setNeedsReapplyStyles):
       
 51349         (WebCore::Frame::customHighlightLineRect):
       
 51350         (WebCore::Frame::paintCustomHighlight):
       
 51351         (WebCore::Frame::createScriptInstanceForWidget):
       
 51352         (WebCore::Frame::windowScriptObject):
       
 51353         (WebCore::Frame::cleanupPlatformScriptObjects):
       
 51354         * page/mac/WebCoreFrameBridge.h:
       
 51355         * page/mac/WebCoreFrameBridge.mm:
       
 51356         (createRootObject):
       
 51357         (bridge):
       
 51358         (-[WebCoreFrameBridge _frame]):
       
 51359         * page/qt/EventHandlerQt.cpp:
       
 51360         * page/qt/FrameQt.cpp:
       
 51361         (WebCore::Frame::unfocusWindow):
       
 51362         (WebCore::Frame::focusWindow):
       
 51363         (WebCore::Frame::issueTransposeCommand):
       
 51364         (WebCore::Frame::respondToChangedSelection):
       
 51365         (WebCore::Frame::print):
       
 51366         (WebCore::Frame::createScriptInstanceForWidget):
       
 51367         (WebCore::Frame::cleanupPlatformScriptObjects):
       
 51368         (WebCore::Frame::isCharacterSmartReplaceExempt):
       
 51369         * page/qt/FrameQt.h: Removed.
       
 51370         * platform/MimeTypeRegistry.h:
       
 51371         * platform/graphics/svg/SVGImage.cpp:
       
 51372         (WebCore::SVGImage::setData):
       
 51373         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 51374         (WebCore::SVGEmptyChromeClient::shouldInterruptJavaScript):
       
 51375         (WebCore::SVGEmptyEditorClient::shouldChangeSelectedRange):
       
 51376         * platform/mac/ClipboardMac.h:
       
 51377         * platform/mac/ClipboardMac.mm:
       
 51378         (WebCore::ClipboardMac::ClipboardMac):
       
 51379         * platform/mac/FileChooserMac.mm:
       
 51380         (-[OpenPanelController beginSheetWithFrame:]):
       
 51381         * platform/mac/MimeTypeRegistryMac.mm:
       
 51382         (WebCore::MimeTypeRegistry::getMIMETypeForPath):
       
 51383         * platform/mac/PopupMenuMac.mm:
       
 51384         (WebCore::PopupMenu::show):
       
 51385         * platform/mac/WidgetMac.mm:
       
 51386         (WebCore::Widget::setFocus):
       
 51387         (WebCore::Widget::setIsSelected):
       
 51388         * platform/network/mac/ResourceHandleMac.mm:
       
 51389         * platform/network/qt/ResourceHandleManagerQt.cpp:
       
 51390         * platform/network/qt/ResourceHandleQt.cpp:
       
 51391         (WebCore::ResourceHandle::start):
       
 51392         * platform/qt/MimeTypeRegistryQt.cpp:
       
 51393         (WebCore::MimeTypeRegistry::getMIMETypeForPath):
       
 51394         * platform/qt/PopupMenuQt.cpp:
       
 51395         * platform/qt/ScrollViewCanvasQt.cpp:
       
 51396         * platform/qt/ScrollViewQt.cpp:
       
 51397         * platform/win/TemporaryLinkStubs.cpp:
       
 51398         * rendering/InlineTextBox.cpp:
       
 51399         (WebCore::InlineTextBox::paintCustomHighlight):
       
 51400         * rendering/RenderBox.cpp:
       
 51401         (WebCore::RenderBox::paintCustomHighlight):
       
 51402         * rendering/RootInlineBox.cpp:
       
 51403         (WebCore::RootInlineBox::addHighlightOverflow):
       
 51404         (WebCore::RootInlineBox::paintCustomHighlight):
       
 51405 
       
 51406 2007-02-18  Oliver Hunt  <oliver@apple.com>
       
 51407 
       
 51408         Reviewed by NOBODY (Buildfix).
       
 51409 
       
 51410         Oops, missed a 'const'
       
 51411 
       
 51412         * platform/qt/ClipboardQt.h:
       
 51413 
       
 51414 2007-02-18  Oliver Hunt  <oliver@apple.com>
       
 51415 
       
 51416         Reviewed by Adam.
       
 51417 
       
 51418         Adding stubbed out implementation of Clipboard for Qt to stop
       
 51419         it crashing whenever someone drags the mouse.
       
 51420 
       
 51421         * WebCore.pro:
       
 51422         * page/qt/EventHandlerQt.cpp:
       
 51423         (WebCore::EventHandler::createDraggingClipboard):
       
 51424         * platform/qt/ClipboardQt.cpp: Added.
       
 51425         (WebCore::ClipboardQt::ClipboardQt):
       
 51426         (WebCore::ClipboardQt::clearData):
       
 51427         (WebCore::ClipboardQt::clearAllData):
       
 51428         (WebCore::ClipboardQt::getData):
       
 51429         (WebCore::ClipboardQt::setData):
       
 51430         (WebCore::ClipboardQt::types):
       
 51431         (WebCore::ClipboardQt::dragLocation):
       
 51432         (WebCore::ClipboardQt::dragImage):
       
 51433         (WebCore::ClipboardQt::setDragImage):
       
 51434         (WebCore::ClipboardQt::dragImageElement):
       
 51435         (WebCore::ClipboardQt::setDragImageElement):
       
 51436         (WebCore::ClipboardQt::createDragImage):
       
 51437         (WebCore::ClipboardQt::declareAndWriteDragImage):
       
 51438         (WebCore::ClipboardQt::writeURL):
       
 51439         (WebCore::ClipboardQt::writeRange):
       
 51440         (WebCore::ClipboardQt::hasData):
       
 51441         * platform/qt/ClipboardQt.h: Added.
       
 51442         (WebCore::ClipboardQt::~ClipboardQt):
       
 51443         (WebCore::ClipboardQt::isForDragging):
       
 51444 
       
 51445 2007-02-18  Oliver Hunt  <oliver@apple.com>
       
 51446 
       
 51447         Reviewed by Adam.
       
 51448 
       
 51449         Don't even attempt to do a document based drag if there isn't a document
       
 51450         Fixes rdar://problem/4960109
       
 51451 
       
 51452         * page/DragController.cpp:
       
 51453         (WebCore::DragController::tryDocumentDrag):  
       
 51454            Null check m_document
       
 51455         (WebCore::DragController::tryDHTMLDrag):
       
 51456            ASSERT(m_document) -- tryDocumentDrag is the only 
       
 51457            thing that will ever call us, but lets play it safe
       
 51458 
       
 51459 2007-02-18  Adam Roben  <aroben@apple.com>
       
 51460 
       
 51461         Reviewed by Hyatt.
       
 51462 
       
 51463         A little preparation for <rdar://problem/5006872>.
       
 51464 
       
 51465         * platform/PopupMenu.h:
       
 51466 
       
 51467 2007-02-18  Alexey Proskuryakov  <ap@webkit.org>
       
 51468 
       
 51469         Reviewed by Adele.
       
 51470 
       
 51471         http://bugs.webkit.org/show_bug.cgi?id=12807
       
 51472         XPath incorrectly converts NaN to boolean
       
 51473 
       
 51474         Test: fast/xpath/nan-to-boolean.html
       
 51475 
       
 51476         * xml/XPathValue.cpp:
       
 51477         (WebCore::XPath::Value::toBoolean): Convert NaN to false.
       
 51478         * xml/XPathFunctions.cpp:
       
 51479         (WebCore::XPath::FunSubstringAfter::doEvaluate): Fix substring-after to actually work.
       
 51480 
       
 51481 2007-02-18  Mitz Pettel  <mitz@webkit.org>
       
 51482 
       
 51483         Reviewed by Hyatt.
       
 51484 
       
 51485         - fix http://bugs.webkit.org/show_bug.cgi?id=12123
       
 51486           REGRESSION: Incomplete repaint of floats' overflows
       
 51487 
       
 51488         Tests: fast/repaint/float-overflow.html
       
 51489                fast/repaint/float-overflow-right.html
       
 51490                fast/repaint/table-cell-vertical-overflow.html
       
 51491 
       
 51492         - fix http://bugs.webkit.org/show_bug.cgi?id=10116
       
 51493           REGRESSION: Menu item drawn 2 pixels short on WWDC 2006 Attendee Site
       
 51494 
       
 51495         Reflected in existing test results.
       
 51496 
       
 51497         Unified floats and overflow for the purposes of painting and hit-testing.
       
 51498         Overhanging and overflowing floats are now factored into a block's overflow
       
 51499         unless their painting has been propagated to an ancestor.
       
 51500 
       
 51501         Changed table cells to no longer expand to enclose overflow, thus making
       
 51502         it purely "visual overflow", having no effect on layout in WebCore. It
       
 51503         still determines scrolling dimensions.
       
 51504 
       
 51505         * rendering/InlineFlowBox.cpp:
       
 51506         (WebCore::InlineFlowBox::placeBoxesHorizontally): Include inline blocks'
       
 51507         horizontal overflow in the inline box's dimensions.
       
 51508         * rendering/RenderBlock.cpp:
       
 51509         (WebCore::RenderBlock::layoutBlock): Removed the expand to enclose overflows
       
 51510         behavior. Added code to add this block's floats (and their overflow) to its
       
 51511         overflow rect if it is not in a block formatting context. Otherwise, the
       
 51512         inclusion of floats in the overflow is deferred until this block's parent
       
 51513         examines its floats and possibly adopts overhanging floats.
       
 51514         (WebCore::RenderBlock::layoutBlockChildren):
       
 51515         (WebCore::RenderBlock::paint): 
       
 51516         (WebCore::RenderBlock::floatRect): Made non-virtual and changed to return an empty
       
 51517         rect if there are no floats or the floats are clipped, instead of returning the border
       
 51518         box.
       
 51519         (WebCore::RenderBlock::addOverhangingFloats): Any floats of the child that
       
 51520         are not to be painted by the parent are added to the child's overflow rect.
       
 51521         (WebCore::RenderBlock::addVisualOverflow): Added. Adjusts the overflow
       
 51522         bounds to include the given rect.
       
 51523         (WebCore::RenderBlock::nodeAtPoint):
       
 51524         * rendering/RenderBlock.h:
       
 51525         * rendering/RenderFlexibleBox.cpp:
       
 51526         (WebCore::RenderFlexibleBox::layoutBlock): 
       
 51527         (WebCore::RenderFlexibleBox::layoutHorizontalBox): After placing a normal
       
 51528         child, add its floats to its overflow, since painting of floats does not
       
 51529         propagate to flexible boxes. 
       
 51530         (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
       
 51531         * rendering/RenderForeignObject.cpp:
       
 51532         (WebCore::RenderForeignObject::layout):
       
 51533         * rendering/RenderHTMLCanvas.cpp:
       
 51534         (WebCore::RenderHTMLCanvas::layout):
       
 51535         * rendering/RenderImage.cpp:
       
 51536         (WebCore::RenderImage::layout):
       
 51537         * rendering/RenderLayer.cpp:
       
 51538         (WebCore::RenderLayer::updateLayerPositions):
       
 51539         (WebCore::RenderLayer::absoluteBoundingBox):
       
 51540         * rendering/RenderLayer.h:
       
 51541         * rendering/RenderObject.cpp:
       
 51542         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
       
 51543         * rendering/RenderObject.h:
       
 51544         (WebCore::RenderObject::expandsToEncloseOverhangingFloats):
       
 51545         * rendering/RenderPath.cpp:
       
 51546         (WebCore::RenderPath::layout):
       
 51547         * rendering/RenderSVGContainer.cpp:
       
 51548         (WebCore::RenderSVGContainer::layout):
       
 51549         * rendering/RenderSVGText.cpp:
       
 51550         (WebCore::RenderSVGText::layout):
       
 51551         * rendering/RenderTable.h: Removed the override of overflowHeight() since now tables can have
       
 51552         vertical overflow.
       
 51553         * rendering/RenderTableCell.cpp:
       
 51554         (WebCore::RenderTableCell::paint): Made sure that overflow is repainted.
       
 51555         * rendering/RenderTableCell.h:
       
 51556         (WebCore::RenderTableCell::expandsToEncloseOverhangingFloats): Removed.
       
 51557         * rendering/RenderTableSection.cpp:
       
 51558         (WebCore::RenderTableSection::RenderTableSection):
       
 51559         (WebCore::RenderTableSection::layoutRows): Factor in vertical overflow from cells.
       
 51560         (WebCore::RenderTableSection::paint):
       
 51561         * rendering/RenderTableSection.h:
       
 51562         (WebCore::RenderTableSection::overflowHeight):
       
 51563         (WebCore::RenderTableSection::overflowTop):
       
 51564 
       
 51565 2007-02-18  Oliver Hunt  <oliver@apple.com>
       
 51566 
       
 51567         Reviewed by NOBODY (Buildfix).
       
 51568 
       
 51569         Build fix for the build fix -- can't call something that isn't a function
       
 51570 
       
 51571         * platform/qt/CursorQt.cpp:
       
 51572         (WebCore::notAllowedCursor):
       
 51573 
       
 51574 2007-02-18  Oliver Hunt  <oliver@apple.com>
       
 51575 
       
 51576         Reviewed by NOBODY (Build fix).
       
 51577 
       
 51578         Adding platform/DragImage.cpp and platform/qt/DragImageQt.cpp to the Qt
       
 51579         project files
       
 51580 
       
 51581         Stubbed method for WebCore::notAllowedCursor -- not sure what it should return, 
       
 51582         have returned blank cursor, possibly needs to return something else
       
 51583 
       
 51584         * WebCore.pro:
       
 51585         * platform/qt/CursorQt.cpp:
       
 51586         (WebCore::notAllowedCursor):
       
 51587 
       
 51588 2007-02-18  Oliver Hunt  <oliver@apple.com>
       
 51589 
       
 51590         Reviewed by NOBODY (Buildfix).
       
 51591 
       
 51592         Sigh, obnoxious occasional auto conversion from float to int
       
 51593 
       
 51594         * platform/mac/ClipboardMac.mm:
       
 51595         (WebCore::ClipboardMac::createDragImage):
       
 51596 
       
 51597 2007-02-18  Alexey Proskuryakov  <ap@webkit.org>
       
 51598 
       
 51599         Reviewed by Hyatt.
       
 51600 
       
 51601         http://bugs.webkit.org/show_bug.cgi?id=12799
       
 51602         REGRESSION: Webpage doesn't load correctly (www.cincinnati.com
       
 51603         redirects to the wrong URL)
       
 51604 
       
 51605         Test: http/tests/misc/refresh-meta-with-newline.html
       
 51606 
       
 51607         * platform/network/HTTPParsers.cpp:
       
 51608         (WebCore::skipWhiteSpace):
       
 51609         (WebCore::parseHTTPRefresh):
       
 51610         * platform/network/HTTPParsers.h:
       
 51611         In HTML, all characters with codes <= 0x20 are whitespace, while in
       
 51612         HTTP, only space and tab are such.
       
 51613 
       
 51614         * dom/Document.cpp:
       
 51615         (WebCore::Document::processHttpEquiv):
       
 51616         * loader/FrameLoader.cpp:
       
 51617         (WebCore::FrameLoader::receivedFirstData):
       
 51618         Pass parseHTTPRefresh() a flag telling about the source of data.
       
 51619 
       
 51620 2007-02-18  Oliver Hunt  <oliver@apple.com>
       
 51621 
       
 51622         Reviewed by NOBODY (Build fix).
       
 51623 
       
 51624         Buld fix -- surprisingly RetainPtr doesn't exist on Qt
       
 51625 
       
 51626         * platform/DragImage.h:
       
 51627 
       
 51628 2007-02-18  Oliver Hunt  <oliver@apple.com>
       
 51629 
       
 51630         Reviewed by Adam.
       
 51631 
       
 51632         More drag and drop migration, now the entirety of the
       
 51633         drag initiation logic has been rendered platform independent
       
 51634         This has required a number of new interfaces, and a reasonable
       
 51635         amount of logic migration.
       
 51636 
       
 51637         As a side effect, this patch also fixes rdar://problem/4945341
       
 51638 
       
 51639         There are some basic Qt stubs that should stop the build from failing,
       
 51640         however the absence of ClipboardQt means any attempt to initiate a drag 
       
 51641         may cause a crash.
       
 51642 
       
 51643         * WebCore.exp:
       
 51644            Exporting new symbols
       
 51645 
       
 51646         * WebCore.xcodeproj/project.pbxproj:
       
 51647            New files
       
 51648 
       
 51649         * dom/Clipboard.cpp:
       
 51650         (WebCore::Clipboard::canSaveAsWebArchive):
       
 51651           Migrated from WebKit
       
 51652 
       
 51653         * dom/Clipboard.h:
       
 51654           Added more methods to allow Clipboard to be used as a 
       
 51655           platform independent container for drag and drop
       
 51656 
       
 51657         * page/DragClient.h:
       
 51658         (WebCore::DragClient::declareAndWriteDragImage):
       
 51659           This is a mac only helper function, so i've made it have an empty implementation,
       
 51660           that way we won't need a PLATFORM(MAC) block in SVGImageEmptyClients
       
 51661 
       
 51662         * page/DragController.cpp:
       
 51663         (WebCore::DragController::dragExited):
       
 51664         (WebCore::DragController::performDrag):
       
 51665         (WebCore::DragController::tryDocumentDrag): 
       
 51666         (WebCore::DragController::tryDHTMLDrag):
       
 51667           Using RefPtrs now
       
 51668         (WebCore::getCachedImage):
       
 51669         (WebCore::getImage):
       
 51670           Helper functions                   
       
 51671         (WebCore::dragLocForDHTMLDrag):
       
 51672         (WebCore::dragLocForSelectionDrag):
       
 51673         (WebCore::DragController::startDrag):
       
 51674         (WebCore::DragController::doImageDrag):
       
 51675         (WebCore::DragController::doSystemDrag):
       
 51676           Logic that generates drag images and clipboard content, and
       
 51677           initiates the actual system drag operation
       
 51678 
       
 51679         * page/DragController.h:
       
 51680           Method and variable declarations
       
 51681 
       
 51682         * page/EventHandler.cpp:
       
 51683         (WebCore::EventHandler::handleDrag):
       
 51684           handleDrag is now platform independent
       
 51685         (WebCore::EventHandler::handleTextInputEvent):
       
 51686            formatting
       
 51687 
       
 51688         * page/EventHandler.h:
       
 51689         (WebCore::EventHandler::eventLoopHandleMouseDragged):
       
 51690           Forgot to define this stub function 
       
 51691 
       
 51692         * page/Frame.h:
       
 51693           Declaring dragImageForSelection to provide drag image for selected content
       
 51694 
       
 51695         * page/mac/DragControllerMac.mm:
       
 51696           Defining drag images control vars
       
 51697 
       
 51698         * page/mac/EventHandlerMac.mm:
       
 51699         (WebCore::EventHandler::createDraggingClipboard):
       
 51700           Migrated old clipboard creation to here
       
 51701 
       
 51702         * page/mac/FrameMac.mm:
       
 51703         (WebCore::Frame::dragImageForSelection):
       
 51704           Wrap FrameMac::selectionImage
       
 51705 
       
 51706         * page/qt/DragControllerQt.cpp:
       
 51707           Defining drag images control vars
       
 51708 
       
 51709         * page/qt/EventHandlerQt.cpp:
       
 51710         (WebCore::EventHandler::createDraggingClipboard):
       
 51711           stub
       
 51712 
       
 51713         * page/qt/FrameQt.cpp:
       
 51714         (WebCore::Frame::dragImageForSelection):
       
 51715           stub
       
 51716 
       
 51717         * platform/DragImage.cpp: Added.
       
 51718         (WebCore::fitDragImageToMaxSize):
       
 51719         (WebCore::createDragImageForSelection):
       
 51720            Platform independent processing for drag images
       
 51721 
       
 51722         * platform/DragImage.h: Added.
       
 51723            Declaring typedefs and wrapper functions to abstract the handling
       
 51724            of drag images 
       
 51725 
       
 51726         * platform/Pasteboard.h:
       
 51727           Declaring extracted writeURL and writeSelection methods
       
 51728 
       
 51729         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 51730         (WebCore::SVGEmptyDragClient::willPerformDragSourceAction):
       
 51731         (WebCore::SVGEmptyDragClient::startDrag):
       
 51732         (WebCore::SVGEmptyDragClient::createDragImageForLink):
       
 51733           Stubs FTW!
       
 51734 
       
 51735         * platform/mac/ClipboardMac.h:
       
 51736         (WebCore::ClipboardMac::pasteboard):
       
 51737           Provide accessor for underlying NSPasteboard
       
 51738 
       
 51739         * platform/mac/ClipboardMac.mm:
       
 51740         (WebCore::ClipboardMac::hasData):
       
 51741         (WebCore::ClipboardMac::writeRange):
       
 51742         (WebCore::ClipboardMac::writeURL):
       
 51743         (WebCore::ClipboardMac::declareAndWriteDragImage):
       
 51744         (WebCore::ClipboardMac::createDragImage):
       
 51745            Implemented new Clipboarid functionality.
       
 51746         (WebCore::ClipboardMac::dragNSImage):
       
 51747            Made this a const method
       
 51748 
       
 51749         * platform/mac/DragImageMac.mm: Added.
       
 51750         (WebCore::dragImageSize):
       
 51751         (WebCore::deleteDragImage):
       
 51752         (WebCore::scaleDragImage):
       
 51753         (WebCore::dissolveDragImageToFraction):
       
 51754         (WebCore::createDragImageFromImage):
       
 51755         (WebCore::createDragImageIconForCachedImage):
       
 51756            Implemented platform specific DragImage functions
       
 51757 
       
 51758         * platform/mac/PasteboardMac.mm:
       
 51759         (WebCore::writeSelection):
       
 51760         (WebCore::Pasteboard::writeSelection):
       
 51761         (WebCore::writeURL):
       
 51762         (WebCore::Pasteboard::writeURL):
       
 51763            Extracted member implementations of these functions, so that
       
 51764            Clipboard could also make use of this functionality.
       
 51765            Pasteboard methods now call the new non-member implementations.
       
 51766            Also fixed implementations to respect the list of requested types.
       
 51767 
       
 51768         * platform/qt/DragImageQt.cpp: Added.
       
 51769         (WebCore::dragImageSize):
       
 51770         (WebCore::deleteDragImage):
       
 51771         (WebCore::scaleDragImage):
       
 51772         (WebCore::dissolveDragImageToFraction):
       
 51773         (WebCore::createDragImageFromImage):
       
 51774         (WebCore::createDragImageIconForCachedImage):  
       
 51775           Stubs
       
 51776 
       
 51777 2007-02-17  David Hyatt  <hyatt@apple.com>
       
 51778 
       
 51779         Fix textarea resizers to not fill with black by making sure the fill color starts off as
       
 51780         transparent instead of black.
       
 51781 
       
 51782         Reviewed by aroben
       
 51783 
       
 51784         * platform/graphics/GraphicsContext.cpp:
       
 51785         (WebCore::GraphicsContextState::GraphicsContextState):
       
 51786 
       
 51787 2007-02-17  Lars Knoll <lars@trolltech.com>
       
 51788 
       
 51789         Reviewed by Adam.
       
 51790 
       
 51791         fix http://bugs.webkit.org/show_bug.cgi?id=11476
       
 51792         <rdar://problem/4960247> REGRESSION: Nesting the IMG tag inside of a
       
 51793         MAP fails to render correctly in ToT
       
 51794 
       
 51795         Test: fast/images/image-in-map.html
       
 51796 
       
 51797         * html/HTMLMapElement.cpp:
       
 51798         (WebCore::HTMLMapElement::checkDTD):
       
 51799 
       
 51800 2007-02-17  Alexey Proskuryakov  <ap@webkit.org>
       
 51801 
       
 51802         Reviewed by Maciej.
       
 51803 
       
 51804         http://bugs.webkit.org/show_bug.cgi?id=12733
       
 51805         XPath namespace is attached to a wrong step
       
 51806 
       
 51807         * xml/XPathGrammar.y: NAMETEST is different from other NodeTests in that its
       
 51808         resulting type is an expanded name, rather than a string. It is not really possible 
       
 51809         to store the namespace inside Parser, because it gets used in wrong steps then.
       
 51810 
       
 51811         * xml/XPathParser.cpp:
       
 51812         (WebCore::XPath::Parser::expandQName):
       
 51813         * xml/XPathParser.h:
       
 51814         Moved code that expands a QName from XPathGrammar.y. Removed m_currentNamespaceURI.
       
 51815 
       
 51816         * xml/XPathStep.cpp:
       
 51817         (WebCore::XPath::Step::Step):
       
 51818         * xml/XPathStep.h:
       
 51819         Added a constructor that takes a namespace.
       
 51820 
       
 51821 2007-02-17  Mitz Pettel  <mitz@webkit.org>
       
 51822 
       
 51823         Reviewed by Maciej.
       
 51824 
       
 51825         - fix http://bugs.webkit.org/show_bug.cgi?id=12479
       
 51826           ASSERTION FAILURE: resource->inCache() in WebCore::Cache::remove
       
 51827 
       
 51828         Test: fast/loader/simultaneous-reloads-assert.html
       
 51829 
       
 51830         * loader/Cache.cpp:
       
 51831         (WebCore::Cache::remove): Replaced the assertion with a check whether the
       
 51832         resource is in the cache. The resource could have been removed from the cache
       
 51833         as a result of a reload occurring simultaneously in a different document.
       
 51834 
       
 51835 2007-02-12  Lars Naesbye Christensen  <lars@naesbye.dk>
       
 51836 
       
 51837         Reviewed by Adam.
       
 51838 
       
 51839         Fix for http://bugs.webkit.org/show_bug.cgi?id=12711
       
 51840         Prettier and more distinct cursors
       
 51841 
       
 51842         * Resources/crossHairCursor.png: Added.
       
 51843         * Resources/northEastSouthWestResizeCursor.png:
       
 51844         * Resources/northWestSouthEastResizeCursor.png:
       
 51845         * Resources/notAllowedCursor.png: Added.
       
 51846         * page/EventHandler.cpp: (WebCore::selectCursor):
       
 51847         * platform/Cursor.h:
       
 51848         * platform/mac/CursorMac.mm:
       
 51849         (WebCore::crossCursor):
       
 51850         (WebCore::notAllowedCursor):
       
 51851 
       
 51852 2007-02-16  Mitz Pettel  <mitz@webkit.org>
       
 51853 
       
 51854         Reviewed by Darin.
       
 51855 
       
 51856         - fix http://bugs.webkit.org/show_bug.cgi?id=12780
       
 51857           REGRESSION (r19341-r19385): Reproducible crash in "onselectstart" event
       
 51858 
       
 51859         Test: fast/events/shadow-boundary-crossing.html
       
 51860 
       
 51861         * dom/EventTargetNode.cpp:
       
 51862         (WebCore::EventTargetNode::dispatchGenericEvent): Changed to use the new
       
 51863         eventParentNode() function for constructing the chain of ancestors for
       
 51864         capture and bubbling.
       
 51865         * dom/Node.h:
       
 51866         (WebCore::Node::eventParentNode): Added. Returns the node's parent for the
       
 51867         purpose of of event capture and bubbling. The base class implementation is
       
 51868         to return the parent node.
       
 51869         * ksvg2/svg/SVGElement.h:
       
 51870         (WebCore::SVGElement::eventParentNode): Added. Since in SVG events bubble
       
 51871         to and can be captured across the shadow DOM boundary, returns the shadow parent
       
 51872         for shadow nodes.
       
 51873 
       
 51874 2007-02-17  Dave Hyatt <hyatt@apple.com>
       
 51875 
       
 51876         Change how textarea resizers paint to more closely match the way the main window resizer paints.
       
 51877         
       
 51878         Reviewed by olliej
       
 51879 
       
 51880         * rendering/RenderLayer.cpp:
       
 51881         (WebCore::RenderLayer::paintOverflowControls):
       
 51882 
       
 51883 2007-02-17  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 51884 
       
 51885         Reviewed by Adam Roben.
       
 51886 
       
 51887         Fix crashes on ARM due to different struct packing. Based on a patch
       
 51888         from Mike Emmel.
       
 51889 
       
 51890         * platform/DeprecatedString.cpp: compile-time assert to make sure sizeof(DeprecatedChar) == 2
       
 51891         * platform/DeprecatedString.h: pack DeprecatedChar struct to ensure that
       
 51892         sizeof(DeprecatedChar) == 2. Move _internalBuffer in DeprecatedStringData
       
 51893         to the end, to avoid crashes on ARM due to different struct packing.
       
 51894 
       
 51895 2007-02-16  Adele Peterson  <adele@apple.com>
       
 51896 
       
 51897         Reviewed by Mitz.
       
 51898 
       
 51899         Fix for http://bugs.webkit.org/show_bug.cgi?id=11534
       
 51900         <rdar://problem/4946947> REGRESSION: Readonly text fields don't scroll when selecting content
       
 51901 
       
 51902         Test: fast/forms/input-readonly-autoscroll.html
       
 51903 
       
 51904         Implemented autoscroll methods for RenderTextControl, so this works on non-editable text controls.
       
 51905 
       
 51906         * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::autoscroll):
       
 51907         * rendering/RenderTextControl.h: (WebCore::RenderTextControl::shouldAutoscroll):
       
 51908 
       
 51909 2007-02-17  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 51910 
       
 51911         Reviewed by Adam Roben.
       
 51912 
       
 51913         Curl networking improvements inspired by Mike Emmel's patches in
       
 51914         http://bugs.webkit.org/show_bug.cgi?id=11332.
       
 51915         Fix FrameLoaderClientGdk due to changed FrameLoaderClient API.
       
 51916 
       
 51917         * loader/gdk/FrameLoaderClientGdk.cpp: Massage for changed API.
       
 51918         (WebCore::FrameLoaderClientGdk::saveViewStateToItem):
       
 51919         (WebCore::FrameLoaderClientGdk::restoreViewState):
       
 51920         (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme):
       
 51921         (WebCore::FrameLoaderClientGdk::willUseArchive):
       
 51922         * loader/gdk/FrameLoaderClientGdk.h: Ditto.
       
 51923         * platform/network/ResourceHandleInternal.h: Remember url and custom headers
       
 51924         for the request lifetime and free them at the end.
       
 51925         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
       
 51926         * platform/network/gdk/ResourceHandleCurl.cpp: Ditto.
       
 51927         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
       
 51928         * platform/network/gdk/ResourceHandleManager.cpp: url improvements:
       
 51929         - remove m_useSimple code-path since it wasn't used anywhere
       
 51930         - don't use hashmap for keeping track of outstanding jobs - curl does it anyway
       
 51931         - set custom headers from request
       
 51932         - enable gzip and deflate through Accept-Encoding
       
 51933         - setup curl to share cookies and DNS cache between requests
       
 51934         - enable persisting of cookies in a file (if client provides file name
       
 51935           for cookies via ResourceHandleManager::setCookieJarFileName())
       
 51936         (WebCore::ResourceHandleManager::ResourceHandleManager):
       
 51937         (WebCore::ResourceHandleManager::setCookieJarFileName):
       
 51938         (WebCore::ResourceHandleManager::downloadTimerCallback):
       
 51939         (WebCore::ResourceHandleManager::removeFromCurl):
       
 51940         (WebCore::ResourceHandleManager::setupPUT):
       
 51941         (WebCore::ResourceHandleManager::setupPOST):
       
 51942         (WebCore::ResourceHandleManager::add):
       
 51943         (WebCore::ResourceHandleManager::cancel):
       
 51944         * platform/network/gdk/ResourceHandleManager.h:
       
 51945 
       
 51946 2007-02-17  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 51947 
       
 51948         Reviewed by Adam Roben.
       
 51949 
       
 51950         Gdk fixes.
       
 51951 
       
 51952         * page/gdk/EventHandlerGdk.cpp: Comment out chatty message.
       
 51953         (WebCore::EventHandler::handleDrag):
       
 51954         * platform/gdk/EditorClientGdk.cpp: Enable entering text into text field.
       
 51955         (WebCore::EditorClientGdk::shouldInsertText):
       
 51956 
       
 51957 2007-02-16  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 51958 
       
 51959         Reviewed by Adam Roben.
       
 51960 
       
 51961         Move Path implementation from TemporaryLinkStubs.cpp to
       
 51962         its own file.
       
 51963         Implement setLineCap, setLineJoin and setMiterLimit for
       
 51964         cairo's GraphicsContext.
       
 51965 
       
 51966         * WebCoreSources.bkl:
       
 51967         * platform/gdk/TemporaryLinkStubs.cpp:
       
 51968         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
 51969         (WebCore::GraphicsContext::setPlatformFillColor):
       
 51970         (WebCore::GraphicsContext::setPlatformStrokeColor):
       
 51971         (WebCore::GraphicsContext::setLineCap):
       
 51972         (WebCore::GraphicsContext::setLineJoin):
       
 51973         (WebCore::GraphicsContext::setMiterLimit):
       
 51974         * platform/graphics/cairo/PathCairo.cpp: Added.
       
 51975         (WebCore::Path::Path):
       
 51976         (WebCore::Path::~Path):
       
 51977         (WebCore::Path::contains):
       
 51978         (WebCore::Path::translate):
       
 51979         (WebCore::Path::boundingRect):
       
 51980         (WebCore::Path::operator=):
       
 51981         (WebCore::Path::clear):
       
 51982         (WebCore::Path::moveTo):
       
 51983         (WebCore::Path::addLineTo):
       
 51984         (WebCore::Path::addQuadCurveTo):
       
 51985         (WebCore::Path::addBezierCurveTo):
       
 51986         (WebCore::Path::addArcTo):
       
 51987         (WebCore::Path::closeSubpath):
       
 51988         (WebCore::Path::addArc):
       
 51989         (WebCore::Path::addRect):
       
 51990         (WebCore::Path::addEllipse):
       
 51991         (WebCore::Path::transform):
       
 51992         (WebCore::Path::apply):
       
 51993 
       
 51994 2007-02-16  Ada Chan  <adachan@apple.com>
       
 51995 
       
 51996         Reviewed by Adam and Maciej.
       
 51997 
       
 51998         Use a RefPtr to store the old hover node.
       
 51999 
       
 52000         * rendering/RenderLayer.cpp:
       
 52001         (WebCore::RenderLayer::updateHoverActiveState):
       
 52002 
       
 52003 2007-02-16  Darin Adler  <darin@apple.com>
       
 52004 
       
 52005         Reviewed by Adele.
       
 52006 
       
 52007         - fix <rdar://problem/4990864> ASSERT in FormDelegate.m while dragging text between frames
       
 52008 
       
 52009         This symptom is specific to Safari, so no layout test.
       
 52010 
       
 52011         * editing/DeleteSelectionCommand.cpp:
       
 52012         (WebCore::DeleteSelectionCommand::doApply): Only call textWillBeDeletedInTextField if the
       
 52013         text field is focused.
       
 52014         * html/HTMLInputElement.cpp:
       
 52015         (WebCore::HTMLInputElement::aboutToUnload): Only call textFieldDidEndEditing if the text
       
 52016         field is focused.
       
 52017         (WebCore::HTMLInputElement::dispatchBlurEvent): Remove unneeded type cast.
       
 52018         (WebCore::HTMLInputElement::defaultEventHandler): Only call doTextFieldCommandFromEvent if
       
 52019         the text field is focused.
       
 52020         * rendering/RenderTextControl.cpp:
       
 52021         (WebCore::RenderTextControl::subtreeHasChanged): Only call textDidChangeInTextArea,
       
 52022         textFieldDidBeginEditing, and textDidChangeInTextField if the element is focused.
       
 52023 
       
 52024 2007-02-16  Anders Carlsson  <acarlsson@apple.com>
       
 52025 
       
 52026         Reviewed by Adam.
       
 52027 
       
 52028         <rdar://problem/4943985> 
       
 52029         REGRESSION: Dragging standalone images to Finder fails to download the image file
       
 52030         
       
 52031         Set the data and response on the image resource. Also, since this is platform-independent we don't need to do it in 
       
 52032         ImageDocumentMac.mm
       
 52033         
       
 52034         * loader/ImageDocument.cpp:
       
 52035         (WebCore::ImageTokenizer::finish):
       
 52036         * loader/mac/ImageDocumentMac.h:
       
 52037         * loader/mac/ImageDocumentMac.mm:
       
 52038         (WebCore::finishImageLoad):
       
 52039 
       
 52040 2007-02-16  David Harrison  <harrison@apple.com>
       
 52041 
       
 52042         Reviewed by Adam.
       
 52043 
       
 52044         <rdar://problem/5004746> Need mechanism to protect against WebKit calls from secondary threads (DOM APIs)
       
 52045 
       
 52046         * platform/mac/LoggingMac.mm:
       
 52047         (WebCore::_WebCoreThreadViolationCheck):
       
 52048         Change the default to log the violations.
       
 52049 
       
 52050 2007-02-16  Adele Peterson  <adele@apple.com>
       
 52051 
       
 52052         Reviewed by Mitz.
       
 52053 
       
 52054         Fixed: http://bugs.webkit.org/show_bug.cgi?id=12768
       
 52055         <rdar://problem/4995250> REGRESSION: Crash occurs at WebCore::RenderLayer::scrollToOffset() when leaving page that has focus in field
       
 52056 
       
 52057         No test case added.  This crash doesn't occur in DumpRenderTree because the B/F cache is turned off.
       
 52058 
       
 52059         * dom/Node.cpp: (WebCore::Node::willRemove): Check that the document is not in the page cache before 
       
 52060 
       
 52061         * dom/Element.cpp: (WebCore::Element::updateFocusAppearance): Added restorePreviousSelection argument, with appropriate default values.
       
 52062         * dom/Element.h: ditto.
       
 52063         * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateFocusAppearance): ditto.
       
 52064         * html/HTMLInputElement.h: ditto.
       
 52065         * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateFocusAppearance): ditto.
       
 52066         * html/HTMLTextAreaElement.h: ditto.
       
 52067 
       
 52068         * page/PageState.cpp: (WebCore::PageState::restore): Call updateFocusAppearance on the focused node for this page.  Pass true for the
       
 52069           restorePreviousSelection argument.
       
 52070 
       
 52071         * rendering/RenderLayer.cpp: Added ASSERTS and nil checks on the RenderView.  It shouldn't be null, but if it is, 
       
 52072           we'll fail silently on release builds.
       
 52073         (WebCore::RenderLayer::updateLayerPositions):
       
 52074         (WebCore::RenderLayer::scrollToOffset):
       
 52075         (WebCore::RenderLayer::windowClipRect):
       
 52076         (WebCore::RenderLayer::calculateClipRects):
       
 52077         (WebCore::RenderLayer::calculateRects):
       
 52078         (WebCore::RenderLayer::intersectsDamageRect):
       
 52079         (WebCore::RenderLayer::absoluteBoundingBox):
       
 52080 
       
 52081 2007-02-16  Anders Carlsson  <acarlsson@apple.com>
       
 52082 
       
 52083         Reviewed by Darin.
       
 52084 
       
 52085         <rdar://problem/4993055> auto_refcount_underflow_error: WebCore::FrameLoader::continueAfterNavigationPolicy () over-releases under GC
       
 52086 
       
 52087         Add ::adoptNS and ::adoptCF methods to RetainPtr to indicate what type of reference to adopt.
       
 52088         
       
 52089         * platform/cf/RetainPtr.h:
       
 52090         (WebCore::):
       
 52091         (WebCore::adoptNSReference):
       
 52092         (WebCore::RetainPtr::RetainPtr):
       
 52093         (WebCore::::adoptCF):
       
 52094         (WebCore::::adoptNS):
       
 52095         * platform/mac/FileChooserMac.mm:
       
 52096         (WebCore::FileChooser::FileChooser):
       
 52097         * platform/network/mac/ResourceErrorMac.mm:
       
 52098         (WebCore::ResourceError::operator NSError*):
       
 52099         * platform/network/mac/ResourceRequestMac.mm:
       
 52100         (WebCore::ResourceRequest::doUpdatePlatformRequest):
       
 52101         * platform/network/mac/ResourceResponseMac.mm:
       
 52102         (WebCore::ResourceResponse::nsURLResponse):
       
 52103 
       
 52104 2007-02-15  Brady Eidson  <beidson@apple.com>
       
 52105 
       
 52106         Reviewed by Lost Objective-C Hippyness (or hippiness)
       
 52107 
       
 52108         Oh boy, did I ever botch this one up...
       
 52109 
       
 52110         * loader/FrameLoader.cpp:
       
 52111         (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem): Null check the FrameView
       
 52112 
       
 52113 2007-02-15  Brady Eidson  <beidson@apple.com>
       
 52114 
       
 52115         Reviewed by Adam's complaint
       
 52116 
       
 52117         Adam wanted me to do an early return, instead.
       
 52118 
       
 52119         * loader/FrameLoader.cpp:
       
 52120         (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem):
       
 52121 
       
 52122 2007-02-15  Brady Eidson  <beidson@apple.com>
       
 52123 
       
 52124         Reviewed by Adele
       
 52125 
       
 52126         Forgot to bring the null check with me when I backed this code out of 
       
 52127         the FrameLoaderClient
       
 52128 
       
 52129         * loader/FrameLoader.cpp:
       
 52130         (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem): null check the HistoryItem
       
 52131 
       
 52132 2007-02-15  Brady Eidson  <beidson@apple.com>
       
 52133 
       
 52134         Reviewed by Adam
       
 52135 
       
 52136         Save scroll state for back/forward navigation in FrameLoader, not the client
       
 52137 
       
 52138        * loader/FrameLoader.cpp:
       
 52139         (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem): Actually save the scroll position
       
 52140          here instead of asking the FrameLoaderClient
       
 52141         (WebCore::FrameLoader::restoreScrollPositionAndViewState): Ditto
       
 52142 
       
 52143         * loader/FrameLoaderClient.h: Renamed/repurposed 2 methods
       
 52144 
       
 52145         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 52146         (WebCore::SVGEmptyFrameLoaderClient::restoreViewState): Ditto
       
 52147         (WebCore::SVGEmptyFrameLoaderClient::saveViewStateToItem): Ditto
       
 52148 
       
 52149 2007-02-15  Justin Garcia  <justin.garcia@apple.com>
       
 52150 
       
 52151         Reviewed by harrison
       
 52152         
       
 52153         <rdar://problem/4989774>
       
 52154         REGRESSION: Pasting a image into a plain text message can place image on a new line
       
 52155 
       
 52156         <span><img><span><img></span></span> will appear as two
       
 52157         images on different lines because of a layout/rendering
       
 52158         bug.  This patch avoids the bug by producing cleaner
       
 52159         markup so that the paste code can safely remove the style 
       
 52160         spans.
       
 52161 
       
 52162         * editing/markup.cpp:
       
 52163         (WebCore::createMarkup): Get the default style from the
       
 52164         editable root or body instead of the document element.
       
 52165         This produces cleaner markup since we don't inline the 
       
 52166         root's styles.
       
 52167 
       
 52168 2007-02-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 52169 
       
 52170         Reviewed by Adam Roben.
       
 52171 
       
 52172         Add gdk version of ContextMenuClient based on qt version.
       
 52173 
       
 52174         * WebCoreSources.bkl:
       
 52175         * page/gdk/ContextMenuClientGdk.cpp: Added.
       
 52176         (WebCore::ContextMenuClientGdk::contextMenuDestroyed):
       
 52177         (WebCore::ContextMenuClientGdk::getCustomMenuFromDefaultItems):
       
 52178         (WebCore::ContextMenuClientGdk::contextMenuItemSelected):
       
 52179         (WebCore::ContextMenuClientGdk::downloadURL):
       
 52180         (WebCore::ContextMenuClientGdk::copyImageToClipboard):
       
 52181         (WebCore::ContextMenuClientGdk::searchWithGoogle):
       
 52182         (WebCore::ContextMenuClientGdk::lookUpInDictionary):
       
 52183         (WebCore::ContextMenuClientGdk::speak):
       
 52184         (WebCore::ContextMenuClientGdk::stopSpeaking):
       
 52185         * page/gdk/ContextMenuClientGdk.h: Added.
       
 52186         * webcore-base.bkl: curl is needed when building webcore_base files.
       
 52187 
       
 52188 2007-02-15  Kevin Decker  <kdecker@apple.com>
       
 52189 
       
 52190        Reviewed by Darin.
       
 52191 
       
 52192        Fixed: <rdar://problem/4983883> Background of a .mov window should not be white
       
 52193 
       
 52194        * loader/PluginDocument.cpp: 
       
 52195        (WebCore::PluginTokenizer::createDocumentStructure): Set a background color of gray
       
 52196        for full frame plug-ins, which makes it easier on the eyes. It's also the same 
       
 52197        gray that PDFKit uses, too.
       
 52198 
       
 52199 2007-02-15  Mitz Pettel  <mitz@webkit.org>
       
 52200 
       
 52201         Reviewed by Darin.
       
 52202 
       
 52203         - fix http://bugs.webkit.org/show_bug.cgi?id=12625
       
 52204           REGRESSION: Crash when closing the web inspector with text selected
       
 52205 
       
 52206         The problem was that selectionRect() was being called on a render tree that
       
 52207         had pending style changes. The changes were committed as a side effect in
       
 52208         the middle of traversing the render tree, and the current object got
       
 52209         deleted as a result. The solution is to update the render tree before
       
 52210         starting to traverse it.
       
 52211 
       
 52212         The inspector was affected because it makes style changes in response to
       
 52213         an AppKit notification that's sent right before the windowDidResignKey:
       
 52214         notification, under which WebKit calls selectionRect(). I couldn't recreate
       
 52215         the same conditions (having uncommitted style changes in the tree when the
       
 52216         window becomes inactive) using HTML/JS in Safari, hence the lack of
       
 52217         a regression test to go with this patch.
       
 52218 
       
 52219         * rendering/RenderView.cpp:
       
 52220         (WebCore::RenderView::selectionRect): Added call to updateRendering().
       
 52221 
       
 52222 2007-02-15  Mitz Pettel  <mitz@webkit.org>
       
 52223 
       
 52224         Reviewed by Darin.
       
 52225 
       
 52226         - fix http://bugs.webkit.org/show_bug.cgi?id=10127
       
 52227           REGRESSION: Crash undoing delete in textarea
       
 52228 
       
 52229         Document::removeMarkers() was using a Vector iterator (which is just a
       
 52230         pointer) and inserting into the Vector at the same time, which made the
       
 52231         iterator invalid as the Vector's data buffer was relocated.
       
 52232         
       
 52233         Replaced all instances of Vector<DocumentMarker>::iterator with indices.
       
 52234 
       
 52235         * dom/Document.cpp:
       
 52236         (WebCore::Document::addMarker):
       
 52237         (WebCore::Document::copyMarkers):
       
 52238         (WebCore::Document::removeMarkers):
       
 52239         (WebCore::Document::repaintMarkers):
       
 52240         (WebCore::Document::shiftMarkers):
       
 52241 
       
 52242 2007-02-15  Mitz Pettel  <mitz@webkit.org>
       
 52243 
       
 52244         Reviewed by Darin.
       
 52245 
       
 52246         - http://bugs.webkit.org/show_bug.cgi?id=12777
       
 52247           REGRESSION (r18574): User profile pages display incorrectly at ebay.ca
       
 52248 
       
 52249         Fixes existing layout tests: tables/mozilla/bugs/bug45486.html
       
 52250                                      tables/mozilla_expected_failures/core/col_span2.html
       
 52251 
       
 52252         * rendering/AutoTableLayout.cpp:
       
 52253         (WebCore::AutoTableLayout::calcEffectiveWidth): Fixed a mismatch between which
       
 52254         columns count as percentage columns when adding up the total percent and
       
 52255         which columns count as percentage columns when converting non-percentage
       
 52256         columns to effectively-percentage.
       
 52257 
       
 52258 2007-02-14  Mitz Pettel  <mitz@webkit.org>
       
 52259 
       
 52260         Reviewed by Sam Weinig!
       
 52261 
       
 52262         - fix http://bugs.webkit.org/show_bug.cgi?id=12773
       
 52263           REGRESSION (r19490): Crash on ipx-server.de
       
 52264 
       
 52265         * manual-tests/background-image-change-in-page-cache.html: Added.
       
 52266         * rendering/RenderBox.cpp:
       
 52267         (WebCore::RenderBox::imageChanged): Bail out if the object is not in a view,
       
 52268         which can happen if the document is in the page cache and the same cached
       
 52269         image used for its background is also being used in another document that
       
 52270         is currently in view.
       
 52271 
       
 52272 2007-02-14  Adam Roben  <aroben@apple.com>
       
 52273 
       
 52274         Reviewed by Darin.
       
 52275 
       
 52276         Fix http://bugs.webkit.org/show_bug.cgi?id=12517
       
 52277         <rdar://problem/4971227> REGRESSION: Tab order incorrect when input
       
 52278         inside frame/iframe gets initial focus (12517)
       
 52279 
       
 52280         Test: fast/events/frame-programmatic-focus.html
       
 52281 
       
 52282         * dom/Element.cpp:
       
 52283         (WebCore::Element::focus): Call FocusController::setFocusedNode to set
       
 52284         the focus for the whole page.
       
 52285         * html/HTMLInputElement.cpp:
       
 52286         (WebCore::HTMLInputElement::focus): Ditto.
       
 52287         * html/HTMLTextAreaElement.cpp:
       
 52288         (WebCore::HTMLTextAreaElement::focus): Ditto.
       
 52289         * page/EventHandler.cpp:
       
 52290         (WebCore::EventHandler::handleTextInputEvent): Send the textInput
       
 52291         event to the same target that was sent the keypress event before it.
       
 52292         * page/FocusController.cpp:
       
 52293         (WebCore::FocusController::advanceFocus): Added a FIXME.
       
 52294         (WebCore::FocusController::setFocusedNode): Added. Sets the focused
       
 52295         node for a whole page.
       
 52296         * page/FocusController.h: Added declaration.
       
 52297         * platform/cf/RetainPtr.h: Removed unused pointer_cast functions.
       
 52298 
       
 52299 2007-02-14  Justin Garcia  <justin.garcia@apple.com>
       
 52300 
       
 52301         Reviewed by adele
       
 52302         
       
 52303         <rdar://problem/4976800>
       
 52304         Outdent combines 2 separate strings on 2 different lines
       
 52305 
       
 52306         * editing/IndentOutdentCommand.cpp:
       
 52307         (WebCore::IndentOutdentCommand::outdentParagraph): Add line breaks
       
 52308         if removing the indented node causes content before or after it to
       
 52309         collapse into the same paragraph as its content.
       
 52310 
       
 52311 2007-02-14  Justin Garcia  <justin.garcia@apple.com>
       
 52312 
       
 52313         Reviewed by adele
       
 52314         
       
 52315         <rdar://problem/4960120>
       
 52316         REGRESSION: First Enter key ignored on initial focus of textarea after page load (11967)
       
 52317         
       
 52318         We'd insert a newline, but into an empty div.  We need two newlines
       
 52319         in that case.
       
 52320 
       
 52321         * editing/InsertLineBreakCommand.cpp:
       
 52322         (WebCore::lineBreakExistsAtPosition): Returns true if there is a
       
 52323         br or a '\n' in text that preserves newlines at the incoming position.
       
 52324         (WebCore::InsertLineBreakCommand::doApply): Fixed to handle the empty
       
 52325         block case, the anonymous block case.
       
 52326 
       
 52327 2007-02-14  Darin Adler  <darin@apple.com>
       
 52328 
       
 52329         Reviewed by Hyatt.
       
 52330 
       
 52331         - test or http://bugs.webkit.org/show_bug.cgi?id=12417
       
 52332           <rdar://problem/4990046> REGRESSION: pressing "Return" in a <select>
       
 52333           box does not submit the form (12697)
       
 52334 
       
 52335         Test: fast/forms/select-enter-key.html
       
 52336 
       
 52337         * html/HTMLSelectElement.cpp:
       
 52338         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
       
 52339         Add code to submit when someone hits the Enter key.
       
 52340 
       
 52341 2007-02-14  Anders Carlsson  <acarlsson@apple.com>
       
 52342 
       
 52343         Reviewed by Darin.
       
 52344 
       
 52345         <rdar://problem/4960112>
       
 52346         http://bugs.webkit.org/show_bug.cgi?id=12417
       
 52347         REGRESSION: "Are you sure you want to send a form again?" sheet is displayed twice (validator.w3.org)
       
 52348         
       
 52349         The problem was that doing a reload would cause the "Cache-Control" HTTP header to be set on the request _after_ the first
       
 52350         navigation policy delegate callback was called. This would break the request equality check that's used to prevent multiple policy
       
 52351         delegate callbacks from getting called for the same request. The solution is to set the header as early as possible.
       
 52352         
       
 52353         This patch also fixes some bugs in the ResourceRequest equality operator.
       
 52354         
       
 52355         * loader/FrameLoader.cpp:
       
 52356         (WebCore::FrameLoader::reload):
       
 52357         Set the "Cache-Control" header field on the request here.
       
 52358         
       
 52359         * platform/network/FormData.h:
       
 52360         (WebCore::operator==):
       
 52361         Short-circuit if the pointers are the same.
       
 52362         
       
 52363         * platform/network/ResourceRequest.cpp:
       
 52364         (WebCore::operator==):
       
 52365         Check the equality of the objects, not the pointers.
       
 52366 
       
 52367 2007-02-14  David Hyatt  <hyatt@apple.com>
       
 52368 
       
 52369         Move setPlatformData out of FontFallbackListMac.mm and delete the file.  The function was completely
       
 52370         cross-platform already.
       
 52371 
       
 52372         Reviewed by Ada
       
 52373 
       
 52374         * WebCore.xcodeproj/project.pbxproj:
       
 52375         * platform/FontFallbackList.cpp:
       
 52376         (WebCore::FontFallbackList::setPlatformFont):
       
 52377 
       
 52378 2007-02-14  David Hyatt  <hyatt@apple.com>
       
 52379 
       
 52380         Make the Font constructor that takes a FontPlatformData cross-platform, since the implementation was already
       
 52381         completely cross-platform.
       
 52382 
       
 52383         Reviewed by Ada
       
 52384 
       
 52385         * platform/Font.cpp:
       
 52386         (WebCore::Font::Font):
       
 52387         * platform/Font.h:
       
 52388         * platform/mac/FontMac.mm:
       
 52389 
       
 52390 2007-02-14  Antti Koivisto  <antti@apple.com>
       
 52391 
       
 52392         Reverting http://bugs.webkit.org/show_bug.cgi?id=11974, it causes repainting problems in some cases.
       
 52393 
       
 52394         * rendering/RenderTextControl.h:
       
 52395         (WebCore::RenderTextControl::avoidsFloats):
       
 52396 
       
 52397 2007-02-14  Antti Koivisto  <antti@apple.com>
       
 52398 
       
 52399         Reviewed by Maciej.
       
 52400         
       
 52401         - fix http://bugs.webkit.org/show_bug.cgi?id=11974
       
 52402         REGRESSION: Caret drawn over input when smaller than font size on initial focus
       
 52403         <rdar://problem/4960258>
       
 52404         
       
 52405         Set controlClip for non-search text controls.
       
 52406 
       
 52407         * rendering/RenderTextControl.h:
       
 52408         (WebCore::RenderTextControl::hasControlClip):
       
 52409 
       
 52410 2007-02-14  Mitz Pettel  <mitz@webkit.org>
       
 52411 
       
 52412         Reviewed by Hyatt.
       
 52413 
       
 52414         - fix http://bugs.webkit.org/show_bug.cgi?id=12726
       
 52415           REGRESSION (r12073): Text wraps in the middle of a word instead of wrapping at the space before the word
       
 52416 
       
 52417         Test: fast/text/break-word.html
       
 52418 
       
 52419         The wrapW variable used to keep track of the width of the characters scanned
       
 52420         so far by adding up the widths of individual characters. Because of the
       
 52421         rounding hack, the total ended up being bigger than the width of the same characters
       
 52422         when measured together as a single run.
       
 52423 
       
 52424         The fix is to use wrapW only as an upper bound, and once it overflows the line's width,
       
 52425         fall back on measuring everything from the beginning of the line as one run.
       
 52426 
       
 52427         * rendering/bidi.cpp:
       
 52428         (WebCore::RenderBlock::findNextLineBreak): Implemented the above fix, including not measuring
       
 52429         additional single characters once wrapW overflows the line. Also moved the assignment
       
 52430         to breakNBSP out of the loop since it is constant for the entire text object, made breakWords and
       
 52431         midWordBreak update only when they might change, and cleaned up a few things.
       
 52432 
       
 52433 2007-02-14  Antti Koivisto  <antti@apple.com>
       
 52434 
       
 52435         Reviewed by Hyatt.
       
 52436 
       
 52437         - fix http://bugs.webkit.org/show_bug.cgi?id=11923
       
 52438         REGRESSION: Placeholder text in password field shows as bullets
       
 52439         <rdar://problem/4960257> 
       
 52440         
       
 52441         Disable textSecurity when placeholder is visible.
       
 52442         
       
 52443         * rendering/RenderTextControl.cpp:
       
 52444         (WebCore::RenderTextControl::updatePlaceholder):
       
 52445 
       
 52446 2007-02-13  Alexey Proskuryakov  <ap@webkit.org>
       
 52447 
       
 52448         Reviewed by Mark Rowe.
       
 52449 
       
 52450         http://bugs.webkit.org/show_bug.cgi?id=12763
       
 52451         REGRESSION: button title is displayed incorrectly at quotes.burntelectrons.org
       
 52452 
       
 52453         Test: fast/parser/entities-in-attributes.xhtml
       
 52454 
       
 52455         * dom/XMLTokenizer.cpp:
       
 52456         (WebCore::getEntityHandler): Set a correct type for the found entity (I'm not really
       
 52457         sure if XML_INTERNAL_GENERAL_ENTITY is _the_ correct one, but it fixes the problem).
       
 52458 
       
 52459 2007-02-13  Darin Adler  <darin@apple.com>
       
 52460 
       
 52461         Reviewed by Hyatt.
       
 52462 
       
 52463         - removed some bogus names (Hyatt smacked me since this doesn't fix a P1)
       
 52464 
       
 52465         * dom/EventNames.h: Removed half-implemented khtmlDragdrop and khtmlMove
       
 52466         (you could add listeners, but nobody ever sent the events). Renamed the
       
 52467         other two khtml-prefixed internal event names to use the webkit prefix.
       
 52468 
       
 52469         * bindings/js/kjs_dom.cpp:
       
 52470         (KJS::DOMEventTargetNode::getValueProperty): Removed ondragdrop and onmove.
       
 52471         (KJS::DOMEventTargetNode::putValueProperty): Ditto.
       
 52472         * bindings/js/kjs_dom.h:
       
 52473         * bindings/js/kjs_window.cpp:
       
 52474         (KJS::Window::getValueProperty): Ditto.
       
 52475         (KJS::Window::put): Ditto.
       
 52476         * bindings/js/kjs_window.h:
       
 52477 
       
 52478         * dom/BeforeTextInsertedEvent.cpp:
       
 52479         (WebCore::BeforeTextInsertedEvent::BeforeTextInsertedEvent): Renamed to webkit.
       
 52480         * editing/Editor.cpp:
       
 52481         (WebCore::dispatchEditableContentChangedEvents): Ditto.
       
 52482         * editing/ReplaceSelectionCommand.cpp:
       
 52483         (WebCore::ReplacementFragment::ReplacementFragment): Ditto.
       
 52484         * html/HTMLTextFieldInnerElement.cpp:
       
 52485         (WebCore::HTMLTextFieldInnerTextElement::defaultEventHandler): Ditto.
       
 52486 
       
 52487 2007-02-13  Darin Adler  <darin@apple.com>
       
 52488 
       
 52489         Rubber stamped by Maciej.
       
 52490 
       
 52491         * dom/EventNames.h: Resort names. Removed unused names.
       
 52492 
       
 52493 2007-02-13  Anders Carlsson  <acarlsson@apple.com>
       
 52494 
       
 52495         Reviewed by Kevin Decker.
       
 52496 
       
 52497         <rdar://problem/4990049> 
       
 52498         http://bugs.webkit.org/show_bug.cgi?id=12718
       
 52499         REGRESSION: Segmentation fault when loading abc.go.com (12718)
       
 52500 
       
 52501         The problem is that redirecting to about:blank causes the delegate to be released even though the load wasn't finished.
       
 52502         This is usally not a problem since NSURLConnection retains its delegate. However, the proxy delegate does not retain _it's_ 
       
 52503         delegate. The solution is to make releaseDelegate clear out the proxy delegate's delegate.
       
 52504         
       
 52505         * platform/network/mac/ResourceHandleMac.mm:
       
 52506         (WebCore::ResourceHandle::releaseDelegate):
       
 52507         If there's a proxy, nil out its delegate too.
       
 52508 
       
 52509 2007-02-13  Dex Deacon  <occupant4@gmail.com>
       
 52510 
       
 52511         Reviewed by Darin.
       
 52512 
       
 52513         - fix for http://bugs.webkit.org/show_bug.cgi?id=12750
       
 52514           Vector operator== was not defined correctly. It returned void,
       
 52515           did not accept const Vectors, and used an int instead of size_t. 
       
 52516 
       
 52517         * rendering/RenderStyle.h: Added a != operator for StyleDashboardRegion.
       
 52518         The only reason this compiled before was that the comparing two vectors
       
 52519         with a != was simply comparing the pointers.
       
 52520 
       
 52521 2007-02-13  Darin Adler  <darin@apple.com>
       
 52522 
       
 52523         - roll out fix for <rdar://problem/4874059> REGRESSION: Painter IX:register -
       
 52524           Crash in WebCore:: ResourceLoader::willSendRequest()
       
 52525 
       
 52526         This fix was causing a crash in at least one layout test.
       
 52527 
       
 52528         * loader/FrameLoader.cpp:
       
 52529         (WebCore::FrameLoader::stopAllLoaders):
       
 52530         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
       
 52531 
       
 52532 2007-02-13  Mitz Pettel  <mitz@webkit.org>
       
 52533 
       
 52534         Reviewed by Hyatt.
       
 52535 
       
 52536         - fix http://bugs.webkit.org/show_bug.cgi?id=12746
       
 52537         REGRESSION (r13853): List item's first line overflows containing div
       
 52538 
       
 52539         Test: fast/lists/item-not-in-list-line-wrapping.html
       
 52540 
       
 52541         * rendering/bidi.cpp:
       
 52542         (WebCore::RenderBlock::findNextLineBreak): Use the list marker's isInside()
       
 52543         instead of looking at its style()->listStylePosition(), since if the
       
 52544         list item is not in a list, the marker is inside regardless of the style.
       
 52545 
       
 52546 2007-02-13  Rob Buis  <buis@kde.org>
       
 52547 
       
 52548         Reviewed by Maciej.
       
 52549 
       
 52550         http://bugs.webkit.org/show_bug.cgi?id=12578
       
 52551         WebKit incorrectly strokes zero-width/height rectangles
       
 52552 
       
 52553         Create an empty path when encountering zero-width/height rectangles, similar to circles with zero radius.
       
 52554 
       
 52555         * platform/graphics/Path.cpp:
       
 52556         (WebCore::Path::createRectangle):
       
 52557 
       
 52558 2007-02-13  Rob Buis  <buis@kde.org>
       
 52559 
       
 52560         Reviewed by Maciej.
       
 52561 
       
 52562         Remove SVGDOMImplementation from the project.
       
 52563 
       
 52564         * CMakeLists.txt:
       
 52565         * WebCore.pro:
       
 52566         * ksvg2/svg/SVGDOMImplementation.cpp: Removed.
       
 52567         * ksvg2/svg/SVGDOMImplementation.h: Removed.
       
 52568 
       
 52569 2007-02-13  Brady Eidson <beidson@apple.com>
       
 52570 
       
 52571         Reviewed by Maciej and Adam
       
 52572 
       
 52573         Fixes <rdar://problem/4985497> - Crash when opening a new window to "Same Page"
       
 52574 
       
 52575         * loader/FrameLoader.cpp:
       
 52576         (WebCore::FrameLoader::loadItem): Null check documentLoader() since if we're a brand new 
       
 52577           WebView, cloning the history of another view, we have no documentLoader()
       
 52578 
       
 52579 2007-02-12  Antti Koivisto  <antti@apple.com>
       
 52580 
       
 52581         Reviewed by Maciej.
       
 52582 
       
 52583         -fix REGRESSION: <select disabled size="5"> listbox cannot be scrolled
       
 52584         http://bugs.webkit.org/show_bug.cgi?id=11852
       
 52585         <rdar://problem/4960129>
       
 52586         
       
 52587         Pass mouse press events to scrollbars even if event is swallowed.
       
 52588         
       
 52589         No layout test, DumpRenderTree eventSender can't hit scrollbars.
       
 52590 
       
 52591         * page/EventHandler.cpp:
       
 52592         (WebCore::EventHandler::handleMousePressEvent):
       
 52593 
       
 52594 2007-02-12  David Hyatt  <hyatt@apple.com>
       
 52595 
       
 52596         Fix for bug 12149 (Radar Bug#4928692), external CSS causes incomplete
       
 52597         text field focus.
       
 52598 
       
 52599         Make sure to clear out the focus node in willRemove() rather than in
       
 52600         detach(), since detach/attach caused by style recalc should not affect
       
 52601         the focused node.
       
 52602 
       
 52603         Reviewed by aroben
       
 52604 
       
 52605         * dom/ContainerNode.cpp:
       
 52606         (WebCore::ContainerNode::willRemove):
       
 52607         * dom/Document.cpp:
       
 52608         (WebCore::Document::focusedNodeRemoved):
       
 52609         (WebCore::Document::setFocusedNode):
       
 52610         * dom/Document.h:
       
 52611         * dom/Element.cpp:
       
 52612         (WebCore::Element::updateFocusAppearance):
       
 52613         * dom/Node.cpp:
       
 52614         (WebCore::Node::willRemove):
       
 52615         (WebCore::Node::detach):
       
 52616         * html/HTMLInputElement.cpp:
       
 52617         (WebCore::HTMLInputElement::updateFocusAppearance):
       
 52618 
       
 52619 2007-02-12  Kevin McCullough  <kmccullough@apple.com>
       
 52620 
       
 52621         - reverting fix for rdar://problem/4922454 because it caused regressions
       
 52622           and performance problems
       
 52623 
       
 52624         * bindings/objc/DOM.mm:
       
 52625         (-[DOMElement image]):
       
 52626         (-[DOMElement _imageTIFFRepresentation]):
       
 52627         * dom/XMLTokenizer.cpp:
       
 52628         (WebCore::XMLTokenizer::notifyFinished):
       
 52629         * html/HTMLImageLoader.cpp:
       
 52630         (WebCore::HTMLImageLoader::dispatchLoadEvent):
       
 52631         * html/HTMLTokenizer.cpp:
       
 52632         (WebCore::HTMLTokenizer::reset):
       
 52633         (WebCore::HTMLTokenizer::notifyFinished):
       
 52634         * ksvg2/misc/SVGImageLoader.cpp:
       
 52635         (WebCore::SVGImageLoader::dispatchLoadEvent):
       
 52636         * loader/Cache.cpp:
       
 52637         (WebCore::Cache::requestResource):
       
 52638         (WebCore::Cache::remove):
       
 52639         * loader/CachedImage.h:
       
 52640         (WebCore::CachedImage::canRender):
       
 52641         (WebCore::CachedImage::isErrorImage):
       
 52642         * loader/CachedResource.h:
       
 52643         * loader/CachedScript.h:
       
 52644         (WebCore::CachedScript::errorOccurred):
       
 52645         * loader/DocLoader.cpp:
       
 52646         (WebCore::DocLoader::requestResource):
       
 52647         (WebCore::DocLoader::setLoadInProgress):
       
 52648         * loader/FrameLoader.cpp:
       
 52649         (WebCore::FrameLoader::canLoad):
       
 52650         * page/EventHandler.cpp:
       
 52651         (WebCore::selectCursor):
       
 52652         * rendering/HitTestResult.cpp:
       
 52653         (WebCore::HitTestResult::image):
       
 52654         * rendering/RenderImage.cpp:
       
 52655         (WebCore::RenderImage::setCachedImage):
       
 52656         (WebCore::RenderImage::imageChanged):
       
 52657         (WebCore::RenderImage::paint):
       
 52658         (WebCore::RenderImage::layout):
       
 52659         (WebCore::RenderImage::calcAspectRatioWidth):
       
 52660         (WebCore::RenderImage::calcAspectRatioHeight):
       
 52661         * rendering/RenderImage.h:
       
 52662         (WebCore::RenderImage::isErrorImage):
       
 52663         * rendering/RenderListItem.cpp:
       
 52664         (WebCore::RenderListItem::setStyle):
       
 52665         * rendering/RenderListMarker.cpp:
       
 52666         (WebCore::RenderListMarker::isImage):
       
 52667 
       
 52668 2007-02-12  Mitz Pettel  <mitz@webkit.org>
       
 52669 
       
 52670         Reviewed by Dave Hyatt.
       
 52671 
       
 52672         - fix http://bugs.webkit.org/show_bug.cgi?id=12123
       
 52673           REGRESSION: Incomplete repaint of floats' overflows
       
 52674 
       
 52675         Tests: fast/repaint/float-overflow.html
       
 52676                fast/repaint/float-overflow-right.html
       
 52677 
       
 52678         - fix http://bugs.webkit.org/show_bug.cgi?id=10116
       
 52679           REGRESSION: Menu item drawn 2 pixels short on WWDC 2006 Attendee Site
       
 52680 
       
 52681         Reflected in existing test results.
       
 52682 
       
 52683         Unified floats and overflow for the purposes of painting and hit-testing.
       
 52684         Overhanging and overflowing floats are now factored into a block's overflow
       
 52685         unless their painting has been propagated to an ancestor.
       
 52686 
       
 52687         Changed table cells to no longer expand to enclose overflow, thus making
       
 52688         it purely "visual overflow", having no effect on layout in WebCore. It
       
 52689         still determines scrolling dimensions.
       
 52690 
       
 52691         * rendering/InlineFlowBox.cpp:
       
 52692         (WebCore::InlineFlowBox::placeBoxesHorizontally): Include inline blocks'
       
 52693         horizontal overflow in the inline box's dimensions.
       
 52694         * rendering/RenderBlock.cpp:
       
 52695         (WebCore::RenderBlock::layoutBlock): Removed the expand to enclose overflows
       
 52696         behavior. Added code to add this block's floats (and their overflow) to its
       
 52697         overflow rect if it is not in a block formatting context. Otherwise, the
       
 52698         inclusion of floats in the overflow is deferred until this block's parent
       
 52699         examines its floats and possibly adopts overhanging floats.
       
 52700         (WebCore::RenderBlock::layoutBlockChildren):
       
 52701         (WebCore::RenderBlock::paint): 
       
 52702         (WebCore::RenderBlock::floatRect): Changed to return an empty rect if there
       
 52703         are no floats or the floats are clipped, instead of returning the border box.
       
 52704         (WebCore::RenderBlock::addOverhangingFloats): Any floats of the child that
       
 52705         are not to be painted by the parent are added to the child's overflow rect.
       
 52706         (WebCore::RenderBlock::addVisualOverflow): Added. Adjusts the overflow
       
 52707         bounds to include the given rect.
       
 52708         (WebCore::RenderBlock::nodeAtPoint):
       
 52709         * rendering/RenderBlock.h:
       
 52710         * rendering/RenderFlexibleBox.cpp:
       
 52711         (WebCore::RenderFlexibleBox::layoutBlock): 
       
 52712         (WebCore::RenderFlexibleBox::layoutHorizontalBox): After placing a normal
       
 52713         child, add its floats to its overflow, since painting of floats does not
       
 52714         propagate to flexible boxes. 
       
 52715         (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
       
 52716         * rendering/RenderForeignObject.cpp:
       
 52717         (WebCore::RenderForeignObject::layout):
       
 52718         * rendering/RenderHTMLCanvas.cpp:
       
 52719         (WebCore::RenderHTMLCanvas::layout):
       
 52720         * rendering/RenderImage.cpp:
       
 52721         (WebCore::RenderImage::layout):
       
 52722         * rendering/RenderLayer.cpp:
       
 52723         (WebCore::RenderLayer::updateLayerPositions):
       
 52724         (WebCore::RenderLayer::absoluteBoundingBox):
       
 52725         * rendering/RenderLayer.h:
       
 52726         * rendering/RenderObject.cpp:
       
 52727         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
       
 52728         * rendering/RenderObject.h:
       
 52729         (WebCore::RenderObject::expandsToEncloseOverhangingFloats):
       
 52730         * rendering/RenderPath.cpp:
       
 52731         (WebCore::RenderPath::layout):
       
 52732         * rendering/RenderSVGContainer.cpp:
       
 52733         (WebCore::RenderSVGContainer::layout):
       
 52734         * rendering/RenderSVGText.cpp:
       
 52735         (WebCore::RenderSVGText::layout):
       
 52736         * rendering/RenderTable.cpp:
       
 52737         (WebCore::RenderTable::layout):
       
 52738         * rendering/RenderTableCell.h:
       
 52739         (WebCore::RenderTableCell::expandsToEncloseOverhangingFloats):
       
 52740 
       
 52741 2007-02-12  Darin Adler  <darin@apple.com>
       
 52742 
       
 52743         Reviewed by Hyatt.
       
 52744 
       
 52745         - fix http://bugs.webkit.org/show_bug.cgi?id=12668
       
 52746           <rdar://problem/4893344> REGRESSION: underline not visible for the international
       
 52747           input inline hole in most text fields (12668)
       
 52748 
       
 52749         - fix bug where overline and line-through were 1px lower than we intended
       
 52750 
       
 52751         * platform/graphics/GraphicsContext.h: Removed unneeded y offset parameter.
       
 52752         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
 52753         (WebCore::GraphicsContext::drawLineForText): Removed bogus y offset and +1.
       
 52754         * platform/graphics/cg/GraphicsContextCG.cpp:
       
 52755         (WebCore::GraphicsContext::drawLineForText): Ditto.
       
 52756         * platform/graphics/qt/GraphicsContextQt.cpp:
       
 52757         (WebCore::GraphicsContext::drawLineForText): Ditto.
       
 52758 
       
 52759         * rendering/InlineFlowBox.cpp:
       
 52760         (WebCore::InlineFlowBox::paintTextDecorations): Added the "+1" that used to be
       
 52761         inside drawLineForText to the underline-drawing code. Changed the other callers
       
 52762         of drawLineForText to include the y offset in the y coordinate.
       
 52763         * rendering/InlineTextBox.cpp:
       
 52764         (WebCore::InlineTextBox::paintDecoration): Ditto. Also renamed _tx and _ty to
       
 52765         remove the gratuitious underscores.
       
 52766         (WebCore::InlineTextBox::paintMarkedTextUnderline): Made the default thickness
       
 52767         be 1px instead of 0 (which ends up being roughly 1px in the CG code path anyway).
       
 52768         Fixed the code computing the position to put the underline at the bottom of the
       
 52769         line (different from regular underlines which are put 1px under the baseline).
       
 52770         The old code used to put the underline 1px further down in the thick case, and
       
 52771         2px further down in the non-thick case. Both of those are bad, because they
       
 52772         could be completely clipped out in many cases.
       
 52773 
       
 52774 2007-02-12  Anders Carlsson  <acarlsson@apple.com>
       
 52775 
       
 52776         Reviewed by Darin.
       
 52777 
       
 52778         <rdar://problem/4846962>
       
 52779         Aperture: Aperture 1.5 - DOM exception occurs when exporting a web gallery
       
 52780 
       
 52781         * dom/ContainerNode.cpp:
       
 52782         (WebCore::ContainerNode::replaceChild):
       
 52783         Call checkReplaceChild here.
       
 52784         
       
 52785         * dom/Document.cpp:
       
 52786         (WebCore::Document::canReplaceChild):
       
 52787         * dom/Document.h:
       
 52788         Add implementation of canReplaceChild that makes sure that doing the replacement won't cause
       
 52789         more than one element and document type node to end up in the document.
       
 52790         
       
 52791         * dom/Node.cpp:
       
 52792         (WebCore::Node::canReplaceChild):
       
 52793         Base implementation of canReplaceChild.
       
 52794         
       
 52795         (WebCore::Node::checkReplaceChild):
       
 52796         New function that does what checAddChild does but calls canReplaceChild.
       
 52797         
       
 52798 2007-02-12  Kevin Decker <kdecker@apple.com>
       
 52799 
       
 52800         Reviewed by Anders.
       
 52801 
       
 52802         Fixed: <rdar://problem/4874059> REGRESSION: Painter IX:register - Crash in WebCore:: ResourceLoader::willSendRequest()
       
 52803         
       
 52804         What happened here was that a WebDataSource was being dealloced *while* a load for that resource is still in progress. 
       
 52805 
       
 52806         * loader/FrameLoader.cpp:
       
 52807         (WebCore::FrameLoader::stopAllLoaders): Calling stopAllLoaders cancels loads and informs the frame load delegate accordingly.
       
 52808         The delegate however may decide to kick off a new provisional load as the result of the cancel. Therefore a local variable 
       
 52809         for the provisional and main doucment loader is introduced, and we now only nil out the provisional loader if the local and
       
 52810         member provisional variables represent the exact same load.
       
 52811         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Added the same check here, too.
       
 52812 
       
 52813 2007-02-12  Lars Knoll  <lars@trolltech.com>
       
 52814 
       
 52815         Reviewed by Mitz.
       
 52816 
       
 52817         Do not create child renderers for table column groups
       
 52818         if the child has not a table column display type.
       
 52819 
       
 52820         * dom/Node.cpp:
       
 52821         (WebCore::Node::createRendererIfNeeded):
       
 52822         * rendering/RenderObject.h:
       
 52823         (WebCore::RenderObject::isChildAllowed):
       
 52824         * rendering/RenderTableCol.cpp:
       
 52825         (WebCore::RenderTableCol::isChildAllowed):
       
 52826         * rendering/RenderTableCol.h:
       
 52827 
       
 52828 2007-02-12  Antti Koivisto  <antti@apple.com>
       
 52829 
       
 52830         Reviewed by Mitz
       
 52831 
       
 52832         Fix assertion failure in layout test.
       
 52833 
       
 52834         * html/HTMLMapElement.cpp:
       
 52835         (WebCore::HTMLMapElement::parseMappedAttribute):
       
 52836 
       
 52837 2007-02-12  Kevin McCulough  <kmccullough@apple.com>
       
 52838 
       
 52839         Reviewed by Brady.
       
 52840 
       
 52841         - Fixing a performance regression caused by r19500.  The heart of the matter
       
 52842         is that we now call canLoad on every resource request even ones in the cache,
       
 52843         to avoid a security issue. So I could not take out the canLoad call, but I
       
 52844         but I could try to make it more efficient.
       
 52845 
       
 52846         * loader/DocLoader.cpp:
       
 52847         (WebCore::DocLoader::requestResource):
       
 52848         (WebCore::DocLoader::setLoadInProgress):
       
 52849         * loader/FrameLoader.cpp:
       
 52850         (WebCore::FrameLoader::canLoad):
       
 52851 
       
 52852 2007-02-12  Darin Adler  <darin@apple.com>
       
 52853 
       
 52854         Reviewed by Oliver.
       
 52855 
       
 52856         - fix http://bugs.webkit.org/show_bug.cgi?id=12677
       
 52857           <rdar://problem/4759563> REGRESSION: Return key is always sent when you confirm
       
 52858           a clause in kotoeri (12677)
       
 52859 
       
 52860         - fix http://bugs.webkit.org/show_bug.cgi?id=12596
       
 52861           <rdar://problem/4794346> REGRESSION: Tab key shifts form field focus instead of
       
 52862           navigating prediction window (12596)
       
 52863 
       
 52864         - fix http://bugs.webkit.org/show_bug.cgi?id=10010
       
 52865           <rdar://problem/4822935> REGRESSION: Pressing Return with unconfirmed text in
       
 52866           Hangul inserts carriage return (10010)
       
 52867 
       
 52868         - fix http://bugs.webkit.org/show_bug.cgi?id=12531
       
 52869           <rdar://problem/4975126> REGRESSION: Inline text input types repeated keys in
       
 52870           latest nightly (r19336) (12531)
       
 52871 
       
 52872         - fix http://bugs.webkit.org/show_bug.cgi?id=12539
       
 52873           <rdar://problem/4975130> REGRESSION: Pressing Backspace while in inline input
       
 52874           area moves to the previous page in history (12539)
       
 52875 
       
 52876         This area still needs work because keypress events are being sent for all the
       
 52877         events before they go to the input methods, and it seems that this is not
       
 52878         compatible with what other browsers do and with what sites assume. That's covered
       
 52879         by this bug:
       
 52880 
       
 52881             http://bugs.webkit.org/show_bug.cgi?id=10871
       
 52882             <rdar://problem/4823129> REGRESSION: IME key events different in nightly (10871)
       
 52883 
       
 52884         which is still open.
       
 52885 
       
 52886         * bindings/objc/ExceptionHandlers.h: Remove selectRange helper that doesn't really
       
 52887         belong here, and also isn't needed since the callers don't want to raise ObjC
       
 52888         exceptions.
       
 52889         * bindings/objc/ExceptionHandlers.mm: Ditto. Also removed unneeded external globals
       
 52890         that aren't exported anyway and unneeded includes.
       
 52891 
       
 52892         * bridge/EditorClient.h: Added Mac-specific function, markedTextAbandoned. Long term
       
 52893         this might move into platform instead, but it's fine to have it on the client for now
       
 52894         as long as it doesn't cause trouble for platforms other than Mac.
       
 52895 
       
 52896         * dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Since
       
 52897         all the event handling code in this function is intended to run on the node itself,
       
 52898         not parent nodes, check and do nothing if this event is bubbling up from another
       
 52899         node. Added code to call a function on EventHandler for default handling of text
       
 52900         input events.
       
 52901 
       
 52902         * dom/KeyboardEvent.h:
       
 52903         * dom/KeyboardEvent.cpp: (WebCore::findKeyboardEvent): Added. Just like the
       
 52904         findUIEventWithKeyState function, but specific to keyboard events.
       
 52905 
       
 52906         * dom/TextEvent.h: Added isLineBreak and isBackTab flags so that we can carry
       
 52907         additional information about what a text input event is trying to do, but still
       
 52908         go through the DOM event machinery.
       
 52909         * dom/TextEvent.cpp: Ditto.
       
 52910 
       
 52911         * editing/Editor.h:
       
 52912         * editing/Editor.cpp:
       
 52913         (WebCore::Editor::handleKeyPress): Removed unneeded check of isCaretOrRange, since
       
 52914         isContentEditable already checks that.
       
 52915         (WebCore::Editor::canEdit): Ditto.
       
 52916         (WebCore::Editor::canEditRichly): Ditto.
       
 52917         (WebCore::Editor::canPaste): Changed to call canEdit for brevity.
       
 52918         (WebCore::Editor::replaceSelectionWithText): Changed to take a const String&.
       
 52919         (WebCore::Editor::shouldInsertText): Ditto.
       
 52920         (WebCore::hasEditableSelection): Removed unneeded check of isCaretOrRange, since
       
 52921         isContentEditable already checks that.
       
 52922         (WebCore::Editor::Editor): Initialize the new m_ignoreMarkedTextSelectionChange
       
 52923         flag. Moved here from WebHTMLView.
       
 52924         (WebCore::Editor::insertText): Moved most of the code from -[WebHTMLView insertText:]
       
 52925         here, since this needs to be done in response to a text input event and we don't want
       
 52926         to go back over the WebKit side for that.
       
 52927         (WebCore::Editor::insertLineBreak): Added. Moved here from -[WebHTMLView insertLineBreak:]
       
 52928         for the same reason -- needs to be done in response to text input events.
       
 52929         (WebCore::Editor::insertParagraphSeparator): Ditto.
       
 52930         (WebCore::Editor::selectMarkedText): Added. Used by insertText.
       
 52931         (WebCore::Editor::discardMarkedText): Added. Used by insertText.
       
 52932         (WebCore::Editor::unmarkText): Added. Used by insertText.
       
 52933         * editing/mac/EditorMac.mm:
       
 52934         (WebCore::Editor::unmarkText): Added. Used by insertText.
       
 52935 
       
 52936         * html/HTMLInputElement.cpp:
       
 52937         (WebCore::HTMLInputElement::canHaveSelection): Changed to use isTextField to avoid repeating
       
 52938         the switch statement.
       
 52939         (WebCore::HTMLInputElement::selectionStart): Ditto.
       
 52940         (WebCore::HTMLInputElement::selectionEnd): Ditto.
       
 52941         (WebCore::HTMLInputElement::setSelectionStart): Ditto.
       
 52942         (WebCore::HTMLInputElement::setSelectionEnd): Ditto.
       
 52943         (WebCore::HTMLInputElement::select): Ditto.
       
 52944         (WebCore::HTMLInputElement::setSelectionRange): Ditto.
       
 52945         (WebCore::HTMLInputElement::createRenderer): Resorted cases alphaebtically.
       
 52946         (WebCore::HTMLInputElement::defaultEventHandler): Added code to make hitting return cause the
       
 52947         form to be submitted when it comes through as a text input event. This is now the normal case
       
 52948         on Macintosh, because enter key presses normally turn into this. In addition, change the other
       
 52949         event handling to run only after trying the base defaultEventHandler. That makes the key
       
 52950         handling done in EventTargetNode take precedence over the event handling here for editable text
       
 52951         fields, which is what we want. This gets rid of the need for the hack where we check
       
 52952         inputManagerHasMarkedText and suppress the handling of the enter key.
       
 52953 
       
 52954         * page/EventHandler.h: Removed unneeded includes. Moved EventHandlerDragState down into the
       
 52955         private part of the class. Changed sendContextMenuEvent to take a const&. Added new
       
 52956         handleTextInputEvent and defaultTextInputEventHandler functions. Made eventLoopHandleMouseUp
       
 52957         and eventLoopHandleMouseDragged private. Added private defaultTabEventHandler function.
       
 52958         * page/EventHandler.cpp:
       
 52959         (WebCore::EventHandler::sendContextMenuEvent): Changed parameter to be a const&.
       
 52960         (WebCore::EventHandler::defaultKeyboardEventHandler): Rearranged things so that the key bindings
       
 52961         handling in handleKeyPress comes before special tab event handling. In cases where the tab turns
       
 52962         into text to insert, we now handle it in the text input event handler.
       
 52963         (WebCore::EventHandler::handleTextInputEvent): Added. Creates and dispatches a text input event.
       
 52964         (WebCore::EventHandler::defaultTextInputEventHandler): Added. Inserts text, but has special cases
       
 52965         for the tab and newline character cases.
       
 52966         (WebCore::EventHandler::defaultTabEventHandler): Added. Shared by the tab-handling code in
       
 52967         the keyboard event and text input event handlers.
       
 52968         * page/mac/EventHandlerMac.mm: Tweak formatting, remove some unused functions.
       
 52969 
       
 52970         * page/FocusController.h: Removed unnneded includes and forwards, and added an overload of
       
 52971         advanceFocus that takes a FocusDirection parameter.
       
 52972         * page/FocusController.cpp: (WebCore::FocusController::advanceFocus): Changed to allow a 0 for
       
 52973         the event pointer. Also added a version where the direction is passed explicitly, to be used
       
 52974         for cases where we want to tab backward even if the event doesn't have a shift modifier key set.
       
 52975 
       
 52976         * platform/graphics/svg/SVGImageEmptyClients.h: Updated for change to EditorClient.
       
 52977         This should really probably just use 0 for the EditorClient.
       
 52978 
       
 52979         * WebCore.exp: Update both for newly used and no-longer-used entry points.
       
 52980 
       
 52981         * page/mac/WebCoreFrameBridge.h:
       
 52982         * page/mac/WebCoreFrameBridge.mm: Removed two unused methods.
       
 52983 
       
 52984 2007-02-12  Antti Koivisto  <antti@apple.com>
       
 52985 
       
 52986         Reviewed by Darin.
       
 52987 
       
 52988         - fixed Imagemap not clickable in www.toptenbooks.net/
       
 52989         http://bugs.webkit.org/show_bug.cgi?id=12738
       
 52990         
       
 52991         Make imagemap names case insensitive in HTML mode
       
 52992 
       
 52993         * dom/Document.cpp:
       
 52994         (WebCore::Document::getImageMap):
       
 52995         * html/HTMLMapElement.cpp:
       
 52996         (WebCore::HTMLMapElement::parseMappedAttribute):
       
 52997 
       
 52998 2007-02-12  Maciej Stachowiak  <mjs@apple.com>
       
 52999 
       
 53000         Reviewed by Antti.
       
 53001 
       
 53002         - fixed <rdar://problem/4928675> REGRESSION: Crash in CGBlt_copyBytes under WebCore::Font::drawGlyphs (12083)
       
 53003         http://bugs.webkit.org/show_bug.cgi?id=12083
       
 53004         
       
 53005         Test: fast/text/text-shadow-extreme-value.html
       
 53006 
       
 53007         * platform/graphics/cg/GraphicsContextCG.cpp:
       
 53008         (WebCore::GraphicsContext::setShadow): Clamp shadow value to 1000px, anything more seems to 
       
 53009         make CG unhappy.
       
 53010 
       
 53011 2007-02-11  Brady Eidson <beidson@apple.com>
       
 53012 
       
 53013         Reviewed by Maciej.
       
 53014 
       
 53015         First in what will be a series of HistoryItem enhancements to help debugging
       
 53016 
       
 53017         * history/HistoryItem.cpp:
       
 53018         (WebCore::HistoryItem::showTree):
       
 53019         (WebCore::HistoryItem::showTreeWithIndent):
       
 53020         (showTree): Outside of WebCore namespace, and extern "C" - to make even the 
       
 53021           DWARF debugger able to find it...  *sigh* 
       
 53022         * history/HistoryItem.h:
       
 53023 
       
 53024 2007-02-11  Eric Seidel  <eric@webkit.org>
       
 53025 
       
 53026         Reviewed by Anders.
       
 53027 
       
 53028         - fixed <rdar://problem/4975133> ASSERT failure and crash right-clicking on image in SVG use test
       
 53029         http://bugs.webkit.org/show_bug.cgi?id=12580
       
 53030         
       
 53031         Test: svg/cust/use-events-crash.svg
       
 53032 
       
 53033         * bindings/js/kjs_dom.cpp:
       
 53034         (KJS::toJS):
       
 53035         * ksvg2/svg/SVGElementInstance.cpp:
       
 53036         (WebCore::SVGElementInstance::toNode):
       
 53037         * ksvg2/svg/SVGElementInstance.h:
       
 53038 
       
 53039 2007-02-11  Mitz Pettel  <mitz@webkit.org>
       
 53040 
       
 53041         Reviewed by Maciej.
       
 53042 
       
 53043         - fix http://bugs.webkit.org/show_bug.cgi?id=10144
       
 53044           REGRESSION: Reproducible assertion failure in DeleteSelectionCommand::fixupWhitespace()
       
 53045 
       
 53046         Test: fast/text/delete-hard-break-character.html
       
 53047 
       
 53048         The bug was caused by not updating a line whose line break object and offset
       
 53049         has been deleted. When deleting text, all lines containing the deleted text
       
 53050         are marked dirty. However, if the first character being deleted is a newline
       
 53051         which serves as a hard line break for the previous line, then that line will
       
 53052         not be marked, and since it will be a clean line ending with a line break,
       
 53053         relayout will begin at the next line. The fix is to check for this when
       
 53054         determining where to relayout from. 
       
 53055 
       
 53056         * rendering/bidi.cpp:
       
 53057         (WebCore::RenderBlock::determineStartPosition): Changed the condition for
       
 53058         including the last clean line in relayout to include the case where the
       
 53059         last clean line ends with a line break, but that line break is a newline that
       
 53060         has been deleted.
       
 53061 
       
 53062 2007-02-12  Antti Koivisto  <antti@apple.com>
       
 53063 
       
 53064         Reviewed by Maciej.
       
 53065         
       
 53066         REGRESSION: Google Calendar cell highlight misplaced
       
 53067         http://bugs.webkit.org/show_bug.cgi?id=12687
       
 53068         
       
 53069         Make offsetLeft/offsetTop/offsetParent behavior match Firefox.
       
 53070 
       
 53071         * rendering/RenderObject.cpp:
       
 53072         (WebCore::RenderObject::offsetLeft):
       
 53073         (WebCore::RenderObject::offsetTop):
       
 53074         (WebCore::RenderObject::offsetParent):
       
 53075 
       
 53076 2007-02-10  Antti Koivisto  <antti@apple.com>
       
 53077 
       
 53078         Reviewed by Maciej.
       
 53079 
       
 53080         - fixed REGRESSION: No day/week scrollbar in Google Calendar
       
 53081         http://bugs.webkit.org/show_bug.cgi?id=11985
       
 53082 
       
 53083         Make sure overflow:auto scrollbars are always enabled. If they were overflow:scroll
       
 53084         and dynamically changed to auto they might still be disabled.
       
 53085 
       
 53086         * rendering/RenderLayer.cpp:
       
 53087         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
       
 53088 
       
 53089 2007-02-11  Alexey Proskuryakov  <ap@webkit.org>
       
 53090 
       
 53091         Reviewed by Hyatt.
       
 53092 
       
 53093         http://bugs.webkit.org/show_bug.cgi?id=12581
       
 53094         XPath //title shouldn't match <title> in XHTML
       
 53095 
       
 53096         Test: fast/xpath/ensure-null-namespace.xhtml
       
 53097 
       
 53098         * xml/XPathStep.cpp:
       
 53099         (WebCore::XPath::Step::nodeTestMatches): Only let a null namespace match any for HTML.
       
 53100 
       
 53101 2007-02-10  Alexey Proskuryakov  <ap@webkit.org>
       
 53102 
       
 53103         Reviewed by Adam.
       
 53104 
       
 53105         http://bugs.webkit.org/show_bug.cgi?id=12701
       
 53106         REGRESSION: After javascript, onChange not triggered when selecting same option
       
 53107 
       
 53108         * html/HTMLSelectElement.cpp:
       
 53109         (WebCore::HTMLSelectElement::setSelectedIndex): Remember m_lastOnChangeIndex value,
       
 53110         as it can change from setSelected() now.
       
 53111         (WebCore::HTMLSelectElement::notifyOptionSelected): Update m_lastOnChangeIndex.
       
 53112 
       
 53113         * manual-tests/select-onchange-after-js.html: Added. Also tests for bug 11402.
       
 53114 
       
 53115 2007-02-10  David Carson  <dacarson@gmail.com>`
       
 53116 
       
 53117         Reviewed by Maciej.
       
 53118 
       
 53119         Manual tests for http://bugs.webkit.org/show_bug.cgi?id=12636
       
 53120         Call different Java methods that take a variety of Array parameters
       
 53121         from Javascript, passing a Javascript array.
       
 53122 
       
 53123         * manual-tests/liveconnect-applet-array-parameters.html: Added.
       
 53124         * manual-tests/resources/ArrayParameterTestApplet.class: Added.
       
 53125         * manual-tests/resources/ArrayParameterTestApplet.java: Added.
       
 53126 
       
 53127 2007-02-10  Alexey Proskuryakov  <ap@webkit.org>
       
 53128 
       
 53129         Reviewed by Maciej.
       
 53130 
       
 53131         http://bugs.webkit.org/show_bug.cgi?id=12724
       
 53132         Crash when enumerating XPath namespace axis
       
 53133 
       
 53134         * xml/XPathStep.cpp:
       
 53135         (WebCore::XPath::Step::nodesInAxis): Namespace axis enumeration was broken in that it crashed, and also in that
       
 53136         it returned attribute nodes instead of XPath namespace ones. Removed it altogether.
       
 53137 
       
 53138 2007-02-10  Mitz Pettel  <mitz@webkit.org>
       
 53139 
       
 53140         Reviewed by Adam.
       
 53141 
       
 53142         - fix http://bugs.webkit.org/show_bug.cgi?id=12565
       
 53143           ASSERTION failure on some declarative animations <rdar://problem/4975132>
       
 53144 
       
 53145         * ksvg2/svg/SVGAnimationElement.cpp:
       
 53146         (WebCore::parseValues): Changed the string length math to avoid truncating
       
 53147         the last character of each value.
       
 53148         * manual-tests/svg-animation-parseValues.svg: Added.
       
 53149 
       
 53150 2007-02-10  Mitz Pettel  <mitz@webkit.org>
       
 53151 
       
 53152         Reviewed by Adam.
       
 53153 
       
 53154         - fix http://bugs.webkit.org/show_bug.cgi?id=11621
       
 53155           REGRESSION (Native slider): slider thumb not updated when the mouse is dragged/released out of range
       
 53156 
       
 53157         No automated test case because dumping the render tree updates layer positions anyway.
       
 53158 
       
 53159         * manual-tests/slider-thumb-tracking.html: Added.
       
 53160         * rendering/RenderSlider.cpp:
       
 53161         (WebCore::RenderSlider::setCurrentPosition): Added call to updateLayerPosition()
       
 53162         for the thumb's layer.
       
 53163 
       
 53164 2007-02-09  Brady Eidson <beidson@apple.com>
       
 53165 
       
 53166         Reviewed by Maciej
       
 53167 
       
 53168         <rdar://problem/4965133> WebKit sends file:// url referrers
       
 53169 
       
 53170         * loader/SubresourceLoader.cpp:
       
 53171         (WebCore::SubresourceLoader::create): In SubresourceLoader::create(), we make a copy of the original request
       
 53172         to use for the load.  We then call FrameLoader::canLoad() which tells us if we should hide the referer.  Before 
       
 53173         this fix if it said to hide the referrer, we would simply not apply a new referrer to our copy of the request.
       
 53174         But if the original request already had a referrer, so did our copy.  We simply have to clear the referrer from
       
 53175         the copied request.
       
 53176 
       
 53177 2007-02-10  Maciej Stachowiak  <mjs@apple.com>
       
 53178 
       
 53179         Reviewed by me, patch from Ian Eng (cleaned up by me some).
       
 53180 
       
 53181         - fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)
       
 53182         
       
 53183         Test case: fast/dom/Window/window-appendages-cleared.html
       
 53184 
       
 53185         * bindings/js/kjs_window.cpp:
       
 53186         (KJS::Window::clearHelperObjectProperties):
       
 53187         (KJS::Window::clear):
       
 53188         * bindings/js/kjs_window.h:
       
 53189 
       
 53190 2007-02-09  Brady Eidson  <beidson@apple.com>
       
 53191 
       
 53192         Reviewed by Tim Hatcher
       
 53193 
       
 53194         <rdar://problem/4985497> - Plugs a potential null DocumentLoader deref when 
       
 53195         transitioning out of the Bookmarks View
       
 53196 
       
 53197         * loader/FrameLoader.cpp:
       
 53198         (WebCore::FrameLoader::recursiveGoToItem): add a null check
       
 53199 
       
 53200 2007-02-09  Beth Dakin  <bdakin@apple.com>
       
 53201 
       
 53202         Rubber-stamped by John . . . and Adam.
       
 53203 
       
 53204         * page/ContextMenuController.cpp:
       
 53205         (WebCore::ContextMenuController::contextMenuItemSelected): Missing 
       
 53206         break.
       
 53207 
       
 53208 2007-02-09  Justin Garcia  <justin.garcia@apple.com>
       
 53209 
       
 53210         Reviewed by darin
       
 53211 
       
 53212         <rdar://problem/4975120>
       
 53213         REGRESSION: double-cursor after switching window away/back (11770)
       
 53214         <http://bugs.webkit.org/show_bug.cgi?id=11328>
       
 53215         Gmail Editor: Caret can simultaneously appear in both the TO: and message body fields
       
 53216 
       
 53217         * page/mac/WebCoreFrameBridge.h: Removed two unused methods
       
 53218         left over from the old form control implementation.
       
 53219 
       
 53220 2007-02-09  John Sullivan  <sullivan@apple.com>
       
 53221 
       
 53222         * rendering/bidi.cpp:
       
 53223         (WebCore::bidiNext):
       
 53224         At Darin's suggestion, moved the "next = 0" line from my previous patch to the start of the loop body
       
 53225 
       
 53226 2007-02-09  Justin Garcia  <justin.garcia@apple.com>
       
 53227 
       
 53228         Reviewed by john
       
 53229         
       
 53230         <rdar://problem/4960116>
       
 53231         REGRESSION: Nightly Safari crashes in WebCore::SelectionController::xPosForVerticalArrowNavigation (12416)
       
 53232 
       
 53233         * editing/SelectionController.cpp:
       
 53234         (WebCore::SelectionController::xPosForVerticalArrowNavigation):
       
 53235         Null check.  VisiblePosition creation can fail if a node that 
       
 53236         contains the selection was made invisible after the selection 
       
 53237         was made and before this function is called during a selection 
       
 53238         modification operation.
       
 53239 
       
 53240 2007-02-09  Justin Garcia  <justin.garcia@apple.com>
       
 53241 
       
 53242         Reviewed by john
       
 53243         
       
 53244         <rdar://problem/4983858>
       
 53245         REGRESSION: In a new mail message, attempting to select a single word causes the selection to extend to the previous line
       
 53246 
       
 53247         * editing/TextIterator.cpp:
       
 53248         (WebCore::SimplifiedBackwardsTextIterator::exitNode):
       
 53249         We recently split shouldEmitNewlineForNode into
       
 53250         shouldEmitNewline{Before, After}Node, so this function now
       
 53251         needs an implementation that is different from
       
 53252         SimplifiedBackwardsTextIterator::handleNonTextNode.  The
       
 53253         difference is that we must call shouldEmit*BeforeNode
       
 53254         instead of shouldEmit*AfterNode since we are a) exiting
       
 53255         nodes and b) moving backward.
       
 53256 
       
 53257 2007-02-09  Justin Garcia  <justin.garcia@apple.com>
       
 53258 
       
 53259         Reviewed by john
       
 53260 
       
 53261         <rdar://problem/4916541>
       
 53262         Some of the selection isn't preserved during an Indent opreration
       
 53263 
       
 53264         * editing/IndentOutdentCommand.cpp:
       
 53265         (WebCore::indexForVisiblePosition): Added.
       
 53266         (WebCore::IndentOutdentCommand::indentRegion): Use rangeLength
       
 53267         and rangeFromLocationAndLength to restore the selection after
       
 53268         the repeated moveParagraph calls necessary to perform indent are
       
 53269         finished.
       
 53270 
       
 53271 2007-02-09  John Sullivan  <sullivan@apple.com>
       
 53272 
       
 53273         Reviewed by Kevin Decker
       
 53274         
       
 53275         - fixed <rdar://problem/4960095> REPRODUCIBLE HANG: WebKit freezes when printing as PDF
       
 53276           a certain kind of code (12449)
       
 53277  
       
 53278         No test case because I don't know how to make the bug occur without printing.
       
 53279 
       
 53280         * rendering/bidi.cpp:
       
 53281         (WebCore::bidiNext):
       
 53282         reset loop's "next" variable after using it; we were setting "current" to the same value
       
 53283         of "next" each subsequent time through the loop, which is not helpful.
       
 53284 
       
 53285 2007-02-09  Darin Adler  <darin@apple.com>
       
 53286 
       
 53287         Reviewed by Adele.
       
 53288 
       
 53289         - Add TextEvent to the DOM (based on the proposed DOM level 3)
       
 53290           to be used to fix some international input bugs soon.
       
 53291           At this point, we don't send any text events.
       
 53292 
       
 53293         - Remove some obsolete files.
       
 53294 
       
 53295         * CMakeLists.txt:
       
 53296         * WebCore.pro:
       
 53297         * WebCore.xcodeproj/project.pbxproj:
       
 53298         * WebCoreSources.bkl:
       
 53299         Add new files, remove obsolete files.
       
 53300 
       
 53301         * DerivedSources.make: Add TextEvent to the Objective-C and JavaScript bindings lists.
       
 53302         * WebCore.exp: Export DOMTextEvent Objective-C wrapper.
       
 53303 
       
 53304         * bindings/js/kjs_events.cpp: (KJS::toJS): Added TextEvent to the list of Event subclasses
       
 53305         so we make the right kind of JS wrapper.
       
 53306         * bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:]): Same thing, for Objective-C.
       
 53307 
       
 53308         * bindings/objc/DOMInternal.h: Added DOMTextEventInternal.h.
       
 53309 
       
 53310         * dom/DOMImplementation.cpp: (WebCore::DOMImplementation::hasFeature):
       
 53311         Added "TextEvents", "3.0" to the list of things we'll answer true for
       
 53312         (as specified in the DOM Level 3 documentation).
       
 53313         This isn't so great until we actually send textInput events, but that's coming soon.
       
 53314 
       
 53315         * dom/Document.cpp: (WebCore::Document::createEvent): Add "TextEvent" as a way to make
       
 53316         a TextEvent (as specified in the DOM Level 3 documentation).
       
 53317 
       
 53318         * dom/Event.h:
       
 53319         * dom/Event.cpp: (WebCore::Event::isTextEvent): Added virtual function to be used
       
 53320         for runtime type checking of Event objects (as for other event types).
       
 53321 
       
 53322         * dom/TextEvent.cpp: Added.
       
 53323         * dom/TextEvent.h: Added.
       
 53324         * dom/TextEvent.idl: Added.
       
 53325 
       
 53326         * platform/mac/WebCoreWidgetHolder.h: Removed.
       
 53327         * rendering/CounterListItem.h: Removed.
       
 53328         * rendering/CounterResetNode.cpp: Removed.
       
 53329         * rendering/CounterResetNode.h: Removed.
       
 53330 
       
 53331 2007-02-09  Anders Carlsson  <acarlsson@apple.com>
       
 53332 
       
 53333         Reviewed by Geoff.
       
 53334 
       
 53335         <rdar://problem/4816376> 
       
 53336         REGRESSION: NetNewsWire 3.0 - Crashes in WebDocumentLoaderMac::attachToFrame() (12674)
       
 53337         
       
 53338         The bug was that the NNW policy delegate never calls back on the policy listener so we'll try to do a load
       
 53339         while there's a policy decision underway. The extra call to setPolicyDocumentLoader would cause a detached (and deallocated)
       
 53340         WebDataSource to be reattached and thus causing a crash.
       
 53341         
       
 53342         * loader/FrameLoader.cpp:
       
 53343         (WebCore::FrameLoader::load):
       
 53344         Remove extra call to setPolicyDocumentLoader.
       
 53345 
       
 53346 2007-02-09  Beth Dakin  <bdakin@apple.com>
       
 53347 
       
 53348         Reviewed by Darin.
       
 53349 
       
 53350         Fix for <rdar://problem/4674537> REGRESSION: Adobe Acrobat 8 - Text 
       
 53351         blinks when mouse is moved, and is invisible otherwise
       
 53352 
       
 53353         Acrobat 8 was relying on a WebKit bug that was fixed about a year 
       
 53354         ago with r12753. The bug was that we would not reload a page if the 
       
 53355         source of an iframe was set to the same value it already was. Now 
       
 53356         that we have fixed the bug, Acrobat constantly reloads their EULA, 
       
 53357         making it blinky and impossible to read. 
       
 53358 
       
 53359         No layout test since the fix is to add an Acrobat-specific quirk.
       
 53360 
       
 53361         * WebCore.exp:
       
 53362         * html/HTMLFrameElementBase.cpp:
       
 53363         (WebCore::HTMLFrameElementBase::setLocation): If the new url is the 
       
 53364         same as the old one and we are honoring the Acrobat quirk, don't do 
       
 53365         anything.
       
 53366         * page/Settings.cpp:
       
 53367         (WebCore::Settings::Settings):
       
 53368         (WebCore::Settings::setNeedsAcrobatFrameReloadingQuirk):
       
 53369         * page/Settings.h:
       
 53370         (WebCore::Settings::needsAcrobatFrameReloadingQuirk):
       
 53371 
       
 53372 2007-02-09  Brady Eidson  <beidson@apple.com>
       
 53373 
       
 53374         Rubberstamped by Dave Harrison
       
 53375 
       
 53376         Disable the thread-check assertion in WebCore, as well as Webkit
       
 53377 
       
 53378         * WebCore.xcodeproj/project.pbxproj:
       
 53379 
       
 53380 2007-02-08  Anders Carlsson  <acarlsson@apple.com>
       
 53381 
       
 53382         Reviewed by Geoff.
       
 53383 
       
 53384         No need to pause timeout checks anymore.
       
 53385         
       
 53386         * bindings/js/kjs_window.cpp:
       
 53387         (KJS::WindowFunc::callAsFunction):
       
 53388 
       
 53389 2007-02-09  John Sullivan  <sullivan@apple.com>
       
 53390 
       
 53391         Reviewed by Beth
       
 53392         
       
 53393         - WebCore part of fix for radar 4939636, problems with context menu items and binaries linked
       
 53394           against WebKit 2.0.
       
 53395 
       
 53396         * platform/ContextMenuItem.h:
       
 53397         (WebCore::):
       
 53398         Tweaked comment; bumped enum value for new SPI tags to avoid conflict with pre-3.0 SPI tag values.
       
 53399 
       
 53400 2007-02-09  Nicholas Shanks  <webkit@nickshanks.com>
       
 53401 
       
 53402         Reviewed by Dave Hyatt.
       
 53403 
       
 53404         Removed broken recognition of :last-* and :only-* selectors
       
 53405 
       
 53406         * css/CSSGrammar.y:
       
 53407         * css/CSSSelector.cpp:
       
 53408         (WebCore::CSSSelector::extractPseudoType):
       
 53409         * css/CSSSelector.h:
       
 53410         (WebCore::CSSSelector::):
       
 53411         * css/cssstyleselector.cpp:
       
 53412         (WebCore::CSSStyleSelector::checkOneSelector):
       
 53413 
       
 53414 2007-02-09  Maciej Stachowiak  <mjs@apple.com>
       
 53415 
       
 53416         Reviewed by Mark.
       
 53417 
       
 53418         <rdar://problem/4980176>
       
 53419 
       
 53420         * page/Frame.cpp:
       
 53421         (WebCore::Frame::pageDestroyed): Since this frame is getting
       
 53422         disconnected from its page, ensure it is not the focus node.
       
 53423 
       
 53424 2007-02-09  Krzysztof  <kkowalczyk@gmail.com>
       
 53425 
       
 53426         Reviewed by Maciej.
       
 53427 
       
 53428         gdklauncher crashes when compiled with NDEBUG defined.
       
 53429 
       
 53430         * Projects/gdk/webcore-gdk.bkl:
       
 53431 
       
 53432 2007-02-09  Maciej Stachowiak  <mjs@apple.com>
       
 53433 
       
 53434         Reviewed by Mitz.
       
 53435 
       
 53436         <rdar://problem/4971224> REGRESSION: ASSERT in WebCore with Mail (12491)
       
 53437         http://bugs.webkit.org/show_bug.cgi?id=12491
       
 53438 
       
 53439         No test case. Not testable since there is no way to do substitute
       
 53440         data loads from layout tests.
       
 53441         
       
 53442         * loader/MainResourceLoader.cpp:
       
 53443         (WebCore::MainResourceLoader::continueAfterContentPolicy): Don't dispatch data load
       
 53444         callback when loading empty data.
       
 53445 
       
 53446 2007-02-09  Mark Rowe  <mrowe@apple.com>
       
 53447 
       
 53448         Reviewed by Maciej.
       
 53449 
       
 53450         http://bugs.webkit.org/show_bug.cgi?id=12705
       
 53451         REGRESSION: Crash with user stylesheet set
       
 53452 
       
 53453         Allow the Frame::canLoad check to skipped so that user stylesheets can be loaded in remote documents.
       
 53454 
       
 53455         * ChangeLog:
       
 53456         * loader/DocLoader.cpp:
       
 53457         (WebCore::DocLoader::requestCSSStyleSheet): Skip canLoad check if this is a user stylesheet.
       
 53458         (WebCore::DocLoader::requestUserCSSStyleSheet):
       
 53459         (WebCore::DocLoader::requestResource): Allow canLoad check to be skipped.
       
 53460         * loader/DocLoader.h:
       
 53461         * page/Frame.cpp:
       
 53462         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
       
 53463 
       
 53464 2007-02-08  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 53465 
       
 53466         Reviewed by Darin.
       
 53467 
       
 53468         Linux/gdk build fixes.
       
 53469 
       
 53470         * Projects/gdk/webcore-gdk.bkl: Account for file renaming.
       
 53471         * platform/gdk/KeyEventGdk.cpp: Make gdk's tab key recognized as tab so that
       
 53472         keyboard link walking works on gdk.
       
 53473         (WebCore::keyIdentifierForGdkKeyCode):
       
 53474 
       
 53475 2007-02-08  Adele Peterson  <adele@apple.com>
       
 53476 
       
 53477         Reviewed by Brady.
       
 53478 
       
 53479         Fix for http://bugs.webkit.org/show_bug.cgi?id=12599
       
 53480         <rdar://problem/4973507> REGRESSION: When replying in Gmail, the caret disappears when you start to type (12599)
       
 53481 
       
 53482         When a frame's window was focused, the page didn't get updated about the new frame getting focus.
       
 53483         This was causing handleKeyPress to fail because it kept getting a selection for the wrong frame (which wasn't editable).
       
 53484 
       
 53485         Test: fast/frames/iframe-window-focus.html
       
 53486 
       
 53487         * page/Frame.cpp:
       
 53488         (WebCore::Frame::focusWindow):
       
 53489         (WebCore::Frame::unfocusWindow):
       
 53490         * page/Frame.h:
       
 53491         * page/mac/FrameMac.mm:
       
 53492         (WebCore::FrameMac::focusWindow):
       
 53493         (WebCore::FrameMac::unfocusWindow):
       
 53494 
       
 53495 2007-02-08  Adele Peterson  <adele@apple.com>
       
 53496 
       
 53497         Reviewed by Brady.
       
 53498 
       
 53499         Fix for http://bugs.webkit.org/show_bug.cgi?id=12480
       
 53500         <rdar://problem/4971222> REGRESSION (NativeListBox): Deselecting option causes list to jump to top
       
 53501 
       
 53502         Test: fast/forms/listbox-deselect-scroll.html
       
 53503 
       
 53504         * html/HTMLSelectElement.cpp:
       
 53505         (WebCore::HTMLSelectElement::activeSelectionStartListIndex): Added.  Returns the index for the active selection.  If there is no active selection,
       
 53506          it returns the first selected index.
       
 53507         (WebCore::HTMLSelectElement::activeSelectionEndListIndex): Added.  If there is no active selection, it returns the last selected index.
       
 53508         * html/HTMLSelectElement.h:
       
 53509         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::scrollToRevealSelection): Instead of using the first and last selected indices,
       
 53510           use the active selection indices to determine which item to reveal.  This way, when you're selecting with the keyboard, or the mouse,
       
 53511           no unnecessary scrolling will occur if the end of your active selection is already visible.
       
 53512 
       
 53513 2007-02-08  Adele Peterson  <adele@apple.com>
       
 53514 
       
 53515         Reviewed by Hyatt.
       
 53516 
       
 53517         Fix for <rdar://problem/4963411> Items of SELECT element are incorrectly highlighted when display:block is set
       
 53518 
       
 53519         Test: fast/forms/select-block-background.html
       
 53520 
       
 53521         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject):
       
 53522           Paint the item backgrounds during the PaintPhaseChildBlockBackground or PaintPhaseChildBlockBackgrounds phase.
       
 53523 
       
 53524 2007-02-08  Mitz Pettel  <mitz@webkit.org>
       
 53525 
       
 53526         Reviewed by Adele.
       
 53527 
       
 53528         - fix http://bugs.webkit.org/show_bug.cgi?id=11047
       
 53529           REGRESSION: Empty options cause the entire select to collapse
       
 53530         
       
 53531         Test: fast/forms/select-empty-option-height.html
       
 53532 
       
 53533         - fix http://bugs.webkit.org/show_bug.cgi?id=10783
       
 53534           REGRESSION (r16044): Clicking a popup changes layout around it
       
 53535 
       
 53536         * rendering/RenderMenuList.cpp:
       
 53537         (WebCore::RenderMenuList::setText): If the option text is empty, use a RenderBR
       
 53538         as inner text, to ensure that the inner div has line height.
       
 53539 
       
 53540 2007-02-08  Geoffrey Garen  <ggaren@apple.com>
       
 53541 
       
 53542         Reviewed by Beth Dakin.
       
 53543 
       
 53544         Added a hard counter for SubresourceLoaders because the leaks tool now
       
 53545         ignores them.
       
 53546         
       
 53547         * loader/SubresourceLoader.cpp:
       
 53548         (WebCore::):
       
 53549         (WebCore::SubresourceLoaderCounter::~SubresourceLoaderCounter):
       
 53550         (WebCore::SubresourceLoader::SubresourceLoader):
       
 53551         (WebCore::SubresourceLoader::~SubresourceLoader):
       
 53552         * page/Frame.cpp: Removed unnecessary #define
       
 53553 
       
 53554 2007-02-08  Geoffrey Garen  <ggaren@apple.com>
       
 53555 
       
 53556         Reviewed by Beth Dakin.
       
 53557 
       
 53558         Fixed <rdar://problem/4982374> CSSComputedStyleDeclaration::getPropertyCSSValue 
       
 53559         leak reported by buildbot
       
 53560         
       
 53561         The leak was a typo: "new" instead of "return new". I also generously
       
 53562         deployed RefPtr in places that were holding ref-counted objects in
       
 53563         bare pointers.
       
 53564 
       
 53565         * css/CSSComputedStyleDeclaration.cpp:
       
 53566         (WebCore::valueForShadow):
       
 53567         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 53568 
       
 53569 2007-02-08  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 53570 
       
 53571         Reviewed by Adam Roben.
       
 53572 
       
 53573         Linux/gdk build fixes.
       
 53574 
       
 53575         * platform/gdk/EditorClientGdk.cpp: Added. Based on qt version.
       
 53576         (WebCore::EditorClientGdk::shouldDeleteRange):
       
 53577         (WebCore::EditorClientGdk::shouldShowDeleteInterface):
       
 53578         (WebCore::EditorClientGdk::isContinuousSpellCheckingEnabled):
       
 53579         (WebCore::EditorClientGdk::isGrammarCheckingEnabled):
       
 53580         (WebCore::EditorClientGdk::spellCheckerDocumentTag):
       
 53581         (WebCore::EditorClientGdk::shouldBeginEditing):
       
 53582         (WebCore::EditorClientGdk::shouldEndEditing):
       
 53583         (WebCore::EditorClientGdk::shouldInsertText):
       
 53584         (WebCore::EditorClientGdk::shouldApplyStyle):
       
 53585         (WebCore::EditorClientGdk::didBeginEditing):
       
 53586         (WebCore::EditorClientGdk::respondToChangedContents):
       
 53587         (WebCore::EditorClientGdk::didEndEditing):
       
 53588         (WebCore::EditorClientGdk::didWriteSelectionToPasteboard):
       
 53589         (WebCore::EditorClientGdk::didSetSelectionTypesForPasteboard):
       
 53590         (WebCore::EditorClientGdk::selectWordBeforeMenuEvent):
       
 53591         (WebCore::EditorClientGdk::isEditable):
       
 53592         (WebCore::EditorClientGdk::registerCommandForUndo):
       
 53593         (WebCore::EditorClientGdk::registerCommandForRedo):
       
 53594         (WebCore::EditorClientGdk::clearUndoRedoOperations):
       
 53595         (WebCore::EditorClientGdk::canUndo):
       
 53596         (WebCore::EditorClientGdk::canRedo):
       
 53597         (WebCore::EditorClientGdk::undo):
       
 53598         (WebCore::EditorClientGdk::redo):
       
 53599         (WebCore::EditorClientGdk::shouldInsertNode):
       
 53600         (WebCore::EditorClientGdk::pageDestroyed):
       
 53601         (WebCore::EditorClientGdk::smartInsertDeleteEnabled):
       
 53602         (WebCore::EditorClientGdk::toggleContinuousSpellChecking):
       
 53603         (WebCore::EditorClientGdk::toggleGrammarChecking):
       
 53604         (WebCore::EditorClientGdk::handleKeyPress):
       
 53605         (WebCore::EditorClientGdk::EditorClientGdk):
       
 53606         (WebCore::EditorClientGdk::setPage):
       
 53607         * platform/gdk/EditorClientGdk.h: Added. Ditto.
       
 53608         * platform/gdk/FrameGdk.cpp: Add exitAfterLoading and dumpRenderTreeAfterLoading
       
 53609         as small debugging features. Remove FrameGdkClient as no other platform has Frame*Client
       
 53610         anymore. Adjust for new APIs.
       
 53611         (WebCore::FrameGdk::FrameGdk):
       
 53612         (WebCore::FrameGdk::onDidFinishLoad):
       
 53613         (WebCore::FrameGdk::dumpRenderTree):
       
 53614         (WebCore::FrameGdk::keyPress):
       
 53615         (WebCore::FrameGdk::handleGdkEvent):
       
 53616         (WebCore::FrameGdk::focusWindow):
       
 53617         (WebCore::FrameGdk::unfocusWindow):
       
 53618         (WebCore::FrameGdk::getObjectInstanceForWidget):
       
 53619         (WebCore::FrameGdk::getEmbedInstanceForWidget):
       
 53620         (WebCore::FrameGdk::bindingRootObject):
       
 53621         (WebCore::FrameGdk::print):
       
 53622         (WebCore::FrameGdk::getAppletInstanceForWidget):
       
 53623         (WebCore::FrameGdk::issueCutCommand):
       
 53624         (WebCore::FrameGdk::issueCopyCommand):
       
 53625         (WebCore::FrameGdk::issuePasteCommand):
       
 53626         (WebCore::FrameGdk::issueTransposeCommand):
       
 53627         (WebCore::FrameGdk::issuePasteAndMatchStyleCommand):
       
 53628         (WebCore::FrameGdk::markedTextRange):
       
 53629         (WebCore::FrameGdk::shouldChangeSelection):
       
 53630         (WebCore::FrameGdk::respondToChangedSelection):
       
 53631         (WebCore::FrameGdk::mimeTypeForFileName):
       
 53632         * platform/gdk/FrameGdk.h: Ditto.
       
 53633         (WebCore::FrameGdk::setExitAfterLoading):
       
 53634         (WebCore::FrameGdk::exitAfterLoading):
       
 53635         (WebCore::FrameGdk::setDumpRenderTreeAfterLoading):
       
 53636         (WebCore::FrameGdk::dumpRenderTreeAfterLoading):
       
 53637         (WebCore::GdkFrame):
       
 53638         * platform/gdk/TemporaryLinkStubs.cpp: Adjust to new APIs. Small cleanups.
       
 53639         (FrameView::updateBorder):
       
 53640         (Widget::setEnabled):
       
 53641         (Widget::isEnabled):
       
 53642         (Widget::enableFlushDrawing):
       
 53643         (Widget::removeFromParent):
       
 53644         (Widget::paint):
       
 53645         (Widget::setIsSelected):
       
 53646         (Widget::invalidate):
       
 53647         (Widget::invalidateRect):
       
 53648         (PlatformMouseEvent::PlatformMouseEvent):
       
 53649         (WebCore::findWordBoundary):
       
 53650         (ChromeClientGdk::chromeDestroyed):
       
 53651         (ChromeClientGdk::closeWindowSoon):
       
 53652         (ChromeClientGdk::canTakeFocus):
       
 53653         (ChromeClientGdk::takeFocus):
       
 53654         (ChromeClientGdk::canRunBeforeUnloadConfirmPanel):
       
 53655         (ChromeClientGdk::addMessageToConsole):
       
 53656         (ChromeClientGdk::runBeforeUnloadConfirmPanel):
       
 53657         (ChromeClientGdk::runJavaScriptAlert):
       
 53658         (ChromeClientGdk::runJavaScriptConfirm):
       
 53659         (ChromeClientGdk::runJavaScriptPrompt):
       
 53660         (ChromeClientGdk::setStatusbarText):
       
 53661         (ChromeClientGdk::shouldInterruptJavaScript):
       
 53662         (WebCore::inputElementAltText):
       
 53663         (WebCore::resetButtonDefaultLabel):
       
 53664         (WebCore::searchableIndexIntroduction):
       
 53665         (WebCore::fileButtonChooseFileLabel):
       
 53666         (WebCore::fileButtonNoFileSelectedLabel):
       
 53667         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
       
 53668         (WebCore::contextMenuItemTagDownloadLinkToDisk):
       
 53669         (WebCore::contextMenuItemTagCopyLinkToClipboard):
       
 53670         (WebCore::contextMenuItemTagOpenImageInNewWindow):
       
 53671         (WebCore::contextMenuItemTagDownloadImageToDisk):
       
 53672         (WebCore::contextMenuItemTagCopyImageToClipboard):
       
 53673         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
       
 53674         (WebCore::contextMenuItemTagCopy):
       
 53675         (WebCore::contextMenuItemTagGoBack):
       
 53676         (WebCore::contextMenuItemTagGoForward):
       
 53677         (WebCore::contextMenuItemTagStop):
       
 53678         (WebCore::contextMenuItemTagReload):
       
 53679         (WebCore::contextMenuItemTagCut):
       
 53680         (WebCore::contextMenuItemTagPaste):
       
 53681         (WebCore::contextMenuItemTagNoGuessesFound):
       
 53682         (WebCore::contextMenuItemTagIgnoreSpelling):
       
 53683         (WebCore::contextMenuItemTagLearnSpelling):
       
 53684         (WebCore::contextMenuItemTagSearchWeb):
       
 53685         (WebCore::contextMenuItemTagLookUpInDictionary):
       
 53686         (WebCore::contextMenuItemTagOpenLink):
       
 53687         (WebCore::contextMenuItemTagIgnoreGrammar):
       
 53688         (WebCore::contextMenuItemTagSpellingMenu):
       
 53689         (WebCore::contextMenuItemTagShowSpellingPanel):
       
 53690         (WebCore::contextMenuItemTagCheckSpelling):
       
 53691         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
       
 53692         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
       
 53693         (WebCore::contextMenuItemTagFontMenu):
       
 53694         (WebCore::contextMenuItemTagBold):
       
 53695         (WebCore::contextMenuItemTagItalic):
       
 53696         (WebCore::contextMenuItemTagUnderline):
       
 53697         (WebCore::contextMenuItemTagOutline):
       
 53698         (WebCore::contextMenuItemTagWritingDirectionMenu):
       
 53699         (WebCore::contextMenuItemTagDefaultDirection):
       
 53700         (WebCore::contextMenuItemTagLeftToRight):
       
 53701         (WebCore::contextMenuItemTagRightToLeft):
       
 53702         (PlugInInfoStore::createPluginInfoForPluginAtIndex):
       
 53703         (PlugInInfoStore::pluginCount):
       
 53704         (WebCore::PlugInInfoStore::supportsMIMEType):
       
 53705         (WebCore::refreshPlugins):
       
 53706         (SearchPopupMenu::saveRecentSearches):
       
 53707         (SearchPopupMenu::loadRecentSearches):
       
 53708         (SearchPopupMenu::SearchPopupMenu):
       
 53709         (Path::apply):
       
 53710         (PlatformScrollbar::PlatformScrollbar):
       
 53711         (PlatformScrollbar::~PlatformScrollbar):
       
 53712         (PlatformScrollbar::width):
       
 53713         (PlatformScrollbar::height):
       
 53714         (PlatformScrollbar::setEnabled):
       
 53715         (PlatformScrollbar::paint):
       
 53716         (PlatformScrollbar::updateThumbPosition):
       
 53717         (PlatformScrollbar::updateThumbProportion):
       
 53718         (PlatformScrollbar::setRect):
       
 53719         (ResourceHandle::willLoadFromCache):
       
 53720         (ResourceHandle::loadsBlocked):
       
 53721         (ResourceHandle::loadResourceSynchronously):
       
 53722         (PageCache::close):
       
 53723         (Editor::ignoreSpelling):
       
 53724         (Editor::learnSpelling):
       
 53725         (Editor::isSelectionUngrammatical):
       
 53726         (Editor::isSelectionMisspelled):
       
 53727         (Editor::guessesForMisspelledSelection):
       
 53728         (Editor::guessesForUngrammaticalSelection):
       
 53729         (Editor::markMisspellingsAfterTypingToPosition):
       
 53730         (Editor::newGeneralClipboard):
       
 53731         (Pasteboard::generalPasteboard):
       
 53732         (Pasteboard::writeSelection):
       
 53733         (Pasteboard::writeURL):
       
 53734         (Pasteboard::clear):
       
 53735         (Pasteboard::canSmartReplace):
       
 53736         (Pasteboard::documentFragment):
       
 53737         (Pasteboard::plainText):
       
 53738         (Pasteboard::Pasteboard):
       
 53739         (Pasteboard::~Pasteboard):
       
 53740         (ContextMenu::ContextMenu):
       
 53741         (ContextMenu::~ContextMenu):
       
 53742         (ContextMenu::appendItem):
       
 53743         (ContextMenu::setPlatformDescription):
       
 53744         (ContextMenu::platformDescription):
       
 53745         (ContextMenuItem::ContextMenuItem):
       
 53746         (ContextMenuItem::~ContextMenuItem):
       
 53747         (ContextMenuItem::releasePlatformDescription):
       
 53748         (ContextMenuItem::type):
       
 53749         (ContextMenuItem::setType):
       
 53750         (ContextMenuItem::action):
       
 53751         (ContextMenuItem::setAction):
       
 53752         (ContextMenuItem::title):
       
 53753         (ContextMenuItem::setTitle):
       
 53754         (ContextMenuItem::platformSubMenu):
       
 53755         (ContextMenuItem::setSubMenu):
       
 53756         (ContextMenuItem::setChecked):
       
 53757         (ContextMenuItem::setEnabled):
       
 53758         (WebCore::systemBeep):
       
 53759         (WebCore::userIdleTime):
       
 53760 
       
 53761 2007-02-08  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 53762 
       
 53763         Reviewed by Adam Roben.
       
 53764 
       
 53765         Linux/gdk build fixes.
       
 53766 
       
 53767         * platform/GlyphPageTreeNode.h: Fix header guard name.
       
 53768         * platform/gdk/ChromeClientGdk.h:
       
 53769         * platform/gdk/CursorGdk.cpp:
       
 53770         (WebCore::verticalTextCursor):
       
 53771         (WebCore::cellCursor):
       
 53772         (WebCore::contextMenuCursor):
       
 53773         (WebCore::noDropCursor):
       
 53774         (WebCore::copyCursor):
       
 53775         (WebCore::progressCursor):
       
 53776         (WebCore::aliasCursor):
       
 53777         * platform/gdk/MouseEventGdk.cpp:
       
 53778         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
       
 53779         * platform/gdk/PageGdk.cpp: Removed. No longer used.
       
 53780         * platform/gdk/RenderThemeGdk.cpp:
       
 53781         (WebCore::RenderThemeGdk::getThemeData):
       
 53782         (WebCore::RenderThemeGdk::setCheckboxSize):
       
 53783         (WebCore::RenderThemeGdk::paintCheckbox):
       
 53784         (WebCore::RenderThemeGdk::setRadioSize):
       
 53785         (WebCore::RenderThemeGdk::paintRadio):
       
 53786         (WebCore::RenderThemeGdk::paintButton):
       
 53787         (WebCore::RenderThemeGdk::adjustTextFieldStyle):
       
 53788         (WebCore::RenderThemeGdk::paintTextField):
       
 53789         (WebCore::RenderThemeGdk::paintTextArea):
       
 53790         (WebCore::RenderThemeGdk::systemFont):
       
 53791         * platform/gdk/RenderThemeGdk.h:
       
 53792         * platform/gdk/ScreenGdk.cpp:
       
 53793         (WebCore::screenDepth):
       
 53794         (WebCore::screenDepthPerComponent):
       
 53795         (WebCore::screenIsMonochrome):
       
 53796         (WebCore::screenRect):
       
 53797         (WebCore::screenAvailableRect):
       
 53798 
       
 53799 2007-02-08  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 53800 
       
 53801         Reviewed by Adam Roben.
       
 53802 
       
 53803         Linux/gdk build fixes for cairo.
       
 53804 
       
 53805         * platform/graphics/GraphicsContext.cpp:
       
 53806         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
 53807         (WebCore::GraphicsContext::GraphicsContext):
       
 53808         (WebCore::GraphicsContext::strokeArc):
       
 53809         (WebCore::GraphicsContext::drawFocusRing):
       
 53810         (WebCore::GraphicsContext::setFocusRingClip):
       
 53811         (WebCore::GraphicsContext::clearFocusRingClip):
       
 53812         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
       
 53813         (WebCore::GraphicsContext::origin):
       
 53814         (WebCore::GraphicsContext::setPlatformFillColor):
       
 53815         (WebCore::GraphicsContext::setPlatformStrokeColor):
       
 53816         (WebCore::GraphicsContext::setPlatformStrokeThickness):
       
 53817         (WebCore::GraphicsContext::setPlatformStrokeStyle):
       
 53818         (WebCore::GraphicsContext::setPlatformFont):
       
 53819         (WebCore::GraphicsContext::setURLForRect):
       
 53820         (WebCore::GraphicsContext::addRoundedRectClip):
       
 53821         (WebCore::GraphicsContext::addInnerRoundedRectClip):
       
 53822         (WebCore::GraphicsContext::setShadow):
       
 53823         (WebCore::GraphicsContext::clearShadow):
       
 53824         (WebCore::GraphicsContext::beginTransparencyLayer):
       
 53825         (WebCore::GraphicsContext::endTransparencyLayer):
       
 53826         (WebCore::GraphicsContext::clearRect):
       
 53827         (WebCore::GraphicsContext::strokeRect):
       
 53828         (WebCore::GraphicsContext::setLineCap):
       
 53829         (WebCore::GraphicsContext::setLineJoin):
       
 53830         (WebCore::GraphicsContext::setMiterLimit):
       
 53831         (WebCore::GraphicsContext::setAlpha):
       
 53832         (WebCore::toCairoOperator):
       
 53833         (WebCore::GraphicsContext::setCompositeOperation):
       
 53834         (WebCore::GraphicsContext::clip):
       
 53835         (WebCore::GraphicsContext::rotate):
       
 53836         (WebCore::GraphicsContext::scale):
       
 53837         (WebCore::GraphicsContext::clipOut):
       
 53838         (WebCore::GraphicsContext::clipOutEllipseInRect):
       
 53839         (WebCore::GraphicsContext::fillRoundedRect):
       
 53840 
       
 53841 2007-02-08  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 53842 
       
 53843         Reviewed by Adam Roben.
       
 53844 
       
 53845         Linux/gdk build fixes.
       
 53846 
       
 53847         * Projects/gdk/webcore-gdk.bkl:
       
 53848         * WebCoreSources.bkl:
       
 53849         * webcore-base.bkl:
       
 53850 
       
 53851 2007-02-08  Brady Eidson  <beidson@apple.com>
       
 53852 
       
 53853         Reviewed by Tim Hatcher
       
 53854 
       
 53855         Tweaked the thread violation behavior to be disabled by default, and to provide
       
 53856         an easy breakpoint to set.  
       
 53857         The possibilities for the "WebCoreThreadCheck" user defaults key are -
       
 53858           - The value "None" disables thread checking
       
 53859           - The value "Log" causes an NSLog on a violation
       
 53860           - The value "Exception" causes exceptions to be raised on a violation
       
 53861 
       
 53862         * platform/Logging.h:
       
 53863         * platform/mac/LoggingMac.mm:
       
 53864         (WebCore::_WebCoreThreadViolationCheck):
       
 53865         (WebCoreReportThreadViolation):  In the global namespace, making breakpoints cake!
       
 53866 
       
 53867 2007-02-08  Brady Eidson  <beidson@apple.com>
       
 53868 
       
 53869         Reviewed by Tim Hatcher
       
 53870 
       
 53871         <rdar://problem/4983515> Need mechanism to protect against WebKit calls from secondary threads
       
 53872         This initial landing is a conservative move until we can be certain of performance impact.
       
 53873         By writing to the user defaults key @"WebCoreThreadCheck" for the WebKit app you're running -
       
 53874           - The value "None" disables thread checking
       
 53875           - The value "Exception" causes exceptions to be raised on a violation
       
 53876           - The default is to do the check, and NSLog each violation
       
 53877 
       
 53878         * bindings/objc/ExceptionHandlers.h:  Add a "Is Main Thread" assert macro
       
 53879         * bindings/scripts/CodeGeneratorObjC.pm: Use new mechanism in allocs and deallocs for now
       
 53880 
       
 53881         * platform/Logging.h: Added WebCoreThreadViolationCheck macro
       
 53882         * platform/mac/LoggingMac.mm:
       
 53883         (WebCore::_WebCoreThreadViolationCheck): Check for main-threadedness, and do some stuff
       
 53884 
       
 53885 2007-02-08  Kevin McCullough  <KMcCullough@apple.com>
       
 53886 
       
 53887         Reviewed by Maciej, Darin, and Mark.
       
 53888 
       
 53889         rdar://problem/4922454
       
 53890         - Prevents remote sites from executing local scripts.
       
 53891 
       
 53892         * bindings/objc/DOM.mm: - renamed a function that is now in the base class
       
 53893         (-[DOMElement image]):
       
 53894         (-[DOMElement _imageTIFFRepresentation]):
       
 53895         * dom/XMLTokenizer.cpp: - removed needless asserts
       
 53896         (WebCore::XMLTokenizer::notifyFinished):
       
 53897         * html/HTMLImageLoader.cpp: - renamed a function that is now in the base class
       
 53898         (WebCore::HTMLImageLoader::dispatchLoadEvent):
       
 53899         * html/HTMLTokenizer.cpp: - removed needless asserts
       
 53900         (WebCore::HTMLTokenizer::reset):
       
 53901         (WebCore::HTMLTokenizer::notifyFinished):
       
 53902         * ksvg2/misc/SVGImageLoader.cpp: - renamed a function that is now in the base class
       
 53903         (WebCore::SVGImageLoader::dispatchLoadEvent):
       
 53904         * loader/Cache.cpp: - return early if an error occured
       
 53905         (WebCore::Cache::requestResource):
       
 53906         (WebCore::Cache::remove):
       
 53907         * loader/CachedImage.h: - renamed a function that is now in the base class
       
 53908         (WebCore::CachedImage::canRender):
       
 53909         * loader/CachedResource.h: - renamed a function that is now in the base class
       
 53910         (WebCore::CachedResource::errorOccurred):
       
 53911         * loader/CachedScript.h: - renamed a function that is now in the base class 
       
 53912         (WebCore::CachedScript::schedule):
       
 53913         * loader/DocLoader.cpp: - The heart of the fix, prevents resources from being created or retrieved from the cache if a remote site is requesting the local resource.
       
 53914         (WebCore::DocLoader::requestResource):
       
 53915         (WebCore::DocLoader::setLoadInProgress):
       
 53916         * page/EventHandler.cpp: - renamed a function that is now in the base class
       
 53917         (WebCore::selectCursor):
       
 53918         * rendering/HitTestResult.cpp: - renamed a function that is now in the base class
       
 53919         (WebCore::HitTestResult::image):
       
 53920         * rendering/RenderImage.cpp: - renamed a function that is now in the base class
       
 53921         (WebCore::RenderImage::setCachedImage):
       
 53922         (WebCore::RenderImage::imageChanged):
       
 53923         (WebCore::RenderImage::paint):
       
 53924         (WebCore::RenderImage::layout):
       
 53925         (WebCore::RenderImage::calcAspectRatioWidth):
       
 53926         (WebCore::RenderImage::calcAspectRatioHeight):
       
 53927         * rendering/RenderImage.h: - renamed a function that is now in the base class
       
 53928         (WebCore::RenderImage::errorOccurred):
       
 53929         * rendering/RenderListItem.cpp: - renamed a function that is now in the base class
       
 53930         (WebCore::RenderListItem::setStyle):
       
 53931         * rendering/RenderListMarker.cpp: - renamed a function that is now in the base class
       
 53932         (WebCore::RenderListMarker::isImage):
       
 53933 
       
 53934 2007-02-07  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 53935 
       
 53936         Reviewed by Maciej.
       
 53937 
       
 53938         Add updateGeometry() to gdk's ScrollView. Needed to fix resizing of the window
       
 53939         in gdk.
       
 53940 
       
 53941         * platform/ScrollView.h:
       
 53942         * platform/gdk/ScrollViewGdk.cpp:
       
 53943         (WebCore::ScrollView::updateGeometry):
       
 53944         (WebCore::ScrollView::setDrawable):
       
 53945 
       
 53946 2007-02-07  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 53947 
       
 53948         Reviewed by Maciej.
       
 53949 
       
 53950         Linux/gdk build fixes.
       
 53951 
       
 53952         * platform/ContextMenuItem.h:
       
 53953         * platform/PlatformMenuDescription.h:
       
 53954         * platform/gdk/PopupMenuGdk.cpp: Added. Renamed from RenderPopupMenuGdk.cpp for
       
 53955         consistency with other platforms.
       
 53956         (WebCore::PopupMenu::PopupMenu):
       
 53957         (WebCore::PopupMenu::~PopupMenu):
       
 53958         * platform/gdk/RenderPopupMenuGdk.cpp: Removed.
       
 53959         * platform/gdk/RenderPopupMenuGdk.h: Removed.
       
 53960 
       
 53961 2007-02-07  Mitz Pettel  <mitz@webkit.org>
       
 53962 
       
 53963         Reviewed by Maciej.
       
 53964 
       
 53965         - fix http://bugs.webkit.org/show_bug.cgi?id=12608
       
 53966           Incorrect min. width calculation of a series of floats with clear:both and white-space:nowrap
       
 53967 
       
 53968         Test: fast/block/float/nowrap-clear-min-width.html
       
 53969 
       
 53970         * rendering/RenderBlock.cpp:
       
 53971         (WebCore::RenderBlock::calcInlineMinMaxWidth):
       
 53972 
       
 53973 2007-02-07  Mitz Pettel  <mitz@webkit.org>
       
 53974 
       
 53975         Reviewed by Dave Hyatt.
       
 53976 
       
 53977         - fix http://bugs.webkit.org/show_bug.cgi?id=10522
       
 53978           REGRESSION: Incomplete repaint after table relayout that decreases height
       
 53979 
       
 53980         Test: fast/repaint/intermediate-layout-position.html
       
 53981 
       
 53982         * rendering/RenderBlock.cpp:
       
 53983         (WebCore::RenderBlock::layoutBlock): Adjust the old bounds by the layout delta,
       
 53984         to get the block's absolute bounds as they were before its ancestors moved it
       
 53985         during layout.
       
 53986         (WebCore::RenderBlock::collapseMargins): Update the layout delta for the child
       
 53987         when moving it.
       
 53988         (WebCore::RenderBlock::clearFloatsIfNeeded): Ditto.
       
 53989         (WebCore::RenderBlock::determineHorizontalPosition): Ditto.
       
 53990         (WebCore::RenderBlock::layoutBlockChildren): Ditto.
       
 53991         * rendering/RenderFlexibleBox.cpp:
       
 53992         (WebCore::RenderFlexibleBox::layoutBlock): Adjust the old bounds by the current
       
 53993         layout delta.
       
 53994         * rendering/RenderHTMLCanvas.cpp:
       
 53995         (WebCore::RenderHTMLCanvas::layout): Ditto.
       
 53996         * rendering/RenderImage.cpp:
       
 53997         (WebCore::RenderImage::layout): Ditto.
       
 53998         * rendering/RenderTable.cpp:
       
 53999         (WebCore::RenderTable::layout): Ditto.
       
 54000         * rendering/RenderView.h:
       
 54001         (WebCore::RenderView::layoutDelta): Added. Keeps track of the offset between
       
 54002         the position of the object currently being laid out and its position at the
       
 54003         end of the last layout.
       
 54004         (WebCore::RenderView::addLayoutDelta): Added.
       
 54005 
       
 54006 2007-02-07  Christopher Brichford  <chrisb@adobe.com>
       
 54007 
       
 54008         Reviewed by Brady.
       
 54009 
       
 54010         http://bugs.webkit.org/show_bug.cgi?id=6286
       
 54011         Very large (~500MB) images cause reproducible Safari crash
       
 54012 
       
 54013         * loader/CachedImage.cpp: 
       
 54014         (WebCore::CachedImage::bufferData): Detect failure to create a
       
 54015         large Vector<> and call error() when that happens.
       
 54016 
       
 54017 2007-02-07  Mitz Pettel  <mitz@webkit.org>
       
 54018 
       
 54019         Reviewed by Dave Hyatt.
       
 54020 
       
 54021         - fix http://bugs.webkit.org/show_bug.cgi?id=5399
       
 54022           no-repeat on negatively positioned background images are ignored
       
 54023 
       
 54024         Test: fast/backgrounds/repeat/negative-offset-repeat.html
       
 54025 
       
 54026         - fix http://bugs.webkit.org/show_bug.cgi?id=5821
       
 54027           Changing background of <col> doesn't repaint the column
       
 54028 
       
 54029         Test: fast/repaint/table-col-background.html
       
 54030 
       
 54031         - fix http://bugs.webkit.org/show_bug.cgi?id=11720
       
 54032           REGRESSION: large amounts of CPU consumed viewing this site
       
 54033 
       
 54034         * rendering/RenderBox.cpp:
       
 54035         (WebCore::RenderBox::imageChanged): Added. Finds the border and/or background
       
 54036         layer(s) that use the image and invalidates only the rect in which the image
       
 54037         actually paints. There are two special cases in this function: 1) for the body
       
 54038         element, the background is propagated to the root; 2) inline flows do a full
       
 54039         repaint.
       
 54040         (WebCore::RenderBox::calculateBackgroundImageGeometry): Added. Factored out,
       
 54041         simplified and corrected the calculation of the rectangle into which the background
       
 54042         image paints, the tile size and the pattern phase.
       
 54043         (WebCore::RenderBox::paintBackgroundExtended):
       
 54044         * rendering/RenderBox.h:
       
 54045         * rendering/RenderObject.cpp:
       
 54046         * rendering/RenderObject.h:
       
 54047         (WebCore::RenderObject::imageChanged): Moved the implementation to RenderBox.
       
 54048         * rendering/RenderTableCol.cpp:
       
 54049         (WebCore::RenderTableCol::getAbsoluteRepaintRect): Overridden to return the
       
 54050         table's repaint rect.
       
 54051         (WebCore::RenderTableCol::imageChanged): Overridden to do a full repaint, which
       
 54052         currently repaints the entire table.
       
 54053         * rendering/RenderTableCol.h:
       
 54054         * rendering/RenderTableRow.cpp:
       
 54055         (WebCore::RenderTableRow::imageChanged): Overridden to do a full repaint
       
 54056         of the row, since the backgrounds are painted by the cells.
       
 54057         * rendering/RenderTableRow.h:
       
 54058         * rendering/RenderTableSection.cpp:
       
 54059         (WebCore::RenderTableSection::imageChanged): Overridden to do a full
       
 54060         repaint of the section, since the backgrounds are painted by the cells.
       
 54061         * rendering/RenderTableSection.h:
       
 54062 
       
 54063 2007-02-07  Anders Carlsson  <acarlsson@apple.com>
       
 54064 
       
 54065         Reviewed by Maciej.
       
 54066 
       
 54067         Move shouldInterruptJavaScript to the Chrome.
       
 54068 
       
 54069         * bindings/js/kjs_binding.cpp:
       
 54070         (KJS::ScriptInterpreter::shouldInterruptScript):
       
 54071         * page/Chrome.cpp:
       
 54072         (WebCore::Chrome::shouldInterruptJavaScript):
       
 54073         * page/Chrome.h:
       
 54074         * page/ChromeClient.h:
       
 54075         * page/Frame.h:
       
 54076         * page/mac/FrameMac.h:
       
 54077         * page/mac/FrameMac.mm:
       
 54078         * page/mac/WebCoreFrameBridge.h:
       
 54079         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 54080         (WebCore::SVGEmptyChromeClient::shouldInterruptJavaScript):
       
 54081 
       
 54082 2007-02-07  Darin Adler  <darin@apple.com>
       
 54083 
       
 54084         Reviewed by Maciej.
       
 54085 
       
 54086         - <rdar://problem/4826861> WebKit tests show memory leaks in NSHTMLReader, caused by method named "hash"
       
 54087 
       
 54088         * bindings/scripts/CodeGeneratorObjC.pm: Added a list of method names we should never use, since they
       
 54089         are in base classes WebScriptObject and NSObject. Luckily, only "hash" is causing trouble. Added
       
 54090         "hash" to the existing special case for "id". Now "hash" is "hashName" just as "id" is "idName".
       
 54091 
       
 54092 2007-02-07  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 54093 
       
 54094         Reviewed by Adam Roben.
       
 54095 
       
 54096         Linux/gdk build fixes for graphics-related stuff.
       
 54097 
       
 54098         * platform/graphics/cairo/ImageCairo.cpp:
       
 54099         (WebCore::BitmapImage::checkForSolidColor):
       
 54100         * platform/graphics/cairo/ImageSourceCairo.cpp:
       
 54101         (WebCore::ImageSource::setData):
       
 54102         * platform/graphics/gdk/ImageGdk.cpp:
       
 54103         (WebCore::BitmapImage::initPlatformData):
       
 54104         (WebCore::BitmapImage::invalidatePlatformData):
       
 54105         (WebCore::Image::loadPlatformResource):
       
 54106         (WebCore::Image::drawPattern):
       
 54107 
       
 54108 2007-02-07  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 54109 
       
 54110         Reviewed by Maciej.
       
 54111 
       
 54112         Linux/gdk build fixes related to networking.
       
 54113 
       
 54114         * platform/network/ResourceHandleInternal.h: Add accessor for m_client.
       
 54115         (WebCore::ResourceHandleInternal::client):
       
 54116         * platform/network/gdk/ResourceHandleCurl.cpp: Add missing functions and
       
 54117         massage for changed APIs.
       
 54118         (WebCore::ResourceHandle::start):
       
 54119         (WebCore::ResourceHandle::cancel):
       
 54120         (WebCore::ResourceHandle::bufferedData):
       
 54121         (WebCore::ResourceHandle::supportsBufferedData):
       
 54122         (WebCore::ResourceHandle::setDefersLoading):
       
 54123         * platform/network/gdk/ResourceHandleManager.cpp: Rename get() to
       
 54124         sharedInstance(). Massaged for changed APIs.
       
 54125         (WebCore::ResourceHandleManager::sharedInstance):
       
 54126         (WebCore::writeCallback):
       
 54127         (WebCore::ResourceHandleManager::downloadTimerCallback):
       
 54128         (WebCore::ResourceHandleManager::remove):
       
 54129         * platform/network/gdk/ResourceHandleManager.h: Ditto.
       
 54130 
       
 54131 2007-02-07  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 54132 
       
 54133         Reviewed by Maciej.
       
 54134 
       
 54135         Mismatched type of alloc/free function crashes gdk build.
       
 54136 
       
 54137         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
       
 54138         (WebCore::JPEGImageReader::close):
       
 54139 
       
 54140 2007-02-07  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 54141 
       
 54142         Reviewed by Adam Roben.
       
 54143 
       
 54144         Linux/gdk build fixes - add file based on qt implementation.
       
 54145 
       
 54146         * platform/DragData.h:
       
 54147         * platform/gdk/DragDataGdk.cpp: Added.
       
 54148 
       
 54149 2007-02-07  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 54150 
       
 54151         Reviewed by Adam Roben.
       
 54152 
       
 54153         Linux/gdk build fixes - add new files based on qt implementation.
       
 54154 
       
 54155         * page/gdk/DragControllerGdk.cpp: Added.
       
 54156         (WebCore::DragController::dragOperation):
       
 54157         * page/gdk/EventHandlerGdk.cpp: Added.
       
 54158         (WebCore::EventHandler::focusDocumentView):
       
 54159         (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
       
 54160         (WebCore::EventHandler::handleDrag):
       
 54161         (WebCore::EventHandler::eventActivatedView):
       
 54162 
       
 54163 2007-02-07  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 54164 
       
 54165         Reviewed by Adam Roben.
       
 54166 
       
 54167         Linux/gdk build fixes - add new files based on Qt implementation.
       
 54168 
       
 54169         * loader/gdk/DocumentLoaderGdk.cpp: Added.
       
 54170         (WebCore::DocumentLoader::getResponseModifiedHeader):
       
 54171         * loader/gdk/FrameLoaderClientGdk.cpp: Added.
       
 54172         (WebCore::FrameLoaderClientGdk::FrameLoaderClientGdk):
       
 54173         (WebCore::FrameLoaderClientGdk::frame):
       
 54174         (WebCore::FrameLoaderClientGdk::userAgent):
       
 54175         (WebCore::FrameLoaderClientGdk::createDocumentLoader):
       
 54176         (WebCore::FrameLoaderClientGdk::dispatchWillSubmitForm):
       
 54177         (WebCore::FrameLoaderClientGdk::committedLoad):
       
 54178         (WebCore::FrameLoaderClientGdk::dispatchDidReceiveAuthenticationChallenge):
       
 54179         (WebCore::FrameLoaderClientGdk::dispatchDidCancelAuthenticationChallenge):
       
 54180         (WebCore::FrameLoaderClientGdk::dispatchWillSendRequest):
       
 54181         (WebCore::FrameLoaderClientGdk::assignIdentifierToInitialRequest):
       
 54182         (WebCore::FrameLoaderClientGdk::postProgressStartedNotification):
       
 54183         (WebCore::FrameLoaderClientGdk::postProgressEstimateChangedNotification):
       
 54184         (WebCore::FrameLoaderClientGdk::postProgressFinishedNotification):
       
 54185         (WebCore::FrameLoaderClientGdk::frameLoaderDestroyed):
       
 54186         (WebCore::FrameLoaderClientGdk::dispatchDidReceiveResponse):
       
 54187         (WebCore::FrameLoaderClientGdk::dispatchDecidePolicyForMIMEType):
       
 54188         (WebCore::FrameLoaderClientGdk::dispatchDecidePolicyForNewWindowAction):
       
 54189         (WebCore::FrameLoaderClientGdk::dispatchDecidePolicyForNavigationAction):
       
 54190         (WebCore::FrameLoaderClientGdk::createPlugin):
       
 54191         (WebCore::FrameLoaderClientGdk::createFrame):
       
 54192         (WebCore::FrameLoaderClientGdk::redirectDataToPlugin):
       
 54193         (WebCore::FrameLoaderClientGdk::createJavaAppletWidget):
       
 54194         (WebCore::FrameLoaderClientGdk::objectContentType):
       
 54195         (WebCore::FrameLoaderClientGdk::overrideMediaType):
       
 54196         (WebCore::FrameLoaderClientGdk::windowObjectCleared):
       
 54197         (WebCore::FrameLoaderClientGdk::setMainFrameDocumentReady):
       
 54198         (WebCore::FrameLoaderClientGdk::hasWebView):
       
 54199         (WebCore::FrameLoaderClientGdk::hasFrameView):
       
 54200         (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoad):
       
 54201         (WebCore::FrameLoaderClientGdk::frameLoadCompleted):
       
 54202         (WebCore::FrameLoaderClientGdk::privateBrowsingEnabled):
       
 54203         (WebCore::FrameLoaderClientGdk::makeDocumentView):
       
 54204         (WebCore::FrameLoaderClientGdk::makeRepresentation):
       
 54205         (WebCore::FrameLoaderClientGdk::forceLayout):
       
 54206         (WebCore::FrameLoaderClientGdk::forceLayoutForNonHTML):
       
 54207         (WebCore::FrameLoaderClientGdk::setCopiesOnScroll):
       
 54208         (WebCore::FrameLoaderClientGdk::detachedFromParent1):
       
 54209         (WebCore::FrameLoaderClientGdk::detachedFromParent2):
       
 54210         (WebCore::FrameLoaderClientGdk::detachedFromParent3):
       
 54211         (WebCore::FrameLoaderClientGdk::detachedFromParent4):
       
 54212         (WebCore::FrameLoaderClientGdk::loadedFromPageCache):
       
 54213         (WebCore::FrameLoaderClientGdk::dispatchDidHandleOnloadEvents):
       
 54214         (WebCore::FrameLoaderClientGdk::dispatchDidReceiveServerRedirectForProvisionalLoad):
       
 54215         (WebCore::FrameLoaderClientGdk::dispatchDidCancelClientRedirect):
       
 54216         (WebCore::FrameLoaderClientGdk::dispatchWillPerformClientRedirect):
       
 54217         (WebCore::FrameLoaderClientGdk::dispatchDidChangeLocationWithinPage):
       
 54218         (WebCore::FrameLoaderClientGdk::dispatchWillClose):
       
 54219         (WebCore::FrameLoaderClientGdk::dispatchDidReceiveIcon):
       
 54220         (WebCore::FrameLoaderClientGdk::dispatchDidStartProvisionalLoad):
       
 54221         (WebCore::FrameLoaderClientGdk::dispatchDidReceiveTitle):
       
 54222         (WebCore::FrameLoaderClientGdk::dispatchDidCommitLoad):
       
 54223         (WebCore::FrameLoaderClientGdk::dispatchDidFinishDocumentLoad):
       
 54224         (WebCore::FrameLoaderClientGdk::dispatchDidFirstLayout):
       
 54225         (WebCore::FrameLoaderClientGdk::dispatchShow):
       
 54226         (WebCore::FrameLoaderClientGdk::cancelPolicyCheck):
       
 54227         (WebCore::FrameLoaderClientGdk::dispatchDidLoadMainResource):
       
 54228         (WebCore::FrameLoaderClientGdk::revertToProvisionalState):
       
 54229         (WebCore::FrameLoaderClientGdk::clearUnarchivingState):
       
 54230         (WebCore::FrameLoaderClientGdk::willChangeTitle):
       
 54231         (WebCore::FrameLoaderClientGdk::didChangeTitle):
       
 54232         (WebCore::FrameLoaderClientGdk::finishedLoading):
       
 54233         (WebCore::FrameLoaderClientGdk::finalSetupForReplace):
       
 54234         (WebCore::FrameLoaderClientGdk::setDefersLoading):
       
 54235         (WebCore::FrameLoaderClientGdk::isArchiveLoadPending):
       
 54236         (WebCore::FrameLoaderClientGdk::cancelPendingArchiveLoad):
       
 54237         (WebCore::FrameLoaderClientGdk::clearArchivedResources):
       
 54238         (WebCore::FrameLoaderClientGdk::canHandleRequest):
       
 54239         (WebCore::FrameLoaderClientGdk::canShowMIMEType):
       
 54240         (WebCore::FrameLoaderClientGdk::representationExistsForURLScheme):
       
 54241         (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme):
       
 54242         (WebCore::FrameLoaderClientGdk::restoreScrollPositionAndViewState):
       
 54243         (WebCore::FrameLoaderClientGdk::provisionalLoadStarted):
       
 54244         (WebCore::FrameLoaderClientGdk::didFinishLoad):
       
 54245         (WebCore::FrameLoaderClientGdk::prepareForDataSourceReplacement):
       
 54246         (WebCore::FrameLoaderClientGdk::setTitle):
       
 54247         (WebCore::FrameLoaderClientGdk::setDocumentViewFromPageCache):
       
 54248         (WebCore::FrameLoaderClientGdk::dispatchDidReceiveContentLength):
       
 54249         (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading):
       
 54250         (WebCore::FrameLoaderClientGdk::dispatchDidFailLoading):
       
 54251         (WebCore::FrameLoaderClientGdk::dispatchDidLoadResourceFromMemoryCache):
       
 54252         (WebCore::FrameLoaderClientGdk::dispatchDidFailProvisionalLoad):
       
 54253         (WebCore::FrameLoaderClientGdk::dispatchDidFailLoad):
       
 54254         (WebCore::FrameLoaderClientGdk::download):
       
 54255         (WebCore::FrameLoaderClientGdk::cancelledError):
       
 54256         (WebCore::FrameLoaderClientGdk::cannotShowURLError):
       
 54257         (WebCore::FrameLoaderClientGdk::interruptForPolicyChangeError):
       
 54258         (WebCore::FrameLoaderClientGdk::cannotShowMIMETypeError):
       
 54259         (WebCore::FrameLoaderClientGdk::fileDoesNotExistError):
       
 54260         (WebCore::FrameLoaderClientGdk::shouldFallBack):
       
 54261         (WebCore::FrameLoaderClientGdk::willUseArchive):
       
 54262         (WebCore::FrameLoaderClientGdk::saveScrollPositionAndViewStateToItem):
       
 54263         (WebCore::FrameLoaderClientGdk::saveDocumentViewToPageCache):
       
 54264         (WebCore::FrameLoaderClientGdk::canCachePage):
       
 54265         (WebCore::FrameLoaderClientGdk::dispatchCreatePage):
       
 54266         (WebCore::FrameLoaderClientGdk::dispatchUnableToImplementPolicy):
       
 54267         (WebCore::FrameLoaderClientGdk::setMainDocumentError):
       
 54268         (WebCore::FrameLoaderClientGdk::startDownload):
       
 54269         (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForStandardLoad):
       
 54270         (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForReload):
       
 54271         (WebCore::FrameLoaderClientGdk::shouldGoToHistoryItem):
       
 54272         * loader/gdk/FrameLoaderClientGdk.h: Added.
       
 54273         (WebCore::FrameLoaderClientGdk::~FrameLoaderClientGdk):
       
 54274         (WebCore::FrameLoaderClientGdk::setFrame):
       
 54275 
       
 54276 2007-02-07  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
       
 54277 
       
 54278         Reviewed by Maciej.
       
 54279 
       
 54280         Linux/gdk fixes related to fonts.
       
 54281 
       
 54282         * platform/gdk/FontDataGdk.cpp:
       
 54283         (WebCore::FontData::platformInit): remove a work-around for older cairo versions
       
 54284         since Ubuntu 6.10 ships with cairo that is new enough
       
 54285         * platform/gdk/FontGdk.cpp:
       
 54286         (WebCore::Font::drawGlyphs):
       
 54287         * platform/gdk/FontPlatformDataGdk.cpp: Remove unused variables.
       
 54288         (WebCore::FontPlatformData::FontPlatformData):
       
 54289 
       
 54290 2007-02-07  Alexey Proskuryakov  <ap@webkit.org>
       
 54291 
       
 54292         Reviewed by Darin.
       
 54293 
       
 54294         http://bugs.webkit.org/show_bug.cgi?id=12582
       
 54295         REGRESSION: Unclosed <title> makes the window display garbage or empty title
       
 54296 
       
 54297         Automatic testing is not possible, and manual testing probably doesn't make sense.
       
 54298 
       
 54299         * loader/DocumentLoader.cpp:
       
 54300         (WebCore::canonicalizedTitle): Bail out early if the passed in string is all whitespace.
       
 54301 
       
 54302 2007-02-06  Anders Carlsson  <acarlsson@apple.com>
       
 54303 
       
 54304         Reviewed by John Sullivan.
       
 54305 
       
 54306         <rdar://problem/4977952>
       
 54307         REGRESSION: Yahoo Messenger IM is totally blank
       
 54308         
       
 54309         * loader/FrameLoader.cpp:
       
 54310         (WebCore::FrameLoader::checkContentPolicy):
       
 54311         Don't ask the policy delegate for content that has valid substitute data.
       
 54312         
       
 54313         (WebCore::FrameLoader::checkNavigationPolicy):
       
 54314         If the loader has substitute data but doesn't have an unreachable URL, let the policy
       
 54315         delegate decide what to do.
       
 54316 
       
 54317 2007-02-07  Geoffrey Garen  <ggaren@apple.com>
       
 54318 
       
 54319         Reviewed by Darin Adler.
       
 54320 
       
 54321         Restoring some of the functionality I removed in r19445. It's insufficient for
       
 54322         each page to cancel keepAlive only for its child frames, because a frame
       
 54323         can be removed from the page before we get a chance to cancel its keepAlive.
       
 54324         So, the page destructor has to cancel keepAlive for all frames. This is safe
       
 54325         because we prohibit closing a WebView while JavaScript is executing.
       
 54326 
       
 54327         * page/Frame.cpp:
       
 54328         (WebCore::keepAliveSet):
       
 54329         (WebCore::Frame::keepAlive):
       
 54330         (WebCore::Frame::cancelAllKeepAlive):
       
 54331         (WebCore::Frame::lifeSupportTimerFired):
       
 54332         * page/Frame.h:
       
 54333         * page/Page.cpp:
       
 54334         (WebCore::Page::~Page):
       
 54335 
       
 54336 2007-02-07  Alexey Proskuryakov  <ap@webkit.org>
       
 54337 
       
 54338         Reviewed by Darin.
       
 54339 
       
 54340         http://bugs.webkit.org/show_bug.cgi?id=12603
       
 54341         A crash when trying to use XPath functions normalize-space(), string-length() and number()
       
 54342 
       
 54343         Test: fast/xpath/implicit-node-args.html
       
 54344 
       
 54345         * xml/XPathFunctions.cpp:
       
 54346         (WebCore::XPath::FunNumber::doEvaluate): Implemented zero parameter case.
       
 54347         (WebCore::XPath::FunctionMapping::): Corrected descriptions of these functions, as they
       
 54348         do allow zero parameters.
       
 54349         (WebCore::XPath::createFunction): Combined the two failure cases to ensure that this
       
 54350         function never returns 0.
       
 54351 
       
 54352 2007-02-07  Zack Rusin  <zrusin@trolltech.com>
       
 54353 
       
 54354         Fix compilation
       
 54355 
       
 54356         * page/qt/EventHandlerQt.cpp:
       
 54357         (WebCore::EventHandler::eventActivatedView):
       
 54358 
       
 54359 2007-02-06  Alice Liu  <alice.liu@apple.com>
       
 54360 
       
 54361         Reviewed by Maciej.
       
 54362 
       
 54363         Added editing command functions for scrolling by page and moving the caret
       
 54364 
       
 54365         * editing/Editor.cpp:
       
 54366         (WebCore::execMoveUpByPageAndModifyCaret):
       
 54367         (WebCore::execMoveDownByPageAndModifyCaret):
       
 54368         (WebCore::CommandEntry::):
       
 54369 
       
 54370 2007-02-06  Justin Garcia  <justin.garcia@apple.com>
       
 54371 
       
 54372         Reviewed by john
       
 54373 
       
 54374         <rdar://problem/4922367>
       
 54375         WebView selectLine: followed by deleteBackward: deletes TABLE element of following line
       
 54376 
       
 54377         * editing/AppendNodeCommand.cpp:
       
 54378         (WebCore::AppendNodeCommand::doApply): Don't ASSERT when manipulating
       
 54379         non-editable content that is embedded in editable content.  We'll do 
       
 54380         this kind of manipulation when removing redundant style spans after
       
 54381         pasting content that has non-editable pieces.
       
 54382         * editing/InsertNodeBeforeCommand.cpp:
       
 54383         (WebCore::InsertNodeBeforeCommand::doApply): Ditto.
       
 54384         * editing/htmlediting.cpp:
       
 54385         (WebCore::isContentEditable): Added, wrapper for Node::isContentEditable
       
 54386         (WebCore::rangeCompliantEquivalent): Although legal, 
       
 54387         [{table, select, etc.}, {0, numChildren}] don't refer to children of the element, 
       
 54388         but positions before and after the element.  So, rangeCompliantEquivalent is 
       
 54389         really responsible for converting illegal positions *and* legal positions 
       
 54390         that have a special meaning internally.
       
 54391         * editing/htmlediting.h:
       
 54392 
       
 54393 2007-02-06  Anders Carlsson  <acarlsson@apple.com>
       
 54394 
       
 54395         Reviewed by Brady.
       
 54396 
       
 54397         * platform/String.cpp:
       
 54398         (WebCore::String::ascii):
       
 54399         Fix dumping null Strings.
       
 54400 
       
 54401 2007-02-06  Anders Carlsson  <acarlsson@apple.com>
       
 54402 
       
 54403         Reviewed by Geoff.
       
 54404 
       
 54405         Fix <rdar://problem/4979484>
       
 54406         
       
 54407         * css/CSSPrimitiveValue.cpp:
       
 54408         (WebCore::isCSSTokenizerIdentifier):
       
 54409         Do the range check before calling isalpha or isalnum.
       
 54410 
       
 54411 2007-02-06  Geoffrey Garen  <ggaren@apple.com>
       
 54412 
       
 54413         Reviewed by Darin Adler.
       
 54414 
       
 54415         Fixed Frame/RenderObject/Node leak report seen while running SVG image tests.
       
 54416         (We'll need this fix if we ever re-enable SVG image.)
       
 54417         
       
 54418         The extra reference belonged to the Frame keepAlive timer (so this was
       
 54419         not a "real" leak, in the end). The Page destructor has code to cancel all 
       
 54420         Frame keepAlive timers upon the destruction of the last Page, but an SVG 
       
 54421         image puts a Page within a Page, making this condition impossible to meet.
       
 54422         
       
 54423         The fix here is to have each individual page cancel the keepAlive timers 
       
 54424         belonging to its child frames.
       
 54425         
       
 54426         * page/Frame.cpp: Changed the FrameCounter to use WTF logging.
       
 54427         (WebCore::): Nixed the lifeSupportSet, since it's no longer used.
       
 54428         (WebCore::Frame::cancelKeepAlive): Renamed from "endLifeSupport" to match
       
 54429         the name "keepAlive".
       
 54430         * page/Page.cpp:
       
 54431         (WebCore::Page::~Page): Made each page cancel its child keepAlive timers 
       
 54432         and clear its mainFrame, since we may never reach the condition of having 0 Pages.
       
 54433 
       
 54434 2007-02-06  Adam Roben  <aroben@apple.com>
       
 54435 
       
 54436         Rubberstamped by Brady.
       
 54437 
       
 54438         Revert the log channel constants to their old values for all you pretty
       
 54439         people out there who were using the old ones. I also renamed
       
 54440         LogResources to LogPlatformLeaks to be a bit more specific.
       
 54441 
       
 54442         * platform/Logging.cpp:
       
 54443         (WebCore::):
       
 54444         * platform/Logging.h:
       
 54445 
       
 54446 2007-02-05  Justin Garcia  <justin.garcia@apple.com>
       
 54447 
       
 54448         Reviewed by john
       
 54449 
       
 54450         <rdar://problem/4959067>
       
 54451         Bullets get erased or moved down to another line
       
 54452         <rdar://problem/4912529>
       
 54453         Seed: Bulleted list in Note in Mail.app does not work with Japanese input mode
       
 54454         
       
 54455         Do not expand the selection to include fully selected 
       
 54456         special elements when insering text over a selection.
       
 54457 
       
 54458         * editing/CompositeEditCommand.cpp:
       
 54459         (WebCore::CompositeEditCommand::deleteSelection): Pass
       
 54460         expandForSpecialElements through to DeleteSelectionCommand's constructor.
       
 54461         (WebCore::CompositeEditCommand::moveParagraphs): Use the 
       
 54462         convenience function.
       
 54463         * editing/CompositeEditCommand.h:
       
 54464         * editing/DeleteSelectionCommand.h:
       
 54465         * editing/InsertTextCommand.cpp:
       
 54466         (WebCore::InsertTextCommand::input): Do not expand the selection
       
 54467         to be deleted for special elements.
       
 54468         * editing/ReplaceSelectionCommand.cpp:
       
 54469         (WebCore::ReplaceSelectionCommand::doApply): Added a FIXME about 
       
 54470         when we should expand the selection.
       
 54471 
       
 54472 2007-02-06  Geoffrey Garen  <ggaren@apple.com>
       
 54473 
       
 54474         Reviewed by Anders Carlsson.
       
 54475         
       
 54476         Disabled support for SVG image because it crashes all the time.
       
 54477 
       
 54478         * loader/CachedImage.cpp:
       
 54479         (WebCore::CachedImage::createImage):
       
 54480 
       
 54481 2007-02-06  Mitz Pettel  <mitz@webkit.org>
       
 54482 
       
 54483         Reviewed by Darin.
       
 54484 
       
 54485         - fix http://bugs.webkit.org/show_bug.cgi?id=12518
       
 54486           Betsson.com crashes browser
       
 54487 
       
 54488         Test: fast/layers/generated-layer-scrollbar-crash.html
       
 54489 
       
 54490         * rendering/RenderLayer.cpp:
       
 54491         (WebCore::RenderLayer::createScrollbar): Changed element()->document() to
       
 54492         document() to work with anonymous objects.
       
 54493         (WebCore::RenderLayer::updateOverflowStatus): Ditto.
       
 54494 
       
 54495 2007-02-06  Eric Seidel  <eric@webkit.org>
       
 54496 
       
 54497         Reviewed by mitz.
       
 54498 
       
 54499         WebKit ignores floating point values for stroke-miterlimit
       
 54500         http://bugs.webkit.org/show_bug.cgi?id=12577
       
 54501         
       
 54502         Test: svg/W3C-SVG-1.1/painting-stroke-07-t.svg
       
 54503 
       
 54504         * ksvg2/css/SVGCSSParser.cpp:
       
 54505         (WebCore::CSSParser::parseSVGValue):
       
 54506         * ksvg2/css/SVGCSSStyleSelector.cpp:
       
 54507         (WebCore::CSSStyleSelector::applySVGProperty):
       
 54508         * ksvg2/css/SVGRenderStyle.h:
       
 54509         * ksvg2/css/SVGRenderStyleDefs.h:
       
 54510         (WebCore::StyleStrokeData::operator!=):
       
 54511 
       
 54512 2007-02-06  Adam Roben  <aroben@apple.com>
       
 54513 
       
 54514         Reviewed by Ada and Oliver.
       
 54515 
       
 54516         Adding a new LogResources channel for tracking platform resource usage.
       
 54517 
       
 54518         * platform/Logging.cpp: Added new channel, cleaned up constants to be more readable.
       
 54519         * platform/Logging.h: Declare new channel.
       
 54520 
       
 54521 2007-02-06  Alexey Proskuryakov  <ap@webkit.org>
       
 54522 
       
 54523         Reviewed by Geoff.
       
 54524 
       
 54525         http://bugs.webkit.org/show_bug.cgi?id=12619
       
 54526         Non-abbreviated XPaths don't work
       
 54527 
       
 54528         Test: fast/xpath/ancestor-axis.html
       
 54529 
       
 54530         * xml/XPathParser.cpp:
       
 54531         (WebCore::XPath::Parser::lex): Fix axis name parsing to actually work.
       
 54532         * xml/XPathStep.cpp:
       
 54533         (WebCore::XPath::Step::nodeTestMatches): Fix "*" node test to actually work.
       
 54534 
       
 54535 2007-02-06  Mark Rowe  <mrowe@apple.com>
       
 54536 
       
 54537         Roll out incomplete support for font-stretch (r19350) at Dave Hyatt's request.
       
 54538         See http://bugs.webkit.org/show_bug.cgi?id=12530#c9 for more info.
       
 54539 
       
 54540         * css/CSSComputedStyleDeclaration.cpp:
       
 54541         (WebCore::):
       
 54542         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 54543         * css/cssparser.cpp:
       
 54544         (WebCore::CSSParser::parseValue):
       
 54545         * css/cssstyleselector.cpp:
       
 54546         (WebCore::CSSStyleSelector::applyDeclarations):
       
 54547         (WebCore::CSSStyleSelector::applyProperty):
       
 54548         * platform/FontCache.cpp:
       
 54549         (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
       
 54550         (WebCore::FontPlatformDataCacheKey::operator==):
       
 54551         (WebCore::computeHash):
       
 54552         (WebCore::FontPlatformDataCacheKeyTraits::deletedValue):
       
 54553         (WebCore::FontPlatformDataCacheKeyTraits::emptyValue):
       
 54554         (WebCore::FontCache::getCachedFontPlatformData):
       
 54555         * platform/FontDescription.h:
       
 54556         (WebCore::FontDescription::FontDescription):
       
 54557         (WebCore::FontDescription::weight):
       
 54558         (WebCore::FontDescription::setWeight):
       
 54559         (WebCore::FontDescription::operator==):
       
 54560         * platform/mac/FontCacheMac.mm:
       
 54561         (WebCore::FontCache::createFontPlatformData):
       
 54562         * platform/mac/WebFontCache.mm:
       
 54563         (acceptableChoice):
       
 54564         (betterChoice):
       
 54565         (+[WebFontCache fontWithFamily:traits:size:]):
       
 54566 
       
 54567 2007-02-05  Adele Peterson  <adele@apple.com>
       
 54568 
       
 54569         Reviewed by Darin.
       
 54570 
       
 54571         A few small updates to my bidi patch.
       
 54572 
       
 54573         * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Moved the declaration of the CharacterBuffer outside the if statement since we use its data outside that scope.
       
 54574         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): ditto.
       
 54575         * rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderCharacters): Used a PassRefPtr for the BidiContext.
       
 54576 
       
 54577 2007-02-05  Adele Peterson  <adele@apple.com>
       
 54578 
       
 54579         Reviewed by Adam.
       
 54580 
       
 54581         Fix for assertion failure in fast/events/objc-keyboard-event-creation.html
       
 54582 
       
 54583         * html/HTMLInputElement.cpp:
       
 54584         (WebCore::HTMLInputElement::selectionStart): Check that the selection offsets are not equal to -1 (which is means the selection has never been set) instead of checking for >= 0.
       
 54585         (WebCore::HTMLInputElement::selectionEnd): ditto.
       
 54586         (WebCore::HTMLInputElement::setValue): ditto.
       
 54587         (WebCore::HTMLInputElement::selection): Return an empty selection if the input is not a text field or if no selection has ever been set in the text field.
       
 54588         * html/HTMLTextAreaElement.cpp:
       
 54589         (WebCore::HTMLTextAreaElement::selectionStart): Check that the selection offsets are not equal to -1.
       
 54590         (WebCore::HTMLTextAreaElement::selectionEnd): ditto.
       
 54591         (WebCore::HTMLTextAreaElement::setValue): ditto.
       
 54592         (WebCore::HTMLTextAreaElement::selection): Return an empty selection if no selection has ever been set in the textarea.
       
 54593 
       
 54594         * dom/Position.cpp: Added FIXMEs that we should catch the negative offset earlier.
       
 54595         (WebCore::Position::previous):
       
 54596         (WebCore::Position::next):
       
 54597 
       
 54598 2007-02-05  Justin Garcia  <justin.garcia@apple.com>
       
 54599 
       
 54600         Reviewed by harrison
       
 54601 
       
 54602         <rdar://problem/4947387>
       
 54603         REGRESSION Shift Command Left should only select to the beginning of the line
       
 54604 
       
 54605         * editing/Editor.cpp:
       
 54606         (WebCore::CommandEntry::): Never copy/paste code.
       
 54607 
       
 54608 2007-02-05  Darin Adler  <darin@apple.com>
       
 54609 
       
 54610         Reviewed by John Sullivan.
       
 54611 
       
 54612         - fix http://bugs.webkit.org/show_bug.cgi?id=11535
       
 54613           <rdar://problem/4946959> REGRESSION: onclick="this.select();" not working on new forms (11535)
       
 54614 
       
 54615         Test: fast/forms/input-select-on-click.html
       
 54616 
       
 54617         * page/EventHandler.h: Added m_mouseDownWasSingleClickInSelection boolean.
       
 54618         Organized other booleans a bit more logically.
       
 54619         * page/EventHandler.cpp:
       
 54620         (WebCore::EventHandler::EventHandler): Rearrange order to match EventHandler.h, add
       
 54621         m_mouseDownWasSingleClickInSelection initialization.
       
 54622         (WebCore::EventHandler::handleMousePressEventSingleClick): Set m_mouseDownWasSingleClickInSelection
       
 54623         to true in the appropriate special case.
       
 54624         (WebCore::EventHandler::handleMousePressEvent): Set m_mouseDownWasSingleClickInSelection to false.
       
 54625         (WebCore::EventHandler::handleMouseReleaseEvent): Change code to clear selection or set to caret to
       
 54626         only fire if m_mouseDownWasSingleClickInSelection was true rather than firing for any
       
 54627         m_mouseDownMayStartSelect case.
       
 54628 
       
 54629 2007-02-05  George Staikos  <staikos@kde.org>
       
 54630 
       
 54631         Reviewed by Maciej.
       
 54632 
       
 54633         Send HTTP cookies.
       
 54634 
       
 54635         * platform/network/qt/ResourceHandleManagerQt.cpp:
       
 54636         (WebCore::RequestQt::RequestQt):
       
 54637 
       
 54638 2007-02-05  Adele Peterson  <adele@apple.com>
       
 54639 
       
 54640         Reviewed by Mitz and Anders.
       
 54641 
       
 54642         Fix for http://bugs.webkit.org/show_bug.cgi?id=11811
       
 54643         <rdar://problem/4947184> REGRESSION (r11783): Hebrew text in list boxes is reversed
       
 54644 
       
 54645         http://bugs.webkit.org/show_bug.cgi?id=11812
       
 54646         <rdar://problem/4960269> REGRESSION (Native file upload): Hebrew filenames are reversed
       
 54647 
       
 54648         Tests: 
       
 54649         fast/text/international/bidi-listbox.html
       
 54650         fast/text/international/bidi-listbox-atsui.html
       
 54651 
       
 54652         * rendering/RenderBlock.h: Added static bidiReorderCharacters that will run the bidi algorithm on a character buffer.
       
 54653         * rendering/bidi.cpp:
       
 54654         (WebCore::RenderBlock::bidiReorderCharacters): Added. Creates an anonymous RenderBlock and RenderText to feed into bidiReorderLines.
       
 54655         (WebCore::RenderBlock::constructLine): Uses the new convenience methods on BidiRun.
       
 54656         * rendering/bidi.h:
       
 54657         (WebCore::BidiRun::reversed): Added convenience method.
       
 54658         (WebCore::BidiRun::dirOverride): ditto.
       
 54659 
       
 54660         * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Creates a buffer and calls bidiReorderCharacters
       
 54661           to get a correctly ordered character buffer for drawText.
       
 54662         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): ditto.
       
 54663 
       
 54664 2007-02-05  Mitz Pettel  <mitz@webkit.org>
       
 54665 
       
 54666         Reviewed by Darin.
       
 54667 
       
 54668         - fix http://bugs.webkit.org/show_bug.cgi?id=12590
       
 54669           REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
       
 54670 
       
 54671         Test: fast/repaint/selection-gap-overflow-scroll.html
       
 54672 
       
 54673         * rendering/RenderBlock.cpp:
       
 54674         (WebCore::RenderBlock::selectionGapRects): Adjust for overflow scroll.
       
 54675 
       
 54676 2007-02-05  Mitz Pettel  <mitz@webkit.org>
       
 54677 
       
 54678         Reviewed by Adele.
       
 54679 
       
 54680         - fix http://bugs.webkit.org/show_bug.cgi?id=11916
       
 54681           REGRESSION (SearchField): RTL search fields are mixed up
       
 54682 
       
 54683         Test: fast/forms/search-rtl.html
       
 54684 
       
 54685         * rendering/RenderTextControl.cpp:
       
 54686         (WebCore::RenderTextControl::createInnerBlockStyle): Always make the inner
       
 54687         block LTR so that the results button will be on the left and the cancel
       
 54688         button will be on the right.
       
 54689         (WebCore::RenderTextControl::createInnerTextStyle): Inherit the direction
       
 54690         property directly from the control so that it won't be masked by the inner
       
 54691         block's LTR override.
       
 54692         (WebCore::RenderTextControl::nodeAtPoint): Removed code that swapped the
       
 54693         results and cancel buttons for RTL.
       
 54694         (WebCore::RenderTextControl::forwardEvent): Ditto.
       
 54695         (WebCore::RenderTextControl::clientPaddingLeft): Ditto.
       
 54696         (WebCore::RenderTextControl::clientPaddingRight): Ditto.
       
 54697 
       
 54698 2007-02-05  Mitz Pettel  <mitz@webkit.org>
       
 54699 
       
 54700         Reviewed by Adele.
       
 54701 
       
 54702         - fix http://bugs.webkit.org/show_bug.cgi?id=12618
       
 54703           REGRESSION (SearchField): Dragging across the text and releasing over the clear button clears the field
       
 54704 
       
 54705         Test: fast/forms/search-cancel-button-mouseup.html
       
 54706 
       
 54707         Made the cancel button capturing.
       
 54708 
       
 54709         * html/HTMLTextFieldInnerElement.cpp:
       
 54710         (WebCore::HTMLSearchFieldCancelButtonElement::HTMLSearchFieldCancelButtonElement):
       
 54711         (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
       
 54712         * html/HTMLTextFieldInnerElement.h:
       
 54713 
       
 54714 2007-02-05  Mitz Pettel  <mitz@webkit.org>
       
 54715 
       
 54716         Reviewed by Darin.
       
 54717 
       
 54718         - fix http://bugs.webkit.org/show_bug.cgi?id=6626
       
 54719           Arabic & Farsi rendered with no shaping (all glyphs separate, unreadable!)
       
 54720 
       
 54721         No test possible since Mac OS X only ships with fonts that contain shaping
       
 54722         information.
       
 54723 
       
 54724         * icu/unicode/ushape.h: Added from
       
 54725         http://www.opensource.apple.com/darwinsource/10.4.8.ppc/ICU-6.2.9/icuSources/common/unicode/
       
 54726         * platform/FontData.h:
       
 54727         (WebCore::FontData::shapesArabic): Added. Returns whether the font contains
       
 54728         shaping information for Arabic or not.
       
 54729         * platform/mac/FontDataMac.mm:
       
 54730         (WebCore::FontData::platformInit):
       
 54731         (WebCore::FontData::checkShapesArabic): Added. Checks whether the font contains
       
 54732         a glyph metamorphosis table. The heuristic is that if a font contains Arabic glyphs
       
 54733         and a metamorphosis table, then it includes shaping information for Arabic.
       
 54734         * platform/mac/FontMac.mm:
       
 54735         (WebCore::overrideLayoutOperation): Changed to use the same character buffer passed
       
 54736         to ATSUI instead of the original character buffer and to give zero-width spaces zero
       
 54737         width.
       
 54738         (WebCore::isArabicLamWithAlefLigature): Added. Checks if the character is one
       
 54739         of the Arabic presentation forms of Lam with Alef.
       
 54740         (WebCore::shapeArabic): Added. This is a wrapper around the ICU Arabic shaping routine
       
 54741         that replaces each space following a Lam with Alef ligature resulting from shaping
       
 54742         with a zero-width space.
       
 54743         (WebCore::ATSULayoutParameters::initialize): Changed to allocate the auxiliary buffer
       
 54744         lazily for mirroring and Arabic shaping. Added a call to shapeArabic() when required.
       
 54745 
       
 54746 2007-02-05  Eric Seidel  <eric@webkit.org>
       
 54747 
       
 54748         No review, build fix only.
       
 54749 
       
 54750         * ksvg2/svg/SVGStyleElement.cpp: add forgotten header.
       
 54751 
       
 54752 2007-02-05  Eric Seidel  <eric@webkit.org>
       
 54753 
       
 54754         Reviewed by bdash.
       
 54755 
       
 54756         Fix style name testcase which I broke in my last commit.
       
 54757 
       
 54758         * ksvg2/svg/SVGStyleElement.cpp:
       
 54759         (WebCore::SVGStyleElement::xmlspace):
       
 54760         (WebCore::SVGStyleElement::title): override Element::title()
       
 54761         (WebCore::SVGStyleElement::parseMappedAttribute):
       
 54762         * ksvg2/svg/SVGStyleElement.h:
       
 54763 
       
 54764 2007-02-04  Eric Seidel  <eric@webkit.org>
       
 54765 
       
 54766         Reviewed by darin.
       
 54767 
       
 54768         Fix hand cursor on link hover for SVG
       
 54769         Fix status text on link hover for SVG
       
 54770         Fix tooltips on link hover for SVG
       
 54771         Fix link dragging for SVG
       
 54772         http://bugs.webkit.org/show_bug.cgi?id=12575
       
 54773         
       
 54774         Test: added manual-tests/svg-links.svg
       
 54775 
       
 54776         * dom/Document.cpp:
       
 54777         (WebCore::Document::prepareMouseEvent):
       
 54778         * dom/Element.cpp:
       
 54779         (WebCore::Element::title):
       
 54780         * dom/Element.h:
       
 54781         * html/HTMLElement.cpp:
       
 54782         (WebCore::HTMLElement::setId):
       
 54783         (WebCore::HTMLElement::title):
       
 54784         (WebCore::HTMLElement::setTitle):
       
 54785         (WebCore::HTMLElement::setLang):
       
 54786         * html/HTMLElement.h:
       
 54787         * ksvg2/svg/SVGAElement.cpp:
       
 54788         (WebCore::SVGAElement::title):
       
 54789         (WebCore::SVGAElement::parseMappedAttribute):
       
 54790         (WebCore::SVGAElement::defaultEventHandler):
       
 54791         * ksvg2/svg/SVGAElement.h:
       
 54792         * ksvg2/svg/SVGTitleElement.cpp:
       
 54793         * ksvg2/svg/SVGTitleElement.h:
       
 54794         * manual-tests/svg-links.svg: Added.
       
 54795         * rendering/HitTestResult.cpp:
       
 54796         (WebCore::HitTestResult::title):
       
 54797         (WebCore::HitTestResult::absoluteImageURL):
       
 54798         (WebCore::HitTestResult::absoluteLinkURL):
       
 54799         (WebCore::HitTestResult::isLiveLink):
       
 54800         (WebCore::HitTestResult::titleDisplayString):
       
 54801 
       
 54802 2007-02-04  Alexey Proskuryakov  <ap@webkit.org>
       
 54803 
       
 54804         Reviewed by Darin.
       
 54805 
       
 54806         http://bugs.webkit.org/show_bug.cgi?id=12602
       
 54807         XPath functions string(), normalize-space() and string-length() don't work
       
 54808         without arguments
       
 54809 
       
 54810         Test: fast/xpath/implicit-node-args.html
       
 54811 
       
 54812         * xml/XPathFunctions.cpp:
       
 54813         (WebCore::XPath::FunString::doEvaluate):
       
 54814         (WebCore::XPath::FunStringLength::doEvaluate):
       
 54815         (WebCore::XPath::FunNormalizeSpace::doEvaluate):
       
 54816         Don't try to pass RefPtr<Node> to the Value ctor.
       
 54817 
       
 54818 2007-02-04  Alexey Proskuryakov  <ap@webkit.org>
       
 54819 
       
 54820         Reviewed by Darin.
       
 54821 
       
 54822         http://bugs.webkit.org/show_bug.cgi?id=8791
       
 54823         XPath should support custom node resolvers
       
 54824 
       
 54825         * bindings/js/JSCustomXPathNSResolver.cpp: Added.
       
 54826         (WebCore::JSCustomXPathNSResolver::create):
       
 54827         (WebCore::JSCustomXPathNSResolver::JSCustomXPathNSResolver):
       
 54828         (WebCore::JSCustomXPathNSResolver::~JSCustomXPathNSResolver):
       
 54829         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
       
 54830         * bindings/js/JSCustomXPathNSResolver.h: Added.
       
 54831         * bindings/objc/DOMCustomXPathNSResolver.h: Added.
       
 54832         * bindings/objc/DOMCustomXPathNSResolver.mm: Added.
       
 54833         (WebCore::DOMCustomXPathNSResolver::DOMCustomXPathNSResolver):
       
 54834         (WebCore::DOMCustomXPathNSResolver::~DOMCustomXPathNSResolver):
       
 54835         (WebCore::DOMCustomXPathNSResolver::lookupNamespaceURI):
       
 54836         Wrappers for JS/ObjC objects that can be used as resolvers.
       
 54837 
       
 54838         * bindings/scripts/CodeGeneratorJS.pm:
       
 54839         * bindings/scripts/CodeGeneratorObjC.pm:
       
 54840         Use the above wrappers to support custom resolvers.
       
 54841 
       
 54842         * xml/XPathNSResolver.cpp:
       
 54843         * xml/XPathNSResolver.h:
       
 54844         Turned this class into an abstract one.
       
 54845 
       
 54846         * xml/NativeXPathNSResolver.cpp: Added.
       
 54847         (WebCore::NativeXPathNSResolver::NativeXPathNSResolver):
       
 54848         (WebCore::NativeXPathNSResolver::~NativeXPathNSResolver):
       
 54849         (WebCore::NativeXPathNSResolver::lookupNamespaceURI):
       
 54850         * xml/NativeXPathNSResolver.h: Added.
       
 54851         A XPathNSResolver subclass, doing what XPathNSResolver used to do.
       
 54852 
       
 54853         * xml/XPathEvaluator.cpp:
       
 54854         (WebCore::XPathEvaluator::createNSResolver): Create a NativeXPathNSResolver.
       
 54855 
       
 54856         * WebCore.xcodeproj/project.pbxproj: Added new files.
       
 54857 
       
 54858 2007-02-04  Oliver Hunt  <oliver@apple.com>
       
 54859 
       
 54860         Reviewed by Adam.
       
 54861 
       
 54862         Tidying up EventHandler, and moving more of
       
 54863         EventHandlerMac.mm to EventHandler.cpp
       
 54864 
       
 54865         Also added EventHandler::eventLoopHandleMouse[Dragged,Up]
       
 54866         these are basically helper functions to allow correct event
       
 54867         handling on MacOS.        
       
 54868 
       
 54869         * page/EventHandler.cpp:
       
 54870         (WebCore::EventHandler::handleMouseUp):
       
 54871         (WebCore::EventHandler::dragSourceMovedTo):
       
 54872         (WebCore::EventHandler::dragSourceEndedAt):
       
 54873         (WebCore::EventHandler::dispatchDragSrcEvent):
       
 54874            Moved from EventHandlerMac to EventHandler
       
 54875 
       
 54876         * page/EventHandler.h:
       
 54877         (WebCore::EventHandler::eventLoopHandleMouseUp):
       
 54878         (WebCore::EventHandler::eventLoopHandleMouseDragged):
       
 54879           Null implementations of two Mac helper functions
       
 54880         * page/mac/EventHandlerMac.mm:
       
 54881         (WebCore::EventHandler::eventLoopHandleMouseDragged):           
       
 54882         (WebCore::EventHandler::handleDrag):
       
 54883           Much tidying, reduced nesting, made less dependent on NS types   
       
 54884         (WebCore::EventHandler::eventLoopHandleMouseDragged):
       
 54885         (WebCore::EventHandler::eventLoopHandleMouseUp):  
       
 54886           Helper functions to let us process events properly on MacOS
       
 54887 
       
 54888         * page/mac/WebCoreFrameBridge.mm:
       
 54889         (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
       
 54890 
       
 54891 2007-02-04  George Staikos  <staikos@kde.org>
       
 54892 
       
 54893         Reviewed by Zack.
       
 54894 
       
 54895         Some Qt hacks and cleanups - makes rendering of forms much better on
       
 54896         OS X
       
 54897 
       
 54898         * platform/qt/PlatformKeyboardEventQt.cpp: Add Key_Return/Enter
       
 54899         (WebCore::keyIdentifierForQtKeyCode):
       
 54900         (WebCore::windowsKeyCodeForKeyEvent):
       
 54901         * platform/qt/RenderThemeQt.cpp: Hacks and fix buttons
       
 54902         (WebCore::RenderThemeQt::addIntrinsicMargins):
       
 54903         (WebCore::RenderThemeQt::setCheckboxSize):
       
 54904         (WebCore::RenderThemeQt::supportsFocus):
       
 54905         (WebCore::RenderThemeQt::applyTheme):
       
 54906 
       
 54907 2007-02-03  Maciej Stachowiak  <mjs@apple.com>
       
 54908 
       
 54909         Rubber stamped by Adam.
       
 54910 
       
 54911         - remove obsolete code that has an annoying space in the directory name
       
 54912 
       
 54913         * WebCore.vcproj/Image Viewer/Image Viewer.cpp: Removed.
       
 54914         * WebCore.vcproj/Image Viewer/Image Viewer.h: Removed.
       
 54915         * WebCore.vcproj/Image Viewer/Image Viewer.rc: Removed.
       
 54916         * WebCore.vcproj/Image Viewer/Image Viewer.reg: Removed.
       
 54917         * WebCore.vcproj/Image Viewer/Image Viewer.vcproj: Removed.
       
 54918         * WebCore.vcproj/Image Viewer/ImageDocument.cpp: Removed.
       
 54919         * WebCore.vcproj/Image Viewer/ImageDocument.h: Removed.
       
 54920         * WebCore.vcproj/Image Viewer/ImageMainFrame.cpp: Removed.
       
 54921         * WebCore.vcproj/Image Viewer/ImageMainFrame.h: Removed.
       
 54922         * WebCore.vcproj/Image Viewer/ImageView.cpp: Removed.
       
 54923         * WebCore.vcproj/Image Viewer/ImageView.h: Removed.
       
 54924         * WebCore.vcproj/Image Viewer/Resource.h: Removed.
       
 54925         * WebCore.vcproj/Image Viewer/res/Image Viewer.ico: Removed.
       
 54926         * WebCore.vcproj/Image Viewer/res/Image ViewerDoc.ico: Removed.
       
 54927         * WebCore.vcproj/Image Viewer/res/ImageViewer.rc2: Removed.
       
 54928         * WebCore.vcproj/Image Viewer/res/Toolbar.bmp: Removed.
       
 54929         * WebCore.vcproj/Image Viewer/stdafx.cpp: Removed.
       
 54930         * WebCore.vcproj/Image Viewer/stdafx.h: Removed.
       
 54931 
       
 54932 2007-02-04  Mitz Pettel  <mitz@webkit.org>
       
 54933 
       
 54934         Reviewed by Oliver.
       
 54935 
       
 54936         - fix http://bugs.webkit.org/show_bug.cgi?id=12564
       
 54937           REGRESSION: Uncaught AppKit exception when using the scrollwheel while Gmail is loading
       
 54938 
       
 54939         * platform/mac/PlatformMouseEventMac.mm:
       
 54940         (WebCore::eventNumberForEvent): Scroll wheel events don't have an event number.
       
 54941 
       
 54942 2007-02-04  Nikolas Zimmermann  <zimmermann@kde.org>
       
 54943 
       
 54944         Reviewed by Sam.
       
 54945 
       
 54946         Add support for xml:space="preserve" for SVG text.
       
 54947         It can be modeled by using white-space="pre" and replace \n by spaces.
       
 54948 
       
 54949         Handle xml:space="default" correctly.
       
 54950         Always remove tabs from SVG text - as demanded by spec.
       
 54951 
       
 54952         Added test: svg/custom/text-whitespace-handling.svg
       
 54953 
       
 54954         * css/svg.css:
       
 54955         * ksvg2/svg/SVGTextContentElement.cpp:
       
 54956         (WebCore::SVGTextContentElement::parseMappedAttribute):
       
 54957         * rendering/RenderText.cpp:
       
 54958         (WebCore::RenderText::setStyle):
       
 54959         (WebCore::RenderText::setTextInternal):
       
 54960         * rendering/bidi.cpp:
       
 54961         (WebCore::shouldPreserveNewline):
       
 54962         (WebCore::RenderBlock::skipWhitespace):
       
 54963         (WebCore::RenderBlock::findNextLineBreak):
       
 54964 
       
 54965 2007-02-03  Alexey Proskuryakov  <ap@webkit.org>
       
 54966 
       
 54967         Reviewed by Darin.
       
 54968 
       
 54969         http://bugs.webkit.org/show_bug.cgi?id=12560
       
 54970         W3C XPath test Text_Nodes.svg fails
       
 54971 
       
 54972         Covered by dom/svg/level3/xpath/Text_Nodes.svg
       
 54973 
       
 54974         * xml/XPathStep.cpp:
       
 54975         (WebCore::XPath::Step::nodeTestMatches): Only include the first text sibling in text() matches.
       
 54976 
       
 54977 2007-02-03  Alexey Proskuryakov  <ap@webkit.org>
       
 54978 
       
 54979         Reviewed by Darin.
       
 54980 
       
 54981         http://bugs.webkit.org/show_bug.cgi?id=12485
       
 54982         XPath id() function doesn't work as root in paths
       
 54983 
       
 54984         Test: fast/xpath/id-path.html
       
 54985 
       
 54986         * xml/XPathPath.cpp:
       
 54987         (WebCore::XPath::Path::doEvaluate): Implemented.
       
 54988         (WebCore::XPath::LocationPath::evaluate): A new overload that takes an initial NodeVector.
       
 54989         (WebCore::XPath::LocationPath::doEvaluate): Moved most of the logic to the new evaluate().
       
 54990 
       
 54991         * xml/XPathPath.h: Added a new evaluate() overload and a using declaration to keep the
       
 54992         generic one visible.
       
 54993 
       
 54994 2007-02-03  Alexey Proskuryakov  <ap@webkit.org>
       
 54995 
       
 54996         Reviewed by Darin.
       
 54997 
       
 54998         http://bugs.webkit.org/show_bug.cgi?id=12559
       
 54999         REGRESSION: Crash in checkForHeadCharset() under GuardMalloc
       
 55000 
       
 55001         No tests possible.
       
 55002 
       
 55003         * loader/TextResourceDecoder.cpp:
       
 55004         (WebCore::TextResourceDecoder::checkForHeadCharset): Fix end of buffer checks; sprinkle a number 
       
 55005         of new ones over the function.
       
 55006 
       
 55007 2007-02-03  David Kilzer  <ddkilzer@webkit.org>
       
 55008 
       
 55009         Reviewed by NOBODY (no-svg build fix).
       
 55010 
       
 55011         * page/EventHandler.cpp: Include FloatPoint.h.
       
 55012 
       
 55013 2007-02-03  Alexey Proskuryakov  <ap@webkit.org>
       
 55014 
       
 55015         Reviewed by Mitz.
       
 55016 
       
 55017         http://bugs.webkit.org/show_bug.cgi?id=12549
       
 55018         Wrong character encoding at www.ravmilim.co.il
       
 55019 
       
 55020         Test: fast/encoding/meta-charset.html
       
 55021 
       
 55022         * loader/TextResourceDecoder.cpp:
       
 55023         (WebCore::TextResourceDecoder::checkForHeadCharset): Fix an off by one error.
       
 55024 
       
 55025 2007-02-02  Maciej Stachowiak  <mjs@apple.com>
       
 55026         
       
 55027         Reviewed by Hyatt & Adele.
       
 55028         
       
 55029         - <rdar://problem/4896972> TV guide listings page doesn't finish loading (11674)
       
 55030         
       
 55031         Test case: fast/forms/disabled-select-change-index.html
       
 55032         
       
 55033         * html/HTMLOptionElement.cpp:
       
 55034         (WebCore::HTMLOptionElement::setSelected): Allow changing selected state of a disabled
       
 55035         option.
       
 55036         
       
 55037 2007-02-03  Nikolas Zimmermann  <zimmermann@kde.org>
       
 55038 
       
 55039         Build fix, not reviewed.
       
 55040 
       
 55041         Blind attempt to fix Qt build.
       
 55042 
       
 55043         * WebCore.pro: Add RenderSVGGradientStop.cpp / RenderSVGHiddenContainer.cpp
       
 55044 
       
 55045 2007-02-03  Nikolas Zimmermann  <zimmermann@kde.org>
       
 55046 
       
 55047         Reviewed by Eric & Maciej.
       
 55048 
       
 55049         Fix serveral <use> issues:
       
 55050         - When events are dispatch to a referenced element, the actual event.target
       
 55051           has to be set to the corresponding SVGElementInstance object
       
 55052 
       
 55053         - Node::shadowAncestorNode() should _not_ return the shadowParentNode for SVG elements
       
 55054           This is only needed for the HTML forms concept and breaks event dispatching for SVG shadow tree elements.
       
 55055 
       
 55056         - Add SVGElementInstance as possible EventTarget in bindings/js/kjs_dom.cpp
       
 55057           (Now event.target returns the actual SVGElementInstance object for a shadow tree element)
       
 55058 
       
 55059         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12502 (Reproducible crash when browsing SVG map.)
       
 55060         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12511 (<use> has event dispatching issues)
       
 55061 
       
 55062         Added test: svg/custom/use-event-handler-on-use-element.svg
       
 55063         Added test: svg/custom/use-event-handler-on-referenced-element.svg
       
 55064         Added test: svg/custom/use-elementInstance-event-target.svg
       
 55065         Added test: svg/custom/use-elementInstance-methods.svg
       
 55066 
       
 55067         * bindings/js/kjs_dom.cpp:
       
 55068         (KJS::toJS):
       
 55069         * dom/EventTarget.cpp:
       
 55070         (WebCore::EventTarget::toSVGElementInstance):
       
 55071         * dom/EventTarget.h:
       
 55072         * dom/EventTargetNode.cpp:
       
 55073         (WebCore::EventTargetNode::handleLocalEvents):
       
 55074         (WebCore::EventTargetNode::dispatchGenericEvent):
       
 55075         (WebCore::EventTargetNode::dispatchEvent):
       
 55076         * dom/EventTargetNode.h:
       
 55077         * dom/Node.cpp:
       
 55078         (WebCore::Node::shadowAncestorNode):
       
 55079         * ksvg2/svg/SVGElement.cpp:
       
 55080         (WebCore::shadowTreeParentElementForShadowTreeElement):
       
 55081         (WebCore::SVGElement::dispatchEvent):
       
 55082         * ksvg2/svg/SVGElement.h:
       
 55083         * ksvg2/svg/SVGElementInstance.cpp:
       
 55084         (WebCore::SVGElementInstance::toSVGElementInstance):
       
 55085         * ksvg2/svg/SVGElementInstance.h:
       
 55086         * ksvg2/svg/SVGUseElement.cpp:
       
 55087         (WebCore::SVGUseElement::notifyAttributeChange):
       
 55088         (WebCore::SVGUseElement::instanceForShadowTreeElement):
       
 55089         * ksvg2/svg/SVGUseElement.h:
       
 55090 
       
 55091 2007-02-02  Oliver Hunt  <oliver@apple.com>
       
 55092 
       
 55093         Reviewed by Geoff.
       
 55094 
       
 55095         Add guard around accessing [NSEvent eventNumber] to ensure
       
 55096         we don't attempt to access it on on non-mouse related NSEvent.
       
 55097 
       
 55098         * platform/mac/PlatformMouseEventMac.mm:
       
 55099         (WebCore::eventNumberForEvent):
       
 55100         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
       
 55101 
       
 55102 2007-02-02  Adam Roben  <aroben@apple.com>
       
 55103 
       
 55104         Reviewed by Anders.
       
 55105 
       
 55106         Try to be a little less selfish about DocumentLoader.
       
 55107 
       
 55108         Spotted while working on <rdar://problem/4957747>.
       
 55109 
       
 55110         * page/ContextMenuController.cpp:
       
 55111         (WebCore::ContextMenuController::contextMenuItemSelected):
       
 55112             Everyone can open frames in new windows.
       
 55113 
       
 55114 2007-02-02  Nikolas Zimmermann  <zimmermann@kde.org>
       
 55115 
       
 55116         Reviewed by Eric.
       
 55117 
       
 55118         Move xml:space/xml:lang from svgattrs.in to xmlattrs.in where they actually belong.
       
 55119         Now they are actually recognized by SVGLangSpace::parseMappedAttribute.
       
 55120         Patch implementing xml:space="preserve" coming soon, which acts as test for this stuff.
       
 55121 
       
 55122         Always build XMLNames.cpp (not only for SVG) and replace all occourences of
       
 55123         "http://www.w3.org/XML/1998/namespace" by "XMLNames::xmlNamespaceURI".
       
 55124 
       
 55125         * DerivedSources.make:
       
 55126         * dom/DOMImplementation.cpp:
       
 55127         (WebCore::DOMImplementation::createDocument):
       
 55128         * ksvg2/svg/SVGLangSpace.cpp:
       
 55129         (WebCore::SVGLangSpace::SVGLangSpace):
       
 55130         (WebCore::SVGLangSpace::parseMappedAttribute):
       
 55131         * ksvg2/svg/SVGLangSpace.h:
       
 55132         * ksvg2/svg/svgattrs.in:
       
 55133         * page/Frame.cpp:
       
 55134         (WebCore::Frame::Frame):
       
 55135         * xml/XPathNSResolver.cpp:
       
 55136         (WebCore::XPathNSResolver::lookupNamespaceURI):
       
 55137         * xml/xmlattrs.in:
       
 55138 
       
 55139 2007-02-02  Beth Dakin  <bdakin@apple.com>
       
 55140 
       
 55141         Reviewed by Maciej.
       
 55142 
       
 55143         Working on a layout test.
       
 55144 
       
 55145         Fix for <rdar://problem/4966100> REGRESSION: Reproducible ASSERT 
       
 55146         hit at Walgreens.com
       
 55147 
       
 55148         * page/Frame.cpp:
       
 55149         (WebCore::Frame::setView): If we are setting the view to 0 and 
       
 55150         detaching the document, call unscheduleRealyout() on the old view 
       
 55151         before setting it to 0.
       
 55152 
       
 55153 2007-02-01  Geoffrey Garen  <ggaren@apple.com>
       
 55154 
       
 55155         Reviewed by Maciej Stachowiak.
       
 55156         
       
 55157         Added support for selectively ignoring WebCore::Node leaks during layout
       
 55158         tests, so that we can ignore known leaks in other components.
       
 55159 
       
 55160         * WebCore.exp:
       
 55161         * dom/Node.cpp:
       
 55162         (WebCore::Node::isSupported): Moved isSupported up with the rest of the static functions.
       
 55163 
       
 55164         (WebCore::): Added an ignoreSet, which collects WebCore::Nodes whose lifetime
       
 55165         we want to ignore. We need to track which nodes to ignore rather than, say,
       
 55166         just suspending the count, because node destruction depends on lots of
       
 55167         different variables, so it would be nearly impossible to know when exactly 
       
 55168         to suspend the count and when exactly to resume it.
       
 55169 
       
 55170         (WebCore::NodeCounter::~NodeCounter): Changed to use WTFLog instead of fprintf.
       
 55171 
       
 55172         (WebCore::Node::startIgnoringLeaks): Do the ignoring.
       
 55173         (WebCore::Node::stopIgnoringLeaks): ditto
       
 55174         (WebCore::Node::Node): ditto
       
 55175         (WebCore::Node::~Node): ditto
       
 55176 
       
 55177         * dom/Node.h: Moved isSupported up with the rest of the static functions.
       
 55178 
       
 55179         * platform/mac/LoggingMac.mm:
       
 55180         (WebCore::initializeWithUserDefault): Renamed from "initializeLoggingChannel"
       
 55181         because the real goal here is to honor a user default -- WTFLoggingChannels
       
 55182         need no run-time initialization. Also replaced "off by default, on if a 
       
 55183         user default says so" behavior with "only override existing setting if a
       
 55184         user default says so" behavior. It seemed like a bug that you would specify 
       
 55185         a channel's on/off state in its definition, but this function would unconditionally
       
 55186         blow that state away.
       
 55187         (WebCore::InitializeLoggingChannelsIfNecessary):
       
 55188 
       
 55189 2007-02-02  Eric Seidel  <eric@webkit.org>
       
 55190 
       
 55191         Reviewed by mitz.
       
 55192 
       
 55193         Fix gradient stop style resolution to be less of a hack, fixing style invalidation:
       
 55194         http://bugs.webkit.org/show_bug.cgi?id=12193
       
 55195         and fix stop-color and stop-opacity not to inherit:
       
 55196         http://bugs.webkit.org/show_bug.cgi?id=12193
       
 55197         
       
 55198         Tests:
       
 55199         * svg/custom/gradient-stops-style-change.svg: added
       
 55200         * svg/W3C-SVG-1.1/pservers-grad-18-b.svg: updated
       
 55201 
       
 55202         * WebCore.xcodeproj/project.pbxproj:
       
 55203         * ksvg2/css/SVGCSSStyleSelector.cpp:
       
 55204         (WebCore::CSSStyleSelector::applySVGProperty):
       
 55205         * ksvg2/css/SVGRenderStyle.cpp:
       
 55206         (WebCore::SVGRenderStyle::inheritedNotEqual):
       
 55207         (WebCore::SVGRenderStyle::inheritFrom):
       
 55208         * ksvg2/css/SVGRenderStyle.h:
       
 55209         * ksvg2/svg/SVGDefsElement.cpp:
       
 55210         (WebCore::SVGDefsElement::createRenderer):
       
 55211         * ksvg2/svg/SVGGradientElement.cpp:
       
 55212         (WebCore::SVGGradientElement::createRenderer):
       
 55213         (WebCore::SVGGradientElement::buildStops):
       
 55214         * ksvg2/svg/SVGGradientElement.h:
       
 55215         (WebCore::SVGGradientElement::rendererIsNeeded):
       
 55216         * ksvg2/svg/SVGStopElement.cpp:
       
 55217         (WebCore::SVGStopElement::createRenderer):
       
 55218         * ksvg2/svg/SVGStopElement.h:
       
 55219         (WebCore::SVGStopElement::rendererIsNeeded):
       
 55220         * rendering/RenderSVGGradientStop.cpp: Added.
       
 55221         * rendering/RenderSVGGradientStop.h: Added.
       
 55222         * rendering/RenderSVGHiddenContainer.cpp: Added.
       
 55223         * rendering/RenderSVGHiddenContainer.h: Added.
       
 55224         * rendering/RenderSVGContainer.cpp:
       
 55225         * rendering/RenderSVGContainer.h:
       
 55226 
       
 55227 2007-02-02  Zack Rusin  <zrusin@trolltech.com>
       
 55228 
       
 55229         Reviewed by Lars
       
 55230 
       
 55231         Fix scrolling-on-selection bug by correctly
       
 55232         scrolling to the offset instead of trying to 
       
 55233         ensure visibility with margins.
       
 55234 
       
 55235         * platform/qt/ScrollViewQt.cpp:
       
 55236         (WebCore::ScrollView::scrollPointRecursively):
       
 55237 
       
 55238 2007-02-02  Zack Rusin  <zrusin@trolltech.com>
       
 55239 
       
 55240         Reviewed by Lars
       
 55241 
       
 55242         Fix drawing of dashed and colored lines. Pen
       
 55243         has to be inherited for stroke to stay consistent.
       
 55244 
       
 55245         * platform/graphics/qt/GraphicsContextQt.cpp:
       
 55246         (WebCore::GraphicsContext::setAlpha):
       
 55247         (WebCore::GraphicsContext::setPlatformStrokeColor):
       
 55248         (WebCore::GraphicsContext::setPlatformStrokeStyle):
       
 55249 
       
 55250 2007-02-01  Nicholas Shanks  <webkit@nickshanks.com>
       
 55251 
       
 55252         Reviewed by Mark.
       
 55253 
       
 55254         Add support for CSS2 font-stretch property.
       
 55255 
       
 55256         * css/CSSComputedStyleDeclaration.cpp:
       
 55257         (WebCore::):
       
 55258         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 55259         * css/cssparser.cpp:
       
 55260         (WebCore::CSSParser::parseValue):
       
 55261         * css/cssstyleselector.cpp:
       
 55262         (WebCore::CSSStyleSelector::applyDeclarations):
       
 55263         (WebCore::CSSStyleSelector::applyProperty):
       
 55264         * platform/FontCache.cpp:
       
 55265         (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
       
 55266         (WebCore::FontPlatformDataCacheKey::operator==):
       
 55267         (WebCore::computeHash):
       
 55268         (WebCore::FontPlatformDataCacheKeyTraits::deletedValue):
       
 55269         (WebCore::FontPlatformDataCacheKeyTraits::emptyValue):
       
 55270         (WebCore::FontCache::getCachedFontPlatformData):
       
 55271         * platform/FontDescription.h:
       
 55272         (WebCore::):
       
 55273         (WebCore::FontDescription::FontDescription):
       
 55274         (WebCore::FontDescription::stretch):
       
 55275         (WebCore::FontDescription::narrowerStretch):
       
 55276         (WebCore::FontDescription::widerStretch):
       
 55277         (WebCore::FontDescription::setStretch):
       
 55278         (WebCore::FontDescription::operator==):
       
 55279         * platform/mac/FontCacheMac.mm:
       
 55280         (WebCore::FontCache::createFontPlatformData):
       
 55281         * platform/mac/WebFontCache.mm:
       
 55282         (acceptableChoice):
       
 55283         (betterChoice):
       
 55284         (+[WebFontCache fontWithFamily:traits:size:]):
       
 55285 
       
 55286 2007-02-01  Timothy Hatcher  <timothy@apple.com>
       
 55287 
       
 55288         Reviewed by Mark Rowe.
       
 55289 
       
 55290         <rdar://problem/4969201> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
       
 55291 
       
 55292         * platform/mac/WebFontCache.mm:
       
 55293         (+[WebFontCache fontWithFamily:traits:size:]): Don't call [NSFont fontWithName:] with the desiredFamily on Tiger.
       
 55294 
       
 55295 2007-02-01  Alexey Proskuryakov  <ap@webkit.org>
       
 55296 
       
 55297         Reviewed by Darin.
       
 55298 
       
 55299         http://bugs.webkit.org/show_bug.cgi?id=12506
       
 55300         REGRESSION: Safari doesn't display hebrew text on a web page,
       
 55301         displayed correctly on Tiger
       
 55302 
       
 55303         * loader/TextResourceDecoder.cpp:
       
 55304         (WebCore::TextResourceDecoder::checkForHeadCharset): Advance the pointer when necessary.
       
 55305 
       
 55306 2007-02-01  George Staikos  <staikos@kde.org>
       
 55307 
       
 55308         Reviewed by Zack and Lars.
       
 55309 
       
 55310         Add a cookie interface for the Qt build.
       
 55311 
       
 55312         * WebCore.pro:
       
 55313         * platform/qt/CookieJarQt.cpp:
       
 55314         (WebCore::setCookies):
       
 55315         (WebCore::cookies):
       
 55316         (WebCore::cookiesEnabled):
       
 55317 
       
 55318 2007-02-01  Maciej Stachowiak  <mjs@apple.com>
       
 55319 
       
 55320         Reviewed by Adele.
       
 55321         
       
 55322         - fixed <rdar://problem/4922764> ASSERTION: (!m_contentFunction) in PolicyCheck::call trying to visit feed URL (CNN, Apple, etc.)
       
 55323 
       
 55324         * loader/FrameLoader.cpp:
       
 55325         (WebCore::FrameLoader::stopPolicyCheck): Call new cancel method instead of call(false) on old check.
       
 55326         (WebCore::PolicyCheck::cancel): call any callback function that is set with false or PolicyIgnore as
       
 55327         appropriate.
       
 55328         * loader/FrameLoader.h:
       
 55329 
       
 55330 2007-02-01  Beth Dakin  <bdakin@apple.com>
       
 55331 
       
 55332         Reviewed by Hyatt.
       
 55333 
       
 55334         Fix for http://bugs.webkit.org/show_bug.cgi?id=10517 REGRESSION 
       
 55335         (r12065-r12082): Navigation graphic wraps to the next line on 
       
 55336         duart.com and <rdar://problem/4960505> REGRESSION: The Awesome 
       
 55337         Windows Vista page has a layout error in the header table (10517)
       
 55338 
       
 55339         The problem is that we never supported a quirk that other browsers 
       
 55340         support where, under very specific circumstances, a table cell will 
       
 55341         grow to fit an image inside of it. This is only a regression 
       
 55342         because a bug was fixed were we were 1 pixel off in the calculation 
       
 55343         of overflow in some cases.
       
 55344 
       
 55345         * rendering/RenderBlock.cpp:
       
 55346         (WebCore::shouldGrowTableCellForImage):
       
 55347         (WebCore::RenderBlock::calcInlineMinMaxWidth):
       
 55348 
       
 55349 2007-02-01  Zack Rusin  <zrusin@trolltech.com>
       
 55350 
       
 55351         Reviewed by Lars
       
 55352 
       
 55353         Implement native look for comboboxes
       
 55354         and fix/implement popup menus.
       
 55355 
       
 55356         * platform/PopupMenu.h:
       
 55357         * platform/qt/PopupMenuQt.cpp:
       
 55358         (WebCore::PopupMenu::PopupMenu):
       
 55359         (WebCore::PopupMenu::~PopupMenu):
       
 55360         (WebCore::PopupMenu::clear):
       
 55361         (WebCore::PopupMenu::populate):
       
 55362         (WebCore::PopupMenu::show):
       
 55363         (WebCore::PopupMenu::hide):
       
 55364         (WebCore::PopupMenu::updateFromElement):
       
 55365         * platform/qt/RenderThemeQt.cpp:
       
 55366         (WebCore::RenderThemeQt::adjustMenuListStyle):
       
 55367         (WebCore::RenderThemeQt::paintButton):
       
 55368         (WebCore::RenderThemeQt::paintTextField):
       
 55369         (WebCore::RenderThemeQt::paintMenuList):
       
 55370 
       
 55371 2007-02-01  Darin Adler  <darin@apple.com>
       
 55372 
       
 55373         Reviewed by Maciej.
       
 55374 
       
 55375         - fix <rdar://problem/4887428> REGRESSION: Implement slight delay for firing incremental onSearch event
       
 55376 
       
 55377         * rendering/RenderTextControl.h:
       
 55378         * rendering/RenderTextControl.cpp:
       
 55379         (WebCore::RenderTextControl::RenderTextControl): Set up timer.
       
 55380         (WebCore::RenderTextControl::subtreeHasChanged): Start timer here instead of immediately sending event.
       
 55381         (WebCore::RenderTextControl::searchEventTimerFired): Added. Sends search event.
       
 55382         (WebCore::RenderTextControl::stopSearchEventTimer): Added.
       
 55383         (WebCore::RenderTextControl::startSearchEventTimer): Added. Sends search event right away if there is
       
 55384         no text. If there is some text, sets the timer using the same delay rule as NSSearchField. If you keep
       
 55385         typing, then the timer keeps getting reset 0.2 seconds into the future until you pause.
       
 55386 
       
 55387         * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::onSearch): Tell the renderer to
       
 55388         stop the timer, since we're sending a search event. This helps when a caller other than
       
 55389         the timer decides to send an explicit search event.
       
 55390 
       
 55391 2007-02-01  Maciej Stachowiak  <mjs@apple.com>
       
 55392 
       
 55393         Fix by Darin, reviewed by Maciej.
       
 55394 
       
 55395         - fix ~10% performance regression from encoding fix
       
 55396 
       
 55397         * loader/TextResourceDecoder.cpp:
       
 55398         (WebCore::TextResourceDecoder::checkForHeadCharset): Fix a logic
       
 55399         error which made huge strings accidentally.
       
 55400 
       
 55401 2007-02-01  Lars Knoll <lars@trolltech.com>
       
 55402 
       
 55403         Fix the Qt build
       
 55404 
       
 55405         * page/qt/EventHandlerQt.cpp:
       
 55406 
       
 55407 2007-01-31  Darin Adler  <darin@apple.com>
       
 55408 
       
 55409         Reviewed by Adam and Geoff.
       
 55410 
       
 55411         - fix <rdar://problem/4786767> REGRESSION: <select> controls are not resized when zooming text
       
 55412 
       
 55413         Test: fast/forms/select-width-font-change.html
       
 55414 
       
 55415         * rendering/RenderMenuList.h: Cleaned up formatting a bit. Removed unneeded include of PopupMenu.h.
       
 55416         Made a lot more things private, including the PopupMenuClient base class, all of the virtual
       
 55417         functions from PopupMenuClient, and the setTextFromOption function. Added updateOptionsWidth.
       
 55418 
       
 55419         * rendering/RenderMenuList.cpp:
       
 55420         (WebCore::RenderMenuList::setStyle): Added code to call updateOptionsWidth when the font changes.
       
 55421         (WebCore::RenderMenuList::updateOptionsWidth): Added. Factored code out of updateFromElement.
       
 55422         Changed to do nothing when m_optionsWidth is already correct.
       
 55423         (WebCore::RenderMenuList::updateFromElement): Moved code to recomputed options width to the new
       
 55424         updateOptionsWidth function.
       
 55425         (WebCore::RenderMenuList::text): Made const.
       
 55426 
       
 55427 2007-01-31  Oliver Hunt  <oliver@apple.com>
       
 55428 
       
 55429         Reviewed by Adam.
       
 55430 
       
 55431         Migrate more drag and drop logic to WebCore, start preparing
       
 55432         to move EventHandler::handleDrag from EventHandlerMac to EventHandler 
       
 55433 
       
 55434         * WebCore.exp:   
       
 55435           updating methods
       
 55436                     
       
 55437         * dom/Clipboard.cpp:
       
 55438         * dom/Clipboard.h:
       
 55439         (WebCore::Clipboard::Clipboard):
       
 55440         (WebCore::Clipboard::setDragHasStarted):
       
 55441         (WebCore::Clipboard::dragStarted): 
       
 55442           Moving from ClipboardMac to Clipboard 
       
 55443 
       
 55444         * dom/EventTargetNode.cpp:
       
 55445         (WebCore::EventTargetNode::dispatchMouseEvent):
       
 55446           PlatformMouseEvent no longer lies about button state, however 
       
 55447           DOM Events don't allow NoButton, so we need to convert NoButton 
       
 55448           to LeftButton when we create a DOM Event from PlatformMouseEvent
       
 55449 
       
 55450         * page/DragClient.h:
       
 55451           Tidying comment 
       
 55452 
       
 55453         * page/DragController.cpp:
       
 55454         (WebCore::createMouseEvent):
       
 55455           Updated for new PlatformMouseEvent constructors
       
 55456         (WebCore::DragController::mayStartDragAtEventLocation):
       
 55457           Migrated from WebKit
       
 55458 
       
 55459         * page/DragController.h:
       
 55460           Added above function declarations
       
 55461 
       
 55462         * page/EventHandler.cpp:
       
 55463         (WebCore::EventHandler::dragState): 
       
 55464         (WebCore::EventHandler::dragHysteresisExceeded):
       
 55465         (WebCore::EventHandler::freeClipboard):
       
 55466         (WebCore::EventHandler::shouldDragAutoNode):
       
 55467           Moved from EventHandlerMac
       
 55468         (WebCore::EventHandler::handleMouseMoveEvent):
       
 55469         (WebCore::EventHandler::eventMayStartDrag):
       
 55470         (WebCore::EventHandler::handleMousePressEvent):
       
 55471           Use DragController     
       
 55472 
       
 55473         * page/EventHandler.h:
       
 55474           Added DragState struct definition to EventHandler
       
 55475 
       
 55476         * page/mac/EventHandlerMac.mm:
       
 55477         (WebCore::EventHandler::eventActivatedView):
       
 55478         (WebCore::EventHandler::handleDrag):
       
 55479         (WebCore::EventHandler::handleMouseUp):
       
 55480         (WebCore::EventHandler::mouseDown):
       
 55481           Update to use DragController and PlatformMouseEvent
       
 55482 
       
 55483         * page/mac/WebCoreFrameBridge.h:
       
 55484         * page/mac/WebCoreFrameBridge.mm:
       
 55485         (-[WebCoreFrameBridge dragSourceMovedTo:]):
       
 55486         (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
       
 55487           Use DragController for state
       
 55488 
       
 55489         * platform/PlatformMouseEvent.h:
       
 55490         (WebCore::):
       
 55491         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
       
 55492         (WebCore::PlatformMouseEvent::eventType):
       
 55493         (WebCore::PlatformMouseEvent::timestamp):
       
 55494         (WebCore::PlatformMouseEvent::eventNumber):
       
 55495         (WebCore::PlatformMouseEvent::setClickCount):
       
 55496           Exposing necessary data for Drag logic
       
 55497 
       
 55498         * platform/mac/ClipboardMac.h:
       
 55499         * platform/mac/ClipboardMac.mm:
       
 55500         (WebCore::ClipboardMac::ClipboardMac):
       
 55501         (WebCore::ClipboardMac::setDragImage):
       
 55502           Have moved a number of fields from ClipboardMac to Clipboard
       
 55503           so need to use accessors in a few places now
       
 55504 
       
 55505         * platform/mac/PlatformMouseEventMac.mm:
       
 55506         (WebCore::mouseButtonForEvent):
       
 55507         (WebCore::mouseEventForNSEvent):
       
 55508         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
       
 55509           Determine MouseEventType, and provide event time info
       
 55510 
       
 55511 2007-01-31  Alexey Proskuryakov  <ap@webkit.org>
       
 55512 
       
 55513         Reviewed by Darin.
       
 55514 
       
 55515         http://bugs.webkit.org/show_bug.cgi?id=12506
       
 55516         REGRESSION: Safari doesn't display hebrew text on a web page,
       
 55517         displayed correctly on Tiger
       
 55518 
       
 55519         * loader/TextResourceDecoder.cpp:
       
 55520         (WebCore::TextResourceDecoder::checkForHeadCharset): Skip over 
       
 55521         quoted attributes.
       
 55522 
       
 55523 2007-01-31  David Carson  <dacarson@gmail.com>
       
 55524 
       
 55525         Reviewed by Darin.
       
 55526 
       
 55527         - fix http://bugs.webkit.org/show_bug.cgi?id=12510
       
 55528         Initialize the variable m_totalLoops
       
 55529         Is tested by LayoutTests/fast/css/MarqueeLayoutTest.html
       
 55530 
       
 55531         * rendering/RenderLayer.cpp:
       
 55532         (WebCore::Marquee::Marquee):
       
 55533 
       
 55534 2007-01-31  Anders Carlsson  <acarlsson@apple.com>
       
 55535 
       
 55536         Reviewed by Maciej.
       
 55537 
       
 55538         <rdar://problem/4886776>
       
 55539         REGRESSION: After opening a web archive, location shows the actual URL, not the webarchive file
       
 55540 
       
 55541         * WebCore.exp:
       
 55542         * loader/FrameLoader.cpp:
       
 55543         (WebCore::FrameLoader::continueLoadWithData):
       
 55544         * loader/FrameLoader.h:
       
 55545         New function which continues a load but using a given buffer instead.
       
 55546         
       
 55547 2007-01-31  Adele Peterson  <adele@apple.com>
       
 55548 
       
 55549         Reviewed by Adam.
       
 55550 
       
 55551         Fix for http://bugs.webkit.org/show_bug.cgi?id=12516
       
 55552         REGRESSION (r19313): All keyboard navigation has stopped working
       
 55553 
       
 55554         For non-editable selections, handleKeyPress doesn't need to call _interceptEditingKeyEvent. 
       
 55555 
       
 55556         * editing/Editor.cpp:
       
 55557         (WebCore::selectionForEvent): Moved this to the top of the file.
       
 55558         (WebCore::Editor::handleKeyPress): Do the equivalent of the _canEdit check that used to be in WebKit WebEditorClient::handleKeyPress.
       
 55559 
       
 55560 2007-01-31  Geoffrey Garen  <ggaren@apple.com>
       
 55561 
       
 55562         Reviewed by Darin Adler.
       
 55563 
       
 55564         Added a Range counter to detect leaks. Tweaked the Node counter.
       
 55565         
       
 55566         Also fixed a TextIterator destructive modification bug that I noticed along the
       
 55567         way. No test case for this bug because no clients have been bitten by it
       
 55568         yet.
       
 55569 
       
 55570         * dom/Node.cpp: Renamed NodeImplCounter to NodeCounter, changed counter
       
 55571         to unsigned, fixed formatting to match style guidelines.
       
 55572         (WebCore::NodeCounter::~NodeCounter):
       
 55573         (WebCore::Node::Node):
       
 55574         (WebCore::Node::~Node):
       
 55575 
       
 55576         * dom/Range.cpp:
       
 55577         (WebCore::RangeCounter::~RangeCounter): Added.
       
 55578         (WebCore::Range::Range):
       
 55579         (WebCore::Range::~Range):
       
 55580         (WebCore::Range::ownerDocument): New accessor, used by TextIterator to avoid
       
 55581         annoying NULL checks.
       
 55582         * dom/Range.h:
       
 55583 
       
 55584         * editing/TextIterator.cpp:
       
 55585         (WebCore::TextIterator::subrange): 
       
 55586         (1) Don't initialize result with entireRange --  doing so would create a 
       
 55587         PassRefPtr that pointed to entireRange, so this function would destructively 
       
 55588         modify the Range you passed it. Initialize it with a new Range instead.
       
 55589         (2) Don't use a PassRefPtr as a local variable, because they have sneaky
       
 55590         semantics. Use a RefPtr instead.
       
 55591         (3) Don't call CharacterIterator::range() willy-nilly, since it does 
       
 55592         non-trivial work. Use a local variable instead.
       
 55593 
       
 55594 2007-01-31  Adele Peterson  <adele@apple.com>
       
 55595 
       
 55596         Reviewed by Darin.
       
 55597 
       
 55598         WebCore part of fix for <rdar://problem/4521461> REGRESSION: when keyPress event changes form focus, inserted key goes to wrong control
       
 55599 
       
 55600         Test: fast/events/keypress-focus-change.html
       
 55601 
       
 55602         * editing/Editor.cpp:
       
 55603         (WebCore::selectionForEvent): Added.  This computes a selection that considers the case where an event handler 
       
 55604          has moved the selection outside of a text control.  In that case, we use the target control's selection.
       
 55605         (WebCore::Editor::insertText): This gets the selectionForEvent, checks that the selection is editable,
       
 55606          and calls TypingCommand::insertText with the correct selection.
       
 55607 
       
 55608         * editing/TypingCommand.h: Added a version of insertText that takes a selection.  The old version of insertText will call this, and pass
       
 55609           in the frame's selection.
       
 55610         * editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Added. Uses the passed in selection to 
       
 55611           set the starting and ending selections correctly so that the editing machinery will insert the text in the correct place.
       
 55612 
       
 55613         * page/Page.h: Added convenience method to get selection from focused or main frame.
       
 55614         * page/Page.cpp: (WebCore::Page::selection):
       
 55615 
       
 55616         * html/HTMLInputElement.h: Added selection methods to get selection for text controls.
       
 55617         * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::selection):
       
 55618         * html/HTMLTextAreaElement.h:
       
 55619         * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::selection):
       
 55620         * rendering/RenderTextControl.h:
       
 55621         * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selection):
       
 55622 
       
 55623 2007-01-31  Darin Adler  <darin@apple.com>
       
 55624 
       
 55625         - fix build
       
 55626 
       
 55627         * ForwardingHeaders/wtf/ListHashSet.h: Added.
       
 55628 
       
 55629 2007-01-31  Zack Rusin  <zrusin@trolltech.com>
       
 55630 
       
 55631         Reviewed by Lars
       
 55632 
       
 55633         Return the correct selection color.
       
 55634 
       
 55635         * platform/qt/RenderThemeQt.cpp:
       
 55636         (WebCore::RenderThemeQt::supportsFocusRing):
       
 55637         (WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor):
       
 55638         (WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor):
       
 55639         (WebCore::RenderThemeQt::platformActiveSelectionForegroundColor):
       
 55640         (WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor):
       
 55641 
       
 55642 2007-01-31  Maciej Stachowiak  <mjs@apple.com>
       
 55643 
       
 55644         Reviewed by Mark.
       
 55645 
       
 55646         - fixed <rdar://problem/4751164> REGRESSION: Safari places text on incorrect button when returning to a page via back [10541]
       
 55647         http://bugs.webkit.org/show_bug.cgi?id=10541
       
 55648 
       
 55649         * dom/Document.cpp:
       
 55650         (WebCore::Document::formElementsState):
       
 55651         * dom/Document.h:
       
 55652         
       
 55653         I couldn't figure out the back/forward support in the tests enough
       
 55654         to make an automated test, but this maual test reproduces the
       
 55655         problem 100% without this patch:
       
 55656         
       
 55657         * manual-tests/back.html: Added.
       
 55658         * manual-tests/form-control-madness.html: Added.
       
 55659 
       
 55660 2007-01-31  David Kilzer  <ddkilzer@kilzer.net>
       
 55661 
       
 55662         Reviewed by Mitz.
       
 55663 
       
 55664         - fix http://bugs.webkit.org/show_bug.cgi?id=12490
       
 55665           Clean up canPlaceOnLine logic in bidi.cpp
       
 55666 
       
 55667         No test cases since there is no change in functionality.
       
 55668 
       
 55669         * rendering/bidi.cpp:
       
 55670         (WebCore::RenderBlock::findNextLineBreak): Simplify canFitOnLine expression.
       
 55671 
       
 55672 2007-01-31  Zack Rusin  <zack@kde.org>
       
 55673 
       
 55674         Adding comments explaining how the focus ring implementation
       
 55675         works on the Qt platform and just move focus ring rendering
       
 55676         related code to the same spot.
       
 55677 
       
 55678         * platform/graphics/qt/GraphicsContextQt.cpp:
       
 55679         (WebCore::setFocusRingColorChangeFunction):
       
 55680         (WebCore::focusRingColor):
       
 55681         (WebCore::GraphicsContext::drawFocusRing):
       
 55682         * platform/qt/TemporaryLinkStubs.cpp:
       
 55683 
       
 55684 2007-01-31  Zack Rusin  <zrusin@trolltech.com>
       
 55685 
       
 55686         Reviewed by Lars
       
 55687 
       
 55688         Properly propagate key events. 
       
 55689 
       
 55690         * page/qt/FrameQt.cpp:
       
 55691         * page/qt/FrameQt.h: Remove redundant method.
       
 55692         * platform/qt/ScrollViewCanvasQt.cpp:
       
 55693         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
       
 55694 
       
 55695 2007-01-31  George Staikos  <staikos@kde.org>
       
 55696 
       
 55697         Reviewed by Zack and Lars.
       
 55698 
       
 55699         Fix double delete on cancel as well as assertion with proxy.
       
 55700 
       
 55701         * platform/network/qt/ResourceHandleManagerQt.cpp:
       
 55702         (WebCore::WebCoreHttp::getConnection):
       
 55703         (WebCore::WebCoreHttp::onRequestFinished):
       
 55704         (WebCore::WebCoreHttp::cancel):
       
 55705 
       
 55706 2007-01-31  Mark Rowe  <mrowe@apple.com>
       
 55707 
       
 55708         Reviewed by Oliver.
       
 55709 
       
 55710         * dom/Document.h: Change #if XSLT_SUPPORT to #ifdef XSLT_SUPPORT.
       
 55711 
       
 55712 2007-01-31  Lars Knoll <lars@trolltech.com>
       
 55713 
       
 55714         Fix the Qt build.
       
 55715 
       
 55716         * platform/network/qt/ResourceHandleQt.cpp:
       
 55717         (WebCore::ResourceHandle::setDefersLoading):
       
 55718 
       
 55719 2007-01-31  Zack Rusin  <zack@kde.org>
       
 55720 
       
 55721         Reviewed by Eric.
       
 55722 
       
 55723         Implement SVGImage on the Qt platform.
       
 55724 
       
 55725         * WebCore.pro:
       
 55726         * loader/CachedImage.cpp:
       
 55727         (WebCore::CachedImage::createImage):
       
 55728         * platform/graphics/ImageBuffer.h:
       
 55729         * platform/graphics/qt/ImageBufferQt.cpp:
       
 55730         (WebCore::ImageBuffer::create):
       
 55731         (WebCore::ImageBuffer::ImageBuffer):
       
 55732         (WebCore::ImageBuffer::~ImageBuffer):
       
 55733         (WebCore::ImageBuffer::context):
       
 55734         (WebCore::ImageBuffer::pixmap):
       
 55735         * platform/graphics/svg/SVGImage.cpp:
       
 55736         (WebCore::SVGImage::nativeImageForCurrentFrame):
       
 55737         (WebCore::SVGImage::setData):
       
 55738 
       
 55739 2007-01-30  Maciej Stachowiak  <mjs@apple.com>
       
 55740 
       
 55741         Reviewed by Brady.
       
 55742 
       
 55743         - fixed <rdar://problem/4939366> REGRESSION: Assertion failure and crash when going back in history (12314)
       
 55744 
       
 55745         * loader/FrameLoader.cpp:
       
 55746         (WebCore::FrameLoader::createWindow): special case a frame name of "_blank"
       
 55747         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): ditto
       
 55748 
       
 55749 2007-01-30  Maciej Stachowiak  <mjs@apple.com>
       
 55750 
       
 55751         Reviewed by Anders.
       
 55752 
       
 55753         - fixed <rdar://problem/4963871> REGRESSION: Crash occurs at WebCore::Frame::loader() when attempting to open a saved archive file
       
 55754 
       
 55755         * loader/DocumentLoader.cpp:
       
 55756         (WebCore::DocumentLoader::request): Removed obsolete FIXME.
       
 55757         (WebCore::DocumentLoader::initialRequest): Ditto.
       
 55758         * loader/MainResourceLoader.cpp:
       
 55759         (WebCore::MainResourceLoader::MainResourceLoader): Handle data loads from a timer, otherwise bad things happen.
       
 55760         (WebCore::MainResourceLoader::handleDataLoadNow):
       
 55761         (WebCore::MainResourceLoader::handleDataLoadSoon):
       
 55762         (WebCore::MainResourceLoader::loadNow):
       
 55763         (WebCore::MainResourceLoader::didCancel): cancel data load timer
       
 55764         * loader/MainResourceLoader.h:
       
 55765 
       
 55766 2007-01-30  Timothy Hatcher  <timothy@apple.com>
       
 55767 
       
 55768         Reviewed by Darin.
       
 55769 
       
 55770         <rdar://problem/4961953> Stop using NSString deprecated methods like initWithCString:
       
 55771 
       
 55772         * WebCore.xcodeproj/project.pbxproj:
       
 55773         * platform/graphics/svg/filters/cg/WKArithmeticFilter.m:
       
 55774         (-[WKArithmeticFilter init]):
       
 55775         * platform/graphics/svg/filters/cg/WKComponentMergeFilter.m:
       
 55776         (-[WKComponentMergeFilter init]):
       
 55777         * platform/graphics/svg/filters/cg/WKDiffuseLightingFilter.m:
       
 55778         (-[WKDiffuseLightingFilter init]):
       
 55779         * platform/graphics/svg/filters/cg/WKDiscreteTransferFilter.m:
       
 55780         (-[WKDiscreteTransferFilter init]):
       
 55781         * platform/graphics/svg/filters/cg/WKDisplacementMapFilter.m:
       
 55782         (-[WKDisplacementMapFilter init]):
       
 55783         * platform/graphics/svg/filters/cg/WKDistantLightFilter.m:
       
 55784         (-[WKDistantLightFilter init]):
       
 55785         * platform/graphics/svg/filters/cg/WKGammaTransferFilter.m:
       
 55786         (-[WKGammaTransferFilter init]):
       
 55787         * platform/graphics/svg/filters/cg/WKLinearTransferFilter.m:
       
 55788         (-[WKLinearTransferFilter init]):
       
 55789         * platform/graphics/svg/filters/cg/WKNormalMapFilter.m:
       
 55790         (-[WKNormalMapFilter init]):
       
 55791         * platform/graphics/svg/filters/cg/WKPointLightFilter.m:
       
 55792         (-[WKPointLightFilter init]):
       
 55793         * platform/graphics/svg/filters/cg/WKSpecularLightingFilter.m:
       
 55794         (-[WKSpecularLightingFilter init]):
       
 55795         * platform/graphics/svg/filters/cg/WKSpotLightFilter.m:
       
 55796         (-[WKSpotLightFilter init]):
       
 55797         * platform/graphics/svg/filters/cg/WKTableTransferFilter.m:
       
 55798         (-[WKTableTransferFilter init]):
       
 55799 
       
 55800 2007-01-30  David Hyatt  <hyatt@apple.com>
       
 55801 
       
 55802         Fix for Radar bug #4679426, golden gate bridge Web site layout broken.
       
 55803         
       
 55804         This is a regression caused by the addition of :lang support.  This
       
 55805         feature caused us to accept any pseudo-class/element with function
       
 55806         arguments, even ones we couldn't handle.  The site used such a construct
       
 55807         in conjunction with :not, which turned :not(something-crazy) into not(false).
       
 55808         This ended up being "true", and so we started matching a rule we used to
       
 55809         reject.
       
 55810 
       
 55811         The fix is to now aggressively parse pseudo-elements and classes and to
       
 55812         cause the rejection of an entire rule if any pseudoclass or element within
       
 55813         any simple selector of that rule is unrecognized.
       
 55814 
       
 55815         Reviewed by darin
       
 55816 
       
 55817         fast/css/invalid-pseudo-classes.html
       
 55818 
       
 55819         * css/CSSGrammar.y:
       
 55820         * css/CSSSelector.cpp:
       
 55821         (WebCore::CSSSelector::extractPseudoType):
       
 55822         * css/CSSSelector.h:
       
 55823         (WebCore::CSSSelector::):
       
 55824         * css/cssstyleselector.cpp:
       
 55825         (WebCore::CSSStyleSelector::checkOneSelector):
       
 55826 
       
 55827 2007-01-30  Mitz Pettel  <mitz@webkit.org>
       
 55828 
       
 55829         Reviewed by Darin.
       
 55830 
       
 55831         - fix http://bugs.webkit.org/show_bug.cgi?id=12487
       
 55832           REGRESSION: Repro crash when a second background image is animated
       
 55833 
       
 55834         Test: fast/images/animated-background-image-crash.html
       
 55835 
       
 55836         * rendering/RenderObject.cpp:
       
 55837         (WebCore::RenderObject::arenaDelete): Deref() all background images and the
       
 55838         border image.
       
 55839 
       
 55840 2007-01-30  Darin Adler  <darin@apple.com>
       
 55841 
       
 55842         Reviewed by Maciej.
       
 55843 
       
 55844         * dom/EventTarget.h:
       
 55845         * dom/EventTarget.cpp: (WebCore::EventTarget::toNode):
       
 55846         Use EventTargetNode instead of Node. Removed unneeded includes.
       
 55847         Make EventTarget's destructor protected to make it clear that you
       
 55848         should never delete one.
       
 55849 
       
 55850         * dom/EventTargetNode.h:
       
 55851         (WebCore::EventTargetNode::toNode):
       
 55852         Tweaked formatting. Updated for change to return value.
       
 55853 
       
 55854         * platform/graphics/BitmapImage.h: Updated comment for clarity.
       
 55855         Marked FrameData Noncopyable.
       
 55856 
       
 55857         * platform/graphics/Image.h: Tweaked formatting.
       
 55858 
       
 55859         * platform/graphics/ImageAnimationObserver.h:
       
 55860         Make ImageAnimationObserver's destructor protected to make it clear that you
       
 55861         should never delete one.
       
 55862 
       
 55863 2007-01-30  Mitz Pettel  <mitz@webkit.org>
       
 55864 
       
 55865         Reviewed by Darin (by way of Hyatt).
       
 55866 
       
 55867         - fix http://bugs.webkit.org/show_bug.cgi?id=12373
       
 55868           ASSERTION FAILURE: !child->needsLayout() on paypal.com
       
 55869 
       
 55870         Test: fast/table/inline-form-assert.html
       
 55871 
       
 55872         * rendering/RenderContainer.cpp:
       
 55873         (WebCore::RenderContainer::layout): Changed the assertion to ignore inlines.
       
 55874 
       
 55875 2007-01-30  Alexey Proskuryakov  <ap@webkit.org>
       
 55876 
       
 55877         Reviewed by Darin.
       
 55878 
       
 55879         http://bugs.webkit.org/show_bug.cgi?id=12486
       
 55880         XPathNSResolver.lookupNamespaceURI should return null if no URI is found
       
 55881 
       
 55882         * xml/XPathNSResolver.idl: added [ConvertNullStringTo=Null].
       
 55883 
       
 55884 2007-01-30  Anders Carlsson  <acarlsson@apple.com>
       
 55885 
       
 55886         Reviewed by Maciej.
       
 55887 
       
 55888         Revert the parts of 19244 that removed deferring NSURLConnections, that was not a correct change.
       
 55889         Remove ASSERTS from loader.cpp that aren't true anymore since the callbacks are invoked without a handle
       
 55890         when loading a subresource from an archive.
       
 55891 
       
 55892         * loader/MainResourceLoader.cpp:
       
 55893         (WebCore::MainResourceLoader::loadNow):
       
 55894         * loader/ResourceLoader.cpp:
       
 55895         (WebCore::ResourceLoader::releaseResources):
       
 55896         (WebCore::ResourceLoader::load):
       
 55897         (WebCore::ResourceLoader::setDefersLoading):
       
 55898         * loader/loader.cpp:
       
 55899         (WebCore::Loader::didFail):
       
 55900         (WebCore::Loader::didReceiveResponse):
       
 55901         (WebCore::Loader::didReceiveData):
       
 55902         * platform/network/ResourceHandle.cpp:
       
 55903         (WebCore::ResourceHandle::ResourceHandle):
       
 55904         (WebCore::ResourceHandle::create):
       
 55905         * platform/network/ResourceHandle.h:
       
 55906         * platform/network/ResourceHandleInternal.h:
       
 55907         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
       
 55908         * platform/network/mac/ResourceHandleMac.mm:
       
 55909         (WebCore::ResourceHandle::start):
       
 55910         (WebCore::ResourceHandle::setDefersLoading):
       
 55911 
       
 55912 2007-01-30  Darin Adler  <darin@apple.com>
       
 55913 
       
 55914         Reviewed by John.
       
 55915 
       
 55916         - fix for <rdar://problem/4911504> REGRESSION: With a image selected, ctrl-clicking
       
 55917           on page displays the wrong contextual menu items "Search in Google", "Search in Spotlight"
       
 55918           and "Look up in Dictionary"
       
 55919 
       
 55920         * platform/ContextMenu.cpp:
       
 55921         (WebCore::selectionContainsPossibleWord): Added. Returns true if there are some
       
 55922         non-whitespace characters in the selection.
       
 55923         (WebCore::ContextMenu::populate): Don't add SearchSpotlightItem, SearchWebItem,
       
 55924         or LookInDictionaryItem if selectionContainsPossibleWord returns false.
       
 55925 
       
 55926 2007-01-30  Nikolas Zimmermann  <zimmermann@kde.org>
       
 55927 
       
 55928         Reviewed by Oliver.
       
 55929 
       
 55930         Respect stroke-width in absolute repaint rect calculations for SVG text.
       
 55931         Added test: svg/custom/text-repaint-including-stroke.svg
       
 55932 
       
 55933         * rendering/RenderSVGText.cpp:
       
 55934         (WebCore::RenderSVGText::relativeBBox):
       
 55935 
       
 55936 2007-01-30  Steve Falkenburg  <sfalken@apple.com>
       
 55937 
       
 55938         Reviewed by Oliver.
       
 55939 
       
 55940         Add missing includes.
       
 55941 
       
 55942         * ksvg2/svg/SVGElementInstance.cpp:
       
 55943 
       
 55944 2007-01-30  Alexey Proskuryakov  <ap@webkit.org>
       
 55945 
       
 55946         Reviewed by Darin.
       
 55947 
       
 55948         http://bugs.webkit.org/show_bug.cgi?id=12452
       
 55949         XPath id() function is not supported
       
 55950 
       
 55951         * xml/XPathFunctions.cpp:
       
 55952         (WebCore::XPath::isWhitespace): A helper to detect XML whitespace.
       
 55953 
       
 55954         (WebCore::XPath::FunId::isConstant):
       
 55955         (WebCore::XPath::FunId::doEvaluate):
       
 55956         (WebCore::XPath::FunctionMapping::):
       
 55957         Implemented id().
       
 55958 
       
 55959 2007-01-30  Zack Rusin  <zrusin@trolltech.com>
       
 55960 
       
 55961         Reviewed by Sam.
       
 55962 
       
 55963         Make the gradients work on the Qt platform.
       
 55964 
       
 55965         * platform/graphics/svg/SVGPaintServerGradient.h:
       
 55966         * platform/graphics/svg/SVGPaintServerLinearGradient.h:
       
 55967         * platform/graphics/svg/SVGPaintServerRadialGradient.h:
       
 55968         * platform/graphics/svg/qt/SVGPaintServerGradientQt.cpp:
       
 55969         (WebCore::SVGPaintServerGradient::fillColorArray):
       
 55970         (WebCore::SVGPaintServerGradient::setup):
       
 55971         * platform/graphics/svg/qt/SVGPaintServerLinearGradientQt.cpp:
       
 55972         (WebCore::SVGPaintServerLinearGradient::setupGradient):
       
 55973         * platform/graphics/svg/qt/SVGPaintServerRadialGradientQt.cpp:
       
 55974         (WebCore::SVGPaintServerRadialGradient::setupGradient):
       
 55975 
       
 55976 2007-01-30  Nikolas Zimmermann  <zimmermann@kde.org>
       
 55977 
       
 55978         Reviewed by Eric & Oliver. Leak related fixes reviewed by Mark.
       
 55979 
       
 55980         Finally make the SVG <use> implementation use the proper "shadow tree" concept,
       
 55981         which is also used by the HTML forms implementation. It's the first time in ksvg
       
 55982         history that <use> is not implement as a crude hack, but proper & sane.
       
 55983 
       
 55984         Implement deep expansion of use trees both for the instance & shadow tree.
       
 55985         (<use> on a <symbol> containing a <g> containg a <use> element referencing a <rect>)
       
 55986  
       
 55987         The shadow tree is free of any symbol/use tags, but is properly expanded to the
       
 55988         actual referenced content. The instance tree (SVGElementInstance objects) now exactly
       
 55989         exposes the "expanded" shadow tree, as required by the specification. Previously
       
 55990         we cloned referenced <use> elements, so our faked use shadow tree itself contained
       
 55991         <use> elements. That lead to very nasty bugs - finally these dirty pieces are gone.
       
 55992 
       
 55993         Checked twice that the updating logic works for all weird "deep expansions" cases. Example:
       
 55994         <rect id="someRect"/> <g id="g"> <symbol> <use xlink:href="#someRect"/> </g> <use xlink:href="#g" id="use"/>
       
 55995  
       
 55996         If you walk through the instanceRoot using JavasScript, and explicitely modify some propertties of "someRect"
       
 55997         -> all instances get updated correctly. For such simple cases it doesn't even involve recloning the shadow tree!
       
 55998 
       
 55999         SVGElementInstance is now an EventTarget, as demanded by the specification - sending events to <use> instances
       
 56000         will be implemented in a follow-up patch - as well as the "share event listeners with referenced target" logic.
       
 56001 
       
 56002         Fixes all updating/stability issues with svg/carto.net/window.svg.
       
 56003         Fixes: http://bugs.webkit.org/show_bug.cgi?id=6000 (<use> does not handle recursion safely)
       
 56004 
       
 56005         Added test: svg/custom/use-on-use.svg (deep use referencing)
       
 56006         Added test: svg/custom/use-on-g-containing-use.svg (nested deep use referencing)
       
 56007         Added test: svg/custom/use-modify-target-container.svg (instanceRoot scripting, modifying <g> target)
       
 56008         Added test: svg/custom/use-modify-target-symbol.svg (instanceRoot scripting, modfiying <symbol> target)
       
 56009         Added test: svg/custom/use-modify-container-in-target.svg (modify <g> within referenced use target -> needs to update instances)
       
 56010         Added test: svg/custom/use-recursion-1.svg (referencing container, whose children reference itself)
       
 56011         Added test: svg/custom/use-recursion-2.svg (<use> self referencing)
       
 56012         Added test: svg/custom/use-recursion-3.svg (<use> self rerencing, within <use> target)
       
 56013         Added test: svg/custom/use-recursion-4.svg (cyclic referencing, within <use> target)
       
 56014 
       
 56015         * bindings/scripts/CodeGeneratorJS.pm:
       
 56016         * css/cssstyleselector.cpp:
       
 56017         (WebCore::CSSStyleSelector::initForStyleResolve):
       
 56018         (WebCore::CSSStyleSelector::adjustRenderStyle):
       
 56019         * ksvg2/misc/SVGDocumentExtensions.cpp:
       
 56020         (WebCore::SVGDocumentExtensions::removeTimeContainer):
       
 56021         * ksvg2/svg/SVGElement.cpp:
       
 56022         (WebCore::SVGElement::SVGElement):
       
 56023         (WebCore::SVGElement::viewportElement):
       
 56024         * ksvg2/svg/SVGElement.h:
       
 56025         (WebCore::SVGElement::isShadowNode):
       
 56026         (WebCore::SVGElement::shadowParentNode):
       
 56027         (WebCore::SVGElement::setShadowParentNode):
       
 56028         * ksvg2/svg/SVGElementInstance.cpp:
       
 56029         (WebCore::SVGElementInstance::SVGElementInstance):
       
 56030         (WebCore::SVGElementInstance::correspondingUseElement):
       
 56031         (WebCore::SVGElementInstance::shadowTreeElement):
       
 56032         (WebCore::SVGElementInstance::setShadowTreeElement):
       
 56033         (WebCore::containsUseChildNode):
       
 56034         (WebCore::SVGElementInstance::updateInstance):
       
 56035         (WebCore::SVGElementInstance::addEventListener):
       
 56036         (WebCore::SVGElementInstance::removeEventListener):
       
 56037         (WebCore::SVGElementInstance::dispatchEvent):
       
 56038         * ksvg2/svg/SVGElementInstance.h:
       
 56039         (WebCore::SVGElementInstance::refEventTarget):
       
 56040         (WebCore::SVGElementInstance::derefEventTarget):
       
 56041         (WebCore::SVGElementInstance::hasOneRef):
       
 56042         (WebCore::SVGElementInstance::refCount):
       
 56043         (WebCore::SVGElementInstance::setParent):
       
 56044         (WebCore::SVGElementInstance::parent):
       
 56045         * ksvg2/svg/SVGElementInstance.idl:
       
 56046         * ksvg2/svg/SVGGElement.cpp:
       
 56047         (WebCore::SVGGElement::localMatrix):
       
 56048         * ksvg2/svg/SVGGElement.h:
       
 56049         * ksvg2/svg/SVGHiddenElement.h: Removed.
       
 56050         * ksvg2/svg/SVGSVGElement.cpp:
       
 56051         (WebCore::SVGSVGElement::~SVGSVGElement):
       
 56052         * ksvg2/svg/SVGStyledElement.cpp:
       
 56053         (WebCore::SVGStyledElement::updateElementInstance):
       
 56054         * ksvg2/svg/SVGUseElement.cpp:
       
 56055         (WebCore::SVGUseElement::removedFromDocument):
       
 56056         (WebCore::SVGUseElement::notifyAttributeChange):
       
 56057         (WebCore::dumpInstanceTree):
       
 56058         (WebCore::SVGUseElement::buildPendingResource):
       
 56059         (WebCore::SVGUseElement::attach):
       
 56060         (WebCore::SVGUseElement::buildInstanceTree):
       
 56061         (WebCore::SVGUseElement::handleDeepUseReferencing):
       
 56062         (WebCore::SVGUseElement::buildShadowTree):
       
 56063         (WebCore::SVGUseElement::expandUseElementsInShadowTree):
       
 56064         (WebCore::SVGUseElement::attachShadowTree):
       
 56065         (WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):
       
 56066         (WebCore::SVGUseElement::transferUseAttributesToReplacedElement):
       
 56067         * ksvg2/svg/SVGUseElement.h:
       
 56068 
       
 56069 2007-01-30  Maciej Stachowiak  <mjs@apple.com>
       
 56070 
       
 56071         Reviewed by Eric.
       
 56072 
       
 56073         <rdar://problem/4928646> REGRESSION: manual-tests/remove-input-file-onchange.html crashes
       
 56074         
       
 56075         * platform/FileChooser.h:
       
 56076         (WebCore::FileChooser::disconnected): New method, so the RenderFileControl can tell when it's
       
 56077         gotten disconected.
       
 56078         * rendering/RenderFileUploadControl.cpp:
       
 56079         (WebCore::RenderFileUploadControl::valueChanged): Avoid calling repainted() when onChange()
       
 56080         handler destroyed us.
       
 56081 
       
 56082 2007-01-30  Simon Hausmann  <hausmann@kde.org>
       
 56083 
       
 56084         Reviewed by Zack.
       
 56085 
       
 56086         Combine libJavaScriptCore into libWebKitQt.
       
 56087         Build with ELF visibility if possible.
       
 56088 
       
 56089         * WebCore.pro:
       
 56090 
       
 56091 2007-01-30  Zack Rusin  <zack@kde.org>
       
 56092 
       
 56093         The method has been removed from the header
       
 56094         (make it compile)
       
 56095 
       
 56096         * platform/network/qt/ResourceHandleQt.cpp:
       
 56097 
       
 56098 2007-01-30  Zack Rusin  <zrusin@trolltech.com>
       
 56099 
       
 56100         Reviewed by aroben
       
 56101 
       
 56102         Compile fix. 
       
 56103 
       
 56104         * loader/ResourceLoader.cpp:
       
 56105         (WebCore::ResourceLoader::releaseResources):
       
 56106         (WebCore::ResourceLoader::setDefersLoading):
       
 56107 
       
 56108 2007-01-29  Zack Rusin  <zack@kde.org>
       
 56109 
       
 56110         Reviewed by Lars
       
 56111 
       
 56112         Propagate the allows-scrolling property on the frames
       
 56113         correctly. If the frame has been constructed as non-
       
 56114         scrolling, respect that and don't show scrollbars.
       
 56115 
       
 56116         * platform/ScrollView.h:
       
 56117         * platform/qt/ScrollViewQt.cpp:
       
 56118         (WebCore::ScrollView::ScrollView):
       
 56119         (WebCore::ScrollView::setHScrollbarMode):
       
 56120         (WebCore::ScrollView::setVScrollbarMode):
       
 56121         (WebCore::ScrollView::setAllowsScrolling):
       
 56122 
       
 56123 2007-01-29  Geoffrey Garen  <ggaren@apple.com>
       
 56124 
       
 56125         I am the chosen one! I have seen the faces of the final five! I will
       
 56126         save the WebKit build!
       
 56127         
       
 56128         * loader/ResourceLoader.cpp:
       
 56129         (WebCore::ResourceLoader::load):
       
 56130 
       
 56131 2007-01-30  Graham Dennis  <graham.dennis@gmail.com>
       
 56132 
       
 56133         Reviewed by Maciej.
       
 56134 
       
 56135         Part of fix for http://bugs.webkit.org/show_bug.cgi?id=10725
       
 56136         Image data in from RTFD clipboard data thrown away
       
 56137         
       
 56138         ResourceHandles no longer need to be able to defer loading as that is
       
 56139         now handled by the ResourceLoader.
       
 56140 
       
 56141         * loader/MainResourceLoader.cpp:
       
 56142         (WebCore::MainResourceLoader::loadNow): updated to remove defersLoading argument.
       
 56143         * loader/ResourceLoader.cpp:
       
 56144         (WebCore::ResourceLoader::releaseResources): release the deferred request.
       
 56145         (WebCore::ResourceLoader::load): defer creating the ResourceHandle instead of
       
 56146         asking the ResourceHandle to defer loading.
       
 56147         (WebCore::ResourceLoader::setDefersLoading): create the ResourceHandle if we have deferred creating it.
       
 56148         * loader/ResourceLoader.h:
       
 56149         * platform/network/ResourceHandle.cpp: ResourceHandle's don't need to know about deferLoading.
       
 56150         (WebCore::ResourceHandle::ResourceHandle):
       
 56151         (WebCore::ResourceHandle::create):
       
 56152         * platform/network/ResourceHandle.h: ditto.
       
 56153         * platform/network/ResourceHandleInternal.h: ditto.
       
 56154         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
       
 56155         * platform/network/mac/ResourceHandleMac.mm: ditto.
       
 56156         (WebCore::ResourceHandle::start):
       
 56157 
       
 56158 2007-01-29  Brady Eidson  <beidson@apple.com>
       
 56159 
       
 56160         Reviewed by Alice
       
 56161 
       
 56162         Lets use smart pointers, shall we?
       
 56163 
       
 56164         * platform/network/ResourceHandleInternal.h:
       
 56165 
       
 56166 2007-01-29  Justin Garcia  <justin.garcia@apple.com>
       
 56167 
       
 56168         Reviewed by harrison
       
 56169         
       
 56170         <rdar://problem/4960137>
       
 56171         ASSERTION FAILURE calling SelectionController::setBaseAndExtent (11833)
       
 56172 
       
 56173         * editing/SelectionController.cpp:
       
 56174         (WebCore::SelectionController::setSelection): Hand off the selection
       
 56175         to the selectionController responsible for it, instead of asserting.
       
 56176         A selection object can't be constructed with endpoints in different 
       
 56177         documents, so this code is only necessary for one endpoint.
       
 56178 
       
 56179 2007-01-29  Ada Chan  <adachan@apple.com>
       
 56180 
       
 56181         Reviewed by Brady.
       
 56182         
       
 56183         Moved the update of the title of the current entry in the backforward list to WebCore.
       
 56184 
       
 56185         * loader/FrameLoader.cpp:
       
 56186         (WebCore::FrameLoader::didChangeTitle):
       
 56187 
       
 56188 2007-01-29  Adele Peterson  <adele@apple.com>
       
 56189 
       
 56190         Reviewed by Darin.
       
 56191 
       
 56192         More preparation for event handling fixes.
       
 56193 
       
 56194         * bridge/EditorClient.h: Removed EventTargetNode parameter from handleKeyPress since we can just get that from the event.
       
 56195         * dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): ditto.
       
 56196         * page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): ditto.
       
 56197         * page/EventHandler.h: ditto.
       
 56198         * platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::handleKeyPress): ditto.
       
 56199 
       
 56200         * editing/Editor.h:
       
 56201         * editing/Editor.cpp:
       
 56202         (WebCore::Editor::handleKeyPress): Removed EventTargetNode parameter.
       
 56203         (WebCore::Editor::execCommand): Made commandMap use AtomicStringImpls instead of Strings.
       
 56204         (WebCore::Editor::insertText): Moved from the bridge.
       
 56205 
       
 56206         * page/mac/WebCoreFrameBridge.h: Moved insertText method to Editor.
       
 56207         * page/mac/WebCoreFrameBridge.mm:
       
 56208 
       
 56209         * WebCore.exp: Updated exports.
       
 56210 
       
 56211 2007-01-29  Anders Carlsson  <acarlsson@apple.com>
       
 56212 
       
 56213         Reviewed by Geoff.
       
 56214 
       
 56215         <rdar://problem/4960097>
       
 56216         http://bugs.webkit.org/show_bug.cgi?id=12444
       
 56217         Assertion failure in -[WebCoreFrameBridge installInFrame:]
       
 56218         
       
 56219         The problem was that the XML tokenizer didn't create elements with 
       
 56220         createdByParser set to true.
       
 56221         
       
 56222         * dom/Document.cpp:
       
 56223         (WebCore::Document::createElement):
       
 56224         New method which takes a QName. This is used by both the XML tokenizer and createElementNS.
       
 56225         
       
 56226         (WebCore::Document::createElementNS):
       
 56227         Call new createElement method.
       
 56228         
       
 56229         * dom/XMLTokenizer.h:        
       
 56230         * dom/XMLTokenizer.cpp:
       
 56231         (WebCore::XMLTokenizer::XMLTokenizer):
       
 56232         (WebCore::XMLTokenizer::~XMLTokenizer):
       
 56233         Use an OwnPtr for the pending callbacks object. Also, use String instead of StringImpl in the hash map.
       
 56234         
       
 56235         (WebCore::toString):
       
 56236         (WebCore::XMLTokenizer::startElementNs):
       
 56237         Call createElement.
       
 56238         
       
 56239 2007-01-29  Brady Eidson  <beidson@apple.com>
       
 56240 
       
 56241         Reviewed by Oliver
       
 56242 
       
 56243         http://bugs.webkit.org/show_bug.cgi?id=12465
       
 56244         Only set the iconURL port for non-zero ports
       
 56245 
       
 56246         * loader/FrameLoader.cpp:
       
 56247         (WebCore::FrameLoader::iconURL):
       
 56248 
       
 56249 2007-01-29  John Sullivan  <sullivan@apple.com>
       
 56250 
       
 56251         * platform/network/mac/ResourceRequestMac.mm:
       
 56252         Build fix -- removed #import of no-longer-extant WebDataProtocol.h (and also one of the
       
 56253         two #imports for WebCoreSystemInterface.h, while I was at it)
       
 56254 
       
 56255 2007-01-29  Anders Carlsson  <acarlsson@apple.com>
       
 56256 
       
 56257         Reviewed by Oliver.
       
 56258 
       
 56259         * page/DragController.cpp:
       
 56260         (WebCore::DragController::dragEnteredOrUpdated):
       
 56261         Only try a drag operation if the drag client explicitly specified that it is OK
       
 56262 
       
 56263 2007-01-29  Oliver Hunt  <oliver@apple.com>
       
 56264 
       
 56265         Reviewed by Adam.
       
 56266 
       
 56267         Migrated more drag logic and state to WebCore
       
 56268                                               
       
 56269         * page/DragClient.h:       
       
 56270 
       
 56271         * page/DragController.cpp:
       
 56272         (WebCore::DragController::delegateDragSourceAction):
       
 56273           New forwarding method for the UI delegate
       
 56274         * page/DragController.h:
       
 56275         (WebCore::DragController::dragOffset):
       
 56276           Now store the drag offset -- the offset of the cursor relative to the drag image)
       
 56277           in DragController
       
 56278         * page/EventHandler.cpp:
       
 56279         (WebCore::EventHandler::allowDHTMLDrag):
       
 56280           Moved from WebFrameBridge
       
 56281         * page/EventHandler.h:
       
 56282         * page/mac/EventHandlerMac.mm:
       
 56283         (WebCore::EventHandler::eventMayStartDrag):
       
 56284         (WebCore::EventHandler::handleDrag):                  
       
 56285           EventHandlerMac now uses EventHandler::allowDHTMLDrag rather than the 
       
 56286           implementation in WebFrameBridge
       
 56287         * page/mac/WebCoreFrameBridge.h:
       
 56288           removed definition of allowDHTMLDrag from WebFrameBridge
       
 56289         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 56290         (WebCore::SVGEmptyDragClient::dragSourceActionMaskForPoint):
       
 56291           Updated empty DragClient
       
 56292 
       
 56293 2007-01-29  Alexey Proskuryakov  <ap@webkit.org>
       
 56294 
       
 56295         Reviewed by Darin.
       
 56296 
       
 56297         http://bugs.webkit.org/show_bug.cgi?id=12359
       
 56298         XPathEvaluator may return some nodes more than once in a result set
       
 56299 
       
 56300         Test: fast/xpath/nodeset-duplicates.html
       
 56301 
       
 56302         * xml/XPathPath.cpp:
       
 56303         (WebCore::XPath::LocationPath::doEvaluate): Ensure uniqueness of elements
       
 56304         in the node-set.
       
 56305 
       
 56306         * xml/XPathPredicate.cpp:
       
 56307         (WebCore::XPath::Union::doEvaluate): Fixed a uniqueness algorithm that was
       
 56308         already present here. Added a FIXME about incorrect result ordering.
       
 56309 
       
 56310 2007-01-29  Alexey Proskuryakov  <ap@webkit.org>
       
 56311 
       
 56312         Reviewed by Darin.
       
 56313 
       
 56314         http://bugs.webkit.org/show_bug.cgi?id=12340
       
 56315         XPathEvaluator behavior does not match Firefox - name() and attribute nodes
       
 56316 
       
 56317         * xml/XPathFunctions.cpp:
       
 56318         (WebCore::XPath::FunName::doEvaluate): Do not try to append a prefix if it doesn't exist.
       
 56319 
       
 56320 2007-01-29  Alexey Proskuryakov  <ap@webkit.org>
       
 56321 
       
 56322         Reviewed by Darin.
       
 56323 
       
 56324         http://bugs.webkit.org/show_bug.cgi?id=11815
       
 56325         XPathEvaluator behavior does not match Firefox - substring() and empty element
       
 56326 
       
 56327         Test: fast/xpath/empty-string-substring.html
       
 56328 
       
 56329         * xml/XPathValue.cpp:
       
 56330         (WebCore::XPath::Value::Value):
       
 56331         * xml/XPathValue.h:
       
 56332         Added a constructor taking const char*, so that string literals and arrays don't 
       
 56333         get converted to boolean values.
       
 56334 
       
 56335 2007-01-29  Zack Rusin  <zrusin@trolltech.com>
       
 56336 
       
 56337         Cosmetic fixes - don't resize the widget in the constructor
       
 56338         (it was a hack from the initial port) and fix the paint
       
 56339         signature.
       
 56340 
       
 56341         * platform/qt/ScrollViewCanvasQt.cpp:
       
 56342         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
       
 56343         * platform/qt/WidgetQt.cpp:
       
 56344         (WebCore::Widget::paint):
       
 56345 
       
 56346 2007-01-29  Maciej Stachowiak  <mjs@apple.com>
       
 56347 
       
 56348         - change from struct to class to make picky compilers happy
       
 56349 
       
 56350         * loader/SubstituteData.h:
       
 56351 
       
 56352 2007-01-30  Mark Rowe  <mrowe@apple.com>
       
 56353 
       
 56354         Reviewed by Maciej.
       
 56355 
       
 56356         http://bugs.webkit.org/show_bug.cgi?id=12458
       
 56357         Bug 12458: Crash in W3C-SVG-1.1/animate-elem-09-t.svg running layout tests under guard malloc
       
 56358 
       
 56359         * ksvg2/svg/SVGAnimationElement.cpp: 
       
 56360         (WebCore::parseValues): ptr either points to a ';' or off the end of the buffer.  We're
       
 56361         interested in what comes before the ';', so start there instead.
       
 56362 
       
 56363 2007-01-29  Zack Rusin  <zrusin@trolltech.com>
       
 56364 
       
 56365         Reviewed by Lars.
       
 56366 
       
 56367         Take the scrollbars into considation when computing
       
 56368         the contents size of the main frame.
       
 56369 
       
 56370         * platform/qt/PlatformScrollBarQt.cpp:
       
 56371         (WebCore::PlatformScrollbar::paint):
       
 56372         * platform/qt/ScrollViewQt.cpp:
       
 56373         (WebCore::ScrollView::visibleWidth):
       
 56374         (WebCore::ScrollView::visibleHeight):
       
 56375         (WebCore::ScrollView::visibleContentRect):
       
 56376         * platform/qt/WidgetQt.cpp:
       
 56377         (WebCore::Widget::invalidate):
       
 56378         (WebCore::Widget::invalidateRect):
       
 56379 
       
 56380 2007-01-29  Maciej Stachowiak  <mjs@apple.com>
       
 56381 
       
 56382         - fix includes
       
 56383 
       
 56384         * loader/SubstituteData.h:
       
 56385 
       
 56386 2007-01-29  Maciej Stachowiak  <mjs@apple.com>
       
 56387 
       
 56388         - added new file that I forgot in the last commit
       
 56389 
       
 56390         * loader/SubstituteData.h: Added.
       
 56391         (WebCore::SubstituteData::SubstituteData):
       
 56392         (WebCore::SubstituteData::isValid):
       
 56393         (WebCore::SubstituteData::content):
       
 56394         (WebCore::SubstituteData::mimeType):
       
 56395         (WebCore::SubstituteData::textEncoding):
       
 56396         (WebCore::SubstituteData::failingURL):
       
 56397 
       
 56398 2007-01-29  Maciej Stachowiak  <mjs@apple.com>
       
 56399 
       
 56400         Reviewed by Mark.
       
 56401 
       
 56402         - made data loading cross-platform
       
 56403         - fixed <rdar://problem/4910106>
       
 56404 
       
 56405         * WebCore.exp:
       
 56406         * WebCore.xcodeproj/project.pbxproj:
       
 56407         * loader/CachedResource.cpp:
       
 56408         * loader/CachedResource.h:
       
 56409         * loader/DocLoader.cpp:
       
 56410         (WebCore::DocLoader::requestResource):
       
 56411         * loader/DocumentLoader.cpp:
       
 56412         (WebCore::DocumentLoader::DocumentLoader):
       
 56413         (WebCore::DocumentLoader::setRequest):
       
 56414         (WebCore::DocumentLoader::urlForHistory):
       
 56415         (WebCore::DocumentLoader::unreachableURL):
       
 56416         * loader/DocumentLoader.h:
       
 56417         (WebCore::DocumentLoader::substituteData):
       
 56418         * loader/FrameLoader.cpp:
       
 56419         (WebCore::FrameLoader::load):
       
 56420         (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
       
 56421         (WebCore::FrameLoader::reloadAllowingStaleData):
       
 56422         (WebCore::FrameLoader::reload):
       
 56423         (WebCore::FrameLoader::commitProvisionalLoad):
       
 56424         (WebCore::FrameLoader::startLoadingMainResource):
       
 56425         (WebCore::FrameLoader::startLoading):
       
 56426         (WebCore::FrameLoader::checkNavigationPolicy):
       
 56427         * loader/FrameLoader.h:
       
 56428         * loader/FrameLoaderClient.h:
       
 56429         * loader/MainResourceLoader.cpp:
       
 56430         (WebCore::MainResourceLoader::willSendRequest):
       
 56431         (WebCore::MainResourceLoader::continueAfterContentPolicy):
       
 56432         (WebCore::MainResourceLoader::handleEmptyLoad):
       
 56433         (WebCore::MainResourceLoader::handleDataLoad):
       
 56434         (WebCore::MainResourceLoader::loadNow):
       
 56435         (WebCore::MainResourceLoader::load):
       
 56436         * loader/MainResourceLoader.h:
       
 56437         * loader/mac/DocumentLoaderMac.mm:
       
 56438         * loader/mac/WebDataProtocol.h: Removed.
       
 56439         * loader/mac/WebDataProtocol.mm: Removed.
       
 56440         * loader/qt/DocumentLoaderQt.cpp:
       
 56441         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 56442         (WebCore::SVGEmptyFrameLoaderClient::createDocumentLoader):
       
 56443 
       
 56444 2007-01-29  Zack Rusin  <zrusin@trolltech.com>
       
 56445 
       
 56446         Order the build files alphabetically instead of
       
 56447         the random mess we had before.
       
 56448 
       
 56449         * WebCore.pro:
       
 56450 
       
 56451 2007-01-29  Zack Rusin  <zack@kde.org>
       
 56452 
       
 56453         Reviewed by Lars
       
 56454 
       
 56455         Use the platform independent scrollbar code.
       
 56456         Remove the redundant empty stubs and forward
       
 56457         few missing platform scrollbar calls.
       
 56458 
       
 56459         * WebCore.pro:
       
 56460         * platform/qt/PlatformScrollBarQt.cpp:
       
 56461         (WebCore::PlatformScrollbar::paint):
       
 56462         (WebCore::PlatformScrollbar::setRect):
       
 56463 
       
 56464 2007-01-29  Lars Knoll <lars@trolltech.com>
       
 56465 
       
 56466         Reviewed by Zack
       
 56467 
       
 56468         Fix the way we handle native widgets (QWidget) inside
       
 56469         WebCore. Now WebCore::Widget owns the QWidget in all
       
 56470         cases. This is the only way to get well defined semantics
       
 56471         for all teh native widgets we have (currently ScrollView
       
 56472         and ScrollBar, but plugins will follow).
       
 56473 
       
 56474         This has the side effect that one cannot rely on a defined 
       
 56475         lifetime of a QWebFrame when using the API. 
       
 56476 
       
 56477         * platform/Widget.h:
       
 56478         * platform/qt/PlatformScrollBarQt.cpp:
       
 56479         (WebCore::PlatformScrollbar::PlatformScrollbar):
       
 56480         * platform/qt/ScrollViewQt.cpp:
       
 56481         (WebCore::ScrollView::addChild):
       
 56482         (WebCore::ScrollView::removeChild):
       
 56483         * platform/qt/WidgetQt.cpp:
       
 56484         (WebCore::WidgetPrivate::WidgetPrivate):
       
 56485         (WebCore::WidgetPrivate::~WidgetPrivate):
       
 56486         (WebCore::Widget::qwidget):
       
 56487 
       
 56488 2007-01-28  George Staikos  <staikos@kde.org>
       
 56489 
       
 56490         Reviewed by Maciej.
       
 56491 
       
 56492         Don't send data during a redirect -> causes assert failure.
       
 56493 
       
 56494         * platform/network/qt/ResourceHandleManagerQt.cpp:
       
 56495         (WebCore::ResourceHandleManager::receivedData):
       
 56496 
       
 56497 2007-01-29  Mark Rowe  <mrowe@apple.com>
       
 56498 
       
 56499         Reviewed by Brady.
       
 56500 
       
 56501         http://bugs.webkit.org/show_bug.cgi?id=11085
       
 56502         Bug 11085: REGRESSION: favicon.ico always looked for on port 80
       
 56503 
       
 56504         * loader/FrameLoader.cpp:
       
 56505         (WebCore::FrameLoader::iconURL): Copy the port over to the favicon URL.
       
 56506 
       
 56507 2007-01-28  Adam Roben  <aroben@apple.com>
       
 56508 
       
 56509         Reviewed by Adele.
       
 56510 
       
 56511         Fix http://bugs.webkit.org/show_bug.cgi?id=12453
       
 56512         REGRESSION(r19197): Tabbing into web page requires two key presses
       
 56513 
       
 56514         All layout tests pass.
       
 56515 
       
 56516         * page/FocusController.cpp:
       
 56517         (WebCore::FocusController::advanceFocus): If there's no focused frame,
       
 56518         actually go ahead and find a focusable node instead of just focusing
       
 56519         the main frame and quitting. This behavior was a holdover from a
       
 56520         previous desired tabbing behavior with respect to frames.
       
 56521 
       
 56522 2007-01-28  David Kilzer  <ddkilzer@webkit.org>
       
 56523 
       
 56524         Reviewed by Darin and David Hyatt.
       
 56525 
       
 56526         - fix http://bugs.webkit.org/show_bug.cgi?id=12423
       
 56527           Mixing white-space:pre text with non white-space:pre text does not wrap properly
       
 56528 
       
 56529         Test: fast/block/basic/white-space-pre-wraps.html
       
 56530 
       
 56531         * rendering/bidi.cpp:
       
 56532         (WebCore::RenderBlock::findNextLineBreak): Wrap a non-wrapping text run if it
       
 56533         appears on a line with previous text runs that do wrap.
       
 56534 
       
 56535 2007-01-28  Mitz Pettel  <mitz@webkit.org>
       
 56536 
       
 56537         Reviewed by Darin.
       
 56538 
       
 56539         - fix http://bugs.webkit.org/show_bug.cgi?id=8360
       
 56540           Repro crash when onscroll handler deletes the scrolled object
       
 56541 
       
 56542         Test: fast/layers/removed-by-scroll-handler.html
       
 56543 
       
 56544         * page/FrameView.cpp:
       
 56545         (WebCore::FrameViewPrivate::FrameViewPrivate): Added a m_enqueueEvents count.
       
 56546         (WebCore::FrameView::layout): Raise the enqueue count before starting layout and
       
 56547         until after enqueued events are dispatched.
       
 56548         (WebCore::FrameView::scheduleEvent): Made this function dispatch the event
       
 56549         immediately unless the enqueue count is positive.
       
 56550         * rendering/RenderLayer.cpp:
       
 56551         (WebCore::RenderLayer::scrollToOffset): Schedule the scroll event through the
       
 56552         FrameView.
       
 56553         (WebCore::RenderLayer::scrollRectToVisible):
       
 56554         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
       
 56555         (WebCore::Marquee::start):
       
 56556 
       
 56557 2007-01-28  Charles Ying  <charles_ying@yahoo.com>
       
 56558 
       
 56559         Reviewed by eseidel.  Landed by eseidel.
       
 56560 
       
 56561         Fix http://bugs.webkit.org/show_bug.cgi?id=12429
       
 56562             animateTransform rotate, with cx/cy is broken
       
 56563             
       
 56564         SVGTransform now contains a float point to store the rotation center, needed
       
 56565             to track rotation center for interpolation by animateTransform.
       
 56566             
       
 56567         SVGTransform now has an additional constructor:
       
 56568             SVGTransform(type) to make empty base value transforms that match their
       
 56569             distanced values.
       
 56570             
       
 56571         Removed m_colorDistance and m_transformDistance from their respective classes
       
 56572             as they are now computed at update time.
       
 56573 
       
 56574         Fix a case where animateTransform did not parse transform values correctly
       
 56575             according to BNF in W3C spec:
       
 56576 
       
 56577         Test case in:
       
 56578         * manual-tests/animation/animateTransform-toanimation.svg: Added.
       
 56579 
       
 56580         Fix a case where animateTransform only specified a to animation only.
       
 56581 
       
 56582         Test case in:
       
 56583         * manual-tests/animation/animateTransform-parser.svg: Added.
       
 56584 
       
 56585         * ksvg2/svg/SVGAnimateColorElement.cpp:
       
 56586         (WebCore::SVGAnimateColorElement::updateAnimationBaseValueFromElement):
       
 56587         (WebCore::SVGAnimateColorElement::updateAnimatedValue):
       
 56588         (WebCore::SVGAnimateColorElement::calculateFromAndToValues):
       
 56589         * ksvg2/svg/SVGAnimateColorElement.h:
       
 56590         * ksvg2/svg/SVGAnimateTransformElement.cpp:
       
 56591         (WebCore::SVGAnimateTransformElement::updateAnimatedValue):
       
 56592         (WebCore::SVGAnimateTransformElement::updateAnimationBaseValueFromElement):
       
 56593         (WebCore::SVGAnimateTransformElement::calculateFromAndToValues):
       
 56594         (WebCore::SVGAnimateTransformElement::parseTransformValue):
       
 56595         * ksvg2/svg/SVGAnimateTransformElement.h:
       
 56596         * ksvg2/svg/SVGTransform.cpp:
       
 56597         (SVGTransform::SVGTransform):
       
 56598         (SVGTransform::angle):
       
 56599         (SVGTransform::rotationCenter):
       
 56600         (SVGTransform::setTranslate):
       
 56601         (SVGTransform::setScale):
       
 56602         (SVGTransform::setRotate):
       
 56603         (SVGTransform::setSkewX):
       
 56604         (SVGTransform::setSkewY):
       
 56605         * ksvg2/svg/SVGTransform.h:
       
 56606         * ksvg2/svg/SVGTransformDistance.cpp:
       
 56607         (WebCore::SVGTransformDistance::SVGTransformDistance):
       
 56608         (WebCore::SVGTransformDistance::scaledDistance):
       
 56609         (WebCore::SVGTransformDistance::addSVGTransforms):
       
 56610         (WebCore::SVGTransformDistance::addSVGTransform):
       
 56611         (WebCore::SVGTransformDistance::addToSVGTransform):
       
 56612         (WebCore::SVGTransformDistance::distance):
       
 56613         * ksvg2/svg/SVGTransformDistance.h:
       
 56614         * manual-tests/animation/animateTransform-parser.svg: Added.
       
 56615         * manual-tests/animation/animateTransform-toanimation.svg: Added.
       
 56616 
       
 56617 2007-01-27  Adam Roben  <aroben@apple.com>
       
 56618 
       
 56619         Reviewed by Ada.
       
 56620 
       
 56621         Fix <rdar://problem/4957184> REGRESSION: After creating a new mail
       
 56622         message, the caret is automatically in message body
       
 56623 
       
 56624         -[WebHTMLView _updateActiveState] was calling
       
 56625         FocusController::focusedOrMainFrame, which had the surprising
       
 56626         side-effect of setting the focused frame if there was none. The fix
       
 56627         was to remove this side-effect.
       
 56628 
       
 56629         No tests possible, as this bug involves focus outside the WebView,
       
 56630         which we have no support for in DRT.
       
 56631 
       
 56632         Change inspired by Dave Harrison.
       
 56633 
       
 56634         * page/FocusController.cpp:
       
 56635         (WebCore::FocusController::focusedOrMainFrame): Removed this method's
       
 56636         non-obvious side-effect of setting the focused frame.
       
 56637         * WebCore.xcodeproj/project.pbxproj: Version wars.
       
 56638 
       
 56639 2007-01-27  Don Gibson  <dgibson77@gmail.com>
       
 56640 
       
 56641         Reviewed by Maciej.
       
 56642 
       
 56643         http://bugs.webkit.org/show_bug.cgi?id=11880: Improve some egregious
       
 56644         Windows form control drawing issues:
       
 56645         Provide Classic mode fallbacks for the button/textfield drawing
       
 56646         routines.
       
 56647         Provide some basic drawing of menulists (still relatively broken).
       
 56648         Some cleanup.
       
 56649 
       
 56650         * platform/win/TemporaryLinkStubs.cpp:
       
 56651         (WebCore::RenderThemeWin::systemFont):
       
 56652         * rendering/RenderThemeWin.cpp:
       
 56653         (WebCore::m_menuListTheme):
       
 56654         (WebCore::RenderThemeWin::close):
       
 56655         (WebCore::RenderThemeWin::determineClassicState):
       
 56656         (WebCore::RenderThemeWin::getThemeData):
       
 56657         (WebCore::RenderThemeWin::paintButton):
       
 56658         (WebCore::RenderThemeWin::paintTextField):
       
 56659         (WebCore::RenderThemeWin::paintMenuList):
       
 56660         (WebCore::RenderThemeWin::paintMenuListButton):
       
 56661         * rendering/RenderThemeWin.h:
       
 56662         (WebCore::ThemeData::m_classicState):
       
 56663         (WebCore::RenderThemeWin::setRadioSize):
       
 56664         (WebCore::RenderThemeWin::paintTextArea):
       
 56665 
       
 56666 2007-01-27  David Kilzer  <ddkilzer@webkit.org>
       
 56667 
       
 56668         Reviewed by Adam.
       
 56669 
       
 56670         - fix http://bugs.webkit.org/show_bug.cgi?id=12260
       
 56671           Windows platform build is not maintained
       
 56672 
       
 56673         * loader/win/FrameLoaderWin.cpp:
       
 56674         * platform/network/win/ResourceHandleWin.cpp:
       
 56675         * platform/win/TemporaryLinkStubs.cpp:
       
 56676         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
       
 56677         (WebCore::contextMenuItemTagDownloadLinkToDisk):
       
 56678         (WebCore::contextMenuItemTagCopyLinkToClipboard):
       
 56679         (WebCore::contextMenuItemTagOpenImageInNewWindow):
       
 56680         (WebCore::contextMenuItemTagDownloadImageToDisk):
       
 56681         (WebCore::contextMenuItemTagCopyImageToClipboard):
       
 56682         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
       
 56683         (WebCore::contextMenuItemTagCopy):
       
 56684         (WebCore::contextMenuItemTagGoBack):
       
 56685         (WebCore::contextMenuItemTagGoForward):
       
 56686         (WebCore::contextMenuItemTagStop):
       
 56687         (WebCore::contextMenuItemTagReload):
       
 56688         (WebCore::contextMenuItemTagCut):
       
 56689         (WebCore::contextMenuItemTagPaste):
       
 56690         (WebCore::contextMenuItemTagNoGuessesFound):
       
 56691         (WebCore::contextMenuItemTagIgnoreSpelling):
       
 56692         (WebCore::contextMenuItemTagLearnSpelling):
       
 56693         (WebCore::contextMenuItemTagSearchWeb):
       
 56694         (WebCore::contextMenuItemTagLookUpInDictionary):
       
 56695         (WebCore::contextMenuItemTagOpenLink):
       
 56696         (WebCore::contextMenuItemTagIgnoreGrammar):
       
 56697         (WebCore::contextMenuItemTagSpellingMenu):
       
 56698         (WebCore::contextMenuItemTagShowSpellingPanel):
       
 56699         (WebCore::contextMenuItemTagCheckSpelling):
       
 56700         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
       
 56701         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
       
 56702         (WebCore::contextMenuItemTagFontMenu):
       
 56703         (WebCore::contextMenuItemTagBold):
       
 56704         (WebCore::contextMenuItemTagItalic):
       
 56705         (WebCore::contextMenuItemTagUnderline):
       
 56706         (WebCore::contextMenuItemTagOutline):
       
 56707         (WebCore::contextMenuItemTagWritingDirectionMenu):
       
 56708         (WebCore::contextMenuItemTagDefaultDirection):
       
 56709         (WebCore::contextMenuItemTagLeftToRight):
       
 56710         (WebCore::contextMenuItemTagRightToLeft):
       
 56711         (WebCore::DocumentLoader::unreachableURL):
       
 56712         (WebCore::FrameLoader::redirectDataToPlugin):
       
 56713         (WebCore::FrameLoader::partClearedInBegin):
       
 56714         (WebCore::FrameLoader::createPlugin):
       
 56715 
       
 56716 2007-01-27  Sam Weinig  <sam@webkit.org>
       
 56717 
       
 56718         Reviewed by Mitz.
       
 56719 
       
 56720         - Patch for http://bugs.webkit.org/show_bug.cgi?id=11957
       
 56721           REGRESSION: Unordered List Bullets too big and changing from size
       
 56722 
       
 56723         * rendering/RenderListMarker.cpp:
       
 56724         (WebCore::RenderListMarker::paint): Explicitly set the stroke size to 1.0f.
       
 56725 
       
 56726 2007-01-27  Lars Knoll <lars@trolltech.com>
       
 56727 
       
 56728         Fix the Qt build and disable the usage
       
 56729         of QScrollbars for PlatformScrollBar for 
       
 56730         now as it causes crashes in the layout tests.
       
 56731 
       
 56732         * WebCore.pro:
       
 56733         * ksvg2/svg/SVGTransformDistance.cpp:
       
 56734         * page/qt/FrameQt.cpp:
       
 56735         (WebCore::FrameQt::FrameQt):
       
 56736         (WebCore::FrameQt::bindingRootObject):
       
 56737         (WebCore::FrameQt::createRootObject):
       
 56738         * page/qt/FrameQt.h:
       
 56739         * platform/qt/PlatformScrollBarQt.cpp:
       
 56740         (WebCore::PlatformScrollbar::PlatformScrollbar):
       
 56741         * platform/qt/ScrollViewQt.cpp:
       
 56742         (WebCore::ScrollView::addChild):
       
 56743 
       
 56744 2007-01-27  David Kilzer  <ddkilzer@kilzer.net>
       
 56745 
       
 56746         Reviewed by NOBODY (buildbot build fix).
       
 56747 
       
 56748         * ksvg2/svg/ColorDistance.cpp:
       
 56749         (WebCore::ColorDistance::scaledDistance): Added static cast of arguments to int.
       
 56750 
       
 56751 2007-01-27  Rob Buis  <buis@kde.org>
       
 56752 
       
 56753         Reviewed by NOBODY (typo in method name fix).
       
 56754 
       
 56755         * ksvg2/svg/SVGSVGElement.cpp:
       
 56756         (WebCore::SVGSVGElement::addSVGWindowEventListener):
       
 56757         (WebCore::SVGSVGElement::parseMappedAttribute):
       
 56758         * ksvg2/svg/SVGSVGElement.h:
       
 56759 
       
 56760 2007-01-27  Eric Seidel  <eric@webkit.org>
       
 56761 
       
 56762         Reviewed by olliej.
       
 56763 
       
 56764         Fix support for SVG's <set> element.
       
 56765 
       
 56766         Manual test added.
       
 56767 
       
 56768         * ksvg2/svg/SVGSetElement.cpp:
       
 56769         (WebCore::SVGSetElement::updateAnimatedValue):
       
 56770         (WebCore::SVGSetElement::calculateFromAndToValues):
       
 56771         * ksvg2/svg/SVGSetElement.h:
       
 56772         * manual-tests/animation/set-to.svg: Added.
       
 56773 
       
 56774 2007-01-27  Alexey Proskuryakov  <ap@webkit.org>
       
 56775 
       
 56776         Release build fix.
       
 56777 
       
 56778         * loader/TextResourceDecoder.cpp:
       
 56779         (WebCore::TextResourceDecoder::checkForHeadCharset):
       
 56780 
       
 56781 2007-01-27  Alexey Proskuryakov  <ap@webkit.org>
       
 56782 
       
 56783         Reviewed by Darin.
       
 56784 
       
 56785         http://bugs.webkit.org/show_bug.cgi?id=12389
       
 56786         Chinese decoding error at hk.antispam.yahoo.com
       
 56787 
       
 56788         Test: fast/encoding/noscript-in-head.html
       
 56789 
       
 56790         * loader/TextResourceDecoder.cpp:
       
 56791         (WebCore::TextResourceDecoder::checkForHeadCharset): We were already allowing 
       
 56792         NOSCRIPT tags in head, let's actually skip over their content.
       
 56793 
       
 56794 2007-01-26  Geoffrey Garen  <ggaren@apple.com>
       
 56795 
       
 56796         Reviewed by Maciej Stachowiak.
       
 56797         
       
 56798         Fixed <rdar://problem/4608404> WebScriptObject's _executionContext lack 
       
 56799         of ownership policy causes crashes (e.g., in Dashcode)
       
 56800 
       
 56801         Added RootObject ref-counting goodness.
       
 56802 
       
 56803         * page/mac/FrameMac.h:
       
 56804         * page/mac/FrameMac.mm:
       
 56805         (WebCore::FrameMac::cleanupPluginObjects): Invalidate our RootObjects 
       
 56806         instead of detroying them. Track _bindingRootObject separately from the
       
 56807         rest of our RootObjects, since it has its own variable.
       
 56808 
       
 56809         * page/mac/WebCoreFrameBridge.mm:
       
 56810         (createRootObject): Use the Frame's new, more encapsulated function to
       
 56811         create a RootObject.
       
 56812 
       
 56813         * bindings/objc/WebScriptObject.mm: Nixed rootObject setters, since they
       
 56814         were unused and they complicated reference-counting.
       
 56815 
       
 56816 2007-01-26  David Kilzer  <ddkilzer@webkit.org>
       
 56817 
       
 56818         Reviewed by Eric.
       
 56819 
       
 56820         Release build fix.
       
 56821 
       
 56822         * ksvg2/svg/SVGAnimationElement.cpp:
       
 56823         (WebCore::SVGAnimationElement::calculateValueIndexAndPercentagePast): Added static cast
       
 56824         to unsigned when calculating flooredValueIndex.
       
 56825 
       
 56826 2007-01-26  Darin Adler  <darin@apple.com>
       
 56827 
       
 56828         - checked in slightly newer revision of the patch below
       
 56829 
       
 56830         * css/CSSComputedStyleDeclaration.cpp:
       
 56831         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 56832         Grouped all the unimplemented values at the bottom. Fixed the ifdef for
       
 56833         CSS_PROP__WEBKIT_DASHBOARD_REGION so that it compiles on all platforms.
       
 56834 
       
 56835         * css/cssparser.cpp: (WebCore::CSSParser::parseValue): Removed default
       
 56836         case and added type so that the compiler warns about missing properties.
       
 56837         * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): Ditto.
       
 56838 
       
 56839 2007-01-26  Darin Adler  <darin@apple.com>
       
 56840 
       
 56841         Reviewed by Beth.
       
 56842 
       
 56843         - fix http://bugs.webkit.org/show_bug.cgi?id=12412
       
 56844           "unimplemented propertyID: 46" seen at dojotoolkit.org
       
 56845 
       
 56846         Covered by fast/css/computed-style.html
       
 56847 
       
 56848         * css/CSSPropertyNames.in: Sorted the file into two separate sections, one
       
 56849         for properties without the -webkit- prefix and another for properties with.
       
 56850 
       
 56851         * css/makeprop: Generate a CSSPropertyID enum instead of a set of #defines.
       
 56852         Removed unused CSS_PROP_MIN and CSS_PROP_MAX. Renamed CSS_PROP_TOTAL to
       
 56853         numCSSProperties and changed it to a const int instead of #define.
       
 56854         Added a declaration of getPropertyName in the header. Changed the return
       
 56855         type of getPropertyName to const char* and the parameter type to CSSPropertyID.
       
 56856 
       
 56857         * css/CSSComputedStyleDeclaration.cpp: Sort the lists of properties in
       
 56858         an easier to maintain order -- properties without a WebKit prefix first.
       
 56859         (WebCore::valueForLength): Changed return value to PassRefPtr.
       
 56860         (WebCore::valueForMaxLength): Ditto.
       
 56861         (WebCore::valueForBorderStyle): Ditto.
       
 56862         (WebCore::valueForTextAlign): Ditto.
       
 56863         (WebCore::valueForAppearance): Added.
       
 56864         (WebCore::valueForMarginCollapse): Added.
       
 56865         (WebCore::valueForShadow): Changed return value to PassRefPtr.
       
 56866         (WebCore::getPositionOffsetValue): Ditto.
       
 56867         (WebCore::currentColorOrValidColor): Ditto.
       
 56868         (WebCore::CSSComputedStyleDeclaration::cssText): Added cast since
       
 56869         getPropertyName now takes an enum value.
       
 56870         (WebCore::primitiveValueFromLength): Changed return value to PassRefPtr.
       
 56871         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 56872         Added cast to CSSPropertyID so that gcc will detect missing enums in the
       
 56873         switch statement. Simplified the background-size and border-spacing
       
 56874         implementations so they don't have local variables. Added lots of cases
       
 56875         to the switch statement for unimplemented properties. Implemented the
       
 56876         outline-width, box-sizing, -webkit-appearance, -webkit-rtl-ordering,
       
 56877         -webkit-user-drag, and -webkit-user-select properties.
       
 56878         (WebCore::CSSComputedStyleDeclaration::item): Added cast since
       
 56879         getPropertyName now takes an enum value.
       
 56880 
       
 56881         * css/CSSMutableStyleDeclaration.cpp: Removed declaration of getPropertyName.
       
 56882         (WebCore::CSSMutableStyleDeclaration::item): Added cast since
       
 56883         getPropertyName now takes an enum value.
       
 56884 
       
 56885         * css/CSSProperty.cpp: Removed declaration of getPropertyName.
       
 56886         (WebCore::CSSProperty::cssText): Added cast since
       
 56887         getPropertyName now takes an enum value and returns a const char*.
       
 56888 
       
 56889         * css/CSSStyleDeclaration.cpp: Removed declaration of getPropertyName.
       
 56890         (WebCore::CSSStyleDeclaration::getPropertyShorthand): Added cast since
       
 56891         getPropertyName now takes an enum value and returns a const char*.
       
 56892 
       
 56893 2007-01-26  Alice Liu  <alice.liu@apple.com>
       
 56894 
       
 56895         Reviewed by Brady.
       
 56896 
       
 56897         Fixed <rdar://problem/4838076> CrashTracer: 10 crashes in Mail at com.apple.WebCore: WTF::HashMap<WebCore::String
       
 56898 
       
 56899         * loader/DocLoader.cpp:
       
 56900         (WebCore::DocLoader::requestResource):
       
 56901         Added nil check around resource from cache.
       
 56902 
       
 56903 2007-01-26  Adam Roben  <aroben@apple.com>
       
 56904 
       
 56905         Reviewed by Oliver.
       
 56906 
       
 56907         Build fix.
       
 56908 
       
 56909         * ksvg2/svg/SVGAnimationElement.cpp:
       
 56910         (WebCore::SVGAnimationElement::calculateValueIndexAndPercentagePast):
       
 56911         Keep index variables as unsigned until we need to convert to float.
       
 56912 
       
 56913 2007-01-26  Alice Liu  <alice.liu@apple.com>
       
 56914 
       
 56915         Reviewed by Ada.
       
 56916 
       
 56917         Fixed <rdar://problem/4919097> REGRESSION: Ctrl-Y fails to yank (11076)
       
 56918 
       
 56919         * editing/Editor.cpp:
       
 56920         (WebCore::Editor::deleteWithDirection):
       
 56921         If there's no selection, locally create a range that is to the end of the granularity unit and pass that to deleteRange(). 
       
 56922 
       
 56923 2007-01-26  Sam Weinig  <sam@webkit.org>
       
 56924 
       
 56925         Reviewed by Maciej.
       
 56926 
       
 56927         Qt build fix.
       
 56928 
       
 56929         * page/qt/EventHandlerQt.cpp:
       
 56930 
       
 56931 2007-01-26  Dex Deacon  <occupant4@gmail.com>
       
 56932 
       
 56933         Reviewed by Hyatt.
       
 56934 
       
 56935         Fix so that we only relayout frameset children on calls to layout.
       
 56936 
       
 56937         * page/FrameView.cpp:
       
 56938         (WebCore::FrameView::layout):
       
 56939 
       
 56940 2007-01-26  Oliver Hunt  <oliver@apple.com>
       
 56941 
       
 56942         Build Fix
       
 56943 
       
 56944         * ksvg2/svg/ColorDistance.cpp:
       
 56945         * ksvg2/svg/SVGAnimationElement.cpp:
       
 56946         (WebCore::SVGAnimationElement::handleTimerEvent):
       
 56947 
       
 56948 2007-01-26  Eric Seidel  <eric@webkit.org>
       
 56949 
       
 56950         Reviewed by olliej.
       
 56951 
       
 56952         Add support for calcMode, keyTimes and (nearly) keySplines.
       
 56953         http://bugs.webkit.org/show_bug.cgi?id=12350
       
 56954         Re-architect much of the animation system to remove huge sections of code.
       
 56955         Added new ColorDistance, SVGTransformDistance to simplify animateColor, animateTransform calculations.
       
 56956         I also added basic <animateMotion> support since it was so easy w/ the new architecture.
       
 56957         
       
 56958         Adding manual animation tests until bug 12074 is fixed.
       
 56959 
       
 56960         * WebCore.xcodeproj/project.pbxproj:
       
 56961         * ksvg2/misc/SVGTimer.cpp:
       
 56962         (WebCore::SVGTimer::applyAnimations):
       
 56963         * ksvg2/svg/ColorDistance.cpp: Added.
       
 56964         (WebCore::ColorDistance::ColorDistance):
       
 56965         (WebCore::clampColorValue):
       
 56966         (WebCore::ColorDistance::scaledDistance):
       
 56967         (WebCore::ColorDistance::addColorsAndClamp):
       
 56968         (WebCore::ColorDistance::addToColorAndClamp):
       
 56969         (WebCore::ColorDistance::isZero):
       
 56970         (WebCore::ColorDistance::distance):
       
 56971         * ksvg2/svg/ColorDistance.h: Added.
       
 56972         * ksvg2/svg/SVGAnimateColorElement.cpp:
       
 56973         (WebCore::SVGAnimateColorElement::SVGAnimateColorElement):
       
 56974         (WebCore::SVGAnimateColorElement::updateAnimationBaseValueFromElement):
       
 56975         (WebCore::SVGAnimateColorElement::applyAnimatedValueToElement):
       
 56976         (WebCore::SVGAnimateColorElement::updateAnimatedValue):
       
 56977         (WebCore::SVGAnimateColorElement::calculateFromAndToValues):
       
 56978         * ksvg2/svg/SVGAnimateColorElement.h:
       
 56979         (WebCore::SVGAnimateColorElement::contextElement):
       
 56980         * ksvg2/svg/SVGAnimateElement.h:
       
 56981         (WebCore::SVGAnimateElement::updateAnimatedValue):
       
 56982         (WebCore::SVGAnimateElement::calculateFromAndToValues):
       
 56983         * ksvg2/svg/SVGAnimateMotionElement.cpp:
       
 56984         (WebCore::SVGAnimateMotionElement::hasValidTarget):
       
 56985         (WebCore::SVGAnimateMotionElement::updateAnimatedValue):
       
 56986         (WebCore::parsePoint):
       
 56987         (WebCore::SVGAnimateMotionElement::calculateFromAndToValues):
       
 56988         (WebCore::SVGAnimateMotionElement::updateAnimationBaseValueFromElement):
       
 56989         (WebCore::SVGAnimateMotionElement::applyAnimatedValueToElement):
       
 56990         * ksvg2/svg/SVGAnimateMotionElement.h:
       
 56991         * ksvg2/svg/SVGAnimateTransformElement.cpp:
       
 56992         (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
       
 56993         (WebCore::SVGAnimateTransformElement::updateAnimatedValue):
       
 56994         (WebCore::SVGAnimateTransformElement::updateAnimationBaseValueFromElement):
       
 56995         (WebCore::SVGAnimateTransformElement::applyAnimatedValueToElement):
       
 56996         (WebCore::SVGAnimateTransformElement::calculateFromAndToValues):
       
 56997         (WebCore::SVGAnimateTransformElement::parseTransformValue):
       
 56998         * ksvg2/svg/SVGAnimateTransformElement.h:
       
 56999         (WebCore::SVGAnimateTransformElement::contextElement):
       
 57000         * ksvg2/svg/SVGAnimationElement.cpp:
       
 57001         (WebCore::SVGAnimationElement::parseKeyNumbers):
       
 57002         (WebCore::parseValues):
       
 57003         (WebCore::parseKeySplines):
       
 57004         (WebCore::SVGAnimationElement::parseMappedAttribute):
       
 57005         (WebCore::SVGAnimationElement::targetAttributeAnimatedValue):
       
 57006         (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
       
 57007         (WebCore::SVGAnimationElement::detectAnimationMode):
       
 57008         (WebCore::adjustPercentagePastForKeySplines):
       
 57009         (WebCore::SVGAnimationElement::valueIndexAndPercentagePastForDistance):
       
 57010         (WebCore::SVGAnimationElement::calculateTotalDistance):
       
 57011         (WebCore::caculateValueIndexForKeyTimes):
       
 57012         (WebCore::SVGAnimationElement::isValidAnimation):
       
 57013         (WebCore::SVGAnimationElement::calculateValueIndexAndPercentagePast):
       
 57014         (WebCore::SVGAnimationElement::updateAnimationBaseValueFromElement):
       
 57015         (WebCore::SVGAnimationElement::applyAnimatedValueToElement):
       
 57016         (WebCore::SVGAnimationElement::handleTimerEvent):
       
 57017         (WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds):
       
 57018         * ksvg2/svg/SVGAnimationElement.h:
       
 57019         * ksvg2/svg/SVGParserUtilities.cpp:
       
 57020         (WebCore::SVGPolyParser::parsePoints):
       
 57021         * ksvg2/svg/SVGParserUtilities.h:
       
 57022         * ksvg2/svg/SVGSetElement.cpp:
       
 57023         * ksvg2/svg/SVGSetElement.h:
       
 57024         (WebCore::SVGSetElement::updateAnimatedValue):
       
 57025         (WebCore::SVGSetElement::calculateFromAndToValues):
       
 57026         * ksvg2/svg/SVGTransform.cpp:
       
 57027         (SVGTransform::type):
       
 57028         (SVGTransform::translate):
       
 57029         (SVGTransform::scale):
       
 57030         (SVGTransform::setSkewX):
       
 57031         (SVGTransform::setSkewY):
       
 57032         * ksvg2/svg/SVGTransform.h:
       
 57033         (WebCore::operator==):
       
 57034         (WebCore::operator!=):
       
 57035         * ksvg2/svg/SVGTransformDistance.cpp: Added.
       
 57036         (WebCore::SVGTransformDistance::SVGTransformDistance):
       
 57037         (WebCore::SVGTransformDistance::scaledDistance):
       
 57038         (WebCore::SVGTransformDistance::addSVGTransforms):
       
 57039         (WebCore::SVGTransformDistance::addSVGTransform):
       
 57040         (WebCore::SVGTransformDistance::addToSVGTransform):
       
 57041         (WebCore::SVGTransformDistance::isZero):
       
 57042         (WebCore::SVGTransformDistance::distance):
       
 57043         * ksvg2/svg/SVGTransformDistance.h: Added.
       
 57044         * ksvg2/svg/SVGTransformList.cpp:
       
 57045         (SVGTransformList::concatenateForType):
       
 57046         * ksvg2/svg/SVGTransformList.h:
       
 57047         * manual-tests/animation/animateColor-by.svg: Added.
       
 57048         * manual-tests/animation/animateColor-from-by.svg: Added.
       
 57049         * manual-tests/animation/animateColor-repeat-indefinite.svg: Added.
       
 57050         * manual-tests/animation/animateColor-to-from.svg: Added.
       
 57051         * manual-tests/animation/animateColor-to.svg: Added.
       
 57052         * manual-tests/animation/animateColor-values-simple.svg: Added.
       
 57053         * manual-tests/animation/animateMotion-to.svg: Added.
       
 57054         * manual-tests/animation/animateTransform-keyTimes.svg: Added.
       
 57055         * manual-tests/animation/animateTransform-repeat-once.svg: Added.
       
 57056 
       
 57057 2007-01-26  Beth Dakin  <bdakin@apple.com>
       
 57058 
       
 57059         Reviewed by Darin.
       
 57060 
       
 57061         Fix for <rdar://problem/4956565> REGRESSION: After scrolling frame, 
       
 57062         hovering over link in this frame doesn't change cursor to pointing 
       
 57063         hand
       
 57064 
       
 57065         The mouseMove event was not being propagated correctly after using 
       
 57066         the mouse to scroll the frame because m_mousePressed was never 
       
 57067         getting set to false.
       
 57068 
       
 57069         * page/EventHandler.cpp:
       
 57070         (WebCore::EventHandler::handleMousePressEvent): This code does not 
       
 57071         belong here.
       
 57072         * page/EventHandler.h: lastEventIsMouseUp() is only ever relevant 
       
 57073         in EventHandlerMac, so it can just be a static function there.
       
 57074         * page/mac/EventHandlerMac.mm:
       
 57075         (WebCore::lastEventIsMouseUp): Make this static.
       
 57076         (WebCore::EventHandler::passMouseDownEventToWidget): Here is where 
       
 57077         we need to set m_mousePressed to false if lastEventIsMouseUp() is 
       
 57078         true.
       
 57079 
       
 57080 2007-01-26  David Hyatt  <hyatt@apple.com>
       
 57081 
       
 57082         Fix for style regression caused by strictness checking of the number of properties.  This caused code like:
       
 57083         "width: 20 px" to fail, because we interpreted it as two values and rejected it.  Our old code allowed 20 to be
       
 57084         used like a pixel value and then ignored the orphaned unit.
       
 57085 
       
 57086         This patch actually scans the list of values looking for orphaned units and reattaches them to the numeric
       
 57087         values that they should correspond to.  This means rules like "width: 5 em" will now work in quirks mdoe and
       
 57088         the "em" unit type will be honored.
       
 57089 
       
 57090         Reviewed by beth
       
 57091 
       
 57092         * WebCore.xcodeproj/project.pbxproj:
       
 57093         * css/cssparser.cpp:
       
 57094         (WebCore::unitFromString):
       
 57095         (WebCore::CSSParser::checkForOrphanedUnits):
       
 57096         (WebCore::CSSParser::parseValue):
       
 57097         * css/cssparser.h:
       
 57098         (WebCore::ValueList::valueAt):
       
 57099         (WebCore::ValueList::deleteValueAt):
       
 57100 
       
 57101 2007-01-26  George Staikos  <staikos@kde.org>
       
 57102 
       
 57103         Reviewed by Zack.
       
 57104 
       
 57105         Qt implementation.
       
 57106 
       
 57107         * WebCore.pro:
       
 57108         * platform/qt/FontPlatformDataQt.cpp:
       
 57109         (WebCore::FontPlatformData::FontPlatformData):
       
 57110         * platform/qt/ScrollViewQt.cpp:
       
 57111         (WebCore::ScrollView::scrollbarUnderMouse):
       
 57112 
       
 57113 2007-01-26  Brady Eidson  <beidson@apple.com>
       
 57114 
       
 57115         Reviewed by Anders' rubberstamp
       
 57116         
       
 57117         Warning about unreferenced formal parameter caused compile to fail
       
 57118 
       
 57119         * platform/cf/RetainPtr.h:
       
 57120         (WebCore::adoptCFReference):
       
 57121 
       
 57122 2007-01-26  Darin Adler  <darin@apple.com>
       
 57123 
       
 57124         Reviewed by Brady.
       
 57125 
       
 57126         - fix <rdar://problem/4956688> move Mac-specific part of icon code into IconMac
       
 57127         - fix a GC-compatibility problem in the icon code I noticed by code inspection
       
 57128 
       
 57129         * platform/FileChooser.cpp: (WebCore::FileChooser::chooseIcon): Removed Mac-specific
       
 57130         path check -- that's in newIconForFile now.
       
 57131 
       
 57132         * platform/graphics/Icon.h: Changed the image to be a RetainPtr. The old code was
       
 57133         using -[NSObject retain] which is not good enough for a pointer in a C++ object.
       
 57134         * platform/graphics/mac/IconMac.mm:
       
 57135         (WebCore::Icon::Icon): Got rid of unneeded code to do what RetainPtr does for us.
       
 57136         (WebCore::Icon::~Icon): Ditto.
       
 57137         (WebCore::Icon::newIconForFile): Added check for non-absolute file names. Updated
       
 57138         for use of RetainPtr. Use constructor that takes NSImage.
       
 57139         (WebCore::Icon::paint): Add get() calls needed now that we are using a RetainPtr.
       
 57140 
       
 57141         * WebCore.xcodeproj/project.pbxproj: Let Xcode do its thing.
       
 57142 
       
 57143 2007-01-26  Alexey Proskuryakov  <ap@webkit.org>
       
 57144 
       
 57145         Reviewed by Maciej.
       
 57146 
       
 57147         http://bugs.webkit.org/show_bug.cgi?id=12385
       
 57148         Assertion failure when loading subresources from "data:" frames
       
 57149 
       
 57150         Test: fast/loader/opaque-base-url.html
       
 57151 
       
 57152         * platform/KURL.cpp:
       
 57153         (WebCore::KURL::init): Make the URL invalid if it's relative, but has an opaque or empty base.
       
 57154 
       
 57155 2007-01-26  Dex Deacon  <occupant4@gmail.com>
       
 57156 
       
 57157         Reviewed by Darin.
       
 57158 
       
 57159         * page/EventHandler.cpp:
       
 57160         (WebCore::EventHandler::handleMouseMoveEvent):
       
 57161         Removed a call to invalidateClick(), since we don't want to cancel a
       
 57162         click if the mouse moves.
       
 57163 
       
 57164 2007-01-26  Darin Adler  <darin@apple.com>
       
 57165 
       
 57166         * css/MediaQueryEvaluator.cpp:
       
 57167         (WebCore::MediaQueryEvaluator::mediaTypeMatchSpecific):
       
 57168         Oops, forgot a !.
       
 57169 
       
 57170 2007-01-26  Darin Adler  <darin@apple.com>
       
 57171 
       
 57172         Patch by Nate Begeman.
       
 57173         Reviewed by Darin and Maciej.
       
 57174 
       
 57175         - <rdar://problem/4946877> Avoid unnecessary allocations in CSS, patch attached (12401)
       
 57176           http://bugs.webkit.org/show_bug.cgi?id=12401
       
 57177 
       
 57178         * css/MediaQueryEvaluator.h: Add mediaTypeMatchSpecific, a function that
       
 57179         takes a char* to avoid creating and destroying a String for simple media
       
 57180         type queries.
       
 57181         * css/MediaQueryEvaluator.cpp:
       
 57182         (WebCore::MediaQueryEvaluator::mediaTypeMatchSpecific): Added. Besides
       
 57183         avoiding the conversion to String, this also doesn't have the special
       
 57184         case code to handle "" and "all".
       
 57185 
       
 57186         * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::matchUARules):
       
 57187         Call mediaTypeMatchSpecific here when deciding whether to use the
       
 57188         print version of the user agent style sheet.
       
 57189 
       
 57190         * loader/Cache.cpp: (WebCore::Cache::requestResource): Don't convert to
       
 57191         a string and back to a KURL when calling createResource. Avoids reparsing
       
 57192         the URL string.
       
 57193 
       
 57194 2007-01-26  Zack Rusin  <zrusin@trolltech.com>
       
 57195 
       
 57196         Reviewed by Lars
       
 57197 
       
 57198         Add history related classes to the project file.
       
 57199 
       
 57200         * WebCore.pro:
       
 57201 
       
 57202 2007-01-26  Zack Rusin  <zack@kde.org>
       
 57203 
       
 57204         Reviewed by Lars
       
 57205 
       
 57206         Introduce PlatformScrollBar and try to make 
       
 57207         the scrollbar behavior a little more sane.
       
 57208 
       
 57209         * WebCore.pro:
       
 57210         * platform/qt/PlatformScrollBarQt.cpp: Added.
       
 57211         (WebCore::Scrollbar::Scrollbar):
       
 57212         (WebCore::Scrollbar::setSteps):
       
 57213         (WebCore::Scrollbar::scroll):
       
 57214         (WebCore::Scrollbar::setValue):
       
 57215         (WebCore::Scrollbar::setProportion):
       
 57216         (WebCore::PlatformScrollbar::PlatformScrollbar):
       
 57217         (WebCore::PlatformScrollbar::~PlatformScrollbar):
       
 57218         (WebCore::PlatformScrollbar::width):
       
 57219         (WebCore::PlatformScrollbar::height):
       
 57220         (WebCore::PlatformScrollbar::setEnabled):
       
 57221         (WebCore::PlatformScrollbar::paint):
       
 57222         (WebCore::PlatformScrollbar::updateThumbPosition):
       
 57223         (WebCore::PlatformScrollbar::updateThumbProportion):
       
 57224         (WebCore::PlatformScrollbar::setRect):
       
 57225         * platform/qt/ScrollViewQt.cpp:
       
 57226         (WebCore::ScrollView::addChild):
       
 57227         * platform/qt/TemporaryLinkStubs.cpp:
       
 57228         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
       
 57229 
       
 57230 2007-01-26  Mitz Pettel  <mitz@webkit.org>
       
 57231 
       
 57232         Reviewed by Darin.
       
 57233 
       
 57234         - fix http://bugs.webkit.org/show_bug.cgi?id=11109
       
 57235           REGRESSION (r15471): menus are offset on eink.com
       
 57236           <rdar://problem/4824760>
       
 57237 
       
 57238         Changed offset{Left,Top} to match Firefox. If the body element is statically
       
 57239         positioned, it is still returned as the offsetParent of elements whose containing
       
 57240         block is the initial containing block (the root), but their offset{Left,Top} are
       
 57241         relative to the root. If the body element is positioned, then offsets are relative
       
 57242         to it. The body's own offset{Left,Top} are always 0. 
       
 57243 
       
 57244         Test: fast/dom/Element/offsetLeft-offsetTop-body-quirk.html
       
 57245 
       
 57246         * rendering/RenderObject.cpp:
       
 57247         (WebCore::RenderObject::offsetLeft):
       
 57248         (WebCore::RenderObject::offsetTop):
       
 57249 
       
 57250 2007-01-26  Mitz Pettel  <mitz@webkit.org>
       
 57251 
       
 57252         Reviewed by Darin and Maciej.
       
 57253 
       
 57254         - fix http://bugs.webkit.org/show_bug.cgi?id=10983
       
 57255           REGRESSION (r12290): Drop shadow of flickr photo note is positioned incorrectly the second time it's shown
       
 57256 
       
 57257         Test: fast/dynamic/staticY.html
       
 57258 
       
 57259         * rendering/RenderBlock.cpp:
       
 57260         (WebCore::RenderBlock::layoutPositionedObjects): Avoid marking the object's
       
 57261         parents, since they have already been laid out.
       
 57262         * rendering/RenderBox.cpp:
       
 57263         (WebCore::RenderBox::setStaticY): Added a call to setChildNeedsLayout() to
       
 57264         ensure relayout by this box's container (third and fourth cases in the
       
 57265         layout test).
       
 57266         * rendering/RenderBox.h:
       
 57267         * rendering/RenderObject.cpp:
       
 57268         (WebCore::RenderObject::markContainingBlocksForLayout): For positioned objects
       
 57269         with static y, also mark the object's parent to ensure that it recomputes
       
 57270         the static y value (first case in the layout test).
       
 57271 
       
 57272 2007-01-26  Lars Knoll <lars@trolltech.com>
       
 57273 
       
 57274         Reviewed by Zack
       
 57275 
       
 57276         Get rid of FrameQtClient. It's unused since we moved over
       
 57277         to the loader.
       
 57278 
       
 57279         * WebCore.pro:
       
 57280         * page/qt/FrameQt.cpp:
       
 57281         (WebCore::FrameQt::FrameQt):
       
 57282         * page/qt/FrameQt.h:
       
 57283         * page/qt/FrameQtClient.cpp: Removed.
       
 57284         * page/qt/FrameQtClient.h: Removed.
       
 57285         * platform/network/ResourceHandleInternal.h:
       
 57286         * platform/network/qt/ResourceHandleManagerQt.cpp:
       
 57287         (WebCore::RequestQt::RequestQt):
       
 57288         (WebCore::ResourceHandleManager::add):
       
 57289         * platform/network/qt/ResourceHandleManagerQt.h:
       
 57290         * platform/network/qt/ResourceHandleQt.cpp:
       
 57291         (WebCore::ResourceHandle::start):
       
 57292 
       
 57293 2007-01-26  Zack Rusin  <zack@kde.org>
       
 57294 
       
 57295         Fix the compile
       
 57296 
       
 57297         * WebCore.pro:
       
 57298 
       
 57299 2007-01-26  Adam Roben  <aroben@apple.com>
       
 57300 
       
 57301         Reviewed by Maciej.
       
 57302 
       
 57303         Fixed <rdar://problem/4946499>, which made it impossible to tab
       
 57304         forward into the left frame of tivofaq.com after tabbing out of the
       
 57305         document.
       
 57306 
       
 57307         * page/FocusController.cpp:
       
 57308         (WebCore::FocusController::advanceFocus): Clear the focused frame
       
 57309         before passing off focus to Chrome so that when we re-enter the
       
 57310         document we start at the main frame instead of the last focused frame.
       
 57311 
       
 57312 2007-01-25  Rob Buis  <buis@kde.org>
       
 57313 
       
 57314         Reviewed by olliej.
       
 57315 
       
 57316         http://bugs.webkit.org/show_bug.cgi?id=11911
       
 57317         SVG exhibits double-text-selection behavior
       
 57318 
       
 57319         Fix selection height of the inline text boxes for svg.
       
 57320 
       
 57321         * WebCore.xcodeproj/project.pbxproj:
       
 57322         * rendering/InlineTextBox.cpp:
       
 57323         (WebCore::InlineTextBox::selectionTop):
       
 57324         (WebCore::InlineTextBox::selectionHeight):
       
 57325         (WebCore::InlineTextBox::selectionRect):
       
 57326         (WebCore::InlineTextBox::paintSelection):
       
 57327         (WebCore::InlineTextBox::paintMarkedTextBackground):
       
 57328         (WebCore::InlineTextBox::paintCustomHighlight):
       
 57329         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
       
 57330         (WebCore::InlineTextBox::paintTextMatchMarker):
       
 57331         * rendering/InlineTextBox.h:
       
 57332         * rendering/RenderSVGInlineText.cpp:
       
 57333         (WebCore::RenderSVGInlineText::createInlineTextBox):
       
 57334         * rendering/RenderSVGInlineText.h:
       
 57335         * rendering/RenderText.cpp:
       
 57336         (WebCore::RenderText::createInlineTextBox):
       
 57337         (WebCore::RenderText::createInlineBox):
       
 57338         * rendering/RenderText.h:
       
 57339         * rendering/SVGInlineTextBox.cpp: Added.
       
 57340         (WebCore::SVGInlineTextBox::selectionTop):
       
 57341         (WebCore::SVGInlineTextBox::selectionHeight):
       
 57342         * rendering/SVGInlineTextBox.h: Added.
       
 57343         (WebCore::SVGInlineTextBox::SVGInlineTextBox):
       
 57344 
       
 57345 2007-01-26  Zack Rusin  <zack@kde.org>
       
 57346 
       
 57347         Reviewed by Lars
       
 57348 
       
 57349         Fix drawing of tiled images.
       
 57350 
       
 57351         * WebCore.pro:
       
 57352         * platform/graphics/qt/ImageQt.cpp:
       
 57353         (WebCore::BitmapImage::drawPattern):
       
 57354 
       
 57355 2007-01-26  Zack Rusin  <zack@kde.org>
       
 57356 
       
 57357         Reviewed by Lars
       
 57358 
       
 57359         Fixing image loading - we decode QImages
       
 57360         but render QPixmaps now. Implement Icon
       
 57361         class
       
 57362 
       
 57363         * platform/graphics/BitmapImage.h:
       
 57364         * platform/graphics/Icon.h:
       
 57365         * platform/graphics/Image.h:
       
 57366         (WebCore::Image::getPixmap):
       
 57367         * platform/graphics/qt/IconQt.cpp:
       
 57368         (WebCore::Icon::Icon):
       
 57369         (WebCore::Icon::~Icon):
       
 57370         (WebCore::Icon::newIconForFile):
       
 57371         (WebCore::Icon::paint):
       
 57372         * platform/graphics/qt/ImageDecoderQt.cpp:
       
 57373         (WebCore::ImageDecoderQt::ImageData::ImageData):
       
 57374         (WebCore::ImageDecoderQt::ReadContext::read):
       
 57375         (WebCore::ImageDecoderQt::ReadContext::readImageLines):
       
 57376         (WebCore::ImageDecoderQt::reset):
       
 57377         (WebCore::ImageDecoderQt::imageAtIndex):
       
 57378         * platform/graphics/qt/ImageDecoderQt.h:
       
 57379         * platform/graphics/qt/ImageQt.cpp:
       
 57380         (WebCore::BitmapImage::drawPattern):
       
 57381         (WebCore::BitmapImage::getPixmap):
       
 57382         * platform/graphics/qt/ImageSourceQt.cpp:
       
 57383         (WebCore::ImageSource::createFrameAtIndex):
       
 57384 
       
 57385 2007-01-25  Justin Garcia  <justin.garcia@apple.com>
       
 57386 
       
 57387         Reviewed by oliver
       
 57388         
       
 57389         <http://bugs.webkit.org/show_bug.cgi?id=12409>
       
 57390         REGRESSION (r19039): Drag caret isn't cleared after a drop
       
 57391 
       
 57392         No new layout tests because the regression was
       
 57393         caught by current layout tests.
       
 57394 
       
 57395         * page/DragController.cpp:
       
 57396         (WebCore::DragController::concludeDrag): Clear the drag caret.
       
 57397 
       
 57398 2007-01-25  Darin Adler  <darin@apple.com>
       
 57399 
       
 57400         Reviewed and landed by Geoffrey Garen.
       
 57401 
       
 57402         - fix http://bugs.webkit.org/show_bug.cgi?id=12342
       
 57403           REGRESSION: destroying a frame from its own script causes various crashes
       
 57404 
       
 57405         * bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute):
       
 57406         Use RefPtr for the frame and the interpreter object so they don't get deleted
       
 57407         out from underneath us.
       
 57408 
       
 57409         * bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate):
       
 57410         Add a check for a page of 0. This was the only call site for the
       
 57411         addMessageToConsole function that did not have a check for a page of 0.
       
 57412 
       
 57413 2007-01-25 Dirk Mueller  <mueller@kde.org>
       
 57414 
       
 57415         Reviewed and merged by Beth.
       
 57416 
       
 57417         Fix for <rdar://problem/4921692> not processing comments inside a 
       
 57418         title element leads to XSS (for at least BlogSpot)
       
 57419 
       
 57420         This is equivalent to commit 626791 in the KDE tree. Basically, the 
       
 57421         patch allows comment parsing in titles to avoid capturing a 
       
 57422         <script> tag by accident.
       
 57423 
       
 57424         * html/HTMLTokenizer.cpp:
       
 57425         (WebCore::HTMLTokenizer::parseSpecial):
       
 57426         (WebCore::HTMLTokenizer::parseComment):
       
 57427 
       
 57428 2007-01-25  Darin Adler  <darin@apple.com>
       
 57429 
       
 57430         * ksvg2/svg/SVGPreserveAspectRatio.cpp: Add a couple of comments.
       
 57431 
       
 57432 2007-01-25  Darin Adler  <darin@apple.com>
       
 57433 
       
 57434         Reviewed by Maciej.
       
 57435 
       
 57436         - fix http://bugs.webkit.org/show_bug.cgi?id=12365
       
 57437           Reproducible crash in WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio
       
 57438           in svg/W3C-SVG-1.1/animate-elem-40-t.svg under guard malloc
       
 57439         - fix bug where the parser accepts "meet" or "slice" as an entire string
       
 57440         - fix bug where "slice" is ignored if the old alignment was "none"
       
 57441           even if the newly-parsed alignment is something other than "none", and
       
 57442           "slice" is not ignored if the old alignment was not "none", but the
       
 57443           newly-parsed alignment is "none"
       
 57444         - optimize to only call notifyAttributeChange if the attribute actually changed
       
 57445 
       
 57446         Test: svg/dom/preserve-aspect-ratio-parser-test.html
       
 57447 
       
 57448         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
       
 57449         (WebCore::checkString): Added an overload for using char* constants which is
       
 57450         much simpler than the old one, and almost as fast.
       
 57451         (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): Fail if there's no
       
 57452         more text after "defer". Fail if there's neither "none" nor an x/y specified.
       
 57453         Check that there's more text before looking at the "m" and "s" for "meet" and
       
 57454         "slice". Merged the failure and success cases. Only call notifyAttributeChange
       
 57455         if something changed.
       
 57456 
       
 57457         I think all the "optimized" code where we check the first character before
       
 57458         calling checkString isn't really helpful, but I decided to leave it as-is
       
 57459         for now.
       
 57460 
       
 57461 2007-01-25  Lars Knoll <lars@trolltech.com>
       
 57462 
       
 57463         Reviewed by Zack
       
 57464 
       
 57465         Trivial implementation of getMIMETypeForExtension.
       
 57466         Use the above method in the ResourceHandleManager to set
       
 57467         a mimetype on Resources that don't have one set (which
       
 57468         includes everything loaded from local disk).
       
 57469 
       
 57470         Should fix quite a few test cases :)
       
 57471 
       
 57472         * platform/network/qt/ResourceHandleManagerQt.cpp:
       
 57473         (WebCore::ResourceHandleManager::receivedResponse):
       
 57474         * platform/qt/MimeTypeRegistryQt.cpp:
       
 57475         (WebCore::):
       
 57476         (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
       
 57477 
       
 57478 2007-01-25 Harald Fernengel <harald@trolltech.com>
       
 57479 
       
 57480         Reviewed by zack
       
 57481 
       
 57482         Compile on platforms where qreal is not a double.
       
 57483 
       
 57484         * platform/graphics/qt/AffineTransformQt.cpp:
       
 57485         (WebCore::AffineTransform::map):
       
 57486 
       
 57487 2007-01-25  Zack Rusin  <zack@kde.org>
       
 57488 
       
 57489         Reviewed by Lars.
       
 57490 
       
 57491         Add wheel event handling and make explicit usage
       
 57492         of the EventHandler.
       
 57493 
       
 57494         * WebCore.pro:
       
 57495         * page/qt/EventHandlerQt.cpp:
       
 57496         (WebCore::EventHandler::focusDocumentView):
       
 57497         (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
       
 57498         (WebCore::EventHandler::passMouseDownEventToWidget):
       
 57499         (WebCore::EventHandler::lastEventIsMouseUp):
       
 57500         (WebCore::EventHandler::handleMouseUp):
       
 57501         * platform/PlatformWheelEvent.h:
       
 57502         * platform/qt/ScrollViewCanvasQt.cpp:
       
 57503         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
       
 57504         (WebCore::ScrollViewCanvasQt::mousePressEvent):
       
 57505         (WebCore::ScrollViewCanvasQt::wheelEvent):
       
 57506         (WebCore::ScrollViewCanvasQt::dragEnterEvent):
       
 57507         (WebCore::ScrollViewCanvasQt::dragLeaveEvent):
       
 57508         (WebCore::ScrollViewCanvasQt::dragMoveEvent):
       
 57509         * platform/qt/ScrollViewCanvasQt.h:
       
 57510         * platform/qt/ScrollViewQt.cpp:
       
 57511         (WebCore::ScrollView::wheelEvent):
       
 57512         * platform/qt/WheelEventQt.cpp: Added.
       
 57513         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
       
 57514 
       
 57515 2007-01-25  Rob Buis  <buis@kde.org>
       
 57516 
       
 57517         Reviewed by Maciej.
       
 57518 
       
 57519         http://bugs.webkit.org/show_bug.cgi?id=12391
       
 57520         SVG containers with viewports should respect overflow when hit testing
       
 57521 
       
 57522         Take into account the overflow property when hit testing <svg>.
       
 57523 
       
 57524         * rendering/RenderSVGContainer.cpp:
       
 57525         (WebCore::RenderSVGContainer::nodeAtPoint):
       
 57526 
       
 57527 2007-01-23  Alice Liu  <alice.liu@apple.com>
       
 57528 
       
 57529         Reviewed by Maciej.
       
 57530 
       
 57531         fixed <rdar://problem/4808039> REGRESSION: eBay ID check never completes
       
 57532         Also known as http://bugs.webkit.org/show_bug.cgi?id=11230
       
 57533 
       
 57534         * bindings/js/kjs_window.cpp:
       
 57535         It's not necessary to check safeScript when doing a location.replace, .reload, or .assign
       
 57536         (KJS::Location::getOwnPropertySlot):
       
 57537         (KJS::LocationFunc::callAsFunction):
       
 57538 
       
 57539 2007-01-25  Alice Liu  <alice.liu@apple.com>
       
 57540 
       
 57541         Reviewed by Geoff and Adele.
       
 57542 
       
 57543         fixed <rdar://problem/4866655> REGRESSION: Copying out of Calculator & CIFIlterWidget is broken on 9A320
       
 57544 
       
 57545         * editing/Editor.cpp:
       
 57546         (WebCore::Editor::canDHTMLCut):
       
 57547         (WebCore::Editor::canDHTMLCopy):
       
 57548         (WebCore::Editor::tryDHTMLCopy):
       
 57549         (WebCore::Editor::tryDHTMLCut):
       
 57550         Reverting some mistakes made in r17504:
       
 57551         Anything in r17503 that used to call mayDHTML* still calls canDHTML* as it was changed in r17504, where canDHTML* now calls !selectionController::isInPasswordField instead of editor::canCopy
       
 57552         Anything else in r17503 that used to call mayCopy now calls (!)selectionController::isInPasswordField.
       
 57553 
       
 57554         * editing/JSEditor.cpp:
       
 57555         copy via JS should be enabled as long as selection is not in a password field.  a range selection shouldn't be required. 
       
 57556 
       
 57557 2007-01-24  Adele Peterson  <adele@apple.com>
       
 57558 
       
 57559         Reviewed by Brady and Oliver.
       
 57560 
       
 57561         Fix for <rdar://problem/4953504> When the keydown event changes focus, the keypress event should go to the new focused node
       
 57562 
       
 57563         Test: fast/events/keydown-keypress-focus-change.html
       
 57564 
       
 57565         * page/EventHandler.cpp:
       
 57566         (WebCore::eventTargetNodeForDocument): Added for convenience.
       
 57567         (WebCore::EventHandler::keyEvent): Moved from EventHandlerMac.mm.  After dispatching the keyDown event,
       
 57568          recheck the target node for the keyPress event in case its changed.
       
 57569         * page/EventHandler.h:
       
 57570         * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::keyEvent):
       
 57571           Moved the bulk of this code to EventHandler.cpp.
       
 57572 
       
 57573 2007-01-24  Geoffrey Garen  <ggaren@apple.com>
       
 57574 
       
 57575         New forwarding header. No review necessary.
       
 57576 
       
 57577         * ForwardingHeaders/kjs/ustring.h: Added.
       
 57578 
       
 57579 2007-01-24  Oliver Hunt  <oliver@apple.com>
       
 57580 
       
 57581         Reviewed by Maciej.
       
 57582 
       
 57583         Migrating more drag state information to WebCore
       
 57584 
       
 57585         * page/DragController.cpp:
       
 57586         * page/DragController.h:
       
 57587         (WebCore::DragController::dragOperation):
       
 57588         (WebCore::DragController::setDraggingImageURL):
       
 57589         (WebCore::DragController::draggingImageURL):
       
 57590         (WebCore::DragController::setDragOffset):
       
 57591         (WebCore::DragController::dragOffset):
       
 57592 
       
 57593 2007-01-24  Darin Adler  <darin@apple.com>
       
 57594 
       
 57595         Reviewed by Adele.
       
 57596 
       
 57597         - fix http://bugs.webkit.org/show_bug.cgi?id=12331
       
 57598           REGRESSION(r18951): Selecting text in a textarea makes the page scroll
       
 57599 
       
 57600         Test: fast/events/autoscroll.html
       
 57601 
       
 57602         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll):
       
 57603         Adjust position to be relative to the object's corner for the hit test, but not for the
       
 57604         scrollRectToVisible call. The previous version accidentally re-used the version that was
       
 57605         adjusted for the hit test.
       
 57606 
       
 57607 2007-01-24  Beth Dakin  <bdakin@apple.com>
       
 57608 
       
 57609         Reviewed by Geoff.
       
 57610 
       
 57611         Fix for <rdar://problem/4948128> REGRESSION: A crash occurs at 
       
 57612         WebCore::Frame::view() after completing a query at mapquest.com 
       
 57613         then switching to Bookmarks view
       
 57614 
       
 57615         This is just a null-check. If you are in strict mode and ask for 
       
 57616         the clientWidth or clientHeight after the document was removed from 
       
 57617         it's parent, we no longer have a frameView, so we have to null-
       
 57618         check it. I added null checks for the FrameView in some other 
       
 57619         places where it seems like we could potentially run into this 
       
 57620         issue.
       
 57621 
       
 57622         * bindings/objc/DOMHTML.mm:
       
 57623         (-[DOMHTMLInputElement _rectOnScreen]):
       
 57624         * bridge/mac/WebCoreAXObject.mm:
       
 57625         (-[WebCoreAXObject accessibilityAttributeValue:]):
       
 57626         * dom/ContainerNode.cpp:
       
 57627         (WebCore::ContainerNode::getUpperLeftCorner):
       
 57628         * dom/Element.cpp:
       
 57629         (WebCore::Element::clientWidth): Actual bug fix here!
       
 57630         (WebCore::Element::clientHeight): And here!
       
 57631         * ksvg2/svg/SVGLength.cpp:
       
 57632         (WebCore::SVGLength::PercentageOfViewport):
       
 57633         * loader/FrameLoader.cpp:
       
 57634         (WebCore::FrameLoader::createJavaAppletWidget):
       
 57635         * page/mac/WebCoreFrameBridge.mm:
       
 57636         (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
       
 57637         * rendering/RenderLayer.cpp:
       
 57638         (WebCore::RenderLayer::windowClipRect):
       
 57639         (WebCore::RenderLayer::updateOverflowStatus):
       
 57640         (WebCore::frameVisibleRect):
       
 57641         * rendering/RenderListBox.cpp:
       
 57642         (WebCore::RenderListBox::windowClipRect):
       
 57643         * rendering/RenderTable.cpp:
       
 57644         (WebCore::RenderTable::layout):
       
 57645 
       
 57646 2007-01-24  Maciej Stachowiak  <mjs@apple.com>
       
 57647 
       
 57648         Not reviewed, just removing accidentally committed file.
       
 57649 
       
 57650         - removed file that shouldn't be there
       
 57651 
       
 57652         * Image Viewer/Image Viewer.aps: Removed.
       
 57653 
       
 57654 2007-01-24  Anders Carlsson  <acarlsson@apple.com>
       
 57655 
       
 57656         Reviewed by Geoff and Adam.
       
 57657 
       
 57658         <rdar://problem/4922655>
       
 57659         http://galeri.milliyet.com.tr/ reproducibly crashes Safari
       
 57660         
       
 57661         * loader/FrameLoader.cpp:
       
 57662         (WebCore::FrameLoader::requestFrame):
       
 57663         If the frame already exists, defer the navigation so that we won't end up replacing the document
       
 57664         while we're parsing it. This is similar to what setting window.location ends up doing.
       
 57665 
       
 57666 2007-01-25  Mark Rowe  <mrowe@apple.com>
       
 57667 
       
 57668         Reviewed by Darin.
       
 57669 
       
 57670         * Info.plist: Update copyright string.
       
 57671 
       
 57672 2007-01-24  Justin Garcia  <justin.garcia@apple.com>
       
 57673 
       
 57674         Reviewed by harrison
       
 57675 
       
 57676         <rdar://problem/4916235>
       
 57677         eBay Editor: Crash occurs at WebCore::Range::startPosition() after applying ordered list styling to selected text
       
 57678         <rdar://problem/4857269>
       
 57679         REGRESSION: editing/execCommand/create-list-from-range-selection.html no longer works as intended
       
 57680         <rdar://problem/4916583>
       
 57681         eBay Editor: Removing a indent from a list item actually deletes the list item instead
       
 57682         <rdar://problem/4928635>
       
 57683         designMode outdent causes crash (11750)
       
 57684 
       
 57685         * editing/CompositeEditCommand.cpp:
       
 57686         (WebCore::CompositeEditCommand::moveParagraphs): Fixed br insertion
       
 57687         after the pruning of empty containers left over after the paragraph
       
 57688         to move is removed.
       
 57689         * editing/DeleteSelectionCommand.cpp:
       
 57690         (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): There are
       
 57691         bugs that leave the wrong number of line breaks after a deletion 
       
 57692         that expands to include special elements (lists/tables).  Added 
       
 57693         a workaround so that moveParagraphs can avoid these until they 
       
 57694         are fixed.
       
 57695         (WebCore::DeleteSelectionCommand::initializeStartEnd): Ditto.
       
 57696         (WebCore::DeleteSelectionCommand::initializePositionData): Ditto.
       
 57697         * editing/DeleteSelectionCommand.h:
       
 57698         * editing/TextIterator.cpp:
       
 57699         (WebCore::TextIterator::advance): We used to not call exitNode for
       
 57700         ancestors of a node where the next node in a pre-order traversal is 
       
 57701         the ranges's pastEndNode().  This is only correct for ancestors that
       
 57702         contain the end of the range.
       
 57703         (WebCore::shouldEmitNewlineAfterNode): Added, we should only emit newlines
       
 57704         after blocks that have VisiblePositions after them.  VisiblePosition creation
       
 57705         though is too expensive to do here, what I added here is an OK substitute.
       
 57706         (WebCore::shouldEmitNewlineBeforeNode): Added.  No special logic yet.
       
 57707         (WebCore::TextIterator::handleNonTextNode): Call shouldEmitNewlineBeforeNode.
       
 57708         (WebCore::TextIterator::exitNode): Call shouldEmitNewlineAfterNode.
       
 57709         (WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode): Call
       
 57710         shouldEmitNewlineAfterNode.
       
 57711 
       
 57712 2007-01-24  Darin Adler  <darin@apple.com>
       
 57713 
       
 57714         Reviewed by Mark Rowe.
       
 57715 
       
 57716         * WebCore.xcodeproj/project.pbxproj: Changed to /usr/sbin/sysctl
       
 57717         so we don't rely on people's paths.
       
 57718 
       
 57719 2007-01-24  Darin Adler  <darin@apple.com>
       
 57720 
       
 57721         Reviewed by Adele.
       
 57722 
       
 57723         - a couple minor tweaks to recently-changed things
       
 57724 
       
 57725         * dom/Document.h: Use HTMLHeadElement as type for the head function.
       
 57726         * dom/Document.cpp: (WebCore::Document::head):
       
 57727 
       
 57728         * ksvg2/svg/SVGElementInstance.cpp:
       
 57729         (WebCore::SVGElementInstance::~SVGElementInstance): Change loop to
       
 57730         a for loop and use a local variable for document.
       
 57731 
       
 57732 2007-01-24  Oliver Hunt  <oliver@apple.com>
       
 57733 
       
 57734         Reviewed by Adele.
       
 57735 
       
 57736         Fixes DragController to allow a null target Document.
       
 57737         This is encountered in new tabs/windows that have not 
       
 57738         loaded any page
       
 57739 
       
 57740         * page/DragController.cpp:
       
 57741         (WebCore::documentAtPoint):
       
 57742         (WebCore::DragController::tryDocumentDrag):
       
 57743         (WebCore::DragController::operationForLoad):
       
 57744         (WebCore::DragController::concludeDrag):
       
 57745         * page/mac/DragControllerMac.mm:
       
 57746         (WebCore::DragController::dragOperation):
       
 57747 
       
 57748 2007-01-24  Sam Weinig  <sam@webkit.org>
       
 57749 
       
 57750         Reviewed by Mitz.
       
 57751 
       
 57752         Patch for http://bugs.webkit.org/show_bug.cgi?id=12394
       
 57753         Cleanup RenderBox
       
 57754 
       
 57755         No functionality changes, just a good old fashion cleanup,
       
 57756         thus no tests.
       
 57757 
       
 57758         * rendering/RenderBox.cpp:
       
 57759         (WebCore::RenderBox::RenderBox):
       
 57760         (WebCore::RenderBox::setStyle):
       
 57761         (WebCore::RenderBox::destroy):
       
 57762         (WebCore::RenderBox::setPos):
       
 57763         (WebCore::RenderBox::calcBorderBoxWidth):
       
 57764         (WebCore::RenderBox::calcBorderBoxHeight):
       
 57765         (WebCore::RenderBox::calcContentBoxWidth):
       
 57766         (WebCore::RenderBox::calcContentBoxHeight):
       
 57767         (WebCore::RenderBox::nodeAtPoint):
       
 57768         (WebCore::RenderBox::paintRootBoxDecorations):
       
 57769         (WebCore::RenderBox::paintBoxDecorations):
       
 57770         (WebCore::RenderBox::paintBackgrounds):
       
 57771         (WebCore::RenderBox::paintBackground):
       
 57772         (WebCore::cacluateBackgroundSize):
       
 57773         (WebCore::RenderBox::paintBackgroundExtended):
       
 57774         (WebCore::RenderBox::getOverflowClipRect):
       
 57775         (WebCore::RenderBox::getClipRect):
       
 57776         (WebCore::RenderBox::containingBlockWidth):
       
 57777         (WebCore::RenderBox::absolutePosition):
       
 57778         (WebCore::RenderBox::dirtyLineBoxes):
       
 57779         (WebCore::RenderBox::position):
       
 57780         (WebCore::RenderBox::getAbsoluteRepaintRect):
       
 57781         (WebCore::RenderBox::computeAbsoluteRepaintRect):
       
 57782         (WebCore::RenderBox::repaintDuringLayoutIfMoved):
       
 57783         (WebCore::RenderBox::relativePositionOffsetX):
       
 57784         (WebCore::RenderBox::relativePositionOffsetY):
       
 57785         (WebCore::RenderBox::calcWidth):
       
 57786         (WebCore::RenderBox::calcWidthUsing):
       
 57787         (WebCore::RenderBox::sizesToIntrinsicWidth):
       
 57788         (WebCore::RenderBox::calcHorizontalMargins):
       
 57789         (WebCore::RenderBox::calcHeight):
       
 57790         (WebCore::RenderBox::calcPercentageHeight):
       
 57791         (WebCore::RenderBox::calcReplacedWidthUsing):
       
 57792         (WebCore::RenderBox::calcReplacedHeightUsing):
       
 57793         (WebCore::RenderBox::availableHeightUsing):
       
 57794         (WebCore::RenderBox::calcVerticalMargins):
       
 57795         (WebCore::RenderBox::containingBlockWidthForPositioned):
       
 57796         (WebCore::RenderBox::calcAbsoluteHorizontal):
       
 57797         (WebCore::RenderBox::calcAbsoluteHorizontalValues):
       
 57798         (WebCore::RenderBox::calcAbsoluteVertical):
       
 57799         (WebCore::RenderBox::calcAbsoluteVerticalValues):
       
 57800         (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
       
 57801         (WebCore::RenderBox::caretRect):
       
 57802         * rendering/RenderBox.h:
       
 57803         (WebCore::RenderBox::setOverrideSize):
       
 57804         (WebCore::RenderBox::width):
       
 57805         (WebCore::RenderBox::height):
       
 57806         (WebCore::RenderBox::setWidth):
       
 57807         (WebCore::RenderBox::setHeight):
       
 57808         (WebCore::RenderBox::inlineBoxWrapper):
       
 57809         (WebCore::RenderBox::setInlineBoxWrapper):
       
 57810         (WebCore::RenderBox::stretchesToViewHeight):
       
 57811         (WebCore::RenderBox::setStaticX):
       
 57812         (WebCore::RenderBox::setStaticY):
       
 57813 
       
 57814 2007-01-24  Eric Seidel  <eric@webkit.org>
       
 57815 
       
 57816         Reviewed by ap.
       
 57817 
       
 57818         Converted SVGTransform from being Shared<T> to a POD type.
       
 57819 
       
 57820         No functional changes, thus no tests.
       
 57821 
       
 57822         * bindings/scripts/CodeGenerator.pm:
       
 57823         * bindings/scripts/CodeGeneratorJS.pm:
       
 57824         * ksvg2/misc/SVGTimer.cpp:
       
 57825         (WebCore::baseValueTransformList):
       
 57826         * ksvg2/svg/SVGAnimateTransformElement.cpp:
       
 57827         (WebCore::SVGAnimateTransformElement::storeInitialValue):
       
 57828         (WebCore::SVGAnimateTransformElement::resetValues):
       
 57829         (WebCore::SVGAnimateTransformElement::updateCurrentValue):
       
 57830         (WebCore::SVGAnimateTransformElement::handleStartCondition):
       
 57831         (WebCore::SVGAnimateTransformElement::applyAnimationToValue):
       
 57832         (WebCore::SVGAnimateTransformElement::parseTransformValue):
       
 57833         * ksvg2/svg/SVGAnimateTransformElement.h:
       
 57834         * ksvg2/svg/SVGLinearGradientElement.cpp:
       
 57835         (WebCore::SVGLinearGradientElement::collectGradientProperties):
       
 57836         * ksvg2/svg/SVGPatternElement.cpp:
       
 57837         (WebCore::SVGPatternElement::collectPatternProperties):
       
 57838         * ksvg2/svg/SVGRadialGradientElement.cpp:
       
 57839         (WebCore::SVGRadialGradientElement::collectGradientProperties):
       
 57840         * ksvg2/svg/SVGSVGElement.cpp:
       
 57841         (WebCore::SVGSVGElement::createSVGTransform):
       
 57842         (WebCore::SVGSVGElement::createSVGTransformFromMatrix):
       
 57843         * ksvg2/svg/SVGSVGElement.h:
       
 57844         * ksvg2/svg/SVGStyledTransformableElement.cpp:
       
 57845         (WebCore::SVGStyledTransformableElement::updateLocalTransform):
       
 57846         * ksvg2/svg/SVGTextElement.cpp:
       
 57847         (WebCore::SVGTextElement::updateLocalTransform):
       
 57848         * ksvg2/svg/SVGTransform.cpp:
       
 57849         (SVGTransform::SVGTransform):
       
 57850         (SVGTransform::isValid):
       
 57851         * ksvg2/svg/SVGTransform.h:
       
 57852         * ksvg2/svg/SVGTransform.idl:
       
 57853         * ksvg2/svg/SVGTransformList.cpp:
       
 57854         (SVGTransformList::SVGTransformList):
       
 57855         (SVGTransformList::createSVGTransformFromMatrix):
       
 57856         (SVGTransformList::consolidate):
       
 57857         (SVGTransformList::concatenate):
       
 57858         * ksvg2/svg/SVGTransformList.h:
       
 57859         * ksvg2/svg/SVGTransformable.cpp:
       
 57860         (WebCore::SVGTransformable::parseTransformAttribute):
       
 57861 
       
 57862 2007-01-24  Mark Rowe  <mrowe@apple.com>
       
 57863 
       
 57864         Reviewed by Eric.
       
 57865 
       
 57866         Plug another bunch of SVG memory leaks.
       
 57867 
       
 57868         * ksvg2/misc/SVGDocumentExtensions.cpp:
       
 57869         (WebCore::SVGDocumentExtensions::~SVGDocumentExtensions): Delete memory we have allocated.
       
 57870         (WebCore::SVGDocumentExtensions::removePendingResource): Return an auto_ptr to show that we are transferring ownership.
       
 57871         * ksvg2/misc/SVGDocumentExtensions.h:
       
 57872         * ksvg2/svg/SVGElement.cpp:
       
 57873         (WebCore::SVGElement::insertedIntoDocument): Update for use of auto_ptr.
       
 57874 
       
 57875 2007-01-23  Mark Rowe  <mrowe@apple.com>
       
 57876 
       
 57877         Reviewed by Brady.
       
 57878 
       
 57879         Plug thousands of node leaks seen running layout tests.
       
 57880 
       
 57881         * ksvg2/svg/SVGElementInstance.cpp:
       
 57882         (WebCore::SVGElementInstance::~SVGElementInstance): Disassociate ourselves from our children so they will
       
 57883         be destroyed if we were the only thing referencing them.
       
 57884         * ksvg2/svg/SVGUseElement.cpp:
       
 57885         (WebCore::SVGUseElement::removedFromDocument):
       
 57886         * ksvg2/svg/SVGUseElement.h:
       
 57887 
       
 57888 2007-01-23  Alice Liu  <alice.liu@apple.com>
       
 57889 
       
 57890         Reviewed by Brady.
       
 57891 
       
 57892         * editing/Editor.cpp:
       
 57893         (WebCore::Editor::appliedEditing):
       
 57894         minor change.  removing unnecessary call to frame to fetch editor
       
 57895 
       
 57896 2007-01-23  Mark Rowe  <mrowe@apple.com>
       
 57897 
       
 57898         Reviewed by Adele.
       
 57899 
       
 57900         http://bugs.webkit.org/show_bug.cgi?id=12375
       
 57901         Bug 12375: REGRESSION(r19038): fast/dom/title-text-property-2.html failing
       
 57902 
       
 57903         Fix regression by making setTitle/updateTitle/removeTitle logic match document.title
       
 57904         specification at http://whatwg.org/specs/web-apps/current-work/#the-title1.
       
 57905 
       
 57906         * dom/Document.cpp:
       
 57907         (WebCore::Document::setTitle): Materialize a title element into the head if one doesn't exist when setting
       
 57908         document.title.  Also update the contents of the title element when the title is set via document.title.
       
 57909         (WebCore::Document::removeTitle): Update the title based on first title element in the head, if one exists.
       
 57910         (WebCore::Document::head): Convenience method to retrieve the head element in an HTML document.
       
 57911         * dom/Document.h:
       
 57912 
       
 57913 2007-01-23  Beth Dakin  <bdakin@apple.com>
       
 57914 
       
 57915         Reviewed by Hyatt.
       
 57916 
       
 57917         Follow-up to the fix below for 4843226.
       
 57918 
       
 57919         * rendering/RenderLayer.cpp:
       
 57920         (WebCore::transparencyClipBox): Has to be recursive or we will miss 
       
 57921         out on grandchildren!
       
 57922 
       
 57923 2007-01-23  Oliver Hunt  <oliver@apple.com>
       
 57924 
       
 57925         Reviewed by Adam.
       
 57926 
       
 57927         Fixes dropping of files into safari
       
 57928 
       
 57929         * page/DragController.cpp:
       
 57930         (WebCore::DragController::performDrag):
       
 57931 
       
 57932 2007-01-23  Brady Eidson  <beidson@apple.com>
       
 57933 
       
 57934         Reviewed by Darin
       
 57935 
       
 57936         Added a couple of CF things previously missed
       
 57937 
       
 57938         * platform/network/ResourceError.h:
       
 57939         * platform/network/ResourceHandle.h:
       
 57940 
       
 57941 2007-01-23  Nikolas Zimmermann  <zimmermann@kde.org>
       
 57942 
       
 57943         Reviewed by Maciej.
       
 57944 
       
 57945         Fix evil genericContext() assertion, which occours sometimes when running DRT.
       
 57946         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12379
       
 57947 
       
 57948         * bindings/scripts/CodeGeneratorJS.pm:
       
 57949         * ksvg2/misc/SVGDocumentExtensions.h:
       
 57950         (WebCore::SVGDocumentExtensions::genericContextMap):
       
 57951         (WebCore::SVGDocumentExtensions::forgetGenericContext):
       
 57952 
       
 57953 2007-01-23  Beth Dakin  <bdakin@apple.com>
       
 57954 
       
 57955         Reviewed by Hyatt.
       
 57956 
       
 57957         Fix for <rdar://problem/4843226> REGRESSION: Pull down menu appears 
       
 57958         clipped at http://istweb.apple.com/
       
 57959 
       
 57960         * rendering/RenderLayer.cpp:
       
 57961         (WebCore::transparencyClipBox): Always unite with sibling rects.
       
 57962 
       
 57963 2007-01-22  Justin Garcia  <justin.garcia@apple.com>
       
 57964 
       
 57965         Reviewed by john
       
 57966 
       
 57967         <rdar://problem/4920742>
       
 57968         REGRESSION: GMail Editor: Attempting to remove formatting from selection results in a crash at WebCore::Range::checkDeleteExtract()
       
 57969 
       
 57970         * dom/Range.cpp:
       
 57971         (WebCore::Range::checkDeleteExtract): Return if there is no
       
 57972         commonAncestor container or if commonAncestorContainer() throws
       
 57973         an exception.
       
 57974         * editing/Editor.cpp:
       
 57975         (WebCore::Editor::removeFormattingAndStyle): Fixed a bug that reversed
       
 57976         the order of the selected paragraphs.
       
 57977 
       
 57978 2007-01-23  Nikolas Zimmermann  <zimmermann@kde.org>
       
 57979 
       
 57980         Reviewed by Sam.
       
 57981 
       
 57982         Fix dynamic creation/updates of markers, masks, clipPaths, and several tiny pattern issues.
       
 57983         Added 16 (!) new layout tests covering quite some weird scenerios - Batik & Opera do have problems, we don't.
       
 57984 
       
 57985         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12380
       
 57986         Fixes: svg/custom/image-with-transform-clip-filter.svg (filter shows up again)
       
 57987 
       
 57988         Added: svg/custom/clip-path-child-changes.svg
       
 57989         Added: svg/custom/clip-path-href-changes.svg
       
 57990         Added: svg/custom/clip-path-units-changes.svg
       
 57991         Added: svg/custom/deep-dynamic-updates.svg
       
 57992         Added: svg/custom/js-late-clipPath-and-object-creation.svg
       
 57993         Added: svg/custom/js-late-clipPath-creation.svg
       
 57994         Added: svg/custom/js-late-marker-and-object-creation.svg
       
 57995         Added: svg/custom/js-late-marker-creation.svg
       
 57996         Added: svg/custom/js-late-mask-and-object-creation.svg
       
 57997         Added: svg/custom/js-late-mask-creation.svg
       
 57998         Added: svg/custom/js-update-pattern-child.svg
       
 57999         Added: svg/custom/marker-changes.svg
       
 58000         Added: svg/custom/marker-child-changes.svg
       
 58001         Added: svg/custom/marker-viewBox-changes.svg
       
 58002         Added: svg/custom/mask-changes.svg
       
 58003         Added: svg/custom/mask-child-changes.svg
       
 58004 
       
 58005         * ksvg2/misc/KCanvasRenderingStyle.cpp:
       
 58006         (WebCore::KSVGPainterFactory::fillPaintServer):
       
 58007         (WebCore::KSVGPainterFactory::strokePaintServer):
       
 58008         * ksvg2/svg/SVGClipPathElement.cpp:
       
 58009         (WebCore::SVGClipPathElement::notifyAttributeChange):
       
 58010         * ksvg2/svg/SVGClipPathElement.h:
       
 58011         * ksvg2/svg/SVGGradientElement.cpp:
       
 58012         * ksvg2/svg/SVGGradientElement.h:
       
 58013         * ksvg2/svg/SVGMarkerElement.cpp:
       
 58014         (WebCore::SVGMarkerElement::canvasResource):
       
 58015         (WebCore::SVGMarkerElement::notifyAttributeChange):
       
 58016         * ksvg2/svg/SVGMarkerElement.h:
       
 58017         * ksvg2/svg/SVGMaskElement.cpp:
       
 58018         (WebCore::SVGMaskElement::notifyAttributeChange):
       
 58019         * ksvg2/svg/SVGMaskElement.h:
       
 58020         * ksvg2/svg/SVGStopElement.cpp:
       
 58021         (WebCore::SVGStopElement::notifyAttributeChange):
       
 58022         * ksvg2/svg/SVGStyledElement.cpp:
       
 58023         (WebCore::SVGStyledElement::notifyAttributeChange):
       
 58024         (WebCore::SVGStyledElement::notifyResourceParentIfExistant):
       
 58025         (WebCore::SVGStyledElement::rebuildRenderer):
       
 58026         * ksvg2/svg/SVGStyledElement.h:
       
 58027         * ksvg2/svg/SVGUseElement.cpp:
       
 58028         (WebCore::SVGUseElement::notifyAttributeChange):
       
 58029         * platform/graphics/svg/SVGResource.cpp:
       
 58030         (WebCore::SVGResource::invalidate):
       
 58031         (WebCore::SVGResource::addClient):
       
 58032         (WebCore::SVGResource::repaintClients):
       
 58033         * platform/graphics/svg/SVGResource.h:
       
 58034         * platform/graphics/svg/SVGResourceMarker.cpp:
       
 58035         (WebCore::SVGResourceMarker::draw):
       
 58036         (WebCore::SVGResourceMarker::cachedBounds):
       
 58037         * platform/graphics/svg/SVGResourceMarker.h:
       
 58038         * rendering/RenderPath.cpp:
       
 58039         (WebCore::RenderPath::layout):
       
 58040         (WebCore::RenderPath::getAbsoluteRepaintRect):
       
 58041         (WebCore::RenderPath::paint):
       
 58042         (WebCore::drawMarkerWithData):
       
 58043         (WebCore::RenderPath::drawMarkersIfNeeded):
       
 58044         * rendering/RenderPath.h:
       
 58045         * rendering/RenderSVGContainer.cpp:
       
 58046         (WebCore::RenderSVGContainer::paint):
       
 58047         (WebCore::RenderSVGContainer::getAbsoluteRepaintRect):
       
 58048         * rendering/RenderSVGImage.cpp:
       
 58049         (WebCore::RenderSVGImage::paint):
       
 58050         (WebCore::RenderSVGImage::getAbsoluteRepaintRect):
       
 58051         * rendering/SVGInlineFlowBox.cpp:
       
 58052         (WebCore::paintSVGInlineFlow):
       
 58053 
       
 58054 2007-01-23  Adele Peterson  <adele@apple.com>
       
 58055 
       
 58056         Reviewed by Darin.
       
 58057         
       
 58058         WebCore part of fix for <rdar://problem/4946753>REGRESSION: Inserting tabs is broken in Mail
       
 58059 
       
 58060         In addition to this fix, I also reorganized some event handling code for keyPress events to
       
 58061         prepare for another fix.  There's also just a little bit of unrelated cleanup.
       
 58062         
       
 58063         * dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler):
       
 58064           Move tab focus behavior into new defaultKeyboardEventHandler method.
       
 58065         
       
 58066         * bridge/EditorClient.h: Added handleKeyPress.
       
 58067         * editing/Editor.cpp:
       
 58068         (WebCore::Editor::handleKeyPress): Added. Calls over to the client method.
       
 58069         (WebCore::Editor::deleteRange): Removed unnecessary propogateDOMException.
       
 58070         * editing/Editor.h: Added handleKeyPress.
       
 58071         (WebCore::Editor::addToKillRing): Formatting cleanup.
       
 58072         * editing/mac/EditorMac.mm: Removed unnecessary propogateDOMException.
       
 58073         
       
 58074         * page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): Added. Checks
       
 58075           the tabKeyCyclesThroughElements setting before advancing focus for tab key events.  Calls handleKeyPress.
       
 58076         * page/EventHandler.h: Added defaultKeyboardEventHandler.
       
 58077         
       
 58078         * page/Page.cpp: (WebCore::Page::Page): Initialize m_tabKeyCyclesThroughElements to true.
       
 58079         * page/Page.h: Added m_tabKeyCyclesThroughElements.
       
 58080         (WebCore::Page::setTabKeyCyclesThroughElements): Added.
       
 58081         (WebCore::Page::tabKeyCyclesThroughElements): Added.
       
 58082         
       
 58083         * platform/PlatformKeyboardEvent.h: Added ability to get NSEvent from PlatformKeyboardEvent.
       
 58084         * platform/mac/KeyEventMac.mm: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
       
 58085           Initialize m_macEvent to the NSEvent.
       
 58086         
       
 58087         * platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::handleKeyPress): Added.
       
 58088 
       
 58089 2007-01-23  George Staikos  <staikos@kde.org>
       
 58090 
       
 58091         Compile with a released Qt.
       
 58092 
       
 58093         * platform/graphics/qt/ImageQt.cpp:
       
 58094 
       
 58095 2007-01-23  Lars Knoll <lars@trolltech.com>
       
 58096 
       
 58097         Reviewed by Zack
       
 58098 
       
 58099         Widget and ScrollView do not own the Qt widgets
       
 58100         anymore. Make sure they can handle the case of
       
 58101         a null QWidget and never delete them.
       
 58102 
       
 58103         * platform/qt/ScrollViewQt.cpp:
       
 58104         (WebCore::ScrollView::setScrollArea):
       
 58105         (WebCore::ScrollView::updateContents):
       
 58106         (WebCore::ScrollView::visibleWidth):
       
 58107         (WebCore::ScrollView::visibleHeight):
       
 58108         (WebCore::ScrollView::visibleContentRect):
       
 58109         (WebCore::ScrollView::setContentsPos):
       
 58110         (WebCore::ScrollView::resizeContents):
       
 58111         (WebCore::ScrollView::contentsX):
       
 58112         (WebCore::ScrollView::contentsY):
       
 58113         (WebCore::ScrollView::contentsWidth):
       
 58114         (WebCore::ScrollView::contentsHeight):
       
 58115         (WebCore::ScrollView::scrollOffset):
       
 58116         (WebCore::ScrollView::scrollBy):
       
 58117         (WebCore::ScrollView::hScrollbarMode):
       
 58118         (WebCore::ScrollView::vScrollbarMode):
       
 58119         (WebCore::ScrollView::setHScrollbarMode):
       
 58120         (WebCore::ScrollView::setVScrollbarMode):
       
 58121         * platform/qt/WidgetQt.cpp:
       
 58122         (WebCore::WidgetPrivate::~WidgetPrivate):
       
 58123         (WebCore::Widget::setQWidget):
       
 58124 
       
 58125 2007-01-23  Zack Rusin  <zack@kde.org>
       
 58126 
       
 58127         Forgot to add one new file to the build.
       
 58128 
       
 58129         * WebCore.pro: Add dom/clipboard.cpp
       
 58130 
       
 58131 2007-01-23  Zack Rusin  <zack@kde.org>
       
 58132 
       
 58133         Fix the Qt build
       
 58134 
       
 58135         * page/DragActions.h:
       
 58136         * page/DragController.cpp:
       
 58137         * platform/qt/DragDataQt.cpp:
       
 58138         (WebCore::DragData::canSmartReplace):
       
 58139         (WebCore::DragData::containsColor):
       
 58140         (WebCore::DragData::containsPlainText):
       
 58141         (WebCore::DragData::asPlainText):
       
 58142         (WebCore::DragData::asColor):
       
 58143         (WebCore::DragData::createClipboard):
       
 58144         (WebCore::DragData::containsCompatibleContent):
       
 58145         (WebCore::DragData::containsURL):
       
 58146         (WebCore::DragData::asURL):
       
 58147         (WebCore::DragData::asFragment):
       
 58148         * platform/qt/FileChooserQt.cpp:
       
 58149 
       
 58150 2007-01-23  Lars Knoll <lars@trolltech.com>
       
 58151 
       
 58152         Reviewed by Maciej
       
 58153 
       
 58154         Make the last remaining pieces of the FrameLoader platform 
       
 58155         independent. Move most of the code over to WebFrameLoaderClient.
       
 58156         Some smaller cleanups in the WebFrameBridge, and moved some
       
 58157         platform independent functionality over to the shared code
       
 58158         in WebCore.
       
 58159         
       
 58160         * WebCore.exp:
       
 58161         * WebCore.pro:
       
 58162         * WebCore.xcodeproj/project.pbxproj:
       
 58163         * loader/FrameLoader.cpp:
       
 58164         (WebCore::FrameLoader::loadSubframe):
       
 58165         (WebCore::FrameLoader::shouldUsePlugin):
       
 58166         (WebCore::FrameLoader::loadPlugin):
       
 58167         (WebCore::FrameLoader::detachFromParent):
       
 58168         (WebCore::FrameLoader::partClearedInBegin):
       
 58169         (WebCore::FrameLoader::createJavaAppletWidget):
       
 58170         (WebCore::FrameLoader::didChangeTitle):
       
 58171         * loader/FrameLoader.h:
       
 58172         * loader/FrameLoaderClient.h:
       
 58173         * loader/FrameLoaderTypes.h:
       
 58174         (WebCore::):
       
 58175         * loader/PluginDocument.cpp:
       
 58176         (WebCore::PluginTokenizer::writeRawData):
       
 58177         * loader/mac/FrameLoaderMac.mm: Removed.
       
 58178         * loader/qt/FrameLoaderQt.cpp: Removed.
       
 58179         * page/Frame.cpp:
       
 58180         (WebCore::Frame::Frame):
       
 58181         * page/FrameView.cpp:
       
 58182         (WebCore::FrameView::mediaType):
       
 58183         * page/qt/FrameQt.cpp:
       
 58184         (WebCore::FrameQt::FrameQt):
       
 58185         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 58186         (WebCore::SVGEmptyFrameLoaderClient::makeRepresentation):
       
 58187         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
       
 58188         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCommitLoad):
       
 58189         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoad):
       
 58190         (WebCore::SVGEmptyFrameLoaderClient::dispatchCreatePage):
       
 58191         (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
       
 58192         (WebCore::SVGEmptyFrameLoaderClient::dispatchUnableToImplementPolicy):
       
 58193         (WebCore::SVGEmptyFrameLoaderClient::revertToProvisionalState):
       
 58194         (WebCore::SVGEmptyFrameLoaderClient::setMainDocumentError):
       
 58195         (WebCore::SVGEmptyFrameLoaderClient::startDownload):
       
 58196         (WebCore::SVGEmptyFrameLoaderClient::committedLoad):
       
 58197         (WebCore::SVGEmptyFrameLoaderClient::shouldFallBack):
       
 58198         (WebCore::SVGEmptyFrameLoaderClient::willUseArchive):
       
 58199         (WebCore::SVGEmptyFrameLoaderClient::createDocumentLoader):
       
 58200         (WebCore::SVGEmptyFrameLoaderClient::createFrame):
       
 58201         (WebCore::SVGEmptyFrameLoaderClient::createPlugin):
       
 58202         (WebCore::SVGEmptyFrameLoaderClient::createJavaAppletWidget):
       
 58203         (WebCore::SVGEmptyFrameLoaderClient::objectContentType):
       
 58204         (WebCore::SVGEmptyFrameLoaderClient::overrideMediaType):
       
 58205         (WebCore::SVGEmptyFrameLoaderClient::redirectDataToPlugin):
       
 58206         (WebCore::SVGEmptyFrameLoaderClient::windowObjectCleared):
       
 58207 
       
 58208 2007-01-23  Oliver Hunt  <oliver@apple.com>
       
 58209 
       
 58210         Reviewed by Adam.
       
 58211 
       
 58212         Added DragController to handled drag and drop state and control logic.
       
 58213         Currently this only handles logic for Dragging and Dropping, and is 
       
 58214         unable to initialise a drag itself.
       
 58215 
       
 58216         platform/DragData encapsulate the paltform Drag data (NSDraggingInfo on Mac, 
       
 58217         QMimeType in Qt).  This provides methods to pull data out the drag data as a String, 
       
 58218         a URL, a DocumentFragment (for rich content), or a Colour.
       
 58219 
       
 58220         * WebCore.exp:
       
 58221         * WebCore.pro:
       
 58222         * WebCore.xcodeproj/project.pbxproj:
       
 58223         * dom/Clipboard.cpp: Added.
       
 58224         (WebCore::Clipboard::setAccessPolicy):
       
 58225         (WebCore::dragOpFromIEOp):
       
 58226         (WebCore::IEOpFromDragOp):
       
 58227         (WebCore::Clipboard::sourceOperation):
       
 58228         (WebCore::Clipboard::destinationOperation):
       
 58229         (WebCore::Clipboard::setSourceOperation):
       
 58230         (WebCore::Clipboard::setDestinationOperation):
       
 58231         (WebCore::Clipboard::setDropEffect):
       
 58232         (WebCore::Clipboard::setEffectAllowed):
       
 58233           move platform independent functions from ClipboardMac to Clipboard
       
 58234 
       
 58235         * dom/Clipboard.h:
       
 58236         (WebCore::Clipboard::Clipboard):
       
 58237         (WebCore::Clipboard::dropEffect):
       
 58238         (WebCore::Clipboard::effectAllowed):
       
 58239         (WebCore::Clipboard::policy):
       
 58240           as above -- also removed virtual modifier from now 
       
 58241           platform independent methods
       
 58242 
       
 58243         * editing/Editor.cpp:
       
 58244         (WebCore::Editor::smartInsertDeleteEnabled): 
       
 58245         (WebCore::Editor::shouldApplyStyle):
       
 58246         * editing/Editor.h:
       
 58247           adding calls through to EditorClient
       
 58248          
       
 58249         * page/DragActions.h: Added.
       
 58250         (WebCore::):
       
 58251           Replicates a number of NS* enums in the WebCore namespace
       
 58252 
       
 58253         * page/DragClient.h: Added.
       
 58254         (WebCore::DragClient::~DragClient):
       
 58255           Standard client interface for dragging UIDelegate
       
 58256 
       
 58257         * page/DragController.cpp: Added.
       
 58258         (WebCore::createMouseEvent):
       
 58259         (WebCore::DragController::DragController):
       
 58260         (WebCore::DragController::~DragController):
       
 58261         (WebCore::documentFragmentFromDragData):
       
 58262         (WebCore::DragController::isMoveDrag):
       
 58263         (WebCore::visiblePositionForPoint):
       
 58264         (WebCore::DragController::cancelDrag):
       
 58265         (WebCore::documentAtPoint):
       
 58266         (WebCore::DragController::dragEntered):
       
 58267         (WebCore::DragController::dragExited):
       
 58268         (WebCore::DragController::dragUpdated):
       
 58269         (WebCore::DragController::performDrag):
       
 58270         (WebCore::DragController::dragEnteredOrUpdated):
       
 58271         (WebCore::DragController::tryDocumentDrag):
       
 58272         (WebCore::DragController::operationForLoad):
       
 58273         (WebCore::DragController::concludeDrag):
       
 58274         (WebCore::DragController::canProcessDrag):
       
 58275         (WebCore::DragController::tryDHTMLDrag):
       
 58276           Class to handle state and logic for dragging and dropping
       
 58277 
       
 58278         * page/DragController.h: Added.
       
 58279         (WebCore::DragController::client):
       
 58280         (WebCore::DragController::didInitiateDrag):
       
 58281         (WebCore::DragController::isHandlingDrag):
       
 58282         (WebCore::DragController::dragOperation):
       
 58283         (WebCore::DragController::document):
       
 58284         (WebCore::DragController::dragInitiator):
       
 58285         (WebCore::DragController::dragDestinationAction):
       
 58286         (WebCore::DragController::dragSourceAction):
       
 58287         (WebCore::DragController::dragEnded):
       
 58288         (WebCore::DragController::setIsHandlingDrag):
       
 58289         (WebCore::DragController::setDidInitiateDrag):
       
 58290         (WebCore::DragController::setDragOperation):
       
 58291         (WebCore::DragController::setDragSourceAction):
       
 58292         (WebCore::DragController::setDragInitiator):
       
 58293           See above
       
 58294 
       
 58295         * page/Page.cpp:
       
 58296         (WebCore::Page::Page):
       
 58297           Update Page to have DragController
       
 58298 
       
 58299         * page/Page.h:
       
 58300         (WebCore::Page::dragController):
       
 58301           ditto
       
 58302 
       
 58303         * page/mac/DragControllerMac.mm: Added.
       
 58304         (WebCore::DragController::isCopyKeyDown):
       
 58305         (WebCore::DragController::dragOperation):
       
 58306           Platform specific portions of the DragController
       
 58307 
       
 58308         * page/mac/EventHandlerMac.mm:
       
 58309         (WebCore::EventHandler::handleDrag):
       
 58310         (WebCore::EventHandler::dragSourceEndedAt):
       
 58311           Convert from NSDragOperation to WebCore::DragOperation
       
 58312 
       
 58313         * page/mac/WebCoreFrameBridge.h:
       
 58314         * page/mac/WebCoreFrameBridge.mm:
       
 58315           Remove obsolete Drag functions
       
 58316 
       
 58317         * page/qt/DragControllerQt.cpp: Added.
       
 58318         (WebCore::DragController::isCopyKeyDown):
       
 58319         (WebCore::DragController::dragOperation):
       
 58320           Basic stubs to maintain Qt  build
       
 58321 
       
 58322         * platform/DragData.cpp: Added.
       
 58323         (WebCore::DragData::DragData):
       
 58324         * platform/DragData.h: Added.
       
 58325         (WebCore::DragData::clientPosition):
       
 58326         (WebCore::DragData::globalPosition):
       
 58327         (WebCore::DragData::platformData):
       
 58328         (WebCore::DragData::draggingSourceOperationMask):
       
 58329           DragData class to encapsulate platform drag data/event
       
 58330 
       
 58331         * platform/graphics/svg/SVGImage.cpp:
       
 58332         (WebCore::SVGImage::setData):
       
 58333           Addition of dummy DragClient
       
 58334 
       
 58335         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 58336         (WebCore::SVGEmptyDragClient::~SVGEmptyDragClient):
       
 58337         (WebCore::SVGEmptyDragClient::willPerformDragDestinationAction):
       
 58338         (WebCore::SVGEmptyDragClient::actionMaskForDrag):
       
 58339         (WebCore::SVGEmptyDragClient::dragControllerDestroyed):
       
 58340           ditto
       
 58341 
       
 58342         * platform/mac/ClipboardMac.h:
       
 58343         * platform/mac/ClipboardMac.mm:
       
 58344         (WebCore::ClipboardMac::ClipboardMac):
       
 58345         (WebCore::ClipboardMac::clearData):
       
 58346         (WebCore::ClipboardMac::clearAllData):
       
 58347         (WebCore::ClipboardMac::getData):
       
 58348         (WebCore::ClipboardMac::setData):
       
 58349         (WebCore::ClipboardMac::types):
       
 58350         (WebCore::ClipboardMac::setDragImage):
       
 58351          Moving platform independent logic to Clipboard, and updating
       
 58352          platform specific methods to use appropriate accessors rather than 
       
 58353          directly manipulating data they no longer own
       
 58354 
       
 58355         * platform/mac/DragDataMac.mm: Added.
       
 58356         (WebCore::DragData::DragData):
       
 58357         (WebCore::DragData::canSmartReplace):
       
 58358         (WebCore::DragData::containsColor):
       
 58359         (WebCore::DragData::containsPlainText):
       
 58360         (WebCore::DragData::asPlainText):
       
 58361         (WebCore::DragData::asColor):
       
 58362         (WebCore::DragData::createClipboard):
       
 58363         (WebCore::imageExistsAtPaths):
       
 58364         (WebCore::DragData::containsCompatibleContent):
       
 58365         (WebCore::DragData::containsURL):
       
 58366         (WebCore::DragData::asURL):
       
 58367         (WebCore::DragData::asFragment):
       
 58368           Mac implementations of DragData methods.  A number of these use
       
 58369           a Helper class that accesses WebKit functionality.  That functionality 
       
 58370           should be migrated to WebCore in the future.
       
 58371 
       
 58372         * platform/mac/PasteboardHelper.h: Added.
       
 58373         (WebCore::PasteboardHelper::~PasteboardHelper):
       
 58374           Temporary, and Mac only, helper class to access WebKit functionality 
       
 58375           from WebCore
       
 58376 
       
 58377         * platform/qt/DragDataQt.cpp: Added.
       
 58378         (WebCore::DragData::canSmartReplace):
       
 58379         (WebCore::DragData::containsColor):
       
 58380         (WebCore::DragData::containsPlainText):
       
 58381         (WebCore::DragData::asPlainText):
       
 58382         (WebCore::DragData::asColor):
       
 58383         (WebCore::DragData::createClipboard):
       
 58384         (WebCore::DragData::containsCompatibleContent):
       
 58385         (WebCore::DragData::containsURL):
       
 58386         (WebCore::DragData::asURL):
       
 58387         (WebCore::DragData::asFragment):
       
 58388          Basic stubs to maintain Qt build
       
 58389 
       
 58390         * rendering/HitTestResult.cpp:
       
 58391         (WebCore::HitTestResult::HitTestResult):
       
 58392          Correct HitTestResult copy contructor to copy localPoint
       
 58393 
       
 58394 2007-01-22  Mark Rowe  <mrowe@apple.com>
       
 58395 
       
 58396         Reviewed by Maciej.
       
 58397 
       
 58398         http://bugs.webkit.org/show_bug.cgi?id=11692
       
 58399         Bug 11692: REGRESSION(r17352): Disappearing page title
       
 58400 
       
 58401         * dom/Document.cpp:
       
 58402         (WebCore::Document::setTitle): If the title has already been set explicitly via JavaScript,
       
 58403         ignore any changes to it due to encountering <title> tags.
       
 58404 
       
 58405 2007-01-22  Mitz Pettel  <mitz@webkit.org>
       
 58406 
       
 58407         Reviewed by Darin.
       
 58408 
       
 58409         - fix http://bugs.webkit.org/show_bug.cgi?id=12344
       
 58410           NativeListBox: item hit testing does not account for top padding and border
       
 58411 
       
 58412         Test: fast/forms/listbox-selection-2.html
       
 58413 
       
 58414         * rendering/RenderListBox.cpp:
       
 58415         (WebCore::RenderListBox::numVisibleItems): Changed height() to contentHeight()
       
 58416         since items are visible only in the content box.
       
 58417         (WebCore::RenderListBox::listIndexAtOffset): Adjusted for vertical padding and
       
 58418         borders. Changed to return -1 instead of the last item's index if the given offset
       
 58419         is below the last item.
       
 58420         (WebCore::RenderListBox::autoscroll): Adjusted for vertical padding and borders.
       
 58421         (WebCore::RenderListBox::controlClipRect): Changed to return the content box since
       
 58422         items should not spill into the padding box. This change is the reason the test
       
 58423         generates pixel results.
       
 58424 
       
 58425 2007-01-22  Justin Garcia  <justin.garcia@apple.com>
       
 58426 
       
 58427         Reviewed by darin
       
 58428         
       
 58429         <rdar://problem/4944770>
       
 58430         editing/pasteboard/4641033 layout test is broken (12328)
       
 58431         
       
 58432         This layout test failure demonstrates three bugs:
       
 58433         Smart replace shouldn't be turned on, but is because a word
       
 58434         selection granularity from the previous test isn't cleared.
       
 58435         Smart replace shouldn't add any spaces because the paste is performed
       
 58436         in an empty paragraph.
       
 58437         Smart replace spaces are added to the text of options inside
       
 58438         the select element instead of before/after the select element.
       
 58439         
       
 58440         This patch fixes the second two problems.  During a 
       
 58441         ReplaceSelectionCommand, the VisiblePosition for the end of 
       
 58442         the inserted content is the last position in the last leaf 
       
 58443         inserted.  This is a problem when the last leaf is inside a 
       
 58444         select element, since VP creation is inconsistent there.  
       
 58445         Second, smart spaces were inserted inside the last leaf, not
       
 58446         at the endOfInsertedContent.
       
 58447 
       
 58448         * editing/ReplaceSelectionCommand.cpp:
       
 58449         (WebCore::ReplaceSelectionCommand::shouldMergeStart): Renamed 
       
 58450         m_lastNodeInserted to m_lastLeafInserted.  Use the 
       
 58451         start/endOfInsertedContent getters.
       
 58452         (WebCore::ReplaceSelectionCommand::shouldMergeEnd): Ditto.
       
 58453         (WebCore::ReplaceSelectionCommand::removeNodePreservingChildren): Ditto.
       
 58454         (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Ditto.
       
 58455         (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent): Added.
       
 58456         Special case for when the last leaf inserted is inside a select 
       
 58457         element: return the VisiblePosition after the select element.
       
 58458         (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Added.
       
 58459         (WebCore::ReplaceSelectionCommand::doApply): Did renaming.  Used
       
 58460         the start/endOfInsertedContent getters.  Insert smart replace spaces
       
 58461         into the right nodes.
       
 58462         (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): Renaming.
       
 58463         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Ditto.
       
 58464         (WebCore::ReplaceSelectionCommand::updateNodesInserted): Ditto.
       
 58465         * editing/ReplaceSelectionCommand.h:
       
 58466 
       
 58467 2007-01-22  Darin Adler  <darin@apple.com>
       
 58468 
       
 58469         Reviewed by Adam.
       
 58470 
       
 58471         - fix http://bugs.webkit.org/show_bug.cgi?id=12273
       
 58472           REGRESSION: File input value invisible after removing and re-appending
       
 58473 
       
 58474         - made more of the file chooser code cross-platform
       
 58475 
       
 58476         - fixed an Objective-C garbage collection problem in FileChooser
       
 58477 
       
 58478         - tried to remove layering violations where FileChooser in the platform
       
 58479           directory knows about the rendering and DOM trees (but wasn't able to
       
 58480           do it entirely)
       
 58481 
       
 58482         * platform/FileChooser.cpp: Added.
       
 58483         (WebCore::FileChooser::create): Changed parameters.
       
 58484         (WebCore::FileChooser::chooseFile): Changed to call chooseIcon function.
       
 58485         (WebCore::FileChooser::chooseIcon): Added.
       
 58486 
       
 58487         * platform/FileChooser.h: Added FileChooserClient so this file doesn't have
       
 58488         to know about RenderFileUploadControl. Used RetainPtr instead of retain/release
       
 58489         so this works properly with Objective-C GC. Replaced disconnectUploadControl
       
 58490         with disconnectClient, which has a simple inline implementation. Moved the
       
 58491         Document parameter from the constructor to openFileChooser, along with a comment
       
 58492         about why it should not be there. Added a filename parameter to the constructor
       
 58493         for the initial filename. Added a font parameter to basenameForWidth so we don't
       
 58494         depend on having a pointer to the renderer. Removed the uploadControl() and
       
 58495         document() functions since no one calls either of them.
       
 58496 
       
 58497         * platform/mac/FileChooserMac.mm: Removed code that is now cross-platform.
       
 58498         (-[OpenPanelController beginSheetWithFrame:]): Added frame parameter, instead
       
 58499         of storing a document pointer in the FileChooser.
       
 58500         (WebCore::FileChooser::FileChooser): Updated for changed parameters. Also added
       
 58501         code to choose the icon based on the initial filename. Pass the adopt parameter
       
 58502         to the constructor of the RetainPtr.
       
 58503         (WebCore::FileChooser::~FileChooser): Removed the release call, since the
       
 58504         RetainPtr will take care of it. Added a call to disconnectFileChooser here.
       
 58505         There's no need to disconnect at disconnectClient time, and that lets us have
       
 58506         one more cross-platform function.
       
 58507         (WebCore::FileChooser::openFileChooser): Added document parameter. Added code
       
 58508         to get the frame from the document. And added a nil check since there's no
       
 58509         ironclad guarantee the document won't have outlived its frame.
       
 58510         (WebCore::FileChooser::basenameForWidth): Added font parameter. Use that instead
       
 58511         of going at the upload control's style. The caller can handle that now.
       
 58512 
       
 58513         * rendering/RenderFileUploadControl.h: Removed unnecessary includes.
       
 58514         Made class inherit privately from FileChooserClient. Changed constructor
       
 58515         parameter to HTMLInputElement rather than Node. Made protected members be
       
 58516         private instead, and made a couple function members const.
       
 58517         * rendering/RenderFileUploadControl.cpp: Moved constants to the top of the file,
       
 58518         but after the "using namespace"
       
 58519         (WebCore::RenderFileUploadControl::RenderFileUploadControl): Updated for changes
       
 58520         to the FileChooser::create function and the parameter types.
       
 58521         (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed unneeded
       
 58522         null check -- there's no case where the FileChooser fails to be created.
       
 58523         (WebCore::RenderFileUploadControl::click): Pass document to openFileChooser.
       
 58524         (WebCore::RenderFileUploadControl::updateFromElement): Tweaked code a bit by
       
 58525         using updateFromElement and setValue instead of casting the renderer to a
       
 58526         RenderButton and calling setText directly. Put setInputType call here.
       
 58527         (WebCore::RenderFileUploadControl::maxFilenameWidth): Made const. Broke long line.
       
 58528         (WebCore::RenderFileUploadControl::createButtonStyle): Made const.
       
 58529         (WebCore::RenderFileUploadControl::paintObject): Moved buttonShadowHeight constant
       
 58530         to the top of the file. Call isEmpty instead of checking width and height of
       
 58531         IntRect for 0. Computed font to pass to FileChooser::basenameForWidth. Broke
       
 58532         long lines.
       
 58533         (WebCore::HTMLFileUploadInnerButtonElement::HTMLFileUploadInnerButtonElement):
       
 58534         Moved the setInputType call to the caller; concept here is that this class is
       
 58535         as simple as possible, rather than doing as much of the button job as possible.
       
 58536 
       
 58537         * WebCore.xcodeproj/project.pbxproj: Added FileChooser.cpp.
       
 58538         * WebCore.pro: Ditto.
       
 58539         * CMakeLists.txt: Ditto.
       
 58540         * WebCoreSources.bkl: Ditto.
       
 58541 
       
 58542         * platform/gdk/TemporaryLinkStubs.cpp: Updated stubs.
       
 58543         * platform/qt/FileChooserQt.cpp: Updated stubs.
       
 58544 
       
 58545 2007-01-22  Mitz Pettel  <mitz@webkit.org>
       
 58546 
       
 58547         Reviewed by Darin.
       
 58548 
       
 58549         - fix http://bugs.webkit.org/show_bug.cgi?id=12364
       
 58550           REGRESSSION (NativeListBox): Selected option's background is not clipped to the list box
       
 58551 
       
 58552         Test: fast/forms/select-item-background-clip.html
       
 58553 
       
 58554         * rendering/RenderListBox.cpp:
       
 58555         (WebCore::RenderListBox::paintItemBackground): Intersect the item's rect with
       
 58556         the list box's clip rect.
       
 58557 
       
 58558 2007-01-22  Darin Adler  <darin@apple.com>
       
 58559 
       
 58560         Reviewed by Beth.
       
 58561 
       
 58562         - fix http://bugs.webkit.org/show_bug.cgi?id=12369
       
 58563           REGRESSION (r19027): amazon.com home page crashes WebKit r19028 debug build
       
 58564 
       
 58565         I caused this a few hours ago. Oops!
       
 58566 
       
 58567         * rendering/RenderText.cpp: (WebCore::RenderText::setStyle):
       
 58568         Compute whether the font changed before calling RenderObject::setStyle.
       
 58569 
       
 58570 2007-01-22  Beth Dakin  <bdakin@apple.com>
       
 58571 
       
 58572         Reviewed by Maciej.
       
 58573 
       
 58574         Fix for <rdar://problem/4912129> REGRESSION: Crash occurs at 
       
 58575         WebCore::Frame::eventHandler() after clicking to dismiss a 
       
 58576         contextual menu on the page
       
 58577 
       
 58578         * page/EventHandler.cpp:
       
 58579         (WebCore::EventHandler::stopAutoscrollTimer): Added nil-check.
       
 58580 
       
 58581 2007-01-22  Darin Adler  <darin@apple.com>
       
 58582 
       
 58583         Reviewed by Mitz.
       
 58584 
       
 58585         Inspired by a much simpler patch by Andrew Wellington <proton@wiretapped.net>.
       
 58586 
       
 58587         - fix http://bugs.webkit.org/show_bug.cgi?id=11197
       
 58588           REGRESSION: Specifying a counter for a CODE tag's content style property
       
 58589           on before or after causes a crash.
       
 58590 
       
 58591         Test: fast/css/beforeSelectorOnCodeElement.html
       
 58592 
       
 58593         - fix regression I recently introduced where the monospace cache could be
       
 58594           used for text that was not ASCII, if text was changed after the style was set
       
 58595 
       
 58596         Test: fast/text/monospace-width-cache.html
       
 58597 
       
 58598         - streamline RenderText.h -- remove unneeded functions, make some needlessly
       
 58599           virtual functions non-virtual, remove unneeded header includes, replace use
       
 58600           of Font* with Font& for consistency with RenderStyle, use "text" consistently
       
 58601           instead of "string"
       
 58602 
       
 58603         * rendering/RenderText.h: Removed unneeded include of "Text.h", declarations of
       
 58604         SOFT_HYPHEN, DocumentMarker, InlineBox, Position, String. Got rid of friend
       
 58605         declaration for InlineTextBox. Changed constructor to take a PassRefPtr since
       
 58606         we do take owership of the passed-in text. Made deleteTextBoxes() private.
       
 58607         Removed unneeded data(). Made override of length() private so people will use
       
 58608         the faster textLength() instead. Renamed string() to text() so it matches up
       
 58609         better with setText(). Same for stringLength(), originalString(), and
       
 58610         setInternalString(), which are now textLength(), originalText(), and
       
 58611         setTextInternal(). Renamed the old text() function to characters(), since it
       
 58612         returns a pointer as StringImpl::characters does. Changed Font* to Font& everywhere.
       
 58613         Renamed the internal calcMinMaxWidth() function to calcMinMaxWidthInternal() and
       
 58614         made it non-virtual since it's not overriden anywhere. Also made the
       
 58615         trimmedMinMaxWidth() function non-virtual. Made containsOnlyWhitespace() private.
       
 58616         Removed both font() functions (one was needlessly virtual) and element().
       
 58617         Renamed cacheWidths() to updateMonospaceCharacterWidth() and removed the
       
 58618         shouldUseMonospaceCache() function. Renamed allAscii() to isAllASCII() and made
       
 58619         it an inline function. Removed the m_allAsciiChecked flag and renamed the
       
 58620         m_allAscii flag to m_isAllASCII.
       
 58621         * rendering/RenderText.cpp:
       
 58622         (WebCore::RenderText::RenderText): Removed initialization of m_allAsciiChecked.
       
 58623         Initialize m_isAllASCII. Changed all occurrences of m_str->length() and
       
 58624         m_str->characters () to use the stringLength() and characters() inline functions
       
 58625         instead.
       
 58626         (WebCore::RenderText::setStyle): Replaced the unconditional call to cacheWidths
       
 58627         with a conditional call to updateMonospaceCharacterWidth. This speeds up the common
       
 58628         case where style is changed without changing the font.
       
 58629         (WebCore::RenderText::originalText): Changed code to not depend on overridden
       
 58630         element() function with casts to a Text node -- this was one of only two call sites.
       
 58631         Also renamed.
       
 58632         (WebCore::RenderText::positionForCoordinates): Name change.
       
 58633         (WebCore::RenderText::caretRect): Ditto.
       
 58634         (WebCore::RenderText::updateMonospaceCharacterWidth): Renamed from cacheWidths and
       
 58635         incorporate the check that was formerly in a separate shouldUseMonospaceCache
       
 58636         function.
       
 58637         (WebCore::RenderText::widthFromCache): Changed to take a Font& instead of Font*.
       
 58638         Changed to take advantage of the fact that the string is known to be all ASCII in
       
 58639         the m_monospaceCharacterWidth code path.
       
 58640         (WebCore::RenderText::trimmedMinMaxWidth): Ditto. Also use style()->font() instead
       
 58641         of font(false).
       
 58642         (WebCore::RenderText::calcMinMaxWidth): Ditto. Also changed to use softHyphen instead
       
 58643         of SOFT_HYPHEN.
       
 58644         (WebCore::RenderText::containsOnlyWhitespace): More of the same.
       
 58645         (WebCore::RenderText::setSelectionState): Ditto.
       
 58646         (WebCore::RenderText::setTextWithOffset): Ditto.
       
 58647         (WebCore::isInlineFlowOrEmptyText): Ditto.
       
 58648         (WebCore::RenderText::setTextInternal): Updated for name changes. Also changed to
       
 58649         set the m_isAllASCII flag every time, in the more-efficient way we use elsewhere
       
 58650         (or'ing all the characters together), and to call updateMonospaceCharacterWidth
       
 58651         if the "all ASCII"-ness of the text changes.
       
 58652         (WebCore::RenderText::setText): Updated for name changes.
       
 58653         (WebCore::RenderText::width): More like above.
       
 58654         (WebCore::RenderText::selectionRect): Ditto.
       
 58655         (WebCore::RenderText::caretMaxOffset): Ditto.
       
 58656         (WebCore::RenderText::previousOffset): Ditto.
       
 58657         (WebCore::RenderText::nextOffset): Ditto.
       
 58658 
       
 58659         * dom/Position.cpp:
       
 58660         * dom/Range.cpp:
       
 58661         * editing/CompositeEditCommand.cpp:
       
 58662         * editing/DeleteSelectionCommand.cpp:
       
 58663         * editing/VisiblePosition.cpp:
       
 58664         * html/HTMLElement.cpp:
       
 58665         Added now-needed include of "Text.h" which is no longer included by "RenderText.h".
       
 58666 
       
 58667         * editing/SelectionController.cpp:
       
 58668         (WebCore::SelectionController::debugRenderer):
       
 58669         * editing/TextIterator.cpp:
       
 58670         (WebCore::TextIterator::handleTextNode):
       
 58671         (WebCore::TextIterator::handleTextBox):
       
 58672         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
       
 58673         Update for name changes of stringLength(), string(), and originalString() to
       
 58674         textLength(), text(), and originalText(), and to always use textLength() instead
       
 58675         of length() when we have a RenderText* rather than a RenderObject*.
       
 58676         * editing/visible_units.cpp:
       
 58677         (WebCore::startOfParagraph): Ditto.
       
 58678         (WebCore::endOfParagraph): Ditto.
       
 58679         * rendering/InlineFlowBox.cpp:
       
 58680         (WebCore::InlineFlowBox::placeBoxesHorizontally): Ditto. Also removed use of the
       
 58681         RenderObject::font() function and replaced it with explicit access to the style.
       
 58682         (WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
       
 58683         * rendering/InlineTextBox.cpp:
       
 58684         (WebCore::InlineTextBox::selectionRect): Ditto.
       
 58685         (WebCore::InlineTextBox::isLineBreak): Ditto.
       
 58686         (WebCore::InlineTextBox::paint): Ditto.
       
 58687         (WebCore::InlineTextBox::selectionStartEnd): Ditto.
       
 58688         (WebCore::InlineTextBox::paintSelection): Ditto.
       
 58689         (WebCore::InlineTextBox::paintMarkedTextBackground): Ditto.
       
 58690         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Ditto.
       
 58691         (WebCore::InlineTextBox::paintTextMatchMarker): Ditto.
       
 58692         (WebCore::InlineTextBox::offsetForPosition): Ditto.
       
 58693         (WebCore::InlineTextBox::positionForOffset): Ditto.
       
 58694         * rendering/RenderContainer.cpp:
       
 58695         (WebCore::RenderContainer::addChild): Ditto.
       
 58696         * rendering/RenderCounter.cpp:
       
 58697         (WebCore::RenderCounter::originalText): Ditto.
       
 58698         (WebCore::RenderCounter::calcMinMaxWidth): Ditto.
       
 58699         * rendering/RenderCounter.h: Ditto.
       
 58700         * rendering/RenderTextFragment.cpp:
       
 58701         (WebCore::RenderTextFragment::originalText): Ditto.
       
 58702         * rendering/RenderTextFragment.h: Ditto.
       
 58703         * rendering/SVGInlineFlowBox.cpp:
       
 58704         (WebCore::placePositionedBoxesHorizontally): Ditto.
       
 58705         (WebCore::placeBoxesVerticallyWithAbsBaseline): Ditto.
       
 58706         * rendering/bidi.cpp:
       
 58707         (WebCore::BidiIterator::increment): Ditto.
       
 58708         (WebCore::BidiIterator::current): Ditto.
       
 58709         (WebCore::BidiIterator::direction): Ditto.
       
 58710         (WebCore::addRun): Ditto.
       
 58711         (WebCore::checkMidpoints): Ditto.
       
 58712         (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto.
       
 58713         (WebCore::RenderBlock::skipWhitespace): Ditto.
       
 58714         (WebCore::RenderBlock::findNextLineBreak): Ditto.
       
 58715 
       
 58716         * rendering/RenderBR.h: Updated signature of width function which now takes a
       
 58717         Font& instead of a Font*.
       
 58718 
       
 58719         * rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace): Updated to no longer
       
 58720         use the RenderObject::font() function, and added a comment about first-line, which
       
 58721         is not handled properly here.
       
 58722 
       
 58723         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::text):
       
 58724         * rendering/RenderTreeAsText.cpp: (WebCore::writeTextRun):
       
 58725         Eliminated use of RenderText::data().
       
 58726 
       
 58727         * rendering/RenderObject.h: Removed RenderObject::font(). This had the bad effect of
       
 58728         having everyone pass in a boolean rather than using the cleaner style() and
       
 58729         firstLineStyle() functions in cases where there's no a firstLineStyle boolean.
       
 58730         * rendering/RenderObject.cpp:
       
 58731         (WebCore::RenderObject::getVerticalPosition): Replaced use of RenderObject::font()
       
 58732         with direct use of the style instead, which is arguably easier to understand anyway.
       
 58733         (WebCore::RenderObject::baselinePosition): Ditto.
       
 58734 
       
 58735 2007-01-22  Sam Weinig  <sam@webkit.org>
       
 58736 
       
 58737         Reviewed by The Mitz.
       
 58738 
       
 58739         Move JSHTMLSelectElementCustom.cpp from bindings to bindings/js
       
 58740         where it belongs.
       
 58741 
       
 58742         * WebCore.pro:
       
 58743         * WebCore.xcodeproj/project.pbxproj:
       
 58744         * bindings/JSHTMLSelectElementCustom.cpp: Removed.
       
 58745         * bindings/js/JSHTMLSelectElementCustom.cpp: Added.
       
 58746 
       
 58747 2007-01-22  Zack Rusin  <zack@kde.org>
       
 58748 
       
 58749         Fix the Qt build.
       
 58750 
       
 58751         * WebCore.pro: adjust after last changes
       
 58752 
       
 58753 2007-01-21  Alexey Proskuryakov  <ap@webkit.org>
       
 58754 
       
 58755         Reviewed by Darin.
       
 58756 
       
 58757         http://bugs.webkit.org/show_bug.cgi?id=10934
       
 58758         REGRESSION: prototype.js logs error (HTMLFormElement) on webkit builds
       
 58759 
       
 58760         Added constructors for most HTML elements; started auto-generating HTMLSelectElement JS binding.
       
 58761 
       
 58762         Test: fast/dom/Window/element-constructors-on-window.html
       
 58763 
       
 58764         * DerivedSources.make: Generate JSHTMLSelectElement.
       
 58765         * WebCore.xcodeproj/project.pbxproj: Added JSHTMLSelectElement{Custom}.
       
 58766         * bindings/js/JSHTMLElementWrapperFactory.cpp: Create a proper binding for SELECT.
       
 58767 
       
 58768         * bindings/js/kjs_html.cpp:
       
 58769         (KJS::):
       
 58770         (KJS::JSHTMLElement::classInfo):
       
 58771         (KJS::JSHTMLElement::accessors):
       
 58772         (KJS::JSHTMLElement::getOwnPropertySlot):
       
 58773         (KJS::HTMLElementFunction::callAsFunction):
       
 58774         (KJS::JSHTMLElement::put):
       
 58775         * bindings/js/kjs_html.h:
       
 58776         (KJS::JSHTMLElement::):
       
 58777         Removed everything related to SELECT. Renamed getHTMLOptionsCollection to toJS for autogenerated code 
       
 58778         to be happy, and rewrote it using cacheDOMObject.
       
 58779 
       
 58780         * bindings/scripts/CodeGeneratorJS.pm: Added HTMLElement to the list of types that cannot fail conversion.
       
 58781 
       
 58782         * html/HTMLAnchorElement.idl:
       
 58783         * html/HTMLAppletElement.idl:
       
 58784         * html/HTMLAreaElement.idl:
       
 58785         * html/HTMLBRElement.idl:
       
 58786         * html/HTMLBaseElement.idl:
       
 58787         * html/HTMLBaseFontElement.idl:
       
 58788         * html/HTMLBodyElement.idl:
       
 58789         * html/HTMLButtonElement.idl:
       
 58790         * html/HTMLCanvasElement.idl:
       
 58791         * html/HTMLDListElement.idl:
       
 58792         * html/HTMLDirectoryElement.idl:
       
 58793         * html/HTMLDivElement.idl:
       
 58794         * html/HTMLFieldSetElement.idl:
       
 58795         * html/HTMLFontElement.idl:
       
 58796         * html/HTMLFormElement.idl:
       
 58797         * html/HTMLHRElement.idl:
       
 58798         * html/HTMLHeadElement.idl:
       
 58799         * html/HTMLHeadingElement.idl:
       
 58800         * html/HTMLHtmlElement.idl:
       
 58801         * html/HTMLImageElement.idl:
       
 58802         * html/HTMLInputElement.idl:
       
 58803         * html/HTMLIsIndexElement.idl:
       
 58804         * html/HTMLLIElement.idl:
       
 58805         * html/HTMLLabelElement.idl:
       
 58806         * html/HTMLLegendElement.idl:
       
 58807         * html/HTMLLinkElement.idl:
       
 58808         * html/HTMLMapElement.idl:
       
 58809         * html/HTMLMenuElement.idl:
       
 58810         * html/HTMLMetaElement.idl:
       
 58811         * html/HTMLModElement.idl:
       
 58812         * html/HTMLOListElement.idl:
       
 58813         * html/HTMLOptGroupElement.idl:
       
 58814         * html/HTMLParagraphElement.idl:
       
 58815         * html/HTMLParamElement.idl:
       
 58816         * html/HTMLPreElement.idl:
       
 58817         * html/HTMLQuoteElement.idl:
       
 58818         * html/HTMLScriptElement.idl:
       
 58819         * html/HTMLStyleElement.idl:
       
 58820         * html/HTMLTextAreaElement.idl:
       
 58821         * html/HTMLTitleElement.idl:
       
 58822         * html/HTMLUListElement.idl:
       
 58823         Generate constructors.
       
 58824 
       
 58825         * html/HTMLSelectElement.cpp:
       
 58826         (WebCore::HTMLSelectElement::length):
       
 58827         * html/HTMLSelectElement.h:
       
 58828         Make length() return unsigned for auto-generated code to be happy.
       
 58829 
       
 58830         * html/HTMLSelectElement.idl: Adjusted to be usable for JS.
       
 58831 
       
 58832         * bindings/JSHTMLSelectElementCustom.cpp: Added. Implements remove().
       
 58833 
       
 58834         * page/DOMWindow.idl:
       
 58835         Added properties for most elements' constructors.
       
 58836 
       
 58837 2007-01-21  Mark Rowe  <mrowe@apple.com>
       
 58838 
       
 58839         Reviewed by Maciej.
       
 58840 
       
 58841         http://bugs.webkit.org/show_bug.cgi?id=12357
       
 58842         Bug 12357: Reproducible crash in WebCore::Settings::isJavaScriptEnabled in svg/custom/js-update-bounce.svg under guard-malloc
       
 58843 
       
 58844         * page/Frame.cpp:
       
 58845         (WebCore::Frame::~Frame): Access the global object directly rather than via Window::retrieveWindow to prevent our reference to
       
 58846         a deleted settings object being used.
       
 58847 
       
 58848 2007-01-21  Darin Adler  <darin@apple.com>
       
 58849 
       
 58850         Reviewed by Maciej.
       
 58851 
       
 58852         - fix <rdar://problem/4930503> REGRESSION: Page changes title when
       
 58853           command-clicking on named anchor link (12299)
       
 58854 
       
 58855         * loader/FrameLoader.cpp:
       
 58856         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
       
 58857         Return if shouldContinue is false. This matches the other similar
       
 58858         functions and prevents us from doing extra work in the "ignore" case.
       
 58859 
       
 58860 2007-01-21  Mark Rowe  <mrowe@apple.com>
       
 58861 
       
 58862         Reviewed by Darin.
       
 58863 
       
 58864         http://bugs.webkit.org/show_bug.cgi?id=12355
       
 58865         Bug 12355: Reproducible crash in WebCore::parseNumber in svg/custom/js-update-bounce.svg under guard-malloc
       
 58866 
       
 58867         * ksvg2/svg/SVGParserUtilities.cpp:
       
 58868         (WebCore::parseNumber): Parenthesize to prevent reading past end of buffer.
       
 58869 
       
 58870 2007-01-21  Mitz Pettel  <mitz@webkit.org>
       
 58871 
       
 58872         Reviewed by Darin.
       
 58873 
       
 58874         - fix http://bugs.webkit.org/show_bug.cgi?id=12345
       
 58875           REGRESSION: Disabled pop-up text is not grayed out
       
 58876 
       
 58877         Test: fast/forms/select-disabled-appearance.html
       
 58878 
       
 58879         * rendering/RenderThemeMac.mm:
       
 58880         (WebCore::RenderThemeMac::adjustMenuListStyle):
       
 58881 
       
 58882 2007-01-21  Darin Adler  <darin@apple.com>
       
 58883 
       
 58884         - fix non-Mac builds
       
 58885 
       
 58886         * CMakeLists.txt: Added JSDocumentCustom.cpp.
       
 58887         * WebCore.pro: Ditto.
       
 58888         * WebCoreSources.bkl: Ditto.
       
 58889 
       
 58890 2007-01-21  Mitz Pettel  <mitz@webkit.org>
       
 58891 
       
 58892         Reviewed by Darin.
       
 58893 
       
 58894         - fix http://bugs.webkit.org/show_bug.cgi?id=12353 <rdar://problem/4944599>
       
 58895           REGRESSION: Crash on load (mutation event dispatch under the image element constructor deletes the element)
       
 58896     
       
 58897         Test: fast/dom/HTMLImageElement/constructor-mutation-event-dispatch.html
       
 58898 
       
 58899         * bindings/js/kjs_html.cpp:
       
 58900         (KJS::ImageConstructorImp::construct): Protect the image element before setting
       
 58901         its attributes.
       
 58902 
       
 58903 2007-01-21  Sam Weinig  <sam@webkit.org>
       
 58904 
       
 58905         Rolling out patch for http://bugs.webkit.org/show_bug.cgi?id=8360.
       
 58906 
       
 58907         * rendering/RenderLayer.cpp:
       
 58908         (WebCore::RenderLayer::RenderLayer):
       
 58909         (WebCore::RenderLayer::scrollToOffset):
       
 58910         (WebCore::RenderLayer::scrollRectToVisible):
       
 58911         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
       
 58912         (WebCore::Marquee::start):
       
 58913         * rendering/RenderLayer.h:
       
 58914 
       
 58915 2007-01-21  David Kilzer  <ddkilzer@webkit.org>
       
 58916 
       
 58917         Reviewed by Darin.
       
 58918 
       
 58919         - fix http://bugs.webkit.org/show_bug.cgi?id=12280
       
 58920           select element not available by name through document.all
       
 58921           (dropdown list not available on smarthome.com checkout)
       
 58922 
       
 58923         Test: fast/dom/document-all-select.html
       
 58924 
       
 58925         * html/HTMLCollection.cpp:
       
 58926         (WebCore::HTMLCollection::checkForNameMatch):
       
 58927         (WebCore::HTMLCollection::updateNameCache):
       
 58928 
       
 58929 2007-01-21  Mitz Pettel  <mitz@webkit.org>
       
 58930 
       
 58931         Reviewed by Darin.
       
 58932 
       
 58933         - http://bugs.webkit.org/show_bug.cgi?id=10805
       
 58934           REGRESSION (r15720): manual-tests/onblur-remove.html failing
       
 58935 
       
 58936         * manual-tests/onblur-remove.html: Changed the test to not require pressing
       
 58937         Enter, since the correct behavior for Enter is to send a blur event.
       
 58938 
       
 58939 2007-01-21  Sanjay Madhav  <sanjay12@gmail.com>
       
 58940 
       
 58941         Reviewed by Darin.
       
 58942 
       
 58943         Fix for: <rdar://problem/4928583> Memory usage grows when reloading google.com/ig
       
 58944 
       
 58945         JSDocuments are now responsible for marking the DOM wrappers associated with them, when they get marked.
       
 58946         This fixes a JS object leak when a DOM wrapper has a reference to a JSDocument that is otherwise not reachable.
       
 58947 
       
 58948         Test: fast/dom/gc-10.html
       
 58949 
       
 58950         * WebCore.vcproj/WebCore/WebCore.vcproj:
       
 58951         * WebCore.xcodeproj/project.pbxproj:
       
 58952         * bindings/js/JSDocumentCustom.cpp: Added.
       
 58953         (WebCore::JSDocument::mark):
       
 58954         * bindings/js/kjs_binding.cpp:
       
 58955         (KJS::ScriptInterpreter::markDOMNodesForDocument):
       
 58956         (KJS::ScriptInterpreter::mark):
       
 58957         * bindings/js/kjs_binding.h:
       
 58958         * dom/Document.idl:
       
 58959 
       
 58960 2007-01-21  Mitz Pettel  <mitz@webkit.org>
       
 58961 
       
 58962         Reviewed by Darin.
       
 58963 
       
 58964         - fix http://bugs.webkit.org/show_bug.cgi?id=10692
       
 58965           REGRESSION (r14847): Unnecessary scrollbars with position:relative; and overflow:auto;
       
 58966 
       
 58967         Test: fast/overflow/position-relative.html
       
 58968 
       
 58969         * rendering/RenderBox.cpp:
       
 58970         (WebCore::RenderBox::lowestPosition): Add the relative position offset only
       
 58971         if 'includeSelf' is true.
       
 58972         (WebCore::RenderBox::rightmostPosition): Ditto.
       
 58973         (WebCore::RenderBox::leftmostPosition): Ditto.
       
 58974         * rendering/RenderFlow.cpp:
       
 58975         (WebCore::RenderFlow::lowestPosition): Ditto.
       
 58976         (WebCore::RenderFlow::rightmostPosition): Ditto.
       
 58977         (WebCore::RenderFlow::leftmostPosition): Ditto.
       
 58978 
       
 58979 2007-01-21  Mitz Pettel  <mitz@webkit.org>
       
 58980 
       
 58981         Reviewed by Darin.
       
 58982 
       
 58983         - fix http://bugs.webkit.org/show_bug.cgi?id=10472
       
 58984           REGRESSION: "add" method of <select> object does not put the <option> object in the correct position
       
 58985 
       
 58986         Test: fast/dom/HTMLSelectElement/options-collection-detached.html
       
 58987 
       
 58988         * html/HTMLSelectElement.cpp:
       
 58989         (WebCore::HTMLSelectElement::setRecalcListItems): Reset the options collection
       
 58990         info if the <select> is not in the document. For in-document <select>s this
       
 58991         happens anyway as a result of the DOM tree version increasing.
       
 58992 
       
 58993 2007-01-21  Mitz Pettel  <mitz@webkit.org>
       
 58994 
       
 58995         Reviewed by Darin.
       
 58996 
       
 58997         - fix http://bugs.webkit.org/show_bug.cgi?id=12349
       
 58998           NativeFileUpload: Button text is not grayed out when the control is disabled
       
 58999 
       
 59000         Covered by fast/forms/file-input-disabled.html 
       
 59001 
       
 59002         * css/html4.css: Changed selectors that had pseudo-classes after the -webkit-file-upload-button
       
 59003         pseudo-element to have the pseudo-element at the end. Pseudo-elements must be at the end.
       
 59004         * rendering/RenderFileUploadControl.cpp:
       
 59005         (WebCore::RenderFileUploadControl::createButtonStyle): Changed to not overwrite the button's
       
 59006         style with its parent's style. getPseudoStyle() handles inheritance properly.
       
 59007 
       
 59008 2007-01-21  Mitz Pettel  <mitz@webkit.org>
       
 59009 
       
 59010         Reviewed by Darin.
       
 59011 
       
 59012         - fix http://bugs.webkit.org/show_bug.cgi?id=12343
       
 59013           crash in css2.1/t1202-counter-09-b.html
       
 59014 
       
 59015         * platform/Font.cpp:
       
 59016         (WebCore::Font::glyphDataForCharacter):
       
 59017 
       
 59018 2007-01-21  Darin Adler  <darin@apple.com>
       
 59019 
       
 59020         Reviewed by Adam and Mitz.
       
 59021 
       
 59022         - fix http://bugs.webkit.org/show_bug.cgi?id=12347
       
 59023           REGRESSION: list box scrolling broken (fast/forms/listbox-selection.html)
       
 59024 
       
 59025         Covered by existing test: fast/forms/listbox-selection.html
       
 59026 
       
 59027         * rendering/RenderListBox.h: Added override of layout(), made selectionChanged()
       
 59028         no longer an inline. Added private scrollToRevealSelection(),
       
 59029         m_scrollToRevealSelectionAfterLayout, and m_inAutoscroll.
       
 59030         * rendering/RenderListBox.cpp:
       
 59031         (WebCore::RenderListBox::RenderListBox): Initialize new data members.
       
 59032         (WebCore::RenderListBox::updateFromElement): Remove scrolling code.
       
 59033         (WebCore::RenderListBox::selectionChanged): Moved from header. Calls repaint
       
 59034         and then scrollToRevealSelection, but if we need layout, instead schedules
       
 59035         scrollToRevealSelection to be done after layout.
       
 59036         (WebCore::RenderListBox::layout): Added. After calling base class, calls
       
 59037         scrollToRevealSelection if the m_scrollToRevealSelectionAfterLayout is set.
       
 59038         (WebCore::RenderListBox::scrollToRevealSelection): Added. Code was originally
       
 59039         in updateFromElement.
       
 59040         (WebCore::RenderListBox::autoscroll): Set m_inAutoscroll so that the
       
 59041         selectionChanged function knows not to scroll. Also removed the repaint()
       
 59042         here because updateListBoxSelection() takes care of repainting by calling
       
 59043         selectionChanged().
       
 59044 
       
 59045 2007-01-21  David Kilzer  <ddkilzer@webkit.org>
       
 59046 
       
 59047         * page/EventHandler.cpp:
       
 59048         (WebCore::EventHandler::handleMouseMoveEvent): Changed #if SVG_SUPPORT to #ifdef SVG_SUPPORT.
       
 59049 
       
 59050 2007-01-20  Mitz Pettel  <mitz@webkit.org>
       
 59051 
       
 59052         Reviewed by Maciej.
       
 59053 
       
 59054         - fix http://bugs.webkit.org/show_bug.cgi?id=11115
       
 59055           REGRESSION: Crash on Flickr after hitting cancel from adding a note
       
 59056 
       
 59057         Test: fast/forms/text-set-value-crash.html
       
 59058 
       
 59059         * html/HTMLInputElement.cpp:
       
 59060         (WebCore::HTMLInputElement::setValue): Added a call to Document::updateRendering().
       
 59061         * html/HTMLTextAreaElement.cpp:
       
 59062         (WebCore::HTMLTextAreaElement::setValue): Ditto.
       
 59063 
       
 59064 2007-01-20  Mitz Pettel  <mitz@webkit.org>
       
 59065 
       
 59066         Reviewed by Darin.
       
 59067 
       
 59068         - fix http://bugs.webkit.org/show_bug.cgi?id=8360
       
 59069           Repro crash when onscroll handler deletes the scrolled object
       
 59070 
       
 59071         Test: fast/layers/removed-by-scroll-handler.html
       
 59072 
       
 59073         * rendering/RenderLayer.cpp:
       
 59074         (WebCore::RenderLayer::RenderLayer):
       
 59075         (WebCore::RenderLayer::dispatchScrollEvent): Added. Called when the timer
       
 59076         fires and dispatches the scroll event to the layer's element.
       
 59077         (WebCore::RenderLayer::scrollToOffset): Instead of dispatching the scroll
       
 59078         event from this function, which is called during layout, schedule a 0-duration
       
 59079         timer to dispatch the event after layout.
       
 59080         (WebCore::RenderLayer::scrollRectToVisible):
       
 59081         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
       
 59082         (WebCore::Marquee::start):
       
 59083         * rendering/RenderLayer.h:
       
 59084 
       
 59085 2007-01-20  Nikolas Zimmermann  <zimmermann@kde.org>
       
 59086 
       
 59087         Reviewed by Sam.
       
 59088 
       
 59089         Fix JS bindings for SVGAnimated{Boolean, Enumeration, Integer, Number, String}.
       
 59090 
       
 59091         Dynamic SVG DOM updates (ie. "someUse.href.baseVal = '#rect'") with these types
       
 59092         didn't work. Existing gradient updating examples relied on calling setAttribute
       
 59093         after a SVG DOM update - that was the only reason it worked, added a new test
       
 59094         only using SVG DOM updates (js-update-stop.svg).
       
 59095 
       
 59096         Added test: js-update-stop.svg
       
 59097         Added test: use-property-changes-through-dom.svg (change xlink:href, x/y attributes using setAttribute)
       
 59098         Added test: use-property-changes-through-svg-dom.svg (change xlink:href, x/y attributes using SVG DOM)
       
 59099 
       
 59100         * bindings/js/JSSVGPODTypeWrapper.h:
       
 59101         (WebCore::JSSVGPODTypeWrapper::commitChange):
       
 59102         (WebCore::JSSVGPODTypeWrapperCreator::commitChange):
       
 59103         (WebCore::JSSVGPODTypeWrapperCreatorForList::commitChange):
       
 59104         * bindings/js/JSSVGPathSegListCustom.cpp:
       
 59105         (WebCore::updatePathSegContextMap):
       
 59106         (WebCore::removeFromPathSegContextMap):
       
 59107         * bindings/scripts/CodeGeneratorJS.pm:
       
 59108         * ksvg2/misc/SVGDocumentExtensions.h:
       
 59109         (WebCore::SVGDocumentExtensions::baseValueMap):
       
 59110         (WebCore::SVGDocumentExtensions::genericContextMap):
       
 59111         (WebCore::SVGDocumentExtensions::baseValue):
       
 59112         (WebCore::SVGDocumentExtensions::setBaseValue):
       
 59113         (WebCore::SVGDocumentExtensions::removeBaseValue):
       
 59114         (WebCore::SVGDocumentExtensions::hasBaseValue):
       
 59115         (WebCore::SVGDocumentExtensions::genericContext):
       
 59116         (WebCore::SVGDocumentExtensions::setGenericContext):
       
 59117         (WebCore::SVGDocumentExtensions::removeGenericContext):
       
 59118         (WebCore::SVGDocumentExtensions::hasGenericContext):
       
 59119         (WebCore::String):
       
 59120         (WebCore::FloatRect):
       
 59121         (WebCore::bool):
       
 59122         (WebCore::double):
       
 59123         * ksvg2/svg/SVGClipPathElement.h:
       
 59124         * ksvg2/svg/SVGElement.h:
       
 59125         (WebCore::SVGElement::notifyAttributeChange):
       
 59126         * ksvg2/svg/SVGPathSegList.cpp:
       
 59127         (WebCore::SVGPathSegList::SVGPathSegList):
       
 59128         (WebCore::SVGPathSegList::context):
       
 59129         * ksvg2/svg/SVGPathSegList.h:
       
 59130         * ksvg2/svg/SVGPatternElement.h:
       
 59131         * ksvg2/svg/SVGPointList.cpp:
       
 59132         (SVGPointList::SVGPointList):
       
 59133         (SVGPointList::context):
       
 59134         * ksvg2/svg/SVGPointList.h:
       
 59135         * ksvg2/svg/SVGStopElement.cpp:
       
 59136         (WebCore::SVGStopElement::parseMappedAttribute):
       
 59137         (WebCore::SVGStopElement::notifyAttributeChange):
       
 59138         * ksvg2/svg/SVGStopElement.h:
       
 59139         * ksvg2/svg/SVGUseElement.cpp:
       
 59140         (WebCore::SVGUseElement::notifyAttributeChange):
       
 59141 
       
 59142 2007-01-20  Rob Buis  <buis@kde.org>
       
 59143 
       
 59144         Reviewed by Sam.
       
 59145 
       
 59146         http://bugs.webkit.org/show_bug.cgi?id=12334
       
 59147         Respect <text> boundaries for svg text selecting
       
 59148 
       
 59149         Make sure the text selection for svg stays inside
       
 59150         containing blocks.
       
 59151         Added one manual test since html selection does not
       
 59152         seem to work for SVG and selectSubString for SVG
       
 59153         is not implemented yet.
       
 59154 
       
 59155         * manual-tests/svg-text-selection.svg: Added.
       
 59156         * page/EventHandler.cpp:
       
 59157         (WebCore::EventHandler::handleMouseMoveEvent):
       
 59158         * rendering/RenderObject.h:
       
 59159         (WebCore::RenderObject::isSVGText):
       
 59160         * rendering/RenderSVGInlineText.h:
       
 59161         (WebCore::RenderSVGInlineText::isSVGText):
       
 59162         * rendering/RenderSVGText.h:
       
 59163         (WebCore::RenderSVGText::isSVGText):
       
 59164 
       
 59165 2007-01-19  Adele Peterson  <adele@apple.com>
       
 59166 
       
 59167         Reviewed by Hyatt.
       
 59168 
       
 59169         Fix for: <rdar://problem/4697438> REGRESSION: select menu lists match the wrong css rule on www.chainreaction.com
       
 59170 
       
 59171         Update the size attribute value for select elements to match the numeric value.  This is a special case since this
       
 59172         attribute is used to determine which control to use.  We want to make sure that the size attribute is valid when we match
       
 59173         CSS rules.
       
 59174 
       
 59175         Test: fast/forms/select-size.html
       
 59176 
       
 59177         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): If the attribute string value is not the
       
 59178           same as its integer value, then update the attribute value to match the integer.
       
 59179         * dom/Attribute.h: Made setValue and setPrefix public.
       
 59180 
       
 59181 2007-01-19  John Sullivan  <sullivan@apple.com>
       
 59182 
       
 59183         Reviewed by Darin
       
 59184 
       
 59185         - WebCore part of fix for: <rdar://problem/4451715> REGRESSION: On some sites, have to 
       
 59186           type a character before username/password autofill kicks in
       
 59187 
       
 59188         * loader/FrameLoaderClient.h:
       
 59189         new dispatchDidFinishDocumentLoad call
       
 59190 
       
 59191         * loader/FrameLoader.cpp:
       
 59192         (WebCore::FrameLoader::finishedParsing):
       
 59193         call dispatchDidFinishDocumentLoad
       
 59194         
       
 59195         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 59196         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishDocumentLoad):
       
 59197         empty implementation for dispatchDidFinishDocumentLoad
       
 59198 
       
 59199 2007-01-19  Adele Peterson  <adele@apple.com>
       
 59200 
       
 59201         Reviewed by Hyatt.
       
 59202 
       
 59203         Fix for <rdar://problem/4760280> REGRESSION: Bottom portion of text hangs off edge of SELECT element at http://macreviewzone.com/index.php
       
 59204         
       
 59205         Test: fast/forms/control-restrict-line-height.html
       
 59206 
       
 59207         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::setFontFromControlSize): Don't honor line-height for controls that
       
 59208           have restricted font size.
       
 59209 
       
 59210 2007-01-19  Darin Adler  <darin@apple.com>
       
 59211 
       
 59212         Reviewed by Adele.
       
 59213 
       
 59214         - fix http://bugs.webkit.org/show_bug.cgi?id=11999
       
 59215           <rdar://problem/4940442> REGRESSION: Incomplete listing in TVListings window (11999)
       
 59216           Fix was to use the actual size of the renderer in the RenderListBox
       
 59217           case, instead of always using the size specified by the select element.
       
 59218 
       
 59219         Test: fast/forms/select-list-box-with-height.html
       
 59220 
       
 59221         - fix http://bugs.webkit.org/show_bug.cgi?id=11995
       
 59222           <rdar://problem/4901834> REGRESSION(NativeListBox): Focus is not placed on
       
 59223           SELECT after mousing down on OPTION
       
 59224 
       
 59225         Test: fast/forms/select-list-box-mouse-focus.html
       
 59226 
       
 59227         - fix bug where auto-scrolling was not working in list box select elements
       
 59228 
       
 59229         No test yet.
       
 59230 
       
 59231         - fix a missing semicolon in the radio/checkbox section of html4.css
       
 59232 
       
 59233         Test: fast/forms/radio-no-theme-padding.html
       
 59234 
       
 59235         - fix bug where the scroll bars for select elements were pixel-type scroll
       
 59236           bars even though the scrolling is line at a time scrolling
       
 59237 
       
 59238         No test.
       
 59239 
       
 59240         * html/HTMLSelectElement.cpp:
       
 59241         (WebCore::HTMLSelectElement::selectAll): Removed an explicit call
       
 59242         to repaint, since the RenderListBox now does that in selectionChanged.
       
 59243         (WebCore::HTMLSelectElement::notifyOptionSelected): Call the new
       
 59244         selectionChanged instead of the old setSelectionChanged.
       
 59245         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Added a call
       
 59246         to focus. Removed an explicit call to repaint and added a call to the
       
 59247         new setMouseDownMayStartAutoscroll function in EventHandler. Removed an
       
 59248         explicit call to repaint as above.
       
 59249         (WebCore::HTMLSelectElement::updateListBoxSelection): Call the new
       
 59250         selectionChanged instead of the old setSelectionChanged.
       
 59251 
       
 59252         * page/EventHandler.h: Added setMouseDownMayStartAutoscroll, needed
       
 59253         because the existing code to set that flag won't get triggered when
       
 59254         the select element's default event handler handles the event.
       
 59255 
       
 59256         * rendering/RenderListBox.h: Made ScrollbarClient a private base class.
       
 59257         Removed setSelectionChanged and m_selectionChanged. Added selectionChanged,
       
 59258         which is really just a synonym for repaint for now. Moved valueChanged,
       
 59259         the ScrollbarClient function implementations, and itemHeight into the
       
 59260         private part of the class. Added numVisibleItems() and listHeight() to
       
 59261         the private section. Changed m_vBar to be a RefPtr.
       
 59262 
       
 59263         * rendering/RenderListBox.cpp: Removed unneeded includes. Moved all
       
 59264         the constants to the top of the file.
       
 59265         (WebCore::RenderListBox::RenderListBox): Removed initialization of
       
 59266         m_selectionChanged because it was removed and of m_vBar because it's
       
 59267         now a RefPtr which is automaticall initialized.
       
 59268         (WebCore::RenderListBox::~RenderListBox): Removed the explicit deref of
       
 59269         m_vBar because it's a RefPtr. Added null checking for FrameView.
       
 59270         (WebCore::RenderListBox::updateFromElement): Use numItems().
       
 59271         (WebCore::RenderListBox::calcMinMaxWidth): Added null checking for
       
 59272         FrameView and used RefPtr for the newly-created scroll bar.
       
 59273         (WebCore::RenderListBox::size): Tweaked formatting. Also renamed the
       
 59274         misleading minDefaultSize to maxDefaultSize, since it's a maximum.
       
 59275         (WebCore::RenderListBox::numVisibleItems): Added. Used in many places
       
 59276         where size() was used before. This computes the number of rows we have
       
 59277         room for. We don't need a row space after the last row, and this takes
       
 59278         that into account.
       
 59279         (WebCore::RenderListBox::numItems): Tweaked to remove the local variable.
       
 59280         (WebCore::RenderListBox::listHeight): Added. Total height of all the rows
       
 59281         and spaces between them.
       
 59282         (WebCore::RenderListBox::calcHeight): Changed to call itemHeight for the
       
 59283         row height, and to subtract the last row spacing off since we don't need
       
 59284         a space after the last row. Changed the scroll bar setup to make it
       
 59285         correspond to row numbers, not pixel numbers.
       
 59286         (WebCore::RenderListBox::baselinePosition): Moved the comment to the
       
 59287         constant declaration at the top of the file.
       
 59288         (WebCore::RenderListBox::itemBoundingBoxRect): Simplified by using
       
 59289         the itemHeight() function.
       
 59290         (WebCore::RenderListBox::paintObject): Changed to use numItems and
       
 59291         to use numVisibleItems instead of size.
       
 59292         (WebCore::RenderListBox::isPointInScrollbar): Added get() call since
       
 59293         m_vBar is now a RefPtr.
       
 59294         (WebCore::RenderListBox::listIndexAtOffset): Changed to use numItems(),
       
 59295         itemHeight(), and rearranged a min/max combo so it starts with the low,
       
 59296         then the value, then the high value for pinning.
       
 59297         (WebCore::RenderListBox::autoscroll): Use numVisibleItems() instead of
       
 59298         size().
       
 59299         (WebCore::RenderListBox::stopAutoscroll): Removed an unneeded nil check
       
 59300         of the element.
       
 59301         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Changed
       
 59302         to use numItems() and to use numVisibleItems() instead of size().
       
 59303         Also changed scroll bar code to work more simply now that the scroll
       
 59304         bar is row-based.
       
 59305         (WebCore::RenderListBox::listIndexIsVisible): Changed to use
       
 59306         numVisibleItems() instead of size().
       
 59307         (WebCore::RenderListBox::valueChanged): Simplified since the scrollbar
       
 59308         is now row-based. Also removed an unnecessary null check.
       
 59309         (WebCore::RenderListBox::itemHeight): Updated for name change from
       
 59310         optionsSpacingMiddle to rowSpacing.
       
 59311         (WebCore::RenderListBox::scrollHeight): Changed to use listHeight().
       
 59312         (WebCore::RenderListBox::setScrollTop): Simplified, and removed the code
       
 59313         that does nothing if the computed list index is visible (which did not
       
 59314         make sense for this function and seemed a cut and paste error from the
       
 59315         scrollToReveal function). The scrollbar part is simpler now that it's
       
 59316         row-based.
       
 59317         (WebCore::RenderListBox::windowClipRect): Changed to use document()->view()
       
 59318         so we don't have to include RenderView.h.
       
 59319 
       
 59320         * css/html4.css: Added a semicolon I noticed was missing.
       
 59321 
       
 59322 2007-01-19  Beth Dakin  <bdakin@apple.com>
       
 59323 
       
 59324         Reviewed by Maciej and Darin.
       
 59325 
       
 59326         Fix for <rdar://problem/4702420> REGRESSION: Null characters need 
       
 59327         to be stripped from text nodes (townhall.com)
       
 59328 
       
 59329         This was a regression from the fix for <rdar://problem/3727939>
       
 59330         Safari strips \0 characters from HTML tags making them valid, which
       
 59331         was fixed with r12652. We still need to strip null characters in
       
 59332         text nodes.
       
 59333 
       
 59334         * html/HTMLTokenizer.cpp:
       
 59335         (WebCore::HTMLTokenizer::write): No behavior change here, this is
       
 59336         just to make Darin happy.
       
 59337         (WebCore::HTMLTokenizer::processToken): Call into StringImpl's new 
       
 59338         createStrippingNull function instead of the normal StringImpl 
       
 59339         constructor.
       
 59340         * platform/StringImpl.cpp:
       
 59341         (WebCore::StringImpl::createStrippingNull): Strip null.
       
 59342         * platform/StringImpl.h:
       
 59343 
       
 59344 2007-01-19  David Kilzer  <ddkilzer@webkit.org>
       
 59345 
       
 59346         Reviewed by NOBODY (no-svg build fix).
       
 59347 
       
 59348         * ksvg2/svg/SVGMPathElement.cpp: Added #ifdef SVG_SUPPORT/#endif guards.
       
 59349 
       
 59350 2007-01-19  Anders Carlsson  <acarlsson@apple.com>
       
 59351         
       
 59352         Build fix.
       
 59353         
       
 59354         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 59355         (WebCore::SVGEmptyChromeClient::setStatusbarText):
       
 59356 
       
 59357 2007-01-18  Anders Carlsson  <acarlsson@apple.com>
       
 59358 
       
 59359         Reviewed by Adam.
       
 59360 
       
 59361         Move JavaScript alert and status bar functions to the chrome.
       
 59362         
       
 59363         * bindings/js/kjs_window.cpp:
       
 59364         (KJS::WindowFunc::callAsFunction):
       
 59365         * page/Chrome.cpp:
       
 59366         (WebCore::Chrome::runJavaScriptAlert):
       
 59367         (WebCore::Chrome::runJavaScriptConfirm):
       
 59368         (WebCore::Chrome::runJavaScriptPrompt):
       
 59369         (WebCore::Chrome::setStatusBarText):
       
 59370         * page/Chrome.h:
       
 59371         * page/ChromeClient.h:
       
 59372         * page/Frame.cpp:
       
 59373         (WebCore::Frame::setJSStatusBarText):
       
 59374         (WebCore::Frame::setJSDefaultStatusBarText):
       
 59375         * page/Frame.h:
       
 59376         * page/mac/FrameMac.h:
       
 59377         * page/mac/FrameMac.mm:
       
 59378         * page/mac/WebCoreFrameBridge.h:
       
 59379         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 59380         (WebCore::SVGEmptyChromeClient::runJavaScriptAlert):
       
 59381         (WebCore::SVGEmptyChromeClient::runJavaScriptConfirm):
       
 59382         (WebCore::SVGEmptyChromeClient::runJavaScriptPrompt):
       
 59383         (WebCore::SVGEmptyChromeClient::setStatusBarText):
       
 59384 
       
 59385 2007-01-19  Zack Rusin  <zack@kde.org>
       
 59386 
       
 59387         Fix the build.
       
 59388 
       
 59389         * WebCore.pro: Add missing files
       
 59390 
       
 59391 2007-01-19  Eric Seidel  <eric@webkit.org>
       
 59392 
       
 59393         Reviewed by rwlbuis.
       
 59394 
       
 59395         More cleanup to SVGAnimated* classes.
       
 59396 
       
 59397         No tests possible (only code cleanup)
       
 59398 
       
 59399         * ksvg2/svg/SVGAnimateMotionElement.cpp:
       
 59400         (WebCore::SVGAnimateMotionElement::applyAnimationToValue):
       
 59401         * ksvg2/svg/SVGAnimateMotionElement.h:
       
 59402         * ksvg2/svg/SVGAnimationElement.cpp:
       
 59403         (WebCore::SVGAnimationElement::parseBeginOrEndValue):
       
 59404         (WebCore::SVGAnimationElement::parseMappedAttribute):
       
 59405         (WebCore::SVGAnimationElement::parseClockValue):
       
 59406         (WebCore::SVGAnimationElement::isIndefinite):
       
 59407         * ksvg2/svg/SVGAnimationElement.h:
       
 59408 
       
 59409 2007-01-19  Nikolas Zimmermann  <zimmermann@kde.org>
       
 59410 
       
 59411         Not reviewed.
       
 59412 
       
 59413         Remove accidently commited debug output. Shame on me :-)
       
 59414 
       
 59415         * ksvg2/svg/SVGUseElement.cpp:
       
 59416         (WebCore::SVGUseElement::notifyAttributeChange):
       
 59417 
       
 59418 2007-01-19  Nikolas Zimmermann  <zimmermann@kde.org>
       
 59419 
       
 59420         Reviewed by Eric.
       
 59421 
       
 59422         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10410 (SVG Slider example renders completely wrong (inserting <use> dynamically doesn't work))
       
 59423         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11660 (SVG: creation of <use/> elements through scripting/DOM doesn't work)
       
 59424 
       
 59425         Added test: svg/custom/use-instanceRoot-modifications.svg
       
 59426         Added test: svg/custom/use-on-g.svg
       
 59427         Added test: svg/custom/use-on-rect.svg
       
 59428         Added test: svg/custom/use-on-symbol-inside-pattern.svg
       
 59429         Added test: svg/custom/use-on-symbol.svg
       
 59430         Added test: svg/custom/use-on-text.svg
       
 59431         Added test: svg/custom/use-transform.svg
       
 59432 
       
 59433         Fixes: svg/W3C-SVG-1.1/text-text-04-t.svg (missing use elements)
       
 59434         Fixes: svg/carto.net/button.svg (image buttons didn't appear)
       
 59435         Fixes: svg/carto.net/colourpicker.svg (slider handles finally show up)
       
 59436         Fixes: svg/carto.net/slider.svg (slider handles finally show up)
       
 59437         Fixes: svg/carto.net/window.svg (window decorations show up) 
       
 59438         Fixes: svg/custom/use-forward-refs.svg (missing use elements)
       
 59439 
       
 59440         Rewrite <use> support with a real-shadow tree (as the spec demands), and implement SVGElementInstance.
       
 59441         AFAIK we're the first implementing this SVG feature - after ASV3 (!).
       
 59442 
       
 59443         * DerivedSources.make:
       
 59444         * WebCore.xcodeproj/project.pbxproj:
       
 59445         * bindings/objc/DOMInternal.h:
       
 59446         * bindings/objc/DOMSVG.h:
       
 59447         * ksvg2/misc/SVGDocumentExtensions.cpp:
       
 59448         (WebCore::SVGDocumentExtensions::reportWarning):
       
 59449         (WebCore::SVGDocumentExtensions::reportError):
       
 59450         (WebCore::SVGDocumentExtensions::addPendingResource):
       
 59451         (WebCore::SVGDocumentExtensions::isPendingResource):
       
 59452         (WebCore::SVGDocumentExtensions::removePendingResource):
       
 59453         (WebCore::SVGDocumentExtensions::mapInstanceToElement):
       
 59454         (WebCore::SVGDocumentExtensions::removeInstanceMapping):
       
 59455         (WebCore::SVGDocumentExtensions::instancesForElement):
       
 59456         * ksvg2/misc/SVGDocumentExtensions.h:
       
 59457         * ksvg2/svg/SVGCircleElement.cpp:
       
 59458         (WebCore::SVGCircleElement::notifyAttributeChange):
       
 59459         * ksvg2/svg/SVGElement.cpp:
       
 59460         (WebCore::SVGElement::insertedIntoDocument):
       
 59461         * ksvg2/svg/SVGElement.h:
       
 59462         (WebCore::SVGElement::buildPendingResource):
       
 59463         * ksvg2/svg/SVGElementInstance.cpp:
       
 59464         (WebCore::SVGElementInstance::SVGElementInstance):
       
 59465         (WebCore::SVGElementInstance::~SVGElementInstance):
       
 59466         (WebCore::SVGElementInstance::clonedElement):
       
 59467         (WebCore::SVGElementInstance::correspondingElement):
       
 59468         (WebCore::SVGElementInstance::correspondingUseElement):
       
 59469         (WebCore::SVGElementInstance::parentNode):
       
 59470         (WebCore::SVGElementInstance::childNodes):
       
 59471         (WebCore::SVGElementInstance::previousSibling):
       
 59472         (WebCore::SVGElementInstance::nextSibling):
       
 59473         (WebCore::SVGElementInstance::firstChild):
       
 59474         (WebCore::SVGElementInstance::lastChild):
       
 59475         (WebCore::SVGElementInstance::appendChild):
       
 59476         (WebCore::SVGElementInstance::updateInstance):
       
 59477         * ksvg2/svg/SVGElementInstance.h:
       
 59478         * ksvg2/svg/SVGElementInstance.idl: Added.
       
 59479         * ksvg2/svg/SVGElementInstanceList.cpp:
       
 59480         (WebCore::SVGElementInstanceList::SVGElementInstanceList):
       
 59481         (WebCore::SVGElementInstanceList::length):
       
 59482         (WebCore::SVGElementInstanceList::item):
       
 59483         * ksvg2/svg/SVGElementInstanceList.h:
       
 59484         * ksvg2/svg/SVGElementInstanceList.idl: Added.
       
 59485         * ksvg2/svg/SVGEllipseElement.cpp:
       
 59486         (WebCore::SVGEllipseElement::notifyAttributeChange):
       
 59487         * ksvg2/svg/SVGGElement.cpp:
       
 59488         * ksvg2/svg/SVGGElement.h:
       
 59489         (WebCore::SVGGElement::contextElement):
       
 59490         * ksvg2/svg/SVGGradientElement.cpp:
       
 59491         * ksvg2/svg/SVGGradientElement.h:
       
 59492         * ksvg2/svg/SVGHiddenElement.h: Added.
       
 59493         (WebCore::SVGHiddenElement::Type):
       
 59494         (WebCore::SVGHiddenElement::~SVGHiddenElement):
       
 59495         (WebCore::SVGHiddenElement::localName):
       
 59496         * ksvg2/svg/SVGImageElement.cpp:
       
 59497         (WebCore::SVGImageElement::notifyAttributeChange):
       
 59498         * ksvg2/svg/SVGLineElement.cpp:
       
 59499         (WebCore::SVGLineElement::notifyAttributeChange):
       
 59500         * ksvg2/svg/SVGPathElement.cpp:
       
 59501         (WebCore::SVGPathElement::notifyAttributeChange):
       
 59502         * ksvg2/svg/SVGPatternElement.cpp:
       
 59503         * ksvg2/svg/SVGPatternElement.h:
       
 59504         * ksvg2/svg/SVGPolyElement.cpp:
       
 59505         (WebCore::SVGPolyElement::notifyAttributeChange):
       
 59506         * ksvg2/svg/SVGRectElement.cpp:
       
 59507         (WebCore::SVGRectElement::notifyAttributeChange):
       
 59508         * ksvg2/svg/SVGStyledElement.cpp:
       
 59509         (WebCore::SVGStyledElement::notifyAttributeChange):
       
 59510         (WebCore::SVGStyledElement::updateElementInstance):
       
 59511         * ksvg2/svg/SVGStyledElement.h:
       
 59512         * ksvg2/svg/SVGUseElement.cpp:
       
 59513         (WebCore::SVGUseElement::instanceRoot):
       
 59514         (WebCore::SVGUseElement::animatedInstanceRoot):
       
 59515         (WebCore::SVGUseElement::hasChildNodes):
       
 59516         (WebCore::SVGUseElement::insertedIntoDocument):
       
 59517         (WebCore::SVGUseElement::buildPendingResource):
       
 59518         (WebCore::SVGUseElement::createRenderer):
       
 59519         (WebCore::SVGUseElement::buildShadowTree):
       
 59520         (WebCore::SVGUseElement::recursiveShadowTreeBuilder):
       
 59521         (WebCore::dumpShadowTree):
       
 59522         (WebCore::SVGUseElement::addShadowTree):
       
 59523         * ksvg2/svg/SVGUseElement.h:
       
 59524         * ksvg2/svg/SVGUseElement.idl:
       
 59525 
       
 59526 2007-01-19  Eric Seidel  <eric@webkit.org>
       
 59527 
       
 59528         Reviewed by rwlbuis.
       
 59529 
       
 59530         Add support for SVGMPathElement parsing.
       
 59531 
       
 59532         No test cases possible (SVGAnimateMotion doesn't work yet)
       
 59533 
       
 59534         * WebCore.xcodeproj/project.pbxproj:
       
 59535         * ksvg2/svg/SVGAnimateMotionElement.cpp:
       
 59536         (WebCore::SVGAnimateMotionElement::animationPath):
       
 59537         * ksvg2/svg/SVGMPathElement.cpp: Added.
       
 59538         (WebCore::SVGMPathElement::SVGMPathElement):
       
 59539         (WebCore::SVGMPathElement::~SVGMPathElement):
       
 59540         (WebCore::SVGMPathElement::parseMappedAttribute):
       
 59541         (WebCore::SVGMPathElement::pathElement):
       
 59542         * ksvg2/svg/SVGMPathElement.h: Added.
       
 59543         * ksvg2/svg/SVGNumberList.cpp:
       
 59544         (WebCore::SVGNumberList::parse): fix typo in comment
       
 59545         * ksvg2/svg/svgtags.in: add back mpath
       
 59546 
       
 59547 2007-01-19  Eric Seidel  <eric@webkit.org>
       
 59548 
       
 59549         Reviewed by rwlbuis.
       
 59550 
       
 59551         Implement better parsing for keyTimes, keySplines and keyPoints.
       
 59552 
       
 59553         Unfortunately none of this code is used much yet, thus isn't very testable.
       
 59554 
       
 59555         * ksvg2/svg/SVGAnimateMotionElement.cpp:
       
 59556         (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
       
 59557         * ksvg2/svg/SVGAnimationElement.cpp:
       
 59558         (WebCore::SVGAnimationElement::parseKeyNumbers):
       
 59559         (WebCore::parseKeySplines):
       
 59560         (WebCore::SVGAnimationElement::parseMappedAttribute):
       
 59561         * ksvg2/svg/SVGAnimationElement.h:
       
 59562         * ksvg2/svg/SVGNumberList.cpp:
       
 59563         (WebCore::SVGNumberList::parse):
       
 59564 
       
 59565 2007-01-18  Adam Roben  <aroben@apple.com>
       
 59566 
       
 59567         Reviewed by Beth.
       
 59568 
       
 59569         Fix: <rdar://problem/4939672> REGRESSION: With text selected that is
       
 59570         not a link, the "Remove Link" contextual menu item remains active
       
 59571 
       
 59572         * platform/ContextMenuItem.h: Added enabled method.
       
 59573         * platform/qt/ContextMenuItemQt.cpp:
       
 59574         (WebCore::ContextMenuItem::enabled): Implemented.
       
 59575         * platform/mac/ContextMenuItemMac.mm:
       
 59576         (WebCore::ContextMenuItem::enabled): Ditto.
       
 59577         * platform/mac/ContextMenuMac.mm:
       
 59578         (-[WebCoreMenuTarget validateMenuItem:]): Implemented to fulfill the
       
 59579         NSMenuValidation protocol.
       
 59580         
       
 59581 2007-01-18  Beth Dakin  <bdakin@apple.com>
       
 59582 
       
 59583         Reviewed by Adele.
       
 59584 
       
 59585         Fix for <rdar://problem/4939558> REGRESSION: "Search in Google", 
       
 59586         "Search in Spotlight" and "Look up in Dictionary" are missing 
       
 59587         initially from the contextual menu
       
 59588 
       
 59589         The bug here is that we select the we were selecting the word after 
       
 59590         the context menu event was dispatched and after the context menu 
       
 59591         was built up.
       
 59592 
       
 59593         * page/EventHandler.cpp:
       
 59594         (WebCore::EventHandler::sendContextMenuEvent): Select the word 
       
 59595         before dispatching the event. It is safe to remove the check for 
       
 59596         swallowEvent since WebCore context menus ensure that we always 
       
 59597         swallow the event anyway.
       
 59598 
       
 59599 2007-01-18  Mark Rowe  <mrowe@apple.com>
       
 59600 
       
 59601         Reviewed by Tim H.
       
 59602 
       
 59603         Fix for http://bugs.webkit.org/show_bug.cgi?id=7926
       
 59604         Bug 7926: Crash using -callWebScriptMethod to access offsetTop property
       
 59605 
       
 59606         * bindings/objc/WebScriptObject.mm:
       
 59607         (-[WebScriptObject callWebScriptMethod:withArguments:]): Bail out early if function value is an immediate,
       
 59608         or if the function object is not callable.
       
 59609 
       
 59610 2007-01-18  Sam Weinig  <sam@webkit.org>
       
 59611 
       
 59612         Reviewed by Maciej.
       
 59613 
       
 59614         Patch for http://bugs.webkit.org/show_bug.cgi?id=11853
       
 59615         REGRESSION (r17352): Whitespace in <title> is rendered
       
 59616 
       
 59617         * loader/DocumentLoader.cpp:
       
 59618         (WebCore::canonicalizedTitle): Changed to also collapse internal
       
 59619         whitespace.  This required removing an optimization that is no
       
 59620         longer possible.
       
 59621         * manual-tests/title-internal-whitespace.html: Added.
       
 59622 
       
 59623 2007-01-18  Mitz Pettel  <mitz@webkit.org>
       
 59624 
       
 59625         Reviewed by Maciej.
       
 59626 
       
 59627         - fix http://bugs.webkit.org/show_bug.cgi?id=12039
       
 59628           Assertion failure in WebCore::Font::primaryFont
       
 59629 
       
 59630         Test: fast/text/font-initial.html
       
 59631 
       
 59632         * css/cssstyleselector.cpp:
       
 59633         (WebCore::CSSStyleSelector::applyProperty): Give 'font: initial' the
       
 59634         Standard generic family. This makes the FontDescription different from
       
 59635         that of the initial font of a GraphicsContext, ensuring that the latter
       
 59636         will not be used.
       
 59637 
       
 59638 2007-01-18  Mitz Pettel  <mitz@webkit.org>
       
 59639 
       
 59640         Reviewed by Darin.
       
 59641 
       
 59642         - fix http://bugs.webkit.org/show_bug.cgi?id=11451
       
 59643           REGRESSION: Dell.com does not render correctly in ToT (stylesheet not loaded)
       
 59644 
       
 59645         Test: http/tests/misc/css-accept-any-type.html
       
 59646 
       
 59647         * loader/CachedCSSStyleSheet.cpp:
       
 59648         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): Changed the accept header
       
 59649         for stylesheets to "text/css,*/*;q=0.1" to match Firefox, accepting CSS served
       
 59650         as any type.
       
 59651 
       
 59652 2007-01-18  Mitz Pettel  <mitz@webkit.org>
       
 59653 
       
 59654         Reviewed by Darin.
       
 59655 
       
 59656         - fix http://bugs.webkit.org/show_bug.cgi?id=11271
       
 59657         REGRESSION (r12358): Text in display: table unselectable
       
 59658 
       
 59659         Test: editing/selection/display-table-text.html
       
 59660 
       
 59661         * editing/htmlediting.cpp:
       
 59662         (WebCore::isTableElement): Changed to return false for text nodes.
       
 59663 
       
 59664 2007-01-18  Mitz Pettel  <mitz@webkit.org>
       
 59665 
       
 59666         Reviewed by Darin.
       
 59667 
       
 59668         - fix http://bugs.webkit.org/show_bug.cgi?id=6218
       
 59669           CSS1: WebTextRenderer caches and re-uses fallback renderers that are based on family lists
       
 59670 
       
 59671         This patch takes character-to-glyph mapping out of FontData and instead makes
       
 59672         each Font keep its own mapping, using a shared set of glyph page fallback trees.
       
 59673 
       
 59674         For each page number there is (at most) one tree. A path from the root to a
       
 59675         node in the tree corresponds to a fallback list of FontDatas. The node points to
       
 59676         a page (which may be shared with other nodes) that maps each character in its range
       
 59677         to a glyph in the first FontData in the fallback list that has it, or to 0 if none of
       
 59678         the FontDatas has a glyph for that character. A special kind of node, that can
       
 59679         only occur as a leaf, corresponds to using system fallback fonts after the list
       
 59680         has been exhausted. This prevents system fallback from polluting non-leaf
       
 59681         nodes.
       
 59682 
       
 59683         Nodes and pages are initialized lazily and employ "copy on write".
       
 59684 
       
 59685         * CMakeLists.txt:
       
 59686         * WebCore.pro:
       
 59687         * WebCore.vcproj/WebCore/WebCore.vcproj:
       
 59688         * WebCore.xcodeproj/project.pbxproj:
       
 59689         * WebCoreSources.bkl:
       
 59690         * platform/Font.cpp:
       
 59691         (WebCore::WidthIterator::WidthIterator): Removed substituteFontData.
       
 59692         (WebCore::WidthIterator::advance): Moved all character-to-glyph mapping logic out
       
 59693         of here and replaced it with a call to Font::glyphDataForCharacter().
       
 59694         (WebCore::Font::Font):
       
 59695         (WebCore::Font::operator=):
       
 59696         (WebCore::Font::glyphDataForCharacter): Added. This method performs the lookup in the
       
 59697         page fallback trees, triggering lazy initialization as needed, and caching pointers to
       
 59698         the retrieved page tree nodes in the font.
       
 59699         (WebCore::Font::update):
       
 59700         (WebCore::Font::drawSimpleText):
       
 59701         (WebCore::Font::floatWidth):
       
 59702         (WebCore::Font::floatWidthForSimpleText): Removed substituteFont argument.
       
 59703         (WebCore::Font::offsetForPositionForSimpleText):
       
 59704         * platform/Font.h:
       
 59705         * platform/FontData.cpp:
       
 59706         (WebCore::FontData::FontData):
       
 59707         * platform/FontData.h:
       
 59708         (WebCore::FontData::missingGlyphData): Added. Returns the "missing glyph" GlyphData for
       
 59709         this FontData.
       
 59710         * platform/GlyphMap.cpp: Removed.
       
 59711         * platform/GlyphMap.h: Removed.
       
 59712         * platform/GlyphPageTreeNode.cpp: Renamed GlyphMap.cpp to this.
       
 59713         (WebCore::GlyphPageTreeNode::getRoot): Added. Returns the root of the page fallback tree for
       
 59714         the given page number.
       
 59715         (WebCore::GlyphPageTreeNode::initializePage): Added. Helper method that initializes the page
       
 59716         pointer of a node, possibly to a pointer to another node's page or to 0.
       
 59717         (WebCore::GlyphPageTreeNode::getChild): Added.
       
 59718         * platform/GlyphPageTreeNode.h: Renamed GlyphMap.h to this.
       
 59719         (WebCore::GlyphPage::glyphDataForCharacter):
       
 59720         (WebCore::GlyphPage::setGlyphDataForCharacter):
       
 59721         (WebCore::GlyphPage::setGlyphDataForIndex):
       
 59722         (WebCore::GlyphPageTreeNode::GlyphPageTreeNode):
       
 59723         (WebCore::GlyphPageTreeNode::getRootChild):
       
 59724         (WebCore::GlyphPageTreeNode::parent):
       
 59725         (WebCore::GlyphPageTreeNode::page):
       
 59726         (WebCore::GlyphPageTreeNode::level):
       
 59727         (WebCore::GlyphPageTreeNode::isSystemFallback): Added. Returns whether the node corresponds
       
 59728         to the system providing fallback fonts, which is done on a character-by-character basis.
       
 59729         * platform/gdk/GlyphMapGdk.cpp: Removed.
       
 59730         * platform/gdk/GlyphPageTreeNodeGdk.cpp: Renamed GlyphMapGdk.cpp to this.
       
 59731         (WebCore::GlyphPage::fill):
       
 59732         * platform/mac/FontDataMac.mm:
       
 59733         (WebCore::FontData::platformInit):
       
 59734         * platform/mac/FontMac.mm:
       
 59735         (WebCore::Font::Font):
       
 59736         * platform/mac/GlyphMapMac.cpp: Removed.
       
 59737         * platform/mac/GlyphPageTreeNodeMac.cpp: Renamed GlypMapMac.cpp to this.
       
 59738         (WebCore::GlyphPage::fill): Changed to return false if the font has no glyphs in the page.
       
 59739         * platform/qt/GlyphMapQt.cpp: Removed.
       
 59740         * platform/qt/GlyphPageTreeNodeQt.cpp: Renamed GlyphMapQt.cpp to this.
       
 59741         (WebCore::GlyphPage::fill):
       
 59742         * platform/win/GlyphMapWin.cpp: Removed.
       
 59743         * platform/win/GlyphPageTreeNodeWin.cpp: Renamed GlyphMapWin to this.
       
 59744         (WebCore::GlyphPage::fill):
       
 59745 
       
 59746 2007-01-18  Mitz Pettel  <mitz@webkit.org>
       
 59747 
       
 59748         Reviewed by Darin.
       
 59749 
       
 59750         - fix http://bugs.webkit.org/show_bug.cgi?id=9952
       
 59751           REGRESSION: Repro crash when dragging an image from the window to the address bar
       
 59752 
       
 59753         * page/FrameView.cpp:
       
 59754         (WebCore::FrameView::~FrameView): Removed the call to Document::detach(). If this
       
 59755         view is the current view, then the Frame should have already detached the document.
       
 59756         Added an assertion that this is the case. If this view is not the current view,
       
 59757         then it cannot access its document, but the page cache should have detached it already.
       
 59758         Similarly, changed to call RenderPart::setWidget() only if this is the current view
       
 59759         in the frame.
       
 59760         (WebCore::FrameView::adjustViewSize): Added an assertion that this view is the current
       
 59761         view in the frame.
       
 59762         (WebCore::FrameView::layout): Ditto.
       
 59763         (WebCore::FrameView::scheduleRelayout): Ditto.
       
 59764         (WebCore::FrameView::scheduleRelayoutOfSubtree): Ditto.
       
 59765         (WebCore::FrameView::windowClipRect): Ditto.
       
 59766 
       
 59767 2007-01-18  Eric Seidel  <eric@webkit.org>
       
 59768 
       
 59769         Reviewed by bdash.
       
 59770 
       
 59771         No test needed, removed bogus debug-only ASSERT.
       
 59772 
       
 59773         * rendering/RenderSVGContainer.cpp:
       
 59774         (WebCore::RenderSVGContainer::paint):
       
 59775 
       
 59776 2007-01-18  Alice Liu  <alice.liu@apple.com>
       
 59777 
       
 59778         Build Fix
       
 59779 
       
 59780         * platform/mac/PasteboardMac.mm:
       
 59781         (WebCore::Pasteboard::writeSelection):
       
 59782 
       
 59783 2007-01-18  Alice Liu  <alice.liu@apple.com>
       
 59784 
       
 59785         Reviewed by Mark Rowe.
       
 59786 
       
 59787         Fixes the leaks from my last patch, except for the first change below which is a missing delegate call for Mail purposes
       
 59788 
       
 59789         * editing/Editor.cpp:
       
 59790         (WebCore::Editor::cut):
       
 59791         * platform/Pasteboard.h:
       
 59792         * platform/mac/PasteboardMac.mm:
       
 59793         (WebCore::Pasteboard::Pasteboard):
       
 59794         (WebCore::Pasteboard::clear):
       
 59795         (WebCore::Pasteboard::writeSelection):
       
 59796         (WebCore::Pasteboard::writeURL):
       
 59797         (WebCore::Pasteboard::plainText):
       
 59798         (WebCore::Pasteboard::documentFragment):
       
 59799 
       
 59800 2007-01-18  David Hyatt  <hyatt@apple.com>
       
 59801 
       
 59802         Make sure layer autoscrolling puts the event coordinates into the layer's coordinate space before
       
 59803         calling hitTest on it.  Fixes "flashy" selection in textareas.
       
 59804 
       
 59805         Reviewed by darin
       
 59806 
       
 59807         * rendering/RenderLayer.cpp:
       
 59808         (WebCore::RenderLayer::autoscroll):
       
 59809         * rendering/RenderTextControl.cpp:
       
 59810         (WebCore::RenderTextControl::nodeAtPoint):
       
 59811 
       
 59812 2007-01-18  Anders Carlsson  <acarlsson@apple.com>
       
 59813 
       
 59814         Reviewed by Adam.
       
 59815 
       
 59816         Get rid of ResourceLoaderMac.mm and make willCacheResponse platform-independent.
       
 59817         
       
 59818         * loader/ResourceLoader.cpp:
       
 59819         (WebCore::ResourceLoader::willCacheResponse):
       
 59820         * loader/ResourceLoader.h:
       
 59821         * loader/mac/ResourceLoaderMac.mm: Removed.
       
 59822         * platform/network/ResourceHandleClient.h:
       
 59823         (WebCore::):
       
 59824         (WebCore::ResourceHandleClient::willCacheResponse):
       
 59825         (WebCore::ResourceHandleClient::willStopBufferingData):
       
 59826         * platform/network/mac/ResourceHandleMac.mm:
       
 59827         (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
       
 59828 
       
 59829 2007-01-18  Maciej Stachowiak  <mjs@apple.com>
       
 59830 
       
 59831         Reviewed by John.
       
 59832 
       
 59833         - fixed <rdar://problem/4887416> REGRESSION (SearchField): Assertion failure in HTMLInputElement::setValueFromRenderer when editing via drag and drop (11846)
       
 59834         http://bugs.webkit.org/show_bug.cgi?id=11846
       
 59835         
       
 59836         * editing/ReplaceSelectionCommand.cpp:
       
 59837         (WebCore::ReplaceSelectionCommand::doApply): Don't insert extra paragraph separators to avoid
       
 59838         nesting blocks in plaintext mode, since that's not an issue under normal circumstances.
       
 59839         * html/HTMLInputElement.h:
       
 59840         * manual-tests/drag-move-in-search-field.html: Added.
       
 59841         * rendering/RenderTextControl.cpp:
       
 59842         (WebCore::RenderTextControl::subtreeHasChanged): constrain the value; we'd
       
 59843         rather truncate it than end up with an illegal value here.
       
 59844 
       
 59845 2007-01-18  Simon Hausmann  <hausmann@kde.org>
       
 59846 
       
 59847         Reviewed by Zack.
       
 59848 
       
 59849         * WebCore.pro: Ha^H^HFix to support massive parallel builds.
       
 59850 
       
 59851 2007-01-18  David Kilzer  <ddkilzer@kilzer.net>
       
 59852 
       
 59853         Reviewed by Darin and Mitz.
       
 59854 
       
 59855         - fix http://bugs.webkit.org/show_bug.cgi?id=12305
       
 59856           REGRESSION: Images do not load in video sections on CNN.com homepage
       
 59857 
       
 59858         <rdar://problem/4931480> REGRESSION: Images do not load in video sections on CNN.com homepage (12305)
       
 59859 
       
 59860         Test: fast/dom/HTMLImageElement/image-lowsrc-getset.html
       
 59861 
       
 59862         * html/HTMLAttributeNames.in: Added lowsrc.
       
 59863         * html/HTMLImageElement.cpp:
       
 59864         (WebCore::HTMLImageElement::isURLAttribute): Added lowsrc.
       
 59865         (WebCore::HTMLImageElement::lowsrc): Added.
       
 59866         (WebCore::HTMLImageElement::setLowsrc): Added.
       
 59867         * html/HTMLImageElement.h: Added lowsrc and setLowsrc.
       
 59868         * html/HTMLImageElement.idl: Added lowsrc.
       
 59869 
       
 59870 2007-01-18  Simon Hausmann  <hausmann@kde.org>
       
 59871 
       
 59872         Reviewed by Zack.
       
 59873 
       
 59874         * WebCore.pro: Remove generated files on make clean.
       
 59875 
       
 59876 2007-01-17  Alice Liu  <alice.liu@apple.com>
       
 59877 
       
 59878         Reviewed by Harrison.
       
 59879 
       
 59880         Fix for <rdar://problem/4894155> REGRESSION: Extra line break is pasted with content into message body after choosing File - Paste
       
 59881 
       
 59882         Migration of some editing code from WebHTMView to WebCore::Editor
       
 59883         resulted in not calling pasteboardTypesForSelection, which Mail was
       
 59884         overriding for the special purpose of adding a type to the
       
 59885         pasteboard after WebKit did.  This patch adds 2 separate code paths
       
 59886         for Tiger and Leopard.  On Tiger we give in and call the WebView's
       
 59887         pasteboardTypesForSelection.  On Leopard we call a delegate after
       
 59888         the pasteboard types are set. 
       
 59889 
       
 59890         * bridge/EditorClient.h:
       
 59891         * editing/Editor.h:
       
 59892         * platform/Pasteboard.h:
       
 59893         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 59894         (WebCore::SVGEmptyEditorClient::didSetSelectionTypesForPasteboard):
       
 59895         (WebCore::SVGEmptyEditorClient::pasteboardTypesForSelection):
       
 59896         * platform/mac/PasteboardMac.mm:
       
 59897         (WebCore::Pasteboard::Pasteboard):
       
 59898         (WebCore::Pasteboard::clear):
       
 59899         (WebCore::Pasteboard::writeSelection):
       
 59900         (WebCore::Pasteboard::writeURL):
       
 59901         (WebCore::Pasteboard::plainText):
       
 59902         (WebCore::Pasteboard::documentFragment):
       
 59903 
       
 59904 2007-01-17  John Sullivan  <sullivan@apple.com>
       
 59905 
       
 59906         Reviewed by Darin
       
 59907 
       
 59908         - WebCore part of fix for <rdar://problem/4462420> REGRESSION: Mail hangs during 
       
 59909           Replace All if the replacement string contains the search string
       
 59910         
       
 59911         * page/Frame.h:
       
 59912         * page/Frame.cpp:
       
 59913         (WebCore::Frame::findString):
       
 59914         new startInSelection parameter -- if true, search starts looking in selection; if false,
       
 59915         search starts looking after the selection
       
 59916         
       
 59917         * page/mac/WebCoreFrameBridge.h:
       
 59918         * page/mac/WebCoreFrameBridge.mm:
       
 59919         (-[WebCoreFrameBridge searchFor:direction:caseSensitive:wrap:startInSelection:]):
       
 59920         new startInSelection parameter, passed through to Frame::findString()
       
 59921 
       
 59922         * editing/JSEditor.cpp:
       
 59923         pass false for new findString parameter, to match old behavior
       
 59924 
       
 59925 2007-01-17  Beth Dakin  <bdakin@apple.com>
       
 59926 
       
 59927         Rubber stamped by Darin.
       
 59928 
       
 59929         * rendering/HitTestResult.cpp: Just added a comment.
       
 59930 
       
 59931 2007-01-17  Justin Garcia  <justin.garcia@apple.com>
       
 59932 
       
 59933         Reviewed by darin
       
 59934         
       
 59935         <rdar://problem/4920488>
       
 59936         REGRESSION: A crash occurs at WebCore::Range::processContents () when removing formatting from selected text (that contains a link)
       
 59937 
       
 59938         * dom/Range.cpp:
       
 59939         (WebCore::Range::commonAncestorContainer): Return null if the nodes
       
 59940         don't have a common ancestor.  As a side effect, the public 
       
 59941         commonAncestorContainer now sets an exception if the Range starts
       
 59942         in one document and ends in another, or starts or ends in a tree
       
 59943         that's been removed from the document.  The spec doesn't cover
       
 59944         this and there is no precedent in other browsers for this case because
       
 59945         they don't allow invalid Ranges (you can create one with WebCore
       
 59946         by removing a node that contains the start/end of a Range).
       
 59947         (WebCore::Range::compareBoundaryPoints): If the the two positions
       
 59948         are in nodes that have no common ancestor, return null.  This doesn't
       
 59949         change the behavior of the public compareBoundaryPoints: it already
       
 59950         throws an exception if the two positions are in nodes that don't have
       
 59951         a common ancestor.  This follows the spec.
       
 59952 
       
 59953 2007-01-17  John Sullivan  <sullivan@apple.com>
       
 59954 
       
 59955         The one word was typed by me, but only after debugging for a long time with Darin.
       
 59956 
       
 59957         - fixed <rdar://problem/4912002> REGRESSION: Series of words marked as a single misspelled word
       
 59958 
       
 59959         * editing/TextIterator.cpp:
       
 59960         (WebCore::WordAwareIterator::WordAwareIterator):
       
 59961         We were creating a TextIterator with the default kind, but WordAwareIterator is designed to work
       
 59962         in concert with CharacterIterator, so they need to use the same kind. CharacterIterator uses
       
 59963         kind RUNFINDER, so WordAwareIterator needs to do so also.
       
 59964 
       
 59965 2007-01-17  Adele Peterson  <adele@apple.com>
       
 59966 
       
 59967         Reviewed by Brady.
       
 59968 
       
 59969         Fix for <rdar://problem/4900895> REGRESSION: onChange doesn't always fire for popups that have had value changed by JS
       
 59970 
       
 59971         No test case since you need to open up the menu to fire onChange.
       
 59972 
       
 59973         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex):
       
 59974           Keep track of m_lastOnChangeIndex even when we're not firing onChange.  Since
       
 59975           the selected index has changed, we still want the m_lastOnChangeIndex to be up to date when we compare
       
 59976           it later.  This matches our behavior in Safari 2.0.
       
 59977 
       
 59978 2007-01-17  Adele Peterson  <adele@apple.com>
       
 59979 
       
 59980         Reviewed by Darin and John.
       
 59981 
       
 59982         - Fix for <rdar://problem/4816550> REGRESSION: autoscrolling doesn't work after double-click
       
 59983 
       
 59984         * page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Set swallowEvent bool instead
       
 59985           of returning early for double and triple clicks.
       
 59986 
       
 59987 2007-01-17  Darin Adler  <darin@apple.com>
       
 59988 
       
 59989         Reviewed by Hyatt.
       
 59990 
       
 59991         * rendering/RenderObject.h: Removed unused nextEditable and previousEditable.
       
 59992         * rendering/RenderObject.cpp: Ditto.
       
 59993 
       
 59994 2007-01-17  Darin Adler  <darin@apple.com>
       
 59995 
       
 59996         Reviewed by Maciej.
       
 59997 
       
 59998         - fix http://bugs.webkit.org/show_bug.cgi?id=12278
       
 59999           <rdar://problem/4928705> REGRESSION(r13070): Dragged image size includes padding (12278)
       
 60000 
       
 60001         * WebCore.exp: Added HitTestResult::imageRect,
       
 60002         removed HitTestResult::boundingBox.
       
 60003 
       
 60004         * rendering/HitTestResult.h:
       
 60005         * rendering/HitTestResult.cpp: (WebCore::HitTestResult::imageRect):
       
 60006         Added. Returns the content rectangle of the image.
       
 60007 
       
 60008         * rendering/RenderObject.h:
       
 60009         * rendering/RenderObject.cpp:
       
 60010         (WebCore::RenderObject::absolutePosition): Made const.
       
 60011         (WebCore::RenderObject::contentBox): Added.
       
 60012         (WebCore::RenderObject::absoluteContentBox): Added.
       
 60013 
       
 60014         * rendering/RenderBox.h:
       
 60015         * rendering/RenderBox.cpp:
       
 60016         (WebCore::RenderBox::absolutePosition): Made const.
       
 60017 
       
 60018         * rendering/RenderTableCell.h:
       
 60019         * rendering/RenderTableCell.cpp:
       
 60020         (WebCore::RenderTableCell::absolutePosition): Made const.
       
 60021 
       
 60022         * rendering/RenderView.h:
       
 60023         * rendering/RenderView.cpp:
       
 60024         (WebCore::RenderView::absolutePosition): Made const.
       
 60025 
       
 60026 2007-01-17  Adele Peterson  <adele@apple.com>
       
 60027 
       
 60028         Reviewed by Beth.
       
 60029 
       
 60030         Fix for  http://bugs.webkit.org/show_bug.cgi?id=10139
       
 60031         <rdar://problem/4823028> REGRESSION: Reproducible crash when selecting a popup/button with ::selection pseudostyle
       
 60032 
       
 60033         Test: fast/css/pseudostyle-anonymous-text.html
       
 60034 
       
 60035         * rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle): Nil check the node.
       
 60036 
       
 60037 2007-01-17  Adele Peterson  <adele@apple.com>
       
 60038 
       
 60039         Reviewed by Anders and John.
       
 60040 
       
 60041         Fix for http://bugs.webkit.org/show_bug.cgi?id=11278
       
 60042         <rdar://problem/4826875> REGRESSION: Popup width doesn't change to accommodate dynamic changes to options
       
 60043 
       
 60044         Test: fast/forms/menulist-width-change.html
       
 60045 
       
 60046         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement):
       
 60047           When the options change, call setNeedsLayoutAndMinMaxRecalc.
       
 60048 
       
 60049 2007-01-16  Alexey Proskuryakov  <ap@webkit.org>
       
 60050 
       
 60051         Reviewed by Maciej.
       
 60052 
       
 60053         http://bugs.webkit.org/show_bug.cgi?id=12268
       
 60054         Give object prototypes their own names
       
 60055 
       
 60056         * bindings/js/kjs_html.cpp: Changed the names of KJS:HTMLElement and KJS::HTMLElement to 
       
 60057         not match the names of their WebCore counterparts. The "DOM" prefix I gave them doesn't 
       
 60058         seem to carry much sense, but matches some other kjs_html object names.
       
 60059 
       
 60060         * bindings/scripts/CodeGeneratorJS.pm: Append "Proto" to interface name for the prototype's ClassInfo.
       
 60061 
       
 60062         * bindings/js/JSHTMLInputElementBase.cpp:
       
 60063         (WebCore::JSHTMLInputElementBasePrototypeFunction::callAsFunction):
       
 60064         (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
       
 60065         * bindings/js/JSHTMLInputElementBase.h:
       
 60066         * bindings/js/JSXMLHttpRequest.cpp:
       
 60067         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
       
 60068         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
       
 60069         (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
       
 60070         * bindings/js/JSXMLHttpRequest.h:
       
 60071         * bindings/js/JSXSLTProcessor.cpp:
       
 60072         (KJS::JSXSLTProcessor::JSXSLTProcessor):
       
 60073         (KJS::XSLTProcessorPrototypeFunction::callAsFunction):
       
 60074         (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
       
 60075         * bindings/js/kjs_css.cpp:
       
 60076         (KJS::DOMCSSStyleDeclaration::DOMCSSStyleDeclaration):
       
 60077         (KJS::DOMCSSStyleDeclarationPrototypeFunction::callAsFunction):
       
 60078         (KJS::DOMMediaList::DOMMediaList):
       
 60079         (KJS::KJS::DOMMediaListPrototypeFunction::callAsFunction):
       
 60080         (KJS::DOMCSSStyleSheet::DOMCSSStyleSheet):
       
 60081         (KJS::DOMCSSStyleSheetPrototypeFunction::callAsFunction):
       
 60082         (KJS::DOMCSSValue::DOMCSSValue):
       
 60083         (KJS::DOMCSSValuePrototypeFunction::callAsFunction):
       
 60084         * bindings/js/kjs_css.h:
       
 60085         * bindings/js/kjs_dom.cpp:
       
 60086         (KJS::DOMNode::DOMNode):
       
 60087         (KJS::DOMNodePrototypeFunction::callAsFunction):
       
 60088         (KJS::DOMEventTargetNode::DOMEventTargetNode):
       
 60089         (KJS::DOMEventTargetNodePrototypeFunction::callAsFunction):
       
 60090         (KJS::DOMNamedNodeMap::DOMNamedNodeMap):
       
 60091         (KJS::DOMNamedNodeMapPrototypeFunction::callAsFunction):
       
 60092         * bindings/js/kjs_dom.h:
       
 60093         * bindings/js/kjs_domnode.h:
       
 60094         * bindings/js/kjs_events.cpp:
       
 60095         (KJS::DOMEvent::DOMEvent):
       
 60096         (KJS::DOMEventPrototypeFunction::callAsFunction):
       
 60097         (KJS::Clipboard::Clipboard):
       
 60098         (KJS::ClipboardPrototypeFunction::callAsFunction):
       
 60099         * bindings/js/kjs_events.h:
       
 60100         * bindings/js/kjs_html.cpp:
       
 60101         (KJS::JSHTMLDocumentPrototypeFunction::callAsFunction):
       
 60102         (KJS::):
       
 60103         (KJS::JSHTMLDocument::JSHTMLDocument):
       
 60104         (KJS::JSHTMLElementPrototypeFunction::callAsFunction):
       
 60105         (KJS::JSHTMLElement::JSHTMLElement):
       
 60106         (KJS::JSHTMLCollection::JSHTMLCollection):
       
 60107         (KJS::JSHTMLCollectionPrototypeFunction::callAsFunction):
       
 60108         * bindings/js/kjs_html.h:
       
 60109         * bindings/js/kjs_navigator.cpp:
       
 60110         * bindings/js/kjs_traversal.cpp:
       
 60111         (KJS::DOMNodeFilter::DOMNodeFilter):
       
 60112         (KJS::DOMNodeFilterPrototypeFunction::callAsFunction):
       
 60113         * bindings/js/kjs_window.cpp:
       
 60114         (KJS::Window::clear):
       
 60115         Changed Proto to Prototype, and ProtoFunc to PrototypeFunction.
       
 60116 
       
 60117 2007-01-17  Lars Knoll <lars@trolltech.com>
       
 60118 
       
 60119         Reviewed by Zack and Darin
       
 60120 
       
 60121         Fix the Qt build again after the latest Image changes.
       
 60122         Also make some of the methods implemented in ImageCG 
       
 60123         crossplatform.
       
 60124 
       
 60125         * platform/graphics/BitmapImage.h:
       
 60126         * platform/graphics/Image.cpp:
       
 60127         (WebCore::Image::fillWithSolidColor):
       
 60128         (WebCore::calculatePatternScale):
       
 60129         (WebCore::Image::drawTiled):
       
 60130         * platform/graphics/Image.h:
       
 60131         * platform/graphics/cg/ImageCG.cpp:
       
 60132         (WebCore::BitmapImage::draw):
       
 60133         * platform/graphics/qt/ImageQt.cpp:
       
 60134         (WebCore::Image::loadPlatformResource):
       
 60135         (WebCore::Image::drawPattern):
       
 60136         (WebCore::BitmapImage::initPlatformData):
       
 60137         (WebCore::BitmapImage::invalidatePlatformData):
       
 60138         (WebCore::BitmapImage::draw):
       
 60139         (WebCore::BitmapImage::drawPattern):
       
 60140         * platform/qt/TemporaryLinkStubs.cpp:
       
 60141 
       
 60142 2007-01-17  Darin Adler  <darin@apple.com>
       
 60143 
       
 60144         - quick attempt to fix the Qt build
       
 60145 
       
 60146         * platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::drawTiled):
       
 60147         Remove obsolete parameters from this stub.
       
 60148 
       
 60149 2007-01-17  Eric Seidel  <eric@webkit.org>
       
 60150 
       
 60151         Reviewed by rwlbuis.
       
 60152 
       
 60153         Test: svg/custom/inner-svg-hit-test.svg
       
 60154 
       
 60155         * rendering/RenderSVGContainer.cpp:
       
 60156         (WebCore::RenderSVGContainer::nodeAtPoint): never allow containers to be hit.
       
 60157 
       
 60158 2007-01-17  Lars Knoll <lars@trolltech.com>
       
 60159 
       
 60160         Reviewed by Zack
       
 60161 
       
 60162         Don't call receivedResponse twice for file: URLs.
       
 60163         Never call back into the ResourceHandleClient once
       
 60164         cancel() has been called on the ResourceHandle.
       
 60165 
       
 60166         * WebCore.pro:
       
 60167         * platform/network/qt/ResourceHandleManagerQt.cpp:
       
 60168         (WebCore::ResourceHandleManager::cancel):
       
 60169         (WebCore::ResourceHandleManager::receivedResponse):
       
 60170         (WebCore::ResourceHandleManager::receivedData):
       
 60171         (WebCore::ResourceHandleManager::receivedFinished):
       
 60172         (WebCore::FileLoader::request):
       
 60173         (WebCore::FileLoader::parseDataUrl):
       
 60174         (WebCore::WebCoreHttp::scheduleNextRequest):
       
 60175         * platform/network/qt/ResourceHandleManagerQt.h:
       
 60176 
       
 60177 2007-01-17  Eric Seidel  <eric@webkit.org>
       
 60178 
       
 60179         No review, build fix only.
       
 60180 
       
 60181         * platform/graphics/cg/ImageCG.cpp: correct drawPatternCombined to drawPattern
       
 60182         (WebCore::Image::drawPattern):
       
 60183         (WebCore::Image::drawTiled):
       
 60184 
       
 60185 2007-01-17  Eric Seidel  <eric@webkit.org>
       
 60186 
       
 60187         Reviewed by mitz and rwlbuis.
       
 60188         
       
 60189         SVGs do not work as background images:
       
 60190         http://bugs.webkit.org/show_bug.cgi?id=12096
       
 60191 
       
 60192         Tests updated:
       
 60193         - fast/images/svg-as-background.svg: now passes
       
 60194         - fast/images/svg-as-tiled-background.svg: now passes
       
 60195 
       
 60196         * platform/graphics/BitmapImage.h:
       
 60197         (WebCore::BitmapImage::nativeImageForCurrentFrame):
       
 60198         (WebCore::BitmapImage::mayFillWithSolidColor):
       
 60199         (WebCore::BitmapImage::solidColor):
       
 60200         * platform/graphics/Image.h:
       
 60201         (WebCore::Image::mayFillWithSolidColor):
       
 60202         (WebCore::Image::solidColor):
       
 60203         (WebCore::Image::nativeImageForCurrentFrame):
       
 60204         (WebCore::Image::startAnimation):
       
 60205         * platform/graphics/cg/ImageCG.cpp:
       
 60206         (WebCore::Image::drawPatternCallback):
       
 60207         (WebCore::Image::drawPatternCombined):
       
 60208         (WebCore::caculatePatternScale):
       
 60209         (WebCore::Image::drawTiled):
       
 60210         * platform/graphics/cg/PDFDocumentImage.cpp:
       
 60211         * platform/graphics/cg/PDFDocumentImage.h:
       
 60212         * platform/graphics/svg/SVGImage.cpp:
       
 60213         (WebCore::SVGImage::nativeImageForCurrentFrame):
       
 60214         * platform/graphics/svg/SVGImage.h:
       
 60215 
       
 60216 2007-01-17  Rob Buis  <buis@kde.org>
       
 60217 
       
 60218         Reviewed by Eric
       
 60219 
       
 60220         Add proper condition for rx attribute negative check.
       
 60221 
       
 60222         * ksvg2/svg/SVGRectElement.cpp:
       
 60223         (WebCore::SVGRectElement::parseMappedAttribute):
       
 60224 
       
 60225 2007-01-17  Lars Knoll <lars@trolltech.com>
       
 60226 
       
 60227         Reviewed by Zack
       
 60228 
       
 60229         change all notImplemented() macros to use qDebug
       
 60230         instead of fprintf(stder, ...)
       
 60231 
       
 60232         * loader/qt/DocumentLoaderQt.cpp:
       
 60233         * loader/qt/FrameLoaderQt.cpp:
       
 60234         * page/qt/EventHandlerQt.cpp:
       
 60235         * page/qt/FrameQt.cpp:
       
 60236         * platform/graphics/qt/GraphicsContextQt.cpp:
       
 60237         * platform/graphics/qt/IconQt.cpp:
       
 60238         * platform/network/qt/ResourceHandleManagerQt.cpp:
       
 60239         * platform/network/qt/ResourceHandleQt.cpp:
       
 60240         * platform/qt/CursorQt.cpp:
       
 60241         * platform/qt/FileChooserQt.cpp:
       
 60242         * platform/qt/MimeTypeRegistryQt.cpp:
       
 60243         * platform/qt/PageQt.cpp: Removed.
       
 60244         * platform/qt/PopupMenuQt.cpp:
       
 60245         * platform/qt/ScrollViewQt.cpp:
       
 60246         * platform/qt/TemporaryLinkStubs.cpp:
       
 60247         * platform/qt/TextBoundaries.cpp:
       
 60248         * platform/qt/WidgetQt.cpp:
       
 60249 
       
 60250 2007-01-16  Brady Eidson  <beidson@apple.com>
       
 60251 
       
 60252         Reviewed by Oliver
       
 60253 
       
 60254         A few enhancements to the HTTP Auth architecture
       
 60255 
       
 60256         * platform/network/ProtectionSpace.cpp:
       
 60257         (WebCore::ProtectionSpace::isProxy):
       
 60258         (WebCore::ProtectionSpace::receivesCredentialSecurely):
       
 60259         * platform/network/ProtectionSpace.h:
       
 60260 
       
 60261 2007-01-16  Alice Liu  <alice.liu@apple.com>
       
 60262 
       
 60263         Reviewed by harrison.
       
 60264 
       
 60265         Fixed <rdar://problem/4921134> WebKit needs extensible cut/copy to allow additional types to be written to pasteboard
       
 60266 
       
 60267         * WebCore.xcodeproj/project.pbxproj:
       
 60268         * bridge/EditorClient.h:
       
 60269         * editing/Editor.cpp:
       
 60270         (WebCore::Editor::copy):
       
 60271         (WebCore::Editor::didWriteSelectionToPasteboard):
       
 60272         * editing/Editor.h:
       
 60273         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 60274         (WebCore::SVGEmptyEditorClient::didWriteSelectionToPasteboard):
       
 60275 
       
 60276 2007-01-16  Justin Garcia  <justin.garcia@apple.com>
       
 60277 
       
 60278         Reviewed by harrison
       
 60279         
       
 60280         <rdar://problem/4747450>
       
 60281         Gmail Editor: Caret doesn't always position itself after list marker
       
 60282         <rdar://problem/4917055>
       
 60283         GMail Editor: A hang can occur when attempting to apply list styling to selected indented text
       
 60284 
       
 60285         * editing/TextIterator.cpp:
       
 60286         (WebCore::TextIterator::rangeFromLocationAndLength): Use VisiblePositions
       
 60287         to compute the end of a run for emitted '\n's, because it's often wrong
       
 60288         in that case.
       
 60289 
       
 60290 2007-01-16  Darin Adler  <darin@apple.com>
       
 60291 
       
 60292         - quick lame attempt to get Qt compiling again
       
 60293 
       
 60294         * platform/qt/ContextMenuQt.cpp: Removed show() function.
       
 60295 
       
 60296 2007-01-17  Nicholas Shanks  <contact@nickshanks.com>
       
 60297 
       
 60298         Reviewed by Darin.
       
 60299 
       
 60300         * platform/network/ResourceRequest.h:
       
 60301         (WebCore::ResourceRequest::setHTTPAccept): Correct argument name.
       
 60302 
       
 60303 2007-01-16  Beth Dakin  <bdakin@apple.com>
       
 60304 
       
 60305         Reviewed by Adam.
       
 60306 
       
 60307         Get rid of show() and hide() since they don't do anything.
       
 60308 
       
 60309         * page/ContextMenuController.cpp:
       
 60310         (WebCore::ContextMenuController::handleContextMenuEvent):
       
 60311         * platform/ContextMenu.h:
       
 60312         * platform/mac/ContextMenuMac.mm:
       
 60313 
       
 60314 2007-01-16  Lars Knoll <lars@trolltech.com>
       
 60315 
       
 60316         Reviewed by Zack
       
 60317 
       
 60318         Cleaned up the way we create native widgets. They are
       
 60319         now not created in WebCore anymore, but in the new
       
 60320         Qt API to WebKit.
       
 60321 
       
 60322         Fix a compile issue in the ResourceHandleManager.
       
 60323 
       
 60324         * WebCore.pro:
       
 60325         * platform/ScrollView.h:
       
 60326         * platform/Widget.h:
       
 60327         (WebCore::ResourceHandleManager::cancel):
       
 60328         * platform/qt/ScrollViewCanvasQt.cpp:
       
 60329         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
       
 60330         (WebCore::ScrollViewCanvasQt::paintEvent):
       
 60331         (WebCore::ScrollViewCanvasQt::mouseMoveEvent):
       
 60332         (WebCore::ScrollViewCanvasQt::mousePressEvent):
       
 60333         (WebCore::ScrollViewCanvasQt::mouseReleaseEvent):
       
 60334         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
       
 60335         * platform/qt/ScrollViewCanvasQt.h:
       
 60336         * platform/qt/ScrollViewQt.cpp:
       
 60337         (WebCore::ScrollView::ScrollView):
       
 60338         (WebCore::ScrollView::setScrollArea):
       
 60339         (WebCore::ScrollView::addChild):
       
 60340         * platform/qt/WidgetQt.cpp:
       
 60341         * platform/network/qt/ResourceHandleManagerQt.cpp:
       
 60342 
       
 60343 2007-01-16  Lars Knoll <lars@trolltech.com>
       
 60344 
       
 60345         Reviewed by Zack
       
 60346 
       
 60347         Looks like ResourceHandle _has_ to do everything
       
 60348         asynchronously if we don't want to run into
       
 60349         lots of trouble in the loader.
       
 60350 
       
 60351         Implement support data: URLs.
       
 60352 
       
 60353         Remove some unused Qt only code in ResourceHandleClient.h
       
 60354 
       
 60355         * platform/network/ResourceHandleClient.h:
       
 60356         * platform/network/qt/ResourceHandleManagerQt.cpp:
       
 60357         (WebCore::RequestQt::setURL):
       
 60358         (WebCore::ResourceHandleManager::add):
       
 60359         (WebCore::ResourceHandleManager::cancel):
       
 60360         (WebCore::ResourceHandleManager::receivedFinished):
       
 60361         (WebCore::LoaderThread::run):
       
 60362         (WebCore::FileLoader::request):
       
 60363         (WebCore::FileLoader::sendData):
       
 60364         (WebCore::FileLoader::parseDataUrl):
       
 60365         * platform/network/qt/ResourceHandleManagerQt.h:
       
 60366 
       
 60367 2007-01-16  Eric Seidel  <eric@webkit.org>
       
 60368 
       
 60369         Reviewed by mitz.
       
 60370 
       
 60371         Refactor drawTiled implementations in preparation for combining them.
       
 60372         Removed unused RoundTile code path.
       
 60373 
       
 60374         * platform/graphics/cg/ImageCG.cpp:
       
 60375         (WebCore::drawPattern):
       
 60376         (WebCore::BitmapImage::drawTiled):
       
 60377         (WebCore::caculatePatternScale):
       
 60378 
       
 60379 2007-01-16  Darin Adler  <darin@apple.com>
       
 60380 
       
 60381         Reviewed by Mark Rowe.
       
 60382 
       
 60383         - removed unused field from loader
       
 60384 
       
 60385         * loader/loader.cpp:
       
 60386         (WebCore::Loader::numRequests):
       
 60387         (WebCore::Loader::cancelRequests):
       
 60388         * loader/loader.h:
       
 60389 
       
 60390 2007-01-15  Rob Buis  <buis@kde.org>
       
 60391 
       
 60392         Reviewed by Eric.
       
 60393 
       
 60394         http://bugs.webkit.org/show_bug.cgi?id=12272
       
 60395         SVG picture is clipped (edges not visible)
       
 60396 
       
 60397         Expose css dpi constant and use it for svg, making
       
 60398         1in amount to 96 pixels like for html.
       
 60399 
       
 60400         * css/CSSPrimitiveValue.cpp:
       
 60401         (WebCore::CSSPrimitiveValue::computeLengthFloat):
       
 60402         (WebCore::scaleFactorForConversion):
       
 60403         * css/csshelper.h:
       
 60404         * ksvg2/svg/SVGLength.cpp:
       
 60405         (WebCore::SVGLength::value):
       
 60406         (WebCore::SVGLength::setValue):
       
 60407         * ksvg2/svg/SVGLength.h:
       
 60408 
       
 60409 2007-01-15  Brady Eidson  <beidson@apple.com>
       
 60410 
       
 60411         Reviewed by Adam
       
 60412         
       
 60413         CFNet additions
       
 60414 
       
 60415         * platform/network/AuthenticationChallenge.cpp:
       
 60416         (WebCore::operator==):
       
 60417         * platform/network/AuthenticationChallenge.h:
       
 60418         (WebCore::AuthenticationChallenge::sourceHandle):
       
 60419         (WebCore::AuthenticationChallenge::cfURLAuthChallengeRef):
       
 60420         * platform/network/ResourceError.h:
       
 60421         * platform/network/ResourceHandle.h:
       
 60422         * platform/network/ResourceHandleInternal.h:
       
 60423         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
       
 60424 
       
 60425 2007-01-15  Eric Seidel  <eric@webkit.org>
       
 60426 
       
 60427         Reviewed by hyatt.
       
 60428 
       
 60429         Don't map attributes in namespaces other than null to CSS properties.
       
 60430         
       
 60431         Test: svg/custom/attribute-namespace-check.svg
       
 60432 
       
 60433         * ksvg2/svg/SVGStyledElement.cpp:
       
 60434         (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
       
 60435 
       
 60436 2007-01-15  Lars Naesbye Christensen  <lars@naesbye.dk>
       
 60437 
       
 60438         Reviewed by Darin.
       
 60439 
       
 60440         - http://bugs.webkit.org/show_bug.cgi?id=11112
       
 60441           add a drop shadow to the hand cursor used for links
       
 60442 
       
 60443         * Resources/linkCursor.png: Added a drop shadow.
       
 60444 
       
 60445 2007-01-15  Darin Adler  <darin@apple.com>
       
 60446 
       
 60447         Reviewed by Adam.
       
 60448 
       
 60449         - fix http://bugs.webkit.org/show_bug.cgi?id=12190
       
 60450           REGRESSION: Placeholder text does not reflect dynamic updates
       
 60451 
       
 60452         Test: fast/forms/placeholder-set-attribute.html
       
 60453 
       
 60454         * html/HTMLTextFieldInnerElement.cpp:
       
 60455         (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
       
 60456         Call onSearch on the element since I removed it from the renderer.
       
 60457 
       
 60458         * rendering/RenderTextControl.h: Added explicit virtual keywords for overrides
       
 60459         of virtual functions. Removed the unneeded onSearch function. Made the inheritance
       
 60460         from PopupMenuClient be private, and made the overrides all private. Replaced the
       
 60461         showPlaceholderIfNeeded and hidePlaceholderIfNeeded functions with updatePlaceholder.
       
 60462         * rendering/RenderTextControl.cpp:
       
 60463         (WebCore::RenderTextControl::createResultsButtonStyle): Added an assertion.
       
 60464         (WebCore::RenderTextControl::updatePlaceholder): Added. Replaces the two
       
 60465         functions, showPlaceholderIfNeeded and hidePlaceholderIfNeeded.
       
 60466         (WebCore::RenderTextControl::updateFromElement): Added call to
       
 60467         updatePlaceholder before updating the value. Also improved the structure
       
 60468         of the function and corrected incorrect use of copy and replace.
       
 60469         (WebCore::RenderTextControl::updateCancelButtonVisibility): Added an
       
 60470         assertion and removed an unneeded local variable.
       
 60471         (WebCore::RenderTextControl::subtreeHasChanged): Removed an unneeded
       
 60472         null check and virtual function calls.
       
 60473         (WebCore::RenderTextControl::forwardEvent): Replaced calls to the old
       
 60474         functions with calls to updatePlaceholder.
       
 60475         (WebCore::RenderTextControl::selectionChanged): Changed code to dispatch
       
 60476         the select event directly -- I plan to remove the onSelect function, which
       
 60477         was only called here.
       
 60478         (WebCore::RenderTextControl::autosaveName): Removed too-specific cast and
       
 60479         local variable.
       
 60480         (WebCore::RenderTextControl::addSearchResult): Added assertion and changed
       
 60481         variable name for clarity.
       
 60482         (WebCore::RenderTextControl::valueChanged): Changed code to check for empty
       
 60483         autosave name instead of null for consistency with other call sites that
       
 60484         manage the autosave name. Also changed the code that dispatches an event
       
 60485         to call onSearch on the input element so we don't need our own function.
       
 60486 
       
 60487 2007-01-15  Eric Seidel  <eric@webkit.org>
       
 60488 
       
 60489         Reviewed by hyatt.
       
 60490 
       
 60491         Fix SVGStyledElement::parseMappedAttribute to only map SVG-allowed CSS properties
       
 60492         (i.e. width is no longer mapped to CSS for SVG)
       
 60493         Add SVGStyledElement::mapToEntry to allow RenderStyle-sharing
       
 60494         http://bugs.webkit.org/show_bug.cgi?id=12060
       
 60495 
       
 60496         * dom/MappedAttributeEntry.h:
       
 60497         (WebCore::):
       
 60498         * ksvg2/svg/SVGStyledElement.cpp:
       
 60499         (WebCore::cssPropertyIdForName): new helper
       
 60500         (WebCore::mapAttributeToCSSProperty): new helper
       
 60501         (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName): new helper
       
 60502         (WebCore::SVGStyledElement::mapToEntry): added.
       
 60503         (WebCore::SVGStyledElement::parseMappedAttribute): use cssPropertyIdForSVGAttributeName
       
 60504         * ksvg2/svg/SVGStyledElement.h:
       
 60505 
       
 60506 2007-01-15  Eric Seidel  <eric@webkit.org>
       
 60507 
       
 60508         Reviewed by bdash.
       
 60509 
       
 60510         Update header guards to follow new style guidelines using new clean-header-guards script.
       
 60511 
       
 60512         * bindings/js/JSHTMLElementWrapperFactory.h:
       
 60513         * bindings/js/JSHTMLInputElementBase.h:
       
 60514         * bindings/js/JSHTMLOptionElementConstructor.h:
       
 60515         * bindings/js/JSSVGElementWrapperFactory.h:
       
 60516         * bindings/js/JSSVGPODTypeWrapper.h:
       
 60517         * bindings/js/JSXMLHttpRequest.h:
       
 60518         * bindings/js/JSXSLTProcessor.h:
       
 60519         * bindings/js/kjs_binding.h:
       
 60520         * bindings/js/kjs_css.h:
       
 60521         * bindings/js/kjs_dom.h:
       
 60522         * bindings/js/kjs_domnode.h:
       
 60523         * bindings/js/kjs_events.h:
       
 60524         * bindings/js/kjs_html.h:
       
 60525         * bindings/js/kjs_navigator.h:
       
 60526         * bindings/js/kjs_proxy.h:
       
 60527         * bindings/js/kjs_traversal.h:
       
 60528         * bindings/js/kjs_window.h:
       
 60529         * bridge/EditorClient.h:
       
 60530         * bridge/History.h:
       
 60531         * css/CSSStyleSheet.h:
       
 60532         * css/CSSValue.h:
       
 60533         * css/CSSValueList.h:
       
 60534         * css/DashboardRegion.h:
       
 60535         * css/FontFamilyValue.h:
       
 60536         * css/FontValue.h:
       
 60537         * css/MediaFeatureNames.h:
       
 60538         * css/MediaList.h:
       
 60539         * css/Pair.h:
       
 60540         * css/RectImpl.h:
       
 60541         * css/ShadowValue.h:
       
 60542         * css/StyleBase.h:
       
 60543         * css/StyleList.h:
       
 60544         * css/StyleSheet.h:
       
 60545         * css/StyleSheetList.h:
       
 60546         * css/cssstyleselector.h:
       
 60547         * dom/BeforeTextInsertedEvent.h:
       
 60548         * dom/CDATASection.h:
       
 60549         * dom/CharacterData.h:
       
 60550         * dom/ChildNodeList.h:
       
 60551         * dom/Comment.h:
       
 60552         * dom/DOMImplementation.h:
       
 60553         * dom/DocPtr.h:
       
 60554         * dom/Document.h:
       
 60555         * dom/DocumentFragment.h:
       
 60556         * dom/DocumentMarker.h:
       
 60557         * dom/DocumentType.h:
       
 60558         * dom/EditingText.h:
       
 60559         * dom/Entity.h:
       
 60560         * dom/EntityReference.h:
       
 60561         * dom/EventNames.h:
       
 60562         * dom/EventTargetNode.h:
       
 60563         * dom/NameNodeList.h:
       
 60564         * dom/NamedNodeMap.h:
       
 60565         * dom/Node.h:
       
 60566         * dom/NodeList.h:
       
 60567         * dom/Notation.h:
       
 60568         * dom/Position.h:
       
 60569         * dom/ProcessingInstruction.h:
       
 60570         * dom/Range.h:
       
 60571         * dom/StyleElement.h:
       
 60572         * dom/Text.h:
       
 60573         * editing/AppendNodeCommand.h:
       
 60574         * editing/ApplyStyleCommand.h:
       
 60575         * editing/BreakBlockquoteCommand.h:
       
 60576         * editing/CommandByName.h:
       
 60577         * editing/CompositeEditCommand.h:
       
 60578         * editing/DeleteButton.h:
       
 60579         * editing/DeleteButtonController.h:
       
 60580         * editing/DeleteFromTextNodeCommand.h:
       
 60581         * editing/DeleteSelectionCommand.h:
       
 60582         * editing/InsertIntoTextNodeCommand.h:
       
 60583         * editing/InsertLineBreakCommand.h:
       
 60584         * editing/InsertNodeBeforeCommand.h:
       
 60585         * editing/InsertParagraphSeparatorCommand.h:
       
 60586         * editing/InsertTextCommand.h:
       
 60587         * editing/JoinTextNodesCommand.h:
       
 60588         * editing/MergeIdenticalElementsCommand.h:
       
 60589         * editing/ModifySelectionListLevel.h:
       
 60590         * editing/MoveSelectionCommand.h:
       
 60591         * editing/RemoveCSSPropertyCommand.h:
       
 60592         * editing/RemoveNodeAttributeCommand.h:
       
 60593         * editing/RemoveNodeCommand.h:
       
 60594         * editing/RemoveNodePreservingChildrenCommand.h:
       
 60595         * editing/ReplaceSelectionCommand.h:
       
 60596         * editing/SetNodeAttributeCommand.h:
       
 60597         * editing/SplitElementCommand.h:
       
 60598         * editing/SplitTextNodeCommand.h:
       
 60599         * editing/SplitTextNodeContainingElementCommand.h:
       
 60600         * editing/TextGranularity.h:
       
 60601         * editing/TypingCommand.h:
       
 60602         * editing/WrapContentsInDummySpanCommand.h:
       
 60603         * history/BackForwardList.h:
       
 60604         * history/HistoryItem.h:
       
 60605         * history/HistoryItemTimer.h:
       
 60606         * history/PageCache.h:
       
 60607         * html/CanvasGradient.h:
       
 60608         * html/CanvasPattern.h:
       
 60609         * html/CanvasRenderingContext2D.h:
       
 60610         * html/CanvasStyle.h:
       
 60611         * html/FormDataList.h:
       
 60612         * html/HTMLAnchorElement.h:
       
 60613         * html/HTMLAppletElement.h:
       
 60614         * html/HTMLAreaElement.h:
       
 60615         * html/HTMLBRElement.h:
       
 60616         * html/HTMLBaseElement.h:
       
 60617         * html/HTMLBaseFontElement.h:
       
 60618         * html/HTMLBlockquoteElement.h:
       
 60619         * html/HTMLBodyElement.h:
       
 60620         * html/HTMLButtonElement.h:
       
 60621         * html/HTMLCanvasElement.h:
       
 60622         * html/HTMLCollection.h:
       
 60623         * html/HTMLDListElement.h:
       
 60624         * html/HTMLDirectoryElement.h:
       
 60625         * html/HTMLDivElement.h:
       
 60626         * html/HTMLElement.h:
       
 60627         * html/HTMLElementFactory.h:
       
 60628         * html/HTMLEmbedElement.h:
       
 60629         * html/HTMLFieldSetElement.h:
       
 60630         * html/HTMLFontElement.h:
       
 60631         * html/HTMLFormCollection.h:
       
 60632         * html/HTMLFormElement.h:
       
 60633         * html/HTMLFrameSetElement.h:
       
 60634         * html/HTMLGenericFormElement.h:
       
 60635         * html/HTMLHRElement.h:
       
 60636         * html/HTMLHeadElement.h:
       
 60637         * html/HTMLHeadingElement.h:
       
 60638         * html/HTMLHtmlElement.h:
       
 60639         * html/HTMLImageElement.h:
       
 60640         * html/HTMLImageLoader.h:
       
 60641         * html/HTMLInputElement.h:
       
 60642         * html/HTMLIsIndexElement.h:
       
 60643         * html/HTMLKeygenElement.h:
       
 60644         * html/HTMLLIElement.h:
       
 60645         * html/HTMLLabelElement.h:
       
 60646         * html/HTMLLegendElement.h:
       
 60647         * html/HTMLLinkElement.h:
       
 60648         * html/HTMLMapElement.h:
       
 60649         * html/HTMLMarqueeElement.h:
       
 60650         * html/HTMLMenuElement.h:
       
 60651         * html/HTMLMetaElement.h:
       
 60652         * html/HTMLModElement.h:
       
 60653         * html/HTMLNameCollection.h:
       
 60654         * html/HTMLOListElement.h:
       
 60655         * html/HTMLObjectElement.h:
       
 60656         * html/HTMLOptGroupElement.h:
       
 60657         * html/HTMLOptionElement.h:
       
 60658         * html/HTMLOptionsCollection.h:
       
 60659         * html/HTMLParagraphElement.h:
       
 60660         * html/HTMLParamElement.h:
       
 60661         * html/HTMLParser.h:
       
 60662         * html/HTMLPlugInElement.h:
       
 60663         * html/HTMLPreElement.h:
       
 60664         * html/HTMLQuoteElement.h:
       
 60665         * html/HTMLScriptElement.h:
       
 60666         * html/HTMLSelectElement.h:
       
 60667         * html/HTMLStyleElement.h:
       
 60668         * html/HTMLTableCaptionElement.h:
       
 60669         * html/HTMLTableCellElement.h:
       
 60670         * html/HTMLTableColElement.h:
       
 60671         * html/HTMLTableElement.h:
       
 60672         * html/HTMLTablePartElement.h:
       
 60673         * html/HTMLTableRowElement.h:
       
 60674         * html/HTMLTableSectionElement.h:
       
 60675         * html/HTMLTextAreaElement.h:
       
 60676         * html/HTMLTextFieldInnerElement.h:
       
 60677         * html/HTMLTitleElement.h:
       
 60678         * html/HTMLUListElement.h:
       
 60679         * ksvg2/css/SVGRenderStyle.h:
       
 60680         * ksvg2/css/SVGRenderStyleDefs.h:
       
 60681         * ksvg2/events/JSSVGLazyEventListener.h:
       
 60682         * ksvg2/events/SVGZoomEvent.h:
       
 60683         * ksvg2/misc/KCanvasRenderingStyle.h:
       
 60684         * ksvg2/misc/PointerEventsHitRules.h:
       
 60685         * ksvg2/misc/SVGDocumentExtensions.h:
       
 60686         * ksvg2/misc/SVGImageLoader.h:
       
 60687         * ksvg2/misc/TimeScheduler.h:
       
 60688         * ksvg2/svg/GradientAttributes.h:
       
 60689         * ksvg2/svg/LinearGradientAttributes.h:
       
 60690         * ksvg2/svg/PatternAttributes.h:
       
 60691         * ksvg2/svg/RadialGradientAttributes.h:
       
 60692         * ksvg2/svg/SVGAElement.h:
       
 60693         * ksvg2/svg/SVGAngle.h:
       
 60694         * ksvg2/svg/SVGAnimateColorElement.h:
       
 60695         * ksvg2/svg/SVGAnimateElement.h:
       
 60696         * ksvg2/svg/SVGAnimateMotionElement.h:
       
 60697         * ksvg2/svg/SVGAnimateTransformElement.h:
       
 60698         * ksvg2/svg/SVGAnimatedPathData.h:
       
 60699         * ksvg2/svg/SVGAnimatedPoints.h:
       
 60700         * ksvg2/svg/SVGAnimatedTemplate.h:
       
 60701         * ksvg2/svg/SVGAnimationElement.h:
       
 60702         * ksvg2/svg/SVGCircleElement.h:
       
 60703         * ksvg2/svg/SVGClipPathElement.h:
       
 60704         * ksvg2/svg/SVGColor.h:
       
 60705         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
       
 60706         * ksvg2/svg/SVGCursorElement.h:
       
 60707         * ksvg2/svg/SVGDOMImplementation.h:
       
 60708         * ksvg2/svg/SVGDefsElement.h:
       
 60709         * ksvg2/svg/SVGDescElement.h:
       
 60710         * ksvg2/svg/SVGDocument.h:
       
 60711         * ksvg2/svg/SVGElement.h:
       
 60712         * ksvg2/svg/SVGElementInstance.h:
       
 60713         * ksvg2/svg/SVGElementInstanceList.h:
       
 60714         * ksvg2/svg/SVGEllipseElement.h:
       
 60715         * ksvg2/svg/SVGExternalResourcesRequired.h:
       
 60716         * ksvg2/svg/SVGFEBlendElement.h:
       
 60717         * ksvg2/svg/SVGFEColorMatrixElement.h:
       
 60718         * ksvg2/svg/SVGFEComponentTransferElement.h:
       
 60719         * ksvg2/svg/SVGFECompositeElement.h:
       
 60720         * ksvg2/svg/SVGFEDiffuseLightingElement.h:
       
 60721         * ksvg2/svg/SVGFEDisplacementMapElement.h:
       
 60722         * ksvg2/svg/SVGFEDistantLightElement.h:
       
 60723         * ksvg2/svg/SVGFEFloodElement.h:
       
 60724         * ksvg2/svg/SVGFEFuncAElement.h:
       
 60725         * ksvg2/svg/SVGFEFuncBElement.h:
       
 60726         * ksvg2/svg/SVGFEFuncGElement.h:
       
 60727         * ksvg2/svg/SVGFEFuncRElement.h:
       
 60728         * ksvg2/svg/SVGFEGaussianBlurElement.h:
       
 60729         * ksvg2/svg/SVGFEImageElement.h:
       
 60730         * ksvg2/svg/SVGFELightElement.h:
       
 60731         * ksvg2/svg/SVGFEMergeElement.h:
       
 60732         * ksvg2/svg/SVGFEMergeNodeElement.h:
       
 60733         * ksvg2/svg/SVGFEOffsetElement.h:
       
 60734         * ksvg2/svg/SVGFEPointLightElement.h:
       
 60735         * ksvg2/svg/SVGFESpecularLightingElement.h:
       
 60736         * ksvg2/svg/SVGFESpotLightElement.h:
       
 60737         * ksvg2/svg/SVGFETileElement.h:
       
 60738         * ksvg2/svg/SVGFETurbulenceElement.h:
       
 60739         * ksvg2/svg/SVGFilterElement.h:
       
 60740         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
       
 60741         * ksvg2/svg/SVGFitToViewBox.h:
       
 60742         * ksvg2/svg/SVGForeignObjectElement.h:
       
 60743         * ksvg2/svg/SVGGElement.h:
       
 60744         * ksvg2/svg/SVGGradientElement.h:
       
 60745         * ksvg2/svg/SVGImageElement.h:
       
 60746         * ksvg2/svg/SVGLangSpace.h:
       
 60747         * ksvg2/svg/SVGLength.h:
       
 60748         * ksvg2/svg/SVGLengthList.h:
       
 60749         * ksvg2/svg/SVGLineElement.h:
       
 60750         * ksvg2/svg/SVGLinearGradientElement.h:
       
 60751         * ksvg2/svg/SVGList.h:
       
 60752         * ksvg2/svg/SVGListTraits.h:
       
 60753         * ksvg2/svg/SVGLocatable.h:
       
 60754         * ksvg2/svg/SVGMarkerElement.h:
       
 60755         * ksvg2/svg/SVGMaskElement.h:
       
 60756         * ksvg2/svg/SVGMetadataElement.h:
       
 60757         * ksvg2/svg/SVGNumberList.h:
       
 60758         * ksvg2/svg/SVGPaint.h:
       
 60759         * ksvg2/svg/SVGParserUtilities.h:
       
 60760         * ksvg2/svg/SVGPathElement.h:
       
 60761         * ksvg2/svg/SVGPathSeg.h:
       
 60762         * ksvg2/svg/SVGPathSegArc.h:
       
 60763         * ksvg2/svg/SVGPathSegClosePath.h:
       
 60764         * ksvg2/svg/SVGPathSegCurvetoCubic.h:
       
 60765         * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
       
 60766         * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
       
 60767         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
       
 60768         * ksvg2/svg/SVGPathSegLineto.h:
       
 60769         * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
       
 60770         * ksvg2/svg/SVGPathSegLinetoVertical.h:
       
 60771         * ksvg2/svg/SVGPathSegList.h:
       
 60772         * ksvg2/svg/SVGPathSegMoveto.h:
       
 60773         * ksvg2/svg/SVGPatternElement.h:
       
 60774         * ksvg2/svg/SVGPointList.h:
       
 60775         * ksvg2/svg/SVGPolyElement.h:
       
 60776         * ksvg2/svg/SVGPolygonElement.h:
       
 60777         * ksvg2/svg/SVGPolylineElement.h:
       
 60778         * ksvg2/svg/SVGPreserveAspectRatio.h:
       
 60779         * ksvg2/svg/SVGRadialGradientElement.h:
       
 60780         * ksvg2/svg/SVGRectElement.h:
       
 60781         * ksvg2/svg/SVGRenderingIntent.h:
       
 60782         * ksvg2/svg/SVGSVGElement.h:
       
 60783         * ksvg2/svg/SVGScriptElement.h:
       
 60784         * ksvg2/svg/SVGSetElement.h:
       
 60785         * ksvg2/svg/SVGStopElement.h:
       
 60786         * ksvg2/svg/SVGStringList.h:
       
 60787         * ksvg2/svg/SVGStylable.h:
       
 60788         * ksvg2/svg/SVGStyleElement.h:
       
 60789         * ksvg2/svg/SVGStyledElement.h:
       
 60790         * ksvg2/svg/SVGStyledLocatableElement.h:
       
 60791         * ksvg2/svg/SVGStyledTransformableElement.h:
       
 60792         * ksvg2/svg/SVGSwitchElement.h:
       
 60793         * ksvg2/svg/SVGSymbolElement.h:
       
 60794         * ksvg2/svg/SVGTRefElement.h:
       
 60795         * ksvg2/svg/SVGTSpanElement.h:
       
 60796         * ksvg2/svg/SVGTests.h:
       
 60797         * ksvg2/svg/SVGTextContentElement.h:
       
 60798         * ksvg2/svg/SVGTextElement.h:
       
 60799         * ksvg2/svg/SVGTextPositioningElement.h:
       
 60800         * ksvg2/svg/SVGTitleElement.h:
       
 60801         * ksvg2/svg/SVGTransform.h:
       
 60802         * ksvg2/svg/SVGTransformList.h:
       
 60803         * ksvg2/svg/SVGTransformable.h:
       
 60804         * ksvg2/svg/SVGURIReference.h:
       
 60805         * ksvg2/svg/SVGUnitTypes.h:
       
 60806         * ksvg2/svg/SVGUseElement.h:
       
 60807         * ksvg2/svg/SVGViewElement.h:
       
 60808         * ksvg2/svg/SVGZoomAndPan.h:
       
 60809         * loader/CachedCSSStyleSheet.h:
       
 60810         * loader/CachedImage.h:
       
 60811         * loader/CachedXSLStyleSheet.h:
       
 60812         * loader/DocumentLoader.h:
       
 60813         * loader/Request.h:
       
 60814         * loader/SubresourceLoader.h:
       
 60815         * loader/icon/IconDataCache.h:
       
 60816         * loader/icon/IconDatabase.h:
       
 60817         * loader/icon/IconLoader.h:
       
 60818         * loader/icon/SQLDatabase.h:
       
 60819         * loader/icon/SQLStatement.h:
       
 60820         * loader/icon/SQLTransaction.h:
       
 60821         * page/Frame.h:
       
 60822         * page/FrameLoadRequest.h:
       
 60823         * page/FrameTree.h:
       
 60824         * page/FrameView.h:
       
 60825         * page/PageState.h:
       
 60826         * page/Plugin.h:
       
 60827         * page/qt/FrameQt.h:
       
 60828         * page/qt/FrameQtClient.h:
       
 60829         * platform/Arena.h:
       
 60830         * platform/ArrayImpl.h:
       
 60831         * platform/Cursor.h:
       
 60832         * platform/DeprecatedArray.h:
       
 60833         * platform/DeprecatedCString.h:
       
 60834         * platform/FileChooser.h:
       
 60835         * platform/Font.h:
       
 60836         * platform/FontCache.h:
       
 60837         * platform/FontData.h:
       
 60838         * platform/FontDescription.h:
       
 60839         * platform/FontFamily.h:
       
 60840         * platform/GlyphBuffer.h:
       
 60841         * platform/GlyphMap.h:
       
 60842         * platform/GlyphWidthMap.h:
       
 60843         * platform/Logging.h:
       
 60844         * platform/Pasteboard.h:
       
 60845         * platform/PlatformString.h:
       
 60846         * platform/PlugInInfoStore.h:
       
 60847         * platform/PopupMenu.h:
       
 60848         * platform/PopupMenuClient.h:
       
 60849         * platform/ScrollBar.h:
       
 60850         * platform/ScrollView.h:
       
 60851         * platform/SearchPopupMenu.h:
       
 60852         * platform/Shared.h:
       
 60853         * platform/Sound.h:
       
 60854         * platform/SystemTime.h:
       
 60855         * platform/Timer.h:
       
 60856         * platform/Widget.h:
       
 60857         * platform/cf/RetainPtr.h:
       
 60858         * platform/gdk/ChromeClientGdk.h:
       
 60859         * platform/gdk/FontPlatformData.h:
       
 60860         * platform/gdk/FrameGdk.h:
       
 60861         * platform/gdk/KeyboardCodes.h:
       
 60862         * platform/gdk/RenderPopupMenuGdk.h:
       
 60863         * platform/gdk/RenderThemeGdk.h:
       
 60864         * platform/graphics/BitmapImage.h:
       
 60865         * platform/graphics/Color.h:
       
 60866         * platform/graphics/FloatPoint.h:
       
 60867         * platform/graphics/FloatPoint3D.h:
       
 60868         * platform/graphics/FloatRect.h:
       
 60869         * platform/graphics/Icon.h:
       
 60870         * platform/graphics/Image.h:
       
 60871         * platform/graphics/ImageAnimationObserver.h:
       
 60872         * platform/graphics/ImageBuffer.h:
       
 60873         * platform/graphics/ImageSource.h:
       
 60874         * platform/graphics/IntPoint.h:
       
 60875         * platform/graphics/IntRect.h:
       
 60876         * platform/graphics/IntSize.h:
       
 60877         * platform/graphics/IntSizeHash.h:
       
 60878         * platform/graphics/PathTraversalState.h:
       
 60879         * platform/graphics/Pen.h:
       
 60880         * platform/graphics/qt/ImageDecoderQt.h:
       
 60881         * platform/graphics/svg/SVGImage.h:
       
 60882         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 60883         * platform/graphics/svg/SVGPaintServer.h:
       
 60884         * platform/graphics/svg/SVGPaintServerGradient.h:
       
 60885         * platform/graphics/svg/SVGPaintServerLinearGradient.h:
       
 60886         * platform/graphics/svg/SVGPaintServerPattern.h:
       
 60887         * platform/graphics/svg/SVGPaintServerRadialGradient.h:
       
 60888         * platform/graphics/svg/SVGPaintServerSolid.h:
       
 60889         * platform/graphics/svg/SVGResource.h:
       
 60890         * platform/graphics/svg/SVGResourceClipper.h:
       
 60891         * platform/graphics/svg/SVGResourceFilter.h:
       
 60892         * platform/graphics/svg/SVGResourceMarker.h:
       
 60893         * platform/graphics/svg/SVGResourceMasker.h:
       
 60894         * platform/graphics/svg/cg/CgSupport.h:
       
 60895         * platform/graphics/svg/filters/SVGDistantLightSource.h:
       
 60896         * platform/graphics/svg/filters/SVGFEBlend.h:
       
 60897         * platform/graphics/svg/filters/SVGFEColorMatrix.h:
       
 60898         * platform/graphics/svg/filters/SVGFEComponentTransfer.h:
       
 60899         * platform/graphics/svg/filters/SVGFEComposite.h:
       
 60900         * platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
       
 60901         * platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
       
 60902         * platform/graphics/svg/filters/SVGFEDisplacementMap.h:
       
 60903         * platform/graphics/svg/filters/SVGFEFlood.h:
       
 60904         * platform/graphics/svg/filters/SVGFEGaussianBlur.h:
       
 60905         * platform/graphics/svg/filters/SVGFEImage.h:
       
 60906         * platform/graphics/svg/filters/SVGFEMerge.h:
       
 60907         * platform/graphics/svg/filters/SVGFEMorphology.h:
       
 60908         * platform/graphics/svg/filters/SVGFEOffset.h:
       
 60909         * platform/graphics/svg/filters/SVGFESpecularLighting.h:
       
 60910         * platform/graphics/svg/filters/SVGFETile.h:
       
 60911         * platform/graphics/svg/filters/SVGFETurbulence.h:
       
 60912         * platform/graphics/svg/filters/SVGFilterEffect.h:
       
 60913         * platform/graphics/svg/filters/SVGLightSource.h:
       
 60914         * platform/graphics/svg/filters/SVGPointLightSource.h:
       
 60915         * platform/graphics/svg/filters/SVGSpotLightSource.h:
       
 60916         * platform/mac/FontPlatformData.h:
       
 60917         * platform/mac/PlatformScrollBar.h:
       
 60918         * platform/network/AuthenticationChallenge.h:
       
 60919         * platform/network/Credential.h:
       
 60920         * platform/network/HTTPHeaderMap.h:
       
 60921         * platform/network/ProtectionSpace.h:
       
 60922         * platform/network/ResourceError.h:
       
 60923         * platform/network/ResourceRequest.h:
       
 60924         * platform/network/ResourceResponse.h:
       
 60925         * platform/network/cf/FormDataStreamCFNet.h:
       
 60926         * platform/network/cf/ResourceRequestCFNet.h:
       
 60927         * platform/network/cf/ResourceResponseCFNet.h:
       
 60928         * platform/network/gdk/ResourceHandleManager.h:
       
 60929         * platform/network/mac/AuthenticationMac.h:
       
 60930         * platform/network/mac/FormDataStreamMac.h:
       
 60931         * platform/network/qt/ResourceHandleManagerKDE.h:
       
 60932         * platform/network/qt/ResourceHandleManagerQt.h:
       
 60933         * platform/network/win/ResourceHandleWin.h:
       
 60934         * platform/qt/FontPlatformData.h:
       
 60935         * platform/qt/KeyboardCodes.h:
       
 60936         * platform/qt/PlatformScrollBar.h:
       
 60937         * platform/qt/ScrollViewCanvasQt.h:
       
 60938         * platform/qt/SharedTimerQt.h:
       
 60939         * platform/win/FontPlatformData.h:
       
 60940         * platform/win/PlatformScrollBar.h:
       
 60941         * rendering/AutoTableLayout.h:
       
 60942         * rendering/HitTestRequest.h:
       
 60943         * rendering/HitTestResult.h:
       
 60944         * rendering/InlineBox.h:
       
 60945         * rendering/InlineFlowBox.h:
       
 60946         * rendering/Length.h:
       
 60947         * rendering/ListMarkerBox.h:
       
 60948         * rendering/RenderBox.h:
       
 60949         * rendering/RenderMenuList.h:
       
 60950         * rendering/RenderPart.h:
       
 60951         * rendering/RenderPartObject.h:
       
 60952         * rendering/RenderPath.h:
       
 60953         * rendering/RenderReplaced.h:
       
 60954         * rendering/RenderSVGContainer.h:
       
 60955         * rendering/RenderSVGImage.h:
       
 60956         * rendering/RenderSVGInline.h:
       
 60957         * rendering/RenderSVGInlineText.h:
       
 60958         * rendering/RenderSVGTSpan.h:
       
 60959         * rendering/RenderSVGText.h:
       
 60960         * rendering/RenderStyle.h:
       
 60961         * rendering/RenderTableCol.h:
       
 60962         * rendering/RenderThemeWin.h:
       
 60963         * rendering/bidi.h:
       
 60964         * xml/DOMParser.h:
       
 60965         * xml/XPathEvaluator.h:
       
 60966         * xml/XPathExpression.h:
       
 60967         * xml/XPathExpressionNode.h:
       
 60968         * xml/XPathFunctions.h:
       
 60969         * xml/XPathNSResolver.h:
       
 60970         * xml/XPathNamespace.h:
       
 60971         * xml/XPathParser.h:
       
 60972         * xml/XPathPath.h:
       
 60973         * xml/XPathPredicate.h:
       
 60974         * xml/XPathResult.h:
       
 60975         * xml/XPathStep.h:
       
 60976         * xml/XPathUtil.h:
       
 60977         * xml/XPathValue.h:
       
 60978         * xml/XPathVariableReference.h:
       
 60979         * xml/XSLImportRule.h:
       
 60980         * xml/XSLStyleSheet.h:
       
 60981         * xml/XSLTProcessor.h:
       
 60982         * xml/xmlhttprequest.h:
       
 60983 
       
 60984 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
       
 60985 
       
 60986         Build fix.
       
 60987         
       
 60988         * loader/ProgressTracker.cpp:
       
 60989 
       
 60990 2007-01-15  Lars Knoll <lars@trolltech.com>
       
 60991 
       
 60992         Fix the Qt build
       
 60993 
       
 60994         * WebCore.pro:
       
 60995 
       
 60996 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
       
 60997 
       
 60998         Reviewed by Darin.
       
 60999 
       
 61000         * loader/ProgressTracker.cpp:
       
 61001         Set finalProgressValue to its value explicitly instead of calculating it 
       
 61002         (which causes a global initializer to be generated).
       
 61003 
       
 61004 2007-01-15  Anders Carlsson  <acarlsson@apple.com>
       
 61005 
       
 61006         Reviewed by Darin and Adam.
       
 61007 
       
 61008         Move progress tracking down to WebCore.
       
 61009         
       
 61010         * WebCore.exp:
       
 61011         Add ProgressTracker::estimatedProgress() to be used by WebKit.
       
 61012         
       
 61013         * WebCore.xcodeproj/project.pbxproj:
       
 61014         Add ProgressTracker.[cpp|h]
       
 61015         
       
 61016         * loader/FrameLoader.cpp:
       
 61017         (WebCore::FrameLoader::prepareForLoadStart):
       
 61018         (WebCore::FrameLoader::clearProvisionalLoad):
       
 61019         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
       
 61020         (WebCore::FrameLoader::startLoading):
       
 61021         (WebCore::FrameLoader::didReceiveResponse):
       
 61022         (WebCore::FrameLoader::didReceiveData):
       
 61023         (WebCore::FrameLoader::didFailToLoad):
       
 61024         (WebCore::FrameLoader::requestFromDelegate):
       
 61025         (WebCore::FrameLoader::didFinishLoad):
       
 61026         Call directly to the progress tracker instead of through the frame loader client.
       
 61027         
       
 61028         * loader/FrameLoaderClient.h:
       
 61029         Get rid of the old methods and add new methods for tracking progress.
       
 61030         
       
 61031         * loader/ProgressTracker.cpp: Added.
       
 61032         (WebCore::ProgressItem::ProgressItem):
       
 61033         (WebCore::ProgressTracker::ProgressTracker):
       
 61034         (WebCore::ProgressTracker::~ProgressTracker):
       
 61035         (WebCore::ProgressTracker::estimatedProgress):
       
 61036         (WebCore::ProgressTracker::reset):
       
 61037         (WebCore::ProgressTracker::progressStarted):
       
 61038         (WebCore::ProgressTracker::progressCompleted):
       
 61039         (WebCore::ProgressTracker::finalProgressComplete):
       
 61040         (WebCore::ProgressTracker::incrementProgress):
       
 61041         (WebCore::ProgressTracker::completeProgress):
       
 61042         (WebCore::ProgressTracker::createUniqueIdentifier):
       
 61043         * loader/ProgressTracker.h: Added.
       
 61044         New per page class which tracks progress.
       
 61045         
       
 61046         * loader/ResourceLoader.cpp:
       
 61047         (WebCore::ResourceLoader::willSendRequest):
       
 61048         * page/Page.cpp:
       
 61049         (WebCore::Page::Page):
       
 61050         * page/Page.h:
       
 61051         (WebCore::Page::progress):
       
 61052         Move createUniqueIdentifier to ProgressTracker, add ProgressTracker object to Page.
       
 61053         
       
 61054         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 61055         (WebCore::SVGEmptyFrameLoaderClient::willChangeEstimatedProgress):
       
 61056         (WebCore::SVGEmptyFrameLoaderClient::didChangeEstimatedProgress):
       
 61057         (WebCore::SVGEmptyFrameLoaderClient::postProgressStartedNotification):
       
 61058         (WebCore::SVGEmptyFrameLoaderClient::postProgressEstimateChangedNotification):
       
 61059         (WebCore::SVGEmptyFrameLoaderClient::postProgressFinishedNotification):
       
 61060         Add new methods, get rid of the old ones.
       
 61061 
       
 61062 2007-01-15  Adam Roben  <aroben@apple.com>
       
 61063 
       
 61064         Reviewed by Anders.
       
 61065 
       
 61066         Fix comment.
       
 61067 
       
 61068         * html/HTMLScriptElement.cpp:
       
 61069         (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):
       
 61070 
       
 61071 2007-01-15  John Sullivan  <sullivan@apple.com>
       
 61072 
       
 61073         * platform/ContextMenu.cpp:
       
 61074         (WebCore::ContextMenu::checkOrEnableIfNeeded):
       
 61075         Leopard build fix; don't declare one of the case values twice
       
 61076 
       
 61077 2007-01-15  Mitz Pettel  <mitz@webkit.org>
       
 61078 
       
 61079         Reviewed by Darin.
       
 61080 
       
 61081         - fix http://bugs.webkit.org/show_bug.cgi?id=8604
       
 61082           rowspan does not work when set through javascript
       
 61083 
       
 61084         Covered by existing tests.
       
 61085 
       
 61086         * rendering/RenderTableCell.cpp:
       
 61087         (WebCore::RenderTableCell::updateFromElement): Mark the section for grid recalc
       
 61088         if row span or column span change.
       
 61089 
       
 61090 2007-01-15  Adam Roben  <aroben@apple.com>
       
 61091 
       
 61092         Reviewed by Darin.
       
 61093 
       
 61094         Small context menu fixes.
       
 61095 
       
 61096         * platform/ContextMenu.cpp:
       
 61097         (WebCore::ContextMenu::populate): Fix typo.
       
 61098         (WebCore::ContextMenu::checkOrEnableIfNeeded): Disabled "No Guesses
       
 61099         Found", and added all enum values explicitly.
       
 61100 
       
 61101 2007-01-15  Alexey Proskuryakov  <ap@webkit.org>
       
 61102 
       
 61103         Reviewed by Darin.
       
 61104 
       
 61105         http://bugs.webkit.org/show_bug.cgi?id=6272
       
 61106         XMLHttpRequest freezes on getting a missing document with overridden Content-Length
       
 61107 
       
 61108         http://bugs.webkit.org/show_bug.cgi?id=6212
       
 61109         Investigate disallowing some XMLHttpRequest headers from being set via setRequestHeader.
       
 61110 
       
 61111         Tests:
       
 61112         - http/tests/xmlhttprequest/connection-error-sync.html
       
 61113         - http/tests/xmlhttprequest/set-dangerous-headers.html
       
 61114 
       
 61115         * bindings/js/kjs_binding.cpp:
       
 61116         (KJS::):
       
 61117         (KJS::setDOMException): Added support for NETWORK_ERR. Changed the temporary 
       
 61118         PERMISSION_DENIED error into a special case.
       
 61119 
       
 61120         * loader/FrameLoader.cpp:
       
 61121         (WebCore::FrameLoader::loadResourceSynchronously):
       
 61122         * loader/FrameLoader.h:
       
 61123         Return the error object to the caller. Removed an extra local variable for error, 
       
 61124         which shadowed the one from enclosing block.
       
 61125 
       
 61126         * dom/XMLTokenizer.cpp:
       
 61127         (WebCore::openFunc): 
       
 61128         * xml/XSLTProcessor.cpp:
       
 61129         (WebCore::docLoaderFunc): 
       
 61130         Updated to pass an error object (currently ignored).
       
 61131 
       
 61132         * xml/xmlhttprequest.cpp:
       
 61133         (WebCore::canSetRequestHeader): Added. The headers to block include the ones from 
       
 61134         the current XMLHttpRequest draft plus "Via", which is blocked by Firefox.
       
 61135         (WebCore::XMLHttpRequest::send): Raise an exception if a sync request results in 
       
 61136         an error.
       
 61137         (WebCore::XMLHttpRequest::setRequestHeader): Call canSetRequestHeader().
       
 61138         * xml/xmlhttprequest.h:
       
 61139         (WebCore::): Added NETWORK_ERR and a comment about PERMISSION_DENIED.
       
 61140 
       
 61141 2007-01-15  Zack Rusin  <zack@kde.org>
       
 61142 
       
 61143         Optimizing rendering on the Qt platform. Mainly
       
 61144         switching from client side QImage to QPixmap's.
       
 61145         Also cleaning the the ScrollViewCanvasQt code
       
 61146         quite a bit.
       
 61147 
       
 61148         * platform/graphics/ImageSource.h: use QPixmap
       
 61149         * platform/graphics/qt/GraphicsContextQt.cpp:
       
 61150         (WebCore::TransparencyLayer::TransparencyLayer):
       
 61151         (WebCore::GraphicsContext::clip): clip rects when you can
       
 61152         * platform/graphics/qt/ImageDecoderQt.cpp:
       
 61153         (WebCore::ImageDecoderQt::ImageData::ImageData):
       
 61154         (WebCore::ImageDecoderQt::ReadContext::read):
       
 61155         (WebCore::ImageDecoderQt::ReadContext::readImageLines):
       
 61156         (WebCore::ImageDecoderQt::imageAtIndex):
       
 61157         * platform/graphics/qt/ImageDecoderQt.h: use QPixmap
       
 61158         * platform/graphics/qt/ImageQt.cpp: QPixmap instead of QImage
       
 61159         (WebCore::BitmapImage::draw):
       
 61160         (WebCore::BitmapImage::drawTiled):
       
 61161         * platform/graphics/qt/ImageSourceQt.cpp:
       
 61162         (WebCore::):
       
 61163         (WebCore::ImageSource::createFrameAtIndex):
       
 61164         (WebCore::ImageSource::frameHasAlphaAtIndex):
       
 61165         * platform/qt/ScrollViewCanvasQt.cpp: clean up
       
 61166         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
       
 61167         (WebCore::ScrollViewCanvasQt::updateFrameView):
       
 61168         (WebCore::ScrollViewCanvasQt::paintEvent):
       
 61169         (WebCore::ScrollViewCanvasQt::mouseMoveEvent):
       
 61170         (WebCore::ScrollViewCanvasQt::mousePressEvent):
       
 61171         (WebCore::ScrollViewCanvasQt::mouseReleaseEvent):
       
 61172         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
       
 61173         * platform/qt/ScrollViewCanvasQt.h:
       
 61174         * platform/qt/ScrollViewQt.cpp: remove hacks
       
 61175         (WebCore::ScrollView::ScrollView):
       
 61176         (WebCore::ScrollView::setParentWidget):
       
 61177         (WebCore::ScrollView::updateContents):
       
 61178 
       
 61179 2007-01-15  Lars Knoll <lars@trolltech.com>
       
 61180 
       
 61181         Reviewed by Zack
       
 61182 
       
 61183         Fix weird crashes when running the layout tests. The
       
 61184         reason was that I used KURL (and thus DeprecatedString)
       
 61185         in a thread. Unfortunately that class is not threadsafe
       
 61186         at all.
       
 61187 
       
 61188         * platform/network/qt/ResourceHandleManagerQt.cpp:
       
 61189         (WebCore::RequestQt::RequestQt):
       
 61190         (WebCore::RequestQt::setURL):
       
 61191         (WebCore::ResourceHandleManager::add):
       
 61192         (WebCore::ResourceHandleManager::cancel):
       
 61193         (WebCore::ResourceHandleManager::receivedResponse):
       
 61194         (WebCore::FileLoader::request):
       
 61195         (WebCore::HostInfo::HostInfo):
       
 61196         (WebCore::NetworkLoader::request):
       
 61197         (WebCore::NetworkLoader::cancel):
       
 61198         * platform/network/qt/ResourceHandleManagerQt.h:
       
 61199         (WebCore::HostInfo::HostInfo):
       
 61200         (WebCore::HostInfo::isLocalFile):
       
 61201 
       
 61202 2007-01-15  Eric Seidel  <eric@webkit.org>
       
 61203 
       
 61204         Reviewed by rwlbuis.
       
 61205 
       
 61206         Make isValid check not malloc 3 SVGStringLists for every element.
       
 61207         
       
 61208         No test possible, performance fix only.
       
 61209 
       
 61210         * ksvg2/svg/SVGTests.cpp:
       
 61211         (WebCore::SVGTests::isValid):
       
 61212 
       
 61213 2007-01-15  Rob Buis  <buis@kde.org>
       
 61214 
       
 61215         Reviewed by Eric.
       
 61216 
       
 61217         Remove unused member var.
       
 61218 
       
 61219         * ksvg2/svg/SVGStyledElement.h:
       
 61220 
       
 61221 2007-01-15  Rob Buis  <buis@kde.org>
       
 61222 
       
 61223         Reviewed by Eric.
       
 61224 
       
 61225         http://bugs.webkit.org/show_bug.cgi?id=12069
       
 61226         Hit detection fails under some viewbox constraints
       
 61227 
       
 61228         Do not take viewBox into account when hit testing svg container.
       
 61229 
       
 61230         * rendering/RenderSVGContainer.cpp:
       
 61231         (WebCore::RenderSVGContainer::nodeAtPoint):
       
 61232 
       
 61233 2007-01-15  David Hyatt  <hyatt@apple.com>
       
 61234 
       
 61235         Fix  for 12275, negative margins confuse page breaks.
       
 61236 
       
 61237         Reviewed by Eric
       
 61238 
       
 61239         * rendering/RenderBlock.cpp:
       
 61240         (WebCore::RenderBlock::paintChildren):
       
 61241 
       
 61242 2007-01-15  Eric Seidel  <eric@webkit.org>
       
 61243 
       
 61244         Reviewed by mjs.
       
 61245         
       
 61246         SVG gradients do not notice stop additions
       
 61247         http://bugs.webkit.org/show_bug.cgi?id=12192
       
 61248 
       
 61249         Test: svg/custom/gradient-add-stops.svg
       
 61250 
       
 61251         * ksvg2/svg/SVGGradientElement.cpp:
       
 61252         (WebCore::SVGGradientElement::childrenChanged):
       
 61253         * ksvg2/svg/SVGGradientElement.h:
       
 61254 
       
 61255 2007-01-14  David Hyatt  <hyatt@apple.com>
       
 61256 
       
 61257         Fix for bug 10356, positioning doesn't work with <svg> elements in XHTML.  Change the requiresLayer
       
 61258         check to use the DOM, since the old check would fail if the parent block had no element.
       
 61259 
       
 61260         Reviewed by Eric
       
 61261 
       
 61262         Added svg/custom/relative-positioning.html (absolute/fixed too)
       
 61263 
       
 61264         * rendering/RenderSVGContainer.cpp:
       
 61265         (WebCore::RenderSVGContainer::requiresLayer):
       
 61266 
       
 61267 2007-01-14  Eric Seidel  <eric@webkit.org>
       
 61268 
       
 61269         Reviewed by hyatt.
       
 61270         
       
 61271         SVG does not correctly handle float: left
       
 61272         http://bugs.webkit.org/show_bug.cgi?id=12210
       
 61273 
       
 61274         Test: svg/custom/svg-float-border-padding.xml
       
 61275 
       
 61276         * rendering/RenderSVGContainer.cpp:
       
 61277         (WebCore::RenderSVGContainer::paint):
       
 61278 
       
 61279 2007-01-14  David Hyatt  <hyatt@apple.com>
       
 61280 
       
 61281         More work to fix 10145, regression where form elements don't break properly.  Make sure to really use
       
 61282         the parent of the replaced element's whitespace value everywhere.
       
 61283 
       
 61284         Reviewed by olliej
       
 61285 
       
 61286         fast/replaced/three-selects-break.html
       
 61287 
       
 61288         * rendering/bidi.cpp:
       
 61289         (WebCore::RenderBlock::findNextLineBreak):
       
 61290 
       
 61291 2007-01-14  Sam Weinig  <sam@webkit.org>
       
 61292 
       
 61293         Reviewed by Darin and then by Mitz.
       
 61294 
       
 61295         Patch for http://bugs.webkit.org/show_bug.cgi?id=12228
       
 61296         Cleanup assorted CSS classes
       
 61297 
       
 61298         * css/CSSBorderImageValue.cpp:
       
 61299         (WebCore::CSSBorderImageValue::CSSBorderImageValue):
       
 61300         (WebCore::CSSBorderImageValue::cssText):
       
 61301         * css/CSSBorderImageValue.h:
       
 61302         * css/CSSComputedStyleDeclaration.cpp:
       
 61303         (WebCore::valueForLength):
       
 61304         (WebCore::valueForBorderStyle):
       
 61305         (WebCore::valueForTextAlign):
       
 61306         (WebCore::valueForShadow):
       
 61307         (WebCore::getPositionOffsetValue):
       
 61308         (WebCore::CSSComputedStyleDeclaration::cssText):
       
 61309         (WebCore::primitiveValueFromLength):
       
 61310         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 61311         (WebCore::CSSComputedStyleDeclaration::getPropertyPriority):
       
 61312         (WebCore::CSSComputedStyleDeclaration::removeProperty):
       
 61313         (WebCore::CSSComputedStyleDeclaration::setProperty):
       
 61314         (WebCore::CSSComputedStyleDeclaration::length):
       
 61315         (WebCore::CSSComputedStyleDeclaration::item):
       
 61316         * css/CSSComputedStyleDeclaration.h:
       
 61317         * css/CSSCursorImageValue.cpp:
       
 61318         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
       
 61319         * css/CSSCursorImageValue.h:
       
 61320         * css/CSSGrammar.y:
       
 61321         * css/CSSImageValue.cpp:
       
 61322         * css/CSSImageValue.h:
       
 61323         * css/CSSInheritedValue.cpp:
       
 61324         * css/CSSInheritedValue.h:
       
 61325         * css/CSSInitialValue.cpp:
       
 61326         * css/CSSInitialValue.h:
       
 61327         * css/CSSMutableStyleDeclaration.cpp:
       
 61328         (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
       
 61329         (WebCore::CSSMutableStyleDeclaration::operator=):
       
 61330         (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
       
 61331         (WebCore::CSSMutableStyleDeclaration::get4Values):
       
 61332         (WebCore::CSSMutableStyleDeclaration::getShorthandValue):
       
 61333         (WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue):
       
 61334         (WebCore::CSSMutableStyleDeclaration::removeProperty):
       
 61335         (WebCore::CSSMutableStyleDeclaration::setChanged):
       
 61336         (WebCore::CSSMutableStyleDeclaration::getPropertyPriority):
       
 61337         (WebCore::CSSMutableStyleDeclaration::getPropertyShorthand):
       
 61338         (WebCore::CSSMutableStyleDeclaration::isPropertyImplicit):
       
 61339         (WebCore::CSSMutableStyleDeclaration::setProperty):
       
 61340         (WebCore::CSSMutableStyleDeclaration::setImageProperty):
       
 61341         (WebCore::CSSMutableStyleDeclaration::parseDeclaration):
       
 61342         (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
       
 61343         (WebCore::CSSMutableStyleDeclaration::setLengthProperty):
       
 61344         (WebCore::CSSMutableStyleDeclaration::cssText):
       
 61345         (WebCore::CSSMutableStyleDeclaration::merge):
       
 61346         (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
       
 61347         * css/CSSMutableStyleDeclaration.h:
       
 61348         (WebCore::CSSMutableStyleDeclaration::setProperty):
       
 61349         (WebCore::CSSMutableStyleDeclaration::removeProperty):
       
 61350         * css/CSSNamespace.h:
       
 61351         (WebCore::CSSNamespace::CSSNamespace):
       
 61352         * css/CSSPrimitiveValue.cpp:
       
 61353         (WebCore::isCSSTokenizerIdentifier):
       
 61354         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
       
 61355         (WebCore::CSSPrimitiveValue::cleanup):
       
 61356         (WebCore::CSSPrimitiveValue::computeLengthInt):
       
 61357         (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
       
 61358         (WebCore::CSSPrimitiveValue::computeLengthShort):
       
 61359         (WebCore::CSSPrimitiveValue::computeLengthFloat):
       
 61360         (WebCore::CSSPrimitiveValue::setFloatValue):
       
 61361         (WebCore::scaleFactorForConversion):
       
 61362         (WebCore::CSSPrimitiveValue::getFloatValue):
       
 61363         (WebCore::CSSPrimitiveValue::setStringValue):
       
 61364         (WebCore::CSSPrimitiveValue::getStringValue):
       
 61365         (WebCore::CSSPrimitiveValue::parseString):
       
 61366         (WebCore::CSSPrimitiveValue::getIdent):
       
 61367         (WebCore::CSSPrimitiveValue::cssText):
       
 61368         * css/CSSPrimitiveValue.h:
       
 61369         (WebCore::CSSPrimitiveValue::getCounterValue):
       
 61370         (WebCore::CSSPrimitiveValue::getRectValue):
       
 61371         (WebCore::CSSPrimitiveValue::getRGBColorValue):
       
 61372         (WebCore::CSSPrimitiveValue::getPairValue):
       
 61373         (WebCore::CSSPrimitiveValue::getDashboardRegionValue):
       
 61374         * css/CSSProperty.cpp:
       
 61375         (WebCore::operator==):
       
 61376         * css/CSSProperty.h:
       
 61377         (WebCore::CSSProperty::operator=):
       
 61378         * css/CSSQuirkPrimitiveValue.h:
       
 61379         (WebCore::CSSQuirkPrimitiveValue::CSSQuirkPrimitiveValue):
       
 61380         * css/CSSRuleList.cpp:
       
 61381         (WebCore::CSSRuleList::CSSRuleList):
       
 61382         (WebCore::CSSRuleList::deleteRule):
       
 61383         (WebCore::CSSRuleList::insertRule):
       
 61384         * css/CSSRuleList.h:
       
 61385         (WebCore::CSSRuleList::item):
       
 61386         * css/CSSSelector.cpp:
       
 61387         (WebCore::CSSSelector::print):
       
 61388         (WebCore::CSSSelector::specificity):
       
 61389         (WebCore::CSSSelector::extractPseudoType):
       
 61390         (WebCore::CSSSelector::operator==):
       
 61391         (WebCore::CSSSelector::selectorText):
       
 61392         * css/CSSSelector.h:
       
 61393         (WebCore::CSSSelector::CSSSelector):
       
 61394         (WebCore::CSSSelector::~CSSSelector):
       
 61395         (WebCore::CSSSelector::append):
       
 61396         (WebCore::CSSSelector::next):
       
 61397         (WebCore::CSSSelector::pseudoType):
       
 61398         (WebCore::CSSSelector::hasTag):
       
 61399         (WebCore::CSSSelector::hasAttribute):
       
 61400         * css/CSSStyleDeclaration.cpp:
       
 61401         (WebCore::propertyID):
       
 61402         (WebCore::CSSStyleDeclaration::getPropertyPriority):
       
 61403         (WebCore::CSSStyleDeclaration::getPropertyShorthand):
       
 61404         (WebCore::CSSStyleDeclaration::isPropertyImplicit):
       
 61405         (WebCore::CSSStyleDeclaration::setProperty):
       
 61406         (WebCore::CSSStyleDeclaration::isPropertyName):
       
 61407         (WebCore::CSSStyleDeclaration::parentRule):
       
 61408         (WebCore::CSSStyleDeclaration::diff):
       
 61409         (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
       
 61410         * css/CSSStyleDeclaration.h:
       
 61411         * css/Counter.h:
       
 61412         (WebCore::Counter::Counter):
       
 61413         (WebCore::Counter::listStyleNumber):
       
 61414         * css/csshelper.cpp:
       
 61415         (WebCore::parseURL):
       
 61416         * css/csshelper.h:
       
 61417         * css/cssparser.h:
       
 61418         (WebCore::domString):
       
 61419         (WebCore::atomicString):
       
 61420         (WebCore::CSSParser::operator|):
       
 61421         * css/cssstyleselector.cpp:
       
 61422         (WebCore::CSSStyleSelector::matchRulesForList):
       
 61423         (WebCore::CSSStyleSelector::checkSelector):
       
 61424         (WebCore::CSSStyleSelector::checkOneSelector):
       
 61425         (WebCore::CSSRuleSet::addRule):
       
 61426 
       
 61427 2007-01-14  Mitz Pettel  <mitz@webkit.org>
       
 61428 
       
 61429         Reviewed by Adam.
       
 61430 
       
 61431         - fix http://bugs.webkit.org/show_bug.cgi?id=12264
       
 61432           REGRESSION (r18843): Webkit crashes on 43Folders.com home page
       
 61433 
       
 61434         Test: fast/tokenizer/ignore-tags-in-iframe.html
       
 61435 
       
 61436         * html/HTMLParser.cpp:
       
 61437         (WebCore::HTMLParser::reset): Removed unused inSelect member variable.
       
 61438         (WebCore::HTMLParser::selectCreateErrorCheck): Ditto.
       
 61439         (WebCore::HTMLParser::processCloseTag): Ditto.
       
 61440         * html/HTMLParser.h: Ditto.
       
 61441         * html/HTMLTokenizer.cpp:
       
 61442         (WebCore::HTMLTokenizer::parseTag): Changed not to process <pre>, <listing>,
       
 61443         <script>, <style>, <title>, <textarea> and <xmp> if the parser is in skip mode
       
 61444         (waiting for a close tag of an element whose contents are not parsed,
       
 61445         such as iframe).
       
 61446         * html/HTMLTokenizer.h:
       
 61447         (WebCore::HTMLTokenizer::State::setInStyle): Removed unused bit.
       
 61448         (WebCore::HTMLTokenizer::State::): Ditto.
       
 61449 
       
 61450 2007-01-14  Alexey Proskuryakov  <ap@webkit.org>
       
 61451 
       
 61452         Reviewed by Darin.
       
 61453 
       
 61454         http://bugs.webkit.org/show_bug.cgi?id=12258
       
 61455         fast/tokenizer/002 test broken
       
 61456 
       
 61457         * loader/FrameLoader.h: Added a flush parameter to write().
       
 61458         * loader/FrameLoader.cpp:
       
 61459         (WebCore::FrameLoader::write): Ditto.
       
 61460         (WebCore::FrameLoader::endIfNotLoading): Instead of poorly duplicating the logic in write(),
       
 61461         call it directly.
       
 61462 
       
 61463 2007-01-14  Adam Roben  <aroben@apple.com>
       
 61464 
       
 61465         Reviewed by Maciej.
       
 61466 
       
 61467         Make sure our whitelisting of the type and language attributes of the
       
 61468         <script> element is enforced in all HTMLTokenizer/HTMLScriptElement
       
 61469         code paths.
       
 61470 
       
 61471         All layout tests pass.
       
 61472 
       
 61473         * html/HTMLScriptElement.cpp:
       
 61474         (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript): New method to
       
 61475         determine whether the script should be executed, given its type and
       
 61476         language attributes.
       
 61477         (WebCore::HTMLScriptElement::evaluateScript): Check type/language
       
 61478         before executing.
       
 61479         * html/HTMLScriptElement.h: Added new declarations.
       
 61480         * html/HTMLTokenizer.cpp:
       
 61481         (WebCore::HTMLTokenizer::begin): Made scriptSrc a String. 
       
 61482         (WebCore::HTMLTokenizer::scriptHandler): Check
       
 61483         shouldExecuteAsJavaScript before executing.
       
 61484         (WebCore::HTMLTokenizer::notifyFinished): Ditto.
       
 61485         (WebCore::HTMLTokenizer::parseTag): Moved type/language checking from
       
 61486         here to HTMLScriptElement::shouldExecuteAsJavaScript.
       
 61487         * html/HTMLTokenizer.h: Made scriptSrc a String, and removed the
       
 61488         javascript member.
       
 61489 
       
 61490 2007-01-14  David Hyatt  <hyatt@apple.com>
       
 61491 
       
 61492         Make sure floats are avoided if you have non-auto column property values.  Fixes the crazy layout
       
 61493         on http://weblogs.mozillazine.org/roc.
       
 61494 
       
 61495         Reviewed by mitz
       
 61496 
       
 61497         Added fast/multicol/float-avoidance.html
       
 61498 
       
 61499         * rendering/RenderBlock.cpp:
       
 61500         (WebCore::RenderBlock::avoidsFloats):
       
 61501 
       
 61502 2007-01-14  David Hyatt  <hyatt@apple.com>
       
 61503 
       
 61504         Fix for 10145, regression where line breaks are not being honored between adjacent replaced elements.
       
 61505         When checking for break opportunities where replaced elements are involved, we ignore their white-space
       
 61506         values and use their parents' instead.  The assumption/idea behind this change is that because the element
       
 61507         is replaced, its white-space value is irrelevant except as a means of applying style to its interior.
       
 61508 
       
 61509         The CSS spec does not cover this situation, so we're implementing this based off what other browsers seem to
       
 61510         do.
       
 61511 
       
 61512         Reviewed by aroben
       
 61513 
       
 61514         * css/CSSComputedStyleDeclaration.cpp:
       
 61515         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 61516         * css/CSSValueKeywords.in:
       
 61517         * css/cssparser.cpp:
       
 61518         (WebCore::CSSParser::parseValue):
       
 61519         * css/cssstyleselector.cpp:
       
 61520         (WebCore::CSSStyleSelector::applyProperty):
       
 61521         * page/EventHandler.cpp:
       
 61522         (WebCore::EventHandler::EventHandler):
       
 61523         (WebCore::EventHandler::clear):
       
 61524         (WebCore::EventHandler::handleWheelEvent):
       
 61525         * page/EventHandler.h:
       
 61526         * rendering/RenderBox.cpp:
       
 61527         (WebCore::RenderBox::calcHeight):
       
 61528         * rendering/RenderLayer.cpp:
       
 61529         (WebCore::Marquee::Marquee):
       
 61530         (WebCore::Marquee::start):
       
 61531         (WebCore::Marquee::updateMarqueePosition):
       
 61532         (WebCore::Marquee::updateMarqueeStyle):
       
 61533         (WebCore::Marquee::timerFired):
       
 61534         * rendering/RenderLayer.h:
       
 61535         * rendering/RenderPartObject.cpp:
       
 61536         (WebCore::RenderPartObject::viewCleared):
       
 61537         * rendering/RenderStyle.h:
       
 61538         (WebCore::):
       
 61539         * rendering/bidi.cpp:
       
 61540         (WebCore::RenderBlock::findNextLineBreak):
       
 61541 
       
 61542 2007-01-13  David Hyatt  <hyatt@apple.com>
       
 61543 
       
 61544         While optimizing form controls and fixing their clipping, I caused this text zoom regression.  The layout
       
 61545         of text is necessary because it needs to recalc minmaxwidth.  This is still a really unfortunate
       
 61546         bit of code... since a lot of properties don't apply to text (e.g., borders), we're marking text renderers
       
 61547         as dirty when we don't have to.
       
 61548 
       
 61549         Reviewed by mitz
       
 61550 
       
 61551         * rendering/RenderObject.cpp:
       
 61552         (WebCore::RenderObject::setStyle):
       
 61553 
       
 61554 2007-01-13  Lars Knoll <lars@trolltech.com>
       
 61555 
       
 61556         Reviewed by Alexey
       
 61557 
       
 61558         String::format() was relying on undefined behaviour, which
       
 61559         happened to work on lots of systems (Mac and 32bit Linux at least)
       
 61560         but broke badly on 64bit Linux.
       
 61561         
       
 61562         * platform/String.cpp:
       
 61563         (WebCore::String::format):
       
 61564 
       
 61565 2007-01-13  Martin Reddy  <reddy@pixar.com>
       
 61566 
       
 61567         Fix for bug 11924: WebCore would crash on any HTML content
       
 61568         with a non-empty <table> tag in it on a 64-bit machine. The
       
 61569         size_t (64bit) vs int (32bit) cast is now fixed in ensureRows,
       
 61570         and the clients of this function have been updated to check
       
 61571         for a false return code.
       
 61572 
       
 61573         Reviewed by Darin, landed by Lars
       
 61574 
       
 61575         * rendering/RenderTableSection.cpp:
       
 61576         (WebCore::RenderTableSection::addChild):
       
 61577         (WebCore::RenderTableSection::ensureRows):
       
 61578         (WebCore::RenderTableSection::recalcCells):
       
 61579 
       
 61580 2007-01-13  Alexey Proskuryakov  <ap@webkit.org>
       
 61581 
       
 61582         Reviewed by Darin.
       
 61583 
       
 61584         http://bugs.webkit.org/show_bug.cgi?id=12165
       
 61585         REGRESSION: text encoding problem at jn.sapo.pt
       
 61586 
       
 61587         Test: fast/encoding/script-in-head.html
       
 61588 
       
 61589         * loader/TextResourceDecoder.cpp:
       
 61590         (WebCore::TextResourceDecoder::checkForHeadCharset):
       
 61591         Ignore tags within <script> elements in head, just like we do for <title>.
       
 61592 
       
 61593 2007-01-13  Lars Knoll <lars@trolltech.com>
       
 61594 
       
 61595         Reviewed by Maciej
       
 61596 
       
 61597         Don't crash when constructing a GraphicsContext with a 0
       
 61598         PlatformGraphicsContext and don't do anything if painting
       
 61599         is disabled.
       
 61600 
       
 61601         * platform/graphics/qt/GraphicsContextQt.cpp:
       
 61602         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
       
 61603         (WebCore::GraphicsContext::origin):
       
 61604         (WebCore::GraphicsContext::setPlatformFont):
       
 61605         (WebCore::GraphicsContext::setPlatformStrokeColor):
       
 61606         (WebCore::GraphicsContext::setPlatformStrokeStyle):
       
 61607         (WebCore::GraphicsContext::setPlatformStrokeThickness):
       
 61608         (WebCore::GraphicsContext::setPlatformFillColor):
       
 61609 
       
 61610 2007-01-13  Eric Seidel  <eric@webkit.org>
       
 61611 
       
 61612         Reviewed by hyatt.
       
 61613 
       
 61614         RichDraw demo does not live-update in Safari
       
 61615         (SVG elements should ignore CSS position)
       
 61616         http://bugs.webkit.org/show_bug.cgi?id=10364
       
 61617 
       
 61618         * css/cssstyleselector.cpp:
       
 61619         (WebCore::CSSStyleSelector::adjustRenderStyle): ignore position for everything but <svg>
       
 61620         * ksvg2/svg/SVGStyledElement.cpp:
       
 61621         (WebCore::SVGStyledElement::rebuildRenderer): move path generation into layout()
       
 61622         * rendering/RenderContainer.cpp:
       
 61623         (WebCore::RenderContainer::layout): ASSERT kids marked as having completed layout
       
 61624         * rendering/RenderPath.cpp:
       
 61625         (WebCore::RenderPath::layout): move path generation into layout()
       
 61626         * rendering/RenderSVGContainer.cpp:
       
 61627         (WebCore::RenderSVGContainer::layout): ASSERT kids marked as having completed layout
       
 61628 
       
 61629 2007-01-12  David Hyatt  <hyatt@apple.com>
       
 61630 
       
 61631         Add support for column rules.
       
 61632 
       
 61633         Reviewed by bdash
       
 61634 
       
 61635         fast/multicol/column-rules.html
       
 61636 
       
 61637         * rendering/RenderBlock.cpp:
       
 61638         (WebCore::RenderBlock::paintColumns):
       
 61639         * rendering/RenderStyle.h:
       
 61640         (WebCore::RenderStyle::columnRuleIsTransparent):
       
 61641 
       
 61642 2007-01-12  David Hyatt  <hyatt@apple.com>
       
 61643 
       
 61644         Make multicolumn layout work with floats.
       
 61645 
       
 61646         Reviewed by andersca
       
 61647 
       
 61648         Added fast/multicol/float-multicol.html
       
 61649 
       
 61650         * rendering/RenderBlock.cpp:
       
 61651         (WebCore::RenderBlock::layoutBlock):
       
 61652         (WebCore::RenderBlock::paintColumns):
       
 61653         (WebCore::RenderBlock::paintObject):
       
 61654         * rendering/RenderBlock.h:
       
 61655 
       
 61656 2007-01-12  David Kilzer  <ddkilzer@kilzer.net>
       
 61657 
       
 61658         Reviewed by Maciej.
       
 61659 
       
 61660         - fix http://bugs.webkit.org/show_bug.cgi?id=12239
       
 61661           REGRESSION (r18816-r18818): Assertion failure in 
       
 61662           WebCore::Length::Length[in-charge](int, WebCore::LengthType, bool)
       
 61663 
       
 61664         Test: fast/css/line-height.html
       
 61665 
       
 61666         * rendering/RenderTextControl.cpp:
       
 61667         (WebCore::RenderTextControl::createInnerTextStyle): Use a float to create a percent Length.
       
 61668 
       
 61669 2007-01-12  Anders Carlsson  <acarlsson@apple.com>
       
 61670 
       
 61671         Reviewed by Darin.
       
 61672 
       
 61673         Use unsigned long for identifiers instead of Objective-C objects.
       
 61674         
       
 61675         * loader/FrameLoader.cpp:
       
 61676         (WebCore::FrameLoader::loadResourceSynchronously):
       
 61677         (WebCore::FrameLoader::startLoadingMainResource):
       
 61678         (WebCore::FrameLoader::startLoading):
       
 61679         (WebCore::FrameLoader::assignIdentifierToInitialRequest):
       
 61680         (WebCore::FrameLoader::opened):
       
 61681         (WebCore::FrameLoader::sendRemainingDelegateMessages):
       
 61682         (WebCore::FrameLoader::requestFromDelegate):
       
 61683         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
       
 61684         * loader/FrameLoader.h:
       
 61685         * loader/FrameLoaderClient.h:
       
 61686         * loader/ResourceLoader.cpp:
       
 61687         (WebCore::ResourceLoader::ResourceLoader):
       
 61688         (WebCore::ResourceLoader::willSendRequest):
       
 61689         * loader/ResourceLoader.h:
       
 61690         (WebCore::ResourceLoader::setIdentifier):
       
 61691         (WebCore::ResourceLoader::identifier):
       
 61692         * page/Page.cpp:
       
 61693         (WebCore::Page::Page):
       
 61694         (WebCore::Page::createUniqueIdentifier):
       
 61695         * page/Page.h:
       
 61696         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 61697         (WebCore::SVGEmptyFrameLoaderClient::assignIdentifierToInitialRequest):
       
 61698         (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest):
       
 61699         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
       
 61700         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
       
 61701         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse):
       
 61702         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveContentLength):
       
 61703         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoading):
       
 61704         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoading):
       
 61705         (WebCore::SVGEmptyFrameLoaderClient::incrementProgress):
       
 61706         (WebCore::SVGEmptyFrameLoaderClient::completeProgress):
       
 61707 
       
 61708 2007-01-12  Mitz Pettel  <mitz@webkit.org>
       
 61709 
       
 61710         Reviewed by Darin.
       
 61711 
       
 61712         - fix http://bugs.webkit.org/show_bug.cgi?id=12235
       
 61713           REGRESSION (r18815): Marquees do not scroll
       
 61714 
       
 61715         * css/cssstyleselector.cpp:
       
 61716         (WebCore::CSSStyleSelector::applyProperty): Apply the '-webkit-marquee' value
       
 61717         of 'overflow-x' and 'overflow-y'.
       
 61718 
       
 61719 2007-01-12  Justin Garcia  <justin.garcia@apple.com>
       
 61720 
       
 61721         Reviewed by hyatt
       
 61722         
       
 61723         <rdar://problem/4875425>
       
 61724         EBay, GMail, and GoogleDocs RTEs font size popups don't work
       
 61725 
       
 61726         Changed execCommand("FontSize", ...) to match the spec 
       
 61727         and the behavior of other browsers.  It expects a number, 
       
 61728         n, which, the spec says can be 1 through 7.  Other browsers 
       
 61729         perform the font size change by creating a font element 
       
 61730         wrapper with size="n".  We convert n into one of the absolute 
       
 61731         size CSS keywords (x-small, medium, etc.).
       
 61732 
       
 61733         * editing/JSEditor.cpp: Call cssValueFromFontSizeNumber.  If
       
 61734         successful, perform the style change.
       
 61735         * html/HTMLFontElement.cpp:
       
 61736         (WebCore::HTMLFontElement::cssValueFromFontSizeNumber):  Added.
       
 61737         Moved this code from parsedMappedAttribute so that it could be
       
 61738         called from the Editor.
       
 61739         (WebCore::HTMLFontElement::parseMappedAttribute): Moved code into
       
 61740         cssValueFromFontSizeNumber.
       
 61741         * html/HTMLFontElement.h:
       
 61742 
       
 61743 2007-01-12  David Hyatt  <hyatt@apple.com>
       
 61744 
       
 61745         Fix for bug 11598, implement lightweight control clipping mechanism for
       
 61746         buttons, list boxes, and dropdown lists.  Make sure list box respects
       
 61747         scrollLeft/Top/Width/Height as well as clientWidth/Height.
       
 61748 
       
 61749         Fix bugs in RenderStyle::diff.  CursorData was not being compared properly.
       
 61750         vertical-align had a non-inline display check that was wrong (preventing
       
 61751         dynamic changes to keyword-based vertical-align from working).
       
 61752 
       
 61753         Reviewed by mitz
       
 61754 
       
 61755         * page/EventHandler.cpp:
       
 61756         (WebCore::EventHandler::selectClosestWordFromMouseEvent):
       
 61757         * rendering/RenderBlock.cpp:
       
 61758         (WebCore::RenderBlock::layout):
       
 61759         (WebCore::RenderBlock::layoutBlock):
       
 61760         (WebCore::RenderBlock::determineHorizontalPosition):
       
 61761         (WebCore::RenderBlock::layoutBlockChildren):
       
 61762         (WebCore::RenderBlock::paint):
       
 61763         (WebCore::RenderBlock::fillHorizontalSelectionGap):
       
 61764         (WebCore::RenderBlock::nodeAtPoint):
       
 61765         (WebCore::RenderBlock::layoutColumns):
       
 61766         * rendering/RenderBox.cpp:
       
 61767         (WebCore::RenderBox::computeAbsoluteRepaintRect):
       
 61768         * rendering/RenderBox.h:
       
 61769         * rendering/RenderButton.cpp:
       
 61770         (WebCore::RenderButton::setStyle):
       
 61771         (WebCore::RenderButton::controlClipRect):
       
 61772         * rendering/RenderButton.h:
       
 61773         (WebCore::RenderButton::hasControlClip):
       
 61774         * rendering/RenderFlexibleBox.cpp:
       
 61775         (WebCore::RenderFlexibleBox::layoutBlock):
       
 61776         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
       
 61777         (WebCore::RenderFlexibleBox::layoutVerticalBox):
       
 61778         * rendering/RenderFlow.cpp:
       
 61779         (WebCore::RenderFlow::addFocusRingRects):
       
 61780         * rendering/RenderListBox.cpp:
       
 61781         (WebCore::RenderListBox::itemBoundingBoxRect):
       
 61782         (WebCore::RenderListBox::paintObject):
       
 61783         (WebCore::RenderListBox::itemHeight):
       
 61784         (WebCore::RenderListBox::verticalScrollbarWidth):
       
 61785         (WebCore::RenderListBox::scrollWidth):
       
 61786         (WebCore::RenderListBox::scrollHeight):
       
 61787         (WebCore::RenderListBox::scrollLeft):
       
 61788         (WebCore::RenderListBox::setScrollLeft):
       
 61789         (WebCore::RenderListBox::scrollTop):
       
 61790         (WebCore::RenderListBox::setScrollTop):
       
 61791         (WebCore::RenderListBox::controlClipRect):
       
 61792         * rendering/RenderListBox.h:
       
 61793         (WebCore::RenderListBox::hasControlClip):
       
 61794         * rendering/RenderMenuList.cpp:
       
 61795         (WebCore::RenderMenuList::setStyle):
       
 61796         (WebCore::RenderMenuList::controlClipRect):
       
 61797         * rendering/RenderMenuList.h:
       
 61798         (WebCore::RenderMenuList::hasControlClip):
       
 61799         * rendering/RenderObject.cpp:
       
 61800         (WebCore::RenderObject::verticalScrollbarWidth):
       
 61801         (WebCore::RenderObject::horizontalScrollbarHeight):
       
 61802         (WebCore::RenderObject::clientWidth):
       
 61803         (WebCore::RenderObject::clientHeight):
       
 61804         (WebCore::RenderObject::setStyle):
       
 61805         * rendering/RenderObject.h:
       
 61806         (WebCore::RenderObject::hasControlClip):
       
 61807         (WebCore::RenderObject::controlClipRect):
       
 61808         (WebCore::RenderObject::contentWidth):
       
 61809         (WebCore::RenderObject::contentHeight):
       
 61810         * rendering/RenderStyle.cpp:
       
 61811         (WebCore::StyleVisualData::StyleVisualData):
       
 61812         (WebCore::cursorDataEqvuialent):
       
 61813         (WebCore::StyleInheritedData::operator==):
       
 61814         (WebCore::CursorList::operator==):
       
 61815         (WebCore::RenderStyle::diff):
       
 61816         * rendering/RenderStyle.h:
       
 61817         (WebCore::LengthBox::operator!=):
       
 61818         (WebCore::StyleVisualData::operator==):
       
 61819         (WebCore::CursorData::operator==):
       
 61820         (WebCore::CursorData::operator!=):
       
 61821         (WebCore::CursorList::operator!=):
       
 61822         (WebCore::RenderStyle::setTableLayout):
       
 61823         * rendering/bidi.cpp:
       
 61824         (WebCore::RenderBlock::layoutInlineChildren):
       
 61825 
       
 61826 2007-01-12  David Hyatt  <hyatt@apple.com>
       
 61827 
       
 61828         Fix for bug 9934, smaller line heights should not be allowed on
       
 61829         text fields.
       
 61830 
       
 61831         Reviewed by darin
       
 61832 
       
 61833         * rendering/RenderTextControl.cpp:
       
 61834         (WebCore::RenderTextControl::createInnerTextStyle):
       
 61835 
       
 61836 2007-01-12  Mitz Pettel  <mitz@webkit.org>
       
 61837 
       
 61838         Reviewed by Hyatt.
       
 61839 
       
 61840         - http://bugs.webkit.org/show_bug.cgi?id=12215
       
 61841           Treat 'overflow' and '-webkit-border-radius' as shorthands when parsing and
       
 61842           when removing.
       
 61843 
       
 61844         Test: fast/css/remove-shorthand.html (updated)
       
 61845 
       
 61846         * css/CSSMutableStyleDeclaration.cpp:
       
 61847         (WebCore::initShorthandMap):
       
 61848         * css/cssparser.cpp:
       
 61849         (WebCore::CSSParser::parseValue):
       
 61850 
       
 61851 2007-01-12  Rob Buis  <buis@kde.org>
       
 61852 
       
 61853         Reviewed by Mitz.
       
 61854 
       
 61855         Do not mix up JSSVGPolygonElement and JSSVGPolylineElement.
       
 61856 
       
 61857         * bindings/js/JSSVGElementWrapperFactory.cpp:
       
 61858 
       
 61859 2007-01-12  Kevin Decker <kdecker@apple.com>
       
 61860 
       
 61861         Reviewed by andersca.
       
 61862 
       
 61863         Fixed: <rdar://problem/4701326>21.2 ms launch time regression spent in +[WebPluginDatabase installedPlugins]
       
 61864 
       
 61865         * dom/DOMImplementation.cpp:
       
 61866         (WebCore::DOMImplementation::createDocument): Added a guard clause for text/html which used to be in WebKit before a lot of the 
       
 61867         loader plumbing was moved to WebCore.  Pinging the plug-in database to ask it if it supports a given mime type has the side 
       
 61868         effect of reading from disk on first call, therefore such a check should be a last resort.  
       
 61869 
       
 61870 2007-01-12  Mitz Pettel  <mitz@webkit.org>
       
 61871 
       
 61872         Reviewed by Darin.
       
 61873 
       
 61874         - fix http://bugs.webkit.org/show_bug.cgi?id=12223
       
 61875           REGRESSION: Leaks under CSSStyleSelector::applyProperty
       
 61876 
       
 61877         No test possible (no change to functionality).
       
 61878 
       
 61879         * rendering/RenderObject.h: Removed unused forward declaration.
       
 61880         * rendering/RenderStyle.cpp:
       
 61881         (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData):
       
 61882         Delete shadow data.
       
 61883 
       
 61884 2007-01-12  Anders Carlsson  <acarlsson@apple.com>
       
 61885 
       
 61886         Build fix.
       
 61887         
       
 61888         * WebCore.xcodeproj/project.pbxproj:
       
 61889         Remove SubresourceLoaderMac.mm.
       
 61890         
       
 61891 2007-01-12  Lars Knoll <lars@trolltech.com>
       
 61892 
       
 61893         Reviewed by Darin and Anders.
       
 61894 
       
 61895         Make some more of the loader code platform independent.
       
 61896 
       
 61897         * loader/FrameLoader.cpp:
       
 61898         (WebCore::FrameLoader::clear):
       
 61899         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
       
 61900         (WebCore::FrameLoader::urlSelected):
       
 61901         (WebCore::FrameLoader::createEmptyDocument):
       
 61902         (WebCore::FrameLoader::setTitle):
       
 61903         (WebCore::FrameLoader::originalRequestURL):
       
 61904         (WebCore::FrameLoader::referrer):
       
 61905         * loader/SubresourceLoader.cpp:
       
 61906         (WebCore::SubresourceLoader::SubresourceLoader):
       
 61907         (WebCore::SubresourceLoader::load):
       
 61908         (WebCore::SubresourceLoader::create):
       
 61909         (WebCore::SubresourceLoader::willSendRequest):
       
 61910         (WebCore::SubresourceLoader::didReceiveResponse):
       
 61911         (WebCore::SubresourceLoader::didReceiveData):
       
 61912         (WebCore::SubresourceLoader::didFinishLoading):
       
 61913         (WebCore::SubresourceLoader::didFail):
       
 61914         (WebCore::SubresourceLoader::didCancel):
       
 61915         (WebCore::SubresourceLoader::stopLoading):
       
 61916         * loader/SubresourceLoader.h:
       
 61917         * loader/mac/FrameLoaderMac.mm:
       
 61918         * loader/mac/SubresourceLoaderMac.mm: Removed.
       
 61919         * loader/qt/FrameLoaderQt.cpp:
       
 61920 
       
 61921 2007-01-12  Lars Knoll <lars@trolltech.com>
       
 61922 
       
 61923         Reviewed by Zack
       
 61924 
       
 61925         Valgrind reported uninitialized variable.
       
 61926 
       
 61927         * platform/network/qt/ResourceHandleManagerQt.cpp:
       
 61928         (WebCore::FileLoader::request):
       
 61929 
       
 61930 2007-01-12  Mitz Pettel  <mitz@webkit.org>
       
 61931 
       
 61932         Reviewed by rwlbuis.
       
 61933 
       
 61934         - add missing null check in new fixed table layout code
       
 61935 
       
 61936         * rendering/FixedTableLayout.cpp:
       
 61937         (WebCore::FixedTableLayout::calcWidthArray):
       
 61938 
       
 61939 2007-01-12  Lars Knoll <lars@trolltech.com>
       
 61940 
       
 61941         Fix the Qt build after the Authenitcation changes.
       
 61942 
       
 61943         * WebCore.pro:
       
 61944         * platform/network/ResourceHandleInternal.h:
       
 61945 
       
 61946 2007-01-12  David Hyatt  <hyatt@apple.com>
       
 61947 
       
 61948         Fix for bug 9569.  Make sure the selection offset for selection roots excludes border and padding.
       
 61949 
       
 61950         Reviewed by Eric
       
 61951 
       
 61952         * rendering/RenderBlock.cpp:
       
 61953         (WebCore::RenderBlock::leftSelectionOffset):
       
 61954         (WebCore::RenderBlock::rightSelectionOffset):
       
 61955 
       
 61956 2007-01-11  David Hyatt  <hyatt@apple.com>
       
 61957 
       
 61958         Fix for bug 8705, readonly text fields should not get focus rings.  Add a rule to that effect to
       
 61959         html4.css and then also add readonly as a special case for style sharing so that we can retain the
       
 61960         performance boost from sharing styles on inputs.
       
 61961 
       
 61962         Reviewed by bdash
       
 61963 
       
 61964         * css/cssstyleselector.cpp:
       
 61965         (WebCore::CSSStyleSelector::canShareStyleWithElement):
       
 61966         (WebCore::CSSStyleSelector::checkOneSelector):
       
 61967         * css/html4.css:
       
 61968 
       
 61969 2007-01-11  David Hyatt  <hyatt@apple.com>
       
 61970 
       
 61971         Fix for bug 11595.  Autoscrolling of layers didn't really work at all unless the layer was coincidentally
       
 61972         in the root layer's coordinate space.  The event point was an absolute position within the document, but
       
 61973         the layer's rect was only local coords.  This patch makes sure to use absolute bounds for the layer
       
 61974         when comparing it with the point.
       
 61975 
       
 61976         This is covered by the scrollRevealButton test case already in the tree... the results change to be more
       
 61977         correct.
       
 61978 
       
 61979         Reviewed by ggaren
       
 61980 
       
 61981         * rendering/RenderLayer.cpp:
       
 61982         (WebCore::RenderLayer::scrollRectToVisible):
       
 61983 
       
 61984 2007-01-11  Brady Eidson  <beidson@apple.com>
       
 61985 
       
 61986         Reviewed by Oliver
       
 61987 
       
 61988         -Move more HTTP Auth handling towards ResourceHandle, away from ResourceHandleClient
       
 61989         -Make more of ResourceLoader cross-platform
       
 61990 
       
 61991         * loader/ResourceLoader.cpp:
       
 61992         (WebCore::ResourceLoader::ResourceLoader):
       
 61993         (WebCore::ResourceLoader::releaseResources):
       
 61994         (WebCore::ResourceLoader::didCancel):
       
 61995         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
       
 61996         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
       
 61997         (WebCore::ResourceLoader::receivedCancellation):
       
 61998         * loader/ResourceLoader.h:
       
 61999         (WebCore::ResourceLoader::willStopBufferingData):
       
 62000         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
       
 62001         (WebCore::ResourceLoader::willCacheResponse):
       
 62002         * loader/mac/ResourceLoaderMac.mm:
       
 62003         * platform/network/ResourceHandle.h:
       
 62004         * platform/network/ResourceHandleClient.h:
       
 62005         (WebCore::ResourceHandleClient::willStopBufferingData):
       
 62006         * platform/network/ResourceHandleInternal.h:
       
 62007         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
       
 62008         * platform/network/mac/ResourceHandleMac.mm:
       
 62009         (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
       
 62010         (WebCore::ResourceHandle::didCancelAuthenticationChallenge):
       
 62011         (WebCore::ResourceHandle::receivedCredential):
       
 62012         (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
       
 62013         (WebCore::ResourceHandle::receivedCancellation):
       
 62014         (WebCore::ResourceHandle::clearAuthentication):
       
 62015         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
       
 62016         (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
       
 62017         (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]):
       
 62018         (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]):
       
 62019         (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
       
 62020 
       
 62021 2007-01-11  David Hyatt  <hyatt@apple.com>
       
 62022 
       
 62023         A hit test is returning a null renderer.  Make sure to null-check it in the autoscroll code.
       
 62024         This really shouldn't happen, but I'm just going to bullet proof for now given that it's happening
       
 62025         on the front page of yahoo.com!
       
 62026 
       
 62027         Reviewed by mark
       
 62028 
       
 62029         * rendering/RenderLayer.cpp:
       
 62030         (WebCore::RenderLayer::autoscroll):
       
 62031 
       
 62032 2007-01-11  David Hyatt  <hyatt@apple.com>
       
 62033 
       
 62034         Force column-width to parse in strict mode so that there is no confusion when it is used in the columns
       
 62035         shorthand (it can be mistaken for column-count otherwise).
       
 62036 
       
 62037         Reviewed by Mark
       
 62038 
       
 62039         fast/multicol/columns-shorthand-parsing.html
       
 62040 
       
 62041         * css/cssparser.cpp:
       
 62042         (WebCore::CSSParser::parseValue):
       
 62043 
       
 62044 2007-01-11  Mitz Pettel  <mitz@webkit.org>
       
 62045 
       
 62046         Reviewed by Hyatt.
       
 62047 
       
 62048         - fix http://bugs.webkit.org/show_bug.cgi?id=12124
       
 62049           RenderTable::section{Above,Below}() can return the wrong answer for the {footer,header}
       
 62050 
       
 62051         * rendering/RenderTable.cpp:
       
 62052         (WebCore::resetSectionPointerIfNotBefore): Added this function to help with
       
 62053         checking if a section being inserted is the going to be the first of its kind.
       
 62054         (WebCore::RenderTable::addChild): Changed to maintain the pointers to the
       
 62055         header, the footer, the caption and the first table body properly when objects
       
 62056         are inserted in the middle. Also changed to make the first caption win over
       
 62057         any other captions. This matches Firefox and what already used to happen when a
       
 62058         section recalc took place.
       
 62059         (WebCore::RenderTable::layout): Changed to use sectionBelow() for iterating
       
 62060         over the sections from top to bottom.
       
 62061         (WebCore::RenderTable::calcBorderLeft): Changed to really find the section
       
 62062         containing the first row.
       
 62063         (WebCore::RenderTable::calcBorderRight): Ditto.
       
 62064         (WebCore::RenderTable::sectionAbove): Fixed a bug when the last section was
       
 62065         skipped if the input was the footer.
       
 62066         (WebCore::RenderTable::sectionBelow): Ditto for "first" and "header"
       
 62067         respectively.
       
 62068 
       
 62069 2007-01-11  Mitz Pettel  <mitz@webkit.org>
       
 62070 
       
 62071         Reviewed by Hyatt.
       
 62072 
       
 62073         - fix http://bugs.webkit.org/show_bug.cgi?id=12115
       
 62074           RTL text is jumbled on display
       
 62075 
       
 62076         Fixed fixed table layout. Implemented an algorithm that matches the behavior
       
 62077         of Firefox, up to rounding errors.
       
 62078 
       
 62079         Fixes three existing table tests.
       
 62080 
       
 62081         * rendering/FixedTableLayout.cpp:
       
 62082         Undid accidental search-and-replace of "width" to "m_width" in the comments.
       
 62083         Removed an outdated comment, since WebKit no longer honors table-layout:fixed
       
 62084         for variable-width tables.
       
 62085         (WebCore::FixedTableLayout::calcWidthArray): Fixed the logic that finds the
       
 62086         first row. Changed to divide the width specified for a cell that spans multiple
       
 62087         columns between the columns rather than assign its entire width to each column.
       
 62088         (WebCore::FixedTableLayout::calcMinMaxWidth):
       
 62089         (WebCore::FixedTableLayout::layout): Implemented the behavior observed in
       
 62090         Firefox.
       
 62091         * rendering/FixedTableLayout.h:
       
 62092 
       
 62093 2007-01-11  Mitz Pettel  <mitz@webkit.org>
       
 62094 
       
 62095         Reviewed by Hyatt.
       
 62096 
       
 62097         - fix http://bugs.webkit.org/show_bug.cgi?id=8438
       
 62098           iExploder(#460): Assertion failure in RenderObject::drawBorder()
       
 62099 
       
 62100         Test: fast/block/basic/fieldset-stretch-to-legend.html
       
 62101 
       
 62102         * rendering/RenderBox.cpp:
       
 62103         (WebCore::RenderBox::calcWidth): Stretch to the minimum intrinsic
       
 62104         width if the object requires it.
       
 62105         (WebCore::RenderBox::calcHorizontalMargins): Some style cleanup.
       
 62106         (WebCore::RenderBox::calcAbsoluteHorizontal): Stretch to the minimum
       
 62107         intrinsic width if the object requires it.
       
 62108         * rendering/RenderBox.h:
       
 62109         (WebCore::RenderBox::stretchesToMinIntrinsicWidth): Added. Returns false.
       
 62110         * rendering/RenderFieldset.cpp:
       
 62111         (WebCore::RenderFieldset::calcMinMaxWidth): Overloaded RenderBlock's
       
 62112         implementation to ensure that the legend's will fit in the fieldset's
       
 62113         minimum intrinsic width.
       
 62114         (WebCore::RenderFieldset::findLegend): Made const.
       
 62115         (WebCore::RenderFieldset::paintBoxDecorations):
       
 62116         (WebCore::RenderFieldset::paintBorderMinusLegend): Fixed the behavior when
       
 62117         the legend does overflow the fieldset. This is the part of the fix that
       
 62118         prevents the assertion failure. If the legend intersects with a corner of
       
 62119         the fieldset's border, that corner will not be painted, even if it is not
       
 62120         completely occluded. This edge case can be improved with clipping in the
       
 62121         future. Added FIXME to implement border-radius.
       
 62122         * rendering/RenderFieldset.h:
       
 62123         (WebCore::RenderFieldset::stretchesToMinIntrinsicWidth): Overloaded to
       
 62124         return true.
       
 62125 
       
 62126 2007-01-11  Brady Eidson  <beidson@apple.com>
       
 62127 
       
 62128         Reviewed by Build Fix Karma
       
 62129 
       
 62130         I broke the release build (debug build passed)
       
 62131 
       
 62132         * platform/network/mac/AuthenticationMac.mm:
       
 62133         (WebCore::core):
       
 62134 
       
 62135 2007-01-11  Brady Eidson  <beidson@apple.com>
       
 62136 
       
 62137         Reviewed by Anders
       
 62138 
       
 62139         Rewrites HTTP Authentication setting up a more platform-independent structure
       
 62140 
       
 62141         * WebCore.exp:
       
 62142         * WebCore.xcodeproj/project.pbxproj:
       
 62143         * loader/FrameLoader.cpp:
       
 62144         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
       
 62145         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
       
 62146         * loader/FrameLoader.h:
       
 62147         * loader/FrameLoaderClient.h:
       
 62148         * loader/ResourceLoader.cpp:
       
 62149         (WebCore::ResourceLoader::ResourceLoader):
       
 62150         (WebCore::ResourceLoader::didCancel):
       
 62151         * loader/ResourceLoader.h:
       
 62152         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
       
 62153         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
       
 62154         (WebCore::ResourceLoader::receivedCredential):
       
 62155         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
       
 62156         (WebCore::ResourceLoader::receivedCancellation):
       
 62157         * loader/mac/FrameLoaderMac.mm:
       
 62158         * loader/mac/ResourceLoaderMac.mm:
       
 62159         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
       
 62160         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
       
 62161         (WebCore::ResourceLoader::receivedCredential):
       
 62162         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
       
 62163         (WebCore::ResourceLoader::receivedCancellation):
       
 62164         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 62165         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
       
 62166         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
       
 62167         * platform/network/ResourceHandleClient.h:
       
 62168         (WebCore::ResourceHandleClient::willSendRequest):
       
 62169         (WebCore::ResourceHandleClient::didReceiveAuthenticationChallenge):
       
 62170         (WebCore::ResourceHandleClient::didCancelAuthenticationChallenge):
       
 62171         (WebCore::ResourceHandleClient::receivedCredential):
       
 62172         (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential):
       
 62173         (WebCore::ResourceHandleClient::receivedCancellation):
       
 62174         (WebCore::ResourceHandleClient::willCacheResponse):
       
 62175         * platform/network/ResourceResponse.h:
       
 62176         (WebCore::operator!=):
       
 62177         * platform/network/URLAuthenticationChallenge.cpp: Added.
       
 62178         (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge):
       
 62179         (WebCore::URLAuthenticationChallenge::previousFailureCount):
       
 62180         (WebCore::URLAuthenticationChallenge::proposedCredential):
       
 62181         (WebCore::URLAuthenticationChallenge::protectionSpace):
       
 62182         (WebCore::URLAuthenticationChallenge::failureResponse):
       
 62183         (WebCore::URLAuthenticationChallenge::error):
       
 62184         (WebCore::URLAuthenticationChallenge::isNull):
       
 62185         (WebCore::URLAuthenticationChallenge::nullify):
       
 62186         (WebCore::operator==):
       
 62187         (WebCore::operator!=):
       
 62188         * platform/network/URLAuthenticationChallenge.h: Added.
       
 62189         (WebCore::URLAuthenticationChallenge::sender):
       
 62190         (WebCore::URLAuthenticationChallenge::nsURLAuthenticationChallenge):
       
 62191         * platform/network/URLCredential.cpp: Added.
       
 62192         (WebCore::URLCredential::URLCredential):
       
 62193         (WebCore::URLCredential::user):
       
 62194         (WebCore::URLCredential::password):
       
 62195         (WebCore::URLCredential::hasPassword):
       
 62196         (WebCore::URLCredential::persistence):
       
 62197         (WebCore::operator==):
       
 62198         * platform/network/URLCredential.h: Added.
       
 62199         (WebCore::):
       
 62200         (WebCore::operator!=):
       
 62201         * platform/network/URLProtectionSpace.cpp: Added.
       
 62202         (WebCore::URLProtectionSpace::URLProtectionSpace):
       
 62203         (WebCore::URLProtectionSpace::host):
       
 62204         (WebCore::URLProtectionSpace::port):
       
 62205         (WebCore::URLProtectionSpace::serverType):
       
 62206         (WebCore::URLProtectionSpace::realm):
       
 62207         (WebCore::URLProtectionSpace::authenticationScheme):
       
 62208         (WebCore::operator==):
       
 62209         * platform/network/URLProtectionSpace.h: Added.
       
 62210         (WebCore::):
       
 62211         (WebCore::operator!=):
       
 62212         * platform/network/mac/AuthenticationMac.h: Added.
       
 62213         * platform/network/mac/AuthenticationMac.mm: Added.
       
 62214         (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge):
       
 62215         (WebCore::mac):
       
 62216         (WebCore::core):
       
 62217         * platform/network/mac/ResourceHandleMac.mm:
       
 62218         (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
       
 62219         (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
       
 62220         (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]):
       
 62221         (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]):
       
 62222         (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
       
 62223         * platform/network/mac/ResourceResponseMac.mm:
       
 62224         (WebCore::operator==):
       
 62225 
       
 62226 2007-01-11  Geoffrey Garen  <ggaren@apple.com>
       
 62227 
       
 62228         Reviewed by Anders Carlsson.
       
 62229         
       
 62230         Even more cleanup in preparation for fixing <rdar://problem/4608404> 
       
 62231         WebScriptObject's _executionContext lack of ownership policy causes 
       
 62232         crashes (e.g., in Dashcode)
       
 62233         
       
 62234         Layout tests pass.
       
 62235         
       
 62236         Renames:
       
 62237             findRootObjectForNativeHandleFunction => createRootObject
       
 62238             FindRootObjectForNativeHandleFunctionPtr => createRootObjectFunction
       
 62239             rootForView => createRootObject
       
 62240             getInstanceForView => getPluginInstanceForWidget
       
 62241 
       
 62242         * page/mac/FrameMac.mm:
       
 62243         (WebCore::FrameMac::getAppletInstanceForWidget): Put the NSView * in a void*
       
 62244         variable named "nativeHandle" to be more explicit about the fact that JavaScript's
       
 62245         "nativeHandle" is just an NSView *.
       
 62246 
       
 62247         (WebCore::getPluginInstanceForWidget): This function now does the NSView *
       
 62248         fetching that its callers used to do.
       
 62249         (WebCore::FrameMac::getEmbedInstanceForWidget): Updated for rename.
       
 62250         (WebCore::FrameMac::getObjectInstanceForWidget): ditto
       
 62251 
       
 62252         * page/mac/WebCoreFrameBridge.mm: Killed the WebCoreBridgeInternal category,
       
 62253         which was really more of a shmategory.
       
 62254         (createRootObject): Removed rootObjectForView, folding it into its only
       
 62255         caller, the similarly named rootForView. Renamed the pair to "createRootObject"
       
 62256         because that's what they do.
       
 62257 
       
 62258         (-[WebCoreFrameBridge init]): Updated for renames
       
 62259 
       
 62260 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
       
 62261 
       
 62262         Reviewed by Darin.
       
 62263 
       
 62264         Fix crash on platforms that don't use the new loader yet.
       
 62265         
       
 62266         * loader/DocLoader.cpp:
       
 62267         (WebCore::DocLoader::requestResource):
       
 62268 
       
 62269 2007-01-11  Mitz Pettel  <mitz@webkit.org>
       
 62270 
       
 62271         Reviewed by Adam.
       
 62272 
       
 62273         - fix http://bugs.webkit.org/show_bug.cgi?id=11449
       
 62274           Type-to-select in unopened popups doesn't work with Hebrew
       
 62275 
       
 62276         Test: fast/forms/select-type-ahead-non-latin.html
       
 62277 
       
 62278         * html/HTMLSelectElement.cpp:
       
 62279         (WebCore::HTMLSelectElement::defaultEventHandler): Changed locale-specific
       
 62280         isprint() condition to a Unicode isPrintableChar().
       
 62281 
       
 62282 2007-01-09  Justin Garcia  <justin.garcia@apple.com>
       
 62283 
       
 62284         Reviewed by geoff
       
 62285         
       
 62286         <rdar://problem/4889140>
       
 62287         GMail Editor: List creation fails in new message
       
 62288 
       
 62289         * editing/InsertListCommand.cpp:
       
 62290         (WebCore::InsertListCommand::doApply): Inserting the list
       
 62291         into an empty paragraph not held open by a br or a '\n', 
       
 62292         will invalidate start and end.  Insert a placeholder and 
       
 62293         then recompute start and end.
       
 62294 
       
 62295 2007-01-11  Lars Knoll <lars@trolltech.com>
       
 62296 
       
 62297         Rubberstamped by Anders
       
 62298 
       
 62299         This one is not needed any longer neither.
       
 62300 
       
 62301         * ChangeLog:
       
 62302         * WebCore.pro:
       
 62303         * loader/qt/NavigationActionQt.cpp: Removed.
       
 62304 
       
 62305 2007-01-11  Lars Knoll <lars@trolltech.com>
       
 62306 
       
 62307         Reviewed by Anders
       
 62308 
       
 62309         Remove now unused file
       
 62310 
       
 62311         * WebCore.pro:
       
 62312         * loader/qt/LoaderFunctionsQt.cpp: Removed.
       
 62313 
       
 62314 2007-01-11  David Kilzer  <ddkilzer@webkit.org>
       
 62315 
       
 62316         Reviewed by NOBODY (build fix).
       
 62317 
       
 62318         * loader/mac/FrameLoaderMac.mm:  Removed import of LoaderNSURLRequestExtras.h.
       
 62319         * loader/mac/SubresourceLoaderMac.mm:  Ditto.
       
 62320 
       
 62321 2007-01-11  George Staikos  <staikos@kde.org>
       
 62322 
       
 62323         Fix compile.
       
 62324 
       
 62325         * page/qt/FrameQtClient.cpp:
       
 62326 
       
 62327 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
       
 62328 
       
 62329         Fix build.
       
 62330         
       
 62331         * dom/XMLTokenizer.cpp:
       
 62332         * loader/CachedCSSStyleSheet.cpp:
       
 62333         * loader/CachedImage.cpp:
       
 62334         * loader/DocLoader.cpp:
       
 62335         * loader/loader.cpp:
       
 62336         * xml/XSLTProcessor.cpp:
       
 62337         * xml/xmlhttprequest.cpp:
       
 62338 
       
 62339 2007-01-11  Anders Carlsson  <acarlsson@apple.com>
       
 62340 
       
 62341         Reviewed by Adam.
       
 62342 
       
 62343         Loader cleanup, get rid of unused code.
       
 62344         
       
 62345         * WebCore.xcodeproj/project.pbxproj:
       
 62346         * loader/CachedResource.h:
       
 62347         * loader/DocLoader.cpp:
       
 62348         (WebCore::DocLoader::requestResource):
       
 62349         (WebCore::DocLoader::checkCacheObjectStatus):
       
 62350         * loader/DocLoader.h:
       
 62351         * loader/LoaderFunctions.h: Removed.
       
 62352         * loader/mac/CachedResourceMac.mm: Removed.
       
 62353         * loader/mac/LoaderFunctionsMac.mm: Removed.
       
 62354         * loader/mac/LoaderNSURLRequestExtras.h: Removed.
       
 62355         * loader/mac/LoaderNSURLRequestExtras.m: Removed.
       
 62356         * loader/mac/SubresourceLoaderMac.mm:
       
 62357         * page/mac/WebCoreFrameBridge.mm:
       
 62358         * platform/network/ResourceHandle.cpp:
       
 62359 
       
 62360 2007-01-11  Beth Dakin  <bdakin@apple.com>
       
 62361 
       
 62362         Reviewed by Adam.
       
 62363 
       
 62364         Fix for http://bugs.webkit.org/show_bug.cgi?id=12135 REGRESSION: 
       
 62365         <input> and <textarea> not focused on right click (4908884 in 
       
 62366         Radar)
       
 62367 
       
 62368         * page/EventHandler.cpp:
       
 62369         (WebCore::EventHandler::sendContextMenuEvent): Since WebcCore now 
       
 62370         handles the context menu event, we want to ask if we *have* 
       
 62371         swallowed the event instead of if we *haven't* when deciding to 
       
 62372         perform a selection. In the past, WebKit handled the event, so 
       
 62373         swallowEvent was false in the case where we want to pop up a menu. 
       
 62374 
       
 62375 2007-01-11  Darin Adler  <darin@apple.com>
       
 62376 
       
 62377         Reviewed by Anders.
       
 62378 
       
 62379         - fix http://bugs.webkit.org/show_bug.cgi?id=12189
       
 62380           REGRESSION(r18614-18640): Crash in WebCore::SharedBuffer::hasPlatformData()
       
 62381 
       
 62382         * loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus):
       
 62383         Added null check.
       
 62384 
       
 62385 2007-01-11  Darin Adler  <darin@apple.com>
       
 62386 
       
 62387         * platform/CharacterNames.h: Oops! horizontalEllipsis != zeroWidthSpace!
       
 62388 
       
 62389 2007-01-11  Lars Knoll <lars@trolltech.com>
       
 62390 
       
 62391         Reviewed by Darin.
       
 62392 
       
 62393         Start using the loader in the Qt port.
       
 62394 
       
 62395         * loader/FrameLoader.cpp:
       
 62396         (WebCore::FrameLoader::clear):
       
 62397         (WebCore::FrameLoader::URL):
       
 62398         (WebCore::FrameLoader::createEmptyDocument):
       
 62399         * loader/qt/FrameLoaderQt.cpp:
       
 62400         (WebCore::FrameLoader::setTitle):
       
 62401         (WebCore::FrameLoader::originalRequestURL):
       
 62402         (WebCore::FrameLoader::referrer):
       
 62403         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
       
 62404         * page/qt/FrameQtClient.cpp:
       
 62405         (WebCore::FrameQtClient::openURL):
       
 62406 
       
 62407 2007-01-11  Darin Adler  <darin@apple.com>
       
 62408 
       
 62409         Reviewed by Hyatt.
       
 62410 
       
 62411         - removed a couple Mac bridging classes; put the code in WebKit instead
       
 62412 
       
 62413         * WebCore.exp: Updated for new WebKit uses.
       
 62414 
       
 62415         * WebCore.xcodeproj/project.pbxproj: Removed files.
       
 62416         * bridge/mac/WebCoreEncodings.h: Removed.
       
 62417         * bridge/mac/WebCoreEncodings.mm: Removed.
       
 62418         * bridge/mac/WebMimeTypeRegistryBridge.h: Removed.
       
 62419         * bridge/mac/WebMimeTypeRegistryBridge.mm: Removed.
       
 62420         * platform/mac/WebNSAttributedStringExtras.h: Removed.
       
 62421         * platform/mac/WebNSAttributedStringExtras.mm: Removed.
       
 62422 
       
 62423         * platform/mac/PasteboardMac.mm:
       
 62424         (WebCore::stripAttachmentCharacters): Added. Moved code from
       
 62425         WebNSAttributedStringExtras.mm, and fixed a garbage collection problem
       
 62426         (a global with a plain old retain rather than HardRetain).
       
 62427         (WebCore::Pasteboard::writeSelection): Updated to use stripAttachmentCharacters.
       
 62428 
       
 62429         - removed some DeprecatedCString use
       
 62430 
       
 62431         * loader/FrameLoader.cpp: Changed to use String more to eliminate use of
       
 62432         DeprecatedCString here in the mailto form support. But maybe we can remove
       
 62433         this entirely. Do we really care about mailto forms any more?
       
 62434 
       
 62435         * platform/Pasteboard.h: Removed unneeded DeprecatedCString declaration.
       
 62436 
       
 62437         * platform/PlatformString.h: Added replace that takes two strings.
       
 62438         * platform/StringImpl.h: Ditto.
       
 62439         * platform/StringImpl.cpp: (WebCore::StringImpl::replace): Ditto.
       
 62440 
       
 62441         * platform/TextStream.h: Remove DeprecatedCString case.
       
 62442         * platform/TextStream.cpp: Ditto.
       
 62443 
       
 62444         - made a few more files use CharacterNames.h
       
 62445 
       
 62446         * platform/CharacterNames.h: Added some more character names and
       
 62447         sorted alphabetically.
       
 62448 
       
 62449         * bridge/mac/WebCoreStringTruncator.mm:
       
 62450         (centerTruncateToBuffer): Use character name from CharacterNames.h.
       
 62451         (rightTruncateToBuffer): Ditto.
       
 62452         (truncateString): Ditto.
       
 62453         * platform/mac/FontMac.mm: (WebCore::addDirectionalOverride): Ditto.
       
 62454         * rendering/RenderFlexibleBox.cpp:
       
 62455         (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
       
 62456         * rendering/bidi.cpp:
       
 62457         (WebCore::RenderBlock::checkLinesForTextOverflow): Ditto.
       
 62458 
       
 62459 2007-01-11  David Hyatt  <hyatt@apple.com>
       
 62460 
       
 62461         Fix two bugs in positionForCoordinates.  (Make it work when you have a margin in between your border and
       
 62462         your first child block.)
       
 62463 
       
 62464         Rewrite column rebalancing to have two modes: constrained and unconstrained.  In unconstrained mode,
       
 62465         the system will dynamically rebalance as it loses space to breaks and compute a final intrinsic height
       
 62466         for the overall block.  In constrained mode, columns flow into the fixed height block, and extra columns
       
 62467         spill out horizontally in the appropriate direction (RTL/LTR).
       
 62468 
       
 62469         Make columns work properly with both LTR and RTL overflow blocks.
       
 62470 
       
 62471         Initial column test suite coming soon now that the basic layout is right.
       
 62472 
       
 62473         Reviewed by darin
       
 62474 
       
 62475         * rendering/RenderBlock.cpp:
       
 62476         (WebCore:::RenderFlow):
       
 62477         (WebCore::RenderBlock::layoutBlock):
       
 62478         (WebCore::RenderBlock::paintColumns):
       
 62479         (WebCore::RenderBlock::lowestPosition):
       
 62480         (WebCore::RenderBlock::rightmostPosition):
       
 62481         (WebCore::RenderBlock::leftmostPosition):
       
 62482         (WebCore::RenderBlock::hitTestColumns):
       
 62483         (WebCore::RenderBlock::positionForCoordinates):
       
 62484         (WebCore::RenderBlock::availableWidth):
       
 62485         (WebCore::RenderBlock::calcColumnWidth):
       
 62486         (WebCore::RenderBlock::layoutColumns):
       
 62487         (WebCore::RenderBlock::adjustPointToColumnContents):
       
 62488         * rendering/RenderBlock.h:
       
 62489         (WebCore::RenderBlock::hasColumns):
       
 62490 
       
 62491 2007-01-10  Rob Buis  <buis@kde.org>
       
 62492 
       
 62493         Reviewed by Eric.
       
 62494 
       
 62495         http://bugs.webkit.org/show_bug.cgi?id=12201
       
 62496         Fix image dragging issues with http://www.carto.net/papers/svg/gui/scrollbar/index.svg
       
 62497 
       
 62498         Fix calculation of absolute transform so that viewport x,y
       
 62499         translation is always done, also when viewBox is set.     
       
 62500 
       
 62501         * rendering/RenderSVGContainer.cpp:
       
 62502         (WebCore::RenderSVGContainer::paint):
       
 62503         (WebCore::RenderSVGContainer::viewportTransform):
       
 62504         (WebCore::RenderSVGContainer::absoluteTransform):
       
 62505 
       
 62506 2007-01-10  David Hyatt  <hyatt@apple.com>
       
 62507 
       
 62508         Rework positionForCoordinates to be more efficient and to handle multi-column content.  This entailed
       
 62509         adding a new field to HitTestResult called localPoint that cached the mouse coordinate in the coordinate
       
 62510         space of the renderer.
       
 62511 
       
 62512         positionForCoordinates now takes local coordinates and so no longer needs to waste time recomputing
       
 62513         absolute positions over and over again.
       
 62514 
       
 62515         Reviewed by darin
       
 62516 
       
 62517         * bridge/mac/WebCoreAXObject.mm:
       
 62518         (-[WebCoreAXObject value]):
       
 62519         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
       
 62520         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
       
 62521         * dom/Document.cpp:
       
 62522         (WebCore::Document::prepareMouseEvent):
       
 62523         * editing/SelectionController.cpp:
       
 62524         (WebCore::SelectionController::contains):
       
 62525         * editing/visible_units.cpp:
       
 62526         (WebCore::previousLinePosition):
       
 62527         (WebCore::nextLinePosition):
       
 62528         * page/EventHandler.cpp:
       
 62529         (WebCore::EventHandler::selectClosestWordFromMouseEvent):
       
 62530         (WebCore::EventHandler::handleMousePressEventDoubleClick):
       
 62531         (WebCore::EventHandler::handleMousePressEventTripleClick):
       
 62532         (WebCore::EventHandler::handleMousePressEventSingleClick):
       
 62533         (WebCore::EventHandler::handleMouseMoveEvent):
       
 62534         (WebCore::EventHandler::handleMouseReleaseEvent):
       
 62535         (WebCore::EventHandler::sendContextMenuEvent):
       
 62536         * page/EventHandler.h:
       
 62537         * page/MouseEventWithHitTestResults.cpp:
       
 62538         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
       
 62539         * page/MouseEventWithHitTestResults.h:
       
 62540         (WebCore::MouseEventWithHitTestResults::localPoint):
       
 62541         * page/mac/WebCoreFrameBridge.mm:
       
 62542         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
       
 62543         * rendering/EllipsisBox.cpp:
       
 62544         (WebCore::EllipsisBox::nodeAtPoint):
       
 62545         * rendering/HitTestResult.h:
       
 62546         (WebCore::HitTestResult::localPoint):
       
 62547         (WebCore::HitTestResult::setLocalPoint):
       
 62548         * rendering/InlineFlowBox.cpp:
       
 62549         (WebCore::InlineFlowBox::nodeAtPoint):
       
 62550         * rendering/InlineTextBox.cpp:
       
 62551         (WebCore::InlineTextBox::nodeAtPoint):
       
 62552         * rendering/RenderBlock.cpp:
       
 62553         (WebCore::RenderBlock::nodeAtPoint):
       
 62554         (WebCore::RenderBlock::hitTestContents):
       
 62555         (WebCore::RenderBlock::positionForCoordinates):
       
 62556         * rendering/RenderBox.cpp:
       
 62557         (WebCore::RenderBox::nodeAtPoint):
       
 62558         * rendering/RenderContainer.cpp:
       
 62559         (WebCore::RenderContainer::positionForCoordinates):
       
 62560         * rendering/RenderFlow.cpp:
       
 62561         (WebCore::RenderFlow::hitTestLines):
       
 62562         * rendering/RenderInline.cpp:
       
 62563         (WebCore::RenderInline::positionForCoordinates):
       
 62564         * rendering/RenderLayer.cpp:
       
 62565         (WebCore::RenderLayer::autoscroll):
       
 62566         (WebCore::RenderLayer::hitTestLayer):
       
 62567         * rendering/RenderObject.cpp:
       
 62568         (WebCore::RenderObject::updateHitTestResult):
       
 62569         * rendering/RenderObject.h:
       
 62570         * rendering/RenderPath.cpp:
       
 62571         (WebCore::RenderPath::nodeAtPoint):
       
 62572         * rendering/RenderReplaced.cpp:
       
 62573         (WebCore::RenderReplaced::positionForCoordinates):
       
 62574         * rendering/RenderTableRow.cpp:
       
 62575         (WebCore::RenderTableRow::nodeAtPoint):
       
 62576         * rendering/RenderTableSection.cpp:
       
 62577         (WebCore::RenderTableSection::nodeAtPoint):
       
 62578         * rendering/RenderText.cpp:
       
 62579         (WebCore::RenderText::positionForCoordinates):
       
 62580         * rendering/RootInlineBox.cpp:
       
 62581         (WebCore::RootInlineBox::nodeAtPoint):
       
 62582         (WebCore::RootInlineBox::closestLeafChildForXPos):
       
 62583         * rendering/RootInlineBox.h:
       
 62584 
       
 62585 2007-01-11  George Staikos  <staikos@kde.org>
       
 62586 
       
 62587         Reviewed by Maciej.
       
 62588 
       
 62589         Fix Qt Build.
       
 62590 
       
 62591         * loader/qt/DocumentLoaderQt.cpp:
       
 62592         (WebCore::DocumentLoader::getResponseModifiedHeader):
       
 62593 
       
 62594 2007-01-10  Kirby White  <KWhiteRight@gmail.com>
       
 62595 
       
 62596         Reviewed by Darin.
       
 62597 
       
 62598         Fixes for http://bugs.webkit.org/show_bug.cgi?id=11841
       
 62599 
       
 62600         Set image size to fit alt text when image or input-image element
       
 62601         has no src attribute, so that those images show their alt text instead
       
 62602         of showing nothing at all.
       
 62603 
       
 62604         * html/HTMLImageElement.cpp:
       
 62605         (WebCore::HTMLImageElement::attach):
       
 62606         * html/HTMLInputElement.cpp:
       
 62607         (WebCore::HTMLInputElement::attach):
       
 62608         * rendering/RenderImage.cpp:
       
 62609         (WebCore::RenderImage::setImageSizeForAltText):
       
 62610         (WebCore::RenderImage::imageChanged):
       
 62611         * rendering/RenderImage.h:
       
 62612 
       
 62613 2007-01-11  Mark Rowe  <mrowe@apple.com>
       
 62614 
       
 62615         Build fix.
       
 62616 
       
 62617         * rendering/RenderView.cpp:
       
 62618         (WebCore::RenderView::printing):
       
 62619 
       
 62620 2007-01-10  Mitz Pettel  <mitz@webkit.org>
       
 62621 
       
 62622         Reviewed by Darin.
       
 62623 
       
 62624         - fix http://bugs.webkit.org/show_bug.cgi?id=9284
       
 62625           Quirksmode (CSS1): Removing inline border styles is impossible
       
 62626 
       
 62627         Test: fast/css/remove-shorthand.html
       
 62628 
       
 62629         * css/CSSMutableStyleDeclaration.cpp:
       
 62630         (WebCore::PropertyLonghand::PropertyLonghand): Added this structure
       
 62631         containing a pointer to an array if properties and the array's length.
       
 62632         (WebCore::PropertyLonghand::properties):
       
 62633         (WebCore::PropertyLonghand::length):
       
 62634         (WebCore::initShorthandMap): Initialize the mapping from shorthand
       
 62635         properties to their dependent properties.
       
 62636         (WebCore::CSSMutableStyleDeclaration::removeProperty): Changed to check
       
 62637         if the property being removed is a shorthand, and if so, to remove all
       
 62638         of its dependent properties.
       
 62639         (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet): Added a
       
 62640         'notifyChanged' boolean parameter which controls whether this method
       
 62641         calls setChanged() if it actually removes any property.
       
 62642         * css/CSSMutableStyleDeclaration.h:
       
 62643 
       
 62644 2007-01-10  Steve Falkenburg  <sfalken@apple.com>
       
 62645 
       
 62646         Reviewed by Kevin.
       
 62647 
       
 62648         Removed unnecessary printing state
       
 62649 
       
 62650         * page/FrameView.cpp:
       
 62651         (WebCore::FrameView::layout):
       
 62652         * page/mac/WebCoreFrameBridge.mm:
       
 62653         (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]):
       
 62654         (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
       
 62655         (-[WebCoreFrameBridge drawRect:]):
       
 62656         (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
       
 62657         (-[WebCoreFrameBridge adjustPageHeightNew:top:bottom:limit:]):
       
 62658         * rendering/RenderLayer.cpp:
       
 62659         (WebCore::RenderLayer::updateLayerPositions):
       
 62660         * rendering/RenderObject.cpp:
       
 62661         (WebCore::RenderObject::repaint):
       
 62662         (WebCore::RenderObject::repaintRectangle):
       
 62663         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
       
 62664         * rendering/RenderView.cpp:
       
 62665         (WebCore::RenderView::RenderView):
       
 62666         (WebCore::RenderView::calcHeight):
       
 62667         (WebCore::RenderView::calcWidth):
       
 62668         (WebCore::RenderView::layout):
       
 62669         (WebCore::RenderView::paint):
       
 62670         (WebCore::RenderView::repaintViewRectangle):
       
 62671         (WebCore::RenderView::computeAbsoluteRepaintRect):
       
 62672         (WebCore::RenderView::printing):
       
 62673         (WebCore::RenderView::viewRect):
       
 62674         (WebCore::RenderView::docHeight):
       
 62675         (WebCore::RenderView::docWidth):
       
 62676         * rendering/RenderView.h:
       
 62677         * rendering/RenderWidget.cpp:
       
 62678         (WebCore::RenderWidget::updateWidgetPosition):
       
 62679         * rendering/bidi.cpp:
       
 62680         (WebCore::RenderBlock::layoutInlineChildren):
       
 62681 
       
 62682 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
       
 62683 
       
 62684         Reviewed by Maciej.
       
 62685 
       
 62686         Get the Refresh header directly from the ResourceResponse.
       
 62687         
       
 62688         * loader/DocumentLoader.h:
       
 62689         * loader/FrameLoader.cpp:
       
 62690         (WebCore::FrameLoader::commitProvisionalLoad):
       
 62691         * loader/mac/DocumentLoaderMac.mm:
       
 62692         (WebCore::DocumentLoader::getResponseModifiedHeader):
       
 62693 
       
 62694 2007-01-10  Beth Dakin  <bdakin@apple.com>
       
 62695 
       
 62696         Reviewed by John.
       
 62697 
       
 62698         Fix for <rdar://problem/4914258> REGRESSION: Search in Google now 
       
 62699         operates on the current WebView instead of invoking Safari's 
       
 62700         service
       
 62701 
       
 62702         * page/ContextMenuClient.h: New call to the client to search in 
       
 62703         google.
       
 62704         * page/ContextMenuController.cpp:
       
 62705         (WebCore::ContextMenuController::contextMenuItemSelected): Call 
       
 62706         into the client instead of forming a new url string and loading it.
       
 62707         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 62708         (WebCore::SVGEmptyContextMenuClient::searchWithGoogle): New call.
       
 62709 
       
 62710 2007-01-10  Adam Roben  <aroben@apple.com>
       
 62711 
       
 62712         Rubberstamped by Darin.
       
 62713 
       
 62714         * page/ContextMenuController.cpp:
       
 62715         (WebCore::ContextMenuController::contextMenuItemSelected): Pass 0
       
 62716         instead of an empty Event to FrameLoader::load and
       
 62717         FrameLoader::urlSelected.
       
 62718 
       
 62719 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
       
 62720 
       
 62721         * loader/ResourceLoader.cpp:
       
 62722         (WebCore::ResourceLoader::~ResourceLoader):
       
 62723         Disable assertion (I forgot to do this even though I added the comment!)
       
 62724 
       
 62725 2007-01-10  Ross Burton  <ross@burtonini.com>
       
 62726 
       
 62727         Reviewed and landed by Anders.
       
 62728 
       
 62729         Fix case in vcproj file (the GTK+ port uses the vcproj file).
       
 62730 
       
 62731         * WebCore.vcproj/WebCore/WebCore.vcproj:
       
 62732 
       
 62733 2007-01-10  Lars Knoll  <lars@trolltech.com>
       
 62734 
       
 62735         Make the Qt build compile again after 
       
 62736         the ResourceLoader was made platform
       
 62737         independent. 
       
 62738 
       
 62739         * WebCore.pro:
       
 62740         * loader/FrameLoader.cpp:
       
 62741         (WebCore::FrameLoader::didFirstLayout):
       
 62742         * loader/qt/FrameLoaderQt.cpp:
       
 62743         * loader/qt/MainResourceLoaderQt.cpp: Removed.
       
 62744         * loader/qt/ResourceLoaderQt.cpp: Removed.
       
 62745         * page/qt/FrameQtClient.cpp:
       
 62746         (WebCore::FrameQtClient::openURL):
       
 62747         * platform/network/qt/ResourceHandleQt.cpp:
       
 62748         (WebCore::ResourceHandle::setDefersLoading):
       
 62749 
       
 62750 2007-01-10  Anders Carlsson  <acarlsson@apple.com>
       
 62751 
       
 62752         Rubber-stamped by Maciej.
       
 62753         
       
 62754         Move most of ResourceLoader and MainResourceLoader into the platform-independent files.
       
 62755         
       
 62756         * WebCore.xcodeproj/project.pbxproj:
       
 62757         * loader/FrameLoader.cpp:
       
 62758         (WebCore::FrameLoader::didFinishLoad):
       
 62759         * loader/MainResourceLoader.cpp:
       
 62760         (WebCore::MainResourceLoader::MainResourceLoader):
       
 62761         (WebCore::MainResourceLoader::~MainResourceLoader):
       
 62762         (WebCore::MainResourceLoader::create):
       
 62763         (WebCore::MainResourceLoader::receivedError):
       
 62764         (WebCore::MainResourceLoader::didCancel):
       
 62765         (WebCore::MainResourceLoader::interruptionForPolicyChangeError):
       
 62766         (WebCore::MainResourceLoader::stopLoadingForPolicyChange):
       
 62767         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
       
 62768         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
       
 62769         (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
       
 62770         (WebCore::MainResourceLoader::addData):
       
 62771         (WebCore::MainResourceLoader::willSendRequest):
       
 62772         (WebCore::shouldLoadAsEmptyDocument):
       
 62773         (WebCore::MainResourceLoader::continueAfterContentPolicy):
       
 62774         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
       
 62775         (WebCore::MainResourceLoader::didReceiveResponse):
       
 62776         (WebCore::MainResourceLoader::didReceiveData):
       
 62777         (WebCore::MainResourceLoader::didFinishLoading):
       
 62778         (WebCore::MainResourceLoader::didFail):
       
 62779         (WebCore::MainResourceLoader::loadNow):
       
 62780         (WebCore::MainResourceLoader::load):
       
 62781         (WebCore::MainResourceLoader::setDefersLoading):
       
 62782         * loader/MainResourceLoader.h:
       
 62783         * loader/ResourceLoader.cpp:
       
 62784         (WebCore::ResourceLoader::ResourceLoader):
       
 62785         (WebCore::ResourceLoader::~ResourceLoader):
       
 62786         (WebCore::ResourceLoader::releaseResources):
       
 62787         (WebCore::ResourceLoader::load):
       
 62788         (WebCore::ResourceLoader::setDefersLoading):
       
 62789         (WebCore::ResourceLoader::frameLoader):
       
 62790         (WebCore::ResourceLoader::addData):
       
 62791         (WebCore::ResourceLoader::clearResourceData):
       
 62792         (WebCore::ResourceLoader::willSendRequest):
       
 62793         (WebCore::ResourceLoader::didReceiveResponse):
       
 62794         (WebCore::ResourceLoader::didReceiveData):
       
 62795         (WebCore::ResourceLoader::willStopBufferingData):
       
 62796         (WebCore::ResourceLoader::didFinishLoading):
       
 62797         (WebCore::ResourceLoader::didFinishLoadingOnePart):
       
 62798         (WebCore::ResourceLoader::didFail):
       
 62799         (WebCore::ResourceLoader::didCancel):
       
 62800         (WebCore::ResourceLoader::cancel):
       
 62801         (WebCore::ResourceLoader::response):
       
 62802         (WebCore::ResourceLoader::cancelledError):
       
 62803         * loader/ResourceLoader.h:
       
 62804         (WebCore::ResourceLoader::willStopBufferingData):
       
 62805         (WebCore::ResourceLoader::setRequest):
       
 62806         * loader/mac/FrameLoaderMac.mm:
       
 62807         * loader/mac/MainResourceLoaderMac.mm: Removed.
       
 62808         * loader/mac/ResourceLoaderMac.mm:
       
 62809 
       
 62810 2007-01-10  Lars Knoll <lars@trolltech.com>
       
 62811 
       
 62812         Move files to the correct location,
       
 62813         and remove a few unused methods from 
       
 62814         LoaderFunctionsQt.cpp
       
 62815 
       
 62816         * WebCore.pro:
       
 62817         * loader/qt/LoaderFunctionsQt.cpp: Added.
       
 62818         (WebCore::CheckCacheObjectStatus):
       
 62819         * page/qt/FrameQt.cpp: Added.
       
 62820         (WebCore::doScroll):
       
 62821         (WebCore::FrameQt::FrameQt):
       
 62822         (WebCore::FrameQt::~FrameQt):
       
 62823         (WebCore::FrameQt::passMouseDownEventToWidget):
       
 62824         (WebCore::FrameQt::isLoadTypeReload):
       
 62825         (WebCore::FrameQt::markedTextRange):
       
 62826         (WebCore::FrameQt::mimeTypeForFileName):
       
 62827         (WebCore::FrameQt::unfocusWindow):
       
 62828         (WebCore::FrameQt::focusWindow):
       
 62829         (WebCore::FrameQt::getEmbedInstanceForWidget):
       
 62830         (WebCore::FrameQt::getObjectInstanceForWidget):
       
 62831         (WebCore::FrameQt::getAppletInstanceForWidget):
       
 62832         (WebCore::FrameQt::issueCutCommand):
       
 62833         (WebCore::FrameQt::issueCopyCommand):
       
 62834         (WebCore::FrameQt::issuePasteCommand):
       
 62835         (WebCore::FrameQt::issuePasteAndMatchStyleCommand):
       
 62836         (WebCore::FrameQt::issueTransposeCommand):
       
 62837         (WebCore::FrameQt::respondToChangedSelection):
       
 62838         (WebCore::FrameQt::shouldChangeSelection):
       
 62839         (WebCore::FrameQt::print):
       
 62840         (WebCore::FrameQt::shouldInterruptJavaScript):
       
 62841         (WebCore::FrameQt::keyEvent):
       
 62842         (WebCore::FrameQt::setFrameGeometry):
       
 62843         (WebCore::FrameQt::client):
       
 62844         (WebCore::FrameQt::createNewWindow):
       
 62845         (WebCore::FrameQt::goBackOrForward):
       
 62846         (WebCore::FrameQt::historyURL):
       
 62847         (WebCore::FrameQt::runJavaScriptAlert):
       
 62848         (WebCore::FrameQt::runJavaScriptConfirm):
       
 62849         (WebCore::FrameQt::runJavaScriptPrompt):
       
 62850         (WebCore::FrameQt::bindingRootObject):
       
 62851         (WebCore::FrameQt::addPluginRootObject):
       
 62852         * page/qt/FrameQt.h: Added.
       
 62853         (WebCore::QtFrame):
       
 62854         * page/qt/FrameQtClient.cpp: Added.
       
 62855         (WebCore::FrameQtClient::FrameQtClient):
       
 62856         (WebCore::FrameQtClient::~FrameQtClient):
       
 62857         (WebCore::FrameQtClient::setFrame):
       
 62858         (WebCore::FrameQtClient::openURL):
       
 62859         (WebCore::FrameQtClient::submitForm):
       
 62860         (WebCore::FrameQtClient::didReceiveResponse):
       
 62861         (WebCore::FrameQtClient::didFinishLoading):
       
 62862         (WebCore::FrameQtClient::didFail):
       
 62863         (WebCore::FrameQtClient::didReceiveData):
       
 62864         (WebCore::FrameQtClient::traverseNextFrameStayWithin):
       
 62865         (WebCore::numRequests):
       
 62866         (WebCore::FrameQtClient::numPendingOrLoadingRequests):
       
 62867         * page/qt/FrameQtClient.h: Added.
       
 62868         * platform/qt/FrameQt.cpp: Removed.
       
 62869         * platform/qt/FrameQt.h: Removed.
       
 62870         * platform/qt/FrameQtClient.cpp: Removed.
       
 62871         * platform/qt/FrameQtClient.h: Removed.
       
 62872         * platform/qt/LoaderFunctionsQt.cpp: Removed.
       
 62873 
       
 62874 2007-01-10  Adam Roben  <aroben@apple.com>
       
 62875 
       
 62876         Reviewed by Geoff.
       
 62877 
       
 62878         Fix: <rdar://problem/4917054> ContextMenuController leaks Events
       
 62879 
       
 62880         No layout tests possible.
       
 62881 
       
 62882         * page/ContextMenuController.cpp:
       
 62883         (WebCore::ContextMenuController::contextMenuItemSelected): Use RefPtr
       
 62884         to manage the lifetime of Shared objects.
       
 62885 
       
 62886 2007-01-10  Rob Buis  <buis@kde.org>
       
 62887 
       
 62888         Reviewed by Sam.
       
 62889 
       
 62890         http://bugs.webkit.org/show_bug.cgi?id=12196
       
 62891         SVGPatternElement should not be locatable
       
 62892 
       
 62893         Replace SVGStyledLocatableElement derivation with
       
 62894         SVGStyledElement.
       
 62895 
       
 62896         * ksvg2/svg/SVGPatternElement.cpp:
       
 62897         (WebCore::SVGPatternElement::SVGPatternElement):
       
 62898         * ksvg2/svg/SVGPatternElement.h:
       
 62899 
       
 62900 2007-01-10  Nikolas Zimmermann  <zimmermann@kde.org>
       
 62901 
       
 62902         Build fix, not reviewed.
       
 62903 
       
 62904         * rendering/RenderSVGText.cpp: Use correct method name.
       
 62905         (WebCore::RenderSVGText::relativeBBox):
       
 62906 
       
 62907 2007-01-10  Nikolas Zimmermann  <zimmermann@kde.org>
       
 62908 
       
 62909         Reviewed by Eric.
       
 62910 
       
 62911         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10262 (SVG fails to redraw top 20 pixels)
       
 62912         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10263 (SVG seems to repaint way too many times during load)
       
 62913         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10404 (Invalidation issues with text skew)
       
 62914         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10407 (bad SVG text invalidation issues on mouseover/mouseout)
       
 62915         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10806 (failing manual-tests/svg-repaint-group.svg)
       
 62916         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10913 (SVG charts from plotkit fail to render unless you scroll them offscreen)
       
 62917         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10964 (inclusion of svg into svg leave a ghost invisible rectangle)
       
 62918         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11680 (DojoKit SVG test chart fails to render (clipping issue?))
       
 62919         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11883 (SVG Text has updating/repainting issues)
       
 62920         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11907 (RenderSVGContainer does not mark itself for repaint after setting viewBox, slice or align) 
       
 62921         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11913 (Invalidation issues in SVG javascript-based animation example)
       
 62922         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11979 (SVG text does not respect font-size scaling in bbox calculation)
       
 62923         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11984 (SVG <text> does not calculate the correct absoluteRepaintRect)
       
 62924         Partly fixes: http://bugs.webkit.org/show_bug.cgi?id=10745 (SVG layout needs to move out of DOM and into rendering tree during layout() call)
       
 62925 
       
 62926         Fixes text redrawing issues seen in svg/carto.net (when actually playing with those files, manually)
       
 62927         Fixes svg/carto.net/window.svg (moving "Navigation Window" caused artefacts)
       
 62928         Fixes svg/W3C-SVG-1.1/types-basicDOM-01-b.svg (bbox calculations had one pixel offset)
       
 62929 
       
 62930         Large SVG dynamic update rework/optimization. Also fixes SVG printing.
       
 62931 
       
 62932         Rename updateCanvasItem() to rebuildRenderer(), as this is what it really does.
       
 62933 
       
 62934         Do NOT call rebuildRenderer() in notifyAttributeChange() anymore,
       
 62935         but override notifyAttributeChange() in SVGPathElement/SVGCircleElement/etc..
       
 62936         (as only primitives using RenderPath as rendering object need this logic!)
       
 62937 
       
 62938         This should clarify what really happens, as discussed with Eric.
       
 62939 
       
 62940         Remove the invocations of notifyAttributeChange() in SVGLength. It's already
       
 62941         handled by the JS bindings, and we do double updating work. Fixed.
       
 62942 
       
 62943         Because SVG dynamic updates have been flaky in the past, there was a hack introduced
       
 62944         in RenderPath causing the updateCanvasItem() function to be called _on every layout_ (!!!).
       
 62945         Finally this hack is gone. Offer RenderSVGContainer::absoluteRects() function to be able
       
 62946         to use WebInspector for <g> elements (very handy!).
       
 62947 
       
 62948         Remove the unneeded "m_updateVectorial" bool from SVGStyledElement.
       
 62949         Remove computeAbsoluteRepaintRect() from RenderSVGContainer/RenderSVGImage/RenderSVGText,
       
 62950         as dicussed with David (we only need to reimplement getAbsoluteRepaintRect there).
       
 62951 
       
 62952         Make RenderSVGText::absoluteRects just use the getAbsoluteRepaintRect() function, instead of
       
 62953         code duplication. Remove unneeded RenderSVGImage::layout() function (RenderImage does the same).
       
 62954 
       
 62955         Add new function SVGStyledElement::renderStyleForElement, which centralizes the manual style
       
 62956         resolving needed for gradient stops.
       
 62957 
       
 62958         * ksvg2/svg/SVGCircleElement.cpp:
       
 62959         (WebCore::SVGCircleElement::notifyAttributeChange):
       
 62960         (WebCore::SVGCircleElement::hasRelativeValues):
       
 62961         * ksvg2/svg/SVGCircleElement.h:
       
 62962         * ksvg2/svg/SVGEllipseElement.cpp:
       
 62963         (WebCore::SVGEllipseElement::notifyAttributeChange):
       
 62964         (WebCore::SVGEllipseElement::hasRelativeValues):
       
 62965         * ksvg2/svg/SVGEllipseElement.h:
       
 62966         * ksvg2/svg/SVGImageElement.cpp:
       
 62967         (WebCore::SVGImageElement::notifyAttributeChange):
       
 62968         * ksvg2/svg/SVGImageElement.h:
       
 62969         * ksvg2/svg/SVGLength.cpp:
       
 62970         (WebCore::SVGLength::setValue):
       
 62971         (WebCore::SVGLength::setValueInSpecifiedUnits):
       
 62972         * ksvg2/svg/SVGLength.h:
       
 62973         (WebCore::SVGLength::isRelative):
       
 62974         * ksvg2/svg/SVGLineElement.cpp:
       
 62975         (WebCore::SVGLineElement::notifyAttributeChange):
       
 62976         (WebCore::SVGLineElement::hasRelativeValues):
       
 62977         * ksvg2/svg/SVGLineElement.h:
       
 62978         * ksvg2/svg/SVGLocatable.cpp:
       
 62979         (WebCore::SVGLocatable::getBBox):
       
 62980         * ksvg2/svg/SVGPathElement.cpp:
       
 62981         (WebCore::SVGPathElement::notifyAttributeChange):
       
 62982         * ksvg2/svg/SVGPathElement.h:
       
 62983         * ksvg2/svg/SVGPolyElement.cpp:
       
 62984         (WebCore::SVGPolyElement::notifyAttributeChange):
       
 62985         * ksvg2/svg/SVGPolyElement.h:
       
 62986         (WebCore::SVGPolyElement::rendererIsNeeded):
       
 62987         * ksvg2/svg/SVGRectElement.cpp:
       
 62988         (WebCore::SVGRectElement::notifyAttributeChange):
       
 62989         (WebCore::SVGRectElement::hasRelativeValues):
       
 62990         * ksvg2/svg/SVGRectElement.h:
       
 62991         * ksvg2/svg/SVGSVGElement.cpp:
       
 62992         (WebCore::SVGSVGElement::hasRelativeValues):
       
 62993         * ksvg2/svg/SVGSVGElement.h:
       
 62994         * ksvg2/svg/SVGStyledElement.cpp:
       
 62995         (WebCore::SVGStyledElement::SVGStyledElement):
       
 62996         (WebCore::SVGStyledElement::createRenderer):
       
 62997         (WebCore::SVGStyledElement::notifyAttributeChange):
       
 62998         (WebCore::SVGStyledElement::rebuildRenderer):
       
 62999         * ksvg2/svg/SVGStyledElement.h:
       
 63000         (WebCore::SVGStyledElement::hasRelativeValues):
       
 63001         * rendering/RenderPath.cpp:
       
 63002         (WebCore::RenderPath::setLocalTransform):
       
 63003         (WebCore::RenderPath::fillContains):
       
 63004         (WebCore::RenderPath::relativeBBox):
       
 63005         (WebCore::RenderPath::layout):
       
 63006         (WebCore::RenderPath::getAbsoluteRepaintRect):
       
 63007         (WebCore::RenderPath::paint):
       
 63008         (WebCore::RenderPath::nodeAtPoint):
       
 63009         (WebCore::drawMarkerWithData):
       
 63010         (WebCore::updateMarkerDataForElement):
       
 63011         (WebCore::drawStartAndMidMarkers):
       
 63012         (WebCore::RenderPath::drawMarkersIfNeeded):
       
 63013         (WebCore::RenderPath::hasRelativeValues):
       
 63014         * rendering/RenderPath.h:
       
 63015         * rendering/RenderSVGContainer.cpp:
       
 63016         (WebCore::RenderSVGContainer::layout):
       
 63017         (WebCore::RenderSVGContainer::paint):
       
 63018         (WebCore::RenderSVGContainer::calcViewport):
       
 63019         (WebCore::RenderSVGContainer::setViewBox):
       
 63020         (WebCore::RenderSVGContainer::setAlign):
       
 63021         (WebCore::RenderSVGContainer::viewportTransform):
       
 63022         (WebCore::RenderSVGContainer::getAbsoluteRepaintRect):
       
 63023         (WebCore::RenderSVGContainer::absoluteRects):
       
 63024         (WebCore::RenderSVGContainer::fillContains):
       
 63025         (WebCore::RenderSVGContainer::strokeContains):
       
 63026         (WebCore::RenderSVGContainer::relativeBBox):
       
 63027         (WebCore::RenderSVGContainer::setSlice):
       
 63028         * rendering/RenderSVGContainer.h:
       
 63029         * rendering/RenderSVGImage.cpp:
       
 63030         (WebCore::RenderSVGImage::RenderSVGImage):
       
 63031         (WebCore::RenderSVGImage::adjustRectsForAspectRatio):
       
 63032         (WebCore::RenderSVGImage::relativeBBox):
       
 63033         (WebCore::RenderSVGImage::imageChanged):
       
 63034         (WebCore::RenderSVGImage::getAbsoluteRepaintRect):
       
 63035         (WebCore::RenderSVGImage::absoluteRects):
       
 63036         * rendering/RenderSVGImage.h:
       
 63037         * rendering/RenderSVGText.cpp:
       
 63038         (WebCore::RenderSVGText::getAbsoluteRepaintRect):
       
 63039         (WebCore::RenderSVGText::layout):
       
 63040         (WebCore::RenderSVGText::createInlineBox):
       
 63041         (WebCore::RenderSVGText::absoluteRects):
       
 63042         (WebCore::RenderSVGText::relativeBBox):
       
 63043         * rendering/RenderSVGText.h:
       
 63044         * rendering/SVGInlineFlowBox.cpp:
       
 63045         (WebCore::placePositionedBoxesHorizontally):
       
 63046 
       
 63047 2007-01-10  David Hyatt  <hyatt@apple.com>
       
 63048 
       
 63049         Make the selectionRect() method of RenderText better by reusing computeAbsoluteRepaintRect.  This enables
       
 63050         the method to be multi-column aware and also to understand when the selection is clipped out by overflow.
       
 63051 
       
 63052         Reviewed by bdash
       
 63053 
       
 63054         * rendering/RenderText.cpp:
       
 63055         (WebCore::RenderText::selectionRect):
       
 63056 
       
 63057 2007-01-10  David Hyatt  <hyatt@apple.com>
       
 63058 
       
 63059         Make the absolutePosition method multi-column aware.  Note that there is now a real problem with the
       
 63060         absoluteRects method, since an object can split across multiple columns and break into multiple rects.
       
 63061         absolutePosition just returns the top-left corner of the element's box in the first column in which it
       
 63062         appears.
       
 63063 
       
 63064         Reviewed by bdash
       
 63065 
       
 63066         * rendering/RenderBlock.cpp:
       
 63067         (WebCore::RenderBlock::adjustRectForColumns):
       
 63068         * rendering/RenderBlock.h:
       
 63069         * rendering/RenderBox.cpp:
       
 63070         (WebCore::RenderBox::absolutePosition):
       
 63071         (WebCore::RenderBox::computeAbsoluteRepaintRect):
       
 63072         * rendering/RenderFlow.cpp:
       
 63073         (WebCore::RenderFlow::getAbsoluteRepaintRect):
       
 63074 
       
 63075 2007-01-09  David Hyatt  <hyatt@apple.com>
       
 63076 
       
 63077         Avoid crashing when repainting multiple columns... make sure to use the current vector's size and
       
 63078         not the newly-computed column count.
       
 63079 
       
 63080         * rendering/RenderBlock.cpp:
       
 63081         (WebCore::RenderBlock::layoutColumns):
       
 63082         (WebCore::RenderBlock::adjustRepaintRectForColumns):
       
 63083 
       
 63084 2007-01-09  David Hyatt  <hyatt@apple.com>
       
 63085 
       
 63086         Break up painting and hit testing of children into helper methods and add multi-column versions for both.
       
 63087         
       
 63088         Make incremental repainting able to invalidate the right spot in multiple column layouts so that e.g., link
       
 63089         hover works.
       
 63090 
       
 63091         Turn off selection gap filling in columns for now until it can be made to work correctly.
       
 63092 
       
 63093         Improve the column balancing heuristic by adding in the block's lineHeight/2 to each column initially to
       
 63094         account for column break adjustments that shrink the columns slightly.  Avoid clipping of the last column's
       
 63095         contents by ensuring it gets all the remaining available height.
       
 63096 
       
 63097         Reviewed by mitz
       
 63098 
       
 63099         * rendering/RenderBlock.cpp:
       
 63100         (WebCore::RenderBlock::paintColumns):
       
 63101         (WebCore::RenderBlock::paintContents):
       
 63102         (WebCore::RenderBlock::paintObject):
       
 63103         (WebCore::RenderBlock::fillSelectionGaps):
       
 63104         (WebCore::RenderBlock::nodeAtPoint):
       
 63105         (WebCore::RenderBlock::hitTestColumns):
       
 63106         (WebCore::RenderBlock::layoutColumns):
       
 63107         (WebCore::RenderBlock::adjustRepaintRectForColumns):
       
 63108         * rendering/RenderBlock.h:
       
 63109         * rendering/RenderBox.cpp:
       
 63110         (WebCore::RenderBox::computeAbsoluteRepaintRect):
       
 63111         * rendering/RenderFlow.cpp:
       
 63112         (WebCore::RenderFlow::getAbsoluteRepaintRect):
       
 63113 
       
 63114 2007-01-09  Remi Zara  <remi_zara@mac.com>
       
 63115 
       
 63116         Reviewed by Darin and Eric.
       
 63117 
       
 63118         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12150
       
 63119 
       
 63120         Don't use memset to set float to 0
       
 63121 
       
 63122         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
       
 63123         (WebCore::cgGradientCallback):
       
 63124 
       
 63125 2007-01-09  Anders Carlsson  <acarlsson@apple.com>
       
 63126 
       
 63127         Reviewed by Brady.
       
 63128 
       
 63129         Add default constructor to SharedBuffer.
       
 63130 
       
 63131         * platform/SharedBuffer.cpp:
       
 63132         (WebCore::SharedBuffer::SharedBuffer):
       
 63133         * platform/SharedBuffer.h:
       
 63134 
       
 63135 2007-01-09  David Hyatt  <hyatt@apple.com>
       
 63136 
       
 63137         This patch gets rudimentary column layout working.  Normal flow content only gets laid out into
       
 63138         columns properly and painted correctly initially.  What doesn't work: hit testing, incremental repainting,
       
 63139         column rule painting, child layers.
       
 63140 
       
 63141         Some work needs to be done on the render tree dumper before column tests will be
       
 63142         meaningful.
       
 63143 
       
 63144         Also reworked overflow and fixed a bunch of bugs with the computation of overflow.  These include an error
       
 63145         in the height calculations caused by not adding in the horizontal scrollbar height and other errors caused
       
 63146         by not checking overflow in lowest/rightmostPosition.  Existing tests improve their rendering to match
       
 63147         Firefox with this change.
       
 63148 
       
 63149         Fixed a bug where a table cell incorrectly expanded to encompass floats inside an overflow:auto block.
       
 63150         This should not have happened.  Covered by new test fast/overflow/table-overflow-float.html.
       
 63151 
       
 63152         Reviewed by mitz
       
 63153 
       
 63154         * page/Frame.cpp:
       
 63155         * rendering/RenderBlock.cpp:
       
 63156         (WebCore:::RenderFlow):
       
 63157         (WebCore::RenderBlock::layoutBlock):
       
 63158         (WebCore::RenderBlock::paintContents):
       
 63159         (WebCore::RenderBlock::paintChildren):
       
 63160         (WebCore::RenderBlock::paintObject):
       
 63161         (WebCore::RenderBlock::lowestPosition):
       
 63162         (WebCore::RenderBlock::rightmostPosition):
       
 63163         (WebCore::RenderBlock::leftmostPosition):
       
 63164         (WebCore::RenderBlock::avoidsFloats):
       
 63165         (WebCore::RenderBlock::nodeAtPoint):
       
 63166         (WebCore::RenderBlock::hitTestContents):
       
 63167         (WebCore::RenderBlock::layoutColumns):
       
 63168         * rendering/RenderBlock.h:
       
 63169         (WebCore::RenderBlock::hasOverhangingFloats):
       
 63170         (WebCore::RenderBlock::hasColumns):
       
 63171         * rendering/RenderFlexibleBox.cpp:
       
 63172         (WebCore::RenderFlexibleBox::layoutBlock):
       
 63173         (WebCore::RenderFlexibleBox::layoutHorizontalBox):
       
 63174         (WebCore::RenderFlexibleBox::layoutVerticalBox):
       
 63175         * rendering/RenderFlow.cpp:
       
 63176         (WebCore::RenderFlow::paintLines):
       
 63177         (WebCore::RenderFlow::lowestPosition):
       
 63178         (WebCore::RenderFlow::rightmostPosition):
       
 63179         (WebCore::RenderFlow::leftmostPosition):
       
 63180         * rendering/RenderFlow.h:
       
 63181         (WebCore::RenderFlow::hasColumns):
       
 63182         * rendering/RenderListMarker.cpp:
       
 63183         (WebCore::RenderListMarker::paint):
       
 63184         * rendering/RenderObject.h:
       
 63185         (WebCore::RenderObject::expandsToEncloseOverflow):
       
 63186         * rendering/RenderTableCell.h:
       
 63187         (WebCore::RenderTableCell::expandsToEncloseOverflow):
       
 63188         * rendering/RenderView.cpp:
       
 63189         (WebCore::RenderView::paint):
       
 63190 
       
 63191 2007-01-09  Darin Adler  <darin@apple.com>
       
 63192 
       
 63193         - update all 2007 Apple copyrights for the new company name
       
 63194 
       
 63195         * css/cssstyleselector.cpp:
       
 63196         * html/HTMLLIElement.cpp:
       
 63197         * platform/CharacterNames.h:
       
 63198         * platform/TextBreakIterator.h:
       
 63199         * platform/TextBreakIteratorICU.cpp:
       
 63200         * platform/graphics/ImageBuffer.h:
       
 63201         * rendering/CounterNode.cpp:
       
 63202         * rendering/CounterNode.h:
       
 63203         * rendering/RenderBox.h:
       
 63204         * rendering/RenderContainer.cpp:
       
 63205         * rendering/RenderCounter.cpp:
       
 63206         * rendering/RenderCounter.h:
       
 63207         * rendering/RenderImage.h:
       
 63208         * rendering/RenderListItem.h:
       
 63209         * rendering/RenderListMarker.h:
       
 63210         * rendering/RenderObject.cpp:
       
 63211         * rendering/RenderObject.h:
       
 63212         * rendering/RenderStyle.cpp:
       
 63213         * rendering/RenderStyle.h:
       
 63214         * rendering/RenderTable.cpp:
       
 63215         * rendering/RenderTableCell.cpp:
       
 63216         * rendering/RenderTableCell.h:
       
 63217         * rendering/RenderText.cpp:
       
 63218         * rendering/RenderText.h:
       
 63219         * rendering/RenderTreeAsText.cpp:
       
 63220         * rendering/SVGRenderTreeAsText.cpp:
       
 63221         * rendering/break_lines.cpp:
       
 63222 
       
 63223 2007-01-09  Justin Garcia  <justin.garcia@apple.com>
       
 63224 
       
 63225         Reviewed by john
       
 63226 
       
 63227         <rdar://problem/4840662>
       
 63228         REGRESSION: Mail crash when dragging text into a link
       
 63229         
       
 63230         moveParagraphs fails to move content into a display:block 
       
 63231         anchor because of code in positionAvoidingSpecialElementBoundary,
       
 63232         and so it infinitely recurs.
       
 63233         
       
 63234         * editing/htmlediting.cpp:
       
 63235         (WebCore::positionAvoidingSpecialElementBoundary): Don't avoid anchors
       
 63236         that have display:block so that content is inserted in the expected
       
 63237         paragraph.  This fixes the bug and weird behavior when typing before/after
       
 63238         anchors with display:block.
       
 63239 
       
 63240 2007-01-09  Rob Buis  <buis@kde.org>
       
 63241 
       
 63242         Reviewed by Darin.
       
 63243 
       
 63244         http://bugs.webkit.org/show_bug.cgi?id=12145
       
 63245         Color parsing is too relaxed in strict mode
       
 63246         http://bugs.webkit.org/show_bug.cgi?id=12166
       
 63247         REGRESSION (r18480): "336633" is not parsed as a color
       
 63248 
       
 63249         Fix a regression by using String::format return value.
       
 63250         Also make strict mode more strict for cases where hexcolors
       
 63251         lack a #.
       
 63252 
       
 63253         * css/cssparser.cpp:
       
 63254         (WebCore::CSSParser::parseColor):
       
 63255         (WebCore::CSSParser::parseColorFromValue):
       
 63256         * css/cssparser.h:
       
 63257 
       
 63258 2007-01-09  Darin Adler  <darin@apple.com>
       
 63259 
       
 63260         Reviewed by Maciej.
       
 63261 
       
 63262         - fixed regression where redirects did not have user-agent any more
       
 63263 
       
 63264         Showed up as a failure in one of the http tests, so no new test needed.
       
 63265 
       
 63266         * loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest):
       
 63267         Don't use a copy of the ResourceRequest; pass the original so it can be modified.
       
 63268 
       
 63269 2007-01-09  Mitz Pettel  <mitz@webkit.org>
       
 63270 
       
 63271         Reviewed by Darin.
       
 63272 
       
 63273         - fix http://bugs.webkit.org/show_bug.cgi?id=11078
       
 63274           Forms Don't Submit (ASP Pages)
       
 63275 
       
 63276         Test: fast/dom/collection-namedItem-via-item.html
       
 63277 
       
 63278         * bindings/js/kjs_html.cpp:
       
 63279         (KJS::JSHTMLCollectionProtoFunc::callAsFunction): Changed item() to fall back
       
 63280         to namedItem() if its argument does not convert to a number.
       
 63281 
       
 63282 2007-01-09  Darin Adler  <darin@apple.com>
       
 63283 
       
 63284         Reviewed by Maciej.
       
 63285 
       
 63286         - fix http://bugs.webkit.org/show_bug.cgi?id=12174
       
 63287           improve Unicode use (less WTF::Unicode:: prefix, centralized character names)
       
 63288 
       
 63289         - got rid of namespace prefixes from most uses of WTF::Unicode
       
 63290 
       
 63291         - updated for removal of WTF::Unicode::memcmp
       
 63292         - updated for renaming of WTF::Unicode::strcasecmp to umemcasecmp.
       
 63293 
       
 63294         - unified constants for special Unicode characters in a new
       
 63295           CharacterNames.h header
       
 63296 
       
 63297         * WebCore.xcodeproj/project.pbxproj:
       
 63298         * css/cssparser.cpp:
       
 63299         (WebCore::ParseString::lower):
       
 63300         * dom/Document.cpp:
       
 63301         (WebCore::isValidNameStart):
       
 63302         (WebCore::isValidNamePart):
       
 63303         * dom/Position.cpp:
       
 63304         (WebCore::Position::leadingWhitespacePosition):
       
 63305         (WebCore::Position::trailingWhitespacePosition):
       
 63306         * editing/CompositeEditCommand.cpp:
       
 63307         (WebCore::isWhitespace):
       
 63308         * editing/HTMLInterchange.cpp:
       
 63309         * editing/TextIterator.cpp:
       
 63310         (WebCore::CircularSearchBuffer::CircularSearchBuffer):
       
 63311         (WebCore::CircularSearchBuffer::append):
       
 63312         * editing/htmlediting.cpp:
       
 63313         (WebCore::stringWithRebalancedWhitespace):
       
 63314         (WebCore::nonBreakingSpaceString):
       
 63315         * editing/htmlediting.h:
       
 63316         * html/HTMLFontElement.cpp:
       
 63317         (WebCore::parseFontSizeNumber):
       
 63318         * html/HTMLParser.cpp:
       
 63319         (WebCore::HTMLParser::handleError):
       
 63320         * html/HTMLSelectElement.cpp:
       
 63321         (WebCore::stripLeadingWhiteSpace):
       
 63322         * platform/Font.cpp:
       
 63323         (WebCore::WidthIterator::advance):
       
 63324         (WebCore::WidthIterator::normalizeVoicingMarks):
       
 63325         * platform/GlyphMap.cpp:
       
 63326         (WebCore::GlyphMap::locatePage):
       
 63327         * platform/MimeTypeRegistry.h:
       
 63328         * platform/StringHash.h:
       
 63329         * platform/StringImpl.cpp:
       
 63330         (WebCore::isSpace):
       
 63331         (WebCore::StringImpl::append):
       
 63332         (WebCore::StringImpl::insert):
       
 63333         (WebCore::StringImpl::truncate):
       
 63334         (WebCore::StringImpl::remove):
       
 63335         (WebCore::parseLength):
       
 63336         (WebCore::StringImpl::isLower):
       
 63337         (WebCore::StringImpl::lower):
       
 63338         (WebCore::StringImpl::upper):
       
 63339         (WebCore::StringImpl::secure):
       
 63340         (WebCore::StringImpl::foldCase):
       
 63341         (WebCore::StringImpl::capitalize):t
       
 63342         (WebCore::StringImpl::toInt):
       
 63343         (WebCore::equalIgnoringCase):
       
 63344         (WebCore::StringImpl::find):
       
 63345         * platform/TextBoundaries.h:
       
 63346         * platform/TextCodec.h:
       
 63347         * platform/TextCodecLatin1.cpp:
       
 63348         * platform/TextEncoding.h:
       
 63349         * platform/TextEncodingRegistry.h:
       
 63350         * platform/mac/PasteboardMac.mm:
       
 63351         (WebCore::Pasteboard::writeSelection):
       
 63352         * platform/mac/TextCodecMac.cpp:
       
 63353         (WebCore::TextCodecMac::decode):
       
 63354         * rendering/RenderBlock.cpp:
       
 63355         (WebCore::RenderBlock::updateFirstLetter):
       
 63356         * rendering/RenderListMarker.cpp:
       
 63357         (WebCore::listMarkerText):
       
 63358         (WebCore::RenderListMarker::paint):
       
 63359         * rendering/RenderText.cpp:
       
 63360         (WebCore::RenderText::widthFromCache):
       
 63361         (WebCore::isSpaceAccordingToStyle):
       
 63362         (WebCore::RenderText::setInternalString):
       
 63363         * rendering/RenderTreeAsText.cpp:
       
 63364         (WebCore::quoteAndEscapeNonPrintables):
       
 63365         (WebCore::operator<<):
       
 63366         * rendering/bidi.cpp:
       
 63367         (WebCore::BidiState::BidiState):
       
 63368         (WebCore::BidiContext::BidiContext):
       
 63369         (WebCore::bidiNext):
       
 63370         (WebCore::bidiFirst):
       
 63371         (WebCore::BidiIterator::direction):
       
 63372         (WebCore::appendRun):
       
 63373         (WebCore::embed):
       
 63374         (WebCore::RenderBlock::bidiReorderLine):
       
 63375         (WebCore::RenderBlock::layoutInlineChildren):
       
 63376         (WebCore::skipNonBreakingSpace):
       
 63377         (WebCore::RenderBlock::findNextLineBreak):
       
 63378         * rendering/break_lines.cpp:
       
 63379         (WebCore::nextBreakablePosition):
       
 63380         * rendering/break_lines.h:
       
 63381         * xml/XPathParser.cpp:
       
 63382         (WebCore::XPath::charCat):
       
 63383 
       
 63384 2007-01-09  Dex Deacon  <occupant4@gmail.com>
       
 63385 
       
 63386         Reviewed by Darin.
       
 63387 
       
 63388         - fix http://bugs.webkit.org/show_bug.cgi?id=12170
       
 63389           RenderView holds dangling reference to RenderObjects as selection markers
       
 63390 
       
 63391         This fixes the crash seen on Windows -- the underlying problem
       
 63392         may still exist.
       
 63393 
       
 63394         * rendering/RenderText.h:
       
 63395         (WebCore::RenderText::selectionState):
       
 63396         Change the m_selectionState enum-bitfield to an unsigned-bitfield,
       
 63397         because enums on Windows are signed, which caused it to become
       
 63398         negative (whereas the valid values are all positive).
       
 63399 
       
 63400 2007-01-09  Darin Adler  <darin@apple.com>
       
 63401 
       
 63402         Reviewed by Hyatt.
       
 63403 
       
 63404         - http://bugs.webkit.org/show_bug.cgi?id=12175
       
 63405           port break_lines.cpp to be platform independent
       
 63406 
       
 63407         * platform/TextBreakIterator.h: Added lineBreakIterator.
       
 63408         Removed ICU-specific stuff from the header.
       
 63409 
       
 63410         * platform/TextBreakIteratorICU.cpp:
       
 63411         (WebCore::setUpIterator): Added helper to be shared by the three different
       
 63412         creation functions.
       
 63413         (WebCore::characterBreakIterator): Changed to use setUpIterator.
       
 63414         (WebCore::wordBreakIterator): Ditto.
       
 63415         (WebCore::lineBreakIterator): Added.
       
 63416 
       
 63417         * platform/qt/TextBreakIteratorQt.cpp:
       
 63418         (WebCore::lineBreakIterator): Added a stub.
       
 63419 
       
 63420         * rendering/break_lines.cpp:
       
 63421         (WebCore::isBreakableSpace): Added.
       
 63422         (WebCore::shouldBreakAfter): Added.
       
 63423         (WebCore::needsAdvancedBreakAnalysis): Added.
       
 63424         (WebCore::nextBreakablePosition): Changed to use TextBreakIterator on platforms
       
 63425         other than Mac.
       
 63426 
       
 63427 2007-01-09  Maciej Stachowiak  <mjs@apple.com>
       
 63428 
       
 63429         Reviewed by Darin.
       
 63430 
       
 63431         - move WebDataProtocol load handling from ResourceLoader to MainResourceLoader
       
 63432         
       
 63433         (it's only ever used for main resources)
       
 63434 
       
 63435         * loader/ResourceLoader.h:
       
 63436         (WebCore::ResourceLoader::setRequest):
       
 63437         * loader/mac/MainResourceLoaderMac.mm:
       
 63438         (WebCore::MainResourceLoader::willSendRequest):
       
 63439         (WebCore::MainResourceLoader::continueAfterContentPolicy):
       
 63440         * loader/mac/ResourceLoaderMac.mm:
       
 63441         (WebCore::ResourceLoader::willSendRequest):
       
 63442         (WebCore::ResourceLoader::didReceiveResponse):
       
 63443 
       
 63444 2007-01-09  Rob Buis  <buis@kde.org>
       
 63445 
       
 63446         Reviewed by Eric.
       
 63447 
       
 63448         http://bugs.webkit.org/show_bug.cgi?id=12129
       
 63449         repaint issue after setting viewBox attribute with ECMAScript
       
 63450 
       
 63451         Make sure RenderSVGContainer updates after setting viewBox from js.
       
 63452 
       
 63453         * ksvg2/svg/SVGSVGElement.cpp:
       
 63454         (WebCore::SVGSVGElement::parseMappedAttribute):
       
 63455         * rendering/RenderSVGContainer.cpp:
       
 63456         (WebCore::RenderSVGContainer::setViewBox):
       
 63457 
       
 63458 2007-01-09  Lars Knoll <lars@trolltech.com>
       
 63459 
       
 63460         Make the Qt build compile... again!
       
 63461 
       
 63462         * WebCore.pro:
       
 63463         * loader/qt/FrameLoaderQt.cpp:
       
 63464         * platform/graphics/qt/GraphicsContextQt.cpp:
       
 63465         * platform/graphics/qt/ImageBufferQt.cpp:
       
 63466         (WebCore::ImageBuffer::create):
       
 63467         * platform/qt/WidgetQt.cpp:
       
 63468         (WebCore::Widget::focusPolicy):
       
 63469 
       
 63470 2007-01-09  David Hyatt  <hyatt@apple.com>
       
 63471 
       
 63472         Fix for background: inherit bug where background-color wasn't getting properly overridden.  This was a
       
 63473         regression from Safari 1.3 to 2.0.
       
 63474 
       
 63475         Reviewed by bdash
       
 63476 
       
 63477         fast/backgrounds/background-color-inherit-bug.html
       
 63478 
       
 63479         * css/cssstyleselector.cpp:
       
 63480         (WebCore::CSSStyleSelector::applyProperty):
       
 63481 
       
 63482 2007-01-08  Brady Eidson <beidson@apple.com>
       
 63483 
       
 63484         Reviewed by Brian Dash
       
 63485 
       
 63486         <rdar://problem/4895178> 
       
 63487         WebCore::BackForwardList vector should be backed by a HashSet to remove
       
 63488         the potential expense in frequently calling BackForwardList::containsItem()
       
 63489 
       
 63490         * history/BackForwardList.cpp:
       
 63491         (WebCore::BackForwardList::addItem): Maintain HashSet as well as Vector
       
 63492         (WebCore::BackForwardList::setCapacity): Ditto
       
 63493         (WebCore::BackForwardList::close): Ditto
       
 63494         (WebCore::BackForwardList::removeItem): Ditto
       
 63495         (WebCore::BackForwardList::containsItem): Make a hash lookup instead of iterate 
       
 63496         through the Vector
       
 63497         * history/BackForwardList.h:
       
 63498 
       
 63499 2007-01-08  David Hyatt  <hyatt@apple.com>
       
 63500 
       
 63501         Fix a regression where layout is triggering on all recalcStyles, due to a bad comparison
       
 63502         in the multicol assignment operator.
       
 63503 
       
 63504         * rendering/RenderStyle.cpp:
       
 63505         (WebCore::StyleMultiColData::operator==):
       
 63506 
       
 63507 2007-01-08  Darin Adler  <darin@apple.com>
       
 63508 
       
 63509         - rolled out Beth's RenderFlow::destroy change, which broke 5 editing tests
       
 63510 
       
 63511         * rendering/InlineBox.cpp: (WebCore::InlineBox::root):
       
 63512         * rendering/RenderFlow.cpp: (WebCore::RenderFlow::destroy):
       
 63513         Used svn merge to roll the change out.
       
 63514 
       
 63515 2007-01-09  Mark Rowe  <mrowe@apple.com>
       
 63516 
       
 63517         Reviewed by Tim H.
       
 63518 
       
 63519         Build fix for 64-bit platforms.
       
 63520 
       
 63521         * platform/graphics/svg/SVGPaintServerGradient.h:
       
 63522         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
       
 63523         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
       
 63524 
       
 63525 2007-01-08  Anders Carlsson  <acarlsson@apple.com>
       
 63526 
       
 63527         Reviewed by Brady.
       
 63528 
       
 63529         Move some history related functions off the bridge and into FrameLoader directly.
       
 63530 
       
 63531         * loader/FrameLoader.cpp:
       
 63532         (WebCore::FrameLoader::canGoBackOrForward):
       
 63533         (WebCore::FrameLoader::getHistoryLength):
       
 63534         (WebCore::FrameLoader::historyURL):
       
 63535         * loader/mac/FrameLoaderMac.mm:
       
 63536         * page/mac/WebCoreFrameBridge.h:
       
 63537 
       
 63538 2007-01-08  Sam Weinig  <sam@webkit.org>
       
 63539 
       
 63540         Reviewed by Mark.
       
 63541 
       
 63542         Adds outline-color to list of computable styles.
       
 63543 
       
 63544         * css/CSSComputedStyleDeclaration.cpp:
       
 63545         (WebCore::):
       
 63546 
       
 63547 2007-01-08  Beth Dakin  <bdakin@apple.com>
       
 63548 
       
 63549         Reviewed by Hyatt.
       
 63550 
       
 63551         Fix for a bug that Adam, Hyatt, and I noticed when debugging 
       
 63552         another problem.
       
 63553 
       
 63554         * rendering/InlineBox.cpp:
       
 63555         (WebCore::InlineBox::root): Added assertion. If we are casting to a 
       
 63556         root, we should make sure we are root.
       
 63557         * rendering/RenderFlow.cpp:
       
 63558         (WebCore::RenderFlow::destroy): It is not enough to remove the 
       
 63559         child boxes for anonymous blocks. We need to be more thorough when 
       
 63560         cleaning these up. Adam's test case illustrates the problem well.
       
 63561 
       
 63562 2007-01-08  John Sullivan  <sullivan@apple.com>
       
 63563 
       
 63564         Tweak to previous checkin
       
 63565 
       
 63566         * page/ContextMenuController.cpp:
       
 63567         (WebCore::ContextMenuController::contextMenuItemSelected):
       
 63568         Adam suggested I should nil-check frame->page()
       
 63569 
       
 63570 2007-01-08  John Sullivan  <sullivan@apple.com>
       
 63571 
       
 63572         Reviewed by Brady and Beth
       
 63573         
       
 63574         - fixed <rdar://problem/4912541> GMAIL: With selected text in a rich text message, choosing 
       
 63575         "Search in Google" displays search results in the message body field
       
 63576 
       
 63577         * page/ContextMenuController.cpp:
       
 63578         (WebCore::ContextMenuController::contextMenuItemSelected):
       
 63579         Visit google URL in main frame rather than in current frame
       
 63580 
       
 63581 2007-01-08  David Hyatt  <hyatt@apple.com>
       
 63582 
       
 63583         Fix computed style errors for color properties that had invalid colors.
       
 63584         They should return the value of the 'color' property when their colors
       
 63585         are not valid.
       
 63586 
       
 63587         Fixed the computed style value for border-top-color (a typo was causing it to
       
 63588         use border-left-color instead).
       
 63589 
       
 63590         Implement outline-color computed style.
       
 63591 
       
 63592         Reviewed by harrison
       
 63593 
       
 63594         * css/CSSComputedStyleDeclaration.cpp:
       
 63595         (WebCore::currentColorOrValidColor):
       
 63596         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 63597 
       
 63598 2007-01-08  Remi Zara  <remi_zara@mac.com>
       
 63599 
       
 63600         Reviewed by Darin and Eric.
       
 63601 
       
 63602         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12150
       
 63603         Handle correctly cases where no stops are defined, cases where a
       
 63604         stop offset value is less than previous stops offset value, and cases
       
 63605         where a stop offset value is greater than 1.0.
       
 63606         
       
 63607         * platform/graphics/svg/SVGPaintServerGradient.cpp:
       
 63608         (WebCore::SVGPaintServerGradient::setGradientStops): Don't sort stops
       
 63609         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
       
 63610         (WebCore::cgGradientCallback): When there are no stops, use a transparent
       
 63611         fill
       
 63612         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
       
 63613         a stop offset must always be considered at greater or equal to all
       
 63614         preceding stop offsets, but no more than 1.0
       
 63615 
       
 63616 2007-01-08  Timothy Hatcher  <timothy@apple.com>
       
 63617 
       
 63618         Reviewed by Geoff.
       
 63619 
       
 63620         <rdar://problem/4865325> please re-add auto font activation support in WebKit
       
 63621 
       
 63622         * platform/mac/WebFontCache.mm:
       
 63623         (+[WebFontCache fontWithFamily:traits:size:]):
       
 63624 
       
 63625 2007-01-08  Darin Adler  <darin@apple.com>
       
 63626 
       
 63627         Reviewed by Adam.
       
 63628 
       
 63629         - http://bugs.webkit.org/show_bug.cgi?id=12143
       
 63630           remove Widget code unneeded now that form elements do not use Widget
       
 63631 
       
 63632         * bindings/objc/DOMHTML.mm: (-[DOMHTMLSelectElement _activateItemAtIndex:]):
       
 63633         Removed useless implementation that would only work with NSView-based
       
 63634         <select> elements, and added a FIXME about the fact that this function
       
 63635         doesn't do anything any more. I think it's used by Safari forms auto-fill.
       
 63636 
       
 63637         * bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject rendererForView:]):
       
 63638         Removed code that depends on elementForView:, since that always returns
       
 63639         nil now.
       
 63640 
       
 63641         * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::~HTMLFormElement):
       
 63642         Use a formDestroyed() function rather than clearing m_form directly so that
       
 63643         this class doesn't have to be a friend of HTMLGenericFormElement.
       
 63644 
       
 63645         * html/HTMLGenericFormElement.h: Removed now-unneeded friend declaration
       
 63646         for HTMLFormElement. Moved definition of supportsFocus into the .cpp file.
       
 63647         Added a public formDestroyed function for use by HTMLFormElement.
       
 63648         * html/HTMLGenericFormElement.cpp:
       
 63649         (WebCore::HTMLGenericFormElement::attach): Removed widget-specific code.
       
 63650         (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
       
 63651         (WebCore::HTMLGenericFormElement::isMouseFocusable): Ditto.
       
 63652         (WebCore::HTMLGenericFormElement::supportsFocus): Added this here; it was
       
 63653         in the header file before, for no good reason.
       
 63654 
       
 63655         * page/EventHandler.h: Removed unused Mac-specific
       
 63656         currentEventIsMouseDownInWidget.
       
 63657         * page/mac/EventHandlerMac.mm: Ditto.
       
 63658 
       
 63659         * page/Frame.cpp: (WebCore::Frame::frameForWidget): Changed to use
       
 63660         RenderWidget to find the frame rather than the WigetClient element()
       
 63661         function.
       
 63662 
       
 63663         * page/mac/FrameMac.h: Removed unused bridgeForWidget.
       
 63664         * page/mac/FrameMac.mm: Ditto.
       
 63665 
       
 63666         * page/mac/WebCoreFrameBridge.h: Removed elementForView.
       
 63667         * page/mac/WebCoreFrameBridge.mm: Ditto. While the scroll bar still did
       
 63668         implement WebCoreWidgetHolder, it does not correspond to a DOM element,
       
 63669         so this method was always returning nil.
       
 63670 
       
 63671         * platform/Widget.h: Moved unused types and functions that are still
       
 63672         in the platform-specific implementations into a "to be deleted" section:
       
 63673         FocusPolicy, NoFocus, TabFocus, ClickFocus, StrongFocus, WheelFocus,
       
 63674         lockDrawingFocus, font, focusPolicy, hasFocus, clearFocus, setFont,
       
 63675         disableFlushDrawing, enableFlushDrawing, unlockDrawingFocus.
       
 63676         Removed unused functions that are not in platform-specific implementations:
       
 63677         sizeHint, baselinePosition, checksDescendantsForFocus.
       
 63678         * platform/Widget.cpp: Removed functions.
       
 63679 
       
 63680         * platform/WidgetClient.h: Emptied out the class. Soon we can delete it.
       
 63681 
       
 63682         * platform/mac/PlatformScrollBarMac.mm: (-[WebCoreScrollBar mouseDown:]):
       
 63683         Got rid of unneeded includes, removed use of the WebCoreWidgetHolder
       
 63684         protocol and the one method in it, and changed the calls to beforeMouseDown
       
 63685         and afterMouseDown to pass the widget pointer in.
       
 63686 
       
 63687         * platform/mac/WebCoreWidgetHolder.h: Emptied out the file -- to be deleted
       
 63688         later.
       
 63689 
       
 63690         * platform/mac/WidgetMac.mm:
       
 63691         (WebCore::Widget::~Widget): Removed code to manage deferredFirstResponder.
       
 63692         (WebCore::Widget::hasFocus): Removed body of function and replaced with
       
 63693         an assertion that it's never called. Later we'll remove it.
       
 63694         (WebCore::Widget::setFocus): Tweaked a bit to work given changes to the
       
 63695         FrameMac class. Also added a FIXME. Given how this works, it does not
       
 63696         belong in the platform layer.
       
 63697         (WebCore::Widget::clearFocus): Removed body of function and replaced with
       
 63698         an assertion that it's never called. Later we'll remove it.
       
 63699         (WebCore::Widget::focusPolicy): Ditto.
       
 63700         (WebCore::Widget::font): Ditto.
       
 63701         (WebCore::Widget::setFont): Ditto.
       
 63702         (WebCore::Widget::lockDrawingFocus): Ditto.
       
 63703         (WebCore::Widget::unlockDrawingFocus): Ditto.
       
 63704         (WebCore::Widget::disableFlushDrawing): Ditto.
       
 63705         (WebCore::Widget::enableFlushDrawing): Ditto.
       
 63706         (WebCore::Widget::paint): Removed obsolete comment.
       
 63707         (WebCore::Widget::sendConsumedMouseUp): Removed body of function and replaced with
       
 63708         an assertion that it's never called. Later we'll remove it.
       
 63709         (WebCore::Widget::setIsSelected): Tweaked a bit to work given changes to the
       
 63710         FrameMac class. Also added a FIXME. Given how this works, it does not
       
 63711         belong in the platform layer.
       
 63712         (WebCore::Widget::beforeMouseDown): Changed to take an explicit Widget parameter.
       
 63713         (WebCore::Widget::afterMouseDown): Ditto.
       
 63714 
       
 63715         * rendering/RenderApplet.cpp:
       
 63716         (WebCore::RenderApplet::intrinsicWidth): Changed to not call sizeHint() any more.
       
 63717         I didn't change the values returned by the function, but they make no sense and
       
 63718         this should probably be fixed later.
       
 63719         (WebCore::RenderApplet::intrinsicHeight): Ditto.
       
 63720 
       
 63721         * rendering/RenderWidget.h: Removed unneeded WidgetClient.h include. Changed
       
 63722         RenderWidget to no longer inherit from WidgetClient. Added a find function to find
       
 63723         a RenderWidget given a Widget. Removed all the virtual functions that override
       
 63724         WidgetClient hooks.
       
 63725         * rendering/RenderWidget.cpp: Removed all the WidgetClient functions.
       
 63726         (WebCore::widgetRendererMap): Added. Map that gives the RenderWidget for each
       
 63727         Widget that is owned by a RenderWidget.
       
 63728         (WebCore::RenderWidget::destroy): Removed the setClient call and added a call to
       
 63729         remove the widget from the widgetRendererMap.
       
 63730         (WebCore::RenderWidget::setWidget): Ditto.
       
 63731         (WebCore::RenderWidget::setStyle): Removed the call to Widget::setFont.
       
 63732         (WebCore::RenderWidget::find): Added. Returns the RenderWidget for a Widget, if any.
       
 63733 
       
 63734         - other changes
       
 63735 
       
 63736         * dom/Node.cpp:
       
 63737         (WebCore::Node::dump): Removed unnecessary use of DeprecatedString.
       
 63738         (WebCore::appendAttributeDesc): Ditto.
       
 63739         (WebCore::Node::showNode): Ditto.
       
 63740         (WebCore::Node::formatForDebugger): Ditto.
       
 63741 
       
 63742         * loader/CachedImage.cpp: (WebCore::CachedImage::createImage): Cleaned up
       
 63743         conditional compilation so adding more MIME types here doesn't make the
       
 63744         function more and more difficult to read.
       
 63745 
       
 63746         * page/Frame.h: Removed unneeded includes and declarations.
       
 63747         Tweaked formatting.
       
 63748         * page/Page.h: Removed unneeded declarations.
       
 63749         * platform/ScrollView.h: Removed unneeded includes.
       
 63750 
       
 63751         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::renderName): Tweaked formatting.
       
 63752 
       
 63753 2007-01-08  Mitz Pettel  <mitz@webkit.org>
       
 63754 
       
 63755         Reviewed by Darin.
       
 63756 
       
 63757         - fix http://bugs.webkit.org/show_bug.cgi?id=12162
       
 63758           The inheritableProperties array is duplicated
       
 63759 
       
 63760         No test possible (no change to functionality).
       
 63761 
       
 63762         * css/CSSComputedStyleDeclaration.cpp:
       
 63763         (WebCore::CSSComputedStyleDeclaration::removeComputedInheritablePropertiesFrom): Added.
       
 63764         Removes the inheritable properties that CSSComputedStyleDeclaration knows how to compute
       
 63765         from the given mutable declaration.
       
 63766         * css/CSSComputedStyleDeclaration.h:
       
 63767         * css/CSSMutableStyleDeclaration.cpp: Removed one copy of the inheritableProperties array.
       
 63768         * css/CSSMutableStyleDeclaration.h:
       
 63769         * editing/ReplaceSelectionCommand.cpp:
       
 63770         (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Changed to call
       
 63771         CSSComputedStyleDeclaration::removeComputedInheritablePropertiesFrom.
       
 63772 
       
 63773 2007-01-08  Alexey Proskuryakov  <ap@webkit.org>
       
 63774 
       
 63775         Reviewed by Darin.
       
 63776 
       
 63777         http://bugs.webkit.org/show_bug.cgi?id=12099
       
 63778         XMLHttpRequest shouldn't honor a charset specified via setRequestHeader
       
 63779 
       
 63780         Test: http/tests/xmlhttprequest/request-encoding.html
       
 63781 
       
 63782         * xml/xmlhttprequest.cpp:
       
 63783         (WebCore::XMLHttpRequest::send): Don't try to get the charset from Content-Type. Keep checking 
       
 63784         for unknown charsets, because that will be needed again when we start using document.xmlEncoding.
       
 63785 
       
 63786 2007-01-08  Alexey Proskuryakov  <ap@webkit.org>
       
 63787 
       
 63788         Reviewed by Darin.
       
 63789 
       
 63790         http://bugs.webkit.org/show_bug.cgi?id=7640
       
 63791         Menu items are displayed as "undefined"
       
 63792 
       
 63793         * bindings/js/kjs_dom.cpp:
       
 63794         (KJS::DOMNodeProtoFunc::callAsFunction):
       
 63795         * bindings/js/kjs_domnode.h:
       
 63796         (KJS::DOMNode::):
       
 63797         Removed Node::item. No idea why it was there in the first place.
       
 63798 
       
 63799         * bindings/js/kjs_html.cpp:
       
 63800         (KJS::HTMLElementFunction::callAsFunction):
       
 63801         * bindings/js/kjs_html.h:
       
 63802         (KJS::JSHTMLElement::):
       
 63803         Added HTMLSelectElement::item. It is not in DOM2 IDL, but the spec seems to mentions it anyway:
       
 63804         "The contained options can be directly accessed through the select element as a collection."
       
 63805 
       
 63806         * html/HTMLSelectElement.cpp:
       
 63807         (WebCore::HTMLSelectElement::namedItem):
       
 63808         (WebCore::HTMLSelectElement::item):
       
 63809         * html/HTMLSelectElement.h:
       
 63810         * html/HTMLSelectElement.idl:
       
 63811         Added this method to DOM and IDL, too. Made namedItem() non-virtual.
       
 63812 
       
 63813 2007-01-08  Beth Dakin  <bdakin@apple.com>
       
 63814 
       
 63815         Reviewed by Maciej.
       
 63816 
       
 63817         Fix for <rdar://problem/4912254> REGRESSION: After copying text to 
       
 63818         the clipboard, the paste contextual remains dimmed when it should
       
 63819         be active
       
 63820 
       
 63821         No layout test for context menu problems.
       
 63822 
       
 63823         * platform/ContextMenu.cpp:
       
 63824         (WebCore::ContextMenu::checkOrEnableIfNeeded): Remove check to see 
       
 63825         if the content is richly editable; it only has to be regular 
       
 63826         editable and the call to canPaste() takes care of that.
       
 63827 
       
 63828 2007-01-08  Sam Weinig  <sam@webkit.org>
       
 63829 
       
 63830         Reviewed by Mitz.
       
 63831 
       
 63832         Attempt to fix build for buildbots.
       
 63833 
       
 63834         * rendering/RenderBlock.cpp:
       
 63835         (WebCore::RenderBlock::columnGap):
       
 63836         (WebCore::RenderBlock::calcColumnWidth):
       
 63837 
       
 63838 2007-01-08  Darin Adler  <darin@apple.com>
       
 63839 
       
 63840         Reviewed by Maciej.
       
 63841 
       
 63842         - fix http://bugs.webkit.org/show_bug.cgi?id=3232
       
 63843           CSS2: Web Kit does not support all list style types
       
 63844 
       
 63845         Test case showed problems in cjk-ideographic and hebrew
       
 63846         Test: fast/lists/w3-list-styles.html
       
 63847 
       
 63848         * rendering/RenderListMarker.cpp:
       
 63849         (WebCore::toCJKIdeographic): Fix the algorithm so it doesn't include leading zeroes.
       
 63850         I had misread the part that says you start with the decimal form of the number.
       
 63851         Fix an assertion that was too stringent. Fix the code to collapse consecutive zeroes
       
 63852         so that it doesn't get confused by intervening "noChar" characters.
       
 63853         (WebCore::RenderListMarker::paint): Reverse the text before painting if the first character's
       
 63854         direction is right to left.
       
 63855 
       
 63856 2007-01-08  Darin Adler  <darin@apple.com>
       
 63857 
       
 63858         Reviewed by Beth.
       
 63859 
       
 63860         - http://bugs.webkit.org/show_bug.cgi?id=12142
       
 63861           render tree dump for test results should include the value of list markers
       
 63862 
       
 63863         * rendering/RenderTreeAsText.cpp:
       
 63864         (WebCore::getTagName): Changed to use String instead of DeprecatedString.
       
 63865         (WebCore::quoteAndEscapeNonPrintables): Ditto. Also moved up so it can be used
       
 63866         in the operator below.
       
 63867         (WebCore::operator<<): Added clause for RenderListMarker that dumps the value
       
 63868         of the list marker's text.
       
 63869         (WebCore::nodePosition): Changed to use String instead of DeprecatedString.
       
 63870         * rendering/SVGRenderTreeAsText.cpp:
       
 63871         (WebCore::TextStreamSeparator::TextStreamSeparator): Changed to use String
       
 63872         instead of DeprecatedString.
       
 63873         (WebCore::getTagName): Ditto.
       
 63874         (WebCore::write): Ditto.
       
 63875 
       
 63876 2007-01-08  Sam Weinig  <sam@webkit.org>
       
 63877 
       
 63878         Reviewed by ap and the rubber stamp of Maciej.
       
 63879 
       
 63880         Patch for http://bugs.webkit.org/show_bug.cgi?id=12164
       
 63881         Cleanup Tokenizers
       
 63882 
       
 63883         - Moves Tokenizer class into its own file.
       
 63884         - Move XMLTokenizer declaration from XMLTokenizer.cpp to XMLTokenizer.h
       
 63885         - Fixup #includes.
       
 63886 
       
 63887         * WebCore.xcodeproj/project.pbxproj:
       
 63888         * dom/Document.cpp:
       
 63889         (WebCore::Document::createTokenizer):
       
 63890         * dom/Tokenizer.h: Added.
       
 63891         (WebCore::Tokenizer::Tokenizer):
       
 63892         (WebCore::Tokenizer::~Tokenizer):
       
 63893         (WebCore::Tokenizer::stopParsing):
       
 63894         (WebCore::Tokenizer::processingData):
       
 63895         (WebCore::Tokenizer::executingScript):
       
 63896         (WebCore::Tokenizer::wantsRawData):
       
 63897         (WebCore::Tokenizer::writeRawData):
       
 63898         (WebCore::Tokenizer::inViewSourceMode):
       
 63899         (WebCore::Tokenizer::setInViewSourceMode):
       
 63900         (WebCore::Tokenizer::wellFormed):
       
 63901         (WebCore::Tokenizer::lineNumber):
       
 63902         (WebCore::Tokenizer::columnNumber):
       
 63903         * dom/XMLTokenizer.cpp:
       
 63904         * dom/XMLTokenizer.h:
       
 63905         (WebCore::XMLTokenizer::):
       
 63906         (WebCore::XMLTokenizer::setIsXHTMLDocument):
       
 63907         (WebCore::XMLTokenizer::isXHTMLDocument):
       
 63908         (WebCore::XMLTokenizer::wellFormed):
       
 63909         * html/HTMLElement.cpp:
       
 63910         * html/HTMLTokenizer.h:
       
 63911         (WebCore::Token::reset):
       
 63912         (WebCore::HTMLTokenizer::checkBuffer):
       
 63913         (WebCore::HTMLTokenizer::checkScriptBuffer):
       
 63914         (WebCore::HTMLTokenizer::State::State):
       
 63915         (WebCore::HTMLTokenizer::State::setBit):
       
 63916         * xml/XSLTProcessor.cpp:
       
 63917 
       
 63918 2007-01-08  Sam Weinig  <sam@webkit.org>
       
 63919 
       
 63920         Reviewed by Tim H.
       
 63921 
       
 63922         Adds -webkit-box-shadow to list of computable styles.
       
 63923 
       
 63924         * css/CSSComputedStyleDeclaration.cpp:
       
 63925         (WebCore::):
       
 63926 
       
 63927 2007-01-08  Rob Buis  <buis@kde.org>
       
 63928 
       
 63929         Reviewed by bdash.
       
 63930 
       
 63931         Initialize the member vars, fixes testcases
       
 63932         pointer-events-path.svg and pointer-events-text.svg
       
 63933         on the PPC build.
       
 63934 
       
 63935         * ksvg2/misc/PointerEventsHitRules.cpp:
       
 63936         (WebCore::PointerEventsHitRules::PointerEventsHitRules):
       
 63937 
       
 63938 2007-01-08  David Hyatt  <hyatt@apple.com>
       
 63939 
       
 63940         This patch computes the correct column width and column count.  It ensures that content lays out constrained
       
 63941         to the column width in one long strip.  It does not yet balance the long strip into multiple columns.
       
 63942 
       
 63943         Reviewed by Mark
       
 63944 
       
 63945         * rendering/RenderBlock.cpp:
       
 63946         (WebCore:::RenderFlow):
       
 63947         (WebCore::RenderBlock::layoutBlock):
       
 63948         (WebCore::RenderBlock::rightOffset):
       
 63949         (WebCore::RenderBlock::availableWidth):
       
 63950         (WebCore::RenderBlock::columnGap):
       
 63951         (WebCore::RenderBlock::calcColumnWidth):
       
 63952         * rendering/RenderBlock.h:
       
 63953         * rendering/RenderStyle.h:
       
 63954         (WebCore::RenderStyle::setColumnWidth):
       
 63955 
       
 63956 2007-01-08  David Hyatt  <hyatt@apple.com>
       
 63957 
       
 63958         Fix column-count so that it supports auto just like column-width does.
       
 63959 
       
 63960         Add a new function, availableWidth(), that will be used to return the width available to content placed inside
       
 63961         a block.  For now it still returns contentWidth(), so no behavioral change has occurred yet.
       
 63962 
       
 63963         Subclass calcWidth() in RenderBlock, but don't change anything yet.  This is where RenderBlock will calc the
       
 63964         correct column width.
       
 63965 
       
 63966         Reviewed by mark
       
 63967 
       
 63968         * css/CSSComputedStyleDeclaration.cpp:
       
 63969         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 63970         * css/cssstyleselector.cpp:
       
 63971         (WebCore::CSSStyleSelector::applyProperty):
       
 63972         * rendering/RenderBlock.cpp:
       
 63973         (WebCore::RenderBlock::leftRelOffset):
       
 63974         (WebCore::RenderBlock::rightRelOffset):
       
 63975         (WebCore::RenderBlock::getClearDelta):
       
 63976         (WebCore::RenderBlock::availableWidth):
       
 63977         (WebCore::RenderBlock::calcWidth):
       
 63978         * rendering/RenderBlock.h:
       
 63979         * rendering/RenderBox.cpp:
       
 63980         (WebCore::RenderBox::containingBlockWidth):
       
 63981         * rendering/RenderObject.cpp:
       
 63982         (WebCore::RenderObject::containingBlockWidth):
       
 63983         (WebCore::RenderObject::paddingTop):
       
 63984         (WebCore::RenderObject::paddingBottom):
       
 63985         (WebCore::RenderObject::paddingLeft):
       
 63986         (WebCore::RenderObject::paddingRight):
       
 63987         * rendering/RenderObject.h:
       
 63988         (WebCore::RenderObject::availableWidth):
       
 63989         * rendering/RenderStyle.cpp:
       
 63990         (WebCore::StyleMultiColData::StyleMultiColData):
       
 63991         (WebCore::StyleMultiColData::operator==):
       
 63992         * rendering/RenderStyle.h:
       
 63993         (WebCore::RenderStyle::hasAutoColumnCount):
       
 63994         (WebCore::RenderStyle::setColumnCount):
       
 63995         (WebCore::RenderStyle::setHasAutoColumnCount):
       
 63996         * rendering/RenderTable.cpp:
       
 63997         (WebCore::RenderTable::calcWidth):
       
 63998 
       
 63999 2007-01-08  David Hyatt  <hyatt@apple.com>
       
 64000 
       
 64001         Fix z-index:inherit so that it works properly when inheriting from z-index:auto.
       
 64002 
       
 64003         Reviewed by eric
       
 64004 
       
 64005         fast/layers/zindex-inherit.html
       
 64006 
       
 64007         * css/cssstyleselector.cpp:
       
 64008         (WebCore::CSSStyleSelector::applyProperty):
       
 64009 
       
 64010 2007-01-08  David Hyatt  <hyatt@apple.com>
       
 64011 
       
 64012         Add support for all of the CSS3 multi-column properties in preparation for implementing the
       
 64013         feature.
       
 64014 
       
 64015         Reviewed by eric
       
 64016 
       
 64017         * css/CSSComputedStyleDeclaration.cpp:
       
 64018         (WebCore::):
       
 64019         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 64020         * css/CSSMutableStyleDeclaration.cpp:
       
 64021         (WebCore::):
       
 64022         * css/CSSPropertyNames.in:
       
 64023         * css/cssparser.cpp:
       
 64024         (WebCore::CSSParser::parseValue):
       
 64025         * css/cssstyleselector.cpp:
       
 64026         (WebCore::CSSStyleSelector::applyProperty):
       
 64027         * rendering/RenderStyle.cpp:
       
 64028         (WebCore::StyleMultiColData::StyleMultiColData):
       
 64029         (WebCore::StyleMultiColData::operator==):
       
 64030         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
       
 64031         (WebCore::StyleRareNonInheritedData::operator==):
       
 64032         (WebCore::RenderStyle::RenderStyle):
       
 64033         (WebCore::RenderStyle::diff):
       
 64034         * rendering/RenderStyle.h:
       
 64035         (WebCore::StyleMultiColData::operator!=):
       
 64036         (WebCore::StyleMultiColData::ruleWidth):
       
 64037         (WebCore::RenderStyle::columnWidth):
       
 64038         (WebCore::RenderStyle::hasAutoColumnWidth):
       
 64039         (WebCore::RenderStyle::columnCount):
       
 64040         (WebCore::RenderStyle::columnGap):
       
 64041         (WebCore::RenderStyle::hasAutoColumnGap):
       
 64042         (WebCore::RenderStyle::columnRuleColor):
       
 64043         (WebCore::RenderStyle::columnRuleStyle):
       
 64044         (WebCore::RenderStyle::columnRuleWidth):
       
 64045         (WebCore::RenderStyle::columnBreakBefore):
       
 64046         (WebCore::RenderStyle::columnBreakInside):
       
 64047         (WebCore::RenderStyle::columnBreakAfter):
       
 64048         (WebCore::RenderStyle::setColumnWidth):
       
 64049         (WebCore::RenderStyle::setHasAutoColumnWidth):
       
 64050         (WebCore::RenderStyle::setColumnCount):
       
 64051         (WebCore::RenderStyle::setColumnGap):
       
 64052         (WebCore::RenderStyle::setHasAutoColumnGap):
       
 64053         (WebCore::RenderStyle::setColumnRuleColor):
       
 64054         (WebCore::RenderStyle::setColumnRuleStyle):
       
 64055         (WebCore::RenderStyle::setColumnRuleWidth):
       
 64056         (WebCore::RenderStyle::resetColumnRule):
       
 64057         (WebCore::RenderStyle::setColumnBreakBefore):
       
 64058         (WebCore::RenderStyle::setColumnBreakInside):
       
 64059         (WebCore::RenderStyle::setColumnBreakAfter):
       
 64060         (WebCore::RenderStyle::initialColumnCount):
       
 64061         (WebCore::RenderStyle::initialColumnWidth):
       
 64062 
       
 64063 2007-01-07  Rob Buis  <buis@kde.org>
       
 64064 
       
 64065         Reviewed by Eric.
       
 64066 
       
 64067         http://bugs.webkit.org/show_bug.cgi?id=10587
       
 64068         pointer-events is not implemented for RenderSVGImage or RenderSVGText
       
 64069 
       
 64070         Implement pointer-events for raster images and svg text.
       
 64071 
       
 64072         * WebCore.xcodeproj/project.pbxproj:
       
 64073         * ksvg2/misc/PointerEventsHitRules.cpp: Added.
       
 64074         (WebCore::PointerEventsHitRules::PointerEventsHitRules):
       
 64075         * ksvg2/misc/PointerEventsHitRules.h: Added.
       
 64076         (WebCore::PointerEventsHitRules::):
       
 64077         * rendering/RenderPath.cpp:
       
 64078         (WebCore::RenderPath::nodeAtPoint):
       
 64079         * rendering/RenderPath.h:
       
 64080         * rendering/RenderSVGImage.cpp:
       
 64081         (WebCore::RenderSVGImage::nodeAtPoint):
       
 64082         * rendering/RenderSVGImage.h:
       
 64083         * rendering/RenderSVGText.cpp:
       
 64084         (WebCore::RenderSVGText::nodeAtPoint):
       
 64085         * rendering/RenderSVGText.h:
       
 64086 
       
 64087 2007-01-07  David Hyatt  <hyatt@apple.com>
       
 64088 
       
 64089         Fix a regression where border-radius was not clipping the background when border was set to none.
       
 64090         Fix multi-line inline flow painting to properly apply border-radius to the background only at the
       
 64091         beginning of the first line and end of the last line.
       
 64092 
       
 64093         Reviewed by eric
       
 64094 
       
 64095         * rendering/InlineFlowBox.cpp:
       
 64096         (WebCore::InlineFlowBox::paintBackground):
       
 64097         * rendering/RenderBox.cpp:
       
 64098         (WebCore::RenderBox::paintBackground):
       
 64099         (WebCore::RenderBox::paintBackgroundExtended):
       
 64100         * rendering/RenderBox.h:
       
 64101         * rendering/RenderObject.h:
       
 64102         (WebCore::RenderObject::paintBackgroundExtended):
       
 64103 
       
 64104 2007-01-07  David Hyatt  <hyatt@apple.com>
       
 64105 
       
 64106         Add support for the CSS3 box-shadow property.
       
 64107 
       
 64108         Reviewed by olliej
       
 64109 
       
 64110         fast/box-shadow/ contains the tests for this feature.
       
 64111 
       
 64112         * platform/graphics/GraphicsContext.cpp:
       
 64113         (WebCore::GraphicsContext::clipOutRoundedRect):
       
 64114         * platform/graphics/GraphicsContext.h:
       
 64115         * platform/graphics/cg/GraphicsContextCG.cpp:
       
 64116         (WebCore::GraphicsContext::fillRoundedRect):
       
 64117         (WebCore::GraphicsContext::clipOut):
       
 64118         (WebCore::GraphicsContext::clipOutEllipseInRect):
       
 64119         * platform/graphics/qt/GraphicsContextQt.cpp:
       
 64120         (WebCore::GraphicsContext::fillRoundedRect):
       
 64121         (WebCore::GraphicsContext::clipOut):
       
 64122         (WebCore::GraphicsContext::clipOutEllipseInRect):
       
 64123         * rendering/InlineFlowBox.cpp:
       
 64124         (WebCore::InlineFlowBox::paint):
       
 64125         (WebCore::InlineFlowBox::paintBoxShadow):
       
 64126         (WebCore::InlineFlowBox::paintBoxDecorations):
       
 64127         (WebCore::shouldDrawTextDecoration):
       
 64128         (WebCore::InlineFlowBox::paintTextDecorations):
       
 64129         * rendering/InlineFlowBox.h:
       
 64130         * rendering/InlineRunBox.h:
       
 64131         (WebCore::InlineRunBox::paintBoxDecorations):
       
 64132         (WebCore::InlineRunBox::paintTextDecorations):
       
 64133         * rendering/RenderBlock.cpp:
       
 64134         (WebCore::RenderBlock::paintObject):
       
 64135         * rendering/RenderBox.cpp:
       
 64136         (WebCore::RenderBox::setStyle):
       
 64137         (WebCore::RenderBox::paintBoxDecorations):
       
 64138         (WebCore::RenderBox::paintBackgroundExtended):
       
 64139         * rendering/RenderFieldset.cpp:
       
 64140         (WebCore::RenderFieldset::paintBoxDecorations):
       
 64141         * rendering/RenderHTMLCanvas.cpp:
       
 64142         (WebCore::RenderHTMLCanvas::paint):
       
 64143         * rendering/RenderImage.cpp:
       
 64144         (WebCore::RenderImage::paint):
       
 64145         * rendering/RenderImage.h:
       
 64146         * rendering/RenderListMarker.cpp:
       
 64147         (WebCore::RenderListMarker::paint):
       
 64148         * rendering/RenderObject.cpp:
       
 64149         (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
       
 64150         (WebCore::RenderObject::paintBoxShadow):
       
 64151         (WebCore::RenderObject::dump):
       
 64152         (WebCore::RenderObject::setStyle):
       
 64153         * rendering/RenderObject.h:
       
 64154         (WebCore::RenderObject::hasBoxDecorations):
       
 64155         (WebCore::RenderObject::setHasBoxDecorations):
       
 64156         * rendering/RenderSVGContainer.cpp:
       
 64157         (WebCore::RenderSVGContainer::paint):
       
 64158         * rendering/RenderTable.cpp:
       
 64159         (WebCore::RenderTable::paint):
       
 64160         (WebCore::RenderTable::paintBoxDecorations):
       
 64161         * rendering/RenderTableCell.cpp:
       
 64162         (WebCore::RenderTableCell::RenderTableCell):
       
 64163         (WebCore::RenderTableCell::setStyle):
       
 64164         (WebCore::RenderTableCell::paintBoxDecorations):
       
 64165         * rendering/RenderWidget.cpp:
       
 64166         (WebCore::RenderWidget::paint):
       
 64167 
       
 64168 2007-01-07  Rob Buis  <buis@kde.org>
       
 64169 
       
 64170         Reviewed by weinig.
       
 64171 
       
 64172         http://bugs.webkit.org/show_bug.cgi?id=10362
       
 64173         SVG needs to support SVGError events and some form of "error state"
       
 64174 
       
 64175         Report SVG warnings and errors on (JS) console.
       
 64176         Expose line and column number getters in Tokenizer in
       
 64177         order to display them with the error message.
       
 64178 
       
 64179         * dom/XMLTokenizer.cpp:
       
 64180         * dom/XMLTokenizer.h:
       
 64181         (WebCore::Tokenizer::lineNumber):
       
 64182         (WebCore::Tokenizer::columnNumber):
       
 64183         * html/HTMLTokenizer.h:
       
 64184         (WebCore::HTMLTokenizer::lineNumber):
       
 64185         (WebCore::HTMLTokenizer::columnNumber):
       
 64186         * ksvg2/misc/SVGDocumentExtensions.cpp:
       
 64187         (WebCore::SVGDocumentExtensions::reportWarning):
       
 64188         (WebCore::SVGDocumentExtensions::reportError):
       
 64189         * ksvg2/misc/SVGDocumentExtensions.h:
       
 64190         * ksvg2/svg/SVGCircleElement.cpp:
       
 64191         (WebCore::SVGCircleElement::parseMappedAttribute):
       
 64192         * ksvg2/svg/SVGElement.h:
       
 64193         * ksvg2/svg/SVGEllipseElement.cpp:
       
 64194         (WebCore::SVGEllipseElement::parseMappedAttribute):
       
 64195         * ksvg2/svg/SVGFitToViewBox.cpp:
       
 64196         (WebCore::SVGFitToViewBox::parseViewBox):
       
 64197         * ksvg2/svg/SVGFitToViewBox.h:
       
 64198         * ksvg2/svg/SVGImageElement.cpp:
       
 64199         (WebCore::SVGImageElement::parseMappedAttribute):
       
 64200         * ksvg2/svg/SVGParserUtilities.cpp:
       
 64201         (WebCore::SVGPolyParser::parsePoints):
       
 64202         * ksvg2/svg/SVGParserUtilities.h:
       
 64203         * ksvg2/svg/SVGPathElement.cpp:
       
 64204         (WebCore::SVGPathElement::parseMappedAttribute):
       
 64205         * ksvg2/svg/SVGPatternElement.cpp:
       
 64206         (WebCore::SVGPatternElement::parseMappedAttribute):
       
 64207         * ksvg2/svg/SVGPolyElement.cpp:
       
 64208         (WebCore::SVGPolyElement::parseMappedAttribute):
       
 64209         * ksvg2/svg/SVGRadialGradientElement.cpp:
       
 64210         (WebCore::SVGRadialGradientElement::parseMappedAttribute):
       
 64211         * ksvg2/svg/SVGRectElement.cpp:
       
 64212         (WebCore::SVGRectElement::parseMappedAttribute):
       
 64213         * ksvg2/svg/SVGSVGElement.cpp:
       
 64214         (WebCore::SVGSVGElement::parseMappedAttribute):
       
 64215         * ksvg2/svg/SVGTextContentElement.cpp:
       
 64216         (WebCore::SVGTextContentElement::parseMappedAttribute):
       
 64217         * ksvg2/svg/SVGUseElement.cpp:
       
 64218         (WebCore::SVGUseElement::parseMappedAttribute):
       
 64219 
       
 64220 2007-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
       
 64221 
       
 64222         Reviewed by Sam.
       
 64223 
       
 64224         Cleanup code & fix InlineBox positioning when text-anchor is used.
       
 64225 
       
 64226         * rendering/RenderSVGText.cpp: Cleanup code.
       
 64227         (WebCore::RenderSVGText::nodeAtPoint):
       
 64228         (WebCore::RenderSVGText::absoluteRects):
       
 64229         (WebCore::RenderSVGText::paint):
       
 64230         * rendering/RenderText.cpp: Remove unused function posOfChar()
       
 64231         * rendering/RenderText.h: Ditto.
       
 64232         * rendering/SVGInlineFlowBox.cpp:
       
 64233         (WebCore::translateBox):
       
 64234         (WebCore::placePositionedBoxesHorizontally):
       
 64235 
       
 64236 2007-01-06  George Staikos  <staikos@kde.org>
       
 64237 
       
 64238         Reviewed by Brady.
       
 64239 
       
 64240         Make the Qt build work.... again.
       
 64241 
       
 64242         * WebCore.pro:
       
 64243         * loader/FrameLoader.cpp:
       
 64244         (WebCore::FrameLoader::requestFromDelegate):
       
 64245         * loader/qt/DocumentLoaderQt.cpp:
       
 64246         * loader/qt/FrameLoaderQt.cpp:
       
 64247         * loader/qt/MainResourceLoaderQt.cpp: Added.
       
 64248         (WebCore::MainResourceLoader::create):
       
 64249         * loader/qt/ResourceLoaderQt.cpp:
       
 64250         (WebCore::ResourceLoader::load):
       
 64251         (WebCore::ResourceLoader::cancel):
       
 64252         (WebCore::ResourceLoader::releaseResources):
       
 64253         (WebCore::ResourceLoader::addData):
       
 64254         * platform/network/qt/ResourceHandleQt.cpp:
       
 64255         (WebCore::ResourceHandle::supportsBufferedData):
       
 64256         (WebCore::ResourceHandle::bufferedData):
       
 64257         (WebCore::ResourceHandle::loadResourceSynchronously):
       
 64258         * platform/qt/LoaderFunctionsQt.cpp:
       
 64259         * platform/qt/TemporaryLinkStubs.cpp: implemented some functions
       
 64260         (WebCore::screenDepth):
       
 64261         (WebCore::screenDepthPerComponent):
       
 64262         (WebCore::screenIsMonochrome):
       
 64263         (WebCore::screenRect):
       
 64264         (WebCore::screenAvailableRect):
       
 64265 
       
 64266 2007-01-07  Mitz Pettel  <mitz@webkit.org>
       
 64267 
       
 64268         Reviewed by Mark Rowe.
       
 64269 
       
 64270         - fix http://bugs.webkit.org/show_bug.cgi?id=11133
       
 64271 
       
 64272         Test: fast/forms/listbox-clip.html
       
 64273 
       
 64274         * platform/mac/PlatformScrollBarMac.mm:
       
 64275         (-[WebCoreScrollBar initWithPlatformScrollbar:]): Get the correct scrollbar
       
 64276         width/height based on control size.
       
 64277         * rendering/RenderListBox.cpp:
       
 64278         Renamed optionsSpacingLeft to optionsSpacingHorizontal since it is applied
       
 64279         on both sides.
       
 64280         (WebCore::RenderListBox::calcMinMaxWidth): Account for optionsSpacingHorizontal.
       
 64281         Not including the spacing before went unnoticed since the scrollbar was lying
       
 64282         about its width by exactly the same amount.
       
 64283         (WebCore::RenderListBox::paintObject): Clip out the scrollbar.
       
 64284         (WebCore::RenderListBox::paintItemForeground): Changed for the rename.
       
 64285 
       
 64286 2007-01-07  Mitz Pettel  <mitz@webkit.org>
       
 64287 
       
 64288         Reviewed by Hyatt.
       
 64289 
       
 64290         - fix http://bugs.webkit.org/show_bug.cgi?id=11935
       
 64291           REGRESSION: Changing the overflow style dynamically does not force repaint
       
 64292 
       
 64293         Test: fast/repaint/erase-overflow.html
       
 64294 
       
 64295         * rendering/RenderBox.cpp:
       
 64296         (WebCore::RenderBox::setStyle): Added a repaint before changing hasOverflowClip
       
 64297         to true, to ensure that the current overflow is erased.
       
 64298 
       
 64299 2007-01-07  Graham Dennis  <graham.dennis@gmail.com>
       
 64300 
       
 64301         Reviewed by Darin.
       
 64302 
       
 64303         Patch for http://bugs.webkit.org/show_bug.cgi?id=12106
       
 64304         Changed URL from WebResourceLoadDelegate's webView:resource:willSendRequest:... is ignored
       
 64305 
       
 64306         * loader/mac/SubresourceLoaderMac.mm:
       
 64307         (WebCore::SubresourceLoader::willSendRequest): Use m_originalURL instead of request().url()
       
 64308         as m_request is not set until the end of ResourceLoader::willSendRequest. Also, ensure that
       
 64309         the request is updated if the frame's client changes it, and that the SubresourceLoader's client
       
 64310         gets the new request and not the old one. 
       
 64311 
       
 64312 2007-01-07  Alexey Proskuryakov  <ap@webkit.org>
       
 64313 
       
 64314         Reviewed by Darin.
       
 64315 
       
 64316         http://bugs.webkit.org/show_bug.cgi?id=10313
       
 64317         xsl:import doesn't work in stylesheets loaded via XMLHttpRequest
       
 64318 
       
 64319         This is a partial fix that makes a couple more steps towards fixing the problem.
       
 64320 
       
 64321         Test: fast/xsl/transform-xhr-doc.xhtml
       
 64322 
       
 64323         * xml/XSLTProcessor.cpp:
       
 64324         (WebCore::xsltStylesheetPointer): Pass an URL for the stylesheet. I'm not sure why this constructor even needs it, 
       
 64325         given that it has a Node, but this is a small modifications that makes XSLImportRule try to load from a correct URL.
       
 64326         (WebCore::XSLTProcessor::transformToString): Fix the crash for real this time.
       
 64327 
       
 64328 2007-01-06  Rob Buis  <buis@kde.org>
       
 64329 
       
 64330         Reviewed by Darin.
       
 64331 
       
 64332         http://bugs.webkit.org/show_bug.cgi?id=12125
       
 64333         overflow attribute of the symbol element not respected
       
 64334 
       
 64335         Copy the attribute map to the cloned node so the overflow on
       
 64336         the symbol is respected.
       
 64337 
       
 64338         * ksvg2/svg/SVGUseElement.cpp:
       
 64339         (WebCore::SVGUseElement::closeRenderer):
       
 64340 
       
 64341 2007-01-06  Eric Seidel  <eric@webkit.org>
       
 64342 
       
 64343         Reviewed and significantly tweaked by Darin.
       
 64344 
       
 64345         - fix http://bugs.webkit.org/show_bug.cgi?id=12103
       
 64346           LEAK: Fix the leaking ImageBuffer buffers on TOT
       
 64347 
       
 64348         * ksvg2/svg/SVGMaskElement.h:
       
 64349         * ksvg2/svg/SVGMaskElement.cpp:
       
 64350         (WebCore::SVGMaskElement::drawMaskerContent):
       
 64351         Changed to return auto_ptr since it returns a newly-created ImageBuffer.
       
 64352 
       
 64353         * ksvg2/svg/SVGPatternElement.cpp:
       
 64354         (WebCore::SVGPatternElement::buildPattern):
       
 64355         Changed to use auto_ptr since ImageBuffer::create now returns one.
       
 64356 
       
 64357         * platform/graphics/GraphicsContext.h: Removed the include of ImageBuffer.h,
       
 64358         which was never needed, and the declaration of createImageBuffer, which is
       
 64359         now a class member function of ImageBuffer.
       
 64360 
       
 64361         * platform/graphics/ImageBuffer.h: Replaced the constructor with a create
       
 64362         function. Added a comment about the need to move renderSubtreeToImage
       
 64363         elsewhere. Added an m_data member to store the data so it can be deleted
       
 64364         when the object is done, made the m_size member non-platform-specific.
       
 64365         Added a private constructor for use to create the CG version.
       
 64366 
       
 64367         * platform/graphics/cg/GraphicsContextCG.cpp: Removed
       
 64368         GraphicsContext::createImageBuffer.
       
 64369 
       
 64370         * platform/graphics/cg/ImageBufferCG.cpp:
       
 64371         (WebCore::ImageBuffer::create): Added. Replaces the old
       
 64372         GraphicsContext::createImageBuffer function.
       
 64373         (WebCore::ImageBuffer::ImageBuffer): Added m_data and m_context.
       
 64374         (WebCore::ImageBuffer::~ImageBuffer): Added a fastFree of the data and got
       
 64375         rid of the unneeded null check before calling CGImageRelease.
       
 64376 
       
 64377         * platform/graphics/svg/SVGPaintServerGradient.h: Removed the include of
       
 64378         ImageBuffer.h and declared the ImageBuffer class instead.
       
 64379 
       
 64380         * platform/graphics/svg/SVGPaintServerPattern.h: Removed the include of
       
 64381         ImageBuffer.h and declared the ImageBuffer class instead, and changed setTile
       
 64382         to take an auto_ptr since it takes ownership of the ImageBuffer.
       
 64383         * platform/graphics/svg/SVGPaintServerPattern.cpp:
       
 64384         (WebCore::SVGPaintServerPattern::setTile): Ditto.
       
 64385 
       
 64386         * platform/graphics/svg/SVGResourceMasker.h: Removed the include of
       
 64387         ImageBuffer.h and declared the ImageBuffer class instead, and changed setMask
       
 64388         to take an auto_ptr since it takes ownership of the ImageBuffer.
       
 64389         * platform/graphics/svg/SVGResourceMasker.cpp:
       
 64390         (WebCore::SVGResourceMasker::setMask): Ditto.
       
 64391 
       
 64392         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
       
 64393         (WebCore::SVGPaintServerGradient::setup): Updated to use auto_ptr.
       
 64394 
       
 64395         * platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp: Updated includes.
       
 64396 
       
 64397         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
       
 64398         (WebCore::SVGResourceMasker::applyMask): Updated to use auto_ptr.
       
 64399 
       
 64400         - other changes
       
 64401 
       
 64402         * ksvg2/svg/SVGAnimateTransformElement.cpp:
       
 64403         (WebCore::SVGAnimateTransformElement::handleStartCondition):
       
 64404         Remove unused variables.
       
 64405 
       
 64406 2007-01-06  Mitz Pettel  <mitz@webkit.org>
       
 64407 
       
 64408         Reviewed by Maciej.
       
 64409 
       
 64410         - fix http://bugs.webkit.org/show_bug.cgi?id=12136
       
 64411           REGRESSION: Counters-related leaks
       
 64412 
       
 64413         * rendering/RenderCounter.cpp:
       
 64414         (WebCore::destroyCounterNodeChildren): Delete the child counter nodes.
       
 64415 
       
 64416 2007-01-05  Adele Peterson  <adele@apple.com>
       
 64417 
       
 64418         Release build fix.
       
 64419 
       
 64420         * rendering/RenderListItem.cpp: (WebCore::RenderListItem::explicitValueChanged): Initialize listRenderer.
       
 64421 
       
 64422 2007-01-05  Darin Adler  <darin@apple.com>
       
 64423 
       
 64424         Reviewed by Hyatt.
       
 64425 
       
 64426         - eliminated use of DeprecatedString for list item markers
       
 64427         - eliminated use of DeprecatedValueList for border style collapsing
       
 64428         - made many members private instead of protected or public
       
 64429 
       
 64430         - reworked counter implementation to fix most of the CSS 2.1 counter tests;
       
 64431             made CounterNode be a simple non-polymorphic class, moved most counter-
       
 64432             specific code out of RenderObject into RenderCounter, changed the data
       
 64433             structure in RenderStyle to be more speed-efficient but less space-
       
 64434             efficient for nodes with counter styles
       
 64435         - fixed http://bugs.webkit.org/show_bug.cgi?id=11557
       
 64436 
       
 64437         Tests: css2.1
       
 64438 
       
 64439         - fixed a bug where counter text did not have text transform or text security
       
 64440           applied to it
       
 64441 
       
 64442         Test: fast/css/counters/counter-text-security.html
       
 64443         Test: fast/css/counters/counter-text-transform.html
       
 64444 
       
 64445         - improved handling of CSS content property values with data of the wrong
       
 64446           type; this probably needs a bit more refinement
       
 64447 
       
 64448         Test: fast/css-generated-content/reset-content-to-initial-expected.txt
       
 64449 
       
 64450         - fixed a bug where removing the value attribute from an HTMLLIElement would
       
 64451           set the list item's value to 0 instead of restoring it to normal
       
 64452 
       
 64453         Test: fast/lists/li-values.html
       
 64454 
       
 64455         - fixed a bug where changing the text security style from one style to another
       
 64456           would not change the displayed text
       
 64457 
       
 64458         Test: fast/css/text-security.html
       
 64459 
       
 64460         - fixed some problems handling long sequences of counter-related styles;
       
 64461           still needs more work and some super-large test cases to check if
       
 64462           recursive algorithms for these that will overflow stack remain
       
 64463 
       
 64464         - added support for list styles decimal-leading-zero, hiragana, hirigana-iroha,
       
 64465           katakana, katakana-iroha, cjk-ideographic, armenian, and georgian
       
 64466 
       
 64467         Test: fast/lists/decimal-leading-zero.html
       
 64468 
       
 64469         - minor tweaks and bug fixes for other list styles, including range checking
       
 64470 
       
 64471         * WebCore.exp: Updated for RenderListItem change.
       
 64472 
       
 64473         * bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]): Updated to use
       
 64474         String instead of DeprecatedString.
       
 64475 
       
 64476         * css/CSSComputedStyleDeclaration.cpp:
       
 64477         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Removed
       
 64478         implementation for counter styles for now. We should probably restore it
       
 64479         later, but we need to make sure the returned list is separate from the
       
 64480         original list in the DOM -- modifying the list should not change the element
       
 64481         it was computed from.
       
 64482 
       
 64483         * css/Counter.h: Removed unneeded empty constructor and destructor.
       
 64484 
       
 64485         * css/cssstyleselector.cpp:
       
 64486         (WebCore::applyCounterList): Added. Stores counter directives in hash tables
       
 64487         that should allow us to efficiently implement dynamic counter changes. Full
       
 64488         support will have to wait for a future check-in.
       
 64489         (WebCore::CSSStyleSelector::applyProperty): Changed counter properties to
       
 64490         call applyCounterList. Reformatted the code to parse the content property for
       
 64491         changes to RenderStyle and to handle the case where some the items in the
       
 64492         content list don't generate any content.
       
 64493 
       
 64494         * editing/visible_units.cpp:
       
 64495         * rendering/RenderBox.cpp:
       
 64496         * rendering/RenderFlexibleBox.cpp:
       
 64497         * rendering/RenderFlow.cpp:
       
 64498         * rendering/RenderSlider.cpp:
       
 64499         Added includes needed because of header changes.
       
 64500 
       
 64501         * html/HTMLLIElement.H: Removed unneeded m_isValued.
       
 64502         * html/HTMLLIElement.cpp:
       
 64503         (WebCore::HTMLLIElement::parseMappedAttribute): To match test results seen
       
 64504         in WinIE, ignore values that are 0 or negative, and use new functions in
       
 64505         RenderListItem to communicate the lack of a valid value.
       
 64506         (WebCore::HTMLLIElement::attach): More of the same.
       
 64507 
       
 64508         * rendering/CounterNode.h: Made CounterNode be a non-polymorphic class,
       
 64509         removing all the subclasses. Merged in CounterResetNode. Removed
       
 64510         m_total from CounterResetNode, because it isn't needed for any of
       
 64511         the styles (decimal-leading-zero always uses two digits). Removed
       
 64512         m_hasSeparator and m_willNeedLayout since they aren't needed any more.
       
 64513         Renamed m_count to m_countInParent for clarify, and named the list
       
 64514         links the same as their associated functions. Removed many functions
       
 64515         as well.
       
 64516         * rendering/CounterNode.cpp:
       
 64517         (WebCore::CounterNode::CounterNode): Added new fields.
       
 64518         (WebCore::CounterNode::computeCountInParent): Added. Used by recount.
       
 64519         (WebCore::CounterNode::recount): Simplified by removing unused parameter and the
       
 64520         "get next" idiom. Changed to be iterative instead of recursive so we can handle
       
 64521         arbitrarily long lists.
       
 64522         (WebCore::CounterNode::insertAfter): Moved here from CounterResetNode. Updated
       
 64523         for field name changes. Corrected rule for when to recount.
       
 64524         (WebCore::CounterNode::removeChild): Moved here from CounterResetNode. Changed
       
 64525         to only work on nodes without children. Corrected rule for when to recount.
       
 64526         (WebCore::nextInPreOrderAfterChildren): Added. For debugging only.
       
 64527         (WebCore::nextInPreOrder): Ditto.
       
 64528         (WebCore::showTreeAndMark): Ditto.
       
 64529         (showTree): Ditto.
       
 64530 
       
 64531         * rendering/CounterListItem.h:
       
 64532         * rendering/CounterResetNode.h:
       
 64533         * rendering/CounterResetNode.cpp:
       
 64534         Marked ready to remove. I'll do the remove in a separate patch, since I have
       
 64535         to update a lot of different make files when I do.
       
 64536 
       
 64537         * rendering/ListMarkerBox.cpp: (WebCore::ListMarkerBox::isText): Changed for the
       
 64538         change to RenderListMarker.
       
 64539 
       
 64540         * rendering/RenderBlock.cpp:
       
 64541         (WebCore::RenderBlock::addChildToFlow): Changed to use functions instead of
       
 64542         direct field access so the fields can be private and we don't need to be friends.
       
 64543         (WebCore::RenderBlock::getBaselineOfFirstLineBox): Ditto.
       
 64544         (WebCore::RenderBlock::getBaselineOfLastLineBox): Ditto.
       
 64545         * rendering/RenderBlock.h:
       
 64546         (WebCore::RenderBlock::initMaxMarginValues): Ditto.
       
 64547         (WebCore::RenderBlock::firstRootBox): Ditto.
       
 64548         (WebCore::RenderBlock::lastRootBox): Ditto.
       
 64549         * rendering/RenderBox.h:
       
 64550         (WebCore::RenderBox::setWidth): Ditto.
       
 64551         (WebCore::RenderBox::setHeight): Ditto.
       
 64552         * rendering/RenderButton.cpp:
       
 64553         (WebCore::RenderButton::addChild): Ditto.
       
 64554         * rendering/bidi.cpp:
       
 64555         (WebCore::RenderBlock::determineStartPosition): Ditto.
       
 64556 
       
 64557         * rendering/RenderContainer.h: Renamed m_first and m_last to m_firstChild
       
 64558         and m_lastChild. Made them private instead of proected. Removed the
       
 64559         setFirstChild and setLastChild functions.
       
 64560         * rendering/RenderContainer.cpp:
       
 64561         (WebCore::RenderContainer::RenderContainer): Updated for field name change.
       
 64562         Changed all calls to get at fields directly instead of using functions.
       
 64563         (WebCore::RenderContainer::destroyLeftoverChildren): Ditto.
       
 64564         (WebCore::updateListMarkerNumbers): Updated for RenderListItem change.
       
 64565         (WebCore::RenderContainer::addChild): Changed to get at fields directly
       
 64566         instead of using functions. Also used release() since RenderText::setText
       
 64567         now takes PassRefPtr.
       
 64568         (WebCore::RenderContainer::removeChildNode): Changed to get at fields directly
       
 64569         instead of using functions.
       
 64570         (WebCore::RenderContainer::updatePseudoChildForObject): Create the anonymous
       
 64571         box only if at least one of of the items in the content list actually
       
 64572         generates content. Since a RenderCounter is a RenderText, don't bother making
       
 64573         a new style for it -- it just shares the style with its parent. Changed code
       
 64574         to use RenderImage::setCachedImage() instead of of setContentObject().
       
 64575         Added a call to setIsAnonymousImage() here, which was the only special thing
       
 64576         that setContentObject() used to do. Pass a reference to the counter to the
       
 64577         RenderCounter rather than a pointer. Pass document() as the node instead of
       
 64578         passing the element to RenderCounter, which makes it anonymous automatically,
       
 64579         and removed the setIsAnonymous call.
       
 64580         (WebCore::RenderContainer::appendChildNode): Chagned to get at fields directly
       
 64581         instead of using functions.
       
 64582         (WebCore::RenderContainer::insertChildNode): Ditto.
       
 64583         (WebCore::RenderContainer::layout): Ditto.
       
 64584         (WebCore::RenderContainer::removeLeftoverAnonymousBoxes): Ditto.
       
 64585         (WebCore::RenderContainer::positionForCoordinates): Ditto.
       
 64586         (WebCore::RenderContainer::addLineBoxRects): Ditto.
       
 64587 
       
 64588         * rendering/RenderCounter.h: Removed unneeded layout override, never called on a
       
 64589         text node. Added override of originalString. Replaced CounterData* with a copy of
       
 64590         the CounterContent -- it's two atomic strings and an integer so it's efficient
       
 64591         enough to store all three in the render object, and this eliminates the lifetime
       
 64592         problems we could have if we used a pointer.
       
 64593         * rendering/RenderCounter.cpp: Removed duplicate copy of list marker code.
       
 64594         (WebCore::counterMaps): Moved these maps here from RenderObject.
       
 64595         (WebCore::previousSiblingOrParent): Added.
       
 64596         (WebCore::lastDescendant): Added.
       
 64597         (WebCore::previousInPreOrder): Added.
       
 64598         (WebCore::planCounter): Added.
       
 64599         (WebCore::findPlaceForCounter): Added.
       
 64600         (WebCore::counter): New name of function that was named RenderObject::findCounter.
       
 64601         Also uses a new algorithm that passes all the CSS 2.1 tests.
       
 64602         (WebCore::RenderCounter::RenderCounter): Changed to take a Document* instead of a
       
 64603         Node*, since at the moment counters are always anonymous.
       
 64604         (WebCore::RenderCounter::originalString): Added. This overrides the originalString
       
 64605         in the RenderText base class so that any text transforms will use the counter's
       
 64606         value. This code was previously in calcMinMaxWidth.
       
 64607         (WebCore::RenderCounter::calcMinMaxWidth): Changed to call setInternalString and
       
 64608         pass originalString -- this uses the counter's value from the counter tree.
       
 64609         (WebCore::destroyCounterNodeChildren): Added.
       
 64610         (WebCore::RenderCounter::destroyCounterNodes): Added. Called as needed from
       
 64611         RenderObject::destroy for objects that have counter nodes.
       
 64612 
       
 64613         * rendering/RenderFlow.h: Made m_continuation private instead of protected.
       
 64614 
       
 64615         * rendering/RenderImage.h: Removed unneeded includes, and unnecessary element()
       
 64616         function that casts to HTMLElement*. Made image() protected, and made the two
       
 64617         calcAspectRatio functions private. Removed setContentObject(). Renamed the
       
 64618         errorOccured() function to isErrorImage() and made it private.
       
 64619         * rendering/RenderImage.cpp:
       
 64620         (WebCore::RenderImage::RenderImage): Removed initialization of removed
       
 64621         m_selectionState field.
       
 64622         (WebCore::RenderImage::setCachedImage): Rearrange code so it won't try to
       
 64623         call isErrorImage() on a null image.
       
 64624         (WebCore::RenderImage::paint): Updated for name change.
       
 64625 
       
 64626         * rendering/RenderListBox.h: Removed unneeded forward declarations.
       
 64627 
       
 64628         * rendering/RenderListItem.h:
       
 64629         Renamed markerStringValue() to markerText() and made it return a String instead of
       
 64630         a DeprecatedString. Renamed m_prededfVal to m_explicitValue. Added booleans named
       
 64631         m_hasExplicitValue and m_isValueUpToDate and marked m_value mutable so it can be
       
 64632         computed in const member functions.
       
 64633         (WebCore::RenderListItem::value): Changed to update value on demand at the time
       
 64634         you ask for it.
       
 64635         (WebCore::RenderListItem::hasExplicitValue): Added. Use instead of magic -1 value
       
 64636         to indicate that the item does or does not have an explicit value.
       
 64637         (WebCore::RenderListItem::explicitValue): Added.
       
 64638         (WebCore::RenderListItem::setExplicitValue): Added.
       
 64639         (WebCore::RenderListItem::clearExplicitValue): Added.
       
 64640         * rendering/RenderListItem.cpp:
       
 64641         (WebCore::RenderListItem::RenderListItem): Updated to not use magic -1 values.
       
 64642         (WebCore::RenderListItem::setStyle): Removed call to RenderListMarker::setListItem
       
 64643         since it's not needed any more, and instead pass the list item to the constructor.
       
 64644         (WebCore::previousListItem): Made parameter const.
       
 64645         (WebCore::RenderListItem::calcValue): Restructed the function a bit.
       
 64646         (WebCore::RenderListItem::updateValueNow): Added. Calls calcValue.
       
 64647         (WebCore::RenderListItem::updateValue): Added. New name for resetValue(). Unlike
       
 64648         the old version, this no longer calculates the value until it's asked-for later.
       
 64649         (WebCore::RenderListItem::markerText): Changed to return String rather than a
       
 64650         DeprecatedString and to return a null string rather than empty string when there
       
 64651         is no marker.
       
 64652 
       
 64653         * rendering/RenderListMarker.h: Added listMarkerText function -- common code shared
       
 64654         with anyone who needs to convert a value into text given a list style.
       
 64655         Changed constructor to take a RenderListItem and figure out the document from that.
       
 64656         Added isImage() and isText() functions and removed listImage() function. Changed the
       
 64657         type of the text() function from DeprecatedString to String. Removed the listItem()
       
 64658         and seListeItem() functions. Made the getRelativeMarkerRect() function private.
       
 64659         Renamed m_item to m_text and chagned it from DeprecatedString to String. Renamed
       
 64660         m_listImage to m_image.
       
 64661         * rendering/RenderListMarker.cpp:
       
 64662         (WebCore::toRoman): Added range checking to fix buffer overrun for large or negative
       
 64663         numbers. Rewrote to use a local UChar array and String rather than prepending to a
       
 64664         DeprecatedString.
       
 64665         (WebCore::toAlphabetic): Replaces toLetterString, and is more flexible since it takes
       
 64666         an alphabet array. Changed to match CSS 3 specification by using decimal numbering for
       
 64667         0 and negative numbers. Rewrote to use a local UChar array and String rather than
       
 64668         prepending to a DeprecatedString.
       
 64669         (WebCore::toHebrewUnder1000): Added. Helper function for Hebrew numbers so we can
       
 64670         handle numbers up to a million.
       
 64671         (WebCore::toHebrew): Changed to use toHebrewUnder1000, added a special case for
       
 64672         zero, negative, and too-large numbers.
       
 64673         (WebCore::toArmenianUnder10000): Added. Used by toArmenian.
       
 64674         (WebCore::toArmenian): Added.
       
 64675         (WebCore::toGeorgian): Added.
       
 64676         (WebCore::toCJKIdeographic): Added.
       
 64677         (WebCore::listMarkerText): Added. Moved the code here from calcMinMaxWidth, but added
       
 64678         support for text for the styles disc, circle, square, decimal-leading-zero, hiragana,
       
 64679         hirigana-iroha, katakana, katakana-iroha, cjk-ideographic, armenian, and georgian.
       
 64680         Also changed some of the styles to share the new toAlphabetic function.
       
 64681         (WebCore::RenderListMarker::RenderListMarker): Updated for name changes and list
       
 64682         item parameter.
       
 64683         (WebCore::RenderListMarker::~RenderListMarker): Updated for name changes.
       
 64684         (WebCore::RenderListMarker::setStyle): Updated for name changes.
       
 64685         (WebCore::RenderListMarker::isImage): Added. Useful helper that unifies the check
       
 64686         for no image and the error image.
       
 64687         (WebCore::RenderListMarker::paint): Updated for name changes to to use isImage()
       
 64688         and rearranged the code a bit.
       
 64689         (WebCore::RenderListMarker::imageChanged): Updated for name change
       
 64690         (WebCore::RenderListMarker::calcMinMaxWidth): Updated for name change, fixed a bug
       
 64691         where we'd leave the old text around if we were using an image-based marker. Also
       
 64692         changed the code to use isImage() instead of checking m_listImage.
       
 64693         (WebCore::RenderListMarker::calcWidth): Changed to use isImage().
       
 64694         (WebCore::RenderListMarker::lineHeight): Changed to use isImage().
       
 64695         (WebCore::RenderListMarker::baselinePosition): Changed to use isImage().
       
 64696         (WebCore::RenderListMarker::getRelativeMarkerRect): Changed to use isImage(),
       
 64697         restructured the code a little.
       
 64698 
       
 64699         * rendering/RenderObject.h: Removed now-uneeded includes. Removed collectBorders()
       
 64700         and isFormElement(). Made remove() function and m_hasCounterNodeMap public so
       
 64701         we could remove friend declarations for RenderListItem and RenderView.
       
 64702         Moved findCounter() to become a private function inside RenderCounter.cpp.
       
 64703         * rendering/RenderObject.cpp:
       
 64704         (WebCore::RenderObject::createObject): Fix bug where a contentData() with
       
 64705         CONTENT_NONE is treated as image content -- only look at the content property
       
 64706         if it has exactly one entry which is a CONTENT_OBJECT.
       
 64707         (WebCore::RenderObject::selectionStartEnd): Add const.
       
 64708         (WebCore::RenderObject::destroy): Moved counter-specific code to
       
 64709         RenderCounter::destroyCounterNodes.
       
 64710         (WebCore::RenderObject::recalcMinMaxWidths): Changed code to set m_recalcMinMax
       
 64711         near the top of the function -- the old code would potentially reset it after it
       
 64712         was set by the calcMinMaxWidths functions, and possibly skip a future needed
       
 64713         recalc. That came up in counter test cases. Removed unneeded boolean check right
       
 64714         after an assertion.
       
 64715 
       
 64716         * rendering/RenderPart.h: Marked two virtual functions virtual for clarity.
       
 64717 
       
 64718         * rendering/RenderReplaced.h: Made shouldPaint be protected, and made
       
 64719         m_intrinsicWidth, m_intrinsicHeight, and m_selectionState be private.
       
 64720         Also marked isSelected() const.
       
 64721         * rendering/RenderReplaced.cpp: Added newly-needed include.
       
 64722         (WebCore::RenderReplaced::RenderReplaced): Use constructor syntax.
       
 64723         (WebCore::RenderReplaced::isSelected): Made const and changed to call the
       
 64724         selectionStartEnd function in the straightforward way.
       
 64725 
       
 64726         * rendering/RenderSVGText.cpp:
       
 64727         (WebCore::RenderSVGText::absoluteRects): Use functions instead of direct field
       
 64728         access so the fields can be private.
       
 64729         (WebCore::RenderSVGText::relativeBBox): Ditto.
       
 64730 
       
 64731         * rendering/RenderStyle.h: Tweaked formatting. Changed names of CSS3 holders
       
 64732         to say "rare" instead, since it's not all CSS 3. Renamed CounterData to
       
 64733         CounterContent, since it's used inside ContentData. Changed names of fields in
       
 64734         ContentData to have m prefix. Moved content and counter fields into the rare
       
 64735         non-inherited data object. Removed unneeded assignment operator from a class
       
 64736         that already inherits from Shared which makes it start out noncopyable.
       
 64737         * rendering/RenderStyle.cpp: Name changes, plus:
       
 64738         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
       
 64739         Updated for added fields (content, counter-reset, counter-increment).
       
 64740         (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): Ditto.
       
 64741         (WebCore::StyleRareNonInheritedData::operator==): Reformatted and sorted so it's
       
 64742         easy to see if any fields are missing.
       
 64743         (WebCore::operator!=): Added. Compares two CounterContent objects.
       
 64744         (WebCore::RenderStyle::arenaDelete): Removed code to handle content, which is
       
 64745         now in the rareNonInheritedData structure.
       
 64746         (WebCore::RenderStyle::RenderStyle): Ditto.
       
 64747         (WebCore::RenderStyle::inheritFrom): Ditto.
       
 64748         (WebCore::RenderStyle::operator==): Ditto.
       
 64749         (WebCore::RenderStyle::inheritedNotEqual):
       
 64750         (WebCore::RenderStyle::diff):
       
 64751         (WebCore::RenderStyle::contentDataEquivalent): Added case for counter,
       
 64752         which previously would be ignored when determining if content is equivalent.
       
 64753         (WebCore::RenderStyle::clearContent): Added.
       
 64754         (WebCore::RenderStyle::setContent): Updated for change in content location.
       
 64755         (WebCore::ContentData::clear): Changed algorithm so that it's not recursive
       
 64756         and thus can handle a very long list of ContentData.
       
 64757         (WebCore::operator==): Added. Compares two CounterDirective objects.
       
 64758         (WebCore::RenderStyle::counterDirectives): Added.
       
 64759         (WebCore::RenderStyle::accessCounterDirectives): Added.
       
 64760 
       
 64761         * rendering/RenderTable.h: Made m_currentBorder const to better reflect the
       
 64762         paint algorithm.
       
 64763         * rendering/RenderTable.cpp: (WebCore::RenderTable::paint): Changed to use
       
 64764         Vector instead of DeprecatedValueList for the border styles, and to sort
       
 64765         rather than inserting in sorted order as we go. Put the code to loop through
       
 64766         the nodes and collect border styles here instead of in a RenderObject virtual
       
 64767         function. Also set m_currentBorder to 0 after the loop for greater clarity.
       
 64768 
       
 64769         * rendering/RenderTableCell.h: Added a typedef for a vector of border values.
       
 64770         Removed the virtual collectBorders and replaced with the non-virtual named
       
 64771         collectBorderStyles. Also added a static member function named sortBorderStyles.
       
 64772         * rendering/RenderTableCell.cpp:
       
 64773         (WebCore::CollapsedBorders::CollapsedBorders): Removed unneeded constructor
       
 64774         parameter.
       
 64775         (WebCore::addBorderStyle): Changed to use a vector instead of a
       
 64776         DeprecatedValueList. Wrote out a loop since Vector doesn't have a contains
       
 64777         member function. Removed the code to insert the border at a sorted location;
       
 64778         instead we have a separate call to sort the border styles
       
 64779         (WebCore::RenderTableCell::collectBorderStyles): Renamed, and changed the
       
 64780         parameter type.
       
 64781         (WebCore::compareBorderStylesForQSort): Added.
       
 64782         (WebCore::RenderTableCell::sortBorderStyles): Added.
       
 64783 
       
 64784         * rendering/RenderText.h: Changed StringImpl parameters in setText functions
       
 64785         to be PassRefPtr; added a new setInternalString function. Made a bunch of the
       
 64786         member functions private and made all the data members private instead of
       
 64787         protected.
       
 64788         * rendering/RenderText.cpp:
       
 64789         (WebCore::RenderText::setStyle): Restructure a bit for clarity. Fix case where
       
 64790         the old style has a different security than the new style. Use release() since
       
 64791         RenderText::setText now takes PassRefPtr. Always call cacheWidths here.
       
 64792         (WebCore::RenderText::setTextWithOffset): Changed to take the string as a
       
 64793         PassRefPtr instead of a raw pointer.
       
 64794         (WebCore::isInlineFlowOrEmptyText): Added.
       
 64795         (WebCore::RenderText::setInternalString): Refactored core of setText into a
       
 64796         separate protected member function that can be used RenderCounter. Changed
       
 64797         the text security square character to match what's used in list markers.
       
 64798         Changed the text transform switch statement so that gcc will warn us if we add
       
 64799         a new value and don't add a case for it.
       
 64800         (WebCore::RenderText::setText): Refactored most of the function into
       
 64801         setInternalString. Removed the call to cacheWidths -- that's now done in the
       
 64802         setStyle function only.
       
 64803 
       
 64804         * rendering/RenderView.h:
       
 64805         * rendering/RenderView.cpp: (WebCore::RenderView::selectionStartEnd): Now const.
       
 64806 
       
 64807         * rendering/RenderWidget.cpp: Added newly-needed include.
       
 64808         (WebCore::RenderWidget::setSelectionState): Don't bother setting m_selectionState
       
 64809         here since RenderReplaced::setSelectionState already does that.
       
 64810 
       
 64811 2007-01-05  Anders Carlsson  <acarlsson@apple.com>
       
 64812 
       
 64813         Rubber stamped by Adam.
       
 64814         
       
 64815         Move even more code to .cpp files.
       
 64816 
       
 64817         * WebCore.xcodeproj/project.pbxproj:
       
 64818         * loader/FrameLoader.cpp:
       
 64819         (WebCore::FrameLoader::createWindow):
       
 64820         (WebCore::FrameLoader::load):
       
 64821         (WebCore::FrameLoader::canLoad):
       
 64822         (WebCore::FrameLoader::initialRequest):
       
 64823         (WebCore::FrameLoader::receivedData):
       
 64824         (WebCore::FrameLoader::setRequest):
       
 64825         (WebCore::FrameLoader::setResponse):
       
 64826         (WebCore::FrameLoader::willUseArchive):
       
 64827         (WebCore::FrameLoader::handleUnimplementablePolicy):
       
 64828         (WebCore::FrameLoader::cannotShowMIMEType):
       
 64829         (WebCore::FrameLoader::interruptionForPolicyChangeError):
       
 64830         (WebCore::FrameLoader::checkNavigationPolicy):
       
 64831         (WebCore::FrameLoader::checkContentPolicy):
       
 64832         (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
       
 64833         (WebCore::FrameLoader::reloadAllowingStaleData):
       
 64834         (WebCore::FrameLoader::reload):
       
 64835         (WebCore::FrameLoader::finishedLoading):
       
 64836         (WebCore::FrameLoader::continueAfterWillSubmitForm):
       
 64837         (WebCore::FrameLoader::submitForm):
       
 64838         (WebCore::FrameLoader::post):
       
 64839         (WebCore::FrameLoader::isReloading):
       
 64840         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
       
 64841         (WebCore::FrameLoader::loadResourceSynchronously):
       
 64842         (WebCore::FrameLoader::startLoadingMainResource):
       
 64843         (WebCore::FrameLoader::startLoading):
       
 64844         (WebCore::FrameLoader::cancelMainResourceLoad):
       
 64845         (WebCore::FrameLoader::identifierForInitialRequest):
       
 64846         (WebCore::FrameLoader::willSendRequest):
       
 64847         (WebCore::FrameLoader::didReceiveResponse):
       
 64848         (WebCore::FrameLoader::didReceiveData):
       
 64849         (WebCore::FrameLoader::didFailToLoad):
       
 64850         (WebCore::FrameLoader::originalRequest):
       
 64851         (WebCore::FrameLoader::receivedMainResourceError):
       
 64852         (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
       
 64853         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
       
 64854         (WebCore::FrameLoader::opened):
       
 64855         (WebCore::FrameLoader::dataURLBaseFromRequest):
       
 64856         (WebCore::FrameLoader::checkNewWindowPolicy):
       
 64857         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
       
 64858         (WebCore::FrameLoader::continueAfterNavigationPolicy):
       
 64859         (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
       
 64860         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
       
 64861         (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
       
 64862         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
       
 64863         (WebCore::FrameLoader::sendRemainingDelegateMessages):
       
 64864         (WebCore::FrameLoader::requestFromDelegate):
       
 64865         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
       
 64866         (WebCore::FrameLoader::applyUserAgent):
       
 64867         (WebCore::PolicyCheck::PolicyCheck):
       
 64868         (WebCore::PolicyCheck::clear):
       
 64869         (WebCore::PolicyCheck::set):
       
 64870         (WebCore::PolicyCheck::call):
       
 64871         (WebCore::PolicyCheck::clearRequest):
       
 64872         * loader/FrameLoader.h:
       
 64873         * loader/FrameLoaderClient.h:
       
 64874         * loader/MainResourceLoader.h:
       
 64875         * loader/ResourceLoader.h:
       
 64876         (WebCore::ResourceLoader::setIdentifier):
       
 64877         (WebCore::ResourceLoader::identifier):
       
 64878         * loader/mac/FrameLoaderMac.mm:
       
 64879         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
       
 64880         (WebCore::FrameLoader::referrer):
       
 64881         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
       
 64882         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
       
 64883         (WebCore::FrameLoader::didChangeTitle):
       
 64884         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 64885         (WebCore::SVGEmptyFrameLoaderClient::dispatchCreatePage):
       
 64886 
       
 64887 2007-01-05  Mitz Pettel  <mitz@webkit.org>
       
 64888 
       
 64889         Reviewed by Hyatt.
       
 64890 
       
 64891         - fix http://bugs.webkit.org/show_bug.cgi?id=12079
       
 64892           Nested tables don't repaint properly when a certain row is added
       
 64893 
       
 64894         Tests: fast/repaint/table-section-repaint.html
       
 64895                fast/repaint/table-section-overflow.html
       
 64896 
       
 64897         Fixed repainting when table sections move during layout.
       
 64898 
       
 64899         Made table cells' overflows propagate to table sections and gave tables
       
 64900         overflows.
       
 64901 
       
 64902         * rendering/RenderTable.cpp:
       
 64903         (WebCore::RenderTable::layout): Added computation of horizontal and vertical overflows
       
 64904         based on the caption's and the table sections' overflows.
       
 64905         Added checks for table sections that change position during layout. When that happens,
       
 64906         we assume all sections below the first section that moved also moved, and repaint
       
 64907         everything downwards from there.
       
 64908         Added calls to repaintDuringLayoutIfMoved() for the caption.
       
 64909         Changed the way table sections are iterated over and added a FIXME to change it again
       
 64910         once bug 12124 is fixed.
       
 64911         (WebCore::RenderTable::paint): Changed to paint overflow.
       
 64912         (WebCore::RenderTable::outerBorderBottom):
       
 64913         * rendering/RenderTableSection.cpp:
       
 64914         (WebCore::RenderTableSection::RenderTableSection):
       
 64915         (WebCore::RenderTableSection::layoutRows): Added code to compute the section's overflow
       
 64916         and a flag saying whether any cells in this section overflow.
       
 64917         (WebCore::RenderTableSection::paint): Changed to paint overflow. If any cell
       
 64918         in the section has overflow, then all cells are given a chance to paint. This is needed
       
 64919         because there can be internal overflow, and external overflow can be coming from any
       
 64920         cell inside.
       
 64921         * rendering/RenderTableSection.h:
       
 64922         (WebCore::RenderTableSection::overflowWidth):
       
 64923         (WebCore::RenderTableSection::overflowLeft):
       
 64924 
       
 64925 2007-01-05  Beth Dakin  <bdakin@apple.com>
       
 64926 
       
 64927         Reviewed by Adam.
       
 64928 
       
 64929         Fix for <rdar://problem/4863434> Wrong contextual menu appears for 
       
 64930         textarea and input elements at http://www.apple.com/feedback/
       
 64931         ical.html
       
 64932 
       
 64933         No test cases added since context menus are not in DRT.
       
 64934 
       
 64935         * page/ContextMenuController.cpp: 
       
 64936         (WebCore::ContextMenuController::handleContextMenuEvent): Call 
       
 64937         EventHandler's hitTestResultAtPoint() instead of just hit testing 
       
 64938         the layer.
       
 64939 
       
 64940 2007-01-05  Anders Carlsson  <acarlsson@apple.com>
       
 64941 
       
 64942         Rubber-stamped by Adam.
       
 64943         
       
 64944         Move a bunch of platform independent code over to DocumentLoader.cpp
       
 64945 
       
 64946         * WebCore.xcodeproj/project.pbxproj:
       
 64947         * loader/DocumentLoader.cpp:
       
 64948         (WebCore::canonicalizedTitle):
       
 64949         (WebCore::DocumentLoader::DocumentLoader):
       
 64950         (WebCore::DocumentLoader::frameLoader):
       
 64951         (WebCore::DocumentLoader::~DocumentLoader):
       
 64952         (WebCore::DocumentLoader::setMainResourceData):
       
 64953         (WebCore::DocumentLoader::mainResourceData):
       
 64954         (WebCore::DocumentLoader::originalRequest):
       
 64955         (WebCore::DocumentLoader::originalRequestCopy):
       
 64956         (WebCore::DocumentLoader::request):
       
 64957         (WebCore::DocumentLoader::initialRequest):
       
 64958         (WebCore::DocumentLoader::actualRequest):
       
 64959         (WebCore::DocumentLoader::URL):
       
 64960         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
       
 64961         (WebCore::DocumentLoader::setRequest):
       
 64962         (WebCore::DocumentLoader::setMainDocumentError):
       
 64963         (WebCore::DocumentLoader::clearErrors):
       
 64964         (WebCore::DocumentLoader::mainReceivedError):
       
 64965         (WebCore::DocumentLoader::stopLoading):
       
 64966         (WebCore::DocumentLoader::setupForReplace):
       
 64967         (WebCore::DocumentLoader::commitIfReady):
       
 64968         (WebCore::DocumentLoader::finishedLoading):
       
 64969         (WebCore::DocumentLoader::setCommitted):
       
 64970         (WebCore::DocumentLoader::isCommitted):
       
 64971         (WebCore::DocumentLoader::setLoading):
       
 64972         (WebCore::DocumentLoader::isLoading):
       
 64973         (WebCore::DocumentLoader::commitLoad):
       
 64974         (WebCore::DocumentLoader::doesProgressiveLoad):
       
 64975         (WebCore::DocumentLoader::receivedData):
       
 64976         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
       
 64977         (WebCore::DocumentLoader::updateLoading):
       
 64978         (WebCore::DocumentLoader::setFrame):
       
 64979         (WebCore::DocumentLoader::attachToFrame):
       
 64980         (WebCore::DocumentLoader::detachFromFrame):
       
 64981         (WebCore::DocumentLoader::prepareForLoadStart):
       
 64982         (WebCore::DocumentLoader::setIsClientRedirect):
       
 64983         (WebCore::DocumentLoader::isClientRedirect):
       
 64984         (WebCore::DocumentLoader::setPrimaryLoadComplete):
       
 64985         (WebCore::DocumentLoader::isLoadingInAPISense):
       
 64986         (WebCore::DocumentLoader::addResponse):
       
 64987         (WebCore::DocumentLoader::stopRecordingResponses):
       
 64988         (WebCore::DocumentLoader::title):
       
 64989         (WebCore::DocumentLoader::setLastCheckedRequest):
       
 64990         (WebCore::DocumentLoader::lastCheckedRequest):
       
 64991         (WebCore::DocumentLoader::triggeringAction):
       
 64992         (WebCore::DocumentLoader::setTriggeringAction):
       
 64993         (WebCore::DocumentLoader::responses):
       
 64994         (WebCore::DocumentLoader::setOverrideEncoding):
       
 64995         (WebCore::DocumentLoader::overrideEncoding):
       
 64996         (WebCore::DocumentLoader::setTitle):
       
 64997         (WebCore::DocumentLoader::urlForHistory):
       
 64998         * loader/DocumentLoader.h:
       
 64999         * loader/FrameLoader.cpp:
       
 65000         (WebCore::FrameLoader::load):
       
 65001         (WebCore::FrameLoader::committedLoad):
       
 65002         (WebCore::FrameLoader::setMainDocumentError):
       
 65003         (WebCore::FrameLoader::mainReceivedCompleteError):
       
 65004         (WebCore::FrameLoader::mainReceivedError):
       
 65005         (WebCore::FrameLoader::cancelledError):
       
 65006         (WebCore::FrameLoader::fileDoesNotExistError):
       
 65007         (WebCore::FrameLoader::mainResourceData):
       
 65008         * loader/FrameLoader.h:
       
 65009         * loader/FrameLoaderClient.h:
       
 65010         * loader/mac/DocumentLoaderMac.mm:
       
 65011         (WebCore::DocumentLoader::unreachableURL):
       
 65012         * loader/mac/FrameLoaderMac.mm:
       
 65013 
       
 65014 2007-01-05  Brady Eidson  <beidson@apple.com>
       
 65015 
       
 65016         Reviewed by Eric Seidel
       
 65017 
       
 65018         http://bugs.webkit.org/show_bug.cgi?id=12117
       
 65019         Fixes null deref when opening links from a gmail account
       
 65020 
       
 65021         * loader/FrameLoader.cpp:
       
 65022         (WebCore::FrameLoader::updateHistoryForStandardLoad): Null check m_currentHistoryItem
       
 65023         (WebCore::FrameLoader::updateHistoryForClientRedirect): Ditto
       
 65024 
       
 65025 2007-01-05  Anders Carlsson  <acarlsson@apple.com>
       
 65026 
       
 65027         Move some now cross platform functions over to ResourceLoader.cpp in an attempt to fix the non Mac builds.
       
 65028         
       
 65029         * loader/CachedResource.h:
       
 65030         (WebCore::CachedResource::setAllData):
       
 65031         * loader/ResourceLoader.cpp:
       
 65032         (WebCore::ResourceLoader::resourceData):
       
 65033         * loader/ResourceLoader.h:
       
 65034         * loader/SubresourceLoader.cpp:
       
 65035         (WebCore::SubresourceLoader::didFinishLoading):
       
 65036         * loader/mac/LoaderFunctionsMac.mm:
       
 65037         * loader/mac/ResourceLoaderMac.mm:
       
 65038         * platform/SharedBuffer.cpp:
       
 65039         (WebCore::SharedBuffer::platformDataSize):
       
 65040         * platform/network/ResourceHandle.h:
       
 65041 
       
 65042 2007-01-05  David Hyatt  <hyatt@apple.com>
       
 65043 
       
 65044         Back out fix for 12114.  I missed rule #5 in the float positioning part of the CSS2.1 spec.  Keep all
       
 65045         the code cleanup though.
       
 65046 
       
 65047         Reviewed by mitz
       
 65048 
       
 65049         * rendering/RenderBlock.cpp:
       
 65050         (WebCore::RenderBlock::positionNewFloats):
       
 65051 
       
 65052 2007-01-05  Anders Carlsson  <acarlsson@apple.com>
       
 65053 
       
 65054         Reviewed by Maciej.
       
 65055 
       
 65056         Add a shared buffer class which is backed by either a vector or an NSData object. This object can also
       
 65057         be held in a custom NSData subclass. Use this in the loader wherever NSData was used.
       
 65058         
       
 65059         * WebCore.exp:
       
 65060         * WebCore.xcodeproj/project.pbxproj:
       
 65061         * loader/CachedResource.h:
       
 65062         (WebCore::CachedResource::allData):
       
 65063         * loader/DocumentLoader.h:
       
 65064         * loader/FrameLoader.h:
       
 65065         * loader/ResourceLoader.h:
       
 65066         * loader/SubresourceLoaderClient.h:
       
 65067         (WebCore::SubresourceLoaderClient::didFail):
       
 65068         * loader/loader.cpp:
       
 65069         (WebCore::Loader::didFinishLoading):
       
 65070         * loader/loader.h:
       
 65071         * loader/mac/DocumentLoaderMac.mm:
       
 65072         (WebCore::DocumentLoader::setMainResourceData):
       
 65073         (WebCore::DocumentLoader::mainResourceData):
       
 65074         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
       
 65075         * loader/mac/FrameLoaderMac.mm:
       
 65076         (WebCore::FrameLoader::mainResourceData):
       
 65077         * loader/mac/ImageDocumentMac.mm:
       
 65078         (WebCore::finishImageLoad):
       
 65079         * loader/mac/LoaderFunctionsMac.mm:
       
 65080         (WebCore::CheckCacheObjectStatus):
       
 65081         (WebCore::CachedResource::setAllData):
       
 65082         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
       
 65083         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
       
 65084         * loader/mac/ResourceLoaderMac.mm:
       
 65085         (WebCore::ResourceLoader::addData):
       
 65086         (WebCore::ResourceLoader::resourceData):
       
 65087         (WebCore::ResourceLoader::clearResourceData):
       
 65088         (WebCore::ResourceLoader::didReceiveData):
       
 65089         (WebCore::ResourceLoader::willStopBufferingData):
       
 65090         * loader/mac/SubresourceLoaderMac.mm:
       
 65091         (WebCore::SubresourceLoader::didReceiveResponse):
       
 65092         (WebCore::SubresourceLoader::didFinishLoading):
       
 65093         * page/mac/WebCoreFrameBridge.mm:
       
 65094         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
       
 65095         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
       
 65096         * platform/KURL.h:
       
 65097         * platform/SharedBuffer.cpp: Added.
       
 65098         (WebCore::SharedBuffer::SharedBuffer):
       
 65099         (WebCore::SharedBuffer::size):
       
 65100         (WebCore::SharedBuffer::data):
       
 65101         (WebCore::SharedBuffer::append):
       
 65102         (WebCore::SharedBuffer::clear):
       
 65103         (WebCore::SharedBuffer::clearPlatformData):
       
 65104         (WebCore::SharedBuffer::maybeTransferPlatformData):
       
 65105         (WebCore::SharedBuffer::hasPlatformData):
       
 65106         (WebCore::SharedBuffer::platformData):
       
 65107         * platform/SharedBuffer.h: Added.
       
 65108         * platform/mac/SharedBufferMac.mm: Added.
       
 65109         (-[SharedBufferData dealloc]):
       
 65110         (-[SharedBufferData finalize]):
       
 65111         (-[SharedBufferData initWithSharedBuffer:]):
       
 65112         (-[SharedBufferData length]):
       
 65113         (-[SharedBufferData bytes]):
       
 65114         (WebCore::SharedBuffer::wrapNSData):
       
 65115         (WebCore::SharedBuffer::SharedBuffer):
       
 65116         (WebCore::SharedBuffer::createNSData):
       
 65117         (WebCore::SharedBuffer::hasPlatformData):
       
 65118         (WebCore::SharedBuffer::platformData):
       
 65119         (WebCore::SharedBuffer::platformDataSize):
       
 65120         (WebCore::SharedBuffer::maybeTransferPlatformData):
       
 65121         (WebCore::SharedBuffer::clearPlatformData):
       
 65122         * platform/network/ResourceHandle.h:
       
 65123         * platform/network/ResourceHandleClient.h:
       
 65124         * platform/network/mac/ResourceHandleMac.mm:
       
 65125         (WebCore::ResourceHandle::bufferedData):
       
 65126 
       
 65127 2007-01-05  Anders Carlsson  <acarlsson@apple.com>
       
 65128 
       
 65129         Reviewed by Adam.
       
 65130 
       
 65131         http://bugs.webkit.org/show_bug.cgi?id=12120
       
 65132         REGRESSION(r18605): Safari snippet editor no longer works
       
 65133         
       
 65134         * loader/mac/ResourceLoaderMac.mm:
       
 65135         (WebCore::ResourceLoader::willSendRequest):
       
 65136         Put back the code change in r18607.
       
 65137         
       
 65138         * platform/mac/KURLMac.mm:
       
 65139         (WebCore::KURL::KURL):
       
 65140         Convert nil NSURLs to null KURLs.
       
 65141 
       
 65142 2007-01-04  Alexey Proskuryakov  <ap@webkit.org>
       
 65143 
       
 65144         Reviewed by Geoff.
       
 65145 
       
 65146         http://bugs.webkit.org/show_bug.cgi?id=7296
       
 65147         Disable JavaScript exceptions when dynamically changing CSS properties.
       
 65148 
       
 65149         * bindings/js/kjs_css.cpp:
       
 65150         (KJS::DOMCSSStyleDeclaration::put): Removed the Dashboard quirk logic.
       
 65151 
       
 65152         * css/CSSMutableStyleDeclaration.cpp:
       
 65153         (WebCore::CSSMutableStyleDeclaration::setProperty): Don't raise an exception if parsing fails.
       
 65154 
       
 65155 2007-01-05  Antti Koivisto  <koivisto@iki.fi>
       
 65156 
       
 65157         Reviewed by hyatt.
       
 65158         
       
 65159         http://bugs.webkit.org/show_bug.cgi?id=12109
       
 65160         
       
 65161         Fix layer visibility in some cases with nested layers.
       
 65162 
       
 65163         * rendering/RenderLayer.cpp:
       
 65164         (WebCore::RenderLayer::updateVisibilityStatus):
       
 65165 
       
 65166 2007-01-05  Lars Knoll <lars@trolltech.com>
       
 65167 
       
 65168         Make it compile with gcc 4.1
       
 65169 
       
 65170         * rendering/RenderTableSection.h:
       
 65171 
       
 65172 2007-01-04  Adam Roben  <aroben@apple.com>
       
 65173 
       
 65174         Reviewed by Geoff, cheered by others.
       
 65175 
       
 65176         Dead code elimination.
       
 65177 
       
 65178         All layout tests pass.
       
 65179 
       
 65180         * page/EventHandler.h:
       
 65181         * page/mac/EventHandlerMac.mm:
       
 65182         * page/mac/WebCoreFrameBridge.h:
       
 65183         * page/mac/WebCoreFrameBridge.mm:
       
 65184 
       
 65185 2007-01-04  Adam Roben  <aroben@apple.com>
       
 65186 
       
 65187         Reviewed by Geoff.
       
 65188 
       
 65189         Fix: <rdar://4800335> REGRESSION: shift-tabbing from location field
       
 65190         goes to first field rather than last (businessweek.com)
       
 65191 
       
 65192         Fix: <rdar://4800373> REGRESSION: tabbing from last control focuses
       
 65193         nothing visible (busniessweek.com)
       
 65194 
       
 65195         Handle tabbing into/out of subframes in WebCore instead of letting
       
 65196         AppKit do the dirty work. This change also fixes a number of bugs and
       
 65197         changes some behavior to match other browsers:
       
 65198           - No frames receive a focus event when the page is first loaded.
       
 65199           - When a frame is clicked or focused with the keyboard, it receives
       
 65200             a focus event and all other frames receive a blur event.
       
 65201           - tabindex values are clamped to the range of a signed short, rather
       
 65202             than overflowing within an unsigned short.
       
 65203           - tabindex is respected on frame owner elements, even though HTML4
       
 65204             says it shouldn't be.
       
 65205           - Subframes will be focused when tabbing if they don't contain any
       
 65206             focusable elements within them (it would be nice to only focus the
       
 65207             frame if it has scrollbars).
       
 65208 
       
 65209         Renamed SelectionDirection to FocusDirection and put it in its own file.
       
 65210 
       
 65211         * page/FocusDirection.h: Added.
       
 65212         (WebCore::):
       
 65213         * page/mac/WebCoreFrameBridge.mm: Updated for renames.
       
 65214         (-[WebCoreFrameBridge nextKeyView]):
       
 65215         (-[WebCoreFrameBridge previousKeyView]):
       
 65216         (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]):
       
 65217         (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]):
       
 65218 
       
 65219         Moved advanceFocus from EventHandler to FocusController and added
       
 65220         support for moving into/out of subframes..
       
 65221 
       
 65222         * page/EventHandler.cpp: Moved advanceFocus to FocusController.
       
 65223         * page/EventHandler.h: Ditto.
       
 65224         * page/FocusController.cpp:
       
 65225         (WebCore::deepFocusableNode): Static helper function to find focusable
       
 65226         nodes nested within frames.
       
 65227         (WebCore::FocusController::advanceFocus): Moved from EventHandler and
       
 65228         rewritten to handle subframes.
       
 65229         * page/FocusController.h: Added advanceFocus declaration.
       
 65230         * dom/EventTargetNode.cpp:
       
 65231         (WebCore::EventTargetNode::defaultEventHandler): Updated for the move
       
 65232         of advanceFocus to FocusController.
       
 65233         * html/HTMLFrameOwnerElement.h:
       
 65234         (WebCore::HTMLFrameOwnerElement::isFrameOwnerElement): New method.
       
 65235         (WebCore::HTMLFrameOwnerElement::isKeyboardFocusable): New virtual
       
 65236         implementation used to trick Document::nextFocusableNode so that we
       
 65237         can focus frames.
       
 65238 
       
 65239         Rewrote/renamed
       
 65240         Document::nextFocusableNode/Document::previousFocusableNode.
       
 65241 
       
 65242         * dom/Document.cpp:
       
 65243         (WebCore::nextNodeWithExactTabIndex): New static helper
       
 65244         function.
       
 65245         (WebCore::previousNodeWithExactTabIndex): Ditto.
       
 65246         (WebCore::nextNodeWithGreaterTabIndex): Ditto.
       
 65247         (WebCore::previousNodeWithLowerTabIndex): Ditto.
       
 65248         (WebCore::Document::nextFocusableNode): Renamed from nextFocusedNode,
       
 65249         and rewritten with much simpler logic.
       
 65250         (WebCore::Document::previousFocusableNode): Ditto.
       
 65251         * dom/Document.h: Updated declarations for renames.
       
 65252         * page/mac/EventHandlerMac.mm: Updated for rename of SelectionDirection
       
 65253         to FocusDirection.
       
 65254         (WebCore::EventHandler::nextKeyViewInFrame): Updated for renames.
       
 65255         (WebCore::EventHandler::nextKeyViewInFrameHierarchy): Ditto.
       
 65256         (WebCore::EventHandler::nextKeyView): Ditto.
       
 65257         (WebCore::EventHandler::focusDocumentView): Added call to
       
 65258         setFocusedFrame when focusing the document view.
       
 65259         (WebCore::EventHandler::passMouseDownEventToWidget): Removed LOG_ERROR
       
 65260         when a nil NSView is returned from AppKit, as this is a fairly common
       
 65261         occurrence when a RenderWidget has a border.
       
 65262         (WebCore::EventHandler::passWheelEventToWidget): Added a nil-check of
       
 65263         the hit-tested NSView.
       
 65264 
       
 65265         Changed storage of tabIndex to a signed short, and added clamping of
       
 65266         tabindex attribute values to match Firefox's behavior.
       
 65267 
       
 65268         * dom/Node.h: Use a signed short to store m_tabIndex.
       
 65269         (WebCore::Node::isFrameOwnerElement): New method.
       
 65270         (WebCore::Node::tabIndex): Updated for signedness.
       
 65271         (WebCore::Node::setTabIndex): Ditto.
       
 65272         * html/HTMLAnchorElement.cpp: Remove implementation of tabIndex() so
       
 65273         that Node::tabIndex() will be called instead and return the clamped
       
 65274         value (which matches Firefox's behavior).
       
 65275         * html/HTMLAnchorElement.h: Ditto.
       
 65276         * html/HTMLAreaElement.cpp: Ditto.
       
 65277         * html/HTMLAreaElement.h: Ditto.
       
 65278         * html/HTMLGenericFormElement.cpp: Ditto.
       
 65279         * html/HTMLGenericFormElement.h: Ditto.
       
 65280         * html/HTMLObjectElement.cpp: Ditto.
       
 65281         * html/HTMLObjectElement.h: Ditto.
       
 65282         * html/HTMLElement.cpp:
       
 65283         (WebCore::HTMLElement::parseMappedAttribute): Clamp tabIndex to the
       
 65284         range of a signed short to match Firefox.
       
 65285 
       
 65286         Added two new Chrome methods for transferring focus out of the
       
 65287         WebView.
       
 65288 
       
 65289         * page/Chrome.cpp:
       
 65290         (WebCore::Chrome::canTakeFocus):
       
 65291         (WebCore::Chrome::takeFocus):
       
 65292         * page/Chrome.h:
       
 65293         * page/ChromeClient.h:
       
 65294         * platform/graphics/svg/SVGImageEmptyClients.h: Fixed typo "CromeClient" -> "ChromeClient".
       
 65295         (WebCore::SVGEmptyChromeClient::~SVGEmptyChromeClient):
       
 65296         (WebCore::SVGEmptyChromeClient::canTakeFocus):
       
 65297         (WebCore::SVGEmptyChromeClient::takeFocus):
       
 65298         * platform/graphics/svg/SVGImage.cpp:
       
 65299         (WebCore::SVGImage::setData): Fixed typo.
       
 65300 
       
 65301         Miscellaneous:
       
 65302 
       
 65303         * WebCore.exp: Updated/sorted symbols.
       
 65304         * WebCore.xcodeproj/project.pbxproj: Made FocusController.h Private so
       
 65305         WebKit can access it.
       
 65306 
       
 65307 2007-01-04  Brady Eidson  <beidson@apple.com>
       
 65308 
       
 65309         Reverted Anders' change to fix the world
       
 65310 
       
 65311         * loader/mac/ResourceLoaderMac.mm:
       
 65312         (WebCore::ResourceLoader::willSendRequest):
       
 65313         (WebCore::ResourceLoader::didReceiveResponse):
       
 65314 
       
 65315 2007-01-04  Mitz Pettel  <mitz@webkit.org>
       
 65316 
       
 65317         Reviewed by Sam Weinig.
       
 65318 
       
 65319         - http://bugs.webkit.org/show_bug.cgi?id=12078
       
 65320           Clean up RenderTable*
       
 65321 
       
 65322         - Coding style cleanup.
       
 65323         - Canceled AutoTableLayout and FixedTableLayout being friend classes of
       
 65324           RenderTable. Instead, added public accessors to RenderTable for what
       
 65325           the table layout classes need and changed TableLayout::calcMinMaxWidth()
       
 65326           to take references to the caller's min and max widths.
       
 65327         - Made RenderTableSection's grid protected and moved code that accessed it
       
 65328           from RenderTable into RenderTableSection.
       
 65329 
       
 65330         No test possible (no change to functionality).
       
 65331 
       
 65332         * rendering/AutoTableLayout.cpp:
       
 65333         (WebCore::AutoTableLayout::calcMinMaxWidth):
       
 65334         (WebCore::AutoTableLayout::layout):
       
 65335         * rendering/AutoTableLayout.h:
       
 65336         * rendering/FixedTableLayout.cpp:
       
 65337         (WebCore::FixedTableLayout::calcWidthArray):
       
 65338         (WebCore::FixedTableLayout::calcMinMaxWidth):
       
 65339         (WebCore::FixedTableLayout::layout):
       
 65340         * rendering/FixedTableLayout.h:
       
 65341         * rendering/RenderTable.cpp:
       
 65342         (WebCore::RenderTable::RenderTable):
       
 65343         (WebCore::RenderTable::~RenderTable):
       
 65344         (WebCore::RenderTable::setStyle):
       
 65345         (WebCore::RenderTable::addChild):
       
 65346         (WebCore::RenderTable::calcWidth):
       
 65347         (WebCore::RenderTable::layout):
       
 65348         (WebCore::RenderTable::setCellWidths):
       
 65349         (WebCore::RenderTable::paint):
       
 65350         (WebCore::RenderTable::paintBoxDecorations):
       
 65351         (WebCore::RenderTable::calcMinMaxWidth):
       
 65352         (WebCore::RenderTable::splitColumn): Factored out the section work
       
 65353         to RenderTableSection::splitColumn().
       
 65354         (WebCore::RenderTable::appendColumn): Factored out the section work
       
 65355         to RenderTableSection::appendColumn().
       
 65356         (WebCore::RenderTable::colElement):
       
 65357         (WebCore::RenderTable::recalcSections):
       
 65358         (WebCore::RenderTable::removeChildNode):
       
 65359         (WebCore::RenderTable::calcBorderLeft):
       
 65360         (WebCore::RenderTable::calcBorderRight):
       
 65361         (WebCore::RenderTable::outerBorderTop):
       
 65362         (WebCore::RenderTable::outerBorderBottom):
       
 65363         (WebCore::RenderTable::outerBorderLeft):
       
 65364         (WebCore::RenderTable::outerBorderRight):
       
 65365         (WebCore::RenderTable::sectionAbove):
       
 65366         (WebCore::RenderTable::sectionBelow):
       
 65367         (WebCore::RenderTable::cellAbove):
       
 65368         (WebCore::RenderTable::cellBelow):
       
 65369         (WebCore::RenderTable::cellBefore):
       
 65370         (WebCore::RenderTable::getOverflowClipRect):
       
 65371         (WebCore::RenderTable::dump):
       
 65372         * rendering/RenderTable.h:
       
 65373         (WebCore::RenderTable::getColumnPos):
       
 65374         (WebCore::RenderTable::hBorderSpacing):
       
 65375         (WebCore::RenderTable::vBorderSpacing):
       
 65376         (WebCore::RenderTable::getRules):
       
 65377         (WebCore::RenderTable::cellPadding):
       
 65378         (WebCore::RenderTable::setCellPadding):
       
 65379         (WebCore::RenderTable::ColumnStruct::ColumnStruct):
       
 65380         (WebCore::RenderTable::columns): Added this accessor.
       
 65381         (WebCore::RenderTable::columnPositions): Added this accessor.
       
 65382         (WebCore::RenderTable::header):
       
 65383         (WebCore::RenderTable::footer):
       
 65384         (WebCore::RenderTable::firstBody):
       
 65385         (WebCore::RenderTable::numEffCols):
       
 65386         (WebCore::RenderTable::spanOfEffCol):
       
 65387         (WebCore::RenderTable::colToEffCol):
       
 65388         (WebCore::RenderTable::effColToCol):
       
 65389         (WebCore::RenderTable::bordersPaddingAndSpacing):
       
 65390         (WebCore::RenderTable::needsSectionRecalc):
       
 65391         (WebCore::RenderTable::setNeedsSectionRecalc): Renamed setNeedSectionRecalc()
       
 65392         to this.
       
 65393         (WebCore::RenderTable::hasSections):
       
 65394         (WebCore::RenderTable::recalcSectionsIfNeeded):
       
 65395         * rendering/RenderTableCell.cpp:
       
 65396         (WebCore::RenderTableCell::RenderTableCell):
       
 65397         (WebCore::RenderTableCell::destroy):
       
 65398         (WebCore::RenderTableCell::updateFromElement):
       
 65399         (WebCore::RenderTableCell::styleOrColWidth):
       
 65400         (WebCore::RenderTableCell::computeAbsoluteRepaintRect):
       
 65401         (WebCore::RenderTableCell::absolutePosition):
       
 65402         (WebCore::RenderTableCell::baselinePosition):
       
 65403         (WebCore::RenderTableCell::setStyle):
       
 65404         (WebCore::compareBorders):
       
 65405         (WebCore::RenderTableCell::collapsedTopBorder):
       
 65406         (WebCore::RenderTableCell::paint):
       
 65407         (WebCore::collapsedBorderStyle):
       
 65408         (WebCore::CollapsedBorder::CollapsedBorder):
       
 65409         (WebCore::CollapsedBorders::CollapsedBorders):
       
 65410         (WebCore::CollapsedBorders::addBorder):
       
 65411         (WebCore::CollapsedBorders::nextBorder):
       
 65412         (WebCore::RenderTableCell::paintCollapsedBorder):
       
 65413         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
       
 65414         (WebCore::RenderTableCell::paintBoxDecorations):
       
 65415         (WebCore::RenderTableCell::dump):
       
 65416         * rendering/RenderTableCell.h:
       
 65417         (WebCore::RenderTableCell::colSpan):
       
 65418         (WebCore::RenderTableCell::setColSpan):
       
 65419         (WebCore::RenderTableCell::rowSpan):
       
 65420         (WebCore::RenderTableCell::setRowSpan):
       
 65421         (WebCore::RenderTableCell::col):
       
 65422         (WebCore::RenderTableCell::setCol):
       
 65423         (WebCore::RenderTableCell::row):
       
 65424         (WebCore::RenderTableCell::setRow):
       
 65425         (WebCore::RenderTableCell::section):
       
 65426         (WebCore::RenderTableCell::table):
       
 65427         (WebCore::RenderTableCell::yPos):
       
 65428         (WebCore::RenderTableCell::setCellTopExtra):
       
 65429         (WebCore::RenderTableCell::setCellBottomExtra):
       
 65430         (WebCore::RenderTableCell::borderTopExtra):
       
 65431         (WebCore::RenderTableCell::borderBottomExtra):
       
 65432         * rendering/RenderTableRow.cpp:
       
 65433         (WebCore::RenderTableRow::destroy):
       
 65434         (WebCore::RenderTableRow::setStyle):
       
 65435         (WebCore::RenderTableRow::addChild):
       
 65436         (WebCore::RenderTableRow::layout):
       
 65437         (WebCore::RenderTableRow::getAbsoluteRepaintRect):
       
 65438         (WebCore::RenderTableRow::paint):
       
 65439         * rendering/RenderTableRow.h:
       
 65440         (WebCore::RenderTableRow::section):
       
 65441         (WebCore::RenderTableRow::table):
       
 65442         (WebCore::RenderTableRow::lineHeight):
       
 65443         * rendering/RenderTableSection.cpp:
       
 65444         (WebCore::RenderTableSection::RenderTableSection):
       
 65445         (WebCore::RenderTableSection::destroy):
       
 65446         (WebCore::RenderTableSection::setStyle):
       
 65447         (WebCore::RenderTableSection::addChild):
       
 65448         (WebCore::RenderTableSection::ensureRows):
       
 65449         (WebCore::RenderTableSection::addCell):
       
 65450         (WebCore::RenderTableSection::setCellWidths):
       
 65451         (WebCore::RenderTableSection::calcRowHeight):
       
 65452         (WebCore::RenderTableSection::layoutRows):
       
 65453         (WebCore::RenderTableSection::lowestPosition):
       
 65454         (WebCore::RenderTableSection::rightmostPosition):
       
 65455         (WebCore::RenderTableSection::leftmostPosition):
       
 65456         (WebCore::RenderTableSection::calcOuterBorderTop):
       
 65457         (WebCore::RenderTableSection::calcOuterBorderBottom):
       
 65458         (WebCore::RenderTableSection::calcOuterBorderLeft):
       
 65459         (WebCore::RenderTableSection::calcOuterBorderRight):
       
 65460         (WebCore::RenderTableSection::paint):
       
 65461         (WebCore::RenderTableSection::recalcCells):
       
 65462         (WebCore::RenderTableSection::clearGrid):
       
 65463         (WebCore::RenderTableSection::numColumns):
       
 65464         (WebCore::RenderTableSection::appendColumn): Added. Moved code from
       
 65465         RenderTable::appendColumn() into here.
       
 65466         (WebCore::RenderTableSection::splitColumn): Added. Moved code from
       
 65467         RenderTable::splitColumn() into here.
       
 65468         (WebCore::RenderTableSection::removeChildNode):
       
 65469         (WebCore::RenderTableSection::dump):
       
 65470         * rendering/RenderTableSection.h:
       
 65471         (WebCore::RenderTableSection::renderName):
       
 65472         (WebCore::RenderTableSection::isTableSection):
       
 65473         (WebCore::RenderTableSection::lineHeight):
       
 65474         (WebCore::RenderTableSection::table):
       
 65475         (WebCore::RenderTableSection::cellAt):
       
 65476         (WebCore::RenderTableSection::numRows):
       
 65477         (WebCore::RenderTableSection::recalcCellsIfNeeded):
       
 65478         (WebCore::RenderTableSection::needsCellRecalc):
       
 65479         (WebCore::RenderTableSection::setNeedsCellRecalc):
       
 65480         (WebCore::RenderTableSection::getBaseline):
       
 65481         * rendering/TableLayout.h:
       
 65482 
       
 65483 2007-01-04  Anders Carlsson  <acarlsson@apple.com>
       
 65484 
       
 65485         Reviewed by Adam.
       
 65486 
       
 65487         http://bugs.webkit.org/show_bug.cgi?id=12120
       
 65488         REGRESSION(r18605): Safari snippet editor no longer works
       
 65489         
       
 65490         * loader/mac/ResourceLoaderMac.mm:
       
 65491         (WebCore::ResourceLoader::willSendRequest):
       
 65492         Fix logic so applewebdata: URLs no longer cause the underlying URL to be fetched .
       
 65493 
       
 65494 2007-01-04  Anders Carlsson  <acarlsson@apple.com>
       
 65495 
       
 65496         Reviewed by Adam.
       
 65497 
       
 65498         Move all remaining instances of NSURLRequest over to ResourceRequest (well, pretty much all).
       
 65499 
       
 65500         * loader/MainResourceLoader.h:
       
 65501         * loader/ResourceLoader.h:
       
 65502         * loader/SubresourceLoader.h:
       
 65503         * loader/mac/FrameLoaderMac.mm:
       
 65504         (WebCore::FrameLoader::startLoadingMainResource):
       
 65505         * loader/mac/MainResourceLoaderMac.mm:
       
 65506         (WebCore::MainResourceLoader::loadNow):
       
 65507         (WebCore::MainResourceLoader::load):
       
 65508         (WebCore::MainResourceLoader::setDefersLoading):
       
 65509         * loader/mac/ResourceLoaderMac.mm:
       
 65510         (WebCore::ResourceLoader::load):
       
 65511         * loader/mac/SubresourceLoaderMac.mm:
       
 65512         (WebCore::SubresourceLoader::load):
       
 65513         (WebCore::SubresourceLoader::create):
       
 65514         * platform/graphics/svg/SVGImage.cpp:
       
 65515         (WebCore::SVGImage::setData):
       
 65516         * platform/network/mac/ResourceRequestMac.mm:
       
 65517         (WebCore::ResourceRequest::doUpdatePlatformRequest):
       
 65518 
       
 65519 2007-01-04  Anders Carlsson  <acarlsson@apple.com>
       
 65520 
       
 65521         Reviewed by Brady.
       
 65522 
       
 65523         Move more NSURLRequests over to ResourceRequests.
       
 65524         
       
 65525         * loader/DocumentLoader.h:
       
 65526         * loader/FrameLoader.h:
       
 65527         * loader/FrameLoaderClient.h:
       
 65528         * loader/MainResourceLoader.h:
       
 65529         * loader/ResourceLoader.h:
       
 65530         (WebCore::ResourceLoader::request):
       
 65531         * loader/SubresourceLoader.h:
       
 65532         * loader/mac/FrameLoaderMac.mm:
       
 65533         (WebCore::FrameLoader::willSendRequest):
       
 65534         (WebCore::FrameLoader::opened):
       
 65535         (WebCore::FrameLoader::requestFromDelegate):
       
 65536         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
       
 65537         (WebCore::FrameLoader::loadResourceSynchronously):
       
 65538         * loader/mac/MainResourceLoaderMac.mm:
       
 65539         (WebCore::MainResourceLoader::willSendRequest):
       
 65540         (WebCore::MainResourceLoader::continueAfterContentPolicy):
       
 65541         (WebCore::MainResourceLoader::loadNow):
       
 65542         (WebCore::MainResourceLoader::setDefersLoading):
       
 65543         * loader/mac/ResourceLoaderMac.mm:
       
 65544         (WebCore::ResourceLoader::load):
       
 65545         (WebCore::ResourceLoader::willSendRequest):
       
 65546         (WebCore::ResourceLoader::didReceiveResponse):
       
 65547         (WebCore::ResourceLoader::cancelledError):
       
 65548         * loader/mac/SubresourceLoaderMac.mm:
       
 65549         (WebCore::SubresourceLoader::willSendRequest):
       
 65550         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 65551         (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest):
       
 65552         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
       
 65553         * platform/network/ResourceRequest.cpp:
       
 65554         (WebCore::ResourceRequest::isNull):
       
 65555         * platform/network/ResourceRequest.h:
       
 65556 
       
 65557 2007-01-04  Brady Eidson  <beidson@apple.com>
       
 65558 
       
 65559         Reviewed by Mark Rowe
       
 65560 
       
 65561         http://bugs.webkit.org/show_bug.cgi?id=12119
       
 65562         Changing the behavior of HistoryItem::pageCache() this morning also necessitated
       
 65563         changing the behavior of HistoryItem::hasPageCache()
       
 65564 
       
 65565         * history/HistoryItem.cpp:
       
 65566         (WebCore::HistoryItem::hasPageCache): Add the same pendingRelease check pageCache() has
       
 65567 
       
 65568 2007-01-04  Mitz Pettel  <mitz@webkit.org>
       
 65569 
       
 65570         Reviewed by Sam Weinig.
       
 65571 
       
 65572         - fix http://bugs.webkit.org/show_bug.cgi?id=12043
       
 65573           Another assertion failure in WebCore::RenderObject::drawBorder
       
 65574 
       
 65575         Test: fast/borders/border-radius-huge-assert.html
       
 65576 
       
 65577         * platform/graphics/cg/GraphicsContextCG.cpp:
       
 65578         (WebCore::GraphicsContext::addRoundedRectClip): Fixed the check for border radii
       
 65579         that do not fit in the given width or height to work with radii that sum up to
       
 65580         more than MAX_INT.
       
 65581         * rendering/RenderObject.cpp:
       
 65582         (WebCore::RenderObject::paintBorder): Ditto.
       
 65583 
       
 65584 2007-01-04  Justin Garcia  <justin.garcia@apple.com>
       
 65585 
       
 65586         Reviewed by john
       
 65587 
       
 65588         <rdar://problem/4861080>
       
 65589         GMail Editor: Crash when dropping content into certain list items
       
 65590         
       
 65591         A rendering bug (4907469) creates unwanted space at the top of a 
       
 65592         list item when its contents are wrapped in span.  Dropping content 
       
 65593         inside that space causes a crash because positionForCoordinates 
       
 65594         fails there and the code that creates drag carets can't handle it.
       
 65595 
       
 65596         * page/mac/WebCoreFrameBridge.mm:
       
 65597         (-[WebCoreFrameBridge _visiblePositionForPoint:]): Added the
       
 65598         that's inside click handling for the case where 
       
 65599         positionForCoordinates returns null.  We should also fix 
       
 65600         positionForCoordinates but that's less important: now its only side 
       
 65601         effect is that a no-op drop is performed instead of a snap back 
       
 65602         when you drop the contents of one of these list items its own 
       
 65603         unwanted space.
       
 65604 
       
 65605 2007-01-04  Beth Dakin  <bdakin@apple.com>
       
 65606 
       
 65607         Reviewed by Adam.
       
 65608 
       
 65609         Fix for http://bugs.webkit.org/show_bug.cgi?id=12118 REGRESSION 
       
 65610         (Context menus): No context menu displayed when clicking outside a 
       
 65611         short document
       
 65612 
       
 65613         No test case added since we do not currently have a way to automate 
       
 65614         context menus. 
       
 65615 
       
 65616         * page/ContextMenuController.cpp:
       
 65617         (WebCore::ContextMenuController::handleContextMenuEvent): If the 
       
 65618         hit test does not find a node, use the document node.
       
 65619 
       
 65620 2007-01-04  Anders Carlsson  <acarlsson@apple.com>
       
 65621 
       
 65622         Reviewed by Adam.
       
 65623 
       
 65624         Convert NSURLRequest to ResourceRequest in a few places
       
 65625 
       
 65626         * loader/FrameLoader.h:
       
 65627         * loader/FrameLoaderClient.h:
       
 65628         * loader/MainResourceLoader.h:
       
 65629         * loader/mac/FrameLoaderMac.mm:
       
 65630         (WebCore::FrameLoader::identifierForInitialRequest):
       
 65631         (WebCore::FrameLoader::willUseArchive):
       
 65632         * loader/mac/MainResourceLoaderMac.mm:
       
 65633         (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
       
 65634         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 65635         (WebCore::SVGEmptyFrameLoaderClient::download):
       
 65636         (WebCore::SVGEmptyFrameLoaderClient::willUseArchive):
       
 65637 
       
 65638 2007-01-04  David Hyatt  <hyatt@apple.com>
       
 65639 
       
 65640         Bug 12114 fix, make sure left/right floats are allowed to go above
       
 65641         other floats of opposite alignment.
       
 65642 
       
 65643         Reviewed by aroben
       
 65644 
       
 65645         fast/block/float/independent-align-positioning.html
       
 65646 
       
 65647         * rendering/RenderBlock.cpp:
       
 65648         (WebCore::RenderBlock::positionNewFloats):
       
 65649 
       
 65650 2007-01-04  Anders Carlsson  <acarlsson@apple.com>
       
 65651 
       
 65652         Reviewed by Brady.
       
 65653 
       
 65654         http://bugs.webkit.org/show_bug.cgi?id=12116
       
 65655         REGRESSION: ASSERTION FAILED: URL in +[WebDataProtocol _webIsDataProtocolURL:]
       
 65656         
       
 65657         <rdar://problem/4908910> 
       
 65658         REGRESSION: After switching to Bookmarks view, the browser window is completely empty (no bookmarks are displayed)
       
 65659         
       
 65660         * platform/network/ResourceResponse.h:
       
 65661         (WebCore::ResourceResponse::ResourceResponse):
       
 65662         Initialize m_isNull
       
 65663 
       
 65664 2007-01-04  Beth Dakin  <bdakin@apple.com>
       
 65665 
       
 65666         Reviewed by Adam.
       
 65667 
       
 65668         Turn on WebCore context menus.
       
 65669 
       
 65670         * dom/EventTargetNode.cpp:
       
 65671         (WebCore::EventTargetNode::defaultEventHandler): Turn on WebCore 
       
 65672         menus.
       
 65673         * page/ContextMenuClient.h: Name change and have the 
       
 65674         former getCustomMenuFromDefaultItems function return the 
       
 65675         PlatformMenuDescription since it feels funny to have the client set 
       
 65676         the new platform description.
       
 65677         * page/ContextMenuController.cpp:
       
 65678         (WebCore::ContextMenuController::handleContextMenuEvent): Above 
       
 65679         name change.
       
 65680         (WebCore::ContextMenuController::contextMenuItemSelected): Use 
       
 65681         local variable.
       
 65682         * platform/ContextMenu.cpp:
       
 65683         (WebCore::createAndAppendSpeechSubMenu): Fix silly mistake -- make 
       
 65684         "Stop speaking" actually stop speaking.
       
 65685         * platform/graphics/svg/SVGImageEmptyClients.h: Name change and 
       
 65686         have the former getCustomMenuFromDefaultItems function return the 
       
 65687         PlatformMenuDescription since it feels funny to have the client set 
       
 65688         the new platform description.
       
 65689        (WebCore::SVGEmptyContextMenuClient::getCustomMenuFromDefaultItems):
       
 65690 
       
 65691 2007-01-04  Mitz Pettel  <mitz@webkit.org>
       
 65692 
       
 65693         Reviewed and landed by Brady
       
 65694 
       
 65695         - fix http://bugs.webkit.org/show_bug.cgi?id=12087
       
 65696           REGRESSION: Reproducible crash going back in Back/Forward history
       
 65697 
       
 65698         Allow a PageCache that is pending release to be resurrected by its
       
 65699         HistoryItem instead of creating a new PageCache. This avoids the
       
 65700         the condition of having two PageCaches for the same HistoryItem, one
       
 65701         current and one pending release but not yet released, which was causing
       
 65702         this and other bugs before.
       
 65703         
       
 65704         Replaced the vector of PageCaches pending release with a set of
       
 65705         HistoryItems that are pending release of their PageCache.
       
 65706 
       
 65707         * history/HistoryItem.cpp:
       
 65708         (WebCore::HistoryItem::HistoryItem):
       
 65709         (WebCore::HistoryItem::setHasPageCache): Check for an existing PageCache
       
 65710         pending release, and if found, resurrect it by canceling the release.
       
 65711         (WebCore::HistoryItem::pageCache): Return 0 if the PageCache is pending
       
 65712         release.
       
 65713         (WebCore::itemsWithPendingPageCacheToRelease): Renamed pendingPageCacheToRelease
       
 65714         to this. This method now returns a HashSet of HistoryItems that have scheduled
       
 65715         their PageCaches for release.
       
 65716         (WebCore::HistoryItem::releasePageCachesOrReschedule): Renamed releasePageCache
       
 65717         to this.
       
 65718         (WebCore::HistoryItem::releasePageCache): Added. Actually closes and releases
       
 65719         the PageCache.
       
 65720         (WebCore::HistoryItem::releaseAllPendingPageCaches): Rolled closeObjectsInPendingPageCaches
       
 65721         into this method.
       
 65722         (WebCore::HistoryItem::scheduleRelease):
       
 65723         (WebCore::HistoryItem::cancelRelease): Added.
       
 65724         * history/HistoryItem.h: Removed unused declaration of scheduleReleaseTimer()
       
 65725         * history/HistoryItemTimer.cpp:
       
 65726         (WebCore::HistoryItemTimer::HistoryItemTimer):
       
 65727         (WebCore::HistoryItemTimer::callReleasePageCachesOrReschedule):
       
 65728         * history/HistoryItemTimer.h:
       
 65729 
       
 65730 2007-01-04  David Hyatt  <hyatt@apple.com>
       
 65731 
       
 65732         Just make the synthetic bold offset always be 1.0.  This fixes bug
       
 65733         9534, synthetic bold looks doubled.
       
 65734 
       
 65735         Reviewed by olliej
       
 65736 
       
 65737         * platform/mac/FontDataMac.mm:
       
 65738         (WebCore::FontData::platformInit):
       
 65739 
       
 65740 2007-01-04  Anders Carlsson  <acarlsson@apple.com>
       
 65741 
       
 65742         Reviewed by Brady.
       
 65743 
       
 65744         Convert almost all occurrences of NSURLResponse to ResourceResponse.
       
 65745 
       
 65746         * WebCore.exp:
       
 65747         * loader/DocumentLoader.h:
       
 65748         * loader/FrameLoader.h:
       
 65749         * loader/FrameLoaderClient.h:
       
 65750         * loader/MainResourceLoader.h:
       
 65751         * loader/NetscapePlugInStreamLoader.h:
       
 65752         * loader/ResourceLoader.h:
       
 65753         * loader/SubresourceLoader.h:
       
 65754         * loader/loader.h:
       
 65755         * loader/mac/FrameLoaderMac.mm:
       
 65756         (WebCore::FrameLoader::willSendRequest):
       
 65757         (WebCore::FrameLoader::didReceiveResponse):
       
 65758         (WebCore::FrameLoader::opened):
       
 65759         (WebCore::FrameLoader::sendRemainingDelegateMessages):
       
 65760         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
       
 65761         (WebCore::FrameLoader::loadResourceSynchronously):
       
 65762         * loader/mac/LoaderFunctionsMac.mm:
       
 65763         (WebCore::CheckCacheObjectStatus):
       
 65764         * loader/mac/MainResourceLoaderMac.mm:
       
 65765         (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
       
 65766         (WebCore::MainResourceLoader::willSendRequest):
       
 65767         (WebCore::MainResourceLoader::continueAfterContentPolicy):
       
 65768         (WebCore::MainResourceLoader::didReceiveResponse):
       
 65769         (WebCore::MainResourceLoader::loadNow):
       
 65770         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
       
 65771         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
       
 65772         * loader/mac/ResourceLoaderMac.mm:
       
 65773         (WebCore::ResourceLoader::willSendRequest):
       
 65774         (WebCore::ResourceLoader::didReceiveResponse):
       
 65775         (WebCore::ResourceLoader::response):
       
 65776         * loader/mac/SubresourceLoaderMac.mm:
       
 65777         (WebCore::SubresourceLoader::willSendRequest):
       
 65778         (WebCore::SubresourceLoader::didReceiveResponse):
       
 65779         * platform/graphics/svg/SVGImageEmptyClients.h:
       
 65780         (WebCore::SVGEmptyFrameLoaderClient::download):
       
 65781         (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest):
       
 65782         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse):
       
 65783         (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
       
 65784         (WebCore::SVGEmptyFrameLoaderClient::incrementProgress):
       
 65785         * platform/network/ResourceHandle.h:
       
 65786         * platform/network/ResourceHandleClient.h:
       
 65787         * platform/network/ResourceResponse.cpp:
       
 65788         (WebCore::ResourceResponse::isHTTP):
       
 65789         * platform/network/ResourceResponse.h:
       
 65790         (WebCore::ResourceResponse::ResourceResponse):
       
 65791         (WebCore::ResourceResponse::isNull):
       
 65792         * platform/network/mac/ResourceResponseMac.mm:
       
 65793         (WebCore::ResourceResponse::nsURLResponse):
       
 65794         (WebCore::ResourceResponse::doUpdateResourceResponse):
       
 65795 
       
 65796 2007-01-03  Adele Peterson  <adele@apple.com>
       
 65797 
       
 65798         Reviewed by Darin.
       
 65799 
       
 65800         - Fix for <rdar://problem/4887422>
       
 65801         http://bugs.webkit.org/show_bug.cgi?id=11848
       
 65802         REGRESSION (SearchField): Search field on developer.apple.com not drawn with top/bottom borders (11848)
       
 65803 
       
 65804         Test: fast/forms/searchfield-heights.html
       
 65805 
       
 65806         Override the border and the height for search fields that use -webkit-appearance: searchfield.
       
 65807 
       
 65808         * css/html4.css: Use box-sizing: border-box for search fields.  We don't need to have the border-box quirk
       
 65809           that we use for the other text fields for this control.
       
 65810         * rendering/RenderThemeMac.h:
       
 65811         * rendering/RenderThemeMac.mm:
       
 65812         (WebCore::RenderThemeMac::searchFieldSizes): Added.
       
 65813         (WebCore::RenderThemeMac::setSearchFieldSize): Added.
       
 65814         (WebCore::RenderThemeMac::adjustSearchFieldStyle): Override the border and the height of the search field.
       
 65815 
       
 65816 2007-01-04  Lars Knoll <lars@trolltech.com>
       
 65817 
       
 65818         * platform/qt/TemporaryLinkStubs.cpp:
       
 65819         (WebCore::inputElementAltText):
       
 65820         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
       
 65821         (WebCore::contextMenuItemTagDownloadLinkToDisk):
       
 65822         (WebCore::contextMenuItemTagCopyLinkToClipboard):
       
 65823         (WebCore::contextMenuItemTagOpenImageInNewWindow):
       
 65824         (WebCore::contextMenuItemTagDownloadImageToDisk):
       
 65825         (WebCore::contextMenuItemTagCopyImageToClipboard):
       
 65826         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
       
 65827         (WebCore::contextMenuItemTagCopy):
       
 65828         (WebCore::contextMenuItemTagGoBack):
       
 65829         (WebCore::contextMenuItemTagGoForward):
       
 65830         (WebCore::contextMenuItemTagStop):
       
 65831         (WebCore::contextMenuItemTagReload):
       
 65832         (WebCore::contextMenuItemTagCut):
       
 65833         (WebCore::contextMenuItemTagPaste):
       
 65834         (WebCore::contextMenuItemTagNoGuessesFound):
       
 65835         (WebCore::contextMenuItemTagIgnoreSpelling):
       
 65836         (WebCore::contextMenuItemTagLearnSpelling):
       
 65837         (WebCore::contextMenuItemTagSearchWeb):
       
 65838         (WebCore::contextMenuItemTagLookUpInDictionary):
       
 65839         (WebCore::contextMenuItemTagOpenLink):
       
 65840         (WebCore::contextMenuItemTagIgnoreGrammar):
       
 65841         (WebCore::contextMenuItemTagSpellingMenu):
       
 65842         (WebCore::contextMenuItemTagShowSpellingPanel):
       
 65843         (WebCore::contextMenuItemTagCheckSpelling):
       
 65844         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
       
 65845         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
       
 65846         (WebCore::contextMenuItemTagFontMenu):
       
 65847         (WebCore::contextMenuItemTagBold):
       
 65848         (WebCore::contextMenuItemTagItalic):
       
 65849         (WebCore::contextMenuItemTagUnderline):
       
 65850         (WebCore::contextMenuItemTagOutline):
       
 65851         (WebCore::contextMenuItemTagWritingDirectionMenu):
       
 65852         (WebCore::contextMenuItemTagDefaultDirection):
       
 65853         (WebCore::contextMenuItemTagLeftToRight):
       
 65854         (WebCore::contextMenuItemTagRightToLeft):
       
 65855             Added missing stubs.
       
 65856 
       
 65857 2007-01-04  Don Gibson  <dgibson77@gmail.com>
       
 65858 
       
 65859         Reviewed by Alexey.
       
 65860 
       
 65861         http://bugs.webkit.org/show_bug.cgi?id=11900:
       
 65862         Windows build bustage
       
 65863 
       
 65864         * WebCore.vcproj/WebCore/WebCore.vcproj:
       
 65865         * bridge/win/FrameWin.cpp:
       
 65866         (WebCore::FrameWin::FrameWin):
       
 65867         * platform/graphics/BitmapImage.h:
       
 65868         * platform/graphics/GraphicsContext.cpp:
       
 65869         (WebCore::GraphicsContext::setPlatformStrokeColor):
       
 65870         * platform/graphics/Image.h:
       
 65871         * platform/graphics/cairo/GraphicsContextCairo.cpp:
       
 65872         (WebCore::GraphicsContext::drawRect):
       
 65873         (WebCore::adjustLineToPixelBoundaries):
       
 65874         (WebCore::GraphicsContext::drawLine):
       
 65875         (WebCore::GraphicsContext::drawEllipse):
       
 65876         (WebCore::GraphicsContext::strokeArc):
       
 65877         (WebCore::GraphicsContext::drawConvexPolygon):
       
 65878         * platform/graphics/cairo/ImageCairo.cpp:
       
 65879         (WebCore::BitmapImage::checkForSolidColor):
       
 65880         (WebCore::BitmapImage::draw):
       
 65881         (WebCore::BitmapImage::drawTiled):
       
 65882         * platform/graphics/win/ImageWin.cpp:
       
 65883         (WebCore::BitmapImage::initPlatformData):
       
 65884         (WebCore::BitmapImage::invalidatePlatformData):
       
 65885         (WebCore::Image::loadPlatformResource):
       
 65886         * platform/win/FontWin.cpp:
       
 65887         (WebCore::Font::drawGlyphs):
       
 65888         * platform/win/TemporaryLinkStubs.cpp:
       
 65889         (WebCore::userIdleTime):
       
 65890         (WebCore::BitmapImage::drawTiled):
       
 65891         (WebCore::BitmapImage::getHBITMAP):
       
 65892         (WebCore::ContextMenu::~ContextMenu):
       
 65893         (WebCore::ContextMenu::appendItem):
       
 65894         (WebCore::ContextMenuItem::ContextMenuItem):
       
 65895         (WebCore::ContextMenuItem::releasePlatformDescription):
       
 65896         (WebCore::ContextMenuItem::type):
       
 65897         (WebCore::ContextMenuItem::setType):
       
 65898         (WebCore::ContextMenuItem::setAction):
       
 65899         (WebCore::ContextMenuItem::setTitle):
       
 65900         (WebCore::ContextMenuItem::setSubMenu):
       
 65901         (WebCore::ContextMenuItem::setChecked):
       
 65902         (WebCore::ContextMenuItem::setEnabled):
       
 65903         (WebCore::DocumentLoader::originalRequest):
       
 65904         (WebCore::DocumentLoader::request):
       
 65905         (WebCore::DocumentLoader::unreachableURL):
       
 65906         (WebCore::DocumentLoader::getResponseRefreshAndModifiedHeaders):
       
 65907         (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
       
 65908         (WebCore::DocumentLoader::setCommitted):
       
 65909         (WebCore::DocumentLoader::isLoading):
       
 65910         (WebCore::DocumentLoader::prepareForLoadStart):
       
 65911         (WebCore::DocumentLoader::isClientRedirect):
       
 65912         (WebCore::DocumentLoader::title):
       
 65913         (WebCore::DocumentLoader::urlForHistory):
       
 65914         (WebCore::Editor::markMisspellingsAfterTypingToPosition):
       
 65915         (WebCore::FrameLoader::load):
       
 65916         (WebCore::FrameLoader::referrer):
       
 65917         (WebCore::FrameLoader::dataURLBaseFromRequest):
       
 65918         (WebCore::FrameLoader::opened):
       
 65919         (WebCore::FrameLoader::applyUserAgent):
       
 65920         (WebCore::GraphicsContext::strokeRect):
       
 65921         (WebCore::IconDatabase::iconForPageURL):
       
 65922         (WebCore::IconDatabase::defaultIcon):
       
 65923         (WebCore::IconDatabase::retainIconForPageURL):
       
 65924         (WebCore::IconDatabase::releaseIconForPageURL):
       
 65925         (WebCore::PageCache::close):
       
 65926         (WebCore::ResourceHandle::willLoadFromCache):
       
 65927         (WebCore::SearchPopupMenu::saveRecentSearches):
       
 65928         (WebCore::SearchPopupMenu::loadRecentSearches):
       
 65929         (WebCore::SearchPopupMenu::SearchPopupMenu):
       
 65930 
       
 65931 2007-01-04  Alexey Proskuryakov  <ap@webkit.org>
       
 65932 
       
 65933         Reviewed by Darin.
       
 65934 
       
 65935         http://bugs.webkit.org/show_bug.cgi?id=11611
       
 65936         REGRESSION: No http referer header sent on XMLHttpRequest
       
 65937 
       
 65938         Test: http/tests/xmlhttprequest/referer.html
       
 65939 
       
 65940         * loader/FrameLoader.h: Removed FrameLoader::addExtraFieldsToRequest(NSMutableURLRequest*, bool, bool),
       
 65941         which is no longer used.
       
 65942         * loader/mac/FrameLoaderMac.mm: Ditto.
       
 65943         * WebCore.exp: Do not export this method (WebKit doesn't use it).
       
 65944 
       
 65945         * loader/mac/SubresourceLoaderMac.mm:
       
 65946         (WebCore::SubresourceLoader::create): Rewrote to create the request with ResourceRequest::nsURLRequest.
       
 65947 
       
 65948         * platform/PlatformString.h:
       
 65949         (WebCore::operator!): Added. Previously, attempts to use operator! on a String would result 
       
 65950         with an NSString* conversion, which never returns nil. This was causing a problem in SubresourceLoader::create().
       
 65951 
       
 65952 2007-01-04  Lars Knoll <lars@trolltech.com>
       
 65953 
       
 65954 
       
 65955         Make the Qt build compile again.
       
 65956 
       
 65957         * platform/ContextMenu.cpp:
       
 65958         (WebCore::ContextMenu::populate):
       
 65959 
       
 65960 2007-01-03  Mitz Pettel  <mitz@webkit.org>
       
 65961 
       
 65962         Reviewed by Hyatt.
       
 65963 
       
 65964         - fix http://bugs.webkit.org/show_bug.cgi?id=5164
       
 65965           Non-integer percentages are incorrectly rounded down in Safari
       
 65966 
       
 65967         Test: fast/css/percentage-non-integer.html
       
 65968 
       
 65969         Added floating point constructor and accessors to Length for use with
       
 65970         Percent lengths only. The raw value of a percent length is the integer
       
 65971         part of a constant multiple of the original double value. The constant
       
 65972         is percentScaleFactor, which is currently 128.
       
 65973         
       
 65974         Added assertions that the correct constructors and accessors are used
       
 65975         depending on the type: the double-based percent(), setValue() and Length()
       
 65976         for the Percent type, and the integer-based value(), setValue() and Length()
       
 65977         for all other types.
       
 65978         
       
 65979         calcValue() and calcMinValue() work the same as before, regardless of the
       
 65980         type.
       
 65981 
       
 65982         Added helpers for testing if the value is 0, positive, negative or undefined
       
 65983         without having to check the type first.
       
 65984         
       
 65985         Added raw value accessors. These are useful for doing integer math and
       
 65986         comparisons with scaled percent values or doing Length type-agnostic math.
       
 65987 
       
 65988         Changed the rest of the code to use the appropriate accessors and helpers.
       
 65989 
       
 65990         * css/CSSComputedStyleDeclaration.cpp:
       
 65991         (WebCore::valueForLength):
       
 65992         (WebCore::primitiveValueFromLength):
       
 65993         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 65994         * css/cssstyleselector.cpp:
       
 65995         (WebCore::convertToLength):
       
 65996         (WebCore::CSSStyleSelector::applyProperty):
       
 65997         (WebCore::CSSStyleSelector::mapBackgroundSize):
       
 65998         (WebCore::CSSStyleSelector::mapBackgroundXPosition):
       
 65999         (WebCore::CSSStyleSelector::mapBackgroundYPosition):
       
 66000         * platform/StringImpl.cpp:
       
 66001         (WebCore::parseLength):
       
 66002         * rendering/AutoTableLayout.cpp:
       
 66003         (WebCore::AutoTableLayout::recalcColumn):
       
 66004         (WebCore::AutoTableLayout::fullRecalc):
       
 66005         (WebCore::AutoTableLayout::calcMinMaxWidth):
       
 66006         (WebCore::AutoTableLayout::calcEffectiveWidth):
       
 66007         (WebCore::AutoTableLayout::layout):
       
 66008         (WebCore::AutoTableLayout::calcPercentages):
       
 66009         * rendering/FixedTableLayout.cpp:
       
 66010         (WebCore::FixedTableLayout::calcWidthArray):
       
 66011         (WebCore::FixedTableLayout::layout):
       
 66012         * rendering/Length.h:
       
 66013         (WebCore::Length::Length):
       
 66014         (WebCore::Length::value):
       
 66015         (WebCore::Length::rawValue):
       
 66016         (WebCore::Length::percent):
       
 66017         (WebCore::Length::setValue):
       
 66018         (WebCore::Length::setRawValue):
       
 66019         (WebCore::Length::calcValue):
       
 66020         (WebCore::Length::calcMinValue):
       
 66021         (WebCore::Length::isUndefined):
       
 66022         (WebCore::Length::isZero):
       
 66023         (WebCore::Length::isPositive):
       
 66024         (WebCore::Length::isNegative):
       
 66025         * rendering/RenderBR.cpp:
       
 66026         (WebCore::RenderBR::lineHeight):
       
 66027         * rendering/RenderBlock.cpp:
       
 66028         (WebCore::RenderBlock::isSelfCollapsingBlock):
       
 66029         * rendering/RenderBox.cpp:
       
 66030         (WebCore::cacluateBackgroundSize):
       
 66031         (WebCore::RenderBox::calcWidth):
       
 66032         (WebCore::RenderBox::calcHeight):
       
 66033         (WebCore::RenderBox::calcReplacedWidth):
       
 66034         (WebCore::RenderBox::calcReplacedHeight):
       
 66035         (WebCore::RenderBox::calcAbsoluteHorizontal):
       
 66036         (WebCore::RenderBox::calcAbsoluteVertical):
       
 66037         * rendering/RenderFlexibleBox.cpp:
       
 66038         (WebCore::RenderFlexibleBox::allowedChildFlex):
       
 66039         * rendering/RenderFlow.cpp:
       
 66040         (WebCore::RenderFlow::lineHeight):
       
 66041         * rendering/RenderImage.cpp:
       
 66042         (WebCore::RenderImage::calcReplacedWidth):
       
 66043         (WebCore::RenderImage::calcReplacedHeight):
       
 66044         * rendering/RenderLayer.cpp:
       
 66045         (WebCore::Marquee::direction):
       
 66046         (WebCore::Marquee::start):
       
 66047         * rendering/RenderObject.cpp:
       
 66048         (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
       
 66049         (WebCore::RenderObject::lineHeight):
       
 66050         * rendering/RenderSlider.cpp:
       
 66051         (WebCore::RenderSlider::layout): Added FIXMEs.
       
 66052         * rendering/RenderStyle.h:
       
 66053         (WebCore::LengthBox::nonZero):
       
 66054         (WebCore::RenderStyle::initialLineHeight):
       
 66055         * rendering/RenderTable.cpp:
       
 66056         (WebCore::RenderTable::calcWidth):
       
 66057         * rendering/RenderTableSection.cpp:
       
 66058         (WebCore::RenderTableSection::addCell):
       
 66059         (WebCore::RenderTableSection::layoutRows):
       
 66060 
       
 66061 2007-01-03  Mitz Pettel  <mitz@webkit.org>
       
 66062 
       
 66063         Reviewed by Hyatt.
       
 66064 
       
 66065         - fix http://bugs.webkit.org/show_bug.cgi?id=11744
       
 66066           Setting the 'content' property dynamically has no effect
       
 66067 
       
 66068         Test: fast/css/content-dynamic.html
       
 66069 
       
 66070         * dom/Node.cpp:
       
 66071         (WebCore::Node::diff): Changed to return 'Detach' if the styles' content
       
 66072         data are not equivalent.
       
 66073 
       
 66074 2007-01-03  Mitz Pettel  <mitz@webkit.org>
       
 66075 
       
 66076         Reviewed by Darin.
       
 66077 
       
 66078         - fix http://bugs.webkit.org/show_bug.cgi?id=12082
       
 66079           REGRESSION (r18333): Crash in RenderFrameSet::layOutAxis()
       
 66080 
       
 66081         Test: fast/frames/negative-remaining-length-crash.html
       
 66082 
       
 66083         * rendering/RenderFrameSet.cpp:
       
 66084         (WebCore::RenderFrameSet::layOutAxis): Treat negative availableLength
       
 66085         as zero.
       
 66086 
       
 66087 2007-01-03  John Sullivan  <sullivan@apple.com>
       
 66088 
       
 66089         Written by Darin over my shoulder; reviewed by me
       
 66090 
       
 66091         - fixed <rdar://problem/4907437> Find doesn't work if invoked when a form field is focused
       
 66092 
       
 66093         * page/Frame.cpp:
       
 66094         (WebCore::isInShadowTree):
       
 66095         new helper function used by findString
       
 66096         (WebCore::Frame::findString):
       
 66097         when deciding whether to start from the selection, ignore selections that are in
       
 66098         a shadow tree (i.e. in a form control)
       
 66099 
       
 66100 2007-01-03  Brady Eidson  <beidson@apple.com>
       
 66101 
       
 66102         Reviewed by Mark Rowe
       
 66103 
       
 66104         Fixes http://bugs.webkit.org/show_bug.cgi?id=12089
       
 66105 
       
 66106         * loader/FrameLoader.cpp:
       
 66107         (WebCore::FrameLoader::updateHistoryForCommit): Null check the documentLoader
       
 66108 
       
 66109 2007-01-03  David Hyatt  <hyatt@apple.com>
       
 66110 
       
 66111         Relax the display type restriction a little bit for generated content inside
       
 66112         inlines.  We still don't allow block display types like we should (since this
       
 66113         will cause a crash), but we at least handle inline-table and inline-block now.
       
 66114 
       
 66115         Reviewed by beth
       
 66116 
       
 66117         fast/css-generated-content/inline-display-types.html
       
 66118 
       
 66119         * rendering/RenderContainer.cpp:
       
 66120         (WebCore::RenderContainer::updatePseudoChildForObject):
       
 66121 
       
 66122 2007-01-03  Justin Garcia  <justin.garcia@apple.com>
       
 66123 
       
 66124         Reviewed by john
       
 66125         
       
 66126         <rdar://problem/4663571> Spell checking won't cross boundary of individual To-Do item
       
 66127         
       
 66128         No layout tests because advanceToNextMisspelling isn't yet exposed to automated tests.
       
 66129 
       
 66130         * editing/mac/EditorMac.mm:
       
 66131         (WebCore::Editor::advanceToNextMisspelling): Confine spell checking to
       
 66132         the highest editable root, instead of the lowest.  Use firstEditablePosition...
       
 66133         to look for an editable position.
       
 66134 
       
 66135 2007-01-03  Beth Dakin  <bdakin@apple.com>
       
 66136 
       
 66137         Fixing silly mistake. 
       
 66138 
       
 66139         * platform/ContextMenu.cpp:
       
 66140         (WebCore::ContextMenu::checkOrEnableIfNeeded): Called wrong string 
       
 66141         function.
       
 66142 
       
 66143 2007-01-03  Brady Eidson  <beidson@apple.com>
       
 66144 
       
 66145         Reviewed by Anders
       
 66146 
       
 66147         http://bugs.webkit.org/show_bug.cgi?id=12093 - Assertion in certain SVG layout tests
       
 66148         I can't really think of a cleaner way to fix this then to help these SVG cases avoid
       
 66149         the ASSERT - hopefully we can clean up the svg-as-image situation as the loader stabilizes 
       
 66150         and we find better ways to handle it...
       
 66151 
       
 66152         * loader/mac/DocumentLoaderMac.mm:
       
 66153         (WebCore::DocumentLoader::urlForHistory): empty-check the url before passing it to the
       
 66154         ASSERTing method
       
 66155 
       
 66156 2007-01-03  Darin Adler  <darin@apple.com>
       
 66157 
       
 66158         Reviewed by Adele.
       
 66159 
       
 66160         - removed some obsolete source files
       
 66161 
       
 66162         * CMakeLists.txt: Removed obsolete files.
       
 66163         * WebCore.pro: Ditto.
       
 66164         * WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
       
 66165         * WebCore.xcodeproj/project.pbxproj: Ditto.
       
 66166         * WebCoreSources.bkl: Ditto.
       
 66167 
       
 66168         * html/HTMLGenericFormElement.h: Removed reference to RenderFormElement.
       
 66169 
       
 66170         * platform/qt/ComboBoxQt.cpp: Removed.
       
 66171         * platform/qt/LineEditQt.cpp: Removed.
       
 66172         * platform/qt/ListBoxQt.cpp: Removed.
       
 66173         * platform/qt/TextEditQt.cpp: Removed.
       
 66174         * rendering/RenderFormElement.cpp: Removed.
       
 66175         * rendering/RenderFormElement.h: Removed.
       
 66176         * rendering/RenderLabel.cpp: Removed.
       
 66177         * rendering/RenderLabel.h: Removed.
       
 66178 
       
 66179 2007-01-03  Darin Adler  <darin@apple.com>
       
 66180 
       
 66181         Reviewed by Hyatt.
       
 66182 
       
 66183         - fix bug where :after content appears backwards
       
 66184 
       
 66185         Test: fast/css-generated-content/after-order.html
       
 66186 
       
 66187         * rendering/RenderBlock.cpp:
       
 66188         (WebCore::isAfterContent): Added.
       
 66189         (WebCore::RenderBlock::addChildToFlow): Use isAfterContent.
       
 66190         * rendering/RenderInline.cpp:
       
 66191         (WebCore::isAfterContent): Added.
       
 66192         (WebCore::RenderInline::addChildToFlow): Use isAfterContent.
       
 66193 
       
 66194 2007-01-03  David Hyatt  <hyatt@apple.com>
       
 66195 
       
 66196         Implement box-shadow parsing... getting it all into the RenderStyle.
       
 66197 
       
 66198         Reviewed by beth
       
 66199 
       
 66200         * css/CSSComputedStyleDeclaration.cpp:
       
 66201         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
       
 66202         * css/CSSPropertyNames.in:
       
 66203         * css/cssparser.cpp:
       
 66204         (WebCore::CSSParser::parseValue):
       
 66205         * css/cssstyleselector.cpp:
       
 66206         (WebCore::CSSStyleSelector::applyProperty):
       
 66207         * rendering/RenderStyle.cpp:
       
 66208         (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData):
       
 66209         (WebCore::StyleCSS3NonInheritedData::operator==):
       
 66210         (WebCore::StyleCSS3NonInheritedData::shadowDataEquivalent):
       
 66211         (WebCore::RenderStyle::diff):
       
 66212         (WebCore::RenderStyle::setBoxShadow):
       
 66213         * rendering/RenderStyle.h:
       
 66214         (WebCore::RenderStyle::boxShadow):
       
 66215 
       
 66216 2007-01-03  Beth Dakin  <bdakin@apple.com>
       
 66217 
       
 66218         Reviewed by John.
       
 66219 
       
 66220         Call into WebKit to get localized strings for all of the context 
       
 66221         menu item titles.
       
 66222 
       
 66223         * page/mac/WebCoreViewFactory.h:
       
 66224         * platform/ContextMenu.cpp:
       
 66225         (WebCore::createAndAppendFontSubMenu):
       
 66226         (WebCore::createAndAppendSpellingAndGrammarSubMenu):
       
 66227         (WebCore::createAndAppendSpellingSubMenu):
       
 66228         (WebCore::createAndAppendSpeechSubMenu):
       
 66229         (WebCore::createAndAppendWritingDirectionSubMenu):
       
 66230         (WebCore::ContextMenu::populate):
       
 66231         (WebCore::ContextMenu::checkOrEnableIfNeeded):
       
 66232         * platform/LocalizedStrings.h:
       
 66233         * platform/mac/LocalizedStringsMac.mm:
       
 66234         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
       
 66235         (WebCore::contextMenuItemTagDownloadLinkToDisk):
       
 66236         (WebCore::contextMenuItemTagCopyLinkToClipboard):
       
 66237         (WebCore::contextMenuItemTagOpenImageInNewWindow):
       
 66238         (WebCore::contextMenuItemTagDownloadImageToDisk):
       
 66239         (WebCore::contextMenuItemTagCopyImageToClipboard):
       
 66240         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
       
 66241         (WebCore::contextMenuItemTagCopy):
       
 66242         (WebCore::contextMenuItemTagGoBack):
       
 66243         (WebCore::contextMenuItemTagGoForward):
       
 66244         (WebCore::contextMenuItemTagStop):
       
 66245         (WebCore::contextMenuItemTagReload):
       
 66246         (WebCore::contextMenuItemTagCut):
       
 66247         (WebCore::contextMenuItemTagPaste):
       
 66248         (WebCore::contextMenuItemTagNoGuessesFound):
       
 66249         (WebCore::contextMenuItemTagIgnoreSpelling):
       
 66250         (WebCore::contextMenuItemTagLearnSpelling):
       
 66251         (WebCore::contextMenuItemTagSearchInSpotlight):
       
 66252         (WebCore::contextMenuItemTagSearchWeb):
       
 66253         (WebCore::contextMenuItemTagLookUpInDictionary):
       
 66254         (WebCore::contextMenuItemTagOpenLink):
       
 66255         (WebCore::contextMenuItemTagIgnoreGrammar):
       
 66256         (WebCore::contextMenuItemTagSpellingMenu):
       
 66257         (WebCore::contextMenuItemTagShowSpellingPanel):
       
 66258         (WebCore::contextMenuItemTagCheckSpelling):
       
 66259         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
       
 66260         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
       
 66261         (WebCore::contextMenuItemTagFontMenu):
       
 66262         (WebCore::contextMenuItemTagShowFonts):
       
 66263         (WebCore::contextMenuItemTagBold):
       
 66264         (WebCore::contextMenuItemTagItalic):
       
 66265         (WebCore::contextMenuItemTagUnderline):
       
 66266         (WebCore::contextMenuItemTagOutline):
       
 66267         (WebCore::contextMenuItemTagStyles):
       
 66268         (WebCore::contextMenuItemTagShowColors):
       
 66269         (WebCore::contextMenuItemTagSpeechMenu):
       
 66270         (WebCore::contextMenuItemTagStartSpeaking):
       
 66271         (WebCore::contextMenuItemTagStopSpeaking):
       
 66272         (WebCore::contextMenuItemTagWritingDirectionMenu):
       
 66273         (WebCore::contextMenuItemTagDefaultDirection):
       
 66274         (WebCore::contextMenuItemTagLeftToRight):
       
 66275         (WebCore::contextMenuItemTagRightToLeft):
       
 66276 
       
 66277 2007-01-03  Brady Eidson  <beidson@apple.com>
       
 66278 
       
 66279         Reviewed by Darin and Geoff
       
 66280 
       
 66281         http://bugs.webkit.org/show_bug.cgi?id=12105 - Crash visiting Acid2 test page
       
 66282         -Replace lost "free nil checking" in the WebKit->WebCore conversion of the BackForwardList
       
 66283         -Changed ::createItem and ::createItemTree to ::createHistoryItem and ::createHistoryItemTree
       
 66284 
       
 66285         * loader/FrameLoader.cpp:
       
 66286         (WebCore::FrameLoader::createHistoryItem):
       
 66287         (WebCore::FrameLoader::addBackForwardItemClippedAtTarget):
       
 66288         (WebCore::FrameLoader::createHistoryItemTree):
       
 66289         (WebCore::FrameLoader::updateHistoryForInternalLoad):
       
 66290         * loader/FrameLoader.h:
       
 66291 
       
 66292 2007-01-03  Anders Carlsson  <acarlsson@apple.com>
       
 66293 
       
 66294         Reviewed by Geoff.
       
 66295         
       
 66296         Allow plugin elements to handle off events to their widgets.
       
 66297         
       
 66298         * html/HTMLPlugInElement.cpp:
       
 66299         (WebCore::HTMLPlugInElement::defaultEventHandler):
       
 66300         * html/HTMLPlugInElement.h:
       
 66301         * platform/Widget.h:
       
 66302         (WebCore::Widget::handleEvent):
       
 66303 
       
 66304 2007-01-03  Lars Knoll <lars@trolltech.com>
       
 66305 
       
 66306         Fix the Qt build
       
 66307 
       
 66308         * WebCore.pro:
       
 66309         * history/qt/PageCacheQt.cpp: Added.
       
 66310         (WebCore::PageCache::close):
       
 66311         * loader/qt/DocumentLoaderQt.cpp:
       
 66312         (WebCore::DocumentLoader::getResponseRefreshAndModifiedHeaders):
       
 66313         (WebCore::DocumentLoader::urlForHistory):
       
 66314         * loader/qt/FrameLoaderQt.cpp:
       
 66315         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
       
 66316         (WebCore::FrameLoader::didFirstLayout):
       
 66317         (WebCore::FrameLoader::load):
       
 66318         (WebCore::FrameLoader::opened):
       
 66319         (WebCore::FrameLoader::dataURLBaseFromRequest):
       
 66320         (WebCore::FrameLoader::applyUserAgent):
       
 66321         * platform/network/qt/ResourceHandleQt.cpp:
       
 66322         (WebCore::ResourceHandle::loadsBlocked):
       
 66323         (WebCore::ResourceHandle::willLoadFromCache):
       
 66324 
       
 66325 2007-01-02  Brady Eidson  <beidson@apple.com>
       
 66326 
       
 66327         Reviewed extensively and repeatedly by Darin
       
 66328 
       
 66329         <rdar://problem/4887137> - WebCore Back/Forward Cache
       
 66330 
       
 66331         * WebCore.exp:
       
 66332         * WebCore.xcodeproj/project.pbxproj:
       
 66333 
       
 66334         * bridge/mac/WebCorePageState.h: Removed.
       
 66335         * bridge/mac/WebCorePageState.mm: Removed.
       
 66336 
       
 66337         * history/BackForwardList.cpp: Added - This largely emulates the design of WebBackForwardList
       
 66338         (WebCore::BackForwardList::BackForwardList):
       
 66339         (WebCore::BackForwardList::~BackForwardList):
       
 66340         (WebCore::BackForwardList::addItem):
       
 66341         (WebCore::BackForwardList::goBack):
       
 66342         (WebCore::BackForwardList::goForward):
       
 66343         (WebCore::BackForwardList::goToItem):
       
 66344         (WebCore::BackForwardList::backItem):
       
 66345         (WebCore::BackForwardList::currentItem):
       
 66346         (WebCore::BackForwardList::forwardItem):
       
 66347         (WebCore::BackForwardList::backListWithLimit):
       
 66348         (WebCore::BackForwardList::forwardListWithLimit):
       
 66349         (WebCore::BackForwardList::capacity):
       
 66350         (WebCore::BackForwardList::setCapacity):
       
 66351         (WebCore::BackForwardList::setPageCacheSize):
       
 66352         (WebCore::BackForwardList::pageCacheSize):
       
 66353         (WebCore::BackForwardList::clearPageCache):
       
 66354         (WebCore::BackForwardList::usesPageCache):
       
 66355         (WebCore::BackForwardList::backListCount):
       
 66356         (WebCore::BackForwardList::forwardListCount):
       
 66357         (WebCore::BackForwardList::itemAtIndex):
       
 66358         (WebCore::BackForwardList::entries):
       
 66359         (WebCore::BackForwardList::close):
       
 66360         (WebCore::BackForwardList::closed):
       
 66361         (WebCore::BackForwardList::removeItem):
       
 66362         (WebCore::BackForwardList::containsItem):
       
 66363         (WebCore::BackForwardList::setDefaultPageCacheSize):
       
 66364         (WebCore::BackForwardList::defaultPageCacheSize):
       
 66365         * history/BackForwardList.h: Added.
       
 66366 
       
 66367         * history/HistoryItem.cpp: Added - This largely emulates the design of WebBackForwardList
       
 66368         (WebCore::defaultNotifyHistoryItemChanged):
       
 66369         (WebCore::HistoryItem::HistoryItem):
       
 66370         (WebCore::HistoryItem::~HistoryItem):
       
 66371         (WebCore::HistoryItem::copy):
       
 66372         (WebCore::HistoryItem::setHasPageCache):
       
 66373         (WebCore::HistoryItem::retainIconInDatabase):
       
 66374         (WebCore::HistoryItem::urlString):
       
 66375         (WebCore::HistoryItem::originalURLString):
       
 66376         (WebCore::HistoryItem::title):
       
 66377         (WebCore::HistoryItem::alternateTitle):
       
 66378         (WebCore::HistoryItem::icon):
       
 66379         (WebCore::HistoryItem::lastVisitedTime):
       
 66380         (WebCore::HistoryItem::url):
       
 66381         (WebCore::HistoryItem::originalURL):
       
 66382         (WebCore::HistoryItem::target):
       
 66383         (WebCore::HistoryItem::parent):
       
 66384         (WebCore::HistoryItem::setAlternateTitle):
       
 66385         (WebCore::HistoryItem::setURLString):
       
 66386         (WebCore::HistoryItem::setURL):
       
 66387         (WebCore::HistoryItem::setOriginalURLString):
       
 66388         (WebCore::HistoryItem::setTitle):
       
 66389         (WebCore::HistoryItem::setTarget):
       
 66390         (WebCore::HistoryItem::setParent):
       
 66391         (WebCore::HistoryItem::setLastVisitedTime):
       
 66392         (WebCore::HistoryItem::visitCount):
       
 66393         (WebCore::HistoryItem::setVisitCount):
       
 66394         (WebCore::HistoryItem::scrollPoint):
       
 66395         (WebCore::HistoryItem::setScrollPoint):
       
 66396         (WebCore::HistoryItem::clearScrollPoint):
       
 66397         (WebCore::HistoryItem::setDocumentState):
       
 66398         (WebCore::HistoryItem::documentState):
       
 66399         (WebCore::HistoryItem::clearDocumentState):
       
 66400         (WebCore::HistoryItem::isTargetItem):
       
 66401         (WebCore::HistoryItem::setIsTargetItem):
       
 66402         (WebCore::HistoryItem::alwaysAttemptToUsePageCache):
       
 66403         (WebCore::HistoryItem::setAlwaysAttemptToUsePageCache):
       
 66404         (WebCore::HistoryItem::addChildItem):
       
 66405         (WebCore::HistoryItem::childItemWithName):
       
 66406         (WebCore::HistoryItem::recurseToFindTargetItem):
       
 66407         (WebCore::HistoryItem::targetItem):
       
 66408         (WebCore::HistoryItem::pageCache):
       
 66409         (WebCore::HistoryItem::children):
       
 66410         (WebCore::HistoryItem::hasChildren):
       
 66411         (WebCore::HistoryItem::formContentType):
       
 66412         (WebCore::HistoryItem::formReferrer):
       
 66413         (WebCore::HistoryItem::rssFeedReferrer):
       
 66414         (WebCore::HistoryItem::setRSSFeedReferrer):
       
 66415         (WebCore::HistoryItem::setFormInfoFromRequest):
       
 66416         (WebCore::HistoryItem::formData):
       
 66417         (WebCore::HistoryItem::mergeAutoCompleteHints):
       
 66418         (WebCore::HistoryItem::hasPageCache):
       
 66419         (WebCore::timer): Function to manage the global release timer
       
 66420         (WebCore::pendingPageCacheToRelease): Function to manage the global queue of caches to be released
       
 66421         (WebCore::HistoryItem::releasePageCache):
       
 66422         (WebCore::closeObjectsInPendingPageCaches):
       
 66423         (WebCore::HistoryItem::releaseAllPendingPageCaches):
       
 66424         (WebCore::HistoryItem::scheduleRelease):
       
 66425         (WebCore::HistoryItem::print):
       
 66426         * history/HistoryItem.h: Added.
       
 66427         * history/mac/HistoryItemMac.mm: Added.
       
 66428         (WebCore::HistoryItem::viewState): In the future we need a platform agnostic way to manage the view state
       
 66429         (WebCore::HistoryItem::setViewState):
       
 66430         (WebCore::HistoryItem::getTransientProperty): Transient properties are, for now, only a Mac concept
       
 66431         (WebCore::HistoryItem::setTransientProperty):
       
 66432 
       
 66433         * history/HistoryItemTimer.cpp: Added
       
 66434         (WebCore::HistoryItemTimer::HistoryItemTimer): We need a specific class to be the history item timer because
       
 66435         WebCore::Timers only work when you have an instance of an object, but the caches pending release is a static concept
       
 66436         (WebCore::HistoryItemTimer::isActive):
       
 66437         (WebCore::HistoryItemTimer::schedule):
       
 66438         (WebCore::HistoryItemTimer::invalidate):
       
 66439         (WebCore::HistoryItemTimer::callReleasePageCache):
       
 66440         * history/HistoryItemTimer.h: Added.
       
 66441 
       
 66442         * history/PageCache.cpp Added - This is a class that contains the fields that used to be in an NSDictionary in WebKit
       
 66443         (WebCore::PageCache::PageCache):
       
 66444         (WebCore::PageCache::setPageState):
       
 66445         (WebCore::PageCache::~PageCache):
       
 66446         (WebCore::PageCache::pageState):
       
 66447         (WebCore::PageCache::setDocumentLoader):
       
 66448         (WebCore::PageCache::documentLoader):
       
 66449         (WebCore::PageCache::setTimeStamp):
       
 66450         (WebCore::PageCache::setTimeStampToNow):
       
 66451         (WebCore::PageCache::timeStamp):
       
 66452         * history/PageCache.h: Added.
       
 66453         * history/mac/PageCacheMac.mm: Added.
       
 66454         (WebCore::PageCache::close):
       
 66455         (WebCore::PageCache::setDocumentView): In the future we need a platform agnostic way to manage the documentView
       
 66456         (WebCore::PageCache::documentView):
       
 66457 
       
 66458         * loader/DocumentLoader.cpp:
       
 66459         (WebCore::DocumentLoader::loadFromPageCache):
       
 66460         (WebCore::DocumentLoader::setLoadingFromPageCache): 
       
 66461         (WebCore::DocumentLoader::isLoadingFromPageCache):
       
 66462         (WebCore::DocumentLoader::originalURL):
       
 66463         (WebCore::DocumentLoader::requestURL):
       
 66464         (WebCore::DocumentLoader::responseURL):
       
 66465         (WebCore::DocumentLoader::responseMIMEType):
       
 66466         * loader/DocumentLoader.h:
       
 66467 
       
 66468         * loader/FrameLoader.cpp: Responsibilities previously scattered in WebKit but concentrated in WebView and WebFrame 
       
 66469           are now here, where they should be.
       
 66470         (WebCore::FrameLoader::clear):
       
 66471         (WebCore::FrameLoader::restoreDocumentState):
       
 66472         (WebCore::FrameLoader::goBackOrForward):
       
 66473         (WebCore::FrameLoader::provisionalLoadStarted):
       
 66474         (WebCore::FrameLoader::canCachePage):
       
 66475         (WebCore::FrameLoader::commitProvisionalLoad):
       
 66476         (WebCore::FrameLoader::transitionToCommitted):
       
 66477         (WebCore::FrameLoader::open):
       
 66478         (WebCore::FrameLoader::didFirstLayout):
       
 66479         (WebCore::FrameLoader::dispatchDidChangeLocationWithinPage):
       
 66480         (WebCore::FrameLoader::dispatchDidFinishLoadToClient):
       
 66481         (WebCore::FrameLoader::updateGlobalHistoryForStandardLoad): Marked for usage in future GlobalHistory (uses client for now)
       
 66482         (WebCore::FrameLoader::updateGlobalHistoryForReload): Ditto
       
 66483         (WebCore::FrameLoader::shouldGoToHistoryItem):
       
 66484         (WebCore::FrameLoader::addExtraFieldsToRequest):
       
 66485         (WebCore::FrameLoader::addHistoryItemForFragmentScroll):
       
 66486         (WebCore::FrameLoader::loadProvisionalItemFromPageCache):
       
 66487         (WebCore::FrameLoader::createPageCache):
       
 66488         (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent):
       
 66489         (WebCore::FrameLoader::createItem):
       
 66490         (WebCore::FrameLoader::addBackForwardItemClippedAtTarget):
       
 66491         (WebCore::FrameLoader::createItemTree):
       
 66492         (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem):
       
 66493         (WebCore::FrameLoader::restoreScrollPositionAndViewState):
       
 66494         (WebCore::FrameLoader::purgePageCache):
       
 66495         (WebCore::FrameLoader::invalidateCurrentItemPageCache):
       
 66496         (WebCore::FrameLoader::saveDocumentState):
       
 66497         (WebCore::FrameLoader::loadItem):
       
 66498         (WebCore::FrameLoader::urlsMatchItem):
       
 66499         (WebCore::FrameLoader::goToItem):
       
 66500         (WebCore::FrameLoader::recursiveGoToItem):
       
 66501         (WebCore::FrameLoader::childFramesMatchItem):
       
 66502         (WebCore::FrameLoader::updateHistoryForStandardLoad):
       
 66503         (WebCore::FrameLoader::updateHistoryForClientRedirect):
       
 66504         (WebCore::FrameLoader::updateHistoryForBackForwardNavigation):
       
 66505         (WebCore::FrameLoader::updateHistoryForReload):
       
 66506         (WebCore::FrameLoader::updateHistoryForInternalLoad):
       
 66507         (WebCore::FrameLoader::updateHistoryForCommit):
       
 66508         (WebCore::FrameLoader::saveDocumentAndScrollState):
       
 66509         (WebCore::FrameLoader::currentHistoryItem):
       
 66510         (WebCore::FrameLoader::previousHistoryItem):
       
 66511         (WebCore::FrameLoader::provisionalHistoryItem):
       
 66512         (WebCore::FrameLoader::setCurrentHistoryItem):
       
 66513         (WebCore::FrameLoader::setPreviousHistoryItem):
       
 66514         (WebCore::FrameLoader::setProvisionalHistoryItem):
       
 66515         * loader/FrameLoader.h:
       
 66516 
       
 66517         * loader/FrameLoaderClient.h:
       
 66518 
       
 66519         * loader/mac/DocumentLoaderMac.mm:
       
 66520         (WebCore::DocumentLoader::DocumentLoader):
       
 66521         (WebCore::DocumentLoader::getResponseRefreshAndModifiedHeaders):
       
 66522         (WebCore::DocumentLoader::commitIfReady):
       
 66523         (WebCore::DocumentLoader::urlForHistory):
       
 66524 
       
 66525         * loader/mac/FrameLoaderMac.mm:
       
 66526         (WebCore::FrameLoader::load):
       
 66527         (WebCore::FrameLoader::startLoading):
       
 66528         (WebCore::FrameLoader::receivedMainResourceError):
       
 66529         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
       
 66530         (WebCore::FrameLoader::opened):
       
 66531         (WebCore::FrameLoader::dataURLBaseFromRequest):
       
 66532         (WebCore::FrameLoader::didChangeTitle):
       
 66533         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
       
 66534         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
       
 66535 
       
 66536         * page/FrameTree.cpp:
       
 66537         (WebCore::FrameTree::removeChild):
       
 66538 
       
 66539         * page/Page.cpp: Transfered a handful of concepts from WebView
       
 66540         (WebCore::Page::Page):
       
 66541         (WebCore::Page::~Page):
       
 66542         (WebCore::Page::backForwardList):
       
 66543         (WebCore::Page::goBack):
       
 66544         (WebCore::Page::goForward):
       
 66545         (WebCore::Page::goToItem):
       
 66546         * page/Page.h:
       
 66547 
       
 66548         * page/PageState.h:
       
 66549         * page/mac/FrameMac.h:
       
 66550         * page/mac/FrameMac.mm:
       
 66551         * page/mac/WebCoreFrameBridge.h:
       
 66552         * page/mac/WebCoreFrameBridge.mm:
       
 66553 
       
 66554         * platform/KURL.cpp:
       
 66555         (WebCore::KURL::print):  Added debug only method for debugging convenience
       
 66556         * platform/KURL.h:
       
 66557 
       
 66558         * platform/Logging.cpp:
       
 66559         (WebCore::): Added some logging channels
       
 66560         * platform/Logging.h:
       
 66561 
       
 66562         * platform/PlatformString.h:
       
 66563         (WebCore::nsStringNilIfEmpty): Added for WebKit use
       
 66564 
       
 66565         * platform/SystemTime.h: Added userIdleTime()
       
 66566 
       
 66567         * platform/graphics/svg/SVGImage.cpp:
       
 66568         * platform/graphics/svg/SVGImageEmptyClients.h: Updated for new FrameLoaderClient methods
       
 66569         (WebCore::SVGEmptyFrameLoaderClient::setDocumentViewFromPageCache):
       
 66570         (WebCore::SVGEmptyFrameLoaderClient::updateGlobalHistoryForStandardLoad):
       
 66571         (WebCore::SVGEmptyFrameLoaderClient::updateGlobalHistoryForReload):
       
 66572         (WebCore::SVGEmptyFrameLoaderClient::shouldGoToHistoryItem):
       
 66573         (WebCore::SVGEmptyFrameLoaderClient::saveScrollPositionAndViewStateToItem):
       
 66574         (WebCore::SVGEmptyFrameLoaderClient::saveDocumentViewToPageCache):
       
 66575         (WebCore::SVGEmptyFrameLoaderClient::canCachePage):
       
 66576         (WebCore::SVGEmptyEditorClient::~SVGEmptyEditorClient):
       
 66577 
       
 66578         * platform/mac/LoggingMac.mm:
       
 66579         (WebCore::InitializeLoggingChannelsIfNecessary):
       
 66580 
       
 66581         * platform/mac/SystemTimeMac.cpp:
       
 66582         (WebCore::userIdleTime):
       
 66583 
       
 66584         * platform/mac/WebCoreSystemInterface.h: Added wkSecondsSinceLastInput for use in userIdleTime
       
 66585         * platform/mac/WebCoreSystemInterface.mm:
       
 66586 
       
 66587         * platform/network/FormData.cpp:
       
 66588         (WebCore::FormData::FormData):
       
 66589         (WebCore::FormData::copy):
       
 66590         * platform/network/FormData.h:
       
 66591 
       
 66592         * platform/network/ResourceHandle.h:
       
 66593         * platform/network/mac/ResourceHandleMac.mm:
       
 66594         (WebCore::ResourceHandle::willLoadFromCache): For "are you sure you want to resubmit?" nag
       
 66595 
       
 66596         * platform/qt/TemporaryLinkStubs.cpp:
       
 66597         (WebCore::userIdleTime):
       
 66598         * rendering/RenderPart.h:
       
 66599 
       
 66600 2007-01-02  Darin Adler  <darin@apple.com>
       
 66601 
       
 66602         Rubber stamped by Mitz.
       
 66603 
       
 66604         Rename isRenderSVGContainer to isSVGContainer.
       
 66605 
       
 66606         * platform/graphics/ImageBuffer.cpp:
       
 66607         (WebCore::ImageBuffer::renderSubtreeToImage):
       
 66608         * rendering/RenderObject.cpp:
       
 66609         (WebCore::RenderObject::containingBlock):
       
 66610         * rendering/RenderObject.h:
       
 66611         (WebCore::RenderObject::isSVGContainer):
       
 66612         * rendering/RenderSVGContainer.cpp:
       
 66613         (WebCore::RenderSVGContainer::viewportTransform):
       
 66614         * rendering/RenderSVGContainer.h:
       
 66615         (WebCore::RenderSVGContainer::isSVGContainer):
       
 66616         * rendering/RenderTreeAsText.cpp:
       
 66617         (WebCore::write):
       
 66618 
       
 66619 2007-01-03  Nikolas Zimmermann  <zimmermann@kde.org>
       
 66620 
       
 66621         Reviewed by Mitz.
       
 66622 
       
 66623         Rename isKCanvasContainer to isRenderSVGContainer.
       
 66624 
       
 66625         * platform/graphics/ImageBuffer.cpp:
       
 66626         (WebCore::ImageBuffer::renderSubtreeToImage):
       
 66627         * rendering/RenderObject.cpp:
       
 66628         (WebCore::RenderObject::containingBlock):
       
 66629         * rendering/RenderObject.h:
       
 66630         (WebCore::RenderObject::isRenderSVGContainer):
       
 66631         * rendering/RenderSVGContainer.cpp:
       
 66632         (WebCore::RenderSVGContainer::viewportTransform):
       
 66633         * rendering/RenderSVGContainer.h:
       
 66634         (WebCore::RenderSVGContainer::isRenderSVGContainer):
       
 66635         * rendering/RenderTreeAsText.cpp:
       
 66636         (WebCore::write):
       
 66637 
       
 66638 2007-01-02  Beth Dakin  <bdakin@apple.com>
       
 66639 
       
 66640         Reviewed by Darin.
       
 66641 
       
 66642         Fix assertion failure with WebCore context menus by getting "Copy 
       
 66643         Image" item added in.
       
 66644 
       
 66645         * platform/ContextMenu.cpp:
       
 66646         (WebCore::ContextMenu::populate): Check if the image url is a local 
       
 66647         file or if we have an image in the cache.
       
 66648 
       
 66649 2007-01-02  Sam Weinig  <sam@webkit.org>
       
 66650 
       
 66651         Reviewed by Anders.
       
 66652 
       
 66653         Patch for http://bugs.webkit.org/show_bug.cgi?id=12072
       
 66654         select with align attribute should not affect contained text
       
 66655 
       
 66656         Don't map align for select elements.
       
 66657 
       
 66658         Test: fast/forms/select-align.html
       
 66659 
       
 66660         * html/HTMLSelectElement.cpp:
       
 66661         (WebCore::HTMLSelectElement::parseMappedAttribute):
       
 66662 
       
 66663 2007-01-02  Sam Weinig  <sam@webkit.org>
       
 66664 
       
 66665         Reviewed by Mitz.
       
 66666 
       
 66667         Patch for http://bugs.webkit.org/show_bug.cgi?id=12071
       
 66668         button with align attribute should not affect contained text
       
 66669 
       
 66670         Don't map align for button elements.
       
 66671 
       
 66672         Test: fast/forms/button-align.html
       
 66673 
       
 66674         * html/HTMLButtonElement.cpp:
       
 66675         (WebCore::HTMLButtonElement::parseMappedAttribute):
       
 66676 
       
 66677 2007-01-02  Sam Weinig  <sam@webkit.org>
       
 66678 
       
 66679         Reviewed by Mitz and Anders.
       
 66680 
       
 66681         Patch for http://bugs.webkit.org/show_bug.cgi?id=7075
       
 66682         textarea with align=right should not cause contained text to 
       
 66683         be right-justified
       
 66684 
       
 66685         Don't map align for textarea elements.
       
 66686 
       
 66687         Test: fast/forms/textarea-align.html
       
 66688 
       
 66689         * html/HTMLTextAreaElement.cpp:
       
 66690         (WebCore::HTMLTextAreaElement::parseMappedAttribute):
       
 66691 
       
 66692 2007-01-02  Eric Seidel  <eric@webkit.org>
       
 66693 
       
 66694         Reviewed by mitz.
       
 66695 
       
 66696         Implement SVGSVGElement::deselectAll()
       
 66697 
       
 66698         * ksvg2/svg/SVGAnimationElement.h:
       
 66699         (WebCore::SVGAnimationElement::updateLastValueWithCurrent): add comment
       
 66700         * ksvg2/svg/SVGSVGElement.cpp:
       
 66701         (WebCore::SVGSVGElement::deselectAll): implement
       
 66702         (WebCore::SVGSVGElement::setCurrentTime): add comment about bug
       
 66703         * ksvg2/svg/SVGSVGElement.idl: remove unnecessary comment
       
 66704 
       
 66705 2007-01-02  Sam Weinig  <sam@webkit.org>
       
 66706 
       
 66707         Reviewed by Darin.
       
 66708 
       
 66709         Patch for http://bugs.webkit.org/show_bug.cgi?id=3360
       
 66710         align="right" on a text input aligns the input field to the right
       
 66711 
       
 66712         Don't map align if input type is not 'image'.
       
 66713 
       
 66714         Test: fast/forms/input-align-image.html
       
 66715         Test: fast/forms/input-align.html
       
 66716 
       
 66717         * WebCore.xcodeproj/project.pbxproj:
       
 66718         * html/HTMLInputElement.cpp:
       
 66719         (WebCore::HTMLInputElement::setInputType):
       
 66720         (WebCore::HTMLInputElement::mapToEntry):
       
 66721         (WebCore::HTMLInputElement::parseMappedAttribute):
       
 66722 
       
 66723 2007-01-02  Nikolas Zimmermann  <zimmermann@kde.org>
       
 66724 
       
 66725         Reviewed by Eric.
       
 66726 
       
 66727         Fixes: http://bugs.webkit.org/show_bug.cgi?id=12013
       
 66728         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11980
       
 66729         Partly fixes: http://bugs.webkit.org/show_bug.cgi?id=6000 (pattern/gradient recursion works now)
       
 66730 
       
 66731         Fixed testcases:
       
 66732         coords-units-01-b.svg (<pattern> in objectBoundingBoxMode were broken.)
       
 66733         pattern-in-defs.svg (clip pattern size against target size, to avoid excessive mallocs)
       
 66734         js-update-pattern.svg (live updating really works now!)
       
 66735         js-late-gradient-and-object-creation.svg (objectBoundingBoxMode gradients-on-text work now)
       
 66736         js-late-gradient-creation.svg (same)
       
 66737 
       
 66738         Added testcases:
       
 66739         js-late-pattern-and-object-creation.svg (objectBoundingBoxMode patterns-on-text work now)
       
 66740         js-late-pattern-creation.svg (same)
       
 66741         gradient-cycle-detection.svg (tests that cyclic gradients are ignored)
       
 66742         gradient-deep-referencing.svg
       
 66743         pattern-cycle-detection.svg (tests that cyclic patterns are ignored)
       
 66744         pattern-deep-referencing.svg
       
 66745 
       
 66746         Rewrite gradient & pattern code, fixing all known bugs & regressions.
       
 66747 
       
 66748         -> Remove SVGResourceListener completly (the ugly resourceNotification() hack is gone now)
       
 66749 
       
 66750         -> Make patterns operate in all possible combinations of patternUnits / patternContentunits
       
 66751            The SVGPaintServerPattern now asks the SVGPatternElement to build the pattern tile, passing
       
 66752            the target object's bbox rectangle -> objectBoundingBox calculations can be done, so SVGPaintServerPattern
       
 66753            itself doesn't need to know anything about "bounding box mode". Same could be done for gradients.
       
 66754 
       
 66755         -> SVGLength::valueAsPercentage() returns again fractional values, saves some "/ 100.0" statements.
       
 66756 
       
 66757         -> Deep references (gradientA -> gradientB -> gradientC...) work now. Previously only one reference worked.
       
 66758            Adding GradientAttributes.h / PatternAttributes.h helper structures for the property collection.
       
 66759            Cycle detection is implemented and won't kill us anymore :-)
       
 66760 
       
 66761         JS updates on gradients/patterns only cause one repaint of the client's now. Gradient drawing
       
 66762         does not cause the target object to be redrawn immediately afterwards anymore.
       
 66763 
       
 66764         * WebCore.xcodeproj/project.pbxproj:
       
 66765         * ksvg2/misc/KCanvasRenderingStyle.cpp:
       
 66766         (WebCore::KSVGPainterFactory::fillPaintServer):
       
 66767         (WebCore::KSVGPainterFactory::strokePaintServer):
       
 66768         * ksvg2/misc/KCanvasRenderingStyle.h:
       
 66769         * ksvg2/misc/SVGDocumentExtensions.cpp:
       
 66770         (WebCore::SVGDocumentExtensions::addPendingResource):
       
 66771         (WebCore::SVGDocumentExtensions::isPendingResource):
       
 66772         (WebCore::SVGDocumentExtensions::removePendingResource):
       
 66773         * ksvg2/misc/SVGDocumentExtensions.h:
       
 66774         * ksvg2/svg/GradientAttributes.h: Added.
       
 66775         (WebCore::GradientAttributes::GradientAttributes):
       
 66776         (WebCore::GradientAttributes::spreadMethod):
       
 66777         (WebCore::GradientAttributes::boundingBoxMode):
       
 66778         (WebCore::GradientAttributes::gradientTransform):
       
 66779         (WebCore::GradientAttributes::stops):
       
 66780         (WebCore::GradientAttributes::setSpreadMethod):
       
 66781         (WebCore::GradientAttributes::setBoundingBoxMode):
       
 66782         (WebCore::GradientAttributes::setGradientTransform):
       
 66783         (WebCore::GradientAttributes::setStops):
       
 66784         (WebCore::GradientAttributes::hasSpreadMethod):
       
 66785         (WebCore::GradientAttributes::hasBoundingBoxMode):
       
 66786         (WebCore::GradientAttributes::hasGradientTransform):
       
 66787         (WebCore::GradientAttributes::hasStops):
       
 66788         * ksvg2/svg/LinearGradientAttributes.h: Added.
       
 66789         (WebCore::LinearGradientAttributes::LinearGradientAttributes):
       
 66790         (WebCore::LinearGradientAttributes::x1):
       
 66791         (WebCore::LinearGradientAttributes::y1):
       
 66792         (WebCore::LinearGradientAttributes::x2):
       
 66793         (WebCore::LinearGradientAttributes::y2):
       
 66794         (WebCore::LinearGradientAttributes::setX1):
       
 66795         (WebCore::LinearGradientAttributes::setY1):
       
 66796         (WebCore::LinearGradientAttributes::setX2):
       
 66797         (WebCore::LinearGradientAttributes::setY2):
       
 66798         (WebCore::LinearGradientAttributes::hasX1):
       
 66799         (WebCore::LinearGradientAttributes::hasY1):
       
 66800         (WebCore::LinearGradientAttributes::hasX2):
       
 66801         (WebCore::LinearGradientAttributes::hasY2):
       
 66802         * ksvg2/svg/PatternAttributes.h: Added.
       
 66803         (WebCore::PatternAttributes::PatternAttributes):
       
 66804         (WebCore::PatternAttributes::x):
       
 66805         (WebCore::PatternAttributes::y):
       
 66806         (WebCore::PatternAttributes::width):
       
 66807         (WebCore::PatternAttributes::height):
       
 66808         (WebCore::PatternAttributes::boundingBoxMode):
       
 66809         (WebCore::PatternAttributes::boundingBoxModeContent):
       
 66810         (WebCore::PatternAttributes::patternTransform):
       
 66811         (WebCore::PatternAttributes::patternContentElement):
       
 66812         (WebCore::PatternAttributes::setX):
       
 66813         (WebCore::PatternAttributes::setY):
       
 66814         (WebCore::PatternAttributes::setWidth):
       
 66815         (WebCore::PatternAttributes::setHeight):
       
 66816         (WebCore::PatternAttributes::setBoundingBoxMode):
       
 66817         (WebCore::PatternAttributes::setBoundingBoxModeContent):
       
 66818         (WebCore::PatternAttributes::setPatternTransform):
       
 66819         (WebCore::PatternAttributes::setPatternContentElement):
       
 66820         (WebCore::PatternAttributes::hasX):
       
 66821         (WebCore::PatternAttributes::hasY):
       
 66822         (WebCore::PatternAttributes::hasWidth):
       
 66823         (WebCore::PatternAttributes::hasHeight):
       
 66824         (WebCore::PatternAttributes::hasBoundingBoxMode):
       
 66825         (WebCore::PatternAttributes::hasBoundingBoxModeContent):
       
 66826         (WebCore::PatternAttributes::hasPatternTransform):
       
 66827         (WebCore::PatternAttributes::hasPatternContentElement):
       
 66828         * ksvg2/svg/RadialGradientAttributes.h: Added.
       
 66829         (WebCore::RadialGradientAttributes::RadialGradientAttributes):
       
 66830         (WebCore::RadialGradientAttributes::cx):
       
 66831         (WebCore::RadialGradientAttributes::cy):
       
 66832         (WebCore::RadialGradientAttributes::r):
       
 66833         (WebCore::RadialGradientAttributes::fx):
       
 66834         (WebCore::RadialGradientAttributes::fy):
       
 66835         (WebCore::RadialGradientAttributes::setCx):
       
 66836         (WebCore::RadialGradientAttributes::setCy):
       
 66837         (WebCore::RadialGradientAttributes::setR):
       
 66838         (WebCore::RadialGradientAttributes::setFx):
       
 66839         (WebCore::RadialGradientAttributes::setFy):
       
 66840         (WebCore::RadialGradientAttributes::hasCx):
       
 66841         (WebCore::RadialGradientAttributes::hasCy):
       
 66842         (WebCore::RadialGradientAttributes::hasR):
       
 66843         (WebCore::RadialGradientAttributes::hasFx):
       
 66844         (WebCore::RadialGradientAttributes::hasFy):
       
 66845         * ksvg2/svg/SVGGradientElement.cpp:
       
 66846         (WebCore::SVGGradientElement::notifyAttributeChange):
       
 66847         (WebCore::SVGGradientElement::canvasResource):
       
 66848         (WebCore::SVGGradientElement::buildStops):
       
 66849         (WebCore::SVGGradientElement::insertedIntoDocument):
       
 66850         * ksvg2/svg/SVGGradientElement.h:
       
 66851         * ksvg2/svg/SVGLength.cpp:
       
 66852         (WebCore::SVGLength::valueAsPercentage):
       
 66853         * ksvg2/svg/SVGLinearGradientElement.cpp:
       
 66854         (WebCore::SVGLinearGradientElement::buildGradient):
       
 66855         (WebCore::SVGLinearGradientElement::collectGradientProperties):
       
 66856         * ksvg2/svg/SVGLinearGradientElement.h:
       
 66857         * ksvg2/svg/SVGLocatable.cpp:
       
 66858         (WebCore::SVGLocatable::getScreenCTM):
       
 66859         * ksvg2/svg/SVGPatternElement.cpp:
       
 66860         (WebCore::SVGPatternElement::SVGPatternElement):
       
 66861         (WebCore::SVGPatternElement::buildPattern):
       
 66862         (WebCore::SVGPatternElement::notifyAttributeChange):
       
 66863         (WebCore::SVGPatternElement::canvasResource):
       
 66864         (WebCore::SVGPatternElement::insertedIntoDocument):
       
 66865         (WebCore::SVGPatternElement::collectPatternProperties):
       
 66866         * ksvg2/svg/SVGPatternElement.h:
       
 66867         * ksvg2/svg/SVGRadialGradientElement.cpp:
       
 66868         (WebCore::SVGRadialGradientElement::buildGradient):
       
 66869         (WebCore::SVGRadialGradientElement::collectGradientProperties):
       
 66870         * ksvg2/svg/SVGRadialGradientElement.h:
       
 66871         * platform/graphics/svg/SVGPaintServerGradient.cpp:
       
 66872         (WebCore::SVGPaintServerGradient::SVGPaintServerGradient):
       
 66873         (WebCore::SVGPaintServerGradient::externalRepresentation):
       
 66874         * platform/graphics/svg/SVGPaintServerGradient.h:
       
 66875         (WebCore::):
       
 66876         * platform/graphics/svg/SVGPaintServerLinearGradient.cpp:
       
 66877         (WebCore::SVGPaintServerLinearGradient::SVGPaintServerLinearGradient):
       
 66878         * platform/graphics/svg/SVGPaintServerLinearGradient.h:
       
 66879         * platform/graphics/svg/SVGPaintServerPattern.cpp:
       
 66880         (WebCore::SVGPaintServerPattern::SVGPaintServerPattern):
       
 66881         (WebCore::SVGPaintServerPattern::patternBoundaries):
       
 66882         (WebCore::SVGPaintServerPattern::setPatternBoundaries):
       
 66883         (WebCore::SVGPaintServerPattern::setTile):
       
 66884         (WebCore::SVGPaintServerPattern::externalRepresentation):
       
 66885         * platform/graphics/svg/SVGPaintServerPattern.h:
       
 66886         * platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
       
 66887         (WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
       
 66888         * platform/graphics/svg/SVGPaintServerRadialGradient.h:
       
 66889         * platform/graphics/svg/SVGResource.cpp:
       
 66890         (WebCore::SVGResource::invalidate):
       
 66891         (WebCore::SVGResource::repaintClients):
       
 66892         * platform/graphics/svg/SVGResource.h:
       
 66893         * platform/graphics/svg/SVGResourceListener.h:
       
 66894         * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
       
 66895         (WebCore::cgGradientCallback):
       
 66896         (WebCore::CGShadingRefForRadialGradient):
       
 66897         (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
       
 66898         (WebCore::SVGPaintServerGradient::updateQuartzGradientCache):
       
 66899         (WebCore::SVGPaintServerGradient::teardown):
       
 66900         (WebCore::SVGPaintServerGradient::renderPath):
       
 66901         (WebCore::SVGPaintServerGradient::handleBoundingBoxModeAndGradientTransformation):
       
 66902         (WebCore::SVGPaintServerGradient::setup):
       
 66903         (WebCore::SVGPaintServerGradient::invalidate):
       
 66904         * platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp:
       
 66905         (WebCore::SVGPaintServerPattern::setup):
       
 66906         (WebCore::SVGPaintServerPattern::teardown):
       
 66907         * platform/graphics/svg/qt/SVGPaintServerLinearGradientQt.cpp:
       
 66908         (WebCore::SVGPaintServerLinearGradient::setup):
       
 66909         * platform/graphics/svg/qt/SVGPaintServerPatternQt.cpp:
       
 66910         (WebCore::SVGPaintServerPattern::setup):
       
 66911         * platform/graphics/svg/qt/SVGPaintServerRadialGradientQt.cpp:
       
 66912         (WebCore::SVGPaintServerRadialGradient::setup):
       
 66913 
       
 66914 2007-01-02  Zack Rusin  <zack@kde.org>
       
 66915 
       
 66916         Compilation fix. File names are case-sensitive.
       
 66917 
       
 66918         * ksvg2/svg/SVGPathSegList.cpp:
       
 66919 
       
 66920 2007-01-02  Zack Rusin  <zack@kde.org>
       
 66921 
       
 66922         Compilation fixes for the Qt port.
       
 66923 
       
 66924         * WebCore.pro:
       
 66925         * platform/qt/FrameQt.cpp:
       
 66926         (WebCore::FrameQt::bindingRootObject):
       
 66927         (WebCore::FrameQt::addPluginRootObject):
       
 66928 
       
 66929 2007-01-02  Eric Seidel  <eric@webkit.org>
       
 66930 
       
 66931         Reviewed by rwlbuis.
       
 66932 
       
 66933         Refactor more animation code for better sharing between SVGAnimate*Element classes.
       
 66934         - replace handleEndCondition with resetValues() and updateLastValueWithCurrent()
       
 66935         - move initialTransform() function down into SVGTimer (eventually to AnimationCompositor)
       
 66936         Add non-functional (only parses) SVGAnimateMotionElement
       
 66937         Improve precision of getPointAtLength calculations and add support for "getNormalAtLength" functionality (needed for rotate='auto' support in animateMotion)
       
 66938         Move add getSegmentAtLength functionality to SVGPathSegList, move toPathData into SVGPathSegList as well.
       
 66939         Add SVGAnimationElement::hasValidTarget() for future better/simpler ASSERT checking
       
 66940         change transformMatrix() to currentTransform() to match AffineTransform class name
       
 66941 
       
 66942         * WebCore.xcodeproj/project.pbxproj:
       
 66943         * ksvg2/misc/SVGTimer.cpp:
       
 66944         (WebCore::SVGTimer::animationsByElement):
       
 66945         (WebCore::baseValueTransformList):
       
 66946         (WebCore::SVGTimer::applyAnimations):
       
 66947         * ksvg2/svg/SVGAnimateColorElement.cpp:
       
 66948         (WebCore::SVGAnimateColorElement::updateLastValueWithCurrent):
       
 66949         * ksvg2/svg/SVGAnimateColorElement.h:
       
 66950         * ksvg2/svg/SVGAnimateMotionElement.cpp: Added.
       
 66951         (WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement):
       
 66952         (WebCore::SVGAnimateMotionElement::~SVGAnimateMotionElement):
       
 66953         (WebCore::SVGAnimateMotionElement::hasValidTarget): added.
       
 66954         (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
       
 66955         (WebCore::SVGAnimateMotionElement::animationPath): fetch path from <mpath> or d attribute
       
 66956         (WebCore::SVGAnimateMotionElement::updateCurrentValue):
       
 66957         (WebCore::SVGAnimateMotionElement::handleStartCondition):
       
 66958         (WebCore::SVGAnimateMotionElement::applyAnimationToValue):
       
 66959         * ksvg2/svg/SVGAnimateMotionElement.h: Added.
       
 66960         (WebCore::SVGAnimateMotionElement::contextElement):
       
 66961         (WebCore::SVGAnimateMotionElement::):
       
 66962         * ksvg2/svg/SVGAnimateTransformElement.cpp:
       
 66963         (WebCore::SVGAnimateTransformElement::hasValidTarget): added.
       
 66964         (WebCore::SVGAnimateTransformElement::storeInitialValue):
       
 66965         (WebCore::SVGAnimateTransformElement::updateCurrentValue):
       
 66966         (WebCore::SVGAnimateTransformElement::updateLastValueWithCurrent):
       
 66967         (WebCore::SVGAnimateTransformElement::applyAnimationToValue):
       
 66968         (WebCore::SVGAnimateTransformElement::currentTransform):
       
 66969         * ksvg2/svg/SVGAnimateTransformElement.h:
       
 66970         * ksvg2/svg/SVGAnimationElement.cpp:
       
 66971         (WebCore::SVGAnimationElement::hasValidTarget): added.
       
 66972         (WebCore::SVGAnimationElement::parseMappedAttribute):
       
 66973         (WebCore::SVGAnimationElement::isAdditive):
       
 66974         (WebCore::SVGAnimationElement::isAccumulated):
       
 66975         (WebCore::SVGAnimationElement::handleTimerEvent):
       
 66976         * ksvg2/svg/SVGAnimationElement.h:
       
 66977         (WebCore::SVGAnimationElement::updateLastValueWithCurrent):
       
 66978         (WebCore::SVGAnimationElement::resetValues):
       
 66979         * ksvg2/svg/SVGPathElement.cpp:
       
 66980         (WebCore::SVGPathElement::getPointAtLength):
       
 66981         (WebCore::SVGPathElement::getPathSegAtLength):
       
 66982         (WebCore::SVGPathElement::parseMappedAttribute):
       
 66983         (WebCore::SVGPathElement::toPathData):
       
 66984         * ksvg2/svg/SVGPathSegList.cpp:
       
 66985         (WebCore::SVGPathSegList::getPathSegAtLength): added.
       
 66986         (WebCore::SVGPathSegList::toPathData): added.
       
 66987         * ksvg2/svg/SVGPathSegList.h:
       
 66988         * ksvg2/svg/svgtags.in: add animateMotion
       
 66989         * platform/graphics/Path.cpp:
       
 66990         (WebCore::pathLengthApplierFunction): add support for TraversalNormalAngleAtLength
       
 66991         * platform/graphics/PathTraversalState.cpp:
       
 66992         (WebCore::curveLength): support higher precision pointAtLength calculations, and add normalAtLength support
       
 66993         (WebCore::PathTraversalState::quadraticBezierTo):
       
 66994         (WebCore::PathTraversalState::cubicBezierTo):
       
 66995         * platform/graphics/PathTraversalState.h:
       
 66996         (WebCore::PathTraversalState::): add TraversalNormalAngleAtLength mode
       
 66997 
       
 66998 2007-01-01  Mitz Pettel  <mitz@webkit.org>
       
 66999 
       
 67000         Reviewed by Darin.
       
 67001 
       
 67002         - WebCore changes for http://bugs.webkit.org/show_bug.cgi?id=11849
       
 67003           REGRESSION (r18182): Google Calendar is broken (a regular expression containing a null character is not parsed correctly)
       
 67004 
       
 67005         * platform/RegularExpression.cpp:
       
 67006         (WebCore::RegularExpression::Private::compile): Changed to not null-terminate
       
 67007         the pattern string and instead pass its length to pcre_compile.
       
 67008 
       
 67009 2007-01-01  Mitz Pettel  <mitz@webkit.org>
       
 67010 
       
 67011         Reviewed by Darin.
       
 67012 
       
 67013         - fix http://bugs.webkit.org/show_bug.cgi?id=11359
       
 67014           Incomplete repaint of table cell's collapsed border when changing only the cell
       
 67015 
       
 67016         Test: fast/repaint/table-cell-collapsed-border.html
       
 67017 
       
 67018         * rendering/RenderTable.h:
       
 67019         Added needsSectionRecalc() accessor.
       
 67020         * rendering/RenderTableCell.cpp:
       
 67021         (WebCore::RenderTableCell::getAbsoluteRepaintRect): Overloaded to add the
       
 67022         outer half of any collapsed borders. This function checks the cell's borders'
       
 67023         widths but also the widths of the adjoining cells' borders, since they can
       
 67024         contribute to the length of this cell's borders perpendicular to them, making
       
 67025         such a border overflow the cell in both dimensions.
       
 67026         (WebCore::RenderTableCell::borderLeft): Split the collapsing borders case off to
       
 67027         borderHalfLeft().
       
 67028         (WebCore::RenderTableCell::borderRight): Ditto.
       
 67029         (WebCore::RenderTableCell::borderTop): Ditto.
       
 67030         (WebCore::RenderTableCell::borderBottom): Ditto.
       
 67031         (WebCore::RenderTableCell::borderHalfLeft): Added. Takes an 'outer' boolean
       
 67032         parameter. When true, this function returns the width of the part of the border
       
 67033         that is outside the cell (different from the inner width when the total width is odd).
       
 67034         (WebCore::RenderTableCell::borderHalfRight): Ditto.
       
 67035         (WebCore::RenderTableCell::borderHalfTop): Ditto.
       
 67036         (WebCore::RenderTableCell::borderHalfBottom): Ditto.
       
 67037         * rendering/RenderTableCell.h:
       
 67038 
       
 67039 2007-01-01  David Kilzer  <ddkilzer@webkit.org>
       
 67040 
       
 67041         WebCore.vcproj change reviewed by Darin.  Additional build files updated by ddkilzer.
       
 67042 
       
 67043         * CMakeLists.txt: Removed RenderLineEdit.cpp.
       
 67044         * WebCore.vcproj/WebCore/WebCore.vcproj: Removed RenderLineEdit.cpp and RenderLineEdit.h.
       
 67045         * WebCoreSources.bkl: Removed RenderLineEdit.cpp.
       
 67046 
       
 67047 2007-01-01  Mitz Pettel  <mitz@webkit.org>
       
 67048 
       
 67049         Reviewed by Mark Rowe.
       
 67050 
       
 67051         - fix http://bugs.webkit.org/show_bug.cgi?id=12042
       
 67052           Assertion failure in WebCore::RenderObject::drawBorder
       
 67053 
       
 67054         Test: fast/borders/outline-offset-min-assert.html
       
 67055 
       
 67056         * rendering/RenderObject.cpp:
       
 67057         (WebCore::RenderObject::paintOutline): Bail out if the width or height is
       
 67058         smaller than twice the outline inset.
       
 67059         
       
 67060 2007-01-01  Mark Rowe  <bdash@webkit.org>
       
 67061 
       
 67062         Reviewed by Eric.
       
 67063 
       
 67064         http://bugs.webkit.org/show_bug.cgi?id=12061
       
 67065         Bug 12061: Crash in WebCore::Shared<WebCore::StringImpl>::deref
       
 67066 
       
 67067         * rendering/RenderStyle.cpp:
       
 67068         (WebCore::ContentData::clearContent): Reset _contentType to CONTENT_NONE to ensure repeated calls to clearContent
       
 67069         do not result in derefing deallocated members.
       
 67070 
       
 67071 2007-01-01  Eric Seidel  <eric@webkit.org>
       
 67072 
       
 67073         Reviewed by andersca.
       
 67074 
       
 67075         Begin pushing code down into SVGAnimateElement
       
 67076 
       
 67077         * ksvg2/svg/SVGAnimateColorElement.cpp:
       
 67078         (WebCore::SVGAnimateColorElement::handleStartCondition):
       
 67079         * ksvg2/svg/SVGAnimateColorElement.h:
       
 67080         * ksvg2/svg/SVGAnimateElement.h:
       
 67081         (WebCore::SVGAnimateElement::updateCurrentValue):
       
 67082         (WebCore::SVGAnimateElement::handleStartCondition):
       
 67083         (WebCore::SVGAnimateElement::handleEndCondition):
       
 67084         * ksvg2/svg/SVGAnimateTransformElement.cpp:
       
 67085         (WebCore::SVGAnimateTransformElement::handleStartCondition):
       
 67086         * ksvg2/svg/SVGAnimateTransformElement.h:
       
 67087         * ksvg2/svg/SVGAnimationElement.cpp:
       
 67088         (WebCore::SVGAnimationElement::handleTimerEvent):
       
 67089         * ksvg2/svg/SVGAnimationElement.h:
       
 67090         * ksvg2/svg/SVGSetElement.cpp:
       
 67091         (WebCore::SVGSetElement::updateCurrentValue):
       
 67092         (WebCore::SVGSetElement::handleStartCondition):
       
 67093         (WebCore::SVGSetElement::handleEndCondition):
       
 67094         * ksvg2/svg/SVGSetElement.h:
       
 67095 
       
 67096 2007-01-01  Eric Seidel  <eric@webkit.org>
       
 67097 
       
 67098         Reviewed by andersca.
       
 67099 
       
 67100         Add static function SVGColor::colorFromRGBColorString to allow parsing Colors from SVG color strings w/o creating an SVGColor object.
       
 67101 
       
 67102         * ksvg2/svg/SVGAnimateColorElement.cpp:
       
 67103         (WebCore::SVGAnimateColorElement::storeInitialValue): use colorFromRGBColorString
       
 67104         (WebCore::SVGAnimateColorElement::startIfNecessary): use colorFromRGBColorString
       
 67105         * ksvg2/svg/SVGColor.cpp:
       
 67106         (WebCore::SVGColor::setRGBColor): use colorFromRGBColorString
       
 67107         (WebCore::parseNumberOrPercent): new color parsing helper
       
 67108         (WebCore::SVGColor::colorFromRGBColorString): cleaned up version of setRGBColor parsing logic
       
 67109         * ksvg2/svg/SVGColor.h:
       
 67110 
       
 67111 2007-01-01  Eric Seidel  <eric@webkit.org>
       
 67112 
       
 67113         Reviewed by andersca.
       
 67114 
       
 67115         Split handleTimerEvent logic into separate functions in preparation for moving down into SVGAnimationElement
       
 67116 
       
 67117         * ksvg2/svg/SVGAnimateColorElement.cpp:
       
 67118         (WebCore::SVGAnimateColorElement::storeInitialValue):
       
 67119         (WebCore::SVGAnimateColorElement::resetValues):
       
 67120         (WebCore::SVGAnimateColorElement::updateCurrentValue):
       
 67121         (WebCore::SVGAnimateColorElement::startIfNecessary):
       
 67122         (WebCore::SVGAnimateColorElement::handleEndCondition):
       
 67123         (WebCore::SVGAnimateColorElement::handleTimerEvent):
       
 67124         * ksvg2/svg/SVGAnimateColorElement.h:
       
 67125         * ksvg2/svg/SVGAnimateTransformElement.cpp:
       
 67126         (WebCore::SVGAnimateTransformElement::storeInitialValue):
       
 67127         (WebCore::SVGAnimateTransformElement::resetValues):
       
 67128         (WebCore::SVGAnimateTransformElement::updateCurrentValue):
       
 67129         (WebCore::SVGAnimateTransformElement::startIfNecessary):
       
 67130         (WebCore::SVGAnimateTransformElement::handleEndCondition):
       
 67131         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
       
 67132         * ksvg2/svg/SVGAnimateTransformElement.h:
       
 67133 
       
 67134 2007-01-01  Rob Buis  <buis@kde.org>
       
 67135 
       
 67136         Reviewed by Eric.
       
 67137 
       
 67138         Simple cleanups, removing unused color table, copyright and include guard fixes.
       
 67139 
       
 67140         * ksvg2/svg/SVGColor.cpp:
       
 67141         * ksvg2/svg/SVGColor.h:
       
 67142 
       
 67143 2007-01-01  Eric Seidel  <eric@webkit.org>
       
 67144 
       
 67145         Reviewed by andersca.
       
 67146 
       
 67147         More animation code cleanup.
       
 67148 
       
 67149         * ksvg2/svg/SVGAnimateColorElement.cpp:
       
 67150         (WebCore::SVGAnimateColorElement::handleTimerEvent):
       
 67151         * ksvg2/svg/SVGAnimateTransformElement.cpp:
       
 67152         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
       
 67153         * ksvg2/svg/SVGAnimationElement.cpp:
       
 67154         (WebCore::SVGAnimationElement::SVGAnimationElement):
       
 67155         (WebCore::SVGAnimationElement::connectedToTimer):
       
 67156         (WebCore::SVGAnimationElement::connectTimer):
       
 67157         (WebCore::SVGAnimationElement::disconnectTimer):
       
 67158         (WebCore::SVGAnimationElement::updateForElapsedSeconds):
       
 67159         * ksvg2/svg/SVGAnimationElement.h:
       
 67160         * ksvg2/svg/SVGSetElement.cpp:
       
 67161         (WebCore::SVGSetElement::handleTimerEvent):
       
 67162         * ksvg2/svg/SVGSetElement.h:
       
 67163 
       
 67164 2007-01-01  Eric Seidel  <eric@webkit.org>
       
 67165 
       
 67166         Reviewed by mitz.
       
 67167 
       
 67168         More clean-up to animation code.
       
 67169 
       
 67170         * ksvg2/svg/SVGAnimateColorElement.cpp:
       
 67171         (WebCore::SVGAnimateColorElement::handleTimerEvent):
       
 67172         * ksvg2/svg/SVGAnimateTransformElement.cpp:
       
 67173         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
       
 67174         (WebCore::SVGAnimateTransformElement::parseTransformValue):
       
 67175         (WebCore::SVGAnimateTransformElement::calculateRotationFromMatrix):
       
 67176 
       
 67177 2007-01-01  Eric Seidel  <eric@webkit.org>
       
 67178 
       
 67179         Reviewed by olliej.
       
 67180 
       
 67181         Begin pushing more animation logic out of SVGTimer and into the SVGAnimate* classes.
       
 67182         
       
 67183         * ksvg2/misc/SVGTimer.cpp:
       
 67184         (WebCore::SVGTimer::animationsByElement): add comment
       
 67185         (WebCore::SVGTimer::notifyAll): push logic into SVGAnimte* classes
       
 67186         * ksvg2/svg/SVGAnimateColorElement.cpp:
       
 67187         (WebCore::SVGAnimateColorElement::applyAnimationToValue): added.
       
 67188         * ksvg2/svg/SVGAnimateColorElement.h:
       
 67189         * ksvg2/svg/SVGAnimateElement.cpp:
       
 67190         * ksvg2/svg/SVGAnimateTransformElement.cpp:
       
 67191         (WebCore::SVGAnimateTransformElement::applyAnimationToValue): added.
       
 67192         * ksvg2/svg/SVGAnimateTransformElement.h:
       
 67193         * ksvg2/svg/SVGAnimationElement.cpp:
       
 67194         (WebCore::calculateTimePercentage): logic moved from SVGTimer
       
 67195         (WebCore::SVGAnimationElement::updateForElapsedSeconds): logic moved from SVGTimer
       
 67196         * ksvg2/svg/SVGAnimationElement.h:
       
 67197         * ksvg2/svg/SVGTransformList.cpp:
       
 67198         (SVGTransformList::concatenate): fixed spacing
       
 67199 
       
 67200 2007-01-01  Eric Seidel  <eric@webkit.org>
       
 67201 
       
 67202         Reviewed by olliej.
       
 67203 
       
 67204         Split out animationsByElement() logic in preparation for adding AnimationCompositor class
       
 67205         Add addColorsAndClamp helper (since adding and clamping is the common case)
       
 67206 
       
 67207         * ksvg2/misc/SVGTimer.cpp:
       
 67208         (WebCore::SVGTimer::animationsByElement): split out from notifyAll
       
 67209         (WebCore::SVGTimer::notifyAll):
       
 67210         * ksvg2/misc/SVGTimer.h:
       
 67211         * ksvg2/svg/SVGAnimateColorElement.cpp:
       
 67212         (WebCore::SVGAnimateColorElement::addColorsAndClamp): added.
       
 67213         * ksvg2/svg/SVGAnimateColorElement.h:
       
 67214 
       
 67215 2006-12-31  Eric Seidel  <eric@webkit.org>
       
 67216 
       
 67217         Reviewed by olliej.
       
 67218 
       
 67219         Split KSVGTimeScheduler into SVGTimer and TimeScheduler.
       
 67220         (Basic clean-up before re-working animation system)
       
 67221 
       
 67222         * WebCore.xcodeproj/project.pbxproj:
       
 67223         * ksvg2/misc/KSVGTimeScheduler.cpp: Removed.
       
 67224         * ksvg2/misc/KSVGTimeScheduler.h: Removed.
       
 67225         * ksvg2/misc/SVGTimer.cpp: Added.
       
 67226         (WebCore::SVGTimer::SVGTimer):
       
 67227         (WebCore::SVGTimer::calculateTimePercentage):
       
 67228         (WebCore::SVGTimer::notifyAll):
       
 67229         * ksvg2/misc/SVGTimer.h: Added.
       
 67230         * ksvg2/misc/TimeScheduler.cpp: Added.
       
 67231         (WebCore::TimeScheduler::TimeScheduler):
       
 67232 
       
 67233 2006-12-31  Eric Seidel  <eric@webkit.org>
       
 67234 
       
 67235         Reviewed by olliej.
       
 67236 
       
 67237         Re-enable animateTransform (now that SVGList is fixed)
       
 67238         (Things are only "less broken" not totally fixed yet.)
       
 67239 
       
 67240         * ksvg2/misc/KSVGTimeScheduler.cpp:
       
 67241         (WebCore::SVGTimer::notifyAll):
       
 67242 
       
 67243 2006-12-31  Mitz Pettel  <mitz@webkit.org>
       
 67244 
       
 67245         Reviewed by Hyatt.
       
 67246 
       
 67247         - http://bugs.webkit.org/show_bug.cgi?id=12049
       
 67248           RenderBlock::calcMinMaxWidth() should not examine children of fixed-width blocks
       
 67249 
       
 67250         No test possible (no change to functionality).
       
 67251 
       
 67252         * rendering/RenderBlock.cpp:
       
 67253         (WebCore::RenderBlock::calcMinMaxWidth): Call calc{Inline,Block}MinMaxWidth()
       
 67254         only if their result is needed.
       
 67255 
       
 67256 == Rolled over to ChangeLog-2006-12-31 ==