diff -r cbb19216b74d -r 00c6709d25aa datacommsserver/esockserver/ssock/ss_connstates.cpp --- a/datacommsserver/esockserver/ssock/ss_connstates.cpp Thu Jul 15 20:01:43 2010 +0300 +++ b/datacommsserver/esockserver/ssock/ss_connstates.cpp Thu Aug 19 11:05:47 2010 +0300 @@ -56,7 +56,7 @@ #include #include #endif - +#include #ifdef _DEBUG // Panic category for "absolutely impossible!" vanilla ASSERT()-type panics from this module // (if it could happen through user error then you should give it an explicit, documented, category + code) @@ -252,35 +252,6 @@ TCFMessage::TStateChange(TStateChange(KFinishedSelection,KErrNone)).CRef()); } -DEFINE_SMELEMENT(ConnStates::TJoinReceivedCpr, NetStateMachine::MStateTransition, ConnStates::TContext) -void ConnStates::TJoinReceivedCpr::DoL() - { - __ASSERT_DEBUG(iContext.iNodeActivity, ConnPanic(KPanicNoActivity)); - __ASSERT_DEBUG(iContext.Node().ServiceProvider()==NULL, ConnPanic(KPanicExpectedNoServiceProvider)); - - TCFDataClient::TBindTo& bt = message_cast(iContext.iMessage); - RNodeInterface* newSP = iContext.Node().AddClientL(bt.iNodeId, TClientType(TCFClientType::EServProvider, TCFClientType::EActive)); - __ASSERT_DEBUG(iContext.Node().ServiceProvider()==newSP, ConnPanic(KPanicNoServiceProvider)); //[RZ] revise this, possibly overdefensive - - //If this is attach, we need to see if we are a monitor or not - TClientType clientType(TCFClientType::ECtrl); - - TUint selPrefs = static_cast(*iContext.iNodeActivity).SelectionPrefs().Flags(); - if (selPrefs & TSelectionPrefs::EMonitor) - { - clientType.SetFlags(TCFClientType::EMonitor); - iContext.Node().iIsMonitor = ETrue; - } - - // If it is an attach set the flag cause it is used by NetUPS to check if a JoinRequest comes from an RConnection::Attach - if (selPrefs & TSelectionPrefs::EAttach) - { - clientType.SetFlags(TCFClientType::EAttach); - } - iContext.iNodeActivity->PostRequestTo(*newSP, - TCFServiceProvider::TJoinRequest(iContext.NodeId(), clientType).CRef()); - } - DEFINE_SMELEMENT(ConnStates::TJoinReceivedSCpr, NetStateMachine::MStateTransition, ConnStates::TContext) void ConnStates::TJoinReceivedSCpr::DoL() { @@ -1303,9 +1274,61 @@ { iNode.RemoveClient(aux->RecipientId()); } + + if (iRegisteredForInterfaceStateChanges) + { + CCommsFactoryBase* ipProtoCprFactory = IpProtoCprFactory(); + if (ipProtoCprFactory) + { + Factories::IFactoryNotify itf(this, GetVTable()); + ipProtoCprFactory->DeRegisterNotifier(itf); + } + } + delete iAllInterfaceNotificationWorker; //delete this node (why via iAllInterfaceNotificationWorker??) } +/** +Called by the IpProtoCpr factory to propagate an interface state change from IpProtoCpr to registered +observers (suc as ourself). If the interface is restarting, then we need to insert an EInterfaceDown, +EInterfaceUp "toggle" sequence into the AllInterfaceNotification queue. This is because, ordinarily, +EInterfaceUp and EInterfaceDown are generated when the IpProtoCpr itself is created and destroyed, +but not if it is restarted before being destroyed. +*/ +void CAllInterfaceNotificationActivity::InterfaceStateChangeNotification(const TDesC8& aInfo) + { + if (aInfo.Length() == sizeof(TInterfaceNotification)) + { + const TInterfaceNotification* const info = reinterpret_cast(aInfo.Ptr()); + if (info && info->iState == EInterfaceRestarting) + { + LOG( ESockLog::Printf(KESockConnectionTag, _L("CAllInterfaceNotificationActivity %08x:\tInterfaceStateChangeNotification(): CConnection %08x, IapId %d, NetId %d"), + this, &iAllInterfaceNotificationWorker->iConnection, info->iConnectionInfo.iIapId, info->iConnectionInfo.iNetId )); + + AConnectionLegacy& legacy = iAllInterfaceNotificationWorker->iConnection.iLegacyConnection; + TInterfaceNotification notification(*info); + notification.iState = EInterfaceDown; + legacy.iNotificationQueue.Enque(notification); + notification.iState = EInterfaceUp; + legacy.iNotificationQueue.Enque(notification); + legacy.CompleteAllInterfaceNotificationL(KErrNone); + } + } + } + +CCommsFactoryBase* CAllInterfaceNotificationActivity::IpProtoCprFactory() const + { + CConnectionFactoryContainer& container = *static_cast(iAllInterfaceNotificationWorker->iConnection.Player()).SockManGlobals()->iConnectionFactories; + return static_cast(container.FindFactory(TUid::Uid(AConnectionLegacy::KIPProtoConnectionProviderFactoryUid))); + } + +// Registration table for receiving InterfaceStateChangeNotification() events. +const Factories::TAnyFn CAllInterfaceNotificationActivity::iInterfaceVTableF[] = + { + (Factories::TAnyFn)1, // number of methods. the following entries must be in this order! + (Factories::TAnyFn)(Factories::TFactoryNotify::Notification) + }; + // States DEFINE_SMELEMENT(AllInterfaceNotificationActivity::TAwaitingStart, NetStateMachine::MState, TContext) @@ -1461,6 +1484,23 @@ TCFTierStatusProvider::TTierNotification& msg = message_cast(iContext.iMessage); __ASSERT_DEBUG(msg.iBundle, User::Panic(KSpecAssert_ESockSSockscnsts, 14)); + + CAllInterfaceNotificationActivity& act = *iContext.Activity(); + + // Register with the IpProtoCpr factory for interface state changes if we haven't already done so. + // We can only do this if the IpProtoCpr is active, and the assumption here is that it must be active + // if an interface event has been generated. + if (!act.iRegisteredForInterfaceStateChanges) + { + CCommsFactoryBase* ipProtoCprFactory = act.IpProtoCprFactory(); + if (ipProtoCprFactory) + { + Factories::IFactoryNotify itf(&act, act.GetVTable()); + ipProtoCprFactory->RegisterNotifierL(itf); + act.iRegisteredForInterfaceStateChanges = ETrue; + } + } + if(msg.iBundle->PtrL()->CountParamSetContainers() > 0) { TInt i = 0;