diff -r f92a4f87e424 -r 012cc2ee6408 usbmgmt/usbmgr/device/classdrivers/acm/classimplementation/ecacm/src/CdcDataInterface.cpp --- a/usbmgmt/usbmgr/device/classdrivers/acm/classimplementation/ecacm/src/CdcDataInterface.cpp Tue Aug 31 17:01:47 2010 +0300 +++ b/usbmgmt/usbmgr/device/classdrivers/acm/classimplementation/ecacm/src/CdcDataInterface.cpp Wed Sep 01 12:35:00 2010 +0100 @@ -1,5 +1,5 @@ /* -* Copyright (c) 1997-2010 Nokia Corporation and/or its subsidiary(-ies). +* Copyright (c) 1997-2009 Nokia Corporation and/or its subsidiary(-ies). * All rights reserved. * This component and the accompanying materials are made available * under the terms of "Eclipse Public License v1.0" @@ -23,12 +23,12 @@ #include "AcmUtils.h" #include "ActiveReadOneOrMoreReader.h" #include "ActiveDataAvailableNotifier.h" -#include "OstTraceDefinitions.h" -#ifdef OST_TRACE_COMPILER_IN_USE -#include "CdcDataInterfaceTraces.h" +#include + +#ifdef __FLOG_ACTIVE +_LIT8(KLogComponent, "ECACM"); #endif - #ifdef __HEADLESS_ACM_TEST_CODE__ #pragma message ("Building headless ACM (performance test code for RDevUsbcClient)") #endif // __HEADLESS_ACM_TEST_CODE__ @@ -41,8 +41,6 @@ : CCdcInterfaceBase(aIfcName), iPacketSize(KDefaultMaxPacketTypeBulk) { - OstTraceFunctionEntry0( CCDCDATAINTERFACE_CCDCDATAINTERFACE_CONS_ENTRY ); - OstTraceFunctionExit0( CCDCDATAINTERFACE_CCDCDATAINTERFACE_CONS_EXIT ); } CCdcDataInterface* CCdcDataInterface::NewL(const TDesC16& aIfcName) @@ -55,13 +53,14 @@ * @return A pointer to the new object */ { - OstTraceFunctionEntry0( CCDCDATAINTERFACE_NEWL_ENTRY ); - OstTraceExt1( TRACE_NORMAL, CCDCDATAINTERFACE_NEWL, "CCdcDataInterface::NewL;\tData Ifc Name = %S", aIfcName ); + LOG_STATIC_FUNC_ENTRY + + LOGTEXT2(_L("\tData Ifc Name = %S"), &aIfcName); + CCdcDataInterface* self = new (ELeave) CCdcDataInterface(aIfcName); CleanupStack::PushL(self); self->ConstructL(); CLEANUPSTACK_POP(self); - OstTraceFunctionExit0( CCDCDATAINTERFACE_NEWL_EXIT ); return self; } @@ -73,9 +72,8 @@ * @param aParent Observer. */ { - OstTraceFunctionEntry0( CCDCDATAINTERFACE_CONSTRUCTL_ENTRY ); - BaseConstructL(); + iReadOneOrMoreReader = CActiveReadOneOrMoreReader::NewL(*this, iLdd, EEndpoint2); iReader = CActiveReader::NewL(*this, iLdd, EEndpoint2); iDataAvailableNotifier = CActiveDataAvailableNotifier::NewL(*this, iLdd, EEndpoint2); @@ -86,7 +84,6 @@ iHostCanHandleZLPs = (KUsbAcmHostCanHandleZLPs != 0); - OstTraceFunctionExit0( CCDCDATAINTERFACE_CONSTRUCTL_EXIT ); } TInt CCdcDataInterface::SetUpInterface() @@ -96,15 +93,14 @@ * descriptor for the endpoints is registered with the LDD. */ { - OstTraceFunctionEntry0( CCDCDATAINTERFACE_SETUPINTERFACE_ENTRY ); + LOGTEXT(_L8(">>CCdcDataInterface::SetUpInterface")); TUsbDeviceCaps dCaps; TInt ret = iLdd.DeviceCaps(dCaps); - OstTrace0( TRACE_NORMAL, CCDCDATAINTERFACE_SETUPINTERFACE, "CCdcDataInterface::SetUpInterface;\tchecking result of DeviceCaps" ); + LOGTEXT(_L8("\tchecking result of DeviceCaps")); if ( ret ) { - OstTrace1( TRACE_NORMAL, CCDCDATAINTERFACE_SETUPINTERFACE_DUP1, "CCdcDataInterface::SetUpInterface;ret=%d", ret ); - OstTraceFunctionExit0( CCDCDATAINTERFACE_SETUPINTERFACE_EXIT ); + LOGTEXT2(_L8("<(dCaps().iTotalEndpoints); - OstTrace1( TRACE_NORMAL, CCDCDATAINTERFACE_SETUPINTERFACE_DUP2, - "CCdcDataInterface::SetUpInterface;totalEndpoints=%d", (TInt)totalEndpoints ); - + LOGTEXT2(_L8("\tiTotalEndpoints = %d"), totalEndpoints); if ( totalEndpoints < KRequiredNumberOfEndpoints ) { - OstTrace1( TRACE_NORMAL, CCDCDATAINTERFACE_SETUPINTERFACE_DUP3, "CCdcDataInterface::SetUpInterface;ret=%d", KErrGeneral ); - OstTraceFunctionExit0( CCDCDATAINTERFACE_SETUPINTERFACE_EXIT_DUP1 ); + LOGTEXT2(_L8("<(data), sizeof(data), sizeof(data)); ret = iLdd.EndpointCaps(dataptr); - OstTrace0( TRACE_NORMAL, CCDCDATAINTERFACE_SETUPINTERFACE_DUP9, "CCdcDataInterface::SetUpInterface;\tchecking result of EndpointCaps" ); + LOGTEXT(_L8("\tchecking result of EndpointCaps")); if ( ret ) { - OstTrace1( TRACE_NORMAL, CCDCDATAINTERFACE_SETUPINTERFACE_DUP4, "CCdcDataInterface::SetUpInterface;ret=%d", ret ); - OstTraceFunctionExit0( CCDCDATAINTERFACE_SETUPINTERFACE_EXIT_DUP2 ); + LOGTEXT2(_L8("<Write(aDes, aLen, EFalse); } - OstTraceFunctionExit0( CCDCDATAINTERFACE_WRITE_EXIT ); + LOGTEXT(_L8("<>CCdcDataInterface::WriteCompleted aError=%d"), aError); #ifdef __HEADLESS_ACM_TEST_CODE__ // Issue another Read or ReadOneOrMore as appropriate. // If the Write completed with an error, we panic, as it's invalidating // the test. - if (aError != KErrNone) - { - OstTrace1( TRACE_FATAL, CCDCDATAINTERFACE_WRITECOMPLETED_DUP1, "CCdcDataInterface::WriteCompleted;aError=%d", aError ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); - } + __ASSERT_DEBUG(aError == KErrNone, + _USB_PANIC(KAcmPanicCat, EPanicInternalError)); switch ( iHeadlessReadType ) { case ERead: - OstTrace1( TRACE_NORMAL, CCDCDATAINTERFACE_WRITECOMPLETED_DUP2, - "CCdcDataInterface::WriteCompleted;__HEADLESS_ACM_TEST_CODE__- issuing Read for %d bytes", iHeadlessReadLength ); - - if (!iReader) - { - OstTraceExt1( TRACE_FATAL, CCDCDATAINTERFACE_WRITECOMPLETED_DUP3, "CCdcDataInterface::WriteCompleted;iReader=%p", iReader ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); - } + LOGTEXT2(_L8("__HEADLESS_ACM_TEST_CODE__- issuing Read for %d bytes"), + iHeadlessReadLength); + __ASSERT_DEBUG(iReader, _USB_PANIC(KAcmPanicCat, EPanicInternalError)); iReader->Read(iHeadlessAcmBuffer, iHeadlessReadLength); break; case EReadOneOrMore: - OstTrace1( TRACE_NORMAL, CCDCDATAINTERFACE_WRITECOMPLETED_DUP4, - "CCdcDataInterface::WriteCompleted;__HEADLESS_ACM_TEST_CODE__- issuing ReadOneOrMore for %d bytes", iHeadlessReadLength ); - - if (!iReadOneOrMoreReader) - { - OstTraceExt1( TRACE_FATAL, CCDCDATAINTERFACE_WRITECOMPLETED_DUP5, - "CCdcDataInterface::WriteCompleted;iReadOneOrMoreReader=%p", iReadOneOrMoreReader ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); - } + LOGTEXT2(_L8("__HEADLESS_ACM_TEST_CODE__- issuing ReadOneOrMore for %d bytes"), + iHeadlessReadLength); + __ASSERT_DEBUG(iReadOneOrMoreReader, _USB_PANIC(KAcmPanicCat, EPanicInternalError)); iReadOneOrMoreReader->ReadOneOrMore(iHeadlessAcmBuffer, iHeadlessReadLength); break; case EUnknown: default: - OstTrace0( TRACE_FATAL, CCDCDATAINTERFACE_WRITECOMPLETED_DUP6, "CCdcDataInterface::WriteCompleted;EPanicInternalError" ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); + _USB_PANIC(KAcmPanicCat, EPanicInternalError); break; } #else // In case the write observer wants to post another write synchronously on // being informed that this write has completed, use this little 'temp' // fiddle. - if (!iWriteObserver) - { - OstTraceExt1( TRACE_FATAL, CCDCDATAINTERFACE_WRITECOMPLETED_DUP7, - "CCdcDataInterface::WriteCompleted;iWriteObserver=%p", iWriteObserver ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); - } + __ASSERT_DEBUG(iWriteObserver, + _USB_PANIC(KAcmPanicCat, EPanicInternalError)); MWriteObserver* temp = iWriteObserver; iWriteObserver = NULL; - OstTrace0( TRACE_NORMAL, CCDCDATAINTERFACE_WRITECOMPLETED_DUP8, - "CCdcDataInterface::WriteCompleted;\tcalling WriteCompleted on observer" ); + LOGTEXT(_L8("\tcalling WriteCompleted on observer")); temp->WriteCompleted(aError); #endif // __HEADLESS_ACM_TEST_CODE__ - OstTraceFunctionExit0( CCDCDATAINTERFACE_WRITECOMPLETED_EXIT ); + LOGTEXT(_L8("<Cancel(); + iWriteObserver = NULL; - OstTraceFunctionExit0( CCDCDATAINTERFACE_CANCELWRITE_EXIT ); } void CCdcDataInterface::Read(MReadObserver& aObserver, @@ -385,42 +345,27 @@ * @param aMaxLen Number of bytes to read */ { - OstTraceFunctionEntry0( CCDCDATAINTERFACE_READ_ENTRY ); - + LOG_FUNC + #ifdef __HEADLESS_ACM_TEST_CODE__ - OstTrace0( TRACE_NORMAL, CCDCDATAINTERFACE_READ, "CCdcDataInterface::Read;__HEADLESS_ACM_TEST_CODE__" ); + LOGTEXT(_L8("__HEADLESS_ACM_TEST_CODE__")); // Issue a Read using our special internal buffer. iHeadlessReadType = ERead; iHeadlessReadLength = aMaxLen; static_cast(&aObserver); static_cast(&aDes); - if (aMaxLen > iHeadlessAcmBuffer.MaxLength()) - { - OstTrace1( TRACE_FATAL, CCDCDATAINTERFACE_READ_DUP1, "CCdcDataInterface::Read;aMaxLen=%d", aMaxLen ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); - } - if (!iReader) - { - OstTraceExt1( TRACE_FATAL, CCDCDATAINTERFACE_READ_DUP2, "CCdcDataInterface::Read;iReader=%p", iReader ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); - } + __ASSERT_DEBUG(aMaxLen <= iHeadlessAcmBuffer.MaxLength(), + _USB_PANIC(KAcmPanicCat, EPanicInternalError)); + __ASSERT_DEBUG(iReader, _USB_PANIC(KAcmPanicCat, EPanicInternalError)); iReader->Read(iHeadlessAcmBuffer, aMaxLen); #else - if (iReadObserver) - { - OstTraceExt1( TRACE_FATAL, CCDCDATAINTERFACE_READ_DUP3, "CCdcDataInterface::Read;iReadObserver=%p", iReadObserver ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); - } + __ASSERT_DEBUG(!iReadObserver, + _USB_PANIC(KAcmPanicCat, EPanicInternalError)); iReadObserver = &aObserver; - if (!iReader) - { - OstTraceExt1( TRACE_FATAL, CCDCDATAINTERFACE_READ_DUP4, "CCdcDataInterface::Read;iReader=%p", iReader ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); - } - + + __ASSERT_DEBUG(iReader, _USB_PANIC(KAcmPanicCat, EPanicInternalError)); iReader->Read(aDes, aMaxLen); #endif // __HEADLESS_ACM_TEST_CODE__ - OstTraceFunctionExit0( CCDCDATAINTERFACE_READ_EXIT ); } void CCdcDataInterface::ReadOneOrMore(MReadOneOrMoreObserver& aObserver, @@ -435,45 +380,29 @@ * @param aMaxLen Number of bytes to read */ { - OstTraceFunctionEntry0( CCDCDATAINTERFACE_READONEORMORE_ENTRY ); - + LOG_FUNC #ifdef __HEADLESS_ACM_TEST_CODE__ - OstTrace0( TRACE_NORMAL, CCDCDATAINTERFACE_READONEORMORE, "CCdcDataInterface::ReadOneOrMore;__HEADLESS_ACM_TEST_CODE__" ); + LOGTEXT(_L8("__HEADLESS_ACM_TEST_CODE__")); // Issue a ReadOneOrMore using our special internal buffer. iHeadlessReadType = EReadOneOrMore; iHeadlessReadLength = aMaxLen; static_cast(&aObserver); static_cast(&aDes); - if (aMaxLen > iHeadlessAcmBuffer.MaxLength()) - { - OstTrace1( TRACE_FATAL, CCDCDATAINTERFACE_READONEORMORE_DUP1, "CCdcDataInterface::ReadOneOrMore;aMaxLen=%d", aMaxLen ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); - } - if (!iReadOneOrMoreReader) - { - OstTraceExt1( TRACE_FATAL, CCDCDATAINTERFACE_READONEORMORE_DUP2, - "CCdcDataInterface::ReadOneOrMore;iReadOneOrMoreReader=%p", iReadOneOrMoreReader ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); - } + __ASSERT_DEBUG(aMaxLen <= iHeadlessAcmBuffer.MaxLength(), + _USB_PANIC(KAcmPanicCat, EPanicInternalError)); + __ASSERT_DEBUG(iReadOneOrMoreReader, + _USB_PANIC(KAcmPanicCat, EPanicInternalError)); iReadOneOrMoreReader->ReadOneOrMore(iHeadlessAcmBuffer, aMaxLen); #else - if (iReadOneOrMoreObserver) - { - OstTraceExt1( TRACE_FATAL, CCDCDATAINTERFACE_READONEORMORE_DUP3, - "CCdcDataInterface::ReadOneOrMore;iReadOneOrMoreObserver=%p", iReadOneOrMoreObserver ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); - } + __ASSERT_DEBUG(!iReadOneOrMoreObserver, + _USB_PANIC(KAcmPanicCat, EPanicInternalError)); iReadOneOrMoreObserver = &aObserver; - if (!iReadOneOrMoreReader) - { - OstTraceExt1( TRACE_FATAL, CCDCDATAINTERFACE_READONEORMORE_DUP4, - "CCdcDataInterface::ReadOneOrMore;iReadOneOrMoreObserver=%p", iReadOneOrMoreObserver ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); - } + + __ASSERT_DEBUG(iReadOneOrMoreReader, + _USB_PANIC(KAcmPanicCat, EPanicInternalError)); iReadOneOrMoreReader->ReadOneOrMore(aDes, aMaxLen); #endif // __HEADLESS_ACM_TEST_CODE__ - OstTraceFunctionExit0( CCDCDATAINTERFACE_READONEORMORE_EXIT ); } void CCdcDataInterface::ReadOneOrMoreCompleted(TInt aError) @@ -484,47 +413,31 @@ * @param aError The result of the read request. */ { - OstTraceFunctionEntry0( CCDCDATAINTERFACE_READONEORMORECOMPLETED_ENTRY ); - OstTrace1( TRACE_NORMAL, CCDCDATAINTERFACE_READONEORMORECOMPLETED, "CCdcDataInterface::ReadOneOrMoreCompleted;aError=%d", aError ); + LOGTEXT2(_L8(">>CCdcDataInterface::ReadOneOrMoreCompleted aError=%d"), + aError); #ifdef __HEADLESS_ACM_TEST_CODE__ - OstTrace1( TRACE_NORMAL, CCDCDATAINTERFACE_READONEORMORECOMPLETED_DUP1, - "CCdcDataInterface::ReadOneOrMoreCompleted;__HEADLESS_ACM_TEST_CODE__- issuing Write for %d bytes", iHeadlessAcmBuffer.Length() ); - + LOGTEXT2(_L8("__HEADLESS_ACM_TEST_CODE__- issuing Write for %d bytes"), + iHeadlessAcmBuffer.Length()); // Write back the data just read. // If the ReadOneOrMore completed with an error, we panic, as it's // invalidating the test. - if (aError != KErrNone) - { - OstTrace1( TRACE_FATAL, CCDCDATAINTERFACE_READONEORMORECOMPLETED_DUP2, - "CCdcDataInterface::ReadOneOrMoreCompleted;aError=%d", aError ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); - } - - if (!iWriter) - { - OstTraceExt1( TRACE_FATAL, CCDCDATAINTERFACE_READONEORMORECOMPLETED_DUP3, - "CCdcDataInterface::ReadOneOrMoreCompleted;iWriter=%p", iWriter ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); - } + __ASSERT_DEBUG(aError == KErrNone, + _USB_PANIC(KAcmPanicCat, EPanicInternalError)); + __ASSERT_DEBUG(iWriter, _USB_PANIC(KAcmPanicCat, EPanicInternalError)); iWriter->Write(iHeadlessAcmBuffer, iHeadlessAcmBuffer.Length(), EFalse); #else - if (!iReadOneOrMoreObserver) - { - OstTraceExt1( TRACE_FATAL, CCDCDATAINTERFACE_READONEORMORECOMPLETED_DUP4, - "CCdcDataInterface::ReadOneOrMoreCompleted;iReadOneOrMoreObserver=%p", iReadOneOrMoreObserver ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); - } + __ASSERT_DEBUG(iReadOneOrMoreObserver, + _USB_PANIC(KAcmPanicCat, EPanicInternalError)); // See comment in WriteCompleted. MReadOneOrMoreObserver* temp = iReadOneOrMoreObserver; iReadOneOrMoreObserver = NULL; - OstTrace0( TRACE_NORMAL, CCDCDATAINTERFACE_READONEORMORECOMPLETED_DUP5, - "CCdcDataInterface::ReadOneOrMoreCompleted;\tcalling ReadOneOrMoreCompleted on observer" ); + LOGTEXT(_L8("\tcalling ReadOneOrMoreCompleted on observer")); temp->ReadOneOrMoreCompleted(aError); #endif // __HEADLESS_ACM_TEST_CODE__ - OstTraceFunctionExit0( CCDCDATAINTERFACE_READONEORMORECOMPLETED_EXIT ); + LOGTEXT(_L8("<>CCdcDataInterface::ReadCompleted aError=%d"), aError); #ifdef __HEADLESS_ACM_TEST_CODE__ - OstTrace1( TRACE_NORMAL, CCDCDATAINTERFACE_READCOMPLETED_DUP1, - "CCdcDataInterface::ReadCompleted;__HEADLESS_ACM_TEST_CODE__- issuing Write for %d bytes", iHeadlessAcmBuffer.Length() ); - + LOGTEXT2(_L8("__HEADLESS_ACM_TEST_CODE__- issuing Write for %d bytes"), + iHeadlessAcmBuffer.Length()); // Write back the data just read. // If the Read completed with an error, we panic, as it's invalidating the // test. - if (aError != KErrNone) - { - OstTrace1( TRACE_FATAL, CCDCDATAINTERFACE_READCOMPLETED_DUP2, "CCdcDataInterface::ReadCompleted;aError=%d", aError ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); - } - - if (!iWriter) - { - OstTraceExt1( TRACE_NORMAL, CCDCDATAINTERFACE_READCOMPLETED_DUP3, "CCdcDataInterface::ReadCompleted;iWriter=%p", iWriter ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); - } + __ASSERT_DEBUG(aError == KErrNone, + _USB_PANIC(KAcmPanicCat, EPanicInternalError)); + __ASSERT_DEBUG(iWriter, _USB_PANIC(KAcmPanicCat, EPanicInternalError)); iWriter->Write(iHeadlessAcmBuffer, iHeadlessAcmBuffer.Length(), EFalse); #else - if (!iReadObserver) - { - OstTraceExt1( TRACE_FATAL, CCDCDATAINTERFACE_READCOMPLETED_DUP4, - "CCdcDataInterface::ReadCompleted;iReadObserver=%p", iReadObserver ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); - } + __ASSERT_DEBUG(iReadObserver, + _USB_PANIC(KAcmPanicCat, EPanicInternalError)); // See comment in WriteCompleted. MReadObserver* temp = iReadObserver; iReadObserver = NULL; - OstTrace0( TRACE_NORMAL, CCDCDATAINTERFACE_READCOMPLETED_DUP5, "CCdcDataInterface::ReadCompleted;\tcalled ReadCompleted on observer" ); + LOGTEXT(_L8("\tcalled ReadCompleted on observer")); temp->ReadCompleted(aError); #endif // __HEADLESS_ACM_TEST_CODE__ - OstTraceFunctionExit0( CCDCDATAINTERFACE_READCOMPLETED_EXIT ); + LOGTEXT(_L8("<Cancel(); iReadOneOrMoreReader->Cancel(); iReadObserver = NULL; iReadOneOrMoreObserver = NULL; - OstTraceFunctionExit0( CCDCDATAINTERFACE_CANCELREAD_EXIT ); } @@ -607,17 +498,15 @@ * @param aError Error. */ { - OstTraceFunctionEntry0( CCDCDATAINTERFACE_NOTIFYDATAAVAILABLECOMPLETED_ENTRY ); - OstTrace1( TRACE_NORMAL, CCDCDATAINTERFACE_NOTIFYDATAAVAILABLECOMPLETED, - "CCdcDataInterface::NotifyDataAvailableCompleted;aError=%d", aError ); + LOGTEXT2(_L8(">>CCdcDataInterface::NotifyDataAvailableCompleted aError=%d"), aError); // See comment in WriteCompleted. MNotifyDataAvailableObserver* temp = iNotifyDataAvailableObserver; iNotifyDataAvailableObserver = NULL; - OstTrace0( TRACE_NORMAL, CCDCDATAINTERFACE_NOTIFYDATAAVAILABLECOMPLETED_DUP1, - "CCdcDataInterface::NotifyDataAvailableCompleted;\tcalled NotifyDataAvailableCompleted on observer" ); + LOGTEXT(_L8("\tcalled NotifyDataAvailableCompleted on observer")); temp->NotifyDataAvailableCompleted(aError); - OstTraceFunctionExit0( CCDCDATAINTERFACE_NOTIFYDATAAVAILABLECOMPLETED_EXIT ); + + LOGTEXT(_L8("<NotifyDataAvailable(); - OstTraceFunctionExit0( CCDCDATAINTERFACE_NOTIFYDATAAVAILABLE_EXIT ); } void CCdcDataInterface::CancelNotifyDataAvailable() @@ -651,16 +531,12 @@ * Cancel notification of arrival of data. */ { - OstTraceFunctionEntry0( CCDCDATAINTERFACE_CANCELNOTIFYDATAAVAILABLE_ENTRY ); - if (!iDataAvailableNotifier) - { - OstTraceExt1( TRACE_FATAL, CCDCDATAINTERFACE_CANCELNOTIFYDATAAVAILABLE, - "CCdcDataInterface::CancelNotifyDataAvailable;iDataAvailableNotifier=%p", iDataAvailableNotifier ); - __ASSERT_DEBUG( EFalse, User::Panic(KAcmPanicCat, EPanicInternalError) ); - } + LOG_FUNC + + __ASSERT_DEBUG(iDataAvailableNotifier, _USB_PANIC(KAcmPanicCat, EPanicInternalError)); + iDataAvailableNotifier->Cancel(); iNotifyDataAvailableObserver = NULL; - OstTraceFunctionExit0( CCDCDATAINTERFACE_CANCELNOTIFYDATAAVAILABLE_EXIT ); } //