|
1 # ################################################################# |
|
2 # Copyright (c) 2009 Nokia Corporation and/or its subsidiary(-ies). |
|
3 # All rights reserved. |
|
4 # |
|
5 # Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: |
|
6 # |
|
7 # * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. |
|
8 # * Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. |
|
9 # * Neither the name of Nokia Corporation nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. |
|
10 # |
|
11 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, |
|
12 # THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS |
|
13 # BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF |
|
14 # SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN |
|
15 # CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.# |
|
16 # |
|
17 # arrayptrcleanup.py |
|
18 # |
|
19 # Checks : Using local CArrayPtr classes without cleanup items. |
|
20 # |
|
21 # Reason : It is not enough to push a local CArrayPtr class onto |
|
22 # the cleanup stack. A TCleanupItem and callback function must be |
|
23 # used to avoid leaking the elements. |
|
24 # |
|
25 # ################################################################# |
|
26 |
|
27 script = CScript("arrayptrcleanup") |
|
28 script.iReString = r""" |
|
29 \s+ |
|
30 ( |
|
31 \w+ |
|
32 ) |
|
33 \s* |
|
34 = |
|
35 \s* |
|
36 new |
|
37 \s* |
|
38 \( |
|
39 \s* |
|
40 ELeave |
|
41 \s* |
|
42 \) |
|
43 \s* |
|
44 CArrayPtr |
|
45 """ |
|
46 script.iFileExts = ["cpp"] |
|
47 script.iCategory = KCategoryCodeReviewGuides |
|
48 script.iIgnore = KIgnoreCommentsAndQuotes |
|
49 script.iSeverity = KSeverityLow |
|
50 |
|
51 def arrayptrcleanupcompare(lines, currentline, rematch, filename): |
|
52 m = rematch.search(lines[currentline]) |
|
53 if m: |
|
54 varName = m.group(1) |
|
55 if (len(varName) == 1) or (varName[0] not in "ai") or varName[1].islower(): |
|
56 for i in range(currentline, currentline + 10): |
|
57 if i >= len(lines): |
|
58 break |
|
59 elif (lines[i].find("TCleanupItem") <> -1) and (lines[i].find(varName) <> -1): |
|
60 return 0 |
|
61 return 1 |
|
62 return 0 |
|
63 |
|
64 script.iCompare = arrayptrcleanupcompare |
|
65 scanner.AddScript(script) |