|
1 # ################################################################# |
|
2 # Copyright (c) 2009 Nokia Corporation and/or its subsidiary(-ies). |
|
3 # All rights reserved. |
|
4 # |
|
5 # Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: |
|
6 # |
|
7 # * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. |
|
8 # * Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. |
|
9 # * Neither the name of Nokia Corporation nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. |
|
10 # |
|
11 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, |
|
12 # THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS |
|
13 # BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF |
|
14 # SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN |
|
15 # CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.# |
|
16 # |
|
17 # destructor.py |
|
18 # |
|
19 # Checks : Pointer access in destructors. |
|
20 # |
|
21 # Reason : Accessing pointers to objects in destructors without |
|
22 # checking whether they are not NULL could result in a panic, since |
|
23 # they may not have been constructed. The pointers should be |
|
24 # checked to determine whether they are owned objects. If they are |
|
25 # not owned, they should really be references rather than pointers. |
|
26 # |
|
27 # ################################################################# |
|
28 |
|
29 script = CScript("destructor") |
|
30 script.iReString = r""" |
|
31 ^\s* |
|
32 \w+ |
|
33 \s* |
|
34 ::~ |
|
35 \s* |
|
36 \w+ |
|
37 \( |
|
38 """ |
|
39 script.iFileExts = ["cpp"] |
|
40 script.iCategory = KCategoryCanPanic |
|
41 script.iIgnore = KIgnoreCommentsAndQuotes |
|
42 script.iSeverity = KSeverityHigh |
|
43 |
|
44 remember = re.compile("(i[A-Z]\w*)(.+)") |
|
45 reguard = re.compile("^\s*(if|while)(.*)({|$)") |
|
46 |
|
47 def findguard(lines, currentline, destructorstartline, membername): |
|
48 i = currentline |
|
49 line = lines[i] |
|
50 |
|
51 while (i > destructorstartline): |
|
52 line = lines[i] |
|
53 m = reguard.search(line) |
|
54 if m: |
|
55 index = m.group(2).find(membername) |
|
56 if (index <> -1): |
|
57 if (line[index - 1:index] <> "*") and (line[index + len(membername):index + len(membername) + 2] <> "->"): |
|
58 return 1 |
|
59 i = i - 1 |
|
60 |
|
61 return 0 |
|
62 |
|
63 def destructorcompare(lines, currentline, rematch, filename): |
|
64 m = rematch.search(lines[currentline]) |
|
65 if m: |
|
66 openbracecount = 0 |
|
67 closebracecount = 0 |
|
68 checkline = currentline |
|
69 |
|
70 while (checkline < len(lines)): |
|
71 line = lines[checkline] |
|
72 openbracecount += line.count("{") |
|
73 closebracecount += line.count("}") |
|
74 member = remember.search(line) |
|
75 if member and ((member.group(2)[:2] == "->") or (line[member.start()-1:member.start()] == "*" and member.group(2)[:1] <> ".")): |
|
76 membername = member.group(1) |
|
77 if (membername.upper()[-3:] == "ENV") or findguard(lines, checkline, currentline, membername) <> 0: |
|
78 return 0 |
|
79 else: |
|
80 return 1 |
|
81 |
|
82 if (openbracecount and (openbracecount - closebracecount == 0)): |
|
83 break |
|
84 checkline += 1 |
|
85 |
|
86 return 0 |
|
87 |
|
88 script.iCompare = destructorcompare |
|
89 scanner.AddScript(script) |