|
1 # ################################################################# |
|
2 # Copyright (c) 2009 Nokia Corporation and/or its subsidiary(-ies). |
|
3 # All rights reserved. |
|
4 # |
|
5 # Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: |
|
6 # |
|
7 # * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. |
|
8 # * Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. |
|
9 # * Neither the name of Nokia Corporation nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. |
|
10 # |
|
11 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, |
|
12 # THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS |
|
13 # BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF |
|
14 # SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN |
|
15 # CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.# |
|
16 # |
|
17 # nonleavenew.py |
|
18 # |
|
19 # Checks : Use of new without (ELeave). |
|
20 # |
|
21 # Reason : Using new without (ELeave) is only used in special |
|
22 # circumstances. The leaving variant should typically be used in |
|
23 # preference. A common exception is for application creation, |
|
24 # where NULL is returned for failed creation. |
|
25 # |
|
26 # ################################################################# |
|
27 |
|
28 script = CScript("nonleavenew") |
|
29 script.iReString = r""" |
|
30 (=|\(|,) # equals, open bracket or comma |
|
31 \s* # optional whitespace |
|
32 new\s+ # "new" plus at least one whitespace char |
|
33 ([^\(\s] # a character other than a bracket |
|
34 .*) |
|
35 """ |
|
36 script.iFileExts = ["cpp"] |
|
37 script.iCategory = KCategoryCodeReviewGuides |
|
38 script.iIgnore = KIgnoreCommentsAndQuotes |
|
39 script.iSeverity = KSeverityLow |
|
40 |
|
41 currentfilename = "" |
|
42 iswindowsfile = 0 |
|
43 rewindows = re.compile("^\s*#include\s+<(windows|wchar).h>", re.IGNORECASE) |
|
44 |
|
45 def checkforwindowsinclude(lines, filename): |
|
46 global currentfilename |
|
47 global iswindowsfile |
|
48 global rewindows |
|
49 |
|
50 if (currentfilename <> filename): |
|
51 currentfilename = filename |
|
52 iswindowsfile = 0 |
|
53 for line in lines: |
|
54 m = rewindows.search(line) |
|
55 if m: |
|
56 iswindowsfile = 1 |
|
57 break |
|
58 |
|
59 return iswindowsfile |
|
60 |
|
61 def nonleavenewcompare(lines, currentline, rematch, filename): |
|
62 m = rematch.search(lines[currentline]) |
|
63 if m: |
|
64 if (m.group(2).find("Application") <> -1): |
|
65 return 0 |
|
66 else: |
|
67 return not checkforwindowsinclude(lines, filename) |
|
68 |
|
69 return 0 |
|
70 |
|
71 script.iCompare = nonleavenewcompare |
|
72 scanner.AddScript(script) |