Revision: 201025
authorDremov Kirill (Nokia-D-MSW/Tampere) <kirill.dremov@nokia.com>
Tue, 06 Jul 2010 14:04:37 +0300
changeset 24 fb066cc7cee3
parent 23 f90aa9fa4530
child 25 b3527b504290
child 34 d70405a27336
Revision: 201025 Kit: 2010127
nettools/conntest/data/ConnTest_reg.rss
nettools/conntest/probe/src/prt.cpp
nettools/conntest/src/ConnTestAppUi.cpp
nettools/conntest/src/ConnTestView.cpp
nettools/conntest/src/Utils.cpp
--- a/nettools/conntest/data/ConnTest_reg.rss	Wed Jun 23 18:00:23 2010 +0300
+++ b/nettools/conntest/data/ConnTest_reg.rss	Tue Jul 06 14:04:37 2010 +0300
@@ -1,5 +1,5 @@
 /*
-* Copyright (c) 2006 Nokia Corporation and/or its subsidiary(-ies). 
+* Copyright (c) 2010 Nokia Corporation and/or its subsidiary(-ies). 
 * All rights reserved.
 * This component and the accompanying materials are made available
 * under the terms of "Eclipse Public License v1.0"
@@ -16,7 +16,7 @@
 */
 
 #include <appinfo.rh>
-#include <ConnTest.rsg>
+#include <conntest.rsg>
 
 UID2 KUidAppRegistrationResourceFile
 UID3 0x101F6D2B // application UID
--- a/nettools/conntest/probe/src/prt.cpp	Wed Jun 23 18:00:23 2010 +0300
+++ b/nettools/conntest/probe/src/prt.cpp	Tue Jul 06 14:04:37 2010 +0300
@@ -307,18 +307,20 @@
 
 		const TInt KMicrosInASecond = 1000000;
 
-		//TUint32 micros = interval.Int64().Low();
-		TUint32 micros = I64LOW(interval.Int64());//.Low();  x.Low() -> I64LOW(x)
-		TUint32 secs = micros / KMicrosInASecond;
-		micros -= (secs * KMicrosInASecond);
+		// To avoid possible overflow caused by microsecond accuracy (32 bits
+		// of microseconds is just a bit over an hour), use 64-bit variables
+		// in calculation of timestamp
+		TInt64 secs = interval.Int64() / KMicrosInASecond;
 
 		//
 		// Reuse the protocol and flags fields of
 		// RMBufPktInfo to store the time-stamp
 		//
 		RMBufPktInfo* info = RMBufPacket::PeekInfoInChain(copy);
-		info->iProtocol = static_cast<TInt>(secs);
-		info->iFlags = static_cast<TUint>(micros);
+		// Just let the seconds overflow in case of timestamp is over the
+		// integer scope (nothing reasonable to do in this case anyway)
+		info->iProtocol = static_cast<TInt>( secs );
+		info->iFlags = static_cast<TUint>( interval.Int64() - ( secs * KMicrosInASecond ));
 
 		iQueue.Append(copy);
 		iDumpCb.CallBack();
--- a/nettools/conntest/src/ConnTestAppUi.cpp	Wed Jun 23 18:00:23 2010 +0300
+++ b/nettools/conntest/src/ConnTestAppUi.cpp	Tue Jul 06 14:04:37 2010 +0300
@@ -1,5 +1,5 @@
 /*
-* Copyright (c) 2006-2009 Nokia Corporation and/or its subsidiary(-ies). 
+ * Copyright (c) 2006-2010 Nokia Corporation and/or its subsidiary(-ies).
 * All rights reserved.
 * This component and the accompanying materials are made available
 * under the terms of "Eclipse Public License v1.0"
@@ -26,7 +26,7 @@
 
 #include "ConnTestAppUi.h"
 #include "ConnTestView.h"
-#include <ConnTest.rsg>
+#include <conntest.rsg>
 #include "conntest.hrh"
 #include "SettingData.h"
 #include "ipdumpengine.h"
--- a/nettools/conntest/src/ConnTestView.cpp	Wed Jun 23 18:00:23 2010 +0300
+++ b/nettools/conntest/src/ConnTestView.cpp	Tue Jul 06 14:04:37 2010 +0300
@@ -1,5 +1,5 @@
 /*
-* Copyright (c) 2006-2009 Nokia Corporation and/or its subsidiary(-ies). 
+ * Copyright (c) 2006-2010 Nokia Corporation and/or its subsidiary(-ies).
 * All rights reserved.
 * This component and the accompanying materials are made available
 * under the terms of "Eclipse Public License v1.0"
@@ -22,7 +22,7 @@
 #include <avkon.hrh>
 #include <AknGlobalNote.h>
 
-#include <ConnTest.rsg>
+#include <conntest.rsg>
 #include "ConnTestView.h"
 #include "ConnTestContainer.h"
 #include "CustomPrefsItemList.h"
--- a/nettools/conntest/src/Utils.cpp	Wed Jun 23 18:00:23 2010 +0300
+++ b/nettools/conntest/src/Utils.cpp	Tue Jul 06 14:04:37 2010 +0300
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2006-2009 Nokia Corporation and/or its subsidiary(-ies). 
+ * Copyright (c) 2006-2010 Nokia Corporation and/or its subsidiary(-ies). 
  * All rights reserved.
  * This component and the accompanying materials are made available
  * under the terms of "Eclipse Public License v1.0"
@@ -19,7 +19,7 @@
 // INCLUDE FILES
 #include <commdb.h>
 #include <aknlistquerydialog.h>
-#include <ConnTest.rsg>
+#include <conntest.rsg>
 
 #include <aknselectionlist.h>
 #include <aknPopup.h>