2010-05-24  Gavin Barraclough  <barraclough@apple.com>

        Rubber Stamped by Sam Weinig.

        Accidentally committed double write of codeblock in Interpreter.

        * interpreter/Interpreter.cpp:

        (JSC::Interpreter::privateExecute):

2010-05-24  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=39583

        Move creation of 'this' object from caller to callee in construction.

        Presently the caller of a constructor is responsible for providing a this

        object.  Instead, move the object creation into a new op_create_this opcode,

        planted in the head of the contructor bytecode for a function.  Since the

        prototype for the object is provided by performing a get_by_id on the callee,

        also add a new get_callee opcode (this is used to get the callee JSFunction

        into a register so that a normal get_by_id can be used).

        Currently the caller is also responsible for detecting when op_construct is

        performed on a JSFunction representing a host function, in which case an

        exception is thrown – and this check currently takes place when constructing

        the this object.  Instead, mirroring the recent changes for non-host functions,

        add a parallel code-path for native constructors to follow, with a thunk for

        invoking native constructors provided by JITStubs, and a constructor-specific

        NativeFunction on NativeExecutable.  Provide an implementation of a host

        constructor which will throw an exception.

        * bytecode/CodeBlock.cpp:

        (JSC::CodeBlock::dump):

        (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset):

        * bytecode/CodeBlock.h:

        * bytecode/Opcode.h:

        * bytecompiler/BytecodeGenerator.cpp:

        (JSC::BytecodeGenerator::BytecodeGenerator):

        (JSC::BytecodeGenerator::emitConstruct):

        * bytecompiler/BytecodeGenerator.h:

        (JSC::BytecodeGenerator::emitGetByIdExceptionInfo):

        * interpreter/Interpreter.cpp:

        (JSC::Interpreter::privateExecute):

        * jit/JIT.cpp:

        (JSC::JIT::privateCompileMainPass):

        * jit/JIT.h:

        * jit/JITCall.cpp:

        (JSC::JIT::compileOpCall):

        (JSC::JIT::compileOpCallSlowCase):

        * jit/JITCall32_64.cpp:

        (JSC::JIT::compileOpCall):

        (JSC::JIT::compileOpCallSlowCase):

        * jit/JITOpcodes.cpp:

        (JSC::JIT::privateCompileCTIMachineTrampolines):

        (JSC::JIT::privateCompileCTINativeCall):

        (JSC::JIT::emit_op_neq_null):

        (JSC::JIT::emit_op_convert_this):

        (JSC::JIT::emit_op_get_callee):

        (JSC::JIT::emit_op_create_this):

        * jit/JITOpcodes32_64.cpp:

        (JSC::JIT::privateCompileCTIMachineTrampolines):

        (JSC::JIT::privateCompileCTINativeCall):

        (JSC::JIT::emit_op_get_callee):

        (JSC::JIT::emit_op_create_this):

        * jit/JITStubs.cpp:

        (JSC::DEFINE_STUB_FUNCTION):

        (JSC::JITThunks::hostFunctionStub):

        * jit/JITStubs.h:

        (JSC::JITThunks::ctiNativeConstruct):

        (JSC::):

        * runtime/ExceptionHelpers.cpp:

        (JSC::createNotAnObjectError):

        * runtime/Executable.h:

        (JSC::NativeExecutable::create):

        (JSC::NativeExecutable::NativeExecutable):

        * runtime/JSFunction.cpp:

        (JSC::callHostFunctionAsConstructor):

        * runtime/JSFunction.h:

2010-05-23  Sam Weinig  <sam@webkit.org>

        Fix windows build.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

2010-05-23  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=39575

        Make JS DOMObject inherit from JSObjectWithGlobalObject instead of JSObject

        Expose the global object stored in JSObjectWithGlobalObject.

        * JavaScriptCore.exp:

        * JavaScriptCore.xcodeproj/project.pbxproj:

        * runtime/JSObjectWithGlobalObject.cpp:

        (JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):

        (JSC::JSObjectWithGlobalObject::globalObject):

        * runtime/JSObjectWithGlobalObject.h:

2010-05-21  Oliver Hunt  <oliver@apple.com>

        "asm volatile" isn't valid outside of functions.

        Reviewed by Gavin Barraclough.

        * jit/JITStubs.cpp:

2010-05-21  Gavin Barraclough  <barraclough@apple.com>

        Unreviewed build fix.

        Interpreter fix following r59974.

        * interpreter/Interpreter.cpp:

        (JSC::Interpreter::privateExecute):

        * runtime/JSPropertyNameIterator.cpp:

        (JSC::JSPropertyNameIterator::get):

        * runtime/JSPropertyNameIterator.h:

2010-05-21  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamped by Oliver Hunt.

        Interpreter fix following r59939.

        * interpreter/Interpreter.cpp:

        (JSC::Interpreter::privateExecute):

2010-05-21  David Levin  <levin@chromium.org>

        Unreviewed build fix.

        * wtf/SizeLimits.cpp: Removed a check while I figure out how to write it properly.

2010-05-21  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        Enforce size constraints on various data structures in JavaScriptCore/wtf.

        https://bugs.webkit.org/show_bug.cgi?id=39327

        I only modified the default build for OSX and Chromium's build file to include WTFCompileAsserts.cpp

        as those should be sufficient to catch regressions on the size of the data structures.

        * JavaScriptCore.gypi: Added the WTFCompileAsserts.cpp file.

        * JavaScriptCore.xcodeproj/project.pbxproj: Added the WTFCompileAsserts.cpp file.

        * runtime/UString.cpp: Added a compile assert for UString size.

        * wtf/SizeLimits.cpp: Added compile asserts for data structures that didn't have cpp files.

        * wtf/text/StringImpl.cpp: Added a compile assert for StringImpl size.

2010-05-21  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Bug 39509 - Exceptions raised when JSString::value() is called not always properly thrown.

        Missing some CHECK_FOR_EXCEPTION()s, cleanup NativeError construction (adding a property

        via the prototype was inefficient, and whilst trivially true that the property is is not

        a rope - and thus couldn't except - it would be hard to prove this).

        * interpreter/Interpreter.cpp:

        (JSC::Interpreter::callEval):

        (JSC::Interpreter::privateExecute):

        * jit/JITStubs.cpp:

        (JSC::DEFINE_STUB_FUNCTION):

        * runtime/InternalFunction.cpp:

        (JSC::InternalFunction::name):

        (JSC::InternalFunction::displayName):

        * runtime/JSFunction.cpp:

        (JSC::JSFunction::name):

        (JSC::JSFunction::displayName):

        * runtime/JSGlobalObject.cpp:

        (JSC::JSGlobalObject::reset):

        * runtime/JSPropertyNameIterator.cpp:

        * runtime/JSPropertyNameIterator.h:

        * runtime/JSString.h:

        (JSC::RopeBuilder::tryGetValue):

        (JSC::JSString::getIndex):

        * runtime/NativeErrorConstructor.cpp:

        (JSC::NativeErrorConstructor::NativeErrorConstructor):

        * runtime/NativeErrorConstructor.h:

        * runtime/NativeErrorPrototype.cpp:

        (JSC::NativeErrorPrototype::NativeErrorPrototype):

        * runtime/NativeErrorPrototype.h:

        * runtime/StringPrototype.cpp:

        (JSC::stringProtoFuncReplace):

2010-05-21  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by NOBODY (build fix).

        Fix interpreter build.

        * interpreter/Interpreter.cpp:

        (JSC::Interpreter::privateExecute):

2010-05-21  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Gavin Barraclough.

        Split out JITCall32_64.cpp, and tightened up some #ifdefs in the hopes

        of improving compile times.

        https://bugs.webkit.org/show_bug.cgi?id=39507

        * JavaScriptCore.xcodeproj/project.pbxproj:

        * jit/JIT.cpp:

        * jit/JITArithmetic.cpp:

        * jit/JITArithmetic32_64.cpp:

        * jit/JITCall.cpp:

        * jit/JITCall32_64.cpp: Copied from jit/JITCall.cpp.

        * jit/JITOpcodes.cpp:

        * jit/JITOpcodes32_64.cpp:

        * jit/JITPropertyAccess.cpp:

        * jit/JITPropertyAccess32_64.cpp:

        * jit/JITStubs.cpp:

2010-05-21  Csaba Osztrogonác  <ossy@webkit.org>

        Unreviewed buildfix for Qt after r59941.

        * JavaScriptCore.pro: missing runtime/JSObjectWithGlobalObject.cpp added to SOURCES.

2010-05-21  Oliver Hunt  <oliver@apple.com>

        Windows build fix #3

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

2010-05-21  Oliver Hunt  <oliver@apple.com>

        Windows build fix #2

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

2010-05-21  Oliver Hunt  <oliver@apple.com>

        Windows build fix #1

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

2010-05-21  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        All callable objects should have a global object reference

        https://bugs.webkit.org/show_bug.cgi?id=39495

        All objects that may ever return a value other CallTypeNone

        or ConstructTypeNone now get a global object in their constructor

        and store that in their first anonymous slot.  We add a new type

        JSObjectWithGlobalObject to allow us to share this logic as much

        as possible, however some objects have specific inheritance 

        requirements so we can't just use it universally.

        To enforce this requirement JSValue::getCallData and getConstructData

        make use of a new "isValidCallee" function to assert that any object

        that returns a value other than CallType/ConstructTypeNone has a

        global object in anonymous slot 0.

        In order to ensure that static function slots are converted into

        function objects with the correct global object, all prototype objects

        and other classes with static function slots also gain a global object

        reference.  Happily this fixes the long standing issue where host

        function objects get a prototype from the lexical global object of the

        first function that calls them, instead of the global object that they

        are defined on.

        * API/JSCallbackConstructor.cpp:

        (JSC::JSCallbackConstructor::JSCallbackConstructor):

        * API/JSCallbackConstructor.h:

        * API/JSCallbackFunction.cpp:

        (JSC::JSCallbackFunction::JSCallbackFunction):

        * API/JSCallbackFunction.h:

        * API/JSCallbackObject.cpp:

        (JSC::):

        * API/JSCallbackObject.h:

        * API/JSCallbackObjectFunctions.h:

        (JSC::::JSCallbackObject):

        (JSC::::staticFunctionGetter):

        * API/JSClassRef.cpp:

        (OpaqueJSClass::prototype):

        * API/JSContextRef.cpp:

        * API/JSObjectRef.cpp:

        (JSObjectMake):

        (JSObjectMakeFunctionWithCallback):

        (JSObjectMakeConstructor):

        (JSObjectGetPrivate):

        (JSObjectSetPrivate):

        (JSObjectGetPrivateProperty):

        (JSObjectSetPrivateProperty):

        (JSObjectDeletePrivateProperty):

        * API/JSValueRef.cpp:

        (JSValueIsObjectOfClass):

        * API/JSWeakObjectMapRefPrivate.cpp:

        * CMakeLists.txt:

        * GNUmakefile.am:

        * JavaScriptCore.exp:

        * JavaScriptCore.gypi:

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

        * JavaScriptCore.xcodeproj/project.pbxproj:

        * interpreter/Interpreter.cpp:

        (JSC::Interpreter::privateExecute):

        * jit/JITStubs.cpp:

        (JSC::DEFINE_STUB_FUNCTION):

        * jsc.cpp:

        (GlobalObject::GlobalObject):

        * runtime/ArrayConstructor.cpp:

        (JSC::ArrayConstructor::ArrayConstructor):

        * runtime/ArrayConstructor.h:

        * runtime/ArrayPrototype.cpp:

        (JSC::ArrayPrototype::ArrayPrototype):

        * runtime/ArrayPrototype.h:

        (JSC::ArrayPrototype::createStructure):

        * runtime/BooleanConstructor.cpp:

        (JSC::BooleanConstructor::BooleanConstructor):

        * runtime/BooleanConstructor.h:

        * runtime/BooleanPrototype.cpp:

        (JSC::BooleanPrototype::BooleanPrototype):

        * runtime/BooleanPrototype.h:

        * runtime/DateConstructor.cpp:

        (JSC::DateConstructor::DateConstructor):

        * runtime/DateConstructor.h:

        * runtime/DatePrototype.cpp:

        (JSC::DatePrototype::DatePrototype):

        * runtime/DatePrototype.h:

        * runtime/ErrorConstructor.cpp:

        (JSC::ErrorConstructor::ErrorConstructor):

        * runtime/ErrorConstructor.h:

        * runtime/ErrorPrototype.cpp:

        (JSC::ErrorPrototype::ErrorPrototype):

        * runtime/ErrorPrototype.h:

        * runtime/FunctionConstructor.cpp:

        (JSC::FunctionConstructor::FunctionConstructor):

        * runtime/FunctionConstructor.h:

        * runtime/FunctionPrototype.cpp:

        (JSC::FunctionPrototype::FunctionPrototype):

        (JSC::FunctionPrototype::addFunctionProperties):

        * runtime/FunctionPrototype.h:

        * runtime/GlobalEvalFunction.cpp:

        (JSC::GlobalEvalFunction::GlobalEvalFunction):

        * runtime/GlobalEvalFunction.h:

        * runtime/InternalFunction.cpp:

        (JSC::InternalFunction::InternalFunction):

        * runtime/InternalFunction.h:

        * runtime/JSCell.h:

        (JSC::JSValue::getCallData):

        (JSC::JSValue::getConstructData):

        * runtime/JSFunction.cpp:

        (JSC::JSFunction::JSFunction):

        * runtime/JSFunction.h:

        * runtime/JSGlobalObject.cpp:

        (JSC::JSGlobalObject::reset):

        * runtime/JSGlobalObject.h:

        (JSC::JSGlobalObject::JSGlobalObject):

        * runtime/JSONObject.cpp:

        (JSC::JSONObject::JSONObject):

        * runtime/JSONObject.h:

        * runtime/JSObject.h:

        * runtime/JSObjectWithGlobalObject.cpp: Added.

        (JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):

        * runtime/JSObjectWithGlobalObject.h: Added.

        (JSC::JSObjectWithGlobalObject::createStructure):

        (JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):

        * runtime/JSValue.cpp:

        (JSC::JSValue::isValidCallee):

        * runtime/JSValue.h:

        * runtime/Lookup.cpp:

        (JSC::setUpStaticFunctionSlot):

        * runtime/MathObject.cpp:

        (JSC::MathObject::MathObject):

        * runtime/MathObject.h:

        * runtime/NativeErrorConstructor.cpp:

        (JSC::NativeErrorConstructor::NativeErrorConstructor):

        * runtime/NativeErrorConstructor.h:

        * runtime/NativeErrorPrototype.cpp:

        (JSC::NativeErrorPrototype::NativeErrorPrototype):

        * runtime/NativeErrorPrototype.h:

        * runtime/NumberConstructor.cpp:

        (JSC::NumberConstructor::NumberConstructor):

        * runtime/NumberConstructor.h:

        * runtime/NumberPrototype.cpp:

        (JSC::NumberPrototype::NumberPrototype):

        * runtime/NumberPrototype.h:

        * runtime/ObjectConstructor.cpp:

        (JSC::ObjectConstructor::ObjectConstructor):

        * runtime/ObjectConstructor.h:

        * runtime/ObjectPrototype.cpp:

        (JSC::ObjectPrototype::ObjectPrototype):

        * runtime/ObjectPrototype.h:

        * runtime/PrototypeFunction.cpp:

        (JSC::PrototypeFunction::PrototypeFunction):

        * runtime/PrototypeFunction.h:

        * runtime/RegExpConstructor.cpp:

        (JSC::RegExpConstructor::RegExpConstructor):

        (JSC::constructRegExp):

        * runtime/RegExpConstructor.h:

        * runtime/RegExpObject.cpp:

        (JSC::RegExpObject::RegExpObject):

        * runtime/RegExpObject.h:

        * runtime/RegExpPrototype.cpp:

        (JSC::RegExpPrototype::RegExpPrototype):

        * runtime/RegExpPrototype.h:

        * runtime/StringConstructor.cpp:

        (JSC::StringConstructor::StringConstructor):

        * runtime/StringConstructor.h:

        * runtime/StringPrototype.cpp:

        (JSC::StringPrototype::StringPrototype):

        * runtime/StringPrototype.h:

2010-05-21  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed the unused entry in the CallFrame

        https://bugs.webkit.org/show_bug.cgi?id=39470

        Removed the unused entry in the CallFrame, and reordered CallFrame

        writes on the hot path to be in forwards order.

        SunSpider says 0.3% faster.

        * interpreter/RegisterFile.h:

        (JSC::RegisterFile::):

        * jit/JITCall.cpp:

        (JSC::JIT::compileOpCall):

2010-05-21  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Split the QScriptValue autotest into smaller chunks.

        File tst_qscriptvalue_generated.cpp was huge and it was difficult to compile

        it with MSVS2008, because of the code optimization.

        Tests were splited into a few files for better use of distributed

        compilation.

        Repeated calls to insert() and operator<<() where replaced by loops,

        that should reduce time of code optimizing.

        New files were generated by the same application, test logic wasn't changed.

        [Qt] The QScriptValue autotest should be refactored.

        https://bugs.webkit.org/show_bug.cgi?id=38987

        * qt/tests/qscriptvalue/qscriptvalue.pro:

        * qt/tests/qscriptvalue/tst_qscriptvalue.h:

        * qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: Removed.

        * qt/tests/qscriptvalue/tst_qscriptvalue_generated_init.cpp: Added.

        (tst_QScriptValue::initScriptValues):

        * qt/tests/qscriptvalue/tst_qscriptvalue_generated_istype.cpp: Added.

        (tst_QScriptValue::isValid_initData):

        (tst_QScriptValue::isValid_makeData):

        (tst_QScriptValue::isValid_test):

        (tst_QScriptValue::isBool_initData):

        (tst_QScriptValue::isBool_makeData):

        (tst_QScriptValue::isBool_test):

        (tst_QScriptValue::isBoolean_initData):

        (tst_QScriptValue::isBoolean_makeData):

        (tst_QScriptValue::isBoolean_test):

        (tst_QScriptValue::isNumber_initData):

        (tst_QScriptValue::isNumber_makeData):

        (tst_QScriptValue::isNumber_test):

        (tst_QScriptValue::isFunction_initData):

        (tst_QScriptValue::isFunction_makeData):

        (tst_QScriptValue::isFunction_test):

        (tst_QScriptValue::isNull_initData):

        (tst_QScriptValue::isNull_makeData):

        (tst_QScriptValue::isNull_test):

        (tst_QScriptValue::isString_initData):

        (tst_QScriptValue::isString_makeData):

        (tst_QScriptValue::isString_test):

        (tst_QScriptValue::isUndefined_initData):

        (tst_QScriptValue::isUndefined_makeData):

        (tst_QScriptValue::isUndefined_test):

        (tst_QScriptValue::isObject_initData):

        (tst_QScriptValue::isObject_makeData):

        (tst_QScriptValue::isObject_test):

        * qt/tests/qscriptvalue/tst_qscriptvalue_generated_totype.cpp: Added.

        (tst_QScriptValue::toString_initData):

        (tst_QScriptValue::toString_makeData):

        (tst_QScriptValue::toString_test):

        (tst_QScriptValue::toNumber_initData):

        (tst_QScriptValue::toNumber_makeData):

        (tst_QScriptValue::toNumber_test):

        (tst_QScriptValue::toBool_initData):

        (tst_QScriptValue::toBool_makeData):

        (tst_QScriptValue::toBool_test):

        (tst_QScriptValue::toBoolean_initData):

        (tst_QScriptValue::toBoolean_makeData):

        (tst_QScriptValue::toBoolean_test):

        (tst_QScriptValue::toInteger_initData):

        (tst_QScriptValue::toInteger_makeData):

        (tst_QScriptValue::toInteger_test):

        (tst_QScriptValue::toInt32_initData):

        (tst_QScriptValue::toInt32_makeData):

        (tst_QScriptValue::toInt32_test):

        (tst_QScriptValue::toUInt32_initData):

        (tst_QScriptValue::toUInt32_makeData):

        (tst_QScriptValue::toUInt32_test):

        (tst_QScriptValue::toUInt16_initData):

        (tst_QScriptValue::toUInt16_makeData):

        (tst_QScriptValue::toUInt16_test):

2010-05-21  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        Add COMPILER(MSVC) guard for strnstr

        https://bugs.webkit.org/show_bug.cgi?id=39397

        BREWMP uses MSVC for simulator build, but it is not OS(WINDOWS).

        Add COMPILER(MSVC) guard for strnstr.

        * wtf/StringExtras.h:

2010-05-21  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Add !PLATFORM(BREWMP) guard for isMainThread

        https://bugs.webkit.org/show_bug.cgi?id=39396

        BREWMP sets ENABLE(SINGLE_THREADED), so it uses isMainThread from ThreadingNone.cpp.

        Exclude isMainThread in MainThread.cpp.

        * wtf/MainThread.cpp: