2007-10-16  Adam Roben  <aroben@apple.com>

        Remove WebKitInitializer

        Reviewed by Sam.

        * WebKit.vcproj/WebKit.sln:

2007-10-16  Adam Roben  <aroben@apple.com>

        Add FindSafari

        Reviewed by Darin.

        * WebKit.vcproj/WebKit.sln:

2007-10-16  Adam Roben  <aroben@apple.com>

        Rename WebKit_debug.dll to WebKit.dll for the Debug configuration

        This is needed so that we can stop having Safari delay-load WebKit,

        which in turn is needed so that Maciej can land a JavaScript speedup

        which breaks delay-loading.

        Reviewed by Kevin McCullough.

        * WebKit.vcproj/WebKit.vcproj: Use WebKitDLLConfigSuffix for the name

        of our DLL and module definition file.

        * WebKit.vcproj/debug.vsprops: Added WebKitDLLConfigSuffix.

        * WebKit.vcproj/debug_internal.vsprops: Ditto.

        * WebKit.vcproj/release.vsprops: Ditto.

2007-10-15  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Ollie.

        <rdar://5530789>: REGRESSION(303-310A19): Crash opening .wma files with

        MediaPlayer for the first time

        Failure to setup the stream in PluginView::didReceiveResponse will lead,

        in a full-page plugin, to the main document load being cancelled. This

        is the case with at least two versions of Windows Media Player, which

        cancels the stream and brings up its own "Welcome to Windows Media

        Player" dialog.

        As part of the main document load cancellation, m_pluginView is set to

        null, and the crash came from dereferencing this pointer. This patch

        adds a null check.

        * WebFrame.cpp:

        (WebFrame::finishedLoading): Fix some typos

        (WebFrame::committedLoad): Added a null check

2007-10-12  Steve Falkenburg  <sfalken@apple.com>

        Move pthreads up in the linker order and don't mark it for delay load.

        Fixes crash during regsvr32 of WebKit (currently repro if you do a spade ti).

        Reviewed by Darin, Ada.

        * WebKit.vcproj/WebKit.vcproj:

2007-10-11  Steve Falkenburg  <sfalken@apple.com>

        Delay load additional libraries to improve startup time.

        Reviewed by Darin, Ada.

        * WebKit.vcproj/WebKit.vcproj:

2007-10-11  Ada Chan  <adachan@apple.com>

        <rdar://problem/5534421>

        Switched to using wkGetDefaultHTTPCookieStorage() to avoid recreating CFHTTPCookieStorageRef.

        Removed usage of ResourceHandle::cookieStorage().

        Reviewed by Oliver.

        * WebView.cpp:

        (WebView::updateWebCoreSettingsFromPreferences):

        (WebView::initWithFrame):

2007-10-10  Alice Liu  <alice.liu@apple.com>

        Reviewed by Geoff Garen.

        Fixed <rdar://5464402> Crash when running fast/frames/onload-remove-iframe-crash.html in DRT

        * WebFrame.cpp:

        (WebFrame::createFrame):

        The crash was caused by the early destruction of the subframe.  To resolve this issue, 

        the manual deref of the child frame that occurs in between being appended to the 

        frametree and being used in loadURLIntoChild wasn't exactly incorrect, but just needed 

        to be moved until after loadURLIntoChild. This hasn't been a problem for other uses of 

        child frames because this test case involves removing a child frame immediately after 

        loading it, all in an onload handler.  Even better than just moving the deref would be 

        to change the signature of createFrame to use a RefPtr<Frame> so that a manual deref isn't 

        necessary. This is what was done in this patch. 

        * WebFrame.h:

        createFrame() now returns a RefPtr instead of a raw Frame pointer. 

        Making this change improves the way we handle frames on Windows WebKit. 

2007-10-05  Ada Chan  <adachan@apple.com>

        <rdar://problem/5436617>

        Implement WebIconDatabase::delayDatabaseCleanup() and WebIconDatabase::allowDatabaseCleanup().

        Reviewed by Brady.

        * WebIconDatabase.cpp:

        (WebIconDatabase::delayDatabaseCleanup):

        (WebIconDatabase::allowDatabaseCleanup):

2007-10-04  Adele Peterson  <adele@apple.com>

        * Interfaces/IWebViewPrivate.idl: Moving setInitialFocus down to the end to avoid breaking the OpenSource build.

2007-10-04  Adele Peterson  <adele@apple.com>

        Reviewed by Darin.

        WebKit/win part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content

        * WebView.cpp: Added setInitialFocus so the application can specify that its handing off focus to WebKit

          and so that it can specify the focus direction.

        * WebView.h: ditto.

        * Interfaces/IWebViewPrivate.idl: ditto.

2007-10-03  Ada Chan  <adachan@apple.com>

        <rdar://problem/5521230> Implement IWebIconDatabase::iconURLForURL in WebKit for windows

        Reviewed by Steve and Brady.

        * Interfaces/IWebIconDatabase.idl:

        * WebIconDatabase.cpp:

        (WebIconDatabase::iconURLForURL):

        * WebIconDatabase.h:

2007-10-02  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Adam Roben.

        * Interfaces/IWebPreferences.idl: Remove unnecessary comments. 

2007-10-02  Darin Adler  <darin@apple.com>

        Reviewed by Adam.

        - started using the new OwnPtr everywhere we do DeleteObject

        * WebNodeHighlight.cpp:

        (WebNodeHighlight::updateWindow):

        * WebView.cpp:

        (WebView::WebView):

        (WebView::deleteBackingStore):

        (WebView::ensureBackingStore):

        (WebView::addToDirtyRegion):

        (WebView::scrollBackingStore):

        (WebView::updateBackingStore):

        (WebView::paint):

        (WebView::paintIntoBackingStore):

        (WebView::paintIntoWindow):

        * WebView.h:

2007-10-02  Adam Roben  <aroben@apple.com>

        Fix <rdar://5505062> WebKit's version-independent ProgIDs contain version numbers

        I also added a few registry keys for our version-independent ProgIDs

        that we were missing.

        Reviewed by Steve.

        * ProgIDMacros.h: Added new macros to get version-independent ProgIDs.

        * WebKitDLL.cpp: Use the version-independent ProgIDs in the right

        places, and added some new keys for version-independent ProgIDs.

2007-10-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Fix a bug discovered by app verifier where we would treat an LPCTSTR as a BSTR causing a crash.

        Also rename some protection space constants and change their values to match the mac version.

        * Interfaces/IWebURLAuthenticationChallenge.idl:

        * WebURLProtectionSpace.cpp:

        (WebURLProtectionSpace::initWithHost):

        (WebURLProtectionSpace::initWithProxyHost):

        (WebURLProtectionSpace::protocol):

        (WebURLProtectionSpace::proxyType):

2007-09-29  Adam Roben  <aroben@apple.com>

        Clean-up in preparation for <rdar://5505062> WebKit's version-independent ProgIDs contain version numbers

        Reviewed by Steve.

        * ProgIDMacros.h: Stringify the passed in class name.

        * WebKitDLL.cpp: Added a FOR_EACH_CLASS macro to ensure that our class

        lists stay in the right order, and updated uses of the *_PROGID macros

        for to take the stringification into account.

2007-09-27  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Darin.

        - <rdar://5261371> Nothing downloaded when exporting bookmarks from iGoogle web history

        - Implemented IWebHTTPURLResponse::allHeaderFields so that if the content disposition is "attachment" we will download the file instead of display it.  Also implemented some missing functionality.

        * HTTPHeaderPropertyBag.cpp: Added.

        (HTTPHeaderPropertyBag::HTTPHeaderPropertyBag):

        (HTTPHeaderPropertyBag::createInstance):

        (HTTPHeaderPropertyBag::setResponse):

        (HTTPHeaderPropertyBag::response):

        (HTTPHeaderPropertyBag::QueryInterface):

        (HTTPHeaderPropertyBag::AddRef):

        (HTTPHeaderPropertyBag::Release):

        (ConvertFromLPCOLESTR):

        (ConvertToVariant):

        (ConvertFromVariant):

        (HTTPHeaderPropertyBag::Read):

        (HTTPHeaderPropertyBag::Write):

        * HTTPHeaderPropertyBag.h: Added.

        * Interfaces/IWebHTTPURLResponse.idl:

        * WebKit.vcproj/WebKit.vcproj:

        * WebURLResponse.cpp:

        (WebURLResponse::allHeaderFields):

        (WebURLResponse::isAttachment):

        * WebURLResponse.h:

2007-09-27  Ada Chan  <adachan@apple.com>

        <rdar://problem/5507481> Added a delegate method to inform the client

        app that WebView has painted.

        Reviewed by Steve.

        * Interfaces/IWebUIDelegatePrivate.idl:

        * WebView.cpp:

        (WebView::updateBackingStore):

2007-09-25  Adam Roben  <aroben@apple.com>

        Add WebKitInitializer to WebKit.sln

        Reviewed by Sam.

        * WebKit.vcproj/WebKit.sln: DumpRenderTree and testkjs now depend on

        WebKitInitializer.

2007-09-25  Darin Adler  <darin@apple.com>

        Reviewed by Steve.

        - fix <rdar://problem/5095701> Download requring HTTP auth fails

          (progress bar forever)

        The functions in WebDownload relating to authentication challenges needed

        to be implemented.

        * WebDownload.cpp:

        (WebDownload::cancelAuthenticationChallenge): Implement.

        (WebDownload::continueWithoutCredentialForAuthenticationChallenge): Ditto.

        (WebDownload::useCredential): Ditto.

        (WebDownload::willSendRequest): Fix storage leak by adopting request

        and response after creating them. Also retain the result before returning

        it, since that's the API contract with CFNetwork.

        (WebDownload::didReceiveAuthenticationChallenge): Implement.

        (WebDownload::didReceiveResponse): Fix storage leak by adopting response.

        (WebDownload::willResumeWithResponse): Ditto.

        (WebDownload::didFail): Ditto.

        * WebURLAuthenticationChallenge.h: Get rid of the IID #define,

        instead using __declspec(uuid). Added a sender parameter to the

        create function and an m_sender data member.

        * WebURLAuthenticationChallenge.cpp:

        (WebURLAuthenticationChallenge::WebURLAuthenticationChallenge): Added an

        explicit sender parameter so this can be used with a WebDownload, which

        does not involve a ResourceHandle. Later we should clean this up and not

        involve WebCore or ResourceHandle directly even for the non-download case.

        (WebURLAuthenticationChallenge::createInstance): Added an overload for the

        case with an explicit sender parameter.

        (WebURLAuthenticationChallenge::QueryInterface): Use __uuidof for the ID

        of this class. In general, we should move to __uuidof as much as possible

        and keep the separate macros to a minimum -- but we should do this for all

        uses of each class at one time to make sure we don't run into problems

        with two different UUIDs for the same class. This patch does it for three

        classes.

        (WebURLAuthenticationChallenge::initWithProtectionSpace): Use the query

        constructor instead of an explicit QueryInterface for WebURLCredential.

        This is another class where I'm switching from CLSID/IID macros to the

        use of __uuidof, but in this case the use of __uuidof is implicit.

        (WebURLAuthenticationChallenge::initWithAuthenticationChallenge): Ditto,

        but for WebURLAuthenticationChallenge and WebURLAuthenticationChallengeSender.

        (WebURLAuthenticationChallenge::sender): Use the new m_sender member to

        cache the sender object and also use the one that was passed into the

        constructor, if any.

        * WebURLAuthenticationChallengeSender.h: Get rid of the IID #define,

        instead using __declspec(uuid). Also minimize includes and make data

        members private instead of protected.

        * WebURLAuthenticationChallengeSender.cpp:

        (WebURLAuthenticationChallengeSender::QueryInterface): Use __uuidof instead

        of IID macro.

        (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge):

        Use query constructor instead of QueryInterface.

        (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge):

        Ditto.

        (WebURLAuthenticationChallengeSender::useCredential): Ditto.

        * WebURLCredential.cpp: (WebURLCredential::QueryInterface): Use __uuidof

        instead of CLSID_WebURLCredential.

        - tangentially-related cleanup

        * WebFrame.cpp:

        (WebFrame::dispatchDidReceiveAuthenticationChallenge): Use the adopt

        constructor instead of a separate adoptRef call.

        (WebFrame::dispatchDidCancelAuthenticationChallenge): Ditto.

2007-09-24  Brady Eidson  <beidson@apple.com>

        Reviewed by John Sullivan

        Fix for <rdar://5493371> - Crash in Icon Database on Windows

        * WebIconDatabase.cpp:

        (WebIconDatabase::iconForURL): If the URL is NULL, fallback to the default icon without asking WebCore

2007-09-24  Adam Roben  <aroben@apple.com>

        Fix <rdar://5499507> FrameView will always have size (0,0) if its parent WebView is never resized

        Reviewed by Darin.

        * WebView.cpp:

        (WebView::initWithFrame): Set the main FrameView's size to the size of

        the WebView.

2007-09-21  Kevin McCullough  <kmccullough@apple.com>

        - Fixed a syntax guideline mistake.

        * WebChromeClient.cpp:

        (WebChromeClient::scrollbarsVisible):

2007-09-20  Oliver Hunt  <oliver@apple.com>

        Reviewed by Steve.

        <rdar://problem/5487153> Korean characters are displayed as garbage with default encoding in some Korean web sites

        Adding support for per-localisation default character encodings on

        windows.

        * English.lproj/Localizable.strings:

        * WebPreferences.cpp:

        (WebPreferences::initializeDefaultSettings):

2007-09-20  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Oliver.

        - Added the ability to ask if scrollbars are visible

        - <rdar://problem/5496211> scrollbarsVisible in WebChromeClient is not implemented

        * WebChromeClient.cpp:

        (WebChromeClient::scrollbarsVisible):

2007-09-20  Ada Chan  <adachan@apple.com>

        <rdar://problem/5477240> Regression: Footer is too high in print preview

        Reviewed by Steve.

        * WebFrame.cpp:

        (WebFrame::WebFrame): initialize new data member m_pageHeight, which is the height of the page adjusted for margins.

        (WebFrame::computePageRects): get the height of the page adjusted for margins by passing m_pageHeight to

        computePageRectsForFrame().

        (WebFrame::spoolPages): footer rect's top is the max of the bottom of the page content and the bottom of the page

        minus footer height.

        * WebFrame.h:

2007-09-19  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Hyatt.

        - <rdar://problem/5101991> Avril Lavigne music player comes up in a window with scrollbars

        - Implementing missing scrollbar functionality to allow turning off scrollbars correctly.

        * Interfaces/IWebFrame.idl:

        * Interfaces/IWebFrameView.idl:

        * WebChromeClient.cpp:

        (WebChromeClient::setScrollbarsVisible):

        * WebFrame.cpp:

        (WebFrame::setAllowsScrolling):

        (WebFrame::allowsScrolling):

        (WebFrame::frameView):

        * WebFrame.h:

2007-09-20  Brady Eidson  <beidson@apple.com>

        Reviewed by Dave Hyatt

        <rdar://problem/5245981> - No favicon shows up for cnet.com

        * WebIconDatabase.cpp:

        (WebIconDatabase::iconForURL): Call getHBITMAPOfSize

        (WebIconDatabase::getOrCreateDefaultIconBitmap): Ditto

2007-09-19  Sam Weinig  <sam@webkit.org>

        Rubber stamped by Adam Roben.

        * WebKit.vcproj/WebKit.sln: Update location of DumpRenderTree and TestNetscapePlugin

        to point to their new locations.

2007-09-18  Brady Eidson  <beidson@apple.com>

        Reviewed by Adam

        Final part of <rdar://problem/5471308> - Hook up async icon database on Windows        

        * CFDictionaryPropertyBag.cpp:

        (CFDictionaryPropertyBag::CFDictionaryPropertyBag): Took the opportunity to rewrite with a RetainPtr

          since it became available after the initial implementation

        (CFDictionaryPropertyBag::setDictionary):

        (CFDictionaryPropertyBag::dictionary): Added accessor to the CFDictionaryRef to ease use within WebKit

        (CFDictionaryPropertyBag::QueryInterface): Added IID_CFDictionaryPropertyBag accessor

        (CFDictionaryPropertyBag::Read):

        (CFDictionaryPropertyBag::Write):

        * CFDictionaryPropertyBag.h: Added IID_CFDictionaryPropertyBag

        * WebFrame.cpp:

        (WebFrame::url): Added accessor, gets the current URL from WebCore

        (WebFrame::dispatchDidReceiveIcon): Calls through to the WebView

        (WebFrame::registerForIconNotification): Ditto

        * WebFrame.h:        

        * WebIconDatabase.cpp:

        (WebIconDatabase::iconDatabaseDidAddIconNotification):

        (WebIconDatabase::iconDatabaseNotificationUserInfoURLKey):

        (WebIconDatabase::iconDatabaseDidRemoveAllIconsNotification):

        (postDidRemoveAllIconsNotification):

        (postDidAddIconNotification):

        * WebIconDatabase.h:        

        * WebView.cpp:

        (WebView::close): Unregister for the notification, just in case

        (WebView::notifyDidAddIcon): Called when the webview gets the didAddIcon notification, compares the url

          in the notification to the current main frame URL.  If they match, calls to dispatchDidReceiveIconFromWebFrame

        (WebView::registerForIconNotification): 

        (WebView::dispatchDidReceiveIconFromWebFrame): Dispatches the FrameLoadDelegate call.  Once the delegate call is dispatched,

          either via the FrameLoaderClient interface of by listening for a notification, we know that our info is up to date in the 

          IconDatabase and we don't need to listen for the generic notification any long, so we unregister for it here, as well.

        (WebView::onNotify): The WebView listens for two notifications now, so make the decision which was received

        * WebView.h:

2007-09-18  Brady Eidson  <beidson@apple.com>

        Reviewed by Ada and Geoff

        Part of <rdar://problem/5471308> - Get async Icon Database fully hooked up on Windows

        Hook up main thread delivery of Icon Database notifications from the secondary thread

        * WebIconDatabase.cpp:

        (WebIconDatabase::WebIconDatabase): Initialize m_deliveryRequested

        (WebIconDatabase::init): Set the IconDatabaseClient to the shared WebIconDatabase

        (WebIconDatabase::dispatchDidRemoveAllIcons): Queue the notification to be delivered on the main thread then

          ask for the delivery

        (WebIconDatabase::dispatchDidAddIconForPageURL): Ditto

        (WebIconDatabase::scheduleNotificationDelivery): If the m_deliveryRequested hasn't been set, then set it

          and perform the callOnMainThread() for WebIconDatabase::deliverNotifications

        (postDidRemoveAllIconsNotification):

        (postDidAddIconNotification):

        (WebIconDatabase::deliverNotifications): Deliver all notifications in the current queue

        * WebIconDatabase.h:

2007-09-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Fixed a hang due to an infinite script running in the window's unload 

        event handler, which may be the cause of <rdar://problem/5479443> 

        REGRESSION: Hang due to infinite JS recursion on close @ engadget.com 

        (onunload-based ad)

        Added a bunch of WebKitMac's close features, and reordered others to

        match WebKitMac.

        * WebView.cpp:

        (WebView::close):

        (WebView::removeDragCaret):

2007-09-17  Adam Roben  <aroben@apple.com>

        Fix <rdar://4979801> overflow divs don't respond to keyboard scrolling (affects RSS pages)

        Reviewed by Hyatt.

        * WebView.cpp:

        (WebView::keyDown): Attempt to scroll an overflow area before

        scrolling the whole frame.

2007-09-17  Brady Eidson  <beidson@apple.com>

        Reviewed by Adam

        <rdar://problem/5471308> - Get async Icon Database fully hooked up on Windows

        Add a global "shut down WebKit" procedure to do cleanup at the engine level on quit. 

        Critical now for the IconDatabase and might be for other things in the future.

        * WebKitDLL.cpp:

        (shutDownWebKit): For now, just close the IconDatabase

        (DllMain): On DLL_PROCESS_DETACH, call shutDownWebKit

2007-09-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        <rdar://problem/5421997>

        http://bugs.webkit.org/show_bug.cgi?id=14247

        Display problem with Flash - image does not stop changing